ui/dbus-display1.[ch] are not properly listed in dependencies

2024-02-03 Thread Michael Tokarev
Doing a build of just a single target with --enable modules results in build error: rm -rf b; cd b ../configure --enable-modules --target-list=x86_64-softmmu ninja qemu-system-x86_64 In file included from ../ui/dbus-chardev.c:34: ../ui/dbus.h:34:10: fatal error: ui/dbus-display1.h: No

Re: [PATCH 3/3] monitor: only run coroutine commands in qemu_aio_context

2024-02-03 Thread Michael Tokarev
03.02.2024 12:01, Michael Tokarev wrote: ... This change broke something in 7.2. I'm still debugging it, will come with a follow-up once some more details are found, I'll also check current master with and without this commit. The prob happens with multiple suspend-resume cycles

Re: [PATCH 3/3] monitor: only run coroutine commands in qemu_aio_context

2024-02-03 Thread Michael Tokarev
16.01.2024 22:00, Stefan Hajnoczi пишет: monitor_qmp_dispatcher_co() runs in the iohandler AioContext that is not polled during nested event loops. The coroutine currently reschedules itself in the main loop's qemu_aio_context AioContext, which is polled during nested event loops. One known

Re: building qemu on a system with libxkbcommon installed but not xkeyboard-config produces an core dump

2024-02-01 Thread Michael Tokarev
01.02.2024 15:57, Peter Maydell пишет: On Thu, 1 Feb 2024 at 12:50, Michael Tokarev wrote: 01.02.2024 15:11, Michael Tokarev wrote: 31.01.2024 11:13, Zhang Wen: With this patch, qemu requires keyboard-config when libxkbcommon is found on the system. So if the qemu is configured when

Re: building qemu on a system with libxkbcommon installed but not xkeyboard-config produces an core dump

2024-02-01 Thread Michael Tokarev
01.02.2024 15:11, Michael Tokarev wrote: 31.01.2024 11:13, Zhang Wen: With this patch, qemu requires keyboard-config when libxkbcommon is found on the system. So if the qemu is configured when libxkbcommon is installed but not keyboard-config, the configure stage will produce an error message

Re: building qemu on a system with libxkbcommon installed but not xkeyboard-config produces an core dump

2024-02-01 Thread Michael Tokarev
31.01.2024 11:13, Zhang Wen: With this patch, qemu requires keyboard-config when libxkbcommon is found on the system. So if the qemu is configured when libxkbcommon is installed but not keyboard-config, the configure stage will produce an error message, thus avoid coredump in the build stage.

Re: [PATCH] pflash: fix sectors vs bytes confusion in blk_pread_nonzeroes()

2024-02-01 Thread Michael Tokarev
30.01.2024 03:27, Stefan Hajnoczi wrote: The following expression is incorrect because blk_pread_nonzeroes() deals in units of bytes, not sectors: bytes = MIN(size - offset, BDRV_REQUEST_MAX_SECTORS) ^^^ BDRV_REQUEST_MAX_BYTES is the

Re: [PATCH v2] block/blkio: Make s->mem_region_alignment be 64 bits

2024-02-01 Thread Michael Tokarev
30.01.2024 15:20, Richard W.M. Jones : With GCC 14 the code failed to compile on i686 (and was wrong for any version of GCC): ../block/blkio.c: In function ‘blkio_file_open’: ../block/blkio.c:857:28: error: passing argument 3 of ‘blkio_get_uint64’ from incompatible pointer type

[PULL 06/21] scripts/clean-includes: Update exclude list

2024-01-31 Thread Michael Tokarev
From: Peter Maydell Update the exclude list to exclude some more files which don't follow our standard #include policy. Signed-off-by: Peter Maydell Signed-off-by: Michael Tokarev --- scripts/clean-includes | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/clean

[PULL 19/21] hw/arm: Add `\n` to hint message

2024-01-31 Thread Michael Tokarev
From: Greg Kurz error_printf() doesn't add newlines. Signed-off-by: Greg Kurz Reviewed-by: Ani Sinha Signed-off-by: Michael Tokarev --- hw/arm/virt-acpi-build.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c index

[PULL 21/21] hw/hyperv: Include missing headers

2024-01-31 Thread Michael Tokarev
’ undeclared (first use in this function) 885 | return HV_SYNDBG_STATUS_INVALID; |^~~~ Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Manos Pitsidianakis Signed-off-by: Michael Tokarev --- hw/hyperv/hyperv.c | 4

[PULL 13/21] cxl: Clean up includes

2024-01-31 Thread Michael Tokarev
such inclusions. * Likewise, including headers qemu/osdep.h includes is redundant. Drop these, too. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Zhao Liu Acked-by: Jonathan Cameron Signed-off-by: Michael Tokarev --- hw/cxl/cxl-events.c | 4 +--- 1 file changed, 1

[PULL 16/21] backends/hostmem: Fix block comments style (checkpatch.pl warnings)

2024-01-31 Thread Michael Tokarev
kends: Simplify host_memory_backend_memory_complete()") Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Xiaoyao Li Signed-off-by: Michael Tokarev --- backends/hostmem.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/backends/hostmem.c b/backends/hostmem.c index 30f69b2cb

[PULL 01/21] dump: Fix HMP dump-guest-memory -z without -R

2024-01-31 Thread Michael Tokarev
-by: Marc-André Lureau Signed-off-by: Michael Tokarev --- dump/dump-hmp-cmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dump/dump-hmp-cmds.c b/dump/dump-hmp-cmds.c index b428ec33df..d9340427c3 100644 --- a/dump/dump-hmp-cmds.c +++ b/dump/dump-hmp-cmds.c @@ -41,7 +41,7

[PULL 09/21] aspeed: Clean up includes

2024-01-31 Thread Michael Tokarev
such inclusions. * Likewise, including headers qemu/osdep.h includes is redundant. Drop these, too. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Zhao Liu Reviewed-by: Richard Henderson Signed-off-by: Michael Tokarev --- hw/arm/aspeed_eeprom.c | 1 + hw/arm

[PULL 11/21] m68k: Clean up includes

2024-01-31 Thread Michael Tokarev
-by: Michael Tokarev --- include/hw/audio/asc.h | 1 - include/hw/m68k/q800-glue.h | 1 - 2 files changed, 2 deletions(-) diff --git a/include/hw/audio/asc.h b/include/hw/audio/asc.h index 4741f92c46..04fac270b6 100644 --- a/include/hw/audio/asc.h +++ b/include/hw/audio/asc.h @@ -13,7 +13,6

[PULL 10/21] acpi: Clean up includes

2024-01-31 Thread Michael Tokarev
-by: Michael Tokarev --- hw/nvram/fw_cfg-acpi.c | 1 + hw/virtio/virtio-acpi.c | 1 + include/hw/nvram/fw_cfg_acpi.h | 1 - include/hw/virtio/virtio-acpi.h | 1 - 4 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/nvram/fw_cfg-acpi.c b/hw/nvram/fw_cfg-acpi.c index

[PULL 20/21] hw/intc/xics: Include missing 'cpu.h' header

2024-01-31 Thread Michael Tokarev
Mathieu-Daudé Reviewed-by: Thomas Huth Signed-off-by: Michael Tokarev --- hw/intc/xics.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/intc/xics.c b/hw/intc/xics.c index 8b25787227..700abfa7a6 100644 --- a/hw/intc/xics.c +++ b/hw/intc/xics.c @@ -40,6 +40,7 @@ #include "hw/

[PULL 07/21] hyperv: Clean up includes

2024-01-31 Thread Michael Tokarev
is redundant, since the .c already includes it. Drop such inclusions. * Likewise, including headers qemu/osdep.h includes is redundant. Drop these, too. Signed-off-by: Peter Maydell Reviewed-by: Zhao Liu Reviewed-by: Richard Henderson Signed-off-by: Michael Tokarev --- hw/hyperv/hv-balloon

[PULL 17/21] hw/i386: Add `\n` to hint message

2024-01-31 Thread Michael Tokarev
From: Greg Kurz error_printf() doesn't add newlines. Signed-off-by: Greg Kurz Reviewed-by: Ani Sinha Signed-off-by: Michael Tokarev --- hw/i386/acpi-build.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index edc979379c

[PULL 18/21] hw/loongarch: Add `\n` to hint message

2024-01-31 Thread Michael Tokarev
From: Greg Kurz error_printf() doesn't add newlines. Signed-off-by: Greg Kurz Reviewed-by: Ani Sinha Signed-off-by: Michael Tokarev --- hw/loongarch/acpi-build.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/loongarch/acpi-build.c b/hw/loongarch/acpi-build.c index

[PULL 12/21] include: Clean up includes

2024-01-31 Thread Michael Tokarev
it in a .h is redundant, since the .c already includes it. Drop such inclusions. * Likewise, including headers qemu/osdep.h includes is redundant. Drop these, too. Signed-off-by: Peter Maydell Reviewed-by: Zhao Liu Signed-off-by: Michael Tokarev --- include/hw/arm/raspberrypi-fw-defs.h | 1

[PULL 15/21] misc: Clean up includes

2024-01-31 Thread Michael Tokarev
/osdep.h first. * Including it in a .h is redundant, since the .c already includes it. Drop such inclusions. * Likewise, including headers qemu/osdep.h includes is redundant. Drop these, too. Signed-off-by: Peter Maydell Reviewed-by: Zhao Liu Signed-off-by: Michael Tokarev --- audio/pwaudio.c

[PULL 14/21] riscv: Clean up includes

2024-01-31 Thread Michael Tokarev
is redundant, since the .c already includes it. Drop such inclusions. * Likewise, including headers qemu/osdep.h includes is redundant. Drop these, too. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Zhao Liu Signed-off-by: Michael Tokarev --- target/riscv

[PULL 08/21] disas/riscv: Clean up includes

2024-01-31 Thread Michael Tokarev
is redundant, since the .c already includes it. Drop such inclusions. * Likewise, including headers qemu/osdep.h includes is redundant. Drop these, too. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Zhao Liu Reviewed-by: Richard Henderson Signed-off-by: Michael

[PULL 04/21] qemu-docs: Update options for graphical frontends

2024-01-31 Thread Michael Tokarev
From: Yihuan Pan The command line options `-ctrl-grab` and `-alt-grab` have been removed in QEMU 7.1. Instead, use the `-display sdl,grab-mod=` option to specify the grab modifiers. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2103 Signed-off-by: Yihuan Pan Signed-off-by: Michael

[PULL 05/21] mailmap: Fix Stefan Weil email

2024-01-31 Thread Michael Tokarev
tefan Weil Fixes: d819fc9516 ("virtio-blk: Fix potential nullptr read access") Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Michael Tokarev --- .mailmap | 4 1 file changed, 4 insertions(+) diff --git a/.mailmap b/.mailmap index d94572af05..88fb68143e 100644 --- a/.ma

[PULL 02/21] colo: examples: remove mentions of script= and (wrong) downscript=

2024-01-31 Thread Michael Tokarev
There's no need to repeat script=/etc/qemu-ifup in examples, as it is already in there. More, all examples uses incorrect "down script=" (which should be "downscript="). Signed-off-by: Michael Tokarev Reviewed-by: Zhang Chen --- docs/colo-proxy.txt | 6 +++--- qem

[PULL 00/21] Trivial patches for 2024-01-31

2024-01-31 Thread Michael Tokarev
Michael Tokarev (1): colo: examples: remove mentions of script= and (wrong) downscript= Peter Maydell (10): scripts/clean-includes: Update exclude list hyperv: Clean up includes disas/riscv: Clean up includes aspeed: Clean up includes acpi: Clean up includes

[PULL 03/21] qapi/migration.json: Fix the member name for MigrationCapability

2024-01-31 Thread Michael Tokarev
From: Han Han s/@compression/@compress/ Fixes: 864128df46 Signed-off-by: Han Han Signed-off-by: Michael Tokarev --- qapi/migration.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi/migration.json b/qapi/migration.json index d3e2b864c5..819708321d 100644

why various devices are loading x86 roms on non-x86 architectures?

2024-01-31 Thread Michael Tokarev
Hi! qemu-system-aarch64 -device virtio-vga this one loads vgabios-virtio.bin. Why? Does this bios work on aarch64 (or any other non-x86 arch)? Should there may be some conditional in this and similar places? The same is true for x86 pxe roms and other x86-only roms. Thanks, /mjt

Re: [PATCH] Make 'uri' optional for migrate QAPI

2024-01-29 Thread Michael Tokarev
30.01.2024 04:35, Peter Xu: .. This seems like a stable material too, - please let me know if it is not. Yes it is. I used to be more careful on copying stable at least in the commit message when I post patches, but forgot to do so when start picking up.. Note that it's already merged in

Re: [PATCH] Make 'uri' optional for migrate QAPI

2024-01-29 Thread Michael Tokarev
23.01.2024 09:42, Het Gala: 'uri' argument should be optional, as 'uri' and 'channels' arguments are mutally exclusive in nature. Fixes: 074dbce5fcce (migration: New migrate and migrate-incoming argument 'channels') Signed-off-by: Het Gala --- qapi/migration.json | 2 +- 1 file changed, 1

Re: [ANNOUNCE] QEMU 8.2.2 Stable released

2024-01-29 Thread Michael Tokarev
29.01.2024 23:18, Michael Tokarev wrote: Hi everyone, The QEMU v8.2.2 stable release is now available. You can grab the tarball from our download page here: https://www.qemu.org/download/#source https://download.qemu.org/qemu-8.2.2.tar.xz https://download.qemu.org/qemu-8.2.2

[ANNOUNCE] QEMU 8.2.1 Stable released

2024-01-29 Thread Michael Tokarev
Changelog (stable-8.2-hash master-hash Author Name: Commmit-Subject): f48c205fb4 Michael Tokarev: Update version for 8.2.1 release 45b3ce5e83 ee0a2e3c9d Peter Maydell: target/arm: Fix incorrect aa64_tidcp1 feature check 570e624426 6fffc83785 Peter Maydell: target/arm: Fix A64 scalar SQSHRN and SQRSHRN

Re: [PATCH] vfio/pci: Clear MSI-X IRQ index always

2024-01-29 Thread Michael Tokarev
29.01.2024 23:10, Michael Tokarev пишет: This seems to be a stable material too, for stable-8.2 series. Please let me know if it is not. Please Cc: qemu-stable@ for other stable-worthy changes. Ahh, this is already Cc'ed to qemu-stable@, - please excuse me for the noise! /mjt

[ANNOUNCE] QEMU 8.2.2 Stable released

2024-01-29 Thread Michael Tokarev
Changelog (stable-8.2-hash master-hash Author Name: Commmit-Subject): read 063472fa01 Michael Tokarev: Update version for 8.2.2 release read b79a2ef0d4 d2b668fca5 Cédric Le Goater: vfio/pci: Clear MSI-X IRQ index always read 106aa13c5b 27eb8499ed Fabiano Rosas: migration: Fix use-after-free

Re: [PATCH] vfio/pci: Clear MSI-X IRQ index always

2024-01-29 Thread Michael Tokarev
25.01.2024 17:42, Cédric Le Goater: When doing device assignment of a physical device, MSI-X can be enabled with no vectors enabled and this sets the IRQ index to VFIO_PCI_MSIX_IRQ_INDEX. However, when MSI-X is disabled, the IRQ index is left untouched if no vectors are in use. Then, when INTx

Re: [ANNOUNCE] QEMU 8.1.5 Stable released

2024-01-29 Thread Michael Tokarev
29.01.2024 22:13, Michael Tokarev пишет: Hi everyone, The QEMU v8.1.5 stable release is now available. You can grab the tarball from our download page here: https://www.qemu.org/download/#source https://download.qemu.org/qemu-8.1.5.tar.xz https://download.qemu.org/qemu-8.1.5

[ANNOUNCE] QEMU 8.1.5 Stable released

2024-01-29 Thread Michael Tokarev
Changelog (stable-8.1-hash master-hash Author Name: Commmit-Subject): 20a1b341a0 Michael Tokarev: Update version for 8.1.5 release ccdb4cc209 6fffc83785 Peter Maydell: target/arm: Fix A64 scalar SQSHRN and SQRSHRN b86fa3a4f2 604927e357 Max Filippov: target/xtensa: fix OOB TLB entry access d24dd10143

[ANNOUNCE] QEMU 7.2.9 Stable released

2024-01-29 Thread Michael Tokarev
Changelog (stable-7.2-hash master-hash Author Name: Commmit-Subject): 0c918cb0ab Michael Tokarev: Update version for 7.2.9 release ecc23c6e95 604927e357 Max Filippov: target/xtensa: fix OOB TLB entry access fa020ef10b e8a12fe31f Daniel P. Berrangé: qtest: bump aspeed_smc-test timeout to 6 minutes

Re: [PATCH] hw/scsi/lsi53c895a: add missing decrement of reentrancy counter

2024-01-28 Thread Michael Tokarev
28.01.2024 23:22, Sven Schnelle : When the maximum count of SCRIPTS instructions is reached, the code stops execution and returns, but fails to decrement the reentrancy counter. This effectively renders the SCSI controller unusable because on next entry the reentrancy counter is still above the

Re: [PATCH 2/2] hw/smbios: Fix port connector option validation

2024-01-28 Thread Michael Tokarev
28.01.2024 10:15, Akihiko Odaki: qemu_smbios_type8_opts did not the list terminator and that resulted in out-of-bound memory access. qemu_smbios_type8_opts also needs to have an element for the type option. With the same description fix as in 1/1, Reviewed-by: Michael Tokarev /mjt

Re: [PATCH 1/2] hw/smbios: Fix OEM strings table option validation

2024-01-28 Thread Michael Tokarev
("smbios: support setting OEM strings table") Wow. That's long ago.. This is a -stable material. And since it's exactly the same 2 problems in 2 nearby places, it can be combined into a single patch, but it definitely works this way too, just a question of taste. Reviewed-by: Micha

[Stable-8.2.1 64/71] block/blklogwrites: Fix a bug when logging "write zeroes" operations.

2024-01-28 Thread Michael Tokarev
ea95470c27a8a02062b67f9fa6940e828ab6) Signed-off-by: Michael Tokarev diff --git a/block/blklogwrites.c b/block/blklogwrites.c index 3678f6cf42..84e03f309f 100644 --- a/block/blklogwrites.c +++ b/block/blklogwrites.c @@ -328,22 +328,39 @@ static void coroutine_fn GRAPH_RDLOCK blk_log_wri

[Stable-8.2.1 69/71] target/xtensa: fix OOB TLB entry access

2024-01-28 Thread Michael Tokarev
81-1-jcmvb...@gmail.com Signed-off-by: Peter Maydell (cherry picked from commit 604927e357c2b292c70826e4ce42574ad126ef32) Signed-off-by: Michael Tokarev diff --git a/target/xtensa/mmu_helper.c b/target/xtensa/mmu_helper.c index 12552a3347..2fda4e887c 100644 --- a/target/xtensa/mmu_helper.c ++

[Stable-8.1.5 35/36] target/xtensa: fix OOB TLB entry access

2024-01-28 Thread Michael Tokarev
81-1-jcmvb...@gmail.com Signed-off-by: Peter Maydell (cherry picked from commit 604927e357c2b292c70826e4ce42574ad126ef32) Signed-off-by: Michael Tokarev diff --git a/target/xtensa/mmu_helper.c b/target/xtensa/mmu_helper.c index fa66e8e867..c4b4df4d74 100644 --- a/target/xtensa/mmu_helper.c ++

[Stable-8.2.1 70/71] target/arm: Fix A64 scalar SQSHRN and SQRSHRN

2024-01-28 Thread Michael Tokarev
y: Richard Henderson Message-id: 20240123153416.877308-1-peter.mayd...@linaro.org (cherry picked from commit 6fffc8378562c7fea6290c430b4f653f830a4c1a) Signed-off-by: Michael Tokarev diff --git a/target/arm/tcg/translate-a64.c b/target/arm/tcg/translate-a64.c index a2e49c39f9..f2d05c589c 100644 --

[Stable-8.2.1 58/71] coroutine-ucontext: Save fake stack for pooled coroutine

2024-01-28 Thread Michael Tokarev
-by: Akihiko Odaki Reviewed-by: Marc-André Lureau Signed-off-by: Stefan Hajnoczi Message-ID: <20240117-asan-v2-1-26f9e1ea6...@daynix.com> (cherry picked from commit d9945ccda08ef83b09ac7725b6ee2d1959f2c0c0) Signed-off-by: Michael Tokarev diff --git a/util/coroutine-ucontext.c b/util/cor

[Stable-7.2.9 23/30] block/io: clear BDRV_BLOCK_RECURSE flag after recursing in bdrv_co_block_status

2024-01-28 Thread Michael Tokarev
ot; } } > {"execute": "blockdev-backup", "arguments": { "device": "snap0", "target": > "node1", "sync": "full", "job-id": "backup0" } } > EOF Signed-off-by: Fiona Ebner Reviewed-by: Vladimir Sementso

[Stable-8.1.5 30/36] block/blklogwrites: Fix a bug when logging "write zeroes" operations.

2024-01-28 Thread Michael Tokarev
ea95470c27a8a02062b67f9fa6940e828ab6) Signed-off-by: Michael Tokarev diff --git a/block/blklogwrites.c b/block/blklogwrites.c index 3ea7141cb5..5d715383c9 100644 --- a/block/blklogwrites.c +++ b/block/blklogwrites.c @@ -324,22 +324,39 @@ static void coroutine_fn GRAPH_RDLOCK blk_log_wri

[Stable-8.2.1 65/71] iotests: add filter_qmp_generated_node_ids()

2024-01-28 Thread Michael Tokarev
: <20240118144823.1497953-2-stefa...@redhat.com> Reviewed-by: Kevin Wolf Signed-off-by: Kevin Wolf (cherry picked from commit da62b507a20510d819bcfbe8f5e573409b954006) Signed-off-by: Michael Tokarev diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index e5c5798c71..ea48af4a7b

[Stable-8.1.5 28/36] tcg/arm: Fix SIGILL in tcg_out_qemu_st_direct

2024-01-28 Thread Michael Tokarev
t Message-Id: <20240121211439.100829-1-caseo...@gmail.com> Reviewed-by: Richard Henderson Signed-off-by: Richard Henderson (cherry picked from commit 9f6523e8e4689cafdbed7c10b7cf7c775b5a607b) Signed-off-by: Michael Tokarev diff --git a/tcg/arm/tcg-target.c.inc b/tcg/arm/tcg-target.c.inc

[Stable-8.2.1 56/71] accel/tcg: Revert mapping of PCREL translation block to multiple virtual addresses

2024-01-28 Thread Michael Tokarev
From: Paolo Bonzini This is causing regressions that have not been analyzed yet. Revert the change on stable branches. Cc: qemu-sta...@nongnu.org Cc: Michael Tokarev Related: https://gitlab.com/qemu-project/qemu/-/issues/2092 Signed-off-by: Paolo Bonzini Signed-off-by: Michael Tokarev diff

[Stable-8.2.1 67/71] monitor: only run coroutine commands in qemu_aio_context

2024-01-28 Thread Michael Tokarev
rowse/RHEL-17369 Signed-off-by: Stefan Hajnoczi Message-ID: <20240118144823.1497953-4-stefa...@redhat.com> Reviewed-by: Kevin Wolf Tested-by: Fiona Ebner Signed-off-by: Kevin Wolf (cherry picked from commit effd60c878176bcaf97fa7ce2b12d04bb8ead6f7) Signed-off-by: Michael Tokarev diff --git

[Stable-8.2.1 71/71] target/arm: Fix incorrect aa64_tidcp1 feature check

2024-01-28 Thread Michael Tokarev
rom commit ee0a2e3c9d2991a11c13ffadb15e4d0add43c257) Signed-off-by: Michael Tokarev diff --git a/target/arm/cpu-features.h b/target/arm/cpu-features.h index 954d358268..165a497f7b 100644 --- a/target/arm/cpu-features.h +++ b/target/arm/cpu-features.h @@ -771,7 +771,7 @@ static inline bool isar_feature_aa64_hcx(const ARMISAReg

[Stable-8.2.1 62/71] tcg/arm: Fix SIGILL in tcg_out_qemu_st_direct

2024-01-28 Thread Michael Tokarev
t Message-Id: <20240121211439.100829-1-caseo...@gmail.com> Reviewed-by: Richard Henderson Signed-off-by: Richard Henderson (cherry picked from commit 9f6523e8e4689cafdbed7c10b7cf7c775b5a607b) Signed-off-by: Michael Tokarev diff --git a/tcg/arm/tcg-target.c.inc b/tcg/arm/tcg-target.c.inc

[Stable-8.2.1 68/71] qtest: bump aspeed_smc-test timeout to 6 minutes

2024-01-28 Thread Michael Tokarev
-off-by: Thomas Huth Message-Id: <20231215070357.10888-11-th...@redhat.com> Signed-off-by: Alex Bennée (cherry picked from commit e8a12fe31f776c60fec993513cd1b1e66c2b8e29) Signed-off-by: Michael Tokarev (Mjt: context fixup in tests/qtest/meson.build) diff --git a/tests/qtest/meson.build b

[Stable-8.1.5 36/36] target/arm: Fix A64 scalar SQSHRN and SQRSHRN

2024-01-28 Thread Michael Tokarev
y: Richard Henderson Message-id: 20240123153416.877308-1-peter.mayd...@linaro.org (cherry picked from commit 6fffc8378562c7fea6290c430b4f653f830a4c1a) Signed-off-by: Michael Tokarev diff --git a/target/arm/tcg/translate-a64.c b/target/arm/tcg/translate-a64.c index 7267f172d7..4e54cb7502 100644 --

[Stable-8.1.5 34/36] qtest: bump aspeed_smc-test timeout to 6 minutes

2024-01-28 Thread Michael Tokarev
-off-by: Thomas Huth Message-Id: <20231215070357.10888-11-th...@redhat.com> Signed-off-by: Alex Bennée (cherry picked from commit e8a12fe31f776c60fec993513cd1b1e66c2b8e29) Signed-off-by: Michael Tokarev (Mjt: context fixup in tests/qtest/meson.build) diff --git a/tests/qtest/meson.build b

[Stable-8.2.1 60/71] linux-user: Fixed cpu restore with pc 0 on SIGBUS

2024-01-28 Thread Michael Tokarev
("linux-user: Split out host_sig{segv,bus}_handler") Reviewed-by: Palmer Dabbelt Message-Id: <33f27425878fb529b9e39ef22c303f6e0d90525f.ca...@rivosinc.com> Signed-off-by: Richard Henderson (cherry picked from commit 6d913158b5023ac948b8fd649d77fc86e28072f6) Signed-off-by: Michae

[Stable-8.2.1 63/71] virtio-net: correctly copy vnet header when flushing TX

2024-01-28 Thread Michael Tokarev
-by: Xiao Lei Cc: Yuri Benditovich Cc: qemu-sta...@nongnu.org Cc: Mauro Matteo Cascella Fixes: CVE-2023-6693 Fixes: e22f0603fb2f ("virtio-net: reference implementation of hash report") Reviewed-by: Michael Tokarev Signed-off-by: Jason Wang (cherry picked f

[Stable-8.2.1 59/71] block/io: clear BDRV_BLOCK_RECURSE flag after recursing in bdrv_co_block_status

2024-01-28 Thread Michael Tokarev
ot; } } > {"execute": "blockdev-backup", "arguments": { "device": "snap0", "target": > "node1", "sync": "full", "job-id": "backup0" } } > EOF Signed-off-by: Fiona Ebner Reviewed-by: Vladimir Sem

[Stable-8.2.1 00/71] Patch Round-up for stable 8.2.1, frozen on 2024-01-27

2024-01-28 Thread Michael Tokarev
and standard frame 09* 5cb0e7abe163 Xu Lu: target/riscv: Fix mcycle/minstret increment behavior 10* 4ad87cd4b225 Michael Tokarev: chardev/char.c: fix "abstract device type" error message 11* 09a36158c283 Michael Tokarev: audio/audio.c: remove trailing newline in error_setg 12* 0c

[Stable-8.2.1 55/71] acpi/tests/avocado/bits: wait for 200 seconds for SHUTDOWN event from bits VM

2024-01-28 Thread Michael Tokarev
/2077 Signed-off-by: Ani Sinha Reviewed-by: Daniel P. Berrangé Message-id: 20240117042556.3360190-1-anisi...@redhat.com Signed-off-by: Peter Maydell (cherry picked from commit 7ef4c41e91d59d72a3b8bc022a6cb3e81787a50a) Signed-off-by: Michael Tokarev diff --git a/tests/avocado/acpi-bits.py b/tests

[Stable-8.2.1 66/71] iotests: port 141 to Python for reliable QMP testing

2024-01-28 Thread Michael Tokarev
reliable first. Cc: Hanna Czenczek Signed-off-by: Stefan Hajnoczi Message-ID: <20240118144823.1497953-3-stefa...@redhat.com> Reviewed-by: Kevin Wolf Signed-off-by: Kevin Wolf (cherry picked from commit 9ee2dd4c22a3639c5462b3fc20df60c005c3de64) Signed-off-by: Michael Tokarev diff --git a/test

[Stable-8.2.1 61/71] linux-user/riscv: Adjust vdso signal frame cfa offsets

2024-01-28 Thread Michael Tokarev
Reviewed-by: Alistair Francis Signed-off-by: Richard Henderson (cherry picked from commit 1b21fe27e75a59bfe2513f5abcc6a18cfc35cfc8) Signed-off-by: Michael Tokarev diff --git a/linux-user/riscv/vdso-32.so b/linux-user/riscv/vdso-32.so index 1ad1e5cbbb..c2ce2a4757 100755 Binary files a/linux-user/riscv

[Stable-8.2.1 57/71] tcg/s390x: Fix encoding of VRIc, VRSa, VRSc insns

2024-01-28 Thread Michael Tokarev
...@nongnu.org Reported-by: Michael Tokarev Fixes: 22cb37b4172 ("tcg/s390x: Implement vector shift operations") Fixes: 79cada8693d ("tcg/s390x: Implement tcg_out_dup*_vec") Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2054 Reviewed-by: Thomas Huth Tested-by: Michael

[Stable-8.1.5 29/36] virtio-net: correctly copy vnet header when flushing TX

2024-01-28 Thread Michael Tokarev
-by: Xiao Lei Cc: Yuri Benditovich Cc: qemu-sta...@nongnu.org Cc: Mauro Matteo Cascella Fixes: CVE-2023-6693 Fixes: e22f0603fb2f ("virtio-net: reference implementation of hash report") Reviewed-by: Michael Tokarev Signed-off-by: Jason Wang (cherry picked f

[Stable-8.1.5 31/36] iotests: add filter_qmp_generated_node_ids()

2024-01-28 Thread Michael Tokarev
: <20240118144823.1497953-2-stefa...@redhat.com> Reviewed-by: Kevin Wolf Signed-off-by: Kevin Wolf (cherry picked from commit da62b507a20510d819bcfbe8f5e573409b954006) Signed-off-by: Michael Tokarev diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index ef66fbd62b..1dd41e68ee

[Stable-7.2.9 27/30] iotests: port 141 to Python for reliable QMP testing

2024-01-28 Thread Michael Tokarev
reliable first. Cc: Hanna Czenczek Signed-off-by: Stefan Hajnoczi Message-ID: <20240118144823.1497953-3-stefa...@redhat.com> Reviewed-by: Kevin Wolf Signed-off-by: Kevin Wolf (cherry picked from commit 9ee2dd4c22a3639c5462b3fc20df60c005c3de64) Signed-off-by: Michael Tokarev diff --git a/test

[Stable-8.1.5 25/36] readthodocs: fully specify a build environment

2024-01-28 Thread Michael Tokarev
-by: Alex Bennée Message-Id: <20231221174200.2693694-1-alex.ben...@linaro.org> (cherry picked from commit b16a45bc5e0e329a16af8a2e020a6e7044f9afa2) Signed-off-by: Michael Tokarev diff --git a/.readthedocs.yml b/.readthedocs.yml index 7fb7b8dd61..0b262469ce 100644 --- a/.readthedocs.yml

[Stable-8.1.5 33/36] monitor: only run coroutine commands in qemu_aio_context

2024-01-28 Thread Michael Tokarev
rowse/RHEL-17369 Signed-off-by: Stefan Hajnoczi Message-ID: <20240118144823.1497953-4-stefa...@redhat.com> Reviewed-by: Kevin Wolf Tested-by: Fiona Ebner Signed-off-by: Kevin Wolf (cherry picked from commit effd60c878176bcaf97fa7ce2b12d04bb8ead6f7) Signed-off-by: Michael Tokarev diff --git

[Stable-7.2.9 29/30] qtest: bump aspeed_smc-test timeout to 6 minutes

2024-01-28 Thread Michael Tokarev
-off-by: Thomas Huth Message-Id: <20231215070357.10888-11-th...@redhat.com> Signed-off-by: Alex Bennée (cherry picked from commit e8a12fe31f776c60fec993513cd1b1e66c2b8e29) Signed-off-by: Michael Tokarev (Mjt: context fixup in tests/qtest/meson.build) diff --git a/tests/qtest/meson.build b

[Stable-8.1.5 32/36] iotests: port 141 to Python for reliable QMP testing

2024-01-28 Thread Michael Tokarev
reliable first. Cc: Hanna Czenczek Signed-off-by: Stefan Hajnoczi Message-ID: <20240118144823.1497953-3-stefa...@redhat.com> Reviewed-by: Kevin Wolf Signed-off-by: Kevin Wolf (cherry picked from commit 9ee2dd4c22a3639c5462b3fc20df60c005c3de64) Signed-off-by: Michael Tokarev diff --git a/test

[Stable-8.1.5 v3 00/36] Patch Round-up for stable 8.1.5, frozen on 2024-01-27

2024-01-28 Thread Michael Tokarev
* 25145a7d7735 Pavel Pisa: hw/net/can/sja1000: fix bug for single acceptance filter and standard frame 05* 5cb0e7abe163 Xu Lu: target/riscv: Fix mcycle/minstret increment behavior 06* 4ad87cd4b225 Michael Tokarev: chardev/char.c: fix "abstract device type" error message 07* 82a65e3188ab Pet

[Stable-7.2.9 24/30] virtio-net: correctly copy vnet header when flushing TX

2024-01-28 Thread Michael Tokarev
-by: Xiao Lei Cc: Yuri Benditovich Cc: qemu-sta...@nongnu.org Cc: Mauro Matteo Cascella Fixes: CVE-2023-6693 Fixes: e22f0603fb2f ("virtio-net: reference implementation of hash report") Reviewed-by: Michael Tokarev Signed-off-by: Jason Wang (cherry picked f

[Stable-8.1.5 26/36] accel/tcg: Revert mapping of PCREL translation block to multiple virtual addresses

2024-01-28 Thread Michael Tokarev
From: Paolo Bonzini This is causing regressions that have not been analyzed yet. Revert the change on stable branches. Cc: qemu-sta...@nongnu.org Cc: Michael Tokarev Related: https://gitlab.com/qemu-project/qemu/-/issues/2092 Signed-off-by: Paolo Bonzini Signed-off-by: Michael Tokarev diff

[Stable-8.1.5 27/36] block/io: clear BDRV_BLOCK_RECURSE flag after recursing in bdrv_co_block_status

2024-01-28 Thread Michael Tokarev
ot; } } > {"execute": "blockdev-backup", "arguments": { "device": "snap0", "target": > "node1", "sync": "full", "job-id": "backup0" } } > EOF Signed-off-by: Fiona Ebner Reviewed-by: Vladimir

[Stable-7.2.9 v3 00/30] Patch Round-up for stable 7.2.9, frozen on 2024-01-27

2024-01-28 Thread Michael Tokarev
05* 4ad87cd4b225 Michael Tokarev: chardev/char.c: fix "abstract device type" error message 06* 82a65e3188ab Peter Maydell: hw/intc/arm_gicv3_cpuif: handle LPIs in in the list registers 07* e358a25a97c7 Ilya Leoshkevich: target/s390x: Fix LAE setting a wrong access register 08* 52

[Stable-7.2.9 30/30] target/xtensa: fix OOB TLB entry access

2024-01-28 Thread Michael Tokarev
81-1-jcmvb...@gmail.com Signed-off-by: Peter Maydell (cherry picked from commit 604927e357c2b292c70826e4ce42574ad126ef32) Signed-off-by: Michael Tokarev diff --git a/target/xtensa/mmu_helper.c b/target/xtensa/mmu_helper.c index fa66e8e867..c4b4df4d74 100644 --- a/target/xtensa/mmu_helper.c ++

[Stable-7.2.9 28/30] monitor: only run coroutine commands in qemu_aio_context

2024-01-28 Thread Michael Tokarev
rowse/RHEL-17369 Signed-off-by: Stefan Hajnoczi Message-ID: <20240118144823.1497953-4-stefa...@redhat.com> Reviewed-by: Kevin Wolf Tested-by: Fiona Ebner Signed-off-by: Kevin Wolf (cherry picked from commit effd60c878176bcaf97fa7ce2b12d04bb8ead6f7) Signed-off-by: Michael Tokarev (Mjt: omit

[Stable-7.2.9 22/30] accel/tcg: Revert mapping of PCREL translation block to multiple virtual addresses

2024-01-28 Thread Michael Tokarev
From: Paolo Bonzini This is causing regressions that have not been analyzed yet. Revert the change on stable branches. Cc: qemu-sta...@nongnu.org Cc: Michael Tokarev Related: https://gitlab.com/qemu-project/qemu/-/issues/2092 Signed-off-by: Paolo Bonzini Signed-off-by: Michael Tokarev diff

[Stable-7.2.9 25/30] block/blklogwrites: Fix a bug when logging "write zeroes" operations.

2024-01-28 Thread Michael Tokarev
ea95470c27a8a02062b67f9fa6940e828ab6) Signed-off-by: Michael Tokarev diff --git a/block/blklogwrites.c b/block/blklogwrites.c index cef9efe55d..ad589c4a2e 100644 --- a/block/blklogwrites.c +++ b/block/blklogwrites.c @@ -321,22 +321,39 @@ typedef struct { static void coroutine_fn blk_log_wri

[Stable-7.2.9 26/30] iotests: add filter_qmp_generated_node_ids()

2024-01-28 Thread Michael Tokarev
: <20240118144823.1497953-2-stefa...@redhat.com> Reviewed-by: Kevin Wolf Signed-off-by: Kevin Wolf (cherry picked from commit da62b507a20510d819bcfbe8f5e573409b954006) Signed-off-by: Michael Tokarev (Mjt: context fix in tests/qemu-iotests/iotests.py due to v7.2.0-939-gbcc6777ad6 "iotests: Filter

[Stable-7.2.9 21/30] readthodocs: fully specify a build environment

2024-01-28 Thread Michael Tokarev
-by: Alex Bennée Message-Id: <20231221174200.2693694-1-alex.ben...@linaro.org> (cherry picked from commit b16a45bc5e0e329a16af8a2e020a6e7044f9afa2) Signed-off-by: Michael Tokarev diff --git a/.readthedocs.yml b/.readthedocs.yml index 7fb7b8dd61..0b262469ce 100644 --- a/.readthedocs.yml

Re: [PATCH v2] target/arm: fix exception syndrome for AArch32 bkpt insn

2024-01-27 Thread Michael Tokarev
On 27.01.2024 23:27, Jan Klötzke wrote: Debug exceptions that target AArch32 Hyp mode are reported differently than on AAarch64. Internally, Qemu uses the AArch64 syndromes. Therefore such exceptions need to be either converted to a prefetch abort (breakpoints, vector catch) or a data abort

Re: [PATCH 00/10] Clean up includes

2024-01-26 Thread Michael Tokarev
25.01.2024 19:33, Peter Maydell : This series makes a bunch of automated edits with the clean-includes script. The script performs three related cleanups: * Ensure .c files include qemu/osdep.h first. * Including it in a .h is redundant, since the .c already includes it. Drop such

Re: [PULL 05/13] linux-user: Use walk_memory_regions for open_self_maps

2024-01-26 Thread Michael Tokarev
26.01.2024 16:03, Richard Purdie wrote: Hi, I've run into a problem with this change. We (Yocto Project) upgraded to qemu 8.2.0 recently and after that we started seeing errors cross compiling webkitgtk on x86_64 for x86_64 during the introspection code which runs under user mode qemu. Hi

Re: [PATCH trivial 1/2] close_all_open_fd(): move to oslib-posix.c

2024-01-26 Thread Michael Tokarev
26.01.2024 14:01, Daniel P. Berrangé: [] We should try to use O_CLOEXEC everywhere, but at the same time QEMU links to a large number of libraries, and we can't assume that they've reliably used O_CLOEXEC. Non-QEMU owned code that is mapped in process likely dwarfs QEMU owned code by a factor of

Re: [PATCH trivial 1/2] close_all_open_fd(): move to oslib-posix.c

2024-01-26 Thread Michael Tokarev
26.01.2024 12:06, Daniel P. Berrangé wrote: On Fri, Jan 26, 2024 at 08:44:13AM +0100, Laurent Vivier wrote: Le 25/01/2024 à 23:29, Michael Tokarev a écrit : I think the way using sysconf(_SC_OPEN_MAX) is more portable, simpler and cleaner than the one using /proc/self/fd. A fallback

Re: [PATCH v2] mailmap: Fix Stefan Weil email

2024-01-26 Thread Michael Tokarev
23.01.2024 11:21, Philippe Mathieu-Daudé: Commit 5204b499a6 ("mailmap: Fix Stefan Weil author email") corrected authorship for patch received at qemu-devel@nongnu.org, correct now for patch received at qemu-triv...@nongnu.org. Update other authorship email for Stefan's commits. Applied to

Re: [PATCH v2] qemu-docs: Update options for graphical frontends

2024-01-26 Thread Michael Tokarev
22.01.2024 07:22, Yihuan Pan wrote: The command line options `-ctrl-grab` and `-alt-grab` have been removed in QEMU 7.1. Instead, use the `-display sdl,grab-mod=` option to specify the grab modifiers. Applied to trivial-patches, thanks! /mjt Resolves:

Re: [PATCH] qapi/migration.json: Fix the member name for MigrationCapability

2024-01-26 Thread Michael Tokarev
19.01.2024 16:53, Han Han: s/@compression/@compress/ Fixes: 864128df46 Please post all patches to qemu-devel@. I'm picking this one up because it is an obvious an trivial fix, but it's still a good idea to let the migration/qapi people to know. Thanks, /mjt Signed-off-by: Han Han ---

[PATCH trivial 1/2] close_all_open_fd(): move to oslib-posix.c

2024-01-25 Thread Michael Tokarev
Initially in async-teardown.c, but the same construct is used elsewhere too. Signed-off-by: Michael Tokarev --- include/sysemu/os-posix.h | 1 + system/async-teardown.c | 37 + util/oslib-posix.c| 36 3 files

[PATCH trivial 2/2] net/tap: use os_close_all_open_fd() instead of open-coding it

2024-01-25 Thread Michael Tokarev
Current code loops over every file descriptor up to SC_OPEN_MAX/RLIMIT_NOFILE which might be huge and the loop might be slow. But we already have os_close_all_open_fd() which is fast. Use it. Signed-off-by: Michael Tokarev --- net/tap.c | 15 ++- 1 file changed, 2 insertions

[PATCH trivial 0/2] split out os_close_all_open_fd and use it in net/tap.c too

2024-01-25 Thread Michael Tokarev
-to-be-used implementation which only needs to be moved into a common place. Michael Tokarev (2): close_all_open_fd(): move to oslib-posix.c net/tap: use os_close_all_open_fd() instead of open-coding it include/sysemu/os-posix.h | 1 + net/tap.c | 15 ++- system

Re: [PULL 0/2] Block patches

2024-01-25 Thread Michael Tokarev
22.01.2024 19:01, Stefan Hajnoczi : Akihiko Odaki (1): coroutine-ucontext: Save fake stack for pooled coroutine Fiona Ebner (1): block/io: clear BDRV_BLOCK_RECURSE flag after recursing in bdrv_co_block_status These too also look like -stable matherial, both of the changes. Please

Re: Do we still need pre-meson compatibility hacks?

2024-01-25 Thread Michael Tokarev
25.01.2024 14:04, Peter Maydell : On Thu, 25 Jan 2024 at 07:54, Paolo Bonzini wrote: Right now configure contains a couple hacks to preserve some of the semantics of the pre-meson build system: 1) emulation of ./configure by creating a build directory and a forwarding GNUmakefile

Re: [PATCH v3 00/16] tests: enable meson test timeouts to improve debuggability

2024-01-23 Thread Michael Tokarev
23.01.2024 20:47, Thomas Huth: On 23/01/2024 17.50, Michael Tokarev wrote: .. I'm picking this up for stable branches too, since there we have the same problems in CI environment. In particular, bios-tables-test almost always times out, even hitting retry doesn't help.  Let's see how it goes

<    3   4   5   6   7   8   9   10   11   12   >