Re: [Qemu-devel] [PATCHv2 1/2] Revert migration: do not sent zero pages in bulk stage

2013-06-10 Thread Orit Wasserman
++; } else if (!ram_bulk_stage migrate_use_xbzrle()) { current_addr = block-offset + offset; bytes_sent = save_xbzrle_page(f, p, current_addr, block, Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCHv2 2/2] migration: do not overwrite zero pages

2013-06-10 Thread Orit Wasserman
()) +getpagesize() = TARGET_PAGE_SIZE) { +qemu_madvise(host, TARGET_PAGE_SIZE, QEMU_MADV_DONTNEED); +} #endif +} } else if (flags RAM_SAVE_FLAG_PAGE) { void *host; Reviewed-by: Orit Wasserman owass...@redhat.com?

Re: [Qemu-devel] KVM call for agenda for 2013-10-01

2013-09-30 Thread Orit Wasserman
On 09/24/2013 05:09 PM, Juan Quintela wrote: Hi Please, send any topic that you are interested in covering. Last week I forgot to send the call for topics. We still have a topic there. Thanks, Juan. Agenda so far: - Talk about qemu reverse executing (1st description was done this

Re: [Qemu-devel] [PATCH 0/3 resend v2] Migration fix

2013-09-04 Thread Orit Wasserman
| 15 ++- savevm.c|9 - 2 files changed, 18 insertions(+), 6 deletions(-) Looks good, Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH RFC 0/4] Curling: KVM Fault Tolerance

2013-09-10 Thread Orit Wasserman
On 09/10/2013 06:43 AM, Jules Wang wrote: The goal of Curling(sports) is to provide a fault tolerant mechanism for KVM, so that in the event of a hardware failure, the virtual machine fails over to the backup in a way that is completely transparent to the guest operating system. Our goal

Re: [Qemu-devel] [PATCH RFC 0/4] Curling: KVM Fault Tolerance

2013-09-12 Thread Orit Wasserman
On 09/11/2013 04:54 AM, junqing.w...@cs2c.com.cn wrote: Hi, The first is that if the VM failure happen in the middle on the live migration the backup VM state will be inconsistent which means you can't failover to it. Yes, I have concerned about this problem. That is why we need a

Re: [Qemu-devel] [PATCH 3/3 resend v2] arch_init: right return for ram_save_iterate

2013-09-12 Thread Orit Wasserman
On 09/11/2013 02:27 PM, Paolo Bonzini wrote: Il 11/09/2013 13:06, Juan Quintela ha scritto: And I think that the right solution is make qemu_get_rate_limit() to return -1 in case of error (or the error, I don't care). You might do both things, it would avoid the useless g_usleep you pointed

Re: [Qemu-devel] [PATCH] rdma: bugfix: make IPv6 support work

2013-07-30 Thread Orit Wasserman
On 07/27/2013 05:23 AM, mrhi...@linux.vnet.ibm.com wrote: From: Michael R. Hines mrhi...@us.ibm.com When testing with libvirt, a simple IPv6 migration test failed because we were not using getaddrinfo() properly. This makes IPv6 migration over RDMA work. Also, we forgot to turn the

Re: [Qemu-devel] [PATCH] rdma: bugfix: make IPv6 support work

2013-07-30 Thread Orit Wasserman
On 07/30/2013 05:57 PM, Michael R. Hines wrote: On 07/30/2013 04:14 AM, Orit Wasserman wrote: On 07/27/2013 05:23 AM, mrhi...@linux.vnet.ibm.com wrote: From: Michael R. Hines mrhi...@us.ibm.com When testing with libvirt, a simple IPv6 migration test failed because we were not using

Re: [Qemu-devel] [PATCH] rdma: bugfix: make IPv6 support work

2013-07-31 Thread Orit Wasserman
On 07/31/2013 04:39 PM, Michael R. Hines wrote: On 07/30/2013 11:31 AM, Orit Wasserman wrote: On 07/30/2013 05:57 PM, Michael R. Hines wrote: On 07/30/2013 04:14 AM, Orit Wasserman wrote: On 07/27/2013 05:23 AM, mrhi...@linux.vnet.ibm.com wrote: From: Michael R. Hines mrhi...@us.ibm.com

Re: [Qemu-devel] [PATCH v3 For-1.6 1/7] rdma: bugfix: make IPv6 support work

2013-08-07 Thread Orit Wasserman
On 08/04/2013 05:54 AM, mrhi...@linux.vnet.ibm.com wrote: From: Michael R. Hines mrhi...@us.ibm.com RDMA does not use sockets, so we cannot use many of the socket helper functions, but we *do* use inet_parse() which gives RDMA all the necessary details of the connection parameters.

Re: [Qemu-devel] [PATCH v3 For-1.6 2/7] rdma: forgot to turn off the debugging flag

2013-08-07 Thread Orit Wasserman
Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH v3 For-1.6 3/7] rdma: correct newlines in error statements

2013-08-07 Thread Orit Wasserman
rdma_start_outgoing_migration(void *opaque, int ret = 0; if (rdma == NULL) { -ERROR(temp, Failed to initialize RDMA data structures! %d\n, ret); +ERROR(temp, Failed to initialize RDMA data structures! %d, ret); goto err; } Reviewed-by: Orit Wasserman owass

Re: [Qemu-devel] [PATCH 0/3] rdma: validate remote provided RDMAControlHeader::len

2013-08-07 Thread Orit Wasserman
match transferred byte migration-rdma.c | 44 ++-- 1 file changed, 30 insertions(+), 14 deletions(-) Series Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH for-1.6 4/4] rdma: proper getaddrinfo() handling

2013-08-08 Thread Orit Wasserman
); -rdma-ipv6 = addr-ipv6; } else { ERROR(errp, bad RDMA migration address '%s', host_port); g_free(rdma); Looks good, Reviewed-by: Orit Wasserman owass...@redhat.com

[Qemu-devel] [PATCH] Fix query-migrate documentation in qmp-commands.hx

2013-08-08 Thread Orit Wasserman
ram is present also when migration completes. total-time and downtime are no longer part of ram data. Signed-off-by: Orit Wasserman owass...@redhat.com --- qmp-commands.hx | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/qmp-commands.hx b/qmp-commands.hx index

Re: [Qemu-devel] [PATCH] Fix query-migrate documentation in qmp-commands.hx

2013-08-08 Thread Orit Wasserman
On 08/08/2013 05:50 PM, Luiz Capitulino wrote: On Thu, 8 Aug 2013 11:46:14 +0300 Orit Wasserman owass...@redhat.com wrote: ram is present also when migration completes. total-time and downtime are no longer part of ram data. expected-downtime has to be moved too, looks good otherwise. I

[Qemu-devel] [PATCH v2] Fix query-migrate documentation in qmp-commands.hx

2013-08-08 Thread Orit Wasserman
ram is present also when migration completes. expected-downtime, total-time and downtime are no longer part of ram data. Signed-off-by: Orit Wasserman owass...@redhat.com --- qmp-commands.hx | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/qmp

Re: [Qemu-devel] [PATCH 01/39] Move prototypes to memory.h

2013-11-07 Thread Orit Wasserman
, ram_addr_t *ram_addr); +void qemu_ram_set_idstr(ram_addr_t addr, const char *name, DeviceState *dev); #endif #endif Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH 02/39] memory: cpu_physical_memory_set_dirty_flags() result is never used

2013-11-07 Thread Orit Wasserman
cpu_physical_memory_set_dirty(ram_addr_t addr) Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH 03/39] memory: cpu_physical_memory_set_dirty_range() return void

2013-11-07 Thread Orit Wasserman
memory_region_test_and_clear_dirty(MemoryRegion *mr, hwaddr addr, Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH 04/39] exec: use accessor function to know if memory is dirty

2013-11-07 Thread Orit Wasserman
= current_cpu-env_ptr; tlb_set_dirty(env, env-mem_io_vaddr); } Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH 05/39] memory: create function to set a single dirty bit

2013-11-07 Thread Orit Wasserman
) +{ +ram_list.phys_dirty[addr TARGET_PAGE_BITS] |= dirty_flag; +} + static inline void cpu_physical_memory_set_dirty(ram_addr_t addr) { cpu_physical_memory_set_dirty_flags(addr, 0xff); Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH] The calculation of bytes_xfer in qemu_put_buffer() is wrong

2013-11-20 Thread Orit Wasserman
= size; memcpy(f-buf + f-buf_index, buf, l); -f-bytes_xfer += size; +f-bytes_xfer += l; if (f-ops-writev_buffer) { add_to_iovec(f, f-buf + f-buf_index, l); } Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH v8 1/3] Introduce async_run_on_cpu()

2013-07-13 Thread Orit Wasserman
on the vCPU @cpu asynchronously. + */ +void async_run_on_cpu(CPUState *cpu, void (*func)(void *data), void *data); + +/** * qemu_for_each_cpu: * @func: The function to be executed. * @data: Data to pass to the function. Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH v8 2/3] Add 'auto-converge' migration capability

2013-07-13 Thread Orit Wasserman
convergence of RAM migration. (since 1.6) +# # Since: 1.2 ## { 'enum': 'MigrationCapability', - 'data': ['xbzrle'] } + 'data': ['xbzrle', 'auto-converge'] } ## # @MigrationCapabilityStatus Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH v8 3/3] Force auto-convegence of live migration

2013-07-13 Thread Orit Wasserman
; +} + +t1 = qemu_get_clock_ns(rt_clock); + +/* If it has been more than 40 ms since the last time the guest + * was throttled then do it again. + */ +if (40 (t1-t0)/100) { +mig_throttle_guest_down(); +t0 = t1; +} +} Reviewed-by: Orit Wasserman

[Qemu-devel] [PATCH 2/2] Fix real mode guest segments dpl value in savevm

2013-07-22 Thread Orit Wasserman
. Signed-off-by: Orit Wasserman owass...@redhat.com --- target-i386/machine.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/target-i386/machine.c b/target-i386/machine.c index 7e95829..4e39ca9 100644 --- a/target-i386/machine.c +++ b/target-i386/machine.c @@ -252,6 +252,24

[Qemu-devel] [PATCH 1/2] Fix real mode guest migration

2013-07-22 Thread Orit Wasserman
. For example migration from a Penryn host (with kernel 2.6.32) to a Westmere host. Signed-off-by: Orit Wasserman owass...@redhat.com --- target-i386/machine.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/target-i386/machine.c b/target-i386/machine.c index 3659db9..7e95829

Re: [Qemu-devel] [PATCH] migration: send total time in QMP at completed stage

2013-07-22 Thread Orit Wasserman
; info-total_time = s-total_time; info-has_downtime = true; info-downtime = s-downtime; Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH] migration: don't use uninitialized variables

2013-07-22 Thread Orit Wasserman
; -params.blk = blk; -params.shared = inc; +params.blk = has_blk blk; +params.shared = has_inc inc; if (s-state == MIG_STATE_ACTIVE) { error_set(errp, QERR_MIGRATION_ACTIVE); Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH 1/2] Fix real mode guest migration

2013-07-22 Thread Orit Wasserman
On 07/22/2013 12:49 PM, Paolo Bonzini wrote: Il 22/07/2013 08:49, Orit Wasserman ha scritto: Older KVM versions save CS dpl value to an invalid value for real mode guests (0x3). This patch detect this situation when loading CPU state and set all the segments dpl to zero. This will allow

Re: [Qemu-devel] [PATCH 1/2] Fix real mode guest migration

2013-07-22 Thread Orit Wasserman
On 07/22/2013 01:33 PM, Andreas Färber wrote: Am 22.07.2013 11:49, schrieb Paolo Bonzini: Il 22/07/2013 08:49, Orit Wasserman ha scritto: Older KVM versions save CS dpl value to an invalid value for real mode guests (0x3). This patch detect this situation when loading CPU state and set all

[Qemu-devel] [PATCH v2 2/2] Fix real mode guest segments dpl value in savevm

2013-07-22 Thread Orit Wasserman
. Signed-off-by: Orit Wasserman owass...@redhat.com --- target-i386/machine.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/target-i386/machine.c b/target-i386/machine.c index 83ea6ac..c98f1c9 100644 --- a/target-i386/machine.c +++ b/target-i386/machine.c @@ -252,6 +252,24

[Qemu-devel] [PATCH v2 1/2] Fix real mode guest migration

2013-07-22 Thread Orit Wasserman
. For example migration from a Penryn host (with kernel 2.6.32) to a Westmere host (for real mode guest) will fail with kvm: unhandled exit 8021. Signed-off-by: Orit Wasserman owass...@redhat.com --- target-i386/machine.c | 18 ++ 1 file changed, 18 insertions(+) diff --git

[Qemu-devel] [PATCH v3 0/2] Fix real mode guest live migration

2013-07-22 Thread Orit Wasserman
2.6.32) to a Westmere host (for real mode guest) This series fixing it both in the destination and source QEMU. Changes from v2: Fix more typos Changes from v1: Fix typos and style Orit Wasserman (2): Fix real mode guest migration Fix real mode guest segments dpl value in savevm target

[Qemu-devel] [PATCH v3 2/2] Fix real mode guest segments dpl value in savevm

2013-07-22 Thread Orit Wasserman
. Signed-off-by: Orit Wasserman owass...@redhat.com Reviewed-by: Juan Quintela quint...@redhat.com --- target-i386/machine.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/target-i386/machine.c b/target-i386/machine.c index af4c167..f9ec581 100644 --- a/target-i386/machine.c +++ b

[Qemu-devel] [PATCH v3 1/2] Fix real mode guest migration

2013-07-22 Thread Orit Wasserman
. For example migration from a Penryn host (with kernel 2.6.32) to a Westmere host (for real mode guest) will fail with kvm: unhandled exit 8021. Signed-off-by: Orit Wasserman owass...@redhat.com Reviewed-by: Juan Quintela quint...@redhat.com --- target-i386/machine.c | 18 ++ 1

Re: [Qemu-devel] [PATCH 0/9] vmstate code split + unit tests

2013-12-05 Thread Orit Wasserman
create mode 100644 vmstate.c Series Reviewed-by: Orit Wasserman owass...@redhat.com (with v2 of patch 8)

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-18 Thread Orit Wasserman
On 12/18/2013 01:03 AM, Peter Lieven wrote: Am 17.12.2013 um 18:32 schrieb Daniel P. Berrange berra...@redhat.com: On Tue, Dec 17, 2013 at 10:15:25AM +0100, Peter Lieven wrote: This patch adds native support for accessing images on NFS shares without the requirement to actually mount the

Re: [Qemu-devel] [PATCH 07/38] memory: make cpu_physical_memory_is_dirty return bool

2013-12-18 Thread Orit Wasserman
= +cpu_physical_memory_get_dirty_flag(addr, MIGRATION_DIRTY_FLAG); +return vga code migration; } static inline int cpu_physical_memory_get_dirty(ram_addr_t start, Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH 08/38] memory: all users of cpu_physical_memory_get_dirty used only one flag

2013-12-18 Thread Orit Wasserman
; addr end; addr += TARGET_PAGE_SIZE) { -ret |= cpu_physical_memory_get_dirty_flags(addr) dirty_flags; +ret |= cpu_physical_memory_get_dirty_flag(addr, dirty_flag); } return ret; } Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH 09/38] memory: set single dirty flags when possible

2013-12-18 Thread Orit Wasserman
(addr, MIGRATION_DIRTY_FLAG); +cpu_physical_memory_set_dirty_flag(addr, VGA_DIRTY_FLAG); +cpu_physical_memory_set_dirty_flag(addr, CODE_DIRTY_FLAG); } static inline int cpu_physical_memory_clear_dirty_flags(ram_addr_t addr, Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH 10/38] memory: cpu_physical_memory_set_dirty_range() always dirty all flags

2013-12-18 Thread Orit Wasserman
, hwaddr size) { assert(mr-terminates); -cpu_physical_memory_set_dirty_range(mr-ram_addr + addr, size, -1); +cpu_physical_memory_set_dirty_range(mr-ram_addr + addr, size); } bool memory_region_test_and_clear_dirty(MemoryRegion *mr, hwaddr addr, Reviewed-by: Orit Wasserman owass

Re: [Qemu-devel] [PATCH 11/38] memory: cpu_physical_memory_mask_dirty_range() always clears a single flag

2013-12-18 Thread Orit Wasserman
client); +client); } void *memory_region_get_ram_ptr(MemoryRegion *mr) Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH 12/38] memory: use bit 2 for migration

2013-12-18 Thread Orit Wasserman
DIRTY_MEMORY_CODE 1 -#define DIRTY_MEMORY_MIGRATION 3 +#define DIRTY_MEMORY_MIGRATION 2 +#define DIRTY_MEMORY_NUM 3/* num of dirty bits */ struct MemoryRegionMmio { CPUReadMemoryFunc *read[3]; Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH 13/38] memory: make sure that client is always inside range

2013-12-18 Thread Orit Wasserman
); +assert(client DIRTY_MEMORY_NUM); + return ram_list.phys_dirty[addr TARGET_PAGE_BITS] = mask; } Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH 15/38] memory: cpu_physical_memory_clear_dirty_flag() result is never used

2013-12-18 Thread Orit Wasserman
ram_list.phys_dirty[addr TARGET_PAGE_BITS] = mask; +ram_list.phys_dirty[addr TARGET_PAGE_BITS] = mask; } static inline void cpu_physical_memory_set_dirty_range(ram_addr_t start, Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH 14/38] memory: only resize dirty bitmap when memory size increases

2013-12-18 Thread Orit Wasserman
, new_ram_size); +memset(ram_list.phys_dirty + (new_block-offset TARGET_PAGE_BITS), 0, size TARGET_PAGE_BITS); +} cpu_physical_memory_set_dirty_range(new_block-offset, size); qemu_ram_setup_dump(new_block-host, size); Reviewed-by: Orit Wasserman owass

Re: [Qemu-devel] [PATCH 16/38] bitmap: Add bitmap_zero_extend operation

2013-12-18 Thread Orit Wasserman
- old_nbits); +return new; +} + #endif /* BITMAP_H */ Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH 17/38] memory: split dirty bitmap into three

2013-12-18 Thread Orit Wasserman
bits */ - struct MemoryRegionMmio { CPUReadMemoryFunc *read[3]; CPUWriteMemoryFunc *write[3]; Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-18 Thread Orit Wasserman
On 12/18/2013 12:18 PM, Daniel P. Berrange wrote: On Wed, Dec 18, 2013 at 12:00:03PM +0200, Orit Wasserman wrote: On 12/18/2013 01:03 AM, Peter Lieven wrote: Am 17.12.2013 um 18:32 schrieb Daniel P. Berrange berra...@redhat.com: On Tue, Dec 17, 2013 at 10:15:25AM +0100, Peter Lieven wrote

Re: [Qemu-devel] [PATCH 18/38] memory: unfold cpu_physical_memory_clear_dirty_flag() in its only user

2013-12-18 Thread Orit Wasserman
= TARGET_PAGE_ALIGN(start + length); start = TARGET_PAGE_MASK; for (addr = start; addr end; addr += TARGET_PAGE_SIZE) { -cpu_physical_memory_clear_dirty_flag(addr, client); +clear_bit(addr TARGET_PAGE_BITS, ram_list.dirty_memory[client]); } } Reviewed-by: Orit Wasserman owass

Re: [Qemu-devel] [PATCH 19/38] memory: unfold cpu_physical_memory_set_dirty() in its only user

2013-12-18 Thread Orit Wasserman
, DIRTY_MEMORY_CODE); } xen_modified_memory(addr, length); } Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH 20/38] memory: unfold cpu_physical_memory_set_dirty_flag()

2013-12-18 Thread Orit Wasserman
]); } xen_modified_memory(addr, length); } Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH 21/38] memory: make cpu_physical_memory_get_dirty() the main function

2013-12-18 Thread Orit Wasserman
) { Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH 22/38] memory: cpu_physical_memory_get_dirty() is used as returning a bool

2013-12-18 Thread Orit Wasserman
[client])) { +return true; +} } -return ret; +return false; } static inline bool cpu_physical_memory_get_dirty_flag(ram_addr_t addr, Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH 18/38] memory: unfold cpu_physical_memory_clear_dirty_flag() in its only user

2013-12-18 Thread Orit Wasserman
= TARGET_PAGE_ALIGN(start + length); start = TARGET_PAGE_MASK; for (addr = start; addr end; addr += TARGET_PAGE_SIZE) { -cpu_physical_memory_clear_dirty_flag(addr, client); +clear_bit(addr TARGET_PAGE_BITS, ram_list.dirty_memory[client]); } } Reviewed-by: Orit Wasserman owass

Re: [Qemu-devel] [PATCH 23/38] memory: s/mask/clear/ cpu_physical_memory_mask_dirty_range

2013-12-18 Thread Orit Wasserman
, + ram_addr_t length, + unsigned client) { ram_addr_t addr, end; Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-18 Thread Orit Wasserman
On 12/18/2013 01:11 PM, Peter Lieven wrote: Am 18.12.2013 um 11:00 schrieb Orit Wasserman owass...@redhat.com: On 12/18/2013 01:03 AM, Peter Lieven wrote: Am 17.12.2013 um 18:32 schrieb Daniel P. Berrange berra...@redhat.com: On Tue, Dec 17, 2013 at 10:15:25AM +0100, Peter Lieven wrote

Re: [Qemu-devel] [PATCH 24/38] memory: use find_next_bit() to find dirty bits

2013-12-18 Thread Orit Wasserman
; +page = start TARGET_PAGE_BITS; +next = find_next_bit(ram_list.dirty_memory[client], end, page); + +return next end; } static inline bool cpu_physical_memory_get_dirty_flag(ram_addr_t addr, Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH 25/38] memory: cpu_physical_memory_set_dirty_range() now uses bitmap operations

2013-12-18 Thread Orit Wasserman
cpu_physical_memory_clear_dirty_range(ram_addr_t start, Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH 27/38] memory: s/dirty/clean/ in cpu_physical_memory_is_dirty()

2013-12-18 Thread Orit Wasserman
addr, Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH 28/38] memory: make cpu_physical_memory_reset_dirty() take a length parameter

2013-12-18 Thread Orit Wasserman
, -mr-ram_addr + addr + size, -client); +cpu_physical_memory_reset_dirty(mr-ram_addr + addr, size, client); } void *memory_region_get_ram_ptr(MemoryRegion *mr) Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH 29/38] memory: cpu_physical_memory_set_dirty_tracking() should return void

2013-12-18 Thread Orit Wasserman
); +cpu_physical_memory_set_dirty_tracking(true); } static void core_log_global_stop(MemoryListener *listener) { -cpu_physical_memory_set_dirty_tracking(0); +cpu_physical_memory_set_dirty_tracking(false); } static MemoryListener core_memory_listener = { Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH 30/38] memory: split cpu_physical_memory_* functions to its own include

2013-12-18 Thread Orit Wasserman
exec/memory-internal.h +#include exec/ram_addr.h //#define DEBUG_UNASSIGNED Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH 26/38] memory: cpu_physical_memory_clear_dirty_range() now uses bitmap operations

2013-12-18 Thread Orit Wasserman
[client], page, end - page); } void cpu_physical_memory_reset_dirty(ram_addr_t start, ram_addr_t end, Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH 31/38] memory: unfold memory_region_test_and_clear()

2013-12-18 Thread Orit Wasserman
, +TARGET_PAGE_SIZE, +DIRTY_MEMORY_MIGRATION); migration_bitmap_set_dirty(block-mr, addr); } } Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH 00/21][RFC] postcopy live migration

2012-01-01 Thread Orit Wasserman
On 12/30/2011 12:39 AM, Anthony Liguori wrote: On 12/28/2011 07:25 PM, Isaku Yamahata wrote: Intro = This patch series implements postcopy live migration.[1] As discussed at KVM forum 2011, dedicated character device is used for distributed shared memory between migration source and

[Qemu-devel] [PATCH v5 1/9] Add cache handling functions

2012-01-03 Thread Orit Wasserman
Add page caching mechanism. The pages are stored in the cache ordered by their address. Signed-off-by: Orit Wasserman owass...@redhat.com --- arch_init.c | 183 +++ 1 files changed, 183 insertions(+), 0 deletions(-) diff --git

[Qemu-devel] [PATCH v5 4/9] Add host_from_stream_offset_versioned function

2012-01-03 Thread Orit Wasserman
Signed-off-by: Orit Wasserman owass...@redhat.com --- arch_init.c | 35 +-- 1 files changed, 21 insertions(+), 14 deletions(-) diff --git a/arch_init.c b/arch_init.c index e87dfbc..05b8053 100644 --- a/arch_init.c +++ b/arch_init.c @@ -613,6 +613,23 @@ static

[Qemu-devel] [PATCH v5 3/9] Add save_block_hdr function

2012-01-03 Thread Orit Wasserman
Signed-off-by: Orit Wasserman owass...@redhat.com --- arch_init.c | 30 +++--- 1 files changed, 15 insertions(+), 15 deletions(-) diff --git a/arch_init.c b/arch_init.c index 426b34d..e87dfbc 100644 --- a/arch_init.c +++ b/arch_init.c @@ -335,6 +335,17 @@ static void

[Qemu-devel] [PATCH v5 8/9] QMP commands changes

2012-01-03 Thread Orit Wasserman
Signed-off-by: Orit Wasserman owass...@redhat.com --- hmp-commands.hx | 34 ++ qmp-commands.hx | 44 +--- 2 files changed, 63 insertions(+), 15 deletions(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index 14838b7

[Qemu-devel] [PATCH v5 0/9] XBZRLE delta for live migration of large memory apps

2012-01-03 Thread Orit Wasserman
Changes from v4: 1) Rebase 2) divide patch into 9 patches 3) move memory allocation into cache_insert By using XBZRLE (Xor Binary Zero Run-Length-Encoding) we can reduce VM downtime and total live-migration time of VMs running memory write intensive workloads typical of large enterprise

[Qemu-devel] [PATCH v5 5/9] Add XBRLE to ram_save_block and ram_save_live

2012-01-03 Thread Orit Wasserman
function). Signed-off-by: Orit Wasserman owass...@redhat.com --- arch_init.c | 173 +++ 1 files changed, 163 insertions(+), 10 deletions(-) diff --git a/arch_init.c b/arch_init.c index 05b8053..6b839a1 100644 --- a/arch_init.c +++ b/arch_init.c

Re: [Qemu-devel] [PATCH v5 8/9] QMP commands changes

2012-01-03 Thread Orit Wasserman
On 01/03/2012 05:47 PM, Stefan Hajnoczi wrote: On Tue, Jan 3, 2012 at 3:34 PM, Orit Wasserman owass...@redhat.com wrote: +.args_type = detach:-d,blk:-b,inc:-i,xbrle:-x,uri:s, +.params = [-d] [-b] [-i] [-x] uri, +.help = migrate to URI

[Qemu-devel] [PATCH v5 6/9] Add xbrle parameters to MigrationState

2012-01-03 Thread Orit Wasserman
Signed-off-by: Orit Wasserman owass...@redhat.com --- block-migration.c |4 +++- hw/hw.h |4 +++- migration.c | 15 +-- migration.h |3 +++ savevm.c | 11 +++ sysemu.h |4 +++- 6 files changed, 32 insertions(+), 9

[Qemu-devel] [PATCH v5 7/9] Add set_cachesize to change XBRLE cache size

2012-01-03 Thread Orit Wasserman
Signed-off-by: Orit Wasserman owass...@redhat.com --- migration.c | 25 - migration.h |7 +++ 2 files changed, 31 insertions(+), 1 deletions(-) diff --git a/migration.c b/migration.c index ed47958..3d88cdd 100644 --- a/migration.c +++ b/migration.c @@ -380,7

[Qemu-devel] [PATCH v5 2/9] Add rle_encode and rle_decode functions Implement Run Length Encoding compression

2012-01-03 Thread Orit Wasserman
Signed-off-by: Orit Wasserman owass...@redhat.com --- arch_init.c | 58 ++ 1 files changed, 58 insertions(+), 0 deletions(-) diff --git a/arch_init.c b/arch_init.c index fdda277..426b34d 100644 --- a/arch_init.c +++ b/arch_init.c

[Qemu-devel] [PATCH v5 9/9] Add XBRLE statistics information

2012-01-03 Thread Orit Wasserman
Signed-off-by: Orit Wasserman owass...@redhat.com --- arch_init.c | 67 +++ migration.c | 11 + migration.h |9 3 files changed, 87 insertions(+), 0 deletions(-) diff --git a/arch_init.c b/arch_init.c index 6b839a1

Re: [Qemu-devel] [PATCH v5 0/9] XBZRLE delta for live migration of large memory apps

2012-01-03 Thread Orit Wasserman
On 01/03/2012 06:32 PM, Anthony Liguori wrote: On 01/03/2012 09:34 AM, Orit Wasserman wrote: Changes from v4: 1) Rebase 2) divide patch into 9 patches 3) move memory allocation into cache_insert By using XBZRLE (Xor Binary Zero Run-Length-Encoding) we can reduce VM downtime and total

[Qemu-devel] [PATCH v5 7/9] Add set_cachesize to change XBRLE cache size

2012-01-03 Thread Orit Wasserman
Signed-off-by: Orit Wasserman owass...@redhat.com --- migration.c | 25 - migration.h |7 +++ 2 files changed, 31 insertions(+), 1 deletions(-) diff --git a/migration.c b/migration.c index ed47958..3d88cdd 100644 --- a/migration.c +++ b/migration.c @@ -380,7

[Qemu-devel] [PATCH v5 1/9] Add cache handling functions

2012-01-03 Thread Orit Wasserman
Add page caching mechanism. The pages are stored in the cache ordered by their address. Signed-off-by: Orit Wasserman owass...@redhat.com --- arch_init.c | 183 +++ 1 files changed, 183 insertions(+), 0 deletions(-) diff --git

[Qemu-devel] [PATCH v5 4/9] Add host_from_stream_offset_versioned function

2012-01-03 Thread Orit Wasserman
Signed-off-by: Orit Wasserman owass...@redhat.com --- arch_init.c | 35 +-- 1 files changed, 21 insertions(+), 14 deletions(-) diff --git a/arch_init.c b/arch_init.c index e87dfbc..05b8053 100644 --- a/arch_init.c +++ b/arch_init.c @@ -613,6 +613,23 @@ static

[Qemu-devel] [PATCH v5 3/9] Add save_block_hdr function

2012-01-03 Thread Orit Wasserman
Signed-off-by: Orit Wasserman owass...@redhat.com --- arch_init.c | 30 +++--- 1 files changed, 15 insertions(+), 15 deletions(-) diff --git a/arch_init.c b/arch_init.c index 426b34d..e87dfbc 100644 --- a/arch_init.c +++ b/arch_init.c @@ -335,6 +335,17 @@ static void

[Qemu-devel] [PATCH v5 6/9] Add xbrle parameters to MigrationState

2012-01-03 Thread Orit Wasserman
Signed-off-by: Orit Wasserman owass...@redhat.com --- block-migration.c |4 +++- hw/hw.h |4 +++- migration.c | 15 +-- migration.h |3 +++ savevm.c | 11 +++ sysemu.h |4 +++- 6 files changed, 32 insertions(+), 9

[Qemu-devel] [PATCH v5 9/9] Add XBRLE statistics information

2012-01-03 Thread Orit Wasserman
Signed-off-by: Orit Wasserman owass...@redhat.com --- arch_init.c | 67 +++ migration.c | 11 + migration.h |9 3 files changed, 87 insertions(+), 0 deletions(-) diff --git a/arch_init.c b/arch_init.c index 6b839a1

[Qemu-devel] [PATCH v5 5/9] Add XBRLE to ram_save_block and ram_save_live

2012-01-03 Thread Orit Wasserman
function). Signed-off-by: Orit Wasserman owass...@redhat.com --- arch_init.c | 173 +++ 1 files changed, 163 insertions(+), 10 deletions(-) diff --git a/arch_init.c b/arch_init.c index 05b8053..6b839a1 100644 --- a/arch_init.c +++ b/arch_init.c

[Qemu-devel] [PATCH v5 2/9] Add rle_encode and rle_decode functions Implement Run Length Encoding compression

2012-01-03 Thread Orit Wasserman
Signed-off-by: Orit Wasserman owass...@redhat.com --- arch_init.c | 58 ++ 1 files changed, 58 insertions(+), 0 deletions(-) diff --git a/arch_init.c b/arch_init.c index fdda277..426b34d 100644 --- a/arch_init.c +++ b/arch_init.c

[Qemu-devel] [PATCH v5 0/9] XBZRLE delta for live migration of large memory apps

2012-01-03 Thread Orit Wasserman
Changes from v4: 1) Rebase 2) divide patch into 9 patches 3) move memory allocation into cache_insert By using XBZRLE (Xor Binary Zero Run-Length-Encoding) we can reduce VM downtime and total live-migration time of VMs running memory write intensive workloads typical of large enterprise

[Qemu-devel] [PATCH v5 8/9] QMP commands changes

2012-01-03 Thread Orit Wasserman
Signed-off-by: Orit Wasserman owass...@redhat.com --- hmp-commands.hx | 34 ++ qmp-commands.hx | 44 +--- 2 files changed, 63 insertions(+), 15 deletions(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index 14838b7

Re: [Qemu-devel] [PATCH v5 1/9] Add cache handling functions

2012-01-04 Thread Orit Wasserman
On 01/03/2012 09:54 PM, Anthony Liguori wrote: On 01/03/2012 09:34 AM, Orit Wasserman wrote: Add page caching mechanism. The pages are stored in the cache ordered by their address. Signed-off-by: Orit Wassermanowass...@redhat.com --- arch_init.c | 183

Re: [Qemu-devel] [PATCH v5 2/9] Add rle_encode and rle_decode functions Implement Run Length Encoding compression

2012-01-04 Thread Orit Wasserman
On 01/03/2012 09:57 PM, Anthony Liguori wrote: On 01/03/2012 09:34 AM, Orit Wasserman wrote: Signed-off-by: Orit Wassermanowass...@redhat.com --- arch_init.c | 58 ++ 1 files changed, 58 insertions(+), 0 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v5 1/9] Add cache handling functions

2012-01-04 Thread Orit Wasserman
On 01/04/2012 01:46 PM, Stefan Hajnoczi wrote: On Tue, Jan 3, 2012 at 3:34 PM, Orit Wasserman owass...@redhat.com wrote: +static unsigned long cache_get_cache_pos(ram_addr_t address) +{ +unsigned long pos; + +assert(cache_num_buckets); +pos = (address/TARGET_PAGE_SIZE

Re: [Qemu-devel] [PATCH v5 5/9] Add XBRLE to ram_save_block and ram_save_live

2012-01-04 Thread Orit Wasserman
On 01/04/2012 02:14 PM, Stefan Hajnoczi wrote: On Tue, Jan 3, 2012 at 3:34 PM, Orit Wasserman owass...@redhat.com wrote: +/* XOR encoding */ +xor_buf = (uint8_t *) g_malloc0(TARGET_PAGE_SIZE); Is this an old version of the code? I remember pointing out all the useless zeroing

Re: [Qemu-devel] [PATCH v5 0/9] XBZRLE delta for live migration of large memory apps

2012-01-04 Thread Orit Wasserman
On 01/04/2012 03:02 PM, Avi Kivity wrote: On 01/03/2012 05:34 PM, Orit Wasserman wrote: Signed-off-by: Benoit Hudzia benoit.hud...@sap.com Signed-off-by: Petter Svard pett...@cs.umu.se Signed-off-by: Aidan Shribman aidan.shrib...@sap.com Looks like the original authorship (From

Re: [Qemu-devel] [PATCH] iSCSI: add configuration variables for iSCSI

2011-11-27 Thread Orit Wasserman
On 11/27/2011 01:24 AM, Ronnie Sahlberg wrote: This patch adds configuration variables for iSCSI to set initiator-name to use when logging in to the target, which type of header-digest to negotiate with the target and username and password for CHAP authentication. This allows specifying a

[Qemu-devel] Problem editing wiki page in wiki.qemu.org

2011-12-18 Thread Orit Wasserman
include all above details in any queries you make. Any idea how to solve it ? Regards, Orit Wasserman

Re: [Qemu-devel] [PATCH] Add iSCSI support for QEMU

2011-09-14 Thread Orit Wasserman
Looks quite good, didn't have any more comments. We can use it for streaming with non shared storage with minor changes (http://wiki.qemu.org/Features/LiveBlockMigration#ISCSI_for_non_shared_storage) Ronnie , are you looking into ISCSI target too? Orit On Mon, 2011-09-12 at 10:56 +0200, Kevin

Re: [Qemu-devel] [PATCH] Add iSCSI support for QEMU

2011-09-14 Thread Orit Wasserman
On Wed, 2011-09-14 at 16:51 +0100, Stefan Hajnoczi wrote: On Wed, Sep 14, 2011 at 4:40 PM, Christoph Hellwig h...@lst.de wrote: On Wed, Sep 14, 2011 at 04:35:50PM +0100, Stefan Hajnoczi wrote: I think the motivation for iSCSI target support in QEMU is exactly what you mentioned - providing

  1   2   3   4   5   6   7   8   >