RFC: Start-time Device Addition for BMC devices

2020-12-28 Thread Patrick Venture
Hi; Currently, devices for a BMC are specified in the board init method for that machine, see: - https://github.com/qemu/qemu/blob/b785d25e91718a660546a6550f64b3c543af7754/hw/arm/aspeed.c#L414 This requires listing all i2c devices, and setting some properties. QMP can be used to set the

[PATCH 2/2] docs/system/arm: Add quanta-gbs-bmc reference

2021-06-15 Thread Patrick Venture
Add line item reference to quanta-gbs-bmc machine. Signed-off-by: Patrick Venture --- docs/system/arm/nuvoton.rst | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/system/arm/nuvoton.rst b/docs/system/arm/nuvoton.rst index ca011bd479..197d149f66 100644 --- a/docs/system

[PATCH 0/2] Updates docs/system/arm to include new bmc machines

2021-06-15 Thread Patrick Venture
Patrick Venture (2): docs/system/arm: Add quanta-q7l1-bmc reference docs/system/arm: Add quanta-gbs-bmc reference docs/system/arm/aspeed.rst | 1 + docs/system/arm/nuvoton.rst | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) -- 2.32.0.272.g935e593368-goog

[PATCH 1/2] docs/system/arm: Add quanta-q7l1-bmc reference

2021-06-15 Thread Patrick Venture
Adds a line-item reference to the supported quanta-q71l-bmc aspeed entry. Signed-off-by: Patrick Venture --- docs/system/arm/aspeed.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/system/arm/aspeed.rst b/docs/system/arm/aspeed.rst index 57ee2bd94f..cec87e3743 100644 --- a/docs

Re: [PATCH 4/4] aspeed: sonorapass: enable pca954x muxes

2021-06-08 Thread Patrick Venture
On Wed, May 19, 2021 at 10:18 AM Patrick Venture wrote: > > On Tue, May 18, 2021 at 4:27 PM Joel Stanley wrote: > > > > On Tue, 18 May 2021 at 19:41, Patrick Venture wrote: > > > > > > Enables the pca954x muxes in the bmc board configuration. > &

[PATCH v2 2/2] hw/arm: quanta-gbs-bmc add i2c comments

2021-06-08 Thread Patrick Venture
Add a comment and i2c method that describes the board layout. Tested: firmware booted to userspace. Signed-off-by: Patrick Venture Reviewed-by: Brandon Kim Reviewed-by: Hao Wu --- hw/arm/npcm7xx_boards.c | 60 + 1 file changed, 60 insertions(+) diff

[PATCH v2 1/2] hw/arm: add quanta-gbs-bmc machine

2021-06-08 Thread Patrick Venture
Adds initial quanta-gbs-bmc machine support. Tested: Boots to userspace. Signed-off-by: Patrick Venture Reviewed-by: Brandon Kim Reviewed-by: Hao Wu --- hw/arm/npcm7xx_boards.c | 33 + 1 file changed, 33 insertions(+) diff --git a/hw/arm/npcm7xx_boards.c b/hw

[PATCH v2 0/2] Adds quanta-gbs-bmc machine to nuvoton boards.

2021-06-08 Thread Patrick Venture
This is a board supported by OpenBmc. v2: - Fixed missing hyphen in Cortex name and dropped TODO on hardware strap value. Patrick Venture (2): hw/arm: add quanta-gbs-bmc machine hw/arm: quanta-gbs-bmc add i2c comments hw/arm/npcm7xx_boards.c | 93

[PATCH v2 0/3] With the pca954x i2c mux available, enable it on aspeed and nuvoton BMC boards.

2021-06-08 Thread Patrick Venture
v2: - Dropped sonorapass patch. Patrick Venture (3): hw/arm: gsj add i2c comments hw/arm: gsj add pca9548 hw/arm: quanta-q71l add pca954x muxes hw/arm/Kconfig | 2 ++ hw/arm/aspeed.c | 11 --- hw/arm/npcm7xx_boards.c | 14 +- 3 files changed, 23

[PATCH v2 2/3] hw/arm: gsj add pca9548

2021-06-08 Thread Patrick Venture
i2c-15: Added multiplexed i2c bus 20 i2c i2c-15: Added multiplexed i2c bus 21 i2c i2c-15: Added multiplexed i2c bus 22 i2c i2c-15: Added multiplexed i2c bus 23 pca954x 15-0075: registered 8 multiplexed busses for I2C switch pca9548 Signed-off-by: Patrick Venture Reviewed-by: Hao Wu Reviewed

[PATCH v2 3/3] hw/arm: quanta-q71l add pca954x muxes

2021-06-08 Thread Patrick Venture
Adds the pca954x muxes expected. Tested: Booted quanta-q71l image to userspace. Signed-off-by: Patrick Venture Reviewed-by: Hao Wu Reviewed-by: Joel Stanley --- hw/arm/Kconfig | 1 + hw/arm/aspeed.c | 11 --- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/hw/arm

[PATCH v2 1/3] hw/arm: gsj add i2c comments

2021-06-08 Thread Patrick Venture
Adds comments to the board init to identify missing i2c devices. Signed-off-by: Patrick Venture Reviewed-by: Hao Wu Reviewed-by: Joel Stanley --- hw/arm/npcm7xx_boards.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/hw/arm/npcm7xx_boards.c b/hw/arm

Re: [PATCH v2 0/2] Adds quanta-gbs-bmc machine to nuvoton boards.

2021-06-15 Thread Patrick Venture
On Tue, Jun 15, 2021 at 8:46 AM Peter Maydell wrote: > > On Tue, 8 Jun 2021 at 20:36, Patrick Venture wrote: > > > > This is a board supported by OpenBmc. > > > > v2: > > - Fixed missing hyphen in Cortex name and dropped TODO on hardware > > strap value.

[PATCH 3/4] hw/arm: quanta-q71l add pca954x muxes

2021-05-18 Thread Patrick Venture
Adds the pca954x muxes expected. Tested: Booted quanta-q71l image to userspace. Signed-off-by: Patrick Venture Reviewed-by: Hao Wu --- hw/arm/Kconfig | 1 + hw/arm/aspeed.c | 11 --- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig index

[PATCH 1/4] hw/arm: gsj add i2c comments

2021-05-18 Thread Patrick Venture
Adds comments to the board init to identify missing i2c devices. Signed-off-by: Patrick Venture Reviewed-by: Hao Wu --- hw/arm/npcm7xx_boards.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/hw/arm/npcm7xx_boards.c b/hw/arm/npcm7xx_boards.c index

[PATCH 2/4] hw/arm: gsj add pca9548

2021-05-18 Thread Patrick Venture
i2c-15: Added multiplexed i2c bus 20 i2c i2c-15: Added multiplexed i2c bus 21 i2c i2c-15: Added multiplexed i2c bus 22 i2c i2c-15: Added multiplexed i2c bus 23 pca954x 15-0075: registered 8 multiplexed busses for I2C switch pca9548 Signed-off-by: Patrick Venture Reviewed-by: Hao Wu --- hw/arm

[PATCH 0/2] Adds quanta-gbs-bmc machine to nuvoton boards.

2021-05-18 Thread Patrick Venture
This is a board supported by OpenBmc. Patrick Venture (2): hw/arm: add quanta-gbs-bmc machine hw/arm: quanta-gbs-bmc add i2c comments hw/arm/npcm7xx_boards.c | 93 + 1 file changed, 93 insertions(+) -- 2.31.1.751.gd2f1c929bd-goog

[PATCH 0/4] With the pca954x i2c mux available, enable it on aspeed and nuvoton BMC boards.

2021-05-18 Thread Patrick Venture
Patrick Venture (4): hw/arm: gsj add i2c comments hw/arm: gsj add pca9548 hw/arm: quanta-q71l add pca954x muxes aspeed: sonorapass: enable pca954x muxes hw/arm/Kconfig | 2 ++ hw/arm/aspeed.c | 33 +++-- hw/arm/npcm7xx_boards.c | 14

[PATCH 4/4] aspeed: sonorapass: enable pca954x muxes

2021-05-18 Thread Patrick Venture
Enables the pca954x muxes in the bmc board configuration. Signed-off-by: Patrick Venture Reviewed-by: Hao Wu --- hw/arm/aspeed.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c index 35a28b0e8b..27fd51980c 100644

[PATCH 2/2] hw/arm: quanta-gbs-bmc add i2c comments

2021-05-18 Thread Patrick Venture
Add a comment and i2c method that describes the board layout. Tested: firmware booted to userspace. Signed-off-by: Patrick Venture Reviewed-by: Brandon Kim Reviewed-by: Hao Wu --- hw/arm/npcm7xx_boards.c | 60 + 1 file changed, 60 insertions(+) diff

[PATCH 1/2] hw/arm: add quanta-gbs-bmc machine

2021-05-18 Thread Patrick Venture
Adds initial quanta-gbs-bmc machine support. Tested: Boots to userspace. Signed-off-by: Patrick Venture Reviewed-by: Brandon Kim Reviewed-by: Hao Wu --- hw/arm/npcm7xx_boards.c | 33 + 1 file changed, 33 insertions(+) diff --git a/hw/arm/npcm7xx_boards.c b/hw

Re: [PATCH 1/2] hw/arm: add quanta-gbs-bmc machine

2021-06-02 Thread Patrick Venture
On Thu, May 27, 2021 at 2:34 AM Peter Maydell wrote: > > On Tue, 18 May 2021 at 20:54, Patrick Venture wrote: > > > > Adds initial quanta-gbs-bmc machine support. > > > > Tested: Boots to userspace. > > Signed-off-by: Patrick Venture > > Reviewe

Re: [PATCH 4/4] aspeed: sonorapass: enable pca954x muxes

2021-05-19 Thread Patrick Venture
On Tue, May 18, 2021 at 4:27 PM Joel Stanley wrote: > > On Tue, 18 May 2021 at 19:41, Patrick Venture wrote: > > > > Enables the pca954x muxes in the bmc board configuration. > > > > Signed-off-by: Patrick Venture > > Reviewed-by: Hao Wu > > Not s

Re: [PATCH 0/2] hw/i2c: Adds pca954x i2c mux switch device

2021-04-06 Thread Patrick Venture
On Tue, Apr 6, 2021 at 11:36 AM Corey Minyard wrote: > > On Tue, Apr 06, 2021 at 08:55:14AM -0700, Patrick Venture wrote: > > On Tue, Apr 6, 2021 at 8:41 AM Patrick Venture wrote: > > > > > > On Mon, Apr 5, 2021 at 12:58 PM Corey Minyard wrote: > > > >

[PATCH 2/2] hw/i2c: add pca954x i2c-mux switch

2021-04-03 Thread Patrick Venture
The pca954x is an i2c mux, and this adds support for two variants of this device: the pca9546 and pca9548. This device is very common on BMCs to route a different channel to each PCIe i2c bus downstream from the BMC. Signed-off-by: Patrick Venture Reviewed-by: Havard Skinnemoen Reviewed

[PATCH 1/2] hw/i2c/core: add reachable state boolean

2021-04-03 Thread Patrick Venture
An i2c device can be reachable or not, controlled by some external factor. This field is leveraged by an i2c mux which presents the devices on the parent bus when the associated channel is enabled and otherwise not. Signed-off-by: Patrick Venture Reviewed-by: Havard Skinnemoen Reviewed-by: Hao

[PATCH 0/2] hw/i2c: Adds pca954x i2c mux switch device

2021-04-03 Thread Patrick Venture
The i2c mux device pca954x implements two devices: - the pca9546 and pca9548. Patrick Venture (2): hw/i2c/core: add reachable state boolean hw/i2c: add pca954x i2c-mux switch MAINTAINERS | 6 + hw/i2c/Kconfig | 4 + hw/i2c/core.c

Re: IPMI Smbus

2021-04-06 Thread Patrick Venture
On Tue, Apr 6, 2021 at 9:54 AM Corey Minyard wrote: > > On Tue, Apr 06, 2021 at 09:04:35AM -0700, Patrick Venture wrote: > > Corey; > > > > I saw you have a branch that is working on adding smbus IPMI support > > (the ssif approach). > > > > Can you

Re: [PATCH 0/2] hw/i2c: Adds pca954x i2c mux switch device

2021-04-06 Thread Patrick Venture
On Mon, Apr 5, 2021 at 12:58 PM Corey Minyard wrote: > > On Sat, Apr 03, 2021 at 03:28:08PM -0700, Patrick Venture wrote: > > The i2c mux device pca954x implements two devices: > > - the pca9546 and pca9548. > > > > Patrick Venture (2): > > hw/i2c/core: add

Re: [PATCH 0/2] hw/i2c: Adds pca954x i2c mux switch device

2021-04-06 Thread Patrick Venture
On Tue, Apr 6, 2021 at 8:41 AM Patrick Venture wrote: > > On Mon, Apr 5, 2021 at 12:58 PM Corey Minyard wrote: > > > > On Sat, Apr 03, 2021 at 03:28:08PM -0700, Patrick Venture wrote: > > > The i2c mux device pca954x implements two devices: > > > - the pca9

IPMI Smbus

2021-04-06 Thread Patrick Venture
Corey; I saw you have a branch that is working on adding smbus IPMI support (the ssif approach). Can you provide details on the status of this work? Patrick

Re: [PATCH 0/2] hw/i2c: Adds pca954x i2c mux switch device

2021-04-07 Thread Patrick Venture
On Tue, Apr 6, 2021 at 4:39 PM Corey Minyard wrote: > > On Tue, Apr 06, 2021 at 03:21:18PM -0700, Patrick Venture wrote: > > On Tue, Apr 6, 2021 at 11:36 AM Corey Minyard wrote: > > > > > > On Tue, Apr 06, 2021 at 08:55:14AM -0700, Patrick Venture wrote: > >

Re: [PATCH v4 0/4] hw/i2c: Adds pca954x i2c mux switch device

2021-04-15 Thread Patrick Venture
On Thu, Apr 15, 2021 at 5:13 AM Corey Minyard wrote: > > On Mon, Apr 12, 2021 at 12:45:18PM -0700, Patrick Venture wrote: > > The i2c mux device pca954x implements two devices: > > - the pca9546 and pca9548. > > This looks good, I have pulled it into my queue. 6.0 i

Re: [PATCH v2 4/4] hw/i2c: add pca954x i2c-mux switch

2021-04-09 Thread Patrick Venture
On Fri, Apr 9, 2021 at 2:20 PM Philippe Mathieu-Daudé wrote: > > +Paolo/Thomas > > On 4/9/21 7:21 PM, Patrick Venture wrote: > > On Fri, Apr 9, 2021 at 9:51 AM Philippe Mathieu-Daudé > > wrote: > >> > >> Hi Patrick, > >> > >> On 4/9/21

[PATCH v4 4/4] hw/i2c: add pca954x i2c-mux switch

2021-04-12 Thread Patrick Venture
The pca954x is an i2c mux, and this adds support for two variants of this device: the pca9546 and pca9548. This device is very common on BMCs to route a different channel to each PCIe i2c bus downstream from the BMC. Signed-off-by: Patrick Venture Reviewed-by: Hao Wu Reviewed-by: Havard

[PATCH v4 1/4] hw/i2c: name I2CNode list in I2CBus

2021-04-12 Thread Patrick Venture
To enable passing the current_devs field as a parameter, we need to use a named struct type. Tested: BMC firmware with i2c devices booted to userspace. Signed-off-by: Patrick Venture Reviewed-by: Hao Wu Reviewed-by: Philippe Mathieu-Daudé --- include/hw/i2c/i2c.h | 4 +++- 1 file changed, 3

[PATCH v4 0/4] hw/i2c: Adds pca954x i2c mux switch device

2021-04-12 Thread Patrick Venture
an i2c bus for each channel, allowing the normal device model to attach devices to the channels. Patrick Venture (4): hw/i2c: name I2CNode list in I2CBus hw/i2c: add match method for device search hw/i2c: move search to i2c_scan_bus method hw/i2c: add pca954x i2c-mux switch MAINTAINERS

[PATCH v4 3/4] hw/i2c: move search to i2c_scan_bus method

2021-04-12 Thread Patrick Venture
Moves the search for matching devices on an i2c bus into a separate method. This allows for an object that owns an I2CBus can avoid duplicating this method. Tested: A BMC firmware was booted to userspace and i2c devices were detected. Signed-off-by: Patrick Venture Reviewed-by: Hao Wu --- hw

[PATCH v4 2/4] hw/i2c: add match method for device search

2021-04-12 Thread Patrick Venture
rt devices, such as i2c muxes. Tested: A BMC firmware was booted to userspace and i2c devices were detected. Signed-off-by: Patrick Venture Reviewed-by: Hao Wu --- hw/i2c/core.c| 23 +++ include/hw/i2c/i2c.h | 11 +++ 2 files changed, 30 insertions(+), 4 deletions(-)

RFC: Adding new system, quanta-q71l

2021-04-13 Thread Patrick Venture
HI; My team is actively engaged now in producing Qemu support for new devices and boards, and I previously worked on the quanta-q71l board for OpenBmc. I'm currently fixing up the configuration to build again, and I'd like to introduce a board for it in Aspeed. The palmetto doesn't really

[PATCH] aspeed: Add support for the quanta-q7l1-bmc board

2021-04-16 Thread Patrick Venture
The Quanta-Q71l BMC board is a board supported by OpenBMC. Tested: Booted quanta-q71l firmware. Signed-off-by: Patrick Venture Reviewed-by: Hao Wu --- hw/arm/aspeed.c | 62 + 1 file changed, 62 insertions(+) diff --git a/hw/arm/aspeed.c b/hw/arm

Re: [PATCH] aspeed: Add support for the quanta-q7l1-bmc board

2021-04-16 Thread Patrick Venture
On Fri, Apr 16, 2021 at 9:40 AM Cédric Le Goater wrote: > > Patrick, > > On 4/16/21 6:24 PM, Patrick Venture wrote: > > The Quanta-Q71l BMC board is a board supported by OpenBMC. > > > > Tested: Booted quanta-q71l firmware. > > Signed-off-by: Patr

[PATCH v2 0/4] hw/i2c: Adds pca954x i2c mux switch device

2021-04-09 Thread Patrick Venture
for each of its buses that are active. - the pca954x device now owns an i2c bus for each channel, allowing the normal device model to attach devices to the channels. Patrick Venture (4): hw/i2c: name I2CNode list in I2CBus hw/i2c: add match method for device search hw/i2c: move search

[PATCH v2 3/4] hw/i2c: move search to i2c_scan_bus method

2021-04-09 Thread Patrick Venture
Moves the search for matching devices on an i2c bus into a separate method. This allows for an object that owns an I2CBus can avoid duplicating this method. Tested: A BMC firmware was booted to userspace and i2c devices were detected. Signed-off-by: Patrick Venture Reviewed-by: Hao Wu --- hw

[PATCH v2 2/4] hw/i2c: add match method for device search

2021-04-09 Thread Patrick Venture
rt devices, such as i2c muxes. Tested: A BMC firmware was booted to userspace and i2c devices were detected. Signed-off-by: Patrick Venture Reviewed-by: Hao Wu --- hw/i2c/core.c| 23 +++ include/hw/i2c/i2c.h | 11 +++ 2 files changed, 30 insertions(+), 4 deletions(-)

[PATCH v2 4/4] hw/i2c: add pca954x i2c-mux switch

2021-04-09 Thread Patrick Venture
The pca954x is an i2c mux, and this adds support for two variants of this device: the pca9546 and pca9548. This device is very common on BMCs to route a different channel to each PCIe i2c bus downstream from the BMC. Signed-off-by: Patrick Venture Reviewed-by: Hao Wu Reviewed-by: Havard

[PATCH v2 1/4] hw/i2c: name I2CNode list in I2CBus

2021-04-09 Thread Patrick Venture
To enable passing the current_devs field as a parameter, we need to use a named struct type. Tested: BMC firmware with i2c devices booted to userspace. Signed-off-by: Patrick Venture Reviewed-by: Hao Wu --- include/hw/i2c/i2c.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff

Re: [PATCH v2 4/4] hw/i2c: add pca954x i2c-mux switch

2021-04-09 Thread Patrick Venture
On Fri, Apr 9, 2021 at 9:51 AM Philippe Mathieu-Daudé wrote: > > Hi Patrick, > > On 4/9/21 6:25 PM, Patrick Venture wrote: > > The pca954x is an i2c mux, and this adds support for two variants of > > this device: the pca9546 and pca9548. > > > > This de

Re: [PATCH v2 0/4] hw/i2c: Adds pca954x i2c mux switch device

2021-04-09 Thread Patrick Venture
On Fri, Apr 9, 2021 at 11:31 AM Corey Minyard wrote: > > On Fri, Apr 09, 2021 at 09:25:41AM -0700, Patrick Venture wrote: > > The i2c mux device pca954x implements two devices: > > - the pca9546 and pca9548. > > > > v2: > > - the core i2c bus now calls a m

Re: [PATCH v2 4/4] hw/i2c: add pca954x i2c-mux switch

2021-04-09 Thread Patrick Venture
On Fri, Apr 9, 2021 at 11:34 AM Corey Minyard wrote: > > On Fri, Apr 09, 2021 at 09:25:45AM -0700, Patrick Venture wrote: > > The pca954x is an i2c mux, and this adds support for two variants of > > this device: the pca9546 and pca9548. > > > > This device i

[PATCH v3 2/4] hw/i2c: add match method for device search

2021-04-09 Thread Patrick Venture
rt devices, such as i2c muxes. Tested: A BMC firmware was booted to userspace and i2c devices were detected. Signed-off-by: Patrick Venture Reviewed-by: Hao Wu --- hw/i2c/core.c| 23 +++ include/hw/i2c/i2c.h | 11 +++ 2 files changed, 30 insertions(+), 4 deletions(-)

[PATCH v3 1/4] hw/i2c: name I2CNode list in I2CBus

2021-04-09 Thread Patrick Venture
To enable passing the current_devs field as a parameter, we need to use a named struct type. Tested: BMC firmware with i2c devices booted to userspace. Signed-off-by: Patrick Venture Reviewed-by: Hao Wu Reviewed-by: Philippe Mathieu-Daudé --- include/hw/i2c/i2c.h | 4 +++- 1 file changed, 3

[PATCH v3 3/4] hw/i2c: move search to i2c_scan_bus method

2021-04-09 Thread Patrick Venture
Moves the search for matching devices on an i2c bus into a separate method. This allows for an object that owns an I2CBus can avoid duplicating this method. Tested: A BMC firmware was booted to userspace and i2c devices were detected. Signed-off-by: Patrick Venture Reviewed-by: Hao Wu --- hw

[PATCH v3 0/4] hw/i2c: Adds pca954x i2c mux switch device

2021-04-09 Thread Patrick Venture
. - the pca954x device overrides the i2c device match method to search the children for each of its buses that are active. - the pca954x device now owns an i2c bus for each channel, allowing the normal device model to attach devices to the channels. Patrick Venture (4): hw/i2c: name I2CNode

[PATCH v3 4/4] hw/i2c: add pca954x i2c-mux switch

2021-04-09 Thread Patrick Venture
The pca954x is an i2c mux, and this adds support for two variants of this device: the pca9546 and pca9548. This device is very common on BMCs to route a different channel to each PCIe i2c bus downstream from the BMC. Signed-off-by: Patrick Venture Reviewed-by: Hao Wu Reviewed-by: Havard

Re: [PATCH] hw/arm: Add support for kudo-bmc board.

2021-09-02 Thread Patrick Venture
On Thu, Sep 2, 2021 at 12:01 PM Chris Rauer wrote: > kudo-bmc is a board supported by OpenBMC. > https://github.com/openbmc/openbmc/tree/master/meta-fii/meta-kudo > > Tested: Booted kudo firmware. > Signed-off-by: Chris Rauer > Reviewed-by: Patrick Venture > --- > doc

Re: [PATCH] net: Add "info neighbors" command

2021-09-02 Thread Patrick Venture
On Thu, Sep 2, 2021 at 2:21 PM Doug Evans wrote: > This command dumps the ARP and NDP tables maintained within slirp. > One use-case for it is showing the guest's IPv6 address(es). > > Signed-off-by: Doug Evans > Reviewed-by: Patrick Venture > --- > hmp-commands-info.

Re: [PATCH v2] hw/arm: Add support for kudo-bmc board.

2021-09-09 Thread Patrick Venture
On Tue, Sep 7, 2021 at 3:35 PM Chris Rauer wrote: > kudo-bmc is a board supported by OpenBMC. > https://github.com/openbmc/openbmc/tree/master/meta-fii/meta-kudo > > Since v1: > - hyphenated Cortex-A9 > > Tested: Booted kudo firmware. > Signed-off-by: Chris Rauer > R

[PATCH v2] hw/net: npcm7xx_emc fix missing queue_flush

2021-12-03 Thread Patrick Venture
The rx_active boolean change to true should always trigger a try_read call that flushes the queue. Signed-off-by: Patrick Venture --- v2: introduced helper method to encapsulate rx activation and queue flush. --- hw/net/npcm7xx_emc.c | 18 -- 1 file changed, 8 insertions(+), 10

Re: [PATCH] hw/net: npcm7xx_emc fix missing queue_flush

2021-12-03 Thread Patrick Venture
On Fri, Dec 3, 2021 at 1:42 PM Philippe Mathieu-Daudé wrote: > On 12/3/21 22:27, Patrick Venture wrote: > > The rx_active boolean change to true should always trigger a try_read > > call that flushes the queue. > > > > Signed-off-by: Patrick Venture > > -

[PATCH] hw/net: npcm7xx_emc fix missing queue_flush

2021-12-03 Thread Patrick Venture
The rx_active boolean change to true should always trigger a try_read call that flushes the queue. Signed-off-by: Patrick Venture --- hw/net/npcm7xx_emc.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/hw/net/npcm7xx_emc.c b/hw/net/npcm7xx_emc.c index 7c892f820f

Re: [PATCH] hw/net: npcm7xx_emc fix missing queue_flush

2021-12-03 Thread Patrick Venture
On Fri, Dec 3, 2021 at 1:54 PM Patrick Venture wrote: > > > On Fri, Dec 3, 2021 at 1:42 PM Philippe Mathieu-Daudé > wrote: > >> On 12/3/21 22:27, Patrick Venture wrote: >> > The rx_active boolean change to true should always trigger a try_read >> > call t

[PATCH] hw/nvram: at24 return 0xff if 1 byte address

2021-12-19 Thread Patrick Venture
The at24 eeproms are 2 byte devices that return 0xff when they are read from with a partial (1-byte) address written. This distinction was found comparing model behavior to real hardware testing. Tested: `i2ctransfer -f -y 45 w1@85 0 r1` returns 0xff instead of next byte Signed-off-by: Patrick

Re: [PATCH] hw/nvram: at24 return 0xff if 1 byte address

2021-12-20 Thread Patrick Venture
On Mon, Dec 20, 2021 at 1:12 AM Philippe Mathieu-Daudé wrote: > Hi Patrick, > > On 12/20/21 01:32, Patrick Venture wrote: > > The at24 eeproms are 2 byte devices that return 0xff when they are read > > from with a partial (1-byte) address written. This distinction was >

[PATCH 3/4] hw/arm: add i2c muxes to kudo-bmc

2022-01-02 Thread Patrick Venture
Signed-off-by: Patrick Venture Reviewed-by: Hao Wu --- hw/arm/npcm7xx_boards.c | 9 + 1 file changed, 9 insertions(+) diff --git a/hw/arm/npcm7xx_boards.c b/hw/arm/npcm7xx_boards.c index 257bf638fd..4cd58972c5 100644 --- a/hw/arm/npcm7xx_boards.c +++ b/hw/arm/npcm7xx_boards.c @@ -330,8

[PATCH 4/4] hw/arm: kudo add lm75s on bus 13

2022-01-02 Thread Patrick Venture
' lm75 45-0049: supply vs not found, using dummy regulator lm75 45-0049: hwmon3: sensor 'lm75' Signed-off-by: Patrick Venture Reviewed-by: Titus Rwantare --- hw/arm/npcm7xx_boards.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/hw/arm/npcm7xx_boards.c b/hw/arm

[PATCH 0/4] hw/arm: Add more devices to kudo-bmc

2022-01-02 Thread Patrick Venture
This series of patches adds various devices that are defined in the device-tree for this board. Chris Rauer (1): hw/arm: Add kudo i2c eeproms. Patrick Venture (2): hw/arm: add i2c muxes to kudo-bmc hw/arm: kudo add lm75s on bus 13 Shengtan Mao (1): hw/arm: attach MMC to kudo-bmc hw

[PATCH 2/4] hw/arm: attach MMC to kudo-bmc

2022-01-02 Thread Patrick Venture
From: Shengtan Mao Signed-off-by: Shengtan Mao Reviewed-by: Hao Wu Reviewed-by: Chris Rauer --- hw/arm/npcm7xx_boards.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/arm/npcm7xx_boards.c b/hw/arm/npcm7xx_boards.c index 37de9fef43..257bf638fd 100644 --- a/hw/arm/npcm7xx_boards.c +++

[PATCH 1/4] hw/arm: Add kudo i2c eeproms.

2022-01-02 Thread Patrick Venture
From: Chris Rauer Signed-off-by: Chris Rauer Reviewed-by: Hao Wu Reviewed-by: Patrick Venture --- hw/arm/npcm7xx_boards.c | 8 1 file changed, 8 insertions(+) diff --git a/hw/arm/npcm7xx_boards.c b/hw/arm/npcm7xx_boards.c index 0866d2f4f0..37de9fef43 100644 --- a/hw/arm

[PATCH] Set return code on failure

2022-01-04 Thread Patrick Venture
From: Peter Foley Match the other error handling in this function. Signed-off-by: Peter Foley --- net/tap.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/tap.c b/net/tap.c index f716be3e3f..c5cbeaa7a2 100644 --- a/net/tap.c +++ b/net/tap.c @@ -900,6 +900,7 @@ int net_init_tap(const

Re: [PATCH] Set return code on failure

2022-01-04 Thread Patrick Venture
On Tue, Jan 4, 2022 at 1:18 PM Patrick Venture wrote: > From: Peter Foley > > Match the other error handling in this function. > Just noticed I didn't fix up the commit title here to match style. Should I do a PATCH RESEND or a new patch, or can you add the "net/tap: &quo

[PATCH v2] net/tap: Set return code on failure

2022-01-05 Thread Patrick Venture
From: Peter Foley Match the other error handling in this function. Fixes: e7b347d0bf6 ("net: detect errors from probing vnet hdr flag for TAP devices") Reviewed-by: Patrick Venture Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Peter Foley --- v2: Fixed commit titlewq a

[PATCH v2] net/tap: Set return code on failure

2022-01-05 Thread Patrick Venture
From: Peter Foley Match the other error handling in this function. Fixes: e7b347d0bf6 ("net: detect errors from probing vnet hdr flag for TAP devices") Reviewed-by: Patrick Venture Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Peter Foley --- v2: Fixed commit titlewq a

[PATCH v2] hw/nvram: at24 return 0xff if 1 byte address

2021-12-20 Thread Patrick Venture
The at24 eeproms are 2 byte devices that return 0xff when they are read from with a partial (1-byte) address written. This distinction was found comparing model behavior to real hardware testing. Tested: `i2ctransfer -f -y 45 w1@85 0 r1` returns 0xff instead of next byte Signed-off-by: Patrick

Re: [PATCH] hw/i2c: add pca9543 support to mux

2021-11-18 Thread Patrick Venture
On Mon, Nov 8, 2021 at 1:58 PM Patrick Venture wrote: > Adds support for the 2 channel pca9543 i2c switch. > > Signed-off-by: Patrick Venture > --- > hw/i2c/i2c_mux_pca954x.c | 12 > include/hw/i2c/i2c_mux_pca954x.h | 1 + > 2 files changed, 13 i

[PATCH] hw/i2c: add pca9543 support to mux

2021-11-08 Thread Patrick Venture
Adds support for the 2 channel pca9543 i2c switch. Signed-off-by: Patrick Venture --- hw/i2c/i2c_mux_pca954x.c | 12 include/hw/i2c/i2c_mux_pca954x.h | 1 + 2 files changed, 13 insertions(+) diff --git a/hw/i2c/i2c_mux_pca954x.c b/hw/i2c/i2c_mux_pca954x.c index 847c59921c

Introducing PECI support in Qemu

2021-12-16 Thread Patrick Venture
Hi all; My team has a working PECI bus/device in Qemu, but we only have internal board specifications that enable it. We'd like to upstream it as soon as possible, but obviously we can't enable testing for it without an upstream board that uses it. We only have it attached to Nuvoton 7xx

Re: [PATCH] hw/sensor: enable setting adm1272 temperature with qmp

2022-01-07 Thread Patrick Venture
On Fri, Jan 7, 2022 at 5:24 AM Thomas Huth wrote: > On 06/01/2022 18.38, Patrick Venture wrote: > > From: Titus Rwantare > > > > Reviewed-by: Patrick Venture > > Reviewed-by: Chris Rauer > > Reviewed-by: Hao Wu > > Signed-off-by: Titus Rwantare > &

Re: [PATCH] hw/sensor: Add SB-TSI Temperature Sensor Interface

2022-01-09 Thread Patrick Venture
On Fri, Jan 7, 2022 at 7:04 PM Patrick Venture wrote: > From: Hao Wu > > SB Temperature Sensor Interface (SB-TSI) is an SMBus compatible > interface that reports AMD SoC's Ttcl (normalized temperature), > and resembles a typical 8-pin remote temperature sensor's I2C int

[PATCH 0/2] Adds designware i2c module and adds it to virt arm

2022-01-10 Thread Patrick Venture
This patch series introduces a new i2c module, namely the designware one and further enables this (optionally) for the virt-arm machine. Chris Rauer (2): hw/i2c: Add designware i2c controller. hw/arm: Enable smbus on arm virt machine. MAINTAINERS | 6 +

[PATCH 1/2] hw/i2c: Add designware i2c controller.

2022-01-10 Thread Patrick Venture
From: Chris Rauer Reviewed-by: Hao Wu Signed-off-by: Chris Rauer --- MAINTAINERS | 6 + hw/i2c/Kconfig | 4 + hw/i2c/designware_i2c.c | 821 hw/i2c/meson.build | 1 +

[PATCH 2/2] hw/arm: Enable smbus on arm virt machine.

2022-01-10 Thread Patrick Venture
From: Chris Rauer Reviewed-by: Hao Wu Signed-off-by: Chris Rauer --- docs/system/arm/virt.rst | 4 +++ hw/arm/Kconfig | 1 + hw/arm/virt-acpi-build.c | 24 ++ hw/arm/virt.c| 55 include/hw/arm/virt.h| 3 +++

[PATCH v3 0/2] hw/sensor: Add SB-TSI Temperature Sensor Interface

2022-01-13 Thread Patrick Venture
v3: * typofix where I accidentally embedded 'wq' into a string * moved the type sbtsi definition back into the source file * renamed the qtest file to use hyphens only v2: * Split the commit into a separate patch for the qtest * Moved the common registers into the new header * Introduced a

[PATCH v3 1/2] hw/sensor: Add SB-TSI Temperature Sensor Interface

2022-01-13 Thread Patrick Venture
From: Hao Wu SB Temperature Sensor Interface (SB-TSI) is an SMBus compatible interface that reports AMD SoC's Ttcl (normalized temperature), and resembles a typical 8-pin remote temperature sensor's I2C interface to BMC. This patch implements a basic AMD SB-TSI sensor that is compatible with

[PATCH v3 2/2] tests: add qtest for hw/sensor/sbtsi

2022-01-13 Thread Patrick Venture
From: Hao Wu Reviewed-by: Doug Evans Signed-off-by: Hao Wu Signed-off-by: Patrick Venture Acked-by: Thomas Huth --- tests/qtest/tmp-sbtsi-test.c | 161 +++ tests/qtest/meson.build | 1 + 2 files changed, 162 insertions(+) create mode 100644 tests

[PATCH] hw/arm: kudo add lm75s behind bus 1 switch at 75

2022-01-11 Thread Patrick Venture
Reviewed-by: Hao Wu Signed-off-by: Patrick Venture --- hw/arm/npcm7xx_boards.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/hw/arm/npcm7xx_boards.c b/hw/arm/npcm7xx_boards.c index 7d0f3148be..d701e5cc55 100644 --- a/hw/arm/npcm7xx_boards.c +++ b/hw/arm

[PATCH v2 2/2] tests: add qtest for hw/sensor/sbtsi

2022-01-12 Thread Patrick Venture
From: Hao Wu Reviewed-by: Doug Evanwqs Signed-off-by: Hao Wu Signed-off-by: Patrick Venture --- tests/qtest/meson.build | 1 + tests/qtest/tmp_sbtsi-test.c | 161 +++ 2 files changed, 162 insertions(+) create mode 100644 tests/qtest/tmp_sbtsi-test.c

[PATCH v2 0/2] hw/sensor: Add SB-TSI Temperature Sensor Interface

2022-01-12 Thread Patrick Venture
v2: * Split the commit into a separate patch for the qtest * Moved the common registers into the new header * Introduced a new header Hao Wu (2): hw/sensor: Add SB-TSI Temperature Sensor Interface tests: add qtest for hw/sensor/sbtsi hw/sensor/Kconfig| 4 +

[PATCH v2 1/2] hw/sensor: Add SB-TSI Temperature Sensor Interface

2022-01-12 Thread Patrick Venture
From: Hao Wu SB Temperature Sensor Interface (SB-TSI) is an SMBus compatible interface that reports AMD SoC's Ttcl (normalized temperature), and resembles a typical 8-pin remote temperature sensor's I2C interface to BMC. This patch implements a basic AMD SB-TSI sensor that is compatible with

Re: [PATCH] linux-user: rt_sigprocmask, check read perms first

2022-01-11 Thread Patrick Venture
On Sat, Jan 8, 2022 at 10:16 AM Laurent Vivier wrote: > Le 06/01/2022 à 23:00, Patrick Venture a écrit : > > From: Shu-Chun Weng > > > > Linux kernel does it this way (checks read permission before validating > `how`) > > and the latest version of ABSL's

Re: [PATCH] tests/qtest: add qtests for npcm7xx sdhci

2022-01-10 Thread Patrick Venture
On Fri, Jan 7, 2022 at 2:26 PM Patrick Venture wrote: > From: Shengtan Mao > > Reviewed-by: Hao Wu > Reviewed-by: Chris Rauer > Signed-off-by: Shengtan Mao > --- > tests/qtest/meson.build | 1 + > tests/qtest/npcm7xx_sdhci-test.c | 201 ++

Re: [PATCH] hw/sensor: Add SB-TSI Temperature Sensor Interface

2022-01-10 Thread Patrick Venture
On Mon, Jan 10, 2022 at 1:35 AM Philippe Mathieu-Daudé wrote: > Hi Patrick, > > On 1/8/22 04:04, Patrick Venture wrote: > > From: Hao Wu > > > > SB Temperature Sensor Interface (SB-TSI) is an SMBus compatible > > interface that reports AMD SoC's Ttcl (normalize

Re: [PATCH] linux-user: rt_sigprocmask, check read perms first

2022-01-11 Thread Patrick Venture
On Tue, Jan 11, 2022 at 12:50 PM Laurent Vivier wrote: > Hi Patrick, > > Le 11/01/2022 à 21:14, Patrick Venture a écrit : > > > > > > On Sat, Jan 8, 2022 at 10:16 AM Laurent Vivier <mailto:laur...@vivier.eu>> wrote: > > > > Le 06/01/2022 à

Re: [PATCH] hw/sensor: Add SB-TSI Temperature Sensor Interface

2022-01-10 Thread Patrick Venture
On Mon, Jan 10, 2022 at 11:30 AM Philippe Mathieu-Daudé wrote: > On 1/10/22 18:14, Patrick Venture wrote: > > On Mon, Jan 10, 2022 at 1:35 AM Philippe Mathieu-Daudé > <mailto:f4...@amsat.org>> wrote: > > > > Hi Patrick, > > > > On 1/8/22 04:0

[PATCH 0/2] Introduce PCI mbox module for Nuvoton SoC

2022-01-10 Thread Patrick Venture
The PCI mbox module connects to a host such that the host can interact with the BMC SoC as a PCI device using a chardev. This chardev portion will be in a follow-on CL with the corresponding documentation. Hao Wu (2): hw/misc: Add Nuvoton's PCI Mailbox Module hw/arm: Add PCI mailbox module

[PATCH 1/2] hw/misc: Add Nuvoton's PCI Mailbox Module

2022-01-10 Thread Patrick Venture
with the core CPU is emulated via a chardev and will be in a follow-up patch. Reviewed-by: Patrick Venture Reviewed-by: Joe Komlodi Signed-off-by: Hao Wu --- hw/misc/meson.build| 1 + hw/misc/npcm7xx_pci_mbox.c | 178 + hw/misc/trace-events

[PATCH 2/2] hw/arm: Add PCI mailbox module to Nuvoton SoC

2022-01-10 Thread Patrick Venture
From: Hao Wu This patch wires the PCI mailbox module to Nuvoton SoC. Reviewed-by: Patrick Venture Reviewed-by: Joe Komlodi Signed-off-by: Hao Wu --- docs/system/arm/nuvoton.rst | 1 + hw/arm/npcm7xx.c| 15 ++- include/hw/arm/npcm7xx.h| 2 ++ 3 files changed, 17

[PATCH] hw/nvram: Add at24c-eeprom support for small eeproms

2022-03-14 Thread Patrick Venture
Tested: Verified at24c02 driver happy and contents matched expectations. Signed-off-by: Patrick Venture Reviewed-by: Hao Wu --- hw/nvram/eeprom_at24c.c | 52 +++-- 1 file changed, 35 insertions(+), 17 deletions(-) diff --git a/hw/nvram/eeprom_at24c.c b/hw

Re: [PATCH] hw/nvram: Add at24c-eeprom support for small eeproms

2022-03-14 Thread Patrick Venture
On Mon, Mar 14, 2022 at 2:12 PM Patrick Venture wrote: > Tested: Verified at24c02 driver happy and contents matched > expectations. > > Signed-off-by: Patrick Venture > Reviewed-by: Hao Wu > --- > hw/nvram/eeprom_at24c.c | 52 +++--

Lost patch, hw/sensor: enable adm1272 temp with qmp

2022-03-14 Thread Patrick Venture
I'm going through my team's spreadsheet for our upstreaming efforts to try to make sure things weren't lost, as sometimes a reply will go into my spam folder, and I saw this patch also fell under the radar: https://lists.gnu.org/archive/html/qemu-devel/2022-01/msg01310.html If you want, I can

  1   2   3   >