[PATCH v2] hw/nvram: Add at24c-eeprom support for small eeproms

2022-07-11 Thread Patrick Venture
Tested: Verified at24c02 driver happy and contents matched expectations. Signed-off-by: Patrick Venture Reviewed-by: Hao Wu --- v2: Added comment describing the new behavior. --- hw/nvram/eeprom_at24c.c | 56 - 1 file changed, 39 insertions(+), 17

Npcm7xx emac tap networking hitting 75MiB limit

2022-05-23 Thread Patrick Venture
Hey; I wanted to ask if anyone has seen this before. When we try to download a file larger than 75MB from within an Ncpm7xx board using TAP networking (versus user) it just fails there. using wget it reports null 75.0M - stalled -\rnull 75.0M - stalled -\rnull

Re: [PATCH v5] tests/qtest: add qtests for npcm7xx sdhci

2022-05-26 Thread Patrick Venture
On Thu, May 26, 2022 at 8:54 AM Peter Maydell wrote: > On Fri, 25 Feb 2022 at 17:45, Hao Wu wrote: > > > > From: Shengtan Mao > > > > Reviewed-by: Hao Wu > > Reviewed-by: Chris Rauer > > Signed-off-by: Shengtan Mao > > Signed-off-by: Patrick

[PATCH] hw/i2c: Enable an id for the pca954x devices

2022-03-17 Thread Patrick Venture
pca954x[77]', for an instance attached at that address. Signed-off-by: Patrick Venture Reviewed-by: Hao Wu --- hw/i2c/i2c_mux_pca954x.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/hw/i2c/i2c_mux_pca954x.c b/hw/i2c/i2c_mux_pca954x.c index a9517b612a..4f8c2d6a

Re: [PATCH v1 8/9] aspeed: Add an AST1030 eval board

2022-03-23 Thread Patrick Venture
On Mon, Mar 21, 2022 at 7:59 PM Jamin Lin wrote: > From: Steven Lee > > The image should be supplied with ELF binary. > $ qemu-system-arm -M ast1030-evb -kernel zephyr.elf -nographic > > Signed-off-by: Troy Lee > Signed-off-by: Jamin Lin > Signed-off-by: Steven Lee

Re: [PATCH 1/2] hw/misc: Add Nuvoton's PCI Mailbox Module

2022-04-11 Thread Patrick Venture
On Thu, Jan 27, 2022 at 1:27 PM Patrick Venture wrote: > > > On Thu, Jan 27, 2022 at 10:37 AM Peter Maydell > wrote: > >> On Mon, 10 Jan 2022 at 17:56, Patrick Venture wrote: >> > >> > From: Hao Wu >> > >> > The PCI Mailbox Module is a

[PATCH] tests/qtest: npcm7xx-emc-test: Skip checking MAC

2022-09-06 Thread Patrick Venture
The register tests walks all the registers to verify they are initially 0 when appropriate. However, if the MAC address is set in the register space, this should not be checked against 0. Reviewed-by: Hao Wu Change-Id: I02426e39bdab33ceedd42c49d233e8680d4ec058 Signed-off-by: Patrick Venture

Seeing qtest assertion failure with 7.1

2022-09-07 Thread Patrick Venture
# Start of nvme tests # Start of pci-device tests # Start of pci-device-tests tests # starting QEMU: exec ./qemu-system-aarch64 -qtest unix:/tmp/qtest-1431.sock -qtest-log /dev/null -chardev socket,path=/tmp/qtest-1431.qmp,id=char0 -mon chardev=char0,mode=control -display none -M virt, -cpu max -dr

[PATCH] crypto/block-luks: always set splitkeylen to 0

2022-09-07 Thread Patrick Venture
This was caught by a sanitized build, that was perhaps oversensitive. Signed-off-by: Patrick Venture --- crypto/block-luks.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/crypto/block-luks.c b/crypto/block-luks.c index f62be6836b..8633fb7e9f 100644 --- a/crypto/block

Re: [PATCH] crypto/block-luks: always set splitkeylen to 0

2022-09-07 Thread Patrick Venture
On Wed, Sep 7, 2022 at 9:34 AM Daniel P. Berrangé wrote: > On Wed, Sep 07, 2022 at 09:21:25AM -0700, Patrick Venture wrote: > > This was caught by a sanitized build, that was perhaps oversensitive. > > > > Signed-off-by: Patrick Venture > > --- > > crypto/bl

Re: Seeing qtest assertion failure with 7.1

2022-09-08 Thread Patrick Venture
On Wed, Sep 7, 2022 at 10:40 AM Peter Maydell wrote: > On Wed, 7 Sept 2022 at 16:39, Patrick Venture wrote: > > > > # Start of nvme tests > > # Start of pci-device tests > > # Start of pci-device-tests tests > > # starting QEMU: exec ./qemu-system-aarch64 -

Re: [PATCH] tests/qtest: npcm7xx-emc-test: Skip checking MAC

2022-09-19 Thread Patrick Venture
On Mon, Sep 19, 2022 at 5:44 AM Thomas Huth wrote: > On 06/09/2022 18.31, Patrick Venture wrote: > > The register tests walks all the registers to verify they are initially > > 0 when appropriate. However, if the MAC address is set in the register > >space, this

[PATCH] hw/net: npcm7xx_emc: set MAC in register space

2022-09-21 Thread Patrick Venture
The MAC address set from Qemu wasn't being saved into the register space. Reviewed-by: Hao Wu Signed-off-by: Patrick Venture --- hw/net/npcm7xx_emc.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/hw/net/npcm7xx_emc.c b/hw/net/npcm7xx_emc.c index 7c86bb52e5..6be10

Re: [PATCH] tests/qtest: npcm7xx-emc-test: Skip checking MAC

2022-10-06 Thread Patrick Venture
On Tue, Sep 20, 2022 at 12:00 AM Thomas Huth wrote: > On 20/09/2022 00.37, Patrick Venture wrote: > > > > > > On Mon, Sep 19, 2022 at 5:44 AM Thomas Huth > <mailto:th...@redhat.com>> wrote: > > > > On 06/09/2022 18.31, Patrick Venture wrote

Re: [PATCH] tests/qtest: npcm7xx-emc-test: Skip checking MAC

2022-10-06 Thread Patrick Venture
On Thu, Oct 6, 2022 at 10:58 AM Patrick Venture wrote: > > > On Tue, Sep 20, 2022 at 12:00 AM Thomas Huth wrote: > >> On 20/09/2022 00.37, Patrick Venture wrote: >> > >> > >> > On Mon, Sep 19, 2022 at 5:44 AM Thomas Huth > > <mailto:th...

[PATCH RESEND] hw/i2c: Enable an id for the pca954x devices

2022-10-11 Thread Patrick Venture
pca954x[77]', for an instance attached at that address. Signed-off-by: Patrick Venture Reviewed-by: Hao Wu --- hw/i2c/i2c_mux_pca954x.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/hw/i2c/i2c_mux_pca954x.c b/hw/i2c/i2c_mux_pca954x.c index a9517b612a..4f8c2d6a

[PATCH] hw/net: npcm7xx_emc fix missing queue_flush

2021-12-03 Thread Patrick Venture
The rx_active boolean change to true should always trigger a try_read call that flushes the queue. Signed-off-by: Patrick Venture --- hw/net/npcm7xx_emc.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/hw/net/npcm7xx_emc.c b/hw/net/npcm7xx_emc.c index 7c892f820f

Re: [PATCH] hw/net: npcm7xx_emc fix missing queue_flush

2021-12-03 Thread Patrick Venture
On Fri, Dec 3, 2021 at 1:42 PM Philippe Mathieu-Daudé wrote: > On 12/3/21 22:27, Patrick Venture wrote: > > The rx_active boolean change to true should always trigger a try_read > > call that flushes the queue. > > > > Signed-off-by: Patrick Venture > > -

Re: [PATCH] hw/net: npcm7xx_emc fix missing queue_flush

2021-12-03 Thread Patrick Venture
On Fri, Dec 3, 2021 at 1:54 PM Patrick Venture wrote: > > > On Fri, Dec 3, 2021 at 1:42 PM Philippe Mathieu-Daudé > wrote: > >> On 12/3/21 22:27, Patrick Venture wrote: >> > The rx_active boolean change to true should always trigger a try_read >> > call t

[PATCH v2] hw/net: npcm7xx_emc fix missing queue_flush

2021-12-03 Thread Patrick Venture
The rx_active boolean change to true should always trigger a try_read call that flushes the queue. Signed-off-by: Patrick Venture --- v2: introduced helper method to encapsulate rx activation and queue flush. --- hw/net/npcm7xx_emc.c | 18 -- 1 file changed, 8 insertions(+), 10

Re: [PATCH RESEND v2] hw/i2c: Enable an id for the pca954x devices

2023-05-31 Thread Patrick Venture
On Wed, Mar 22, 2023 at 2:40 PM Philippe Mathieu-Daudé wrote: > On 22/3/23 22:19, Corey Minyard wrote: > > On Wed, Mar 22, 2023 at 10:21:36AM -0700, Patrick Venture wrote: > >> This allows the devices to be more readily found and specified. > >> Without setting the n

Re: [PATCH v2] system/memory: use ldn_he_p/stn_he_p

2023-12-03 Thread Patrick Venture
On Fri, Nov 17, 2023 at 12:43 AM David Hildenbrand wrote: > On 16.11.23 17:36, Patrick Venture wrote: > > Using direct pointer dereferencing can allow for unaligned accesses, > > which was seen during execution with sanitizers enabled. > > > > Reviewed-by: Chris Ra

Re: [PATCH v2] system/memory: use ldn_he_p/stn_he_p

2023-12-04 Thread Patrick Venture
On Mon, Dec 4, 2023 at 3:24 AM Philippe Mathieu-Daudé wrote: > Hi Patrick, > > On 3/12/23 16:42, Patrick Venture wrote: > > > Friendly ping? Is this going to be applied or do I need to add another > > CC or? I do think it should go into stable. > > I'll

Re: [PATCH 1/1] hw/i2c: add pca9543 i2c-mux switch

2023-12-05 Thread Patrick Venture
On Tue, Nov 14, 2023 at 3:30 PM Corey Minyard wrote: > On Mon, Nov 13, 2023 at 02:31:56PM +0800, Potin Lai wrote: > > Add pca9543 2-channel i2c-mux switch support. > > > > Signed-off-by: Potin Lai > > Looks good to me. > > Acked-by: Corey Minyard > > > --- > > hw/i2c/i2c_mux_pca954x.c

Re: udp guestfwd

2023-12-08 Thread Patrick Venture
On Fri, Oct 27, 2023 at 11:44 PM Louai Al-Khanji wrote: > Hi, > > I'm interested in having the guestfwd option work for udp. My > understanding is that currently it's restricted to only tcp. > > I'm not familiar with libslirp internals. What would need to be changed to > implement this? I'm poten

[PATCH] softmmu/memory: use memcpy for multi-byte accesses

2023-11-14 Thread Patrick Venture
Avoids unaligned pointer issues. Reviewed-by: Chris Rauer Reviewed-by: Peter Foley Signed-off-by: Patrick Venture --- system/memory.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/system/memory.c b/system/memory.c index 304fa843ea..02c97d5187 100644

Re: [PATCH] softmmu/memory: use memcpy for multi-byte accesses

2023-11-14 Thread Patrick Venture
On Tue, Nov 14, 2023 at 1:18 PM Richard Henderson < richard.hender...@linaro.org> wrote: > On 11/14/23 12:55, Patrick Venture wrote: > > Avoids unaligned pointer issues. > > > > Reviewed-by: Chris Rauer > > Reviewed-by: Peter Foley > > Signed-off-by

Re: [PATCH 1/1] hw/i2c: add pca9543 i2c-mux switch

2023-11-14 Thread Patrick Venture
On Sun, Nov 12, 2023 at 10:34 PM Potin Lai wrote: > Add pca9543 2-channel i2c-mux switch support. > > Signed-off-by: Potin Lai > Reviewed-by: Patrick Venture > --- > hw/i2c/i2c_mux_pca954x.c | 12 > include/hw/i2c/i2c_mux_pca954x.h | 1 + &

Re: [PATCH] softmmu/memory: use memcpy for multi-byte accesses

2023-11-15 Thread Patrick Venture
On Wed, Nov 15, 2023 at 2:30 AM Peter Maydell wrote: > On Tue, 14 Nov 2023 at 21:18, Richard Henderson > wrote: > > > > On 11/14/23 12:55, Patrick Venture wrote: > > > Avoids unaligned pointer issues. > > > > > > Reviewed-by: Chris Rauer > &

Re: [PATCH] softmmu/memory: use memcpy for multi-byte accesses

2023-11-15 Thread Patrick Venture
On Wed, Nov 15, 2023 at 2:35 AM Peter Maydell wrote: > On Tue, 14 Nov 2023 at 20:55, Patrick Venture wrote: > > Avoids unaligned pointer issues. > > > > It would be nice to be more specific in the commit message here, by > describing what kind of guest behaviour or machi

Re: [PATCH] softmmu/memory: use memcpy for multi-byte accesses

2023-11-15 Thread Patrick Venture
On Wed, Nov 15, 2023 at 9:02 AM Richard Henderson < richard.hender...@linaro.org> wrote: > On 11/15/23 08:58, Patrick Venture wrote: > > > > > > On Wed, Nov 15, 2023 at 2:35 AM Peter Maydell > <mailto:peter.mayd...@linaro.org>> wrote: > > > >

Re: [PATCH] softmmu/memory: use memcpy for multi-byte accesses

2023-11-15 Thread Patrick Venture
On Wed, Nov 15, 2023 at 9:26 AM Patrick Venture wrote: > > > On Wed, Nov 15, 2023 at 9:02 AM Richard Henderson < > richard.hender...@linaro.org> wrote: > >> On 11/15/23 08:58, Patrick Venture wrote: >> > >> > >> > On Wed, Nov 15, 2023 at 2:35

[PATCH v2] system/memory: use ldn_he_p/stn_he_p

2023-11-16 Thread Patrick Venture
Using direct pointer dereferencing can allow for unaligned accesses, which was seen during execution with sanitizers enabled. Reviewed-by: Chris Rauer Reviewed-by: Peter Foley Signed-off-by: Patrick Venture Cc: qemu-sta...@nongnu.org --- v2: changed commit mesage to be more accurate and

Introducing PECI support in Qemu

2021-12-16 Thread Patrick Venture
Hi all; My team has a working PECI bus/device in Qemu, but we only have internal board specifications that enable it. We'd like to upstream it as soon as possible, but obviously we can't enable testing for it without an upstream board that uses it. We only have it attached to Nuvoton 7xx present

[PATCH] hw/nvram: at24 return 0xff if 1 byte address

2021-12-19 Thread Patrick Venture
The at24 eeproms are 2 byte devices that return 0xff when they are read from with a partial (1-byte) address written. This distinction was found comparing model behavior to real hardware testing. Tested: `i2ctransfer -f -y 45 w1@85 0 r1` returns 0xff instead of next byte Signed-off-by: Patrick

Re: [PATCH] hw/nvram: at24 return 0xff if 1 byte address

2021-12-20 Thread Patrick Venture
On Mon, Dec 20, 2021 at 1:12 AM Philippe Mathieu-Daudé wrote: > Hi Patrick, > > On 12/20/21 01:32, Patrick Venture wrote: > > The at24 eeproms are 2 byte devices that return 0xff when they are read > > from with a partial (1-byte) address written. This distinction was >

[PATCH v2] hw/nvram: at24 return 0xff if 1 byte address

2021-12-20 Thread Patrick Venture
The at24 eeproms are 2 byte devices that return 0xff when they are read from with a partial (1-byte) address written. This distinction was found comparing model behavior to real hardware testing. Tested: `i2ctransfer -f -y 45 w1@85 0 r1` returns 0xff instead of next byte Signed-off-by: Patrick

[PATCH 1/4] hw/arm: Add kudo i2c eeproms.

2022-01-02 Thread Patrick Venture
From: Chris Rauer Signed-off-by: Chris Rauer Reviewed-by: Hao Wu Reviewed-by: Patrick Venture --- hw/arm/npcm7xx_boards.c | 8 1 file changed, 8 insertions(+) diff --git a/hw/arm/npcm7xx_boards.c b/hw/arm/npcm7xx_boards.c index 0866d2f4f0..37de9fef43 100644 --- a/hw/arm

[PATCH 4/4] hw/arm: kudo add lm75s on bus 13

2022-01-02 Thread Patrick Venture
hwmon2: sensor 'lm75' lm75 45-0049: supply vs not found, using dummy regulator lm75 45-0049: hwmon3: sensor 'lm75' Signed-off-by: Patrick Venture Reviewed-by: Titus Rwantare --- hw/arm/npcm7xx_boards.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff

[PATCH 0/4] hw/arm: Add more devices to kudo-bmc

2022-01-02 Thread Patrick Venture
This series of patches adds various devices that are defined in the device-tree for this board. Chris Rauer (1): hw/arm: Add kudo i2c eeproms. Patrick Venture (2): hw/arm: add i2c muxes to kudo-bmc hw/arm: kudo add lm75s on bus 13 Shengtan Mao (1): hw/arm: attach MMC to kudo-bmc hw

[PATCH 2/4] hw/arm: attach MMC to kudo-bmc

2022-01-02 Thread Patrick Venture
From: Shengtan Mao Signed-off-by: Shengtan Mao Reviewed-by: Hao Wu Reviewed-by: Chris Rauer --- hw/arm/npcm7xx_boards.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/arm/npcm7xx_boards.c b/hw/arm/npcm7xx_boards.c index 37de9fef43..257bf638fd 100644 --- a/hw/arm/npcm7xx_boards.c +++ b

[PATCH 3/4] hw/arm: add i2c muxes to kudo-bmc

2022-01-02 Thread Patrick Venture
Signed-off-by: Patrick Venture Reviewed-by: Hao Wu --- hw/arm/npcm7xx_boards.c | 9 + 1 file changed, 9 insertions(+) diff --git a/hw/arm/npcm7xx_boards.c b/hw/arm/npcm7xx_boards.c index 257bf638fd..4cd58972c5 100644 --- a/hw/arm/npcm7xx_boards.c +++ b/hw/arm/npcm7xx_boards.c @@ -330,8

[PATCH 0/2] hw/i2c: Adds pca954x i2c mux switch device

2021-04-03 Thread Patrick Venture
The i2c mux device pca954x implements two devices: - the pca9546 and pca9548. Patrick Venture (2): hw/i2c/core: add reachable state boolean hw/i2c: add pca954x i2c-mux switch MAINTAINERS | 6 + hw/i2c/Kconfig | 4 + hw/i2c/core.c

[PATCH 1/2] hw/i2c/core: add reachable state boolean

2021-04-03 Thread Patrick Venture
An i2c device can be reachable or not, controlled by some external factor. This field is leveraged by an i2c mux which presents the devices on the parent bus when the associated channel is enabled and otherwise not. Signed-off-by: Patrick Venture Reviewed-by: Havard Skinnemoen Reviewed-by: Hao

[PATCH 2/2] hw/i2c: add pca954x i2c-mux switch

2021-04-03 Thread Patrick Venture
The pca954x is an i2c mux, and this adds support for two variants of this device: the pca9546 and pca9548. This device is very common on BMCs to route a different channel to each PCIe i2c bus downstream from the BMC. Signed-off-by: Patrick Venture Reviewed-by: Havard Skinnemoen Reviewed-by

Re: [PATCH 0/2] hw/i2c: Adds pca954x i2c mux switch device

2021-04-06 Thread Patrick Venture
On Mon, Apr 5, 2021 at 12:58 PM Corey Minyard wrote: > > On Sat, Apr 03, 2021 at 03:28:08PM -0700, Patrick Venture wrote: > > The i2c mux device pca954x implements two devices: > > - the pca9546 and pca9548. > > > > Patrick Venture (2): > > hw/i2c/core: add

Re: [PATCH 0/2] hw/i2c: Adds pca954x i2c mux switch device

2021-04-06 Thread Patrick Venture
On Tue, Apr 6, 2021 at 8:41 AM Patrick Venture wrote: > > On Mon, Apr 5, 2021 at 12:58 PM Corey Minyard wrote: > > > > On Sat, Apr 03, 2021 at 03:28:08PM -0700, Patrick Venture wrote: > > > The i2c mux device pca954x implements two devices: > > > - the pca9

IPMI Smbus

2021-04-06 Thread Patrick Venture
Corey; I saw you have a branch that is working on adding smbus IPMI support (the ssif approach). Can you provide details on the status of this work? Patrick

Re: IPMI Smbus

2021-04-06 Thread Patrick Venture
On Tue, Apr 6, 2021 at 9:54 AM Corey Minyard wrote: > > On Tue, Apr 06, 2021 at 09:04:35AM -0700, Patrick Venture wrote: > > Corey; > > > > I saw you have a branch that is working on adding smbus IPMI support > > (the ssif approach). > > > > Can you

Re: [PATCH 0/2] hw/i2c: Adds pca954x i2c mux switch device

2021-04-06 Thread Patrick Venture
On Tue, Apr 6, 2021 at 11:36 AM Corey Minyard wrote: > > On Tue, Apr 06, 2021 at 08:55:14AM -0700, Patrick Venture wrote: > > On Tue, Apr 6, 2021 at 8:41 AM Patrick Venture wrote: > > > > > > On Mon, Apr 5, 2021 at 12:58 PM Corey Minyard wrote: > > > >

Re: [PATCH 0/2] hw/i2c: Adds pca954x i2c mux switch device

2021-04-07 Thread Patrick Venture
On Tue, Apr 6, 2021 at 4:39 PM Corey Minyard wrote: > > On Tue, Apr 06, 2021 at 03:21:18PM -0700, Patrick Venture wrote: > > On Tue, Apr 6, 2021 at 11:36 AM Corey Minyard wrote: > > > > > > On Tue, Apr 06, 2021 at 08:55:14AM -0700, Patrick Venture wrote: > >

[PATCH v2 0/4] hw/i2c: Adds pca954x i2c mux switch device

2021-04-09 Thread Patrick Venture
each of its buses that are active. - the pca954x device now owns an i2c bus for each channel, allowing the normal device model to attach devices to the channels. Patrick Venture (4): hw/i2c: name I2CNode list in I2CBus hw/i2c: add match method for device search hw/i2c: move search to

[PATCH v2 2/4] hw/i2c: add match method for device search

2021-04-09 Thread Patrick Venture
s, such as i2c muxes. Tested: A BMC firmware was booted to userspace and i2c devices were detected. Signed-off-by: Patrick Venture Reviewed-by: Hao Wu --- hw/i2c/core.c| 23 +++ include/hw/i2c/i2c.h | 11 +++ 2 files changed, 30 insertions(+), 4 deletions(-)

[PATCH v2 1/4] hw/i2c: name I2CNode list in I2CBus

2021-04-09 Thread Patrick Venture
To enable passing the current_devs field as a parameter, we need to use a named struct type. Tested: BMC firmware with i2c devices booted to userspace. Signed-off-by: Patrick Venture Reviewed-by: Hao Wu --- include/hw/i2c/i2c.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff

[PATCH v2 4/4] hw/i2c: add pca954x i2c-mux switch

2021-04-09 Thread Patrick Venture
The pca954x is an i2c mux, and this adds support for two variants of this device: the pca9546 and pca9548. This device is very common on BMCs to route a different channel to each PCIe i2c bus downstream from the BMC. Signed-off-by: Patrick Venture Reviewed-by: Hao Wu Reviewed-by: Havard

[PATCH v2 3/4] hw/i2c: move search to i2c_scan_bus method

2021-04-09 Thread Patrick Venture
Moves the search for matching devices on an i2c bus into a separate method. This allows for an object that owns an I2CBus can avoid duplicating this method. Tested: A BMC firmware was booted to userspace and i2c devices were detected. Signed-off-by: Patrick Venture Reviewed-by: Hao Wu --- hw

Re: [PATCH v2 4/4] hw/i2c: add pca954x i2c-mux switch

2021-04-09 Thread Patrick Venture
On Fri, Apr 9, 2021 at 9:51 AM Philippe Mathieu-Daudé wrote: > > Hi Patrick, > > On 4/9/21 6:25 PM, Patrick Venture wrote: > > The pca954x is an i2c mux, and this adds support for two variants of > > this device: the pca9546 and pca9548. > > > > This devi

Re: [PATCH v2 4/4] hw/i2c: add pca954x i2c-mux switch

2021-04-09 Thread Patrick Venture
On Fri, Apr 9, 2021 at 11:34 AM Corey Minyard wrote: > > On Fri, Apr 09, 2021 at 09:25:45AM -0700, Patrick Venture wrote: > > The pca954x is an i2c mux, and this adds support for two variants of > > this device: the pca9546 and pca9548. > > > > This device is

Re: [PATCH v2 0/4] hw/i2c: Adds pca954x i2c mux switch device

2021-04-09 Thread Patrick Venture
On Fri, Apr 9, 2021 at 11:31 AM Corey Minyard wrote: > > On Fri, Apr 09, 2021 at 09:25:41AM -0700, Patrick Venture wrote: > > The i2c mux device pca954x implements two devices: > > - the pca9546 and pca9548. > > > > v2: > > - the core i2c bus now calls a m

[PATCH v3 1/4] hw/i2c: name I2CNode list in I2CBus

2021-04-09 Thread Patrick Venture
To enable passing the current_devs field as a parameter, we need to use a named struct type. Tested: BMC firmware with i2c devices booted to userspace. Signed-off-by: Patrick Venture Reviewed-by: Hao Wu Reviewed-by: Philippe Mathieu-Daudé --- include/hw/i2c/i2c.h | 4 +++- 1 file changed, 3

[PATCH v3 2/4] hw/i2c: add match method for device search

2021-04-09 Thread Patrick Venture
s, such as i2c muxes. Tested: A BMC firmware was booted to userspace and i2c devices were detected. Signed-off-by: Patrick Venture Reviewed-by: Hao Wu --- hw/i2c/core.c| 23 +++ include/hw/i2c/i2c.h | 11 +++ 2 files changed, 30 insertions(+), 4 deletions(-)

[PATCH v3 3/4] hw/i2c: move search to i2c_scan_bus method

2021-04-09 Thread Patrick Venture
Moves the search for matching devices on an i2c bus into a separate method. This allows for an object that owns an I2CBus can avoid duplicating this method. Tested: A BMC firmware was booted to userspace and i2c devices were detected. Signed-off-by: Patrick Venture Reviewed-by: Hao Wu --- hw

[PATCH v3 0/4] hw/i2c: Adds pca954x i2c mux switch device

2021-04-09 Thread Patrick Venture
. - the pca954x device overrides the i2c device match method to search the children for each of its buses that are active. - the pca954x device now owns an i2c bus for each channel, allowing the normal device model to attach devices to the channels. Patrick Venture (4): hw/i2c: name I2CNode

[PATCH v3 4/4] hw/i2c: add pca954x i2c-mux switch

2021-04-09 Thread Patrick Venture
The pca954x is an i2c mux, and this adds support for two variants of this device: the pca9546 and pca9548. This device is very common on BMCs to route a different channel to each PCIe i2c bus downstream from the BMC. Signed-off-by: Patrick Venture Reviewed-by: Hao Wu Reviewed-by: Havard

Re: [PATCH v2 4/4] hw/i2c: add pca954x i2c-mux switch

2021-04-09 Thread Patrick Venture
On Fri, Apr 9, 2021 at 2:20 PM Philippe Mathieu-Daudé wrote: > > +Paolo/Thomas > > On 4/9/21 7:21 PM, Patrick Venture wrote: > > On Fri, Apr 9, 2021 at 9:51 AM Philippe Mathieu-Daudé > > wrote: > >> > >> Hi Patrick, > >> > >> On 4/9/21

[PATCH v4 1/4] hw/i2c: name I2CNode list in I2CBus

2021-04-12 Thread Patrick Venture
To enable passing the current_devs field as a parameter, we need to use a named struct type. Tested: BMC firmware with i2c devices booted to userspace. Signed-off-by: Patrick Venture Reviewed-by: Hao Wu Reviewed-by: Philippe Mathieu-Daudé --- include/hw/i2c/i2c.h | 4 +++- 1 file changed, 3

[PATCH v4 0/4] hw/i2c: Adds pca954x i2c mux switch device

2021-04-12 Thread Patrick Venture
ns an i2c bus for each channel, allowing the normal device model to attach devices to the channels. Patrick Venture (4): hw/i2c: name I2CNode list in I2CBus hw/i2c: add match method for device search hw/i2c: move search to i2c_scan_bus method hw/i2c: add pca954x i2c-mux switch MAINTA

[PATCH v4 3/4] hw/i2c: move search to i2c_scan_bus method

2021-04-12 Thread Patrick Venture
Moves the search for matching devices on an i2c bus into a separate method. This allows for an object that owns an I2CBus can avoid duplicating this method. Tested: A BMC firmware was booted to userspace and i2c devices were detected. Signed-off-by: Patrick Venture Reviewed-by: Hao Wu --- hw

[PATCH v4 2/4] hw/i2c: add match method for device search

2021-04-12 Thread Patrick Venture
s, such as i2c muxes. Tested: A BMC firmware was booted to userspace and i2c devices were detected. Signed-off-by: Patrick Venture Reviewed-by: Hao Wu --- hw/i2c/core.c| 23 +++ include/hw/i2c/i2c.h | 11 +++ 2 files changed, 30 insertions(+), 4 deletions(-)

[PATCH v4 4/4] hw/i2c: add pca954x i2c-mux switch

2021-04-12 Thread Patrick Venture
The pca954x is an i2c mux, and this adds support for two variants of this device: the pca9546 and pca9548. This device is very common on BMCs to route a different channel to each PCIe i2c bus downstream from the BMC. Signed-off-by: Patrick Venture Reviewed-by: Hao Wu Reviewed-by: Havard

RFC: Adding new system, quanta-q71l

2021-04-13 Thread Patrick Venture
HI; My team is actively engaged now in producing Qemu support for new devices and boards, and I previously worked on the quanta-q71l board for OpenBmc. I'm currently fixing up the configuration to build again, and I'd like to introduce a board for it in Aspeed. The palmetto doesn't really repres

Re: [PATCH 1/2] hw/arm: add quanta-gbs-bmc machine

2021-06-02 Thread Patrick Venture
On Thu, May 27, 2021 at 2:34 AM Peter Maydell wrote: > > On Tue, 18 May 2021 at 20:54, Patrick Venture wrote: > > > > Adds initial quanta-gbs-bmc machine support. > > > > Tested: Boots to userspace. > > Signed-off-by: Patrick Venture > > Reviewe

[PATCH 3/4] hw/arm: quanta-q71l add pca954x muxes

2021-05-18 Thread Patrick Venture
Adds the pca954x muxes expected. Tested: Booted quanta-q71l image to userspace. Signed-off-by: Patrick Venture Reviewed-by: Hao Wu --- hw/arm/Kconfig | 1 + hw/arm/aspeed.c | 11 --- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig index

[PATCH 1/4] hw/arm: gsj add i2c comments

2021-05-18 Thread Patrick Venture
Adds comments to the board init to identify missing i2c devices. Signed-off-by: Patrick Venture Reviewed-by: Hao Wu --- hw/arm/npcm7xx_boards.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/hw/arm/npcm7xx_boards.c b/hw/arm/npcm7xx_boards.c index

[PATCH 2/4] hw/arm: gsj add pca9548

2021-05-18 Thread Patrick Venture
i2c-15: Added multiplexed i2c bus 20 i2c i2c-15: Added multiplexed i2c bus 21 i2c i2c-15: Added multiplexed i2c bus 22 i2c i2c-15: Added multiplexed i2c bus 23 pca954x 15-0075: registered 8 multiplexed busses for I2C switch pca9548 Signed-off-by: Patrick Venture Reviewed-by: Hao Wu --- hw/arm

[PATCH 0/4] With the pca954x i2c mux available, enable it on aspeed and nuvoton BMC boards.

2021-05-18 Thread Patrick Venture
Patrick Venture (4): hw/arm: gsj add i2c comments hw/arm: gsj add pca9548 hw/arm: quanta-q71l add pca954x muxes aspeed: sonorapass: enable pca954x muxes hw/arm/Kconfig | 2 ++ hw/arm/aspeed.c | 33 +++-- hw/arm/npcm7xx_boards.c | 14

[PATCH 0/2] Adds quanta-gbs-bmc machine to nuvoton boards.

2021-05-18 Thread Patrick Venture
This is a board supported by OpenBmc. Patrick Venture (2): hw/arm: add quanta-gbs-bmc machine hw/arm: quanta-gbs-bmc add i2c comments hw/arm/npcm7xx_boards.c | 93 + 1 file changed, 93 insertions(+) -- 2.31.1.751.gd2f1c929bd-goog

[PATCH 4/4] aspeed: sonorapass: enable pca954x muxes

2021-05-18 Thread Patrick Venture
Enables the pca954x muxes in the bmc board configuration. Signed-off-by: Patrick Venture Reviewed-by: Hao Wu --- hw/arm/aspeed.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c index 35a28b0e8b..27fd51980c 100644

[PATCH 2/2] hw/arm: quanta-gbs-bmc add i2c comments

2021-05-18 Thread Patrick Venture
Add a comment and i2c method that describes the board layout. Tested: firmware booted to userspace. Signed-off-by: Patrick Venture Reviewed-by: Brandon Kim Reviewed-by: Hao Wu --- hw/arm/npcm7xx_boards.c | 60 + 1 file changed, 60 insertions(+) diff

[PATCH 1/2] hw/arm: add quanta-gbs-bmc machine

2021-05-18 Thread Patrick Venture
Adds initial quanta-gbs-bmc machine support. Tested: Boots to userspace. Signed-off-by: Patrick Venture Reviewed-by: Brandon Kim Reviewed-by: Hao Wu --- hw/arm/npcm7xx_boards.c | 33 + 1 file changed, 33 insertions(+) diff --git a/hw/arm/npcm7xx_boards.c b/hw

Re: [PATCH 4/4] aspeed: sonorapass: enable pca954x muxes

2021-05-19 Thread Patrick Venture
On Tue, May 18, 2021 at 4:27 PM Joel Stanley wrote: > > On Tue, 18 May 2021 at 19:41, Patrick Venture wrote: > > > > Enables the pca954x muxes in the bmc board configuration. > > > > Signed-off-by: Patrick Venture > > Reviewed-by: Hao Wu > > Not sure

Re: [PATCH v4 0/4] hw/i2c: Adds pca954x i2c mux switch device

2021-04-15 Thread Patrick Venture
On Thu, Apr 15, 2021 at 5:13 AM Corey Minyard wrote: > > On Mon, Apr 12, 2021 at 12:45:18PM -0700, Patrick Venture wrote: > > The i2c mux device pca954x implements two devices: > > - the pca9546 and pca9548. > > This looks good, I have pulled it into my queue. 6.0 i

[PATCH] aspeed: Add support for the quanta-q7l1-bmc board

2021-04-16 Thread Patrick Venture
The Quanta-Q71l BMC board is a board supported by OpenBMC. Tested: Booted quanta-q71l firmware. Signed-off-by: Patrick Venture Reviewed-by: Hao Wu --- hw/arm/aspeed.c | 62 + 1 file changed, 62 insertions(+) diff --git a/hw/arm/aspeed.c b/hw/arm

Re: [PATCH] aspeed: Add support for the quanta-q7l1-bmc board

2021-04-16 Thread Patrick Venture
On Fri, Apr 16, 2021 at 9:40 AM Cédric Le Goater wrote: > > Patrick, > > On 4/16/21 6:24 PM, Patrick Venture wrote: > > The Quanta-Q71l BMC board is a board supported by OpenBMC. > > > > Tested: Booted quanta-q71l firmware. > > Signed-off-by: Patrick Ventur

RFC: Start-time Device Addition for BMC devices

2020-12-28 Thread Patrick Venture
Hi; Currently, devices for a BMC are specified in the board init method for that machine, see: - https://github.com/qemu/qemu/blob/b785d25e91718a660546a6550f64b3c543af7754/hw/arm/aspeed.c#L414 This requires listing all i2c devices, and setting some properties. QMP can be used to set the propert

[PATCH v2 0/2] Adds quanta-gbs-bmc machine to nuvoton boards.

2021-06-08 Thread Patrick Venture
This is a board supported by OpenBmc. v2: - Fixed missing hyphen in Cortex name and dropped TODO on hardware strap value. Patrick Venture (2): hw/arm: add quanta-gbs-bmc machine hw/arm: quanta-gbs-bmc add i2c comments hw/arm/npcm7xx_boards.c | 93

[PATCH v2 1/2] hw/arm: add quanta-gbs-bmc machine

2021-06-08 Thread Patrick Venture
Adds initial quanta-gbs-bmc machine support. Tested: Boots to userspace. Signed-off-by: Patrick Venture Reviewed-by: Brandon Kim Reviewed-by: Hao Wu --- hw/arm/npcm7xx_boards.c | 33 + 1 file changed, 33 insertions(+) diff --git a/hw/arm/npcm7xx_boards.c b/hw

[PATCH v2 2/2] hw/arm: quanta-gbs-bmc add i2c comments

2021-06-08 Thread Patrick Venture
Add a comment and i2c method that describes the board layout. Tested: firmware booted to userspace. Signed-off-by: Patrick Venture Reviewed-by: Brandon Kim Reviewed-by: Hao Wu --- hw/arm/npcm7xx_boards.c | 60 + 1 file changed, 60 insertions(+) diff

Re: [PATCH 4/4] aspeed: sonorapass: enable pca954x muxes

2021-06-08 Thread Patrick Venture
On Wed, May 19, 2021 at 10:18 AM Patrick Venture wrote: > > On Tue, May 18, 2021 at 4:27 PM Joel Stanley wrote: > > > > On Tue, 18 May 2021 at 19:41, Patrick Venture wrote: > > > > > > Enables the pca954x muxes in the bmc board configuration. > &

[PATCH v2 0/3] With the pca954x i2c mux available, enable it on aspeed and nuvoton BMC boards.

2021-06-08 Thread Patrick Venture
v2: - Dropped sonorapass patch. Patrick Venture (3): hw/arm: gsj add i2c comments hw/arm: gsj add pca9548 hw/arm: quanta-q71l add pca954x muxes hw/arm/Kconfig | 2 ++ hw/arm/aspeed.c | 11 --- hw/arm/npcm7xx_boards.c | 14 +- 3 files changed, 23

[PATCH v2 1/3] hw/arm: gsj add i2c comments

2021-06-08 Thread Patrick Venture
Adds comments to the board init to identify missing i2c devices. Signed-off-by: Patrick Venture Reviewed-by: Hao Wu Reviewed-by: Joel Stanley --- hw/arm/npcm7xx_boards.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/hw/arm/npcm7xx_boards.c b/hw/arm

[PATCH v2 2/3] hw/arm: gsj add pca9548

2021-06-08 Thread Patrick Venture
i2c-15: Added multiplexed i2c bus 20 i2c i2c-15: Added multiplexed i2c bus 21 i2c i2c-15: Added multiplexed i2c bus 22 i2c i2c-15: Added multiplexed i2c bus 23 pca954x 15-0075: registered 8 multiplexed busses for I2C switch pca9548 Signed-off-by: Patrick Venture Reviewed-by: Hao Wu Reviewed-by

[PATCH v2 3/3] hw/arm: quanta-q71l add pca954x muxes

2021-06-08 Thread Patrick Venture
Adds the pca954x muxes expected. Tested: Booted quanta-q71l image to userspace. Signed-off-by: Patrick Venture Reviewed-by: Hao Wu Reviewed-by: Joel Stanley --- hw/arm/Kconfig | 1 + hw/arm/aspeed.c | 11 --- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/hw/arm

Re: [PATCH v2 0/2] Adds quanta-gbs-bmc machine to nuvoton boards.

2021-06-15 Thread Patrick Venture
On Tue, Jun 15, 2021 at 8:46 AM Peter Maydell wrote: > > On Tue, 8 Jun 2021 at 20:36, Patrick Venture wrote: > > > > This is a board supported by OpenBmc. > > > > v2: > > - Fixed missing hyphen in Cortex name and dropped TODO on hardware > > strap value.

[PATCH 0/2] Updates docs/system/arm to include new bmc machines

2021-06-15 Thread Patrick Venture
Patrick Venture (2): docs/system/arm: Add quanta-q7l1-bmc reference docs/system/arm: Add quanta-gbs-bmc reference docs/system/arm/aspeed.rst | 1 + docs/system/arm/nuvoton.rst | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) -- 2.32.0.272.g935e593368-goog

[PATCH 1/2] docs/system/arm: Add quanta-q7l1-bmc reference

2021-06-15 Thread Patrick Venture
Adds a line-item reference to the supported quanta-q71l-bmc aspeed entry. Signed-off-by: Patrick Venture --- docs/system/arm/aspeed.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/system/arm/aspeed.rst b/docs/system/arm/aspeed.rst index 57ee2bd94f..cec87e3743 100644 --- a/docs

[PATCH 2/2] docs/system/arm: Add quanta-gbs-bmc reference

2021-06-15 Thread Patrick Venture
Add line item reference to quanta-gbs-bmc machine. Signed-off-by: Patrick Venture --- docs/system/arm/nuvoton.rst | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/system/arm/nuvoton.rst b/docs/system/arm/nuvoton.rst index ca011bd479..197d149f66 100644 --- a/docs/system

Re: [PATCH] hw/arm: Add support for kudo-bmc board.

2021-09-02 Thread Patrick Venture
On Thu, Sep 2, 2021 at 12:01 PM Chris Rauer wrote: > kudo-bmc is a board supported by OpenBMC. > https://github.com/openbmc/openbmc/tree/master/meta-fii/meta-kudo > > Tested: Booted kudo firmware. > Signed-off-by: Chris Rauer > Reviewed-by: Patrick Venture > --- > doc

Re: [PATCH] net: Add "info neighbors" command

2021-09-02 Thread Patrick Venture
On Thu, Sep 2, 2021 at 2:21 PM Doug Evans wrote: > This command dumps the ARP and NDP tables maintained within slirp. > One use-case for it is showing the guest's IPv6 address(es). > > Signed-off-by: Doug Evans > Reviewed-by: Patrick Venture > --- > hmp-commands-

Re: [PATCH v2] hw/arm: Add support for kudo-bmc board.

2021-09-09 Thread Patrick Venture
On Tue, Sep 7, 2021 at 3:35 PM Chris Rauer wrote: > kudo-bmc is a board supported by OpenBMC. > https://github.com/openbmc/openbmc/tree/master/meta-fii/meta-kudo > > Since v1: > - hyphenated Cortex-A9 > > Tested: Booted kudo firmware. > Signed-off-by: Chris Rauer > R

<    1   2   3   >