Re: [Qemu-devel] [PATCH] target-i386: add a list of enforceable CPU models to the help output

2015-08-26 Thread Peter Lieven
Am 26.08.2015 um 21:00 schrieb Eduardo Habkost ehabk...@redhat.com: On Wed, Aug 26, 2015 at 08:46:42PM +0200, Peter Lieven wrote: Am 26.08.2015 um 20:38 schrieb Eduardo Habkost: On Mon, Aug 24, 2015 at 09:36:23PM +0200, Peter Lieven wrote: Am 24.08.2015 um 17:46 schrieb Eric Blake: On 08

Re: [Qemu-devel] [PATCH] target-i386: add a list of enforceable CPU models to the help output

2015-08-26 Thread Peter Lieven
Am 26.08.2015 um 20:38 schrieb Eduardo Habkost: On Mon, Aug 24, 2015 at 09:36:23PM +0200, Peter Lieven wrote: Am 24.08.2015 um 17:46 schrieb Eric Blake: On 08/24/2015 03:17 AM, Peter Lieven wrote: this patch adds a probe that lists all enforceable and migrateable CPU models to the -cpu help

Re: [Qemu-devel] [PATCHv2] block/nfs: cache allocated filesize for read-only files

2015-08-26 Thread Peter Lieven
Am 26.08.2015 um 17:31 schrieb Jeff Cody: On Mon, Aug 24, 2015 at 10:13:16PM +0200, Max Reitz wrote: On 24.08.2015 21:34, Peter Lieven wrote: Am 24.08.2015 um 20:39 schrieb Max Reitz: On 24.08.2015 10:06, Peter Lieven wrote: If the file is readonly its not expected to grow so save

Re: [Qemu-devel] CPU Model kvm64 and Windows2012R2

2015-08-24 Thread Peter Lieven
Am 24.08.2015 um 13:50 schrieb Paolo Bonzini: Hi, some very old 64-bit processors had virtualization extensions but not lahf_lm. However, they are very rare, so it is probably a good idea to add it for the 2.5 machine type. Maybe same accounts for sep ? Will you send a patch? BR, Peter

[Qemu-devel] [PATCHv2] block/nfs: cache allocated filesize for read-only files

2015-08-24 Thread Peter Lieven
If the file is readonly its not expected to grow so save the blocking call to nfs_fstat_async and use the value saved at connection time. Also important the monitor (and thus the main loop) will not hang if block device info is queried and the NFS share is unresponsive. Signed-off-by: Peter

[Qemu-devel] [PATCH] target-i386: add a list of enforceable CPU models to the help output

2015-08-24 Thread Peter Lieven
this patch adds a probe that lists all enforceable and migrateable CPU models to the -cpu help output. The idea is to know a priory which CPU modules can be exposed to the user without loosing any feature flags. Signed-off-by: Peter Lieven p...@kamp.de --- target-i386/cpu.c | 49

[Qemu-devel] CPU Model kvm64 and Windows2012R2

2015-08-24 Thread Peter Lieven
Hi, I noticed that Win2012R2 will not boot with CPU model kvm64. The reason is that the feature lahf_lm is missing. Is that an error or correct? Thanks, Peter

Re: [Qemu-devel] [PATCH] target-i386: add a list of enforceable CPU models to the help output

2015-08-24 Thread Peter Lieven
Am 24.08.2015 um 17:46 schrieb Eric Blake: On 08/24/2015 03:17 AM, Peter Lieven wrote: this patch adds a probe that lists all enforceable and migrateable CPU models to the -cpu help output. The idea is to know a priory which CPU modules can be exposed to the user without loosing any feature

Re: [Qemu-devel] [PATCH] target-i386: add a list of enforceable CPU models to the help output

2015-08-24 Thread Peter Lieven
Am 24.08.2015 um 22:22 schrieb Andreas Färber afaer...@suse.de: Hi, Am 24.08.2015 um 03:17 schrieb Peter Lieven: this patch adds a probe that lists all enforceable and migrateable CPU models to the -cpu help output. The idea is to know a priory which CPU modules can be exposed

Re: [Qemu-devel] [PATCHv2] block/nfs: cache allocated filesize for read-only files

2015-08-24 Thread Peter Lieven
Am 24.08.2015 um 20:39 schrieb Max Reitz: On 24.08.2015 10:06, Peter Lieven wrote: If the file is readonly its not expected to grow so save the blocking call to nfs_fstat_async and use the value saved at connection time. Also important the monitor (and thus the main loop) will not hang

Re: [Qemu-devel] [PATCH] block/nfs: cache allocated filesize for read-only files

2015-08-21 Thread Peter Lieven
Am 21.08.2015 um 18:46 schrieb Max Reitz: On 2015-08-21 at 00:49, Peter Lieven wrote: If the file is readonly its not expected to grow so save the blocking call to nfs_fstat_async and use the value saved at connection time. Also important the monitor (and thus the main loop) will not hang

[Qemu-devel] [PATCH] block/nfs: cache allocated filesize for read-only files

2015-08-21 Thread Peter Lieven
If the file is readonly its not expected to grow so save the blocking call to nfs_fstat_async and use the value saved at connection time. Also important the monitor (and thus the main loop) will not hang if block device info is queried and the NFS share is unresponsive. Signed-off-by: Peter

[Qemu-devel] [PATCH 2/2] ide/atapi: partially avoid deadlock if the storage backend is dead

2015-08-20 Thread Peter Lieven
if the mounted CDROM is not used and was just not unmounted after usage. This approach avoids the blk_drain_all for read-only media and cancelles the AIO locally and makes the callback a NOP if the original request is completed after the NFS share is responsive again. Signed-off-by: Peter Lieven p

[Qemu-devel] [PATCH 0/2] ide/atapi: partially avoid deadlock if the storage backend is dead

2015-08-20 Thread Peter Lieven
if the mounted CDROM is not used and was just not unmounted after usage. This approach avoids the blk_drain_all for read-only media and cancelles the AIO locally and makes the callback a NOP if the original request is completed after the NFS share is responsive again. Peter Lieven (2): block/io

[Qemu-devel] [PATCH] block/nfs: fix calculation of allocated file size

2015-08-20 Thread Peter Lieven
st.st_blocks is always counted in 512 byte units. Do not use st.st_blksize as multiplicator which may be larger. Cc: qemu-sta...@nongnu.org Signed-off-by: Peter Lieven p...@kamp.de --- block/nfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/nfs.c b/block/nfs.c index

[Qemu-devel] [PATCH 1/2] block/io: allow AIOCB without callback

2015-08-20 Thread Peter Lieven
-off-by: Peter Lieven p...@kamp.de --- block/io.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/block/io.c b/block/io.c index d4bc83b..e628581 100644 --- a/block/io.c +++ b/block/io.c @@ -2007,7 +2007,9 @@ static void bdrv_aio_bh_cb(void *opaque

Re: [Qemu-devel] Help debugging a regression in KVM Module

2015-08-18 Thread Peter Lieven
Am 14.08.2015 um 22:01 schrieb Alex Bennée: Peter Lieven p...@kamp.de writes: Hi, some time a go I stumbled across a regression in the KVM Module that has been introduced somewhere between 3.17 and 3.19. I have a rather old openSUSE guest with an XFS filesystem which realiably crashes

Re: [Qemu-devel] Help debugging a regression in KVM Module

2015-08-18 Thread Peter Lieven
Am 18.08.2015 um 17:25 schrieb Radim Krčmář rkrc...@redhat.com: 2015-08-18 16:54+0200, Peter Lieven: After some experiments I was able to find out the bad commit that introduced the regression: commit f30ebc312ca9def25650b4e1d01cdb425c310dca Author: Radim Krčmář rkrc...@redhat.com

Re: [Qemu-devel] Help debugging a regression in KVM Module

2015-08-17 Thread Peter Lieven
Am 14.08.2015 um 22:01 schrieb Alex Bennée: Peter Lieven p...@kamp.de writes: Hi, some time a go I stumbled across a regression in the KVM Module that has been introduced somewhere between 3.17 and 3.19. I have a rather old openSUSE guest with an XFS filesystem which realiably crashes

Re: [Qemu-devel] [Qemu-block] RFC cdrom in own thread?

2015-08-15 Thread Peter Lieven
Am 14.08.2015 um 16:45 schrieb Peter Lieven: Am 14.08.2015 um 16:08 schrieb Kevin Wolf: Am 14.08.2015 um 15:43 hat Peter Lieven geschrieben: Am 22.06.2015 um 23:54 schrieb John Snow: On 06/22/2015 09:09 AM, Peter Lieven wrote: Am 22.06.2015 um 11:25 schrieb Stefan Hajnoczi: On Fri, Jun 19

[Qemu-devel] Help debugging a regression in KVM Module

2015-08-14 Thread Peter Lieven
Hi, some time a go I stumbled across a regression in the KVM Module that has been introduced somewhere between 3.17 and 3.19. I have a rather old openSUSE guest with an XFS filesystem which realiably crashes after some live migrations. I originally believed that the issue might be related to

[Qemu-devel] [PATCH] block/iscsi: validate block size returned from target

2015-08-14 Thread Peter Lieven
Signed-off-by: Peter Lieven p...@kamp.de --- block/iscsi.c | 4 dtc | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/block/iscsi.c b/block/iscsi.c index 5002916..fac3a7a 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -1214,6 +1214,10 @@ static void

Re: [Qemu-devel] [Qemu-block] RFC cdrom in own thread?

2015-08-14 Thread Peter Lieven
Am 22.06.2015 um 23:54 schrieb John Snow: On 06/22/2015 09:09 AM, Peter Lieven wrote: Am 22.06.2015 um 11:25 schrieb Stefan Hajnoczi: On Fri, Jun 19, 2015 at 2:14 PM, Peter Lieven p...@kamp.de wrote: Am 18.06.2015 um 11:36 schrieb Stefan Hajnoczi: On Thu, Jun 18, 2015 at 10:29 AM, Peter

Re: [Qemu-devel] [Qemu-block] RFC cdrom in own thread?

2015-08-14 Thread Peter Lieven
Am 14.08.2015 um 16:08 schrieb Kevin Wolf: Am 14.08.2015 um 15:43 hat Peter Lieven geschrieben: Am 22.06.2015 um 23:54 schrieb John Snow: On 06/22/2015 09:09 AM, Peter Lieven wrote: Am 22.06.2015 um 11:25 schrieb Stefan Hajnoczi: On Fri, Jun 19, 2015 at 2:14 PM, Peter Lieven p...@kamp.de

Re: [Qemu-devel] [Qemu-block] RFC cdrom in own thread?

2015-08-14 Thread Peter Lieven
Am 14.08.2015 um 16:08 schrieb Kevin Wolf: Am 14.08.2015 um 15:43 hat Peter Lieven geschrieben: Am 22.06.2015 um 23:54 schrieb John Snow: On 06/22/2015 09:09 AM, Peter Lieven wrote: Am 22.06.2015 um 11:25 schrieb Stefan Hajnoczi: On Fri, Jun 19, 2015 at 2:14 PM, Peter Lieven p...@kamp.de

Re: [Qemu-devel] Help debugging a regression in KVM Module

2015-08-14 Thread Peter Lieven
Am 14.08.2015 um 15:01 schrieb Paolo Bonzini: - Original Message - From: Peter Lieven p...@kamp.de To: qemu-devel@nongnu.org, k...@vger.kernel.org Cc: Paolo Bonzini pbonz...@redhat.com Sent: Friday, August 14, 2015 1:11:34 PM Subject: Help debugging a regression in KVM Module Hi

Re: [Qemu-devel] [Bug 1483070] [NEW] VIRTIO Sequential Write IOPS limits not working

2015-08-13 Thread Peter Lieven
throttling checks. Currently QEMU's I/O queue plug/unplug isn't advanced enough to do the request merging, so it's done earlier in the virtio-blk emulation code. I've CCed Kevin Wolf, Alberto Garcia, and Peter Lieven who may have more thoughts on this. I wouldn't consider this behavior bad

Re: [Qemu-devel] [Qemu-stable] Recent patches for 2.4

2015-08-06 Thread Peter Lieven
Am 05.08.2015 um 10:39 schrieb Paolo Bonzini: On 05/08/2015 01:23, ronnie sahlberg wrote: You only get 0 from this call if there are actual bytes available to read. For context, the problem was that 75 static void nfs_process_read(void *arg) 76 { 77 NFSClient *client = arg;

Re: [Qemu-devel] [Qemu-stable] Recent patches for 2.4

2015-08-04 Thread Peter Lieven
Am 04.08.2015 um 14:29 schrieb Peter Lieven: Am 04.08.2015 um 14:09 schrieb Paolo Bonzini: On 04/08/2015 13:57, Peter Lieven wrote: Okay, what I found out is that in aio_poll I get revents = POLLIN for the nfs file descriptor. But there is no data available on the socket. Does read return 0

Re: [Qemu-devel] [Qemu-stable] Recent patches for 2.4

2015-08-04 Thread Peter Lieven
Am 04.08.2015 um 14:09 schrieb Paolo Bonzini: On 04/08/2015 13:57, Peter Lieven wrote: Okay, what I found out is that in aio_poll I get revents = POLLIN for the nfs file descriptor. But there is no data available on the socket. Does read return 0 or EAGAIN? If it returns EAGAIN, the bug

Re: [Qemu-devel] [Qemu-stable] Recent patches for 2.4

2015-08-04 Thread Peter Lieven
Am 04.08.2015 um 13:53 schrieb Paolo Bonzini: On 04/08/2015 11:22, Peter Lieven wrote: edec47c main-loop: fix qemu_notify_event for aio_notify optimization Part of the above AioContext series. So either the whole series or none of them I guess? It's a separate bug, and theoretically it's

Re: [Qemu-devel] [Qemu-stable] Recent patches for 2.4

2015-08-04 Thread Peter Lieven
Am 31.07.2015 um 11:29 schrieb Paolo Bonzini: On 31/07/2015 10:35, Peter Lieven wrote: Am 31.07.2015 um 10:22 schrieb Paolo Bonzini: 52c91da memory: do not add a reference to the owner of aliased regions This could be backported, yes. Feel free to send it to qemu-stable. However, the bug

Re: [Qemu-devel] Forbid to pass lun 0 to iscsi driver

2015-08-03 Thread Peter Lieven
Am 02.08.2015 um 13:42 schrieb Andrey Korolyov: Hello, As we will never pass LUN#0 as a storage lun, it would be better to prohibit this at least in iscsi.c, otherwise it will result in an FPU exception and emulator crash: traps: qemu-system-x86[32430] trap divide error ip:7f1dab7b5073

Re: [Qemu-devel] Forbid to pass lun 0 to iscsi driver

2015-08-03 Thread Peter Lieven
Am 03.08.2015 um 09:47 schrieb Andrey Korolyov: On Mon, Aug 3, 2015 at 9:45 AM, Peter Lieven p...@kamp.de wrote: Am 02.08.2015 um 13:42 schrieb Andrey Korolyov: Hello, As we will never pass LUN#0 as a storage lun, it would be better to prohibit this at least in iscsi.c, otherwise

Re: [Qemu-devel] Forbid to pass lun 0 to iscsi driver

2015-08-03 Thread Peter Lieven
Am 03.08.2015 um 10:13 schrieb Paolo Bonzini: On 03/08/2015 09:47, Andrey Korolyov wrote: I`ve mistyped lun for tgtd upon volume hotplug, which resulted in an accidental crash, there is nothing but human factor. Until only LUN0 may possess such unusual properties, I`d vote to explicitly work

[Qemu-devel] QMP greeting sometimes does not show up

2015-07-31 Thread Peter Lieven
Hi, I recently had some cases of the QMP greeting not showing up on a vServer configured for incoming migration. Not showing up in a reasonable amount of time (5 second timeout in my case) at least. I retry and retry and suddenly in some cases after 30-60 seconds after vServer setup the

[Qemu-devel] Recent patches for 2.4

2015-07-31 Thread Peter Lieven
Hi Paolo, hi Stefan, you submitted some fixes for 2.4 recently. None of the folloing had qemu-stable in CC. Is this not stable material? ca96ac4 AioContext: force event loop iteration using BH a076972 AioContext: avoid leaking BHs on cleanup fed105e virtio-blk-dataplane: delete bottom half

Re: [Qemu-devel] Recent patches for 2.4

2015-07-31 Thread Peter Lieven
Am 31.07.2015 um 10:22 schrieb Paolo Bonzini: On 31/07/2015 10:12, Peter Lieven wrote: Hi Paolo, hi Stefan, you submitted some fixes for 2.4 recently. None of the folloing had qemu-stable in CC. Is this not stable material? In general I send less and less patches to qemu-stable as we get

Re: [Qemu-devel] [Qemu-stable] [PULL 0/3] Cve 2015 5154 patches

2015-07-27 Thread Peter Lieven
Am 27.07.2015 um 15:38 schrieb Kevin Wolf: Am 27.07.2015 um 15:25 hat Stefan Priebe - Profihost AG geschrieben: Am 27.07.2015 um 14:28 schrieb John Snow: On 07/27/2015 08:10 AM, Stefan Priebe - Profihost AG wrote: Am 27.07.2015 um 14:01 schrieb John Snow: The following changes since commit

Re: [Qemu-devel] [Qemu-stable] [PULL 0/3] Cve 2015 5154 patches

2015-07-27 Thread Peter Lieven
Am 27.07.2015 um 15:54 schrieb Kevin Wolf: Am 27.07.2015 um 15:46 hat Peter Lieven geschrieben: Am 27.07.2015 um 15:38 schrieb Kevin Wolf: Am 27.07.2015 um 15:25 hat Stefan Priebe - Profihost AG geschrieben: Am 27.07.2015 um 14:28 schrieb John Snow: On 07/27/2015

Re: [Qemu-devel] [PATCH for-2.5 1/4] block: add BlockLimits.max_iov field

2015-07-08 Thread Peter Lieven
the limit into BlockLimits. Cc: Peter Lieven p...@kamp.de Suggested-by: Kevin Wolf kw...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- Peter Lieven: I think the SCSI LUN level does not have a maximum scatter-gather segments constraint. That is probably only at the HBA level. CCed

Re: [Qemu-devel] vpc size reporting problem

2015-07-07 Thread Peter Lieven
Am 07.07.2015 um 07:59 schrieb Chun Yan Liu: On 7/7/2015 at 01:50 PM, in message 559b68b2.5060...@kamp.de, Peter Lieven p...@kamp.de wrote: Am 07.07.2015 um 03:50 schrieb Chun Yan Liu: On 7/6/2015 at 06:42 PM, in message 559a5b79.4010...@kamp.de, Peter Lieven p...@kamp.de wrote: Am

Re: [Qemu-devel] vpc size reporting problem

2015-07-07 Thread Peter Lieven
Am 07.07.2015 um 08:34 schrieb Chun Yan Liu: On 7/7/2015 at 02:19 PM, in message 559B6F79.237 : 102 : 21807, Chun Yan Liu wrote: On 7/7/2015 at 02:03 PM, in message 559b6bbe.3050...@kamp.de, Peter Lieven p...@kamp.de wrote: Am 07.07.2015 um 07:59 schrieb Chun Yan Liu: On 7/7/2015

[Qemu-devel] [PATCH V3] block/nfs: add support for setting debug level

2015-07-07 Thread Peter Lieven
upcoming libnfs versions will support logging debug messages. Add support for it in qemu through a per-drive option. Examples: qemu -drive if=virtio,file=nfs://...,file.debug=2 qemu-img create -o debug=2 nfs://... 10G Signed-off-by: Peter Lieven p...@kamp.de --- v2-v3: use a per-drive option

Re: [Qemu-devel] vpc size reporting problem

2015-07-07 Thread Peter Lieven
Am 07.07.2015 um 08:19 schrieb Chun Yan Liu: On 7/7/2015 at 02:03 PM, in message 559b6bbe.3050...@kamp.de, Peter Lieven p...@kamp.de wrote: Am 07.07.2015 um 07:59 schrieb Chun Yan Liu: On 7/7/2015 at 01:50 PM, in message 559b68b2.5060...@kamp.de, Peter Lieven p...@kamp.de wrote: Am

Re: [Qemu-devel] [PULL for-2.4 3/7] block/nfs: add support for setting debug level

2015-07-07 Thread Peter Lieven
Am 07.07.2015 um 14:08 schrieb Stefan Hajnoczi: From: Peter Lieven p...@kamp.de upcoming libnfs versions will support logging debug messages. Add support for it in qemu through a per-drive option. Examples: qemu -drive if=virtio,file=nfs://...,file.debug=2 qemu-img create -o debug=2 nfs

Re: [Qemu-devel] [PULL for-2.4 3/7] block/nfs: add support for setting debug level

2015-07-07 Thread Peter Lieven
Am 07.07.2015 um 15:24 schrieb Stefan Hajnoczi: On Tue, Jul 7, 2015 at 1:08 PM, Stefan Hajnoczi stefa...@redhat.com wrote: From: Peter Lieven p...@kamp.de upcoming libnfs versions will support logging debug messages. Add support for it in qemu through a per-drive option. Examples: qemu

Re: [Qemu-devel] vpc size reporting problem

2015-07-06 Thread Peter Lieven
Am 06.07.2015 um 11:44 schrieb Chun Yan Liu: While testing with a 1GB VHD file created on win7, found that the VHD file size reported on Windows is different from that is reported by qemu-img info or within a Linux KVM guest. Created a dynamic VHD file on win7, on Windows, it is reported 1024MB

Re: [Qemu-devel] vpc size reporting problem

2015-07-06 Thread Peter Lieven
Am 07.07.2015 um 03:50 schrieb Chun Yan Liu: On 7/6/2015 at 06:42 PM, in message 559a5b79.4010...@kamp.de, Peter Lieven p...@kamp.de wrote: Am 06.07.2015 um 11:44 schrieb Chun Yan Liu: While testing with a 1GB VHD file created on win7, found that the VHD file size reported on Windows

[Qemu-devel] [PATCH] block/iscsi: restore compatiblity with libiscsi 1.9.0

2015-06-26 Thread Peter Lieven
RHEL7 and others are stuck with libiscsi 1.9.0 since there unfortunately was an ABI breakage after that release. Signed-off-by: Peter Lieven p...@kamp.de --- block/iscsi.c | 31 ++- configure |6 +++--- qemu-options.hx |3 ++- 3 files changed, 31

Re: [Qemu-devel] [Qemu-block] [PATCH] block/nfs: add support for setting debug level

2015-06-26 Thread Peter Lieven
Am 26.06.2015 um 11:14 schrieb Stefan Hajnoczi: On Thu, Jun 25, 2015 at 03:26:46PM +0200, Peter Lieven wrote: Am 25.06.2015 um 15:18 schrieb Stefan Hajnoczi: On Tue, Jun 23, 2015 at 10:12:15AM +0200, Peter Lieven wrote: upcoming libnfs versions will support logging debug messages. Add support

[Qemu-devel] [PATCH] block/nfs: limit maximum readahead size to 1MB

2015-06-26 Thread Peter Lieven
a malicious caller could otherwise specify a very large value via the URI and force libnfs to allocate a large amount of memory for the readahead buffer. Cc: qemu-sta...@nongnu.org Signed-off-by: Peter Lieven p...@kamp.de --- block/nfs.c |7 +++ 1 file changed, 7 insertions(+) diff

[Qemu-devel] [PATCH V2] block/iscsi: restore compatiblity with libiscsi 1.9.0

2015-06-26 Thread Peter Lieven
RHEL7 and others are stuck with libiscsi 1.9.0 since there unfortunately was an ABI breakage after that release. Signed-off-by: Peter Lieven p...@kamp.de --- v1-v2: - do not use reserved macro names [Paolo] - change text in qemu-options.hx to libiscsi 1.15.0 or greater block/iscsi.c

[Qemu-devel] [PATCH V2] block/nfs: add support for setting debug level

2015-06-26 Thread Peter Lieven
upcoming libnfs versions will support logging debug messages. Add support for it in qemu through a cmdline parameter. Example qemu -nfs debug=99 -cdrom nfs://... Signed-off-by: Peter Lieven p...@kamp.de --- v1-v2: reworked patch to accept the debug level as a cmdline parameter instead

Re: [Qemu-devel] [Qemu-block] [PATCH] block/nfs: add support for setting debug level

2015-06-25 Thread Peter Lieven
Am 25.06.2015 um 15:18 schrieb Stefan Hajnoczi: On Tue, Jun 23, 2015 at 10:12:15AM +0200, Peter Lieven wrote: upcoming libnfs versions will support logging debug messages. Add support for it in qemu through an URL parameter. Signed-off-by: Peter Lieven p...@kamp.de --- block/nfs.c | 4

Re: [Qemu-devel] [PATCH] block/iscsi: add support for request timeouts

2015-06-25 Thread Peter Lieven
Am 25.06.2015 um 23:08 schrieb Paolo Bonzini: On 16/06/2015 13:45, Peter Lieven wrote: libiscsi starting with 1.15 will properly support timeout of iscsi commands. The default will remain no timeout, but this can be changed via cmdline parameters, e.g.: qemu -iscsi timeout=30 -drive file

Re: [Qemu-devel] [PATCH] block/iscsi: add support for request timeouts

2015-06-25 Thread Peter Lieven
Am 23.06.2015 um 01:03 schrieb ronnie sahlberg: LGTM It is good to finally have timeouts that work in libiscsi, and a consumer that can use and benefit from it. Paolo, Kevin, Stefan, do you think this is sth for 2.4? Peter

Re: [Qemu-devel] [Qemu-block] RFC cdrom in own thread?

2015-06-23 Thread Peter Lieven
Am 22.06.2015 um 23:54 schrieb John Snow: On 06/22/2015 09:09 AM, Peter Lieven wrote: Am 22.06.2015 um 11:25 schrieb Stefan Hajnoczi: On Fri, Jun 19, 2015 at 2:14 PM, Peter Lieven p...@kamp.de wrote: Am 18.06.2015 um 11:36 schrieb Stefan Hajnoczi: On Thu, Jun 18, 2015 at 10:29 AM, Peter

[Qemu-devel] [PATCH] block/nfs: add support for setting debug level

2015-06-23 Thread Peter Lieven
upcoming libnfs versions will support logging debug messages. Add support for it in qemu through an URL parameter. Signed-off-by: Peter Lieven p...@kamp.de --- block/nfs.c | 4 1 file changed, 4 insertions(+) diff --git a/block/nfs.c b/block/nfs.c index ca9e24e..f7388a3 100644 --- a/block

Re: [Qemu-devel] [Qemu-block] RFC cdrom in own thread?

2015-06-22 Thread Peter Lieven
Am 22.06.2015 um 11:25 schrieb Stefan Hajnoczi: On Fri, Jun 19, 2015 at 2:14 PM, Peter Lieven p...@kamp.de wrote: Am 18.06.2015 um 11:36 schrieb Stefan Hajnoczi: On Thu, Jun 18, 2015 at 10:29 AM, Peter Lieven p...@kamp.de wrote: Am 18.06.2015 um 10:42 schrieb Kevin Wolf: Am 18.06.2015 um 10

Re: [Qemu-devel] [Qemu-block] RFC cdrom in own thread?

2015-06-19 Thread Peter Lieven
Am 18.06.2015 um 11:36 schrieb Stefan Hajnoczi: On Thu, Jun 18, 2015 at 10:29 AM, Peter Lieven p...@kamp.de wrote: Am 18.06.2015 um 10:42 schrieb Kevin Wolf: Am 18.06.2015 um 10:30 hat Peter Lieven geschrieben: Am 18.06.2015 um 09:45 schrieb Kevin Wolf: Am 18.06.2015 um 09:12 hat Peter Lieven

Re: [Qemu-devel] [Qemu-block] RFC cdrom in own thread?

2015-06-18 Thread Peter Lieven
Am 17.06.2015 um 10:35 schrieb Kevin Wolf: Am 16.06.2015 um 17:34 hat Stefan Hajnoczi geschrieben: On Tue, Jun 16, 2015 at 3:44 PM, Peter Lieven p...@kamp.de wrote: I wonder how difficult it would be to have the IDE CDROM run in its own thread? We usually have ISOs mounted on an NFS share

Re: [Qemu-devel] [Qemu-block] RFC cdrom in own thread?

2015-06-18 Thread Peter Lieven
Am 18.06.2015 um 08:59 schrieb Paolo Bonzini: On 18/06/2015 08:39, Peter Lieven wrote: It seems like the mainloop is waiting here: #0 0x7606c89c in __lll_lock_wait () from /lib/x86_64-linux-gnu/libpthread.so.0 No symbol table info available. #1 0x76068065 in _L_lock_858

Re: [Qemu-devel] [Qemu-block] RFC cdrom in own thread?

2015-06-18 Thread Peter Lieven
Am 18.06.2015 um 09:03 schrieb Peter Lieven: Am 18.06.2015 um 08:59 schrieb Paolo Bonzini: On 18/06/2015 08:39, Peter Lieven wrote: It seems like the mainloop is waiting here: #0 0x7606c89c in __lll_lock_wait () from /lib/x86_64-linux-gnu/libpthread.so.0 No symbol table info

Re: [Qemu-devel] [Qemu-block] RFC cdrom in own thread?

2015-06-18 Thread Peter Lieven
Am 18.06.2015 um 11:36 schrieb Stefan Hajnoczi: On Thu, Jun 18, 2015 at 10:29 AM, Peter Lieven p...@kamp.de wrote: Am 18.06.2015 um 10:42 schrieb Kevin Wolf: Am 18.06.2015 um 10:30 hat Peter Lieven geschrieben: Am 18.06.2015 um 09:45 schrieb Kevin Wolf: Am 18.06.2015 um 09:12 hat Peter

Re: [Qemu-devel] [Qemu-block] RFC cdrom in own thread?

2015-06-18 Thread Peter Lieven
Am 18.06.2015 um 10:42 schrieb Kevin Wolf: Am 18.06.2015 um 10:30 hat Peter Lieven geschrieben: Am 18.06.2015 um 09:45 schrieb Kevin Wolf: Am 18.06.2015 um 09:12 hat Peter Lieven geschrieben: Thread 2 (Thread 0x75550700 (LWP 2636)): #0 0x75d87aa3 in ppoll () from /lib/x86_64

Re: [Qemu-devel] [Qemu-block] RFC cdrom in own thread?

2015-06-18 Thread Peter Lieven
Am 18.06.2015 um 09:45 schrieb Kevin Wolf: Am 18.06.2015 um 09:12 hat Peter Lieven geschrieben: Thread 2 (Thread 0x75550700 (LWP 2636)): #0 0x75d87aa3 in ppoll () from /lib/x86_64-linux-gnu/libc.so.6 No symbol table info available. #1 0x55955d91 in qemu_poll_ns (fds

Re: [Qemu-devel] [Qemu-block] RFC cdrom in own thread?

2015-06-18 Thread Peter Lieven
Am 18.06.2015 um 10:42 schrieb Kevin Wolf: Am 18.06.2015 um 10:30 hat Peter Lieven geschrieben: Am 18.06.2015 um 09:45 schrieb Kevin Wolf: Am 18.06.2015 um 09:12 hat Peter Lieven geschrieben: Thread 2 (Thread 0x75550700 (LWP 2636)): #0 0x75d87aa3 in ppoll () from /lib/x86_64

Re: [Qemu-devel] [Qemu-block] RFC cdrom in own thread?

2015-06-18 Thread Peter Lieven
Am 17.06.2015 um 10:35 schrieb Kevin Wolf: Am 16.06.2015 um 17:34 hat Stefan Hajnoczi geschrieben: On Tue, Jun 16, 2015 at 3:44 PM, Peter Lieven p...@kamp.de wrote: I wonder how difficult it would be to have the IDE CDROM run in its own thread? We usually have ISOs mounted on an NFS share

Re: [Qemu-devel] Windows2012R2 virtio-win drivers and IPv6

2015-06-16 Thread Peter Lieven
Hi Yan, thanks for the reply. * When you experience the issues is it between VMs on the same host? I can reproduce it between a Windows VM on Host A and a Linux VM on Host B. Linux and Windows are not on the same host systems due to licensing. Between Linux VMs and/or if I download to the

[Qemu-devel] [PATCH] block/iscsi: add support for request timeouts

2015-06-16 Thread Peter Lieven
the libiscsi requirement to 1.10 to have all function and macros defined. The patch fixes also a off-by-one error in the NOP timeout calculation which was fixed while touching these code parts. Signed-off-by: Peter Lieven p...@kamp.de --- block/iscsi.c | 87

Re: [Qemu-devel] Windows2012R2 virtio-win drivers and IPv6

2015-06-08 Thread Peter Lieven
Am 28.05.2015 um 16:24 schrieb Vadim Rozenfeld: On Thu, 2015-05-28 at 16:07 +0200, Peter Lieven wrote: Hi, we observed problems with Windows Update Services and Uploading Files from a Windows System to other systems. We tracked this down to IPv6 connections only. IPv4 and IPv6 in Receive

[Qemu-devel] Windows2012R2 virtio-win drivers and IPv6

2015-05-28 Thread Peter Lieven
Hi, we observed problems with Windows Update Services and Uploading Files from a Windows System to other systems. We tracked this down to IPv6 connections only. IPv4 and IPv6 in Receive direction seems to be not a problem. It turned out that setting TCP/UDP Checksum Offloading for IPv6 from

Re: [Qemu-devel] [Qemu-stable] [PATCH v5 3/8] mirror: Do zero write on target if sectors not allocated

2015-05-25 Thread Peter Lieven
Am 26.05.2015 um 05:36 schrieb Fam Zheng: If guest discards a source cluster, mirroring with bdrv_aio_readv is overkill. Some protocols do zero upon discard, where it's best to use bdrv_aio_write_zeroes, otherwise, bdrv_aio_discard will be enough. Signed-off-by: Fam Zheng f...@redhat.com ---

Re: [Qemu-devel] [Qemu-stable] [PATCH] fdc: force the fifo access to be in bounds of the allocated buffer

2015-05-13 Thread Peter Lieven
Am 13.05.2015 um 21:09 schrieb Stefan Priebe: Am 13.05.2015 um 21:05 schrieb Stefan Weil: Am 13.05.2015 um 20:59 schrieb Stefan Priebe: Am 13.05.2015 um 20:51 schrieb Stefan Weil: Hi, I just noticed this patch because my provider told me that my KVM based server needs a reboot because of

Re: [Qemu-devel] [Qemu-stable] [PATCH] fdc: force the fifo access to be in bounds of the allocated buffer

2015-05-13 Thread Peter Lieven
Am 13.05.2015 um 22:03 schrieb John Snow: On 05/13/2015 04:02 PM, Peter Lieven wrote: Am 13.05.2015 um 21:52 schrieb Markus Armbruster: Peter Lieven p...@kamp.de writes: Am 13.05.2015 um 21:09 schrieb Stefan Priebe: Am 13.05.2015 um 21:05 schrieb Stefan Weil: Am 13.05.2015 um 20:59 schrieb

Re: [Qemu-devel] [Qemu-stable] [PATCH] fdc: force the fifo access to be in bounds of the allocated buffer

2015-05-13 Thread Peter Lieven
Am 13.05.2015 um 21:52 schrieb Markus Armbruster: Peter Lieven p...@kamp.de writes: Am 13.05.2015 um 21:09 schrieb Stefan Priebe: Am 13.05.2015 um 21:05 schrieb Stefan Weil: Am 13.05.2015 um 20:59 schrieb Stefan Priebe: Am 13.05.2015 um 20:51 schrieb Stefan Weil: Hi, I just noticed

Re: [Qemu-devel] [PATCH for-2.4 07/10] block/iscsi: bump libiscsi requirement to 1.10.0

2015-04-17 Thread Peter Lieven
Am 16.04.2015 um 15:20 schrieb Paolo Bonzini: On 16/04/2015 14:58, Peter Lieven wrote: On 16/04/2015 14:18, Peter Lieven wrote: We need this to support SCSI_STATUS_TASK_SET_FULL. Any reason apart from the missing constant? No, but I wanted to avoid starting checking for constants that were

Re: [Qemu-devel] [PATCH for-2.4 05/10] block/iscsi: optimize WRITE10/16 if cache.writeback is not set

2015-04-17 Thread Peter Lieven
Am 16.04.2015 um 15:17 schrieb Paolo Bonzini: On 16/04/2015 15:02, Peter Lieven wrote: Also, I think it is iscsi_co_generic_cb that should set force_next_flush, so that it is only set on failure. Not really for the optimization value, but because it's clearer. I don't get what you mean

[Qemu-devel] [PATCH for-2.4 09/10] block/iscsi: bump year in copyright notice

2015-04-16 Thread Peter Lieven
Signed-off-by: Peter Lieven p...@kamp.de --- block/iscsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/iscsi.c b/block/iscsi.c index 3d0ffeb..04c1309 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -2,7 +2,7 @@ * QEMU Block driver for iSCSI images

[Qemu-devel] [PATCH for-2.4 06/10] block/iscsi: increase retry count

2015-04-16 Thread Peter Lieven
The idea is that a command is retried in a BUSY condition up a time of approx. 60 seconds before it is failed. This should be far higher than any command timeout in the guest. Signed-off-by: Peter Lieven p...@kamp.de --- block/iscsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [Qemu-devel] [PATCH for-2.4 05/10] block/iscsi: optimize WRITE10/16 if cache.writeback is not set

2015-04-16 Thread Peter Lieven
Am 16.04.2015 um 14:42 schrieb Paolo Bonzini: On 16/04/2015 14:18, Peter Lieven wrote: SCSI allowes to tell the target to not return from a write command if the date is not written to the disk. Use this so called FUA bit if it is supported to optimize WRITE commands if writeback is not allowed

[Qemu-devel] [PATCH for-2.4 01/10] block/iscsi: do not forget to logout from target

2015-04-16 Thread Peter Lieven
We actually were always impolitely dropping the connection and not cleanly logging out. CC: qemu-sta...@nongnu.org Signed-off-by: Peter Lieven p...@kamp.de --- block/iscsi.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/block/iscsi.c b/block/iscsi.c index ba33290..be8af46 100644

[Qemu-devel] [PATCH for-2.4 04/10] block/iscsi: store DPOFUA bit from the modesense command

2015-04-16 Thread Peter Lieven
Signed-off-by: Peter Lieven p...@kamp.de --- block/iscsi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/iscsi.c b/block/iscsi.c index 221c9fc..237faa1 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -66,6 +66,7 @@ typedef struct IscsiLun { bool write_protected; bool

Re: [Qemu-devel] [PATCH for-2.4 07/10] block/iscsi: bump libiscsi requirement to 1.10.0

2015-04-16 Thread Peter Lieven
Am 16.04.2015 um 14:33 schrieb Paolo Bonzini: On 16/04/2015 14:18, Peter Lieven wrote: We need this to support SCSI_STATUS_TASK_SET_FULL. Any reason apart from the missing constant? No, but I wanted to avoid starting checking for constants that were added shortly after this. You can't

[Qemu-devel] [PATCH for-2.4 08/10] block/iscsi: handle SCSI_STATUS_TASK_SET_FULL

2015-04-16 Thread Peter Lieven
a target may issue a SCSI_STATUS_TASK_SET_FULL status if there is more than one BUSY command queued already. Signed-off-by: Peter Lieven p...@kamp.de --- block/iscsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index a4902ea..3d0ffeb

[Qemu-devel] [PATCH for-2.4 07/10] block/iscsi: bump libiscsi requirement to 1.10.0

2015-04-16 Thread Peter Lieven
We need this to support SCSI_STATUS_TASK_SET_FULL. Signed-off-by: Peter Lieven p...@kamp.de --- configure | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/configure b/configure index 6969f6f..f73b8d0 100755 --- a/configure +++ b/configure @@ -3630,15 +3630,15

[Qemu-devel] [PATCH for-2.4 10/10] block/iscsi: use the allocationmap also if cache.direct=on

2015-04-16 Thread Peter Lieven
-by: Peter Lieven p...@kamp.de --- block/iscsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/iscsi.c b/block/iscsi.c index 04c1309..0737354 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -1495,7 +1495,7 @@ static int iscsi_open(BlockDriverState *bs, QDict *options, int

[Qemu-devel] [PATCH for-2.4 03/10] block/iscsi: rename iscsi_write_protected and let it return void

2015-04-16 Thread Peter Lieven
Signed-off-by: Peter Lieven p...@kamp.de --- block/iscsi.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index 6cf7e99..221c9fc 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -1253,11 +1253,11 @@ static void

[Qemu-devel] [PATCH for-2.4 02/10] block/iscsi: change all iscsilun properties from uint8_t to bool

2015-04-16 Thread Peter Lieven
Signed-off-by: Peter Lieven p...@kamp.de --- block/iscsi.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index be8af46..6cf7e99 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -57,9 +57,6 @@ typedef struct IscsiLun { int

[Qemu-devel] [PATCH for-2.4 00/10] various improvements for the iSCSI driver

2015-04-16 Thread Peter Lieven
Peter Lieven (10): block/iscsi: do not forget to logout from target block/iscsi: change all iscsilun properties from uint8_t to bool block/iscsi: rename iscsi_write_protected and let it return void block/iscsi: store DPOFUA bit from the modesense command block/iscsi: optimize WRITE10/16

[Qemu-devel] [PATCH for-2.4 05/10] block/iscsi: optimize WRITE10/16 if cache.writeback is not set

2015-04-16 Thread Peter Lieven
. If we set the FUA bit we can ignore the following FLUSH. Signed-off-by: Peter Lieven p...@kamp.de --- block/iscsi.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index 237faa1..7fb04d7 100644 --- a/block/iscsi.c +++ b/block

[Qemu-devel] [PATCH for-2.4 V2 8/9] block/iscsi: bump year in copyright notice

2015-04-16 Thread Peter Lieven
Signed-off-by: Peter Lieven p...@kamp.de --- block/iscsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/iscsi.c b/block/iscsi.c index 328907b..8364f97 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -2,7 +2,7 @@ * QEMU Block driver for iSCSI images

[Qemu-devel] [PATCH for-2.4 V2 0/9] various improvements for the iSCSI driver

2015-04-16 Thread Peter Lieven
v1-v2: - removed the requirement for libiscsi 1.10.0 [Paolo] - reworked to force_next_flush logic [Paolo] Peter Lieven (9): block/iscsi: do not forget to logout from target block/iscsi: change all iscsilun properties from uint8_t to bool block/iscsi: rename iscsi_write_protected

[Qemu-devel] [PATCH for-2.4 V2 2/9] block/iscsi: change all iscsilun properties from uint8_t to bool

2015-04-16 Thread Peter Lieven
Signed-off-by: Peter Lieven p...@kamp.de --- block/iscsi.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index be8af46..6cf7e99 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -57,9 +57,6 @@ typedef struct IscsiLun { int

[Qemu-devel] [PATCH for-2.4 V2 4/9] block/iscsi: store DPOFUA bit from the modesense command

2015-04-16 Thread Peter Lieven
Signed-off-by: Peter Lieven p...@kamp.de --- block/iscsi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/iscsi.c b/block/iscsi.c index 221c9fc..237faa1 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -66,6 +66,7 @@ typedef struct IscsiLun { bool write_protected; bool

[Qemu-devel] [PATCH for-2.4 V2 3/9] block/iscsi: rename iscsi_write_protected and let it return void

2015-04-16 Thread Peter Lieven
Signed-off-by: Peter Lieven p...@kamp.de --- block/iscsi.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index 6cf7e99..221c9fc 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -1253,11 +1253,11 @@ static void

[Qemu-devel] [PATCH for-2.4 V2 5/9] block/iscsi: optimize WRITE10/16 if cache.writeback is not set

2015-04-16 Thread Peter Lieven
. If we set the FUA bit we can ignore the following FLUSH. Signed-off-by: Peter Lieven p...@kamp.de --- block/iscsi.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index 237faa1..600 100644 --- a/block/iscsi.c +++ b/block

[Qemu-devel] [PATCH for-2.4 V2 7/9] block/iscsi: handle SCSI_STATUS_TASK_SET_FULL

2015-04-16 Thread Peter Lieven
a target may issue a SCSI_STATUS_TASK_SET_FULL status if there is more than one BUSY command queued already. Signed-off-by: Peter Lieven p...@kamp.de --- block/iscsi.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index 5999f74..328907b

[Qemu-devel] [PATCH for-2.4 V2 1/9] block/iscsi: do not forget to logout from target

2015-04-16 Thread Peter Lieven
We actually were always impolitely dropping the connection and not cleanly logging out. CC: qemu-sta...@nongnu.org Signed-off-by: Peter Lieven p...@kamp.de --- block/iscsi.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/block/iscsi.c b/block/iscsi.c index ba33290..be8af46 100644

<    4   5   6   7   8   9   10   11   12   13   >