[Qemu-devel] linux guests and ksm performance

2012-02-23 Thread Peter Lieven
Hi, i have recently been playing with an old idea (originally in grsecurity for security reasons) to change the policy from zero on allocate to zero after free in the linux page allocator. My concern is that linux leaves a lot of waste in the physical memory unlike Windows which per default zeros

Re: [Qemu-devel] linux guests and ksm performance

2012-02-23 Thread Peter Lieven
stefa...@gmail.com schrieb: On Thu, Feb 23, 2012 at 3:40 PM, Peter Lieven p...@dlh.net wrote: However, in a virtual machine I have not observed the above slow down to that extend while the benefit of zero after free in a virtualisation environment is obvious: 1) zero pages can easily

Re: [Qemu-devel] linux guests and ksm performance

2012-02-28 Thread Peter Lieven
On 24.02.2012 08:23, Stefan Hajnoczi wrote: On Fri, Feb 24, 2012 at 6:53 AM, Stefan Hajnoczistefa...@gmail.com wrote: On Fri, Feb 24, 2012 at 6:41 AM, Stefan Hajnoczistefa...@gmail.com wrote: On Thu, Feb 23, 2012 at 7:08 PM, peter.lie...@gmail.comp...@dlh.net wrote: Stefan

Re: [Qemu-devel] qemu-kvm-1.0 crashes with threaded vnc server?

2012-02-28 Thread Peter Lieven
On 28.02.2012 09:37, Corentin Chary wrote: On Mon, Feb 13, 2012 at 10:24 AM, Peter Lievenp...@dlh.net wrote: Am 11.02.2012 um 09:55 schrieb Corentin Chary: On Thu, Feb 9, 2012 at 7:08 PM, Peter Lievenp...@dlh.net wrote: Hi, is anyone aware if there are still problems when enabling the

Re: [Qemu-devel] linux guests and ksm performance

2012-02-28 Thread Peter Lieven
On 28.02.2012 13:05, Stefan Hajnoczi wrote: On Tue, Feb 28, 2012 at 11:46 AM, Peter Lievenp...@dlh.net wrote: On 24.02.2012 08:23, Stefan Hajnoczi wrote: On Fri, Feb 24, 2012 at 6:53 AM, Stefan Hajnoczistefa...@gmail.com wrote: On Fri, Feb 24, 2012 at 6:41 AM, Stefan

Re: [Qemu-devel] linux guests and ksm performance

2012-02-28 Thread Peter Lieven
On 28.02.2012 14:16, Avi Kivity wrote: On 02/24/2012 08:41 AM, Stefan Hajnoczi wrote: I dont think that it is cpu intense. All user pages are zeroed anyway, but at allocation time it shouldnt be a big difference in terms of cpu power. It's easy to find a scenario where eagerly zeroing pages

Re: [Qemu-devel] qemu-kvm-1.0 crashes with threaded vnc server?

2012-03-13 Thread Peter Lieven
On 11.02.2012 09:55, Corentin Chary wrote: On Thu, Feb 9, 2012 at 7:08 PM, Peter Lievenp...@dlh.net wrote: Hi, is anyone aware if there are still problems when enabling the threaded vnc server? I saw some VMs crashing when using a qemu-kvm build with --enable-vnc-thread. qemu-kvm-1.0[22646]:

[Qemu-devel] qemu-kvm 1.0.1?

2012-04-16 Thread Peter Lieven
Hi, i was wondering if there will be a qemu-kvm version 1.0.1? The last tag I see here is 1.0: http://git.kernel.org/?p=virt/kvm/qemu-kvm.git;a=summary Any hints? Thanks, Peter

[Qemu-devel] help setting up private git for bugfixes / own patches

2012-04-19 Thread Peter Lieven
Hi, I want to setup a private git repository for qemu for to tasks: a) cherry-pick existing patches from qemu git and submitting them as patch set for the next stable qemu release. i'm talking about patches which have not been included yet, but are present in the repository. b) add own

Re: [Qemu-devel] help setting up private git for bugfixes / own patches

2012-04-19 Thread Peter Lieven
On 19.04.2012 12:01, Stefan Hajnoczi wrote: On Thu, Apr 19, 2012 at 10:06 AM, Peter Lievenp...@dlh.net wrote: I want to setup a private git repository for qemu for to tasks: a) cherry-pick existing patches from qemu git and submitting them as patch set for the next stable qemu release.

Re: [Qemu-devel] help setting up private git for bugfixes / own patches

2012-04-19 Thread Peter Lieven
On 19.04.2012 13:15, Stefan Hajnoczi wrote: On Thu, Apr 19, 2012 at 11:05 AM, Peter Lievenp...@dlh.net wrote: On 19.04.2012 12:01, Stefan Hajnoczi wrote: On Thu, Apr 19, 2012 at 10:06 AM, Peter Lievenp...@dlh.netwrote: I want to setup a private git repository for qemu for to tasks: a)

Re: [Qemu-devel] help setting up private git for bugfixes / own patches

2012-04-19 Thread Peter Lieven
On 19.04.2012 13:41, Stefan Hajnoczi wrote: On Thu, Apr 19, 2012 at 12:32 PM, Peter Lievenp...@dlh.net wrote: On 19.04.2012 13:15, Stefan Hajnoczi wrote: On Thu, Apr 19, 2012 at 11:05 AM, Peter Lievenp...@dlh.netwrote: On 19.04.2012 12:01, Stefan Hajnoczi wrote: On Thu, Apr 19, 2012 at

[Qemu-devel] Assertion after chaning display resolution

2012-04-24 Thread Peter Lieven
Hi all, I saw the following assert after chaning display resolution. This might be the cause, but i am not sure. Threaded VNC is enabled. Anyone ever seen this? qemu-kvm-1.0: malloc.c:3096: sYSMALLOc: Assertion `(old_top == (((mbinptr) (((char *) ((av)-bins[((1) - 1) * 2])) -

Re: [Qemu-devel] Assertion after chaning display resolution

2012-04-24 Thread Peter Lieven
On 24.04.2012 15:34, Alon Levy wrote: On Tue, Apr 24, 2012 at 03:24:31PM +0200, Peter Lieven wrote: Hi all, I saw the following assert after chaning display resolution. This might be the cause, but i am not sure. Threaded VNC is enabled. Anyone ever seen this? qemu-kvm-1.0: malloc.c:3096

Re: [Qemu-devel] qemu-kvm-1.0.1 - unable to exit if vcpu is in infinite loop

2012-08-22 Thread Peter Lieven
On 08/21/12 10:23, Stefan Hajnoczi wrote: On Tue, Aug 21, 2012 at 8:21 AM, Jan Kiszkajan.kis...@siemens.com wrote: On 2012-08-19 11:42, Avi Kivity wrote: On 08/17/2012 06:04 PM, Jan Kiszka wrote: Can anyone imagine that such a barrier may actually be required? If it is currently possible

[Qemu-devel] memtest 4.20+ does not work with -cpu host

2012-08-22 Thread Peter Lieven
Hi, has anyone ever tested to run memtest with -cpu host flag passed to qemu-kvm? For me it resets when probing the chipset. With -cpu qemu64 it works just fine. Maybe this is specific to memtest, but it might be sth that can happen in other applications to. Any thoughts? Thanks, Peter

Re: [Qemu-devel] memtest 4.20+ does not work with -cpu host

2012-09-10 Thread Peter Lieven
On 09/06/12 16:58, Avi Kivity wrote: On 08/22/2012 06:06 PM, Peter Lieven wrote: Hi, has anyone ever tested to run memtest with -cpu host flag passed to qemu-kvm? For me it resets when probing the chipset. With -cpu qemu64 it works just fine. Maybe this is specific to memtest, but it might

Re: [Qemu-devel] memtest 4.20+ does not work with -cpu host

2012-09-10 Thread Peter Lieven
On 09/10/12 13:29, Paolo Bonzini wrote: Il 10/09/2012 13:06, Peter Lieven ha scritto: qemu-kvm-1.0.1-5107 [007] 410771.148000: kvm_entry: vcpu 0 qemu-kvm-1.0.1-5107 [007] 410771.148000: kvm_exit: reason MSR_READ rip 0x11478 info 0 0 qemu-kvm-1.0.1-5107 [007] 410771.148000: kvm_msr: msr_read 194

Re: [Qemu-devel] memtest 4.20+ does not work with -cpu host

2012-09-10 Thread Peter Lieven
On 09/10/12 13:29, Paolo Bonzini wrote: Il 10/09/2012 13:06, Peter Lieven ha scritto: qemu-kvm-1.0.1-5107 [007] 410771.148000: kvm_entry: vcpu 0 qemu-kvm-1.0.1-5107 [007] 410771.148000: kvm_exit: reason MSR_READ rip 0x11478 info 0 0 qemu-kvm-1.0.1-5107 [007] 410771.148000: kvm_msr: msr_read 194

Re: [Qemu-devel] memtest 4.20+ does not work with -cpu host

2012-09-10 Thread Peter Lieven
On 09/10/12 14:32, Avi Kivity wrote: On 09/10/2012 03:29 PM, Peter Lieven wrote: On 09/10/12 14:21, Gleb Natapov wrote: On Mon, Sep 10, 2012 at 02:15:49PM +0200, Paolo Bonzini wrote: Il 10/09/2012 13:52, Peter Lieven ha scritto: dd if=/dev/cpu/0/msr skip=$((0x194)) bs=8 count=1 | xxd dd

Re: [Qemu-devel] memtest 4.20+ does not work with -cpu host

2012-09-10 Thread Peter Lieven
On 09/10/12 14:21, Gleb Natapov wrote: On Mon, Sep 10, 2012 at 02:15:49PM +0200, Paolo Bonzini wrote: Il 10/09/2012 13:52, Peter Lieven ha scritto: dd if=/dev/cpu/0/msr skip=$((0x194)) bs=8 count=1 | xxd dd if=/dev/cpu/0/msr skip=$((0xCE)) bs=8 count=1 | xxd it only works without the skip

Re: [Qemu-devel] Block Migration and xbzrle

2012-10-04 Thread Peter Lieven
Am 02.10.2012 um 12:40 schrieb Orit Wasserman: On 10/02/2012 11:30 AM, Peter Lieven wrote: Am 02.10.2012 um 11:28 schrieb Orit Wasserman: On 10/02/2012 10:33 AM, lieven-li...@dlh.net wrote: Orit Wasserman wrote: On 09/16/2012 01:39 PM, Peter Lieven wrote: Hi, I remember

Re: [Qemu-devel] [PATCH] fix monitor

2013-04-03 Thread Peter Lieven
Hi Gerd, I today saw this assert when live migrating a VM. Is this related? The below patch was already applied. qemu-1.4.5: /usr/src/qemu-1.4.5/monitor.c:297: monitor_puts: Assertion `mon-outbuf_index sizeof(mon-outbuf) - 1' failed. Peter Gerd Hoffmann wrote: chardev flow control broke

Re: [Qemu-devel] [PATCH] fix monitor

2013-04-03 Thread Peter Lieven
On 03.04.2013 15:36, Luiz Capitulino wrote: On Wed, 03 Apr 2013 14:35:46 +0200 Gerd Hoffmann kra...@redhat.com wrote: On 04/03/13 14:17, Peter Lieven wrote: Hi Gerd, I today saw this assert when live migrating a VM. Is this related? The below patch was already applied. qemu-1.4.5: /usr/src

Re: [Qemu-devel] Patch Round-up for stable 1.4.1, freeze next Tuesday

2013-04-03 Thread Peter Lieven
On 02.04.2013 23:45, Michael Roth wrote: Hi everyone, The following new patches are queued for QEMU stable v1.4.1: https://github.com/mdroth/qemu/commits/stable-1.4-staging The release is planned for 04-15-2013: http://wiki.qemu.org/Planning/1.4 Please CC qemu-sta...@nongnu.org on any

Re: [Qemu-devel] [PATCHv5 06/10] migration: search for zero instead of dup pages

2013-04-05 Thread Peter Lieven
buffer_find_nonzero_offset() is used directly to avoid the unnecssary additional checks in buffer_is_zero(). raw performace gain checking 1 GByte zeroed memory over is_dup_page() is approx. 10-12% with SSE2 and 8-10% with unsigned long arithmedtic. Signed-off-by: Peter Lieven p...@kamp.de Reviewed-by: Orit

Re: [Qemu-devel] [PATCHv5 06/10] migration: search for zero instead of dup pages

2013-04-05 Thread Peter Lieven
buffer_find_nonzero_offset() is used directly to avoid the unnecssary additional checks in buffer_is_zero(). raw performace gain checking 1 GByte zeroed memory over is_dup_page() is approx. 10-12% with SSE2 and 8-10% with unsigned long arithmedtic. Signed-off-by: Peter Lieven p...@kamp.de Reviewed-by: Orit

Re: [Qemu-devel] [PATCHv5 06/10] migration: search for zero instead of dup pages

2013-04-08 Thread Peter Lieven
Am 05.04.2013 um 21:23 schrieb Kevin Wolf kw...@redhat.com: Am 26.03.2013 um 10:58 hat Peter Lieven geschrieben: virtually all dup pages are zero pages. remove the special is_dup_page() function and use the optimized buffer_find_nonzero_offset() function instead. here

Re: [Qemu-devel] [PATCHv5 06/10] migration: search for zero instead of dup pages

2013-04-08 Thread Peter Lieven
Am 08.04.2013 um 10:33 schrieb Peter Lieven p...@kamp.de: Am 05.04.2013 um 21:23 schrieb Kevin Wolf kw...@redhat.com: Am 26.03.2013 um 10:58 hat Peter Lieven geschrieben: virtually all dup pages are zero pages. remove the special is_dup_page() function and use the optimized

Re: [Qemu-devel] [PATCHv5 06/10] migration: search for zero instead of dup pages

2013-04-08 Thread Peter Lieven
Am 08.04.2013 um 10:49 schrieb Kevin Wolf kw...@redhat.com: Am 08.04.2013 um 10:33 hat Peter Lieven geschrieben: Am 05.04.2013 um 21:23 schrieb Kevin Wolf kw...@redhat.com: Am 26.03.2013 um 10:58 hat Peter Lieven geschrieben: virtually all dup pages are zero pages. remove the special

Re: [Qemu-devel] [PATCHv5 06/10] migration: search for zero instead of dup pages

2013-04-08 Thread Peter Lieven
Am 08.04.2013 um 10:38 schrieb Paolo Bonzini pbonz...@redhat.com: Il 06/04/2013 00:06, Peter Lieven ha scritto: I think we should MADV_DONTNEED it. i have to correct myself, on Linux it seems that MADV_DONTNEED guarantees that subsequent reads will return a zero filled page. If I am

Re: [Qemu-devel] [PATCH] migration: initialize RAM to zero

2013-04-08 Thread Peter Lieven
= qemu_memalign(align, size); + trace_qemu_vmalloc(size, ptr); return ptr; } -- 1.8.1.4 Reviewed-by: Peter Lieven p...@kamp.de

[Qemu-devel] Lost network with rtl8139 / qemu-kvm 1.2.0

2013-04-11 Thread Peter Lieven
Hi all, I have a strange problem with a few old VMs running with Windows XP (and in this case a Win2008 R2 Server) that occasionally loose network connectivity. The tap device shows increasing drops: tap36 Link encap:Ethernet HWaddr b2:84:23:c0:e2:c0 inet6 addr:

Re: [Qemu-devel] [PATCH] mainloop.c: Keep unlocking BQL during busy-wait spin-out

2013-04-18 Thread Peter Lieven
On 15.04.2013 15:08, Anthony Liguori wrote: Peter Crosthwaite peter.crosthwa...@xilinx.com writes: Modify Anthony's starvation detection logic to keep the BQL unlocked until the starvation condition goes away. Otherwise the counter has to count up to 1000 for each needed iteration until the

Re: [Qemu-devel] [PATCH] mainloop.c: Keep unlocking BQL during busy-wait spin-out

2013-04-19 Thread Peter Lieven
On 18.04.2013 16:35, Peter Crosthwaite wrote: Hi Peter, On Fri, Apr 19, 2013 at 12:22 AM, Peter Lieven lieven-li...@dlhnet.de wrote: On 15.04.2013 15:08, Anthony Liguori wrote: Peter Crosthwaite peter.crosthwa...@xilinx.com writes: Modify Anthony's starvation detection logic to keep the BQL

Re: [Qemu-devel] [PATCH] mainloop.c: Keep unlocking BQL during busy-wait spin-out

2013-04-22 Thread Peter Lieven
On 21.04.2013 16:21, Peter Crosthwaite wrote: Hi Peter, On Fri, Apr 19, 2013 at 5:01 PM, Peter Lieven lieven-li...@dlhnet.de wrote: On 18.04.2013 16:35, Peter Crosthwaite wrote: Hi Peter, On Fri, Apr 19, 2013 at 12:22 AM, Peter Lieven lieven-li...@dlhnet.de wrote: On 15.04.2013 15:08

[Qemu-devel] Ubuntu/Debian Installer + Virtio-SCSI - Bad ram pointer

2012-10-29 Thread Peter Lieven
Hi, If I try to Install Ubuntu 12.04 LTS / 12.10 64-bit on a virtio storage backend that supports iSCSI qemu-kvm crashes reliably with the following error: Bad ram pointer 0x3039303620008000 This happens directly after the confirmation of the Timezone before the Disk is partitioned. If I

Re: [Qemu-devel] Ubuntu/Debian Installer + Virtio-BLK - Bad ram pointer

2012-10-30 Thread Peter Lieven
On 30.10.2012 09:32, Stefan Hajnoczi wrote: On Mon, Oct 29, 2012 at 03:09:37PM +0100, Peter Lieven wrote: Hi, Bug subject should be virtio-blk, not virtio-scsi. virtio-scsi is a different virtio device type from virtoi-blk and is not present in the backtrace you posted. you are right, sorry

Re: [Qemu-devel] Ubuntu/Debian Installer + Virtio-SCSI - Bad ram pointer

2012-10-30 Thread Peter Lieven
On 30.10.2012 09:32, Stefan Hajnoczi wrote: On Mon, Oct 29, 2012 at 03:09:37PM +0100, Peter Lieven wrote: Hi, Bug subject should be virtio-blk, not virtio-scsi. virtio-scsi is a different virtio device type from virtoi-blk and is not present in the backtrace you posted. Sounds pedantic but I

Re: [Qemu-devel] Ubuntu/Debian Installer + Virtio-SCSI - Bad ram pointer

2012-10-30 Thread Peter Lieven
Am 30.10.2012 19:27, schrieb Stefan Hajnoczi: On Tue, Oct 30, 2012 at 4:56 PM, Peter Lieven p...@dlhnet.de wrote: On 30.10.2012 09:32, Stefan Hajnoczi wrote: On Mon, Oct 29, 2012 at 03:09:37PM +0100, Peter Lieven wrote: Hi, Bug subject should be virtio-blk, not virtio-scsi. virtio-scsi

Re: [Qemu-devel] Ubuntu/Debian Installer + Virtio-SCSI - Bad ram pointer

2012-10-30 Thread Peter Lieven
Am 30.10.2012 19:27, schrieb Stefan Hajnoczi: On Tue, Oct 30, 2012 at 4:56 PM, Peter Lieven p...@dlhnet.de wrote: On 30.10.2012 09:32, Stefan Hajnoczi wrote: On Mon, Oct 29, 2012 at 03:09:37PM +0100, Peter Lieven wrote: Hi, Bug subject should be virtio-blk, not virtio-scsi. virtio-scsi

Re: [Qemu-devel] Ubuntu/Debian Installer + Virtio-SCSI - Bad ram pointer

2012-11-05 Thread Peter Lieven
Am 31.10.2012 um 15:08 schrieb ronnie sahlberg: On Tue, Oct 30, 2012 at 10:48 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Tue, Oct 30, 2012 at 10:09 PM, ronnie sahlberg ronniesahlb...@gmail.com wrote: About half a year there was an issue where recent kernels had added support to start

Re: [Qemu-devel] slow virtio network with vhost=on and multiple cores

2012-11-06 Thread Peter Lieven
Dietmar Maurer wrote: ./x86_64-softmmu/qemu-system-x86_64 -smp sockets=1,cores=2 -m 512 - hda debian-squeeze-netinst.raw -netdev type=tap,id=net0,ifname=tap111i0,vhost=on -device virtio-net-pci,netdev=net0,id=net0 Downloading a larger file with wget inside the guest will show the

Re: [Qemu-devel] slow virtio network with vhost=on and multiple cores

2012-11-08 Thread Peter Lieven
Jan Kiszka wrote: On 2012-11-06 12:24, Dietmar Maurer wrote: On 2012-11-06 10:46, Dietmar Maurer wrote: This obviously breaks vhost when using multiple cores. With obviously you mean you already have a clue why? I'll try to reproduce. No, sorry - just meant the performance regression is

Re: [Qemu-devel] slow virtio network with vhost=on and multiple cores

2012-11-08 Thread Peter Lieven
Dietmar Maurer wrote: Meanwhile I quickly tried to reproduce but didn't succeed so far (10GBit between host and guest with vhost=on and 2 guest cores). However, I finally realized that we are talking about a pretty special host kernel which I don't have around. I guess this is better dealt

Re: [Qemu-devel] Ubuntu/Debian Installer + Virtio-SCSI - Bad ram pointer

2012-11-08 Thread Peter Lieven
Has anyone any other idea what the cause could be or where to start? Peter Am 31.10.2012 um 15:08 schrieb ronnie sahlberg: On Tue, Oct 30, 2012 at 10:48 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Tue, Oct 30, 2012 at 10:09 PM, ronnie sahlberg ronniesahlb...@gmail.com wrote: About half

Re: [Qemu-devel] slow virtio network with vhost=on and multiple cores

2012-11-09 Thread Peter Lieven
Dietmar Maurer wrote: Dietmar, how is the speed if you specify --machine pc,kernel_irqchip=off as cmdline option to qemu-kvm-1.2.0? I get full speed if i use that flag. I also tried to reproduce it and can confirm your findings. Host Ubuntu 12.04 LTS (kernel 3.2) with vanilla qemu-kvm

Re: [Qemu-devel] slow virtio network with vhost=on and multiple cores

2012-11-09 Thread Peter Lieven
it seems that with in-kernel irqchip the interrupts are distributed across all vpcus. without in-kernel irqchip all interrupts are on cpu0. maybe this is related. without inkernel irqchip CPU0 CPU1 CPU2 CPU3 0: 16 0 0 0

Re: [Qemu-devel] slow virtio network with vhost=on and multiple cores

2012-11-09 Thread Peter Lieven
the interrupt on different CPUs. Peter Lieven wrote: it seems that with in-kernel irqchip the interrupts are distributed across all vpcus. without in-kernel irqchip all interrupts are on cpu0. maybe this is related. without inkernel irqchip CPU0 CPU1 CPU2 CPU3 0

Re: [Qemu-devel] slow virtio network with vhost=on and multiple cores

2012-11-13 Thread Peter Lieven
On 09.11.2012 19:03, Peter Lieven wrote: Remark: If i disable interrupts on CPU1-3 for virtio the performance is ok again. Now we need someone with deeper knowledge of the in-kernel irqchip and the virtio/vhost driver development to say if this is a regression in qemu-kvm or a problem

Re: [Qemu-devel] slow virtio network with vhost=on and multiple cores

2012-11-13 Thread Peter Lieven
On 09.11.2012 19:03, Peter Lieven wrote: Remark: If i disable interrupts on CPU1-3 for virtio the performance is ok again. Now we need someone with deeper knowledge of the in-kernel irqchip and the virtio/vhost driver development to say if this is a regression in qemu-kvm or a problem

Re: [Qemu-devel] slow virtio network with vhost=on and multiple cores

2012-11-13 Thread Peter Lieven
On 13.11.2012 17:22, Michael S. Tsirkin wrote: On Tue, Nov 13, 2012 at 12:49:03PM +0100, Peter Lieven wrote: On 09.11.2012 19:03, Peter Lieven wrote: Remark: If i disable interrupts on CPU1-3 for virtio the performance is ok again. Now we need someone with deeper knowledge of the in-kernel

Re: [Qemu-devel] slow virtio network with vhost=on and multiple cores

2012-11-13 Thread Peter Lieven
Am 13.11.2012 um 17:26 schrieb Michael S. Tsirkin: On Tue, Nov 13, 2012 at 05:21:50PM +0100, Peter Lieven wrote: On 13.11.2012 17:22, Michael S. Tsirkin wrote: On Tue, Nov 13, 2012 at 12:49:03PM +0100, Peter Lieven wrote: On 09.11.2012 19:03, Peter Lieven wrote: Remark: If i disable

Re: [Qemu-devel] slow virtio network with vhost=on and multiple cores

2012-11-13 Thread Peter Lieven
Am 13.11.2012 um 17:33 schrieb Michael S. Tsirkin: On Tue, Nov 13, 2012 at 06:22:56PM +0200, Michael S. Tsirkin wrote: On Tue, Nov 13, 2012 at 12:49:03PM +0100, Peter Lieven wrote: On 09.11.2012 19:03, Peter Lieven wrote: Remark: If i disable interrupts on CPU1-3 for virtio

[Qemu-devel] [PATCH] iscsi: fix segfault in url parsing

2012-11-15 Thread Peter Lieven
If an invalid URL is specified iscsi_get_error(iscsi) is called with iscsi == NULL. Signed-off-by: Peter Lieven p...@kamp.de --- block/iscsi.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index d0b1a10..b5c3161 100644 --- a/block/iscsi.c

[Qemu-devel] [PATCH] iscsi: fix deadlock during login

2012-11-15 Thread Peter Lieven
-off-by: Peter Lieven p...@kamp.de --- block/iscsi.c | 56 +--- 1 file changed, 21 insertions(+), 35 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index b5c3161..f44bb57 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -798,30

Re: [Qemu-devel] [PATCH] iscsi: fix deadlock during login

2012-11-15 Thread Peter Lieven
and another issue that i submitted a patch for earlier: https://github.com/sahlberg/libiscsi/commit/a9257d52a7577b607e237e209b9868c5ce78a927 it might be that this fix introduced the new issue. Peter regards ronnie sahlberg On Thu, Nov 15, 2012 at 6:50 AM, Peter Lieven p...@dlhnet.de wrote

Re: [Qemu-devel] [PATCH] iscsi: fix deadlock during login

2012-11-15 Thread Peter Lieven
Paolo Bonzini wrote: Il 15/11/2012 15:57, ronnie sahlberg ha scritto: I dont know if we should switch to use synchronous code here. It is much nicer if all code is async. bdrv_open is generally synchronous, so I think Peter's patch is ok. if all is sync wouldn't it be best to have all code

Re: [Qemu-devel] slow virtio network with vhost=on and multiple cores

2012-11-15 Thread Peter Lieven
Dietmar Maurer wrote: You can also reproduce the problem with RHEL6.2 as guest But it seems RHEL 6.3 fixed it. RHEL6.2 on ubuntu host? I only tested with RHEL6.3 kernel on host. can you check if there is a difference on interrupt delivery between those two? cat /proc/interrupts should be

Re: [Qemu-devel] [PATCH] iscsi: fix deadlock during login

2012-11-16 Thread Peter Lieven
Am 16.11.2012 08:44, schrieb Paolo Bonzini: Il 15/11/2012 19:28, Peter Lieven ha scritto: I dont know if we should switch to use synchronous code here. It is much nicer if all code is async. bdrv_open is generally synchronous, so I think Peter's patch is ok. if all is sync wouldn't it be best

Re: [Qemu-devel] [PATCH] iscsi: fix deadlock during login

2012-11-16 Thread Peter Lieven
Am 16.11.2012 11:38, schrieb Kevin Wolf: Am 15.11.2012 17:37, schrieb Paolo Bonzini: Il 15/11/2012 17:13, ronnie sahlberg ha scritto: On Thu, Nov 15, 2012 at 7:54 AM, Paolo Bonzini pbonz...@redhat.com wrote: Il 15/11/2012 15:57, ronnie sahlberg ha scritto: I dont know if we should switch to

[Qemu-devel] [PATCH v2] iscsi: fix deadlock during login

2012-11-17 Thread Peter Lieven
: changed the complete iscsi_open routine to sync tasks. Signed-off-by: Peter Lieven p...@kamp.de --- block/iscsi.c | 251 - 1 file changed, 70 insertions(+), 181 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index d0b1a10..4bc3d4b

[Qemu-devel] [PATCH] iscsi: add iscsi_create support

2012-11-17 Thread Peter Lieven
This patch adds support for bdrv_create. This allows e.g. to use qemu-img to convert from any supported device to an iscsi backed storage as destination. Signed-off-by: Peter Lieven p...@kamp.de diff --git a/block/iscsi.c b/block/iscsi.c index 4bc3d4b..eb586cb 100644 --- a/block/iscsi.c +++ b

[Qemu-devel] [PATCH] iscsi: do not assume device is zero initialized

2012-11-17 Thread Peter Lieven
Without any complex checks we can't assume that an iscsi target is initialized to zero. Signed-off-by: Peter Lieven p...@kamp.de --- block/iscsi.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/block/iscsi.c b/block/iscsi.c index eb586cb..d685f20 100644 --- a/block/iscsi.c +++ b

Re: [Qemu-devel] [PATCH] iscsi: fix deadlock during login

2012-11-18 Thread Peter Lieven
Am 15.11.2012 um 16:54 schrieb Paolo Bonzini pbonz...@redhat.com: Il 15/11/2012 15:57, ronnie sahlberg ha scritto: I dont know if we should switch to use synchronous code here. It is much nicer if all code is async. bdrv_open is generally synchronous, so I think Peter's patch is ok.

Re: [Qemu-devel] [PATCH] iscsi: do not assume device is zero initialized

2012-11-19 Thread Peter Lieven
Am 19.11.2012 um 09:25 schrieb Paolo Bonzini pbonz...@redhat.com: Il 17/11/2012 16:20, Peter Lieven ha scritto: Without any complex checks we can't assume that an iscsi target is initialized to zero. Signed-off-by: Peter Lieven p...@kamp.de --- block/iscsi.c |6 ++ 1 file changed

Re: [Qemu-devel] slow virtio network with vhost=on and multiple cores

2012-11-19 Thread Peter Lieven
On 13.11.2012 17:33, Michael S. Tsirkin wrote: On Tue, Nov 13, 2012 at 06:22:56PM +0200, Michael S. Tsirkin wrote: On Tue, Nov 13, 2012 at 12:49:03PM +0100, Peter Lieven wrote: On 09.11.2012 19:03, Peter Lieven wrote: Remark: If i disable interrupts on CPU1-3 for virtio the performance is ok

[Qemu-devel] [PATCH] iscsi: partly avoid iovec linearization in iscsi_aio_writev

2012-11-19 Thread Peter Lieven
libiscsi expects all write16 data in a linear buffer. If the iovec only contains one buffer we can skip the linearization step as well as the additional malloc/free and pass the buffer directly. Reported-by: Ronnie Sahlberg ronniesahlb...@gmail.com Signed-off-by: Peter Lieven p...@kamp.de

Re: [Qemu-devel] [PATCH] iscsi: partly avoid iovec linearization in iscsi_aio_writev

2012-11-19 Thread Peter Lieven
Am 19.11.2012 um 16:18 schrieb Paolo Bonzini pbonz...@redhat.com: Il 19/11/2012 15:58, Peter Lieven ha scritto: -/* XXX we should pass the iovec to write16 to avoid the extra copy */ -/* this will allow us to get rid of 'buf' completely */ size = nb_sectors * BDRV_SECTOR_SIZE

Re: [Qemu-devel] Ubuntu/Debian Installer + Virtio-SCSI - Bad ram pointer

2012-11-22 Thread Peter Lieven
On 19.11.2012 18:20, Stefan Hajnoczi wrote: On Thu, Nov 8, 2012 at 4:26 PM, Peter Lieven p...@dlhnet.de wrote: Has anyone any other idea what the cause could be or where to start? Hi Peter, I suggested posting the source tree you are building. Since you have applied patches yourself no one

[Qemu-devel] tap devices not receiving packets from a bridge

2012-11-22 Thread Peter Lieven
Hi, is anyone aware of a problem with the linux network bridge that in very rare circumstances stops a bridge from sending pakets to a tap device? My problem occurs in conjunction with vanilla qemu-kvm-1.2.0 and Ubuntu Kernel 3.2.0-34.53 which is based on Linux 3.2.33. I was not yet able to

Re: [Qemu-devel] tap devices not receiving packets from a bridge

2012-11-23 Thread Peter Lieven
Am 23.11.2012 um 08:02 schrieb Stefan Hajnoczi: On Thu, Nov 22, 2012 at 03:29:52PM +0100, Peter Lieven wrote: is anyone aware of a problem with the linux network bridge that in very rare circumstances stops a bridge from sending pakets to a tap device? My problem occurs in conjunction

Re: [Qemu-devel] tap devices not receiving packets from a bridge

2012-11-23 Thread Peter Lieven
Am 23.11.2012 um 12:01 schrieb Michael S. Tsirkin: On Fri, Nov 23, 2012 at 10:41:21AM +0100, Peter Lieven wrote: Am 23.11.2012 um 08:02 schrieb Stefan Hajnoczi: On Thu, Nov 22, 2012 at 03:29:52PM +0100, Peter Lieven wrote: is anyone aware of a problem with the linux network bridge

Re: [Qemu-devel] tap devices not receiving packets from a bridge

2013-02-11 Thread Peter Lieven
On 23.01.2013 11:03, Michael S. Tsirkin wrote: On Tue, Jan 22, 2013 at 10:04:07AM +0100, Peter Lieven wrote: On 23.11.2012 12:01, Michael S. Tsirkin wrote: On Fri, Nov 23, 2012 at 10:41:21AM +0100, Peter Lieven wrote: Am 23.11.2012 um 08:02 schrieb Stefan Hajnoczi: On Thu, Nov 22, 2012

Re: [Qemu-devel] tap devices not receiving packets from a bridge

2013-02-12 Thread Peter Lieven
Am 12.02.2013 um 10:08 schrieb Michael S. Tsirkin m...@redhat.com: On Tue, Feb 12, 2013 at 08:06:04AM +0100, Peter Lieven wrote: On 23.01.2013 11:03, Michael S. Tsirkin wrote: On Tue, Jan 22, 2013 at 10:04:07AM +0100, Peter Lieven wrote: On 23.11.2012 12:01, Michael S. Tsirkin wrote: On Fri

Re: [Qemu-devel] tap devices not receiving packets from a bridge

2013-02-12 Thread Peter Lieven
Am 12.02.2013 um 10:54 schrieb Michael S. Tsirkin m...@redhat.com: On Tue, Feb 12, 2013 at 01:39:07PM +0400, Michael Tokarev wrote: 12.02.2013 13:10, Peter Lieven wrote: [] Guys, can we please trim the excessive quoting just a bit? ;) If have set this option for 2 weeks now and not seen

[Qemu-devel] [PATCH] tap: set IFF_ONE_QUEUE per default

2013-02-15 Thread Peter Lieven
5d097109257c03a71845729f8db6b5770c4bbedc Signed-off-by: Peter Lieven p...@kamp.de --- net/tap-linux.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/tap-linux.c b/net/tap-linux.c index a953189..2759b78 100644 --- a/net/tap-linux.c +++ b/net/tap-linux.c @@ -49,7 +49,7 @@ int tap_open(char

Re: [Qemu-devel] [PATCH] tap: set IFF_ONE_QUEUE per default

2013-02-15 Thread Peter Lieven
Am 15.02.2013 um 10:16 schrieb Stefan Hajnoczi stefa...@gmail.com: On Fri, Feb 15, 2013 at 09:27:18AM +0100, Peter Lieven wrote: historically the kernel queues packets two times. once at the device and second in qdisc. this is believed to cause interface stalls if one of these queues

[Qemu-devel] [PATCHv2] tap: set IFF_ONE_QUEUE per default

2013-02-15 Thread Peter Lieven
5d097109257c03a71845729f8db6b5770c4bbedc v2: - do only set the flag on linux as it breaks macvtap - define IFF_ONE_QUEUE in tap-linux.h Signed-off-by: Peter Lieven p...@kamp.de --- net/tap-linux.c |4 net/tap-linux.h |1 + 2 files changed, 5 insertions(+) diff --git a/net/tap-linux.c b/net/tap-linux.c

Re: [Qemu-devel] [PATCH] tap: set IFF_ONE_QUEUE per default

2013-02-15 Thread Peter Lieven
Am 15.02.2013 um 10:22 schrieb Christian Borntraeger borntrae...@de.ibm.com: On 15/02/13 09:27, Peter Lieven wrote: historically the kernel queues packets two times. once at the device and second in qdisc. this is believed to cause interface stalls if one of these queues overruns. setting

[Qemu-devel] [PATCH] iscsi: add iscsi_truncate support

2013-02-15 Thread Peter Lieven
this patch adds iscsi_truncate which effectively allows for online resizing of iscsi volumes. for this to work you have to resize the volume on your storage and then call block_resize command in qemu which will issue a readcapacity16 to update the capacity. Signed-off-by: Peter Lieven p

Re: [Qemu-devel] [PATCH] iscsi: add iscsi_truncate support

2013-02-15 Thread Peter Lieven
On 15.02.2013 12:09, Paolo Bonzini wrote: Il 15/02/2013 11:58, Peter Lieven ha scritto: this patch adds iscsi_truncate which effectively allows for online resizing of iscsi volumes. for this to work you have to resize the volume on your storage and then call block_resize command in qemu which

Re: [Qemu-devel] [PATCH] iscsi: add iscsi_truncate support

2013-02-15 Thread Peter Lieven
Am 15.02.2013 um 12:54 schrieb Paolo Bonzini pbonz...@redhat.com: Il 15/02/2013 12:18, Peter Lieven ha scritto: +task = iscsi_readcapacity16_task(iscsilun-iscsi, iscsilun-lun, + iscsi_readcapacity16_cb, itask); You can use iscsi_readcapacity16_sync

Re: [Qemu-devel] [PATCH] iscsi: add iscsi_truncate support

2013-02-15 Thread Peter Lieven
Am 15.02.2013 um 13:18 schrieb Kevin Wolf kw...@redhat.com: On Fri, Feb 15, 2013 at 12:54:51PM +0100, Paolo Bonzini wrote: Il 15/02/2013 12:18, Peter Lieven ha scritto: +task = iscsi_readcapacity16_task(iscsilun-iscsi, iscsilun-lun

Re: [Qemu-devel] [PATCHv2] tap: set IFF_ONE_QUEUE per default

2013-02-15 Thread Peter Lieven
Am 15.02.2013 um 14:32 schrieb Stefan Hajnoczi stefa...@gmail.com: On Fri, Feb 15, 2013 at 10:32:31AM +0100, Peter Lieven wrote: historically the kernel queues packets two times. once at the device and second in qdisc. this is believed to cause interface stalls if one of these queues

[Qemu-devel] [PATCHv2] iscsi: add iscsi_truncate support

2013-02-15 Thread Peter Lieven
() before bdrv_truncate() to avoid in-flight AIOs while the device is truncated - since no AIOs are in flight we can use a sync libiscsi call to re-read the capacity - factor out the readcapacity16 logic as it is redundant to iscsi_open() and iscsi_truncate(). Signed-off-by: Peter Lieven p

Re: [Qemu-devel] [PATCHv2] tap: set IFF_ONE_QUEUE per default

2013-02-18 Thread Peter Lieven
On 15.02.2013 14:32, Stefan Hajnoczi wrote: On Fri, Feb 15, 2013 at 10:32:31AM +0100, Peter Lieven wrote: historically the kernel queues packets two times. once at the device and second in qdisc. this is believed to cause interface stalls if one of these queues overruns. setting IFF_ONE_QUEUE

[Qemu-devel] [PATCH] block: complete all IOs before .bdrv_truncate

2013-02-18 Thread Peter Lieven
bdrv_truncate() invalidates the bdrv_check_request() result for in-flight requests, so there should better be none. Signed-off-by: Peter Lieven p...@kamp.de Reported-by: Kevin Wolf kw...@redhat.com --- block.c |4 1 file changed, 4 insertions(+) diff --git a/block.c b/block.c index

[Qemu-devel] [PATCHv3] iscsi: add iscsi_truncate support

2013-02-18 Thread Peter Lieven
the readcapacity16 logic as it is redundant to iscsi_open() and iscsi_truncate(). Signed-off-by: Peter Lieven p...@kamp.de --- block/iscsi.c | 77 + 1 file changed, 56 insertions(+), 21 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c

Re: [Qemu-devel] [PATCHv3] iscsi: add iscsi_truncate support

2013-02-18 Thread Peter Lieven
On 18.02.2013 14:01, Paolo Bonzini wrote: Il 18/02/2013 13:58, Peter Lieven ha scritto: -switch (iscsilun-type) { -case TYPE_DISK: -task = iscsi_readcapacity16_sync(iscsi, iscsilun-lun); -if (task == NULL || task-status != SCSI_STATUS_GOOD) { -error_report

[Qemu-devel] [PATCHv4] iscsi: add iscsi_truncate support

2013-02-18 Thread Peter Lieven
to iscsi_open() and iscsi_truncate(). Signed-off-by: Peter Lieven p...@kamp.de --- block/iscsi.c | 133 + 1 file changed, 87 insertions(+), 46 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index deb3b68..1ea290e 100644 --- a/block/iscsi.c

[Qemu-devel] [RFC][PATCH] iscsi: retry read, write, flush and unmap on unit attention check conditions

2013-02-18 Thread Peter Lieven
to avoid this. Signed-off-by: Peter Lieven p...@kamp.de --- block/iscsi.c | 300 +++-- 1 file changed, 208 insertions(+), 92 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index 1ea290e..fc98eea 100644 --- a/block/iscsi.c +++ b/block

Re: [Qemu-devel] [RFC][PATCH] iscsi: retry read, write, flush and unmap on unit attention check conditions

2013-02-19 Thread Peter Lieven
Am 18.02.2013 um 17:14 schrieb Paolo Bonzini pbonz...@redhat.com: Il 18/02/2013 16:58, Peter Lieven ha scritto: +acb = qemu_aio_get(iscsi_aiocb_info, bs, cb, opaque); + +acb-iscsilun = iscsilun; +acb-retries = ISCSI_CMD_RETRIES; +acb-nb_sectors = nb_sectors; +acb

Re: [Qemu-devel] [RFC][PATCH] iscsi: retry read, write, flush and unmap on unit attention check conditions

2013-02-21 Thread Peter Lieven
Am 18.02.2013 um 17:14 schrieb Paolo Bonzini pbonz...@redhat.com: Il 18/02/2013 16:58, Peter Lieven ha scritto: +acb = qemu_aio_get(iscsi_aiocb_info, bs, cb, opaque); + +acb-iscsilun = iscsilun; +acb-retries = ISCSI_CMD_RETRIES; +acb-nb_sectors = nb_sectors; +acb

[Qemu-devel] [PATCHv2] iscsi: retry read, write, flush and unmap on unit attention check conditions

2013-02-21 Thread Peter Lieven
: - fix duplication in iscsi_aio_discard() - allow any type of unit attention check condition in iscsi_readcapacity_sync(). Signed-off-by: Peter Lieven p...@kamp.de --- block/iscsi.c | 303 +++-- 1 file changed, 209 insertions(+), 94

[Qemu-devel] (iSCSI-)Readcache in Qemu?

2013-02-21 Thread Peter Lieven
Hi, is there any project or plans to integrate a readcache in qemu either for iscsi or for the whole block layer? I was thinking of 2 options: a) assign (up to) a fixed amount of ram for readcaching of a VMs disk I/O. Without SG_IO this seems to be quite easy as there are only a handful of

Re: [Qemu-devel] (iSCSI-)Readcache in Qemu?

2013-02-22 Thread Peter Lieven
Am 22.02.2013 um 13:15 schrieb Paolo Bonzini pbonz...@redhat.com: Il 22/02/2013 12:06, Stefan Hajnoczi ha scritto: On Fri, Feb 22, 2013 at 08:51:48AM +0100, Peter Lieven wrote: is there any project or plans to integrate a readcache in qemu either for iscsi or for the whole block layer? I

Re: [Qemu-devel] [PATCHv2] tap: set IFF_ONE_QUEUE per default

2013-02-25 Thread Peter Lieven
On 18.02.2013 13:39, Peter Lieven wrote: On 15.02.2013 14:32, Stefan Hajnoczi wrote: On Fri, Feb 15, 2013 at 10:32:31AM +0100, Peter Lieven wrote: historically the kernel queues packets two times. once at the device and second in qdisc. this is believed to cause interface stalls if one

[Qemu-devel] [PATCHv3] tap: set IFF_ONE_QUEUE per default

2013-02-25 Thread Peter Lieven
5d097109257c03a71845729f8db6b5770c4bbedc v3: - probe if IFF_ONE_QUEUE feature is available v2: - do only set the flag on linux as it breaks macvtap - define IFF_ONE_QUEUE in tap-linux.h Signed-off-by: Peter Lieven p...@kamp.de --- net/tap-linux.c | 10 ++ net/tap-linux.h |9 + 2 files changed

[Qemu-devel] [PATCH] page_cache: Fix memory leak

2013-02-25 Thread Peter Lieven
XBZRLE encoded migration introduced a MRU page cache meachnism. Unfortunately, cached items where never freed on a collision. This lead to out of memory conditions during XBZRLE migration if the page cache was small and there where a lot of collisions. Signed-off-by: Peter Lieven p...@kamp.de

<    3   4   5   6   7   8   9   10   11   12   >