[PULL 26/27] MAINTAINERS: Add my-self as CAN maintainer

2024-09-13 Thread Peter Maydell
From: Francisco Iglesias Signed-off-by: Francisco Iglesias Message-id: 20240906181645.40359-4-francisco.igles...@amd.com Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index b9812d46525

[PULL 16/27] target/arm/tcg: refine cache descriptions with a wrapper

2024-09-13 Thread Peter Maydell
: Philippe Mathieu-Daudé Message-id: 20240903144550.280-1-alireza.san...@huawei.com Signed-off-by: Peter Maydell --- target/arm/cpu-features.h | 50 ++ target/arm/cpu64.c| 19 --- target/arm/tcg/cpu64.c| 108 +++--- 3 files changed, 117

[PULL 00/27] target-arm queue

2024-09-13 Thread Peter Maydell
arhwal as maintainer MAINTAINERS: Update Xilinx Versal OSPI maintainer's email address MAINTAINERS: Add my-self as CAN maintainer Jan Klötzke (1): hw/intc/arm_gic: fix spurious level triggered interrupts Johannes Stoelp (1): kvm: Use 'unsigned long' for request argument in

[PULL 10/27] hw/core/qdev: Simplify legacy_reset handling

2024-09-13 Thread Peter Maydell
DeviceClass::legacy_reset method. This will allow us to remove all the get_transitional_function handling from resettable.c. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Message-id: 20240830145812.1967042-11-peter.mayd...@linaro.org --- hw/core/qdev.c | 55

[PULL 13/27] hw/boards: Add hvf_get_physical_address_range to MachineClass

2024-09-13 Thread Peter Maydell
o admittedly it is much less generic than kvm_type today, but it seemed a somewhat sane way to get the information we need from the memmap at VM creation time. Signed-off-by: Danny Canter Message-id: 20240828111552.93482-2-danny_can...@apple.com Reviewed-by: Peter Maydell [PMM: removed explicit s

[PULL 09/27] hw: Remove device_phases_reset()

2024-09-13 Thread Peter Maydell
!= NULL. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Message-id: 20240830145812.1967042-10-peter.mayd...@linaro.org --- hw/core/qdev.c | 51 -- 1 file changed, 12 insertions(+), 39 deletions(-) diff --git a/hw/core/qdev.c b/hw/core

[PULL 04/27] hw: Remove device_class_set_parent_reset()

2024-09-13 Thread Peter Maydell
There are no callers of device_class_set_parent_reset() left in the tree, as they've all been converted to use three-phase reset and the corresponding resettable_class_set_parent_phases() function. Remove device_class_set_parent_reset(). Signed-off-by: Peter Maydell Reviewed-by: Philippe Ma

[PULL 08/27] hw: Rename DeviceClass::reset field to legacy_reset

2024-09-13 Thread Peter Maydell
Rename the DeviceClass::reset field to legacy_reset; this is helpful both in flagging up that it's best not used in new code and in making it easy to search for where it's being used still. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderso

Re: [PULL v2 00/61] Misc HW & UI patches for 2024-09-12

2024-09-13 Thread Peter Maydell
On Thu, 12 Sept 2024 at 07:53, Philippe Mathieu-Daudé wrote: > > v2: > - Fill Pierrick's commit description suggested by Eric Blake > - Include TMP105 fixes from Guenter > > The following changes since commit a4eb31c678400472de0b4915b9154a7c20d8332f: > > Merge tag 'pull-testing-gdbstub-oct-10092

Re: [PATCH v2] .gitlab-ci.d/crossbuilds.yml: Force 'make check' single-threaded for cross-i686-tci

2024-09-13 Thread Peter Maydell
On Fri, 13 Sept 2024 at 15:05, Daniel P. Berrangé wrote: > > On Fri, Sep 13, 2024 at 02:31:34PM +0100, Peter Maydell wrote: > > On Fri, 13 Sept 2024 at 13:24, Peter Maydell > > wrote: > > > > > > On Thu, 12 Sept 2024 at 16:10, Peter Maydell > > >

Re: [PULL 0/7] loongarch-to-apply queue

2024-09-13 Thread Peter Maydell
On Thu, 12 Sept 2024 at 14:09, Song Gao wrote: > > The following changes since commit 4b7ea33074450bc6148c8e1545d78f179e64adb4: > > Merge tag 'pull-request-2024-09-11' of https://gitlab.com/thuth/qemu into > staging (2024-09-11 19:28:23 +0100) > > are available in the Git repository at: > > h

Re: [PULL 0/5] target/sparc patch queue

2024-09-13 Thread Peter Maydell
On Thu, 12 Sept 2024 at 06:30, Richard Henderson wrote: > > The following changes since commit a4eb31c678400472de0b4915b9154a7c20d8332f: > > Merge tag 'pull-testing-gdbstub-oct-100924-1' of > https://gitlab.com/stsquad/qemu into staging (2024-09-11 13:17:29 +0100) > > are available in the Git r

Re: [PATCH v2] .gitlab-ci.d/crossbuilds.yml: Force 'make check' single-threaded for cross-i686-tci

2024-09-13 Thread Peter Maydell
On Fri, 13 Sept 2024 at 13:24, Peter Maydell wrote: > > On Thu, 12 Sept 2024 at 16:10, Peter Maydell wrote: > > > > The cross-i686-tci CI job is persistently flaky with various tests > > hitting timeouts. One theory for why this is happening is that we're > >

Re: [PATCH v2] .gitlab-ci.d/crossbuilds.yml: Force 'make check' single-threaded for cross-i686-tci

2024-09-13 Thread Peter Maydell
On Thu, 12 Sept 2024 at 16:10, Peter Maydell wrote: > > The cross-i686-tci CI job is persistently flaky with various tests > hitting timeouts. One theory for why this is happening is that we're > running too many tests in parallel and so sometimes a test gets > starved of C

Re: [RFC PATCH 0/2] qtest: Log verbosity changes

2024-09-13 Thread Peter Maydell
On Fri, 13 Sept 2024 at 12:29, Markus Armbruster wrote: > > Peter Maydell writes: > > Specifically, if you don't disable the error-exit when qtest > > is in use, then the generic qom-test tests which say "can we > > at least instantiate every machine?"

Re: [PULL 00/47] riscv-to-apply queue

2024-09-13 Thread Peter Maydell
On Thu, 12 Sept 2024 at 06:30, Alistair Francis wrote: > > The following changes since commit a4eb31c678400472de0b4915b9154a7c20d8332f: > > Merge tag 'pull-testing-gdbstub-oct-100924-1' of > https://gitlab.com/stsquad/qemu into staging (2024-09-11 13:17:29 +0100) > > are available in the Git re

Re: [RFC PATCH 0/2] qtest: Log verbosity changes

2024-09-13 Thread Peter Maydell
On Fri, 13 Sept 2024 at 11:02, Markus Armbruster wrote: > > Fabiano Rosas writes: > > I could add error/warn variants that are noop in case qtest is > > enabled. It would, however, lead to this pattern which is discouraged by > > the error.h documentation (+Cc Markus for advice): > > > > before:

Re: [PATCH 1/2] hw/sd: Remove legacy sd_set_cb()

2024-09-13 Thread Peter Maydell
On Fri, 13 Sept 2024 at 09:28, Markus Armbruster wrote: > > Peter Maydell writes: > > > On Tue, 3 Sept 2024 at 21:04, Philippe Mathieu-Daudé > > wrote: > >> > >> sd_set_cb() was only used by omap2_mmc_init() which > >> got recently removed. Time

Re: [PULL 00/18] virtio,pc,pci: features, fixes, cleanups

2024-09-13 Thread Peter Maydell
On Wed, 11 Sept 2024 at 14:51, Michael S. Tsirkin wrote: > > The following changes since commit a66f28df650166ae8b50c992eea45e7b247f4143: > > Merge tag 'migration-20240909-pull-request' of > https://gitlab.com/peterx/qemu into staging (2024-09-10 11:19:22 +0100) > > are available in the Git rep

Re: [PULL 00/17] Misc patches for 2024-09-11

2024-09-12 Thread Peter Maydell
On Wed, 11 Sept 2024 at 13:34, Paolo Bonzini wrote: > > The following changes since commit 7b87a25f49a301d3377f3e71e0b4a62540c6f6e4: > > Merge tag 'edgar/xen-queue-2024-09-04.for-upstream' of > https://gitlab.com/edgar.iglesias/qemu into staging (2024-09-05 13:02:26 > +0100) > > are available

Re: [PATCH RFC 10/10] tests/migration-tests: Add test case for responsive CPU throttle

2024-09-12 Thread Peter Maydell
On Thu, 12 Sept 2024 at 16:09, Peter Xu wrote: > > On Thu, Sep 12, 2024 at 09:13:16AM +0100, Peter Maydell wrote: > > On Wed, 11 Sept 2024 at 22:26, Fabiano Rosas wrote: > > > I don't think we're discussing total CI time at this point, so the math > > >

[PATCH v2] .gitlab-ci.d/crossbuilds.yml: Force 'make check' single-threaded for cross-i686-tci

2024-09-12 Thread Peter Maydell
I job runs in seems to cause us to default to a parallelism of 9 in the main CI.) Signed-off-by: Peter Maydell --- If this works we might be able to wind this up to -j2 or -j3, and/or consider whether other CI jobs need something similar. --- .gitlab-ci.d/crossbuilds.yml | 6 +- 1 file

Re: [PATCH] softmmu: Support concurrent bounce buffers

2024-09-12 Thread Peter Maydell
On Mon, 19 Aug 2024 at 14:56, Mattias Nissler wrote: > > When DMA memory can't be directly accessed, as is the case when > running the device model in a separate process without shareable DMA > file descriptors, bounce buffering is used. > > It is not uncommon for device models to request mapping

Re: [PATCH RFC 10/10] tests/migration-tests: Add test case for responsive CPU throttle

2024-09-12 Thread Peter Maydell
On Thu, 12 Sept 2024 at 14:48, Fabiano Rosas wrote: > Peter Maydell writes: > > For some examples from this week: > > > > https://gitlab.com/qemu-project/qemu/-/jobs/7802183144 > > https://gitlab.com/qemu-project/qemu/-/jobs/7799842373 > > https://gitlab.com/qe

Re: [PATCH v3 26/29] target/arm: Widen NeonGenNarrowEnvFn return to 64 bits

2024-09-12 Thread Peter Maydell
; Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v2] hw/intc/arm_gic: fix spurious level triggered interrupts

2024-09-12 Thread Peter Maydell
On Wed, 11 Sept 2024 at 12:49, Jan Klötzke wrote: > > On GICv2 and later, level triggered interrupts are pending when either > the interrupt line is asserted or the interrupt was made pending by a > GICD_ISPENDRn write. Making a level triggered interrupt pending by > software persists until either

Re: [PATCH v1 0/3] CAN & Xilinx OSPI maintainer updates

2024-09-12 Thread Peter Maydell
On Fri, 6 Sept 2024 at 19:16, Francisco Iglesias wrote: > > Hi all, > > I'm not in possesion of Vikram's new email address at his new job, because of > this the first patch in the series suggest's to remove Vikram as maintainer > for > the Xilinx CAN models and also the CAN bus subsystem. The sec

Re: [PATCH v2 14/48] include/hw/s390x: replace assert(false) with g_assert_not_reached()

2024-09-12 Thread Peter Maydell
On Thu, 12 Sept 2024 at 12:59, Philippe Mathieu-Daudé wrote: > > On 12/9/24 09:38, Pierrick Bouvier wrote: > > This patch is part of a series that moves towards a consistent use of > > g_assert_not_reached() rather than an ad hoc mix of different > > assertion mechanisms. > > > > Reviewed-by: Rich

Re: [PULL v2 00/24] Tests and misc patches

2024-09-12 Thread Peter Maydell
On Wed, 11 Sept 2024 at 10:34, Thomas Huth wrote: > > Hi Peter! > > The following changes since commit a66f28df650166ae8b50c992eea45e7b247f4143: > > Merge tag 'migration-20240909-pull-request' of > https://gitlab.com/peterx/qemu into staging (2024-09-10 11:19:22 +0100) > > are available in the

Re: [PATCH 0/2] Fixes for standard conformance

2024-09-12 Thread Peter Maydell
On Wed, 11 Sept 2024 at 23:30, Sergey Makarov wrote: > > *** Patchset goal *** > > This patchset aims to improve standard conformance for SiFive PLIC > implementation. > > *** Testing cases *** > > Currently there are no automated tests for these changes, but there > are several test cases, with w

Re: [PATCH RFC 10/10] tests/migration-tests: Add test case for responsive CPU throttle

2024-09-12 Thread Peter Maydell
On Wed, 11 Sept 2024 at 22:26, Fabiano Rosas wrote: > I don't think we're discussing total CI time at this point, so the math > doesn't really add up. We're not looking into making the CI finish > faster. We're looking into making migration-test finish faster. That > would reduce timeouts in CI, s

Re: [PULL 00/10] testing and gdbstub updates

2024-09-11 Thread Peter Maydell
On Wed, 11 Sept 2024 at 07:47, Alex Bennée wrote: > > The following changes since commit a66f28df650166ae8b50c992eea45e7b247f4143: > > Merge tag 'migration-20240909-pull-request' of > https://gitlab.com/peterx/qemu into staging (2024-09-10 11:19:22 +0100) > > are available in the Git repository

Re: [PULL 00/19] QAPI patches patches for 2024-09-10

2024-09-11 Thread Peter Maydell
On Tue, 10 Sept 2024 at 17:47, Markus Armbruster wrote: > > The following changes since commit 7bbadc60b58b742494555f06cd342311ddab9351: > > Merge tag 'crypto-fixes-pull-request' of https://gitlab.com/berrange/qemu > into staging (2024-09-09 15:19:32 +0100) > > are available in the Git reposito

Re: [PATCH] hw/intc/arm_gic: fix spurious level triggered interrupts

2024-09-11 Thread Peter Maydell
On Wed, 11 Sept 2024 at 11:54, Jan Klötzke wrote: > > On Fri, 2024-09-06 at 13:50 +0100, Peter Maydell wrote: > > On Mon, 2 Sept 2024 at 13:32, Jan Klötzke > > wrote: > > > > > > Level triggered interrupts are pending when either the interrupt line > &g

Re: [PATCH] arm/kvm: add support for MTE

2024-09-11 Thread Peter Maydell
On Wed, 11 Sept 2024 at 07:50, Ganapatrao Kulkarni wrote: > > > > On 10-09-2024 05:53 pm, Peter Maydell wrote: > > On Tue, 10 Sept 2024 at 12:57, Ganapatrao Kulkarni > > wrote: > >> On 16-07-2024 09:15 pm, Peter Maydell wrote: > >>> Since Cornelia

Re: [PATCH] hw/char/stm32l4x5_usart.c: Fix ACK and min access size

2024-09-11 Thread Peter Maydell
On Wed, 11 Sept 2024 at 07:27, Jacob Abrams wrote: > On 9/10/24 02:34, Peter Maydell wrote: > > If we make the .impl and .valid changes, then the result is > > that we permit 16 bit writes to come through to the read > > and write functions. Since we don't make any chan

Re: [PATCH] docs/devel: Prohibit calling object_unparent() for memory region

2024-09-10 Thread Peter Maydell
On Tue, 10 Sept 2024 at 18:27, Michael S. Tsirkin wrote: > > On Thu, Aug 29, 2024 at 02:46:48PM +0900, Akihiko Odaki wrote: > > Previously it was allowed to call object_unparent() for a memory region > > in instance_finalize() of its parent. However, such a call typically > > has no effect because

Re: [PATCH] softmmu: Support concurrent bounce buffers

2024-09-10 Thread Peter Maydell
On Tue, 10 Sept 2024 at 15:53, Michael S. Tsirkin wrote: > > On Mon, Aug 19, 2024 at 06:54:54AM -0700, Mattias Nissler wrote: > > When DMA memory can't be directly accessed, as is the case when > > running the device model in a separate process without shareable DMA > > file descriptors, bounce bu

Re: [PULL 00/22] Tests and misc patches

2024-09-10 Thread Peter Maydell
On Tue, 10 Sept 2024 at 13:37, Thomas Huth wrote: > > The following changes since commit 7bbadc60b58b742494555f06cd342311ddab9351: > > Merge tag 'crypto-fixes-pull-request' of https://gitlab.com/berrange/qemu > into staging (2024-09-09 15:19:32 +0100) > > are available in the Git repository at:

Re: [PATCH for-9.2] hw: add compat machines for 9.2

2024-09-10 Thread Peter Maydell
On Tue, 10 Sept 2024 at 16:31, Michael S. Tsirkin wrote: > > On Thu, Sep 05, 2024 at 08:05:14PM +0100, Peter Maydell wrote: > > On Thu, 5 Sept 2024 at 19:22, Daniel P. Berrangé > > wrote: > > > > > > On Fri, Aug 16, 2024 at 11:47:16AM +0100, Daniel P. Be

Re: [PATCH v2 00/29] target/arm: AdvSIMD decodetree conversion, part 4

2024-09-10 Thread Peter Maydell
onvert vector [US]QSHRN, [US]QRSHRN, SQSHRUN to > decodetree > target/arm: Convert scalar [US]QSHRN, [US]QRSHRN, SQSHRUN to > decodetree Other than my comments on the NeonGenNarrowEnvFn patch, series Reviewed-by: Peter Maydell thanks -- PMM

Re: [PULL 0/9] Migration 20240909 patches

2024-09-10 Thread Peter Maydell
On Mon, 9 Sept 2024 at 21:11, Peter Xu wrote: > > The following changes since commit f2aee60305a1e40374b2fc1093e4d04404e780ee: > > Merge tag 'pull-request-2024-09-08' of https://gitlab.com/huth/qemu into > staging (2024-09-09 10:47:24 +0100) > > are available in the Git repository at: > > htt

Re: [PATCH v2 26/29] target/arm: Widen NeonGenNarrowEnvFn return to 64 bits

2024-09-10 Thread Peter Maydell
On Mon, 9 Sept 2024 at 17:25, Richard Henderson wrote: > > While these functions really do return a 32-bit value, > widening the return type means that we need do less > marshalling between TCG types. > > Remove NeonGenNarrowEnvFn typedef; add NeonGenOne64OpEnvFn. > > Signed-off-by: Richard Hender

Re: [PATCH v2 12/29] target/arm: Convert FMOVI (scalar, immediate) to decodetree

2024-09-10 Thread Peter Maydell
On Mon, 9 Sept 2024 at 23:24, Philippe Mathieu-Daudé wrote: > > On 9/9/24 18:22, Richard Henderson wrote: > > Reviewed-by: Peter Maydell > > I wonder, maybe you mispasted my previous R-b tags > with Peter's? > https://lore.kernel.org/qemu-devel/37096dc8-7827-4a4c-a27

Re: [PATCH] arm/kvm: add support for MTE

2024-09-10 Thread Peter Maydell
On Tue, 10 Sept 2024 at 12:57, Ganapatrao Kulkarni wrote: > On 16-07-2024 09:15 pm, Peter Maydell wrote: > > Since Cornelia first wrote the patch this is based on, we've > > landed gdbstub support for MTE (so gdb can find out which > > addresses in the memory map ha

Re: [PATCH 2/2] .gitlab-ci.d/crossbuilds.yml: Force 'make check' single threaded for cross-i686-tci

2024-09-10 Thread Peter Maydell
On Tue, 10 Sept 2024 at 13:13, Thomas Huth wrote: > > On 06/09/2024 20.07, Peter Maydell wrote: > > The cross-i686-tci CI job is persistently flaky with various tests > > hitting timeouts. One theory for why this is happening is that we're > > running too many tests

Re: check-functional skipUnless failure

2024-09-10 Thread Peter Maydell
On Tue, 10 Sept 2024 at 08:37, Thomas Huth wrote: > > On 10/09/2024 08.41, Philippe Mathieu-Daudé wrote: > > While looking at this, I'm surprised to notice has_cmd() actually > > *runs* the command by calling run_cmd(). I'd have expected it solely > > checks for binary presence and RX perms, avoid

Re: [PATCH for-9.2 00/53] arm: Drop deprecated boards

2024-09-10 Thread Peter Maydell
On Mon, 9 Sept 2024 at 16:02, Peter Maydell wrote: > > On Mon, 9 Sept 2024 at 15:55, Guenter Roeck wrote: > > > > On 9/9/24 06:40, Philippe Mathieu-Daudé wrote: > > > Hi, > > > > > > On 3/9/24 18:06, Peter Maydell wrote: > > >> This patc

Re: [PATCH] docs/system/cpu-hotplug: Update example's socket-id/core-id

2024-09-10 Thread Peter Maydell
On Tue, 10 Sept 2024 at 10:03, Igor Mammedov wrote: > > On Mon, 19 Aug 2024 15:43:03 +0100 > Peter Maydell wrote: > > > At some point the way we allocate socket-id and core-id to CPUs > > by default changed; update the example of how to do CPU hotplug > > and unplu

Re: [PATCH] hw/char/stm32l4x5_usart.c: Fix ACK and min access size

2024-09-10 Thread Peter Maydell
On Mon, 9 Sept 2024 at 18:40, Philippe Mathieu-Daudé wrote: > > Hi, > > (Cc'ing Arnaud & Inès who are listed as maintainers) > > On 6/9/24 18:12, Peter Maydell wrote: > > On Mon, 2 Sept 2024 at 14:38, Jacob Abrams wrote: > >> > >> These chan

Re: [PATCH for-9.2 00/53] arm: Drop deprecated boards

2024-09-09 Thread Peter Maydell
On Mon, 9 Sept 2024 at 18:25, Philippe Mathieu-Daudé wrote: > > Hi Peter, > > On 9/9/24 15:44, Peter Maydell wrote: > > On Mon, 9 Sept 2024 at 14:41, Philippe Mathieu-Daudé > > wrote: > >> > >> Hi, > >> > >> On 3/9/24 18:06, Pete

Re: [PATCH trvivial] linux-user/syscall.c: replace function pointers for flock64 fcntl with macros

2024-09-09 Thread Peter Maydell
On Mon, 9 Sept 2024 at 17:19, Richard Henderson wrote: > > On 9/8/24 22:26, Michael Tokarev wrote: > >> Why do you think this is an improvement? > > > > It just feels more natural, so to say. > > > >> What was wrong with the function pointers? > > > > Not exactly wrong. It just hurts my eyes when

Re: [PULL 00/10] Crypto fixes patches

2024-09-09 Thread Peter Maydell
On Mon, 9 Sept 2024 at 15:17, Daniel P. Berrangé wrote: > > The following changes since commit f2aee60305a1e40374b2fc1093e4d04404e780ee: > > Merge tag 'pull-request-2024-09-08' of https://gitlab.com/huth/qemu into > staging (2024-09-09 10:47:24 +0100) > > are available in the Git repository at:

Re: [RFC PATCH] tests/qtest: Don't parallelize migration-test

2024-09-09 Thread Peter Maydell
On Mon, 9 Sept 2024 at 16:23, Alex Bennée wrote: > I guess one question is are we getting value from all the extra > migration tests? There certainly seem to be some sub-tests that are > slower than the others and I assume testing a small delta on the tests > before it. > > On s390x it seems the n

Re: [PATCH 1/2] hw/sd: Remove legacy sd_set_cb()

2024-09-09 Thread Peter Maydell
On Tue, 3 Sept 2024 at 21:04, Philippe Mathieu-Daudé wrote: > > sd_set_cb() was only used by omap2_mmc_init() which > got recently removed. Time to remove it. For historical > background on the me_no_qdev_me_kill_mammoth_with_rocks > kludge, see commit 007d1dbf72 ("sd: Hide the qdev-but-not-quite

Re: [PATCH 2/2] hw/sd: Remove legacy sd_enable()

2024-09-09 Thread Peter Maydell
gt; return dummy_byte; > > if (sd->state != sd_sendingdata_state) { Maybe add the { } that coding style wants to these if()s since we're editing them anyway? Either way, Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH for-9.2 00/53] arm: Drop deprecated boards

2024-09-09 Thread Peter Maydell
On Mon, 9 Sept 2024 at 15:55, Guenter Roeck wrote: > > On 9/9/24 06:40, Philippe Mathieu-Daudé wrote: > > Hi, > > > > On 3/9/24 18:06, Peter Maydell wrote: > >> This patchset removes the various Arm machines which we deprecated > >> for the 9.0 release a

Re: [Bug Report] smmuv3 event 0x10 report when running virtio-blk-pci

2024-09-09 Thread Peter Maydell
On Mon, 9 Sept 2024 at 15:22, Zhou Wang via wrote: > > Hi All, > > When I tested mainline qemu(commit 7b87a25f49), it reports smmuv3 event 0x10 > during kernel booting up. Does it still do this if you either: (1) use the v9.1.0 release (commit fd1952d814da) (2) use "-machine virt-9.1" instead o

Re: [PATCH RFC 10/10] tests/migration-tests: Add test case for responsive CPU throttle

2024-09-09 Thread Peter Maydell
On Mon, 9 Sept 2024 at 14:51, Hyman Huang wrote: > > Despite the fact that the responsive CPU throttle is enabled, > the dirty sync count may not always increase because this is > an optimization that might not happen in any situation. > > This test case just making sure it doesn't interfere with

Re: [PATCH v2 0/7] hw/net/can/xlnx-versal-canfd: Miscellaneous fixes

2024-09-09 Thread Peter Maydell
On Tue, 27 Aug 2024 at 04:51, Doug Brown wrote: > > This series fixes several problems I ran into while trying to simulate > the AMD/Xilinx Versal CANFD controller in the xlnx-versal-virt machine > using Xilinx's v6.6_LTS_2024.1 kernel. With all of these patches > applied, everything works correct

Re: [PATCH for-9.2 00/53] arm: Drop deprecated boards

2024-09-09 Thread Peter Maydell
On Mon, 9 Sept 2024 at 14:41, Philippe Mathieu-Daudé wrote: > > Hi, > > On 3/9/24 18:06, Peter Maydell wrote: > > This patchset removes the various Arm machines which we deprecated > > for the 9.0 release and are therefore allowed to remove for the 9.2 > > release

[RFC PATCH] tests/qtest: Don't parallelize migration-test

2024-09-09 Thread Peter Maydell
nificantly increases the runtime. For an all-architectures build on my local machine 'make check -j8' goes from real8m19.127s user31m47.534s sys 19m42.650s to real20m31.218s user32m48.712s sys 19m52.133s more than doubling the wallclock runtime. Signed-o

Re: [PULL 0/3] m68k patches

2024-09-09 Thread Peter Maydell
nge check 'slot' property (2024-09-08 11:49:49 > +0200) > > > * Fix Coverity issues in mcf5208evb and nubus machines > * Add URLs for mcf5208evb datasheets > > > > Peter Maydell (3): > hw/m68k

Re: [PULL 27/34] migration/multifd: Move nocomp code into multifd-nocomp.c

2024-09-09 Thread Peter Maydell
On Mon, 9 Sept 2024 at 11:28, Peter Maydell wrote: > > On Wed, 4 Sept 2024 at 13:48, Fabiano Rosas wrote: > > > > In preparation for adding new payload types to multifd, move most of > > the no-compression code into multifd-nocomp.c. Let's try to keep a > >

Re: [PULL 27/34] migration/multifd: Move nocomp code into multifd-nocomp.c

2024-09-09 Thread Peter Maydell
On Wed, 4 Sept 2024 at 13:48, Fabiano Rosas wrote: > > In preparation for adding new payload types to multifd, move most of > the no-compression code into multifd-nocomp.c. Let's try to keep a > semblance of layering by not mixing general multifd control flow with > the details of transmitting pag

Re: [PATCH trivial] linux-user/syscall.c: replace function pointer with a helper macro for fcntl/flock case

2024-09-07 Thread Peter Maydell
On Sat, 7 Sept 2024 at 08:00, Michael Tokarev wrote: > > There's a slight difference in fcntl locking handling on arm and others: > arm has 2 variants of struct flock argument handling, with and without eabi. > For this reason, we currently take address of the conversion function into > a variable

Re: [PULL 0/5] ufs queue

2024-09-07 Thread Peter Maydell
On Fri, 6 Sept 2024 at 11:58, Jeuk Kim wrote: > > From: Jeuk Kim > > The following changes since commit 7b87a25f49a301d3377f3e71e0b4a62540c6f6e4: > > Merge tag 'edgar/xen-queue-2024-09-04.for-upstream' of > https://gitlab.com/edgar.iglesias/qemu into staging (2024-09-05 13:02:26 > +0100) > >

Re: Build failure due to xen

2024-09-07 Thread Peter Maydell
On Sat, 7 Sept 2024 at 07:39, Michael Tokarev wrote: > > 07.09.2024 02:59, Kenneth Adam Miller wrote: > > Hello, > > > > I'm on commit bd80b59 and my host is: > > $ git desc bd80b59 > v2.4.0-rc3-9-gbd80b5963f > > Date: Mon Aug 3 11:44:07 2015 +0100 Wow, that is very old. So the answer, in order

Re: [PATCH v5 00/16] hw/char/pl011: Implement TX (async) FIFO to avoid blocking the main loop

2024-09-07 Thread Peter Maydell
On Sat, 7 Sept 2024 at 06:42, Philippe Mathieu-Daudé wrote: > > Hi Peter, > > On 19/7/24 20:10, Philippe Mathieu-Daudé wrote: > > > Philippe Mathieu-Daudé (16): > > >hw/char/pl011: Remove unused 'readbuff' field > >hw/char/pl011: Move pl011_put_fifo() earlier > >hw/char/pl011: Move pl0

[PATCH 1/2] scripts/mtest2make: Honour MESON_TESTTHREADS if it is set

2024-09-06 Thread Peter Maydell
meson test' passing it a --num-processes argument based on whatever the '-j' option to make was. Adjust the logic in mtest2make so that if MESON_TESTTHREADS is set then we honour that, and don't override it. Signed-off-by: Peter Maydell --- scripts/mtest2make.py | 4 1 f

[PATCH 2/2] .gitlab-ci.d/crossbuilds.yml: Force 'make check' single threaded for cross-i686-tci

2024-09-06 Thread Peter Maydell
ESTTHREADS environment variable to 1 for this job; this will cause 'meson test' to run only one test at a time. (Note that this relies on the change to meson2make that makes it honour MESON_TESTTHREADS; otherwise it will have no effect.) Signed-off-by: Peter Maydell --- Seems worth a try -- if

[PATCH 0/2] gitlab-ci: Force 'make check' single-threaded for cross-i686-tci

2024-09-06 Thread Peter Maydell
ider whether we should do something similar across the board -- at the moment we always use a parallelism of num-cpus + 1, because we use the same amount of parallelism that we do for the compile step. thanks -- PMM Peter Maydell (2): scripts/mtest2make: Honour MESON_TESTTHREADS if it is set .gitlab-ci

Re: [PATCH] hw/char/stm32l4x5_usart.c: Fix ACK and min access size

2024-09-06 Thread Peter Maydell
On Mon, 2 Sept 2024 at 14:38, Jacob Abrams wrote: > > These changes allow the official STM32L4xx HAL UART driver to function > properly with the b-l475e-iot01a machine. > > Modifying USART_CR1 TE bit should alter USART_ISR TEACK bit, and > likewise for RE and REACK bit. > > USART registers may be

Re: [PATCH v5] target/arm/tcg: refine cache descriptions with a wrapper

2024-09-06 Thread Peter Maydell
On Tue, 3 Sept 2024 at 15:45, Alireza Sanaee wrote: > > This patch allows for easier manipulation of the cache description > register, CCSIDR. Which is helpful for testing as well. Currently, > numbers get hard-coded and might be prone to errors. > > Therefore, this patch adds a wrapper for differ

Re: [PATCH v2 2/3] hvf: Split up hv_vm_create logic per arch

2024-09-06 Thread Peter Maydell
Is that modify this config that will be > coming in future patches). This should have no > behavioral difference at all as hv_vm_config_create() > just assigns the same default values as if you just > passed NULL to the function. > > Signed-off-by: Danny Canter Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v2 0/3] hvf: arm: Support creating VMs with 64+GB of RAM on macOS 15+

2024-09-06 Thread Peter Maydell
On Wed, 28 Aug 2024 at 12:16, Danny Canter wrote: > > This patchsets focus is on lighting up the ability to create VMs with 64+GB > of RAM through using some new APIs introduced in macOS 13. Due to the IPA > sizes > supported in macOS, the first version we can properly support this requirement >

Re: [PATCH v2 3/3] hvf: arm: Implement and use hvf_get_physical_address_range

2024-09-06 Thread Peter Maydell
ows VMs with 64+ GB of RAM and should fix the > oddness of the PARange situation as well. > > Signed-off-by: Danny Canter Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v2 1/3] hw/boards: Add hvf_get_physical_address_range to MachineClass

2024-09-06 Thread Peter Maydell
d = true; > nc->nmi_monitor_handler = x86_nmi; We guarantee that object and class structs are zero-initialized, so we don't need to explicitly set this field to NULL. Otherwise Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH] docs/system/cpu-hotplug: Update example's socket-id/core-id

2024-09-06 Thread Peter Maydell
On Mon, 19 Aug 2024 at 15:43, Peter Maydell wrote: > > At some point the way we allocate socket-id and core-id to CPUs > by default changed; update the example of how to do CPU hotplug > and unplug so the example commands work again. The differences > in the sample input and outpu

Re: [PATCH for-9.2 0/7] docs/devel: Convert txt files to rST

2024-09-06 Thread Peter Maydell
Ping for review on these docs conversions, please? thanks -- PMM On Fri, 16 Aug 2024 at 14:22, Peter Maydell wrote: > > This patchset converts a collection of the remaining txt files in > docs/devel to rST format. At this point in the release cycle > I'm targeting 9.2 for these

Re: [PATCH for-9.2 0/2] accel/kvm: Fix two minor Coverity nits

2024-09-06 Thread Peter Maydell
On Thu, 15 Aug 2024 at 14:12, Peter Maydell wrote: > > This patchset fixes a couple of minor Coverity nits: > * a can't-happen integer overflow when assigning from a long to >an int in kvm_init_vcpu() > * some unreachable code in kvm_dirty_ring_reaper_thread() > &g

Re: [PATCH v2 00/11] s390: Convert virtio-ccw, cpu to three-phase reset, and followup cleanup

2024-09-06 Thread Peter Maydell
On Fri, 30 Aug 2024 at 15:58, Peter Maydell wrote: > > The main aim of this patchseries is to remove the two remaining uses > of device_class_set_parent_reset() in the tree, which are virtio-ccw > and the s390 CPU class. Doing that lets us do some followup cleanup. > (The diffstat

Re: [PATCH v2 0/7] hw/net/can/xlnx-versal-canfd: Miscellaneous fixes

2024-09-06 Thread Peter Maydell
On Tue, 27 Aug 2024 at 04:51, Doug Brown wrote: > > This series fixes several problems I ran into while trying to simulate > the AMD/Xilinx Versal CANFD controller in the xlnx-versal-virt machine > using Xilinx's v6.6_LTS_2024.1 kernel. With all of these patches > applied, everything works correct

Re: [PATCH 0/2] tests/qtest: Fix problems running with make vm-build-openbsd

2024-09-06 Thread Peter Maydell
On Thu, 5 Sept 2024 at 17:55, Peter Maydell wrote: > > I noticed that 'make vm-build-openbsd' had bitrotted a bit: > * two tests for the stm32l4x5 forgot a qtest_quit(), which meant >they would pass all their subtests but then timeout because the >underlying

Re: [PULL 00/25] target-arm queue

2024-09-06 Thread Peter Maydell
On Thu, 5 Sept 2024 at 14:01, Peter Maydell wrote: > > First target-arm queue for 9.2. I know I have more stuff in > my to-review queue after this... > > -- PMM > > The following changes since commit cab1afb393ea0943b3086188e91d71d594ede6bf: > > Merge tag '

Re: [PULL 00/34] Migration patches for 2024-09-04

2024-09-06 Thread Peter Maydell
On Wed, 4 Sept 2024 at 13:49, Fabiano Rosas wrote: > > The following changes since commit e638d685ec2a0700fb9529cbd1b2823ac4120c53: > > Open 9.2 development tree (2024-09-03 09:18:43 -0700) > > are available in the Git repository at: > > https://gitlab.com/farosas/qemu.git tags/migration-20240

Re: [PATCH] hw/intc/arm_gic: fix spurious level triggered interrupts

2024-09-06 Thread Peter Maydell
On Mon, 2 Sept 2024 at 13:32, Jan Klötzke wrote: > > Level triggered interrupts are pending when either the interrupt line > is asserted or the interrupt was made pending by a GICD_ISPENDRn write. > Making a level triggered interrupt pending by software persists until > either the interrupt is ack

Re: [PULL 00/42] Introduce new functional test framework

2024-09-06 Thread Peter Maydell
On Wed, 4 Sept 2024 at 11:40, Thomas Huth wrote: > > Hi! > > The following changes since commit e638d685ec2a0700fb9529cbd1b2823ac4120c53: > > Open 9.2 development tree (2024-09-03 09:18:43 -0700) > > are available in the Git repository at: > > https://gitlab.com/thuth/qemu.git tags/pull-reque

Re: [RFC PATCH 0/2] qtest: Log verbosity changes

2024-09-06 Thread Peter Maydell
On Fri, 6 Sept 2024 at 09:14, Daniel P. Berrangé wrote: > > On Fri, Sep 06, 2024 at 08:16:31AM +0200, Thomas Huth wrote: > > On 05/09/2024 23.03, Fabiano Rosas wrote: > > > Hi, > > > > > > This series silences QEMU stderr unless the QTEST_LOG variable is set > > > and silences -qtest-log unless bo

Re: [PATCH] target/riscv/cpu_helper: Fix linking problem with semihosting disabled

2024-09-06 Thread Peter Maydell
On Fri, 6 Sept 2024 at 10:30, Thomas Huth wrote: > > On 06/09/2024 10.58, Peter Maydell wrote: > > On Fri, 6 Sept 2024 at 09:09, Thomas Huth wrote: > >> > >> When QEMU has been configured with "--without-default-devices", the build > >> is current

Re: [PATCH] target/riscv/cpu_helper: Fix linking problem with semihosting disabled

2024-09-06 Thread Peter Maydell
On Fri, 6 Sept 2024 at 09:09, Thomas Huth wrote: > > When QEMU has been configured with "--without-default-devices", the build > is currently failing with: > > /usr/bin/ld: libqemu-riscv32-softmmu.a.p/target_riscv_cpu_helper.c.o: > in function `riscv_cpu_do_interrupt': > .../qemu/target/riscv/

Re: [PATCH v2 1/1] util/util/cpuinfo-riscv.c: fix riscv64 build on musl libc

2024-09-05 Thread Peter Maydell
On Thu, 5 Sept 2024 at 20:44, Richard Henderson wrote: > > On 9/5/24 08:06, Milan P. Stanić wrote: > > build fails on musl libc (alpine linux) with this error: > > > > ../util/cpuinfo-riscv.c: In function 'cpuinfo_init': > > ../util/cpuinfo-riscv.c:63:21: error: '__NR_riscv_hwprobe' undeclared >

Re: [PATCH] ci: migration: Don't run python tests in the compat job

2024-09-05 Thread Peter Maydell
On Thu, 5 Sept 2024 at 20:34, Fabiano Rosas wrote: > > Peter Xu writes: > > > On Thu, Sep 05, 2024 at 03:54:45PM -0300, Fabiano Rosas wrote: > >> The vmstate-checker-script test has a bug that makes it flaky. It was > >> also committed by mistake and will be removed. > >> > >> Since the migration

Re: [PATCH 7/8] Revert "target/riscv: Restrict semihosting to TCG"

2024-09-05 Thread Peter Maydell
On Thu, 5 Sept 2024 at 20:16, Thomas Huth wrote: > > This reverts commit 10425887ba54241be1ce97f8935fc320332b531c. > > Using "imply" instead of "select" is causing a build failure: > > /usr/bin/ld: libqemu-riscv32-softmmu.a.p/target_riscv_cpu_helper.c.o: in > function `riscv_cpu_do_interrupt': >

Re: [PATCH for-9.2] hw: add compat machines for 9.2

2024-09-05 Thread Peter Maydell
On Thu, 5 Sept 2024 at 19:22, Daniel P. Berrangé wrote: > > On Fri, Aug 16, 2024 at 11:47:16AM +0100, Daniel P. Berrangé wrote: > > On Fri, Aug 16, 2024 at 12:37:23PM +0200, Cornelia Huck wrote: > > > Add 9.2 machine types for arm/i440fx/m68k/q35/s390x/spapr. > > > > > > Signed-off-by: Cornelia Hu

[PATCH 1/2] tests/qtest: Add missing qtest_quit() to stm32 tests

2024-09-05 Thread Peter Maydell
to a SIGTERM or polite request to quit, but it also sidestepped the problem in this case. However, OpenBSD doesn't have a PDEATHSIG equivalent, so we see the timeouts when running a 'make vm-build-openbsd' run. Add the missing qtest_quit() calls. Signed-off-by: Peter Maydell --- Many th

[PATCH 2/2] tests/qtest: Bump timeout on ahci-test

2024-09-05 Thread Peter Maydell
On my OpenBSD VM test system, the ahci-test sometimes hits its 60 second timeout. It has 75 subtests and allowing at least two seconds per subtest seems reasonable. Bump it to 150s. Signed-off-by: Peter Maydell --- tests/qtest/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a

[PATCH 0/2] tests/qtest: Fix problems running with make vm-build-openbsd

2024-09-05 Thread Peter Maydell
s patchset fixes these. thanks -- PMM Peter Maydell (2): tests/qtest: Add missing qtest_quit() to stm32 tests tests/qtest: Bump timeout on ahci-test tests/qtest/dm163-test.c | 2 ++ tests/qtest/stm32l4x5_usart-test.c | 2 ++ tests/qtest/meson.build| 1 + 3 files changed, 5

Re: [PULL v1 00/12] Xen queue

2024-09-05 Thread Peter Maydell
On Wed, 4 Sept 2024 at 17:15, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > The following changes since commit e638d685ec2a0700fb9529cbd1b2823ac4120c53: > > Open 9.2 development tree (2024-09-03 09:18:43 -0700) > > are available in the Git repository at: > > https://gitlab.com/ed

Re: [PATCH] util/util/cpuinfo-riscv.c: fix riscv64 build on musl libc

2024-09-05 Thread Peter Maydell
On Thu, 5 Sept 2024 at 14:19, Milan P. Stanić wrote: > > build fails on musl libc (alpine linux) with this error: > > ../util/cpuinfo-riscv.c: In function 'cpuinfo_init': > ../util/cpuinfo-riscv.c:63:21: error: '__NR_riscv_hwprobe' undeclared (first > use in this function); did you mean 'riscv_hw

<    1   2   3   4   5   6   7   8   9   10   >