[PULL 03/15] gdbstub/system: Rename 'user_ctx' argument as 'ctx'

2024-04-02 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20240313213339.82071-4-phi...@linaro.org> --- gdbstub/internals.h | 8 gdbstub/system.c| 8 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/gdbstub/internals.h b/g

[PULL 07/15] qtest/libqos: Reduce size_to_prdtl() declaration scope

2024-04-02 Thread Philippe Mathieu-Daudé
Since size_to_prdtl() is only used within ahci.c, declare it statically. This removes the last use of "inlined function with external linkage". See previous commit and commit 9de9fa5cf2 for rationale. Suggested-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Pet

[PULL 06/15] accel/hvf: Un-inline hvf_arch_supports_guest_debug()

2024-04-02 Thread Philippe Mathieu-Daudé
See previous commit and commit 9de9fa5cf2 ("Avoid using inlined functions with external linkage") for rationale. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Reviewed-by: Richard Henderson Message-Id: <20240313184954.42513-3-phi...@linaro.org> --- target/ar

[PULL 05/15] hw/arm/smmu: Avoid using inlined functions with external linkage again

2024-04-02 Thread Philippe Mathieu-Daudé
quot;hw/arm/smmuv3: Add CMDs related to stage-2") Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Eric Auger Message-Id: <20240313184954.42513-2-phi...@linaro.org> --- hw/arm/smmu-common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

[PULL 00/15] Misc HW patches for 2024-04-02

2024-04-02 Thread Philippe Mathieu-Daudé
maintainer email address Kevin Wolf (1): block: Remove unnecessary NULL check in bdrv_pad_request() Marc-André Lureau (2): plugins: fix -Werror=maybe-uninitialized false-positive hw/nvme: fix -Werror=maybe-uninitialized Philippe Mathieu-Daudé (8): accel/tcg/plugin: Remove CONFIG_SOFTMMU_GATE

[PULL 02/15] gdbstub: Correct invalid mentions of 'softmmu' by 'system'

2024-04-02 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson Message-Id: <20240313213339.82071-3-phi...@linaro.org> --- gdbstub/internals.h | 20 ++-- gdbstub/system.c| 2 +- 2 files changed, 11 insertions(+), 11 deletions(-) diff

Re: [PATCH] virtio-net: fix qemu set used ring flag even vhost started

2024-04-02 Thread Philippe Mathieu-Daudé
On 2/4/24 14:41, Yajun Wu wrote: On 4/2/2024 8:11 PM, Philippe Mathieu-Daudé wrote: External email: Use caution opening links or attachments Hi Yajun, On 2/4/24 06:51, Yajun Wu wrote: When vhost-user or vhost-kernel is handling virtio net datapath, qemu "QEMU" Ack. should not

Re: Patch for qemu-project/qemu#2247 issue

2024-04-02 Thread Philippe Mathieu-Daudé
On 2/4/24 11:59, Michael Tokarev wrote: 02.04.2024 12:50, Philippe Mathieu-Daudé пишет: On 1/4/24 18:52, Michael Tokarev wrote: 01.04.2024 12:43, liu.d...@zte.com.cn wrote: hmp: Add help information for watchdog action: inject-nmi virsh qemu-monitor-command --hmp help information

Re: [PATCH] sh4: mac.w: memory accesses are 16-bit words

2024-04-02 Thread Philippe Mathieu-Daudé
IGN); arg1 = tcg_temp_new(); tcg_gen_qemu_ld_i32(arg1, REG(B11_8), ctx->memidx, -MO_TESL | MO_ALIGN); +MO_TESW | MO_ALIGN); Apparently invalid since its introduction in commit fdf9b3e831. Reviewed-by: Philippe M

Re: [PATCH] virtio-net: fix qemu set used ring flag even vhost started

2024-04-02 Thread Philippe Mathieu-Daudé
Hi Yajun, On 2/4/24 06:51, Yajun Wu wrote: When vhost-user or vhost-kernel is handling virtio net datapath, qemu "QEMU" should not touch used ring. But with vhost-user socket reconnect scenario, in a very rare case (has pending kick event). VRING_USED_F_NO_NOTIFY is set by qemu in "QEMU"

[PATCH v2 1/2] scripts/checkpatch: Avoid author email mangled by qemu-*@nongnu.org

2024-04-02 Thread Philippe Mathieu-Daudé
Commit f5177798d8 ("scripts: report on author emails that are mangled by the mailing list") added a check for qemu-devel@ list, extend the regexp to cover more such qemu-trivial@, qemu-block@ and qemu-ppc@. Signed-off-by: Philippe Mathieu-Daudé --- scripts/checkpatch.pl | 2 +- 1 fi

[PATCH v2 2/2] scripts/checkpatch: Do not use mailmap

2024-04-02 Thread Philippe Mathieu-Daudé
The .mailmap file fixes mistake we already did. Do not use it when running checkpatch.pl, otherwise we might commit the very same mistakes. Reported-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé --- scripts/checkpatch.pl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions

[PATCH v2 0/2] scripts/checkpatch: Do not use mailmap and check qemu-trivial@ author

2024-04-02 Thread Philippe Mathieu-Daudé
Since v1: - Extend regexp to cover all lists (Peter) * qemu-trivial@ is not checked * mailmap hides the mistakes we want to catch See https://lore.kernel.org/qemu-devel/60faa39d-52e8-46f1-8bd9-9d9661794...@tls.msk.ru/ Philippe Mathieu-Daudé (2): scripts/checkpatch: Avoid author email mangled

Re: [PATCH 1/2] scripts/checkpatch: Avoid author email mangled by qemu-trivial@

2024-04-02 Thread Philippe Mathieu-Daudé
On 2/4/24 13:53, Philippe Mathieu-Daudé wrote: On 2/4/24 13:52, Peter Maydell wrote: On Tue, 2 Apr 2024 at 12:30, Philippe Mathieu-Daudé wrote: Commit f5177798d8 ("scripts: report on author emails that are mangled by the mailing list") added a check for qemu-devel@ list, complete

Re: [PATCH 1/2] scripts/checkpatch: Avoid author email mangled by qemu-trivial@

2024-04-02 Thread Philippe Mathieu-Daudé
On 2/4/24 13:52, Peter Maydell wrote: On Tue, 2 Apr 2024 at 12:30, Philippe Mathieu-Daudé wrote: Commit f5177798d8 ("scripts: report on author emails that are mangled by the mailing list") added a check for qemu-devel@ list, complete with qemu-trivial@. Signed-off-by: Philippe Mat

Re: [PATCH for-9.0 3/4] vga: adjust dirty memory region if pel panning is active

2024-04-02 Thread Philippe Mathieu-Daudé
ilippe Mathieu-Daudé

Re: [PATCH for-9.0 2/4] vga: move computation of dirty memory region later

2024-04-02 Thread Philippe Mathieu-Daudé
vga.c | 50 1 file changed, 25 insertions(+), 25 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH for-9.0 1/4] vga: merge conditionals on shift control register

2024-04-02 Thread Philippe Mathieu-Daudé
ts" value available early and can use it to compute region_end. Signed-off-by: Paolo Bonzini --- hw/display/vga.c | 89 +++- 1 file changed, 42 insertions(+), 47 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v3 11/17] esp.c: rework esp_cdb_length() into esp_cdb_ready()

2024-04-02 Thread Philippe Mathieu-Daudé
() returns -1, plus simplify the logic for its callers. Suggested-by: Paolo Bonzini Signed-off-by: Mark Cave-Ayland --- hw/scsi/esp.c | 30 ++ 1 file changed, 14 insertions(+), 16 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v3 12/17] esp.c: prevent cmdfifo overflow in esp_cdb_ready()

2024-04-02 Thread Philippe Mathieu-Daudé
On 25/3/24 13:41, Mark Cave-Ayland wrote: On 25/03/2024 10:26, Philippe Mathieu-Daudé wrote: On 24/3/24 20:17, Mark Cave-Ayland wrote: During normal use the cmdfifo will never wrap internally and cmdfifo_cdb_offset will always indicate the start of the SCSI CDB. However it is possible

Re: [PATCH v3 10/17] esp.c: don't assert() if FIFO empty when executing non-DMA SELATNS

2024-04-02 Thread Philippe Mathieu-Daudé
On 25/3/24 13:57, Mark Cave-Ayland wrote: On 25/03/2024 10:49, Philippe Mathieu-Daudé wrote: On 24/3/24 20:16, Mark Cave-Ayland wrote: The current logic assumes that at least 1 byte is present in the FIFO when executing a non-DMA SELATNS command, but this may not be the case if the guest

[PATCH 1/2] scripts/checkpatch: Avoid author email mangled by qemu-trivial@

2024-04-02 Thread Philippe Mathieu-Daudé
Commit f5177798d8 ("scripts: report on author emails that are mangled by the mailing list") added a check for qemu-devel@ list, complete with qemu-trivial@. Signed-off-by: Philippe Mathieu-Daudé --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 2/2] scripts/checkpatch: Do not use mailmap

2024-04-02 Thread Philippe Mathieu-Daudé
The .mailmap file fixes mistake we already did. Do not use it when running checkpatch.pl, otherwise we might commit the very same mistakes. Reported-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé --- scripts/checkpatch.pl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions

[PATCH 0/2] scripts/checkpatch: Do not use mailmap and check qemu-trivial@ author

2024-04-02 Thread Philippe Mathieu-Daudé
- qemu-trivial@ is not checked - mailmap hides the mistakes we want to catch See https://lore.kernel.org/qemu-devel/60faa39d-52e8-46f1-8bd9-9d9661794...@tls.msk.ru/ Philippe Mathieu-Daudé (2): scripts/checkpatch: Avoid author email mangled by qemu-trivial@ scripts/checkpatch: Do not use

Re: [PATCH v2] linux-user/syscall: xtensa: fix ipc_perm conversion

2024-04-02 Thread Philippe Mathieu-Daudé
: a3da8be5126b ("target/xtensa: linux-user: fix sysv IPC structures") Signed-off-by: Max Filippov --- Changes v1->v2: - split into a separate patch linux-user/syscall.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH] hw/xen_evtchn: Initialize flush_kvm_routes

2024-04-02 Thread Philippe Mathieu-Daudé
On 29/3/24 12:39, Artem Chernyshev wrote: In xen_evtchn_soft_reset() variable flush_kvm_routes can be used before being initialized. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Oleg Sviridov Signed-off-by: Artem Chernyshev --- hw/i386/kvm/xen_evtchn.c |

Re: [PATCH] gpio/pca955x: Update maintainer email address

2024-04-02 Thread Philippe Mathieu-Daudé
On 28/3/24 20:49, Glenn Miles wrote: It was noticed that my linux.vnet.ibm.com address does not always work so dropping the vnet to see if that works better. Signed-off-by: Glenn Miles --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Patch queued, thanks!

Re: [PATCH] block: Remove unnecessary NULL check in bdrv_pad_request()

2024-04-02 Thread Philippe Mathieu-Daudé
On 27/3/24 20:27, Kevin Wolf wrote: Coverity complains that the check introduced in commit 3f934817 suggests that qiov could be NULL and we dereference it before reaching the check. In fact, all of the callers pass a non-NULL pointer, so just remove the misleading check. Resolves: Coverity CID

Re: [PATCH] MAINTAINERS: Fix error-report.c entry

2024-04-02 Thread Philippe Mathieu-Daudé
rt.c entry. Signed-off-by: Zhao Liu --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé And queued, thanks!

Re: Patch for qemu-project/qemu#2247 issue

2024-04-02 Thread Philippe Mathieu-Daudé
On 1/4/24 18:52, Michael Tokarev wrote: 01.04.2024 12:43, liu.d...@zte.com.cn wrote: hmp: Add help information for watchdog action: inject-nmi virsh qemu-monitor-command --hmp help information of watchdog_action missing inject-nmi which already supported in Commit 795dc6e4 Signed-off-by:

Re: [PATCH] lsi53c895a: avoid out of bounds access to s->msg[]

2024-04-02 Thread Philippe Mathieu-Daudé
c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 4/4] linux-user/syscall: do_setsockopt(): eliminate goto in switch for SO_SNDTIMEO

2024-04-02 Thread Philippe Mathieu-Daudé
--- 1 file changed, 4 insertions(+), 7 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: Fast booting q35 VM?

2024-04-02 Thread Philippe Mathieu-Daudé
Cc'ing qemu-devel@ On 30/3/24 10:00, Paul Menzel wrote: Dear Linux folks, Starting a QEMU q35 with Linux built with `make defconfig`     qemu7-system-x86_64 -M q35 -m 32G -enable-kvm -cpu host -smp cpus=32 -device virtio-rng-pci -net nic,model=virtio-net-pci -net

Re: [PATCH v6 1/2] qga: Refactor common functions between POSIX and Windows implementation

2024-04-02 Thread Philippe Mathieu-Daudé
linaro.org/): Reviewed-by: Philippe Mathieu-Daudé --- qga/commands-common-ssh.c | 50 +++ qga/commands-common-ssh.h | 10 qga/commands-posix-ssh.c | 47 +--- qga/meson.build | 1 + 4 files changed, 62

QEMU Community Call Agenda Items (April 2nd, 2024)

2024-03-29 Thread Philippe Mathieu-Daudé
Hi, The KVM/QEMU community call is at: https://meet.jit.si/kvmcallmeeting @ 2/4/2024 14:00 UTC Are there any agenda items for the sync-up? Alex maintains the invite on our Linaro project calendar here:

Re: [RFC PATCH-for-9.1 14/21] system: Introduce QMP generic_query_cpu_definitions()

2024-03-29 Thread Philippe Mathieu-Daudé
Hi Markus, On 26/3/24 14:28, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: Each target use a common template for qmp_query_cpu_definitions(). Extract it as generic_query_cpu_definitions(), keeping the target-specific implementations as the following SysemuCPUOps handlers

Re: [PATCH] hw/xen_evtchn: Initialize flush_kvm_routes

2024-03-29 Thread Philippe Mathieu-Daudé
| 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH for-9.1] migration: Add Error** argument to add_bitmaps_to_list()

2024-03-29 Thread Philippe Mathieu-Daudé
/20240320064911.545001-1-...@redhat.com/ migration/block-dirty-bitmap.c | 34 -- 1 file changed, 16 insertions(+), 18 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH for-9.0] tests/qtest: Fix STM32L4x5 GPIO test on 32-bit

2024-03-29 Thread Philippe Mathieu-Daudé
Hi Cédric, Thomas, On 29/3/24 10:27, Cédric Le Goater wrote: The test mangles the GPIO address and the pin number in the qtest_add_data_func data parameter. Doing so, it assumes that the host pointer size is always 64-bit, which breaks on 32-bit : ../tests/qtest/stm32l4x5_gpio-test.c: In

Re: [PATCH] linux-user/syscall: xtensa: fix target_msqid_ds and ipc_perm conversion

2024-03-29 Thread Philippe Mathieu-Daudé
Hi Max, On 29/3/24 07:31, Max Filippov wrote: - target_ipc_perm::mode and target_ipc_perm::__seq fields are 32-bit wide on xtensa and thus need to use tswap32 - target_msqid_ds::msg_*time field pairs are reversed on big-endian xtensa Please split in 2 distinct patches. Both issues

Re: [PATCH] spapr: nested: use bitwise NOT operator for flags check

2024-03-29 Thread Philippe Mathieu-Daudé
/spapr_nested.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

2024-03-29 Thread Philippe Mathieu-Daudé
Hi Zhijian, On 29/3/24 02:53, Zhijian Li (Fujitsu) wrote: On 28/03/2024 23:01, Peter Xu wrote: On Thu, Mar 28, 2024 at 11:18:04AM -0300, Fabiano Rosas wrote: Philippe Mathieu-Daudé writes: The whole RDMA subsystem was deprecated in commit e9a54265f5 ("hw/rdma: Deprecate the pvrdma d

Re: [PATCH-for-9.0 v2] hw/i386/pc: Deprecate 64-bit CPUs on ISA-only PC machine

2024-03-29 Thread Philippe Mathieu-Daudé
On 28/3/24 16:39, Thomas Huth wrote: On 28/03/2024 16.12, Mark Cave-Ayland wrote: On 27/03/2024 16:54, Philippe Mathieu-Daudé wrote: Per Daniel suggestion [*]:   > isapc could arguably be restricted to just 32-bit CPU models,   > because we should not need it to support any f

Re: [RFC PATCH-for-9.1 09/29] hw/i386/pc: Pass PCMachineState argument to acpi_setup()

2024-03-29 Thread Philippe Mathieu-Daudé
On 28/3/24 19:45, BALATON Zoltan wrote: On Thu, 28 Mar 2024, Philippe Mathieu-Daudé wrote: acpi_setup() caller knows about the machine state, so pass it as argument to avoid a qdev_get_machine() call. We already resolved X86_MACHINE(pcms) as 'x86ms' so use the latter. Signed-off-by: Philippe

Re: [PATCH v5 1/2] Refactor common functions between POSIX and Windows implementation

2024-03-28 Thread Philippe Mathieu-Daudé
har *user_name, GError **error) + static struct passwd * + test_get_passwd_entry(const gchar *user_name, GError **error) Modulo this spurious change, Reviewed-by: Philippe Mathieu-Daudé Thank you for your various iterations, Phil.

[RFC PATCH-for-9.1 13/29] hw/i386/pc: Remove non-PCI code from pc_system_firmware_init()

2024-03-28 Thread Philippe Mathieu-Daudé
x86_bios_rom_init() is the single non-PCI-machine call from pc_system_firmware_init(). Extract it to the caller. Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/pc.c | 6 +- hw/i386/pc_sysfw.c | 5 + 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/hw/i386/pc.c b

[RFC PATCH-for-9.1 08/29] hw/i386/pc: Move CXLState to PcPciMachineState

2024-03-28 Thread Philippe Mathieu-Daudé
CXL depends on PCIe, which isn't available on non-PCI machines such the ISA-only PC one. Move CXLState to PcPciMachineState, and move the CXL specific calls to pc_pci_machine_initfn() and pc_pci_machine_done(). Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i386/pc.h | 3 ++- hw/i386

[RFC PATCH-for-9.1 28/29] hw/i386/pc: Rename pc_init1() -> pc_piix_init()

2024-03-28 Thread Philippe Mathieu-Daudé
pc_init1() is specific to the isapc and i440fx/piix machines, rename it as pc_piix_init(). Expose it in "hw/i386/pc.h" to be able to call it externally (see next patch). Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i386/pc.h | 1 + hw/i386/pc_piix.c| 8 hw/

[RFC PATCH-for-9.1 15/29] hw/i386/pc: Move FW/pflash related fields to PcPciMachineState

2024-03-28 Thread Philippe Mathieu-Daudé
Only PCI-based machines use the set of parallel flash devices. Move the fields from PCMachineState to PcPciMachineState. Directly pass a PcPciMachineState argument to the pc_system_flash/fw methods. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i386/pc.h | 10 hw/i386/pc.c

[RFC PATCH-for-9.1 07/29] hw/i386/pc: Call fw_cfg_add_extra_pci_roots() in pc_pci_machine_done()

2024-03-28 Thread Philippe Mathieu-Daudé
fw_cfg_add_extra_pci_roots() expects a PCI bus, which only PCI-based machines have. No need to call it on the ISA-only machine. Move it to the PCI-specific machine_done handler. Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/pc.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions

[RFC PATCH-for-9.1 24/29] hw/i386/fw_cfg: Inline smbios_legacy_mode()

2024-03-28 Thread Philippe Mathieu-Daudé
All PCI-based machines have the smbios_legacy_mode field set to %false. Simplify by using an inlined helper checking whether the machine is PCI-based or not. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i386/pc.h | 1 - hw/i386/fw_cfg.c | 8 ++-- hw/i386/pc_piix.c| 2 -- 3

[RFC PATCH-for-9.1 14/29] hw/i386/pc: Move pc_system_flash_create() to pc_pci_machine_initfn()

2024-03-28 Thread Philippe Mathieu-Daudé
pc_system_flash_create() is only useful for PCI-based machines. Move the call to the PCI-based init() handler. Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/pc.c | 2 +- hw/i386/pc_sysfw.c | 10 -- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/hw/i386/pc.c b

[RFC PATCH-for-9.1 22/29] hw/i386/fw_cfg: Define fw_cfg_build_smbios() stub

2024-03-28 Thread Philippe Mathieu-Daudé
We are going to refactor fw_cfg_build_smbios() in the next patches. In order to avoid too much #ifdef'ry in it, define a stub. Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/fw_cfg-smbios-stub.c | 15 +++ hw/i386/fw_cfg.c | 4 ++-- hw/i386/meson.build | 1

[RFC PATCH-for-9.1 19/29] hw/i386/pc: Pass PcPciMachineState argument to CXL helpers

2024-03-28 Thread Philippe Mathieu-Daudé
Since CXL helpers expect a PCI-based machine, we can directly pass them a PcPciMachineState argument. Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/pc.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index e36d76656b

[RFC PATCH-for-9.1 29/29] hw/i386/pc: Move ISA-only PC machine to pc_isa.c

2024-03-28 Thread Philippe Mathieu-Daudé
Extract the ISA-only PC machine code from pc_piix.c to a new file, pc_isa.c. Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 + hw/i386/pc_isa.c| 33 + hw/i386/pc_piix.c | 23 --- hw/i386/meson.build | 1 + 4 files

[RFC PATCH-for-9.1 27/29] hw/i386/pc: Call fw_cfg_build_smbios_legacy() in pc_machine_done()

2024-03-28 Thread Philippe Mathieu-Daudé
Keep fw_cfg_build_smbios() for PCI-based machines, call fw_cfg_build_smbios_legacy() directly from pc_machine_done(). Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/fw_cfg.c | 10 -- hw/i386/pc.c | 12 +++- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git

[RFC PATCH-for-9.1 25/29] hw/i386/fw_cfg: Replace smbios_defaults() by !smbios_legacy_mode()

2024-03-28 Thread Philippe Mathieu-Daudé
smbios_defaults() and smbios_legacy_mode() are logical opposite. Simplify using the latter. Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/fw_cfg.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/hw/i386/fw_cfg.c b/hw/i386/fw_cfg.c index ffa60a4a33..df05fe060c

[RFC PATCH-for-9.1 11/29] hw/i386/pc: Move acpi_setup() call to pc_pci_machine_done()

2024-03-28 Thread Philippe Mathieu-Daudé
build_enabled is only set on PCI-based machines, so it is pointless to call acpi_setup() from non-PCI like the ISA-only machine, move the call to pc_pci_machine_done(). Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/pc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/i

[RFC PATCH-for-9.1 21/29] hw/i386/fw_cfg: Include missing 'qapi-types-machine.h' header

2024-03-28 Thread Philippe Mathieu-Daudé
tryPointType ep_type); ^^^^ Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/fw_cfg.h | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/i386/fw_cfg.h b/hw/i386/fw_cfg.h index 92e310f5fd..7a426119f8 100644 --- a/hw/i386/fw_cfg.h +++ b/hw/i386/fw_cfg.h @@ -12,6 +12,7 @@ #include "hw/boards.h

[RFC PATCH-for-9.1 26/29] hw/i386/fw_cfg: Factor fw_cfg_build_smbios_legacy() out

2024-03-28 Thread Philippe Mathieu-Daudé
Factor fw_cfg_build_smbios_legacy() out of fw_cfg_build_smbios(). Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/fw_cfg.h | 1 + hw/i386/fw_cfg-smbios-stub.c | 4 hw/i386/fw_cfg.c | 33 ++--- 3 files changed, 27 insertions(+), 11

[RFC PATCH-for-9.1 17/29] hw/i386/pc: Inline gigabyte_align()

2024-03-28 Thread Philippe Mathieu-Daudé
All PCI-based machines have the gigabyte_align field set to %true. Simplify by using an inlined helper checking whether the machine is PCI-based or not. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i386/pc.h | 9 - hw/i386/pc.c | 1 - hw/i386/pc_piix.c| 16

[RFC PATCH-for-9.1 18/29] hw/i386/pc: Inline has_reserved_memory()

2024-03-28 Thread Philippe Mathieu-Daudé
All PCI-based machines have the has_reserved_memory field set to %true. Simplify by using an inlined helper checking whether the machine is PCI-based or not. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i386/pc.h | 1 - hw/i386/pc.c | 17 ++--- hw/i386/pc_piix.c

[RFC PATCH-for-9.1 20/29] hw/i386/pc: Pass PcPciMachineState argument to pc_pci_hole64_start()

2024-03-28 Thread Philippe Mathieu-Daudé
pc_pci_hole64_start() is only used by PCI-based machines. Pass it a PcPciMachineState argument, removing a qdev_get_machine() call. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i386/pc.h | 2 +- hw/i386/pc.c | 8 hw/pci-host/i440fx.c | 2 +- hw/pci-host/q35.c| 2

[RFC PATCH-for-9.1 23/29] hw/i386/fw_cfg: Inline smbios_defaults()

2024-03-28 Thread Philippe Mathieu-Daudé
All PCI-based machines have the smbios_defaults field set to %true. Simplify by using an inlined helper checking whether the machine is PCI-based or not. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i386/pc.h | 1 - hw/i386/fw_cfg.c | 7 ++- hw/i386/pc.c | 1 - hw/i386

[RFC PATCH-for-9.1 02/29] hw/i386/pc: Extract pc_machine_is_pci_enabled() helper

2024-03-28 Thread Philippe Mathieu-Daudé
Introduce the pc_machine_is_pci_enabled() helper to be able to alter PCMachineClass fields later. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i386/pc.h | 2 ++ hw/i386/pc.c | 11 +-- hw/i386/pc_piix.c| 11 ++- hw/i386/pc_q35.c | 2 +- hw/i386

[RFC PATCH-for-9.1 09/29] hw/i386/pc: Pass PCMachineState argument to acpi_setup()

2024-03-28 Thread Philippe Mathieu-Daudé
acpi_setup() caller knows about the machine state, so pass it as argument to avoid a qdev_get_machine() call. We already resolved X86_MACHINE(pcms) as 'x86ms' so use the latter. Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/acpi-build.h | 3 ++- hw/i386/acpi-build.c | 5 ++--- hw/i386/pc.c

[RFC PATCH-for-9.1 16/29] hw/i386/pc: Move south-bridge related fields to PcPciMachine

2024-03-28 Thread Philippe Mathieu-Daudé
South bridge type is only relevant for the i440fx/piix machine, which is PCI-based. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i386/pc.h | 8 hw/i386/pc.c | 3 ++- hw/i386/pc_piix.c| 12 ++-- 3 files changed, 12 insertions(+), 11 deletions(-) diff --git

[RFC PATCH-for-9.1 10/29] hw/i386/pc: Remove PCMachineClass::has_acpi_build field

2024-03-28 Thread Philippe Mathieu-Daudé
PCMachineClass::has_acpi_build is always %true for PCI based machines. Remove it, setting the 'acpi_build_enabled' field once in pc_pci_machine_initfn(). Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i386/pc.h | 3 --- hw/i386/pc.c | 6 +++--- hw/i386/pc_piix.c| 1 - 3 files

[RFC PATCH-for-9.1 05/29] hw/i386/pc: Remove PCMachineClass::pci_enabled field

2024-03-28 Thread Philippe Mathieu-Daudé
All TYPE_PC_PCI_MACHINE-based machines have pci_enabled set to %true. By checking a TYPE_PC_MACHINE inherits the TYPE_PC_PCI_MACHINE base class, we don't need this field anymore. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i386/pc.h | 1 - hw/i386/pc.c | 3 +-- hw/i386

[RFC PATCH-for-9.1 12/29] hw/i386/pc: Move acpi_build_enabled to PcPciMachineState

2024-03-28 Thread Philippe Mathieu-Daudé
Since only PCI-based machines use the 'acpi_build_enabled', move it to PcPciMachineState. Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/acpi-build.h | 2 +- include/hw/i386/pc.h | 3 ++- hw/i386/acpi-build.c | 8 hw/i386/pc.c | 5 ++--- hw/i386/xen/xen-hvm.c | 3 ++- 5

[RFC PATCH-for-9.1 06/29] hw/i386/pc: Move pci_root_uid field to PcPciMachineClass

2024-03-28 Thread Philippe Mathieu-Daudé
The 'pci_root_uid' field is irrelevant for non-PCI machines, restrict it to the PcPciMachineClass. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i386/pc.h | 4 +++- hw/i386/acpi-build.c | 9 +++-- hw/i386/pc_piix.c| 7 +-- hw/i386/pc_q35.c | 7 +-- 4 files changed, 20

[RFC PATCH-for-9.1 03/29] hw/i386/pc: Pass base machine type as argument to DEFINE_PC_MACHINE()

2024-03-28 Thread Philippe Mathieu-Daudé
Currently PC machines are based on TYPE_PC_MACHINE. In preparation of being based on different types, pass the current type as argument. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i386/pc.h | 4 ++-- hw/i386/pc_piix.c| 9 + hw/i386/pc_q35.c | 3 ++- 3 files changed, 9

[RFC PATCH-for-9.1 04/29] hw/i386/pc: Introduce PC_PCI_MACHINE QOM type

2024-03-28 Thread Philippe Mathieu-Daudé
Introduce TYPE_PC_PCI_MACHINE for machines where PCI is expected (as opposition to the ISA-only PC machine). This type inherits from the well known TYPE_PC_MACHINE. Convert I440FX/PIIX and Q35 machines to use it. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i386/pc.h | 25

[RFC PATCH-for-9.1 01/29] hw/i386/pc: Declare CPU QOM types using DEFINE_TYPES() macro

2024-03-28 Thread Philippe Mathieu-Daudé
. Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/pc.c | 31 ++- 1 file changed, 14 insertions(+), 17 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 0be8f08c47..2c41b08478 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -1810,23 +1810,20 @@ static void

[RFC PATCH-for-9.1 00/29] hw/i386/pc: Decouple ISA vs PCI-based machines

2024-03-28 Thread Philippe Mathieu-Daudé
with only CONFIG_ISAPC enabled. Based-on: <20240327095124.73639-1-phi...@linaro.org> "hw/i386: Remove deprecated pc-i440fx-2.0 -> 2.3 machines" Philippe Mathieu-Daudé (29): hw/i386/pc: Declare CPU QOM types using DEFINE_TYPES() macro hw/i386/pc: Extract pc_machine_is_pci_en

Re: [PATCH 0/3] target/ppc: fix tlb flushing race

2024-03-28 Thread Philippe Mathieu-Daudé
On 28/3/24 11:37, Nicholas Piggin wrote: On Thu Mar 28, 2024 at 8:15 PM AEST, Nicholas Piggin wrote: On Thu Mar 28, 2024 at 6:12 PM AEST, Nicholas Piggin wrote: On Thu Mar 28, 2024 at 3:31 PM AEST, Nicholas Piggin wrote: ppc broadcast tlb flushes should be synchronised with other vCPUs, like

Re: [PATCH 2/3] tcg/cputlb: Remove non-synced variants of global TLB flushes

2024-03-28 Thread Philippe Mathieu-Daudé
| 103 3 files changed, 19 insertions(+), 194 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 1/3] target/ppc: Fix broadcast tlbie synchronisation

2024-03-28 Thread Philippe Mathieu-Daudé
of host vCPU threads could trigger the race anywhere. Signed-off-by: Nicholas Piggin --- target/ppc/helper_regs.c | 2 +- target/ppc/mmu_helper.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) To the best of my knowledge, Reviewed-by: Philippe Mathieu-Daudé

[PATCH-for-9.1 v2 3/3] block/gluster: Remove RDMA protocol handling

2024-03-28 Thread Philippe Mathieu-Daudé
in commit e9a54265f5 ("hw/rdma: Deprecate the pvrdma device and the rdma subsystem") released in v8.2. Cc: Prasanna Kumar Kalever Signed-off-by: Philippe Mathieu-Daudé --- docs/system/device-url-syntax.rst.inc | 4 +-- docs/system/qemu-block-drivers.rst.inc |

[PATCH-for-9.1 v2 0/3] rdma: Remove RDMA subsystem and pvrdma device

2024-03-28 Thread Philippe Mathieu-Daudé
Since v1: - split in 3 (Thomas) - justify gluster removal Philippe Mathieu-Daudé (3): hw/rdma: Remove pvrdma device and rdmacm-mux helper migration: Remove RDMA protocol handling block/gluster: Remove RDMA protocol handling MAINTAINERS | 17 - docs

Re: [PATCH-for-9.1] rdma: Remove RDMA subsystem and pvrdma device

2024-03-28 Thread Philippe Mathieu-Daudé
On 28/3/24 10:06, Daniel P. Berrangé wrote: On Wed, Mar 27, 2024 at 11:55:48AM +0100, Philippe Mathieu-Daudé wrote: The whole RDMA subsystem was deprecated in commit e9a54265f5 ("hw/rdma: Deprecate the pvrdma device and the rdma subsystem") released in v8.2. Time to remove

Re: [PATCH-for-9.1 v2 19/21] hw/i386/pc: Remove 2.3 and deprecate 2.4 to 2.7 pc-i440fx machines

2024-03-28 Thread Philippe Mathieu-Daudé
Hi Zhao, On 28/3/24 04:44, Zhao Liu wrote: Hi Philippe, On Wed, Mar 27, 2024 at 10:51:21AM +0100, Philippe Mathieu-Daudé wrote: Date: Wed, 27 Mar 2024 10:51:21 +0100 From: Philippe Mathieu-Daudé Subject: [PATCH-for-9.1 v2 19/21] hw/i386/pc: Remove 2.3 and deprecate 2.4 to 2.7 pc-i440fx

Re: [PATCH 09/19] hw/sdhci: fix -Werror=maybe-uninitialized false-positive

2024-03-28 Thread Philippe Mathieu-Daudé
On 28/3/24 11:20, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau ../hw/sd/sdhci.c:846:16: error: ‘res’ may be used uninitialized [-Werror=maybe-uninitialized] False-positive, because "length" is non-null. Signed-off-by: Marc-André Lureau --- hw/sd/sdhci.c | 2 +- 1 file

Re: [PATCH] block: Remove unnecessary NULL check in bdrv_pad_request()

2024-03-28 Thread Philippe Mathieu-Daudé
1542668 Signed-off-by: Kevin Wolf --- block/io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH-for-9.0 v2] hw/i386/pc: Deprecate 64-bit CPUs on ISA-only PC machine

2024-03-27 Thread Philippe Mathieu-Daudé
On 27/3/24 18:29, Marcin Juszkiewicz wrote: W dniu 27.03.2024 o 17:54, Philippe Mathieu-Daudé pisze: diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 7b548519b5..345c35507f 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -208,6 +208,13

Re: [PATCH-for-9.1] target/nios2: Remove machines and system emulation

2024-03-27 Thread Philippe Mathieu-Daudé
On 27/3/24 16:39, Thomas Huth wrote: On 27/03/2024 15.15, Philippe Mathieu-Daudé wrote: On 27/3/24 14:19, Thomas Huth wrote: On 27/03/2024 13.45, Philippe Mathieu-Daudé wrote: On 27/3/24 13:35, Philippe Mathieu-Daudé wrote: Remove the Nios II machines and the system emulation code

Re: [PATCH v4 1/2] Refactor common functions between POSIX and Windows implementation

2024-03-27 Thread Philippe Mathieu-Daudé
On 27/3/24 17:24, aidan_le...@selinc.com wrote: From: aidaleuc Signed-off-by: aidaleuc --- qga/commands-common-ssh.c | 49 + qga/commands-common-ssh.h | 12 + qga/commands-posix-ssh.c | 51 +++

[PATCH-for-9.0 v2] hw/i386/pc: Deprecate 64-bit CPUs on ISA-only PC machine

2024-03-27 Thread Philippe Mathieu-Daudé
stdio -S -M isapc -cpu athlon QEMU 8.2.91 monitor - type 'help' for more information (qemu) q [*] https://lore.kernel.org/qemu-devel/zgqks4rpmst5x...@redhat.com/ Suggested-by: Daniel P. Berrangé Signed-off-by: Philippe Mathieu-Daudé --- docs/about/deprecated.rst | 7 +++ include/

Re: [PATCH v3 2/2] Implement SSH commands in QEMU GA for Windows

2024-03-27 Thread Philippe Mathieu-Daudé
On 27/3/24 16:54, Aidan Leuck wrote: On 22/3/24 18:46, aidan_le...@selinc.com wrote: From: Aidan Leuck Signed-off-by: Aidan Leuck --- qga/commands-windows-ssh.c | 791 + Huge file, I'm skipping it. qga/commands-windows-ssh.h | 26 ++

[PATCH-for-9.0] hw/i386/pc: Restrict CXL to PCI-based machines

2024-03-27 Thread Philippe Mathieu-Daudé
CXL is based on PCIe. In is pointless to initialize its context on non-PCI machines. Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/pc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index e80f02bef4..5c21b0c4db 100644 --- a/hw/i386/pc.c

Re: [PATCH v3 2/2] Implement SSH commands in QEMU GA for Windows

2024-03-27 Thread Philippe Mathieu-Daudé
On 27/3/24 15:38, Aidan Leuck wrote: Hi Philippe, Thank you for your feedback I will get these issues addressed. I left one small comment on the QAPI schema JSON. Aidan Leuck -Original Message- From: Philippe Mathieu-Daudé Sent: Monday, March 25, 2024 11:51 AM To: Aidan Leuck ; qemu

[PATCH-for-9.0] hw/i386/pc: Deprecate 64-bit CPUs on ISA-only PC machine

2024-03-27 Thread Philippe Mathieu-Daudé
. [*] https://lore.kernel.org/qemu-devel/zgqks4rpmst5x...@redhat.com/ Suggested-by: Daniel P. Berrangé Signed-off-by: Philippe Mathieu-Daudé --- docs/about/deprecated.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 7b548519b5..345c3

[PATCH-for-9.1 v2 0/3] target/nios2: Remove the deprecated Nios II target

2024-03-27 Thread Philippe Mathieu-Daudé
Since v1: - Remove user emulation too - Remove ALTERA_TIMER Philippe Mathieu-Daudé (3): fpu/softfloat: Remove mention of TILE-Gx target target/nios2: Remove the deprecated Nios II target hw/timer: Remove the ALTERA_TIMER model MAINTAINERS | 13 - docs

[PATCH-for-9.0? v2 1/3] fpu/softfloat: Remove mention of TILE-Gx target

2024-03-27 Thread Philippe Mathieu-Daudé
TILE-Gx has been removed during the v6.0 release (see commit 2cc1a90166 "Remove deprecated target tilegx"), no need to mention it in the list of "supported targets". Signed-off-by: Philippe Mathieu-Daudé --- fpu/softfloat-specialize.c.inc | 2 +- 1 file changed, 1 inse

[PATCH-for-9.1 v2 3/3] hw/timer: Remove the ALTERA_TIMER model

2024-03-27 Thread Philippe Mathieu-Daudé
The ALTERA_TIMER was only used by Nios II machines, which have been removed. Since it has no direct user, remove it. Signed-off-by: Philippe Mathieu-Daudé --- hw/timer/altera_timer.c | 244 hw/timer/Kconfig| 4 - hw/timer/meson.build| 1

Re: [PATCH-for-9.1 v2 10/21] hw/smbios: Remove 'uuid_encoded' argument from smbios_set_defaults()

2024-03-27 Thread Philippe Mathieu-Daudé
On 27/3/24 15:08, Zhao Liu wrote: On Wed, Mar 27, 2024 at 10:51:12AM +0100, Philippe Mathieu-Daudé wrote: Date: Wed, 27 Mar 2024 10:51:12 +0100 From: Philippe Mathieu-Daudé Subject: [PATCH-for-9.1 v2 10/21] hw/smbios: Remove 'uuid_encoded' argument from smbios_set_defaults() X-Mailer: git

Re: [PATCH-for-9.1] target/nios2: Remove machines and system emulation

2024-03-27 Thread Philippe Mathieu-Daudé
On 27/3/24 14:19, Thomas Huth wrote: On 27/03/2024 13.45, Philippe Mathieu-Daudé wrote: On 27/3/24 13:35, Philippe Mathieu-Daudé wrote: Remove the Nios II machines and the system emulation code (deprecated since v8.2 in commit 9997771bc1 "target/nios2: Deprecate the Nios II archite

Re: [PATCH for-9.0] docs/about: Mark the iaspc machine type as deprecated

2024-03-27 Thread Philippe Mathieu-Daudé
On 27/3/24 14:09, Igor Mammedov wrote: On Wed, 27 Mar 2024 10:49:43 + Daniel P. Berrangé wrote: On Tue, Mar 26, 2024 at 05:16:32PM +0100, Igor Mammedov wrote: On Tue, 26 Mar 2024 14:29:58 +0100 Philippe Mathieu-Daudé wrote: Hi Igor, On 26/3/24 14:08, Thomas Huth wrote: s/iaspc

Re: [PATCH-for-9.1] target/nios2: Remove machines and system emulation

2024-03-27 Thread Philippe Mathieu-Daudé
On 27/3/24 13:35, Philippe Mathieu-Daudé wrote: Remove the Nios II machines and the system emulation code (deprecated since v8.2 in commit 9997771bc1 "target/nios2: Deprecate the Nios II architecture"). Cc: Marek Vasut Signed-off-by: Philippe Mathieu-Daudé --- M

Re: [PATCH-for-9.0? v2 4/4] meson: Enable -Wstatic-in-inline

2024-03-27 Thread Philippe Mathieu-Daudé
On 27/3/24 10:26, Paolo Bonzini wrote: On 3/26/24 18:10, Philippe Mathieu-Daudé wrote: Compilers are clever enough to inline code when necessary. The only case we accept an inline function is static in header (we use C, not C++). Add the -Wstatic-in-inline CPPFLAG to prevent public and inline

<    1   2   3   4   5   6   7   8   9   10   >