[Qemu-devel] [PATCH] coccinelle: fix typo in comment

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- scripts/coccinelle/return_directly.cocci | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/coccinelle/return_directly.cocci b/scripts/coccinelle/return_directly.cocci index 48680f2c2a..4cf50e75ea

Re: [Qemu-devel] [PATCH v2 01/16] linux-user: add strace for getuid(), gettid(), getppid(), geteuid()

his commit, typical strace output used to look like this: 20588 geteuid(64,0,0,4832615888,0,-9151031864016699136) = 1000 After this commit, it looks like this: 20588 geteuid() = 1000 Signed-off-by: Miloš Stojanović <milos.stojano...@rt-rk.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsa

Re: [Qemu-devel] [PATCH v2 05/16] linux-user: fix argument type declaration of rt_sigqueinfo() syscall

ano...@rt-rk.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- linux-user/syscall.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index ff03e1a..9ec7ccd 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall

Re: [Qemu-devel] [PATCH 02/13] char-win: remove WinChardev.len

On 05/09/2017 08:33 AM, Marc-André Lureau wrote: The "len" argument can be passed directly to win_chr_read() Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- chardev/char-win.h | 1 - c

Re: [Qemu-devel] [PATCH 09/13] char: generalize qemu_chr_write_all()

Hi Marc-André, On 05/09/2017 08:33 AM, Marc-André Lureau wrote: qemu_chr_fe_write() is similar to qemu_chr_write_all(): the later write all with a chardev backend. Make qemu_chr_write() and qemu_chr_fe_write_buffer() take an 'all' argument. If false, handle 'partial' write the way

Re: [Qemu-devel] [PATCH v2 02/21] docker: add --include-file argument to 'build' command

On 05/09/2017 01:01 AM, Fam Zheng wrote: On Mon, 05/08 19:17, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- tests/docker/Makefile.include | 3 ++- tests/docker/docker.py| 5 + 2 files changed, 7 insertions(+), 1 deletion(-) diff

Re: [Qemu-devel] [PATCH 03/13] char-win: rename win_chr_init/poll win_chr_serial_init/poll

On 05/09/2017 08:33 AM, Marc-André Lureau wrote: Those 2 functions are specific to serial chardev, make it more clear. Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- chardev/char-win.h| 2 +-

Re: [Qemu-devel] [PATCH v2 05/21] docker: compact debian base

On 05/09/2017 05:05 AM, Fam Zheng wrote: On Tue, 05/09 08:46, Alex Bennée wrote: Fam Zheng <f...@redhat.com> writes: On Mon, 05/08 19:17, Philippe Mathieu-Daudé wrote: - install common/basic tools at once - use eatmydata and remove apt cache to save space - add bison and flex a

Re: [Qemu-devel] [PATCH 04/13] char-win: rename hcom->file

On 05/09/2017 08:33 AM, Marc-André Lureau wrote: hcom is the name of the file handle, regardless of the actual chardev driver (serial, file, console etc..). Rename it to be more explicit. Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> Reviewed-by: Philippe Mathieu-Dau

Re: [Qemu-devel] [PATCH 01/13] char-win: simplify win_chr_read()

On 05/09/2017 08:33 AM, Marc-André Lureau wrote: win_chr_read_poll() is always used before win_chr_read(). We can easily fold win_chr_readfile() too. Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- charde

Re: [Qemu-devel] [PATCH 11/13] Remove/replace chardev/char.h inclusion

Hi Marc-André Lureau, Isn't clearer if the "remove" part of this commit goes before your patch 6 "move headers to include/chardev"? On 05/09/2017 08:33 AM, Marc-André Lureau wrote: Those are apparently unnecessary includes. Signed-off-by: Marc-André Lureau ---

Re: [Qemu-devel] [PATCH 12/13] char: rename functions that are not part of fe

On 05/09/2017 08:33 AM, Marc-André Lureau wrote: There is no clear reason to have those functions associated with frontend. Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- chardev/char.c | 15 +++

Re: [Qemu-devel] [PATCH 1/8] coccinelle: add a script to optimize tcg op using tcg_gen_extract()

On 05/10/2017 05:19 PM, Richard Henderson wrote: On 05/10/2017 01:05 PM, Philippe Mathieu-Daudé wrote: +-tcg_gen_shri_tl(ret, arg, ofs); +-tcg_gen_andi_tl(ret, ret, len); ++tcg_gen_extract_tl(ret, arg, ofs, len); You can't simply copy the and mask to the extract length. You need to verify

[Qemu-devel] [PATCH 1/8] coccinelle: add a script to optimize tcg op using tcg_gen_extract()

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- scripts/coccinelle/tcg_gen_extract.cocci | 26 ++ 1 file changed, 26 insertions(+) create mode 100644 scripts/coccinelle/tcg_gen_extract.cocci diff --git a/scripts/coccinelle/tcg_gen_extract.cocci b/s

[Qemu-devel] [PATCH 0/8] optimize various tcg_gen() functions using extract op

/archive/html/qemu-devel/2017-05/msg01499.html Philippe Mathieu-Daudé (8): coccinelle: add a script to optimize tcg op using tcg_gen_extract() target/arm: optimize smul_dual() and neon_trn_u8() using extract op target/arm: optimize rev16() using extract op target/cris: optimize gen_swapb

[Qemu-devel] [PATCH 3/8] target/arm: optimize rev16() using extract op

Applied using Coccinelle script. Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- target/arm/translate-a64.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 24de30d92c..7ea130107e

[Qemu-devel] [PATCH 7/8] target/ppc: optimize various functions using extract op

Applied using Coccinelle script. Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- target/ppc/translate.c | 9 +++-- target/ppc/translate/vsx-impl.inc.c | 21 +++-- 2 files changed, 10 insertions(+), 20 deletions(-) diff --git a/target/ppc/trans

[Qemu-devel] [PATCH 5/8] target/m68k: optimize bcd_flags() using extract op

Applied using Coccinelle script. Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- target/m68k/translate.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target/m68k/translate.c b/target/m68k/translate.c index 9f60fbc0db..babb9e2c5b 100644 --- a/targe

[Qemu-devel] [PATCH 6/8] target/mips: optimize bshfl() using extract op

Applied using Coccinelle script. Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- target/mips/translate.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index 3022f349cb..96177da9ae 100644 --- a/

Re: [Qemu-devel] [PATCH 1/8] coccinelle: add a script to optimize tcg op using tcg_gen_extract()

On 05/10/2017 05:12 PM, Eric Blake wrote: On 05/10/2017 03:05 PM, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- scripts/coccinelle/tcg_gen_extract.cocci | 26 ++ 1 file changed, 26 insertions(+) create mode 100644 s

Re: [Qemu-devel] [PATCH v2] hw/misc: add missing includes

I intended to send those 3 patches as separate since unrelated, but failed again, sorry :S On 06/09/2017 12:06 PM, Philippe Mathieu-Daudé wrote: inlined create_unimplemented_device() calls sysbus_mmio_map_overlap(). Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- v2: Add

Re: [Qemu-devel] [PATCH v2] net/pcnet: modernise PCNET_DEBUG

On 06/09/2017 01:04 PM, Alex Bennée wrote: Philippe Mathieu-Daudé <f4...@amsat.org> writes: Ensure the format strings are always preprocessed, so any problem get reported. Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- v2: Addressed review feedback from

Re: [Qemu-devel] [PATCH 06/11] hw/arm: removed unnecessary include

On 05/23/2017 11:58 AM, Michael Tokarev wrote: 09.05.2017 02:39, Philippe Mathieu-Daudé wrote: "exec/memory.h" already includes it. I think this sort of include cleanups isn't really necessary. Some are useful ;) For a regular include file, it's better to include it if t

Re: [Qemu-devel] [PATCH v4 4/7] target-m68k: move fmove CR to a function

Hi Laurent, On 06/11/2017 08:16 PM, Laurent Vivier wrote: Move code of fmove to/from control register to a function Signed-off-by: Laurent Vivier --- target/m68k/translate.c | 66 ++--- 1 file changed, 41 insertions(+), 25

Re: [Qemu-devel] [PATCH v3 18/18] target/s390x: Clean up TB flag bits

Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- target/s390x/cpu.h | 24 +--- target/s390x/translate.c | 16 2 files changed, 17 insertions(+), 23 deletions(-) diff --git a/target/s390x/cpu.h b/target/s390x/cpu.h index 5b94ace..9faca04 100644 ---

Re: [Qemu-devel] [PATCHv6 2/5] fw_cfg: move setting of FW_CFG_VERSION_DMA bit to fw_cfg_init1()

k <ler...@redhat.com> Tested-by: Laszlo Ersek <ler...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/nvram/fw_cfg.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c index

[Qemu-devel] [PATCH v2 14/21] travis: dump config.log if ./configure script fails

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 96ddc16cfd..bac5bea744 100644 --- a/.travis.yml +++ b/.travis.yml @@ -93,7 +93,7 @@ before_script: - if [ -x "$

[Qemu-devel] [PATCH v2 17/21] travis/osx: don't update Homebrew cache

installed VMs come already updated, and brew is smart enough to upgrade some dependencies are missing. see https://docs.travis-ci.com/user/osx-ci-environment#homebrew Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- .travis.yml | 1 - 1 file changed, 1 deletion(-) diff

[Qemu-devel] [PATCH v2 01/21] tests: add missing dependency to build QTEST_QEMU_BINARY

This allow a one liner from fresh repository clone, i.e.: ./configure && make -j check-qtest-aarch64 Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- tests/Makefile.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Makefile.i

[Qemu-devel] [PATCH v2 11/21] travis: cache git submodules

Travis caching uses the branch name to store packed cache, so each new branch will trigger a cache miss and will clone all submodules. Subsequent builds will benefit from the cache. Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- .travis.yml | 7 ++- 1 file changed, 2 inse

[Qemu-devel] [RFC PATCH v2 21/21] ui/vnc: silent unuseful OSX clang warning

' has been explicitly marked deprecated here LIBSASL_API int sasl_server_init(const sasl_callback_t *callbacks, ^ Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- ui/Makefile.objs | 8 1 file changed, 8 insertions(+) diff --git a/ui/Makefile.objs b/

[Qemu-devel] [PATCH v2 15/21] travis: retry when git submodules initialization fails

-init --recursive" failed and exited with 1 during . Your build has been stopped. Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index bac5bea744..34391722a2 100644 --- a/.

[Qemu-devel] [PATCH v2 07/21] travis: update sudo-enabled Trusty images

see https://blog.travis-ci.com/2017-06-19-trusty-updates-2017-Q2 Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- .travis.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.travis.yml b/.travis.yml index 29c9ef72a4..e60a5cd8e6 100644 --- a/.travis.yml +++ b/.trav

[Qemu-devel] [PATCH v2 02/21] travis: retry if llvm.org timeouts

instead. The command "sudo apt-get update -qq" failed and exited with 100 during . Your build has been stopped. Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Reviewed-by: Alex Bennée <alex.ben...@linaro.org> --- .travis.yml | 16 1 file

[Qemu-devel] [PATCH v2 00/21] travis: speedup to reduce failures

can upload Philippe Mathieu-Daudé (18): tests: add missing dependency to build QTEST_QEMU_BINARY travis: retry if llvm.org timeouts travis: install more library dependencies travis: update sudo-enabled Trusty images travis: use gcc-6 sanitizers travis: enable multiple caching features

[Qemu-devel] [PATCH v2 05/21] scripts/run-coverity-scan: Script to run Coverity Scan build

e QEMU project on the Coverity Scan website and have the secret upload token). Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> Reviewed-by: Alex Bennée <alex.ben...@linaro.org> Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- scripts

[Qemu-devel] [PATCH v2 09/21] travis: enable multiple caching features

(this eases git workflow) see https://docs.travis-ci.com/user/caching#enabling-multiple-caching-features Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- .travis.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 6139

[Qemu-devel] [PATCH v2 18/21] travis/osx: silent texinfo warnings

$ make info GEN qemu-doc.html qemu-doc.texi:8: warning: unrecognized encoding name `UTF-8'. GEN qemu-doc.txt qemu-doc.texi:8: warning: unrecognized encoding name `UTF-8'. Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- .travis.yml | 2 ++ 1 file chan

[Qemu-devel] [PATCH v2 03/21] travis: install more library dependencies

From: Peter Maydell <peter.mayd...@linaro.org> Update the travis list of library packages to install so that our build tests cover more of our code base. Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> Reviewed-by: Alex Bennée <alex.ben...@linaro.org> Reviewed-by: Phil

[Qemu-devel] [PATCH v2 12/21] travis: build using all available cores

Few improvement as of today, but if Travis release their limit on the opensource plan or upgrade their hardware, new builds will get some benefit. Restrict to as most 4 cores to respect Travis Open Source plan. Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- .travis.ym

[Qemu-devel] [PATCH v2 10/21] travis: increase S3 cache timeout

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- .travis.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.travis.yml b/.travis.yml index be28e0642c..62b9dfd2ae 100644 --- a/.travis.yml +++ b/.travis.yml @@ -6,6 +6,7 @@ compiler: - gcc cache: ccache: true + timeout

[Qemu-devel] [PATCH v2 13/21] travis: improve ccache use

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- .travis.yml | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index a7512f3ab0..96ddc16cfd 100644 --- a/.travis.yml +++ b/.travis.yml @@ -68,6 +68,8 @@ env: # b

[Qemu-devel] [PATCH v2 08/21] travis: use gcc-6 sanitizers

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- .travis.yml | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.travis.yml b/.travis.yml index e60a5cd8e6..61394b4764 100644 --- a/.travis.yml +++ b/.travis.yml @@ -172,8 +172,8 @@ matrix: -

[Qemu-devel] [PATCH v2 06/21] travis: Add config to do a Coverity Scan upload

nclude debug features (notably the ability to do a "dry run" test which doesn't actually upload anything). Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- .travis.yml | 24 1 file cha

[Qemu-devel] [PATCH v2 04/21] travis: install more library dependencies

so more codebase is built Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Acked-by: Alex Bennée <alex.ben...@linaro.org> --- .travis.yml | 8 1 file changed, 8 insertions(+) diff --git a/.travis.yml b/.travis.yml index 53d8e79bf5..0220f7472e 100644 --- a/.trav

[Qemu-devel] [PATCH v2 19/21] travis/osx: build using more Xcode versions

) Apple LLVM version 8.1.0 see https://docs.travis-ci.com/user/osx-ci-environment#os-x-version Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- .travis.yml | 11 +++ 1 file changed, 11 insertions(+) diff --git a/.travis.yml b/.travis.yml index d007fdc9fb..880a057c78

[Qemu-devel] [PATCH v2 20/21] MAINTAINERS: self-appoint me as reviewer in build/test automation

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Reviewed-by: Alex Bennée <alex.ben...@linaro.org> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 120788d8fb..e62cbc439a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -18

[Qemu-devel] [PATCH v2 16/21] travis: split the gprof/gcov job

gcov generates lot of output and often trigger job limit timeout Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- .travis.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 34391722a2..4bb288a192 100644 --- a/.travis.yml

Re: [Qemu-devel] [Qemu-ppc] Floating point unit bugs

Hi John, On 05/09/2017 10:58 AM, G 3 wrote: On May 9, 2017, at 5:55 AM, BALATON Zoltan wrote: On Tue, 9 May 2017, Aurelien Jarno wrote: | main.c: In function 'print_fpscr_settings': | main.c:73:26: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses] |

Re: [Qemu-devel] [PATCH v5 1/6] target-m68k: move fmove CR to a function

-- 1 file changed, 31 insertions(+), 25 deletions(-) Reviewed-by: Richard Henderson <r...@twiddle.net> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> r~

Re: [Qemu-devel] [PATCH v5 3/6] target-m68k: use floatx80 internally

Hi Laurent, On 06/20/2017 05:51 PM, Laurent Vivier wrote: Coldfire uses float64, but 680x0 use floatx80. This patch introduces the use of floatx80 internally and enables 680x0 80bits FPU. Signed-off-by: Laurent Vivier --- target/m68k/cpu.c| 4 +-

Re: [Qemu-devel] [PULL 00/21] Docker and shippable updates

On 06/22/2017 11:09 AM, Peter Maydell wrote: On 21 June 2017 at 15:47, Alex Bennée wrote: [...]>> We add the following cross-compile targets: - mipsel-softmmu,mipsel-linux-user,mips64el-linux-user - armeb-linux-user While I was rolling I discovered we could also

Re: [Qemu-devel] [PATCH v3] ivshmem-server: ivshmem-client: Build when eventfd() is available

On Thu, Jun 22, 2017 at 12:54 PM, Peter Maydell wrote: > On 5 June 2017 at 15:29, Michael Tokarev wrote: [...] >> $ ../configure --disable-system --disable-linux-user --static >> $ make V=1 >> ... > > Why are you trying to build with both system

[Qemu-devel] [PATCH v3 2/2] MAINTAINERS: add entry for "Unimplemented" device

Also voluntary myself as reviewer Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 7b7543a54e..6febb4f9ab 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1160,6 +1160,13 @@ F

[Qemu-devel] [PATCH v3 1/2] hw/unimp: add missing include

inlined create_unimplemented_device() calls sysbus_mmio_map_overlap(). Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Reviewed-by: Eric Blake <ebl...@redhat.com> --- include/hw/misc/unimp.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/hw/misc/unimp.h b/inc

[Qemu-devel] [PATCH v3 0/2] hw/unimp: add MAINTAINERS entry and missing include

I separated these patches from the previous series "various easy cleanups". Add an entry in MAINTAINERS for the "Unimplemented" device, voluntary myself as reviewer, fix a missing include. Regards, Phil. Philippe Mathieu-Daudé (2): hw/unimp: add missing include MA

Re: [Qemu-devel] MIPS little endian - Bug when decoding physaddr

Hi Vinicius, On 06/23/2017 04:22 PM, Aurelien Jarno wrote: On 2017-06-23 15:14, Vinicius Maciel wrote: Hi everyone, I'm having a problem similar to the reported in this email, but now I'm trying to emulate a MIPS 24KEc, ralink RT5350F. Assembly Code: 0x802006a0 : lui t5,0xb011

Re: [Qemu-devel] [PATCH v2 01/21] tests: add missing dependency to build QTEST_QEMU_BINARY

On 06/22/2017 06:55 AM, Alex Bennée wrote: Philippe Mathieu-Daudé <f4...@amsat.org> writes: This allow a one liner from fresh repository clone, i.e.: ./configure && make -j check-qtest-aarch64 TIL -j doesn't need a number and GNU Make has a -l option ;-) Also since

[Qemu-devel] [PATCH 3/3] hw/core: report an error if invalid gpio is used

then abort calling error_setg() Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/core/qdev.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/core/qdev.c b/hw/core/qdev.c index 849952a8d4..05aaa67cb8 100644 --- a/hw/core/qdev.c +++ b/hw/core/

[Qemu-devel] [PATCH 2/3] hw/core: fix missing return value in load_image_targphys_as()

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/core/loader.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/core/loader.c b/hw/core/loader.c index 094f24627f..e137e772ae 100644 --- a/hw/core/loader.c +++ b/hw/core/loader.c @@ -150,7 +150,9

[Qemu-devel] [PATCH 1/3] elf-loader: warn about invalid endianess

fprintf(stderr) is how errors are reported in this file. Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/core/loader.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/core/loader.c b/hw/core/loader.c index f72930ca4a..094f24627f 100644 --- a/hw/core/loader.c +++ b/h

[Qemu-devel] [PATCH 0/3] hw/core: minor fixups

Sorry to spam so many people, there is no entries in MAINTAINERS for hw/core/loader.c and hw/core/qdev.c, any volunters? Philippe Mathieu-Daudé (3): elf-loader: warn about invalid endianess hw/core: fix missing return value in load_image_targphys_as() hw/core: report an error if invalid

Re: [Qemu-devel] [PATCH 05/11] travis: build tests objects in parallel, then run tests sequentially

On 06/19/2017 08:12 AM, Peter Maydell wrote: What is perhaps a problem is that I'm not sure our tests all support being run in parallel with each other without tripping each other up by using the same temporary file / TCP port / etc at once. To the extent that this doesn't work it's a bug, but

Re: [Qemu-devel] [PATCH] configure: Handle having no c++ compiler in FORTIFY_SOURCE check

' check. Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index c571ad1..a435908 100755 --- a/configure +++ b/configur

Re: [Qemu-devel] [PATCH v2] main_loop: Make main_loop_wait() return void

org> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- This will coincidentally satisfy Coverity, which currently complains in CID 1372464 that we call main_loop_wait() in vl.c and ignore the return value which may be reporting a poll() syscall failure. Essentially we don't expect po

Re: [Qemu-devel] [RFC PATCH 3/4] coccinelle: script to run them all

On Mon, Jun 26, 2017 at 11:17 PM, Eduardo Habkost <ehabk...@redhat.com> wrote: > On Sun, Jun 25, 2017 at 04:29:49PM -0300, Philippe Mathieu-Daudé wrote: [...] >> +test -z "$(${SUDO} docker images -q ${SPATCH_IMAGE})" && ${SUDO} docker >> pull ${SPATCH_IMAGE

[Qemu-devel] [RFC PATCH 2/4] coccinelle: ignore ASTs pre-parsed cached C files

files generated using coccinelle tool: 'spatch --use-cache' Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- .gitignore | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitignore b/.gitignore index 09c2363acf..cf65316863 100644 --- a/.gitignore +++ b/.gitignore @@ -116,6

[Qemu-devel] [RFC PATCH 4/4] travis: add job to run coccinelle scripts

result pushed to my gh repo via ssh deploy key Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- .travis.sshkey | Bin 0 -> 1296 bytes .travis.yml| 26 -- 2 files changed, 20 insertions(+), 6 deletions(-) create mode 100644 .travis.sshkey d

[Qemu-devel] [RFC PATCH 3/4] coccinelle: script to run them all

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- scripts/check-cocci-scripts.sh | 47 ++ 1 file changed, 47 insertions(+) create mode 100755 scripts/check-cocci-scripts.sh diff --git a/scripts/check-cocci-scripts.sh b/scripts/check

[Qemu-devel] [RFC PATCH 0/4] travis: run all coccinelle scripts

dea is welcome :) Regards, Phil. Philippe Mathieu-Daudé (4): travis: simplify matrix coccinelle: ignore ASTs pre-parsed cached C files coccinelle: script to run them all travis: add job to run coccinelle scripts .gitignore | 2 + .travis.sshkey | Bi

[Qemu-devel] [RFC PATCH 1/4] XXX travis: simplify matrix

to speedup further testing Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- .travis.yml | 119 1 file changed, 119 deletions(-) diff --git a/.travis.yml b/.travis.yml index 27a2d9cfb3..4761569183 100644 --- a/.trav

Re: [Qemu-devel] [PATCH 3/7] target/m68k: add fsglmul and fsgldiv

Hi Laurent, On 06/25/2017 04:21 PM, Laurent Vivier wrote: fsglmul and fsgldiv truncate data to single precision before computing results. Signed-off-by: Laurent Vivier --- target/m68k/fpu_helper.c | 22 ++ target/m68k/helper.h | 2 ++

Re: [Qemu-devel] glue(glue(ld, USUFFIX), _p)

Hi Theodore, > In include/exec/cpu_ldst_useronly_template.h, there’s references to > glue(glue(ld, USUFFIX), _p), which would expand to a call to a function > looking something like uint32_t lduw_p(void *) (for example). Where is this > function defined? You might be looking for the glue

Re: [Qemu-devel] [RFC PATCH 0/4] travis: run all coccinelle scripts

> Patch 4 is the travis job: it calls the previous script. To respect travis > time > limit timeout, each script is limited to <10min. If any commit were > generated, they are pushed to my gh-repo Initially I wanted to use git format-patch/send-email to send to the list as a series but it seems

Re: [Qemu-devel] [RFC PATCH 1/2] arm/highbank: use defined type name instead of hard-coded string

On Fri, Jun 23, 2017 at 7:18 PM, John Snow wrote: > This patch is fine, I took a stab at fixing the include issues in a > separate series. Try it all out and let me know. Thank John, your series does fix my include issues :)

Re: [Qemu-devel] [PATCH 3/3] ahci: split public and private interface

lize the split by switching external users to the new header. > > Signed-off-by: John Snow <js...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> Tested-by: Philippe Mathieu-Daudé <f4...@amsat.org> > --- > hw/ide/ahci.c

Re: [Qemu-devel] [PATCH 2/3] ahci: Isolate public AHCI interface

future > patch. > > Signed-off-by: John Snow <js...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> Tested-by: Philippe Mathieu-Daudé <f4...@amsat.org> > --- > include/hw/ide/ahci.h| 57 +++-

Re: [Qemu-devel] [PATCH 1/3] ahci: add ahci_get_num_ports

On Fri, Jun 23, 2017 at 7:09 PM, John Snow <js...@redhat.com> wrote: > Instead of reaching into the PCI state, allow the AHCIDevice to > respond with how many ports it has. > > Signed-off-by: John Snow <js...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@ams

Re: [Qemu-devel] [PATCH v5 3/6] target-m68k: use floatx80 internally

On Wed, Jun 21, 2017 at 1:37 PM, Richard Henderson <r...@twiddle.net> wrote: > On 06/21/2017 09:18 AM, Philippe Mathieu-Daudé wrote: >> What an awful name... Anyway checking on "qemu/bswap.h" it seems there is >> some endianess issue with it if your host is little-e

Re: [Qemu-devel] [PATCH v4 2/7] Move CONFIG_KVM related definitions to kvm_i386.h

-off-by: Thomas Huth <th...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/i386/pc_q35.c | 1 + include/hw/i386/pc.h | 13 - include/sysemu/kvm.h | 15 --- target/i386/kvm_i386.h | 23 +++ 4 files

Re: [Qemu-devel] [PATCH v4 7/7] hw/misc/edu: Compile the edu device as common object

On 06/26/2017 02:22 AM, Thomas Huth wrote: edu.c does not contain any target-specific code, so we can put it into common-obj-y to compile it only once for all targets. Signed-off-by: Thomas Huth <th...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> -

Re: [Qemu-devel] [PATCH v4 6/7] Makefile: Move bootdevice.o to common-obj-y

On 06/26/2017 02:22 AM, Thomas Huth wrote: There does not seem to be any target specific code in this file, so we can put it into "common-obj" instead of "obj" to compile it only once for all targets. Signed-off-by: Thomas Huth <th...@redhat.com> Reviewed-by:

[Qemu-devel] [PATCH] tcg/tci: fix tcg-interpreter build

fix regression from commit 244f144134: $ make subdir-arm-softmmu make[1]: *** No rule to make target 'tci.o', needed by 'qemu-system-arm'. Stop. Makefile:328: recipe for target 'subdir-arm-softmmu' failed make: *** [subdir-arm-softmmu] Error 2 Signed-off-by: Philippe Mathieu

Re: [Qemu-devel] [PATCH] tcg/tci: fix tcg-interpreter build

On 06/20/2017 02:17 PM, no-re...@patchew.org wrote: === OUTPUT BEGIN === [...] CC aarch64-softmmu/target/arm/cpu64.o cc: Internal error: Killed (program cc1) This is odd... Please submit a full bug report. See for instructions. make[1]: ***

Re: [Qemu-devel] [PATCH 03/11] travis: use yes/no variable to enable/disable tests

On 06/17/2017 05:06 AM, Alex Bennée wrote: Philippe Mathieu-Daudé <f4...@amsat.org> writes: having the command to run in the variable make scripts harder to manage. I'm not sure this adds much over the TEST_CMD not set == don't run we had before. I don't like it neither but had t

Re: [Qemu-devel] [PULL 00/21] Docker and shippable updates

On Thu, Jun 22, 2017 at 12:13 PM, Alex Bennée wrote: > Now we've been running shippable for a while is it worth turning on the > IRC notifications? What about moving such bot/scripts notifications in another channel like #QEMU-notifications? It is often hard to follow 3

Re: [Qemu-devel] [PATCH v2 06/21] travis: Add config to do a Coverity Scan upload

On 06/22/2017 06:56 AM, Alex Bennée wrote:[...] I think this is waiting on a fix I mention when reviewing Peter's original patches. Ok! I'll wait or drop the Coverity part.

Re: [Qemu-devel] [PATCH v2 07/21] travis: update sudo-enabled Trusty images

On 06/22/2017 06:58 AM, Alex Bennée wrote: Philippe Mathieu-Daudé <f4...@amsat.org> writes: see https://blog.travis-ci.com/2017-06-19-trusty-updates-2017-Q2 Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> The way I read that blog post is group: edge is for testing thing

Re: [Qemu-devel] [PATCH v2 13/21] travis: improve ccache use

On 06/22/2017 07:22 AM, Alex Bennée wrote: Philippe Mathieu-Daudé <f4...@amsat.org> writes: Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Can you expand the commit message to breifly explain what all these extra settings change. What is CCACHE_SLOPINESS and ccache -s

Re: [Qemu-devel] [PATCH v2 14/21] travis: dump config.log if ./configure script fails

On 06/22/2017 07:23 AM, Alex Bennée wrote: Philippe Mathieu-Daudé <f4...@amsat.org> writes: [...] - - ./configure ${CONFIG} + - ./configure ${CONFIG} || cat config.log Won't the explicit || mean the job will keep trying even if config is broken? Should it be || cat config.log &a

Re: [Qemu-devel] [PATCH v5 00/24] docker/shippable: cross-build mipsel and powerpc targets

On 06/21/2017 11:15 AM, Alex Bennée wrote: Philippe Mathieu-Daudé <f4...@amsat.org> writes: This patchset add 2 more architectures to the cross-build farm. There is still some issue trying to cross-build mips64el-softmmu, it seems the cross tools use the system outdated libfdt i

Re: [Qemu-devel] [PATCH v2] main_loop: Make main_loop_wait() return void

On Mon, Jun 26, 2017 at 11:28 AM, Peter Maydell wrote: ... On Tue, Jun 27, 2017 at 12:06 PM, wrote: 36h in the queue? > /tmp/qemu-test/src/tests/test-char.c: In function ‘main_loop’: > /tmp/qemu-test/src/tests/test-char.c:29: error: void value

Re: [Qemu-devel] [PATCH v2 6/9] hw/timer: QOM'ify m48txx_sysbus (pass 2)

On 04/29/2017 07:49 AM, xiaoqiang zhao wrote: assign DeviceClass::vmsd instead of using vmstate_register function Signed-off-by: xiaoqiang zhao <zxq_yx_...@163.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/timer/m48t59.c | 3 +-- 1 file changed, 1 ins

Re: [Qemu-devel] [Qemu-arm] [PATCH 1/2] hw/adc: Add basic Aspeed ADC model

Hi Andrew, On 05/19/2017 09:26 PM, Andrew Jeffery wrote: This model implements enough behaviour to do basic functionality tests such as device initialisation and read out of dummy sample values. The sample value generation strategy is similar to the STM ADC already in the tree. Signed-off-by:

Re: [Qemu-devel] [PATCH v2 0/9] QOM'ify work for sparc

Hi Xiaoqiang, On 04/29/2017 07:49 AM, xiaoqiang zhao wrote: This patch set aims for QOM'ifying code relate with sparc. It is part of my QOM'ify work of qemu code base. changes since v1: * rebased on the latest master xiaoqiang zhao (9): hw/misc: QOM'ify eccmemctl.c hw/dma: QOM'ify

Re: [Qemu-devel] [PATCH] oslib: strip trailing '\n' from error_setg() string argument

On 05/17/2017 09:48 AM, Stefan Hajnoczi wrote: On Mon, May 15, 2017 at 09:11:49PM -0300, Philippe Mathieu-Daudé wrote: spotted by Coccinelle script scripts/coccinelle/err-bad-newline.cocci Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- util/oslib-posix.c | 2 +- 1 file chan

Re: [Qemu-devel] [PATCH] coccinelle: fix typo in comment

On 05/16/2017 11:35 AM, Eric Blake wrote: On 05/15/2017 07:11 PM, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- scripts/coccinelle/return_directly.cocci | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Did you intend for this to be th

Re: [Qemu-devel] [PATCH v2 13/13] vvfat: change OEM name to 'MSWIN4.1'

Hi Hervé, On 05/22/2017 06:12 PM, Hervé Poussineau wrote: According to specification: "'MSWIN4.1' is the recommanded setting, because it is the setting least likely to cause compatibility problems. If you want to put something else in here, that is your option, but the result may be that some

Re: [Qemu-devel] [PATCH] docker: Add flex and bison to centos6 image

with debian based images :/ Reported-by: Thomas Huth <th...@redhat.com> Signed-off-by: Fam Zheng <f...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- tests/docker/dockerfiles/centos6.docker | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

Re: [Qemu-devel] [PATCH v2 05/13] vvfat: introduce offset_to_bootsector, offset_to_fat and offset_to_root_dir

Hi Hervé, On 05/22/2017 06:11 PM, Hervé Poussineau wrote: - offset_to_bootsector is the number of sectors up to FAT bootsector - offset_to_fat is the number of sectors up to first File Allocation Table - offset_to_root_dir is the number of sectors up to root directory sector Eventually your

<    6   7   8   9   10   11   12   13   14   15   >