[Qemu-devel] [PATCH 20/23] shippable: add powerpc target

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- .shippable.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.shippable.yml b/.shippable.yml index 7e714991f9..3a80165b6a 100644 --- a/.shippable.yml +++ b/.shippable.yml @@ -18,6 +18,8 @@ env: # mips64el-softmmu di

[Qemu-devel] [PATCH 18/23] shippable: temporary disable mips64el-softmmu build

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- .shippable.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.shippable.yml b/.shippable.yml index 6601243060..7e714991f9 100644 --- a/.shippable.yml +++ b/.shippable.yml @@ -15,8 +15,9 @@ env: TARGE

Re: [Qemu-devel] [PATCH] xtensa: use g_malloc/g_new/g_free

u-triv...@nongnu.org Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/xtensa/sim.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/xtensa/sim.c b/hw/xtensa/sim.c index d2d1d3a6fd..97307728f7 1006

Re: [Qemu-devel] [RFC PATCH 03/23] shippable: ignore SSL verification

Hi Alex, On 05/08/2017 07:58 AM, Alex Bennée wrote: Philippe Mathieu-Daudé <f4...@amsat.org> writes: shippable logs: -- git_sync - ssh-agent bash -c 'ssh-add /tmp/ssh/01_deploy; git clone https://github.com/philmd/qemu.git /root/src/github.com/philmd/qemu' Identity added

Re: [Qemu-devel] [PATCH v2 1/9] hw/misc: QOM'ify eccmemctl.c

On 04/29/2017 07:49 AM, xiaoqiang zhao wrote: * Split the old SysBus init into an instance_init and a DeviceClass::realize function * Drop the old SysBus init function and use instance_init Signed-off-by: xiaoqiang zhao <zxq_yx_...@163.com> Reviewed-by: Philippe Mathieu-Dau

Re: [Qemu-devel] [PATCH] slirp: fix pinging the virtual ipv4 DNS server

On 04/29/2017 09:47 AM, Samuel Thibault wrote: so that people do not think it is not working at least basically. Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> diff --git a/slirp/ip_icmp.c b/slirp/ip_

Re: [Qemu-devel] [PATCH v2 7/9] hw/timer: QOM'ify slavio_timer

On 04/29/2017 07:49 AM, xiaoqiang zhao wrote: rename slavio_timer_init1 to slavio_timer_init and assign it to slavio_timer_info.instance_init, then we drop the SysBusDeviceClass::init Signed-off-by: xiaoqiang zhao <zxq_yx_...@163.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@

Re: [Qemu-devel] [PATCH v2 2/9] hw/dma: QOM'ify sparc32_dma.c

On 04/29/2017 07:49 AM, xiaoqiang zhao wrote: Drop the old SysBus init function and use instance_init and an realize function Signed-off-by: xiaoqiang zhao <zxq_yx_...@163.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/dma/sparc32_dma.c | 25 +++-

Re: [Qemu-devel] [PATCH v2 4/9] hw/misc: QOM'ify slavio_misc.c

On 04/29/2017 07:49 AM, xiaoqiang zhao wrote: Drop the old SysBus init function and use instance_init Signed-off-by: xiaoqiang zhao <zxq_yx_...@163.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/misc/slavio_misc.c | 43 +--

Re: [Qemu-devel] [PATCH v2 9/9] hw/sparc64: QOM'ify sun4u.c

On 04/29/2017 07:49 AM, xiaoqiang zhao wrote: Drop the old SysBusDeviceClass::init and use instance_init or DeviceClass::realize instead Signed-off-by: xiaoqiang zhao <zxq_yx_...@163.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/sparc64/

Re: [Qemu-devel] [PATCH v2 3/9] hw/dma: QOM'ify sun4m_iommu.c

On 04/29/2017 07:49 AM, xiaoqiang zhao wrote: Drop the old SysBus init function and use instance_init Signed-off-by: xiaoqiang zhao <zxq_yx_...@163.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/dma/sun4m_iommu.c | 12 +--- 1 file changed, 5 inse

Re: [Qemu-devel] [PATCH v2 8/9] hw/sparc: QOM'ify sun4m.c

On 04/29/2017 07:49 AM, xiaoqiang zhao wrote: Drop the old SysBusDeviceClass::init and use instance_init or DeviceClass::realize instead Signed-off-by: xiaoqiang zhao <zxq_yx_...@163.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/sparc/

Re: [Qemu-devel] [PATCH 02/14] target/sh4: get rid of DELAY_SLOT_CLEARME

CG era. Signed-off-by: Aurelien Jarno <aurel...@aurel32.net> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- target/sh4/cpu.h | 3 +-- target/sh4/helper.c| 2 -- target/sh4/translate.c | 17 + 3 files changed, 6 insertions(+), 16 deletions(-) d

Re: [Qemu-devel] [PATCH 11/14] target/sh4: generate fences for SH4

On 05/01/2017 07:10 PM, Aurelien Jarno wrote: synco is a SH4-A only instruction. Signed-off-by: Aurelien Jarno <aurel...@aurel32.net> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- target/sh4/translate.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-)

Re: [Qemu-devel] [PATCH 01/14] target/sh4: split ctx->flags into ctx->tbflags and ctx->envflags

Hi Aurelien, On 05/01/2017 07:10 PM, Aurelien Jarno wrote: There is a confusion (and not only in the SH4 target) between tb->flags, env->flags and ctx->flags. To avoid it, split ctx->flags into ctx->tbflags and ctx->envflags. ctx->tbflags stays unchanged during the whole TB translation, while

Re: [Qemu-devel] [PATCH 13/14] target/sh4: movua.l is an SH4-A only instruction

On 05/01/2017 07:10 PM, Aurelien Jarno wrote: At the same time change the comment describing the instruction the same way than other instruction, so that the code is easier to read and search. Signed-off-by: Aurelien Jarno <aurel...@aurel32.net> Reviewed-by: Philippe Mathieu-Dau

Re: [Qemu-devel] [PATCH 14/14] target/sh4: trap unaligned accesses

On 05/01/2017 07:10 PM, Aurelien Jarno wrote: SH4 requires that memory accesses are naturally aligned, except for the SH4-A movua.l instructions which can do unaligned loads. Signed-off-by: Aurelien Jarno <aurel...@aurel32.net> Reviewed-by: Philippe Mathieu-Daudé <f4...@

Re: [Qemu-devel] [PATCH 1/4] qmp: Improve QMP dispatch error messages

On 04/27/2017 05:41 AM, Markus Armbruster wrote: Signed-off-by: Markus Armbruster <arm...@redhat.com> Reviewed-by: Eric Blake <ebl...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- qapi/qmp-dispatch.c | 14 +++--- 1 file changed, 7 insertio

Re: [Qemu-devel] [PATCH 2/6] egl-helpers: drop support for gles and debug logging

On 05/05/2017 07:40 AM, Gerd Hoffmann wrote: Leftover from the early opengl days. Unused now, so delete the dead code. Signed-off-by: Gerd Hoffmann <kra...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- include/ui/egl-helpers.h | 2 +- ui/egl-helpers.c

Re: [Qemu-devel] [PATCH 4/6] egl-helpers: add missing error check

On 05/05/2017 07:40 AM, Gerd Hoffmann wrote: Code didn't check for qemu_egl_init_dpy_mesa() failures, add it. Signed-off-by: Gerd Hoffmann <kra...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- ui/egl-helpers.c | 7 ++- 1 file changed, 6 insertions(+)

Re: [Qemu-devel] [PATCH 1/6] virtio-gpu: move virtio_gpu_gl_block

On 05/05/2017 07:40 AM, Gerd Hoffmann wrote: Move to virtio-gpu-3d.c where all the other virgl code lives too. Signed-off-by: Gerd Hoffmann <kra...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- include/hw/virtio/virtio-gpu.h | 1 + hw/display/vir

Re: [Qemu-devel] [PULL 07/12] target-arm: Add support for Cortex-R5

Hi Peter, On 06/16/2015 09:36 PM, Peter Crosthwaite wrote: Introduce a CPU model for the Cortex R5 processor. ARMv7 with MPU, and both thumb and ARM div instructions. Also implement dummy ATCM and BTCM. These CPs are defined for R5 but don't have a lot of meaning in QEMU yet. Raz them so the

Re: [Qemu-devel] [PATCH] ppc: xics: fix compilation with CentOS 6

On 05/05/2017 06:48 AM, Paolo Bonzini wrote: The PowerPCCPU typedef is included twice if a file includes both hw/ppc/xics.h and target/ppc/cpu-qom.h. Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- There are ot

Re: [Qemu-devel] [PATCH v6 01/25] target/nios2: Fix 64-bit ilp32 compilation

On 05/02/2017 04:22 PM, Richard Henderson wrote: Avoid a "cast from pointer to integer of different size" warning by using the proper host type. Reviewed-by: Alex Bennée <alex.ben...@linaro.org> Signed-off-by: Richard Henderson <r...@twiddle.net> Reviewed-by: Phil

Re: [Qemu-devel] [PATCH] Disable the not fully implemented warning for e1000

Hi Julien, On 05/05/2017 09:57 AM, Julien Duponchelle wrote: Otherwise for image like CISCO IOSv you got a lot of warning on the console preventing you to use the VM because it's slow down the machine. This fix: https://bugs.launchpad.net/qemu/+bug/1673722 Signed-off-by: Julien Duponchelle

Re: [Qemu-devel] [PATCH 04/23] docker: compact debian base

On 05/08/2017 08:04 AM, Alex Bennée wrote: Philippe Mathieu-Daudé <f4...@amsat.org> writes: - install common/basic tools at once - one-line Emdebian setup - use eatmydata and remove apt cache to save space - add bison and flex and git Signed-off-by: Philippe Mathieu-Daudé <f4...@

Re: [Qemu-devel] [PATCH 21/23] docker: fix powerpc debian/stable dependencies problem

On 05/08/2017 08:19 AM, Alex Bennée wrote: Philippe Mathieu-Daudé <f4...@amsat.org> writes: Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- tests/docker/dockerfiles/debian-powerpc-cross.docker | 7 +++ 1 file changed, 7 insertions(+) diff --git a/tests/docker

Re: [Qemu-devel] [PATCH] hw/xtensa: sim: use g_string/g_new

<jcmvb...@gmail.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/xtensa/sim.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/xtensa/sim.c b/hw/xtensa/sim.c index d2d1d3a..b27e28d 100644 --- a/hw/xtensa/sim.c +++ b/hw/xtensa/sim.c @@ -41,2

Re: [Qemu-devel] [RFC PATCH 14/23] docker: add 'apt-fake' script which generate fake debian packages

On 05/08/2017 08:12 AM, Alex Bennée wrote: Philippe Mathieu-Daudé <f4...@amsat.org> writes: Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- tests/docker/Makefile.include | 2 ++ tests/docker/dockerfiles/debian-apt-fake.sh | 46

Re: [Qemu-devel] [PATCH 18/23] shippable: temporary disable mips64el-softmmu build

On 05/08/2017 08:22 AM, Alex Bennée wrote: Philippe Mathieu-Daudé <f4...@amsat.org> writes: Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- .shippable.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.shippable.yml b/.shippable.yml inde

Re: [Qemu-devel] [PATCH 16/23] shippable: do not initialize submodules automatically

On 05/08/2017 08:15 AM, Alex Bennée wrote: Philippe Mathieu-Daudé <f4...@amsat.org> writes: do it in the 'ci' target when needed. Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- .shippable.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.shippable.yml b/.s

Re: [Qemu-devel] [PATCH 02/23] shippable: build using all available cpus

diff --git a/.shippable.yml b/.shippable.yml index 231c29b620..5170486ff9 100644 --- a/.shippable.yml +++ b/.shippable.yml @@ -20,4 +20,4 @@ build: ci: - unset CC - ./configure ${QEMU_CONFIGURE_OPTS} --target-list=${TARGET_LIST} -- make -j2 +- make -j$(getconf

Re: [Qemu-devel] [PATCH 02/23] shippable: build using all available cpus

On 05/08/2017 07:55 AM, Alex Bennée wrote: Philippe Mathieu-Daudé <f4...@amsat.org> writes: Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- .shippable.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.shippable.yml b/.shippable.yml inde

[Qemu-devel] [PATCH v2 01/21] docker: let _copy_with_mkdir() sub_path argument be optional

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- tests/docker/docker.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/docker/docker.py b/tests/docker/docker.py index 8747f6a440..6ddc6e4c2a 100755 --- a/tests/docker/docker.py +++ b/tests/docker/doc

[Qemu-devel] [PATCH v2 02/21] docker: add --include-file argument to 'build' command

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- tests/docker/Makefile.include | 3 ++- tests/docker/docker.py| 5 + 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include index 03eda37bf4..c99c

[Qemu-devel] [PATCH v2 00/21] docker/shippable: cross-build mipsel and powerpc targets

file while building images. Regards, Phil. Philippe Mathieu-Daudé (21): docker: let _copy_with_mkdir() sub_path argument be optional docker: add --include-file argument to 'build' command docker: add 'apt-fake' script which generate fake debian packages docker: install ca-certificat

[Qemu-devel] [PATCH v2 11/21] docker: add mipsel build target

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- tests/docker/Makefile.include | 3 +++ .../docker/dockerfiles/debian-mipsel-cross.docker | 31 ++ 2 files changed, 34 insertions(+) create mode 100644 tests/docker/dockerfiles/debian-

[Qemu-devel] [PATCH v2 16/21] shippable: be verbose while building docker images

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- .shippable.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.shippable.yml b/.shippable.yml index 46adfa030f..fe360f85cb 100644 --- a/.shippable.yml +++ b/.shippable.yml @@ -13,7 +13,7 @@ env: TARGE

[Qemu-devel] [PATCH v2 04/21] docker: install ca-certificates package in base image

) Cloning into '/root/src/github.com/philmd/qemu'... fatal: unable to access 'https://github.com/philmd/qemu.git/': Problem with the SSL CA cert (path? access rights?) retrying 1 of 3 times... Suggested-by: Alex Bennée <alex.ben...@linaro.org> Signed-off-by: Philippe Mathieu-Daudé <f4...@

[Qemu-devel] [PATCH v2 06/21] docker: compact debian armhf

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- tests/docker/dockerfiles/debian-armhf-cross.docker | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/tests/docker/dockerfiles/debian-armhf-cross.docker b/tests/docker/dockerfiles/debian-armhf-cross.

[Qemu-devel] [PATCH v2 13/21] shippable: use C locale to simplify console output

stem. Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Reviewed-by: Alex Bennée <alex.ben...@linaro.org> --- .shippable.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.shippable.yml b/.shippable.yml index 653bd750fe..231c29b620 100644 --- a/.shippable.yml +++ b/.shipp

[Qemu-devel] [PATCH v2 08/21] docker: add extra libs to armhf target to extend codebase coverage

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- tests/docker/dockerfiles/debian-armhf-cross.docker | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/tests/docker/dockerfiles/debian-armhf-cross.docker b/tests/docker/dockerfiles/debian-armhf-cross.docker

[Qemu-devel] [PATCH v2 10/21] docker: add extra libs to s390x target to extend codebase coverage

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- tests/docker/dockerfiles/debian-s390x-cross.docker | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tests/docker/dockerfiles/debian-s390x-cross.docker b/tests/docker/dockerfiles/debian-s390x-cross.docker index 3a68

[Qemu-devel] [PATCH v2 19/21] shippable: add mipsel target

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- .shippable.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.shippable.yml b/.shippable.yml index aad66ec5ec..75c2895a21 100644 --- a/.shippable.yml +++ b/.shippable.yml @@ -13,6 +13,9 @@ env: TARGET_LIST=s390x-s

[Qemu-devel] [PATCH v2 14/21] shippable: build using all available cpus

As of this commit: $ echo "container proc:" `getconf _NPROCESSORS_ONLN` `getconf _NPROCESSORS_CONF` container proc: 2 2 Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- .shippable.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.shippable.yml

[Qemu-devel] [PATCH v2 18/21] shippable: add powerpc target

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- .shippable.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.shippable.yml b/.shippable.yml index 2070c4d827..aad66ec5ec 100644 --- a/.shippable.yml +++ b/.shippable.yml @@ -11,6 +11,8 @@ env: TARGET_LIST=aarch64-s

[Qemu-devel] [PATCH v2 12/21] docker: add powerpc build target

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- tests/docker/Makefile.include | 2 ++ .../docker/dockerfiles/debian-powerpc-cross.docker | 31 ++ 2 files changed, 33 insertions(+) create mode 100644 tests/docker/dockerfiles/debian-p

[Qemu-devel] [PATCH v2 15/21] shippable: do not initialize submodules automatically

ipe for target 'subdir-mips64el-softmmu' failed make: *** [subdir-mips64el-softmmu] Error 2 Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- .shippable.yml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/.shippable.yml b/.shippable.yml index 1e3ae35dd9..46adfa03

[Qemu-devel] [PATCH v2 20/21] MAINTAINERS: add Shippable automation platform URL

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Reviewed-by: Alex Bennée <alex.ben...@linaro.org> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index efdec47319..6d0770fdd0 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1833,6

[Qemu-devel] [PATCH v2 17/21] shippable: add armeb-linux-user target

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- .shippable.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.shippable.yml b/.shippable.yml index fe360f85cb..2070c4d827 100644 --- a/.shippable.yml +++ b/.shippable.yml @@ -6,7 +6,7 @@ env: - LC

[Qemu-devel] [PATCH v2 21/21] MAINTAINERS: self-appoint me as reviewer in build/test automation

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Reviewed-by: Alex Bennée <alex.ben...@linaro.org> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 6d0770fdd0..d61380837a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -18

[Qemu-devel] [PATCH v2 07/21] docker: compact debian arm64

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- tests/docker/dockerfiles/debian-arm64-cross.docker | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/tests/docker/dockerfiles/debian-arm64-cross.docker b/tests/docker/dockerfiles/debian-arm64-cross.

[Qemu-devel] [PATCH v2 03/21] docker: add 'apt-fake' script which generate fake debian packages

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- tests/docker/dockerfiles/debian-apt-fake.sh | 46 + 1 file changed, 46 insertions(+) create mode 100755 tests/docker/dockerfiles/debian-apt-fake.sh diff --git a/tests/docker/dockerfiles/debian-apt-fake

[Qemu-devel] [PATCH v2 05/21] docker: compact debian base

- install common/basic tools at once - use eatmydata and remove apt cache to save space - add bison and flex and git - create deb-src entry and setup Emdebian in the same layer Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- tests/docker/dockerfiles/debian.docke

[Qemu-devel] [PATCH v2 09/21] docker: add extra libs to arm64 target to extend codebase coverage

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- tests/docker/dockerfiles/debian-arm64-cross.docker | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/tests/docker/dockerfiles/debian-arm64-cross.docker b/tests/docker/dockerfiles/debian-arm64-cross.docker

[Qemu-devel] [PATCH] syscall: fix compiler warnings (clang 5)

static code analyzer complain: linux-user/syscall.c:5575:9: warning: Dereference of undefined pointer value if (*host_rt_dev_ptr != 0) { ^~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- linux-user/syscall.c | 4 +

Re: [Qemu-devel] [Qemu-arm] [PATCH 1/3] hw/arm/exynos: Move RAM initialization next boards

Hi Krzysztof, Please modify RAM -> DRAM in subject/description so there is no confusion about also moving the IRAM (which is SoC specific). With this: Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> On 05/06/2017 12:24 PM, Krzysztof Kozlowski wrote: Before QOM-ifying the Ex

Re: [Qemu-devel] [PATCH 2/3] scsi-disk: export rotational qdev property

On 05/06/2017 09:43 AM, Aurelien Jarno wrote: Export the rotational qdev property to the block device characteristics VPD page. Signed-off-by: Aurelien Jarno <aurel...@aurel32.net> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/scsi/scsi-disk.c | 14 ++

Re: [Qemu-devel] [PATCH v2 01/14] target/sh4: split ctx->flags into ctx->tbflags and ctx->envflags

, while ctx->envflags evolves and is kept in sync with env->flags using TCG instructions. ctx->envflags now only contains the part that of env->flags that is contained in the TB state, i.e. the DELAY_SLOT* flags. Signed-off-by: Aurelien Jarno <aurel...@aurel32.net> Reviewed-by:

Re: [Qemu-devel] [PATCH v2 10/14] target/sh4: optimize gen_write_sr using extract op

rel...@aurel32.net> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- target/sh4/translate.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/target/sh4/translate.c b/target/sh4/translate.c index b4e5606098..8c766eed2a 100644 --- a/target/sh4/translate.c

Re: [Qemu-devel] [PATCH 1/5] docker: Run tests with current user

On 05/05/2017 12:23 AM, Fam Zheng wrote: We've used --add-current-user to create a user in the image, use it to run tests, because root has too much priviledge, and can surprise test cases. Signed-off-by: Fam Zheng <f...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@

Re: [Qemu-devel] [PATCH 2/3] hw/arm/exynos: Declare local variables in some order

Aesthetic. Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> On 05/06/2017 12:24 PM, Krzysztof Kozlowski wrote: Bring some more readability by declaring local function variables, first initialized ones and then the rest (with reversed-christmas-tree order). Signed-off-by: Krz

Re: [Qemu-devel] [PATCH 3/3] ide: export rotational qdev property

On 05/06/2017 09:43 AM, Aurelien Jarno wrote: Export the rotational qdev property in the IDENTIFY request. Signed-off-by: Aurelien Jarno <aurel...@aurel32.net> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/ide/core.c | 3 +++ 1 file changed, 3 insertions(+) dif

Re: [Qemu-devel] [PATCH 1/3] hw/block: Introduce rotational qdev property

be configured as a rotational device or a non-rotational device. Default to true to not change the default behavior. Signed-off-by: Aurelien Jarno <aurel...@aurel32.net> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- blockdev.c | 4 include/hw/block

Re: [Qemu-devel] [PATCH 4/5] docker: Add libaio to fedora image

On 05/05/2017 12:23 AM, Fam Zheng wrote: Signed-off-by: Fam Zheng <f...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- tests/docker/dockerfiles/fedora.docker | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/docker/dockerfiles/fedo

Re: [Qemu-devel] [PATCH 3/3] hw/arm/exynos: QOM-ify the SoC

On 05/06/2017 12:24 PM, Krzysztof Kozlowski wrote: Convert the Exynos4210 SoC code into a QOM model which is a preferred approach instead of directly initializing SoC-related devices from the board file. Signed-off-by: Krzysztof Kozlowski <k...@kernel.org> Reviewed-by: Philippe Mathieu

Re: [Qemu-devel] [PATCH v2 06/14] target/sh4: fix BS_EXCP exit

ilippe Mathieu-Daudé <f4...@amsat.org> --- target/sh4/translate.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/target/sh4/translate.c b/target/sh4/translate.c index 04bc18bf7c..f608e314b6 100644 --- a/target/sh4/translate.c +++ b/target/sh4/translate

Re: [Qemu-devel] [PATCH v2 03/14] target/sh4: do not include DELAY_SLOT_TRUE in the TB state

viewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- target/sh4/cpu.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target/sh4/cpu.h b/target/sh4/cpu.h index 9445cc779f..da8d15f1b9 100644 --- a/target/sh4/cpu.h +++ b/target/sh4/cpu.h @@ -382,8 +382,7 @@ static

Re: [Qemu-devel] [PATCH 3/5] docker: Use unconfined security profile

Hi Fam, Alex, Paolo, On 05/05/2017 12:23 AM, Fam Zheng wrote: Some by default blocked syscalls are required to run tests for example userfaultfd. Signed-off-by: Fam Zheng --- tests/docker/Makefile.include | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [Qemu-devel] [PATCH 2/5] docker: Add bzip2 and hostname to fedora image

On 05/05/2017 12:23 AM, Fam Zheng wrote: It is used by qemu-iotests. Signed-off-by: Fam Zheng <f...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- tests/docker/dockerfiles/fedora.docker | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

Re: [Qemu-devel] [PATCH 2/2] migration: Extra tracing

On 04/26/2017 03:37 PM, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" <dgilb...@redhat.com> A couple more traces that would have made fixing that postcopy bug a bit easier. Signed-off-by: Dr. David Alan Gilbert <dgilb...@redhat.com> Reviewed-by:

[Qemu-devel] [PATCH 00/11] various easy cleanups

various easy patchs added while coding around: - remove old comments - add/remove includes - use TYPE_ names when available - use ARRAY_SIZE() macro Philippe Mathieu-Daudé (11): hw/net: removed obsolete comments hw/pci: define msi_nonbroken in pci-stub hw/misc: add missing includes ide

[Qemu-devel] [RFC PATCH 02/11] hw/pci: define msi_nonbroken in pci-stub

This field is accessed in hw/intc/arm_gicv[23*].c Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/pci/pci-stub.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/pci/pci-stub.c b/hw/pci/pci-stub.c index 36d2c430c5..ecad664946 100644 --- a/hw/pci/pci-stub.c +++ b/

[Qemu-devel] [PATCH 01/11] hw/net: removed obsolete comments

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/net/pcnet-pci.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/hw/net/pcnet-pci.c b/hw/net/pcnet-pci.c index 0acf8a4879..bdb533436e 100644 --- a/hw/net/pcnet-pci.c +++ b/hw/net/pcnet-pci.c @@ -38,14

[Qemu-devel] [PATCH 09/11] target/sparc: fix DEBUG_MMU DPRINTF() arguments

invalid since 96df2bc99f9 Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- target/sparc/ldst_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/sparc/ldst_helper.c b/target/sparc/ldst_helper.c index 57968d9143..aa83a49a88 100644 --- a/target

[Qemu-devel] [PATCH 04/11] ide/ahci: add missing includes

’ IDEBus port; ^~ qemu/include/hw/ide/ahci.h:305:15: error: field ‘parent_obj’ has incomplete type PCIDevice parent_obj; ^~ Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- include/hw/ide/ahci.h | 2 ++ 1 file changed, 2 insertions(+) diff

[Qemu-devel] [PATCH 06/11] hw/arm: removed unnecessary include

"exec/memory.h" already includes it. Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- include/hw/arm/arm.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/hw/arm/arm.h b/include/hw/arm/arm.h index a3f79d3379..b9c11d3fb8 100644 --- a/include/hw/arm/arm.h +++

[Qemu-devel] [PATCH 10/11] register: display register prefix (name) since it is available

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/core/register.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/core/register.c b/hw/core/register.c index dc335a79a9..b5988c9cc3 100644 --- a/hw/core/register.c +++ b/hw/core/register.c @@ -195,8

Re: [Qemu-devel] [PATCH 09/11] target/sparc: fix DEBUG_MMU DPRINTF() arguments

On 05/08/2017 09:00 PM, Eric Blake wrote: On 05/08/2017 06:39 PM, Philippe Mathieu-Daudé wrote: invalid since 96df2bc99f9 Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- target/sparc/ldst_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target

[Qemu-devel] [PATCH 05/11] hw/mips: add missing include

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- include/hw/mips/mips.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/hw/mips/mips.h b/include/hw/mips/mips.h index e0065ce808..16412dc150 100644 --- a/include/hw/mips/mips.h +++ b/include/hw/mips/mips.h @@ -6,

[Qemu-devel] [PATCH 03/11] hw/misc: add missing includes

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- include/hw/misc/unimp.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/hw/misc/unimp.h b/include/hw/misc/unimp.h index 3462d85836..353ee19abf 100644 --- a/include/hw/misc/unimp.h +++ b/include/hw/misc/unimp.h @@ -8,

[Qemu-devel] [PATCH 11/11] MAINTAINERS: self-appoint me as reviewer of the Register API

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index efdec47319..de32165059 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1431,6 +1431,7 @@ T: git git://repo.or.cz/qemu/armbru.git qap

[Qemu-devel] [PATCH 08/11] hw/sparc: use ARRAY_SIZE() macro

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/sparc64/sun4u.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/sparc64/sun4u.c b/hw/sparc64/sun4u.c index d347b6616d..525d6f44a0 100644 --- a/hw/sparc64/sun4u.c +++ b/hw/sparc64/sun4u.c @@ -214,7

Re: [Qemu-devel] [PATCH 03/11] hw/misc: add missing includes

On 05/08/2017 08:56 PM, Eric Blake wrote: On 05/08/2017 06:39 PM, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- include/hw/misc/unimp.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/hw/misc/unimp.h b/include/hw/misc/unimp.h

Re: [Qemu-devel] [PATCH v2] pc-bios/s390-ccw: use STRIP variable in Makefile

On 05/31/2017 03:09 PM, Greg Kurz wrote: The docker-run-test-build@debian-s390x-cross target fails with: strip --strip-unneeded s390-ccw.elf -o s390-ccw.img strip: Unable to recognise the format of the input file `s390-ccw.elf' The configure script defines a STRIP makefile variable whose

Re: [Qemu-devel] [PATCH v2 1/5] sockets: ensure we can bind to both ipv4 & ipv6 separately

from mistakenly using a 2nd port for the :: listener. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- util/qemu-sockets.c | 31 +++ 1 file changed, 23 insertions(+), 8 deletions(-) diff -

Re: [Qemu-devel] [PATCH v2 2/5] sockets: don't block IPv4 clients when listening on "::"

being incompatible with the requested protocol. Likewise it is explicitly setting the has_ipv4 & ipv4 flags when the address contains only digits + '.'. This has no ill-effect, but also has no benefit, so is removed. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> Reviewed-by: Phil

Re: [Qemu-devel] [PATCH v2 4/5] io: preserve ipv4/ipv6 flags when resolving InetSocketAddress

t;berra...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- io/dns-resolver.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/io/dns-resolver.c b/io/dns-resolver.c index 57a8896..c072d12 100644 --- a/io/dns-resolver.c +++ b/io/dns-resolver.c @

Re: [Qemu-devel] [PATCH v2 5/9] hw/timer: QOM'ify m48txx_sysbus (pass 1)

On 04/29/2017 07:49 AM, xiaoqiang zhao wrote: * split the old SysBus init function into an instance_init and a Device realize function * use DeviceClass::realize instead of SysBusDeviceClass::init Signed-off-by: xiaoqiang zhao <zxq_yx_...@163.com> Reviewed-by: Philippe Mathieu-Dau

Re: [Qemu-devel] [PATCH v2 14/14] char: move char devices to chardev/

On 05/30/2017 12:18 PM, Eric Blake wrote: On 05/29/2017 04:31 PM, Philippe Mathieu-Daudé wrote: On 05/29/2017 05:45 AM, Marc-André Lureau wrote: Suggested by Paolo Bonizini during series review. Bonzini ;) "serie" singular No, "serie" is not a word. "series"

Re: [Qemu-devel] [PATCH 2/7] megasas: do not read sense length more than once from frame

Hi Paolo, Should this patch go in qemu-stable? On 06/06/2017 09:17 AM, Paolo Bonzini wrote: Avoid TOC-TOU bugs depending on how the compiler behaves. Can you be more descriptive here? Which compiler? (thinking about how to prevent this class of bugs). Regards, Phil. Signed-off-by:

Re: [Qemu-devel] [PATCH v1 1/1] char-socket: Don't report TCP socket waiting as an error

On 06/06/2017 08:58 AM, Marc-André Lureau wrote: Hi On Mon, Jun 5, 2017 at 10:37 PM Alistair Francis < alistair.fran...@xilinx.com> wrote: When QEMU is waiting for a TCP socket connection it reports that message as an error. This isn't an error though, so let's change the report to just use

Re: [Qemu-devel] [PATCH v3 4/4] gdbstub: don't fail on vCont; C04:0; c packets

ben...@linaro.org> Reviewed-by: Greg Kurz <gr...@kaod.org> Reviewed-by: Claudio Imbrenda <imbre...@linux.vnet.ibm.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- v2 - used Greg's less convoluted suggestion - expand commit message --- gdbstub.c | 15 --

Re: [Qemu-devel] [PATCH v1 1/1] char-socket: Don't report TCP socket waiting as an error

viewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- chardev/char-socket.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/chardev/char-socket.c b/chardev/char-socket.c index ccc499cfa1..a9884fa85b 100644 --- a/chardev/char-socket.c +++ b/chardev/char-socket.c @@

Re: [Qemu-devel] [PATCH] block/gluster.c: Handle qdict_array_entries() failure

of qdict_array_entries() and also the type we use for the loop enumeration variable 'i'. (Spotted by Coverity, CID 1360960.) Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- block/gluster.c | 3 +-- 1 file changed,

Re: [Qemu-devel] [PATCH 0/3] hw/core: minor fixups

Hi Eduardo, On 06/23/2017 04:45 PM, Eduardo Habkost wrote: Do you have a simple way to trigger the error paths addressed by patches 1/3 and 2/3? For 1/3 "elf-loader: warn about invalid endianess": $ wget -q https://people.debian.org/~aurel32/qemu/mips/vmlinux-3.2.0-4-4kc-malta $ file

Re: [Qemu-devel] [RFC v1 1/3] util/qemu-error: Rename error_print_loc() to be more generic

On Tue, Jun 27, 2017 at 5:45 PM, Alistair Francis <alistair.fran...@xilinx.com> wrote: > Rename the error_print_loc() function in preperation for using it to preparation > print warnings as well. > > Signed-off-by: Alistair Francis <alistair.fran...@xilinx.com> Revie

Re: [Qemu-devel] [PATCH] throttle: Assert that bkt->max is valid in throttle_compute_wait()

Hi Alberto, On 09/13/2017 05:28 AM, Alberto Garcia wrote: If bkt->max == 0 and bkt->burst_length > 1 then we could have a division by 0 in throttle_do_compute_wait(). That configuration is however not permitted and is already detected by throttle_is_valid(), but let's assert it in

Re: [Qemu-devel] [PULL v4 00/38] Test and build patches

Hi Daniel, On 09/15/2017 08:40 AM, Daniel P. Berrange wrote: On Fri, Sep 15, 2017 at 11:55:44AM +0100, Peter Maydell wrote: [...] So, before I commit an ssh private key to our git repo, can you explain why it's ok that this is public? The commit message for the relevant patch doesn't really

Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Handle SH4's exceptional alignment for p{read, write}64

On 09/15/2017 03:58 AM, James Clarke wrote: Fixes: https://bugs.launchpad.net/qemu/+bug/1716767 Signed-off-by: James Clarke Congratulations! You have won yourself a R: entry (Designated reviewer) in the "Linux user" and "SH4" sections of MAINTAINERS! ---

<    9   10   11   12   13   14   15   16   17   18   >