Re: [Qemu-devel] [PATCH v2 5/5] tcg: restrict i386 regs definitions

On 09/11/2017 06:44 PM, Kamil Rytarowski wrote: On 11.09.2017 23:33, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- cleaning while here :) accel/tcg/user-exec.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff

Re: [Qemu-devel] [PATCH] sparc: Fix typedef clash

1b20610 Fixes: 12a6c15ef31c98ecefa63e91ac36955383038384 you mean "missed in 12a6c15ef31c98ecefa63e91ac36955383038384" Signed-off-by: Dr. David Alan Gilbert <dgilb...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- target/sparc/cpu.h | 4 ++-- 1 file

Re: [Qemu-devel] [Qemu devel v8 PATCH 4/5] msf2: Add Smartfusion2 SoC

Hi Sundeep, On 09/13/2017 06:21 AM, sundeep subbaraya wrote: All patches got Reviewed-by. Do you want me to change alias to remap and send This is just cosmetic for the "alias MSF2.eNVM.alias": (qemu) info mtree address-space: cpu-memory - (prio 0, i/o):

Re: [Qemu-devel] [PATCH] xen_disk: avoid use of g_malloc0_n()

), use the former. Signed-off-by: Jan Beulich <jbeul...@suse.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- a/hw/block/xen_disk.c +++ b/hw/block/xen_disk.c @@ -1232,7 +1232,7 @@ static int blk_connect(struct XenDevice return -1; } -domids =

Re: [Qemu-devel] [PATCH 04/10] disas: Support the Capstone disassembler library

Hi Richard, see inlined comments. On 09/14/2017 03:35 PM, Richard Henderson wrote: If configured, prefer this over our rather dated copy of the GPLv2-only binutils. This will be especially apparent with the proposed vector extensions to TCG, as disas/i386.c does not handle AVX.

Re: [Qemu-devel] [PATCH 10/10] target/mips: Support Capstone in disas_set_info

On 09/14/2017 03:35 PM, Richard Henderson wrote: Cc: Aurelien Jarno Cc: Yongbok Kim Signed-off-by: Richard Henderson --- target/mips/cpu.h| 2 ++ target/mips/cpu.c| 8

Re: [Qemu-devel] [PATCH 00/10] Support the Capstone disassembler

popw (%eax) For i386, arm, mips32/64: Tested-by: Philippe Mathieu-Daudé <f4...@amsat.org> This series but patch 4/10: Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> Regards, Phil.

Re: [Qemu-devel] [PATCH] softfloat: rename make_float[x80|128]_init to const_float[x80|128]

t, exp }) -#define make_floatx80_init(exp, mant) { .low = mant, .high = exp } +#define make_floatx80(exp, mant) __extension__ \ +({ floatx80 f80_val = { .low = mant, .high = exp }; f80_val; }) +#define const_floatx80(exp, mant) { .low = mant, .high = exp } cleaner. Reviewed-by: Philippe Mathieu-Dau

Re: [Qemu-devel] [Qemu devel v9 PATCH 2/5] msf2: Microsemi Smartfusion2 System Register block

On 09/18/2017 11:00 AM, Peter Maydell wrote: On 18 September 2017 at 14:58, Philippe Mathieu-Daudé <f4...@amsat.org> wrote: Hi Peter, On 09/18/2017 10:36 AM, Peter Maydell wrote: On 18 September 2017 at 14:27, sundeep subbaraya <sundeep.l...@gmail.com> wrote: Hi Sundeep, Peter

Re: [Qemu-devel] [Qemu devel v9 PATCH 2/5] msf2: Microsemi Smartfusion2 System Register block

Hi Peter, On 09/18/2017 10:36 AM, Peter Maydell wrote: On 18 September 2017 at 14:27, sundeep subbaraya wrote: Hi Sundeep, Peter, On 09/15/2017 01:59 PM, Subbaraya Sundeep wrote: +static void msf2_sysreg_write(void *opaque, hwaddr offset, +

Re: [Qemu-devel] [Qemu devel v10 PATCH 4/5] msf2: Add Smartfusion2 SoC

rancis <alistair.fran...@xilinx.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> Tested-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- default-configs/arm-softmmu.mak | 1 + hw/arm/Makefile.objs| 1 + hw/arm/msf2-s

[Qemu-devel] [PATCH] msf2: drop cpu_model to directly use cpu type

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- after Igor comment: http://lists.nongnu.org/archive/html/qemu-devel/2017-09/msg04709.html Fam: I'm trying your patchew "apply over series" feature on these 2 series, hoping they get both applied before

[Qemu-devel] [RFC PATCH] vl.c: add is_system_on_chip flag to force board default cpu

add a property to restrict the CPU for SoCs once on machine creation and avoid duplicate code in each board. Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- Based-on: 1505318697-77161-6-git-send-email-imamm...@redhat.com include/hw/boards.h | 3 +++ vl.c

[Qemu-devel] [PATCH] !fixup arm: missed comment update

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- Based-on: 1505318697-77161-6-git-send-email-imamm...@redhat.com include/hw/arm/armv7m.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/arm/armv7m.h b/include/hw/arm/armv7m.h index 68cb30d611..9ad3

Re: [Qemu-devel] [Qemu-trivial] [PATCH] nbd-client: Use correct macro parenthesization

com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> Any magic cocci script to verify there aren't no more? --- I plan to take this through my NBD queue, unless it is picked up by qemu-trivial first... block/nbd-client.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deleti

Re: [Qemu-devel] [RFC v1 0/2] Add a valid_cpu_types property

On 09/18/2017 07:55 PM, Eduardo Habkost wrote: On Mon, Sep 18, 2017 at 06:57:19PM -0300, Philippe Mathieu-Daudé wrote: add a property to restrict the CPU for SoCs once on machine creation and avoid duplicate code in each board. Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.

Re: [Qemu-devel] [Qemu-trivial] [PATCH] nbd-client: Use correct macro parenthesization

On 09/18/2017 07:42 PM, Eric Blake wrote: On 09/18/2017 05:13 PM, Philippe Mathieu-Daudé wrote: Any magic cocci script to verify there aren't no more? I don't know if cocci can do it; checkpatch tries to check whether macro arguments are parenthesized, but even that's prone to missing things

Re: [Qemu-devel] [PATCH 3/5] aspeed: Add EEPROM I2C devices

Hi Cédric, On 09/19/2017 08:26 AM, Cédric Le Goater wrote: The Aspeed boards have at least one EEPROM to hold the Vital Product Data (VPD). Signed-off-by: Cédric Le Goater --- hw/arm/aspeed.c | 20 1 file changed, 20 insertions(+) diff --git

Re: [Qemu-devel] [PATCH] msf2: drop cpu_model to directly use cpu type

On 09/18/2017 11:08 PM, Fam Zheng wrote: On Mon, 09/18 19:11, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- after Igor comment: http://lists.nongnu.org/archive/html/qemu-devel/2017-09/msg04709.html Fam: I'm trying your patchew "apply

Re: [Qemu-devel] [PATCH] nvme: fix cmbuf leak on exit

g_free(n->cmbuf); memory_region_unref(>ctrl_mem); } Anyway g_free() handles NULL, so: Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org>

Re: [Qemu-devel] [PATCH v2 0/5] generalize parsing of cpu_model (x86/arm)

On 09/19/2017 09:11 AM, Eduardo Habkost wrote: Igor Mammedov wrote: [...] Could you merge it via machine tree? [...] Queued on machine-next: Thanks Eduardo for applying the !fixup :)

[Qemu-devel] [PATCH] hw/input/lm832x: move LM8323 declarations to input/keypad.h

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- Based-on: 20170919123053.32675-1-f4...@amsat.org $ ./scripts/get_maintainer.pl -f hw/input/lm832x.c get_maintainer.pl: No maintainers found, printing recent contributors. include/hw/i2c/i2c.h | 3 --- include/hw/input/ke

[Qemu-devel] [PATCH] hw/audio/wm8750: move WM8750 declarations from i2c/i2c.h to audio/wm8750.h

while here use TYPE_WM8750 and declare a data_req_cb() typedef. Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- include/hw/audio/wm8750.h | 30 ++ include/hw/i2c/i2c.h | 9 - hw/arm/musicpal.c | 3 ++- hw/arm/s

Re: [Qemu-devel] [Qemu-arm] [PATCH 4/5] misc: add pca9552 LED blinker model

On 09/19/2017 08:26 AM, Cédric Le Goater wrote: Specs are available here : https://www.nxp.com/docs/en/data-sheet/PCA9552.pdf This is a simple model supporting the basic registers for led and GPIO mode. The device also supports two blinking rates but not the model yet. Signed-off-by:

Re: [Qemu-devel] [PATCH] hw/audio/wm8750: move WM8750 declarations from i2c/i2c.h to audio/wm8750.h

On 09/19/2017 09:30 AM, Philippe Mathieu-Daudé wrote: while here use TYPE_WM8750 and declare a data_req_cb() typedef. Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- include/hw/audio/wm8750.h | 30 ++ Also while here I could rename it wm8750_c

[Qemu-devel] [PATCH v11 0/5] Add support for Smartfusion2 SoC

Hi Peter, Now than Igor's patch landed, I respin Sundeep's series updating it to work after the "arm: drop intermediate cpu_model -> cpu type parsing and use cpu type directly" patch. v11: - msf2-soc.c: add a check for null m3clk - msf2-soc.c, msf2-som.c: drop cpu_model to directly use cpu type

[Qemu-devel] [PATCH v4 6/6] mips: replace cpu_mips_init() with cpu_generic_init()

d-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> [PMD: use internal.h instead of cpu.h] Tested-by: James Hogan <james.ho...@imgtec.com> Reviewed-by: Eduardo Habkost <ehabk...@redhat.com> --- target/mips/cpu.h | 3 +-- hw/mips/cps.c | 2 +- hw/mips/mips_fulong2e.c |

[Qemu-devel] [PATCH v11 4/5] msf2: Add Smartfusion2 SoC

tair Francis <alistair.fran...@xilinx.com> Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> [PMD: drop cpu_model to directly use cpu type, check m3clk non null] --- default-configs/arm-softmmu.mak | 1 + include/hw/arm/msf2-soc.h | 67 +++ hw/arm/msf2-s

[Qemu-devel] [PATCH v11 2/5] msf2: Microsemi Smartfusion2 System Register block

: Philippe Mathieu-Daudé <f4...@amsat.org> Tested-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- include/hw/misc/msf2-sysreg.h | 77 hw/misc/msf2-sysreg.c | 160 ++ hw/misc/Makefile.objs | 1 + hw/misc/tra

[Qemu-devel] [PATCH v11 3/5] msf2: Add Smartfusion2 SPI controller

From: Subbaraya Sundeep <sundeep.l...@gmail.com> Modelled Microsemi's Smartfusion2 SPI controller. Signed-off-by: Subbaraya Sundeep <sundeep.l...@gmail.com> Reviewed-by: Alistair Francis <alistair.fran...@xilinx.com> Tested-by: Philippe Mathieu-Daudé <f4...@amsat.org>

[Qemu-devel] [PATCH v4 1/6] mips: move hw/mips/cputimer.c to target/mips/

ry include. Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Tested-by: Igor Mammedov <imamm...@redhat.com> Tested-by: James Hogan <james.ho...@imgtec.com> Acked-by: Eduardo Habkost <ehabk...@redhat.com> --- hw/mips/cputimer.c => target/mips/cp0

[Qemu-devel] [PATCH v4 0/6] QOMify MIPS cpu

ow triggers a "binary vs unary operators" confusion in checkpatch: "ERROR: space prohibited after that '&' (ctx:WxW)" Igor Mammedov (2): mips: MIPSCPU model subclasses mips: replace cpu_mips_init() with cpu_generic_init() Philippe Mathieu-Daudé (4): mips: move

[Qemu-devel] [PATCH v4 2/6] mips: introduce internal.h and cleanup cpu.h

no logical change, only code movement (and fix a comment typo). Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Tested-by: Igor Mammedov <imamm...@redhat.com> Tested-by: James Hogan <james.ho...@imgtec.com> Acked-by: Eduardo Habkost <ehabk...@redhat.com> --- This p

[Qemu-devel] [PATCH v4 5/6] mips: MIPSCPU model subclasses

From: Igor Mammedov <imamm...@redhat.com> Register separate QOM types for each mips cpu model, so it would be possible to reuse generic CPU creation routines. Signed-off-by: Igor Mammedov <imamm...@redhat.com> Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> [PMD: use in

[Qemu-devel] [PATCH v4 3/6] mips: split cpu_mips_realize_env() out of cpu_mips_init()

so it can be used in mips_cpu_realizefn() in the next commit Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Tested-by: Igor Mammedov <imamm...@redhat.com> Tested-by: James Hogan <james.ho...@imgtec.com> Reviewed-by: Eduardo Habkost <ehabk...@redhat.com> --- targ

[Qemu-devel] [PATCH v4 4/6] mips: call cpu_mips_realize_env() from mips_cpu_realizefn()

This changes the order between cpu_mips_realize_env() and cpu_exec_initfn(), but cpu_exec_initfn() don't have anything that depends on cpu_mips_realize_env() being called first. Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Tested-by: Igor Mammedov <imamm...@redhat.com> Test

[Qemu-devel] [PATCH v11 1/5] msf2: Add Smartfusion2 System timer

Acked-by: Philippe Mathieu-Daudé <f4...@amsat.org> Tested-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- include/hw/timer/mss-timer.h | 64 ++ hw/timer/mss-timer.c | 289 +++ hw/timer/Makefile.objs | 1 + 3 files changed,

[Qemu-devel] [PATCH v11 5/5] msf2: Add Emcraft's Smartfusion2 SOM kit

From: Subbaraya Sundeep <sundeep.l...@gmail.com> Emulated Emcraft's Smartfusion2 System On Module starter kit. Signed-off-by: Subbaraya Sundeep <sundeep.l...@gmail.com> Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> [PMD: drop cpu_model to directly use cpu type] ---

Re: [Qemu-devel] [PATCH v3] linux-user/syscall.c: Handle SH4's exceptional alignment for p{read, write}64

On 09/15/2017 04:33 PM, James Clarke wrote: Fixes: https://bugs.launchpad.net/qemu/+bug/1716767 Signed-off-by: James Clarke <jrt...@jrtc27.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- Changes since v2: * Fixed opening curly brace formatting, both for my new

Re: [Qemu-devel] [PATCH v2 5/7] mips: MIPSCPU model subclasses

Hi Eduardo, On 09/15/2017 09:15 PM, Eduardo Habkost wrote: On Wed, Aug 30, 2017 at 07:52:23PM -0300, Philippe Mathieu-Daudé wrote: From: Igor Mammedov <imamm...@redhat.com> Register separate QOM types for each mips cpu model, so it would be possible to reuse generic CPU creation ro

[Qemu-devel] [PATCH v3 1/6] mips: move hw/mips/cputimer.c to target/mips/

ry include. Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Tested-by: Igor Mammedov <imamm...@redhat.com> Tested-by: James Hogan <james.ho...@imgtec.com> Acked-by: Eduardo Habkost <ehabk...@redhat.com> --- hw/mips/cputimer.c => target/mips/cp0

[Qemu-devel] [PATCH v3 5/6] mips: MIPSCPU model subclasses

From: Igor Mammedov <imamm...@redhat.com> Register separate QOM types for each mips cpu model, so it would be possible to reuse generic CPU creation routines. Signed-off-by: Igor Mammedov <imamm...@redhat.com> Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> [PMD: use in

[Qemu-devel] [PATCH v3 4/6] mips: call cpu_mips_realize_env() from mips_cpu_realizefn()

This changes the order between cpu_mips_realize_env() and cpu_exec_initfn(), but cpu_exec_initfn() don't have anything that depends on cpu_mips_realize_env() being called first. Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Tested-by: Igor Mammedov <imamm...@redhat.com> Test

[Qemu-devel] [PATCH] qom/cpu: move cpu_model null check to cpu_class_by_name()

and clean every implementation. Suggested-by: Eduardo Habkost <ehabk...@redhat.com> Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- Based-on: 20170917232010.14183-7-f4...@amsat.org qom/cpu.c | 7 ++- target/alpha/cpu.c | 6 +- target/arm/cpu

Re: [Qemu-devel] [PATCH v2 7/7] mips: update mips_cpu_list() to use object_class_get_list()

On 09/15/2017 09:20 PM, Eduardo Habkost wrote: On Wed, Aug 30, 2017 at 07:52:25PM -0300, Philippe Mathieu-Daudé wrote: while here, move it from translate_init.c to helper.c Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Tested-by: Igor Mammedov <imamm...@redhat.com> Test

[Qemu-devel] [PATCH v3 0/6] QOMify MIPS cpu

eckpatch: "ERROR: space prohibited after that '&' (ctx:WxW)" Igor Mammedov (2): mips: MIPSCPU model subclasses mips: replace cpu_mips_init() with cpu_generic_init() Philippe Mathieu-Daudé (4): mips: move hw/mips/cputimer.c to target/mips/ mips: introduce internal.h and cleanup cpu.h m

[Qemu-devel] [PATCH v3 2/6] mips: introduce internal.h and cleanup cpu.h

no logical change, only code movement (and fix a comment typo). Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Tested-by: Igor Mammedov <imamm...@redhat.com> Tested-by: James Hogan <james.ho...@imgtec.com> Acked-by: Eduardo Habkost <ehabk...@redhat.com> --- This p

[Qemu-devel] [PATCH v3 3/6] mips: split cpu_mips_realize_env() out of cpu_mips_init()

so it can be used in mips_cpu_realizefn() in the next commit Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Tested-by: Igor Mammedov <imamm...@redhat.com> Tested-by: James Hogan <james.ho...@imgtec.com> Reviewed-by: Eduardo Habkost <ehabk...@redhat.com> --- targ

[Qemu-devel] [PATCH v3 6/6] mips: replace cpu_mips_init() with cpu_generic_init()

d-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> [PMD: use internal.h instead of cpu.h] Tested-by: James Hogan <james.ho...@imgtec.com> Reviewed-by: Eduardo Habkost <ehabk...@redhat.com> --- target/mips/cpu.h | 3 +-- hw/mips/cps.c | 2 +- hw/mips/mips_fulong2e.c |

Re: [Qemu-devel] [Qemu devel v8 PATCH 2/5] msf2: Microsemi Smartfusion2 System Register block

Hi Sundeep, On 09/14/2017 01:36 AM, Philippe Mathieu-Daudé wrote: On 09/07/2017 04:24 PM, Subbaraya Sundeep wrote: [...] +static inline int msf2_divbits(uint32_t div) Please directly use ctz32() instead of msf2_divbits() It seems you missed this review comment in your v9. +{ +    int

Re: [Qemu-devel] [Qemu devel v9 PATCH 1/5] msf2: Add Smartfusion2 System timer

> Acked-by: Philippe Mathieu-Daudé <f4...@amsat.org> Tested-by: Philippe Mathieu-Daudé <f4...@amsat.org>

Re: [Qemu-devel] [Qemu devel v9 PATCH 3/5] msf2: Add Smartfusion2 SPI controller

On 09/15/2017 01:59 PM, Subbaraya Sundeep wrote: Modelled Microsemi's Smartfusion2 SPI controller. Signed-off-by: Subbaraya Sundeep <sundeep.l...@gmail.com> Reviewed-by: Alistair Francis <alistair.fran...@xilinx.com> Tested-by: Philippe Mathieu-Daudé <f4...@amsat.org>

Re: [Qemu-devel] [Qemu devel v9 PATCH 5/5] msf2: Add Emcraft's Smartfusion2 SOM kit

On 09/15/2017 01:59 PM, Subbaraya Sundeep wrote: Emulated Emcraft's Smartfusion2 System On Module starter kit. Signed-off-by: Subbaraya Sundeep <sundeep.l...@gmail.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> Tested-by: Philippe Mathieu-Daudé <f4...@amsat.org>

Re: [Qemu-devel] [Qemu devel v9 PATCH 0/5] Add support for Smartfusion2 SoC

only system timer, sysreg and SPI controller are modelled. Tested-by: Philippe Mathieu-Daudé <f4...@amsat.org> When a review tag is sent to the series cover, this means it can be added to all the patches from the series. Testing: ./arm-softmmu/qemu-system-arm -M emcraft-sf2 -serial mon

Re: [Qemu-devel] [Qemu devel v9 PATCH 2/5] msf2: Microsemi Smartfusion2 System Register block

TUS_HIGH_CR, +MSSDDR_FACC1_CR, +MSSDDR_FACC2_CR, + +MSSDDR_PLL_STATUS = 0x150 / 4, +}; + +#define MSF2_SYSREG_MMIO_SIZE 0x300 + +#define TYPE_MSF2_SYSREG "msf2-sysreg" +#define MSF2_SYSREG(obj) OBJECT_CHECK(MSF2SysregState, (obj), TYPE_MSF2_SYSREG) + +typedef struct MSF2SysregState { +SysBusDevice parent_obj; + +MemoryRegion iomem; + +uint32_t apb0div; +uint32_t apb1div; uint8_t for both + +uint32_t regs[MSF2_SYSREG_MMIO_SIZE / 4]; +} MSF2SysregState; + +#endif /* HW_MSF2_SYSREG_H */ Acked-by: Philippe Mathieu-Daudé <f4...@amsat.org> Tested-by: Philippe Mathieu-Daudé <f4...@amsat.org>

Re: [Qemu-devel] [Qemu devel v9 PATCH 4/5] msf2: Add Smartfusion2 SoC

+#include "hw/misc/msf2-sysreg.h" +#include "hw/ssi/mss-spi.h" + +#define TYPE_MSF2_SOC "msf2-soc" +#define MSF2_SOC(obj) OBJECT_CHECK(MSF2State, (obj), TYPE_MSF2_SOC) + +#define MSF2_NUM_SPIS 2 +#define MSF2_NUM_UARTS 2 + +/* + * System timer consists of two programmable 32-bit + * decrementing counters that generate individual interrupts to + * the Cortex-M3 processor + */ +#define MSF2_NUM_TIMERS 2 + +typedef struct MSF2State { +/*< private >*/ +SysBusDevice parent_obj; +/*< public >*/ + +ARMv7MState armv7m; + +char *part_name; +uint64_t envm_size; +uint64_t esram_size; + +uint32_t m3clk; +uint32_t apb0div; +uint32_t apb1div; uint8_t ? + +MSF2SysregState sysreg; +MSSTimerState timer; +MSSSpiState spi[MSF2_NUM_SPIS]; +} MSF2State; + +#endif Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> Tested-by: Philippe Mathieu-Daudé <f4...@amsat.org>

Re: [Qemu-devel] [PATCH 1/8] ppc: QOMify g3beige machine

On 09/17/2017 02:15 PM, Mark Cave-Ayland wrote: Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/ppc/mac_oldworld.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --

Re: [Qemu-devel] [Qemu devel v8 PATCH 5/5] msf2: Add Emcraft's Smartfusion2 SOM kit

On 09/14/2017 02:14 PM, Peter Maydell wrote: On 7 September 2017 at 20:24, Subbaraya Sundeep wrote: Emulated Emcraft's Smartfusion2 System On Module starter kit. +static void emcraft_sf2_machine_init(MachineClass *mc) +{ +mc->desc = "SmartFusion2 SOM kit from

Re: [Qemu-devel] [Qemu devel v8 PATCH 2/5] msf2: Microsemi Smartfusion2 System Register block

+static uint64_t msf2_sysreg_read(void *opaque, hwaddr offset, +unsigned size) +{ +MSF2SysregState *s = opaque; +uint32_t ret = 0; + +offset >>= 2; +if (offset < ARRAY_SIZE(s->regs)) { This comment is controversial, I'll let Peter nod. The SYSREG behaves differently

Re: [Qemu-devel] [Qemu devel v8 PATCH 0/5] Add support for Smartfusion2 SoC

On 09/08/2017 04:24 AM, sundeep subbaraya wrote: Hi Phillipe, On Fri, Sep 8, 2017 at 3:14 AM, Philippe Mathieu-Daudé <f4...@amsat.org <mailto:f4...@amsat.org>> wrote: Hi Subbaraya, very good work! On 09/07/2017 04:24 PM, Subbaraya Sundeep wrote: H

Re: [Qemu-devel] [Qemu devel v8 PATCH 2/5] msf2: Microsemi Smartfusion2 System Register block

Hi Sundeep, On 09/07/2017 04:24 PM, Subbaraya Sundeep wrote: Added Sytem register block of Smartfusion2. This block has PLL registers which are accessed by guest. Signed-off-by: Subbaraya Sundeep Reviewed-by: Alistair Francis ---

Re: [Qemu-devel] [PATCH] accel/hax: move hax-stub.c to accel/stubs/

>> --- a/accel/stubs/Makefile.objs >> +++ b/accel/stubs/Makefile.objs >> @@ -1,2 +1,3 @@ >> obj-$(call lnot,$(CONFIG_KVM)) += kvm-stub.o >> obj-$(call lnot,$(CONFIG_TCG)) += tcg-stub.o >> +obj-$(call lnot,$(CONFIG_HAX)) += hax-stub.o > > Reviewed-by: Stefan Weil Thanks! > >

Re: [Qemu-devel] [PATCH v2 3/5] vl.c: convert cpu_model to cpu type and set of global properties before machine_init()

. Signed-off-by: Igor Mammedov <imamm...@redhat.com> Acked-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- Target specific changes will split into separate per target/machine patches to make changes reviewable. --- include/hw/boards.h | 6 ++ vl.c| 10 +++

Re: [Qemu-devel] [PATCH v2 5/5] arm: drop intermediate cpu_model -> cpu type parsing and use cpu type directly

parison is always false due to limited range of data type" @@ -380,7 +366,7 @@ static void a15_daughterboard_init(const VexpressMachineState *vms, memory_region_add_subregion(sysmem, 0x8000, ram); /* 0x2c00 A15MPCore private memory region (GIC) */ -init_cpus(cpu

[Qemu-devel] [PATCH] accel/hax: move hax-stub.c to accel/stubs/

Suggested-by: Paolo Bonzini <pbonz...@redhat.com> Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- Makefile.target | 1 - hax-stub.c => accel/stubs/hax-stub.c | 0 accel/stubs/Makefile.objs| 1 + 3 files changed, 1 insertion(+), 1 dele

Re: [Qemu-devel] [PATCH v11 09/13] tests: Add OpenBSD image

Alex, Peter, JTLYK I just finished to test this one too (which was merged in the meaning time). On 09/21/2017 12:07 PM, Fam Zheng wrote: The image is prepared following instructions as in: https://wiki.qemu.org/Hosts/BSD Signed-off-by: Fam Zheng --- tests/vm/openbsd |

Re: [Qemu-devel] [PATCH v11 07/13] tests: Add FreeBSD image

Hi Fam, On 09/21/2017 12:07 PM, Fam Zheng wrote: The image is prepared following instructions as in: https://wiki.qemu.org/Hosts/BSD Signed-off-by: Fam Zheng --- tests/vm/freebsd | 42 ++ 1 file changed, 42 insertions(+) create

Re: [Qemu-devel] [PATCH v11 07/13] tests: Add FreeBSD image

o CC tests/io-channel-helpers.o LINKtests/test-io-channel-socket the build hang here, stopping to use the cpu, keeping 2GB of resident physical memory until I hit ^C ... not enough ram for the guest? guest tmpfs full? useful enough for: Tested-by: Philippe Mathieu-Daudé <f4...@

Re: [Qemu-devel] [PATCH] tests/boot-sector: Increase timeout to 600 seconds

Hi Thomas, On 09/22/2017 12:06 AM, Thomas Huth wrote: If QEMU has been compiled with the flags --enable-tcg-interpreter and --enable-debug, the guest is running incredibly slow. The pxe boot test There already is a qtest_get_arch(), it might be convenient to have a qtest_get_accel() at some

[Qemu-devel] [PATCH 05/34] misc: remove duplicated includes

exec: housekeeping (funny since 02d0e095031) applied using ./scripts/clean-includes Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- accel/tcg/translate-all.c | 1 - exec.c | 3 --- hw/arm/spitz.c | 1 - hw/char/xen_con

[Qemu-devel] [PATCH 09/34] misc: avoid "include/" in include path

while here, remove unused #include from aspeed_smc.h Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/input/adb.c | 2 +- hw/ssi/aspeed_smc.c | 3 +-- numa.c | 1 - 3 files changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/input/adb.c b/hw/input

[Qemu-devel] [PATCH 06/34] ppc: remove duplicated includes

applied using ./scripts/clean-includes not needed since 7ebaf795560 Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/ppc/spapr_hcall.c | 1 - target/ppc/kvm.c | 3 --- 2 files changed, 4 deletions(-) diff --git a/hw/ppc/spapr_hcall.c b/hw/ppc/spapr_hcall.c index 57bb

[Qemu-devel] [PATCH 10/34] amd_iommu: avoid needless includes in header file

instead move them to the source file Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/i386/amd_iommu.h | 5 - hw/i386/amd_iommu.c | 5 - 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/hw/i386/amd_iommu.h b/hw/i386/amd_iommu.h index d370ae3549..aeef

[Qemu-devel] [PATCH 08/34] nios2: remove duplicated includes

applied using ./scripts/clean-includes Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- target/nios2/cpu.h | 1 - disas/nios2.c| 3 --- hw/nios2/boot.c | 1 - target/nios2/helper.c| 7 ++- target/nios2/op_helper.c | 1 + target/nios2/translate

[Qemu-devel] [PATCH 13/34] hw/ide: remove old i386 dependency

and remove a duplicated include Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/ide/ahci.c | 1 - hw/ide/cmd646.c | 1 - hw/ide/core.c | 3 +-- hw/ide/ich.c| 1 - hw/ide/isa.c| 1 - hw/ide/microdrive.c | 1 - hw/ide/pci.c| 1 - hw/ide/

[Qemu-devel] [PATCH 16/34] hw/tpm: remove old i386 dependency

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/tpm/tpm_passthrough.c | 1 - hw/tpm/tpm_tis.c | 1 - 2 files changed, 2 deletions(-) diff --git a/hw/tpm/tpm_passthrough.c b/hw/tpm/tpm_passthrough.c index 9234eb3459..461f551a0c 100644 --- a/hw/tpm/tpm_passthrough.c ++

[Qemu-devel] [PATCH 22/34] hw/input/i8042: extract API from hw/i386/pc.h

- include vmmouse - add entries in MAINTAINERS (pckbd.c, i8042.h) Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- include/hw/i386/pc.h | 11 --- include/hw/input/i8042.h | 30 ++ hw/alpha/dp264.c | 3 ++- hw/i386/pc.c

[Qemu-devel] [PATCH 29/34] hw/net/e1000e: use TYPE_PCI_E1000E

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- include/hw/net/pci.h | 1 + hw/net/e1000e.c | 6 +++--- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/include/hw/net/pci.h b/include/hw/net/pci.h index b24b5257a5..92111f86f3 100644 --- a/include/hw/net/pci.h

[Qemu-devel] [PATCH 25/34] hw/timer/m48t59: use TYPE_M48T59_ISA, add entries to MAINTAINERS

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- include/hw/timer/m48t59.h | 2 ++ hw/ppc/prep.c | 2 +- hw/timer/m48t59-isa.c | 2 +- MAINTAINERS | 2 ++ 4 files changed, 6 insertions(+), 2 deletions(-) diff --git a/include/hw/timer/m48t59.h b/incl

[Qemu-devel] [PATCH 32/34] hw/net/ne2000: use TYPE_PCI_NE2000

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- include/hw/net/pci.h | 1 + hw/net/ne2000.c | 3 ++- hw/ppc/mac_newworld.c | 3 ++- hw/ppc/mac_oldworld.c | 3 ++- hw/ppc/prep.c | 2 +- hw/sparc64/sun4u.c| 3 ++- 6 files changed, 10 insertions(+), 5 del

[Qemu-devel] [PATCH 00/34] remove i386/pc dependency from non-PC world (part 1)

couldn't test the KVM/XEN/HAX part. Regards, Phil. Philippe Mathieu-Daudé (34): hw: use "qemu/osdep.h" as first #include in source files hw: remove "qemu/osdep.h" from header files block: remove "qemu/osdep.h" from header file misc: remove headers impl

[Qemu-devel] [PATCH 01/34] hw: use "qemu/osdep.h" as first #include in source files

applied using ./scripts/clean-includes Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/acpi/ipmi-stub.c | 1 + hw/audio/fmopl.c| 1 - hw/cpu/core.c | 1 + hw/ppc/spapr_cpu_core.c | 1 + hw/smbios/smbios_type_38-stub.c | 1

[Qemu-devel] [PATCH 04/34] misc: remove headers implicitly included

applied using ./scripts/clean-includes Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/audio/fmopl.h | 1 - bsd-user/main.c | 1 - chardev/wctablet.c | 4 hw/scsi/vhost-user-scsi.c| 1 - linux-user/main.c| 1 - ne

[Qemu-devel] [PATCH 03/34] block: remove "qemu/osdep.h" from header file

applied using ./scripts/clean-includes Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- block/dmg.h | 1 - 1 file changed, 1 deletion(-) diff --git a/block/dmg.h b/block/dmg.h index b592d6fa8b..2ecf239ba5 100644 --- a/block/dmg.h +++ b/block/dmg.h @@ -26,7 +26,6 @@ #

[Qemu-devel] [PATCH 14/34] hw/ipmi: remove old i386 dependency

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/ipmi/isa_ipmi_bt.c | 1 - hw/ipmi/isa_ipmi_kcs.c | 1 - 2 files changed, 2 deletions(-) diff --git a/hw/ipmi/isa_ipmi_bt.c b/hw/ipmi/isa_ipmi_bt.c index 2fcc3d2e7c..e098fd5206 100644 --- a/hw/ipmi/isa_ipmi_bt.c +++ b/h

[Qemu-devel] [PATCH 12/34] misc: remove old i386 dependency

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/audio/pcspk.c| 1 - hw/i386/kvm/pci-assign.c| 1 - hw/i386/pci-assign-load-rom.c | 1 - hw/i386/xen/xen_platform.c | 1 - hw/isa/vt82c686.c | 1 - hw/misc/ivs

[Qemu-devel] [PATCH 20/34] hw/timer/i8254: rename pit_init() -> i8254_pit_init()

- add entry for i82378 in MAINTAINERS - remove the old i386/pc dependency Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- include/hw/timer/i8254.h | 5 +++-- include/hw/timer/i8254_internal.h | 2 +- hw/alpha/dp264.c | 2 +- hw/i38

[Qemu-devel] [PATCH 30/34] hw/net/pcnet: use TYPE_PCI_PCNET

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- include/hw/net/pci.h | 1 + hw/mips/mips_malta.c | 2 +- hw/net/pcnet-pci.c | 3 +-- hw/ppc/prep.c| 3 ++- 4 files changed, 5 insertions(+), 4 deletions(-) diff --git a/include/hw/net/pci.h b/include/hw/net/pci.h

[Qemu-devel] [PATCH 26/34] hw/net/ne2000: extract ne2k-isa code from i386/pc to ne2000-isa.c

- add "hw/net/ne2000-isa.h" (and new entry in MAINTAINERS) - remove the old i386 dependency Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/net/ne2000.h | 3 +++ include/hw/i386/pc.h| 20 include/hw/net/n

[Qemu-devel] [PATCH 33/34] hw/alpha: remove old i386 dependency

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/alpha/alpha_sys.h | 2 -- hw/alpha/pci.c | 2 ++ hw/alpha/typhoon.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/alpha/alpha_sys.h b/hw/alpha/alpha_sys.h index b6d8369ed7..ac685c1c46

[Qemu-devel] [PATCH 27/34] hw/pci: declare pci_nic_init_nofail() in "hw/net/pci.h"

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/pci/pci_internal.h | 16 +++ include/hw/net/pci.h | 20 + include/hw/pci/pci.h | 4 --- hw/arm/virt.c | 1 + hw/mips/mips_malta.c | 1 + hw/pci/pci.c

[Qemu-devel] [PATCH 34/34] misc: drop old i386 dependency

while here, add an entry for wdt_ib700 in MAINTAINERS Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/char/debugcon.c | 1 - hw/intc/lm32_pic.c | 1 - hw/moxie/moxiesim.c | 1 - hw/sparc/sun4m.c| 1 - hw/watchdog/wdt_ib700.c | 1 - MAINTAINERS

[Qemu-devel] [PATCH 02/34] hw: remove "qemu/osdep.h" from header files

while here, add entries for ppc4xx_i2c in MAINTAINERS applied using ./scripts/clean-includes Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- Zoltán you might want to add yourself a reviewer entry on ppc4xx :) R: Balaton Zoltan <bala...@eik.bme.hu> include/hw/acpi/ipm

[Qemu-devel] [PATCH 07/34] i386/hax: remove duplicated includes

applied using ./scripts/clean-includes Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- include/sysemu/hax.h | 1 - target/i386/hax-darwin.h | 3 --- target/i386/hax-windows.h | 2 -- target/i386/hax-darwin.c | 8 ++-- 4 files changed, 2 insertions(+), 12 deletions(-)

[Qemu-devel] [PATCH 17/34] hw/virtio-balloon: remove old i386 dependency

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/virtio/virtio-balloon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c index 37cde38982..14e08d20d0 100644 --- a/hw/virtio/virtio-balloon.c +++ b/hw/

[Qemu-devel] [PATCH 18/34] hw/unicore32: restrict hw addr defines to source file

and drop unused #includes Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- include/hw/unicore32/puv3.h | 10 -- hw/unicore32/puv3.c | 16 ++-- 2 files changed, 10 insertions(+), 16 deletions(-) diff --git a/include/hw/unicore32/puv3.h b/incl

[Qemu-devel] [PATCH 19/34] hw/acpi: ACPI_PM_* defines are not restricted to i386 arch

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- include/hw/acpi/acpi.h | 12 include/hw/i386/pc.h | 13 - 2 files changed, 12 insertions(+), 13 deletions(-) diff --git a/include/hw/acpi/acpi.h b/include/hw/acpi/acpi.h index 7b3d93cf0d..30013b0464

[Qemu-devel] [PATCH 11/34] i386/pc: use TYPE_PORT92

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/i386/pc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 05985d4927..f116cede91 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -1577,7 +1577,7 @@ void pc_basic_device_init(

[Qemu-devel] [PATCH 15/34] hw/i2c: remove old i386 dependency

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/i2c/pm_smbus.c | 1 - hw/i2c/smbus_ich9.c | 1 - 2 files changed, 2 deletions(-) diff --git a/hw/i2c/pm_smbus.c b/hw/i2c/pm_smbus.c index 6fc3923f56..a044dd1b27 100644 --- a/hw/i2c/pm_smbus.c +++ b/hw/i2c/pm_smbus.c @@ -19,7

[Qemu-devel] [PATCH 23/34] hw/dma/i8257: rename DMA_init() to i8257_dma_init()

- move the header from hw/isa/ to hw/dma/ - add entry for i82374 in MAINTAINERS - remove the old i386/pc dependency Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- include/hw/{isa/i8257.h => dma/i8257_dma.h} | 6 ++ include/hw/isa/isa.h| 2 -

<    10   11   12   13   14   15   16   17   18   19   >