Re: [Qemu-devel] [PATCH 71/88] block: avoid use of g_new0()

On 10/06/2017 08:50 PM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> > --- > block/qcow2.c | 2 +- > block/vhdx.c | 9 + > 2 files changed, 6 insertions(+), 5 deletions(-) > > diff --git a/block/qcow2.c b/block

Re: [Qemu-devel] [PATCH v1 4/5] xilinx_zynq: : Specify the valid CPUs

On 10/03/2017 05:05 PM, Alistair Francis wrote: > List all possible valid CPU options. > > Signed-off-by: Alistair Francis <alistair.fran...@xilinx.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> > --- > > hw/arm/xilinx_zynq.c | 5 + > 1 file c

Re: [Qemu-devel] [PATCH v1 2/5] netduino2: Specify the valid CPUs

> > Signed-off-by: Alistair Francis <alistair.fran...@xilinx.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> > --- > > RFC v2: > - Use a NULL terminated list > - Add the Cortex-M4 for testing > > > hw/arm/netduino2.c | 9 - > 1

Re: [Qemu-devel] [PATCH v1 5/5] raspi: : Specify the valid CPUs

ault_cpu_type = ARM_CPU_TYPE_NAME("cortex-a7"); >>> +mc->valid_cpu_types = raspi2_valid_cpus; >> >> I'm confused: bcm2836_init() is hardcoded to cortex-a15, not >> cortex-a7. > > Odd. I just looked up the Raspberry Pi 2 and it says a Cortex-A7: &

Re: [Qemu-devel] [PATCH] futex: add missing header guards

Cc: trivial On 10/13/2017 06:30 PM, Emilio G. Cota wrote: > The header file was introduced by fbcc3e5 ("qemu-thread: optimize QemuLockCnt > with futexes on Linux", 2017-01-16) without header guards. Add them. > > Signed-off-by: Emilio G. Cota <c...@braap.org> Reviewe

Re: [Qemu-devel] [PATCH] tco: add trace events

nt32_t idx) "0x%"PRIx32 > cpuhp_acpi_write_ost_ev(uint32_t slot, uint32_t ev) "idx[0x%"PRIx32"] OST > EVENT: 0x%"PRIx32 > cpuhp_acpi_write_ost_status(uint32_t slot, uint32_t st) "idx[0x%"PRIx32"] > OST STATUS: 0x%"PRIx32 > + > +# hw/acpi/tco.c > +tco_timer_reload(int ticks, int msec) "ticks=%d (%d ms)" > +tco_timer_expired(int timeouts_no, bool strap, bool no_reboot) > "timeouts_no=%d no_reboot=%d/%d" Changing tabs by spaces to satisfy checkpatch: Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org>

Re: [Qemu-devel] [PATCH v2] oslib-posix: Fix compiler warning and some data types

do_touch_pages(void *arg) > * don't need to write at all so we don't cause > * wear on the storage backing the region... > */ > -*(volatile char *)addr = *addr; > +*addr = *addr; I personally prefer the other form which i

Re: [Qemu-devel] QEMU without X11 support

>> Hello, is it possible to run (or rebuild modifying build flags) QEMU >> without support for X11 window system integration? > > ./configure --disable-gtk --disable-sdl --disable-opengl Is there some interest in adding a simpler --disable-x11 option?

Re: [Qemu-devel] [PATCH 21/38] sh4: remove SuperHCPUClass::name field

h*_class_init()/SuperHCPUClass a bit. > > Signed-off-by: Igor Mammedov <imamm...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> > --- > CC: aurel...@aurel32.net > --- > target/sh4/cpu-qom.h | 2 -- > target/sh4/cpu.c | 10 +++--- > 2 files c

Re: [Qemu-devel] [PATCH 18/38] sh4: shix: use generic cpu_model parsing

m", 0x4000, _fatal); > @@ -89,6 +85,7 @@ static void shix_machine_init(MachineClass *mc) > mc->desc = "shix card"; > mc->init = shix_init; > mc->is_default = 1; > +mc->default_cpu_type = TYPE_SH7750R_CPU; Maybe worth a comment explaining this. After checking superh_cpu_class_by_name(): Acked-by: Philippe Mathieu-Daudé <f4...@amsat.org> > } > > DEFINE_MACHINE("shix", shix_machine_init) >

Re: [Qemu-devel] [Qemu-arm] [PATCH 18/20] target/arm: Implement BLXNS

On 09/22/2017 12:00 PM, Peter Maydell wrote: > Implement the BLXNS instruction, which allows secure code to > call non-secure code. > > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> Acked-by: Philippe Mathieu-Daudé <f4...@amsat.org> > --- > target/arm/he

Re: [Qemu-devel] [PATCH 17/38] sh4: r2d: use generic cpu_model parsing

On 10/02/2017 06:07 AM, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov <imamm...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> > --- > CC: Magnus Damm <magnus.d...@gmail.com> > CC: Aurelien Jarno <aurel...@aurel32.net> > --- > h

Re: [Qemu-devel] [PATCH v2 2/3] qom: introduce type_register_static_array()

On 10/04/2017 07:08 AM, Igor Mammedov wrote: > it will help to remove code duplication of registration > static types in places that have open coded loop to > perform batch type registering. > > Signed-off-by: Igor Mammedov <imamm...@redhat.com> Reviewed-by: Phili

Re: [Qemu-devel] [Qemu-arm] [PATCH 19/20] target/arm: Implement secure function return

<peter.mayd...@linaro.org> Acked-by: Philippe Mathieu-Daudé <f4...@amsat.org> > --- > target/arm/internals.h | 7 +++ > target/arm/helper.c| 115 > + > target/arm/translate.c | 14 +- > 3 files changed,

Re: [Qemu-devel] [PATCH v2 3/3] qom: add helper macro DEFINE_TYPES()

ive style of > type registration. > > Signed-off-by: Igor Mammedov <imamm...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> > --- > include/qom/object.h | 36 > 1 file changed, 36 insertions(+) > > diff --git

Re: [Qemu-devel] [PATCH 19/38] sh4: cleanup cpu type name composition

; > Signed-off-by: Igor Mammedov <imamm...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> > --- > CC: aurel...@aurel32.net > --- > target/sh4/cpu-qom.h | 6 ++--- > target/sh4/cpu.h | 3 +++ > target/sh4/cpu.c | 63 >

Re: [Qemu-devel] [PATCH 20/38] sh4: simplify superh_cpu_class_by_name()

= SUPERH_CPU_CLASS(a); > -const char *name = b; > - > -return strcasecmp(scc->name, name); > -} > - > static ObjectClass *superh_cpu_class_by_name(const char *cpu_model) > { > -ObjectClass *oc; > +ObjectClass *oc = NULL;; No need to NULL

Re: [Qemu-devel] [PATCH v2 20/40] sh4: shix: use generic cpu_model parsing

On 10/05/2017 10:50 AM, Igor Mammedov wrote: > default cpu model 'any' resolves to type TYPE_SH7750R_CPU > in superh_cpu_class_by_name(), so use it directly. > > Signed-off-by: Igor Mammedov <imamm...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> &

Re: [Qemu-devel] [PATCH v2 22/40] sh4: simplify superh_cpu_class_by_name()

tly instead of >over-complicated >object_class_get_list() >g_slist_find_custom() + superh_cpu_name_compare() > > With #1 droped, #2 could be used for both lookups which > simplifies superh_cpu_class_by_name() quite a bit. > > Signed-off-by: Igor Mammedov <imamm...@re

Re: [Qemu-devel] [PATCH v2 06/40] cris: cleanup cpu type name composition

On 10/05/2017 10:50 AM, Igor Mammedov wrote: > replace ambiguous TYPE macro with a new CRIS_CPU_TYPE_NAME > and use it consistently in the code. > > Signed-off-by: Igor Mammedov <imamm...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org>

Re: [Qemu-devel] [PATCH 33/34] hw/alpha: remove old i386 dependency

On 10/02/2017 04:03 PM, Richard Henderson wrote: > 2017-09-22 12:01 GMT-04:00 Philippe Mathieu-Daudé <f4...@amsat.org>: > >> diff --git a/hw/alpha/alpha_sys.h b/hw/alpha/alpha_sys.h >> index b6d8369ed7..ac685c1c46 100644 >> --- a/hw/alpha/alpha_sys.h >> +++ b/

Re: [Qemu-devel] [PATCH v2 37/39] i386/pc: extract port92 from pc.c

> Why are you doing this? I really fail to see the rationale here. Please > add proper patch descriptions! Oops sorry :/ Mostly because while moving things around I read this comment laying around since commit 4b78a802ffa: /* port 92 stuff: could be split off */ No further rational (except

Re: [Qemu-devel] [PATCH v2 30/39] hw/display/vga: remove the old i386/pc dependency

Hi Thomas, >> diff --git a/hw/display/vga_int.h b/hw/display/vga_int.h >> index ad34a1f048..fe23b81442 100644 >> --- a/hw/display/vga_int.h >> +++ b/hw/display/vga_int.h >> @@ -25,8 +25,9 @@ >> #ifndef HW_VGA_INT_H >> #define HW_VGA_INT_H >> >> -#include "hw/hw.h" >> +#include "exec/ioport.h"

Re: [Qemu-devel] [PATCH v2 36/39] i386/pc: move pvpanic.c from hw/misc/ to hw/i386/

On 10/17/2017 08:04 AM, Paolo Bonzini wrote:> pvpanic does not _have_ to be i386-specific, and losing the > configurability with default-configs/ is a bit of a pity (there are > people who change the configurations), so I think it's better to leave > out this change. Good to know, OK! (patch

[Qemu-devel] [PATCH v2 06/39] MAINTAINERS: add entries for timer/m48t59

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Reviewed-by: Hervé Poussineau <hpous...@reactos.org> --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index b90a42d823..06ec24912e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -

[Qemu-devel] [PATCH v2 01/39] MAINTAINERS: add entries for i2c/ppc4xx_i2c

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> Reviewed-by: Corey Minyard <cminy...@mvista.com> --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9cff9737d3.

[Qemu-devel] [PATCH v2 14/39] i386/hax: remove duplicated includes

applied using ./scripts/clean-includes Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> --- include/sysemu/hax.h | 1 - target/i386/hax-darwin.h | 3 --- target/i386/hax-windows.h | 2 -- target/i386/hax-darwin.c |

[Qemu-devel] [PATCH v2 13/39] ppc: remove duplicated includes

applied using ./scripts/clean-includes not needed since 7ebaf795560 Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> Acked-by: David Gibson <da...@gibson.dropbear.id.au> --- hw/ppc/spapr_hcall.c | 1 - target/ppc/kv

[Qemu-devel] [PATCH v2 17/39] misc: avoid "include/" in include path

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> --- hw/input/adb.c | 2 +- hw/ssi/aspeed_smc.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/input/adb.c b/hw/input/adb.c index fcca3a8eb9

[Qemu-devel] [PATCH v2 16/39] nios2: remove duplicated includes (in code commented out)

applied using ./scripts/clean-includes Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> --- target/nios2/cpu.h | 1 - disas/nios2.c| 3 --- hw/nios2/boot.c | 1 - target/nios2/helper.c| 5 +

[Qemu-devel] [PATCH v2 09/39] hw: remove "qemu/osdep.h" from header files

applied using ./scripts/clean-includes Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> Reviewed-by: Corey Minyard <cminy...@mvista.com> Tested-by: Corey Minyard <cminy...@mvista.com> --- include/hw/acpi/ipmi.

[Qemu-devel] [PATCH v2 29/39] hw/timer/i8254: rename pit_init() -> i8254_pit_init()

and remove the old i386/pc dependency Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Reviewed-by: Hervé Poussineau <hpous...@reactos.org> --- include/hw/timer/i8254.h | 5 +++-- include/hw/timer/i8254_internal.h | 2 +- hw/alpha/dp264.c | 2 +-

[Qemu-devel] [PATCH v2 21/39] misc: remove old i386 dependency

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Reviewed-by: Thomas Huth <th...@redhat.com> Reviewed-by: Anthony PERARD <anthony.per...@citrix.com> --- hw/audio/pcspk.c| 1 - hw/i386/kvm/pci-assign.c| 1 - hw/i386/pci-assign-load-rom.c

[Qemu-devel] [PATCH v2 08/39] hw: use "qemu/osdep.h" as first #include in source files

applied using ./scripts/clean-includes Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> Acked-by: David Gibson <da...@gibson.dropbear.id.au> Acked-by: Cornelia Huck <coh...@redhat.com> --- hw/acpi/ipmi-stub

[Qemu-devel] [PATCH v2 05/39] MAINTAINERS: add an entry for input/pckbd.c

and fix a typo in the "PC Chipset" section Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Reviewed-by: Hervé Poussineau <hpous...@reactos.org> --- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index

[Qemu-devel] [PATCH v2 11/39] misc: remove headers implicitly included

applied using ./scripts/clean-includes Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> --- hw/audio/fmopl.h | 1 - bsd-user/main.c | 1 -

[Qemu-devel] [PATCH v2 12/39] misc: remove duplicated includes

exec: housekeeping (funny since 02d0e095031) applied using ./scripts/clean-includes Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> Acked-by: Cornelia Huck <coh...@redhat.com> Reviewed-by: Anthony PERARD <anth

[Qemu-devel] [PATCH v2 04/39] MAINTAINERS: add an entry for watchdog/wdt_ib700

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Reviewed-by: Thomas Huth <th...@redhat.com> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 0ce3c353e0..99033b049c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -856,6 +856,7 @

[Qemu-devel] [PATCH v2 19/39] hw/ssi/aspeed_smc: remove unused #include

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> --- hw/ssi/aspeed_smc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/ssi/aspeed_smc.c b/hw/ssi/aspeed_smc.c index 992617fd3a..5059396bc6 100644 --- a/hw/ssi/aspeed_sm

[Qemu-devel] [PATCH v2 23/39] hw/ipmi: remove old i386 dependency

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Reviewed-by: Corey Minyard <cminy...@mvista.com> Tested-by: Corey Minyard <cminy...@mvista.com> --- hw/ipmi/isa_ipmi_bt.c | 1 - hw/ipmi/isa_ipmi_kcs.c | 1 - 2 files changed, 2 deletions(-) diff --git a/hw/ipmi/isa_i

[Qemu-devel] [PATCH v2 20/39] amd_iommu: avoid needless includes in header file

instead move them to the source file Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Reviewed-by: Thomas Huth <th...@redhat.com> --- hw/i386/amd_iommu.h | 5 - hw/i386/amd_iommu.c | 5 - 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/hw/i386/amd_iommu

Re: [Qemu-devel] [PATCH 00/34] remove i386/pc dependency from non-PC world (part 1)

Hi Michael, Thanks for your comments! >> hw: remove "qemu/osdep.h" from header files > not applied, doing two things, suggested split-up > (I'm fine with it as it is) split out MAINTAINERS entry >> i386/hax: remove duplicated includes > applied (note it can be trimmed more) done in

[Qemu-devel] [PATCH v2 02/39] MAINTAINERS: add entries for dma/i82374

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 6f56c1349b..cfd9010e27 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -713,6 +713,7 @@ F: hw/ppc/prep_systemio.c F: hw/ppc/rs6000_m

[Qemu-devel] [PATCH v2 00/39] remove i386/pc dependency from non-PC world (part 1)

035/39:[down] 'i386/pc: move vmport.c from hw/misc/ to hw/i386/' 036/39:[down] 'i386/pc: move pvpanic.c from hw/misc/ to hw/i386/' 037/39:[down] 'i386/pc: extract port92 from pc.c' 038/39:[down] 'hw/dma/i82374: avoid multiple creations on the same ISA bus' 039/39:[0006] [FC] 'hw/dma/i8257: rename DMA

[Qemu-devel] [PATCH v2 10/39] block: remove "qemu/osdep.h" from header file

applied using ./scripts/clean-includes Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> --- block/dmg.h | 1 - 1 file changed, 1 deletion(-) diff --git a/block/dmg.h b/block/dmg.h index b592d6fa8b..2ecf239ba5 100644 --- a

[Qemu-devel] [PATCH v2 03/39] MAINTAINERS: add an entry for the i82378 (superio)

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Reviewed-by: Hervé Poussineau <hpous...@reactos.org> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index cfd9010e27..0ce3c353e0 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -712,6

[Qemu-devel] [PATCH v2 15/39] i386/hax: remove duplicated include

this file in include in "target/i386/hax-i386.h": #ifdef CONFIG_WIN32 #include "target/i386/hax-windows.h" #endif which guaranty than sysemu/os-win32.h is previously included (CONFIG_WIN32) Suggested-by: Peter Maydell <peter.mayd...@linaro.org> Signed-off-

[Qemu-devel] [PATCH v2 07/39] MAINTAINERS: add missing entry for include/hw/net/

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Reviewed-by: Hervé Poussineau <hpous...@reactos.org> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 06ec24912e..ddaba2702c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -

[Qemu-devel] [PATCH v2 18/39] numa: remove unused #include

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> --- numa.c | 1 - 1 file changed, 1 deletion(-) diff --git a/numa.c b/numa.c index 100a67febf..ebc553b5d9 100644 --- a/numa.c +++ b/numa.c @@ -29,7 +29,6 @@ #include &q

[Qemu-devel] [PATCH v2 22/39] hw/ide: remove old i386 dependency

and remove a duplicated include Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Acked-by: John Snow <js...@redhat.com> --- hw/ide/ahci.c | 1 - hw/ide/cmd646.c | 1 - hw/ide/core.c | 3 +-- hw/ide/ich.c| 1 - hw/ide/isa.c| 1 - hw/ide/micr

[Qemu-devel] [PATCH v2 37/39] i386/pc: extract port92 from pc.c

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- include/hw/i386/pc.h | 3 +- hw/i386/pc.c | 126 ++ hw/i386/port92.c | 122 hw/i386/Makefile.objs | 2 +- 4 files c

[Qemu-devel] [PATCH v2 27/39] hw/unicore32: restrict hw addr defines to source file

and drop unused #includes Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Reviewed-by: Thomas Huth <th...@redhat.com> --- include/hw/unicore32/puv3.h | 10 -- hw/unicore32/puv3.c | 16 ++-- 2 files changed, 10 insertions(+), 16 deletions(-)

[Qemu-devel] [PATCH v2 39/39] hw/dma/i8257: rename DMA_init() to i8257_dma_init()

- move the header from hw/isa/ to hw/dma/ - remove the old i386/pc dependency Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- include/hw/{isa/i8257.h => dma/i8257_dma.h} | 6 ++ include/hw/isa/isa.h| 2 -- hw/dma/i82374.c

[Qemu-devel] [PATCH v2 30/39] hw/display/vga: remove the old i386/pc dependency

move public API to "hw/display/vga.h" and private registers to "hw/display/vga_int_regs.h" Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/display/vga_int.h | 3 ++- hw/display/{vga.h => vga_int_regs.h} | 0 include/hw/d

[Qemu-devel] [PATCH v2 33/39] hw/net/ne2000: extract ne2k-isa code from i386/pc to ne2000-isa.c

- add "hw/net/ne2000-isa.h" - remove the old i386 dependency Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Reviewed-by: Hervé Poussineau <hpous...@reactos.org> Acked-by: David Gibson <da...@gibson.dropbear.id.au> --- hw/net/ne2000.h |

Re: [Qemu-devel] [PATCH v2 33/39] hw/net/ne2000: extract ne2k-isa code from i386/pc to ne2000-isa.c

> hw/net/ne2000.h | 3 +++ > include/hw/net/ne2000-isa.h | 33 + I used "ne2000-isa.h" to match the source file, but the TYPE name is "ne2k-isa", I'm not sure we care which one is better. > hw/net/ne2000-isa.c | 6 ++ > hw/net/ne2000.c

[Qemu-devel] [PATCH v2 32/39] hw/timer/mc146818: rename rtc_init() -> mc146818_rtc_init()

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Reviewed-by: Hervé Poussineau <hpous...@reactos.org> Reviewed-by: David Gibson <da...@gibson.dropbear.id.au> --- include/hw/timer/mc146818rtc.h | 3 ++- hw/alpha/dp264.c | 2 +- hw/i386/pc.c

[Qemu-devel] [PATCH v2 35/39] i386/pc: move vmport.c from hw/misc/ to hw/i386/

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- default-configs/i386-softmmu.mak | 1 - default-configs/x86_64-softmmu.mak | 1 - hw/{misc => i386}/vmport.c | 0 hw/i386/Makefile.objs | 1 + hw/misc/Makefile.objs | 2 -- 5 files changed, 1

[Qemu-devel] [PATCH v2 25/39] hw/tpm: remove old i386 dependency

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Reviewed-by: Stefan Berger <stef...@linux.vnet.ibm.com> --- hw/tpm/tpm_passthrough.c | 1 - hw/tpm/tpm_tis.c | 1 - 2 files changed, 2 deletions(-) diff --git a/hw/tpm/tpm_passthrough.c b/hw/tpm/tpm_passthrough.c inde

[Qemu-devel] [PATCH v2 24/39] hw/i2c: remove old i386 dependency

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Reviewed-by: Thomas Huth <th...@redhat.com> --- hw/i2c/pm_smbus.c | 1 - hw/i2c/smbus_ich9.c | 1 - 2 files changed, 2 deletions(-) diff --git a/hw/i2c/pm_smbus.c b/hw/i2c/pm_smbus.c index 6fc3923f56..a044dd1b27 100644

[Qemu-devel] [PATCH v2 38/39] hw/dma/i82374: avoid multiple creations on the same ISA bus

$ ./ppc64-softmmu/qemu-system-ppc64 -S -machine 40p,accel=tcg -device i82374 qemu-system-ppc64: -device i82374: DMA already initialized on ISA bus Reported-by: Eduardo Otubo <ot...@redhat.com> Suggested-by: Eduardo Habkost <ehabk...@redhat.com> Signed-off-by: Philippe Mathi

[Qemu-devel] [PATCH v2 26/39] hw/virtio-balloon: remove old i386 dependency

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Reviewed-by: Thomas Huth <th...@redhat.com> --- hw/virtio/virtio-balloon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c index 37cde38982..14e08

[Qemu-devel] [PATCH v2 28/39] hw/acpi: ACPI_PM_* defines are not restricted to i386 arch

this allows to remove the old i386/pc dependency on acpi/core. Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- include/hw/acpi/acpi.h | 12 include/hw/i386/pc.h | 13 - hw/acpi/core.c | 1 - 3 files changed, 12 insertions(+), 14 deletions(-)

[Qemu-devel] [PATCH v2 31/39] hw/input/i8042: extract pckbd and vmmouse API from hw/i386/pc.h

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Reviewed-by: Hervé Poussineau <hpous...@reactos.org> Acked-by: David Gibson <da...@gibson.dropbear.id.au> --- include/hw/i386/pc.h | 11 --- include/hw/input/i8042.h | 30 ++

Re: [Qemu-devel] [PATCH 27/34] hw/pci: declare pci_nic_init_nofail() in "hw/net/pci.h"

Hi Marcel, >> It seems the patch is doing much more than >> what is mentioned in the subject. >> [...] >> Can you add a short explanation on how the split >> helps removing i386/pc dependency from non-PC world? >> - it is not straight forward, at least for me. > > I thought there was an old

[Qemu-devel] [PATCH v2 34/39] misc: drop old i386 dependency

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Reviewed-by: Thomas Huth <th...@redhat.com> --- hw/char/debugcon.c | 1 - hw/intc/lm32_pic.c | 1 - hw/moxie/moxiesim.c | 1 - hw/sparc/sun4m.c| 1 - hw/watchdog/wdt_ib700.c | 1 - 5 files changed, 5 deleti

[Qemu-devel] [PATCH v2 36/39] i386/pc: move pvpanic.c from hw/misc/ to hw/i386/

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- default-configs/i386-softmmu.mak | 1 - default-configs/x86_64-softmmu.mak | 1 - hw/{misc => i386}/pvpanic.c| 0 hw/i386/Makefile.objs | 2 +- hw/misc/Makefile.objs | 1 - 5 files changed, 1

Re: [Qemu-devel] [PATCH v2 3/3] io: use case insensitive check for Connection & Upgrade websock headers

Hi Daniel, On 09/08/2017 07:30 AM, Daniel P. Berrange wrote: When checking the value of the Connection and Upgrade HTTP headers the websock RFC (6455) requires the comparison to be case insensitive. The Connection value should be an exact match not a substring. Reviewed-by: Eric Blake

Re: [Qemu-devel] [PATCH v2 12/17] MAINTAINERS: add missing megasas test entry

ping? On 08/30/2017 06:55 PM, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index fa74b7254b..20d65dca73 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -

Re: [Qemu-devel] [PATCH v2 06/17] MAINTAINERS: add missing Guest Agent entries

ping? Michael, you told me this looks OK on IRC, can I respin with your Acked-by? On 08/30/2017 06:55 PM, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- MAINTAINERS | 4 1 file changed, 4 insertions(+) diff --git a/MAINTAINERS b/MAINT

Re: [Qemu-devel] [PATCH v3 1/3] io: send proper HTTP response for websocket errors

the client gives the wrong path, as a "404 Not Found" would be very helpful. Refactor the handshake code so that it always sends a response to the client unless there was an I/O error. Fixes bug: #1715186 Signed-off-by: Daniel P. Berrange <berra...@redhat.com> Reviewed-by: Philippe M

Re: [Qemu-devel] [PATCH] slirp: Add explanation for hostfwd parsing failure

yntax case the build with abort with -Werror=uninitialized Anyway: Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> p = redir_str; if (!p || get_str_sep(buf, sizeof(buf), , ':') < 0) { +fail_reason = "No : separators"; goto fail_syn

[Qemu-devel] [PATCH v3 12/15] MAINTAINERS: add missing entry for Generic Loader

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Reviewed-by: Alistair Francis <alistair.fran...@xilinx.com> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 98b7edc8b3..8024a3880b 100644 --- a/MAINTAINERS +++ b/MAINTAINER

[Qemu-devel] [PATCH v3 07/15] MAINTAINERS: add missing USB entry

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Reviewed-by: Thomas Huth <th...@redhat.com> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 39ac5d132a..04cc35cc3a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1004,6 +1004,

Re: [Qemu-devel] [PATCH] slirp: Add explanation for hostfwd parsing failure

On 09/08/2017 03:36 PM, Dr. David Alan Gilbert wrote: * Philippe Mathieu-Daudé (f4...@amsat.org) wrote: On 09/08/2017 01:22 PM, Dr. David Alan Gilbert wrote: * Philippe Mathieu-Daudé (f4...@amsat.org) wrote: Hi David, On 09/08/2017 12:53 PM, Dr. David Alan Gilbert (git) wrote: From: &qu

[Qemu-devel] [PATCH v3 02/15] MAINTAINERS: add missing STM32 entry

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Reviewed-by: Thomas Huth <th...@redhat.com> Reviewed-by: Alistair Francis <alist...@alistair23.me> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 35c8c9c752.

[Qemu-devel] [PATCH v3 01/15] MAINTAINERS: add missing ARM entries

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Reviewed-by: Thomas Huth <th...@redhat.com> --- MAINTAINERS | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 36eeb42d19..35c8c9c752 100644 --- a/MAINTAINERS +++ b

[Qemu-devel] [PATCH v3 14/15] MAINTAINERS: update docs/devel/ entries

moved in commit ac06724a7158 Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Reviewed-by: Eric Blake <ebl...@redhat.com> --- MAINTAINERS | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 53891bd36e..f8630

[Qemu-devel] [PATCH v3 09/15] MAINTAINERS: add missing SSI entries

Alistair Francis volunteered :) Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Reviewed-by: Alistair Francis <alistair.fran...@xilinx.com> --- MAINTAINERS | 3 +++ 1 file changed, 3 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 69ad3aac29..517c8

[Qemu-devel] [PATCH v3 15/15] MAINTAINERS: update docs/interop/ entries

moved in commit 7746cf8aab68 Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Acked-by: Fam Zheng <f...@redhat.com> Acked-by: John Snow <js...@redhat.com> --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINER

Re: [Qemu-devel] [PATCH v2 12/17] MAINTAINERS: add missing megasas test entry

suse.de>: Recipient address rejected: User unknown in local recipient table Last-Attempt-Date: Fri, 08 Sep 2017 06:04:54 -0700 (PDT) For now I'll just drop this patch. On 09/08/2017 10:04 AM, Philippe Mathieu-Daudé wrote: ping? On 08/30/2017 06:55 PM, Philippe Mathieu-Daudé wrote: Signed-of

[Qemu-devel] [PATCH v3 04/15] MAINTAINERS: add missing VMWare entry

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Reviewed-by: Thomas Huth <th...@redhat.com> Reviewed-by: Dmitry Fleytman <dmi...@daynix.com> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index afc0072a17..e0e5a8dc3f 100644

[Qemu-devel] [PATCH v3 10/15] MAINTAINERS: add missing entries for throttling infra

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> Reviewed-by: Alberto Garcia <be...@igalia.com> --- MAINTAINERS | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 517c

[Qemu-devel] [PATCH v3 06/15] MAINTAINERS: add missing qcow2 entry

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Acked-by: Kevin Wolf <kw...@redhat.com> Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index fa1620d8a8..39ac5d132a 100644

Re: [Qemu-devel] [PATCH] slirp: Add explanation for hostfwd parsing failure

On 09/08/2017 01:22 PM, Dr. David Alan Gilbert wrote: * Philippe Mathieu-Daudé (f4...@amsat.org) wrote: Hi David, On 09/08/2017 12:53 PM, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" <dgilb...@redhat.com> e.g. ./x86_64-softmmu/qemu-system-x86_64 -n

Re: [Qemu-devel] [PATCH v2 12/17] MAINTAINERS: add missing megasas test entry

Let's try another SUSE domain On 09/08/2017 02:12 PM, Philippe Mathieu-Daudé wrote: I wonder if "megasas" is still maintained, I got: To: Hannes Reinecke <h...@suse.de> Final-Recipient: rfc822; h...@suse.de Action: failed Status: 5.1.1 Remote-MTA: dns; mx2.suse.de. (195.135.22

[Qemu-devel] [PATCH v3 00/15] add missing entries in MAINTAINERS

entries (Thomas Huth) - moved files: comment since which commit (Eric Blake) - drop inconsistent patches (default-configs.mak related to hw/machine, no CPU) - drop unhappy patches (include/standard-headers/linux/*) - drop unreplied patches Philippe Mathieu-Daudé (15): MAINTAINERS: add missing ARM

[Qemu-devel] [PATCH v3 05/15] MAINTAINERS: add missing Guest Agent entries

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Acked-by: Michael Roth <mdr...@linux.vnet.ibm.com> --- MAINTAINERS | 4 1 file changed, 4 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index e0e5a8dc3f..fa1620d8a8 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -144

[Qemu-devel] [PATCH v3 08/15] MAINTAINERS: add missing PCI entries

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Reviewed-by: Marcel Apfelbaum <mar...@redhat.com> Acked-by: Michael S. Tsirkin <m...@redhat.com> --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 04cc35cc3a.

[Qemu-devel] [PATCH v3 03/15] MAINTAINERS: add missing entry for vhost

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Acked-by: Michael S. Tsirkin <m...@redhat.com> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index fb93e4b554..afc0072a17 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1029,6 +102

[Qemu-devel] [PATCH v3 11/15] MAINTAINERS: add missing AIO entry

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Acked-by: Fam Zheng <f...@redhat.com> Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 4e05831bda..98b7edc8b3 100644

[Qemu-devel] [PATCH v3 13/15] MAINTAINERS: add missing Cryptography entry

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Acked-by: Daniel P. Berrange <berra...@redhat.com> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 8024a3880b..53891bd36e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1540,6

Re: [Qemu-devel] [PATCH v6 04/12] tests: Add vm test lib

Hi Fam, Alex, If this fails it's fairly cryptic: /home/alex/lsrc/qemu/qemu.git/tests/vm/openbsd --debug --image "tests/vm/openbsd.img" --build-qemu /home/alex/lsrc/qemu/qemu.git DEBUG:root:Creating archive ./vm-test-fxejnB.tmp/data-2de24.tar for src_dir dir: /home/alex/lsrc/qemu/qemu.git

Re: [Qemu-devel] [PATCH v4 03/10] tests: Add vm test lib

On 08/28/2017 02:47 PM, Fam Zheng wrote: [...] +def __init__(self, debug=False, vcpus=None): +self._guest = None +self._tmpdir = tempfile.mkdtemp(prefix="qemu-vm-") +atexit.register(shutil.rmtree, self._tmpdir) + +self._ssh_key_file =

Re: [Qemu-devel] [PATCH 0/3] scripts: add argparse module for Python 2.6 compatibility

On 08/29/2017 07:01 AM, Stefan Hajnoczi wrote: On Fri, Aug 25, 2017 at 12:42:44PM -0500, Eric Blake wrote: On 08/25/2017 11:40 AM, Peter Maydell wrote: Our choices about our dependencies are generally driven by "what are the versions available on the oldest distros which we wish to support

Re: [Qemu-devel] [PATCH v2 3/7] block/sheepdog: remove spurious NULL check

On Wed, Aug 30, 2017 at 1:57 PM, Jeff Cody wrote: > 'tag' is already checked in the lines immediately preceding this check, > and set to non-NULL if NULL. No need to check again, it hasn't changed. > > Signed-off-by: Jeff Cody > --- > block/sheepdog.c | 2 +-

Re: [Qemu-devel] [PATCH 0/8] QOMify MIPS cpu

Hi James, On 08/30/2017 03:19 PM, James Hogan wrote: [...] git://github.com/philmd/qemu.git tags/mips-qomify-20170830 A sanity check of your branch doesn't reveal any obvious regressions when booting a Malta KVM guest kernel with KVM. Thank you for your time to test this! Does that

Re: [Qemu-devel] [PATCH 00/47] add missing entries in MAINTAINERS

Hi Markus, On 08/28/2017 08:28 AM, Markus Armbruster wrote: Where do we stand with this series? I was giving time to eventual adoptive maintainers until 2.11 opening :) Regards, Phil.

[Qemu-devel] [PATCH v2 4/7] mips: call cpu_mips_realize_env() from mips_cpu_realizefn()

Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Tested-by: Igor Mammedov <imamm...@redhat.com> Tested-by: James Hogan <james.ho...@imgtec.com> --- target/mips/cpu.c | 3 +++ target/mips/translate.c | 1 - 2 files changed, 3 insertions(+), 1 deletion(-) diff -

[Qemu-devel] [PATCH v2 1/7] mips: move hw/mips/cputimer.c to target/mips/

ry include. Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Tested-by: Igor Mammedov <imamm...@redhat.com> Tested-by: James Hogan <james.ho...@imgtec.com> --- hw/mips/cputimer.c => target/mips/cp0_timer.c | 1 - hw/mips/Makefile.objs |

<    12   13   14   15   16   17   18   19   20   21   >