Re: [PATCH 2/3] .gitlab-ci.d: Drop cross-win32-system job

2024-02-20 Thread Philippe Mathieu-Daudé
On 20/2/24 18:44, Peter Maydell wrote: We don't support 32-bit Windows any more, so we don't need to defend it with this CI job. Signed-off-by: Peter Maydell --- .gitlab-ci.d/container-cross.yml | 5 - .gitlab-ci.d/crossbuilds.yml | 14 --- .../dockerfiles/f

Re: [PATCH 3/3] .gitlab-ci.d/windows.yml: Remove shared-msys2 abstraction

2024-02-20 Thread Philippe Mathieu-Daudé
tmmu --without-default-devices -Ddebug=false -Doptimization=0 +# qTests don't run successfully with "--without-default-devices", +# so let's exclude the qtests from CI for now. +TEST_ARGS: --no-suite qtest artifacts: name: "$CI_JOB_NAME-$CI_COMMIT_REF_SLUG" expire_in: 7 days Reviewed-by: Philippe Mathieu-Daudé

Re: [RFC PATCH] linux-user: ensure nios2 processes queued work

2024-02-20 Thread Philippe Mathieu-Daudé
/cpu_loop.c @@ -32,6 +32,7 @@ void cpu_loop(CPUNios2State *env) cpu_exec_start(cs); trapnr = cpu_exec(cs); cpu_exec_end(cs); +process_queued_cpu_work(cs); We really should abstract that pattern for user emulation. Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH] vl, pc: turn -no-fd-bootchk into a machine property

2024-02-20 Thread Philippe Mathieu-Daudé
On 20/2/24 16:53, Paolo Bonzini wrote: Add a fd-bootchk property to PC machine types, so that -no-fd-bootchk returns an error if the machine does not support booting from floppies and checking for boot signatures therein. Suggested-by: Philippe Mathieu-Daudé Signed-off-by: Paolo Bonzini

Re: [PATCH 09/10] hw/core/machine: Use qemu_register_resettable for sysbus reset

2024-02-20 Thread Philippe Mathieu-Daudé
On 20/2/24 17:06, Peter Maydell wrote: Move the reset of the sysbus (and thus all devices and buses anywhere on the qbus tree) from qemu_register_reset() to qemu_register_resettable(). This is a behaviour change: because qemu_register_resettable() is aware of three-phase reset, this now means th

[RFC PATCH 1/2] target/alpha: Expose TMR and SMP IRQ lines via QDev

2024-02-20 Thread Philippe Mathieu-Daudé
In order to remove calls to cpu_interrupt() from hw/ code, expose the TMR and SMP interrupts via QDev as named GPIOs. Signed-off-by: Philippe Mathieu-Daudé --- target/alpha/cpu.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/target/alpha/cpu.c b/target

[RFC PATCH 2/2] hw/alpha/typhoon: Set CPU IRQs using QDev API

2024-02-20 Thread Philippe Mathieu-Daudé
Keep a reference of CPU IRQs in the TyphoonCchip state. Resolve them once in typhoon_init(), and access them with the qemu_irq API. Signed-off-by: Philippe Mathieu-Daudé --- hw/alpha/typhoon.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/hw/alpha/typhoon.c

[RFC PATCH 0/2] hw: Replace cpu_interrupt() calls by qemu_irq(QDev GPIO)

2024-02-20 Thread Philippe Mathieu-Daudé
27;d still target the same kind of target cpus. The Alpha Typhoon HW is unlikely to be used heterogeneously, but it is the simplest case I found to illustrate how I plan to remove cpu_interrupt() calls from hw/: use the QDev GPIO API. Does that sound good enough? Thanks, Phil. Philippe Mathie

Re: [PATCH 0/4] hw/nmi: Remove @cpu_index argument

2024-02-20 Thread Philippe Mathieu-Daudé
On 20/2/24 16:19, Thomas Huth wrote: On 20/02/2024 16.08, Philippe Mathieu-Daudé wrote: Have s390x always deliver NMI to the first CPU, remove the @cpu_index argument from handler, rename API as nmi_trigger() (not monitor specific). Could you please add some rationale here why this is needed

Re: [RFC 0/8] Introduce SMP Cache Topology

2024-02-20 Thread Philippe Mathieu-Daudé
+Igor On 20/2/24 10:24, Zhao Liu wrote: From: Zhao Liu Hi list, This's our proposal for supporting (SMP) cache topology in -smp as the following example: -smp 32,sockets=2,dies=2,modules=2,cores=2,threads=2,maxcpus=32,\ l1d-cache=core,l1i-cache=core,l2-cache=core,l3-cache=die With the

Re: [PATCH 01/10] hw/i386: Store pointers to IDE buses in PCMachineState

2024-02-21 Thread Philippe Mathieu-Daudé
Hi Peter, On 20/2/24 17:06, Peter Maydell wrote: Add the two IDE bus BusState pointers to the set we keep in PCMachineState. This allows us to avoid passing them to pc_cmos_init(), and also will allow a refactoring of how we call pc_cmos_init_late(). Signed-off-by: Peter Maydell --- include/

Re: [PATCH 2/9] hw/i386/pc_piix: Share pc_cmos_init() invocation between pc and isapc machines

2024-02-21 Thread Philippe Mathieu-Daudé
On 8/2/24 23:03, Bernhard Beschow wrote: Both invocations are the same and either one is always executed. Avoid this redundancy. Signed-off-by: Bernhard Beschow --- hw/i386/pc_piix.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v5 2/7] trans_rvv.c.inc: remove 'is_store' bool from load/store fns

2024-02-21 Thread Philippe Mathieu-Daudé
trans_rvv.c.inc | 69 - 1 file changed, 34 insertions(+), 35 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 06/14] hw/pci-bridge: Extract QOM ICH definitions to 'ich_dmi_pci.h'

2024-02-21 Thread Philippe Mathieu-Daudé
On 20/2/24 20:25, Bernhard Beschow wrote: Am 19. Februar 2024 16:38:46 UTC schrieb "Philippe Mathieu-Daudé" : Expose TYPE_ICH_DMI_PCI_BRIDGE to the new "hw/pci-bridge/ich_dmi_pci.h" header. Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS |

Re: [PATCH 06/10] hw/core: Add ResetContainer which holds objects implementing Resettable

2024-02-21 Thread Philippe Mathieu-Daudé
len; i++) { Worth a pair of trace events around the callback call. +cb(g_ptr_array_index(rc->children, i), opaque, type); +/* Detect callbacks trying to unregister themselves */ +assert(len == rc->children->len); + } +} Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 09/10] hw/core/machine: Use qemu_register_resettable for sysbus reset

2024-02-21 Thread Philippe Mathieu-Daudé
devices hanging off it (and all their child buses, recursively) * to be reset. Note that this will *not* reset any Device objects * which are not attached to some part of the qbus tree! */ -qemu_register_reset(resettable_cold_reset_fn, sysbus_get_default()); +qemu_regist

Re: [PATCH 3/9] hw/i386/x86: Turn apic_xrupt_override into class attribute

2024-02-21 Thread Philippe Mathieu-Daudé
hw/i386/acpi-common.c | 3 ++- hw/i386/pc.c | 5 ++--- 3 files changed, 6 insertions(+), 5 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 01/10] hw/i386: Store pointers to IDE buses in PCMachineState

2024-02-21 Thread Philippe Mathieu-Daudé
On 21/2/24 14:07, Philippe Mathieu-Daudé wrote: Hi Peter, On 20/2/24 17:06, Peter Maydell wrote: Add the two IDE bus BusState pointers to the set we keep in PCMachineState. This allows us to avoid passing them to pc_cmos_init(), and also will allow a refactoring of how we call

Re: [PATCH 9/9] hw/i386/pc_{piix, q35}: Eliminate local pci_bus/pci_host variables

2024-02-21 Thread Philippe Mathieu-Daudé
On 8/2/24 23:03, Bernhard Beschow wrote: There is no advantage in having these local variables which 1/ needlessly have different identifiers in both machines and 2/ which are redundant to pcms->bus which is almost as short. Signed-off-by: Bernhard Beschow --- hw/i386/pc_piix.c | 14 ++---

Re: [PATCH 02/10] hw/i386/pc: Do pc_cmos_init_late() from pc_machine_done()

2024-02-21 Thread Philippe Mathieu-Daudé
n just pass the PCMachineState pointer. Even if we remove the IDEBus/RTC pointers from PCMachineState, we can still QOM-resolve them from it in pc_cmos_init_late(). Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Peter Maydell --- hw/i386/pc.c | 39 -

Re: [PATCH 5/9] hw/i386/pc: Defer smbios_set_defaults() to machine_done

2024-02-21 Thread Philippe Mathieu-Daudé
boot_cpus, uint16_t apic_id_limit); -void fw_cfg_build_smbios(MachineState *ms, FWCfgState *fw_cfg); +void fw_cfg_build_smbios(PCMachineState *ms, FWCfgState *fw_cfg); s/ms/pcms/ Otherwise, nice cleanup: Reviewed-by: Philippe Mathieu-Daudé diff --git a/hw/i386

Re: [PATCH 6/9] hw/i386/pc: Confine system flash handling to pc_sysfw

2024-02-21 Thread Philippe Mathieu-Daudé
iles changed, 4 insertions(+), 6 deletions(-) Nice! Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 7/9] hw/i386/pc_sysfw: Inline pc_system_flash_create() and remove it

2024-02-21 Thread Philippe Mathieu-Daudé
15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 06/10] hw/core: Add ResetContainer which holds objects implementing Resettable

2024-02-21 Thread Philippe Mathieu-Daudé
On 21/2/24 17:09, Peter Maydell wrote: On Wed, 21 Feb 2024 at 15:34, Philippe Mathieu-Daudé wrote: On 20/2/24 17:06, Peter Maydell wrote: Implement a ResetContainer. This is a subclass of Object, and it implements the Resettable interface. The container holds a list of arbitrary other

Re: [PATCH 3/3] meson: Enable -Wvla

2024-02-21 Thread Philippe Mathieu-Daudé
ssage-ID: <20240125173211.1786196-3-peter.mayd...@linaro.org> [thuth: rebased to current master branch] Signed-off-by: Thomas Huth ---   meson.build | 1 +   1 file changed, 1 insertion(+) Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé diff --git a/meson.build b/

Re: [PATCH 3/3] meson: Enable -Wvla

2024-02-21 Thread Philippe Mathieu-Daudé
On 21/2/24 18:27, Philippe Mathieu-Daudé wrote: Clément, ResetData::entry isn't used, so we can simplify removing the whole ResetData structure, but I'm not sure this is intended: -- >8 -- diff --git a/hw/sparc/leon3.c b/hw/sparc/leon3.c index 4873b59b6c..1ff6b5d63d 100644 --- a/h

Re: [PATCH] vl, pc: turn -no-fd-bootchk into a machine property

2024-02-21 Thread Philippe Mathieu-Daudé
On 21/2/24 10:47, Bernhard Beschow wrote: Great! I'll rebase my PC initialization series on top of Peter's reset cleanup series which probably results in folding cmos initialization into pc.c. Don't, already done.

Re: [PATCH 4/5] hw/i386/pc: Inline i8042_setup_a20_line() and remove it

2024-02-21 Thread Philippe Mathieu-Daudé
On 18/2/24 14:17, Bernhard Beschow wrote: This function is used once in the pc machines. Remove it since it contains one line only. Now reminds me of https://lore.kernel.org/qemu-devel/20211218130437.1516929-6-f4...@amsat.org/ Signed-off-by: Bernhard Beschow --- include/hw/input/i8042.h

Re: [PATCH v4 2/3] hw/i2c/smbus_slave: Add object path on error prints

2024-02-21 Thread Philippe Mathieu-Daudé
VA_ARGS__); \ + } while (0) #endif enum { Better convert to trace events, so we can enable tracing at runtime. Anyhow, Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v2 3/7] hw/ide: Move IDE DMA related definitions to a separate header ide-dma.h

2024-02-21 Thread Philippe Mathieu-Daudé
truct IDEDMA { +const struct IDEDMAOps *ops; While here, let's use the typedef, otherwise: Reviewed-by: Philippe Mathieu-Daudé +QEMUIOVector qiov; +BlockAIOCB *aiocb; +};

Re: [PATCH v2 4/7] hw/ide: Move IDE device related definitions to ide-dev.h

2024-02-21 Thread Philippe Mathieu-Daudé
On 20/2/24 09:55, Thomas Huth wrote: Unentangle internal.h by moving public IDE device related Disentangle ... from? Untangle? TIL Unentangle. Anyway I'm not a native English speaker, so: Reviewed-by: Philippe Mathieu-Daudé definitions to ide-dev.h. Signed-off-by: Thomas

Re: [PATCH v2 5/7] hw/ide: Move IDE bus related definitions to a new header ide-bus.h

2024-02-21 Thread Philippe Mathieu-Daudé
- 2 files changed, 43 insertions(+), 39 deletions(-) create mode 100644 include/hw/ide/ide-bus.h Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH] hw/sparc/leon3: Fix wrong usage of DO_UPCAST macro

2024-02-21 Thread Philippe Mathieu-Daudé
| 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH] hw/sparc/leon3: Fix wrong usage of DO_UPCAST macro

2024-02-21 Thread Philippe Mathieu-Daudé
On 21/2/24 19:47, Philippe Mathieu-Daudé wrote: On 21/2/24 19:07, Thomas Huth wrote: leon3.c currently fails to compile with some compilers when the -Wvla option has been enabled:   ../hw/sparc/leon3.c: In function ‘leon3_cpu_reset’:   ../hw/sparc/leon3.c:153:5: error: ISO C90 forbids variable

Re: [PATCH v2 4/7] hw/ide: Move IDE device related definitions to ide-dev.h

2024-02-21 Thread Philippe Mathieu-Daudé
On 21/2/24 20:13, Thomas Huth wrote: On 21/02/2024 19.43, Philippe Mathieu-Daudé wrote: On 20/2/24 09:55, Thomas Huth wrote: Unentangle internal.h by moving public IDE device related Disentangle ... from? Untangle? TIL Unentangle. You're right, "disentangle" seems

Re: [PATCH] hw/cxl/cxl-mailbox-utils: remove unneeded mailbox output payload space zeroing

2024-02-21 Thread Philippe Mathieu-Daudé
Hi, On 21/2/24 19:53, nifan@gmail.com wrote: From: Fan Ni The whole mailbox output payload space is already zeroed after copying out the input payload, which happens before processing the specific mailbox command: https://elixir.bootlin.com/qemu/latest/source/hw/cxl/cxl-device-utils.c#L204

Re: [PATCH v3 0/4] hw/pci-host: Build ppc4xx_pci.c/ppc440_pcix.c once

2024-02-21 Thread Philippe Mathieu-Daudé
On 15/2/24 11:50, Philippe Mathieu-Daudé wrote: Philippe Mathieu-Daudé (4): hw/ppc/ppc4xx_pci: Remove unused "hw/ppc/ppc.h" header hw/ppc/ppc4xx_pci: Extract PCI host definitions to hw/pci-host/ppc4xx.h hw/ppc/ppc4xx_pci: Move ppc4xx_pci.c to hw/pci-host/ hw/ppc/p

[PULL 01/25] hw/input/pckbd: Open-code i8042_setup_a20_line() wrapper

2024-02-21 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé Since the named GPIO lines are a "public" interface to the device, we can directly call qdev_connect_gpio_out_named(), making it consistent with how the other A20 input source (port92) is wired. Suggested-by: Peter Maydell Signed-off-by: Philippe Mat

[PULL 07/25] hw/i2c/smbus_slave: Add object path on error prints

2024-02-21 Thread Philippe Mathieu-Daudé
From: Joe Komlodi The current logging doesn't tell us which specific smbus device is an error state. Signed-off-by: Joe Komlodi Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Message-ID: <20240202204847.2062798-3-koml...@google.com> Signed-off-by: Philippe Ma

[PULL 04/25] hw/ppc/ppc4xx_pci: Extract PCI host definitions to hw/pci-host/ppc4xx.h

2024-02-21 Thread Philippe Mathieu-Daudé
Reviewed-by: BALATON Zoltan Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20240215105017.57748-3-phi...@linaro.org> --- MAINTAINERS | 1 + include/hw/pci-host/ppc4xx.h | 17 + include/hw/ppc/ppc4xx.h | 5 -

[PULL 00/25] Misc HW patches for 2024-02-21

2024-02-21 Thread Philippe Mathieu-Daudé
a/meson.build: Sort alphabetically Joe Komlodi (1): hw/i2c/smbus_slave: Add object path on error prints Peter Maydell (2): hw/i386/pc: Store pointers to IDE buses in PCMachineState hw/i386/pc: Do pc_cmos_init_late() from pc_machine_done() Philippe Mathieu-Daudé (6): hw/input/pckbd: Op

[PULL 11/25] hw/i386/x86: Turn apic_xrupt_override into class attribute

2024-02-21 Thread Philippe Mathieu-Daudé
From: Bernhard Beschow The attribute isn't user-changeable and only true for pc-based machines. Turn it into a class attribute which allows for inlining pc_guest_info_init() into pc_machine_initfn(). Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé Messa

[PULL 03/25] hw/ppc/ppc4xx_pci: Remove unused "hw/ppc/ppc.h" header

2024-02-21 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: BALATON Zoltan Reviewed-by: Thomas Huth Message-Id: <20240215105017.57748-2-phi...@linaro.org> --- hw/ppc/ppc440_pcix.c | 1 - hw/ppc/ppc4xx_pci.c | 1 - 2 files changed, 2 deletions(-) diff --git a/hw/ppc/ppc440_pcix.c b/

[PULL 14/25] hw/i386/pc: Confine system flash handling to pc_sysfw

2024-02-21 Thread Philippe Mathieu-Daudé
ll to pc_system_flash_cleanup_unused() in the Xen case. Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé Message-ID: <20240208220349.4948-7-shen...@gmail.com> Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i386/pc.h | 2 -- hw/i386/pc.c | 1 - hw/i386/pc_piix.c| 1

[PULL 02/25] hw/sysbus: Inline and remove sysbus_add_io()

2024-02-21 Thread Philippe Mathieu-Daudé
: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Message-Id: <20240216150441.45681-1-phi...@linaro.org> --- include/hw/sysbus.h | 2 -- hw/core/sysbus.c| 6 -- hw/i386/kvmvapic.c | 2 +- hw/mips/mipssim.c | 2 +- hw/nvram/fw_cfg.c | 5 +++-- 5 files changed, 5 insertions(

[PULL 19/25] hw/ide: Split qdev.c into ide-bus.c and ide-dev.c

2024-02-21 Thread Philippe Mathieu-Daudé
From: Thomas Huth qdev.c is a mixture between IDE bus specific functions and IDE device functions. Let's split it up to make it more obvious which part is related to bus handling and which part is related to device handling. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth

[PULL 12/25] hw/i386/pc: Merge pc_guest_info_init() into pc_machine_initfn()

2024-02-21 Thread Philippe Mathieu-Daudé
From: Bernhard Beschow Resolves redundant code in the piix and q35 machines. Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé Message-ID: <20240208220349.4948-5-shen...@gmail.com> Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i386/pc.h | 2 -- hw/i38

[PULL 13/25] hw/i386/pc: Defer smbios_set_defaults() to machine_done

2024-02-21 Thread Philippe Mathieu-Daudé
: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé Message-ID: <20240208220349.4948-6-shen...@gmail.com> Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/fw_cfg.h | 3 ++- include/hw/i386/pc.h | 1 - hw/i386/fw_cfg.c | 12 +++- hw/i386/pc.c | 2 +- hw/i386/pc_

[PULL 10/25] hw/i386/pc: Do pc_cmos_init_late() from pc_machine_done()

2024-02-21 Thread Philippe Mathieu-Daudé
PCMachineState pointer. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Reviewed-by: Michael S. Tsirkin Reviewed-by: Philippe Mathieu-Daudé Message-ID: <20240220160622.114437-3-peter.mayd...@linaro.org> Signed-off-by: Philippe Mathieu-Daudé -

[PULL 23/25] hw/ide: Remove the include/hw/ide.h legacy file

2024-02-21 Thread Philippe Mathieu-Daudé
From: Thomas Huth There was only one prototype left in this legacy file. Move it to ide-dev.h to finally get rid of it. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth Acked-by: Mark Cave-Ayland Message-ID: <20240220085505.30255-7-th...@redhat.com> Signed-off-by: Ph

[PULL 15/25] hw/i386/pc_sysfw: Inline pc_system_flash_create() and remove it

2024-02-21 Thread Philippe Mathieu-Daudé
From: Bernhard Beschow pc_system_flash_create() checked for pcmc->pci_enabled which is redundant since its caller already checked it. The method can be turned into just two lines, so inline and remove it. Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé Message

[PULL 05/25] hw/ppc/ppc4xx_pci: Move ppc4xx_pci.c to hw/pci-host/

2024-02-21 Thread Philippe Mathieu-Daudé
ppc4xx_pci.c is moved from the target specific ppc_ss[] meson source set to pci_ss[] which is common to all targets: the object is built once. Declare PPC4XX_PCI selector in pci-host/Kconfig. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id: <20240215105017.57748-4-

[PULL 24/25] hw/ide: Stop exposing internal.h to non-IDE files

2024-02-21 Thread Philippe Mathieu-Daudé
-Daudé Signed-off-by: Thomas Huth Acked-by: Mark Cave-Ayland Message-ID: <20240220085505.30255-8-th...@redhat.com> Signed-off-by: Philippe Mathieu-Daudé --- include/hw/ide/pci.h | 2 +- hw/i386/pc.c | 2 +- hw/ide/cmd646.c | 1 + hw/ide/pci.c | 1 + hw/ide/piix.c

[PULL 09/25] hw/i386/pc: Store pointers to IDE buses in PCMachineState

2024-02-21 Thread Philippe Mathieu-Daudé
: Michael S. Tsirkin Reviewed-by: Philippe Mathieu-Daudé [PMD: Do not zero-init pcms->idebus[] again] Message-ID: <20240220160622.114437-2-peter.mayd...@linaro.org> Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i386/pc.h | 4 +++- hw/i386/pc.c | 5 ++--- hw/i386/pc_piix.

[PULL 16/25] hw/i386/pc_q35: Populate interrupt handlers before realizing LPC PCI function

2024-02-21 Thread Philippe Mathieu-Daudé
, i.e. MC146818RtcState::irq is NULL. Fixes: fc11ca08bc29 "hw/i386/q35: Realize LPC PCI function before accessing it" Cc: Philippe Mathieu-Daudé Signed-off-by: Bernhard Beschow Message-ID: <20240217104644.19755-1-shen...@gmail.com> Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/pc_q35.c |

[PULL 25/25] hw/sparc/leon3: Fix wrong usage of DO_UPCAST macro

2024-02-21 Thread Philippe Mathieu-Daudé
ned-off-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Message-ID: <20240221180751.190489-1-th...@redhat.com> Signed-off-by: Philippe Mathieu-Daudé --- hw/sparc/leon3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/sparc/leon3.c b/hw/sparc/leon3.c index 4873b5

[PULL 08/25] hw/i386/pc_piix: Share pc_cmos_init() invocation between pc and isapc machines

2024-02-21 Thread Philippe Mathieu-Daudé
From: Bernhard Beschow Both invocations are the same and either one is always executed. Avoid this redundancy. Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé Message-ID: <20240208220349.4948-3-shen...@gmail.com> Signed-off-by: Philippe Mathieu-Daudé --- h

[PULL 18/25] hw/ide: Add the possibility to disable the CompactFlash device in the build

2024-02-21 Thread Philippe Mathieu-Daudé
h can be used to collect definitions related to IDE devices. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth Acked-by: Mark Cave-Ayland Message-ID: <20240220085505.30255-2-th...@redhat.com> Signed-off-by: Philippe Mathieu-Daudé --- include/hw/ide/ide

[PULL 21/25] hw/ide: Move IDE device related definitions to ide-dev.h

2024-02-21 Thread Philippe Mathieu-Daudé
From: Thomas Huth Untangle internal.h by moving public IDE device related definitions to ide-dev.h. Signed-off-by: Thomas Huth Acked-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé Message-ID: <20240220085505.30255-5-th...@redhat.com> Signed-off-by: Philippe Mathieu

[PULL 22/25] hw/ide: Move IDE bus related definitions to a new header ide-bus.h

2024-02-21 Thread Philippe Mathieu-Daudé
From: Thomas Huth Let's consolidate the public IDE bus related functions in a separate header. Signed-off-by: Thomas Huth Acked-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé Message-ID: <20240220085505.30255-6-th...@redhat.com> Signed-off-by: Philippe Mathieu-Daudé -

[PULL 20/25] hw/ide: Move IDE DMA related definitions to a separate header ide-dma.h

2024-02-21 Thread Philippe Mathieu-Daudé
From: Thomas Huth These definitions are required outside of the hw/ide/ code, too, so lets's move them from internal.h to a new header called ide-dma.h. Signed-off-by: Thomas Huth Acked-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé Message-ID: <20240220085505.30

[PULL 17/25] hw/isa/meson.build: Sort alphabetically

2024-02-21 Thread Philippe Mathieu-Daudé
From: Bernhard Beschow Fixes: fbd758008f0f "hw/isa: extract FDC37M81X to a separate file" Signed-off-by: Bernhard Beschow Reviewed-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé Message-ID: <20240218131701.91132-2-shen...@gmail.com> Signed-off-by: Philippe Mathie

Re: [PATCH v2 0/3] hw/i386: Move SGX under KVM and use QDev API

2024-02-21 Thread Philippe Mathieu-Daudé
On 15/2/24 15:20, Philippe Mathieu-Daudé wrote: - Update MAINTAINERS - Move SGX files with KVM ones - Use QDev API Supersedes: <20240213071613.72566-1-phi...@linaro.org> Philippe Mathieu-Daudé (3): MAINTAINERS: Cover hw/i386/kvm/ in 'X86 KVM CPUs' section hw/i386: Move

[PULL 06/25] hw/ppc/ppc440_pcix: Move ppc440_pcix.c to hw/pci-host/

2024-02-21 Thread Philippe Mathieu-Daudé
ppc440_pcix.c is moved from the target specific ppc_ss[] meson source set to pci_ss[] which is common to all targets: the object is built once. Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20240215105017.57748-5-phi...@linaro.org> --- MAINT

Re: [PATCH] hw/sparc/leon3: Fix wrong usage of DO_UPCAST macro

2024-02-21 Thread Philippe Mathieu-Daudé
On 21/2/24 19:49, Philippe Mathieu-Daudé wrote: On 21/2/24 19:47, Philippe Mathieu-Daudé wrote: On 21/2/24 19:07, Thomas Huth wrote: leon3.c currently fails to compile with some compilers when the -Wvla option has been enabled:   ../hw/sparc/leon3.c: In function ‘leon3_cpu_reset’:   ../hw

Re: [PATCH] hw/intc/Kconfig: Fix GIC settings when using "--without-default-devices"

2024-02-21 Thread Philippe Mathieu-Daudé
On 21/2/24 12:00, Thomas Huth wrote: When using "--without-default-devices", the ARM_GICV3_TCG and ARM_GIC_KVM settings currently get disabled, though the arm virt machine is only of very limited use in that case. This also causes the migration-test to fail in such builds. Let's make sure that we

Re: [PATCH v6 5/9] target/riscv: remove 'cpu_vl' global

2024-02-21 Thread Philippe Mathieu-Daudé
_rvv.c.inc | 2 +- target/riscv/translate.c| 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) I was expecting this to be squashed in previous patch, but it is indeed clearer as a separate one. Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v6 4/9] target/riscv/translate.c: remove 'cpu_vstart' global

2024-02-22 Thread Philippe Mathieu-Daudé
On 21/2/24 22:31, Daniel Henrique Barboza wrote: The global is unused after recent changes. Signed-off-by: Daniel Henrique Barboza Reviewed-by: Richard Henderson --- target/riscv/translate.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v2 1/1] qga-win: Add support of Windows Server 2025 in get-osinfo command

2024-02-22 Thread Philippe Mathieu-Daudé
Hi Dehan, On 22/2/24 03:54, Dehan Meng wrote: Add support of Windows Server 2025 in get-osinfo command Signed-off-by: Dehan Meng --- qga/commands-win32.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qga/commands-win32.c b/qga/commands-win32.c index 697c65507c..b37fa

Re: [PATCH] hw/nvme: fix invalid endian conversion

2024-02-22 Thread Philippe Mathieu-Daudé
Hi Klaus, On 22/2/24 10:29, Klaus Jensen wrote: From: Klaus Jensen numcntl is one byte and so is max_vfs. Using cpu_to_le16 on big endian hosts results in numcntl being set to 0. Fix by dropping the endian conversion. Fixes: 746d42b13368 ("hw/nvme: Initialize capability structures for prima

Re: [PATCH 01/21] hw/i386/pc: Do not use C99 mixed-declarations style

2024-02-22 Thread Philippe Mathieu-Daudé
On 22/2/24 10:12, Zhao Liu wrote: Hi Philippe, On Fri, Feb 16, 2024 at 12:02:52PM +0100, Philippe Mathieu-Daudé wrote: Date: Fri, 16 Feb 2024 12:02:52 +0100 From: Philippe Mathieu-Daudé Subject: [PATCH 01/21] hw/i386/pc: Do not use C99 mixed-declarations style X-Mailer: git-send-email 2.41.0

Re: [PULL 00/25] Misc HW patches for 2024-02-21

2024-02-22 Thread Philippe Mathieu-Daudé
Hi, On 21/2/24 22:16, Philippe Mathieu-Daudé wrote: The following changes since commit 760b4dcdddba4a40b9fa0eb78fdfc7eda7cb83d0: Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging (2024-02-20 10:11:08 +) are available in the Git repository at:

Re: [PATCH] hw/sparc/leon3: Fix wrong usage of DO_UPCAST macro

2024-02-22 Thread Philippe Mathieu-Daudé
eb 22, 2024 at 8:46 AM Philippe Mathieu-Daudé wrote: On 21/2/24 19:49, Philippe Mathieu-Daudé wrote: On 21/2/24 19:47, Philippe Mathieu-Daudé wrote: On 21/2/24 19:07, Thomas Huth wrote: leon3.c currently fails to compile with some compilers when the -Wvla option has been enabled: ../hw/

Re: [PATCH v6 1/9] target/ppc: Use env_cpu for cpu_abort in excp_helper

2024-02-22 Thread Philippe Mathieu-Daudé
Bora --- target/ppc/excp_helper.c | 118 +-- 1 file changed, 63 insertions(+), 55 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v6 5/9] target/ppc: Simplify syscall exception handlers

2024-02-22 Thread Philippe Mathieu-Daudé
On 22/2/24 12:33, BALATON Zoltan wrote: After previous changes the hypercall handling in 7xx and 74xx exception handlers can be folded into one if statement to simpilfy "simplify" this code. Also add "unlikely" to mark the less freqiently used branch "frequently" for the compiler. Signed

Re: [PATCH] gitlab: force allow use of pip in Cirrus jobs

2024-02-22 Thread Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé

[PULL 02/32] hw/sysbus: Inline and remove sysbus_add_io()

2024-02-22 Thread Philippe Mathieu-Daudé
: Peter Maydell Message-Id: <20240216150441.45681-1-phi...@linaro.org> [PMD: Include missing "exec/address-spaces.h" header] Signed-off-by: Philippe Mathieu-Daudé --- include/hw/sysbus.h | 2 -- hw/core/sysbus.c| 6 -- hw/i386/kvmvapic.c | 3 ++- hw/mips/mipssim.c |

[PULL 09/32] hw/tricore/testboard: Use qdev_new() instead of QOM basic API

2024-02-22 Thread Philippe Mathieu-Daudé
Prefer QDev API for QDev objects, avoid the underlying QOM layer. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Bastian Koppelmann Message-Id: <20240216110313.17039-5-phi...@linaro.org> --- include/hw/tricore/tricore_testdevice.h | 3 --- hw/tricore/tricore_testboard.c

[PULL 08/32] hw/ppc/pnv_bmc: Use qdev_new() instead of QOM API

2024-02-22 Thread Philippe Mathieu-Daudé
Prefer QDev API for QDev objects, avoid the underlying QOM layer. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Message-Id: <20240216110313.17039-6-phi...@linaro.org> --- hw/ppc/pnv_bmc.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --gi

[PULL 32/32] hw/sparc/leon3: Fix wrong usage of DO_UPCAST macro

2024-02-22 Thread Philippe Mathieu-Daudé
ned-off-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Message-ID: <20240221180751.190489-1-th...@redhat.com> Tested-by: Clément Chigot Signed-off-by: Philippe Mathieu-Daudé --- hw/sparc/leon3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/sparc/leon3.c b/

[PULL 24/32] hw/acpi/ich9_tco: Include missing 'migration/vmstate.h' header

2024-02-22 Thread Philippe Mathieu-Daudé
We need the VMStateDescription structure definition from "migration/vmstate.h" in order to declare vmstate_tco_io_sts. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Zhao Liu Message-Id: <20240219141412.71418-4-phi...@linaro.org> --- include/hw/acpi/ich9_tco.h | 1 + 1

[PULL 07/32] hw/ppc/spapr_cpu: Use qdev_is_realized() instead of QOM API

2024-02-22 Thread Philippe Mathieu-Daudé
Prefer QDev API for QDev objects, avoid the underlying QOM layer. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Zhao Liu Message-Id: <20240216110313.17039-4-phi...@linaro.org> --- hw/ppc/spapr_cpu_core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/

[PULL 23/32] hw/acpi/cpu: Use CPUState typedef

2024-02-22 Thread Philippe Mathieu-Daudé
QEMU coding style recommend using structure typedefs: https://www.qemu.org/docs/master/devel/style.html#typedefs Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Zhao Liu Message-Id: <20240126220407.95022-2-phi...@linaro.org> --- include/hw/acpi/cpu

[PULL 19/32] hw/i386/pc_sysfw: Use qdev_is_realized() instead of QOM API

2024-02-22 Thread Philippe Mathieu-Daudé
Prefer QDev API for QDev objects, avoid the underlying QOM layer. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Zhao Liu Message-Id: <20240216110313.17039-3-phi...@linaro.org> --- hw/i386/pc_sysfw.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/h

[PULL 22/32] hw/acpi: Include missing 'qapi/qapi-types-acpi.h' generated header

2024-02-22 Thread Philippe Mathieu-Daudé
ospm_status(CPUHotplugState *cpu_st, ACPIOSTInfoList ***list); ^ include/hw/acpi/memory_hotplug.h:51:55: error: unknown type name 'ACPIOSTInfoList' void acpi_memory_ospm_status(MemHotplugState *mem_st, ACPIOSTInfoList ***list); ^ Si

[PULL v2 00/32] Misc HW patches for 2024-02-22

2024-02-22 Thread Philippe Mathieu-Daudé
hw/i386/pc: Do pc_cmos_init_late() from pc_machine_done() Philippe Mathieu-Daudé (13): hw/input/pckbd: Open-code i8042_setup_a20_line() wrapper hw/sysbus: Inline and remove sysbus_add_io() hw/ppc/ppc4xx_pci: Remove unused "hw/ppc/ppc.h" header hw/ppc/ppc4xx_pci: Extract PCI host

Re: [PATCH v2 3/3] .gitlab-ci.d/windows.yml: Remove shared-msys2 abstraction

2024-02-22 Thread Philippe Mathieu-Daudé
NGW_TARGET variable - document why we need to set MSYSTEM - restore comment text truncated in commit 11961d08fcbddf --- .gitlab-ci.d/windows.yml | 85 +++- 1 file changed, 41 insertions(+), 44 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 0/9] Simplify initialization of PC machines

2024-02-22 Thread Philippe Mathieu-Daudé
On 8/2/24 23:03, Bernhard Beschow wrote: The series aims to simplify the initialization process of all PC-based machines. It consists of streamlining redundant code, as well as consolidating the setup of system flash and generation of smbios data which are currently fairly distributed. These ch

Re: [PATCH v4 0/3] hw/i2c: smbus: Reset fixes

2024-02-22 Thread Philippe Mathieu-Daudé
Hi Joe, On 20/2/24 22:11, Joe Komlodi wrote: Changelog: This series adds some resets for SMBus and for the I2C core. Along with it, we make SMBus slave error printing a little more helpful. These reset issues were very infrequent, they would maybe occur in 1 out of hundreds of resets in our

Re: [PATCH V2 1/1] loongarch: Change the UEFI loading mode to loongarch

2024-02-22 Thread Philippe Mathieu-Daudé
e -bios CLI option? Thanks, Phil. Cc: Andrea Bolognani Cc: maob...@loongson.cn Cc: Philippe Mathieu-Daudé Cc: Song Gao Cc: zhaotian...@loongson.cn Signed-off-by: Xianglai Li Tested-by: Andrea Bolognani --- hw/loongarch/acpi-build.c | 29 +++

[PATCH v3 2/3] qga/commands-win32: Do not set matrix_lookup_t/win_10_0_t arrays size

2024-02-22 Thread Philippe Mathieu-Daudé
simplify maintenance when adding new entries to these arrays. Signed-off-by: Philippe Mathieu-Daudé --- qga/commands-win32.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/qga/commands-win32.c b/qga/commands-win32.c index 79b5a580c9..87ce6e2870 100644 --- a

[PATCH v3 1/3] qga/commands-win32: Declare const qualifier before type

2024-02-22 Thread Philippe Mathieu-Daudé
Most of the code base use the 'const' qualifier *before* the type being qualified. Use the same style to unify. Signed-off-by: Philippe Mathieu-Daudé --- qga/commands-win32.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/qga/commands-win

[PATCH v3 0/3] qga/commands-win32: Style cleanups before adding Windows Server 2025

2024-02-22 Thread Philippe Mathieu-Daudé
Respin of Dehan's v2 since I had the changes stashed. Supersedes: <20240222025437.58996-1-dem...@redhat.com> Dehan Meng (1): qga-win: Add support of Windows Server 2025 in get-osinfo command Philippe Mathieu-Daudé (2): qga/commands-win32: Declare const qualifier before type q

[PATCH v3 3/3] qga-win: Add support of Windows Server 2025 in get-osinfo command

2024-02-22 Thread Philippe Mathieu-Daudé
From: Dehan Meng Add support of Windows Server 2025 in get-osinfo command Signed-off-by: Dehan Meng Message-ID: <20240222025352.58859-2-dem...@redhat.com> Signed-off-by: Philippe Mathieu-Daudé --- qga/commands-win32.c | 1 + 1 file changed, 1 insertion(+) diff --git a/qga/commands-win

Re: [PATCH v3] virtio-pci: correctly set virtio pci queue mem multiplier

2024-02-22 Thread Philippe Mathieu-Daudé
Hi Srujana, On 23/2/24 06:26, Srujana Challa wrote: Currently, virtio_pci_queue_mem_mult function always returns 4K when VIRTIO_PCI_FLAG_PAGE_PER_VQ is set. But this won't work for vhost vdpa when host has page size other than 4K. This patch introduces a new property(host-page-per-vq) for vdpa u

Re: [PATCH V5 1/5] util: str_split

2024-02-22 Thread Philippe Mathieu-Daudé
/strList.h create mode 100644 util/strList.c Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH V5 1/5] util: str_split

2024-02-22 Thread Philippe Mathieu-Daudé
On 22/2/24 22:47, Steve Sistare wrote: Generalize hmp_split_at_comma() to take any delimiter string, rename as str_split(), and move it to util/strList.c. No functional change. Signed-off-by: Steve Sistare --- include/monitor/hmp.h | 1 - include/qemu/strList.h | 24 ++

Re: [PATCH v3 1/3] hw/i2c: Implement Broadcom Serial Controller (BSC)

2024-02-22 Thread Philippe Mathieu-Daudé
Hi Rayhan, On 20/2/24 14:41, Rayhan Faizel wrote: A few deficiencies in the current device model need to be noted. 1. FIFOs are not used. All sends and receives are done directly. 2. Repeated starts are not emulated. Repeated starts can be triggered in real hardware by sending a new read transf

Re: [PATCH v3 1/3] hw/i2c: Implement Broadcom Serial Controller (BSC)

2024-02-22 Thread Philippe Mathieu-Daudé
On 20/2/24 14:41, Rayhan Faizel wrote: A few deficiencies in the current device model need to be noted. 1. FIFOs are not used. All sends and receives are done directly. 2. Repeated starts are not emulated. Repeated starts can be triggered in real hardware by sending a new read transfer request i

Re: [PATCH v3 2/3] hw/arm: Connect BSC to BCM2835 board as I2C0, I2C1 and I2C2

2024-02-22 Thread Philippe Mathieu-Daudé
On 20/2/24 14:41, Rayhan Faizel wrote: BCM2835 has three I2C controllers. All of them share the same interrupt line. Signed-off-by: Rayhan Faizel --- hw/arm/Kconfig | 1 + hw/arm/bcm2835_peripherals.c | 32 +--- include/hw/arm/bcm2835_p

<    4   5   6   7   8   9   10   11   12   13   >