Re: [PATCH v2 19/19] tests/tcg: take into account expected clashes pauth-4

2020-02-14 Thread Robert Foley
On Thu, 13 Feb 2020 at 18:00, Alex Bennée wrote: > > Pointer authentication isn't perfect so measure the percentage of > failed checks. As we want to vary the pointer that is authenticated we > recurse down the stack. > > Signed-off-by: Alex Bennée Reviewed-by: Robert Foley

Re: [PATCH v2 01/19] tests/tcg: include a skip runner for pauth3 with plugins

2020-02-14 Thread Robert Foley
On Thu, 13 Feb 2020 at 17:51, Alex Bennée wrote: > > If we have plugins enabled we still need to have built the test to be > able to run it. > > Signed-off-by: Alex Bennée Reviewed-by: Robert Foley

Re: [PATCH v2 14/19] target/riscv: progressively load the instruction during decode

2020-02-14 Thread Robert Foley
gt; This drops opcode from the ctx in favour if passing the appropriately > sized opcode down a few levels of the decode. > > Signed-off-by: Alex Bennée > Reviewed-by: Richard Henderson Reviewed-by: Robert Foley

[PATCH v2 07/14] tests/vm: Add configuration to basevm.py

2020-02-19 Thread Robert Foley
to vary on the VM being created or launched. This will for example allow for creating an aarch64 vm. Signed-off-by: Robert Foley --- tests/vm/basevm.py | 143 +++-- 1 file changed, 112 insertions(+), 31 deletions(-) diff --git a/tests/vm/basevm.py b/tests

[PATCH v2 01/14] tests/vm: use $(PYTHON) consistently

2020-02-19 Thread Robert Foley
Change Makefile.include to use $(PYTHON) so for vm-boot-ssh to be consistent with other cases like vm-build. Signed-off-by: Robert Foley Reviewed-by: Alex Bennée Reviewed-by: Peter Puhov --- tests/vm/Makefile.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/vm

Re: [PATCH v1 06/14] tests/vm: Add logging of console to file.

2020-02-10 Thread Robert Foley
On Fri, 7 Feb 2020 at 17:20, Robert Foley wrote: > > On Fri, 7 Feb 2020 at 12:12, Alex Bennée wrote: > > > + > > > +def join(self, timeout=None): > > > +"""Time to destroy the thread. > > > + Clear the event to stop

Re: [PATCH v3 00/10] tests/vm: Add support for aarch64 VMs

2020-03-11 Thread Robert Foley
On Wed, 11 Mar 2020 at 08:04, Alex Bennée wrote: > > > Robert Foley writes: > > > This is version 3 of the patch series to > > add support for aarch64 VMs in the vm-build infrastructure. > > - Ubuntu 18.04 aarch64 VM > > - CentOS 8 aarch64 VM > > >

[PATCH v4 02/10] tests/vm: Add configuration to basevm.py

2020-03-12 Thread Robert Foley
to vary on the VM being created or launched. This will for example allow for creating an aarch64 vm. Signed-off-by: Robert Foley --- tests/vm/basevm.py | 159 ++--- 1 file changed, 120 insertions(+), 39 deletions(-) diff --git a/tests/vm/basevm.py b/tests

[PATCH v4 06/10] tests/vm: allow wait_ssh() to specify command

2020-03-12 Thread Robert Foley
This allows for waiting for completion of arbitrary commands. Signed-off-by: Robert Foley --- tests/vm/basevm.py | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py index 3562a33ffa..305b839000 100644 --- a/tests/vm

[PATCH v4 09/10] tests/vm: change scripts to use self._config

2020-03-12 Thread Robert Foley
This change converts existing scripts to using for example self.ROOT_PASS, to self._config['root_pass']. We made similar changes for GUEST_USER, and GUEST_PASS. This allows us also to remove the change in basevm.py, which adds __getattr__ for backwards compatibility. Signed-off-by: Robert Foley

[PATCH v4 10/10] tests/vm: Add workaround to consume console

2020-03-12 Thread Robert Foley
characters to be consumed. We also add the option of logging the console to a file. Signed-off-by: Robert Foley --- python/qemu/console_socket.py | 162 ++ python/qemu/machine.py| 23 - tests/vm/Makefile.include | 4 + tests/vm/basevm.py| 24

[PATCH v4 05/10] tests/vm: Add ability to select QEMU from current build.

2020-03-12 Thread Robert Foley
Added a new special variable QEMU_LOCAL=1, which will indicate to take the QEMU binary from the current build. Signed-off-by: Robert Foley --- tests/vm/Makefile.include | 4 tests/vm/basevm.py| 28 2 files changed, 28 insertions(+), 4 deletions

[PATCH v4 01/10] tests/vm: Fix issues in gen_cloud_init_iso

2020-03-12 Thread Robert Foley
Fixed issue caused by dependencies on a later set of patches that have not been merged yet. Signed-off-by: Robert Foley --- tests/vm/basevm.py | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py index 8400b0e07f

[PATCH v4 03/10] tests/vm: Added configuration file support

2020-03-12 Thread Robert Foley
.yml. Signed-off-by: Robert Foley --- configure | 9 ++ tests/vm/Makefile.include | 6 tests/vm/basevm.py| 40 +++- tests/vm/conf_example_aarch64.yml | 51 +++ tests/vm/conf_example_x86.yml

[PATCH v4 07/10] tests/vm: Added a new script for ubuntu.aarch64.

2020-03-12 Thread Robert Foley
ubuntu.aarch64 provides a script to create an Ubuntu 18.04 VM. Another new file is also added aarch64vm.py, which is a module with common methods used by aarch64 VMs, such as how to create the flash images. Signed-off-by: Robert Foley --- configure | 16 ++ tests/vm

[PATCH v4 00/10] tests/vm: Add support for aarch64 VMs

2020-03-12 Thread Robert Foley
into Makefile.include. - Corrected a dependency on a later patch in gen_cloud_init_iso(). - Changed the consume console patch to make draining the console to a buffer optional. This fixes the acceptance test issue. Robert Foley (10): tests/vm: Fix issues in gen_cloud_init_iso tests/vm: Add configuration

[PATCH v4 08/10] tests/vm: Added a new script for centos.aarch64.

2020-03-12 Thread Robert Foley
centos.aarch64 creates a CentOS 8 image. Also added a new kickstart script used to build the centos.aarch64 image. Signed-off-by: Robert Foley --- tests/vm/Makefile.include| 3 +- tests/vm/centos-8-aarch64.ks | 51 tests/vm/centos.aarch64 | 226

[PATCH v4 04/10] tests/vm: add --boot-console switch

2020-03-12 Thread Robert Foley
Added ability to view console during boot via --boot-console switch to basevm.py. This helps debug issues that occur during the boot sequence. Also added a new special variable to vm-build: BOOT_CONSOLE=1 will cause this new --boot-console switch to be set. Signed-off-by: Robert Foley --- tests

[PATCH v3 06/10] tests/vm: allow wait_ssh() to specify command

2020-03-10 Thread Robert Foley
This allows for waiting for completion of arbitrary commands. Signed-off-by: Robert Foley --- tests/vm/basevm.py | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py index 3562a33ffa..305b839000 100644 --- a/tests/vm

[PATCH v3 01/10] tests/vm: Add validation of target

2020-03-10 Thread Robert Foley
This validation is now useful since some targets may not be valid if their dependencies are not installed. Instead of allowing the scripts to fail with missing dependencies we will fail earlier with a helpful error message. Signed-off-by: Robert Foley --- tests/vm/Makefile.include | 16

[PATCH v3 09/10] tests/vm: change scripts to use self._config

2020-03-10 Thread Robert Foley
This change converts existing scripts to using for example self.ROOT_PASS, to self._config['root_pass']. We made similar changes for GUEST_USER, and GUEST_PASS. This allows us also to remove the change in basevm.py, which adds __getattr__ for backwards compatibility. Signed-off-by: Robert Foley

[PATCH v3 03/10] tests/vm: Added configuration file support

2020-03-10 Thread Robert Foley
.yml. Signed-off-by: Robert Foley --- configure | 9 ++ tests/vm/Makefile.include | 6 tests/vm/basevm.py| 40 +++- tests/vm/conf_example_aarch64.yml | 51 +++ tests/vm/conf_example_x86.yml

[PATCH v3 02/10] tests/vm: Add configuration to basevm.py

2020-03-10 Thread Robert Foley
to vary on the VM being created or launched. This will for example allow for creating an aarch64 vm. Signed-off-by: Robert Foley --- tests/vm/basevm.py | 143 +++-- 1 file changed, 112 insertions(+), 31 deletions(-) diff --git a/tests/vm/basevm.py b/tests

[PATCH v3 00/10] tests/vm: Add support for aarch64 VMs

2020-03-10 Thread Robert Foley
text for vm-help. - Moved the workaround for consuming the console to the end of the patch. - Added patch to validate the target of vm-build operations. Robert Foley (10): tests/vm: Add validation of target to Makefile.include tests/vm: Add configuration to basevm.py tests/vm: Added

[PATCH v3 07/10] tests/vm: Added a new script for ubuntu.aarch64.

2020-03-10 Thread Robert Foley
ubuntu.aarch64 provides a script to create an Ubuntu 18.04 VM. Another new file is also added aarch64vm.py, which is a module with common methods used by aarch64 VMs, such as how to create the flash images. Signed-off-by: Robert Foley --- configure | 16 ++ tests/vm

[PATCH v3 04/10] tests/vm: add --boot-console switch

2020-03-10 Thread Robert Foley
Added ability to view console during boot via --boot-console switch to basevm.py. This helps debug issues that occur during the boot sequence. Also added a new special variable to vm-build: BOOT_CONSOLE=1 will cause this new --boot-console switch to be set. Signed-off-by: Robert Foley --- tests

[PATCH v3 05/10] tests/vm: Add ability to select QEMU from current build.

2020-03-10 Thread Robert Foley
Added a new special variable QEMU_LOCAL=1, which will indicate to take the QEMU binary from the current build. Signed-off-by: Robert Foley --- tests/vm/Makefile.include | 4 tests/vm/basevm.py| 28 2 files changed, 28 insertions(+), 4 deletions

[PATCH v3 08/10] tests/vm: Added a new script for centos.aarch64.

2020-03-10 Thread Robert Foley
centos.aarch64 creates a CentOS 8 image. Also added a new kickstart script used to build the centos.aarch64 image. Signed-off-by: Robert Foley --- tests/vm/Makefile.include| 3 +- tests/vm/centos-8-aarch64.ks | 51 tests/vm/centos.aarch64 | 226

[PATCH v3 10/10] tests/vm: Add workaround to consume console

2020-03-10 Thread Robert Foley
characters to be consumed. We also add the option of logging the console to a file. Signed-off-by: Robert Foley --- python/qemu/console_socket.py | 162 ++ python/qemu/machine.py| 12 ++- tests/vm/Makefile.include | 4 + tests/vm/basevm.py| 23

[PATCH v8 07/74] cpu: make per-CPU locks an alias of the BQL in TCG rr mode

2020-03-26 Thread Robert Foley
ex_destroy, and call from cpu_common_finalize, to avoid destroying qemu_global_mutex, when cpu mutex is destroyed. Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota [RF: Fixed destroy issue, added cpu_mutex_destroy.] Signed-off-by: Robert Foley --- cpu

[PATCH v8 09/74] ppc: convert to helper_cpu_halted_set

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Cc: David Gibson Cc: qemu-...@nongnu.org Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Acked-by: David Gibson Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/ppc/translate.c | 6 ++ 1 file changed, 2 insertions(+), 4

[PATCH v8 41/74] i386/kvm: convert to cpu_interrupt_request

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/i386/kvm.c | 58 --- 1 file changed, 35 insertions(+), 23 deletions(-) diff --git a/t

[PATCH v8 24/74] mips: convert to cpu_halted

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota [RF: Converted code in target/mips/kvm.c to cpu_halted.] Signed-off-by: Robert Foley --- hw/mips/cps.c| 2 +- hw/misc/mips_itu.c | 4 ++-- target/mips/cp

[PATCH v8 14/74] microblaze: convert to helper_cpu_halted_set

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Cc: "Edgar E. Iglesias" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/microblaze/translate.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

[PATCH v8 35/74] exec: use cpu_reset_interrupt

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- exec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exec.c b/exec.c index de9d949902..a379016693 100644 --- a/ex

[PATCH v8 38/74] openrisc: use cpu_reset_interrupt

2020-03-26 Thread Robert Foley
From: Paolo Bonzini Cc: Stafford Horne Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Paolo Bonzini Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/openrisc/sys_helper.c | 2 +- 1 file changed, 1 insertion

[PATCH v8 46/74] sh4: convert to cpu_interrupt_request

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Cc: Aurelien Jarno Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/sh4/cpu.c| 2 +- target/sh4/helper.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/

[PATCH v8 49/74] lm32: convert to cpu_interrupt_request

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Cc: Michael Walle Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/lm32/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/lm32/cpu.c b/target/lm32/c

[PATCH v8 45/74] ppc: convert to cpu_interrupt_request

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Cc: David Gibson Cc: qemu-...@nongnu.org Reviewed-by: Richard Henderson Acked-by: David Gibson Signed-off-by: Emilio G. Cota [RF: Minor adjustment for new code in hvf_inject_interrupts] Signed-off-by: Robert Foley --- hw/ppc/ppc.c| 2

[PATCH v8 48/74] hppa: convert to cpu_interrupt_request

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/hppa/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/hppa/cpu.c b/target/hppa/cpu.c index

[PATCH v8 74/74] cputlb: queue async flush jobs without the BQL

2020-03-26 Thread Robert Foley
( +- 0.09% ) 7.389068145 seconds time elapsed ( +- 0.13% ) That is, a 1.37% slowdown. Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Tested-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- acc

[PATCH v8 16/74] tcg-runtime: convert to cpu_halted_set

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- accel/tcg/tcg-runtime.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/accel/tcg/tcg-runtime.c b/accel/tcg/tcg-runti

[PATCH v8 18/74] arm: convert to cpu_halted

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Cc: Andrzej Zaborowski Cc: Peter Maydell Cc: qemu-...@nongnu.org Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- hw/arm/omap1.c| 4 ++-- hw/arm/pxa2xx_gpio.c | 2

[PATCH v8 42/74] i386/hax-all: convert to cpu_interrupt_request

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota [RF: Converted new code to cpu_interrupt_request] Signed-off-by: Robert Foley --- target/i386/hax-all.c | 34 +++--- 1 file changed, 19 inserti

[PATCH v8 15/74] cpu: define cpu_halted helpers

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" cpu->halted will soon be protected by cpu->lock. We will use these helpers to ease the transition, since right now cpu->halted has many direct callers. Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-o

[PATCH v8 32/74] cpu: convert to cpu_halted

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" This finishes the conversion to cpu_halted. Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- accel/tcg/cpu-exec.c | 2 +- cpus.c | 4 ++-- hw/core/cpu.c

[PATCH v8 34/74] ppc: use cpu_reset_interrupt

2020-03-26 Thread Robert Foley
From: Paolo Bonzini Cc: David Gibson Cc: qemu-...@nongnu.org Acked-by: David Gibson Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Paolo Bonzini Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/ppc

[PATCH v8 71/74] cpu: protect CPU state with cpu->lock instead of the BQL

2020-03-26 Thread Robert Foley
up. Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota [RF: Adjusted assert and changed to use timed_wait] Signed-off-by: Robert Foley --- cpus.c| 288 +++--- hw/core/cpu.c | 29 + include/hw/core/cpu.h

[PATCH v8 60/74] accel/tcg: convert to cpu_interrupt_request

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- accel/tcg/cpu-exec.c | 15 --- accel/tcg/tcg-all.c | 12 +--- accel/tcg/translate-all.c | 2 +- 3 files c

[PATCH v8 31/74] cpu-exec: convert to cpu_halted

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- accel/tcg/cpu-exec.c | 25 + 1 file changed, 21 insertions(+), 4 deletions(-) diff --git a/accel/tcg/cpu-exec.c b

[PATCH v8 70/74] cpu: rename all_cpu_threads_idle to qemu_tcg_rr_all_cpu_threads_idle

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" This function is only called from TCG rr mode, so add a prefix to mark this as well as an assertion. Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- cpus.c | 10 ++ 1 file

[PATCH v8 59/74] microblaze: convert to cpu_interrupt_request

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Cc: "Edgar E. Iglesias" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/microblaze/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/micro

[PATCH v8 00/74] per-CPU locks

2020-03-26 Thread Robert Foley
e BQL cpus-common: release BQL earlier in run_on_cpu cpu: add async_run_on_cpu_no_bql cputlb: queue async flush jobs without the BQL Paolo Bonzini (4): ppc: use cpu_reset_interrupt i386: use cpu_reset_interrupt s390x: use cpu_reset_interrupt openrisc: use cpu_reset_interrupt Rob

[PATCH v8 20/74] sh4: convert to cpu_halted

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Cc: Aurelien Jarno Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/sh4/op_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/sh4/op_helper.c b/

[PATCH v8 17/74] hw/semihosting: convert to cpu_halted_set

2020-03-26 Thread Robert Foley
Signed-off-by: Robert Foley --- hw/semihosting/console.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/semihosting/console.c b/hw/semihosting/console.c index 6346bd7f50..f70085f3c1 100644 --- a/hw/semihosting/console.c +++ b/hw/semihosting/console.c @@ -131,7 +131,7

[PATCH v8 27/74] sparc: convert to cpu_halted

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Cc: Fabien Chouteau Cc: Mark Cave-Ayland Cc: Artyom Tarasenko Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Reviewed-by: Mark Cave-Ayland Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- hw/sparc/leon3.c | 2 +- hw/spa

[PATCH v8 65/74] mips: convert to cpu_has_work_with_iothread_lock

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Soon we will call cpu_has_work without the BQL. Cc: Aurelien Jarno Cc: Aleksandar Markovic Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/mips/cpu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletio

[PATCH v8 62/74] cpu: call .cpu_has_work with the CPU lock held

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- include/hw/core/cpu.h | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/include/hw/core/cpu.h b/include/hw/

[PATCH v8 50/74] m68k: convert to cpu_interrupt_request

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Cc: Laurent Vivier Reviewed-by: Richard Henderson Reviewed-by: Laurent Vivier Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/m68k/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/m68k/cpu.c b/target/

[PATCH v8 23/74] m68k: convert to cpu_halted

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Cc: Laurent Vivier Reviewed-by: Richard Henderson Reviewed-by: Laurent Vivier Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/m68k/op_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --gi

[PATCH v8 33/74] cpu: define cpu_interrupt_request helpers

2020-03-26 Thread Robert Foley
ock transition; once that is complete, cpu_interrupt_request will be simple again. Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- hw/core/cpu.c | 27 +-- include/hw/core/cpu.h | 37

[PATCH v8 61/74] cpu: convert to interrupt_request

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" This finishes the conversion to interrupt_request. Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- hw/core/cpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v8 36/74] i386: use cpu_reset_interrupt

2020-03-26 Thread Robert Foley
From: Paolo Bonzini Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Paolo Bonzini Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/i386/hax-all.c| 4 ++-- target/i386/hvf/x86hvf.c | 8 target/i386/kvm.c| 14

[PATCH v8 51/74] mips: convert to cpu_interrupt_request

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Cc: Aurelien Jarno Cc: Aleksandar Markovic Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/mips/cpu.c | 7 --- target/mips/kvm.c | 2 +- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/t

[PATCH v8 63/74] cpu: introduce cpu_has_work_with_iothread_lock

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" It will gain some users soon. Suggested-by: Paolo Bonzini Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- include/hw/core/cpu.h | 37 ++--- 1 file c

[PATCH v8 55/74] moxie: convert to cpu_interrupt_request

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Cc: Anthony Green Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/moxie/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/moxie/cpu.c b/target/m

[PATCH v8 47/74] cris: convert to cpu_interrupt_request

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Cc: "Edgar E. Iglesias" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/cris/cpu.c| 2 +- target/cris/helper.c | 4 ++-- 2 files changed, 3 insertions(+), 3 dele

[PATCH v8 06/74] cpu: introduce process_queued_cpu_work_locked

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" This completes the conversion to cpu_mutex_lock/unlock in the file. Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- cpus-common.c | 17 +++-- 1 file changed, 11 insert

[PATCH v8 08/74] tcg-runtime: define helper_cpu_halted_set

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- accel/tcg/tcg-runtime.c | 7 +++ accel/tcg/tcg-runtime.h | 2 ++ 2 files changed, 9 insertions(+) diff --git a/accel/tcg/tcg-runtime

[PATCH v8 05/74] cpu: move run_on_cpu to cpus-common

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" We don't pass a pointer to qemu_global_mutex anymore. Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- cpus-common.c | 2 +- cpus.c| 5 - include/hw/core/

[PATCH v8 54/74] alpha: convert to cpu_interrupt_request

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/alpha/cpu.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/alpha/cpu.c b/target/alpha/c

[PATCH v8 21/74] i386: convert to cpu_halted

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Cc: Eduardo Habkost Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota [RF: Converted new code in i386/hax-all.c to cpu_halted] Signed-off-by: Robert Foley --- target/i386/cpu.c | 2 +- target/i386/cpu.h

[PATCH v8 25/74] riscv: convert to cpu_halted

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Cc: Palmer Dabbelt Cc: Sagar Karandikar Cc: Bastian Koppelmann Cc: Alistair Francis Reviewed-by: Palmer Dabbelt Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/riscv/op_he

[PATCH v8 29/74] gdbstub: convert to cpu_halted

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- gdbstub.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 013fb1ac0f..d95c329

[PATCH v8 68/74] sparc: convert to cpu_has_work_with_iothread_lock

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Soon we will call cpu_has_work without the BQL. Cc: Mark Cave-Ayland Cc: Artyom Tarasenko Reviewed-by: Richard Henderson Acked-by: Mark Cave-Ayland Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/sparc/cpu.c | 4 +++- 1 file

[PATCH v8 67/74] riscv: convert to cpu_has_work_with_iothread_lock

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Soon we will call cpu_has_work without the BQL. Cc: Palmer Dabbelt Cc: Sagar Karandikar Cc: Bastian Koppelmann Reviewed-by: Palmer Dabbelt Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis Signed-off-by: Emilio G. Cota Signed-off-by: Ro

[PATCH v8 58/74] unicore32: convert to cpu_interrupt_request

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Cc: Guan Xuetao Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/unicore32/cpu.c | 2 +- target/unicore32/softmmu.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)

[PATCH v8 56/74] sparc: convert to cpu_interrupt_request

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Cc: Mark Cave-Ayland Cc: Artyom Tarasenko Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Reviewed-by: Mark Cave-Ayland Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- hw/sparc64/sparc64.c | 4 ++-- target/sparc/cpu.c | 2 +- 2 fil

[PATCH v8 66/74] s390x: convert to cpu_has_work_with_iothread_lock

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Soon we will call cpu_has_work without the BQL. Cc: Cornelia Huck Cc: David Hildenbrand Cc: qemu-s3...@nongnu.org Reviewed-by: Richard Henderson Reviewed-by: Cornelia Huck Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/s390x/cpu.c |

[PATCH v8 02/74] cpu: rename cpu->work_mutex to cpu->lock

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" This lock will soon protect more fields of the struct. Give it a more appropriate name. Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- cpus-common.c | 14 +++-

[PATCH v8 40/74] i386: convert to cpu_interrupt_request

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/i386/cpu.c| 2 +- target/i386/helper.c | 4 ++-- target/i386/svm_helper.c | 4 ++-- 3 files changed, 5 insertions(+), 5

[PATCH v8 52/74] nios: convert to cpu_interrupt_request

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Cc: Chris Wulff Cc: Marek Vasut Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/nios2/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/nios2/cpu.

[PATCH v8 37/74] s390x: use cpu_reset_interrupt

2020-03-26 Thread Robert Foley
From: Paolo Bonzini Cc: Cornelia Huck Cc: David Hildenbrand Cc: qemu-s3...@nongnu.org Reviewed-by: David Hildenbrand Reviewed-by: Richard Henderson Reviewed-by: Cornelia Huck Reviewed-by: Alex Bennée Signed-off-by: Paolo Bonzini Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley

[PATCH v8 28/74] xtensa: convert to cpu_halted

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Cc: Max Filippov Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/xtensa/cpu.c| 2 +- target/xtensa/exc_helper.c | 2 +- target/xtensa/helper.c | 2 +- 3 files

[PATCH v8 64/74] ppc: convert to cpu_has_work_with_iothread_lock

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Soon we will call cpu_has_work without the BQL. Cc: David Gibson Cc: qemu-...@nongnu.org Reviewed-by: Richard Henderson Acked-by: David Gibson Signed-off-by: Emilio G. Cota [RF: Converted new code related to POWER10] Signed-off-by: Robert Foley ---

[PATCH v8 53/74] s390x: convert to cpu_interrupt_request

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Cc: Cornelia Huck Cc: Christian Borntraeger Cc: David Hildenbrand Cc: qemu-s3...@nongnu.org Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Reviewed-by: Cornelia Huck Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- hw/intc/s390_

[PATCH v8 43/74] i386/whpx-all: convert to cpu_interrupt_request

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/i386/whpx-all.c | 41 - 1 file changed, 24 insertions(+), 17 deletions(-) diff --git a/target/i386/whpx-all.c b/target

[PATCH v8 39/74] arm: convert to cpu_interrupt_request

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Cc: Peter Maydell Cc: qemu-...@nongnu.org Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/arm/cpu.c | 6 +++--- target/arm/helper.c | 16 +++- target/arm/mach

[PATCH v8 73/74] cpu: add async_run_on_cpu_no_bql

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Some async jobs do not need the BQL. Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- cpus-common.c | 39 ++- include/hw/core/cpu.h | 14 +++

[PATCH v8 04/74] cpu: make qemu_work_cond per-cpu

2020-03-26 Thread Robert Foley
f-by: Emilio G. Cota Signed-off-by: Robert Foley --- cpus-common.c | 72 ++- cpus.c| 2 +- hw/core/cpu.c | 1 + include/hw/core/cpu.h | 6 ++-- 4 files changed, 63 insertions(+), 18 deletions(-) diff --git a/cpus-comm

[PATCH v8 01/74] cpu: convert queued work to a QSIMPLEQ

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Instead of open-coding it. While at it, make sure that all accesses to the list are performed while holding the list's lock. Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- cpu

[PATCH v8 03/74] cpu: introduce cpu_mutex_lock/unlock

2020-03-26 Thread Robert Foley
Us are locked by the same thread, which explains why the bitmap is introduced here. Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- cpus.c| 48 +-- include/hw/core/cpu.h | 33 +++

[PATCH v8 22/74] lm32: convert to cpu_halted

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Cc: Michael Walle Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/lm32/op_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/lm32/op_helper.

[PATCH v8 11/74] hppa: convert to helper_cpu_halted_set

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/hppa/translate.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target/hppa/translate.c b/target/hppa/transla

[PATCH v8 10/74] cris: convert to helper_cpu_halted_set

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" And fix the temp leak along the way. Cc: "Edgar E. Iglesias" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/cris/translate.c | 5 +++-- 1 file changed, 3 insert

[PATCH v8 19/74] ppc: convert to cpu_halted

2020-03-26 Thread Robert Foley
already held) from cpu_has_work. Cc: David Gibson Cc: qemu-...@nongnu.org Reviewed-by: Richard Henderson Acked-by: David Gibson Signed-off-by: Emilio G. Cota [RF: hw/ppc/spapr_hcall.c, spapr_rtas.c more conversions] Signed-off-by: Robert Foley --- hw/ppc/e500.c | 4

[PATCH v8 12/74] m68k: convert to helper_cpu_halted_set

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Cc: Laurent Vivier Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Reviewed-by: Laurent Vivier Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/m68k/translate.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-)

[PATCH v8 13/74] alpha: convert to helper_cpu_halted_set

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/alpha/translate.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/target/alpha/translate.c b/target/alpha/t

[PATCH v8 44/74] i386/hvf: convert to cpu_request_interrupt

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/i386/hvf/hvf.c| 8 +--- target/i386/hvf/x86hvf.c | 26 +++--- 2 files changed, 20 insertions(+), 14 deletions(-) diff --git a/t

[PATCH v8 69/74] xtensa: convert to cpu_has_work_with_iothread_lock

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Soon we will call cpu_has_work without the BQL. Cc: Max Filippov Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/xtensa/cpu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tar

<    1   2   3   4   5   6   >