[PATCH v8 26/74] s390x: convert to cpu_halted

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Cc: Cornelia Huck Cc: Christian Borntraeger Cc: David Hildenbrand Cc: qemu-s3...@nongnu.org Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Reviewed-by: Cornelia Huck Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- hw/intc/s

[PATCH v8 30/74] openrisc: convert to cpu_halted

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Cc: Stafford Horne Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/openrisc/sys_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/openrisc/sys_

[PATCH v8 57/74] openrisc: convert to cpu_interrupt_request

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" Cc: Stafford Horne Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- hw/openrisc/cputimer.c | 2 +- target/openrisc/cpu.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff

[PATCH v8 72/74] cpus-common: release BQL earlier in run_on_cpu

2020-03-26 Thread Robert Foley
From: "Emilio G. Cota" After completing the conversion to per-CPU locks, there is no need to release the BQL after having called cpu_kick. Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- cpus-com

Re: [PATCH v8 00/74] per-CPU locks

2020-03-27 Thread Robert Foley
:30:43 -0400, Robert Foley wrote: > > This is a continuation of the series created by Emilio Cota. > > We are picking up this patch set with the goal to apply > > any fixes or updates needed to get this accepted. > > Thanks for picking this up! > > > Listed below

Re: [PATCH v8 00/74] per-CPU locks

2020-03-27 Thread Robert Foley
On Fri, 27 Mar 2020 at 06:24, Aleksandar Markovic wrote: > >> >> > >> >> This is a continuation of the series created by Emilio Cota. > >> >> We are picking up this patch set with the goal to apply > >> >> any fixes or updates needed to get this accepted. > >> >> > >> > > >> > Thank for this

[PATCH v5 0/9] tests/vm: Add support for aarch64 VMs

2020-04-30 Thread Robert Foley
uot; - Fix issue in CentOS aarch64 VM where python was not set up. Robert Foley (9): tests/vm: Add configuration to basevm.py tests/vm: Added configuration file support tests/vm: add --boot-console switch tests/vm: Add ability to select QEMU from current build. tests/vm: allow wait_ssh()

[PATCH v5 5/9] tests/vm: allow wait_ssh() to specify command

2020-04-30 Thread Robert Foley
This allows for waiting for completion of arbitrary commands. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov --- tests/vm/basevm.py | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py index 7b86ccd018..9f06f84974

[PATCH v5 6/9] tests/vm: Added a new script for ubuntu.aarch64.

2020-04-30 Thread Robert Foley
ubuntu.aarch64 provides a script to create an Ubuntu 20.04 VM. Another new file is also added aarch64vm.py, which is a module with common methods used by aarch64 VMs, such as how to create the flash images. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov --- configure

[PATCH v5 3/9] tests/vm: add --boot-console switch

2020-04-30 Thread Robert Foley
Added ability to view console during boot via --boot-console switch to basevm.py. This helps debug issues that occur during the boot sequence. Also added a new special variable to vm-build: BOOT_CONSOLE=1 will cause this new --boot-console switch to be set. Signed-off-by: Robert Foley Reviewed

[PATCH v5 4/9] tests/vm: Add ability to select QEMU from current build.

2020-04-30 Thread Robert Foley
Added a new special variable QEMU_LOCAL=1, which will indicate to take the QEMU binary from the current build. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov --- tests/vm/Makefile.include | 4 tests/vm/basevm.py| 30 +- 2 files changed, 29

[PATCH v5 1/9] tests/vm: Add configuration to basevm.py

2020-04-30 Thread Robert Foley
to vary on the VM being created or launched. This will for example allow for creating an aarch64 vm. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov --- tests/vm/basevm.py | 170 ++--- 1 file changed, 131 insertions(+), 39 deletions(-) diff --git

[PATCH v5 8/9] tests/vm: change scripts to use self._config

2020-04-30 Thread Robert Foley
This change converts existing scripts to using for example self.ROOT_PASS, to self._config['root_pass']. We made similar changes for GUEST_USER, and GUEST_PASS. This allows us also to remove the change in basevm.py, which adds __getattr__ for backwards compatibility. Signed-off-by: Robert Foley

[PATCH v5 2/9] tests/vm: Added configuration file support

2020-04-30 Thread Robert Foley
.yml. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov --- configure | 9 ++ tests/vm/Makefile.include | 6 tests/vm/basevm.py| 40 +++- tests/vm/conf_example_aarch64.yml | 51 +++ tests

[PATCH v5 9/9] tests/vm: Add workaround to consume console

2020-04-30 Thread Robert Foley
characters to be consumed. We also add the option of logging the console to a file. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov --- python/qemu/console_socket.py | 162 ++ python/qemu/machine.py| 23 - tests/vm/Makefile.include | 4 + tests/vm

[PATCH v5 7/9] tests/vm: Added a new script for centos.aarch64.

2020-04-30 Thread Robert Foley
centos.aarch64 creates a CentOS 8 image. Also added a new kickstart script used to build the centos.aarch64 image. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov --- tests/vm/Makefile.include| 3 +- tests/vm/centos-8-aarch64.ks | 51 tests/vm/centos.aarch64 | 227

Re: [PATCH v4 04/10] tests/vm: add --boot-console switch

2020-05-11 Thread Robert Foley
On Mon, 11 May 2020 at 05:13, Alex Bennée wrote: > > > Robert Foley writes: > > > Added ability to view console during boot via > > --boot-console switch to basevm.py. This helps debug issues that occur > > during the boot sequence. > > Also adde

Re: [PATCH v4 00/10] tests/vm: Add support for aarch64 VMs

2020-05-11 Thread Robert Foley
On Mon, 11 May 2020 at 05:21, Alex Bennée wrote: > Robert Foley writes: > > > This is version 4 of the patch series to > > add support for aarch64 VMs in the vm-build infrastructure. > > - Ubuntu 18.04 aarch64 VM > > - CentOS 8 aarch64 VM > Hi Robert, > >

Re: [PATCH v8 25/74] riscv: convert to cpu_halted

2020-05-11 Thread Robert Foley
On Mon, 11 May 2020 at 06:40, Alex Bennée wrote: > Robert Foley writes: > > > From: "Emilio G. Cota" > > > > Cc: Palmer Dabbelt > > Cc: Sagar Karandikar > > Cc: Bastian Koppelmann > > Cc: Alistair Francis > > Reviewed-by: Palmer Dabb

Re: [PATCH v8 02/74] cpu: rename cpu->work_mutex to cpu->lock

2020-05-11 Thread Robert Foley
On Mon, 11 May 2020 at 10:48, Alex Bennée wrote: > Hmm while bisecting to find another problem I found this commit: > > /home/alex/lsrc/qemu.git/hw/core/cpu.c: In function ‘cpu_common_finalize’: > /home/alex/lsrc/qemu.git/hw/core/cpu.c:383:27: error: incompatible type for > argument 1 of

Re: [PATCH v8 03/74] cpu: introduce cpu_mutex_lock/unlock

2020-05-11 Thread Robert Foley
On Mon, 11 May 2020 at 06:24, Alex Bennée wrote: > Robert Foley writes: snip > > +/* XXX: is this really the max number of CPUs? */ > > +#define CPU_LOCK_BITMAP_SIZE 2048 > > I wonder if we should be asserting this somewhere? Given it's an init > time constant we can

Re: [PATCH v6 1/9] tests/vm: Add configuration to basevm.py

2020-05-15 Thread Robert Foley
On Fri, 15 May 2020 at 13:23, Alex Bennée wrote: > > > Robert Foley writes: > > > Added use of a configuration to tests/vm/basevm.py. > > The configuration provides parameters used to configure a VM. > > This allows for providing alternate configurations to the VM b

Re: [PATCH v1 0/2] some fixes for genisoimage usage

2020-05-15 Thread Robert Foley
On Fri, 15 May 2020 at 13:28, Alex Bennée wrote: > > Hi Robert, > > Here are a couple of patches you might want to add to the start of > your vm build series that deal with the fact genisoimage might not > exist or have a different name. Hi Alex, Sounds good. I will add them to the start of the

Re: [PATCH v6 6/9] tests/vm: Added a new script for ubuntu.aarch64.

2020-05-15 Thread Robert Foley
Hi Alex, These are all good points. I will make these changes. Thanks & Regards, -Rob On Fri, 15 May 2020 at 11:42, Alex Bennée wrote: > > > Robert Foley writes: > > > ubuntu.aarch64 provides a script to create an Ubuntu 18.04 VM. > > Another new file is al

Re: [PATCH v8 74/74] cputlb: queue async flush jobs without the BQL

2020-05-18 Thread Robert Foley
with the final two results (unix bench and boot times). Regards, -Rob On Tue, 12 May 2020 at 15:26, Robert Foley wrote: > > On Tue, 12 May 2020 at 12:27, Alex Bennée wrote: > > Robert Foley writes: > > > > > From: "Emilio G. Cota" > > > >

Re: [PATCH v8 74/74] cputlb: queue async flush jobs without the BQL

2020-05-12 Thread Robert Foley
On Tue, 12 May 2020 at 12:27, Alex Bennée wrote: > Robert Foley writes: > > > From: "Emilio G. Cota" > > > > This yields sizable scalability improvements, as the below results show. > > > > Host: Two Intel E5-2683 v3 14-core CPUs at 2.00 GHz

[PATCH v6 0/9] tests/vm: Add support for aarch64 VMs

2020-05-12 Thread Robert Foley
thinking about moving this under the DEBUG=1 option, but decided to remove this since we already have support for logging to a file, which can be used instead. - Went back to Ubuntu 18.04. Still working on 20.04 issues and will plan on a later patch to enable 20.04. Robert Foley (9): tests/vm

[PATCH v6 1/9] tests/vm: Add configuration to basevm.py

2020-05-12 Thread Robert Foley
to vary on the VM being created or launched. This will for example allow for creating an aarch64 vm. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov --- tests/vm/basevm.py | 170 ++--- 1 file changed, 131 insertions(+), 39 deletions(-) diff --git

[PATCH v6 2/9] tests/vm: Added configuration file support

2020-05-12 Thread Robert Foley
.yml. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov --- configure | 9 ++ tests/vm/Makefile.include | 6 tests/vm/basevm.py| 40 +++- tests/vm/conf_example_aarch64.yml | 51 +++ tests

[PATCH v6 4/9] tests/vm: Add ability to select QEMU from current build.

2020-05-12 Thread Robert Foley
Added a new special variable QEMU_LOCAL=1, which will indicate to take the QEMU binary from the current build. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov --- tests/vm/Makefile.include | 4 tests/vm/basevm.py| 31 ++- 2 files changed, 30

[PATCH v6 5/9] tests/vm: allow wait_ssh() to specify command

2020-05-12 Thread Robert Foley
This allows for waiting for completion of arbitrary commands. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov Reviewed-by: Alex Bennée --- tests/vm/basevm.py | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py index

[PATCH v6 6/9] tests/vm: Added a new script for ubuntu.aarch64.

2020-05-12 Thread Robert Foley
ubuntu.aarch64 provides a script to create an Ubuntu 18.04 VM. Another new file is also added aarch64vm.py, which is a module with common methods used by aarch64 VMs, such as how to create the flash images. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov --- configure

[PATCH v6 7/9] tests/vm: Added a new script for centos.aarch64.

2020-05-12 Thread Robert Foley
centos.aarch64 creates a CentOS 8 image. Also added a new kickstart script used to build the centos.aarch64 image. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov --- tests/vm/Makefile.include| 3 +- tests/vm/centos-8-aarch64.ks | 51 tests/vm/centos.aarch64 | 227

[PATCH v6 9/9] tests/vm: Add workaround to consume console

2020-05-12 Thread Robert Foley
characters to be consumed. We also add the option of logging the console to a file. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov --- python/qemu/console_socket.py | 162 ++ python/qemu/machine.py| 23 - tests/vm/Makefile.include | 4 + tests/vm

[PATCH v6 3/9] tests/vm: Pass --debug through for vm-boot-ssh.

2020-05-12 Thread Robert Foley
This helps debug issues that occur during the boot sequence. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov --- tests/vm/Makefile.include | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/vm/Makefile.include b/tests/vm/Makefile.include index 78a2de1f82..4e041103b7 100644

[PATCH v6 8/9] tests/vm: change scripts to use self._config

2020-05-12 Thread Robert Foley
This change converts existing scripts to using for example self.ROOT_PASS, to self._config['root_pass']. We made similar changes for GUEST_USER, and GUEST_PASS. This allows us also to remove the change in basevm.py, which adds __getattr__ for backwards compatibility. Signed-off-by: Robert Foley

Re: [PATCH v8 74/74] cputlb: queue async flush jobs without the BQL

2020-05-20 Thread Robert Foley
On Wed, 20 May 2020 at 00:46, Emilio G. Cota wrote: > > On Mon, May 18, 2020 at 09:46:36 -0400, Robert Foley wrote: > > Thanks for doing these tests. I know from experience that benchmarking > is hard and incredibly time consuming, so please do not be discouraged by > my com

[PATCH v7 03/12] tests/vm: pass args through to BaseVM's __init__

2020-05-19 Thread Robert Foley
Signed-off-by: Robert Foley --- tests/vm/basevm.py | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py index a2d4054d72..fbefda0595 100644 --- a/tests/vm/basevm.py +++ b/tests/vm/basevm.py @@ -61,9 +61,9 @@ class BaseVM(object

[PATCH v7 02/12] tests/vm: pass --genisoimage to basevm script

2020-05-19 Thread Robert Foley
-by: Robert Foley --- tests/vm/Makefile.include | 1 + tests/vm/basevm.py| 16 ++-- 2 files changed, 11 insertions(+), 6 deletions(-) diff --git a/tests/vm/Makefile.include b/tests/vm/Makefile.include index 1bf9693d19..74ab522c55 100644 --- a/tests/vm/Makefile.include +++ b/tests/vm

[PATCH v7 01/12] configure: add alternate binary for genisoimage

2020-05-19 Thread Robert Foley
From: Alex Bennée Not all distros ship genisoimage which is a Debian fork from the original cdrtools. As the options are pretty much the same support it as a fallback binary. Signed-off-by: Alex Bennée Signed-off-by: Robert Foley --- configure | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v7 00/12] tests/vm: Add support for aarch64 VMs

2020-05-19 Thread Robert Foley
for genisoimage. Alex Bennée (2): configure: add alternate binary for genisoimage tests/vm: pass --genisoimage to basevm script Robert Foley (10): tests/vm: pass args through to BaseVM's __init__ tests/vm: Add configuration to basevm.py tests/vm: Added configuration file support tests/vm

[PATCH v7 04/12] tests/vm: Add configuration to basevm.py

2020-05-19 Thread Robert Foley
to vary on the VM being created or launched. This will for example allow for creating an aarch64 vm. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov --- tests/vm/basevm.py | 170 ++--- 1 file changed, 131 insertions(+), 39 deletions(-) diff --git

[PATCH v7 10/12] tests/vm: Added a new script for centos.aarch64.

2020-05-19 Thread Robert Foley
centos.aarch64 creates a CentOS 8 image. Also added a new kickstart script used to build the centos.aarch64 image. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov --- tests/vm/Makefile.include| 3 +- tests/vm/centos-8-aarch64.ks | 51 tests/vm/centos.aarch64 | 227

[PATCH v7 07/12] tests/vm: Add ability to select QEMU from current build.

2020-05-19 Thread Robert Foley
Added a new special variable QEMU_LOCAL=1, which will indicate to take the QEMU binary from the current build. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov --- tests/vm/Makefile.include | 4 tests/vm/basevm.py| 25 ++--- 2 files changed, 26 insertions

[PATCH v7 12/12] tests/vm: Add workaround to consume console

2020-05-19 Thread Robert Foley
characters to be consumed. We also add the option of logging the console to a file. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov --- python/qemu/console_socket.py | 162 ++ python/qemu/machine.py| 23 - tests/vm/Makefile.include | 4 + tests/vm

[PATCH v7 11/12] tests/vm: change scripts to use self._config

2020-05-19 Thread Robert Foley
This change converts existing scripts to using for example self.ROOT_PASS, to self._config['root_pass']. We made similar changes for GUEST_USER, and GUEST_PASS. This allows us also to remove the change in basevm.py, which adds __getattr__ for backwards compatibility. Signed-off-by: Robert Foley

[PATCH v7 08/12] tests/vm: allow wait_ssh() to specify command

2020-05-19 Thread Robert Foley
This allows for waiting for completion of arbitrary commands. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov Reviewed-by: Alex Bennée --- tests/vm/basevm.py | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py index

[PATCH v7 05/12] tests/vm: Added configuration file support

2020-05-19 Thread Robert Foley
.yml. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov --- configure | 9 ++ tests/vm/Makefile.include | 6 tests/vm/basevm.py| 40 +++- tests/vm/conf_example_aarch64.yml | 51 +++ tests

[PATCH v7 09/12] tests/vm: Added a new script for ubuntu.aarch64.

2020-05-19 Thread Robert Foley
ubuntu.aarch64 provides a script to create an Ubuntu 18.04 VM. Another new file is also added aarch64vm.py, which is a module with common methods used by aarch64 VMs, such as how to create the flash images. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov --- configure

[PATCH v7 06/12] tests/vm: Pass --debug through for vm-boot-ssh.

2020-05-19 Thread Robert Foley
This helps debug issues that occur during the boot sequence. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov --- tests/vm/Makefile.include | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/vm/Makefile.include b/tests/vm/Makefile.include index d9b34eae63..e22c391a2a 100644

Re: [PATCH v7 03/12] tests/vm: pass args through to BaseVM's __init__

2020-05-22 Thread Robert Foley
On Wed, 20 May 2020 at 17:49, Alex Bennée wrote: > > > Robert Foley writes: > > A brief rationale wouldn't go amiss in the commit message. e.g. "We will > shortly need to pass more parameters to the class so lets just pass args > rather than growing the parameter list

[PATCH v9 12/74] m68k: convert to helper_cpu_halted_set

2020-05-21 Thread Robert Foley
From: "Emilio G. Cota" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Reviewed-by: Laurent Vivier Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/m68k/translate.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/t

[PATCH v9 09/74] ppc: convert to helper_cpu_halted_set

2020-05-21 Thread Robert Foley
From: "Emilio G. Cota" Cc: qemu-...@nongnu.org Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Acked-by: David Gibson Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/ppc/translate.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-)

[PATCH v9 19/74] ppc: convert to cpu_halted

2020-05-21 Thread Robert Foley
already held) from cpu_has_work. Cc: qemu-...@nongnu.org Reviewed-by: Richard Henderson Acked-by: David Gibson Signed-off-by: Emilio G. Cota [RF: hw/ppc/spapr_hcall.c, spapr_rtas.c more conversions] Signed-off-by: Robert Foley --- hw/ppc/e500.c | 4 ++-- hw/ppc/ppc.c

[PATCH v9 17/74] hw/semihosting: convert to cpu_halted_set

2020-05-21 Thread Robert Foley
Signed-off-by: Robert Foley Reviewed-by: Alex Bennée --- hw/semihosting/console.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/semihosting/console.c b/hw/semihosting/console.c index 6346bd7f50..f70085f3c1 100644 --- a/hw/semihosting/console.c +++ b/hw/semihosting

[PATCH v9 14/74] microblaze: convert to helper_cpu_halted_set

2020-05-21 Thread Robert Foley
From: "Emilio G. Cota" Cc: "Edgar E. Iglesias" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/microblaze/translate.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

[PATCH v9 54/74] alpha: convert to cpu_interrupt_request

2020-05-21 Thread Robert Foley
From: "Emilio G. Cota" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/alpha/cpu.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/alpha/cpu.c b/target/alpha/c

[PATCH v9 68/74] sparc: convert to cpu_has_work_with_iothread_lock

2020-05-21 Thread Robert Foley
From: "Emilio G. Cota" Soon we will call cpu_has_work without the BQL. Cc: Artyom Tarasenko Reviewed-by: Richard Henderson Acked-by: Mark Cave-Ayland Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/sparc/cpu.c | 4 +++- 1 file changed, 3 insertions(+),

[PATCH v9 48/74] hppa: convert to cpu_interrupt_request

2020-05-21 Thread Robert Foley
From: "Emilio G. Cota" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/hppa/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/hppa/cpu.c b/target/hppa/cpu.c index

[PATCH v9 55/74] moxie: convert to cpu_interrupt_request

2020-05-21 Thread Robert Foley
From: "Emilio G. Cota" Cc: Anthony Green Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/moxie/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/moxie/cpu.c b/target/m

[PATCH v9 69/74] xtensa: convert to cpu_has_work_with_iothread_lock

2020-05-21 Thread Robert Foley
From: "Emilio G. Cota" Soon we will call cpu_has_work without the BQL. Cc: Max Filippov Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/xtensa/cpu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tar

[PATCH v9 66/74] s390x: convert to cpu_has_work_with_iothread_lock

2020-05-21 Thread Robert Foley
From: "Emilio G. Cota" Soon we will call cpu_has_work without the BQL. Cc: David Hildenbrand Cc: qemu-s3...@nongnu.org Reviewed-by: Richard Henderson Reviewed-by: Cornelia Huck Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/s390x/cpu.c | 4 +++- 1 file

[PATCH v9 20/74] sh4: convert to cpu_halted

2020-05-21 Thread Robert Foley
From: "Emilio G. Cota" Cc: Aurelien Jarno Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/sh4/op_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/sh4/op_helper.c b/

[PATCH v9 13/74] alpha: convert to helper_cpu_halted_set

2020-05-21 Thread Robert Foley
From: "Emilio G. Cota" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/alpha/translate.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/target/alpha/translate.c b/target/alpha/t

[PATCH v9 21/74] i386: convert to cpu_halted

2020-05-21 Thread Robert Foley
From: "Emilio G. Cota" Cc: Eduardo Habkost Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota [RF: Converted new code in i386/hax-all.c to cpu_halted] Signed-off-by: Robert Foley --- target/i386/cpu.c | 2 +- target/i386/cpu.h

[PATCH v9 24/74] mips: convert to cpu_halted

2020-05-21 Thread Robert Foley
From: "Emilio G. Cota" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota [RF: Converted code in target/mips/kvm.c to cpu_halted.] Signed-off-by: Robert Foley --- hw/mips/cps.c| 2 +- hw/misc/mips_itu.c | 4 ++-- target/mips/cp

[PATCH v9 43/74] i386/whpx-all: convert to cpu_interrupt_request

2020-05-21 Thread Robert Foley
From: "Emilio G. Cota" Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/i386/whpx-all.c | 41 - 1 file changed, 24 insertions(+), 17 deletions(-) diff --git a/target/i386/whpx-all.c b/target

[PATCH v9 60/74] accel/tcg: convert to cpu_interrupt_request

2020-05-21 Thread Robert Foley
From: "Emilio G. Cota" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- accel/tcg/cpu-exec.c | 15 --- accel/tcg/tcg-all.c | 12 +--- accel/tcg/translate-all.c | 2 +- 3 files c

[PATCH v9 41/74] i386/kvm: convert to cpu_interrupt_request

2020-05-21 Thread Robert Foley
From: "Emilio G. Cota" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/i386/kvm.c | 58 --- 1 file changed, 35 insertions(+), 23 deletions(-) diff --git a/t

[PATCH v9 42/74] i386/hax-all: convert to cpu_interrupt_request

2020-05-21 Thread Robert Foley
From: "Emilio G. Cota" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota [RF: Converted new code to cpu_interrupt_request] Signed-off-by: Robert Foley --- target/i386/hax-all.c | 34 +++--- 1 file changed, 19 inserti

[PATCH v9 45/74] ppc: convert to cpu_interrupt_request

2020-05-21 Thread Robert Foley
From: "Emilio G. Cota" Cc: qemu-...@nongnu.org Reviewed-by: Richard Henderson Acked-by: David Gibson Signed-off-by: Emilio G. Cota [RF: Minor adjustment for new code in hvf_inject_interrupts] Signed-off-by: Robert Foley --- hw/ppc/ppc.c| 2 +- target/i386/hv

[PATCH v9 74/74] cputlb: queue async flush jobs without the BQL

2020-05-21 Thread Robert Foley
( +- 0.09% ) 7.389068145 seconds time elapsed ( +- 0.13% ) That is, a 1.37% slowdown. Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Tested-by: Alex Bennée Signed-off-by: Emilio G. Cota [Updated the speedup chart results for re-based series.] Signed-off-by: Robert Foley --- accel/tc

[PATCH v9 73/74] cpu: add async_run_on_cpu_no_bql

2020-05-21 Thread Robert Foley
From: "Emilio G. Cota" Some async jobs do not need the BQL. Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- cpus-common.c | 39 ++- include/hw/core/cpu.h | 14 +++

[PATCH v9 15/74] cpu: define cpu_halted helpers

2020-05-21 Thread Robert Foley
From: "Emilio G. Cota" cpu->halted will soon be protected by cpu->lock. We will use these helpers to ease the transition, since right now cpu->halted has many direct callers. Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-o

[PATCH v9 18/74] arm: convert to cpu_halted

2020-05-21 Thread Robert Foley
From: "Emilio G. Cota" Cc: Andrzej Zaborowski Cc: Peter Maydell Cc: qemu-...@nongnu.org Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- hw/arm/omap1.c| 4 ++-- hw/arm/pxa2xx_gpio.c | 2

[PATCH v9 26/74] s390x: convert to cpu_halted

2020-05-21 Thread Robert Foley
From: "Emilio G. Cota" Cc: Christian Borntraeger Cc: David Hildenbrand Cc: qemu-s3...@nongnu.org Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Reviewed-by: Cornelia Huck Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- hw/intc/s390_flic.c| 2

[PATCH v9 23/74] m68k: convert to cpu_halted

2020-05-21 Thread Robert Foley
From: "Emilio G. Cota" Reviewed-by: Richard Henderson Reviewed-by: Laurent Vivier Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/m68k/op_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/m68k/op_

[PATCH v9 30/74] openrisc: convert to cpu_halted

2020-05-21 Thread Robert Foley
From: "Emilio G. Cota" Cc: Stafford Horne Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/openrisc/sys_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/openrisc/sys_

[PATCH v9 49/74] lm32: convert to cpu_interrupt_request

2020-05-21 Thread Robert Foley
From: "Emilio G. Cota" Cc: Michael Walle Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/lm32/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/lm32/cpu.c b/target/lm32/c

[PATCH v9 65/74] mips: convert to cpu_has_work_with_iothread_lock

2020-05-21 Thread Robert Foley
From: "Emilio G. Cota" Soon we will call cpu_has_work without the BQL. Cc: Aurelien Jarno Cc: Aleksandar Markovic Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/mips/cpu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletio

[PATCH v9 34/74] ppc: use cpu_reset_interrupt

2020-05-21 Thread Robert Foley
From: Paolo Bonzini Cc: qemu-...@nongnu.org Acked-by: David Gibson Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Paolo Bonzini Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/ppc/excp_helper.c | 2 +- 1

[PATCH v9 25/74] riscv: convert to cpu_halted

2020-05-21 Thread Robert Foley
From: "Emilio G. Cota" Cc: Sagar Karandikar Cc: Bastian Koppelmann Reviewed-by: Palmer Dabbelt Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/riscv/op_helper.c | 2 +- 1 file changed, 1 inser

[PATCH v9 27/74] sparc: convert to cpu_halted

2020-05-21 Thread Robert Foley
From: "Emilio G. Cota" Cc: Fabien Chouteau Cc: Artyom Tarasenko Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Reviewed-by: Mark Cave-Ayland Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- hw/sparc/leon3.c | 2 +- hw/sparc/sun4m.c | 8

[PATCH v9 46/74] sh4: convert to cpu_interrupt_request

2020-05-21 Thread Robert Foley
From: "Emilio G. Cota" Cc: Aurelien Jarno Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/sh4/cpu.c| 2 +- target/sh4/helper.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/

[PATCH v9 64/74] ppc: convert to cpu_has_work_with_iothread_lock

2020-05-21 Thread Robert Foley
From: "Emilio G. Cota" Soon we will call cpu_has_work without the BQL. Cc: qemu-...@nongnu.org Reviewed-by: Richard Henderson Acked-by: David Gibson Signed-off-by: Emilio G. Cota [RF: Converted new code related to POWER10] Signed-off-by: Robert Foley --- target/ppc/translate_

[PATCH v9 52/74] nios: convert to cpu_interrupt_request

2020-05-21 Thread Robert Foley
From: "Emilio G. Cota" Cc: Chris Wulff Cc: Marek Vasut Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/nios2/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/nios2/cpu.

[PATCH v9 44/74] i386/hvf: convert to cpu_request_interrupt

2020-05-21 Thread Robert Foley
From: "Emilio G. Cota" Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/i386/hvf/hvf.c| 8 +--- target/i386/hvf/x86hvf.c | 26 +++--- 2 files changed, 20 insertions(+), 14 deletions(-) diff --git a/t

[PATCH v9 72/74] cpus-common: release BQL earlier in run_on_cpu

2020-05-21 Thread Robert Foley
From: "Emilio G. Cota" After completing the conversion to per-CPU locks, there is no need to release the BQL after having called cpu_kick. Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- cpus-com

[PATCH v9 29/74] gdbstub: convert to cpu_halted

2020-05-21 Thread Robert Foley
From: "Emilio G. Cota" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- gdbstub.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 6950fd243f..b25796b

[PATCH v9 36/74] i386: use cpu_reset_interrupt

2020-05-21 Thread Robert Foley
From: Paolo Bonzini Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Paolo Bonzini Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/i386/hax-all.c| 4 ++-- target/i386/hvf/x86hvf.c | 8 target/i386/kvm.c| 14

[PATCH v9 47/74] cris: convert to cpu_interrupt_request

2020-05-21 Thread Robert Foley
From: "Emilio G. Cota" Cc: "Edgar E. Iglesias" Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/cris/cpu.c| 2 +- target/cris/helper.c | 4 ++-- 2 files changed, 3 insertions(+), 3 dele

[PATCH v9 61/74] cpu: convert to interrupt_request

2020-05-21 Thread Robert Foley
From: "Emilio G. Cota" This finishes the conversion to interrupt_request. Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- hw/core/cpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v9 63/74] cpu: introduce cpu_has_work_with_iothread_lock

2020-05-21 Thread Robert Foley
From: "Emilio G. Cota" It will gain some users soon. Suggested-by: Paolo Bonzini Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- include/hw/core/cpu.h | 37 ++--- 1 file c

[PATCH v9 58/74] unicore32: convert to cpu_interrupt_request

2020-05-21 Thread Robert Foley
From: "Emilio G. Cota" Cc: Guan Xuetao Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- target/unicore32/cpu.c | 2 +- target/unicore32/softmmu.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)

[PATCH v9 07/74] cpu: make per-CPU locks an alias of the BQL in TCG rr mode

2020-05-21 Thread Robert Foley
ex_destroy, and call from cpu_common_finalize, to avoid destroying qemu_global_mutex, when cpu mutex is destroyed. Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota [RF: Fixed destroy issue, added cpu_mutex_destroy.] Signed-off-by: Robert Foley --- cpu

[PATCH v9 04/74] cpu: make qemu_work_cond per-cpu

2020-05-21 Thread Robert Foley
f-by: Emilio G. Cota Signed-off-by: Robert Foley --- cpus-common.c | 72 ++- cpus.c| 2 +- hw/core/cpu.c | 1 + include/hw/core/cpu.h | 6 ++-- 4 files changed, 63 insertions(+), 18 deletions(-) diff --git a/cpus-comm

[PATCH v9 03/74] cpu: introduce cpu_mutex_lock/unlock

2020-05-21 Thread Robert Foley
Us are locked by the same thread, which explains why the bitmap is introduced here. Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota [RF: Add assert in smp_parse. Make cpu_mutex_lock stub empty] Signed-off-by: Robert Foley --- cpus.c| 45 ++

[PATCH v9 05/74] cpu: move run_on_cpu to cpus-common

2020-05-21 Thread Robert Foley
From: "Emilio G. Cota" We don't pass a pointer to qemu_global_mutex anymore. Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- cpus-common.c | 2 +- cpus.c| 5 - include/hw/core/

[PATCH v9 32/74] cpu: convert to cpu_halted

2020-05-21 Thread Robert Foley
From: "Emilio G. Cota" This finishes the conversion to cpu_halted. Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- accel/tcg/cpu-exec.c | 2 +- cpus.c | 4 ++-- hw/core/cpu.c

[PATCH v9 33/74] cpu: define cpu_interrupt_request helpers

2020-05-21 Thread Robert Foley
ock transition; once that is complete, cpu_interrupt_request will be simple again. Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley --- hw/core/cpu.c | 27 +-- include/hw/core/cpu.h | 37

<    1   2   3   4   5   6   >