From: "Emilio G. Cota"
Cc: Max Filippov
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Emilio G. Cota
Signed-off-by: Robert Foley
---
target/xtensa/cpu.c| 2 +-
target/xtensa/exc_helper.c | 2 +-
target/xtensa/helper.c | 2 +-
3 files
From: Paolo Bonzini
Cc: Stafford Horne
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Paolo Bonzini
Signed-off-by: Emilio G. Cota
Signed-off-by: Robert Foley
---
target/openrisc/sys_helper.c | 2 +-
1 file changed, 1 insertion
up.
Reviewed-by: Alex Bennée
Reviewed-by: Richard Henderson
Signed-off-by: Emilio G. Cota
[RF: Adjusted assert and changed to use timed_wait]
Signed-off-by: Robert Foley
---
cpus.c| 288 +++---
hw/core/cpu.c | 29 +
include/hw/core/cpu.h
From: "Emilio G. Cota"
Cc: Aurelien Jarno
Cc: Aleksandar Markovic
Reviewed-by: Richard Henderson
Signed-off-by: Emilio G. Cota
Signed-off-by: Robert Foley
---
target/mips/cpu.c | 7 ---
target/mips/kvm.c | 2 +-
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/t
From: "Emilio G. Cota"
Cc: Christian Borntraeger
Cc: David Hildenbrand
Cc: qemu-s3...@nongnu.org
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Reviewed-by: Cornelia Huck
Signed-off-by: Emilio G. Cota
Signed-off-by: Robert Foley
---
hw/intc/s390_flic.c | 2 +-
target/s
From: "Emilio G. Cota"
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Emilio G. Cota
Signed-off-by: Robert Foley
---
exec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/exec.c b/exec.c
index 5162f0d12f..37e039de06 100644
--- a/ex
From: "Emilio G. Cota"
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Emilio G. Cota
Signed-off-by: Robert Foley
---
accel/tcg/tcg-runtime.c | 7 +++
accel/tcg/tcg-runtime.h | 2 ++
2 files changed, 9 insertions(+)
diff --git a/accel/tcg/tcg-runtime
From: "Emilio G. Cota"
And fix the temp leak along the way.
Cc: "Edgar E. Iglesias"
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Emilio G. Cota
Signed-off-by: Robert Foley
---
target/cris/translate.c | 5 +++--
1 file changed, 3 insert
From: "Emilio G. Cota"
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Emilio G. Cota
Signed-off-by: Robert Foley
---
accel/tcg/tcg-runtime.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/accel/tcg/tcg-runtime.c b/accel/tcg/tcg-runti
From: "Emilio G. Cota"
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Emilio G. Cota
Signed-off-by: Robert Foley
---
target/hppa/translate.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/target/hppa/translate.c b/target/hppa/transla
From: "Emilio G. Cota"
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Emilio G. Cota
Signed-off-by: Robert Foley
---
accel/tcg/cpu-exec.c | 25 +
1 file changed, 21 insertions(+), 4 deletions(-)
diff --git a/accel/tcg/cpu-exec.c b
From: "Emilio G. Cota"
Cc: Michael Walle
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Emilio G. Cota
Signed-off-by: Robert Foley
---
target/lm32/op_helper.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target/lm32/op_helper.
From: "Emilio G. Cota"
This function is only called from TCG rr mode, so add
a prefix to mark this as well as an assertion.
Reviewed-by: Alex Bennée
Reviewed-by: Richard Henderson
Signed-off-by: Emilio G. Cota
Signed-off-by: Robert Foley
---
cpus.c | 10 ++
1 file
From: "Emilio G. Cota"
Reviewed-by: Richard Henderson
Reviewed-by: Laurent Vivier
Signed-off-by: Emilio G. Cota
Signed-off-by: Robert Foley
---
target/m68k/cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/m68k/cpu.c b/target/m68k/cpu.c
index
From: "Emilio G. Cota"
Cc: Artyom Tarasenko
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Reviewed-by: Mark Cave-Ayland
Signed-off-by: Emilio G. Cota
Signed-off-by: Robert Foley
---
hw/sparc64/sparc64.c | 4 ++--
target/sparc/cpu.c | 2 +-
2 files changed, 3 insert
From: "Emilio G. Cota"
Cc: Stafford Horne
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Emilio G. Cota
Signed-off-by: Robert Foley
---
hw/openrisc/cputimer.c | 2 +-
target/openrisc/cpu.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff
From: "Emilio G. Cota"
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Emilio G. Cota
Signed-off-by: Robert Foley
---
include/hw/core/cpu.h | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/include/hw/core/cpu.h b/include/hw/
From: "Emilio G. Cota"
Soon we will call cpu_has_work without the BQL.
Cc: Sagar Karandikar
Cc: Bastian Koppelmann
Reviewed-by: Palmer Dabbelt
Reviewed-by: Richard Henderson
Reviewed-by: Alistair Francis
Signed-off-by: Emilio G. Cota
Signed-off-by: Robert Foley
---
target/r
t_interrupt
s390x: use cpu_reset_interrupt
openrisc: use cpu_reset_interrupt
Robert Foley (1):
hw/semihosting: convert to cpu_halted_set
accel/tcg/cpu-exec.c| 40 ++-
accel/tcg/cputlb.c | 10 +-
accel/tcg/tcg-all.c | 12 +-
accel/tcg/tcg-runtime.c
From: "Emilio G. Cota"
This lock will soon protect more fields of the struct. Give
it a more appropriate name.
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Emilio G. Cota
Signed-off-by: Robert Foley
---
cpus-common.c | 14 +++-
From: "Emilio G. Cota"
Instead of open-coding it.
While at it, make sure that all accesses to the list are
performed while holding the list's lock.
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Emilio G. Cota
Signed-off-by: Robert Foley
---
cpu
From: "Emilio G. Cota"
This completes the conversion to cpu_mutex_lock/unlock in the file.
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Emilio G. Cota
Signed-off-by: Robert Foley
---
cpus-common.c | 17 +++--
1 file changed, 11 insert
From: Paolo Bonzini
Cc: qemu-s3...@nongnu.org
Reviewed-by: David Hildenbrand
Reviewed-by: Richard Henderson
Reviewed-by: Cornelia Huck
Reviewed-by: Alex Bennée
Signed-off-by: Paolo Bonzini
Signed-off-by: Emilio G. Cota
Signed-off-by: Robert Foley
---
target/s390x/excp_helper.c | 2 +-
1
From: "Emilio G. Cota"
Cc: "Edgar E. Iglesias"
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Emilio G. Cota
Signed-off-by: Robert Foley
---
target/microblaze/cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/micro
From: "Emilio G. Cota"
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Emilio G. Cota
Signed-off-by: Robert Foley
---
target/i386/cpu.c| 2 +-
target/i386/helper.c | 4 ++--
target/i386/svm_helper.c | 4 ++--
3 files changed, 5 insertions(+), 5
From: "Emilio G. Cota"
Cc: Peter Maydell
Cc: qemu-...@nongnu.org
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Emilio G. Cota
Signed-off-by: Robert Foley
---
target/arm/cpu.c | 6 +++---
target/arm/helper.c | 16 +++-
target/arm/mach
On Sat, 22 Aug 2020 at 16:13, Philippe Mathieu-Daudé wrote:
>
> +Robert
>
> On 8/7/20 12:16 PM, Paolo Bonzini wrote:
> > On 07/08/20 12:02, Stefan Hajnoczi wrote:
> >> On Thu, Aug 06, 2020 at 05:07:26PM +0200, Philippe Mathieu-Daudé wrote:
> >>> Last uses of memory_region_clear_global_locking()
u-devel/2020-08/msg00044.html
Signed-off-by: Robert Foley
---
accel/tcg/cpu-exec.c| 2 --
target/alpha/cpu.c | 2 +-
target/alpha/cpu.h | 2 +-
target/alpha/helper.c | 9 -
target/arm/cpu.c| 2 +-
target/arm/cpu.h
g/archive/html/qemu-devel/2020-08/msg00784.html
https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg01517.html
https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg08731.html
https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00044.html
Signed-off-by: Robert Foley
---
accel/tcg/c
his approach.
https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00784.html
https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg01517.html
https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg08731.html
https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00044.html
Signed-off-by:
://lists.gnu.org/archive/html/qemu-devel/2020-08/msg01517.html
https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg08731.html
https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00044.html
Signed-off-by: Robert Foley
---
hw/ppc/spapr_events.c | 2 +-
target/alpha/cpu.c
-devel/2020-08/msg00784.html
https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg01517.html
https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg08731.html
https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00044.html
Signed-off-by: Robert Foley
---
target/alpha/cpu.c | 2
e need to consider? Are we missing anything here?
Signed-off-by: Robert Foley
---
accel/tcg/cpu-exec.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c
index e661635f06..499a8bdc5e 100644
--- a/accel/tcg/cpu-exec.c
+++ b/accel/t
his approach.
https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00784.html
https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg01517.html
https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg08731.html
https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00044.html
Signed-off-by:
evel/2020-07/msg08731.html
https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00044.html
This patch series is based on the per-CPU locks patch:
https://lists.gnu.org/archive/html/qemu-devel/2020-06/msg05314.html
Our most recent WIP tree is here:
https://github.com/rf972/qemu/tree/interrupts_
On Fri, 21 Aug 2020 at 06:56, Cornelia Huck wrote:
> >
> > As the first step in removing the BQL from this path, we will make
> > changes to the core/common functions of cpu_handle_interrupt/exception
> > to drop the holding of the BQL. The holding of the BQL is pushed down
> > to the per-arch
On Sat, 23 May 2020 at 16:06, Emilio G. Cota wrote:
>
> On Fri, May 22, 2020 at 12:07:49 -0400, Robert Foley wrote:
> > For example:
> > WARNING: ThreadSanitizer: data race (pid=35425)
> > Write of size 4 at 0x7bbc00ac by main thread (mutexes: write M875):
> >
On Sun, 24 May 2020 at 06:21, Philippe Mathieu-Daudé wrote:
>
> On 5/22/20 6:07 PM, Robert Foley wrote:
> > From: "Emilio G. Cota"
> >
> > Instead of open-coding it.
>
> Please use a full sentence (repeating the patch subject):
>
> "Conve
On Sat, 23 May 2020 at 13:18, Emilio G. Cota wrote:
>
> On Fri, May 22, 2020 at 23:36:18 +0100, Peter Maydell wrote:
> > So is this:
> > (a) a TSan false positive, because we've analysed the use
> > of this struct field and know it's not a race because
> > [details], but which we're
On Sat, 23 May 2020 at 17:36, Emilio G. Cota wrote:
>
> On Fri, May 22, 2020 at 12:07:36 -0400, Robert Foley wrote:
> > This patch series continues the work done by Emilio Cota and others to add
> > Thread Sanitizer (TSan) support to QEMU.
> >
> > The starting po
On Sat, 23 May 2020 at 16:12, Emilio G. Cota wrote:
>
> On Fri, May 22, 2020 at 12:07:50 -0400, Robert Foley wrote:
>
> > QSIMPLEQ_INSERT_TAIL(>bh_slice_list, , next);
> >
> > while ((s = QSIMPLEQ_FIRST(>bh_slice_list))) {
> > @@ -280,14 +
Hi Stefan,
On Tue, 26 May 2020 at 06:32, Stefan Hajnoczi wrote:
>
> On Fri, May 22, 2020 at 12:07:50PM -0400, Robert Foley wrote:
> > For example:
> > Atomic write of size 8 at 0x7b4800113c28 by main thread (mutexes: write
> > M30):
> > #0 __tsan_atomic64_
On Sat, 23 May 2020 at 12:55, Philippe Mathieu-Daudé wrote:
>
> Hi Robert,
>
> On 5/22/20 6:07 PM, Robert Foley wrote:
> > From: Lingfeng Yang
> >
> > We tried running QEMU under tsan in 2016, but tsan's lack of support for
> > longjmp-based fibers was
On Sat, 23 May 2020 at 13:27, Emilio G. Cota wrote:
>
> On Fri, May 22, 2020 at 12:07:48 -0400, Robert Foley wrote:
> > Initially put several files into blacklist that were
> > causing the most problems, namely bitops.c and bitmap.c.
> >
> > Signed-off-by: Robert
From: "Emilio G. Cota"
Signed-off-by: Emilio G. Cota
Signed-off-by: Robert Foley
---
include/qemu/thread.h | 39 ---
1 file changed, 36 insertions(+), 3 deletions(-)
diff --git a/include/qemu/thread.h b/include/qemu/thread.h
index e50a073889..
From: "Emilio G. Cota"
The radix tree is append-only, but we can fail to insert
a PageDesc if the insertion races with another thread.
Signed-off-by: Emilio G. Cota
Signed-off-by: Robert Foley
---
accel/tcg/translate-all.c | 9 +
1 file changed, 9 insertions(+)
diff --g
From: "Emilio G. Cota"
Signed-off-by: Robert Foley
---
util/qht.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/util/qht.c b/util/qht.c
index aa51be3c52..67e5d5b916 100644
--- a/util/qht.c
+++ b/util/qht.c
@@ -348,6 +348,7 @@ static inline void qht_chain_destroy(const struct
tcg: call qemu_spin_destroy for tb->jmp_lock
translate-all: call qemu_spin_destroy for PageDesc
thread: add tsan annotations to QemuSpin
Lingfeng Yang (1):
configure: add --enable-tsan flag + fiber annotations for
coroutine-ucontext
Robert Foley (4):
tests/docker: Added docker bu
Signed-off-by: Robert Foley
---
cpus-common.c | 25 -
cpus.c| 14 --
hw/core/cpu.c | 1 +
include/hw/core/cpu.h | 6 +++---
4 files changed, 24 insertions(+), 22 deletions(-)
diff --git a/cpus-common.c b/cpus-common.c
index 55d5df8923..
From: "Emilio G. Cota"
I was after adding qemu_spin_destroy calls, but while at
it I noticed that we are leaking some memory.
Signed-off-by: Emilio G. Cota
Signed-off-by: Robert Foley
---
accel/tcg/cputlb.c | 15 +++
exec.c | 1 +
include/exec/
These annotations will allow us to give tsan
additional hints. For example, we can inform
tsan about reads/writes to ignore to silence certain
classes of warnings.
We can also annotate threads so that the proper thread
naming shows up in tsan warning results.
Signed-off-by: Robert Foley
'
configure flags.
Signed-off-by: Lingfeng Yang
Signed-off-by: Emilio G. Cota
[cota: minor modifications + configure changes]
Signed-off-by: Robert Foley
[RF: Error out in configure if tsan not available, fix checkpatch warnings]
---
configure | 41 +
util/coroutine
This allows us to see the name of the thread in tsan
warning reports such as this:
Thread T7 'CPU 1/TCG' (tid=24317, running) created by main thread at:
Signed-off-by: Robert Foley
---
util/qemu-thread-posix.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/util/qemu-thread-posix.c b
On Fri, 29 May 2020 at 09:51, Eric Blake wrote:
>
> On 5/29/20 8:23 AM, Robert Foley wrote:
> > From: Lingfeng Yang
> >
> > We tried running QEMU under tsan in 2016, but tsan's lack of support for
> > longjmp-based fibers was a blocker:
> >https://gr
the TSAN suppresion file to disable certain
cases of TSAN warnings.
Cc: Fam Zheng
Cc: Philippe Mathieu-Daudé
Signed-off-by: Robert Foley
---
tests/docker/Makefile.include | 2 +
tests/docker/common.rc | 19 +++
tests/docker/dockerfiles/ubuntu2004.docker | 65
From: "Emilio G. Cota"
Signed-off-by: Emilio G. Cota
Signed-off-by: Robert Foley
[RF: Minor changes to fix some checkpatch errors]
---
accel/tcg/translate-all.c | 10 +-
include/tcg/tcg.h | 3 ++-
tcg/tcg.c | 19 ---
3 files c
From: "Emilio G. Cota"
It will be used for TSAN annotations.
Signed-off-by: Emilio G. Cota
Signed-off-by: Robert Foley
---
include/qemu/thread.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/qemu/thread.h b/include/qemu/thread.h
index d22848138e..e50a073
Adds TSan details to testing.rst.
This includes background and reference details on TSan,
and details on how to build and test with TSan
both with and without docker.
Signed-off-by: Robert Foley
Reviewed-by: Emilio G. Cota
---
docs/devel/testing.rst | 113
This helps debug issues that occur during the boot sequence.
Signed-off-by: Robert Foley
Reviewed-by: Peter Puhov
Reviewed-by: Alex Bennée
---
tests/vm/Makefile.include | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/vm/Makefile.include b/tests/vm/Makefile.include
index d9b34eae63
Added a new special variable QEMU_LOCAL=1, which
will indicate to take the QEMU binary from the current
build.
Signed-off-by: Robert Foley
Reviewed-by: Peter Puhov
Reviewed-by: Alex Bennée
---
tests/vm/Makefile.include | 4
tests/vm/basevm.py| 23 ---
2 files
This allows for waiting for completion of arbitrary commands.
Signed-off-by: Robert Foley
Reviewed-by: Peter Puhov
Reviewed-by: Alex Bennée
---
tests/vm/basevm.py | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py
index
centos.aarch64 creates a CentOS 8 image.
Also added a new kickstart script used to build the centos.aarch64 image.
Signed-off-by: Robert Foley
Reviewed-by: Peter Puhov
Reviewed-by: Alex Bennée
---
tests/vm/Makefile.include| 3 +-
tests/vm/centos-8-aarch64.ks | 51
tests/vm
ubuntu.aarch64 provides a script to create an Ubuntu 18.04 VM.
Another new file is also added aarch64vm.py, which is a module with
common methods used by aarch64 VMs, such as how to create the
flash images.
Signed-off-by: Robert Foley
Reviewed-by: Peter Puhov
---
configure
This change converts existing scripts to using for example self.ROOT_PASS,
to self._config['root_pass'].
We made similar changes for GUEST_USER, and GUEST_PASS.
This allows us also to remove the change in basevm.py,
which adds __getattr__ for backwards compatibility.
Signed-off-by: Robert Foley
of the --build-path argument instead.
Robert Foley (12):
tests/vm: pass args through to BaseVM's __init__
tests/vm: Add configuration to basevm.py
tests/vm: Added configuration file support
tests/vm: Pass --debug through for vm-boot-ssh.
tests/vm: Add ability to select QEMU from current build
Adding the args parameter to BaseVM's __init__.
We will shortly need to pass more parameters to the class
so let's just pass args rather than growing the parameter list.
Signed-off-by: Robert Foley
Reviewed-by: Alex Bennée
---
tests/vm/basevm.py | 13 ++---
1 file changed, 6 insertions
Add a common Ubuntu python module and make use of
it with the ubuntu.i386 script.
This is preparation for adding an Ubuntu script
ubuntu.aarch64. Splitting out the common
logic such as build_image() will reduce duplication.
Signed-off-by: Robert Foley
---
tests/vm/ubuntu.i386 | 46
characters to be consumed.
We also added the option of logging the console to a file.
LOG_CONSOLE=1 will now log the output to a file.
Signed-off-by: Robert Foley
Reviewed-by: Peter Puhov
Acked-by: Alex Bennée
---
tests/vm/Makefile.include | 4
tests/vm/basevm.py| 17 +++--
2
for basevm.py since
there is a known issue where QEMU will hang waiting
for console characters to be consumed.
Cc: Eduardo Habkost
Cc: Cleber Rosa
Signed-off-by: Robert Foley
Reviewed-by: Peter Puhov
Acked-by: Alex Bennée
---
python/qemu/console_socket.py | 118 ++
python
.yml.
Signed-off-by: Robert Foley
Reviewed-by: Peter Puhov
Reviewed-by: Alex Bennée
---
configure | 9 ++
tests/vm/Makefile.include | 6
tests/vm/basevm.py| 40 +++-
tests/vm/conf_example_aarch64.yml | 51
to vary on the VM being created
or launched.
This will for example allow for creating an aarch64 vm.
Signed-off-by: Robert Foley
Reviewed-by: Peter Puhov
Reviewed-by: Alex Bennée
---
tests/vm/basevm.py | 172 +++--
1 file changed, 133 insertions(+), 39
On Sun, 31 May 2020 at 06:37, Philippe Mathieu-Daudé wrote:
>
> On 5/29/20 10:34 PM, Robert Foley wrote:
> > Add a common Ubuntu python module and make use of
> > it with the ubuntu.i386 script.
> > This is preparation for adding an Ubuntu script
> > ubuntu.aarc
Hi Philippe,
On Sun, 31 May 2020 at 07:22, Philippe Mathieu-Daudé wrote:
>
> On 5/29/20 10:34 PM, Robert Foley wrote:
> > We add the ConsoleSocket object, which has a socket interface
> > and which will consume all arriving characters on the
> > socket, placing them
On Sun, 31 May 2020 at 06:54, Alex Bennée wrote:
>
>
> Philippe Mathieu-Daudé writes:
>
> > Hi Robert,
> >
> > On 5/29/20 10:34 PM, Robert Foley wrote:
>
> >> diff --git a/configure b/configure
> >> index d82de47fdd..8a286e75a5 100755
>
On Sun, 31 May 2020 at 07:27, Philippe Mathieu-Daudé wrote:
>
> On 5/29/20 10:34 PM, Robert Foley wrote:
> > @@ -271,7 +276,9 @@ class BaseVM(object):
> > args += self._data_args + extra_args + self._config['extra_args']
> > logging.debug("
This change converts existing scripts to using for example self.ROOT_PASS,
to self._config['root_pass'].
We made similar changes for GUEST_USER, and GUEST_PASS.
This allows us also to remove the change in basevm.py,
which adds __getattr__ for backwards compatibility.
Signed-off-by: Robert Foley
Add a common Ubuntu python module and make use of
it with the ubuntu.i386 script.
This is preparation for adding an Ubuntu script
ubuntu.aarch64. Splitting out the common
logic such as build_image() will reduce duplication.
Signed-off-by: Robert Foley
Tested-by: Philippe Mathieu-Daudé
.yml.
Signed-off-by: Robert Foley
Reviewed-by: Peter Puhov
Reviewed-by: Alex Bennée
---
configure | 9 ++
tests/vm/Makefile.include | 6
tests/vm/basevm.py| 40 +++-
tests/vm/conf_example_aarch64.yml | 51
Adding the args parameter to BaseVM's __init__.
We will shortly need to pass more parameters to the class
so let's just pass args rather than growing the parameter list.
Signed-off-by: Robert Foley
Reviewed-by: Alex Bennée
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
indentation of efi-aarch64 code in configure.
- Updated file header for ubuntuvm.py
- Few minor changes in ConsoleSocket
- Updated some comments in basevm.py around the call to
QEMUMachine regarding drain_console=True.
Robert Foley (9):
tests/vm: pass args through to BaseVM's __init__
tests
ubuntu.aarch64 provides a script to create an Ubuntu 18.04 VM.
Another new file is also added aarch64vm.py, which is a module with
common methods used by aarch64 VMs, such as how to create the
flash images.
Signed-off-by: Robert Foley
Reviewed-by: Peter Puhov
---
configure
to vary on the VM being created
or launched.
This will for example allow for creating an aarch64 vm.
Signed-off-by: Robert Foley
Reviewed-by: Peter Puhov
Reviewed-by: Alex Bennée
---
tests/vm/basevm.py | 172 +++--
1 file changed, 133 insertions(+), 39
characters to be consumed.
We also added the option of logging the console to a file.
LOG_CONSOLE=1 will now log the output to a file.
Signed-off-by: Robert Foley
Reviewed-by: Peter Puhov
Acked-by: Alex Bennée
---
tests/vm/Makefile.include | 4
tests/vm/basevm.py| 21
centos.aarch64 creates a CentOS 8 image.
Also added a new kickstart script used to build the centos.aarch64 image.
Signed-off-by: Robert Foley
Reviewed-by: Peter Puhov
Reviewed-by: Alex Bennée
---
tests/vm/Makefile.include| 3 +-
tests/vm/centos-8-aarch64.ks | 51
tests/vm
for basevm.py since
there is a known issue where QEMU will hang waiting
for console characters to be consumed.
Cc: Eduardo Habkost
Cc: Cleber Rosa
Signed-off-by: Robert Foley
Reviewed-by: Peter Puhov
Acked-by: Alex Bennée
Tested-by: Philippe Mathieu-Daudé
---
python/qemu/console_socket.py | 110
(qemu-system-aarch64+0x01fb3e28)
Cc: Richard Henderson
Cc: Paolo Bonzini
Signed-off-by: Robert Foley
---
accel/tcg/cpu-exec.c| 4 ++--
cpus.c | 2 +-
include/exec/exec-all.h | 2 +-
linux-user/syscall.c| 4 ++--
4 files changed, 6 insertions(+), 6 deletions(-)
diff
These annotations will allow us to give tsan
additional hints. For example, we can inform
tsan about reads/writes to ignore to silence certain
classes of warnings.
We can also annotate threads so that the proper thread
naming shows up in tsan warning results.
Signed-off-by: Robert Foley
util/qemu-thread-posix.c:519:9
(qemu-system-aarch64+0xcde280)
Cc: Stefan Hajnoczi
Cc: Fam Zheng
Signed-off-by: Robert Foley
---
util/async.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/util/async.c b/util/async.c
index 1319eee3bc..51e306bf0c 100644
--- a/util
: Richard Henderson
Signed-off-by: Robert Foley
---
target/arm/cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/arm/cpu.c b/target/arm/cpu.c
index 32bec156f2..cdb90582ee 100644
--- a/target/arm/cpu.c
+++ b/target/arm/cpu.c
@@ -75,7 +75,7 @@ static bool arm_cpu_has_work
the TSAN suppresion file to disable certain
cases of TSAN warnings.
Cc: Fam Zheng
Cc: Philippe Mathieu-Daudé
Signed-off-by: Robert Foley
---
tests/docker/Makefile.include | 2 +
tests/docker/common.rc | 19 +++
tests/docker/dockerfiles/ubuntu2004.docker | 65
From: "Emilio G. Cota"
Instead of open-coding it.
While at it, make sure that all accesses to the list are
performed while holding the list's lock.
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Emilio G. Cota
Signed-off-by: Robert Foley
---
cpu
From: "Emilio G. Cota"
Signed-off-by: Emilio G. Cota
Signed-off-by: Robert Foley
[RF: Minor changes to fix some checkpatch errors]
---
accel/tcg/translate-all.c | 10 +-
include/tcg/tcg.h | 3 ++-
tcg/tcg.c | 19 ---
3 files c
From: "Emilio G. Cota"
Signed-off-by: Emilio G. Cota
Signed-off-by: Robert Foley
---
include/qemu/thread.h | 39 ---
1 file changed, 36 insertions(+), 3 deletions(-)
diff --git a/include/qemu/thread.h b/include/qemu/thread.h
index e50a073889..
From: "Emilio G. Cota"
The radix tree is append-only, but we can fail to insert
a PageDesc if the insertion races with another thread.
Signed-off-by: Emilio G. Cota
Signed-off-by: Robert Foley
---
accel/tcg/translate-all.c | 9 +
1 file changed, 9 insertions(+)
diff --g
This allows us to see the name of the thread in tsan
warning reports such as this:
Thread T7 'CPU 1/TCG' (tid=24317, running) created by main thread at:
Signed-off-by: Robert Foley
---
util/qemu-thread-posix.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/util/qemu-thread-posix.c b
This includes details on how to build and test with TSan
both inside a docker and outside.
Signed-off-by: Robert Foley
---
docs/devel/testing.rst | 72 ++
1 file changed, 72 insertions(+)
diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst
index
From: "Emilio G. Cota"
I was after adding qemu_spin_destroy calls, but while at
it I noticed that we are leaking some memory.
Signed-off-by: Emilio G. Cota
Signed-off-by: Robert Foley
---
accel/tcg/cputlb.c | 15 +++
exec.c | 1 +
include/exec/
'
configure flags.
Signed-off-by: Lingfeng Yang
Signed-off-by: Emilio G. Cota
[cota: minor modifications + configure changes]
Signed-off-by: Robert Foley
[RF: minor changes to clean up checkpatch warnings/errors]
---
configure | 39
util/coroutine-ucontext.c | 97
translate-all: call qemu_spin_destroy for PageDesc
thread: add tsan annotations to QemuSpin
Lingfeng Yang (1):
configure: add --enable-tsan flag + fiber annotations for
coroutine-ucontext
Robert Foley (11):
tests/docker: Added docker build support for TSan.
include/qemu: Added tsan.h fo
From: "Emilio G. Cota"
It will be used for TSAN annotations.
Signed-off-by: Emilio G. Cota
Signed-off-by: Robert Foley
---
include/qemu/thread.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/qemu/thread.h b/include/qemu/thread.h
index d22848138e..e50a073
301 - 400 of 572 matches
Mail list logo
