Re: [Qemu-devel] [PATCH 2/3] slirp: Add dns6 resolution

2016-03-20 Thread Samuel Thibault
Samuel Thibault, on Sun 20 Mar 2016 15:45:25 +0100, wrote: > -*pdns_addr = dns_addr; > +memcpy(pdns_addr, &cached_addr, addrlen); Oops, sorry, it should have been > +memcpy(pdns_addr, cached_addr, addrlen); In my tests I had forgotten to try resolving m

[Qemu-devel] [PATCH 0/4] slirp: Add dns6 support

2016-03-20 Thread Samuel Thibault
This adds support for DNS over IPv6 in slirp, which is notably useful when the host has only an IPv6 DNS server. This series depends on "slirp: Allow to disable IPv4 or IPv6" which defines in6_zero. Samuel Thibault (4): slirp: Split get_dns_addr slirp: Add dns6 resolution slir

[Qemu-devel] [PATCH 4/4] slirp: Add RDNSS advertisement

2016-03-20 Thread Samuel Thibault
This adds the RDNSS option to IPv6 router advertisements, so that the guest can autoconfigure the DNS server address. Signed-off-by: Samuel Thibault --- slirp/ip6_icmp.c | 19 --- slirp/ip6_icmp.h | 12 ++-- 2 files changed, 26 insertions(+), 5 deletions(-) diff --git a

[Qemu-devel] [PATCH 3/4] slirp: Support link-local DNS addresses

2016-03-20 Thread Samuel Thibault
They look like fe80::%eth0 Signed-off-by: Samuel Thibault --- slirp/libslirp.h | 2 +- slirp/slirp.c| 26 ++ slirp/socket.c | 2 +- 3 files changed, 24 insertions(+), 6 deletions(-) diff --git a/slirp/libslirp.h b/slirp/libslirp.h index eea9be4..bf3a420 100644

[Qemu-devel] [PATCH 1/4] slirp: Split get_dns_addr

2016-03-20 Thread Samuel Thibault
Separate get_dns_addr into get_dns_addr_cached and get_dns_addr_resolv_conf to make conversion to IPv6 easier. Signed-off-by: Samuel Thibault --- slirp/slirp.c | 53 ++--- 1 file changed, 34 insertions(+), 19 deletions(-) diff --git a/slirp

[Qemu-devel] [PATCH 2/4] slirp: Add dns6 resolution

2016-03-20 Thread Samuel Thibault
This makes get_dns_addr address family-agnostic, thus allowing to add the IPv6 case. Signed-off-by: Samuel Thibault --- slirp/libslirp.h | 1 + slirp/slirp.c| 72 slirp/socket.c | 4 ++-- 3 files changed, 55 insertions(+), 22

Re: [Qemu-devel] [PATCH] slirp: Allow to disable IPv4 or IPv6

2016-03-21 Thread Samuel Thibault
Markus Armbruster, on Mon 21 Mar 2016 08:33:52 +0100, wrote: > > +either in the form a.b.c.d or as number of valid top-most bits. Set to > > 0.0.0.0 > > +to disable IPv4 completely. Default is 10.0.2.0/24. > > Long line. How long is too long? This is 78 characters, and I see plenty of lines beyo

[Qemu-devel] [PATCH] slirp: Fix memory leak on small incoming ipv4 packet

2016-03-21 Thread Samuel Thibault
Signed-off-by: Samuel Thibault --- slirp/ip_input.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/slirp/ip_input.c b/slirp/ip_input.c index 12f173d..b464f6b 100644 --- a/slirp/ip_input.c +++ b/slirp/ip_input.c @@ -85,7 +85,7 @@ ip_input(struct mbuf *m) DEBUG_ARG

[Qemu-devel] [PATCH] slirp: send icmp6 errors when UDP send failed

2016-03-21 Thread Samuel Thibault
Signed-off-by: Samuel Thibault --- slirp/udp6.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/slirp/udp6.c b/slirp/udp6.c index 60a91c9..a23026f 100644 --- a/slirp/udp6.c +++ b/slirp/udp6.c @@ -113,8 +113,7 @@ void udp6_input(struct mbuf *m) m->m_data -= iph

Re: [Qemu-devel] [PULL] slirp: Fix memory leak on small incoming ipv4 packet

2016-03-21 Thread Samuel Thibault
Hello, Peter Maydell, on Mon 21 Mar 2016 09:48:48 +, wrote: > Generally the > process for QEMU is that first patches are sent as normal [PATCH] mails, > for code review. Patches should only be put into pull requests once > they've been through the review process. (And then you can batch them >

Re: [Qemu-devel] [PATCH] slirp: Allow to disable IPv4 or IPv6

2016-03-21 Thread Samuel Thibault
Markus Armbruster, on Mon 21 Mar 2016 08:33:52 +0100, wrote: > Samuel Thibault writes: > > Make net=0.0.0.0 disable IPv4 and ip6-net=:: disable IPv6, so the user can > > setup IPv4-only and IPv6-only network environments. > > Do "net=" and "ip6-net=" mea

Re: [Qemu-devel] [PATCH] slirp: Allow to disable IPv4 or IPv6

2016-03-22 Thread Samuel Thibault
Hello, Markus Armbruster, on Mon 21 Mar 2016 08:33:52 +0100, wrote: > > -# @net: #optional IP address and optional netmask > > +# @net: #optional IP address and optional netmask. Set to 0.0.0.0 to > > disable IPv4 completely > > Long line. > > Syntax? Default value? Something like this? # @n

Re: [Qemu-devel] [PULL 00/13] vhost, virtio, pci, pxe

2016-03-22 Thread Samuel Thibault
Hello Peter, Peter Maydell, on Fri 19 Feb 2016 12:09:17 +, wrote: > diff --git a/slirp/mbuf.h b/slirp/mbuf.h > index 38fedf4..ef5a4f7 100644 > --- a/slirp/mbuf.h > +++ b/slirp/mbuf.h > @@ -81,11 +81,9 @@ struct mbuf { > Slirp *slirp; > boolresolution_requested; > ui

Re: [Qemu-devel] [PULL 00/13] vhost, virtio, pci, pxe

2016-03-23 Thread Samuel Thibault
Peter Maydell, on Wed 23 Mar 2016 12:43:44 +, wrote: > On 23 March 2016 at 00:05, Samuel Thibault wrote: > > Peter Maydell, on Fri 19 Feb 2016 12:09:17 +, wrote: > >> diff --git a/slirp/mbuf.h b/slirp/mbuf.h > >> index 38fedf4..ef5a4f7 100644 > >>

[Qemu-devel] [PATCHv2] slirp: Allow to disable IPv4 or IPv6

2016-03-24 Thread Samuel Thibault
Make net=none disable IPv4 and ip6-net=none disable IPv6, so the user can setup IPv4-only and IPv6-only network environments. Signed-off-by: Samuel Thibault --- net/slirp.c | 19 +-- qapi-schema.json | 15 +-- qemu-options.hx | 19 --- slirp

Re: [Qemu-devel] [PATCH 0/4] slirp: Add dns6 support

2016-03-24 Thread Samuel Thibault
Hello, Could somebody review this? This will be needed for ipv6-only setups. Samuel Samuel Thibault, on Sun 20 Mar 2016 16:26:24 +0100, wrote: > This adds support for DNS over IPv6 in slirp, which is notably useful when the > host has only an IPv6 DNS server. > > This series depen

Re: [Qemu-devel] [PATCHv2] slirp: Allow to disable IPv4 or IPv6

2016-03-24 Thread Samuel Thibault
Eric Blake, on Thu 24 Mar 2016 15:36:19 -0600, wrote: > > Make net=none disable IPv4 and ip6-net=none disable IPv6, so the user can > > setup IPv4-only and IPv6-only network environments. > > This mentions 'net=none', but I don't see that in the patch below; > instead I see a new boolean. Eeergl,

Re: [Qemu-devel] [PATCHv2] slirp: Allow to disable IPv4 or IPv6

2016-03-24 Thread Samuel Thibault
Hello, Eric Blake, on Thu 24 Mar 2016 15:36:19 -0600, wrote: > What happens if 'net' is provided but 'ip4' is false? Is that a user error? We could do that, yes. > The existing 'InetSocketAddress' QAPI type spells these as 'ipv4' and > ipv6'; should we use the same spelling for consistency? Th

[Qemu-devel] [PATCHv2] slirp: Allow disabling IPv4 or IPv6

2016-03-24 Thread Samuel Thibault
Add ipv4 and ipv6 boolean options, so the user can setup IPv4-only and IPv6-only network environments. Signed-off-by: Samuel Thibault --- Changes since previous versions: - Introduce boolean options ipv4 and ipv6 instead of net=none and ip6-net=none. - Rename ipv6 options to ipv6-foo

[Qemu-devel] [PATCHv3 0/2] Rework ipv6 options, add ipv4/ipv6 enabling/disabling options

2016-03-24 Thread Samuel Thibault
This is a split of the previously-sent "Allow disabling IPv4 or IPv6" patch, to separate reworking the existing newly-added options and the new ipv4/ipv6 options. Samuel Thibault (2): Rework ipv6 options slirp: Allow disabling IPv4 or IPv6 net/slirp.c

[Qemu-devel] [PATCHv3 1/2] Rework ipv6 options

2016-03-24 Thread Samuel Thibault
Rename ip6-foo options into ipv6-foo options, to make them coherent with other ipv6 options. Also rework the documentation. --- net/slirp.c | 6 +++--- qapi-schema.json | 25 - qemu-options.hx | 18 ++ 3 files changed, 29 insertions(+), 20 deletions(

[Qemu-devel] [PATCHv3 2/2] slirp: Allow disabling IPv4 or IPv6

2016-03-24 Thread Samuel Thibault
Add ipv4 and ipv6 boolean options, so the user can setup IPv4-only and IPv6-only network environments. Also rename recently-added options to make the whole coherent before 2.6 gets released. Signed-off-by: Samuel Thibault --- Changes since previous versions: - Introduce boolean options ipv4

Re: [Qemu-devel] [PATCHv3 2/2] slirp: Allow disabling IPv4 or IPv6

2016-03-24 Thread Samuel Thibault
Samuel Thibault, on Fri 25 Mar 2016 00:25:55 +0100, wrote: > Also rename recently-added options to make the whole coherent before 2.6 > gets released. GRaaAH I'm so motivated by such bike-shedding changes that I forgot to rework the changelog. Let me do that yet again. Samuel

[Qemu-devel] [PATCHv4 0/2] Rework ipv6 options, add ipv4/ipv6 enabling/disabling options

2016-03-24 Thread Samuel Thibault
This is a split of the previously-sent "Allow disabling IPv4 or IPv6" patch, to separate reworking the existing newly-added options and the new ipv4/ipv6 options. Samuel Thibault (2): Rework ipv6 options slirp: Allow disabling IPv4 or IPv6 net/slirp.c

[Qemu-devel] [PATCHv4 1/2] Rework ipv6 options

2016-03-24 Thread Samuel Thibault
Rename the recently-added ip6-foo options into ipv6-foo options, to make them coherent with other ipv6 options. Also rework the documentation. Signed-off-by: Samuel Thibault --- net/slirp.c | 6 +++--- qapi-schema.json | 25 - qemu-options.hx | 18

[Qemu-devel] [PATCHv4 2/2] slirp: Allow disabling IPv4 or IPv6

2016-03-24 Thread Samuel Thibault
Add ipv4 and ipv6 boolean options, so the user can setup IPv4-only and IPv6-only network environments. Signed-off-by: Samuel Thibault --- Changes since previous versions: - Introduce boolean options ipv4 and ipv6 instead of net=none and ip6-net=none. - Reject incoherent configuration (e.g

[Qemu-devel] [PULL 1/5] slirp: Fix memory leak on small incoming ipv4 packet

2016-03-28 Thread Samuel Thibault
Signed-off-by: Samuel Thibault Reviewed-by: Thomas Huth --- slirp/ip_input.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/slirp/ip_input.c b/slirp/ip_input.c index 12f173d..b464f6b 100644 --- a/slirp/ip_input.c +++ b/slirp/ip_input.c @@ -85,7 +85,7 @@ ip_input(struct mbuf

[Qemu-devel] [PULL 4/5] Use C99 flexible array instead of 1-byte trailing array

2016-03-28 Thread Samuel Thibault
From: Peter Maydell Signed-off-by: Peter Maydell Signed-off-by: Samuel Thibault --- slirp/mbuf.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/slirp/mbuf.h b/slirp/mbuf.h index 38fedf4..36fb814 100644 --- a/slirp/mbuf.h +++ b/slirp/mbuf.h @@ -81,11 +81,9 @@ struct

[Qemu-devel] [PULL 5/5] Rework ipv6 options

2016-03-28 Thread Samuel Thibault
Rename the recently-added ip6-foo options into ipv6-foo options, to make them coherent with other ipv6 options. Also rework the documentation. Signed-off-by: Samuel Thibault Reviewed-by: Eric Blake --- net/net.c| 16 net/slirp.c | 6 +++--- qapi-schema.json | 25

[Qemu-devel] [PULL 0/5] slirp updates

2016-03-28 Thread Samuel Thibault
Merge remote-tracking branch 'remotes/mdroth/tags/qga-pull-2016-03-21-tag' into staging (2016-03-22 17:39:48 +) are available in the git repository at: http://people.debian.org/~sthibault/qemu.git tags/samuel-thibault for you to fetch cha

[Qemu-devel] [PULL 2/5] slirp: send icmp6 errors when UDP send failed

2016-03-28 Thread Samuel Thibault
Signed-off-by: Samuel Thibault Reviewed-by: Thomas Huth --- slirp/udp6.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/slirp/udp6.c b/slirp/udp6.c index 60a91c9..a23026f 100644 --- a/slirp/udp6.c +++ b/slirp/udp6.c @@ -113,8 +113,7 @@ void udp6_input(struct mbuf *m

[Qemu-devel] [PULL 3/5] Avoid embedding struct mbuf in other structures

2016-03-28 Thread Samuel Thibault
appropriate. Signed-off-by: Samuel Thibault Reviewed-by: Peter Maydell --- slirp/if.c| 27 ++- slirp/mbuf.c | 19 ++- slirp/misc.c | 5 - slirp/misc.h | 5 + slirp/slirp.h | 8 +--- 5 files changed, 34 insertions(+), 30 deletions(-) diff

[Qemu-devel] [PATCH 2/5] slirp: Split get_dns_addr

2016-03-28 Thread Samuel Thibault
Separate get_dns_addr into get_dns_addr_cached and get_dns_addr_resolv_conf to make conversion to IPv6 easier. Signed-off-by: Samuel Thibault --- slirp/slirp.c | 53 ++--- 1 file changed, 34 insertions(+), 19 deletions(-) diff --git a/slirp

[Qemu-devel] [PATCH 5/5] slirp: Add RDNSS advertisement

2016-03-28 Thread Samuel Thibault
This adds the RDNSS option to IPv6 router advertisements, so that the guest can autoconfigure the DNS server address. Signed-off-by: Samuel Thibault --- slirp/ip6_icmp.c | 19 --- slirp/ip6_icmp.h | 12 ++-- 2 files changed, 26 insertions(+), 5 deletions(-) diff --git a

[Qemu-devel] [PATCH 0/5] ipv4-only and ipv6-only support

2016-03-28 Thread Samuel Thibault
Hello, This series gathers the patches to enable ipv4-only and ipv6-only support: it adds the discussed ipv4 and ipv6 options to select which is enabled, and adds support for ipv6 dns translation. Samuel Thibault (5): slirp: Allow disabling IPv4 or IPv6 slirp: Split get_dns_addr slirp: Add

[Qemu-devel] [PATCH 3/5] slirp: Add dns6 resolution

2016-03-28 Thread Samuel Thibault
This makes get_dns_addr address family-agnostic, thus allowing to add the IPv6 case. Signed-off-by: Samuel Thibault --- slirp/ip6.h | 9 +++ slirp/libslirp.h | 1 + slirp/slirp.c| 72 slirp/socket.c | 4 ++-- 4 files

[Qemu-devel] [PATCH 1/5] slirp: Allow disabling IPv4 or IPv6

2016-03-28 Thread Samuel Thibault
Add ipv4 and ipv6 boolean options, so the user can setup IPv4-only and IPv6-only network environments. Signed-off-by: Samuel Thibault --- Changes since previous versions: - fix coding style --- net/slirp.c | 36 ++-- qapi-schema.json | 8 qemu

[Qemu-devel] [PATCH 4/5] slirp: Support link-local DNS addresses

2016-03-28 Thread Samuel Thibault
They look like fe80::%eth0 Signed-off-by: Samuel Thibault --- slirp/libslirp.h | 2 +- slirp/slirp.c| 26 ++ slirp/socket.c | 2 +- 3 files changed, 24 insertions(+), 6 deletions(-) diff --git a/slirp/libslirp.h b/slirp/libslirp.h index b0cfbc5..81bd139 100644

Re: [Qemu-devel] [PATCHv4 2/2] slirp: Allow disabling IPv4 or IPv6

2016-03-28 Thread Samuel Thibault
Eric Blake, on Mon 28 Mar 2016 09:12:04 -0600, wrote: > > +if ((user->has_ipv6 && user->ipv6 && !user->has_ipv4) > > +|| (user->has_ipv4 && !user->ipv4)) > > +ipv4 = 0; > > Inconsistent with current qemu style. Should be: > > if ((user->has_ipv6 && user->ipv6 && !user

Re: [Qemu-devel] [PATCH 12/16] slirp: Use DIV_ROUND_UP

2016-05-31 Thread Samuel Thibault
Laurent Vivier, on Tue 31 May 2016 18:36:01 +0200, wrote: > Replace (((n) + (d) - 1) /(d)) by DIV_ROUND_UP(n,d). > > This patch is the result of coccinelle script > scripts/coccinelle/round.cocci > > Signed-off-by: Laurent Vivier Acked-by: Samuel Thibault > --- >

[Qemu-devel] [PATCH] Document that curses usually needs -k option too

2016-06-22 Thread Samuel Thibault
Signed-off-by: Samuel Thibault --- qemu-options.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-options.hx b/qemu-options.hx index 17f15ad..ce535a9 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -306,7 +306,7 @@ STEXI @findex -k Use keyboard layout @var

[Qemu-devel] [PATCH] Reduce curses escdelay from 1s to 0.2s

2016-06-22 Thread Samuel Thibault
, which should be more than enough. Signed-off-by: Samuel Thibault --- ui/curses.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ui/curses.c b/ui/curses.c index b475589..49d3ce6 100644 --- a/ui/curses.c +++ b/ui/curses.c @@ -222,7 +222,7 @@ static void curses_refresh

Re: [Qemu-devel] [PATCH] Reduce curses escdelay from 1s to 0.2s

2016-06-22 Thread Samuel Thibault
Peter Maydell, on Wed 22 Jun 2016 21:49:04 +0100, wrote: > On 22 June 2016 at 16:44, Samuel Thibault > wrote: > > By default, curses will only report single ESC key event after 1s delay, > > since ESC is also used for keypad escape sequences. This however makes users > >

[Qemu-devel] [PATCH 5/5] curses: support wide input

2016-06-22 Thread Samuel Thibault
value is a key code or a character (wide support), or possibly both (non-wide support). The translation tables thus also need to be separated into key code translation and character translation. The curses2foo helper makes it easier to use them. Signed-off-by: Samuel Thibault --- ui/curses.c

[Qemu-devel] [PATCH 0/5] curses: wide character support

2016-06-22 Thread Samuel Thibault
as to specify the keyboard layout with -k). I used option -f to make it simple for now, but I welcome any other idea :) Samuel Samuel Thibault (5): curses: fix left/right arrow translation curses: Use cursesw when available curses: use wide output functions curses: add option to specify VGA

[Qemu-devel] [PATCH 2/5] curses: Use cursesw when available

2016-06-22 Thread Samuel Thibault
Signed-off-by: Samuel Thibault --- configure | 64 ++- 1 file changed, 63 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 10cb212..ff10012 100755 --- a/configure +++ b/configure @@ -203,6 +203,7 @@ bluez

[Qemu-devel] [PATCH 4/5] curses: add option to specify VGA font encoding

2016-06-22 Thread Samuel Thibault
This detects and uses iconv to convert glyphs from the specified VGA font encoding to unicode. Signed-off-by: Samuel Thibault --- configure | 37 + include/sysemu/sysemu.h | 1 + qemu-options.hx | 20 ui/curses.c

[Qemu-devel] [PATCH 3/5] curses: use wide output functions

2016-06-22 Thread Samuel Thibault
This makes use of cchar_t instead of chtype when using ncursesw, which allows to store a wide char as well as the WACS values. This also allows to complete the printable glyphs list beyond ascii and the ACS values. Signed-off-by: Samuel Thibault --- hw/display/vga.c | 4 +- include/ui

[Qemu-devel] [PATCH 1/5] curses: fix left/right arrow translation

2016-06-22 Thread Samuel Thibault
In default VGA font, left/right arrow are glyphs 0x1a and 0x1b, not 0x0a and 0x0b. Signed-off-by: Samuel Thibault --- ui/curses.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/curses.c b/ui/curses.c index 49d3ce6..438b8be 100644 --- a/ui/curses.c +++ b/ui/curses.c

[Qemu-devel] [PULL 3/4] slirp: Remove some unused code from slirp.h

2016-05-16 Thread Samuel Thibault
From: Thomas Huth These hunks are apparently not used anymore, so let's delete them. Signed-off-by: Thomas Huth Reviewed-by: Peter Maydell Signed-off-by: Samuel Thibault --- slirp/slirp.h | 22 -- 1 file changed, 22 deletions(-) diff --git a/slirp/slirp.h b/

[Qemu-devel] [PULL 1/4] slirp: Clean up slirp_config.h

2016-05-16 Thread Samuel Thibault
Peter Maydell Signed-off-by: Samuel Thibault --- slirp/slirp_config.h | 87 1 file changed, 87 deletions(-) diff --git a/slirp/slirp_config.h b/slirp/slirp_config.h index 896d802..a5fa36e 100644 --- a/slirp/slirp_config.h +++ b/slirp/slirp_con

[Qemu-devel] [PULL 2/4] slirp: Remove obsolete backward-compatibility cruft

2016-05-16 Thread Samuel Thibault
not support Ultrix anymore, so no need to keep the code for this platform anymore. Signed-off-by: Thomas Huth Reviewed-by: Peter Maydell Signed-off-by: Samuel Thibault --- slirp/misc.c | 21 - slirp/slirp.h| 28 slirp/slirp_config.h

[Qemu-devel] [PULL 0/4] slirp updates

2016-05-16 Thread Samuel Thibault
Merge remote-tracking branch 'remotes/kraxel/tags/pull-ui-20160513-1' into staging (2016-05-13 13:39:38 +0100) are available in the git repository at: http://people.debian.org/~sthibault/qemu.git tags/samuel-thibault for you to fetch changes up to 9892663dc486755b5534ff8a77913e

[Qemu-devel] [PULL 4/4] slirp: Clean up osdep.h related header inclusions

2016-05-16 Thread Samuel Thibault
: Samuel Thibault --- slirp/ip6_icmp.c | 1 - slirp/ip_input.c | 1 - slirp/udp6.c | 1 - 3 files changed, 3 deletions(-) diff --git a/slirp/ip6_icmp.c b/slirp/ip6_icmp.c index 09571bc..48016a9 100644 --- a/slirp/ip6_icmp.c +++ b/slirp/ip6_icmp.c @@ -9,7 +9,6 @@ #include "qemu/ti

Re: [Qemu-devel] [PULL 18/19] usb: usb-serial QOMify

2015-05-10 Thread Samuel Thibault
Gerd Hoffmann, le Fri 08 May 2015 13:45:52 +0200, a écrit : > From: Gonglei > > Signed-off-by: Gonglei > Signed-off-by: Gerd Hoffmann Acked-by: Samuel Thibault Tested-by: Samuel Thibault > --- > hw/usb/dev-serial.c | 43 +++ >

[Qemu-devel] [PATH,curses] Fix contro...@[\]^_} and ESC

2010-08-29 Thread Samuel Thibault
contro...@[\]^_} shouldn't get the 'a' - 'A' offset for correct translation. ESC is better simulated as escape key. Signed-off-by: Samuel Thibault diff --git a/ui/curses.c b/ui/curses.c index ed3165e..5d949d6 100644 --- a/ui/curses.c +++ b/ui/curses.c @@ -238

Re: [Qemu-devel] linux 2.6.35 hangs with -no-acpi

2010-09-01 Thread Samuel Thibault
Jes Sorensen, le Wed 01 Sep 2010 11:25:48 +0200, a écrit : > On 08/29/10 18:39, Samuel Thibault wrote: > > Linux 2.6.35 hangs at boot when giving -no-acpi to qemu, for instance > > the Debian kernel: > > > > qemu -no-acpi -kernel /boot/vmlinuz-2.6.35-trunk-686 > &

[Qemu-devel] [Bug 627982] [NEW] linux 2.6.35 hangs with -no-acpi

2010-09-01 Thread Samuel thibault
Public bug reported: Linux 2.6.35 hangs at boot when giving -no-acpi to qemu, for instance the Debian kernel: qemu -no-acpi -kernel /boot/vmlinuz-2.6.35-trunk-686 There is no output except just "Booting the kernel" ** Affects: qemu Importance: Undecided Status: New -- linux 2.6.

Re: [Qemu-devel] [Bug 627982] [NEW] linux 2.6.35 hangs with -no-acpi

2010-09-01 Thread Samuel Thibault
Avi Kivity, le Wed 01 Sep 2010 15:17:50 +0300, a écrit : > On 09/01/2010 01:54 PM, Samuel thibault wrote: > >Linux 2.6.35 hangs at boot when giving -no-acpi to qemu, for instance > >the Debian kernel: > > > >qemu -no-acpi -kernel /boot/vmlinuz-2.6.35-trunk-686 > >

[Qemu-devel] Re: [PATCH,curses] Fix contro...@[\]^_} and ESC

2010-10-19 Thread Samuel Thibault
Hello, This apparently has been neither applied, nor commented on. Could either be done? Samuel contro...@[\]^_} shouldn't get the 'a' - 'A' offset for correct translation. ESC is better simulated as escape key. Signed-off-by: Samuel Thibault diff --git a/ui/cur

[Qemu-devel] linux 2.6.35 hangs with -no-acpi

2010-08-29 Thread Samuel Thibault
Hello, Linux 2.6.35 hangs at boot when giving -no-acpi to qemu, for instance the Debian kernel: qemu -no-acpi -kernel /boot/vmlinuz-2.6.35-trunk-686 Samuel

Re: [Qemu-devel] [PATCH] pc: madvise(MADV_DONTNEED) memory on reset

2010-02-24 Thread Samuel Thibault
Hello, I just want to note the fact that although Linux got it badly wrong, according to POSIX, MADV_DONTNEED is _not_ supposed to drop the content of the memory, but just to tune the write-back heuristics and such. (see glibc's ./sysdeps/unix/sysv/linux/posix_madvise.c if you're not convinced) q

[Qemu-devel] [PATCH] Fix curses return key when using -k

2010-02-28 Thread Samuel Thibault
Hello, There is a small incoherency in curses_keys.h, which makes it fail to emit \n when using e.g. -k fr: curses2keysym transforms \r and 0x157 into \n, but name2keysym binds \r with Return, not \n. The patch below fixes that. Samuel diff --git a/curses_keys.h b/curses_keys.h index a6e41cf..6

[Qemu-devel] Re: [PATCH] Fix curses return key when using -k

2010-02-28 Thread Samuel Thibault
Samuel Thibault, le Sun 28 Feb 2010 15:35:19 +0100, a écrit : > There is a small incoherency in curses_keys.h, which makes it fail to > emit \n when using e.g. -k fr: curses2keysym transforms \r and 0x157 > into \n, but name2keysym binds \r with Return, not \n. The patch below >

[Qemu-devel] [PATCH] (curses) Use more descriptive values

2010-02-28 Thread Samuel Thibault
Hello, curses_keys.h is using obscure constant values while the curses.h header provides fine defines, let's use the latter. To be applied on top of my previous patch. Samuel Signed-off-by: Samuel Thibault diff --git a/curses_keys.h b/curses_keys.h index a6e41cf..9c1aa7f 100644

[Qemu-devel] [PATCH] Fix curses interaction with keymaps

2010-02-28 Thread Samuel Thibault
Thibault commit 36f0635cb65e1735a7e231d609da98efcda756c5 Author: Samuel Thibault Date: Sun Feb 28 20:48:39 2010 +0100 Fix curses with -k option diff --git a/curses.c b/curses.c index 3ce12b9..4b5beac 100644 --- a/curses.c +++ b/curses.c @@ -159,11 +159,10 @@ static void

[Qemu-devel] Re: [PATCH] Fix curses interaction with keymaps

2010-02-28 Thread Samuel Thibault
Samuel Thibault, le Sun 28 Feb 2010 21:03:00 +0100, a écrit : > The combination of keymap support (-k option) and curses is currently > very broken. The patch below fixes it by first extending keymap support > to interpret the shift, ctrl, altgr and addupper keywords in keymaps, >

Re: [Qemu-devel] Multi process. using threads in qemu

2010-03-26 Thread Samuel Thibault
Alexandre Muller, le Fri 26 Mar 2010 21:26:52 -0300, a écrit : > 1 - The is a known discussion about it? Yes. The basic answer is: this is hard. You'd need to keep the memory coherency etc. > 2 - There is a patch or a dirty and quick way to do it? (I not worried about > safety) Use kvm. In that

[Qemu-devel] [PATCH] baum: add destroy hook

2010-03-28 Thread Samuel Thibault
Hello, This adds a destroy hook for the baum character device, to properly close the BrlAPI connection and free resources. Signed-off-by: Samuel Thibault commit 447c41758cfda0022ea6e09aaf81137b2b27b915 Author: Samuel Thibault Date: Sun Mar 28 20:38:38 2010 +0200 baum: add destroy hook

[Qemu-devel] BlueTooth RFCOMM?

2010-03-28 Thread Samuel Thibault
git a/hw/bt-baum.c b/hw/bt-baum.c new file mode 100644 index 000..568b8a1 --- /dev/null +++ b/hw/bt-baum.c @@ -0,0 +1,158 @@ +/* + * QEMU Bluetooth Baum driver. + * + * Copyright (C) 2010 Samuel Thibault + * + * This program is free software; you can redistribute it and/or + * modify it under

Re: [Qemu-devel] [PATCH] qemu monitor keyboard functionality

2007-12-31 Thread Samuel Thibault
Noam Taich, le Mon 31 Dec 2007 09:02:08 -0800, a écrit : > Qemu monitor had many missing keys that could not be (easily) sent, > > And there was no mechanism for sending strings properly. > > This patch fixes the problem and enhances the monitor's functionality. Mmm, isn't there a keyboard layou

Re: [Qemu-devel] [PATCH] ensure all invocations to bdrv_{read, write} use (uint8_t *) for its third parameter

2008-01-04 Thread Samuel Thibault
Andreas Färber, le Fri 04 Jan 2008 14:41:29 +0100, a écrit : > > Am 04.01.2008 um 14:20 schrieb Thiemo Seufer: > > >Carlo Marcelo Arenas Belon wrote: > >>Trivial fix that ensures that all buffers used for bdrv_read or > >>bdrv_write > >>are from an array of the uint8_t type > > > >Do we have a

[Qemu-devel] USB serial device

2008-01-10 Thread Samuel Thibault
Hello, I would like to implement support for braille devices, and for this I'd need to first implement a USB serial device (FTDI chip). Has anybody worked on that already? Samuel

[Qemu-devel] [PATCH] USB serial device

2008-01-11 Thread Samuel Thibault
Hello, Samuel Thibault, le Fri 11 Jan 2008 00:23:12 +, a écrit : > I would like to implement support for braille devices, and for this I'd > need to first implement a USB serial device (FTDI chip). Has anybody > worked on that already? Ok, was easier than expected, Here i

[Qemu-devel] Re: [PATCH] USB serial device

2008-01-12 Thread Samuel Thibault
Hello, Samuel Thibault, le Fri 11 Jan 2008 11:09:23 +, a écrit : > Samuel Thibault, le Fri 11 Jan 2008 00:23:12 +, a écrit : > > I would like to implement support for braille devices, and for this I'd > > need to first implement a USB serial device (FTDI chip). Has a

[Qemu-devel] Re: [PATCH] USB serial device

2008-01-13 Thread Samuel Thibault
Hello, Samuel Thibault, le Sun 13 Jan 2008 01:55:56 +, a écrit : > Samuel Thibault, le Fri 11 Jan 2008 11:09:23 +, a écrit : > > Samuel Thibault, le Fri 11 Jan 2008 00:23:12 +, a écrit : > > > I would like to implement support for braille devices, and for this I

Re: [Qemu-devel] QEMU static build

2008-01-16 Thread Samuel Thibault
Salil Bijur, le Wed 16 Jan 2008 18:29:31 +0530, a écrit : > But there are further linker errors with respect to libasound (for > ALSA) and libSDL. This can be solved by adding -ldl, -lartsc, etc. for > every dependency of these libs but would be very tedious, especially > for libSDL. Any better sol

Re: [Qemu-devel] Re: [PATCH] USB serial device

2008-01-17 Thread Samuel Thibault
andrzej zaborowski, le Thu 17 Jan 2008 15:09:54 +0100, a écrit : > On 13/01/2008, Samuel Thibault <[EMAIL PROTECTED]> wrote: > > Samuel Thibault, le Sun 13 Jan 2008 01:55:56 +, a écrit : > > > Here is an updated version, that takes parameters, so as to be able to &

Re: [Qemu-devel] Re: [PATCH] USB serial device

2008-01-17 Thread Samuel Thibault
andrzej zaborowski, le Thu 17 Jan 2008 23:25:04 +0100, a écrit : > Thanks, committed although I hoped for something that lets easily test > that the adapter works, e.g. so that after a usb_add serial:...:stdio > you can do cat /dev/ttyXXXN in the guest and see what's being typed on > qemu's stdin.

Re: [Qemu-devel] Re: [PATCH] USB serial device

2008-01-19 Thread Samuel Thibault
andrzej zaborowski, le Sat 19 Jan 2008 14:05:20 +0100, a écrit : > I applied the patch even though the old values worked ok too. The old values weren't in linux 2.6.12 for instance, and it looks like the new ones are the default ones for the FTDI builderr, so it should be fine now. > I also added

Re: [Qemu-devel] [PATCH] mouse click simple queue

2008-01-28 Thread Samuel Thibault
Ronan Keryell, le Mon 28 Jan 2008 13:24:27 +0100, a écrit : > But is it possible to use higher-level queue constructions rather than > inlining the queue behaviour in the code? There is QEMUFIFO code in console.c which could be shared for instance, yes. Samuel

Re: [OT] Re: [Qemu-devel] [PATCH] Remove broken MIPS PICA 61 machine

2008-01-30 Thread Samuel Thibault
Marius Groeger, le Wed 30 Jan 2008 14:41:17 +0100, a écrit : > On Wed, 30 Jan 2008, Hervé Poussineau wrote: > > > I didn't know how to do a patch which removes the file > > hw/mips_pica61.c, so this file will have to be removed manually by > > the committer. > > One work-around for that is to d

[Qemu-devel] Common Xen/KVM patchqueue repository?

2008-02-01 Thread Samuel Thibault
Hello, We were wondering whether it could be useful to have e.g. a git repository holding the patches from Xen and KVM: while they are being merged upstream, they could at least be shared by both projects... Samuel

Re: [Qemu-devel] Making qemu use 10.0.3.x not 10.0.2.x

2008-02-04 Thread Samuel Thibault
Mmm, actually, shouldn't qemu use a more "private" network like a RFC1918 172.16.0.0/12 network? (see http://www.ucam.org/cam-grin/) Samuel

Re: [Qemu-devel] Making qemu use 10.0.3.x not 10.0.2.x

2008-02-05 Thread Samuel Thibault
Andreas Schwab, le Tue 05 Feb 2008 11:32:30 +0100, a écrit : > Samuel Thibault <[EMAIL PROTECTED]> writes: > > > Mmm, actually, shouldn't qemu use a more "private" network like a > > RFC1918 172.16.0.0/12 network? > > In which way is 172.16.0.0/

[Qemu-devel] [PATCH] memory usage and ioports

2008-02-06 Thread Samuel Thibault
Samuel Thibault, le Mon 19 Nov 2007 15:20:16 +, a écrit : > Qemu currently uses 6 65k tables of pointers for handling ioports, which > makes 3MB on 64bit machines. There's a comment that says "XXX: use a two > level table to limit memory usage". But wouldn't it b

Re: [Qemu-devel] Re: [PATCH] Allow AF_UNIX sockets to be disabled on non-Windows

2008-02-06 Thread Samuel Thibault
Anthony Liguori, le Wed 06 Feb 2008 13:19:23 -0600, a écrit : > Ian Jackson wrote: > >iwj writes ("[PATCH] Allow AF_UNIX sockets to be disabled on non-Windows"): > > > >>The patch below makes it possible to disable AF_UNIX (unix-domain) > >>sockets in host environments which do not define _WIN32,

[Qemu-devel] Switch back from graphical mode to text mode

2008-02-10 Thread Samuel Thibault
Hello, Thanks for merging the ncurses interface, that'll be very useful! However there is a small bug when switching back from graphical mode to text mode in vga.c: in graphical mode, the text screen is resized to 60x3 so as to display a message, but nothing is done to make sure that it will be r

Re: [Qemu-devel] [PATCH] SDL mouse events smoothness

2008-02-26 Thread Samuel Thibault
Johannes Schindelin, le Tue 26 Feb 2008 12:57:25 +, a écrit : > On Tue, 26 Feb 2008, Samuel Thibault wrote: > > > I asked on the SDL mailing list, and they answered that qemu should > > indeed not use SDL_GetRelativeMouseState(), since that only provides the > > la

[Qemu-devel] [PATCH] SDL mouse events smoothness

2008-02-26 Thread Samuel Thibault
Hello, I was having a look at the mouse events that the guest receives, and was surprised to get pos x:452 y:220 z:0 pos x:452 y:220 z:0 pos x:452 y:220 z:0

Re: [Qemu-devel] Keymap selection not working properly

2008-02-26 Thread Samuel Thibault
Thomas Petazzoni, le Tue 26 Feb 2008 14:51:21 +0100, a écrit : > I'm using Qemu 0.9.0 on Kubuntu, and I have issues with the keymap > selection: How is the guest configured? Samuel

[Qemu-devel] [PATCH] Let the USB tablet reach the far bottom and right pixels

2008-02-27 Thread Samuel Thibault
Hello, While using a virtual usbtablet, I noticed that I could not reach the extreme bottom and right pixels. That is because of the conversion from screen coordinates to 0..0x7FFF, below is a patch that fixes it. Samuel Index: cocoa.m ===

Re: [Qemu-devel] [PATCH] Let the USB tablet reach the far bottom and right pixels

2008-02-27 Thread Samuel Thibault
Johannes Schindelin, le Wed 27 Feb 2008 15:35:01 +, a écrit : > > Index: cocoa.m > > === > > RCS file: /sources/qemu/qemu/cocoa.m,v > > retrieving revision 1.15 > > diff -u -p -r1.15 cocoa.m > > --- cocoa.m 22 Jan 2008 23:25:15 -00

[Qemu-devel] Re: [PATCH] Let the USB tablet reach the far bottom and right pixels

2008-03-05 Thread Samuel Thibault
Hello, No news about this patch, could someone apply it? Samuel Samuel Thibault, le Wed 27 Feb 2008 14:45:55 +, a écrit : > While using a virtual usbtablet, I noticed that I could not reach the > extreme bottom and right pixels. That is because of the conversion from > screen co

[Qemu-devel] [PATCH] fix SDL mouse events processing

2008-03-05 Thread Samuel Thibault
Hello, The patch below fixes SDL mouse events processing: - GetRelativeMouseState always returns the last position, so when the polling loop gets several mouse events in one go, we would send useless 'no move' events. - So as to make sure we don't miss any mouse click / double click, we shou

Re: [Qemu-devel] [PATCH] fix SDL mouse events processing

2008-03-05 Thread Samuel Thibault
Johannes Schindelin, le Wed 05 Mar 2008 14:09:10 +0100, a écrit : > What is this good for? (I imagine that it would make sense to add a > comment to document why this is here, for clueless people like me.) > > Maybe it is to initialise the state of the mouse buttons? That's it. > This means th

Re: [Qemu-devel] [PATCH] fix SDL mouse events processing

2008-03-05 Thread Samuel Thibault
Here is a revamped patch: This fixes SDL mouse events processing: - GetRelativeMouseState() always returns the last position, so when the polling loop gets several mouse events in one go, we would send useless 'no move' events, let's avoid that. - So as to make sure we don't miss any mouse cli

[Qemu-devel] Re: [PATCH] Slowdown SDL while minimized

2008-03-11 Thread Samuel Thibault
BTW, it would be good for power consumption to provide a virtual HPET to the guest, and reprogram the host timer as appropriate. 10ms sleeps kill kitten ;) Samuel

[Qemu-devel] [PATCH] Slowdown SDL while minimized

2008-03-11 Thread Samuel Thibault
When SDL is invisible/minimized, there is no need to keep calling the VGA refresh 33 times per second. This patch reduces in that case the rate to 2 times per second, which should be responsive enough for the un-minimizing event. Index: console.h ==

Re: [Qemu-devel] [PATCH] Slowdown SDL while minimized

2008-03-11 Thread Samuel Thibault
Anders, le Wed 12 Mar 2008 00:56:42 +0100, a écrit : > Samuel Thibault wrote: > >When SDL is invisible/minimized, there is no need to keep calling the > >VGA refresh 33 times per second. This patch reduces in that case the > >rate to 2 times per second, which should be resp

<    1   2   3   4   5   6   7   8   9   10   >