[Qemu-devel] [Bug 932487] Re: win32: git rev 59f971d crashes when accessing disk (coroutine issue)

2012-02-16 Thread Stefan Weil
** Changed in: qemu Status: New => Confirmed ** Changed in: qemu Assignee: (unassigned) => Stefan Weil (ubuntu-weilnetz) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/932487

[Qemu-devel] [Bug 932487] Re: win32: git rev 59f971d crashes when accessing disk (coroutine issue)

2012-02-16 Thread Stefan Weil
ds the compiler flag needed for multithreading: --extra-cflags="-O0 -pipe -mthreads". For me, -mthreads solved the problem. Regards, Stefan Weil -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bu

Re: [Qemu-devel] [PATCH] virtfs-proxy-helper: check return code of setfsgid/setfsuid

2012-10-10 Thread Stefan Weil
Am 10.10.2012 13:32, schrieb Paolo Bonzini: Fixes the following error with glibc 2.16 on Fedora 18: virtfs-proxy-helper.c: In function ‘setfsugid’: virtfs-proxy-helper.c:293:13: error: ignoring return value of ‘setfsgid’, declared with attribute warn_unused_result [-Werror=unused-result] virtfs

Re: [Qemu-devel] [PATCH] virtfs-proxy-helper: check return code of setfsgid/setfsuid

2012-10-10 Thread Stefan Weil
Am 10.10.2012 18:17, schrieb Paolo Bonzini: Il 10/10/2012 18:14, Stefan Weil ha scritto: diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev/virtfs-proxy-helper.c index f9a8270..b34a84a 100644 --- a/fsdev/virtfs-proxy-helper.c +++ b/fsdev/virtfs-proxy-helper.c @@ -290,8 +290,12 @@ static int

Re: [Qemu-devel] [PATCH v2] virtfs-proxy-helper: check return code of setfsgid/setfsuid

2012-10-10 Thread Stefan Weil
Am 10.10.2012 18:19, schrieb Paolo Bonzini: Fixes the following error with glibc 2.16 on Fedora 18: virtfs-proxy-helper.c: In function ‘setfsugid’: virtfs-proxy-helper.c:293:13: error: ignoring return value of ‘setfsgid’, declared with attribute warn_unused_result [-Werror=unused-result] virtfs

Re: [Qemu-devel] [PATCH] virtfs-proxy-helper: check return code of setfsgid/setfsuid

2012-10-10 Thread Stefan Weil
Am 10.10.2012 18:36, schrieb Paolo Bonzini: Il 10/10/2012 18:23, Stefan Weil ha scritto: < 0 would be wrong because it looks like both functions never return negative values. I just wrote a small test program (see below) and called it with different uids with and without root rights. T

Re: [Qemu-devel] [PATCH] virtfs-proxy-helper: check return code of setfsgid/setfsuid

2012-10-10 Thread Stefan Weil
Am 10.10.2012 18:54, schrieb Stefan Weil: Am 10.10.2012 18:36, schrieb Paolo Bonzini: Il 10/10/2012 18:23, Stefan Weil ha scritto: < 0 would be wrong because it looks like both functions never return negative values. I just wrote a small test program (see below) and called it with differ

[Qemu-devel] [PATCH] configure: Remove unused parameters from main function

2012-10-14 Thread Stefan Weil
This modification is required if compiler option -Wunused-parameter is activated. Signed-off-by: Stefan Weil --- configure |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 353d788..499ad81 100755 --- a/configure +++ b/configure @@ -1323,7

Re: [Qemu-devel] [PATCH] configure: Disable (clang) initializer-overrides warnings

2012-10-16 Thread Stefan Weil
Am 14.10.2012 22:24, schrieb Peter Maydell: On 14 October 2012 21:15, Blue Swirl wrote: On Sun, Oct 14, 2012 at 8:00 PM, Peter Maydell wrote: Blue Swirl previously submitted a patch which enabled this flag (among others): http://lists.gnu.org/archive/html/qemu-devel/2012-07/msg04203.html In

[Qemu-devel] [PATCH] net/tap-win32: Fix compiler warning caused by missing include statement

2012-10-17 Thread Stefan Weil
The include file for net_init_tap was missing: net/tap-win32.c:703: warning: no previous prototype for ‘net_init_tap’ Signed-off-by: Stefan Weil --- net/tap-win32.c |1 + 1 file changed, 1 insertion(+) diff --git a/net/tap-win32.c b/net/tap-win32.c index f1801e2..22dad3f 100644 --- a/net

Re: [Qemu-devel] [PATCH 1/6] qdev: rework device properties.

2012-10-17 Thread Stefan Weil
x27;s the license they assumed for the file > and their contributions. I prefer and assumed GPL2+ because that is kind of standard for many files of QEMU, but would not mind any other free licenses like LGPL2+, BSD or Public Domain for hw/qdev-properties.c Regards Stefan Weil

Re: [Qemu-devel] [PATCH] ui/vnc-jobs.c: Fix minor typos in comments

2012-10-18 Thread Stefan Weil
t, so we can easilly add more than one encoding thread + * already reentrant, so we can easily add more than one encoding thread */ static VncJobQueue *queue; Reviewed-by: Stefan Weil Cheers Stefan

Re: [Qemu-devel] [PATCH v2] ui/vnc-jobs.c: Fix minor typos in comments

2012-10-18 Thread Stefan Weil
Am 18.10.2012 18:40, schrieb Peter Maydell: Fix some minor typos/grammar errors in comments. Signed-off-by: Peter Maydell --- v1->v2: reinstated carelessly dropped 'if', noted by Stefan Weil. ui/vnc-jobs.c | 16 1 file changed, 8 insertions(+), 8 deletions(-

Re: [Qemu-devel] [PATCH] main: Hide F_GETFD and FD_CLOEXEC use for _WIN32

2012-10-22 Thread Stefan Weil
h the one which adds that code and not applied as a separate patch (otherwise git bisect would be broken). Regards Stefan Weil

Re: [Qemu-devel] [PATCH] win32: fix broken build due to missing QEMU_MADV_HUGEPAGE

2012-10-25 Thread Stefan Weil
#endif Reviewed-by: Stefan Weil This is a build fix for latest QEMU. Please apply it as soon as possible. Regards Stefan Weil

Re: [Qemu-devel] [PATCH] configure: Disable (clang) initializer-overrides warnings

2012-10-27 Thread Stefan Weil
onfigure in the usual environment with gcc (but not with clang). Regards Stefan Weil

Re: [Qemu-devel] [PATCH] configure: use -Wwombat to test whether gcc recognizes -Wno-wombat

2012-10-27 Thread Stefan Weil
uot; +if compile_prog "-Werror $optflag" "" ; then QEMU_CFLAGS="$QEMU_CFLAGS $flag" fi done Yes, that's really a very simple and working solution. Reviewed-by: Stefan Weil

Re: [Qemu-devel] [PATCH] configure: Disable (clang) initializer-overrides warnings

2012-10-27 Thread Stefan Weil
Am 27.10.2012 23:35, schrieb Peter Maydell: On 27 October 2012 22:24, Stefan Weil wrote: Am 27.10.2012 22:32, schrieb Igor Mitsyanko: I encountered strange behavior of latest mingw gcc, it ignores unrecognized -Wno-wombat options only in case if no other warnings are issued (configure

Re: [Qemu-devel] 64-on-32 TCG broken

2012-10-30 Thread Stefan Weil
Am 30.10.2012 09:15, schrieb Paolo Bonzini: Il 29/10/2012 19:29, Aurelien Jarno ha scritto: On Mon, Oct 29, 2012 at 06:53:14PM +0100, Paolo Bonzini wrote: Known-good commit: 8473f377393219390ea6f2d8d450a2b054bb823e Known-bad commit: d262cb02861dd33375c08fc798930653b14769e9 i386-softmmu seems t

[Qemu-devel] [PATCH] configure: Fix typo

2012-06-18 Thread Stefan Weil
The typo did not cause an error because open_by_handle_at was only compared to "yes". Signed-off-by: Stefan Weil --- configure |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 5d73c82..20a0fd3 100755 --- a/configure +++ b/configure

Re: [Qemu-devel] [PATCH] tci: don't write zero for reloc in tci_out_label

2012-06-18 Thread Stefan Weil
Am 19.06.2012 04:31, schrieb Scott Wood: If tci_out_label is called in the context of tcg_gen_code_search_pc, we could be overwriting an already patched relocation with zero -- and not repatch it because the set_label is past search_pc, causing a QEMU crash when it tries to branch to a zero label

Re: [Qemu-devel] [PATCH] Fixes related to processing of qemu's -numa option

2012-06-19 Thread Stefan Weil
qemu-devel was no longer cc'ed, let us add it again. Cheers, Stefan Am 19.06.2012 22:35, schrieb Eduardo Habkost: On Tue, Jun 19, 2012 at 04:33:35AM -0700, Chegu Vinod wrote: [...] +#include Did you check whether this and the macros you're using are available on POSIX and ming

[Qemu-devel] [PATCH] target-i386: Use QEMU instead of Qemu

2012-06-19 Thread Stefan Weil
This new 'QEmu' was recently added. Replace it by the official all upper case 'QEMU'. Signed-off-by: Stefan Weil --- Hopefully those 'Qemu' and 'QEmu' variants will stop as soon as my patch for checkpatch.pl was applied. target-i386/cpu.c |2 +- 1

Re: [Qemu-devel] [PATCH] tci: don't write zero for reloc in tci_out_label

2012-06-20 Thread Stefan Weil
Am 19.06.2012 20:02, schrieb Blue Swirl: On Tue, Jun 19, 2012 at 5:53 AM, Stefan Weil wrote: Am 19.06.2012 04:31, schrieb Scott Wood: If tci_out_label is called in the context of tcg_gen_code_search_pc, we could be overwriting an already patched relocation with zero -- and not repatch it

[Qemu-devel] [PATCH] tci: Support INDEX_op_bswap64_i64

2012-06-20 Thread Stefan Weil
Running the Windows 7 (64 bit) boot process needs INDEX_op_bswap64_i64. It was already implemented, but untested. Remove the TODO() statement. Signed-off-by: Stefan Weil --- tci.c |1 - 1 file changed, 1 deletion(-) diff --git a/tci.c b/tci.c index e40c080..01d365a 100644 --- a/tci.c +++ b

[Qemu-devel] [RFC] QEMU mailing list changes

2012-06-21 Thread Stefan Weil
less frequently used lists (Qemu-commits, Qemu-stable). If that works well, the rest can be renamed. I'd also like to have descriptions of the QEMU related mailing lists. The listinfo (link above) shows none today, but it could be added easily by the list maintainer(s). Regards, Stefan Weil

[Qemu-devel] [PATCH] make: Fix dependencies for fpu/*.c and tcg/*.c

2012-06-21 Thread Stefan Weil
Commit dcff25f2cd8c11a9368cc2369aeb0319c32d9e26 removed too many *.d files. The directories fpu/ and tcg/ still don't use the recursive subdir rules. Signed-off-by: Stefan Weil --- Makefile.target |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.tar

[Qemu-devel] [PATCH] qemu-log: Add GCC format attribute

2012-06-23 Thread Stefan Weil
The new inline function qemu_log_vprintf should use this attribute. Signed-off-by: Stefan Weil --- qemu-log.h |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qemu-log.h b/qemu-log.h index 40f8b7b..db0f23d 100644 --- a/qemu-log.h +++ b/qemu-log.h @@ -51,7 +51,8 @@ void

[Qemu-devel] [PATCH] target-ppc: Fix build with --enable-debug

2012-06-24 Thread Stefan Weil
The order of the arguments was wrong (copy+paste error). Signed-off-by: Stefan Weil --- Hi Alex, hi Blue, there is still one more bug for target-ppc with --enable-debug, so strictly speaking, the subject is not correct: the patch fixes the build only partially. Regards, Stefan target-ppc

[Qemu-devel] [PATCH] target-ppc: Fix 2nd parameter for tcg_gen_shri_tl

2012-06-24 Thread Stefan Weil
This fixes a compiler error when QEMU was configured with --enable-debug. Signed-off-by: Stefan Weil --- Alex, please review. It fixes the compiler error, but I did the change simply by comparision with other functions, so I have no idea whether it is really correct. Regards, Stefan target

Re: [Qemu-devel] [PATCH] target-i386: implement FPREM and FPREM1 using softfloat only

2012-06-27 Thread Stefan Weil
Am 28.06.2012 01:00, schrieb Catalin Patulea: Hey guys, I've been hacking up the FPREM and FPREM1 i386 instructions (without KVM) to be implemented using SoftFloat only. This was motivated by some correctness issues that we noticed with the current implementation which follows the AMD datasheet

[Qemu-devel] [PATCH] configure: Remove help for --disable-vnc-thread, --enable-vnc-thread

2012-06-28 Thread Stefan Weil
Commit 2624bab836662d37f08336408a99d97652fc9c4d removed these configure arguments. Now the help text for both is removed, too. Signed-off-by: Stefan Weil --- configure |2 -- 1 file changed, 2 deletions(-) diff --git a/configure b/configure index 1459c52..c3e09fc 100755 --- a/configure

[Qemu-devel] Build broken for i386-softmmu with --enable-debug

2012-06-28 Thread Stefan Weil
Hi Blue, commit c4baa0503d9623f1ce891f525ccd140c598bc29a improved SSE table type safety which now raises compiler errors when latest QEMU was configured with --enable-debug. CC i386-softmmu/target-i386/translate.o cc1: warnings being treated as errors /qemu/target-i386/translate.c: In function ‘

Re: [Qemu-devel] [PATCH] target-i386: fix build with -Werror

2012-06-29 Thread Stefan Weil
Am 29.06.2012 08:41, schrieb Dunrong Huang: Commit c4baa0503d9623f1ce891f525ccd140c598bc29a improved SSE table type safety but raises compile error of incompatible pointer type. Fix it by casting to correct function type Signed-off-by: Dunrong Huang --- target-i386/translate.c | 22 ++

[Qemu-devel] [PATCH] target-i386: Fix compilation with --enable-debug

2012-06-29 Thread Stefan Weil
calling address 0, the code now jumps to label illegal_op. Signed-off-by: Stefan Weil --- target-i386/translate.c | 59 +++ 1 file changed, 34 insertions(+), 25 deletions(-) diff --git a/target-i386/translate.c b/target-i386/translate.c index a902f4a

Re: [Qemu-devel] [PATCH] target-i386: Fix compilation with --enable-debug

2012-06-30 Thread Stefan Weil
Am 30.06.2012 14:16, schrieb Dunrong Huang: 2012/6/30 Stefan Weil : commit c4baa0503d9623f1ce891f525ccd140c598bc29a improved SSE table type safety which now raises compiler errors when latest QEMU was configured with --enable-debug. The error occurs when building with --enable-werror, which

Re: [Qemu-devel] Bad mail header? (was: [PATCH 01/12] savevm: Use a struct to pass all handlers)

2012-06-30 Thread Stefan Weil
Am 28.06.2012 21:21, schrieb Juan Quintela: This would make easier to add more operations in the next patches. Signed-off-by: Juan Quintela --- savevm.c | 54 +- vmstate.h | 7 +++ 2 files changed, 32 insertions(+), 29 deletions(-) Hi Ju

Re: [Qemu-devel] [PATCH] console: Implementing blinking of cursor

2012-07-03 Thread Stefan Weil
Am 02.07.2012 10:20, schrieb Jan Kiszka: Let the text console cursor blink at 5 HZ. Signed-off-by: Jan Kiszka --- console.c | 26 +- 1 files changed, 25 insertions(+), 1 deletions(-) Hi Jan, I know that there was a "bug" report. Nevertheless I'd like to ask whether QE

Re: [Qemu-devel] [PATCH v2] vga: Implement blinking of text cursor

2012-07-04 Thread Stefan Weil
Hi Jan, please see my comments below. Am 04.07.2012 15:40, schrieb Jan Kiszka: Let the text cursor blink at 5 Hz. No timer is used, instead we rely on the fact that the display is updated periodically. Signed-off-by: Jan Kiszka --- Changes in v2: - avoid full screen updates for cursor blin

Re: [Qemu-devel] [PATCH 1/3] target-i386: Remove unused macros

2012-07-05 Thread Stefan Weil
n some opcodes, so we cannot use them */ -#if 1 -#define BUGGY_64(x) NULL -#endif #else -#define X86_64_ONLY(x) NULL #define X86_64_DEF(...) #define CODE64(s) 0 #define REX_X(s) 0 Reviewed-by: Stefan Weil

Re: [Qemu-devel] [PATCH 3/3] target-i386: make it clearer that op table accesses don't overrun

2012-07-05 Thread Stefan Weil
a 2-dimensional array would make that code even more readable: sse_op_table3bq[(b >> 8) & 1][b & 1]; Anyway, you may add a Reviewed-by: Stefan Weil Regards, Stefan W.

Re: [Qemu-devel] [PATCH v4] bitops.h: Add functions to extract and deposit bitfields

2012-07-08 Thread Stefan Weil
Am 08.07.2012 12:01, schrieb Peter Maydell: On 8 July 2012 10:55, Lluís Vilanova wrote: Wouldn't it be better to use "unsigned int" instead on all the "start" and "length" arguments? See the arguments about this on one of the previous patch series: http://lists.gnu.org/archive/html/qemu-devel/

[Qemu-devel] [PATCH] bitops: Fix documentation

2012-07-08 Thread Stefan Weil
Signed-off-by: Stefan Weil --- bitops.h |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/bitops.h b/bitops.h index b967ef3..c456232 100644 --- a/bitops.h +++ b/bitops.h @@ -319,8 +319,8 @@ static inline uint64_t extract64(uint64_t value, int start, int length

Re: [Qemu-devel] [PATCH] place qemu-sockets.c contributions since 2012-01-13 under GPLv2+

2012-07-09 Thread Stefan Weil
o the patch is valid. Reviewed-by: Stefan Weil

Re: [Qemu-devel] [Bug 1022331] Re: -cpu ? causes confusion when directory has 1-character length filenames

2012-07-09 Thread Stefan Weil
Am 09.07.2012 10:27, schrieb Daniel Berrange: On Sun, Jul 08, 2012 at 11:45:34PM +0100, Peter Maydell wrote: On 8 July 2012 20:44, Michael Tokarev<1022...@bugs.launchpad.net> wrote: Please take this to your shell. The queston mark is a metacharacter for any *nix shell, you should just quote o

Re: [Qemu-devel] [v1 Patch 0/10]Qemu: Dynamic host pagecache change and image file reopen

2012-07-09 Thread Stefan Weil
atch on this mailing list is for QEMU, so there is no need to start the summaries of indiviual patches with "QEMU:". You could start them with "block:" or take a look in the files' history to see what other people used. Regards Stefan Weil

[Qemu-devel] [PATCH] make: Remove 'build-all' rule

2012-07-09 Thread Stefan Weil
It is not needed, because the 'all' rule does the same. Signed-off-by: Stefan Weil --- Makefile |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index bad0e31..76dae56 100644 --- a/Makefile +++ b/Makefile @@ -6,7 +6,7 @@ BUILD_DIR=$(CURD

[Qemu-devel] [PATCH] megasas: Fix compilation for 32 bit hosts

2012-07-09 Thread Stefan Weil
Cc: Hannes Reinecke Signed-off-by: Stefan Weil --- default-configs/pci.mak |4 hw/megasas.c| 13 +++-- 2 files changed, 11 insertions(+), 6 deletions(-) diff --git a/default-configs/pci.mak b/default-configs/pci.mak index 9d3e1db..120b69d 100644 --- a/default

Re: [Qemu-devel] [PATCH] megasas: Fix compilation for 32 bit hosts

2012-07-09 Thread Stefan Weil
Am 10.07.2012 08:00, schrieb Hannes Reinecke: Hi Stefan, you might've seen that Anthony objected to this in general. Apparently I'm not allowed to use the instance address to seed the SAS address. So yes, your fix is valid, but might be pointless as I might have to re-do this section anyway. Bu

Re: [Qemu-devel] [PATCH 4/5] Avoid unportable %m format

2012-07-10 Thread Stefan Weil
he patch should result in identical behaviour with Glibc. It improves the situation for all platforms which don't use Glibc. In theory, strerror_r() might be more correct, but in the typical practical scenarios (error output before abort) it is not really needed. Regards, Stefan Weil

[Qemu-devel] [PATCH] iov: Fix do_send_recv() for MinGW (also fixes a build breakage)

2012-07-10 Thread Stefan Weil
Commit 25e5e4c7 broke compilation for non POSIX hosts (e.g. MinGW) because it partially replaced "ret" by "count". It also changed the handling of EINTR in a wrong way. The patch restores the old code for these two changes. Signed-off-by: Stefan Weil --- iov.c | 11

Re: [Qemu-devel] [PATCH] NVMe: Initial commit to add an NVM Express device

2012-12-07 Thread Stefan Weil
on with MinGW-w64 fails: qemu/hw/nvme.c:61:22: fatal error: sys/mman.h: No such file or directory compilation terminated. make: *** [hw/nvme.o] Error 1 I expect that the pthread stuff will also be missing for MinGW-w64. Regards Stefan Weil

Re: [Qemu-devel] [PATCH] NVMe: Initial commit to add an NVM Express device

2012-12-07 Thread Stefan Weil
Compilation on 32 bit Linux results in lots of warnings caused by wrong format specifiers. Please don't add type casts, but try to use the format specifiers needed (PRIu64, ...). CChw/nvme.o /qemu/hw/nvme.c: In function 'nvme_init_file': /qemu/hw/nvme.c:834:5: error: format '%lu' expects arg

Re: [Qemu-devel] buildbot failure in qemu on default_x86_64_debian_6_0

2012-12-08 Thread Stefan Weil
Am 08.12.2012 23:03, schrieb q...@buildbot.b1-systems.de: The Buildbot has detected a new failure on builder default_x86_64_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_x86_64_debian_6_0/builds/474 Buildbot URL: http://bui

[Qemu-devel] [PATCH] Fix spelling (transfered -> transferred, supressing -> suppressing)

2012-12-09 Thread Stefan Weil
These spellings were found and fixed by codespell. Signed-off-by: Stefan Weil --- hw/usb.h |6 +++--- tests/qemu-iotests/iotests.py |2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/usb.h b/hw/usb.h index 7d6de69..f05eb17 100644 --- a/hw/usb.h

Re: [Qemu-devel] [PATCH] Fix spelling (transfered -> transferred, supressing -> suppressing)

2012-12-09 Thread Stefan Weil
Am 09.12.2012 22:31, schrieb Stefan Weil: These spellings were found and fixed by codespell. Signed-off-by: Stefan Weil --- hw/usb.h |6 +++--- tests/qemu-iotests/iotests.py |2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/usb.h b/hw

Re: [Qemu-devel] [PATCH 4/4] linux-user/syscall.c: remove wrong forward decl of setgroups()

2012-12-09 Thread Stefan Weil
tgroups by an include statement using grp.h. That's fine. Reviewed-by: Stefan Weil There are more extern declarations in linux-user/syscall.c. Even if they are correct, they should be replaced by include statements. If there will be a v2 of your patch series, you could add patches for those de

Re: [Qemu-devel] [PATCH 1/4] fix implicit declaration of syscall() in linux-user/mmap.c

2012-12-10 Thread Stefan Weil
is to the musl developers. Regards Stefan Weil

Re: [Qemu-devel] [PATCH 2/4] fix build error on ARM due to wrong glibc check

2012-12-10 Thread Stefan Weil
__GLIBC__< 2 || (__GLIBC__ == 2&& __GLIBC_MINOR__<= 3)) +#if defined(__GLIBC__)&& (__GLIBC__< 2 || (__GLIBC__ == 2&& __GLIBC_MINOR__<= 3)) pc = uc->uc_mcontext.gregs[R15]; #else pc = uc->uc_mcontext.arm_pc; Reviewed-by: Stefan Weil

Re: [Qemu-devel] [PATCH 4/4] linux-user/syscall.c: remove wrong forward decl of setgroups()

2012-12-10 Thread Stefan Weil
64bit types aligned even on pairs or registers */ #ifdef TARGET_ARM Reviewed-by: Stefan Weil

Re: [Qemu-devel] [PATCH 3/4] fix implicit declaration of syscall() in linux-user/syscall.c

2012-12-10 Thread Stefan Weil
Am 10.12.2012 07:59, schrieb John Spencer: Signed-off-by: John Spencer --- linux-user/syscall.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 31d5276..fabbcd7 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscal

Re: [Qemu-devel] [PATCH 3/4] fix implicit declaration of syscall() in linux-user/syscall.c

2012-12-10 Thread Stefan Weil
Am 11.12.2012 02:23, schrieb John Spencer: On 12/10/2012 06:49 PM, Stefan Weil wrote: Am 10.12.2012 07:59, schrieb John Spencer: +#include This is a workaround for a missing declaration of function syscall in musl's unistd.h. See my comment to patch 1 for more information. thank

Re: [Qemu-devel] [PATCH 1/3] Fix my email address

2012-12-11 Thread Stefan Weil
email address are known to be volatile. Even email addresses at redhat.com (or other companies) are only valid as long as the owner is related to RedHat. Regards Stefan Weil

Re: [Qemu-devel] [RFC PATCH] Allow building without graphics support

2012-12-11 Thread Stefan Weil
Hi, cross compilation works for me with the internal pixman. Here is an example which I use to compile Windows 64 bit executables on Debian: ./configure' '--cross-prefix=amd64-mingw32msvc-' Are there still problems with cross compilation in latest QEMU? Regards, Stefan Weil

Re: [Qemu-devel] [PATCH 1/3] Fix my email address

2012-12-12 Thread Stefan Weil
to find authors by looking at the Signed-off-by in the commit message or by searching the QEMU wiki or other sources of information. Stefan Weil 2012/12/12 Stefan Weil mailto:s...@weilnetz.de>> Am 11.12.2012 15:28, schrieb Dongxue Zhang: Fix my email address,

Re: [Qemu-devel] [RFC PATCH] Allow building without graphics support

2012-12-12 Thread Stefan Weil
Am 13.12.2012 01:48, schrieb Scott Wood: On 12/12/2012 12:46:44 AM, Stefan Weil wrote: Am 12.12.2012 04:18, schrieb Scott Wood: QEMU is sometimes used in embedded contexts, where graphical support is unnecessary. The ability to turn off graphics support not only saves some space, but it

Re: [Qemu-devel] [RFC PATCH] Allow building without graphics support

2012-12-13 Thread Stefan Weil
Am 13.12.2012 16:53, schrieb Scott Wood: On 12/13/2012 12:31:14 AM, Stefan Weil wrote: Am 13.12.2012 01:48, schrieb Scott Wood: It doesn't seem to like my --cross-prefix being a full path rather than being a recognized target pattern: checking host system type... Invalid configur

Re: [Qemu-devel] [PATCH 0/5] pixman patch queue

2012-12-14 Thread Stefan Weil
Am 14.12.2012 08:54, schrieb Gerd Hoffmann: Hi, Pixman patch queue, fixing vnc tight/png and tackeling build issues. cheers, Gerd Gerd Hoffmann (5): pixman: fix version check for PIXMAN_TYPE_BGRA Revert "pixman: require 0.18.4 or newer" pixman: update internal copy to pixman-0.2

[Qemu-devel] [PATCH] block: Probe file for specified format

2012-12-15 Thread Stefan Weil
://bugs.launchpad.net/qemu/+bug/1090600 Signed-off-by: Stefan Weil --- This patch can also be used for the latest stable version of QEMU. blockdev.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/blockdev.c b/blockdev.c index 9a05e57..5a4cd56 100644 --- a/blockdev.c +++ b/blockdev.c @@ -411,6

[Qemu-devel] [Bug 1090600] Re: Improve error reporting when -drive format= is incorrect

2012-12-15 Thread Stefan Weil
** Changed in: qemu Assignee: (unassigned) => Stefan Weil (ubuntu-weilnetz) ** Changed in: qemu Status: New => In Progress -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1090600

Re: [Qemu-devel] [PATCH] block: Probe file for specified format

2012-12-15 Thread Stefan Weil
Am 15.12.2012 12:35, schrieb Stefan Weil: Probe for the file format if the file format was specified explicitly and a probe function is available. example: -drive file=myfile,format=qcow2 Then myfile is probed and must be in qcow2 format. This fixes those bugs: https://bugzilla.redhat.com

[Qemu-devel] [PATCH 0/4] block: Fix error report for wrong file format

2012-12-15 Thread Stefan Weil
These patches improve the error report if the file format was specified explicitly (example: -drive file=myfile,format=qcow2) and the given format does not match the real format. This fixes those bugs: https://bugzilla.redhat.com/show_bug.cgi?id=556482 https://bugs.launchpad.net/qemu/+bug/1090600

[Qemu-devel] [PATCH 4/4] block/vdi: Improved return values from vdi_open and other small fixes

2012-12-15 Thread Stefan Weil
: Stefan Weil --- block/vdi.c | 25 - 1 file changed, 20 insertions(+), 5 deletions(-) diff --git a/block/vdi.c b/block/vdi.c index c8330b7..7c7699f 100644 --- a/block/vdi.c +++ b/block/vdi.c @@ -246,7 +246,7 @@ static void vdi_header_print(VdiHeader *header) { char

[Qemu-devel] [PATCH 3/4] block: Use new error code for wrong format in selected block drivers

2012-12-15 Thread Stefan Weil
This improves error reports for bochs, cow, qcow, qcow2, qed and vmdk when a file with the wrong format is selected. Signed-off-by: Stefan Weil --- block/bochs.c |2 +- block/cow.c |2 +- block/qcow.c |2 +- block/qcow2.c |2 +- block/qed.c |2 +- block/vmdk.c |4

[Qemu-devel] [PATCH 2/4] block: Improve error report for wrong format

2012-12-15 Thread Stefan Weil
There is no good system error for this kind of error, so it needs special handling instead of strerror. Signed-off-by: Stefan Weil --- blockdev.c |9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/blockdev.c b/blockdev.c index 5a4cd56..3da44f6 100644 --- a

[Qemu-devel] [PATCH 1/4] block: Add special error code for wrong format

2012-12-15 Thread Stefan Weil
The block drivers normally return -errno for typical errors. There is no appropriate error code for "wrong format", so use a special error code which does not conflict with system error codes. Signed-off-by: Stefan Weil --- block.h |7 +++ 1 file changed, 7 insertions(+) di

[Qemu-devel] [PATCH] configure: Earlier pkg-config probe

2012-12-16 Thread Stefan Weil
Probe pkg-config before it is used for the first time (libseccomp check). Signed-off-by: Stefan Weil --- configure | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/configure b/configure index ecdb33a..728caca 100755 --- a/configure +++ b/configure

[Qemu-devel] [PATCH] block/raw-win32: Fix compiler warnings (wrong format specifiers)

2012-12-17 Thread Stefan Weil
Commit fbcad04d6bfdff937536eb23088a01a280a1a3af added fprintf statements with wrong format specifiers. GetLastError() returns a DWORD which is unsigned long, so %lu must be used. Signed-off-by: Stefan Weil --- Do we want those fprintf statements here at all? - Stefan block/raw-win32.c

Re: [Qemu-devel] (bisected): Is mips-user broken on 64bit host since v1.1?

2012-12-18 Thread Stefan Weil
that I run user emulation very rarely. Nevertheless it should be possible to add some statically linked binaries for each architecture to the buildbot machines and add tests which run these binaries. Regards, Stefan Weil

[Qemu-devel] [PATCH] pseries: Remove unneeded include statement (fixes MinGW builds)

2012-12-19 Thread Stefan Weil
sys/mman.h is not needed (tested on Linux) and unavailable for MinGW, so remove it. Signed-off-by: Stefan Weil --- hw/spapr_nvram.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/spapr_nvram.c b/hw/spapr_nvram.c index f20f6b4..680cdba 100644 --- a/hw/spapr_nvram.c

[Qemu-devel] [PATCH] pseries: Remove unneeded include statement (fixes MinGW builds)

2012-12-19 Thread Stefan Weil
sys/mman.h is not needed (tested on Linux) and unavailable for MinGW, so remove it. Signed-off-by: Stefan Weil --- hw/spapr_nvram.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/spapr_nvram.c b/hw/spapr_nvram.c index f20f6b4..680cdba 100644 --- a/hw/spapr_nvram.c

[Qemu-devel] [PATCH] net: Add missing include statement (fix compiler warnings for MinGW)

2012-12-20 Thread Stefan Weil
These and some more compiler warnings were caused by a recent commit: net/tap-win32.c:724: warning: no previous prototype for ‘tap_has_ufo’ net/tap-win32.c:729: warning: no previous prototype for ‘tap_has_vnet_hdr’ ... Signed-off-by: Stefan Weil --- net/tap-win32.c |1 + 1 file changed, 1

[Qemu-devel] [PATCH] target-mips: Remove semicolon from macro definition

2012-12-22 Thread Stefan Weil
Macro RESTORE_FLUSH_MODE is similar to RESTORE_ROUNDING_MODE but included a semicolon. The code which uses that macro also includes a semicolon, so the result was an empty statement. Remove the superfluous semicolon from the macro definition. Signed-off-by: Stefan Weil --- Note: After the

[Qemu-devel] [PATCH] hw/mcf5206: Reduce size of lookup table

2012-12-22 Thread Stefan Weil
This typically reduces the size from 512 bytes to 128 bytes. Signed-off-by: Stefan Weil --- hw/mcf5206.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/mcf5206.c b/hw/mcf5206.c index fe7a488..d8c0059 100644 --- a/hw/mcf5206.c +++ b/hw/mcf5206.c @@ -359,7 +359,7

Re: [Qemu-devel] [PATCH] linux-user/syscall.c: remove forward declarations

2012-12-25 Thread Stefan Weil
Am 26.12.2012 00:49, schrieb John Spencer: instead use the correct headers that define these functions. Requested-by: Stefan Weil Signed-off-by: John Spencer --- linux-user/syscall.c |8 +++- 1 files changed, 3 insertions(+), 5 deletions(-) diff --git a/linux-user/syscall.c b

[Qemu-devel] [PATCH] tcg: Remove unneeded assertion

2012-12-29 Thread Stefan Weil
Commit 7f6f0ae5b95adfa76e10eabe2c34424a955fd10c added two assertions. One of these assertions is not needed: The pointer ts is never NULL because it is initialized with the address of an array element. Signed-off-by: Stefan Weil --- tcg/tcg.c |1 - 1 file changed, 1 deletion(-) diff --git

[Qemu-devel] [PATCH] configure: Write new file "config-all-disas.mak" when running configure

2013-01-01 Thread Stefan Weil
Incremental builds added new lines to that file each time when configure was run. Now a new file with a comment line is written. Signed-off-by: Stefan Weil --- The file still contains lots of duplicated entries, but they don't cause problems. Regards and happy new year Stefan conf

[Qemu-devel] [PATCH] tci: Fix broken builds with TCG interpreter

2013-01-01 Thread Stefan Weil
TCI no longer compiled after commit 76cad71136b7eb371cf2a2a4e1621cfe8d9c769a. The TCI disassembler depends on data structures which are different for each QEMU target, so it cannot be compiled as a universal-obj today. Signed-off-by: Stefan Weil --- Makefile.target |3 +-- disas

[Qemu-devel] [PATCH] s390x: Remove inline function ebcdic_put and related data from cpu.h

2013-01-01 Thread Stefan Weil
paces to EBCDIC, so there is no problem today. Signed-off-by: Stefan Weil --- target-s390x/cpu.h | 81 target-s390x/misc_helper.c | 81 2 files changed, 81 insertions(+), 81 deletions(-) diff

[Qemu-devel] [PATCH] target-mips: Replace macros by inline functions

2013-01-01 Thread Stefan Weil
The macros RESTORE_ROUNDING_MODE and RESTORE_FLUSH_MODE silently used variable env from their callers. Using inline functions with env passed as a function argument is more transparent. This modification was proposed by Peter Maydell. Cc: Peter Maydell Signed-off-by: Stefan Weil --- target

Re: [Qemu-devel] dataplane build error

2013-01-03 Thread Stefan Weil
Am 03.01.2013 10:30, schrieb Gerd Hoffmann: CChw/dataplane/vring.o cc1: warnings being treated as errors /home/kraxel/projects/qemu/hw/dataplane/vring.c: In function ‘vring_setup’: /home/kraxel/projects/qemu/hw/dataplane/vring.c:46: error: implicit declaration of function ‘trace_vring_setu

Re: [Qemu-devel] [PULL 00/15] s390 patch queue 2013-01-25

2013-01-28 Thread Stefan Weil
Am 28.01.2013 17:06, schrieb Cornelia Huck: > On Sat, 26 Jan 2013 14:17:36 + > Blue Swirl wrote: > >> On Fri, Jan 25, 2013 at 12:48 PM, Alexander Graf wrote: >>> Hi Blue / Aurelien, >>> >>> This is my current patch queue for s390. Please pull. >>> >>> Alex >>> >>> >>> The following changes s

Re: [Qemu-devel] [PULL 00/15] s390 patch queue 2013-01-25

2013-01-28 Thread Stefan Weil
Am 28.01.2013 18:34, schrieb Cornelia Huck: > On Mon, 28 Jan 2013 18:08:10 +0100 > Stefan Weil wrote: > >> Am 28.01.2013 17:06, schrieb Cornelia Huck: >>> On Sat, 26 Jan 2013 14:17:36 + >>> Blue Swirl wrote: >>> >>>> On Fri, Jan 25,

Re: [Qemu-devel] [PATCH] bitops: unify bitops_ffsl with the one in host-utils.h

2013-01-30 Thread Stefan Weil
emu/host-utils.h | 25 - > util/hbitmap.c| 2 +- > 4 files changed, 16 insertions(+), 53 deletions(-) > This patch also fixes MinGW / MinGW-w64 builds which don't have a prototype declaration for ffsl. Tested-by: Stefan Weil Nevertheless I wonder why you don't u

Re: [Qemu-devel] [PATCH] bitops: unify bitops_ffsl with the one in host-utils.h

2013-01-30 Thread Stefan Weil
Am 30.01.2013 18:46, schrieb Paolo Bonzini: > > - Messaggio originale - >> Da: "Stefan Weil" >> A: "Paolo Bonzini" >> Cc: qemu-devel@nongnu.org, blauwir...@gmail.com, "peter maydell" >> >> Inviato: Mercoledì, 30 gennai

Re: [Qemu-devel] [PATCH v2] bitops: unify bitops_ffsl with the one in host-utils.h, using __builtin_ffsl

2013-01-30 Thread Stefan Weil
emu/host-utils.h | 25 - > util/hbitmap.c| 2 +- > 4 files changed, 16 insertions(+), 53 deletions(-) For MinGW / MinGW-w64 builds: Tested-by: Stefan Weil

Re: [Qemu-devel] [PATCH] util: Fix compilation of envlist.c for MinGW

2013-01-30 Thread Stefan Weil
Am 17.01.2013 21:45, schrieb Blue Swirl: On Wed, Jan 16, 2013 at 6:04 PM, Stefan Weil wrote: MinGW has no strtok_r, so we need a declaration in sysemu/os-win32.h. We must also fix the include statements in util/envlist.c to include that file. We currently don't need an implementati

Re: [Qemu-devel] [PATCH] bswap: Don't rely on HOST_LONG_BITS

2013-01-30 Thread Stefan Weil
Am 30.01.2013 21:55, schrieb Richard Henderson: This is not always defined in all places qemu/bswap.h is used. If we include qemu-common.h to get it, we create an include loop. This resolves a build problem on any big-endian host like ppc64. Signed-off-by: Richard Henderson --- include/qemu/bs

Re: [Qemu-devel] [PATCH] bswap: Don't rely on HOST_LONG_BITS

2013-01-30 Thread Stefan Weil
Am 30.01.2013 22:04, schrieb Stefan Weil: Am 30.01.2013 21:55, schrieb Richard Henderson: This is not always defined in all places qemu/bswap.h is used. If we include qemu-common.h to get it, we create an include loop. This resolves a build problem on any big-endian host like ppc64. Signed-off

Re: [Qemu-devel] [PATCH] bswap: Don't rely on HOST_LONG_BITS

2013-01-30 Thread Stefan Weil
Am 30.01.2013 23:00, schrieb Richard Henderson: > On 01/30/2013 01:56 PM, Stefan Weil wrote: >> Could you please try whether this patch fixes the build problems: >> >> >> From 4dd39af7a3e493669977ec6f50e91bf649b5727f Mon Sep 17 00:00:00 2001 >> From: Stefan Weil

<    1   2   3   4   5   6   7   8   9   10   >