[Qemu-devel] [PATCH] vnc: Fix fatal crash with vnc reverse mode

2011-02-16 Thread Stefan Weil
-by: Stefan Weil w...@mail.berlios.de --- ui/vnc.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index da83adf..096b5f3 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -2349,6 +2349,7 @@ static void vnc_init_timer(VncDisplay *vd) vd-timer_interval

[Qemu-devel] Re: [PATCH] Fix trivial endianness bugs

2011-02-16 Thread Stefan Weil
Am 24.01.2011 19:04, schrieb Stefan Weil: Replace endianess - endianness. Signed-off-by: Stefan Weilw...@mail.berlios.de --- audio/sdlaudio.c | 20 ++-- block/vdi.c |4 ++-- hw/xilinx_ethlite.c |2 +- target-microblaze

Re: [Qemu-devel] [PING 0.14] Missing patches (mostly fixes)

2011-02-16 Thread Stefan Weil
Am 04.02.2011 16:27, schrieb Markus Armbruster: Anthony Liguorianth...@codemonkey.ws writes: On 02/02/2011 01:28 PM, Stefan Weil wrote: [...] [PATCH 1/3] tests: Fix two memory leaks (http://patchwork.ozlabs.org/patch/79945/) [PATCH 2/3] check-qdict: Fix possible

Re: [Qemu-devel] Re: Strategic decision: COW format

2011-02-18 Thread Stefan Weil
Am 18.02.2011 10:57, schrieb Kevin Wolf: Am 18.02.2011 10:12, schrieb Markus Armbruster: Kevin Wolf kw...@redhat.com writes: Yet another file format with yet another implementation is definitely not what we need. We should probably take some of the ideas in FVD and consider them for qcow3.

Re: [Qemu-devel] Bugs in the VDI Block Device Driver

2011-02-19 Thread Stefan Weil
Am 19.02.2011 17:21, schrieb Stefan Hajnoczi: On Sat, Feb 19, 2011 at 12:27 PM, Chunqiang Tang ct...@us.ibm.com wrote: I applied FVD's fully automated testing tool to the VDI block device driver and found several bugs. Some bugs are easy to fix whereas others need some thoughts on design.

[Qemu-devel] [PATCH 2/2] block/qcow: Don't ignore immediate read/write and other failures

2011-02-19 Thread Stefan Weil
-by: Stefan Weil w...@mail.berlios.de --- block/qcow.c | 16 1 files changed, 12 insertions(+), 4 deletions(-) diff --git a/block/qcow.c b/block/qcow.c index f67d3d3..a26c886 100644 --- a/block/qcow.c +++ b/block/qcow.c @@ -589,8 +589,10 @@ static void qcow_aio_read_cb(void *opaque, int

[Qemu-devel] [PATCH 1/2] block/vdi: Don't ignore immediate read/write failures

2011-02-19 Thread Stefan Weil
This patch is similar to 171e3d6b9997c98a97d0c525867f7cd9b640cadd which fixed qcow2: Returning -EIO is far from optimal, but at least it's an error code. Cc: Kevin Wolf kw...@redhat.com Signed-off-by: Stefan Weil w...@mail.berlios.de --- block/vdi.c |5 + 1 files changed, 5 insertions

[Qemu-devel] [Bug 721825] Re: VDI block driver bugs

2011-02-20 Thread Stefan Weil
** Changed in: qemu Status: New = Confirmed ** Changed in: qemu Assignee: (unassigned) = Stefan Weil (ubuntu-weilnetz) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/721825 Title: VDI

[Qemu-devel] [Bug 393562] Re: QEMU does not support files with colons in the filename

2011-02-20 Thread Stefan Weil
** Description changed: It is impossible to feed filenames with the character colon because qemu interprets such names as a protocol. For example a filename scsi:0, is interpreted as a protocol scsi. - Unfortunately filenames like + Unfortunately filenames like

[Qemu-devel] Pad short frames to minimum size (60 bytes)

2011-02-21 Thread Stefan Weil
Am 21.09.2010 11:16, schrieb Stefan Hajnoczi: On Mon, Sep 20, 2010 at 9:31 PM, Anthony Liguori anth...@codemonkey.ws wrote: On 09/20/2010 05:42 AM, Michael S. Tsirkin wrote: On Sun, Sep 19, 2010 at 07:36:51AM +0100, Stefan Hajnoczi wrote: On Sat, Sep 18, 2010 at 10:27 PM, Edgar E. Iglesias

Re: [Qemu-devel] [PATCH] Add new user mode option -ignore-environment

2010-08-01 Thread Stefan Weil
Am 16.07.2010 15:09, schrieb Stefan Weil: Am 16.07.2010 09:04, schrieb Markus Armbruster: Stefan Weilw...@mail.berlios.de writes: An empty environment is sometimes useful in user mode. The new option provides it for linux-user and bsd-user (darwin-user still has no environment related

[Qemu-devel] [PATCH] docs: Improve documentation

2010-08-01 Thread Stefan Weil
Fix some inconsistencies (tabs and punctuation) and try to improve grammar and spelling. Cc: Juan Quintela quint...@redhat.com Signed-off-by: Stefan Weil w...@mail.berlios.de --- docs/migration.txt | 56 ++-- 1 files changed, 28 insertions(+), 28

[Qemu-devel] [PATCH] qemu-option: Include name of invalid parameter in error message

2010-08-01 Thread Stefan Weil
All other error messages in qemu-option.c display the name of the invalid parameter. This seems to be reasonable for invalid identifiers, too. Without it, a debugger is needed to find the name. Cc: Markus Armbruster arm...@redhat.com Cc: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Stefan

Re: [Qemu-devel] [PATCH 0/3] Fix broken if statements

2010-08-01 Thread Stefan Weil
Am 01.08.2010 19:25, schrieb Andreas Färber: Am 22.07.2010 um 18:18 schrieb Stefan Weil: Am 21.07.2010 22:05, schrieb Joel Schopp: I have decided to apply the broken window theory of crime http://en.wikipedia.org/wiki/Broken_windows_theory to code, and more specifically to qemu[:] I'm

Re: [Qemu-devel] [PATCH] qemu-option: Include name of invalid parameter in error message

2010-08-02 Thread Stefan Weil
Am 02.08.2010 10:40, schrieb Markus Armbruster: Stefan Weil w...@mail.berlios.de writes: All other error messages in qemu-option.c display the name of the invalid parameter. This seems to be reasonable for invalid identifiers, too. Without it, a debugger is needed to find the name. Cc: Markus

[Qemu-devel] [PATCH] Fix spelling in comments

2010-08-06 Thread Stefan Weil
multifuction - multifunction successfull - successful. Signed-off-by: Stefan Weil w...@mail.berlios.de --- hw/pci.c |2 +- posix-aio-compat.c |2 +- ui/vnc-enc-tight.c |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index a98d6f3

[Qemu-devel] [PATCH] hw/omap: Fix default setup for OMAP UART devices

2010-08-08 Thread Stefan Weil
serial device, empty char device This is fixed by setting a default label uart1, uart2 or uart3. Cc: Andrzej Zaborowski andrew.zaborow...@intel.com Signed-off-by: Stefan Weil w...@mail.berlios.de --- hw/omap.h |6 -- hw/omap1.c |3 +++ hw/omap2.c |6 +- hw

[Qemu-devel] [PATCH] elf: Calculate symbol size if needed

2010-08-09 Thread Stefan Weil
Symbols with a size of 0 are unusable for the disassembler. Example: While running an arm linux kernel, no symbolic names are used in qemu.log when the cpu is executing an assembler function. Assume that the size of such symbols is the difference to the next symbol value. Signed-off-by: Stefan

[Qemu-devel] [PATCH] hw/arm: Improve detection of Linux kernels

2010-08-09 Thread Stefan Weil
ELF images were not detected as linux kernels. Assume that they are linux kernels if the kernel name contains 'vmlinux'. Cc: Paul Brook p...@codesourcery.com Signed-off-by: Stefan Weil w...@mail.berlios.de --- hw/arm_boot.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff

[Qemu-devel] [PATCH] hw/musicpal: Set loader start address

2010-08-09 Thread Stefan Weil
Start address 0x0 did not work with a linux kernel. Cc: Jan Kiszka jan.kis...@web.de Signed-off-by: Stefan Weil w...@mail.berlios.de --- hw/musicpal.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/musicpal.c b/hw/musicpal.c index 33180a2..dc6bc21 100644 --- a/hw

[Qemu-devel] [PATCH 2/2] ivshmem: Fix compilation without kvm

2010-08-11 Thread Stefan Weil
kvm_set_ioeventfd_mmio_long is only available with CONFIG_KVM. Cc: Anthony Liguori aligu...@us.ibm.com Cc: Cam Macdonell c...@cs.ualberta.ca Signed-off-by: Stefan Weil w...@mail.berlios.de --- hw/ivshmem.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/hw

[Qemu-devel] [PATCH 1/2] ivshmem: Fix compilation (wrong format specifier)

2010-08-11 Thread Stefan Weil
st_size is an off32_t or off64_t, so %ld does not always work. Cc: Anthony Liguori aligu...@us.ibm.com Cc: Cam Macdonell c...@cs.ualberta.ca Signed-off-by: Stefan Weil w...@mail.berlios.de --- hw/ivshmem.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ivshmem.c b

Re: [Qemu-devel] [PATCH v8 5/5] RESEND: Inter-VM shared memory PCI device

2010-08-11 Thread Stefan Weil
Am 27.07.2010 18:54, schrieb Cam Macdonell: resend for bug fix related to removal of irqfd Support an inter-vm shared memory device that maps a shared-memory object as a PCI device in the guest. This patch also supports interrupts between guest by communicating over a unix domain socket. This

Re: [Qemu-devel] Running the user emulation

2010-08-11 Thread Stefan Weil
Am 11.08.2010 10:31, schrieb C K Kashyap: Hi, I've built qemu on my mac osx using this config - ./configure --prefix=/Users/ckk/local/ --target-list=i386-softmmu x86_64-softmmu --enable-linux-user Now, I have a simple a.out built on linux - how can I run it using qemu on my mac box? --

Re: [Qemu-devel] [PATCH] Add new user mode option -ignore-environment

2010-08-11 Thread Stefan Weil
Am 01.08.2010 13:48, schrieb Stefan Weil: Am 16.07.2010 15:09, schrieb Stefan Weil: Am 16.07.2010 09:04, schrieb Markus Armbruster: Stefan Weilw...@mail.berlios.de writes: An empty environment is sometimes useful in user mode. The new option provides it for linux-user and bsd-user (darwin

Re: [Qemu-devel] Running the user emulation

2010-08-11 Thread Stefan Weil
. On Wed, Aug 11, 2010 at 2:12 PM, Stefan Weil w...@mail.berlios.de mailto:w...@mail.berlios.de wrote: Am 11.08.2010 10:31, schrieb C K Kashyap: Hi, I've built qemu on my mac osx using this config - ./configure --prefix=/Users/ckk/local/ --target-list=i386-softmmu x86_64

Re: [Qemu-devel] Running the user emulation

2010-08-11 Thread Stefan Weil
which you will get. If you think they are in code which you don't need for your a.out, #if 0 ... #endif helps to remove that code. Run the new-built qemu-i386 with your a.out and fix the remaining bugs. That's all :-) On Wed, Aug 11, 2010 at 2:48 PM, Stefan Weil w...@mail.berlios.de mailto:w

[Qemu-devel] Unmaintained QEMU builds

2010-08-11 Thread Stefan Weil
Hi, since several months, QEMU for Windows (and mingw32 cross builds) no longer builds without error. I suspect that the same is true for QEMU on Darwin (lots of errors like darwin-user/qemu.h:149: error: cast to pointer from integer of different size), but I'm not sure here because I have no

Re: [Qemu-devel] [PATCH] elf: Calculate symbol size if needed

2010-08-11 Thread Stefan Weil
Am 11.08.2010 18:21, schrieb Blue Swirl: On Mon, Aug 9, 2010 at 2:43 PM, Stefan Weilw...@mail.berlios.de wrote: Symbols with a size of 0 are unusable for the disassembler. Example: While running an arm linux kernel, no symbolic names are used in qemu.log when the cpu is executing an

Re: [Qemu-devel] Unmaintained QEMU builds

2010-08-11 Thread Stefan Weil
Am 11.08.2010 18:34, schrieb Blue Swirl: On Wed, Aug 11, 2010 at 10:58 AM, Stefan Weil w...@mail.berlios.de wrote: Hi, since several months, QEMU for Windows (and mingw32 cross builds) no longer builds without error. Not true for mingw32, it was building fine here until the latest commit

Re: [Qemu-devel] [PATCH v8 5/5] RESEND: Inter-VM shared memory PCI device

2010-08-11 Thread Stefan Weil
Am 11.08.2010 19:07, schrieb Paolo Bonzini: On 08/11/2010 11:49 AM, Cam Macdonell wrote: The win32 problems (missing mmap, maybe more) remain. Could you please fix them? Could that be accomplished with excluding it on Windows on the makefiles? Yes, just use obj-$(CONFIG_POSIX). Paolo

Re: [Qemu-devel] [PATCH 1/2] Add kvm_set_ioeventfd_mmio_long definition for non-KVM systems

2010-08-11 Thread Stefan Weil
Am 11.08.2010 20:16, schrieb Cam Macdonell: --- kvm-stub.c | 5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/kvm-stub.c b/kvm-stub.c index 3378bd3..d45f9fa 100644 --- a/kvm-stub.c +++ b/kvm-stub.c @@ -136,3 +136,8 @@ int kvm_set_ioeventfd_pio_word(int fd, uint16_t addr,

Re: [Qemu-devel] Unmaintained QEMU builds

2010-08-11 Thread Stefan Weil
Am 11.08.2010 21:19, schrieb Blue Swirl: On Wed, Aug 11, 2010 at 6:51 PM, Blue Swirlblauwir...@gmail.com wrote: On Wed, Aug 11, 2010 at 6:18 PM, Stefan Weilw...@mail.berlios.de wrote: Am 11.08.2010 18:34, schrieb Blue Swirl: On Wed, Aug 11, 2010 at 10:58 AM, Stefan

[Qemu-devel] Re: Unmaintained QEMU builds

2010-08-12 Thread Stefan Weil
Am 12.08.2010 00:12, schrieb Paolo Bonzini: On 08/11/2010 03:37 PM, Stefan Weil wrote: With these changes, build succeeds with SDL. For example, qemu-system-sparc.exe can boot from a Sparc32 CD under Wine. Yes, that's a possible solution. You could also take these patches which I sent

Re: [Qemu-devel] Re: Latest version in Git doesn't link - any ideas?

2010-08-14 Thread Stefan Weil
Am 14.08.2010 23:35, schrieb Nigel Horne: I've seen some activity in this area of late, but the code still fails to link. Any clues anyone? make distclean ./configure --enable-linux-aio --enable-io-thread --enable-kvm make ... LINK arm-softmmu/qemu-system-arm ivshmem.o: In function

Re: [Qemu-devel] [PATCH 2/7] pci: memory access API and IOMMU support

2010-09-02 Thread Stefan Weil
Am 02.09.2010 10:51, schrieb Eduard - Gabriel Munteanu: On Wed, Sep 01, 2010 at 10:10:30PM +0200, Stefan Weil wrote: Please see my comments at the end of this mail. Am 30.08.2010 00:08, schrieb Eduard - Gabriel Munteanu: PCI devices should access memory through pci_memory_

Re: [Qemu-devel] [PATCH] target-arm: Handle 'smc' as an undefined instruction

2010-09-02 Thread Stefan Weil
Am 02.09.2010 22:27, schrieb Adam Lackorzynski: Handle smc as an undefined instruction instead of having it wrongly interpreted as some other one. Signed-off-by: Adam Lackorzynskia...@os.inf.tu-dresden.de --- target-arm/translate.c |6 +- 1 files changed, 5 insertions(+), 1

Re: [Qemu-devel] [PATCH] Add new user mode option -ignore-environment

2010-09-09 Thread Stefan Weil
Am 16.07.2010 09:04, schrieb Markus Armbruster: Stefan Weilw...@mail.berlios.de writes: An empty environment is sometimes useful in user mode. The new option provides it for linux-user and bsd-user (darwin-user still has no environment related options). Stupid question: why is

[Qemu-devel] Re: [PATCH] docs: Improve documentation

2010-09-09 Thread Stefan Weil
Am 03.08.2010 11:48, schrieb Juan Quintela: Stefan Weilw...@mail.berlios.de wrote: Fix some inconsistencies (tabs and punctuation) and try to improve grammar and spelling. Cc: Juan Quintelaquint...@redhat.com Signed-off-by: Stefan Weilw...@mail.berlios.de Acked-by: Juan

[Qemu-devel] Re: [PATCH] hw/omap: Fix default setup for OMAP UART devices

2010-09-09 Thread Stefan Weil
Am 08.08.2010 14:09, schrieb Stefan Weil: Character devices created by qemu_chr_open don't allow duplicate device names, so naming all UART devices null no longer works. Running qemu-system-arm -M n800 (and some other machines) results in this error message: qemu-system-arm: Duplicate

Re: [Qemu-devel] [PATCH] elf: Calculate symbol size if needed

2010-09-09 Thread Stefan Weil
Am 11.08.2010 18:21, schrieb Blue Swirl: On Mon, Aug 9, 2010 at 2:43 PM, Stefan Weilw...@mail.berlios.de wrote: Symbols with a size of 0 are unusable for the disassembler. Example: While running an arm linux kernel, no symbolic names are used in qemu.log when the cpu is executing an

[Qemu-devel] Re: [PATCH] hw/arm: Improve detection of Linux kernels

2010-09-09 Thread Stefan Weil
Am 09.08.2010 16:48, schrieb Stefan Weil: ELF images were not detected as linux kernels. Assume that they are linux kernels if the kernel name contains 'vmlinux'. Cc: Paul Brookp...@codesourcery.com Signed-off-by: Stefan Weilw...@mail.berlios.de --- hw/arm_boot.c |6 -- 1 files

Re: [Qemu-devel] [PATCH] elf: Calculate symbol size if needed

2010-09-09 Thread Stefan Weil
Am 09.09.2010 20:44, schrieb Blue Swirl: On Thu, Sep 9, 2010 at 5:42 PM, Stefan Weil w...@mail.berlios.de wrote: Am 11.08.2010 18:21, schrieb Blue Swirl: On Mon, Aug 9, 2010 at 2:43 PM, Stefan Weilw...@mail.berlios.de wrote: Symbols with a size of 0 are unusable for the disassembler

[Qemu-devel] [PATCH] MAINTAINERS: Add new maintainer for Linux user

2010-09-09 Thread Stefan Weil
According to Antony, Riku is the maintainer for Linux user, so make this visible for everyone. (The patch also fixes a whitespace issue at end of line - required by git and by my editor). Cc: Riku Voipio riku.voi...@iki.fi Cc: Antony Liguori aligu...@us.ibm.com Signed-off-by: Stefan Weil w

Re: [Qemu-devel] [PATCH] elf: Calculate symbol size if needed

2010-09-09 Thread Stefan Weil
Am 09.09.2010 21:29, schrieb Blue Swirl: On Thu, Sep 9, 2010 at 7:11 PM, Stefan Weilw...@mail.berlios.de wrote: Am 09.09.2010 20:44, schrieb Blue Swirl: On Thu, Sep 9, 2010 at 5:42 PM, Stefan Weilw...@mail.berlios.de wrote: Am 11.08.2010 18:21, schrieb Blue Swirl:

Re: [Qemu-devel] [PATCH] Update MAINTAINERS

2010-09-09 Thread Stefan Weil
Hello Anthony, I feel responsible for any file with Copyright (c) 20xx Stefan Weil in the header. Maybe a general remark like this would be good: For individual files, there is usually a copyright owner mentioned in the file's header. In most cases, this person also maintains this file

[Qemu-devel] [PATCH] mips_fulong2e: Detect format errors for function prom_set

2010-09-11 Thread Stefan Weil
Add the necessary gcc attribute and fix the detected errors. Cc: Aurelien Jarno aurel...@aurel32.net Signed-off-by: Stefan Weil w...@mail.berlios.de --- hw/mips_fulong2e.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/hw/mips_fulong2e.c b/hw/mips_fulong2e.c

[Qemu-devel] [PATCH] mips_malta: Detect format errors for function prom_set

2010-09-11 Thread Stefan Weil
Add the necessary gcc attribute and fix the detected errors. Cc: Aurelien Jarno aurel...@aurel32.net Signed-off-by: Stefan Weil w...@mail.berlios.de --- hw/mips_malta.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/mips_malta.c b/hw/mips_malta.c index a458c97

Re: [Qemu-devel] [PATCH] Cocoa: Avoid missing prototype warnings for qemu_main

2010-09-11 Thread Stefan Weil
Am 11.09.2010 11:55, schrieb Andreas Färber: In vl.c main is redefined to qemu_main but no prototype is available. Move it into qemu-common.h since it is needed in ui/cocoa.m, too. Adjust the call sites to the signature used in vl.c. Signed-off-by: Andreas Färberandreas.faer...@web.de ---

Re: [Qemu-devel] [PATCH] trace: Fix user emulator dependency on trace objects

2010-09-13 Thread Stefan Weil
%,romsubdir-%, $(ROMS)) romsubdir-%: Acked-by: Stefan Weil w...@mail.berlios.de Doing the same for %-softmmu was a good idea and helped me, thanks. Stefan

[Qemu-devel] [PATCH] linux-user: Fix type m86k - m68k

2010-09-13 Thread Stefan Weil
Replace m86k_sim_stat by m68k_sim_stat. Cc: Riku Voipio riku.voi...@iki.fi Signed-off-by: Stefan Weil w...@mail.berlios.de --- linux-user/m68k-sim.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/linux-user/m68k-sim.c b/linux-user/m68k-sim.c index 64d3b23..d5926ee

Re: [Qemu-devel] [PATCH] Use a Linux-style MAINTAINERS file

2010-09-13 Thread Stefan Weil
Am 09.09.2010 23:18, schrieb Anthony Liguori: I make no claims that this is accurate or exhaustive but I think it's a reasonable place to start. As the file mentions, the purpose of this file is to give contributors information about who they can go to with questions about a particular piece of

Re: [Qemu-devel] [PATCH] Use a Linux-style MAINTAINERS file

2010-09-13 Thread Stefan Weil
Am 13.09.2010 19:32, schrieb Anderson Lizardo: On Thu, Sep 9, 2010 at 5:18 PM, Anthony Liguorialigu...@us.ibm.com wrote: +M86K Machines +- +mcf5208 +M: Paul Brookp...@codesourcery.com +S: Maintained +F: hw/mcf5208.c Just wondering... Is there a M86K or is it a typo from

[Qemu-devel] [PATCH] Remove wrong semicolon in macro definition

2010-09-13 Thread Stefan Weil
Macros normally should not end with a semicolon, otherwise their usage results in two statements where only one statement was expected. Signed-off-by: Stefan Weil w...@mail.berlios.de --- hw/serial.c |4 ++-- tests/cris/check_swap.c |2 +- 2 files changed, 3 insertions(+), 3

[Qemu-devel] [PATCH 1/2] Add support for gcc format attribute gnu_printf

2010-09-13 Thread Stefan Weil
gnu_printf = printf, so they work with the new format attribute, too. Signed-off-by: Stefan Weil w...@mail.berlios.de --- configure | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/configure b/configure index 4061cb7..1300879 100755 --- a/configure +++ b/configure

Re: [Qemu-devel] [PATCH 1/5] Introduce strtobytes() library function to convert string to byte count.

2010-09-15 Thread Stefan Weil
Am 15.09.2010 20:46, schrieb Andreas Färber: Am 15.09.2010 um 14:23 schrieb jes.soren...@redhat.com: [...] +/* + * Convert string to bytes, allowing either K/k for KB, M/m for MB, + * G/b for GB or T/t for TB. Default without any postfix is MB. ^^^ typo + * End pointer will be returned

Re: [Qemu-devel] [PATCH] CMOS file support

2010-09-16 Thread Stefan Weil
Am 16.09.2010 15:58, schrieb Mathias Krause: In contrast to the BIOS and Option ROMs the CMOS content cannot be predefined by the user. Also the amount of useable CMOS ARM is pretty limited, even though the amount of CMOS bytes emulated by qemu is already twice as much as of the original

Re: [Qemu-devel] [PATCH] docs: Improve documentation

2010-09-16 Thread Stefan Weil
Am 09.09.2010 19:32, schrieb Stefan Weil: Am 03.08.2010 11:48, schrieb Juan Quintela: Stefan Weilw...@mail.berlios.de wrote: Fix some inconsistencies (tabs and punctuation) and try to improve grammar and spelling. Cc: Juan Quintelaquint...@redhat.com Signed-off-by: Stefan Weilw

Re: [Qemu-devel] Feature request

2010-09-17 Thread Stefan Weil
Am 16.09.2010 23:56, schrieb Frans de Boer: Dear Reader, When I switch with SHIFT-CTRL-ALT-2 to the monitor mode, the resolution of the used window goes back to 640*480. There a lot of command available and typing help lists then all. in one long list without pause to examine the commands. Is

Re: [Qemu-devel] Feature request

2010-09-17 Thread Stefan Weil
Am 17.09.2010 09:15, schrieb Stefan Weil: Am 16.09.2010 23:56, schrieb Frans de Boer: Dear Reader, When I switch with SHIFT-CTRL-ALT-2 to the monitor mode, the resolution of the used window goes back to 640*480. There a lot of command available and typing help lists then all. in one long list

Re: [Qemu-devel] [PATCH] CMOS file support

2010-09-17 Thread Stefan Weil
Am 17.09.2010 08:42, schrieb Mathias Krause: Am 16.09.2010 18:49, Stefan Weil schrieb: The intention of this patch is ok. Loading CMOS with initial data is needed. I just want to add two questions / remarks how the implementation might be improved. Are there use cases where having a smaller

Re: [Qemu-devel] [PATCH] mingw: add version information to the executables

2010-09-19 Thread Stefan Weil
Could it be that the patch lines were wrapped by your mailer? I cannot apply it here. Regards, Stefan Am 19.09.2010 10:42, schrieb Blue Swirl: Add QEMU version information to the executables, based on earlier work by C. W. Betts and Robert Riebisch. Signed-off-by: Blue

Re: [Qemu-devel] New arm9 Emulation

2010-09-20 Thread Stefan Weil
Hello Andreas, your code is ok and works as expected: $ arm-softmmu/qemu-system-arm -M ? Supported machines are: syborg Syborg (Symbian Virtual Platform) smdk2410 Samsung SMDK2410 (S3C2410A, ARM920T) str910faw32 STR910FAW32 System on a Chip (ARM966E-S Core) bast Simtec Electronics BAST

Re: [Qemu-devel] [PATCH v3 00/15] GCC warning flags

2010-09-20 Thread Stefan Weil
Am 10.09.2010 22:58, schrieb Blue Swirl: I updated the descriptions and cleaned up 6/16. Blue Swirl (15): Check for errors during BIOS or kernel load linux-user: fix socklen_t comparisons linux-user: fix types in a comparison linux-user: improve flatload error checking Introduce range.h Use

[Qemu-devel] [PATCH 2/2] mips_malta: Fix format strings

2010-09-20 Thread Stefan Weil
Fix two compiler warnings (when format attribute is applied). Cc: Aurelien Jarno aurel...@aurel32.net Cc: Blue Swirl blauwir...@gmail.com Signed-off-by: Stefan Weil w...@mail.berlios.de --- hw/mips_malta.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw

[Qemu-devel] [PATCH] Move macros GCC_ATTR and GCC_FMT_ATTR to common header file

2010-09-20 Thread Stefan Weil
always uses standard format strings (even with mingw32)). Cc: Blue Swirl blauwir...@gmail.com Signed-off-by: Stefan Weil w...@mail.berlios.de --- audio/audio_int.h |8 qemu-common.h | 16 2 files changed, 16 insertions(+), 8 deletions(-) diff --git a/audio

Re: [Qemu-devel] [PATCH 1/2] Add support for gcc format attribute gnu_printf

2010-09-20 Thread Stefan Weil
Am 20.09.2010 21:18, schrieb Blue Swirl: On Mon, Sep 13, 2010 at 8:02 PM, Stefan Weilw...@mail.berlios.de wrote: Since version 4.4.x, gcc supports additional format attributes. __attribute__ ((format (gnu_printf, 1, 2))) should be used instead of __attribute__ ((format (printf, 1,

[Qemu-devel] [PATCH 1/2] mips_fulong2e: Fix format strings

2010-09-20 Thread Stefan Weil
Fix two compiler warnings (when format attribute is applied) and one error (missing %) in format strings. Cc: Aurelien Jarno aurel...@aurel32.net Cc: Blue Swirl blauwir...@gmail.com Signed-off-by: Stefan Weil w...@mail.berlios.de --- hw/mips_fulong2e.c |6 +++--- 1 files changed, 3

[Qemu-devel] Re: [PATCH] Move macros GCC_ATTR and GCC_FMT_ATTR to common header file

2010-09-21 Thread Stefan Weil
Please ignore this patch. It's wrong (= instead of ==). I'll send a fixed version. Sorry, Stefan Am 20.09.2010 23:05, schrieb Stefan Weil: By moving the definition of GCC_ATTR and GCC_FMT_ATTR from audio_int.h to qemu-common.h these macros are now generally available for further patches which

[Qemu-devel] [PATCH] Move macros GCC_ATTR and GCC_FMT_ATTR to common header file

2010-09-21 Thread Stefan Weil
always uses standard format strings (even with mingw32)). V2: Use correct operator '==' (instead of '=') Cc: Blue Swirl blauwir...@gmail.com Signed-off-by: Stefan Weil w...@mail.berlios.de --- audio/audio_int.h |8 qemu-common.h | 16 2 files changed, 16

[Qemu-devel] [PATCH] Move macros GCC_ATTR and GCC_FMT_ATTR to common header file

2010-09-21 Thread Stefan Weil
always uses standard format strings (even with mingw32)). V2: Use correct operator '==' (instead of '=') Cc: Blue Swirl blauwir...@gmail.com Signed-off-by: Stefan Weil w...@mail.berlios.de --- audio/audio_int.h |8 qemu-common.h | 16 2 files changed, 16

[Qemu-devel] [PATCH] Fix compilation error (missing include statement)

2010-09-22 Thread Stefan Weil
Wolf kw...@redhat.com Signed-off-by: Stefan Weil w...@mail.berlios.de --- hw/sd.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/sd.c b/hw/sd.c index 4bcf1c0..601545b 100644 --- a/hw/sd.c +++ b/hw/sd.c @@ -31,6 +31,7 @@ #include hw.h #include block.h +#include

[Qemu-devel] [PATCH] block: Use GCC_FMT_ATTR and fix a format error

2010-09-23 Thread Stefan Weil
Adding the gcc format attribute detects a format bug which is fixed here. Cc: Blue Swirl blauwir...@gmail.com Cc: Kevin Wolf kw...@redhat.com Signed-off-by: Stefan Weil w...@mail.berlios.de --- block/blkverify.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/block

[Qemu-devel] [PATCH] blockdev: Use GCC_FMT_ATTR (format checking)

2010-09-23 Thread Stefan Weil
Additional changes: * Removed 'extern' from drive_add (avoids too long line). * Removed 'extern' from other functions (makes declarations consistent with others in same header file). Cc: Blue Swirl blauwir...@gmail.com Cc: Kevin Wolf kw...@redhat.com Signed-off-by: Stefan Weil w

[Qemu-devel] Re: [PATCH] block: Use GCC_FMT_ATTR and fix a format error

2010-09-23 Thread Stefan Weil
Am 23.09.2010 20:53, schrieb Blue Swirl: On Thu, Sep 23, 2010 at 6:37 PM, Stefan Weilw...@mail.berlios.de wrote: Adding the gcc format attribute detects a format bug which is fixed here. Cc: Blue Swirlblauwir...@gmail.com Cc: Kevin Wolfkw...@redhat.com Signed-off-by: Stefan

[Qemu-devel] Re: [PATCH] block: Use GCC_FMT_ATTR and fix a format error

2010-09-23 Thread Stefan Weil
Am 23.09.2010 21:03, schrieb Stefan Weil: Am 23.09.2010 20:53, schrieb Blue Swirl: On Thu, Sep 23, 2010 at 6:37 PM, Stefan Weilw...@mail.berlios.de wrote: Adding the gcc format attribute detects a format bug which is fixed here. Cc: Blue Swirlblauwir...@gmail.com Cc: Kevin Wolfkw

[Qemu-devel] [PATCH 2/3] Replace remaining gcc format attribute by macro GCC_FMT_ATTR (format checking)

2010-09-23 Thread Stefan Weil
these includes. * Remove local definitions which now come from stdio.h. These definitions were needed before tcg was introduced. They raise conflicts when qemu-common.h is included. Cc: Blue Swirl blauwir...@gmail.com Signed-off-by: Stefan Weil w...@mail.berlios.de --- cpu-all.h

[Qemu-devel] [PATCH 1/3] Replace most gcc format attributes by macro GCC_FMT_ATTR (format checking)

2010-09-23 Thread Stefan Weil
/ __printf__ by macro GCC_FMT_ATTR which uses gnu_printf if supported. It also removes an #ifdef __GNUC__ (not needed any longer). Cc: Blue Swirl blauwir...@gmail.com Signed-off-by: Stefan Weil w...@mail.berlios.de --- audio/audio.h |6 +- bsd-user/qemu.h|2 +- darwin-user

[Qemu-devel] [PATCH 3/3] Use GCC_FMT_ATTR (format checking)

2010-09-23 Thread Stefan Weil
Signed-off-by: Stefan Weil w...@mail.berlios.de --- audio/audio.h |2 +- disas.c|3 ++- hw/mips_fulong2e.c |3 ++- hw/mips_malta.c|3 ++- json-parser.c |3 ++- monitor.c |3 ++- monitor.h |3 ++- qemu-char.h|3

[Qemu-devel] Re: [PATCH 2/3] Replace remaining gcc format attribute by macro GCC_FMT_ATTR (format checking)

2010-09-23 Thread Stefan Weil
Am 23.09.2010 22:33, schrieb Blue Swirl: On Thu, Sep 23, 2010 at 7:28 PM, Stefan Weil w...@mail.berlios.de wrote: Replace the remaining format attribute printf by macro GCC_FMT_ATTR which uses gnu_printf (if supported). This needs additional code changes: * Add qemu-common.h (which defined

[Qemu-devel] Re: [PATCH] block: Use GCC_FMT_ATTR and fix a format error

2010-09-23 Thread Stefan Weil
Am 23.09.2010 22:24, schrieb Blue Swirl: On Thu, Sep 23, 2010 at 7:11 PM, Stefan Weil w...@mail.berlios.de wrote: Am 23.09.2010 21:03, schrieb Stefan Weil: Am 23.09.2010 20:53, schrieb Blue Swirl: On Thu, Sep 23, 2010 at 6:37 PM, Stefan Weilw...@mail.berlios.de wrote: Adding the gcc

[Qemu-devel] [PULL] Missing patches in qemu master

2010-09-24 Thread Stefan Weil
The following changes since commit c973a36d178510790c148f88104b85016f59235a: fmopl: workaround for -Wempty-body (2010-09-24 04:09:01 +0400) are available in the git repository at: git://git.weilnetz.de/git/qemu for-anthony Stefan Weil (4): Add new user mode option -ignore-environment

[Qemu-devel] [PATCH] block: Use GCC_FMT_ATTR and fix a format error

2010-09-24 Thread Stefan Weil
Adding the gcc format attribute detects a format bug which is fixed here. v2: Don't use type cast. BDRV_SECTOR_SIZE is unsigned long long, so %lld should be the correct format specifier. Cc: Blue Swirl blauwir...@gmail.com Cc: Kevin Wolf kw...@redhat.com Signed-off-by: Stefan Weil w

[Qemu-devel] Re: [PATCH] block: Use GCC_FMT_ATTR and fix a format error

2010-09-25 Thread Stefan Weil
Am 25.09.2010 10:01, schrieb Blue Swirl: On Thu, Sep 23, 2010 at 9:23 PM, Stefan Weil w...@mail.berlios.de wrote: Am 23.09.2010 22:24, schrieb Blue Swirl: On Thu, Sep 23, 2010 at 7:11 PM, Stefan Weil w...@mail.berlios.de wrote: Am 23.09.2010 21:03, schrieb Stefan Weil: Am 23.09.2010 20

[Qemu-devel] [PATCH] virtio-9p: Use GCC_FMT_ATTR and fix a format warning

2010-09-27 Thread Stefan Weil
With the new gcc format warnings, gcc detected this: /qemu/hw/virtio-9p.c:1040: error: format ‘%u’ expects type ‘unsigned int’, but argument 4 has type ‘__nlink_t’ Cc: Blue Swirl blauwir...@gmail.com Signed-off-by: Stefan Weil w...@mail.berlios.de --- hw/virtio-9p.c | 10 ++ 1 files

Re: [Qemu-devel] eepro100 multicast

2010-09-29 Thread Stefan Weil
Am 25.09.2010 21:11, schrieb Dunc: Hi all, I've been trying to set up some olives running inside qemu to practice for Juniper exam. I came across the multicast issue when enabling VRRP After lots of googling and reading forums, where people have being doing hacky patches, I found a page that

[Qemu-devel] [PATCH] console: Fix crash with missing active_console (null pointer access)

2010-09-29 Thread Stefan Weil
-by: Stefan Weil w...@mail.berlios.de --- console.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/console.c b/console.c index 698bc10..c1728b1 100644 --- a/console.c +++ b/console.c @@ -1060,8 +1060,10 @@ void console_select(unsigned int index) if (index

[Qemu-devel] [PATCH] eepro100: Add support for multiple individual addresses (multiple IA)

2010-09-29 Thread Stefan Weil
. Tsirkin m...@redhat.com Signed-off-by: Stefan Weil w...@mail.berlios.de --- hw/eepro100.c | 30 +- 1 files changed, 21 insertions(+), 9 deletions(-) diff --git a/hw/eepro100.c b/hw/eepro100.c index 2b75c8f..5f6dcb6 100644 --- a/hw/eepro100.c +++ b/hw/eepro100.c

Re: [Qemu-devel] [PATCH] eepro100: Add support for multiple individual addresses (multiple IA)

2010-09-30 Thread Stefan Weil
Am 29.09.2010 22:30, schrieb Edgar E. Iglesias: On Wed, Sep 29, 2010 at 09:59:55PM +0200, Stefan Weil wrote: I reviewed the latest sources of Linux, FreeBSD and NetBSD. They all reset the multiple IA bit (multi_ia in BSD) to zero, but I did not find code which sets this bit to one (like

Re: [Qemu-devel] [PATCH] console: Avoid dereferencing NULL active_console

2010-09-30 Thread Stefan Weil
-g_height = ds_get_height(active_console-ds); + } s = consoles[index]; if (s) { DisplayState *ds = s-ds; To avoid that still more people fix the same bug, I'd appreciate shorter commit times for simple patches like this one. Cheers, Stefan Acked-by: Stefan Weil w...@mail.berlios.de

[Qemu-devel] [PATCH] es1370: Fix compiler warnings for debug code

2010-09-30 Thread Stefan Weil
empty body in an ‘if’ statement Cc: Blue Swirl blauwir...@gmail.com Signed-off-by: Stefan Weil w...@mail.berlios.de --- hw/es1370.c | 11 ++- 1 files changed, 6 insertions(+), 5 deletions(-) diff --git a/hw/es1370.c b/hw/es1370.c index 40cb48c..c87bbf2 100644 --- a/hw/es1370.c +++ b/hw

[Qemu-devel] [PATCH] block/vvfat: Fix compiler warning in debug code

2010-09-30 Thread Stefan Weil
Fix this compiler warning: ./block/vvfat.c:2285: error: comparison of unsigned expression = 0 is always true Cc: Blue Swirl blauwir...@gmail.com Cc: Kevin Wolf kw...@redhat.com Signed-off-by: Stefan Weil w...@mail.berlios.de --- block/vvfat.c |1 - 1 files changed, 0 insertions(+), 1

[Qemu-devel] [PATCH] ds1225y: Fix compiler errors in debug code

2010-09-30 Thread Stefan Weil
/ds1225y.c:107:47: error: attempt to use poisoned TARGET_FMT_lx ./hw/ds1225y.c: In function ‘nvram_writeb_protected’: ./hw/ds1225y.c:107: error: expected ‘)’ before ‘TARGET_FMT_lx’ ./hw/ds1225y.c:107: error: too few arguments for format Cc: Blue Swirl blauwir...@gmail.com Signed-off-by: Stefan Weil w

[Qemu-devel] [PATCH] mipsnet: Fix compiler warning in debug code

2010-09-30 Thread Stefan Weil
size_t needs a different format specifier, so fix this. Cc: Blue Swirl blauwir...@gmail.com Signed-off-by: Stefan Weil w...@mail.berlios.de --- hw/mipsnet.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/mipsnet.c b/hw/mipsnet.c index a95b3ce..c5e54ff 100644

[Qemu-devel] Re: [PATCH] ds1225y: Fix compiler errors in debug code

2010-09-30 Thread Stefan Weil
Am 30.09.2010 21:37, schrieb Blue Swirl: On Thu, Sep 30, 2010 at 7:30 PM, Stefan Weilw...@mail.berlios.de wrote: TARGET_FMT_lx is not allowed here, so use type casts to unsigned (which should be large enough to hold typical nvram addresses). The correct format is TARGET_FMT_plx.

[Qemu-devel] [PATCH] rc4030: Fix compilation error in debug code

2010-09-30 Thread Stefan Weil
min was unknown here, so avoid it. Cc: Blue Swirl blauwir...@gmail.com Signed-off-by: Stefan Weil w...@mail.berlios.de --- hw/rc4030.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/hw/rc4030.c b/hw/rc4030.c index 2231373..abbc3eb 100644 --- a/hw/rc4030.c +++ b/hw

[Qemu-devel] Re: [PATCH] ds1225y: Fix compiler errors in debug code

2010-09-30 Thread Stefan Weil
Am 30.09.2010 22:09, schrieb Blue Swirl: On Thu, Sep 30, 2010 at 7:55 PM, Stefan Weil w...@mail.berlios.de wrote: Am 30.09.2010 21:37, schrieb Blue Swirl: On Thu, Sep 30, 2010 at 7:30 PM, Stefan Weilw...@mail.berlios.de wrote: TARGET_FMT_lx is not allowed here, so use type casts

[Qemu-devel] [PATCH] exec: Fix compilation error for debug code

2010-09-30 Thread Stefan Weil
is_softmmu was removed with commit d4c430a80f000d722bb70287af4d4c184a8d7006, so remove it now from debug code, too. Fix also the format specifier for paddr in the same line of code. Cc: Blue Swirl blauwir...@gmail.com Signed-off-by: Stefan Weil w...@mail.berlios.de --- exec.c |5 +++-- 1

[Qemu-devel] [PATCH v2] es1370: Fix compiler warnings for debug code

2010-10-01 Thread Stefan Weil
empty body in an ‘if’ statement v2 * Use %zd for pointer differences (ptrdiff_t or ssize_t). The gcc error message (long int) was misleading. Malc, thank you for this hint. Cc: Blue Swirl blauwir...@gmail.com Cc: malc av1...@comtv.ru Signed-off-by: Stefan Weil w...@mail.berlios.de --- hw

Re: [Qemu-devel] [PATCH v2] es1370: Fix compiler warnings for debug code

2010-10-02 Thread Stefan Weil
Am 01.10.2010 20:22, schrieb Markus Armbruster: Stefan Weil w...@mail.berlios.de writes: The patch fixes these gcc warnings: ./hw/es1370.c: In function ‘es1370_update_voices’: ./hw/es1370.c:411: error: format ‘%d’ expects type ‘int’, but argument 3 has type ‘size_t’ ./hw/es1370.c

<    2   3   4   5   6   7   8   9   10   11   >