Re: [Qemu-devel] [PATCH 0/5] qemu-timer: Clean code

2012-04-23 Thread Stefan Weil
Am 23.04.2012 22:13, schrieb Anthony Liguori: On 04/20/2012 05:03 AM, Stefan Weil wrote: These patches remove timer code which is no longer needed and try to improve the remaining code. [PATCH 1/5] qemu-timer: Remove redundant include statements [PATCH 2/5] qemu-timer: Remove unused function

[Qemu-devel] [PATCH] block/qcow2: Add missing GCC_FMT_ATTR to function report_unsupported()

2012-04-23 Thread Stefan Weil
Cc: Kevin Wolf Signed-off-by: Stefan Weil --- block/qcow2.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index ad46c03..d03e31c 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -182,7 +182,7 @@ static void cleanup_unknown_header_ext

Re: [Qemu-devel] Generating cachegrind output with qemu

2012-04-23 Thread Stefan Weil
g the TCG interpreter and extending the interpreter main loop tcg_qemu_tb_exec in tci.c. Regards, Stefan Weil

Re: [Qemu-devel] [PATCH v2] configure: Fix creation of symbolic links for MinGW toolchain

2012-04-24 Thread Stefan Weil
Am 19.03.2012 13:20, schrieb Stefan Weil: The MinGW toolchain on w32/w64 hosts does not create symbolic links, but implements 'ln -s' similar to 'cp -r'. In incremental out of tree builds, this resulted in files which were not updated when their counterparts in the QEMU

[Qemu-devel] [PATCH] w32: Support tests (make check)

2012-02-17 Thread Stefan Weil
Adding $(EXESUF) is needed to make those tests work on w32 hosts, too. Signed-off-by: Stefan Weil --- tests/Makefile | 28 +++- 1 files changed, 15 insertions(+), 13 deletions(-) diff --git a/tests/Makefile b/tests/Makefile index 55e8eb0..29c6bfc 100644 --- a/tests

[Qemu-devel] [PATCH] astyle: Formatting rules for QEMU

2012-02-18 Thread Stefan Weil
These AStyle rules try to implement the QEMU coding style. AStyle can also fix only certain aspects of the coding style, for example indentation. Signed-off-by: Stefan Weil --- Hi Blue, maybe this AStyle rules work better. I tried them with target-sparc, and the result does look quite good

Re: [Qemu-devel] [PATCH] checkpatch: Don't WARN about missing spaces in audio files

2012-02-18 Thread Stefan Weil
Am 18.02.2012 10:13, schrieb Blue Swirl: On Fri, Feb 17, 2012 at 15:26, Anthony Liguori wrote: Well this was what I was getting at in my previous comments. If we just need to reindent < 10 files with a few random changes here and there, then maybe that isn't so bad. But if we have to touch

Re: [Qemu-devel] [PATCH] astyle: Formatting rules for QEMU

2012-02-18 Thread Stefan Weil
Am 18.02.2012 11:10, schrieb Blue Swirl: There are still indentation problems when expressions continue to next line, also this does not look OK: --- a/target-sparc/translate.c +++ b/target-sparc/translate.c @@ -36,7 +36,7 @@ #define DYNAMIC_PC 1 /* dynamic pc value */ #define JUMP_PC 2 /* dynam

[Qemu-devel] [Bug 919242] Re: qemu-img convert to VDI corrupts image

2012-02-18 Thread Stefan Weil
** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/919242 Title: qemu-img convert to VDI corrupts image Status in QEMU: Fix Released S

[Qemu-devel] [Bug 919242] Re: qemu-img convert to VDI corrupts image

2012-02-18 Thread Stefan Weil
Hi Serge, yes, please queue it up. The fix was committed to QEMU git master, but it is still missing in QEMU 1.0.1 and older versions. So if you have a QEMU patch queue for Ubuntu , it's needed there. Thanks, Stefan -- You received this bug notification because you are a member of qemu- devel-

[Qemu-devel] [Bug 899143] Re: Raw img not recognized by Windows

2012-02-18 Thread Stefan Weil
** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/899143 Title: Raw img not recognized by Windows Status in QEMU: Invalid Bug description: Hi,

Re: [Qemu-devel] [patch] qemu-1.0.1/VERSION

2012-02-19 Thread Stefan Weil
+1 @@ -1.0,1 +1.0.1 Acked-by: Stefan Weil

Re: [Qemu-devel] [PATCH 2/6] ui: add basic GTK gui

2012-02-20 Thread Stefan Weil
d if buggy features like zooming were removed from SDL again, but having a GUI which also works with framebuffers (without X) and which has much less requirements than GTK+-2.0 (and perhaps also a reduced risk of security problems) is a good feature. Cheers, Stefan Weil PS: git complains about whitespace

Re: [Qemu-devel] [PATCH 3/6] gtk: add virtual console support

2012-02-20 Thread Stefan Weil
custom child setup function and that returns a GError on failure. => It does not work with Debian stable and other "old" distributions. configure detects GTK+ and VTE, but make fails. Regards, Stefan Weil

[Qemu-devel] [PATCH v2] w32: Support tests (make check)

2012-02-22 Thread Stefan Weil
Adding $(EXESUF) is needed to make those tests work on w32 hosts, too. v2: Rebased, added new tests, tests sorted alphabetically. Signed-off-by: Stefan Weil --- tests/Makefile | 38 +++--- 1 files changed, 23 insertions(+), 15 deletions(-) diff --git a/tests

[Qemu-devel] [PATCH] qmp: Fix spelling fourty -> forty

2012-02-25 Thread Stefan Weil
This was found by codespell. Signed-off-by: Stefan Weil --- test-qmp-output-visitor.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/test-qmp-output-visitor.c b/test-qmp-output-visitor.c index c94c208..5452cd4 100644 --- a/test-qmp-output-visitor.c +++ b/test-qmp

[Qemu-devel] [PATCH] Fix spelling in documentation

2012-02-25 Thread Stefan Weil
This fixes a new spelling issue which was detected by codespell. Signed-off-by: Stefan Weil --- include/qemu/object.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/qemu/object.h b/include/qemu/object.h index 69e4b7b..dd7f3c0 100644 --- a/include/qemu/object.h

[Qemu-devel] [PATCH 2/2] sh7750: Remove redundant 'struct' from MemoryRegionOps

2012-02-25 Thread Stefan Weil
The 'struct' is not needed, and all other MemoryRegionOps don't use it. Signed-off-by: Stefan Weil --- hw/sh7750.c |2 +- hw/sh_intc.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/sh7750.c b/hw/sh7750.c index 4f4d8e7..e712928 100644 --- a/hw

[Qemu-devel] [PATCH 1/2] ppc: Add missing 'static' to spin_rw_ops

2012-02-25 Thread Stefan Weil
spin_rw_ops is only used in hw/ppce500_spin.c. Cc: Alexander Graf Signed-off-by: Stefan Weil --- hw/ppce500_spin.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/ppce500_spin.c b/hw/ppce500_spin.c index 6b8a189..6ed676b 100644 --- a/hw/ppce500_spin.c +++ b/hw

[Qemu-devel] [PATCH 0/2] Trivial MemoryRegionOps patches

2012-02-25 Thread Stefan Weil
Please apply http://patchwork.ozlabs.org/patch/139660/ to the qemu-trivial patch queue. Here are two additional trivial patches which also touch MemoryRegionOps and make the code more uniform. [PATCH 1/2] ppc: Add missing 'static' to spin_rw_ops [PATCH 2/2] sh7750: Remove redundant 'struct' from M

[Qemu-devel] [PATCH] block/vmdk: Fix warning from splint (comparision of unsigned value)

2012-02-25 Thread Stefan Weil
l1_entry_sectors will never be less than 0. Signed-off-by: Stefan Weil --- block/vmdk.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index 5623ac1..45c003a 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -453,7 +453,7 @@ static int

[Qemu-devel] [PATCH] Fix sign of sscanf format specifiers

2012-02-25 Thread Stefan Weil
All values read by sscanf are unsigned, so replace %d by %u. This signed / unsigned mismatch was detected by splint. Signed-off-by: Stefan Weil --- cursor.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/cursor.c b/cursor.c index efc5917..76e262c 100644 --- a

[Qemu-devel] [PATCH] vnc: Fix packed boolean struct members

2012-02-25 Thread Stefan Weil
h are used as boolean values. Cc: Anthony Liguori Signed-off-by: Stefan Weil --- ui/vnc-auth-sasl.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/vnc-auth-sasl.h b/ui/vnc-auth-sasl.h index fd9b18a..ee243a9 100644 --- a/ui/vnc-auth-sasl.h +++ b/ui/vnc-auth-sasl.

[Qemu-devel] [PATCH] audio: Add some fall through comments

2012-02-25 Thread Stefan Weil
Static code analysers expect these comments for case statements without a break statement. Signed-off-by: Stefan Weil --- audio/audio.c|3 +++ audio/esdaudio.c |2 +- 2 files changed, 4 insertions(+), 1 deletions(-) diff --git a/audio/audio.c b/audio/audio.c index 5fff6de..398763f

[Qemu-devel] [PATCH] ds1338: Add missing break statement

2012-02-25 Thread Stefan Weil
Without the break statement, case 5 sets month and year from the same data. This does not look correct. The missing break was reported by splint. Signed-off-by: Stefan Weil --- hw/ds1338.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/ds1338.c b/hw/ds1338.c index

[Qemu-devel] [PATCH] libcacard: Use format specifier %u instead of %d for unsigned values

2012-02-25 Thread Stefan Weil
splint reported warnings for those code statements. Signed-off-by: Stefan Weil --- libcacard/vscclient.c | 20 ++-- 1 files changed, 10 insertions(+), 10 deletions(-) diff --git a/libcacard/vscclient.c b/libcacard/vscclient.c index e317a25..0adae13 100644 --- a/libcacard

[Qemu-devel] [PATCH] vnc: Add break statement

2012-02-25 Thread Stefan Weil
This was not a bug, but it is not common practice to omit the break statement from the last case statement before an empty default case. Any change of the default case would introduce a bug. This was reported as a warning by splint. Signed-off-by: Stefan Weil --- ui/vnc-enc-hextile-template.h

Re: [Qemu-devel] [PATCH] vnc: Add break statement

2012-02-25 Thread Stefan Weil
Am 25.02.2012 15:18, schrieb Eric Blake: On 02/25/2012 06:57 AM, Stefan Weil wrote: This was not a bug, but it is not common practice to omit the break statement from the last case statement before an empty default case. Any change of the default case would introduce a bug. This was reported

[Qemu-devel] [PULL] Malta patches

2012-02-25 Thread Stefan Weil
for LED array (2012-02-25 15:28:38 +0100) Stefan Weil (4): malta: Clean allocation of bios region alias malta: Always allocate flash memory malta: Use symbolic hardware addresses malta: Fix display for LED

Re: [Qemu-devel] [PATCH 5/6] gtk: add support for screen scaling and full screen

2012-02-25 Thread Stefan Weil
a better choice instead of GDK_KEY_equal because that's the key used to zoom in by GNOME terminal, most web browsers and many more programs. Usually there is also a "Zoom 100 %" with GDK_KEY_0 which resets zooming to 100 %. Regards, Stefan Weil

Re: [Qemu-devel] [PATCH] vnc: Add break statement

2012-02-25 Thread Stefan Weil
Am 25.02.2012 16:57, schrieb Andreas Färber: Am 25.02.2012 14:57, schrieb Stefan Weil: This was not a bug, but it is not common practice to omit the break statement from the last case statement before an empty default case. Any change of the default case would introduce a bug. This was

Re: [Qemu-devel] [PATCH 3/6] gtk: add virtual console support

2012-02-25 Thread Stefan Weil
n function gtk_display_init there is also a g_malloc0 which should be replaced by g_new0. Regards, Stefan Weil

Re: [Qemu-devel] [PATCH v2] w32: Support tests (make check)

2012-02-25 Thread Stefan Weil
Am 25.02.2012 17:31, schrieb Andreas Färber: Am 22.02.2012 20:48, schrieb Stefan Weil: Adding $(EXESUF) is needed to make those tests work on w32 hosts, too. v2: Rebased, added new tests, tests sorted alphabetically. Signed-off-by: Stefan Weil --- tests/Makefile | 38

Re: [Qemu-devel] [PATCH 0/6] Add GTK UI to enable basic accessibility

2012-02-25 Thread Stefan Weil
crashing never is, but when it crashes, at least the error message should be good :-)). The bug also occurred a second time when I started MIPS Malta (when the Linux kernel loaded module cirrusfb), so it seems to be reproducible. Regards, Stefan Weil

Re: [Qemu-devel] [PATCH 3/6] gtk: add virtual console support

2012-02-25 Thread Stefan Weil
Am 25.02.2012 20:49, schrieb Anthony Liguori: On 02/25/2012 10:21 AM, Stefan Weil wrote: Am 20.02.2012 00:45, schrieb Anthony Liguori: This enables VteTerminal to be used to render the text consoles. VteTerminal is the same widget used by gnome-terminal which means it's VT100 emulation

Re: [Qemu-devel] [PATCH 06/10] qtest: add rtc-test test-case (v2)

2012-02-25 Thread Stefan Weil
ise I'd have to rebase it again. See http://lists.nongnu.org/archive/html/qemu-devel/2012-02/msg03096.html Running the tests on w32 hosts is required because there are w32 specific implementations for coroutines, timers, ... whichneed tests, too. Thanks, Stefan Weil

Re: [Qemu-devel] [PATCH 0/6] Add GTK UI to enable basic accessibility

2012-02-25 Thread Stefan Weil
Am 25.02.2012 21:11, schrieb Anthony Liguori: On 02/25/2012 11:02 AM, Stefan Weil wrote: Am 20.02.2012 00:44, schrieb Anthony Liguori: Hi, I realize UIs are the third rail of QEMU development, but over the years I've gotten a lot of feedback from users about our UI. I think eve

[Qemu-devel] Very small VGA window sizes (was: Re: [PATCH 0/6] Add GTK UI to enable basic accessibility)

2012-02-25 Thread Stefan Weil
Am 25.02.2012 22:15, schrieb Stefan Weil: Am 25.02.2012 21:11, schrieb Anthony Liguori: On 02/25/2012 11:02 AM, Stefan Weil wrote: Am 20.02.2012 00:44, schrieb Anthony Liguori: Hi, I realize UIs are the third rail of QEMU development, but over the years I've gotten a lot of feedback

[Qemu-devel] [PATCH] libcacard: Spelling and grammar fixes in documentation

2012-02-26 Thread Stefan Weil
* it's -> its * it's -> it is (that's no fix, but makes future checks easier) * this functions -> this function * replacable -> replaceable * reader's -> readers * logins into -> logs into Signed-off-by: Stefan Weil --- docs/libcacard.txt | 22 +

[Qemu-devel] [PATCH] Spelling fixes in comments (it's -> its)

2012-02-26 Thread Stefan Weil
* it's -> its (fixed for all files) * dont -> don't (only fixed in a line which was touched by the previous fix) Signed-off-by: Stefan Weil --- configure |2 +- hw/exynos4210_mct.c |2 +- hw/usb-ccid.c |2 +- include/qemu/object.h |4

[Qemu-devel] [PATCH] Fix spelling in comments (iff -> if)

2012-02-26 Thread Stefan Weil
Signed-off-by: Stefan Weil --- a.out.h|2 +- arm-dis.c | 22 +++--- block.c|2 +- block/qcow2-refcount.c |4 ++-- hw/alpha_typhoon.c |2 +- hw/hid.h |2 +- hw/pcnet.c |2 +- m68k

[Qemu-devel] [PATCH v2] Spelling fixes in comments (it's -> its)

2012-02-26 Thread Stefan Weil
* it's -> its (fixed for all files) * dont -> don't (only fixed in a line which was touched by the previous fix) * distrub -> disturb (fixed in the same line) Reviewed-by: Andreas Färber Signed-off-by: Stefan Weil --- This 2nd version of the patch added the fix for '

Re: [Qemu-devel] [PATCH] libcacard: Spelling and grammar fixes in documentation

2012-02-26 Thread Stefan Weil
Am 26.02.2012 19:18, schrieb Peter Maydell: On 26 February 2012 13:30, Stefan Weil wrote: @@ -217,10 +217,10 @@ the card using the following functions: VCardStatus vcard_add_applet(VCard *card, VCardApplet *applet); Add an applet onto the list of applets attached to the card

Re: [Qemu-devel] [PATCH] Fix spelling in comments (iff -> if)

2012-02-26 Thread Stefan Weil
Am 26.02.2012 17:39, schrieb Anthony Liguori: On 02/26/2012 07:39 AM, Stefan Weil wrote: Signed-off-by: Stefan Weil --- a.out.h|2 +- arm-dis.c | 22 +++--- block.c|2 +- block/qcow2-refcount.c |4 ++-- hw

[Qemu-devel] [PATCH v2] libcacard: Spelling and grammar fixes in documentation

2012-02-26 Thread Stefan Weil
* it's -> its * it's -> it is (that's no fix, but makes future checks easier) * this functions -> this function * replacable -> replaceable * reader's -> readers * logins into -> logs into v2: Also replace 'aid' by 'AID' (thanks to

Re: [Qemu-devel] [PATCH 6/8] gtk: add support for screen scaling and full screen (v2)

2012-02-27 Thread Stefan Weil
nu entries. In your previous patch, you scaled s->scale_x *= 1.25 (which was correct) and s->scale_x *= 0.75 (which should have been s->scale_x *= 0.8). Why do you now use s->scale_x += .25, s->scale_x -= .25? Linear scaling is uncommon and not what I'd expect when I read 25 % zooming in / out. I know that SDL also uses linear scaling, but GTK wants to be better than SDL. Regards, Stefan Weil

[Qemu-devel] [PATCH v3] libcacard: Spelling and grammar fixes in documentation

2012-02-27 Thread Stefan Weil
ter Maydell for this hint). v3: Fix sentence (contributed by Alon Levy / Robert Relyea). Cc: Alon Levy Cc: Robert Relyea Cc: Peter Maydell Signed-off-by: Stefan Weil --- docs/libcacard.txt | 26 +- 1 files changed, 13 insertions(+), 13 deletions(-) diff --git a/docs

Re: [Qemu-devel] [PATCH 7/8] gtk: add translation support

2012-02-27 Thread Stefan Weil
100644 po/messages.po What about using the Translation Project (which is already used by other well known GTK based projects) for QEMU, too? See http://translationproject.org/ for more information. Regards, Stefan Weil

[Qemu-devel] [PATCH] sdl: Add QEMU mascot icon for use with SDL

2012-02-28 Thread Stefan Weil
e and replaces the default X icon. Signed-off-by: Stefan Weil --- pc-bios/qemu-icon.bmp | Bin 0 -> 630 bytes 1 files changed, 0 insertions(+), 0 deletions(-) create mode 100644 pc-bios/qemu-icon.bmp diff --git a/pc-bios/qemu-icon.bmp b/pc-bios/qemu-icon.bmp new file mode 1006

Re: [Qemu-devel] [PATCH] sdl: Add QEMU mascot icon for use with SDL

2012-02-28 Thread Stefan Weil
Am 28.02.2012 19:19, schrieb Stefan Weil: This is a bitmap file (32x32x4) derived from the official QEMU mascot (which was designed by Benoît Canet). I stripped the text from the SVG to get a nearly square image and converted the result to BMP without any manual optimization. The bitmap is

[Qemu-devel] [PATCH 10/15] target-ppc: Clean includes

2012-02-28 Thread Stefan Weil
Remove some include statements which are not needed. Acked-by: Alexander Graf Signed-off-by: Stefan Weil --- target-ppc/helper.c|6 -- target-ppc/translate.c |6 -- 2 files changed, 0 insertions(+), 12 deletions(-) diff --git a/target-ppc/helper.c b/target-ppc/helper.c

[Qemu-devel] [PATCH 01/15] Remove macro HOST_LONG_SIZE

2012-02-28 Thread Stefan Weil
HOST_LONG_SIZE is simply the size of a pointer value. There is no need for this macro. Signed-off-by: Stefan Weil --- cpu-defs.h |2 -- thunk.h|4 ++-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/cpu-defs.h b/cpu-defs.h index 57a709b..4527cbf 100644 --- a/cpu

[Qemu-devel] [PATCH 03/15] target-arm: Clean includes

2012-02-28 Thread Stefan Weil
Remove some include statements which are not needed. Reviewed-by: Peter Maydell Signed-off-by: Stefan Weil --- target-arm/helper.c |5 - 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/target-arm/helper.c b/target-arm/helper.c index 4929372..abe1c30 100644 --- a/target

[Qemu-devel] [PATCH 09/15] target-mips: Clean includes

2012-02-28 Thread Stefan Weil
Remove some include statements which are not needed. Cc: Aurelien Jarno Signed-off-by: Stefan Weil --- target-mips/translate.c |7 --- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git a/target-mips/translate.c b/target-mips/translate.c index d5b1c76..8361d88 100644 --- a

[Qemu-devel] [PATCH 05/15] target-i386: Clean includes

2012-02-28 Thread Stefan Weil
Remove some include statements which are not needed. Signed-off-by: Stefan Weil --- target-i386/helper.c|6 -- target-i386/op_helper.c |1 - 2 files changed, 0 insertions(+), 7 deletions(-) diff --git a/target-i386/helper.c b/target-i386/helper.c index 2586aff..87c6a8f 100644

[Qemu-devel] [PATCH 15/15] Move definition of HOST_LONG_BITS to qemu-common.h

2012-02-28 Thread Stefan Weil
Like the related macro TCG_TARGET_LONG, HOST_LONG_BITS can be determined by the C preprocessor. It is also not used in Makefiles. So there is no need to calculate it in configure, and it can be defined in qemu-common.h. Signed-off-by: Stefan Weil --- configure | 12 qemu

[Qemu-devel] [PATCH 08/15] target-microblaze: Clean includes

2012-02-28 Thread Stefan Weil
The change in cpu.h is needed when HOST_LONG_BITS is defined in qemu-common.h. Signed-off-by: Stefan Weil --- target-microblaze/cpu.h |3 +++ target-microblaze/helper.c|5 - target-microblaze/mmu.c |4 target-microblaze/translate.c |8 4 files

Re: [Qemu-devel] [PATCH 2/3] slirp: Fix requeuing of batchq packets in if_start

2012-02-28 Thread Stefan Weil
atch, MIPS Malta worked again as before. So maybe we changed one crash against a new one. Regards, Stefan Weil Program received signal SIGSEGV, Segmentation fault. 0x5577b2a4 in ifs_insque (ifm=0x56eb0e10, ifmhead=0x0) at /home/stefan/src/qemu/repo.or.cz/qemu/ar7/slirp/i

[Qemu-devel] [PATCH 11/15] target-s390x: Clean includes

2012-02-28 Thread Stefan Weil
The change in cpu.h is needed when HOST_LONG_BITS is defined in qemu-common.h. Signed-off-by: Stefan Weil --- target-s390x/cpu.h |3 +++ target-s390x/helper.c|5 - target-s390x/translate.c |5 - 3 files changed, 3 insertions(+), 10 deletions(-) diff --git a/target

[Qemu-devel] [PATCH 13/15] target-unicore32: Clean includes

2012-02-28 Thread Stefan Weil
The change in cpu.h is needed when HOST_LONG_BITS is defined in qemu-common.h. Signed-off-by: Stefan Weil --- target-unicore32/cpu.h|2 ++ target-unicore32/helper.c |4 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/target-unicore32/cpu.h b/target-unicore32

[Qemu-devel] [PULL] Patch queue

2012-02-28 Thread Stefan Weil
Hi, please pull these patches from January. Thanks, Stefan Weil The following changes since commit b55c952aea6de024bf1a06357b49367fba045443: Merge remote-tracking branch 'aneesh/for-upstream' into staging (2012-02-27 11:19:27 -0600) are available in the git repository a

[Qemu-devel] [PATCH 12/15] target-sh4: Clean includes

2012-02-28 Thread Stefan Weil
Remove some include statements which are not needed. Cc: Aurelien Jarno Signed-off-by: Stefan Weil --- target-sh4/translate.c |6 -- 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/target-sh4/translate.c b/target-sh4/translate.c index aacf96d..dd0ee4b 100644 --- a/target

[Qemu-devel] [PATCH 06/15] target-lm32: Clean includes

2012-02-28 Thread Stefan Weil
config.h was missing in cpu.h. Acked-by: Michael Walle Signed-off-by: Stefan Weil --- target-lm32/cpu.h |1 + target-lm32/helper.c|5 - target-lm32/translate.c |8 3 files changed, 1 insertions(+), 13 deletions(-) diff --git a/target-lm32/cpu.h b/target-lm32

[Qemu-devel] [PATCH 02/15] target-alpha: Clean includes

2012-02-28 Thread Stefan Weil
The change in cpu.h is needed when HOST_LONG_BITS is defined in qemu-common.h. Cc: Richard Henderson Signed-off-by: Stefan Weil --- target-alpha/cpu.h |1 + target-alpha/translate.c |5 - 2 files changed, 1 insertions(+), 5 deletions(-) diff --git a/target-alpha/cpu.h b

[Qemu-devel] [PATCH 04/15] target-cris: Clean includes

2012-02-28 Thread Stefan Weil
The change in cpu.h is needed when HOST_LONG_BITS is defined in qemu-common.h. Cc: Edgar E. Iglesias Signed-off-by: Stefan Weil --- target-cris/cpu.h |3 +++ target-cris/helper.c|4 target-cris/mmu.c |5 - target-cris/translate.c |7 --- 4 files

[Qemu-devel] [PATCH 14/15] target-xtensa: Clean includes

2012-02-28 Thread Stefan Weil
Remove some include statements which are not needed. Acked-by: Max Filippov Signed-off-by: Stefan Weil --- target-xtensa/core-dc232b.c |1 - target-xtensa/core-fsf.c|1 - target-xtensa/helper.c |1 - 3 files changed, 0 insertions(+), 3 deletions(-) diff --git a/target

[Qemu-devel] [PATCH 07/15] target-m68k: Clean includes

2012-02-28 Thread Stefan Weil
config.h was missing in cpu.h. Signed-off-by: Stefan Weil --- target-m68k/cpu.h |1 + target-m68k/helper.c|5 - target-m68k/translate.c |6 -- 3 files changed, 1 insertions(+), 11 deletions(-) diff --git a/target-m68k/cpu.h b/target-m68k/cpu.h index 0667f82

Re: [Qemu-devel] [PATCH 09/15] target-mips: Clean includes

2012-02-28 Thread Stefan Weil
git master. This is a problem which is not related to my patch series. Cheers, Stefan W. -Original Message- From: qemu-devel-bounces+ericj=mips@nongnu.org [mailto:qemu-devel-bounces+ericj=mips@nongnu.org] On Behalf Of Stefan Weil Sent: Tuesday, February 28, 2012 1:47 PM T

Re: [Qemu-devel] full valrind report

2012-02-29 Thread Stefan Weil
Am 29.02.2012 17:19, schrieb Michael S. Tsirkin: Here's a full report of possible leaks: Any idea? I am invedtigating. Hi Michael, try valgrind with --track-origins=yes. It costs some memory, but improves diagnostics not only for memory leaks. Most important are the leaks marked with "definit

Re: [Qemu-devel] [PATCH 0/4] slirp: Fix for requeuing crash, cleanups

2012-02-29 Thread Stefan Weil
Am 29.02.2012 20:15, schrieb Jan Kiszka: This is an alternative, more complete approach to fix the requeuing- related crashes reported recently. See patch 2 for details. The rest are simple cleanups. Please check carefully if I messed something up. Hi Jan, here is the result of MIPS Malta wi

Re: [Qemu-devel] [PATCH 0/4] slirp: Fix for requeuing crash, cleanups

2012-02-29 Thread Stefan Weil
Am 29.02.2012 22:33, schrieb Jan Kiszka: On 2012-02-29 22:00, Stefan Weil wrote: Am 29.02.2012 20:15, schrieb Jan Kiszka: This is an alternative, more complete approach to fix the requeuing- related crashes reported recently. See patch 2 for details. The rest are simple cleanups. Please check

[Qemu-devel] [PATCH] usb: Fix compilation for hosts which use the usb-stub

2012-02-29 Thread Stefan Weil
Commit 3741715cf2e54727fe3d9884ea6dcea68c7f7d4b added a new parameter which was still missing here. Signed-off-by: Stefan Weil --- usb-stub.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/usb-stub.c b/usb-stub.c index 9c3fcea..bfd8bb0 100644 --- a/usb-stub.c +++ b

Re: [Qemu-devel] Add support for new image type

2012-03-01 Thread Stefan Weil
le who don't want support for your image type. Regards, Stefan Weil

Re: [Qemu-devel] Add support for new image type

2012-03-01 Thread Stefan Weil
Am 01.03.2012 21:10, schrieb Stefan Weil: Am 01.03.2012 20:45, schrieb Kai Meyer: On 03/01/2012 08:03 AM, Kevin Wolf wrote: Am 29.02.2012 22:52, schrieb Kai Meyer: Is it possible to extend qemu to support a new image type? I have an image type that is ready for consumption and I'm lookin

Re: [Qemu-devel] Add support for new image type

2012-03-01 Thread Stefan Weil
Am 01.03.2012 21:26, schrieb Kai Meyer: On 03/01/2012 01:10 PM, Stefan Weil wrote: Am 01.03.2012 20:45, schrieb Kai Meyer: On 03/01/2012 08:03 AM, Kevin Wolf wrote: Am 29.02.2012 22:52, schrieb Kai Meyer: Is it possible to extend qemu to support a new image type? I have an image type that is

Re: [Qemu-devel] [PATCH v2 0/4] slirp: Fix for requeuing crash, cleanups

2012-03-02 Thread Stefan Weil
(TM). This also comes with a fix for resource cleanups on slirp shutdown. At least valgrind is happy now. Changes in v2: - fixed corner case of session list walk that Stefan Weil reported CC: Fabien Chouteau CC: Michael S. Tsirkin CC: Stefan Weil CC: Zhi Yong Wu Jan Kiszka (4): slirp: Keep

[Qemu-devel] [PATCH 2/6] tcg: Rearrange definitions and include statements

2012-03-02 Thread Stefan Weil
This change makes tcg_target_ulong available in tcg-target.h. Signed-off-by: Stefan Weil --- tcg/tcg.h |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tcg/tcg.h b/tcg/tcg.h index 5c28239..cc223ea 100644 --- a/tcg/tcg.h +++ b/tcg/tcg.h @@ -32,9 +32,6 @@ # error

[Qemu-devel] [PATCH 5/6] cache-utils: Change data type of parameters for flush_icache_range

2012-03-02 Thread Stefan Weil
The TCG targets i386 and tci needed a change of the function prototype for w64. This change is currently not needed here, but it can be applied to avoid code differences. Cc: Alexander Graf Signed-off-by: Stefan Weil --- cache-utils.h |2 +- 1 files changed, 1 insertions(+), 1 deletions

[Qemu-devel] [PATCH 4/6] w64: Change data type of parameters for flush_icache_range

2012-03-02 Thread Stefan Weil
Signed-off-by: Stefan Weil --- tcg/arm/tcg-target.h |3 ++- tcg/hppa/tcg-target.h |4 +++- tcg/ia64/tcg-target.h |3 ++- tcg/mips/tcg-target.h |3 ++- tcg/s390/tcg-target.h |3 ++- tcg/sparc/tcg-target.h |3 ++- 6 files changed, 13 insertions(+), 6 deletions(-) diff

[Qemu-devel] [PATCH 3/6] w64: Fix data type of parameters for flush_icache_range

2012-03-02 Thread Stefan Weil
while sizeof(void *) is 8, so the use of tcg_target_ulong is needed for i386 and tci (the tcg targets which work with w64). Signed-off-by: Stefan Weil --- tcg/i386/tcg-target.h |3 ++- tcg/tci/tcg-target.h |3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/tcg/i386/tcg

[Qemu-devel] [PATCH 6/6] w64: fix type casts when calling flush_icache_range

2012-03-02 Thread Stefan Weil
Signed-off-by: Stefan Weil --- tcg/tcg.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index 351a0a3..cd2db3c 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -253,8 +253,8 @@ void tcg_prologue_init(TCGContext *s) s->code_

[Qemu-devel] [PATCH 0/6] w64: Improve compilation with MinGW-w64

2012-03-02 Thread Stefan Weil
These patches are a step towards full 64 bit support for w64. The patches 4 and 5 are optional. Please apply this series. Thanks, Stefan Weil [PATCH 1/6] w64: Fix size of ram_addr_t [PATCH 2/6] tcg: Rearrange definitions and include statements [PATCH 3/6] w64: Fix data type of parameters for

[Qemu-devel] [PATCH 1/6] w64: Fix size of ram_addr_t

2012-03-02 Thread Stefan Weil
uintptr_t is needed. Signed-off-by: Stefan Weil --- cpu-common.h |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/cpu-common.h b/cpu-common.h index a40c57d..dca5175 100644 --- a/cpu-common.h +++ b/cpu-common.h @@ -28,9 +28,9 @@ typedef uint64_t ram_addr_t; # define

Re: [Qemu-devel] buildbot failure in qemu on block_mingw32

2012-03-03 Thread Stefan Weil
orted, and there are two identical patches which both fix it: http://patchwork.ozlabs.org/patch/143918/ http://patchwork.ozlabs.org/patch/143973/ Could someone with commit rights please commit one of these patches to QEMU git master? Thanks, Stefan Weil

[Qemu-devel] [PATCH] target-mips: Fix some helper functions (VR54xx multiplication)

2012-03-03 Thread Stefan Weil
: Stefan Weil --- Is anybody using QEMU with MIPS VR5432 code which uses the special multiply opcodes? I don't have such code, so I could not test my patch. Regards, Stefan Weil target-mips/op_helper.c | 75 ++ 1 files changed, 29 insertions(+

[Qemu-devel] [PATCH] osdep: Remove local definition of macro offsetof

2012-03-04 Thread Stefan Weil
simply removes the unneeded code from the files configure and osdep.h. If we ever need the local definition again, it should be added to compiler.h (the macro is usually provided with the compiler, it is not OS specific). Signed-off-by: Stefan Weil --- configure | 14 -- osdep.h

Re: [Qemu-devel] [PATCH] osdep: Remove local definition of macro offsetof

2012-03-05 Thread Stefan Weil
Am 05.03.2012 14:49, schrieb Peter Maydell: On 5 March 2012 13:23, Andreas Färber wrote: Am 05.03.2012 07:22, schrieb Stefan Weil: The macro offsetof is defined in stddef.h. It is conforming to the standards C89, C99 and POSIX.1-2001 (see man page), so it is a sufficiently old standard

Re: [Qemu-devel] [PATCH 5/6] cache-utils: Change data type of parameters for flush_icache_range

2012-03-05 Thread Stefan Weil
Am 05.03.2012 19:57, schrieb Alexander Graf: On 03/02/2012 11:30 PM, Stefan Weil wrote: The TCG targets i386 and tci needed a change of the function prototype for w64. This change is currently not needed here, but it can be applied to avoid code differences. Cc: Alexander Graf Signed-off-by

[Qemu-devel] [PATCH] cache-utils: Add missing include file for uintptr_t

2012-03-05 Thread Stefan Weil
Commit 021ecd8b9db37927059f5d3234b51ed766706437 breaks the build for PPC hosts because it uses uintptr_t without the necessary include file. uintptr_t is defined in stdint.h, so add this include. Cc: Alexander Graf Signed-off-by: Stefan Weil --- Hi Alex, could you please test whether my

Re: [Qemu-devel] [PATCH v2 0/4] slirp: Fix for requeuing crash, cleanups

2012-03-07 Thread Stefan Weil
this. Thanks for testing so far, will likely need your services again soon. I'm careful now with claiming it's fixed, but this version git://git.kiszka.org/qemu.git queues/slirp passes all tests that broke in the past. Please have another try. Jan Tested-by: Stefan Weil Hi Jan,

Re: [Qemu-devel] [PATCH 2/2] cache-utils.h needs stdint.h for uintptr_t

2012-03-07 Thread Stefan Weil
Am 08.03.2012 02:09, schrieb David Gibson: cache-utils.h uses the C99 standard uintptr_t type. However, that type comes from stdint.h which is not #included before cache-utils.h in all configurations. This patch adds the necessary include to fix this. Signed-off-by: David Gibson --- cache-ut

[Qemu-devel] [PATCH v2] vnc: Fix packed boolean struct members

2012-03-08 Thread Stefan Weil
piler does not like code which does bool = unsigned = bool = 0 Splitting that code in three statements works. Cc: Anthony Liguori Signed-off-by: Stefan Weil --- ui/vnc-auth-sasl.c |4 +++- ui/vnc-auth-sasl.h |4 ++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/ui/vnc-a

[Qemu-devel] [PATCH] w64: Don't redefine lseek, ftruncate

2012-03-10 Thread Stefan Weil
MinGW-w64 already defines lseek and ftruncate (and uses the 64 bit variants). The conditional compilation avoids redefinitions (which would be wrong) and compiler warnings. Signed-off-by: Stefan Weil --- qemu-common.h |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PATCH] configure: Test for libiberty.a (mingw32)

2012-03-10 Thread Stefan Weil
MinGW-w64 and some versions of MinGW32 don't provide libiberty.a, so add this library only if it was found. Signed-off-by: Stefan Weil --- configure |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/configure b/configure index ca25250..bb16498 100755

Re: [Qemu-devel] [PATCH] w64: Don't redefine lseek, ftruncate

2012-03-10 Thread Stefan Weil
Am 10.03.2012 13:11, schrieb Andreas Färber: Am 10.03.2012 11:14, schrieb Stefan Weil: MinGW-w64 already defines lseek and ftruncate (and uses the 64 bit variants). The conditional compilation avoids redefinitions (which would be wrong) and compiler warnings. Signed-off-by: Stefan Weil

Re: [Qemu-devel] [PATCH] configure: Test for libiberty.a (mingw32)

2012-03-10 Thread Stefan Weil
Am 10.03.2012 17:28, schrieb Andreas Färber: Am 10.03.2012 11:14, schrieb Stefan Weil: MinGW-w64 and some versions of MinGW32 don't provide libiberty.a, so add this library only if it was found. What do we need it for at all then? Andreas Signed-off-by: Stefan Weil --- configur

[Qemu-devel] [PATCH] tcg: Improve tcg_out_label and fix its usage for w64

2012-03-10 Thread Stefan Weil
not matter, but for w64 it was wrong. This is fixed now. Cc: Blue Swirl Cc: Richard Henderson Signed-off-by: Stefan Weil --- tcg/hppa/tcg-target.c |8 tcg/i386/tcg-target.c |8 tcg/sparc/tcg-target.c |6 +++--- tcg/tcg.c |6 +++--- 4 files changed

Re: [Qemu-devel] [PATCH] Add missing const attributes for MemoryRegionOps

2012-03-10 Thread Stefan Weil
Am 05.02.2012 21:19, schrieb Stefan Weil: Most MemoryRegionOps already had the const attribute. This patch adds it to the remaining ones. Signed-off-by: Stefan Weil --- hw/cuda.c |2 +- hw/ide/ahci.c |4 ++-- hw/ide/cmd646.c|6 +++--- hw/ide/macio.c |2

Re: [Qemu-devel] [PATCH] ds1338: Add missing break statement

2012-03-10 Thread Stefan Weil
Am 25.02.2012 14:50, schrieb Stefan Weil: Without the break statement, case 5 sets month and year from the same data. This does not look correct. The missing break was reported by splint. Signed-off-by: Stefan Weil --- hw/ds1338.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff

[Qemu-devel] [PATCH] slirp: Fix compiler warning for w64

2012-03-10 Thread Stefan Weil
matter here and casting pointers to unsigned values seems more reasonable (the unsigned value is a non negative offset. Cc: Jan Kiszka Signed-off-by: Stefan Weil --- slirp/cksum.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/slirp/cksum.c b/slirp/cksum.c index e43867d

<    5   6   7   8   9   10   11   12   13   14   >