negotiated, or
- performing a separate VHOST_USER_GET_FEATURES *exchange*, which requires
a backend response regardless of VHOST_USER_PROTOCOL_F_REPLY_ACK.
Thanks for the excellent analysis (and fix of course!).
Cc: "Michael S. Tsirkin" (supporter:vhost)
Cc: Eugenio Perez Martin
Cc: German Maglione
Cc: Liu Ji
re hard-coded within
"vhost_user_write_msg".
Cc: "Michael S. Tsirkin" (supporter:vhost)
Cc: Eugenio Perez Martin
Cc: German Maglione
Cc: Liu Jiang
Cc: Sergio Lopez Pascual
Cc: Stefano Garzarella
Signed-off-by: Laszlo Ersek
---
hw/virtio/vhost-user.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
Reviewed-by: Stefano Garzarella
genio Perez Martin
Cc: German Maglione
Cc: Liu Jiang
Cc: Sergio Lopez Pascual
Cc: Stefano Garzarella
Signed-off-by: Laszlo Ersek
---
hw/virtio/vhost-user.c | 32
1 file changed, 13 insertions(+), 19 deletions(-)
Reviewed-by: Stefano Garzarella
uot;vhost_set_vring".
This is purely code movement -- no observable change.
Cc: "Michael S. Tsirkin" (supporter:vhost)
Cc: Eugenio Perez Martin
Cc: German Maglione
Cc: Liu Jiang
Cc: Sergio Lopez Pascual
Cc: Stefano Garzarella
Signed-off-by: Laszlo Ersek
---
hw/virtio/vhost-user
y refactoring -- no observable change.
Cc: "Michael S. Tsirkin" (supporter:vhost)
Cc: Eugenio Perez Martin
Cc: German Maglione
Cc: Liu Jiang
Cc: Sergio Lopez Pascual
Cc: Stefano Garzarella
Signed-off-by: Laszlo Ersek
---
hw/virtio/vhost-user.c | 66 +---
1 file
o the minimum.
This is purely refactoring -- no observable change.
Cc: "Michael S. Tsirkin" (supporter:vhost)
Cc: Eugenio Perez Martin
Cc: German Maglione
Cc: Liu Jiang
Cc: Sergio Lopez Pascual
Cc: Stefano Garzarella
Signed-off-by: Laszlo Ersek
---
hw/virtio/vhost-user.c | 11 ++
On Sun, Aug 27, 2023 at 08:29:31PM +0200, Laszlo Ersek wrote:
Cc: "Michael S. Tsirkin" (supporter:vhost)
Cc: Eugenio Perez Martin
Cc: German Maglione
Cc: Liu Jiang
Cc: Sergio Lopez Pascual
Cc: Stefano Garzarella
Signed-off-by: Laszlo Ersek
---
hw/virtio/vhost-user.c | 2 +-
1 fi
Hi Michael,
On Thu, Aug 3, 2023 at 10:02 PM Michael S. Tsirkin wrote:
>
> On Wed, Jul 05, 2023 at 09:15:23AM +0200, Stefano Garzarella wrote:
> > This reverts commit 8cc5583abe6419e7faaebc9fbd109f34f4c850f2.
> >
> > That commit causes several problems in Linu
Signed-off-by: Stefano Garzarella
---
block/blkio.c | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/block/blkio.c b/block/blkio.c
index baba2f0b67..1dd495617c 100644
--- a/block/blkio.c
+++ b/block/blkio.c
@@ -713,6 +713,12 @@ static int blkio_virtio_blk_connect(BlockD
Hanna discovered an fd leak in the error path, and a few comments to
improve in the code.
v2:
- avoid to use `fd_supported` to track a valid fd [Hanna]
v1:
https://lore.kernel.org/qemu-devel/20230801160332.122564-1-sgarz...@redhat.com/
Stefano Garzarella (2):
block/blkio: close the fd when
libblkio drivers take ownership of `fd` only after a successful
blkio_connect(), so if it fails, we are still the owners.
Fixes: cad2ccc395 ("block/blkio: use qemu_open() to support fd passing for
virtio-blk")
Suggested-by: Hanna Czenczek
Signed-off-by: Stefano Garzarella
---
Not
On Wed, Aug 02, 2023 at 01:15:40PM +0200, Hanna Czenczek wrote:
On 01.08.23 18:03, Stefano Garzarella wrote:
libblkio drivers take ownership of `fd` only after a successful
blkio_connect(), so if it fails, we are still the owners.
Fixes: cad2ccc395 ("block/blkio: use qemu_open() to suppo
libblkio drivers take ownership of `fd` only after a successful
blkio_connect(), so if it fails, we are still the owners.
Fixes: cad2ccc395 ("block/blkio: use qemu_open() to support fd passing for
virtio-blk")
Suggested-by: Hanna Czenczek
Signed-off-by: Stefano Garzarella
---
blo
Hanna discovered an fd leak in the error path, and a few comments to
improve in the code.
Stefano Garzarella (2):
block/blkio: close the fd when blkio_connect() fails
block/blkio: add more comments on the fd passing handling
block/blkio.c | 24 +---
1 file changed, 21
As Hanna pointed out, it is not clear in the code why qemu_open()
can fail, and why blkio_set_int("fd") is not enough to discover
the `fd` property support.
Let's fix them by adding more details in the code comments.
Suggested-by: Hanna Czenczek
Signed-off-by: Stefano Garzarella
in UDS
- changed patch 4 commit description [Stefan]
v1:
https://lore.kernel.org/qemu-devel/20230724154611.178858-1-sgarz...@redhat.com/
Based on stefanha/block branch.
Stefano Garzarella (4):
block/blkio: move blkio_connect() in the drivers functions
block/blkio: retry blkio_connect
passing.
This patch switches to setting the `fd` property because it is a
better mechanism for probing fd passing support than getting the `fd`
property.
Signed-off-by: Stefano Garzarella
---
Notes:
v2:
- changed commit description [Stefan]
block/blkio.c | 2 +-
1 file changed, 1 insertion
`s always fall back
on using `path` if we fail the fd passing.
Fixes: cad2ccc395 ("block/blkio: use qemu_open() to support fd passing for
virtio-blk")
Reported-by: Qing Wang
Signed-off-by: Stefano Garzarella
---
block/blkio.c | 20 ++--
1 file changed, 10 inserti
/blkio: use qemu_open() to support fd passing for
virtio-blk")
Suggested-by: Stefan Hajnoczi
Signed-off-by: Stefano Garzarella
---
Notes:
v2:
- reworked retrying blkio_connect() [Stefan]
block/blkio.c | 29 +
1 file changed, 29 insertions(+)
diff --gi
This is in preparation for the next patch, where for virtio-blk
drivers we need to handle the failure of blkio_connect().
Let's also rename the *_open() functions to *_connect() to make
the code reflect the changes applied.
Signed-off-by: Stefano Garzarella
---
block/blkio.c | 67
On Wed, Jul 26, 2023 at 11:32:10AM -0400, Stefan Hajnoczi wrote:
On Wed, Jul 26, 2023 at 09:26:45AM +0200, Stefano Garzarella wrote:
On Tue, Jul 25, 2023 at 04:00:38PM -0400, Stefan Hajnoczi wrote:
> On Mon, Jul 24, 2023 at 05:46:10PM +0200, Stefano Garzarella wrote:
> > libblkio 1.
ink: https://bugzilla.redhat.com/show_bug.cgi?id=2225439
Reported-by: Qing Wang
Signed-off-by: Stefano Garzarella
---
Notes:
v2:
- added comment on top of qemu_open() [Daniel]
v1:
https://lore.kernel.org/qemu-devel/2023072555.85426-1-sgarz...@redhat.com/
block/bl
On Tue, Jul 25, 2023 at 04:05:38PM -0400, Stefan Hajnoczi wrote:
On Mon, Jul 24, 2023 at 05:46:11PM +0200, Stefano Garzarella wrote:
The way the virtio-blk driver is implemented in libblkio,
it's much easier to use blkio_set_int() instead of blkio_get_int()
and have it fail right away to see
On Tue, Jul 25, 2023 at 04:00:38PM -0400, Stefan Hajnoczi wrote:
On Mon, Jul 24, 2023 at 05:46:10PM +0200, Stefano Garzarella wrote:
libblkio 1.3.0 added support of "fd" property for virtio-blk-vhost-vdpa
driver. In QEMU, starting from commit cad2ccc395 ("block/blkio: use
qemu_op
On Tue, Jul 25, 2023 at 12:15:40PM +0100, Daniel P. Berrangé wrote:
On Tue, Jul 25, 2023 at 01:11:55PM +0200, Stefano Garzarella wrote:
qemu_open() in blkio_virtio_blk_common_open() is used to open the
character device (e.g. /dev/vhost-vdpa-0 or /dev/vfio/vfio) or in
the future eventually
Qing Wang
Signed-off-by: Stefano Garzarella
---
block/blkio.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/block/blkio.c b/block/blkio.c
index 1798648134..fe9bf8ea5f 100644
--- a/block/blkio.c
+++ b/block/blkio.c
@@ -686,15 +686,7 @@ static int blkio_virtio_blk_c
, bool enable);
I discovered this while trying a development version of libblkio:
the guest kernel hangs during boot, while probing the device.
Fixes: fd66dbd424f5 ("blkio: add libblkio block driver")
Signed-off-by: Stefano Garzarella
---
block/blkio.c | 1 +
1 file changed, 1 insertio
The way the virtio-blk driver is implemented in libblkio,
it's much easier to use blkio_set_int() instead of blkio_get_int()
and have it fail right away to see if `fd` is supported by the
transport. See https://gitlab.com/libblkio/libblkio/-/merge_requests/208
Signed-off-by: Stefano Garzarella
d passing for
virtio-blk")
Reported-by: Qing Wang
Signed-off-by: Stefano Garzarella
---
block/blkio.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/block/blkio.c b/block/blkio.c
index 1798648134..ca1149042a 100644
--- a/block/blkio.c
+++ b/block/blkio.c
@@ -662,6
There is a problem with virtio-blk-vhost-vdpa. The first patch
fixes the issue, the second patch tries to prepare QEMU for a
future version of libblkio where we can use blkio_set_fd() to
check whether the property is supported or not.
Stefano Garzarella (2):
block/blkio: fix opening virtio-blk
On Thu, Apr 20, 2023 at 6:20 AM Jason Wang wrote:
>
> On Wed, Apr 19, 2023 at 11:33 PM Eugenio Perez Martin
> wrote:
> >
> > On Wed, Apr 19, 2023 at 12:56 AM wrote:
> > >
> > > From: Pei Li
> > >
> > > Currently, part of the vdpa initialization / startup process
> > > needs to trigger many
On Wed, Jul 12, 2023 at 06:38:14PM +0200, Paolo Bonzini wrote:
On 7/12/23 15:43, Stefano Garzarella wrote:
Commit 1880ad4f4e ("virtio-scsi: Batched prepare for cmd reqs") split
calls to scsi_req_new() and scsi_req_enqueue() in the virtio-scsi device.
This had no drawback, un
On Wed, Jul 12, 2023 at 12:14 PM Stefano Garzarella wrote:
>
> On Wed, Jul 12, 2023 at 10:06:56AM +0200, Paolo Bonzini wrote:
> >On 7/11/23 22:21, Mike Christie wrote:
> >>What was the issue you are seeing?
> >>
> >>Was it something like you get the UA.
ogs, and a big thanks to Paolo for his help
in preparing this series!
Stefano
[1]
https://lore.kernel.org/qemu-devel/i3od362o6unuimlqna3aaedliaabauj6g545esg7txidd4s44e@bkx5des6zytx/
Stefano Garzarella (3):
scsi: fetch unit attention when creating the request
scsi: cleanup scsi_clear_unit_
-by: Stefano Garzarella
---
hw/scsi/scsi-bus.c | 34 +++---
1 file changed, 11 insertions(+), 23 deletions(-)
diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c
index f9c95dfb50..fc4b77fdb0 100644
--- a/hw/scsi/scsi-bus.c
+++ b/hw/scsi/scsi-bus.c
@@ -22,6 +22,7
The previous commit moved the unit attention clearing when we create
the request. So now we can clean scsi_clear_unit_attention() to handle
only the case of the REPORT LUNS command.
Suggested-by: Paolo Bonzini
Signed-off-by: Stefano Garzarella
---
hw/scsi/scsi-bus.c | 28
rtio-scsi: Send "REPORTED LUNS CHANGED" sense data upon
disk hotplug events")
Reported-by: Thomas Huth
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=2176702
Co-developed-by: Paolo Bonzini
Signed-off-by: Stefano Garzarella
---
include/hw/scsi/scsi.h | 1 +
hw/scsi/scsi-
On Wed, Jul 12, 2023 at 10:35:48AM +0200, Paolo Bonzini wrote:
On 7/11/23 19:06, Stefano Garzarella wrote:
CCing `./scripts/get_maintainer.pl -f drivers/scsi/virtio_scsi.c`,
since I found a few things in the virtio-scsi driver...
FYI we have seen that Linux has problems with a QEMU patch
On Wed, Jul 12, 2023 at 10:06:56AM +0200, Paolo Bonzini wrote:
On 7/11/23 22:21, Mike Christie wrote:
What was the issue you are seeing?
Was it something like you get the UA. We retry then on one of the
retries the sense is not setup correctly, so the scsi error handler
runs? That fails and
On Tue, Jul 11, 2023 at 01:41:31PM -0400, Stefan Hajnoczi wrote:
On Tue, 11 Jul 2023 at 13:06, Stefano Garzarella wrote:
CCing `./scripts/get_maintainer.pl -f drivers/scsi/virtio_scsi.c`,
since I found a few things in the virtio-scsi driver...
FYI we have seen that Linux has problems
d.
Paolo, Stefan, Linux SCSI maintainers, any suggestion?
Thanks,
Stefano
On Wed, Jul 05, 2023 at 09:15:23AM +0200, Stefano Garzarella wrote:
This reverts commit 8cc5583abe6419e7faaebc9fbd109f34f4c850f2.
That commit causes several problems in Linux as described in the BZ.
In particular, after a wh
Hi Mark
On Fri, Jul 7, 2023 at 5:58 PM Mark Kanda wrote:
[...]
> >> On 7/5/2023 2:15 AM, Stefano Garzarella wrote:
> >>> This reverts commit 8cc5583abe6419e7faaebc9fbd109f34f4c850f2.
> >>>
> >>> That commit causes several problems in Linux as de
On Thu, Jul 06, 2023 at 05:31:15PM +0100, Alex Bennée wrote:
Alex Bennée writes:
Currently QEMU has to know some details about the back-end to be able
to setup the guest. While various parts of the setup can be delegated
to the backend (for example config handling) this is a very piecemeal
On Tue, Jul 04, 2023 at 04:02:42PM +0100, Alex Bennée wrote:
Stefano Garzarella writes:
On Tue, Jul 04, 2023 at 01:36:00PM +0100, Alex Bennée wrote:
Currently QEMU has to know some details about the back-end to be able
to setup the guest. While various parts of the setup can be delegated
Hi Mark,
On Wed, Jul 05, 2023 at 07:28:05AM -0500, Mark Kanda wrote:
On 7/5/2023 2:15 AM, Stefano Garzarella wrote:
This reverts commit 8cc5583abe6419e7faaebc9fbd109f34f4c850f2.
That commit causes several problems in Linux as described in the BZ.
In particular, after a while, other devices
-by: Thomas Huth
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=2176702
Cc: qemu-sta...@nongnu.org
Cc: Mark Kanda
Signed-off-by: Stefano Garzarella
---
include/hw/scsi/scsi.h | 1 -
hw/scsi/scsi-bus.c | 18 --
hw/scsi/virtio-scsi.c | 2 --
3 files changed, 21 deletions
On Tue, Jul 04, 2023 at 01:36:00PM +0100, Alex Bennée wrote:
Currently QEMU has to know some details about the back-end to be able
to setup the guest. While various parts of the setup can be delegated
to the backend (for example config handling) this is a very piecemeal
approach.
This patch
Hi Mark,
we have a bug [1] possibly related to this patch.
I saw this Oracle Linux errata [2] where you reverted this patch, but
there are no details.
Do you think we should revert it upstream as well?
Do you have any details about the problem it causes in Linux?
[1]
: fd66dbd424f5 ("blkio: add libblkio block driver")
Reported-by: Qing Wang
Cc: Stefano Garzarella
Signed-off-by: Stefan Hajnoczi
---
v2:
- Drop unnecessary backslashes [Stefano]
---
block/blkio.c | 108 ++
1 file changed, 56 inserti
: fd66dbd424f5 ("blkio: add libblkio block driver")
Reported-by: Qing Wang
Cc: Stefano Garzarella
Signed-off-by: Stefan Hajnoczi
---
block/blkio.c | 110 ++
1 file changed, 57 insertions(+), 53 deletions(-)
diff --git a/block/blkio.c b/blo
-by: Eric Blake
---
include/block/raw-aio.h | 7 ---
block/file-posix.c | 28
block/linux-aio.c | 41 +++--
3 files changed, 11 insertions(+), 65 deletions(-)
LGTM!
Reviewed-by: Stefano Garzarella
-vhost-vdpa driver in libblkio 1.3.0 supports the new
'fd' property. Let's expose this to the user, so the management layer
can pass the file descriptor of an already opened vhost-vdpa character
device. This is useful especially when the device can only be accessed
with certain privileges.
Stefano
we can handle fd passing
from the management layer through the "/dev/fdset/N" special path.
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Stefano Garzarella
---
Notes:
v4:
- modified commit description
v3:
- use qemu_open() on `path` to simplify libvirt code [Jonatho
-by: Stefano Garzarella
---
Notes:
v5:
- moved `features` to the object level to simplify libvirt code [Jonathon]
- wrapped a line too long in the documentation [Markus]
v4:
- added this patch to allow libvirt to discover we support fdset [Markus]
meson.build | 4
qapi
On Wed, May 24, 2023 at 03:36:34PM -0400, Stefan Hajnoczi wrote:
On Wed, May 24, 2023 at 10:52:03AM +0200, Stefano Garzarella wrote:
On Tue, May 23, 2023 at 01:12:59PM -0400, Stefan Hajnoczi wrote:
> Stop using the .bdrv_co_io_plug() API because it is not multi-queue
> block layer friendl
On Sat, May 27, 2023 at 07:56:13AM +0200, Markus Armbruster wrote:
Stefano Garzarella writes:
The virtio-blk-vhost-vdpa driver in libblkio 1.3.0 supports the fd
passing through the new 'fd' property.
Since now we are using qemu_open() on '@path' if the virtio-blk driver
supports the fd
On Fri, May 26, 2023 at 04:20:14PM -0500, Jonathon Jongsma wrote:
On 5/26/23 10:03 AM, Stefano Garzarella wrote:
The virtio-blk-vhost-vdpa driver in libblkio 1.3.0 supports the fd
passing through the new 'fd' property.
Since now we are using qemu_open() on '@path' if the virtio-blk driver
opened vhost-vdpa character device. This is useful especially
when the device can only be accessed with certain privileges.
Add the '@fdset' feature only when the virtio-blk-vhost-vdpa driver
in libblkio supports it.
Suggested-by: Markus Armbruster
Signed-off-by: Stefano Garzarella
---
Notes
the device can only be accessed
with certain privileges.
Stefano Garzarella (2):
block/blkio: use qemu_open() to support fd passing for virtio-blk
qapi: add '@fdset' feature for BlockdevOptionsVirtioBlkVhostVdpa
meson.build | 4
qapi/block-core.json | 8 ++-
block/blkio.c
we can handle fd passing
from the management layer through the "/dev/fdset/N" special path.
Signed-off-by: Stefano Garzarella
---
Notes:
v4:
- modified commit description
v3:
- use qemu_open() on `path` to simplify libvirt code [Jonathon]
block/bl
On Thu, May 25, 2023 at 08:30:03PM +0200, Markus Armbruster wrote:
Stefan Hajnoczi writes:
On Wed, May 17, 2023 at 09:19:26AM +0200, Stefano Garzarella wrote:
CCing Markus for some advice.
On Tue, May 16, 2023 at 11:04:21AM -0500, Jonathon Jongsma wrote:
[...]
> I need some
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Thomas Huth
---
hw/virtio/vhost-vsock-common.c | 1 +
1 file changed, 1 insertion(+)
Reviewed-by: Stefano Garzarella
Reviewed-by: Thomas Huth
---
hw/virtio/Kconfig | 6 ++
hw/virtio/meson.build | 5 +++--
2 files changed, 9 insertions(+), 2 deletions(-)
Reviewed-by: Stefano Garzarella
Gentle ping :-)
On Wed, May 17, 2023 at 4:30 PM Stefan Hajnoczi wrote:
>
> On Wed, May 17, 2023 at 09:19:26AM +0200, Stefano Garzarella wrote:
> > CCing Markus for some advice.
> >
> > On Tue, May 16, 2023 at 11:04:21AM -0500, Jonathon Jongsma wrote:
> > > On 5/
On Tue, May 23, 2023 at 01:12:59PM -0400, Stefan Hajnoczi wrote:
Stop using the .bdrv_co_io_plug() API because it is not multi-queue
block layer friendly. Use the new blk_io_plug_call() API to batch I/O
submission instead.
Signed-off-by: Stefan Hajnoczi
Reviewed-by: Eric Blake
---
--
block/io.c | 37
3 files changed, 51 deletions(-)
Reviewed-by: Stefano Garzarella
- Removed whitespace hunk [Eric]
---
include/block/raw-aio.h | 7 ---
block/file-posix.c | 10 --
block/io_uring.c| 44 -
block/trace-events | 5 ++---
4 files changed, 19 insertions(+), 47 deletions(-)
Reviewed-by: Stefano Garzarella
missing #include and fix blkio_unplug_fn() prototype [Stefano]
---
block/blkio.c | 43 ---
1 file changed, 24 insertions(+), 19 deletions(-)
Reviewed-by: Stefano Garzarella
unused nvme_process_completion_queue_plugged trace event
[Stefano]
---
block/nvme.c | 44
block/trace-events | 1 -
2 files changed, 12 insertions(+), 33 deletions(-)
Reviewed-by: Stefano Garzarella
block/plug.c
Reviewed-by: Stefano Garzarella
On Tue, May 23, 2023 at 11:47:08AM -0400, Stefan Hajnoczi wrote:
On Fri, May 19, 2023 at 10:45:57AM +0200, Stefano Garzarella wrote:
On Wed, May 17, 2023 at 06:10:17PM -0400, Stefan Hajnoczi wrote:
> Introduce a new API for thread-local blk_io_plug() that does not
> traverse the block
On Wed, May 17, 2023 at 06:10:19PM -0400, Stefan Hajnoczi wrote:
Stop using the .bdrv_co_io_plug() API because it is not multi-queue
block layer friendly. Use the new blk_io_plug_call() API to batch I/O
submission instead.
Signed-off-by: Stefan Hajnoczi
---
block/blkio.c | 40
On Wed, May 17, 2023 at 06:10:18PM -0400, Stefan Hajnoczi wrote:
Stop using the .bdrv_co_io_plug() API because it is not multi-queue
block layer friendly. Use the new blk_io_plug_call() API to batch I/O
submission instead.
Signed-off-by: Stefan Hajnoczi
---
block/nvme.c | 44
On Wed, May 17, 2023 at 06:10:17PM -0400, Stefan Hajnoczi wrote:
Introduce a new API for thread-local blk_io_plug() that does not
traverse the block graph. The goal is to make blk_io_plug() multi-queue
friendly.
Instead of having block drivers track whether or not we're in a plugged
section,
CCing Markus for some advice.
On Tue, May 16, 2023 at 11:04:21AM -0500, Jonathon Jongsma wrote:
On 5/15/23 5:10 AM, Stefano Garzarella wrote:
On Thu, May 11, 2023 at 11:03:22AM -0500, Jonathon Jongsma wrote:
On 5/11/23 4:15 AM, Stefano Garzarella wrote:
The virtio-blk-vhost-vdpa driver
On Thu, May 11, 2023 at 11:03:22AM -0500, Jonathon Jongsma wrote:
On 5/11/23 4:15 AM, Stefano Garzarella wrote:
The virtio-blk-vhost-vdpa driver in libblkio 1.3.0 supports the new
'fd' property. Let's expose this to the user, so the management layer
can pass the file descriptor of an already
descriptor of an already opened vhost-vdpa character
device. This is useful especially when the device can only be accessed
with certain privileges.
Stefano Garzarella (1):
block/blkio: use qemu_open() to support fd passing for virtio-blk
block/blkio.c | 53
privileges.
If the libblkio virtio-blk driver supports fd passing, let's always
use qemu_open() to open the `path`, so we can handle fd passing
from the management layer through the "/dev/fdset/N" special path.
Signed-off-by: Stefano Garzarella
---
Notes:
v3:
- use qemu_open(
On Wed, May 10, 2023 at 6:03 PM Jonathon Jongsma wrote:
>
> On 5/4/23 4:28 AM, Stefano Garzarella wrote:
> > v2:
> > - added patch 01 to use monitor_fd_param() in the blkio module
> > - use monitor_fd_param() to parse the fd like vhost devices [Stefan]
> >
> &
privileges.
Signed-off-by: Stefano Garzarella
---
Notes:
v2:
- used monitor_fd_param() to parse the fd like vhost devices [Stefan]
qapi/block-core.json | 6 -
block/blkio.c| 53 +++-
2 files changed, 57 insertions(+), 2 deletions(-)
diff
The blkio block driver will use monitor_fd_param() to support
file descriptor passing. This is possible in builds (e.g. softmmu)
where the monitor API is available.
Add the monitor_fd_param() stub so tools and tests that link the
block layer can build successfully.
Signed-off-by: Stefano
' property. Let's expose this to the user, so the management layer
can pass the file descriptor of an already opened vhost-vdpa character
device. This is useful especially when the device can only be accessed
with certain privileges.
Stefano Garzarella (2):
stubs/monitor: add monitor_fd_param
On Thu, May 4, 2023 at 9:38 AM Stefano Garzarella wrote:
>
> On Wed, May 3, 2023 at 5:57 PM Stefan Hajnoczi wrote:
> >
> > On Wed, May 03, 2023 at 11:15:56AM +0200, Stefano Garzarella wrote:
> > > On Tue, May 02, 2023 at 03:02:32PM -0400, Stefan Hajnoczi wrote:
> &g
On Wed, May 3, 2023 at 5:57 PM Stefan Hajnoczi wrote:
>
> On Wed, May 03, 2023 at 11:15:56AM +0200, Stefano Garzarella wrote:
> > On Tue, May 02, 2023 at 03:02:32PM -0400, Stefan Hajnoczi wrote:
> > > On Tue, May 02, 2023 at 04:50:50PM +0200, Stefano Garzarella wrote:
> &g
On Tue, May 02, 2023 at 03:02:32PM -0400, Stefan Hajnoczi wrote:
On Tue, May 02, 2023 at 04:50:50PM +0200, Stefano Garzarella wrote:
The virtio-blk-vhost-vdpa driver in libblkio 1.3.0 supports the new
'fd' property. Let's expose this to the user, so the management layer
can pass the file
privileges.
Signed-off-by: Stefano Garzarella
---
Notes:
As an alternative we could support passing `/dev/fdset/N` via 'path',
always opening the path with qemu_open() and passing the fd to the
libblkio driver.
I preferred to add a new parameter though, because the code is
simpler
On Thu, Mar 23, 2023 at 08:54:03PM +0100, Eugenio Pérez wrote:
Evaluating it at start time instead of initialization time may make the
guest capable of dynamically adding or removing migration blockers.
Also, moving to initialization reduces the number of ioctls in the
migration, reducing
insertions(+)
Reviewed-by: Stefano Garzarella
diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c
index 99904a0da7..4397c0d4b3 100644
--- a/net/vhost-vdpa.c
+++ b/net/vhost-vdpa.c
@@ -361,6 +361,14 @@ static NetClientInfo net_vhost_vdpa_info = {
.check_peer_type = vhost_vdpa_check_peer_type
ASID isolation.
Signed-off-by: Eugenio Pérez
---
include/hw/virtio/vhost-vdpa.h | 1 +
hw/virtio/vhost-vdpa.c | 58 +++---
2 files changed, 41 insertions(+), 18 deletions(-)
Reviewed-by: Stefano Garzarella
diff --git a/include/hw/virtio/vhost-vdpa.h b/include
-by: Stefano Garzarella
diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c
index bc6bad23d5..bbabea18f3 100644
--- a/hw/virtio/vhost-vdpa.c
+++ b/hw/virtio/vhost-vdpa.c
@@ -716,7 +716,7 @@ static int vhost_vdpa_reset_device(struct vhost_dev *dev)
uint8_t status = 0;
ret
On Wed, Mar 22, 2023 at 07:04:03PM +0100, Eugenio Perez Martin wrote:
On Wed, Mar 22, 2023 at 3:27 PM Stefano Garzarella wrote:
On Fri, Mar 17, 2023 at 03:55:41PM +0100, Eugenio Pérez wrote:
>Evaluating it at start time instead of initialization time may make the
>guest capable of dynam
On Wed, Mar 22, 2023 at 06:38:21PM +0100, Eugenio Perez Martin wrote:
On Wed, Mar 22, 2023 at 3:26 PM Stefano Garzarella wrote:
On Fri, Mar 17, 2023 at 03:55:40PM +0100, Eugenio Pérez wrote:
>We need to tell in the caller, as some errors are expected in a normal
>workflow. In part
On Wed, Mar 22, 2023 at 06:36:39PM +0100, Eugenio Perez Martin wrote:
On Wed, Mar 22, 2023 at 3:24 PM Stefano Garzarella wrote:
On Fri, Mar 17, 2023 at 03:55:38PM +0100, Eugenio Pérez wrote:
>This allows to reset a vhost-vdpa device from external subsystems like
>vhost-net. It i
On Fri, Mar 17, 2023 at 03:55:41PM +0100, Eugenio Pérez wrote:
Evaluating it at start time instead of initialization time may make the
guest capable of dynamically adding or removing migration blockers.
Also, moving to initialization reduces the number of ioctls in the
migration, reducing
On Fri, Mar 17, 2023 at 03:55:40PM +0100, Eugenio Pérez wrote:
We need to tell in the caller, as some errors are expected in a normal
workflow. In particular, parent drivers in recent kernels with
VHOST_BACKEND_F_IOTLB_ASID may not support vring groups. In that case,
-ENOTSUP is returned.
/virtio/vhost-vdpa.h | 1 +
hw/virtio/vhost-vdpa.c | 20 +---
2 files changed, 14 insertions(+), 7 deletions(-)
Reviewed-by: Stefano Garzarella
On Fri, Mar 17, 2023 at 03:55:38PM +0100, Eugenio Pérez wrote:
This allows to reset a vhost-vdpa device from external subsystems like
vhost-net. It is used in subsequent patches to negotiate features and
probe for CVQ ASID isolation.
Signed-off-by: Eugenio Pérez
---
On Fri, Mar 17, 2023 at 03:55:37PM +0100, Eugenio Pérez wrote:
It is always 0 and it is not useful to route call through file
descriptor.
I didn't get the second part of the sentence (after "and"), anyway the
patch LGTM:
Reviewed-by: Stefano Garzarella
Signed-off-by: Eugenio Pér
Hi Shreyansh,
On Fri, Feb 11, 2022 at 11:18 PM Shreyansh Chouhan
wrote:
>
> The second RFC for implementing the VirtIO Sound card as described in
> the virtio specs. Sorry for the absence of activity on this.
Thanks for starting working on virtio-sound device for QEMU!
I'm interested in
On Fri, Feb 17, 2023 at 11:53:03AM -0500, Stefan Hajnoczi wrote:
On Fri, 17 Feb 2023 at 11:23, Stefano Garzarella wrote:
Hi Stefan,
On Fri, Jan 27, 2023 at 10:17:40AM -0500, Stefan Hajnoczi wrote:
>Dear QEMU, KVM, and rust-vmm communities,
>QEMU will apply for Google Summer of Cod
101 - 200 of 1172 matches
Mail list logo
