On Mon, Jan 17, 2022 at 08:43:26PM +0800, Longpeng(Mike) via wrote:
From: Longpeng
Implements the .realize interface.
Signed-off-by: Longpeng
---
hw/virtio/vdpa-dev.c | 101 +++
include/hw/virtio/vdpa-dev.h | 8 +++
2 files changed, 109 insertions(+)
On Mon, Jan 17, 2022 at 08:43:27PM +0800, Longpeng(Mike) via wrote:
From: Longpeng
Implements the .unrealize interface.
Signed-off-by: Longpeng
---
hw/virtio/vdpa-dev.c | 24 +++-
1 file changed, 23 insertions(+), 1 deletion(-)
diff --git a/hw/virtio/vdpa-dev.c
On Mon, Jan 17, 2022 at 08:43:25PM +0800, Longpeng(Mike) via wrote:
From: Longpeng
Implements the .instance_init and the .class_init interface.
Signed-off-by: Longpeng
---
hw/virtio/vdpa-dev-pci.c | 52 ++-
hw/virtio/vdpa-dev.c | 81
---
block/rbd.c | 42 --
1 file changed, 40 insertions(+), 2 deletions(-)
Tested-by: Stefano Garzarella
diff --git a/block/rbd.c b/block/rbd.c
index 20bb896c4a..d174d51659 100644
--- a/block/rbd.c
+++ b/block/rbd.c
@@ -1320,6 +1320,7 @@ static int
Hi Peter,
On Tue, Jan 11, 2022 at 10:10:16AM +0100, Peter Lieven wrote:
Hi Stefano,
thanks for the feedback. Please note that you also need the other patch
or you will sooner or later run into another assertion as soon as rbd
snapshots are involved.
Yep, I tested with the entire series
mplementation of
tap_probe_vnet_hdr(), in case of error it returns just -1, so it's ok
too:
Reviewed-by: Stefano Garzarella
BZ [1] and the
test now works correctly!
Tested-by: Stefano Garzarella
[1] https://bugzilla.redhat.com/show_bug.cgi?id=2034791
On Thu, Jan 06, 2022 at 03:23:07AM +, Longpeng (Mike, Cloud Infrastructure
Service Product Dept.) wrote:
-Original Message-
From: Stefano Garzarella [mailto:sgarz...@redhat.com]
Sent: Wednesday, January 5, 2022 7:16 PM
To: Longpeng (Mike, Cloud Infrastructure Service Product Dept
+= $(CFLAGS_NOPIE) -ffreestanding -I$(TOPSRC_DIR)/include
override CFLAGS += $(call cc-option, -fno-stack-protector)
override CFLAGS += $(call cc-option, -m16)
+override CFLAGS += $(call cc-option, -fcf-protection=none)
LGTM!
Reviewed-by: Stefano Garzarella
On Wed, Jan 05, 2022 at 08:58:54AM +0800, Longpeng(Mike) wrote:
From: Longpeng
Implements the .instance_init and the .class_init interface.
Signed-off-by: Longpeng
---
hw/virtio/vdpa-dev-pci.c | 80 +++-
hw/virtio/vdpa-dev.c | 68
On Wed, Jan 05, 2022 at 08:58:56AM +0800, Longpeng(Mike) wrote:
From: Longpeng
Implements the .unrealize interface.
Signed-off-by: Longpeng
---
hw/virtio/vdpa-dev.c | 22 +-
1 file changed, 21 insertions(+), 1 deletion(-)
diff --git a/hw/virtio/vdpa-dev.c
'>=0.3',
+ required: get_option('linux_io_uring'),
method: 'pkg-config', kwargs: static_kwargs)
endif
libxml2 = not_found
LGTM!
Reviewed-by: Stefano Garzarella
On Sat, Dec 11, 2021 at 04:11:04AM +, Longpeng (Mike, Cloud Infrastructure
Service Product Dept.) wrote:
-Original Message-
From: Stefano Garzarella [mailto:sgarz...@redhat.com]
Sent: Thursday, December 9, 2021 11:55 PM
To: Longpeng (Mike, Cloud Infrastructure Service Product
; > >
> > > * Heavy but more powerful
> > > Net: netdev + virtio-net + vhost-vdpa
> > > Storage: bdrv + virtio-blk + vhost-vdpa
> > >
> > > [1] https://www.mail-archive.com/qemu-devel@nongnu.org/msg797569.html
> >
> > Stefano prese
] https://www.mail-archive.com/qemu-devel@nongnu.org/msg797569.html
Stefano presented a plan for vdpa-blk at KVM Forum 2021:
https://kvmforum2021.sched.com/event/ke3a/vdpa-blk-unified-hardware-and-software-offload-for-virtio-blk-stefano-garzarella-red-hat
It's closer to today's virtio-net + vhost-net
function. Stefano Garzarella prompted me to make this refactoring.
Great clean up! Thanks for doing this, everything LGTM:
Reviewed-by: Stefano Garzarella
On Thu, Dec 02, 2021 at 01:09:23PM +, Stefan Hajnoczi wrote:
On Wed, Dec 01, 2021 at 12:55:08PM +0100, Stefano Garzarella wrote:
On Tue, Nov 30, 2021 at 11:20:57AM +, Stefan Hajnoczi wrote:
> @@ -657,10 +704,7 @@ bool aio_poll(AioContext *ctx, bool blocking)
> }
>
>
On Tue, Nov 30, 2021 at 11:20:57AM +, Stefan Hajnoczi wrote:
Adaptive polling measures the execution time of the polling check plus
handlers called when a polled event becomes ready. Handlers can take a
significant amount of time, making it look like polling was running for
a long time when
LGTM:
Reviewed-by: Stefano Garzarella
On Mon, Nov 15, 2021 at 12:52:00PM +0800, yadong...@intel.com wrote:
From: Yadong Qi
Add new virtio feature: VIRTIO_BLK_F_SECDISCARD.
Add new virtio command: VIRTIO_BLK_T_SECDISCARD.
Has a proposal been sent out yet to virtio-comment mailing list for
discussing these specification changes?
n both cases:
Reviewed-by: Stefano Garzarella
Stefano
On Tue, Nov 02, 2021 at 05:05:21PM +0100, Philippe Mathieu-Daudé wrote:
On 11/2/21 16:51, Stefano Garzarella wrote:
Use g_autofree to ensure that `config` is freed when
vhost_vdpa_get_max_queue_pairs() returns.
Reported-by: Coverity (CID 1465228: RESOURCE_LEAK)
Fixes: 402378407d ("vhost
Use g_autofree to ensure that `config` is freed when
vhost_vdpa_get_max_queue_pairs() returns.
Reported-by: Coverity (CID 1465228: RESOURCE_LEAK)
Fixes: 402378407d ("vhost-vdpa: multiqueue support")
Signed-off-by: Stefano Garzarella
---
net/vhost-vdpa.c | 2 +-
1 file changed, 1 inser
On Wed, Oct 27, 2021 at 03:06:37PM +0200, Kevin Wolf wrote:
Am 27.10.2021 um 11:23 hat Stefano Garzarella geschrieben:
On Wed, Oct 27, 2021 at 06:28:51AM +0200, Markus Armbruster wrote:
> Stefano Garzarella writes:
>
> > Commit d7ddd0a161 ("linux-aio: limit the batch size u
v2:
- Add ack from Jason
- Extend patch description now that RamDiscardManager is upstream.
---
hw/virtio/vhost-vdpa.c | 13 +
1 file changed, 13 insertions(+)
Reviewed-by: Stefano Garzarella
On Wed, Oct 27, 2021 at 03:06:37PM +0200, Kevin Wolf wrote:
Am 27.10.2021 um 11:23 hat Stefano Garzarella geschrieben:
On Wed, Oct 27, 2021 at 06:28:51AM +0200, Markus Armbruster wrote:
> Stefano Garzarella writes:
>
> > Commit d7ddd0a161 ("linux-aio: limit the batch size u
On Wed, Oct 27, 2021 at 06:28:51AM +0200, Markus Armbruster wrote:
Stefano Garzarella writes:
Commit d7ddd0a161 ("linux-aio: limit the batch size using
`aio-max-batch` parameter") added a way to limit the batch size
of Linux AIO backend for the entire AIO context.
The same AIO c
d,
and use it in laio_co_submit() and laio_io_unplug() to limit the
Linux AIO batch size more than the limit set by the AIO context.
Stefano Garzarella (3):
file-posix: add `aio-max-batch` option
linux-aio: add `dev_max_batch` parameter to laio_co_submit()
linux-aio: add `dev_max_batch` parameter to laio
Hajnoczi
Reviewed-by: Kevin Wolf
Signed-off-by: Stefano Garzarella
---
include/block/raw-aio.h | 3 ++-
block/file-posix.c | 3 ++-
block/linux-aio.c | 30 ++
3 files changed, 26 insertions(+), 10 deletions(-)
diff --git a/include/block/raw-aio.h b/include
size even
more to avoid increasing latency.
For this reason we add the `aio-max-batch` option to the file
backend, which will be used by the next commits to limit the size of
batches including requests generated by this device.
Suggested-by: Kevin Wolf
Reviewed-by: Kevin Wolf
Signed-off-b
-by: Stefan Hajnoczi
Reviewed-by: Kevin Wolf
Signed-off-by: Stefano Garzarella
---
include/block/raw-aio.h | 3 ++-
block/file-posix.c | 2 +-
block/linux-aio.c | 8 +---
3 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/include/block/raw-aio.h b/include/block/raw-aio.h
On Mon, Oct 25, 2021 at 04:04:21PM +0200, Kevin Wolf wrote:
Am 25.10.2021 um 12:20 hat Stefano Garzarella geschrieben:
On Thu, Oct 21, 2021 at 04:18:41PM +0100, Stefan Hajnoczi wrote:
> On Thu, Sep 23, 2021 at 04:30:58PM +0200, Stefano Garzarella wrote:
> > Commit d7ddd0a161 ("li
On Mon, Oct 25, 2021 at 04:16:54PM +0200, Kevin Wolf wrote:
Am 23.09.2021 um 16:30 hat Stefano Garzarella geschrieben:
Commit d7ddd0a161 ("linux-aio: limit the batch size using
`aio-max-batch` parameter") added a way to limit the batch size
of Linux AIO backend for the entire A
On Thu, Oct 21, 2021 at 04:18:41PM +0100, Stefan Hajnoczi wrote:
On Thu, Sep 23, 2021 at 04:30:58PM +0200, Stefano Garzarella wrote:
Commit d7ddd0a161 ("linux-aio: limit the batch size using
`aio-max-batch` parameter") added a way to limit the batch size
of Linux AIO backend for the
66 ++
15 files changed, 102 insertions(+), 23 deletions(-)
create mode 100644 pc-bios/multiboot_dma.bin
create mode 100644 pc-bios/optionrom/multiboot_dma.S
--
2.31.1
Reviewed-by: Stefano Garzarella
ver, this patch LGTM:
Tested-by: Stefano Garzarella
Reviewed-by: Stefano Garzarella
On Mon, Oct 11, 2021 at 12:28:22PM +0800, Jason Wang wrote:
Unlike vhost-kernel, vhost-vdpa adapts a single device multiqueue
model. So we need to simply use virtqueue index as the vhost virtqueue
index. This is a must for multiqueue to work for vhost-vdpa.
Signed-off-by: Jason Wang
| 62 +-
hw/virtio/trace-events | 1 +
3 files changed, 49 insertions(+), 16 deletions(-)
Reviewed-by: Stefano Garzarella
-by: Jason Wang
---
hw/virtio/vhost-vdpa.c | 1 +
1 file changed, 1 insertion(+)
Reviewed-by: Stefano Garzarella
file changed, 15 insertions(+), 7 deletions(-)
Reviewed-by: Stefano Garzarella
er.h | 60 ++--
hw/core/loader.c | 60 +++-
3 files changed, 75 insertions(+), 72 deletions(-)
Reviewed-by: Stefano Garzarella
Please CC maintainers (MST in this case)
On Fri, 2021-10-01 at 18:42 +, Jiang Wang wrote:
> Added a check in vhost_vsock_common_send_transport_reset,
> and only send messages on event queue when the vsock host
> device is started.
>
> Suggested-by: Stefano Garzarella
> Si
Kind ping :-)
Thanks,
Stefano
On Thu, Sep 23, 2021 at 4:31 PM Stefano Garzarella wrote:
>
> Commit d7ddd0a161 ("linux-aio: limit the batch size using
> `aio-max-batch` parameter") added a way to limit the batch size
> of Linux AIO backend for the entire AIO context.
>
&
On Wed, Oct 06, 2021 at 09:28:39PM +0200, Luc Michel wrote:
Until now, int was used as the return type for all the ELF
loader related functions. The returned value is the sum of all loaded
program headers "MemSize" fields.
Because of the overflow check in elf_ops.h, trying to load an ELF bigger
Signed-off-by: Stefano Garzarella
---
block/backup.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/backup.c b/block/backup.c
index 687d2882bc..8b072db5d9 100644
--- a/block/backup.c
+++ b/block/backup.c
@@ -407,8 +407,8 @@ BlockJob *backup_job_create(const char *
This series contains a patch that avoids an integer overflow of
`max-workers` (struct BackupPerf) by adding a check and a patch
that asserts this condition where the problem occurs.
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=2009310
Signed-off-by: Stefano Garzarella
Stefano Garzarella
All code in block/aio_task.c expects `max_busy_tasks` to always
be greater than 0.
Assert this condition during the AioTaskPool creation where
`max_busy_tasks` is set.
Signed-off-by: Stefano Garzarella
---
block/aio_task.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/block/aio_task.c
On Mon, Oct 04, 2021 at 11:27:12AM +0200, Philippe Mathieu-Daudé wrote:
On 10/4/21 11:23, Stefan Hajnoczi wrote:
On Mon, Sep 06, 2021 at 12:43:17PM +0200, Philippe Mathieu-Daudé wrote:
vring_get_region_caches() must be called with the RCU read lock
acquired. virtqueue_packed_drop_all() does
On Fri, Sep 24, 2021 at 03:27:30PM -0700, Jiang Wang . wrote:
On Thu, Sep 23, 2021 at 2:18 AM Stefano Garzarella wrote:
[...]
>
>To explain it, I think the event queue number does not matter for the
>vhost and qemu. The vhost-vsock kernel module does not allocate any
>da
-by: Stefano Garzarella
---
include/block/raw-aio.h | 3 ++-
block/file-posix.c | 2 +-
block/linux-aio.c | 8 +---
3 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/include/block/raw-aio.h b/include/block/raw-aio.h
index ebd042fa27..21fc10c4c9 100644
--- a/include/block/raw
size even
more to avoid increasing latency.
For this reason we add the `aio-max-batch` option to the file
backend, which will be used by the next commits to limit the size of
batches including requests generated by this device.
Suggested-by: Kevin Wolf
Signed-off-by: Stefano Garzarella
---
This new parameter can be used by block devices to limit the
Linux AIO batch size more than the limit set by the AIO context.
file-posix backend supports this, passing its `aio-max-batch` option
previously added.
Add an helper function to calculate the maximum batch size.
Signed-off-by: Stefano
size even
more to avoid increasing latency.
This series add the `aio-max-batch` option to the file backend,
and use it in laio_co_submit() and laio_io_unplug() to limit the
Linux AIO batch size more than the limit set by the AIO context.
Stefano Garzarella (3):
file-posix: add `aio-max-batch` opti
On Wed, Sep 22, 2021 at 10:36:24AM -0700, Jiang Wang . wrote:
On Wed, Sep 22, 2021 at 2:23 AM Stefano Garzarella wrote:
On Wed, Sep 22, 2021 at 12:00:24AM +, Jiang Wang wrote:
>Datagram sockets are connectionless and unreliable.
>The sender does not know the capacity of the re
On Wed, Sep 22, 2021 at 12:00:24AM +, Jiang Wang wrote:
Datagram sockets are connectionless and unreliable.
The sender does not know the capacity of the receiver
and may send more packets than the receiver can handle.
Add two more dedicate virtqueues for datagram sockets,
so that it will
_SEQPACKET feature bit support")
Cc: qemu-sta...@nongnu.org
Reported-by: Jiang Wang
Signed-off-by: Stefano Garzarella
---
v2:
- used OnOffAuto `seqpacket` property instead of boolean `features` [stefanha]
---
include/hw/virtio/vhost-vsock.h | 3 +++
hw/core/machine.c | 1 +
vhost_vsock_common_get_features() used by children, and disable
`seqpacket` for vhost-user-vsock device for machine types < 6.2.
The behavior of vhost-vsock device doesn't change; vhost-user-vsock
device now supports `seqpacket` property.
Signed-off-by: Stefano Garzarella
---
include/hw/virtio/vhost-vsock-commo
, but to simplify the
backport I left them separate.
v1:
https://lore.kernel.org/qemu-devel/20210907124935.147164-1-sgarz...@redhat.com/
v2:
- used OnOffAuto `seqpacket` property instead of boolean `features` [stefanha]
- moved `seqpacket` property to vhost-vsock-common class
Stefano Garzarella (2
On Thu, Sep 16, 2021 at 08:26:15AM +0200, Stefano Garzarella wrote:
On Wed, Sep 15, 2021 at 08:59:17PM -0700, Jiang Wang . wrote:
On Tue, Sep 14, 2021 at 5:46 AM Stefan Hajnoczi wrote:
On Mon, Sep 13, 2021 at 10:18:43PM +, Jiang Wang wrote:
Datagram sockets are connectionless
On Wed, Sep 15, 2021 at 08:59:17PM -0700, Jiang Wang . wrote:
On Tue, Sep 14, 2021 at 5:46 AM Stefan Hajnoczi wrote:
On Mon, Sep 13, 2021 at 10:18:43PM +, Jiang Wang wrote:
> Datagram sockets are connectionless and unreliable.
> The sender does not know the capacity of the receiver
> and
On Mon, Sep 13, 2021 at 09:46:48AM -0400, Michael S. Tsirkin wrote:
On Mon, Sep 13, 2021 at 02:51:42PM +0200, Stefano Garzarella wrote:
On Fri, Sep 10, 2021 at 02:35:53AM -0400, Michael S. Tsirkin wrote:
> On Thu, Sep 09, 2021 at 10:02:12AM +0100, Daniel P. Berrangé wrote:
> > On Th
On Sun, Sep 12, 2021 at 06:46:03PM +, Jiang Wang wrote:
Datagram sockets are connectionless and unreliable.
The sender does not know the capacity of the receiver
and may send more packets than the receiver can handle.
Add two more dedicate virtqueues for datagram sockets,
so that it will
e, Sep 07, 2021 at 02:49:35PM +0200, Stefano Garzarella wrote:
> > > Commit 1e08fd0a46 ("vhost-vsock: SOCK_SEQPACKET feature bit support")
> > > enabled the SEQPACKET feature bit.
> > > This commit is released with QEMU 6.1, so if we try to migrate a VM where
> &
#4 0x7f0909975820 in ?? () at
../sysdeps/unix/sysv/linux/x86_64/__start_context.S:91
from /usr/lib64/libc.so.6
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=2001404
Fixes: d44dae1a7c ("block/mirror: fix active mirror dead-lock in
mirror_wait_on_conflicts")
Signed-off-by: Stefa
On Fri, Sep 10, 2021 at 01:37:40PM +0300, Vladimir Sementsov-Ogievskiy wrote:
10.09.2021 11:56, Stefano Garzarella wrote:
In mirror_iteration() we call mirror_wait_on_conflicts() with
`self` parameter set to NULL.
Starting from commit d44dae1a7c we dereference `self` pointer
#4 0x7f0909975820 in ?? () at
../sysdeps/unix/sysv/linux/x86_64/__start_context.S:91
from /usr/lib64/libc.so.6
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=2001404
Fixes: d44dae1a7c ("block/mirror: fix active mirror dead-lock in
mirror_wait_on_conflicts")
Signed-off-by: Stefa
On Wed, Sep 08, 2021 at 06:20:49PM +0300, Denis Plotnikov wrote:
On 08.09.2021 16:22, Stefano Garzarella wrote:
Message bounced, I use new Denis's email address.
On Wed, Sep 08, 2021 at 03:17:16PM +0200, Stefano Garzarella wrote:
Hi Denis,
I just found this discussion since we still have
On Tue, Sep 07, 2021 at 03:47:56PM +0200, Stefano Garzarella wrote:
On Tue, Sep 07, 2021 at 02:22:24PM +0100, Daniel P. Berrangé wrote:
On Tue, Sep 07, 2021 at 02:49:35PM +0200, Stefano Garzarella wrote:
Commit 1e08fd0a46 ("vhost-vsock: SOCK_SEQPACKET feature bit support"
Message bounced, I use new Denis's email address.
On Wed, Sep 08, 2021 at 03:17:16PM +0200, Stefano Garzarella wrote:
Hi Denis,
I just found this discussion since we still have the following line in
hw/core/machine.c:
{ "vhost-blk-device", "seg_max_adjust", "
Hi Denis,
I just found this discussion since we still have the following line in
hw/core/machine.c:
{ "vhost-blk-device", "seg_max_adjust", "off"}
IIUC it was a typo, and I think we should fix it since in the future we
can have `vhost-blk-device`.
So, I think we have 2 options:
1.
rtio: Have virtqueue_get_avail_bytes() pass caches arg to callees
include/hw/virtio/virtio.h | 7 +++
hw/virtio/virtio.c | 32 +++-
2 files changed, 22 insertions(+), 17 deletions(-)
--
2.31.1
Reviewed-by: Stefano Garzarella
On Tue, Sep 07, 2021 at 02:22:24PM +0100, Daniel P. Berrangé wrote:
On Tue, Sep 07, 2021 at 02:49:35PM +0200, Stefano Garzarella wrote:
Commit 1e08fd0a46 ("vhost-vsock: SOCK_SEQPACKET feature bit support")
enabled the SEQPACKET feature bit.
This commit is released with QEMU 6.1, so
hine types < 6.1, adding a
`features` field to VHostVSock to simplify the handling of upcoming
features we will support.
Fixes: 1e08fd0a46 ("vhost-vsock: SOCK_SEQPACKET feature bit support")
Cc: qemu-sta...@nongnu.org
Reported-by: Jiang Wang
Signed-off-by: Stefano Garzarella
---
On Tue, Sep 07, 2021 at 12:15:30PM +0200, Stefano Garzarella wrote:
On Sun, Sep 05, 2021 at 11:08:34AM -0700, Jiang Wang . wrote:
On Mon, Aug 9, 2021 at 3:58 AM Stefano Garzarella wrote:
On Thu, Aug 05, 2021 at 12:07:02PM -0700, Jiang Wang . wrote:
On Wed, Aug 4, 2021 at 1:13 AM Stefano
On Sun, Sep 05, 2021 at 11:08:34AM -0700, Jiang Wang . wrote:
On Mon, Aug 9, 2021 at 3:58 AM Stefano Garzarella wrote:
On Thu, Aug 05, 2021 at 12:07:02PM -0700, Jiang Wang . wrote:
>On Wed, Aug 4, 2021 at 1:13 AM Stefano Garzarella wrote:
>> On Tue, Aug 03, 2021 at 11:41:32PM +00
Ping :-)
Looks like it went into the crack during feature freeze,
should I resend it?
On Tue, Jul 27, 2021 at 04:59:34PM +0200, Stefano Garzarella wrote:
We recently added a new parameter (aio-max-batch) to IOThread.
This series cleans up the code a bit, no functional changes.
Stefano
On Thu, Sep 02, 2021 at 01:12:33PM +0100, Stefan Hajnoczi wrote:
On Wed, Sep 01, 2021 at 05:55:38PM +0200, Stefano Garzarella wrote:
On Thu, Aug 26, 2021 at 07:26:58PM +0200, Philippe Mathieu-Daudé wrote:
> Both virtqueue_packed_get_avail_bytes() and
> virtqueue_split_get_avail_bytes()
On Thu, Aug 26, 2021 at 07:26:58PM +0200, Philippe Mathieu-Daudé wrote:
Both virtqueue_packed_get_avail_bytes() and
virtqueue_split_get_avail_bytes() access the region cache, but
their caller also does. Simplify by having virtqueue_get_avail_bytes
calling both with RCU lock held, and passing the
;avail);
address_space_cache_destroy(>used);
--
2.31.1
Reviewed-by: Stefano Garzarella
int virtio_queue_split_empty(VirtQueue *vq)
return empty;
}
+/* Called within rcu_read_lock(). */
static int virtio_queue_packed_empty_rcu(VirtQueue *vq)
{
struct VRingPackedDesc desc;
--
2.31.1
Reviewed-by: Stefano Garzarella
CCing Paolo and Thomas
On Wed, Aug 25, 2021 at 06:43:56PM +0200, Helge Konetzka wrote:
The appended patch fixes the link to Wiki Windows page on Website
Download Sources page.
Furthermore I would like to propose to change the instructions for
Native builds with MSYS2 on Wiki Windows page.
g_free(name);
if (virtio_queue_set_host_notifier_mr(vdev, queue_idx, >mr, true)) {
+object_unparent(OBJECT(>mr));
munmap(addr, page_size);
return -1;
}
--
1.8.3.1
Reviewed-by: Stefano Garzarella
On Mon, Aug 09, 2021 at 03:41:36PM +0200, Peter Lieven wrote:
Please, can you add a description?
For example also describing what happens if RBD image does not support
RBD_FEATURE_FAST_DIFF.
Signed-off-by: Peter Lieven
---
block/rbd.c | 119
On Thu, Aug 05, 2021 at 12:07:02PM -0700, Jiang Wang . wrote:
On Wed, Aug 4, 2021 at 1:13 AM Stefano Garzarella wrote:
On Tue, Aug 03, 2021 at 11:41:32PM +, Jiang Wang wrote:
>Datagram sockets are connectionless and unreliable.
>The sender does not know the capacity of the re
On Thu, Aug 05, 2021 at 12:00:05PM -0700, Jiang Wang . wrote:
On Tue, Aug 3, 2021 at 11:49 PM Stefano Garzarella wrote:
On Wed, Aug 4, 2021 at 8:41 AM Stefano Garzarella
wrote:
>
> On Tue, Aug 03, 2021 at 11:58:27AM -0700, Jiang Wang . wrote:
> >On Wed, Jul 7, 2021 at 10:2
On Wed, Aug 04, 2021 at 06:52:15PM +0200, Kevin Wolf wrote:
Am 04.08.2021 um 16:50 hat Stefano Garzarella geschrieben:
On Mon, Aug 02, 2021 at 02:40:36PM +0200, Kevin Wolf wrote:
> Am 29.07.2021 um 11:10 hat Fabian Ebner geschrieben:
> > Linux SCSI can throw spurious -EAGAIN in so
should allow block jobs to complete, even
if such spurious errors are encountered.
Co-authored-by: Stefan Hajnoczi
Reviewed-by: Stefano Garzarella
Signed-off-by: Fabian Ebner
---
Changes from v1:
* Focus on what's relevant for the patch itself in the commit
message.
* Add Stefan's
On Tue, Aug 03, 2021 at 11:41:32PM +, Jiang Wang wrote:
Datagram sockets are connectionless and unreliable.
The sender does not know the capacity of the receiver
and may send more packets than the receiver can handle.
Add two more dedicate virtqueues for datagram sockets,
so that it will
On Wed, Aug 4, 2021 at 8:41 AM Stefano Garzarella
wrote:
>
> On Tue, Aug 03, 2021 at 11:58:27AM -0700, Jiang Wang . wrote:
> >On Wed, Jul 7, 2021 at 10:27 AM Stefano Garzarella
> >wrote:
> >> On Wed, Jul 07, 2021 at 09:52:46AM -0700, Jiang Wang . wrote:
> >
On Tue, Aug 03, 2021 at 11:58:27AM -0700, Jiang Wang . wrote:
On Wed, Jul 7, 2021 at 10:27 AM Stefano Garzarella wrote:
On Wed, Jul 07, 2021 at 09:52:46AM -0700, Jiang Wang . wrote:
>On Wed, Jul 7, 2021 at 1:33 AM Stefano Garzarella wrote:
>> On Tue, Jul 06, 2021 at 10:26:07PM +00
if such spurious errors are encountered.
Co-authored-by: Stefan Hajnoczi
Reviewed-by: Stefano Garzarella
Signed-off-by: Fabian Ebner
---
Changes from v1:
* Focus on what's relevant for the patch itself in the commit
message.
* Add Stefan's comment.
* Add Stefano's R-b tag (I hope that's fine
I've been working with io_uring for a while so I'd like to help
with reviews.
Signed-off-by: Stefano Garzarella
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 42ac45c3e5..1776d0950b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3257,6
plications are, but retrying upon EAGAIN does not sound like
a bad thing to my inexperienced ears.
Yeah, that doesn't sound bad.
For kernels that don't have the patch applied, I don't think there's
much we can do about it, so this change seems okay to me:
Reviewed-by: Stefano Garzarella
We recently added a new parameter (aio-max-batch) to IOThread.
This series cleans up the code a bit, no functional changes.
Stefano Garzarella (2):
iothread: rename PollParamInfo to IOThreadParamInfo
iothread: use IOThreadParamInfo in iothread_[set|get]_param()
iothread.c | 28
parameter with
`IOThreadParamInfo *info`.
Suggested-by: Kevin Wolf
Signed-off-by: Stefano Garzarella
---
iothread.c | 18 ++
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/iothread.c b/iothread.c
index a73e560ba0..0f98af0f2a 100644
--- a/iothread.c
+++ b/iothread.c
@@ -231,
Kevin Wolf
Signed-off-by: Stefano Garzarella
---
iothread.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/iothread.c b/iothread.c
index ddbbde61f7..a73e560ba0 100644
--- a/iothread.c
+++ b/iothread.c
@@ -215,18 +215,18 @@ static void iothread_complete(UserCrea
allows us to control the maximum batch size to reduce
the latency that requests might accumulate while queued in the AIO
engine queue.
If `aio-max-batch` is equal to 0 (default value), the AIO engine will
use its default maximum batch size value.
Signed-off-by: Stefano Garzarella
---
Notes:
v2
Changes in preparation for next patches where we add a new
parameter not related to the poll mechanism.
Let's add two new generic functions (iothread_set_param and
iothread_get_param) that we use to set and get IOThread
parameters.
Signed-off-by: Stefano Garzarella
---
iothread.c | 27
represents a good tradeoff between the latency
increase while a request is queued and the cost of the io_submit(2)
system call.
Signed-off-by: Stefano Garzarella
---
Notes:
v2:
- limit the batch with the number of available events [stefanha]
block/linux-aio.c | 9 -
1 file
e=/dev/vdb \
--rw=${TEST} --bs=${BS} --iodepth=${IODEPTH} --numjobs=16
Next steps:
- benchmark io_uring and use `aio-max-batch` also there
- make MAX_EVENTS parametric adding a new `aio-max-events` parameter
Thanks,
Stefano
Stefano Garzarella (3):
iothread: generalize iothread
301 - 400 of 1173 matches
Mail list logo
