On Wed, 21 Jan 2015 12:23:18 +0100
Cornelia Huck wrote:
> On Tue, 20 Jan 2015 11:08:24 +
> Stefan Hajnoczi wrote:
>
> > On Thu, Dec 11, 2014 at 02:25:12PM +0100, Cornelia Huck wrote:
> > > @@ -608,6 +631,25 @@ static int virtio_ccw_cb(SubchDev *sch, CCW1 ccw)
> > > }
> > >
On Fri, 12 Dec 2014 10:01:46 +0100
Cornelia Huck wrote:
> Several places check against the feature bit number instead of against
> the feature bit. Fix them.
>
> Reported-by: Thomas Huth
> Signed-off-by: Cornelia Huck
> ---
> hw/scsi/virtio-scsi.c | 2 +-
> hw/
On Wed, 22 Oct 2014 15:16:29 -0400
Don Slutz wrote:
> On 10/22/14 08:28, Thomas Huth wrote:
> > Linus likely does not want to get e-mails about QEMU, so let's
> > just remove this option.
> >
> > Suggested-by: Michael S. Tsirkin
> > Signed-off-
On Fri, 31 Oct 2014 04:28:16 +
"Guo, Lei" wrote:
> This patch aims to add new instructions (ABCD) for M68K family.
> The original TCG for M68k doesn’t include all instructions,so I intend to add
> the unrealized instruction or fix wrong instructions step by step.
> This instruction is realiz
ipa1);
> +r = handle_eb(cpu, run, run->s390_sieic.ipb & 0xff);
> break;
> case IPA0_DIAG:
> r = handle_diag(cpu, run, run->s390_sieic.ipb);
Looks right!
Reviewed-by: Thomas Huth
1),
> +GEN_VXFORM_NOA(vrfiz, 5, 9),
>
> #undef GEN_VXFORM_UIMM
> #define GEN_VXFORM_UIMM(name, opc2, opc3) \
Looks right to me.
Reviewed-by: Thomas Huth
config.status and tests/qemu-iotests/common.env are generated files
that should be deleted during 'make distclean'.
Signed-off-by: Thomas Huth
---
Makefile |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index f505202..6817c6f 10
On Mon, 3 Nov 2014 13:50:24 +0100
Thomas Huth wrote:
> On Wed, 22 Oct 2014 15:16:29 -0400
> Don Slutz wrote:
>
> > On 10/22/14 08:28, Thomas Huth wrote:
> > > Linus likely does not want to get e-mails about QEMU, so let's
> > > just remove this optio
Hi Frank,
On Fri, 5 Dec 2014 10:19:59 +0100
Frank Blaschka wrote:
> From: Frank Blaschka
>
> This patch implements the last remaining s390 pci instruction
> to query the function information block.
>
> Signed-off-by: Frank Blaschka
> ---
> hw/s390x/s390-pci-bus.h | 1 +
> hw/s390x/s390
ice_call(S390CPU *cpu, uint8_t r1,
> uint64_t fiba)
> uint32_t data;
> uint64_t cc = ZPCI_PCI_LS_OK;
>
> -cpu_synchronize_state(CPU(cpu));
> -
> if (env->psw.mask & PSW_MASK_PSTATE) {
> program_interrupt(env, PGM_PRIVILEGED, 6);
> return 0;
Reviewed-by: Thomas Huth
queue)(BlockDriverState *bs);
>
> +/* try to get physical and logical blocksizes */
> +int (*bdrv_probe_blocksizes)(BlockDriverState *bs, BlockSizes *bsz);
> +/* tey to get hard drive geometry (cyls, head, sectors) */
> +int (*bdrv_probe_geometry)(BlockDriverState *bs, hdGeometry *geo);
> +
> QLIST_ENTRY(BlockDriver) list;
> };
Looks fine to me (apart from the very minor camel-case issue above):
Reviewed-by: Thomas Huth
On Fri, 5 Dec 2014 18:56:18 +0100
Ekaterina Tumanova wrote:
> Put it in new probe_logical_blocksize().
>
> Signed-off-by: Ekaterina Tumanova
> ---
> block/raw-posix.c | 44 +++-
> 1 file changed, 27 insertions(+), 17 deletions(-)
>
> diff --git a/block
On Fri, 5 Dec 2014 18:56:19 +0100
Ekaterina Tumanova wrote:
> This patch introduces driver methods of defining disk blocksizes
> (physical and logical) and hard drive geometry.
> The method is only implemented for "host_device". For "raw" devices
> driver calls child's method.
>
> For the time
This patch looks basically good to me, I just got some cosmetic
requests:
On Fri, 5 Dec 2014 18:56:21 +0100
Ekaterina Tumanova wrote:
...
> diff --git a/hw/block/hd-geometry.c b/hw/block/hd-geometry.c
> index 6fcf74d..fbd602d 100644
> --- a/hw/block/hd-geometry.c
> +++ b/hw/block/hd-geometry.c
On Thu, 11 Dec 2014 14:17:21 +0300
Ekaterina Tumanova wrote:
> On 12/10/2014 04:14 PM, Thomas Huth wrote:
> > On Fri, 5 Dec 2014 18:56:19 +0100
> > Ekaterina Tumanova wrote:
...
> >> diff --git a/block/raw_bsd.c b/block/raw_bsd.c
> >> index 401b967..cfd5249
| 12
> 8 files changed, 44 insertions(+), 32 deletions(-)
Patch looks fine to me.
Reviewed-by: Thomas Huth
On Thu, 11 Dec 2014 14:25:06 +0100
Cornelia Huck wrote:
> Add a helper function for checking whether a bit is set in the guest
> features for a vdev as well as one that works on a feature bit set.
>
> Convert code that open-coded this: It cleans up the code and makes it
> easier to extend the gu
On Thu, 11 Dec 2014 14:25:07 +0100
Cornelia Huck wrote:
> With virtio-1, we support more than 32 feature bits. Let's extend both
> host and guest features to 64, which should suffice for a while.
>
> vhost and migration have been ignored for now.
>
> Signed-off-by: Cornelia Huck
> ---
> hw/9p
On Thu, 11 Dec 2014 14:25:14 +0100
Cornelia Huck wrote:
> For virtio-1 devices, the driver must not attempt to set feature bits
> after it set FEATURES_OK in the device status. Simply reject it in
> that case.
>
> Signed-off-by: Cornelia Huck
> ---
> hw/virtio/virtio.c | 16 +
On Fri, 12 Dec 2014 12:18:25 +0100
Cornelia Huck wrote:
> On Fri, 12 Dec 2014 11:55:38 +0100
> Thomas Huth wrote:
>
> > On Thu, 11 Dec 2014 14:25:14 +0100
> > Cornelia Huck wrote:
> >
> > > For virtio-1 devices, the driver must not attempt to set feature
On Fri, 12 Dec 2014 16:20:16 -0200
Eduardo Habkost wrote:
> On Wed, Dec 10, 2014 at 07:44:04PM +, Peter Maydell wrote:
> > On 10 December 2014 at 19:26, Eduardo Habkost wrote:
> > > Signed-off-by: Eduardo Habkost
> > > ---
> > > exec.c | 1 -
> > > hw/virtio/virtio.c
config.status and tests/qemu-iotests/common.env are generated files
that should be deleted during 'make distclean'.
Signed-off-by: Thomas Huth
---
Makefile |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index f505202..6817c6f 10
>
> +static int raw_probe_blocksizes(BlockDriverState *bs, BlockSizes *bsz)
> +{
> +bdrv_probe_blocksizes(bs->file, bsz);
> +
> +return 0;
> +}
> +
> +static int raw_probe_geometry(BlockDriverState *bs, HDGeometry *geo)
> +{
> +return bdrv_probe_geometry(bs->file, geo);
> +}
> +
> BlockDriver bdrv_raw = {
> .format_name = "raw",
> .bdrv_probe = &raw_probe,
> @@ -252,6 +264,8 @@ BlockDriver bdrv_raw = {
> .has_variable_length = true,
> .bdrv_get_info= &raw_get_info,
> .bdrv_refresh_limits = &raw_refresh_limits,
> +.bdrv_probe_blocksizes = &raw_probe_blocksizes,
> +.bdrv_probe_geometry = &raw_probe_geometry,
> .bdrv_is_inserted = &raw_is_inserted,
> .bdrv_media_changed = &raw_media_changed,
> .bdrv_eject = &raw_eject,
Looks good to me now (apart from the very minor typo).
Reviewed-by: Thomas Huth
et_stats(BlockBackend *blk);
>
> void *blk_aio_get(const AIOCBInfo *aiocb_info, BlockBackend *blk,
>BlockCompletionFunc *cb, void *opaque);
> +void blk_probe_blocksizes(BlockBackend *blk, BlockSizes *bsz);
> +int blk_probe_geometry(BlockBackend *blk, HDGeometry *geo);
>
> #endif
Reviewed-by: Thomas Huth
_conf.logical_block_size, 512), \
> + _conf.logical_block_size, 0), \
> DEFINE_PROP_BLOCKSIZE("physical_block_size", _state,\
> - _conf.physical_block_size, 512), \
> + _conf.physical_block_size, 0), \
> DEFINE_PROP_UINT16("min_io_size", _state, _conf.min_io_size, 0), \
> DEFINE_PROP_UINT32("opt_io_size", _state, _conf.opt_io_size, 0),\
> DEFINE_PROP_UINT32("discard_granularity", _state, \
> @@ -63,6 +63,7 @@ void blkconf_serial(BlockConf *conf, char **serial);
> void blkconf_geometry(BlockConf *conf, int *trans,
>unsigned cyls_max, unsigned heads_max, unsigned
> secs_max,
>Error **errp);
> +void blkconf_blocksizes(BlockConf *conf);
>
> /* Hard disk geometry */
>
Patch series looks fine to me now.
Reviewed-by: Thomas Huth
does not check whether the err
parameter from pci_nic_init has been set up and thus passes a NULL pointer
to error_report_err(). Fix it by correctly checking the err parameter.
Signed-off-by: Thomas Huth
---
hw/pci/pci.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/p
ue as well on my x86 laptop when playing
around with "--extra-cflags=-m32"... so should this be fixed for the
2.3 release already? I didn't spot your patch on the master branch
yet...
Anyway, your patch looks like the right solution:
Reviewed-by: Thomas Huth
Am Tue, 7 Apr 2015 11:18:41 +0300
schrieb Itamar Tal :
> Hi,
>
> Haven't got any response to this patch and couldn't find relevant
> maintainer as well. Can anyone direct me to the right guy?
>
> Thanks,
>
> Itamar Tal,
> Guardicore
>
> On Mon, Mar 23, 2015 at 6:07 PM, Itamar Tal wrote:
>
>
Am Sat, 11 Apr 2015 01:24:33 +1000
schrieb Alexey Kardashevskiy :
> This moves SPAPR bits to a separate file to avoid pollution of x86 code.
>
> This is a mechanical patch.
>
> Signed-off-by: Alexey Kardashevskiy
> Reviewed-by: David Gibson
> ---
> hw/vfio/Makefile.objs | 1 +
> hw/
Am Sat, 11 Apr 2015 01:24:36 +1000
schrieb Alexey Kardashevskiy :
> This makes use of the new "memory registering" feature. The idea is
> to provide the userspace ability to notify the host kernel about pages
> which are going to be used for DMA. Having this information, the host
> kernel can pin
BVFIOState *svphb = SPAPR_PCI_VFIO_HOST_BRIDGE(sphb);
> struct vfio_eeh_pe_op op = { .argsz = sizeof(op) };
> int ret;
>
> op.op = VFIO_EEH_PE_CONFIGURE;
> -ret = vfio_container_ioctl(&svphb->phb.iommu_as,
> +ret = vfio_container_ioctl(&sphb-&
Am Sat, 11 Apr 2015 01:24:37 +1000
schrieb Alexey Kardashevskiy :
> Currently TCE tables are created once at start and their size never
> changes. We are going to change that by introducing a Dynamic DMA windows
> support where DMA configuration may change during the guest execution.
>
> This cha
t, change the error message printing into a proper
qemu_log_mask(LOG_GUEST_ERROR, ...) call so that it is also possible
to enable this warning without recompiling the binary.
Signed-off-by: Thomas Huth
---
hw/ppc/spapr_iommu.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
Am Tue, 21 Apr 2015 10:24:48 +1000
schrieb David Gibson :
> On Mon, Apr 20, 2015 at 05:34:56PM +0200, Thomas Huth wrote:
> > The check "liobn & 0xULL" in spapr_tce_find_by_liobn()
> > is completely useless since liobn is only declared as an uint32
The check "liobn & 0xULL" in spapr_tce_find_by_liobn()
is completely useless since liobn is only declared as an uint32_t
parameter. Fix this by using target_ulong instead (this is what most
of the callers of this function are using, too).
Signed-off-by: Thomas Huth
Am Wed, 18 Mar 2015 12:22:35 +0100
schrieb Thomas Huth :
>
> Here are some more patches to remove completely unused functions
> from QEMU. Please review carefully, some of the functions might
> still get usefull in the future again, so if you discover one,
> please let me know, t
On Mon, 27 Apr 2015 13:48:27 +0200
Markus Armbruster wrote:
> Paolo Bonzini writes:
>
> > On 09/04/2015 20:31, Eric Blake wrote:
> >>> diff --git a/hw/pci/pci.c b/hw/pci/pci.c
> >>> index 6941a82..b3d5100 100644
> >>> --- a/hw/pci/pci.c
> >>> +++ b/hw/pci/pci.c
> >>> @@ -1660,7 +1660,9 @@ PCIDe
0x10074583: kvm_set_ioeventfd_mmio (kvm-all.c:574)
Let's fix it by using a proper struct initializer in kvm_set_ioeventfd_mmio().
Signed-off-by: Thomas Huth
---
kvm-all.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/kvm-all.c b/kvm-all.c
index dd44f8c..07
g rid of the Error pointer this way.
Signed-off-by: Thomas Huth
---
hw/pci/pci.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/hw/pci/pci.c b/hw/pci/pci.c
index b3d5100..6dac107 100644
--- a/hw/pci/pci.c
+++ b/hw/pci/pci.c
@@ -1613,8 +1613,7 @@ static const
> Date: Mon, 27 Apr 2015 20:09:50 +0200
> From: Stefan Weil
>
> Am 27.04.2015 um 13:27 schrieb Michael Tokarev:
> > 14.03.2015 09:19, Thomas Huth wrote:
> >> Here are some more patches to remove completely unused functions
> >> from QEMU. Please review ca
On Mon, 27 Apr 2015 10:55:41 -0700
Peter Crosthwaite wrote:
> On Mon, Apr 27, 2015 at 10:51 AM, Thomas Huth wrote:
> > The error reporting in pci_nic_init() is quite erratic: Some errors
> > are printed directly with error_report(), and some are passed back
> >
up this inconsistency.
Signed-off-by: Thomas Huth
---
hw/pci/pci.c | 43 ++-
1 file changed, 14 insertions(+), 29 deletions(-)
diff --git a/hw/pci/pci.c b/hw/pci/pci.c
index b3d5100..56947ae 100644
--- a/hw/pci/pci.c
+++ b/hw/pci/pci.c
@@ -1611,28 +1611,32
On Tue, 28 Apr 2015 10:40:09 +0200
"Michael S. Tsirkin" wrote:
> On Tue, Apr 28, 2015 at 09:26:47AM +0200, Thomas Huth wrote:
> > On Mon, 27 Apr 2015 10:55:41 -0700
> > Peter Crosthwaite wrote:
> >
> > > On Mon, Apr 27, 2015 at 10:51 AM, Thomas Hut
here is no default.\n"
> +"Use -machine help to list supported machines!\n");
> +exit(1);
> +}
> +
> +set_memory_options(&ram_slots, &maxram_size, machine_class);
>
> loc_set_none();
>
> @@ -3794,12 +3802,6 @@ int main(int argc, char **argv, char **envp)
> }
> #endif
>
> -if (machine_class == NULL) {
> -fprintf(stderr, "No machine specified, and there is no default.\n"
> -"Use -machine help to list supported machines!\n");
> -exit(1);
> -}
> -
> current_machine = MACHINE(object_new(object_class_get_name(
>OBJECT_CLASS(machine_class;
> if (machine_help_func(qemu_get_machine_opts(), current_machine)) {
Looks good to me.
Reviewed-by: Thomas Huth
ram_size = 1 * G_BYTE;
> mc->kvm_type = spapr_kvm_type;
> mc->has_dynamic_sysbus = true;
>
Reviewed-by: Thomas Huth
On Wed, 29 Apr 2015 09:34:51 +0300
Michael Tokarev wrote:
> 27.04.2015 19:59, Thomas Huth wrote:
> > valgrind complains here about uninitialized bytes with the following
> > message:
> >
> > ==17814== Syscall param ioctl(generic) points to uninitialised byte(s)
&g
Hi Justin,
On Wed, 1 Apr 2015 14:35:51 +0200
Justin Ossevoort wrote:
> The FITRIM ioctl updates the fstrim_range structure it receives. This
> way the caller can determine how many bytes were trimmed. The
> guest-fstrim logic reuses the same fstrim_range for each filesystem,
> effectively lim
hw_error() is designed for printing CPU-related error messages
(e.g. it also prints a full CPU register dump). For error messages
that are not directly related to CPU problems, a function like
error_report() should be used instead.
Signed-off-by: Thomas Huth
---
hw/ppc/spapr.c | 12
7;t expect when you
just typed in a wrong filename, and is rather confusing here
since you've got to find the real error message in the huge
output first. So let's fix that, too.
Thomas Huth (2):
ppc/spapr: Fix error message when firmware could not be loaded
hw/ppc/spapr: Use error_rep
out if the firmware file
had zero length.
Signed-off-by: Thomas Huth
---
hw/ppc/spapr.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index 61ddc79..226f029 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -1641,12 +1641,12 @@ static v
On Thu, 30 Apr 2015 11:18:05 +0200
Alexander Graf wrote:
>
>
> On 30.04.15 06:41, Nikunj A Dadhania wrote:
> >
> > Hi Paolo,
> >
> > Paolo Bonzini writes:
> >> On 29/04/2015 11:06, Nikunj A Dadhania wrote:
> so David can push both patches.
>
> But isn't 1G a bit too much? At
sted as a one-liner
at the end. This is ugly since "-net" is considered as legacy and
even might be removed one day. Thus, this patch switches the output
to explain the host network interfaces with the "-netdev" option
instead, moving the old "-net" option into some few l
On Sat, 16 May 2015 14:42:35 +0200
Alexander Graf wrote:
>
>
> On 15.05.15 15:43, Markus Armbruster wrote:
> > Alexander Graf writes:
> >
> >> On 17.03.15 08:46, Markus Armbruster wrote:
> >>> Alexander Graf writes:
> >>>
> On 09.03.15 19:30, Markus Armbruster wrote:
> > Alexander G
fdtXX_t types instead which have
just been introduced with version 1.4.0.
Signed-off-by: Thomas Huth
---
configure | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/configure b/configure
index b18aa9e..87a5bbc 100755
--- a/configure
+++ b/configure
@@ -3091,9 +3091,10 @@ fi
On Mon, 18 May 2015 09:59:02 +0100
Peter Maydell wrote:
> On 18 May 2015 at 08:11, Thomas Huth wrote:
> > On Sat, 16 May 2015 14:42:35 +0200
> > Alexander Graf wrote:
> >> Some of the patches in David's latest spapr queue are regressing
> >> compilation on
Since some recent patches require libfdt version 1.4.0,
let's update the dtc submodule to this version.
Signed-off-by: Thomas Huth
---
dtc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dtc b/dtc
index bc895d6..65cc4d2 16
--- a/dtc
+++ b/dtc
@@ -1 +1 @@
-Subpr
The patch "spapr_drc: initial implementation of sPAPRDRConnector device"
requires the function fdt_get_property_by_offset() from libfdt, which
is only properly exported there since version 1.4.0. So let's make
sure that we require at least version 1.4.0 of libfdt nowadays.
Thomas
required function
fdt_get_property_by_offset() instead instead.
Signed-off-by: Thomas Huth
---
configure | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/configure b/configure
index 1f0f485..cee997f 100755
--- a/configure
+++ b/configure
@@ -3102,9 +3102,11 @@ fi
if test
uot; option, too, so that you can now dump network packets
like this:
qemu... -device e1000,netdev=myhub -netdev hubport,hubid=1,id=myhub \
-netdev user,id=n1,vlan=1,tftp=/tmp/tftp,bootfile=zImage \
-netdev dump,id=n2,vlan=1,file=/tmp/dump.dat
Signed-off-by: Thomas Huth
---
net/net
g_free(sm->kvm_type);
> -sm->kvm_type = g_strdup(value);
> +g_free(spapr->kvm_type);
> +spapr->kvm_type = g_strdup(value);
> }
I think you could keep the "sm" variable name in these two functions.
Anyway, patch looks good to me now, so:
Reviewed-by: Thomas Huth
t_ulong opcode, target_ulong *args)
> {
> +MachineState *machine = MACHINE(spapr);
> CPUPPCState *env = &cpu->env;
> target_ulong flags = args[0];
> target_ulong pte_index = args[1];
Apart from the above nit, patch looks fine to me, so:
Reviewed-by: Thomas Huth
Another question out of curiosity: Do you know if the global "ram_size"
variable is scheduled to be removed soon in the future?
Thomas
> void *fdt_skel;
> -target_ulong entry_point;
> uint64_t rtc_offset; /* Now used only during incoming migration */
> struct PPCTimebase tb;
> bool has_graphics;
Reviewed-by: Thomas Huth
; +#define SPAPR_MACHINE_GET_CLASS(obj) \
> +OBJECT_GET_CLASS(sPAPRMachineClass, obj, TYPE_SPAPR_MACHINE)
> +#define SPAPR_MACHINE_CLASS(klass) \
> +OBJECT_CLASS_CHECK(sPAPRMachineClass, klass, TYPE_SPAPR_MACHINE)
> +
> +/**
> + * sPAPRMachineClass:
> + */
> +struct s
On Tue, 26 May 2015 13:52:35 +0100
Stefan Hajnoczi wrote:
> On Fri, May 22, 2015 at 09:22:19PM +0200, Thomas Huth wrote:
> > So far, it is not possible to use the network dump interface
> > with the "-netdev" option yet, it only works with the legacy
> > "-ne
On Tue, 26 May 2015 17:43:09 +0100
Stefan Hajnoczi wrote:
> On Tue, May 26, 2015 at 3:36 PM, Daniel P. Berrange
> wrote:
> > On Tue, May 26, 2015 at 04:29:51PM +0200, Markus Armbruster wrote:
> >> Stefan Hajnoczi writes:
> >>
> >> > On Fri, May 22, 2
On Mon, 11 May 2015 08:58:44 +0200
Justin Ossevoort wrote:
> The FITRIM ioctl updates the fstrim_range structure it receives. This
> way the caller can determine how many bytes were trimmed. The
> guest-fstrim logic reuses the same fstrim_range for each filesystem,
> effectively limiting each fil
On Wed, 27 May 2015 17:16:48 +0100
Stefan Hajnoczi wrote:
> Although hmp-commands.hx lists "netmap" as a valid host_net_add type,
> the command rejects it because it's missing from the list.
>
> Signed-off-by: Stefan Hajnoczi
> ---
> net/net.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> di
-
> -default:
> +if (opts->kind == NET_CLIENT_OPTIONS_KIND_DUMP ||
> +opts->kind == NET_CLIENT_OPTIONS_KIND_NIC ||
> +!net_client_init_fun[opts->kind]) {
> error_set(errp, QERR_INVALID_PARAMETER_VALUE, "type",
>"a netdev backend type");
> return -1;
Reviewed-by: Thomas Huth
turn 0; /* nothing to do */
> +}
> +
> +if (!net_client_init_fun[opts->kind]) {
> +error_set(errp, QERR_INVALID_PARAMETER_VALUE, "type",
> + "a net backend type (maybe it is not compiled "
> + "into this binary)");
> +return -1;
> +}
> }
>
> if (net_client_init_fun[opts->kind]) {
Reviewed-by: Thomas Huth
NetClientOptionsKind_lookup[opts->kind]);
> -}
> -return -1;
> +if (net_client_init_fun[opts->kind](opts, name, peer, errp) < 0) {
> +/* FIXME drop when all init functions store an Error */
> +if (errp && !*errp) {
> +error_set(errp, QERR_DEVICE_INIT_FAILED,
> + NetClientOptionsKind_lookup[opts->kind]);
> }
> +return -1;
> }
> return 0;
> }
Reviewed-by: Thomas Huth
(opts->kind != NET_CLIENT_OPTIONS_KIND_NIC ||
> - !opts->nic->has_netdev)) {
> -peer = net_hub_add_port(u.net->has_vlan ? u.net->vlan : 0, NULL);
> +/* Do not add to a vlan if it's a nic with a netdev= parameter. */
> +if (opts->kind != NET_CLIENT_OPTIONS_KIND_NIC ||
> +!opts->nic->has_netdev) {
> +peer = net_hub_add_port(net->has_vlan ? net->vlan : 0, NULL);
> +}
> }
>
> if (net_client_init_fun[opts->kind](opts, name, peer, errp) < 0) {
Reviewed-by: Thomas Huth
Hi Tu Bo!
On Thu, 28 May 2015 12:29:57 +0800
tu bo wrote:
> Hi Kevin:
>
> On 05/26/2015 07:55 PM, Kevin Wolf wrote:
...
> > Is this still an RFC series, as the subject indicates, or is it meant
> > for inclusion?
> This is my first task for qemu which I took over from Xiao Guang Chen,
> and
On Wed, 04 Mar 2015 14:00:17 +0530
Nikunj A Dadhania wrote:
> Markus Armbruster writes:
>
> > Nikunj A Dadhania writes:
> >
> >> diff --git a/vl.c b/vl.c
> >> index eb89d62..dd56754 100644
> >> --- a/vl.c
> >> +++ b/vl.c
> >> @@ -4053,6 +4053,18 @@ int main(int argc, char **argv, char **envp)
On Wed, 04 Mar 2015 14:34:27 +0530
Nikunj A Dadhania wrote:
> Thomas Huth writes:
>
> > On Wed, 04 Mar 2015 14:00:17 +0530
> > Nikunj A Dadhania wrote:
> >
> >> Markus Armbruster writes:
> >>
> >> > Nikunj A Dadhania writes:
> &g
On Wed, 04 Mar 2015 14:59:13 +0530
Nikunj A Dadhania wrote:
> Thomas Huth writes:
>
> > On Wed, 04 Mar 2015 14:34:27 +0530
> > Nikunj A Dadhania wrote:
> >
> >> Thomas Huth writes:
> >>
> >> > On Wed, 04 Mar 2015 14:00:17 +0530
On Thu, 05 Mar 2015 16:01:40 +0530
Nikunj A Dadhania wrote:
> Hi Igor,
>
> Thanks for the review.
>
> Igor Mammedov writes:
> > On Thu, 5 Mar 2015 14:36:10 +0530
> > Nikunj A Dadhania wrote:
> >
> >> Machines types can have different requirement for default ram
> >> size. Introduce a member
On s390, we would like to load our "BIOS" s390-ccw.img to the end of the
RAM. Therefor we need the possibility to relocate the ELF file so that
it can also run from different addresses. This patch adds the necessary
code to the QEMU ELF loader function.
Signed-off-by: Thomas Huth
--
The current bios sits at location 0x7e0 in the guest RAM
and thus prevents loading of bigger ramdisks. By making the
image relocatable we can move it to the end of the RAM so that
it is getting out of the way.
Signed-off-by: Thomas Huth
---
hw/s390x/ipl.c| 23
r ideas to solve
the problem of a relocatable BIOS?
Thanks for any insights!
Thomas Huth (2):
elf-loader: Provide the possibility to relocate s390 ELF files
s390/bios: Make the s390-ccw.img relocatable
hw/core/loader.c |2 +
hw/s390x/ipl.c| 23 +++-
The current bios sits at location 0x7e0 in the guest RAM
and thus prevents loading of bigger ramdisks. By making the
image relocatable we can move it to the end of the RAM so that
it is getting out of the way.
Signed-off-by: Thomas Huth
---
hw/s390x/ipl.c| 23
d
in case we need more (with different compiler version etc.).
The second patch then adds the required changes to the s390-ccw BIOS
Makefile and our s390 ipl code in QEMU.
v2:
- Fixed endianess issues in the ELF relocation function
Thomas Huth (2):
elf-loader: Provide the possibility to relocate s390
On s390, we would like to load our "BIOS" s390-ccw.img to the end of the
RAM. Therefor we need the possibility to relocate the ELF file so that
it can also run from different addresses. This patch adds the necessary
code to the QEMU ELF loader function.
Signed-off-by: Thomas Huth
--
On Mon, 09 Mar 2015 12:11:49 +0100
Christian Borntraeger wrote:
> Am 09.03.2015 um 11:12 schrieb Thomas Huth:
> > On s390, we would like to load our "BIOS" s390-ccw.img to the end of the
> > RAM. Therefor we need the possibility to relocate the ELF file so that
> >
Here are some more patches to remove completely unused functions
from QEMU. Please review carefully, some of the functions might
still get usefull in the future again, so if you discover one,
please let me know, then I'll remove it from the patch series
again.
Thomas Huth (8):
migration: R
The functions pcie_ari_init(), pcie_cap_is_arifwd_enabled()
and ich9_d2pbr_init() are completely unused and thus can
be deleted.
Signed-off-by: Thomas Huth
Cc: Michael S. Tsirkin
Cc: Anthony Liguori
---
hw/pci-bridge/i82801b11.c | 21 -
hw/pci/pcie.c | 25
migrate_rdma_pin_all(), qsb_clone() and qsb_set_length()
are completely unused and thus can be deleted.
Signed-off-by: Thomas Huth
Cc: Juan Quintela
Cc: Amit Shah
---
include/migration/migration.h |1 -
include/migration/qemu-file.h |2 -
migration/migration.c |9
The functions ringbuf_read_completion() and monitor_get_rs()
are not used anywhere anymore, so let's remove them.
Signed-off-by: Thomas Huth
Cc: Luiz Capitulino
---
hmp.h |1 -
include/monitor/monitor.h |1 -
monitor.c | 13 -
3
The function is not used anymore and thus can be deleted.
Signed-off-by: Thomas Huth
Cc: Dmitry Fleytman
---
hw/net/vmxnet_rx_pkt.c |7 ---
hw/net/vmxnet_rx_pkt.h |9 -
2 files changed, 0 insertions(+), 16 deletions(-)
diff --git a/hw/net/vmxnet_rx_pkt.c b/hw/net
Delete set_usb_string(), usb_ep_get_ifnum(), usb_ep_get_max_packet_size()
usb_ep_get_max_streams() and usb_ep_set_pipeline() since they are
not used anymore.
Signed-off-by: Thomas Huth
Cc: Gerd Hoffmann
---
hw/usb/core.c| 41 -
include/hw/usb.h
The functions tpm_backend_thread_tpm_reset(), serial_set_frequency()
and iothread_find() are completely unused, let's remove them.
Signed-off-by: Thomas Huth
---
backends/tpm.c | 11 ---
hw/char/serial.c |7 ---
include/hw/char/ser
The functions portio_list_destroy() and portio_list_del()
are not used anywhere, so let's remove them.
Signed-off-by: Thomas Huth
Cc: Paolo Bonzini
---
include/exec/ioport.h |2 --
ioport.c | 24
2 files changed, 0 insertions(+), 26 dele
Delete the unused functions qemu_signalfd_available(),
qemu_send_full() and qemu_recv_full().
Signed-off-by: Thomas Huth
Cc: Markus Armbruster
---
include/qemu-common.h |4 ---
include/qemu/compatfd.h |1 -
util/compatfd.c | 19 -
util/osdep.c| 66
On Mon, 09 Mar 2015 20:23:24 +0100
Paolo Bonzini wrote:
>
> On 09/03/2015 18:30, Thomas Huth wrote:
> > The functions portio_list_destroy() and portio_list_del()
> > are not used anywhere, so let's remove them.
> >
> > Signed-off-by: Thomas Huth
> > Cc
On Wed, 11 Mar 2015 08:57:34 +0100
Markus Armbruster wrote:
> Christian Borntraeger writes:
>
> > Am 10.03.2015 um 19:01 schrieb Peter Maydell:
> >> On 10 March 2015 at 08:37, Christian Borntraeger
> >> wrote:
> >>> Peter,
> >>>
> >>> this pull reuqest contains a header sync to 4.0-rc3. This s
On Wed, 11 Mar 2015 09:09:21 +0100
Christian Borntraeger wrote:
> Am 11.03.2015 um 08:57 schrieb Markus Armbruster:
> > Christian Borntraeger writes:
> >
> >> Am 10.03.2015 um 19:01 schrieb Peter Maydell:
> >>> On 10 March 2015 at 08:37, Christian Borntraeger
> >>> wrote:
> Peter,
>
On Wed, 11 Mar 2015 10:57:51 +0100
Cornelia Huck wrote:
> All fields in structures transmitted by ccws are big endian; assure
> we handle them as such for the set-revision ccw as well.
>
> Should be merged into "s390x/virtio-ccw: add virtio set-revision call".
>
> C
emu-system-s390x. To avoid this confusion, we
should not include pci.mak and rather include the bare minimum
manually instead.
Signed-off-by: Thomas Huth
Acked-by: Frank Blaschka
---
default-configs/s390x-softmmu.mak |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/defau
and linking the USB files only if it's really
necessary.
Signed-off-by: Thomas Huth
---
default-configs/arm-softmmu.mak |1 +
default-configs/usb.mak |1 +
hw/usb/Makefile.objs|8
3 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/defaul
On Sat, 14 Mar 2015 06:33:35 +0100
Thomas Huth wrote:
> Boards that do not include an USB controller should not provide
> USB devices. However, when running "qemu-system-s390x -device help"
By the way, in case somebody wants to test the above example, and
wonders why there are
The functions ringbuf_read_completion() and monitor_get_rs()
are not used anywhere anymore, so let's remove them.
Signed-off-by: Thomas Huth
Cc: Luiz Capitulino
---
hmp.h |1 -
include/monitor/monitor.h |1 -
monitor.c | 13 -
3
101 - 200 of 18434 matches
Mail list logo
