Re: [Qemu-devel] [PATCH v8 02/11] accel: collecting TB execution count

2019-08-30 Thread Vanderson Martins do Rosario
Ok. I haven't change it before because I would like to be able to collect information for already translated TBs when I, for instance, remove the filter during execution. Having the TBStats already created guarantee this. To guarantee this in your approach, we would need to tb_flush when changing

Re: [Qemu-devel] [PATCH v8 08/11] Adding tb_stats [start|pause|stop|filter] command to hmp.

2019-08-29 Thread Vanderson Martins do Rosario
Ops, this commit shouldn't exist. My mistake. The series still work though. I will remove this on v9. Vanderson M. Rosario On Thu, Aug 29, 2019 at 2:35 PM vandersonmr wrote: > This allows controlling the collection of statistics. > It is also possible to set the level of collection: > all,

Re: [Qemu-devel] [PATCH v1 1/2] accel/tcg: adding integration with linux perf

2019-08-21 Thread Vanderson Martins do Rosario
On Thu, Aug 15, 2019 at 11:40 AM Stefan Hajnoczi wrote: > On Wed, Aug 14, 2019 at 11:37:24PM -0300, vandersonmr wrote: > > This commit adds support to Linux Perf in order > > to be able to analyze qemu jitted code and > > also to able to see the TBs PC in it. > > Is there any reference to the

Re: [Qemu-devel] [PATCH v5 08/10] Adding info [tbs|tb|coverset] commands to HMP. These commands allow the exploration of TBs generated by the TCG. Understand which one hotter, with more guest/host ins

2019-08-21 Thread Vanderson Martins do Rosario
Do you think that "info tb-list 15" as a command to list 15 TBs make more sense than "info tbs 15"? It would be "into tb id" to investigate a specific TB and "into tb-list number" to list the TBs. Vanderson M. Rosario On Thu, Aug 15, 2019 at 6:00 AM Dr. David Alan Gilbert wrote: > *

Re: [Qemu-devel] [PATCH 2/3] pc: Improve error message when die-id is omitted

2019-08-15 Thread Vanderson Martins do Rosario
Reviewed-by: Vanderson M. do Rosario Vanderson M. Rosario On Thu, Aug 15, 2019 at 3:43 PM Eduardo Habkost wrote: > The error message when die-id is omitted doesn't make sense: > > $ qemu-system-x86_64 -smp 1,sockets=6,maxcpus=6 \ > -device

Re: [Qemu-devel] [PATCH 1/3] pc: Fix error message on die-id validation

2019-08-15 Thread Vanderson Martins do Rosario
Reviewed-by: Vanderson M. do Rosario Vanderson M. Rosario On Thu, Aug 15, 2019 at 3:48 PM Eduardo Habkost wrote: > The error message for die-id range validation is incorrect. Example: > > $ qemu-system-x86_64 -smp 1,sockets=6,maxcpus=6 \ > -device

Re: [Qemu-devel] [PATCH v3 5/6] monitor: adding info tb and tbs to monitor

2019-07-07 Thread Vanderson Martins do Rosario
Markus, Thank you for your comments! Based on your questions and suggestions of writing a more complete explanation in my commits, I decided to start to describe our whole work on the wiki: https://wiki.qemu.org/Internships/ProjectIdeas/TCGCodeQuality I will update and expand it weekly, so I can

Re: [Qemu-devel] [PATCH v2 1/4] add and link a statistic struct to TBs

2019-06-25 Thread Vanderson Martins do Rosario
When the tb_flush removes a block and it's recreated, this shouldn't be creating a new block but using the one that is found by: lookup_result = g_list_find_custom(tb_ctx.tb_statistics, new_stats, statistics_cmp); So the tb_statisticics will be reused and we could just add this regen counter in

[Qemu-devel] [GSOC] Improving Measurement of Tiny Code Generation Quality

2019-03-27 Thread Vanderson Martins do Rosario
. - So, before I start, I would like to present myself: I'm Vanderson Martins do Rosario, a Ph.D. candidate in Computer Science at Unicamp in Campinas, Brazil. Motivations to GSOC: My first contact with the Free and Open