Hi Jason,
Thanks again for your comments, much appreciated. I looked into using
qemu_send_packet() instead of can_bus_client_send(). And have a few comments
inline.
-Vikram
> -Original Message-
> From: Jason Wang
> Sent: Tuesday, February 4, 2020 9:47 PM
> To: Vikram Ga
0 7:25 PM
> To: Vikram Garhwal ; qemu-devel@nongnu.org
> Cc: Francisco Eduardo Iglesias
> Subject: Re: [PATCH 1/1] hw/net/can: Introduce Xlnx ZynqMP CAN
> controller for QEMU
>
>
> On 2020/2/25 下午2:22, Vikram Garhwal wrote:
> > Hi Jason,
> > Apologies for the delayed
talks on
how CAN Socket is intended to work. Equivalent file is located as
net/can-socketcan.c.
Regards,
Vikram
> -Original Message-
> From: Jason Wang
> Sent: Monday, February 10, 2020 7:09 PM
> To: Vikram Garhwal ; qemu-devel@nongnu.org
> Subject: Re: [PATCH 1/1] hw/net
Hi Jason,
Thanks for reviewing it. Few comments inline.
Also, I will add a patch for Maintainer updates when I send v2.
Regards,
Vikram
> -Original Message-
> From: Jason Wang
> Sent: Tuesday, February 4, 2020 9:47 PM
> To: Vikram Garhwal ; qemu-devel@nongnu.org
> Subjec
XlnxCAN is developed based on SocketCAN, QEMU CAN bus implementation.
Bus connection and socketCAN connection for each CAN module can be set
through command lines.
Signed-off-by: Vikram Garhwal
---
hw/net/can/Makefile.objs |1 +
hw/net/can/xlnx-zynqmp-can.c | 1106
\
-global driver=xlnx.zynqmp-can,property=canbus0,value=canbus0 \
-global driver=xlnx.zynqmp-can,property=canbus1,value=canbus1 \
-object can-host-socketcan,id=socketcan0,if=vcan0,canbus=canbus0 \
-object can-host-socketcan,id=socketcan1,if=vcan0,canbus=canbus1
Vikram Garhwal (1):
hw/net/can
Hi Jason,
Yes, I will maintain this NIC. Thanks for the help.
Regards,
Vikram
> -Original Message-
> From: Jason Wang
> Sent: Tuesday, February 4, 2020 7:17 PM
> To: Vikram Garhwal ; qemu-devel@nongnu.org
> Subject: Re: [PATCH 0/1] Introduce Xlnx ZynqMP CAN cont
Connect CAN0 and CAN1 to ZCU102 board.
Signed-off-by: Vikram Garhwal
---
hw/arm/xlnx-zynqmp.c | 26 ++
include/hw/arm/xlnx-zynqmp.h | 3 +++
2 files changed, 29 insertions(+)
diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm/xlnx-zynqmp.c
index b84d153..e5f0d9f 100644
XlnxCAN is developed based on SocketCAN, QEMU CAN bus implementation.
Bus connection and socketCAN connection for each CAN module can be set
through command lines.
Signed-off-by: Vikram Garhwal
---
hw/net/can/Makefile.objs |1 +
hw/net/can/xlnx-zynqmp-can.c | 1113
Qtest performs five tests on Xlnx-CAN controller:
It checks communication between CAN0 and CAN1 via can-bus.
Tests CAN in loopback, sleep and snoop mode.
Tests CAN filtering for incoming messages.
Signed-off-by: Vikram Garhwal
---
tests/qtest/Makefile.include | 1
Add myself as Xilinx CAN maintainer.
Signed-off-by: Vikram Garhwal
---
MAINTAINERS | 7 +++
1 file changed, 7 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 8cbc1fa..6223573 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1433,6 +1433,13 @@ F: hw/net/opencores_eth.c
Devices
ate and address code style issues.
Connect the CAN device to Xlnx-ZCU102 board.
Add maintainer entry.
Add QTEST for the CAN device.
Vikram Garhwal (4):
MAINTAINERS: Add maintainer entry for Xilinx CAN
hw/net/can: Introduce Xlnx ZynqMP CAN controller for QEMU
hw/net/can: Connect Xlnx Zyn
Hi Edgar,
Thanks for review.
> -Original Message-
> From: Edgar E. Iglesias
> Sent: Tuesday, April 28, 2020 9:28 AM
> To: Vikram Garhwal
> Cc: qemu-devel@nongnu.org; Jason Wang ;
> Alistair Francis ; Peter Maydell
> ; open list:Xilinx ZynqMP a...@nongnu.org>; da
Qtest performs five tests on Xlnx-CAN controller:
It checks communication between CAN0 and CAN1 via can-bus.
Tests CAN in loopback, sleep and snoop mode.
Tests CAN filtering for incoming messages.
Signed-off-by: Vikram Garhwal
---
tests/qtest/Makefile.include | 2
XlnxCAN is developed based on SocketCAN, QEMU CAN bus implementation.
Bus connection and socketCAN connection for each CAN module can be set
through command lines.
Signed-off-by: Vikram Garhwal
---
hw/net/can/Makefile.objs |1 +
hw/net/can/xlnx-zynqmp-can.c | 1113
Add myself as Xilinx CAN maintainer.
Signed-off-by: Vikram Garhwal
---
MAINTAINERS | 7 +++
1 file changed, 7 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 8cbc1fa..6223573 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1433,6 +1433,13 @@ F: hw/net/opencores_eth.c
Devices
Connect CAN0 and CAN1 to ZCU102 board.
Signed-off-by: Vikram Garhwal
---
hw/arm/xlnx-zynqmp.c | 26 ++
include/hw/arm/xlnx-zynqmp.h | 3 +++
2 files changed, 29 insertions(+)
diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm/xlnx-zynqmp.c
index b84d153..e5f0d9f 100644
sue.
Rearrange the patch order.
v1 -> v2:
Rename the CAN device state and address code style issues.
Connect the CAN device to Xlnx-ZCU102 board.
Add maintainer entry.
Add QTEST for the CAN device.
Vikram Garhwal (4):
hw/net/can: Introduce Xilinx ZynqMP CAN controller
xlnx-
Hi Francisco,
Thanks for the review. Comments inline.
Regards,
Vikram
> -Original Message-
> From: Francisco Iglesias
> Sent: Tuesday, April 28, 2020 12:20 PM
> To: Vikram Garhwal
> Cc: qemu-devel@nongnu.org; Peter Maydell ;
> Jason Wang ; Alistair Francis
> ; op
The Xilinx ZynqMP CAN controller is developed based on SocketCAN, QEMU CAN bus
implementation. Bus connection and socketCAN connection for each CAN module
can be set through command lines.
Signed-off-by: Vikram Garhwal
---
hw/net/can/Makefile.objs |1 +
hw/net/can/xlnx-zynqmp-can.c
Reviewed-by: Francisco Iglesias
Reviewed-by: Edgar E. Iglesias
Signed-off-by: Vikram Garhwal
---
MAINTAINERS | 8
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 8cbc1fa..b53d75e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1433,6 +1433,14 @@ F: hw/net
Connect CAN0 and CAN1 on the ZynqMP.
Reviewed-by: Francisco Iglesias
Reviewed-by: Edgar E. Iglesias
Signed-off-by: Vikram Garhwal
---
hw/arm/xlnx-zynqmp.c | 26 ++
include/hw/arm/xlnx-zynqmp.h | 3 +++
2 files changed, 29 insertions(+)
diff --git a/hw/arm
name the CAN device state and address code style issues.
Connect the CAN device to Xlnx-ZCU102 board.
Add maintainer entry.
Add QTEST for the CAN device.
Vikram Garhwal (4):
hw/net/can: Introduce Xilinx ZynqMP CAN controller
xlnx-zynqmp: Connect Xilinx ZynqMP CAN controllers
tests/qtes
The QTests perform five tests on the Xilinx ZynqMP CAN controller:
Tests the CAN controller in loopback, sleep and snoop mode.
Tests filtering of incoming CAN messages.
Acked-by: Thomas Huth
Signed-off-by: Vikram Garhwal
---
tests/qtest/Makefile.include | 2 +
tests/qtest/xlnx-can
XlnxCAN is developed based on SocketCAN, QEMU CAN bus implementation.
Bus connection and socketCAN connection for each CAN module can be set
through command lines.
Signed-off-by: Vikram Garhwal
---
hw/net/can/Makefile.objs |1 +
hw/net/can/xlnx-zynqmp-can.c |
The QTests perform five tests on the Xilinx ZynqMP CAN controller:
Tests the CAN controller in loopback, sleep and snoop mode.
Tests filtering of incoming CAN messages.
Signed-off-by: Vikram Garhwal
---
tests/qtest/Makefile.include | 2 +
tests/qtest/xlnx-can-test.c | 367
Connect CAN0 and CAN1 on the ZynqMP.
Reviewed-by: Edgar E. Iglesias
Signed-off-by: Vikram Garhwal
---
hw/arm/xlnx-zynqmp.c | 26 ++
include/hw/arm/xlnx-zynqmp.h | 3 +++
2 files changed, 29 insertions(+)
diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm/xlnx-zynqmp.c
Reviewed-by: Edgar E. Iglesias
Signed-off-by: Vikram Garhwal
---
MAINTAINERS | 8
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 8cbc1fa..b53d75e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1433,6 +1433,14 @@ F: hw/net/opencores_eth.c
Devices
-> v4:
Correct formatting issues.
v2 -> v3:
Rectify the build issue.
Rearrange the patch order.
v1 -> v2:
Rename the CAN device state and address code style issues.
Connect the CAN device to Xlnx-ZCU102 board.
Add maintainer entry.
Add QTEST for the CAN device
Hi Peter,
Thanks for the help here.
I had a look at the v1 pull. I will rebase the patches with latest changes and
send next version with changes.
Regards,
Vikram
> -Original Message-
> From: Peter Maydell
> Sent: Monday, September 14, 2020 8:06 AM
> To: Vikram Garhwal
Reviewed-by: Francisco Iglesias
Reviewed-by: Edgar E. Iglesias
Signed-off-by: Vikram Garhwal
---
MAINTAINERS | 8
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 3d17cad..3ed61d9 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1557,6 +1557,14 @@ F: hw/net
Connect CAN0 and CAN1 on the ZynqMP.
Reviewed-by: Francisco Iglesias
Reviewed-by: Edgar E. Iglesias
Signed-off-by: Vikram Garhwal
---
hw/arm/xlnx-zcu102.c | 20
hw/arm/xlnx-zynqmp.c | 34 ++
include/hw/arm/xlnx-zynqmp.h | 8
Rectify the build issue.
Rearrange the patch order.
v1 -> v2:
Rename the CAN device state and address code style issues.
Connect the CAN device to Xlnx-ZCU102 board.
Add maintainer entry.
Add QTEST for the CAN device.
Vikram Garhwal (4):
hw/net/can: Introduce Xilinx ZynqMP C
-by: Edgar E. Iglesias
Signed-off-by: Vikram Garhwal
---
hw/Kconfig |1 +
hw/net/can/meson.build |1 +
hw/net/can/xlnx-zynqmp-can.c | 1165 ++
include/hw/net/xlnx-zynqmp-can.h | 78 +++
4 files changed, 1245 insertions
The QTests perform five tests on the Xilinx ZynqMP CAN controller:
Tests the CAN controller in loopback, sleep and snoop mode.
Tests filtering of incoming CAN messages.
Reviewed-by: Francisco Iglesias
Signed-off-by: Vikram Garhwal
---
tests/qtest/meson.build | 1 +
tests/qtest
On Tue, Jul 14, 2020 at 02:20:16PM +0200, p...@cmp.felk.cvut.cz wrote:
Hi Pavel,
> From: Jan Charvat
>
> Signed-off-by: Jan Charvat
> Signed-off-by: Pavel Pisa
> ---
> include/net/can_emu.h | 4
> net/can/can_core.c| 36
> 2 files changed, 40
Hi Pavel,
Forgot to add this in last reply: Francisco Iglesias(in cc) was also involved a
lot in net/can QEMU devices and willing to help in the review if needed.
Regards
Vikram
> -Original Message-
> From: Vikram Garhwal
> Sent: Wednesday, September 2, 2020 10:20 PM
> To
On Wed, Sep 02, 2020 at 09:51:44AM +0200, Pavel Pisa wrote:
Hi Pavel,
> Hello Vikram,
>
> thanks much for the patches review.
>
> On Tuesday 01 of September 2020 22:01:26 Vikram Garhwal wrote:
> > Hi Jan,
> > A couple of comments on this patch.
> >
> > On T
On Thu, Sep 03, 2020 at 08:12:42AM +0200, Pavel Pisa wrote:
Hey Pavel,
Thanks for clarifying this and sharing the relevant links.
Regards,
Vikram
> Hello Vikram,
>
> On Thursday 03 of September 2020 07:43:34 Vikram Garhwal wrote:
> > On Tue, Jul 14, 2020 at 02:20:16PM +0200, p...@c
On Tue, Jul 14, 2020 at 02:20:15PM +0200, p...@cmp.felk.cvut.cz wrote:
> From: Jan Charvat
>
> Signed-off-by: Jan Charvat
> Signed-off-by: Pavel Pisa
Reviewed-by: Vikram Garhwal
> ---
> hw/net/can/can_sja1000.c | 29 +++--
> 1 file changed
Hi Jan,
A couple of comments on this patch.
On Tue, Jul 14, 2020 at 02:20:14PM +0200, p...@cmp.felk.cvut.cz wrote:
> From: Jan Charvat
>
> Signed-off-by: Jan Charvat
> Signed-off-by: Pavel Pisa
> ---
> hw/net/can/can_sja1000.c | 2 ++
> include/net/can_emu.h| 8 ++-
>
Hi Philippe,
Thank you so much for reviewing this patch.
On Fri, Oct 02, 2020 at 04:18:08PM +0200, Philippe Mathieu-Daudé wrote:
> Hi Vikram,
>
> Sorry for reviewing that late (v10).
>
> On 9/15/20 12:08 AM, Vikram Garhwal wrote:
> > The Xilinx ZynqMP CAN controller is develop
Hi Philippe,
Thanks for reviewing this one. I will address the comments in next version and
add reviewed-by tags.
On Fri, Oct 02, 2020 at 03:49:31PM +0200, Philippe Mathieu-Daudé wrote:
> Hi Vikram,
>
> On 9/15/20 12:08 AM, Vikram Garhwal wrote:
> > The QTests perform five test
-host-socketcan,id=socketcan0,if=vcan0,canbus=canbus0 \
-object can-host-socketcan,id=socketcan1,if=vcan0,canbus=canbus1
To create virtual CAN on the host machine, please check the QEMU CAN docs:
https://github.com/qemu/qemu/blob/master/docs/can.txt
Signed-off-by: Vikram Garhwal
es.
Connect the CAN device to Xlnx-ZCU102 board.
Add maintainer entry.
Add QTEST for the CAN device.
Vikram Garhwal (4):
hw/net/can: Introduce Xilinx ZynqMP CAN controller
xlnx-zynqmp: Connect Xilinx ZynqMP CAN controllers
tests/qtest: Introduce tests for Xilinx ZynqMP CAN
Reviewed-by: Francisco Iglesias
Reviewed-by: Edgar E. Iglesias
Signed-off-by: Vikram Garhwal
---
MAINTAINERS | 8
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 47dd38a..a8c672c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1559,6 +1559,14 @@ F: hw/net
Reviewed-by: Francisco Iglesias
Reviewed-by: Edgar E. Iglesias
Signed-off-by: Vikram Garhwal
---
MAINTAINERS | 8
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 47dd38a..a8c672c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1559,6 +1559,14 @@ F: hw/net
Reviewed-by: Francisco Iglesias
Reviewed-by: Edgar E. Iglesias
Signed-off-by: Vikram Garhwal
---
MAINTAINERS | 8
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 47dd38a..a8c672c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1559,6 +1559,14 @@ F: hw/net
The QTests perform five tests on the Xilinx ZynqMP CAN controller:
Tests the CAN controller in loopback, sleep and snoop mode.
Tests filtering of incoming CAN messages.
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Francisco Iglesias
Signed-off-by: Vikram Garhwal
---
tests/qtest
-host-socketcan,id=socketcan0,if=vcan0,canbus=canbus0 \
-object can-host-socketcan,id=socketcan1,if=vcan0,canbus=canbus1
To create virtual CAN on the host machine, please check the QEMU CAN docs:
https://github.com/qemu/qemu/blob/master/docs/can.txt
Signed-off-by: Vikram Garhwal
The QTests perform five tests on the Xilinx ZynqMP CAN controller:
Tests the CAN controller in loopback, sleep and snoop mode.
Tests filtering of incoming CAN messages.
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Francisco Iglesias
Signed-off-by: Vikram Garhwal
---
tests/qtest
-host-socketcan,id=socketcan0,if=vcan0,canbus=canbus0 \
-object can-host-socketcan,id=socketcan1,if=vcan0,canbus=canbus1
To create virtual CAN on the host machine, please check the QEMU CAN docs:
https://github.com/qemu/qemu/blob/master/docs/can.txt
Signed-off-by: Vikram Garhwal
Connect CAN0 and CAN1 on the ZynqMP.
Reviewed-by: Francisco Iglesias
Reviewed-by: Edgar E. Iglesias
Signed-off-by: Vikram Garhwal
---
include/hw/arm/xlnx-zynqmp.h | 8
hw/arm/xlnx-zcu102.c | 20
hw/arm/xlnx-zynqmp.c | 34
e CAN device state and address code style issues.
Connect the CAN device to Xlnx-ZCU102 board.
Add maintainer entry.
Add QTEST for the CAN device.
Vikram Garhwal (4):
hw/net/can: Introduce Xilinx ZynqMP CAN controller
xlnx-zynqmp: Connect Xilinx ZynqMP CAN controllers
tests/qte
Connect CAN0 and CAN1 on the ZynqMP.
Reviewed-by: Francisco Iglesias
Reviewed-by: Edgar E. Iglesias
Signed-off-by: Vikram Garhwal
---
include/hw/arm/xlnx-zynqmp.h | 8
hw/arm/xlnx-zcu102.c | 20
hw/arm/xlnx-zynqmp.c | 34
e CAN device state and address code style issues.
Connect the CAN device to Xlnx-ZCU102 board.
Add maintainer entry.
Add QTEST for the CAN device.
Vikram Garhwal (4):
hw/net/can: Introduce Xilinx ZynqMP CAN controller
xlnx-zynqmp: Connect Xilinx ZynqMP CAN controllers
tests/qte
Connect CAN0 and CAN1 on the ZynqMP.
Reviewed-by: Francisco Iglesias
Reviewed-by: Edgar E. Iglesias
Signed-off-by: Vikram Garhwal
---
include/hw/arm/xlnx-zynqmp.h | 8
hw/arm/xlnx-zcu102.c | 20
hw/arm/xlnx-zynqmp.c | 34
The QTests perform five tests on the Xilinx ZynqMP CAN controller:
Tests the CAN controller in loopback, sleep and snoop mode.
Tests filtering of incoming CAN messages.
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Francisco Iglesias
Signed-off-by: Vikram Garhwal
---
tests/qtest
On Thu, Oct 08, 2020 at 04:27:12PM -0400, Eduardo Habkost wrote:
> Fix the following crash:
>
> $ qemu-system-x86_64 -object can-host-socketcan,id=obj0
> Segmentation fault (core dumped)
>
> Signed-off-by: Eduardo Habkost
Reviewed-by: Vikram Garhwal
> ---
> Cc:
Hi Edgar,
Thanks for reviewing this one.
On Tue, Sep 29, 2020 at 04:25:47PM +0200, Edgar E. Iglesias wrote:
> On Tue, Sep 29, 2020 at 04:25:41PM +0530, Sai Pavan Boddu wrote:
> > From: Vikram Garhwal
> >
> > This patch adds skeleton model of dwc3 usb controller attached to
&
nal Message-
> From: Vikram Garhwal
> Sent: Monday, September 14, 2020 3:29 PM
> To: Peter Maydell
> Subject: Re: [PATCH v9 0/4] Introduce Xilinx ZynqMP CAN controller
>
> Hi Peter,
> I just sent the v10 series which is rebased with latest master branch
> changes.
>
ZCU102 board.
Add maintainer entry.
Add QTEST for the CAN device.
Vikram Garhwal (4):
hw/net/can: Introduce Xilinx ZynqMP CAN controller
xlnx-zynqmp: Connect Xilinx ZynqMP CAN controllers
tests/qtest: Introduce tests for Xilinx ZynqMP CAN controller
MAINTAINERS: Add maintainer entry
-host-socketcan,id=socketcan0,if=vcan0,canbus=canbus0 \
-object can-host-socketcan,id=socketcan1,if=vcan0,canbus=canbus1
To create virtual CAN on the host machine, please check the QEMU CAN docs:
https://github.com/qemu/qemu/blob/master/docs/can.txt
Signed-off-by: Vikram Garhwal
---
hw/net/can
Reviewed-by: Francisco Iglesias
Reviewed-by: Edgar E. Iglesias
Signed-off-by: Vikram Garhwal
---
MAINTAINERS | 8
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 0886eb3..14d9b73 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1536,6 +1536,14 @@ F: hw/net
Connect CAN0 and CAN1 on the ZynqMP.
Signed-off-by: Vikram Garhwal
---
hw/arm/xlnx-zcu102.c | 20
hw/arm/xlnx-zynqmp.c | 34 ++
include/hw/arm/xlnx-zynqmp.h | 8
3 files changed, 62 insertions(+)
diff --git a/hw/arm
The QTests perform five tests on the Xilinx ZynqMP CAN controller:
Tests the CAN controller in loopback, sleep and snoop mode.
Tests filtering of incoming CAN messages.
Signed-off-by: Vikram Garhwal
---
tests/qtest/Makefile.include | 2 +
tests/qtest/xlnx-can-test.c | 359
The QTests perform five tests on the Xilinx ZynqMP CAN controller:
Tests the CAN controller in loopback, sleep and snoop mode.
Tests filtering of incoming CAN messages.
Reviewed-by: Francisco Iglesias
Signed-off-by: Vikram Garhwal
---
tests/qtest/Makefile.include | 2 +
tests/qtest
-host-socketcan,id=socketcan0,if=vcan0,canbus=canbus0 \
-object can-host-socketcan,id=socketcan1,if=vcan0,canbus=canbus1
To create virtual CAN on the host machine, please check the QEMU CAN docs:
https://github.com/qemu/qemu/blob/master/docs/can.txt
Signed-off-by: Vikram Garhwal
---
hw/net/can
Connect CAN0 and CAN1 on the ZynqMP.
Reviewed-by: Francisco Iglesias
Reviewed-by: Edgar E. Iglesias
Signed-off-by: Vikram Garhwal
---
hw/arm/xlnx-zcu102.c | 20
hw/arm/xlnx-zynqmp.c | 34 ++
include/hw/arm/xlnx-zynqmp.h | 8
ame the CAN device state and address code style issues.
Connect the CAN device to Xlnx-ZCU102 board.
Add maintainer entry.
Add QTEST for the CAN device.
Vikram Garhwal (4):
hw/net/can: Introduce Xilinx ZynqMP CAN controller
xlnx-zynqmp: Connect Xilinx ZynqMP CAN controllers
test
Reviewed-by: Francisco Iglesias
Reviewed-by: Edgar E. Iglesias
Signed-off-by: Vikram Garhwal
---
MAINTAINERS | 8
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 0886eb3..14d9b73 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1536,6 +1536,14 @@ F: hw/net
Hi Edgar,
Thanks for reviewing the patch. Please see some comments.
> -Original Message-
> From: Edgar E. Iglesias
> Sent: Tuesday, July 7, 2020 5:49 AM
> To: Vikram Garhwal
> Cc: qemu-devel@nongnu.org; Francisco Eduardo Iglesias
> ; Jason Wang ; Alistair
> Fr
The QTests perform five tests on the Xilinx ZynqMP CAN controller:
Tests the CAN controller in loopback, sleep and snoop mode.
Tests filtering of incoming CAN messages.
Acked-by: Thomas Huth
Signed-off-by: Vikram Garhwal
---
tests/qtest/Makefile.include | 2 +
tests/qtest/xlnx-can
/qemu/blob/master/docs/can.txt
Signed-off-by: Vikram Garhwal
---
hw/net/can/Makefile.objs |1 +
hw/net/can/xlnx-zynqmp-can.c | 1163 ++
include/hw/net/xlnx-zynqmp-can.h | 79 +++
3 files changed, 1243 insertions(+)
create mode 100644 hw/net/can
Reviewed-by: Francisco Iglesias
Reviewed-by: Edgar E. Iglesias
Signed-off-by: Vikram Garhwal
---
MAINTAINERS | 8
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 63b3bb3..6f73a60 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1466,6 +1466,14 @@ F: hw/net
Connect CAN0 and CAN1 on the ZynqMP.
Signed-off-by: Vikram Garhwal
---
hw/arm/xlnx-zynqmp.c | 28
include/hw/arm/xlnx-zynqmp.h | 4
2 files changed, 32 insertions(+)
diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm/xlnx-zynqmp.c
index 1de9d4a..3f93524
to Xlnx-ZCU102 board.
Add maintainer entry.
Add QTEST for the CAN device.
Vikram Garhwal (4):
hw/net/can: Introduce Xilinx ZynqMP CAN controller
xlnx-zynqmp: Connect Xilinx ZynqMP CAN controllers
tests/qtest: Introduce tests for Xilinx ZynqMP CAN controller
MAINTAINERS: Add maintainer e
range the patch order.
v1 -> v2:
Rename the CAN device state and address code style issues.
Connect the CAN device to Xlnx-ZCU102 board.
Add maintainer entry.
Add QTEST for the CAN device.
Vikram Garhwal (4):
hw/net/can: Introduce Xilinx ZynqMP CAN controller
xlnx-zynqmp: Con
Reviewed-by: Francisco Iglesias
Reviewed-by: Edgar E. Iglesias
Signed-off-by: Vikram Garhwal
---
MAINTAINERS | 8
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 63b3bb3..6f73a60 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1466,6 +1466,14 @@ F: hw/net
/qemu/blob/master/docs/can.txt
Signed-off-by: Vikram Garhwal
---
hw/net/can/Makefile.objs |1 +
hw/net/can/xlnx-zynqmp-can.c | 1163 ++
include/hw/net/xlnx-zynqmp-can.h | 79 +++
3 files changed, 1243 insertions(+)
create mode 100644 hw/net/can
The QTests perform five tests on the Xilinx ZynqMP CAN controller:
Tests the CAN controller in loopback, sleep and snoop mode.
Tests filtering of incoming CAN messages.
Signed-off-by: Vikram Garhwal
---
tests/qtest/Makefile.include | 2 +
tests/qtest/xlnx-can-test.c | 367
Connect CAN0 and CAN1 on the ZynqMP.
Acked-by: Alistair Francis
Signed-off-by: Vikram Garhwal
---
hw/arm/xlnx-zynqmp.c | 28
include/hw/arm/xlnx-zynqmp.h | 4
2 files changed, 32 insertions(+)
diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm/xlnx-zynqmp.c
Connect CAN0 and CAN1 on the ZynqMP.
Reviewed-by: Francisco Iglesias
Reviewed-by: Edgar E. Iglesias
Signed-off-by: Vikram Garhwal
---
include/hw/arm/xlnx-zynqmp.h | 8
hw/arm/xlnx-zcu102.c | 20
hw/arm/xlnx-zynqmp.c | 34
Add maintainer entry.
Add QTEST for the CAN device.
Vikram Garhwal (4):
hw/net/can: Introduce Xilinx ZynqMP CAN controller
xlnx-zynqmp: Connect Xilinx ZynqMP CAN controllers
tests/qtest: Introduce tests for Xilinx ZynqMP CAN controller
MAINTAINERS: Add maintainer entry for Xilinx Zy
-host-socketcan,id=socketcan0,if=vcan0,canbus=canbus0 \
-object can-host-socketcan,id=socketcan1,if=vcan0,canbus=canbus1
To create virtual CAN on the host machine, please check the QEMU CAN docs:
https://github.com/qemu/qemu/blob/master/docs/can.txt
Signed-off-by: Vikram Garhwal
The QTests perform five tests on the Xilinx ZynqMP CAN controller:
Tests the CAN controller in loopback, sleep and snoop mode.
Tests filtering of incoming CAN messages.
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Francisco Iglesias
Signed-off-by: Vikram Garhwal
---
tests/qtest
Reviewed-by: Francisco Iglesias
Reviewed-by: Edgar E. Iglesias
Signed-off-by: Vikram Garhwal
---
MAINTAINERS | 8
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 63223e1..447b7f2 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1554,6 +1554,14 @@ F: hw/net
On Tue, Oct 20, 2020 at 11:53:25AM +0100, Peter Maydell wrote:
> On Wed, 14 Oct 2020 at 07:04, Vikram Garhwal wrote:
> >
> > The Xilinx ZynqMP CAN controller is developed based on SocketCAN, QEMU CAN
> > bus
> > implementation. Bus connection and socketCAN connection
On Fri, Jan 22, 2021 at 01:21:53PM +, Peter Maydell wrote:
Patch looks good to me.
Reviewed-by: Vikram Garhwal
> Just noticed this wasn't cc'd to the Xilinx folks. Would one
> of you like to review it?
>
> thanks
> -- PMM
>
> On Mon, 18 Jan 2021 at 16:25,
is 10.
For the interrupts triggering use already existing on Arm
device-model hypercall.
The toolstack should then insert the same amount of device nodes
into guest device-tree.
Signed-off-by: Oleksandr Tyshchenko
Signed-off-by: Vikram Garhwal
---
hw/arm/xen_arm.c| 35
Hi,
We added virtio-mmio support in xenpvh machine. Now, it can support upto
10 virtio mmio.
Changelog:
v3->v4:
Moved the defs to xen_native.h
v2->v3:
Define GUEST_VIRTIO_*, GUEST_RAM* and xendevicemodel_set_irq() manually
for old xen version. This was done to
machine
usable for /etc/init.d/xencommons.
Signed-off-by: Oleksandr Tyshchenko
Signed-off-by: Vikram Garhwal
---
hw/arm/xen_arm.c| 45 +
include/hw/xen/xen_native.h | 8 +++
2 files changed, 53 insertions(+)
diff --git a/hw/arm/xen_arm.c b
n't have this file change and i missed updating
my cc list.
>
> On Tue, Aug 29, 2023 at 09:35:17PM -0700, Vikram Garhwal wrote:
> > diff --git a/include/hw/xen/xen_native.h b/include/hw/xen/xen_native.h
> > index 4dce905fde..a4b1aa9e5d 100644
> > --- a/include/hw/xen/xen_nati
From: Juergen Gross
Virtio devices should never be unplugged at boot time, as they are
similar to pci passthrough devices.
Signed-off-by: Juergen Gross
Signed-off-by: Vikram Garhwal
---
docs/system/i386/xen.rst | 3 ---
hw/i386/xen/xen_platform.c | 10 --
2 files changed, 8
Enable grant ram mapping support for Xenpvh machine on ARM.
Signed-off-by: Vikram Garhwal
Reviewed-by: Stefano Stabellini
---
hw/arm/xen_arm.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/hw/arm/xen_arm.c b/hw/arm/xen_arm.c
index f83b983ec5..553c289720 100644
--- a/hw/arm/xen_arm.c
From: Juergen Gross
Today xen_ram_addr_from_mapcache() will either abort() or return 0 in
case it can't find a matching entry for a pointer value. Both cases
are bad, so change that to return an invalid address instead.
Signed-off-by: Juergen Gross
Reviewed-by: Stefano Stabellini
---
From: Juergen Gross
Add the callbacks for mapping/unmapping guest memory via grants to the
special grant memory region.
Signed-off-by: Juergen Gross
Signed-off-by: Vikram Garhwal
---
hw/xen/xen-mapcache.c | 175 +-
system/physmem.c | 11 ++-
2
let qemu_map_ram_ptr() use qemu_ram_ptr_length()
xen: let xen_ram_addr_from_mapcache() return -1 in case of not found
entry
memory: add MemoryRegion map and unmap callbacks
xen: add map and unmap callbacks for grant region
Vikram Garhwal (2):
softmmu: physmem: Split ram_block_add()
hw: arm:
Extract ram block list update to a new function ram_block_add_list(). This is
done to support grant mappings which adds a memory region for granted memory and
updates the ram_block list.
Signed-off-by: Juergen Gross
Signed-off-by: Vikram Garhwal
---
include/exec/ram_addr.h | 1 +
system
From: Juergen Gross
qemu_map_ram_ptr() and qemu_ram_ptr_length() share quite some code, so
modify qemu_ram_ptr_length() a little bit and use it for
qemu_map_ram_ptr(), too.
Signed-off-by: Juergen Gross
Signed-off-by: Vikram Garhwal
---
system/physmem.c | 58
1 - 100 of 290 matches
Mail list logo
