[Qemu-devel] [PATCH] bios-tables-test: delete a assert about block name

2017-08-14 Thread wei . yang
From: Wei Yang <wei.y...@ucloud.cn> The assert would be touched when the version of acpica is greater than or equal to 20160318. its reason is that "Disasembler: Update a couple output items(commit id: 1ecbb3d)" is introduced by Robert, the patch emits the AML filename as a ze

Re: [Qemu-devel] [PATCH] bitmap: refine and move BITMAP_{FIRST/LAST}_WORD_MASK

2016-09-29 Thread Wei Yang
On Thu, Sep 29, 2016 at 07:11:39PM +0300, Michael Tokarev wrote: >05.03.2016 16:47, Wei Yang wrote: >>According to linux kernel commit <89c1e79eb30> ("linux/bitmap.h: improve >>BITMAP_{LAST,FIRST}_WORD_MASK"), these two macro could be improved. >> >>This

Re: [Qemu-devel] [RFC Design Doc]Speed up live migration by skipping free pages

2016-03-23 Thread Wei Yang
On Thu, Mar 24, 2016 at 01:32:25AM +, Li, Liang Z wrote: >> >> >> > >> >> >> >6. Handling page cache in the guest The memory used for page >> >> >> >cache in the guest will change depends on the workload, if guest >> >> >> >run some block IO intensive work load, there will >> >> >> >> >> >>

Re: [Qemu-devel] [RFC Design Doc]Speed up live migration by skipping free pages

2016-03-23 Thread Wei Yang
On Wed, Mar 23, 2016 at 06:48:22AM +, Li, Liang Z wrote: [...] >> > 8. Pseudo code >> > Dirty page logging should be enabled before getting the free page >> > information from guest, this is important because during the process >> > of getting free pages, some free pages may be used and

Re: [Qemu-devel] [RFC Design Doc]Speed up live migration by skipping free pages

2016-03-23 Thread Wei Yang
On Wed, Mar 23, 2016 at 02:35:42PM +, Li, Liang Z wrote: >> >No special purpose. Maybe it's caused by the email client. I didn't >> >find the character in the original doc. >> > >> >> https://lists.gnu.org/archive/html/qemu-devel/2016-03/msg00715.html >> >> You could take a look at this

Re: [Qemu-devel] [RFC Design Doc]Speed up live migration by skipping free pages

2016-03-23 Thread Wei Yang
oesn't do >it automatically. > Oh, first time to notice this, interesting~ >-- >Eric Blake eblake redhat com+1-919-301-3266 >Libvirt virtualization library http://libvirt.org > -- Wei Yang Help you, Help me

Re: [Qemu-devel] [RFC Design Doc]Speed up live migration by skipping free pages

2016-03-23 Thread Wei Yang
On Wed, Mar 23, 2016 at 07:18:57AM +, Li, Liang Z wrote: >> Hi, Liang >> >> This is a very clear documentation of your work, I appreciated it a lot. >> Below >> are some of my personal opinion and question. >> > >Thanks for your comments! > >> On Tue, Mar 22, 2016 at 03:43:49PM +0800, Liang

Re: [Qemu-devel] [RFC Design Doc]Speed up live migration by skipping free pages

2016-03-22 Thread Wei Yang
Hi, Liang This is a very clear documentation of your work, I appreciated it a lot. Below are some of my personal opinion and question. On Tue, Mar 22, 2016 at 03:43:49PM +0800, Liang Li wrote: >I have sent the RFC version patch set for live migration optimization >by skipping processing the free

Re: [Qemu-devel] [PATCH] vfio/pci: replace 1 with PCI_CAP_LIST_NEXT to make code self-explain

2016-03-19 Thread Wei Yang
nt. By using the macro, audience is more easy to understand it tries to get the position of next capability. > >Each capability is a node of a linked list, and the position of the next >capability is at offset 1 inside the capability (here it is at offset 1 >from the tmp or pos base). I think the patch is an improvement. > Thanks Paolo for your reply. :-) >Paolo -- Wei Yang Help you, Help me

Re: [Qemu-devel] [RFC PATCH V2 00/10] Qemu: Add live migration support for SRIOV NIC

2016-03-18 Thread Wei Yang
Hi, Tianyu, I am testing your V2 patch set in our environment, while facing two issues now. Have a workaround for the first one and hope you could share some light on the second one :-) 1. Mismatch for ram_block (Have a workaround)

Re: [Qemu-devel] [PATCH] kvm/irqchip: use bitmap utility for gsi tracking

2016-03-07 Thread Wei Yang
On Mon, Mar 07, 2016 at 10:47:53AM +0100, Paolo Bonzini wrote: >On 06/03/2016 02:57, Wei Yang wrote: >> By using utilities in bitops and bitmap, this patch tries to make it more >> friendly to audience. No functional change. >> >> Signed-off-by: Wei Yang <richard.wei

[Qemu-devel] [PATCH] kvm/irqchip: use bitmap utility for gsi tracking

2016-03-05 Thread Wei Yang
By using utilities in bitops and bitmap, this patch tries to make it more friendly to audience. No functional change. Signed-off-by: Wei Yang <richard.weiy...@gmail.com> --- kvm-all.c | 34 ++ 1 file changed, 10 insertions(+), 24 deletions(-) diff --git

[Qemu-devel] [PATCH] bitmap: refine and move BITMAP_{FIRST/LAST}_WORD_MASK

2016-03-05 Thread Wei Yang
According to linux kernel commit <89c1e79eb30> ("linux/bitmap.h: improve BITMAP_{LAST,FIRST}_WORD_MASK"), these two macro could be improved. This patch takes this change and also move them all in header file. Signed-off-by: Wei Yang <richard.weiy...@gmail.com> --- inc

Re: [Qemu-devel] [PATCH 2/2] s390x/pci: use PCI_MSIX_FLAGS on retrieving the MSIX entries

2016-02-24 Thread Wei Yang
On Wed, Feb 24, 2016 at 10:40:15AM +0100, Cornelia Huck wrote: >On Fri, 19 Feb 2016 15:18:11 +0000 >Wei Yang <richard.weiy...@gmail.com> wrote: > >> Even PCI_CAP_FLAGS has the same value as PCI_MSIX_FLAGS, the later one is >> the more proper on retrieving MSIX entr

Re: [Qemu-devel] [PATCH 2/2] s390x/pci: use PCI_MSIX_FLAGS on retrieving the MSIX entries

2016-02-23 Thread Wei Yang
On Tue, Feb 23, 2016 at 02:17:11PM +0800, Yi Min Zhao wrote: >于 Mon, 22 Feb 2016 14:15:07 +0100 >Christian Borntraeger <borntrae...@de.ibm.com> 写道: > >> On 02/19/2016 04:18 PM, Wei Yang wrote: >> > Even PCI_CAP_FLAGS has the same value as PCI_MSIX_FLAGS, the lat

Re: [Qemu-devel] [PATCH] migration: reorder code to make it symmetric

2016-02-19 Thread Wei Yang
Hi, Amit Do you like this one? On Thu, Feb 04, 2016 at 10:50:30PM +, Wei Yang wrote: >In qemu_savevm_state_complete_precopy(), it iterates on each device to add >a json object and transfer related status to destination, while the order >of the last two steps could be refined. &

Re: [Qemu-devel] [PATCH 1/2] vfio/pci: use PCI_MSIX_FLAGS on retrieving the MSIX entries

2016-02-19 Thread Wei Yang
On Fri, Feb 19, 2016 at 09:45:32AM -0700, Alex Williamson wrote: >On Fri, 19 Feb 2016 15:18:10 +0000 >Wei Yang <richard.weiy...@gmail.com> wrote: > >> Even PCI_CAP_FLAGS has the same value as PCI_MSIX_FLAGS, the later one is >> the more proper on retrieving MSIX entr

[Qemu-devel] [PATCH 2/2] s390x/pci: use PCI_MSIX_FLAGS on retrieving the MSIX entries

2016-02-19 Thread Wei Yang
Even PCI_CAP_FLAGS has the same value as PCI_MSIX_FLAGS, the later one is the more proper on retrieving MSIX entries. This patch uses PCI_MSIX_FLAGS to retrieve the MSIX entries. Signed-off-by: Wei Yang <richard.weiy...@gmail.com> CC: Cornelia Huck <cornelia.h...@de.ibm.com> C

[Qemu-devel] [PATCH 1/2] vfio/pci: use PCI_MSIX_FLAGS on retrieving the MSIX entries

2016-02-19 Thread Wei Yang
Even PCI_CAP_FLAGS has the same value as PCI_MSIX_FLAGS, the later one is the more proper on retrieving MSIX entries. This patch uses PCI_MSIX_FLAGS to retrieve the MSIX entries. Signed-off-by: Wei Yang <richard.weiy...@gmail.com> --- hw/vfio/pci.c |2 +- 1 file changed, 1 insertion

[Qemu-devel] [PATCH 0/2] use PCI_MSIX_FLAGS on retrieving the MSIX entries

2016-02-19 Thread Wei Yang
These two patches replace the PCI_CAP_FLAGS with PCI_MSIX_FLAGS on retrieving the MSIX entries. The change is the same, while I put them in two patches for different author to review. Wei Yang (2): vfio/pci: use PCI_MSIX_FLAGS on retrieving the MSIX entries s390x/pci: use PCI_MSIX_FLAGS

Re: [Qemu-devel] [PATCH] migration: reorder code to make it symmetric

2016-02-10 Thread Wei Yang
Hello everyone, Is this one correct? On Thu, Feb 04, 2016 at 10:50:30PM +, Wei Yang wrote: >In qemu_savevm_state_complete_precopy(), it iterates on each device to add >a json object and transfer related status to destination, while the order >of the last two steps could b

[Qemu-devel] [PATCH] vfio/pci: replace 1 with PCI_CAP_LIST_NEXT to make code self-explain

2016-02-10 Thread Wei Yang
Use the macro PCI_CAP_LIST_NEXT instead of 1, so that the code would be more self-explain. This patch makes this change and also fixs one typo in comment. Signed-off-by: Wei Yang <richard.weiy...@gmail.com> --- hw/vfio/pci.c | 8 1 file changed, 4 insertions(+), 4 deletions(-)

[Qemu-devel] [PATCH] migration: reorder code to make it symmetric

2016-02-04 Thread Wei Yang
() json_end_object() save_section_footer() After the change: json_start_object() save_section_header() vmstate_save() save_section_footer() json_end_object() This patch reorder the code to to make it symmetric. No functional change. Signed-off-by: Wei Yang <richard.w

Re: [Qemu-devel] [PATCH 2/2] qmp-spec: fix index in doc

2016-02-01 Thread Wei Yang
On Sat, Jan 30, 2016 at 12:46:58PM +0300, Michael Tokarev wrote: >24.01.2016 17:09, Wei Yang wrote: >> The index is duplicated. Just change it. > >It is indeed, with previous being 2.5 as well >and the next being 3. Applying to -trivial. > >Please the next time se

Re: [Qemu-devel] [PATCH 1/2] rdma: remove check on time_spent when calculating mbs

2016-02-01 Thread Wei Yang
On Sat, Jan 30, 2016 at 12:45:27PM +0300, Michael Tokarev wrote: >24.01.2016 17:09, Wei Yang wrote: >> Within the if statement, time_spent is assured to be non-zero. >> >> This patch just removes the check on time_spent when calculating mbs. > >T

Re: [Qemu-devel] [PULL 9/9] kvm: shorten the parameter list for get_real_device()

2013-08-23 Thread Wei Yang
Paolo, Is it necessary to add this? From: Wei Yang weiy...@linux.vnet.ibm.com On Fri, Aug 23, 2013 at 11:03:35AM +0200, Paolo Bonzini wrote: get_real_device() has 5 parameters with the last 4 is contained in the first structure. This patch removes the last 4 parameters and directly use them

Re: [Qemu-devel] [PULL 9/9] kvm: shorten the parameter list for get_real_device()

2013-08-23 Thread Wei Yang
Paolo, Sorry, maybe I am not familiar with the patch format in qemu-dev. I didn't see the From: Wei Yang in this one neither. On Fri, Aug 23, 2013 at 11:39:53AM +0200, Paolo Bonzini wrote: get_real_device() has 5 parameters with the last 4 is contained in the first structure. This patch

[Qemu-devel] [PATCH] kvm: shoten the parameter list for get_real_device()

2013-08-18 Thread Wei Yang
get_real_device() has 5 parameters with the last 4 is contained in the first structure. This patch removes the last 4 parameters and directly use them from the first parameter. Signed-off-by: Wei Yang weiy...@linux.vnet.ibm.com --- hw/i386/kvm/pci-assign.c |9 - 1 files changed, 4

[Qemu-devel] one question on the makefile

2012-06-12 Thread Wei Yang
All, I saw a makefile rule which confused. This is in the tests/Makefile .PHONY: $(patsubst %, check-qtest-%, $(QTEST_TARGETS)) $(patsubst %, check-qtest-%, $(QTEST_TARGETS)): check-qtest-%: $(check-qtest-y) $(call quiet-command,QTEST_QEMU_BINARY=$*-softmmu/qemu-system-$* \

Re: [Qemu-devel] Failed to set a breakpoint on start_kernel

2012-03-17 Thread Wei Yang
2012/3/17 Jan Kiszka jan.kis...@web.de: [ re-added qemu-devel to CC ] On 2012-03-17 13:10, Wei Yang wrote: Two major issues with this procedure: 1. When using kvm, a soft breakpoint (as set by 'b') will inject a trap instruction into the guest image - which is not yet loaded after the bios

Re: [Qemu-devel] Failed to set a breakpoint on start_kernel

2012-03-17 Thread Wei Yang
You can also try my patch : http://patchwork.ozlabs.org/patch/137543/ Unless there is a use case beyond this x86 band-aid, lets focus on getting gdb right. Reminds me that gdb folks asked me to file a bug about this - which I still need to do. :-/ Jan Jan, I didn't try your patch yet.

[Qemu-devel] Failed to set a breakpoint on start_kernel

2012-03-15 Thread Wei Yang
Then the guest will run very happily Also use the info b could show the break point is set. Which step I made a mistake? -- Wei Yang Help You, Help Me

[Qemu-devel] In OHCI the HC will sent packet to each attached port?

2012-02-19 Thread Wei Yang
All In function ohci_service_td() , there is a loop. for (i = 0; i ohci-num_ports; i++) { dev = ohci-rhport[i].port.dev; if ((ohci-rhport[i].ctrl OHCI_PORT_PES) == 0) continue; if (ohci-async_td) { /* ??? The hardware

[Qemu-devel] Curious about this code in the ohci_service_td()

2012-02-18 Thread Wei Yang
I am reading the code in ohci_service_td(). There is a calculation of the length of the buffer. if ((td.cbp 0xf000) != (td.be 0xf000)) { len = (td.be 0xfff) + 0x1001 - (td.cbp 0xfff); } else { len = (td.be - td.cbp) + 1; } I am curious

Re: [Qemu-devel] Curious about this code in the ohci_service_td()

2012-02-18 Thread Wei Yang
2012/2/19 Peter Maydell peter.mayd...@linaro.org: On 18 February 2012 16:19, Wei Yang weiyang.ker...@gmail.com wrote: I am reading the code in ohci_service_td(). There is a calculation of the length of the buffer.        if ((td.cbp 0xf000) != (td.be 0xf000)) {            len

[Qemu-devel] how could I analysis the trace log?

2012-02-12 Thread Wei Yang
All I enable the trace function with --enable-trace-backend=simple and I create the event file like this g_realloc g_malloc Then I start the qemu with following command. ./i386-softmmu/qemu-system-i386 -enable-kvm -drive file=../../kvm/ubuntu.img -boot dc -m 512 -usb -monitor stdio -trace

Re: [Qemu-devel] How to follow a child process created in the guest OS?

2012-02-12 Thread Wei Yang
2012/2/11 malc av1...@comtv.ru: On Sat, 11 Feb 2012, Andreas F?rber wrote: Am 10.02.2012 11:26, schrieb ???: On Fri, Feb 10, 2012 at 08:14:41AM +, Stefan Hajnoczi wrote: On Thu, Feb 09, 2012 at 06:33:16PM +0800, ??? wrote: I am running a tiny OS on QEMU and debugging it with gdbstub.

Re: [Qemu-devel] how could I analysis the trace log?

2012-02-12 Thread Wei Yang
Hi, this kind of trace is not popular? 2012/2/12 Wei Yang weiyang.ker...@gmail.com: All I enable the trace function with --enable-trace-backend=simple and I create the event file like this g_realloc g_malloc Then I start the qemu with following command. ./i386-softmmu/qemu-system-i386

[Qemu-devel] [PATCH] This patch is used to move some struct definition, like QEMUTimer, QEMUClock, from .c to .h.

2012-02-02 Thread Wei Yang
Tested on i386 platform. Signed-off-by: Wei Yangweiy...@linux.vnet.ibm.com --- qemu-timer.c | 40 qemu-timer.h | 41 + 2 files changed, 41 insertions(+), 40 deletions(-) diff --git a/qemu-timer.c b/qemu-timer.c

<    3   4   5   6   7   8