Public bug reported:
While running the acceptance tests on s390x, the arm tests under
qemu/tests/acceptance/boot_linux_console.py will timeout, except the
test using u-boot. All the arm tests run without problems on x86 and
ppc.
This test boots the kernel and wait for a kernel panic to make sure
sole=ttyS0'
> + self.vm.add_args('-kernel', kbuild.vmlinux,
> + '-append', kernel_command_line)
> +self.vm.launch()
> +wait_for_console_pattern(self, 'Kernel command line: %s' %
> + kernel_command_line)
> --
> 2.21.0
>
Tested-by: Willian Rampazzo
On Mon, Nov 25, 2019 at 3:10 PM Cleber Rosa wrote:
>
> On Mon, Nov 25, 2019 at 10:58:02AM -0300, Eduardo Habkost wrote:
> > Thank you, Philippe, those are great ideas. I have copied them
> > to the Avocado+QEMU Trello board so we don't forget about them:
> >
'/l/linux/kernel-image-5.3.0-1-m68k-di_5.3.7-1_m68k.udeb')
> deb_hash = '044954bb9be4160a3ce81f8bc1b5e856b75cccd1'
> try:
Tested-by: Willian Rampazzo
The code was tested and works as expected.
---
Willian
> '/boot/vmlinux-5.3.0-1-m68k')
>
Tested-by: Willian Rampazzo
Although I prefer to be on the safe side and keep the verification,
the code works as expected.
---
Willian
> That certainly sounds like an improvement. I still don't love the
> idea that the test results will vary based on something outside of the
> tested code, even if a cancel is definitely better than a fail.
During the development of Avocado release 76.0, we have discussed how
to implement a new
:return: IP addresses as a list, otherwise will return False
> +"""
> +local = LocalHost()
> + network_in = NetworkInterface(interface, local)
> +try:
> +ip = network_in.get_ipaddrs()
> +if ip:
> +return ip
> +except:
> +pass
> +return False
>
>
> class Migration(Test):
> --
> 2.21.1
>
>
Reviewed-by: Willian Rampazzo
iface = get_interface_rdma()
> +ip = get_ip_rdma(iface)
> +if ip:
> +free_port = self._get_free_port(address=ip[0])
> +else:
> +self.cancel("Ip address doesn't configured properly on
> interface:%s" % iface)
> + dest_u
etwork.find_free_port()
> +def _get_free_port(self, address='localhost'):
> +port = network.find_free_port(address=address)
> if port is None:
> self.cancel('Failed to find a free port')
> return port
> --
> 2.21.1
>
>
Reviewed-by: Willian Rampazzo
wnloaded from the mirror. I cannot
> judge the mirror is more reliable than ftp.boulder.ibm.com or not, though.
>
During the tests I did to debug Avocado I constantly got a timeout on
FTP. The HTTP URL seems to be more reliable. So far,
Tested-by: Willian Rampazzo
Reviewed-by: W
On Mon, Apr 6, 2020 at 12:39 PM Philippe Mathieu-Daudé
wrote:
>
> On 4/6/20 5:31 PM, Alex Bennée wrote:
> >
> > Philippe Mathieu-Daudé writes:
> >
> >> Signed-off-by: Philippe Mathieu-Daudé
> >> ---
> >> .travis.yml | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff
On Mon, Apr 6, 2020 at 3:21 PM Alex Bennée wrote:
>
>
> Willian Rampazzo writes:
>
> > On Mon, Apr 6, 2020 at 12:39 PM Philippe Mathieu-Daudé
> > wrote:
> >>
> >> On 4/6/20 5:31 PM, Alex Bennée wrote:
> >> >
> >> > Philippe Mat
On Mon, Apr 6, 2020 at 12:41 PM Alex Bennée wrote:
>
>
> Philippe Mathieu-Daudé writes:
>
> > Signed-off-by: Philippe Mathieu-Daudé
> > ---
> > tests/Makefile.include | 7 +++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/tests/Makefile.include b/tests/Makefile.include
> > index
On Thu, Apr 2, 2020 at 8:08 AM Philippe Mathieu-Daudé wrote:
>
> This issue persists, OTOH the good news is caching is working:
>
> https://travis-ci.org/github/philmd/qemu/builds/670078763#L1626
>
Philippe, do you have a way to clean up the Travis cache and try it
again? Last week, when I was
On Wed, Apr 1, 2020 at 5:21 PM Philippe Mathieu-Daudé wrote:
> Odd, with avocado-framework==76.0 I get:
>
> https://travis-ci.org/github/philmd/qemu/jobs/669851870#L4908
>
> Traceback (most recent call last):
>File "/usr/lib/python3.6/runpy.py", line 193, in _run_module_as_main
>
On Tue, Mar 31, 2020 at 5:07 PM Philippe Mathieu-Daudé
wrote:
>
> First job failed by timeout, 2nd succeeded:
> https://travis-ci.org/github/philmd/qemu/jobs/669265466
>
> However "Ran for 46 min 48 sec"
>
> From the log:
>
> Fetching asset from
>
OT_AVAILABLE)
> +self.vm.add_args("-accel", "kvm")
> +self.vm.add_args("-cpu", "host")
> +self.vm.add_args("-machine", "virt,gic-version=2")
> +self.add_common_args()
> + self.launch_an
+ $(call quiet-command, \
> + $(TESTS_VENV_DIR)/bin/python -m avocado vmimage get \
> + --distro=fedora --distro-version=31 --arch=$*)
> +
> +# download all vm images, according to defined targets
> +get-vm-images: $(check-venv) $(patsubst %
port = network.find_free_port()
> +def _get_free_port(self, address='localhost'):
> +port = network.find_free_port(address=address)
> if port is None:
> self.cancel('Failed to find a free port')
> return port
> --
> 2.21.1
>
>
Reviewed-by: Willian Rampazzo
Hi Oksana,
On Fri, Mar 20, 2020 at 12:16 PM Oksana Vohchana wrote:
>
> Adds test for RDMA migration check
>
> Signed-off-by: Oksana Vohchana
> ---
> tests/acceptance/migration.py | 12
> 1 file changed, 12 insertions(+)
>
> diff --git a/tests/acceptance/migration.py
Hi Oksana,
On Fri, Mar 20, 2020 at 12:15 PM Oksana Vohchana wrote:
>
> Provides new functions related to the rdma migration test
> Adds functions to check if service RDMA is enabled and gets
> the ip address on the interface where it was configured
>
> Signed-off-by: Oksana Vohchana
> ---
>
port = network.find_free_port()
> +def _get_free_port(self, address='localhost'):
> +port = network.find_free_port(address=address)
> if port is None:
> self.cancel('Failed to find a free port')
> return port
> --
> 2.21.1
>
Just confirming,
Reviewed-by: Willian Rampazzo
e per line, to be installed
> # in the tests/venv Python virtual environment. For more info,
> # refer to: https://pip.pypa.io/en/stable/user_guide/#id1
> -avocado-framework==76.0
> +avocado-framework==81.0
> pycdlib==1.9.0
>
Reviewed-by: Willian Rampazzo
algorithm='sha256')
> +image_path = archive.extract(image_path_xz, self.workdir)
> image_pow2ceil_expand(image_path)
>
> self.vm.set_console()
> --
> 2.25.4
>
Except for the subject and description seaming a bit confusing as
pointed by Philippe, the changes look good to me.
Reviewed-by: Willian Rampazzo
self.do_test_advcal_2018(file_path, 'uImage', ('-cpu', 'e5500'))
>
> def test_ppc_g3beige(self):
> @@ -260,7 +271,8 @@ class ReplayKernel(LinuxKernelTest):
> tar_hash = 'e0b872a5eb8fdc5bed19bd43ffe863900ebcedfc'
> tar_url = ('https://www.qemu-advent-calendar.org'
> '/2018/download/day15.tar.xz')
> -file_path = self.fetch_asset(tar_url, asset_hash=tar_hash)
> +file_path = self.fetch_asset(tar_url, asset_hash=tar_hash,
> + cancel_on_missing=True)
> self.do_test_advcal_2018(file_path, 'invaders.elf',
> args=('-M', 'graphics=off'))
>
> @@ -272,7 +284,8 @@ class ReplayKernel(LinuxKernelTest):
> tar_hash = 'e0b872a5eb8fdc5bed19bd43ffe863900ebcedfc'
> tar_url = ('https://www.qemu-advent-calendar.org'
> '/2018/download/day15.tar.xz')
> -file_path = self.fetch_asset(tar_url, asset_hash=tar_hash)
> +file_path = self.fetch_asset(tar_url, asset_hash=tar_hash,
> + cancel_on_missing=True)
> self.do_test_advcal_2018(file_path, 'invaders.elf',
> args=('-M', 'graphics=off'))
>
> @@ -284,7 +297,8 @@ class ReplayKernel(LinuxKernelTest):
> tar_hash = 'b18550d5d61c7615d989a06edace051017726a9f'
> tar_url = ('https://www.qemu-advent-calendar.org'
> '/2018/download/day11.tar.xz')
> -file_path = self.fetch_asset(tar_url, asset_hash=tar_hash)
> +file_path = self.fetch_asset(tar_url, asset_hash=tar_hash,
> + cancel_on_missing=True)
> self.do_test_advcal_2018(file_path, 'zImage.elf')
>
> def test_xtensa_lx60(self):
> @@ -296,6 +310,7 @@ class ReplayKernel(LinuxKernelTest):
> tar_hash = '49e88d9933742f0164b60839886c9739cb7a0d34'
> tar_url = ('https://www.qemu-advent-calendar.org'
> '/2018/download/day02.tar.xz')
> -file_path = self.fetch_asset(tar_url, asset_hash=tar_hash)
> +file_path = self.fetch_asset(tar_url, asset_hash=tar_hash,
> + cancel_on_missing=True)
> self.do_test_advcal_2018(file_path, 'santas-sleigh-ride.elf',
> args=('-cpu', 'dc233c'))
> --
> 2.25.4
>
Reviewed-by: Willian Rampazzo
h)
>
> -def prepare_cloudinit(self):
> -cloudinit_iso = self.download_cloudinit()
> +def prepare_cloudinit(self, ssh_pubkey=None):
> +cloudinit_iso = self.download_cloudinit(ssh_pubkey)
> self.vm.add_args('-drive', 'file=%s,format=raw' % cloudinit_iso)
>
> def launch_and_wait(self):
> --
> 2.26.2
>
>
Reviewed-by: WIllian Rampazzo
"""
> U-Boot and checks that the console is operational.
> --
> 2.20.1
>
>
Reviewed-by: Willian Rampazzo
> +self.assertEquals(self.vm.exitcode(), 1, "QEMU exit code should be
> 1")
> +self.assertRegex(self.vm.get_log(),
> + r'Invalid CPU topology: dies must be 1 or greater')
> +
> +def test_valid(self):
> + self.vm.add_args('-S', '-display', 'none', '-smp', '1,dies=1')
> +self.vm.launch()
> +self.vm.command('quit')
> +self.vm.wait()
> +self.assertEquals(self.vm.exitcode(), 0, "QEMU exit code should be
> 0")
> --
> 2.25.4
>
Reviewed-by: Willian Rampazzo
59 100644
> --- a/tests/requirements.txt
> +++ b/tests/requirements.txt
> @@ -2,4 +2,4 @@
> # in the tests/venv Python virtual environment. For more info,
> # refer to: https://pip.pypa.io/en/stable/user_guide/#id1
> avocado-framework==81.0
> -pycdlib==1.9.0
> +pycdlib==1.11.0
> --
> 2.25.4
>
Reviewed-by: Willian Rampazzo
> +# start with BIOS only
> +self.reverse_debugging()
> +
> +class ReverseDebugging_AArch64(ReverseDebugging):
> +REG_PC = 32
> +
> +# unidentified gitlab timeout problem
> +@skipIf(os.getenv('GITLAB_CI'), 'Running on GitLab')
> +def test_aarch64_virt(self):
> +"""
> +:avocado: tags=arch:aarch64
> +:avocado: tags=machine:virt
> +:avocado: tags=cpu:cortex-a53
> +"""
> +kernel_url = ('https://archives.fedoraproject.org/pub/archive/fedora'
> +
> '/linux/releases/29/Everything/aarch64/os/images/pxeboot'
> + '/vmlinuz')
> +kernel_hash = '8c73e469fc6ea06a58dc83a628fc695b693b8493'
> +kernel_path = self.fetch_asset(kernel_url, asset_hash=kernel_hash)
> +
> +self.reverse_debugging(
> +args=('-kernel', kernel_path, '-cpu', 'cortex-a53'))
>
The code looks good to me!
Reviewed-by: Willian Rampazzo
if not kvm_available(self.arch, self.qemu_bin):
> +self.cancel(KVM_NOT_AVAILABLE)
> +self.vm.add_args("-accel", "kvm")
> + self.vm.add_args("-cpu", "host")
> +self.vm.add_args("-machine", "virt,gic-version=3")
> +self.add_common_args()
> +self.launch_and_wait()
> +
>
> class BootLinuxPPC64(BootLinux):
> """
> --
> 2.26.2
>
Reviewed-by: Willian Rampazzo
t; +++ b/tests/acceptance/replay_kernel.py
> @@ -127,6 +127,8 @@ def test_arm_virt(self):
> self.run_rr(kernel_path, kernel_command_line, console_pattern,
> shift=1)
>
> @skipIf(os.getenv('GITLAB_CI'), 'Running on GitLab')
> +@skipUnless(os.getenv('ARMBIAN_ARTIFACTS_CACHED'),
> +'Test artifacts fetched from unreliable apt.armbian.com')
> def test_arm_cubieboard_initrd(self):
> """
> :avocado: tags=arch:arm
> --
> 2.26.2
>
>
Reviewed-by: Willian Rampazzo
til_pattern(self,
> +
> interrupt_string='root\r',
> + success_message='#')
> +pattern = '3 packets transmitted, 3 packets received, 0% packet loss'
> +exec_command_and_wait_for_pattern(self, 'ping -c 3 10.0.2.2',
> pattern)
> --
> 2.26.2
>
>
IMHO, although the solution of spreading images over personal
repositories is not the best, I don't have a strong opinion to block
this, so
Reviewed-by: Willian Rampazzo (willi...@redhat.com)
; > VM as a parameter to interact with it.
> >
> > Signed-off-by: Pavel Dovgalyuk
> > Reviewed-by: Willian Rampazzo
> > ---
> > 0 files changed
> >
> > diff --git a/tests/acceptance/avocado_qemu/__init__.py
> > b/tests/acceptance/avocado_qemu/__init__.py
>
On Mon, May 25, 2020 at 8:28 AM Pavel Dovgalyuk
wrote:
>
> This patch adds more record/replay tests with kernel images.
>
> Signed-off-by: Pavel Dovgalyuk
> ---
> tests/acceptance/replay_kernel.py | 80
> +
> 1 file changed, 80 insertions(+)
>
> diff --git
On Mon, May 25, 2020 at 8:22 AM Pavel Dovgalyuk
wrote:
>
> This patch adds a base for testing kernel boot recording and replaying.
> Each test has the phase of recording and phase of replaying.
> Virtual machines just boot the kernel and do not interact with
> the network.
> Structure and image
"""
> -_console_interaction(test, success_message, failure_message, None)
> +_console_interaction(test, success_message, failure_message, None, vm=vm)
>
> def exec_command_and_wait_for_pattern(test, command,
>success_message, failure_message=None):
>
>
Reviewed-by: Willian Rampazzo
On Mon, May 25, 2020 at 8:30 AM Pavel Dovgalyuk
wrote:
>
> This patch adds a test for record/replay, which boots Linux
> image from the disk and interacts with the network.
> The idea and code of this test is borrowed from boot_linux.py
> However, currently record/replay works only for x86_64,
>
On Mon, May 25, 2020 at 8:30 AM Pavel Dovgalyuk
wrote:
>
> This patch adds a test for record/replay, which boots Linux
> image from the disk and interacts with the network.
> The idea and code of this test is borrowed from boot_linux.py
> However, currently record/replay works only for x86_64,
>
self):
> """
> :avocado: tags=arch:arm
> --
> 2.26.2
>
>
At least, this time, skipUnless is already there :D
Reviewed-by: Willian Rampazzo
On Fri, Jul 24, 2020 at 3:26 PM Wainer dos Santos Moschetta
wrote:
>
> Hi Philippe,
>
> On 7/24/20 4:35 AM, Philippe Mathieu-Daudé wrote:
> > The boot_linux.py file triggers an exception:
> >
> >$ make fetch-acceptance
> >AVOCADO tests/acceptance
> >Fetching assets from
On Thu, Dec 3, 2020 at 2:30 PM Cleber Rosa wrote:
>
> On Thu, Dec 03, 2020 at 05:02:33PM +, Daniel P. Berrangé wrote:
> > I think the problem with the Fedora acceptance is that we'll be constantly
> > chasing a moving target. Every URL we pick will go away 6-12 months later.
> > IOW, while
On Mon, Dec 7, 2020 at 5:10 PM Alex Bennée wrote:
>
> While attempting to debug some console weirdness I thought it would be
> worth making it easier to see what it had inside.
>
> Signed-off-by: Alex Bennée
> ---
> python/qemu/console_socket.py | 8
> 1 file changed, 8 insertions(+)
>
Em seg, 7 de dez de 2020 19:14, Philippe Mathieu-Daudé
escreveu:
> Hi Willian,
>
> On 12/7/20 10:35 PM, Willian Rampazzo wrote:
> > On Mon, Dec 7, 2020 at 5:10 PM Alex Bennée
> wrote:
> >>
> >> While attempting to debug some console weirdness I thought it
\w+'.format(prop) for prop in props]
> @@ -117,7 +123,6 @@ def seg_max_adjust_enabled(mt):
> return True
> return False
>
> -@skip("break multi-arch CI")
> def test_machine_types(self):
> # collect all machine types except 'none', 'isapc', 'microvm'
> with QEMUMachine(self.qemu_bin) as vm:
> --
> 2.26.2
>
>
Reviewed-by: Willian Rampazzo
eptance_test_job
> +integration-system-centos:
> + extends: .integration_test_job
>needs:
> - job: build-system-centos
>artifacts: true
> --
> 2.26.2
>
>
Makes sense, thanks!
Reviewed-by: Willian Rampazzo
python/qemu/machine.py| 2 +-
> tests/acceptance/avocado_qemu/__init__.py | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
Reviewed-by: Willian Rampazzo
|
CANCEL 0
JOB TIME : 7.18 s
Tested-by: Willian Rampazzo
Reviewed-by: Willian Rampazzo
On Fri, Nov 27, 2020 at 2:41 PM Philippe Mathieu-Daudé
wrote:
>
> We lately realized that the Avocado framework was not designed
> to be regularly run on CI environments. Therefore, as of 5.2
> we deprecate the gitlab-ci jobs using Avocado. To not disrupt
> current users, it is possible to keep
---
> .gitlab-ci.yml | 4
> 1 file changed, 4 insertions(+)
>
Reviewed-by: Willian Rampazzo
On Sat, Dec 12, 2020 at 4:15 AM Thomas Huth wrote:
>
> On 11/12/2020 21.10, Willian Rampazzo wrote:
> > On 12/11/20 2:31 PM, Thomas Huth wrote:
> >> Add two more simple tests to check that virtio-rng and virtio-balloon
> >> are at least (very) basically wor
On Mon, Dec 14, 2020 at 8:39 AM Cornelia Huck wrote:
>
> On Sat, 12 Dec 2020 08:15:13 +0100
> Thomas Huth wrote:
>
> > On 11/12/2020 21.10, Willian Rampazzo wrote:
> > > On 12/11/20 2:31 PM, Thomas Huth wrote:
> > >> Add two more simple tests to c
On Sat, Dec 19, 2020 at 4:30 AM Jiaxun Yang wrote:
>
> The kernel comes from debian archive so it's trusted.
>
> Signed-off-by: Jiaxun Yang
> ---
> tests/acceptance/boot_linux_console.py | 21 +
> 1 file changed, 21 insertions(+)
>
Reviewed-by: Willian Rampazzo
ATCH 1/3] tests/acceptance: Extract the code to
clear dmesg and wait for CRW reports" defined the method as
"clear_guests_dmesg". After fixing this in the code:
Tested-by: Willian Rampazzo
+self.vm.command('object-add', qom_type='cryptodev-backend-builtin',
+
wait_for_console_pattern(self, 'godson2 caches found')
Inspite of a small comment,
Reviewed-by: Willian Rampazzo
insertion(+), 1 deletion(-)
>
Reviewed-by: Willian Rampazzo
---
.gitlab-ci.yml | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Willian Rampazzo
s fix
>
> https://gitlab.com/berrange/qemu/-/jobs/915862731
>
> tests/docker/dockerfiles/centos8.docker | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Willian Rampazzo
On Mon, Dec 21, 2020 at 10:00 AM Cornelia Huck wrote:
>
> On Fri, 18 Dec 2020 15:23:32 -0300
> Willian Rampazzo wrote:
>
> > On 12/17/20 5:53 AM, Thomas Huth wrote:
>
> > > +# Hot-plug a virtio-crypto device and see whether it gets
> > > accepte
ust to be sure
>
> tests/acceptance/machine_s390_ccw_virtio.py | 110
> 1 file changed, 110 insertions(+)
>
Reviewed-by: Willian Rampazzo
Tested-by: Willian Rampazzo
AVOCADO tests/acceptance
Fetching asset from
tests/acceptance/machine_s390_ccw_virtio.py:S390CCWVirtioMach
that after the whole series is merged.
As far as code concerned,
Reviewed-by: Willian Rampazzo
Tested-by: Willian Rampazzo
Fetching asset from
tests/acceptance/machine_s390_ccw_virtio.py:S390CCWVirtioMachine.test_s390x_devices
Fetching asset from
tests/acceptance
owever short of cleaning up the test to be more binary focused at
> least limit the attempt to dump the whole file as hexified zeros in
> the logs.
>
> Signed-off-by: Alex Bennée
> ---
> tests/acceptance/machine_s390_ccw_virtio.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Willian Rampazzo
target only,
> since that has very few machine types and thus is least badly
> impacted in the qom-test execution.
>
> With this change, the macOS jobs complete in approx 35 minutes.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> .cirrus.yml | 14 ++
> 1 file changed, 10 insertions(+), 4 deletions(-)
>
Reviewed-by: Willian Rampazzo
console: / # reboot
> console: / # umount: devtmpfs busy - remounted read-only
> console: EXT4-fs (sda): re-mounted. Opts: (null)
> console: The system is going down NOW!
> console: Sent SIGTERM to all processes
> console: Sent SIGKILL to all processes
> console: Requesting system reboot
> console: sd 0:0:0:0: [sda] Synchronizing SCSI cache
> console: reboot: Restarting system
> PASS (8.44 s)
> RESULTS: PASS 1 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 |
> CANCEL 0
> JOB TIME : 8.85 s
>
> [*] https://github.com/groeck/linux-build-test/
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> Cc: Guenter Roeck
> ---
> tests/acceptance/boot_linux_console.py | 30 --
> 1 file changed, 28 insertions(+), 2 deletions(-)
>
Reviewed-by: Willian Rampazzo
gt; tests/acceptance/machine_s390_ccw_virtio.py | 14 ++++--
> 1 file changed, 12 insertions(+), 2 deletions(-)
>
Reviewed-by: Willian Rampazzo
Tested-by: Willian Rampazzo
JOB ID : 6b2b3c1f6f6b0c4c2e9fd694b475bd12c193adbd
JOB LOG:
/home/linux1/src/qemu.d
On Tue, Jan 12, 2021 at 10:53 AM Philippe Mathieu-Daudé
wrote:
>
...
> We explained this feature request to the Avocado project at the
> KVM forum 2018 in Lyon. There was an entry filled on their Trello
> dashboard. Then the project switched to GitLab and I lost track
> of it.
We moved our
On Thu, Jan 14, 2021 at 2:41 PM Alex Bennée wrote:
>
> For prettier output.
>
> Signed-off-by: Alex Bennée
> ---
> Makefile | 9 +++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
Reviewed-by: Willian Rampazzo
part of mypy/pylint cleanup? It seems you are doing more
than that here. It would be good to have this listed in the commit
message. Despite that,
Reviewed-by: Willian Rampazzo
> '151', '152', '155', '163', '165', '169', '194', '196', '199', '202',
> '203', '205', '206', '207', '208', '210', '211', '212', '213', '216',
> '218', '219', '222', '224', '228', '234', '235', '236', '237', '238',
> --
> 2.29.2
>
>
Avocado-QEMU Trello board missing in my previous mail.
On Thu, Jan 14, 2021 at 4:13 PM Willian Rampazzo wrote:
>
> On Tue, Jan 12, 2021 at 10:53 AM Philippe Mathieu-Daudé
> wrote:
> >
> ...
> > We explained this feature request to the Avocado project at the
&g
| 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Reviewed-by: Willian Rampazzo
ff-by: Alex Bennée
> ---
> scripts/checkpatch.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Willian Rampazzo
uot;)
> Signed-off-by: Philippe Mathieu-Daudé
> Message-Id: <20210107072933.3828450-1-f4...@amsat.org>
> Signed-off-by: Alex Bennée
> Reviewed-by: Thomas Huth
> ---
> tests/docker/Makefile.include | 1 -
> 1 file changed, 1 deletion(-)
>
Reviewed-by: Willian Rampazzo
> ---
> .gitlab-ci.yml | 4 +++-
> .travis.yml| 9 -
> 2 files changed, 3 insertions(+), 10 deletions(-)
>
And, it helps moving out of Travis.
Reviewed-by: Willian Rampazzo
On Thu, Jan 14, 2021 at 2:29 PM Alex Bennée wrote:
>
> For prettier output.
>
> Signed-off-by: Alex Bennée
> ---
> Makefile | 14 +++---
> 1 file changed, 11 insertions(+), 3 deletions(-)
>
Reviewed-by: Willian Rampazzo
cceptance/machine_ppc.py| 34 ++
> 3 files changed, 35 insertions(+), 19 deletions(-)
> create mode 100644 tests/acceptance/machine_ppc.py
>
We can have other tests moved to this file later. For now,
Reviewed-by: Willian Rampazzo
On Thu, Jan 14, 2021 at 2:21 PM Alex Bennée wrote:
>
> For prettier output.
>
> Signed-off-by: Alex Bennée
> ---
> Makefile | 9 +++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
Reviewed-by: Willian Rampazzo
t; 2 files changed, 22 insertions(+), 22 deletions(-)
>
Reviewed-by: Willian Rampazzo
r | 5 -
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
Reviewed-by: Willian Rampazzo
On Fri, Jan 15, 2021 at 6:30 AM Max Reitz wrote:
>
> On 14.01.21 21:02, Willian Rampazzo wrote:
> > On Thu, Jan 14, 2021 at 2:41 PM Max Reitz wrote:
> >>
> >> Signed-off-by: Max Reitz
> >> ---
> >> tests/qemu-iotests/129 | 4 ++--
> >>
On Thu, Jan 14, 2021 at 2:29 PM Max Reitz wrote:
>
> Signed-off-by: Max Reitz
> Reviewed-by: Vladimir Sementsov-Ogievskiy
> Reviewed-by: Eric Blake
> ---
> tests/qemu-iotests/129 | 2 ++
> 1 file changed, 2 insertions(+)
Reviewed-by: Willian Rampazzo
Ogievskiy
> ---
> tests/qemu-iotests/129 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Willian Rampazzo
On Tue, Jan 12, 2021 at 1:44 PM Thomas Huth wrote:
>
> We can use the "Stupid creek" image to test the mpc8544ds ppc machine.
>
> Signed-off-by: Thomas Huth
> ---
> tests/acceptance/machine_ppc.py | 17 +
> 1 file changed, 17 insertions(+)
Reviewed-by: Willian Rampazzo
+
> 1 file changed, 18 insertions(+)
Reviewed-by: Willian Rampazzo
-
> 2 files changed, 16 insertions(+), 4 deletions(-)
>
Reviewed-by: Willian Rampazzo
> ---
> tests/qemu-iotests/129 | 27 +--
> 1 file changed, 25 insertions(+), 2 deletions(-)
Reviewed-by: Willian Rampazzo
Reitz
> Reviewed-by: Eric Blake
> Reviewed-by: Vladimir Sementsov-Ogievskiy
> ---
> tests/qemu-iotests/129 | 37 +
> 1 file changed, 13 insertions(+), 24 deletions(-)
Reviewed-by: Willian Rampazzo
> tests/qemu-iotests/129 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Willian Rampazzo
ged, 8 insertions(+), 11 deletions(-)
>
Reviewed-by: Willian Rampazzo
this patch wants to prevent.
>
> Signed-off-by: Max Reitz
> Reviewed-by: Vladimir Sementsov-Ogievskiy
> ---
> tests/qemu-iotests/300| 1 -
> tests/qemu-iotests/iotests.py | 26 +-
> 2 files changed, 13 insertions(+), 14 deletions(-)
>
Reviewed-by: Willian Rampazzo
> +iotests.logger.debug('Files to be checked:')
> +iotests.logger.debug(', '.join(sorted(files)))
> +
> +print('=== pylint ===')
> +sys.stdout.flush()
> +
> +# Todo notes are fine, but fixme's or xxx's should probably just be
> +# fixed (in tests, at least)
> +env = os.environ.copy()
> +try:
> +env['PYTHONPATH'] += ':../../python/'
Do you have any objection to using os.path.dirname and os.path.join
here? This would make the code more pythonic.
> +except KeyError:
> +env['PYTHONPATH'] = '../../python/'
Same here. You could do it once, before the 'try' and use it inside.
Other than that,
Reviewed-by: Willian Rampazzo
+++
> 1 file changed, 5 insertions(+)
Reviewed-by: WIllian Rampazzo
> ---
> .gitlab-ci.d/static_checks.yml | 3 ---
> .patchew.yml | 3 ---
> scripts/checkpatch.pl | 7 ++-
> 3 files changed, 6 insertions(+), 7 deletions(-)
>
Reviewed-by: Willian Rampazzo
> docs/devel/index.rst| 1 +
> 4 files changed, 44 insertions(+)
> create mode 100644 .gitlab-ci.d/custom-runners.yml
> create mode 100644 docs/devel/ci.rst
>
Reviewed-by: Willian Rampazzo
On Tue, Jun 8, 2021 at 3:48 PM Wainer dos Santos Moschetta
wrote:
>
> Hi,
>
> On 6/8/21 12:14 AM, Cleber Rosa wrote:
> > To run basic jobs on custom runners, the environment needs to be
> > properly set up. The most common requirement is having the right
> > packages installed.
> >
> > The
endency messages on the apt side. After I updated the packages on
the system, the playbook worked without problems.
So, my suggestion is to add the "update = yes" here, or add a note in
the documentation asking the user to update the system before running
the playbook.
Except for the above comment and Wainer's comments, it looks good to
me. With these changes:
Reviewed-by: Willian Rampazzo
Tested-by: Willian Rampazzo
On Tue, Jun 8, 2021 at 8:55 PM Cleber Rosa Junior wrote:
>
>
>
> On Tue, Jun 8, 2021 at 5:42 PM Wainer dos Santos Moschetta
> wrote:
>>
>> Hi,
>>
>> On 6/8/21 11:09 AM, Cleber Rosa wrote:
>> > Which can be used to check for any "feature" that is available as a
>> > QEMU command line option, and
On Tue, Jun 8, 2021 at 11:10 AM Cleber Rosa wrote:
>
> This introduces three different parts of a job designed to run
> on a custom runner managed by Red Hat. The goals include:
>
> a) serve as a model for other organizations that want to onboard
> their own runners, with their specific
ature is "machine", option can be "q35".
> +type option: str
> +"""
> +try:
> + options_available = list_feature(self.qemu_bin, feature)
Looking at this code, the previous patch makes more sense the way it is now :)
Maybe, splitting it into multiple `list_` functions will make the code
here more complex.
Anyway, I'll let you decide.
Reviewed-by: Willian Rampazzo
gh the formal method of tracking machine/job maintainers have
> not been formalized, it should be known that the contacts/admins for
> this machine and job are:
>
> - Cleber Rosa
>
>clebergnu on #qemu
>
> - Willian Rampazzo
>
>willianr on #qemu
Acked-by: Willian Rampazzo
gt; 3 files changed, 48 insertions(+), 13 deletions(-)
> create mode 100644 python/qemu/utils/feature.py
>
Based on my comments from the next patch of this series:
Reviewed-by: Willian Rampazzo
1 - 100 of 476 matches
Mail list logo
