[Qemu-devel] [PATCH] cutils: Define min and max marcos

Signed-off-by: Yuval Shaia <yuval.sh...@oracle.com> --- disas/m68k.c | 5 + include/qemu/cutils.h | 3 +++ slirp/slirp.h | 6 +- 3 files changed, 5 insertions(+), 9 deletions(-) diff --git a/disas/m68k.c b/disas/m68k.c index 8e7c3f7..7794abc 100644 --- a/disas/

[Qemu-devel] [PATCH] {disas, slirp}: Replace min/max with MIN/MAX macros

Use generic declaration of min and max macros instead of private ones. Signed-off-by: Yuval Shaia <yuval.sh...@oracle.com> --- disas/m68k.c | 4 slirp/dhcpv6.c | 2 +- slirp/ip6_icmp.c | 2 +- slirp/slirp.c | 2 +- slirp/slirp.h | 5 - slirp/tcp_input.c

Re: [Qemu-devel] [PATCH] cutils: Define min and max marcos

On Sun, Nov 27, 2016 at 03:10:04PM +0100, Samuel Thibault wrote: > Hello, > > Yuval Shaia, on Fri 25 Nov 2016 12:31:26 +0200, wrote: > > -#ifndef _WIN32 > > -#define min(x,y) ((x) < (y) ? (x) : (y)) > > -#define max(x,y) ((x) > (y) ? (x) : (y)) > > -#endif

Re: [Qemu-devel] [PATCH] cutils: Define min and max marcos

On Sun, Nov 27, 2016 at 11:20:41PM +0100, Samuel Thibault wrote: > Yuval Shaia, on Mon 28 Nov 2016 00:18:26 +0200, wrote: > > On Sun, Nov 27, 2016 at 03:10:04PM +0100, Samuel Thibault wrote: > > > Yuval Shaia, on Fri 25 Nov 2016 12:31:26 +0200, wrote: > > > > -#ifndef

[Qemu-devel] [PATCH] include: Add roundup_pow_of_two helper function

Move private implementation of rthe function to osdep.h Signed-off-by: Yuval Shaia <yuval.sh...@oracle.com> --- hw/pci/shpc.c| 12 +--- include/qemu/osdep.h | 10 ++ 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/hw/pci/shpc.c b/hw/pci/shpc.c

Re: [Qemu-devel] [PATCH] {disas, slirp}: Replace min/max with MIN/MAX macros

On Mon, Nov 28, 2016 at 08:39:21AM +0100, Markus Armbruster wrote: > The "{disas, slirp}: " prefix is unusual. Better: "disas, slirp: ". > But I'd instead split the patch into the slirp part, where you really > replace stuff, and the disas part, where you merely drop an unused macro > definition.

[Qemu-devel] [PATCH v1] slirp, disas: Replace min/max with MIN/MAX macros

Signed-off-by: Yuval Shaia <yuval.sh...@oracle.com> --- v0 -> v1: * Remove unndeeded "include" as suggested by Fam Zheng * Change commit message's prefix as suggested by Markus Armbruster * Utilize MIN macro in two extra places in file disas/m68k.

[Qemu-devel] [PATCH v2] slirp, disas: Replace min/max with MIN/MAX macros

Signed-off-by: Yuval Shaia <yuval.sh...@oracle.com> --- v0 -> v1: * Remove unndeeded "include" as suggested by Fam Zheng * Change commit message's prefix as suggested by Markus Armbruster * Utilize MIN macro in two extra places in file disas/m68k.c v1 -

Re: [Qemu-devel] [PATCH RFC] hw/pvrdma: Proposal of a new pvrdma device

On Tue, Apr 04, 2017 at 10:01:55AM -0600, Jason Gunthorpe wrote: > On Tue, Apr 04, 2017 at 04:38:40PM +0300, Marcel Apfelbaum wrote: > > > Here are some thoughts regarding the Soft RoCE usage in our project. > > We thought about using it as backend for QEMU pvrdma device > > we didn't how it will

Re: [Qemu-devel] [PATCH RFC] hw/pvrdma: Proposal of a new pvrdma device

On Tue, Apr 04, 2017 at 08:33:49PM +0300, Leon Romanovsky wrote: > > I'm not going to repeat Jason's answer, I'm completely agree with him. > > Just add my 2 cents. You didn't answer on my question about other possible > implementations. It can be SoftRoCE loopback optimizations, special ULP, >

Re: [Qemu-devel] [PATCH V2 1/5] pci/shpc: Move function to generic header file

On Sun, Dec 17, 2017 at 03:16:15PM -0300, Philippe Mathieu-Daudé wrote: > Hi Marcel, Yuval, > > On 12/17/2017 09:54 AM, Marcel Apfelbaum wrote: > > From: Yuval Shaia <yuval.sh...@oracle.com> > > > > This function should be declared in generic header file so we ca

Re: [Qemu-devel] [PATCH V2 0/5] hw/pvrdma: PVRDMA device implementation

> > > > > What happens if guest attempts to register all its memory? > > > > > > > Then we loose, is not different from bare metal, reg_mr will pin all the > > RAM. > > We need to find a way to communicate to guests about amount > of memory they can pin. dev_caps.max_mr_size is the way

Re: [Qemu-devel] [PATCH V2 4/5] pvrdma: initial implementation

ge[1].length); > > + > > +memcpy(_msg[64], hdr, sge[0].length); > > + memcpy(_msg[sge[0].length+64], msg, sge[1].length); > > + > > +pvrdma_pci_dma_unmap(pci_dev, msg, sge[1].length); > > +pvrdma_pci_dma_unmap(pci_dev, hdr, sge[0].length); > > + &g

Re: [Qemu-devel] [PATCH V2 0/5] hw/pvrdma: PVRDMA device implementation

d buffer size > > bigger than 1MB which was the line rate ~ 50Gb/s. > > The conclusion is that using the PVRDMA device there are no > > actual performance penalties compared to bare metal for big enough > > buffers (which is quite common when using RDMA), while allowing > >

[Qemu-devel] [PATCH] hw/pvrdma: Bugfix - provide the correct attr_mask to query_qp

Calling rdma_rm_query_qp with attr_mask equals to -1 leads to error where backend query_qp fails to retrieve the needed QP attributes. Fix it by providing the attr_mask we got from driver. Signed-off-by: Yuval Shaia --- hw/rdma/vmw/pvrdma_cmd.c | 5 +++-- 1 file changed, 3 insertions(+), 2

Re: [Qemu-devel] [PATCH] MAINTAINERS: update Marcel Apfelbaum email

> +M: Marcel Apfelbaum <marcel.apfelb...@gmail.com> > S: Supported > F: include/hw/pci/* > F: hw/misc/pci-testdev.c > @@ -2075,7 +2075,7 @@ F: docs/block-replication.txt > > PVRDMA > M: Yuval Shaia <yuval.sh...@oracle.com> > -M: Marcel Apfelbaum <mar...@redhat.com> > +M: Marcel Apfelbaum <marcel.apfelb...@gmail.com> :( Reviewed-by: Yuval Shaia <yuval.sh...@oracle.com> > S: Maintained > F: hw/rdma/* > F: hw/rdma/vmw/* > -- > 2.13.6 >

Re: [Qemu-devel] [PATCH PULL v2 09/10] hw/rdma: Implementation of PVRDMA device

On Fri, Apr 27, 2018 at 10:36:33PM +0300, Marcel Apfelbaum wrote: > On 27/04/2018 17:49, Peter Maydell wrote: > > On 19 February 2018 at 11:43, Marcel Apfelbaum <mar...@redhat.com> wrote: > >> From: Yuval Shaia <yuval.sh...@oracle.com> > >> > >&g

Re: [Qemu-devel] [PATCH PULL v2 09/10] hw/rdma: Implementation of PVRDMA device

On Fri, Apr 27, 2018 at 03:55:16PM +0100, Peter Maydell wrote: > On 19 February 2018 at 11:43, Marcel Apfelbaum <mar...@redhat.com> wrote: > > From: Yuval Shaia <yuval.sh...@oracle.com> > > > > PVRDMA is the QEMU implementation of VMware's paravirtualized RDMA de

Re: [Qemu-devel] [PATCH PULL v2 08/10] hw/rdma: PVRDMA commands and data-path ops

On Fri, Apr 27, 2018 at 09:20:44PM +0300, Marcel Apfelbaum wrote: > Hi Peter, > > On 27/04/2018 17:31, Peter Maydell wrote: > > On 19 February 2018 at 11:43, Marcel Apfelbaum <mar...@redhat.com> wrote: > >> From: Yuval Shaia <yuval.sh...@oracle.com&g

Re: [Qemu-devel] [PATCH V2 0/5] hw/pvrdma: PVRDMA device implementation

On Thu, Dec 21, 2017 at 10:46:35PM +0200, Michael S. Tsirkin wrote: > On Thu, Dec 21, 2017 at 05:59:38PM +0200, Marcel Apfelbaum wrote: > > On 21/12/2017 16:22, Michael S. Tsirkin wrote: > > > On Thu, Dec 21, 2017 at 09:27:51AM +0200, Yuval Shaia wrote: > > > > &

Re: [Qemu-devel] [PATCH V6 4/5] pvrdma: initial implementation

On Tue, Jan 09, 2018 at 11:39:11AM +0100, Cornelia Huck wrote: > On Sun, 7 Jan 2018 14:32:23 +0200 > Marcel Apfelbaum <mar...@redhat.com> wrote: > > > From: Yuval Shaia <yuval.sh...@oracle.com> > > > > PVRDMA is the QEMU implementation of VMware's pa

Re: [Qemu-devel] [PATCH 07/13] hw/rdma: Do not allocate memory for non-dma MR

On Tue, Jul 24, 2018 at 03:19:52PM +0300, Marcel Apfelbaum wrote: > > Hi Yuval, > > On 07/16/2018 10:40 AM, Yuval Shaia wrote: > > There is no use in the memory allocated for non-dma MR (one with > > host_virt equals to NULL). > > No need for the (one with...

[Qemu-devel] [PATCH v2 06/13] hw/rdma: Delete useless structure RdmaRmUserMR

The structure RdmaRmUserMR has no benefits, remove it an move all its fields to struct RdmaRmMR. Signed-off-by: Yuval Shaia --- hw/rdma/rdma_backend.c | 3 +-- hw/rdma/rdma_rm.c | 16 hw/rdma/rdma_rm_defs.h | 10 +++--- 3 files changed, 12 insertions(+), 17 deletions

[Qemu-devel] [PATCH v2 10/13] hw/rdma: Cosmetic change - move to generic function

To ease maintenance of struct comp_thread move all related code to dedicated function. Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum --- hw/rdma/rdma_backend.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/rdma/rdma_backend.c b/hw/rdma

[Qemu-devel] [PATCH v2 09/13] hw/pvrdma: Cosmetic change - indent right

Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum --- hw/rdma/vmw/pvrdma_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/rdma/vmw/pvrdma_main.c b/hw/rdma/vmw/pvrdma_main.c index 1b1330e113..3d448bffc4 100644 --- a/hw/rdma/vmw/pvrdma_main.c +++ b/hw/rdma

[Qemu-devel] [PATCH v2 05/13] hw/pvrdma: Make default pkey 0xFFFF

0x7FFF is not the default pkey - fix it. Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum --- hw/rdma/vmw/pvrdma.h | 3 +++ hw/rdma/vmw/pvrdma_cmd.c | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/rdma/vmw/pvrdma.h b/hw/rdma/vmw/pvrdma.h index 81e0e0e99c

[Qemu-devel] [PATCH v2 04/13] hw/pvrdma: Clean CQE before use

Next CQE is fetched from CQ ring, clean it before usage as it still carries old CQE values. Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum --- hw/rdma/vmw/pvrdma_qp_ops.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/rdma/vmw/pvrdma_qp_ops.c b/hw/rdma/vmw/pvrdma_qp_ops.c

[Qemu-devel] [PATCH v2 02/13] hw/pvrdma: Bugfix - provide the correct attr_mask to query_qp

Calling rdma_rm_query_qp with attr_mask equals to -1 leads to error where backend query_qp fails to retrieve the needed QP attributes. Fix it by providing the attr_mask we got from driver. Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum --- hw/rdma/vmw/pvrdma_cmd.c | 5 +++-- 1 file

[Qemu-devel] [PATCH v2 00/13] Misc fixes for pvrdma device

Hi, Please review some changes i've made for pvrdma device. v1 -> v2: * Fix various stuff pointed by Marcel * Add Marcel's r-b Yuval Shaia (13): hw/rdma: Make distinction between device init and start modes hw/pvrdma: Bugfix - provide the correct attr_mask to query_qp

[Qemu-devel] [PATCH v2 08/13] hw/rdma: Reorder resource cleanup

To be consistence with allocation do the reverse order in deallocation Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum --- hw/rdma/rdma_rm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/rdma/rdma_rm.c b/hw/rdma/rdma_rm.c index bf4a5c71b4..1f014b4ab2 100644

[Qemu-devel] [PATCH v2 01/13] hw/rdma: Make distinction between device init and start modes

n of a CQ completion handler thread. Driver expects such distinction - implement it. Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum --- hw/rdma/rdma_backend.c | 96 +-- hw/rdma/rdma_backend.h | 2 + hw/rdma/rdma_backend_defs.h | 3 +- hw/rdma/vmw/p

[Qemu-devel] [PATCH v2 03/13] hw/rdma: Modify debug macros

- Add line counter to ease navigation in log - Print rdma instead of pvrdma Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum --- hw/rdma/rdma_utils.c | 4 hw/rdma/rdma_utils.h | 16 hw/rdma/vmw/pvrdma_main.c | 2 ++ 3 files changed, 18 insertions(+), 4

[Qemu-devel] [PATCH v2 11/13] hw/rdma: Print backend QP number in hex format

To be consistent with other prints throughout the code fix places that print it as decimal number. Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum --- hw/rdma/rdma_rm.c | 4 ++-- hw/rdma/vmw/pvrdma_qp_ops.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff

[Qemu-devel] [PATCH v2 07/13] hw/rdma: Do not allocate memory for non-dma MR

There is no use in the memory allocated for non-dma MR. Delete the code that allocates it. Signed-off-by: Yuval Shaia --- hw/rdma/rdma_rm.c | 52 +++ 1 file changed, 21 insertions(+), 31 deletions(-) diff --git a/hw/rdma/rdma_rm.c b/hw/rdma/rdma_rm.c

[Qemu-devel] [PATCH v2 13/13] hw/rdma: Add reference to pci_dev in backend_dev

The field backend_dev->dev is not initialized, fix it. Signed-off-by: Yuval Shaia --- hw/rdma/rdma_backend.c| 6 +- hw/rdma/rdma_backend.h| 2 +- hw/rdma/vmw/pvrdma_main.c | 2 +- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/hw/rdma/rdma_backend.c b/hw/r

[Qemu-devel] [PATCH v2 12/13] hw/rdma: Bugfix - Support non-aligned buffers

address in mr->virt. Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum --- hw/rdma/rdma_rm.c| 2 ++ hw/rdma/vmw/pvrdma_cmd.c | 1 + 2 files changed, 3 insertions(+) diff --git a/hw/rdma/rdma_rm.c b/hw/rdma/rdma_rm.c index 859c93..8d59a42cd1 100644 --- a/hw/rdma/rdma_rm.c ++

Re: [Qemu-devel] [PATCH] hw/rdma: Abort send-op if fail to create addr handler

On Tue, Aug 14, 2018 at 01:00:10PM +0300, Yuval Shaia wrote: > Function create_ah might return NULL, let's exit with an error. > > Signed-off-by: Yuval Shaia > --- > hw/rdma/rdma_backend.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/hw/rdma/

[Qemu-devel] [PATCH] hw/rdma: Abort send-op if fail to create addr handler

Function create_ah might return NULL, let's exit with an error. Signed-off-by: Yuval Shaia --- hw/rdma/rdma_backend.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/rdma/rdma_backend.c b/hw/rdma/rdma_backend.c index 35726bda2e..59d02eb567 100644 --- a/hw/rdma/rdma_backend.c +++ b/hw

Re: [Qemu-devel] RDMA wrongly detected as being supported on FreeBSD

On Sat, Aug 11, 2018 at 07:47:49PM +0300, Marcel Apfelbaum wrote: > Hi, > > On 08/06/2018 11:51 AM, Thomas Huth wrote: > > On 07/28/2018 05:50 AM, Rebecca Cran wrote: > > > On 7/25/18 5:14 AM, Thomas Huth wrote: > > > > > > > Note that the error has been reported to happen on FreeBSD - so I

Re: [Qemu-devel] [PATCH] hw/pvrdma: remove not needed include

"cpu.h" > -#include > #include "hw/hw.h" > #include "hw/pci/pci.h" > #include "hw/pci/pci_ids.h" Reviewed-by: Yuval Shaia > -- > 2.17.1 >

Re: [Qemu-devel] [PATCH] hw/rdma: Abort send-op if fail to create addr handler

On Sat, Aug 18, 2018 at 04:46:29PM +0300, Marcel Apfelbaum wrote: > Hi Yuval, > > On 08/14/2018 01:00 PM, Yuval Shaia wrote: > > Function create_ah might return NULL, let's exit with an error. > > > > Signed-off-by: Yuval Shaia > > --- > > hw/rdma/rdma_

[Qemu-devel] [PATCH 04/13] hw/pvrdma: Clean CQE before use

Next CQE is fetched from CQ ring, clean it before usage as it still carries old CQE values. Signed-off-by: Yuval Shaia --- hw/rdma/vmw/pvrdma_qp_ops.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/rdma/vmw/pvrdma_qp_ops.c b/hw/rdma/vmw/pvrdma_qp_ops.c index 99bb5e..a8664f40c8

[Qemu-devel] [PATCH 13/13] hw/rdma: Save pci dev in backend_dev

This field is not initialized - fix it. Signed-off-by: Yuval Shaia --- hw/rdma/rdma_backend.c| 6 +- hw/rdma/rdma_backend.h| 2 +- hw/rdma/vmw/pvrdma_main.c | 2 +- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/hw/rdma/rdma_backend.c b/hw/rdma/rdma_backend.c index

[Qemu-devel] [PATCH 11/13] hw/rdma: Print backend QP number in hex format

To be consistent with other prints throughout the code fix places that print it as decimal number. Signed-off-by: Yuval Shaia --- hw/rdma/rdma_rm.c | 4 ++-- hw/rdma/vmw/pvrdma_qp_ops.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/rdma/rdma_rm.c b/hw

[Qemu-devel] [PATCH 10/13] hw/rdma: Cosmetic change - move to generic function

To ease maintenance of struct comp_thread move all related code to dedicated function. Signed-off-by: Yuval Shaia --- hw/rdma/rdma_backend.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/rdma/rdma_backend.c b/hw/rdma/rdma_backend.c index 52981d652d

[Qemu-devel] [PATCH 07/13] hw/rdma: Do not allocate memory for non-dma MR

There is no use in the memory allocated for non-dma MR (one with host_virt equals to NULL). Delete the code that allocates it. Signed-off-by: Yuval Shaia --- hw/rdma/rdma_rm.c | 52 +++ 1 file changed, 21 insertions(+), 31 deletions(-) diff --git

[Qemu-devel] [PATCH 03/13] hw/rdma: Modify debug macros

- Add line counter to ease navigation in log - Print rdma instead of pvrdma Signed-off-by: Yuval Shaia --- hw/rdma/rdma_utils.c | 4 hw/rdma/rdma_utils.h | 16 hw/rdma/vmw/pvrdma_main.c | 2 ++ 3 files changed, 18 insertions(+), 4 deletions(-) diff --git a/hw

[Qemu-devel] [PATCH 08/13] hw/rdma: Reorder resource cleanup

To be consistence with allocation do the reverse order in deallocation Signed-off-by: Yuval Shaia --- hw/rdma/rdma_rm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/rdma/rdma_rm.c b/hw/rdma/rdma_rm.c index bf4a5c71b4..1f014b4ab2 100644 --- a/hw/rdma/rdma_rm.c +++ b

[Qemu-devel] [PATCH 09/13] hw/pvrdma: Cosmetic change - indent right

Signed-off-by: Yuval Shaia --- hw/rdma/vmw/pvrdma_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/rdma/vmw/pvrdma_main.c b/hw/rdma/vmw/pvrdma_main.c index 1b1330e113..3d448bffc4 100644 --- a/hw/rdma/vmw/pvrdma_main.c +++ b/hw/rdma/vmw/pvrdma_main.c @@ -430,7

[Qemu-devel] [PATCH 12/13] hw/rdma: Bugfix: Support non-aligned buffers

address in mr->virt. Signed-off-by: Yuval Shaia --- hw/rdma/rdma_rm.c| 2 ++ hw/rdma/vmw/pvrdma_cmd.c | 1 + 2 files changed, 3 insertions(+) diff --git a/hw/rdma/rdma_rm.c b/hw/rdma/rdma_rm.c index 859c93..8d59a42cd1 100644 --- a/hw/rdma/rdma_rm.c +++ b/hw/rdma/rdma_rm.c @@ -16

[Qemu-devel] [PATCH 06/13] hw/rdma: Get rid of unneeded structure

This structure make no sense - removing it. Signed-off-by: Yuval Shaia --- hw/rdma/rdma_backend.c | 3 +-- hw/rdma/rdma_rm.c | 16 hw/rdma/rdma_rm_defs.h | 10 +++--- 3 files changed, 12 insertions(+), 17 deletions(-) diff --git a/hw/rdma/rdma_backend.c b/hw/rdma

[Qemu-devel] [PATCH 05/13] hw/pvrdma: Make default pkey 0xFFFF

0x7FFF is not the default pkey - fix it. Signed-off-by: Yuval Shaia --- hw/rdma/vmw/pvrdma_cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/rdma/vmw/pvrdma_cmd.c b/hw/rdma/vmw/pvrdma_cmd.c index e7d6589cdc..bb898265a3 100644 --- a/hw/rdma/vmw/pvrdma_cmd.c +++ b/hw

[Qemu-devel] [PATCH 01/13] hw/rdma: Make distinction between device init and start modes

n of a CQ completion handler thread. Driver expects such distinction - implement it. Signed-off-by: Yuval Shaia --- hw/rdma/rdma_backend.c | 96 +-- hw/rdma/rdma_backend.h | 2 + hw/rdma/rdma_backend_defs.h | 3 +- hw/rdma/vmw/p

[Qemu-devel] [PATCH 02/13] hw/pvrdma: Bugfix - provide the correct attr_mask to query_qp

Calling rdma_rm_query_qp with attr_mask equals to -1 leads to error where backend query_qp fails to retrieve the needed QP attributes. Fix it by providing the attr_mask we got from driver. Signed-off-by: Yuval Shaia --- hw/rdma/vmw/pvrdma_cmd.c | 5 +++-- 1 file changed, 3 insertions(+), 2

[Qemu-devel] [PATCH 00/13] Misc fixes for pvrdma device

Hi, Please review some changes i've made for pvrdma device. Thanks, Yuval [Qemu-devel] [PATCH 01/13] hw/rdma: Make distinction between device init and start [Qemu-devel] [PATCH 02/13] hw/pvrdma: Bugfix - provide the correct attr_mask to [Qemu-devel] [PATCH 03/13] hw/rdma: Modify debug macros

Re: [Qemu-devel] [PATCH 01/13] hw/rdma: Make distinction between device init and start modes

On Tue, Jul 24, 2018 at 03:08:10PM +0300, Marcel Apfelbaum wrote: > Hi Yuval, > > On 07/16/2018 10:40 AM, Yuval Shaia wrote: > > There are certain operations that are well considered as part of device > > configuration while others are needed only when "start

Re: [Qemu-devel] [PATCH 0/2] pvrdma: Extend device state

On Sun, Sep 02, 2018 at 11:48:11AM +0300, Yuval Shaia wrote: > pvrdma device state is compose of the state of the following: > - rdma backend device > - vmxnet3 device on PCI function 0 > - pvrdma device on PCI function 1 > > This patch-set aim to make it. > > Patch 1:

Re: [Qemu-devel] [PATCH V8 0/4] hw/pvrdma: PVRDMA device implementation

On Wed, Jan 17, 2018 at 02:50:53AM -0800, no-re...@patchew.org wrote: > Hi, > > This series failed build test on ppc host. Please find the details below. > > Subject: [Qemu-devel] [PATCH V8 0/4] hw/pvrdma: PVRDMA device implementation > Type: series > Message-id:

Re: [Qemu-devel] [PULL v4 09/29] pci/shpc: Move function to generic header file

On Thu, Jan 18, 2018 at 03:51:17PM -0600, Eric Blake wrote: > On 01/18/2018 02:44 PM, Michael S. Tsirkin wrote: > > From: Yuval Shaia <yuval.sh...@oracle.com> > > > > This function should be declared in generic header file so we can > > utilize it. > > >

Re: [Qemu-devel] [PULL, 08/36] qapi: Remove qobject_to_X() functions

Hi Eric, On Mon, Mar 12, 2018 at 01:35:59PM -0500, Eric Blake wrote: > From: Max Reitz > > They are no longer needed now. I'm doing some off-list development which use these functions. Unfortunately i'm not subscribed (yet) to qemu-devel so obviously missed this email. Is

Re: [Qemu-devel] [PULL, 08/36] qapi: Remove qobject_to_X() functions

On Thu, Apr 12, 2018 at 03:52:50PM -0500, Eric Blake wrote: > On 04/12/2018 12:51 PM, Yuval Shaia wrote: > > Hi Eric, > > > > On Mon, Mar 12, 2018 at 01:35:59PM -0500, Eric Blake wrote: > >> From: Max Reitz <mre...@redhat.com> > >> > >> They

Re: [Qemu-devel] [PATCH v3 38/41] hw/rdma: Use the BYTE-based definitions

X0 > #define RDMA_REG_BAR_IDX 1 > #define RDMA_UAR_BAR_IDX 2 > -#define RDMA_BAR0_MSIX_SIZE (16 * 1024) > +#define RDMA_BAR0_MSIX_SIZE (16 * K_BYTE) > #define RDMA_BAR1_REGS_SIZE 256 > #define RDMA_BAR2_UAR_SIZE (0x1000 * MAX_UCS) /* each uc gets page */ Reviewed-by: Yuval Shaia <yuval.sh...@oracle.com> > > -- > 2.17.0 >

Re: [Qemu-devel] [PATCH for-2.12] rdma: Fix 32-bit compilation

On Mon, Mar 19, 2018 at 04:53:35PM -0500, Eric Blake wrote: > Use the correct printf formats, so that a 32-bit compile doesn't > spit out lots of warnings about %lx being incompatible with uint64_t. > Broken since initial commit ef6d4ccd. > > Signed-off-by: Eric Blake > --- >

[Qemu-devel] [PATCH v1 1/2] hw/rdma: Add Query QP operation

This operation is needed by rdma devices - implement it. Signed-off-by: Yuval Shaia <yuval.sh...@oracle.com> --- hw/rdma/rdma_backend.c | 12 hw/rdma/rdma_backend.h | 2 ++ hw/rdma/rdma_rm.c | 18 ++ hw/rdma/rdma_rm.h | 3 +++ 4 files chang

[Qemu-devel] ihw/rdma: Implementation of Query QP verb

Please review implementation of Query QP verb which is needed by some RDMA applications. Patch #1: Implementation in rdma backend layer Patch #2: Add support to pvrdma device v0 -> v1: * Split to two patches, one for rdma and one for pvrdma [PATCH v1 1/2] hw/rdma: Add Query QP operation

[Qemu-devel] [PATCH v1 2/2] hw/rdma: Add support for Query QP verb to pvrdma device

This IB verb is needed by some applications - implement it. Signed-off-by: Yuval Shaia <yuval.sh...@oracle.com> --- hw/rdma/vmw/pvrdma_cmd.c | 24 +++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/hw/rdma/vmw/pvrdma_cmd.c b/hw/rdma/vmw/pvrdma_cmd.c

[Qemu-devel] [PATCH] hw/rdma: Implementation of Query QP command

Signed-off-by: Yuval Shaia <yuval.sh...@oracle.com> --- hw/rdma/rdma_backend.c | 12 hw/rdma/rdma_backend.h | 2 ++ hw/rdma/rdma_rm.c| 18 ++ hw/rdma/rdma_rm.h| 3 +++ hw/rdma/vmw/pvrdma_cmd.c | 24 +++- 5 files chang

[Qemu-devel] [PATCH 3/3] hw/rdma: Fix 32-bit compilation

Use the correct printf formats, so that a 32-bit compile doesn't spit out lots of warnings about %lx being incompatible with uint64_t. Suggested-by: Eric Blake <ebl...@redhat.com> Signed-off-by: Yuval Shaia <yuval.sh...@oracle.com> --- hw/rdma/rdma_backend.c| 21 +++--

[Qemu-devel] [PATCH 2/3] hw/rdma: Use correct print format in CHK_ATTR macro

Macro should not cast the given variable to u64 instead it should use the supplied format argument (fmt). Reported-by: Eric Blake <ebl...@redhat.com> Signed-off-by: Yuval Shaia <yuval.sh...@oracle.com> --- hw/rdma/rdma_backend.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deleti

[Qemu-devel] [PATCH 1/3] hw/rdma: Change host_virt to void *

ported-by: Eric Blake <ebl...@redhat.com> Signed-off-by: Yuval Shaia <yuval.sh...@oracle.com> --- hw/rdma/rdma_backend.c | 8 hw/rdma/rdma_backend.h | 2 +- hw/rdma/rdma_rm.c | 10 +- hw/rdma/rdma_rm_defs.h | 2 +- 4 files changed, 11 insertions(+), 11 deletions(-) di

Re: [Qemu-devel] [PATCH for-2.12 1/2] rdma: fix up include directives

On Wed, Mar 21, 2018 at 05:22:07PM +0200, Michael S. Tsirkin wrote: > Our rule right now is to use <> for external headers only. > RDMA code violates that, fix it up. > > Signed-off-by: Michael S. Tsirkin <m...@redhat.com> Thanks. Reviewed-by: Yuval Shaia <yuval.sh.

[Qemu-devel] [PATCH 0/3] hw/rdma: Fix 32-bit compilation

: Fix 32-bit compilation Based on Eric Blake patch this patch replaces all %ld/%lx with the platform independent PRIx64/PRId64 format. Again, thanks Eric Blake for the report. Yuval Shaia (3): hw/rdma: Change host_virt to void * hw/rdma: Use correct print format in CHK_ATTR macro hw/rdma: Fix

[Qemu-devel] [PATCH v2 for-2.12 1/3] hw/rdma: Change host_virt to void *

ported-by: Eric Blake <ebl...@redhat.com> Signed-off-by: Yuval Shaia <yuval.sh...@oracle.com> Reviewed-by: Eric Blake <ebl...@redhat.com> Tested-by: Eric Blake <ebl...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/rdma/rdma_backend.c | 8

[Qemu-devel] [PATCH v2 for-2.12 2/3] hw/rdma: Use correct print format in CHK_ATTR macro

Macro should not cast the given variable to u64 instead it should use the supplied format argument (fmt). Reported-by: Eric Blake <ebl...@redhat.com> Signed-off-by: Yuval Shaia <yuval.sh...@oracle.com> Reviewed-by: Eric Blake <ebl...@redhat.com> Tested-by: Eric Blake <ebl...

[Qemu-devel] [PATCH v2 for-2.12 0/3] hw/rdma: Fix 32-bit compilation

ngs) * Add reviewers signatures Yuval Shaia (3): hw/rdma: Change host_virt to void * hw/rdma: Use correct print format in CHK_ATTR macro hw/rdma: Fix 32-bit compilation hw/rdma/rdma_backend.c| 33 + hw/rdma/rdma_backend.h| 2 +- hw/r

[Qemu-devel] [PATCH v2 for-2.12 3/3] hw/rdma: Fix 32-bit compilation

Use the correct printf formats, so that a 32-bit compile doesn't spit out lots of warnings about %lx being incompatible with uint64_t. Suggested-by: Eric Blake <ebl...@redhat.com> Signed-off-by: Yuval Shaia <yuval.sh...@oracle.com> Reviewed-by: Eric Blake <ebl...@redhat.com> Tes

Re: [Qemu-devel] [Qemu-trivial] [PATCH 3/3] hw/rdma: Fix 32-bit compilation

> > > > So many pr_err/pr_dbg() changes, you could have take the opportunity to > replace with updated error reporting API and tracepoint. Let's leave something for next time :) > > With %zu: > Reviewed-by: Philippe Mathieu-Daudé Thanks.

Re: [Qemu-devel] [PATCH for-2.12] hw/rdma: fix clang compilation errors

On Wed, Mar 21, 2018 at 02:40:26PM +0200, Marcel Apfelbaum wrote: > Fix some enum castings and extra parentheses. > > Reported-by: Michael S. Tsirkin > Signed-off-by: Marcel Apfelbaum > --- > hw/rdma/vmw/pvrdma_cmd.c | 5 +++-- > hw/rdma/vmw/pvrdma_main.c |

Re: [Qemu-devel] [PATCH V2 for-2.12] hw/rdma: fix clang compilation errors

memset(dev->rdma_dev_res.ports, 0, sizeof(dev->rdma_dev_res.ports)); > > for (i = 0; i < MAX_PORTS; i++) { > - dev->rdma_dev_res.ports[i].state = PVRDMA_PORT_DOWN; > +dev->rdma_dev_res.ports[i].state = IBV_PORT_DOWN; > > dev->rdma_dev_res.ports[i].pkey_tbl = > g_malloc0(sizeof(*dev->rdma_dev_res.ports[i].pkey_tbl) * Reviewed-by: Yuval Shaia <yuval.sh...@oracle.com> > -- > 2.13.5 >

[Qemu-devel] [PATCH] hw/pvrdma: Check the correct return value

Return value of 0 means ok, we want to free the memory only in case of error. Signed-off-by: Yuval Shaia --- hw/rdma/vmw/pvrdma_cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/rdma/vmw/pvrdma_cmd.c b/hw/rdma/vmw/pvrdma_cmd.c index 4faeb21631..57d6f41ae6 100644

[Qemu-devel] [PATCH 01/18] contrib/rdmacm-mux: Add implementation of RDMA User MAD multiplexer

arrived (umad_recv()) the server, depending on the message type (attr_id) looks for target client by either searching in gid->fd table or in local_comm_id->fd table. With the extracted fd the server relays to incoming message to the client. Signed-off-by: Yuval Shaia --- MAINT

[Qemu-devel] [PATCH 09/18] hw/pvrdma: Set the correct opcode for send completion

opcode for WC should be set by the device and not taken from work element. Signed-off-by: Yuval Shaia --- hw/rdma/vmw/pvrdma_qp_ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/rdma/vmw/pvrdma_qp_ops.c b/hw/rdma/vmw/pvrdma_qp_ops.c index 7b0f440fda..3388be1926 100644

[Qemu-devel] [PATCH 18/18] hw/rdma: Remove unneeded code that handles more that one port

Device supports only one port, let's remove a dead code that handles more than one port. Signed-off-by: Yuval Shaia --- hw/rdma/rdma_rm.c | 34 -- hw/rdma/rdma_rm.h | 2 +- hw/rdma/rdma_rm_defs.h | 4 ++-- 3 files changed, 19 insertions(+), 21

[Qemu-devel] [PATCH 04/18] hw/rdma: Abort send-op if fail to create addr handler

Function create_ah might return NULL, let's exit with an error. Signed-off-by: Yuval Shaia --- hw/rdma/rdma_backend.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/rdma/rdma_backend.c b/hw/rdma/rdma_backend.c index d7a4bbd91f..1e148398a2 100644 --- a/hw/rdma/rdma_backend.c +++ b/hw

[Qemu-devel] [PATCH 14/18] hw/rdma: Initialize node_guid from vmxnet3 mac address

node_guid should be set once device is load. Make node_guid be GID format (32 bit) of PCI function 0 vmxnet3 device's MAC. A new function was added to do the conversion. So for example the MAC 56:b6:44:e9:62:dc will be converted to GID 54b6:44ff:fee9:62dc. Signed-off-by: Yuval Shaia --- hw

[Qemu-devel] [PATCH 15/18] hw/pvrdma: Make device state depend on Ethernet function state

User should be able to control the device by changing Ethernet function state so if user runs 'ifconfig ens3 down' the PVRDMA function should be down as well. Signed-off-by: Yuval Shaia --- hw/rdma/vmw/pvrdma_cmd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/rdma

[Qemu-devel] [PATCH 10/18] json: Define new QMP message for pvrdma

. Signed-off-by: Yuval Shaia --- MAINTAINERS | 1 + Makefile | 3 ++- Makefile.objs | 4 qapi/qapi-schema.json | 1 + qapi/rdma.json| 34 ++ 5 files changed, 42 insertions(+), 1 deletion(-) create mode 100644 qapi

[Qemu-devel] [PATCH 03/18] hw/rdma: Return qpn 1 if ibqp is NULL

Device is not supporting QP0, only QP1. Signed-off-by: Yuval Shaia --- hw/rdma/rdma_backend.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/rdma/rdma_backend.h b/hw/rdma/rdma_backend.h index 86e8fe8ab6..3ccc9a2494 100644 --- a/hw/rdma/rdma_backend.h +++ b/hw/rdma

[Qemu-devel] [PATCH 12/18] vmxnet3: Move some definitions to header file

MAC address. To be able to access vmxnet3 device the definition of VMXNET3State is moved to a new header file. Signed-off-by: Yuval Shaia --- hw/net/vmxnet3.c | 116 +--- hw/net/vmxnet3_defs.h | 133 ++ 2 files changed

[Qemu-devel] [PATCH 07/18] hw/pvrdma: Make default pkey 0xFFFF

Commit 6e7dba23af ("hw/pvrdma: Make default pkey 0x") exports default pkey as external definition but omit the change from 0x7FFF to 0x. Fixes: 6e7dba23af ("hw/pvrdma: Make default pkey 0x") Signed-off-by: Yuval Shaia --- hw/rdma/vmw/pvrdma.h | 2 +- 1 file

[Qemu-devel] [PATCH 08/18] hw/pvrdma: Set the correct opcode for recv completion

The function pvrdma_post_cqe populates CQE entry with opcode from the given completion element. For receive operation value was not set. Fix it by setting it to IBV_WC_RECV. Signed-off-by: Yuval Shaia --- hw/rdma/vmw/pvrdma_qp_ops.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[Qemu-devel] [PATCH 00/18] Add support for RDMA MAD

Yuval Shaia (18): contrib/rdmacm-mux: Add implementation of RDMA User MAD multiplexer hw/rdma: Add ability to force notification without re-arm hw/rdma: Return qpn 1 if ibqp is NULL hw/rdma: Abort send-op if fail to create addr handler hw/rdma: Add support for MAD packets hw/pvrdma: Make

[Qemu-devel] [PATCH 06/18] hw/pvrdma: Make function reset_device return void

This function cannot fail - fix it to return void Signed-off-by: Yuval Shaia --- hw/rdma/vmw/pvrdma_main.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/rdma/vmw/pvrdma_main.c b/hw/rdma/vmw/pvrdma_main.c index 6c8c0154fa..fc2abd34af 100644 --- a/hw/rdma/vmw

[Qemu-devel] [PATCH 02/18] hw/rdma: Add ability to force notification without re-arm

to be notified anyway, it even do not need to re-arm the notification bit. Enhance the notification field to support this. Signed-off-by: Yuval Shaia --- hw/rdma/rdma_rm.c | 12 ++-- hw/rdma/rdma_rm_defs.h | 8 +++- hw/rdma/vmw/pvrdma_qp_ops.c | 6 -- 3 files

[Qemu-devel] [PATCH 16/18] hw/pvrdma: Fill all CQE fields

Add ability to pass specific WC attributes to CQE such as GRH_BIT flag. Signed-off-by: Yuval Shaia --- hw/rdma/rdma_backend.c | 59 +++-- hw/rdma/rdma_backend.h | 4 +-- hw/rdma/vmw/pvrdma_qp_ops.c | 31 +++ 3 files changed, 58

[Qemu-devel] [PATCH 13/18] hw/pvrdma: Make sure PCI function 0 is vmxnet3

Guest driver enforces it, we should also. Signed-off-by: Yuval Shaia --- hw/rdma/vmw/pvrdma.h | 2 ++ hw/rdma/vmw/pvrdma_main.c | 3 +++ 2 files changed, 5 insertions(+) diff --git a/hw/rdma/vmw/pvrdma.h b/hw/rdma/vmw/pvrdma.h index b019cb843a..10a3c4fb7c 100644 --- a/hw/rdma/vmw/pvrdma.h

[Qemu-devel] [PATCH 05/18] hw/rdma: Add support for MAD packets

al utility (contrib/rdmacm-mux) to relay packets from and to the guest driver. Signed-off-by: Yuval Shaia --- hw/rdma/rdma_backend.c | 263 +++- hw/rdma/rdma_backend.h | 4 +- hw/rdma/rdma_backend_defs.h | 10 +- hw/rdma/vmw/pvrdma.h| 2 + h

[Qemu-devel] [PATCH 11/18] hw/pvrdma: Add support to allow guest to configure GID table

. Signed-off-by: Yuval Shaia --- hw/rdma/rdma_backend.c | 221 ++-- hw/rdma/rdma_backend.h | 22 ++-- hw/rdma/rdma_backend_defs.h | 3 +- hw/rdma/rdma_rm.c | 101 +++- hw/rdma/rdma_rm.h | 17 ++- hw/rdma/rdma_rm_defs.h

[Qemu-devel] [PATCH 17/18] hw/pvrdma: Fill error code in command's response

Driver checks error code let's set it. Signed-off-by: Yuval Shaia --- hw/rdma/vmw/pvrdma_cmd.c | 67 1 file changed, 48 insertions(+), 19 deletions(-) diff --git a/hw/rdma/vmw/pvrdma_cmd.c b/hw/rdma/vmw/pvrdma_cmd.c index a88d922932..a694faac8d 100644

Re: [Qemu-devel] [PATCH v2 19/22] vl: Introduce shutdown_notifiers

On Thu, Nov 08, 2018 at 05:26:06PM +0100, Cornelia Huck wrote: > On Thu, 8 Nov 2018 18:08:15 +0200 > Yuval Shaia wrote: > > > Notifier will be used for signaling shutdown event to inform system is > > shutdown. This will allow devices and other component to run some &g

  1   2   3   4   5   6   >