Re: [Qemu-devel] [PATCH 1/2] omap_intc: Use MemoryRegion API

2011-09-16 Thread andrzej zaborowski
On 31 August 2011 17:55, Peter Maydell wrote: > Convert omap_intc to use the MemoryRegion API > > Signed-off-by: Peter Maydell > --- >  hw/omap_intc.c |   64 ++- >  1 files changed, 30 insertions(+), 34 deletions(-) > > diff --git a/hw/omap_intc

Re: [Qemu-devel] [PATCH v2 07/18] omap_gpmc: GPMC_IRQSTATUS is write-one-to-clear

2011-09-16 Thread andrzej zaborowski
On 28 August 2011 18:56, Peter Maydell wrote: > Fix a bug in the handling of writes to GPMC_IRQSTATUS: > it behaves as "write one to clear, writing zero is ignored". > > Signed-off-by: Peter Maydell > --- >  hw/omap_gpmc.c |    2 +- >  1 files changed, 1 insertions(+), 1 deletions(-) > > diff --g

Re: [Qemu-devel] [PATCH v2 09/18] omap_gpmc: Fix handling of FIFOTHRESHOLDSTATUS bit

2011-09-16 Thread andrzej zaborowski
On 28 August 2011 18:56, Peter Maydell wrote: > The OMAP3 TRM is inconsistent about whether the GPMC FIFOTHRESHOLDSTATUS > bit should be set when FIFOPOINTER > FIFOTHRESHOLD or when it is >= > FIFOTHRESHOLD. Apparently the underlying functional spec from which > the TRM was created states that the

Re: [Qemu-devel] Usage of Temperature Sensor (TMP105)

2012-12-03 Thread andrzej zaborowski
Hi Alex, On 1 December 2012 20:39, Alex Horn wrote: > Hello all, > > As I have been browsing through QEMU's source code, I've noticed a > hardware model for a temperature sensor called TMP105. This model > implements the function tmp105_set(I2CSlave *i2c, int temp) declared > in i2c.h [0, 1]. > >

Re: [Qemu-devel] [PATCH next v2 33/74] pxa2xx: Use cpu_arm_init() and store ARMCPU

2012-05-11 Thread andrzej zaborowski
On 11 May 2012 13:16, Peter Maydell wrote: > On 10 May 2012 01:14, Andreas Färber wrote: >> Also use cpu_reset() in place of cpu_state_reset(). >> >> Signed-off-by: Andreas Färber > > The pxa2xx stuff is probably going to clash with the cp15 > rework, but I guess we'll sort that out when one or

Re: [Qemu-devel] [PATCH 1/2] hw/omap_gpmc: Add comment about FIFOTHRESHOLDSTATUS bit

2011-09-22 Thread andrzej zaborowski
On 17 September 2011 20:51, Peter Maydell wrote: > Promote the remark about why we handle FIFOTHRESHOLDSTATUS the > way we do from the commit message of de8af7fe0 to a comment in > the code. Thanks, I applied both patches. Looks like any other related patches are waiting for other events. Cheer

Re: [Qemu-devel] GPLv3 troubles

2011-10-18 Thread andrzej zaborowski
On 18 October 2011 15:03, Anthony Liguori wrote: > Okay, let's get serious about it.  I set up the following wiki page for > coordination: > > http://wiki.qemu.org/Relicensing The bottom section with "some SVN authors" has a bunch of files by me that are "GPLv2". Most of them were probably meant

Re: [Qemu-devel] [RESEND][PATCH 2/9] PCMCIA: start qdev'ication

2011-05-15 Thread andrzej zaborowski
Hi Dmitry, On 25 April 2011 11:06, Dmitry Eremin-Solenikov wrote: > Convert PCMCIA bus handling code to use QBus internally. > MicroDrive code is still unaffected. > > Signed-off-by: Dmitry Eremin-Solenikov > --- >  Makefile.objs      |    3 ++ >  hw/pcmcia.c        |  102 > +++

Re: [Qemu-devel] [RESEND][PATCH 3/9] microdrive: qdevify

2011-05-15 Thread andrzej zaborowski
On 25 April 2011 11:06, Dmitry Eremin-Solenikov wrote: > Switch dscm1 microdrive driver to use qdev infrastructure. > --- >  hw/ide/microdrive.c |   49 +++-- >  hw/pcmcia.h         |    2 +- >  hw/spitz.c          |    5 - >  hw/tosa.c          

Re: [Qemu-devel] [PATCH 1/3] omap: remove L4_MUX_HACK

2011-11-26 Thread andrzej zaborowski
ned-off-by: Avi Kivity Reviewed-by: Andrzej Zaborowski

Re: [Qemu-devel] [PATCH 3/3] omap_l4: add memory API variant of omap_l4_attach()

2011-11-26 Thread andrzej zaborowski
On 24 November 2011 16:57, Avi Kivity wrote: > Also add omap_l4_region_size(), since memory API functions need > the size during initialization. Logically it should be one of the omap_l4_* functions that set the size for the region instead of the target agents because this is where all the memory

Re: [Qemu-devel] ncurses 5.3 conflicts with latest qemu

2011-12-05 Thread andrzej zaborowski
Hi, On 17 November 2011 10:06, Caraman Mihai Claudiu-B02008 wrote: > A recent patch in qemu conflicts with old ncurses libraries (version 5.3). > You will see this error cause by bool type redefinition in curses.h (with > CONFIG_CURSES configured by default): > > console.c: In function 'text_co

Re: [Qemu-devel] [PATCH] [ARM] Fix hw_error messages from arm_timer.c

2011-12-05 Thread andrzej zaborowski
On 22 November 2011 04:20, Peter Chubb wrote: > Two of the calls to hw_error() in arm_timer.c contain the wrong function name. > > As suggested by Andreas Färber, use the C99 standard __func__ macro to > get the correct name, instead of putting the name directly into the code. Thanks, applied. C

Re: [Qemu-devel] [PATCH] target-arm/translate.c: Fix slightly misleading comment in Thumb decoder

2011-12-05 Thread andrzej zaborowski
On 24 November 2011 19:33, Peter Maydell wrote: > Clarify some slightly misleading comments in the Thumb decoder's > handling of the memory hint space -- in particular one code path > marked as 'UNPREDICTABLE or unallocated hint' also includes some > legitimate preload instructions. Thanks, appli

Re: [Qemu-devel] [PATCH] target-arm/helper.c: Don't allocate TCG resources unless TCG enabled

2011-12-05 Thread andrzej zaborowski
On 25 November 2011 19:25, Peter Maydell wrote: > Don't call arm_translate_init() (which allocates TCG resources) > unless TCG is enabled. Thanks, applied this patch. Cheers

Re: [Qemu-devel] [Qemu-ppc] [PATCH] pseries: Fix array overrun bug in PCI code

2011-12-05 Thread andrzej zaborowski
On 29 November 2011 08:41, David Gibson wrote: > On Tue, Nov 29, 2011 at 05:21:39PM +1100, David Gibson wrote: >> spapr_populate_pci_devices() containd a loop with PCI_NUM_REGIONS (7) >> iterations.  However this overruns the 'bars' global array, which only has >> 6 elements. In fact we only want

Re: [Qemu-devel] [PATCH] configure: Drop armv4l/armv4b distinction in $cpu

2011-12-05 Thread andrzej zaborowski
On 30 November 2011 10:57, Peter Maydell wrote: > Drop the distinction between armv4l/armv4b in the $cpu variable > (ie host cpu type) in favour of calling everything 'arm'. This > makes it the same as the ARCH setting and removes some special > casing. The only thing we were using the distinction

Re: [Qemu-devel] [PATCH] hw/arm_gic.c: Ignore attempts to complete nonexistent IRQs

2011-12-05 Thread andrzej zaborowski
On 1 December 2011 19:37, Peter Maydell wrote: > Ignore attempts to complete non-existent IRQs; this fixes a buffer > overrun if the guest writes a bad value to the GICC_EOIR register. > (This case is UNPREDICTABLE so ignoring it is a valid choice.) > Note that doing nothing if the guest writes 10

Re: [Qemu-devel] ncurses 5.3 conflicts with latest qemu

2011-12-07 Thread andrzej zaborowski
On 5 December 2011 22:44, Stefan Weil wrote: > Am 05.12.2011 20:13, schrieb andrzej zaborowski: > >> Hi, >> >> On 17 November 2011 10:06, Caraman Mihai Claudiu-B02008 >> wrote: >>> >>> A recent patch in qemu conflicts with old ncurses libraries (ve

[Qemu-devel] [PATCH] configure: don't try to compile against known broken curses.

2011-12-07 Thread Andrzej Zaborowski
This should resolve a problem noted by Caraman Mihai Claudiu. Signed-off-by: Andrzej Zaborowski --- configure |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/configure b/configure index 61c43b9..678b982 100755 --- a/configure +++ b/configure @@ -1846,6 +1846,11

[Qemu-devel] [PATCH 1/2] configure: don't check for Cocoa when detecting SDL.

2011-12-07 Thread Andrzej Zaborowski
The SDL check is supposed to set $sdl to "yes" or "no", but with that check it leaves $sdl unset on darwin, unless --enable-cocoa was specified (which is not needed to enable cocoa anyway). Signed-off-by: Andrzej Zaborowski --- configure |4 +--- 1 files changed

[Qemu-devel] [PATCH 2/2] configure: remove --enable-cocoa (default), add --disable-cocoa.

2011-12-07 Thread Andrzej Zaborowski
Cocoa can only be enabled on Darwin, and is enabled by default too, making --enable-cocoa redundant, with no way to disable Cocoa. It also interfered with SDL support in a way that was dependent on the order of commandline switches. Signed-off-by: Andrzej Zaborowski --- Cocoa support seems to

Re: [Qemu-devel] [PATCH] configure: don't try to compile against known broken curses.

2011-12-07 Thread andrzej zaborowski
On 7 December 2011 19:57, Stefan Weil wrote: > Am 07.12.2011 08:47, schrieb Andrzej Zaborowski: >> +#ifdef NCURSES_VERSION >> +# if NCURSES_VERSION_PATCH < 20040117 >> +# error Old ncurses contain dangerous typedefs, break qemu build (and are >> old) >>

Re: [Qemu-devel] [PATCH 2/2] configure: remove --enable-cocoa (default), add --disable-cocoa.

2011-12-07 Thread andrzej zaborowski
On 7 December 2011 19:56, Peter Maydell wrote: > On 7 December 2011 07:47, Andrzej Zaborowski wrote: >> Cocoa can only be enabled on Darwin, and is enabled by default too, >> making --enable-cocoa redundant, with no way to disable Cocoa.  It >> also interfered with SDL supp

Re: [Qemu-devel] [PATCH 2/2] configure: remove --enable-cocoa (default), add --disable-cocoa.

2011-12-08 Thread andrzej zaborowski
On 7 December 2011 22:12, Andreas Färber wrote: > Am 07.12.2011 08:47, schrieb Andrzej Zaborowski: >> Cocoa can only be enabled on Darwin, and is enabled by default too, >> making --enable-cocoa redundant, with no way to disable Cocoa.  It >> also interfered with SDL supp

Re: [Qemu-devel] [PATCH 2/2] configure: remove --enable-cocoa (default), add --disable-cocoa.

2011-12-08 Thread andrzej zaborowski
On 9 December 2011 02:25, andrzej zaborowski wrote: >>> Cocoa support seems to be broken at the moment, at least on some >>> MacOS X versions.  But qemu builds and runs with SDL. >> >> Many times have I asked how to actually use SDL with QEMU on Mac OS X. >> If

Re: [Qemu-devel] [PATCH] ARM - Remove fixed map code buffer restriction

2011-12-12 Thread andrzej zaborowski
Hi, On 12 December 2011 16:55, Peter Maydell wrote: > On 12 December 2011 15:37, Dr. David Alan Gilbert > wrote: >> On ARM, don't map the code buffer at a fixed location, and fix up the >> call/goto tcg routines to let it do long jumps. >> >> Mapping the code buffer at a fixed address could some

Re: [Qemu-devel] [PATCH] ARM - Remove fixed map code buffer restriction

2011-12-12 Thread andrzej zaborowski
On 12 December 2011 19:03, Peter Maydell wrote: > On 12 December 2011 17:24, andrzej zaborowski wrote: >> BTW: I think we can also use the "ld" branch when we see the goto >> target is in Thumb mode. > > The target of a goto is currently never Thumb (because

Re: [Qemu-devel] [PATCH] ARM - Remove fixed map code buffer restriction

2011-12-14 Thread andrzej zaborowski
On 12 December 2011 16:37, Dr. David Alan Gilbert wrote: > On ARM, don't map the code buffer at a fixed location, and fix up the > call/goto tcg routines to let it do long jumps. > > Mapping the code buffer at a fixed address could sometimes result in it being > mapped over the top of the heap wit

Re: [Qemu-devel] [PULL 00/10] target-arm queue

2011-12-14 Thread andrzej zaborowski
On 13 December 2011 19:30, Peter Maydell wrote: > Current target-arm pending patches; mostly these are Andreas' > inference series, plus one from Jean-Christophe that's been > waiting since before the 1.0 release. > > Please pull. Thanks, pulled (and pushed) Cheers

Re: [Qemu-devel] [PATCH] configure: don't try to compile against known broken curses.

2011-12-14 Thread andrzej zaborowski
On 7 December 2011 20:06, andrzej zaborowski wrote: > On 7 December 2011 19:57, Stefan Weil wrote: >> Am 07.12.2011 08:47, schrieb Andrzej Zaborowski: >>> +#ifdef NCURSES_VERSION >>> +# if NCURSES_VERSION_PATCH < 20040117 >>> +# error Old ncurses contain da

Re: [Qemu-devel] [PATCH 2/3] tcg/arm: fix qemu_st64 for big endian targets

2011-01-07 Thread andrzej zaborowski
On 6 January 2011 22:54, Aurelien Jarno wrote: > Due to a typo, qemu_st64 doesn't properly byteswap the 32-bit low word of > a 64 bit word before saving it. This patch fixes that. This is a good catch. Acked-by: Andrzej Zaborowski Cheers

Re: [Qemu-devel] [PATCH 3/3] tcg/arm: improve constant loading

2011-01-07 Thread andrzej zaborowski
Hi, On 6 January 2011 22:54, Aurelien Jarno wrote: > Improve constant loading in two ways: > - On all ARM versions, it's possible to load 0xff00 = -0x100 using >  the mvn rd, #0. Fix the conditions. > - On <= ARMv6 versions, where movw and movt are not available, load the >  constants using m

Re: [Qemu-devel] [PATCH 3/3] tcg/arm: improve constant loading

2011-01-07 Thread andrzej zaborowski
On 7 January 2011 13:52, andrzej zaborowski wrote: > On 6 January 2011 22:54, Aurelien Jarno wrote: >> Improve constant loading in two ways: >> - On all ARM versions, it's possible to load 0xff00 = -0x100 using >>  the mvn rd, #0. Fix the conditions. >> - On &

Re: [Qemu-devel] [PATCH 3/3] tcg/arm: improve constant loading

2011-01-07 Thread andrzej zaborowski
On 7 January 2011 15:40, Aurelien Jarno wrote: > On Fri, Jan 07, 2011 at 01:52:25PM +0100, andrzej zaborowski wrote: >> Hi, >> >> On 6 January 2011 22:54, Aurelien Jarno wrote: >> > Improve constant loading in two ways: >> > - On all ARM versions, it'

Re: [Qemu-devel] [PATCH 3/3] tcg/arm: improve constant loading

2011-01-09 Thread andrzej zaborowski
On 9 January 2011 23:40, Aurelien Jarno wrote: > On Fri, Jan 07, 2011 at 04:56:32PM +0100, andrzej zaborowski wrote: >> On 7 January 2011 15:40, Aurelien Jarno wrote: >> > On Fri, Jan 07, 2011 at 01:52:25PM +0100, andrzej zaborowski wrote: >> >> On 6 January 201

Re: [Qemu-devel] Re: [PATCH 3/3] MAINTAINERS: add entries for TCG

2011-01-10 Thread andrzej zaborowski
On 10 January 2011 18:46, Alexander Graf wrote: > > On 10.01.2011, at 18:34, Aurelien Jarno wrote: > >> Cc: Andrzej Zaborowski > > ^- That email address always bounces for me. Are you sure it's still valid? It is outdated, please use or alternatively just the mailling list. Cheers

Re: [Qemu-devel] [PATCH 4/5] pxa2xx: fix SSSR TFN logic

2010-09-04 Thread andrzej zaborowski
Hi, On 4 September 2010 16:17, Blue Swirl wrote: > Fix SSSR TFN logic: TX FIFO is never filled, so it is always in > underrun condition if SSP is enabled. As far as I see this doesn't make any change when the port is enabled? How does it fix the logic then? Cheers

Re: [Qemu-devel] [PATCH 1/5] Suppress some gcc warnings with -Wtype-limits

2010-09-04 Thread andrzej zaborowski
On 4 September 2010 16:17, Blue Swirl wrote: > Add various casts, adjust types etc. to make the warnings with > gcc flag -Wtype-limits disappear. > > Signed-off-by: Blue Swirl > --- >  block/blkdebug.c      |    2 +- >  hw/mips_fulong2e.c    |    2 +- >  hw/omap1.c            |    2 +- >  hw/ppc4

Re: [Qemu-devel] [PATCH 1/5] Suppress some gcc warnings with -Wtype-limits

2010-09-04 Thread andrzej zaborowski
On 4 September 2010 18:14, Blue Swirl wrote: > On Sat, Sep 4, 2010 at 3:40 PM, andrzej zaborowski wrote: >> On 4 September 2010 16:17, Blue Swirl wrote: >>> Add various casts, adjust types etc. to make the warnings with >>> gcc flag -Wtype-limits disappear. >&g

Re: [Qemu-devel] [PATCH 1/5] Suppress some gcc warnings with -Wtype-limits

2010-09-04 Thread andrzej zaborowski
On 4 September 2010 19:21, Blue Swirl wrote: > On Sat, Sep 4, 2010 at 4:44 PM, andrzej zaborowski wrote: >> On 4 September 2010 18:14, Blue Swirl wrote: >>> On Sat, Sep 4, 2010 at 3:40 PM, andrzej zaborowski >>> wrote: >>>> On 4 September 2010 16:17, Blu

Re: [Qemu-devel] [PATCH 1/5] Suppress some gcc warnings with -Wtype-limits

2010-09-04 Thread andrzej zaborowski
Hi, On 4 September 2010 21:45, Blue Swirl wrote: > On Sat, Sep 4, 2010 at 5:57 PM, andrzej zaborowski wrote: >>>  -    if (event < 0 || event >= BLKDBG_EVENT_MAX) { >>>  +    if ((int)event < 0 || event >= BLKDBG_EVENT_MAX) { >> Is the behaviour incorrect

[Qemu-devel] Re: [PATCH 1/5] Suppress some gcc warnings with -Wtype-limits

2010-09-05 Thread andrzej zaborowski
On 5 September 2010 11:44, Blue Swirl wrote: > On Sun, Sep 5, 2010 at 9:26 AM, Michael S. Tsirkin wrote: >> On Sun, Sep 05, 2010 at 09:06:10AM +, Blue Swirl wrote: >>> On Sun, Sep 5, 2010 at 7:54 AM, Michael S. Tsirkin wrote: >>> > On Sat, Sep 04, 2010 at 05:21:24PM +, Blue Swirl wrote:

[Qemu-devel] Re: [PATCH 1/5] Suppress some gcc warnings with -Wtype-limits

2010-09-05 Thread andrzej zaborowski
On 5 September 2010 18:15, Blue Swirl wrote: > On Sun, Sep 5, 2010 at 3:26 PM, andrzej zaborowski wrote: >> On 5 September 2010 11:44, Blue Swirl wrote: >>> On Sun, Sep 5, 2010 at 9:26 AM, Michael S. Tsirkin wrote: >>>> On Sun, Sep 05, 2010 at 09:06:10AM +,

[Qemu-devel] Re: [PATCH 1/5] Suppress some gcc warnings with -Wtype-limits

2010-09-05 Thread andrzej zaborowski
On 5 September 2010 19:02, andrzej zaborowski wrote: > Patches 05, 06, 07, 09, 11, 14, 15 all replace one version of the code > with a different that achieves the exact same functionality for all Sorry, patch 11 is a fix (unrelated to the warning though). Cheers

Re: [Qemu-devel] Unmaintained QEMU builds

2010-09-05 Thread andrzej zaborowski
On 5 September 2010 19:33, malc wrote: > On Sun, 5 Sep 2010, Avi Kivity wrote: > >>  On 09/05/2010 06:57 PM, Anthony Liguori wrote: >> > On 09/05/2010 10:10 AM, Avi Kivity wrote: >> > > > As a baby step, is there any chance of publishing an automatic nightly >> > > > Windows (cross-)build as a .zi

Re: [Qemu-devel] Unmaintained QEMU builds

2010-09-05 Thread andrzej zaborowski
On 5 September 2010 19:51, Avi Kivity wrote: >  On 09/05/2010 08:44 PM, andrzej zaborowski wrote: >> >>>> I'm perfectly fine with dropping it.  btw, there are other features in >>>> qemu >>>> that seem to be academic exercises - *-user for exa

[Qemu-devel] Re: [PATCH 1/5] Suppress some gcc warnings with -Wtype-limits

2010-09-05 Thread andrzej zaborowski
On 5 September 2010 21:16, Blue Swirl wrote: > On Sun, Sep 5, 2010 at 5:02 PM, andrzej zaborowski wrote: >> On 5 September 2010 18:15, Blue Swirl wrote: >>> On Sun, Sep 5, 2010 at 3:26 PM, andrzej zaborowski >>> wrote: >>>> On 5 September 2010 11:44,

[Qemu-devel] Re: [PATCH 1/5] Suppress some gcc warnings with -Wtype-limits

2010-09-05 Thread andrzej zaborowski
On 5 September 2010 23:44, Blue Swirl wrote: > The problem case is when BLKDBG_EVENT_MAX > 0x8000 and the type of > enum is unsigned. Then the first check is ignored by the compiler and > the second does not catch values which are between 0x8000 and > BLKDBG_EVENT_MAX. This may not be what

Re: [Qemu-devel] Unknown command 0xffffff in SVGA command FIFO

2010-09-09 Thread andrzej zaborowski
Hi, On 16 August 2010 22:26, Janne Huttunen wrote: > Yes, your version works (both on paper and in practice). I'm not > quite sure I like the way it breaches the apparent abstraction > of the FIFO handling routines (if you can call it that) or the > way it first gives FIFO slots back to the guest

Re: [Qemu-devel] Re: [PATCH,curses] Fix contro...@[\]^_} and ESC

2010-10-21 Thread andrzej zaborowski
On 19 October 2010 19:48, Samuel Thibault wrote: > Hello, > > This apparently has been neither applied, nor commented on.  Could > either be done? Thanks, pushed the patch and sorry for missing the email the first time. Cheers

Re: [Qemu-devel] [PATCH] fix curses update - v2

2010-05-21 Thread andrzej zaborowski
Hi, I pushed a modified patch to preserve attributes such as background colour. Please check if this works for you. Cheers

Re: [Qemu-devel] [PATCH] Fix console_write_ch on 64-bit big-endian hosts

2010-06-02 Thread andrzej zaborowski
Hi, On 2 June 2010 20:58, Anthony Liguori wrote: > Currently, console_ch_t is defined as an unsigned long.  However, immediately > after it's definition, we treat it as a uint32_t *.  This will work on a > little > endian system because of the way bits are layed out but will fail miserably > on

Re: [Qemu-devel] [PATCH] Fix console_write_ch on 64-bit big-endian hosts

2010-06-02 Thread andrzej zaborowski
On 2 June 2010 22:32, Anthony Liguori wrote: > On 06/02/2010 02:31 PM, andrzej zaborowski wrote: >> It seems that what this really tries to do is like *dest = >> leul_to_cpu(v) from bswap.h? (Or cpu_to_leul.. quite difficult to wrap >> my head around it..) >> > >

Re: [Qemu-devel] [PATCH 20/58] vmstate: port pxa2xx_pic

2011-03-03 Thread andrzej zaborowski
On 24 February 2011 18:57, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- >  hw/pxa2xx_pic.c |   52 >  1 files changed, 20 insertions(+), 32 deletions(-) Hi Juan, I pushed an earlier patch from Dmitry Eremin-Solenikov that converte

Re: [Qemu-devel] [PATCH 02/10] pxa2xx_pic: update to use qdev and arm-pic

2011-03-03 Thread andrzej zaborowski
On 25 February 2011 14:50, Dmitry Eremin-Solenikov wrote: > On 2/25/11, andrzej zaborowski wrote: >> Hi Dmitry, >> >> On 20 February 2011 14:50, Dmitry Eremin-Solenikov >> wrote: >>> Use qdev/sysbus framework to handle pxa2xx-pic. Instead of exposing IR

Re: [Qemu-devel] [PATCH 1/2] pxa2xx_timer: separate irq for pxa27x handling

2011-03-09 Thread andrzej zaborowski
On 4 March 2011 01:40, Dmitry Eremin-Solenikov wrote: > First, sysbus_init_irq shan't be called on on-stack variables. Indeed, > it only stores a passed pointer in qdev and the stored irq is later > populated, so we get a nice write-to-stack bug. > Second, irq for pxa27x should probably be handled

Re: [Qemu-devel] [PATCH 1/2][RESEND] vl: initialize all displaystates

2011-03-09 Thread andrzej zaborowski
On 4 March 2011 01:48, Dmitry Eremin-Solenikov wrote: > Init not only first displaystate, but all. Otherwise machines with > multiple display devices (e.g. tosa, as it exists now) will just > segfault on ds switch. > > Signed-off-by: Dmitry Eremin-Solenikov > --- >  vl.c |  104 > +++

[Qemu-devel] Re: [PATCH 20/58] vmstate: port pxa2xx_pic

2011-03-09 Thread andrzej zaborowski
On 9 March 2011 12:42, Juan Quintela wrote: > andrzej zaborowski wrote: >> I pushed an earlier patch from Dmitry Eremin-Solenikov that converted >> this device, so this patch can be skipped.  Unfortunately some of your >> other patches may need rebasing now. > > Remove

[Qemu-devel] Re: [PATCH] tcg/arm: Support host code being compiled for Thumb

2011-03-23 Thread andrzej zaborowski
Hi, On 16 March 2011 16:21, Peter Maydell wrote: > Although the TCG generated code is always in ARM mode, it is possible > that the host code was compiled by gcc in Thumb mode (this is often the > default for Linux distributions targeting ARM v7 only). Handle this > by using BLX imm when doing a

Re: [Qemu-devel] Re: [PATCH 1/5] SharpSL scoop device - convert to qdev

2011-01-29 Thread andrzej zaborowski
Hi, On 26 January 2011 17:55, Dmitry Eremin-Solenikov wrote: > So what about theese patches? > > On 1/20/11, Dmitry Eremin-Solenikov wrote: >> Convert SharpSL scoop device to qdev, remove lots of supporting code, as >> lot of init and gpio related things can now be done automagically. >> >> Sign

Re: [Qemu-devel] [PATCH 08/11] Add scoop post_load callback that sets IRQs to loaded levels

2011-02-10 Thread andrzej zaborowski
Hi Dmitry, On 31 January 2011 16:20, Dmitry Eremin-Solenikov wrote: > Signed-off-by: Dmitry Eremin-Solenikov > --- >  hw/zaurus.c |   19 ++- >  1 files changed, 18 insertions(+), 1 deletions(-) > > diff --git a/hw/zaurus.c b/hw/zaurus.c > index fca11a5..90fedc9 100644 > --- a/hw/

Re: [Qemu-devel] [PATCH 05/11] pxa2xx_pic: update to use qdev and arm-pic

2011-02-10 Thread andrzej zaborowski
On 31 January 2011 16:20, Dmitry Eremin-Solenikov wrote: > pxa2xx_pic duplicated some code from arm-pic. Drop it, replacing with > references to arm-pic. Also use qdev/sysbus framework to handle > pxa2xx-pic. The duplication involves about 4 lines of code, at this level I strongly prefer to not a

Re: [Qemu-devel] [PATCH 05/11] pxa2xx_pic: update to use qdev and arm-pic

2011-02-11 Thread andrzej zaborowski
Hi, On 11 February 2011 21:24, Dmitry Eremin-Solenikov wrote: > On 2/11/11, Dmitry Eremin-Solenikov wrote: >> I just planned to later reuse allocated arm-pic IRQ's (the new one) to >> be passed to pxa2xx-gpio (to drop usage of cpu-env). I think. I can >> still allocate >> arm-pic but use only th

Re: [Qemu-devel] [PATCH 05/11] pxa2xx_pic: update to use qdev and arm-pic

2011-02-11 Thread andrzej zaborowski
On 11 February 2011 21:18, Dmitry Eremin-Solenikov wrote: > On 2/11/11, andrzej zaborowski wrote: >> On 31 January 2011 16:20, Dmitry Eremin-Solenikov >> wrote: >>> pxa2xx_pic duplicated some code from arm-pic. Drop it, replacing with >>> references to arm-pic.

Re: [Qemu-devel] [PATCH 1/7] Add scoop post_load callback that sets IRQs to loaded levels

2011-02-11 Thread andrzej zaborowski
On 11 February 2011 21:57, Dmitry Eremin-Solenikov wrote: > Signed-off-by: Dmitry Eremin-Solenikov > --- >  hw/zaurus.c |   19 ++- >  1 files changed, 18 insertions(+), 1 deletions(-) > > diff --git a/hw/zaurus.c b/hw/zaurus.c > index fca11a5..fb5e228 100644 > --- a/hw/zaurus.c >

Re: [Qemu-devel] [PATCH 1/3] mainstone: correct and simplify irq handling

2011-02-15 Thread andrzej zaborowski
On 12 February 2011 01:15, Dmitry Eremin-Solenikov wrote: > Simplify IRQ handling to stop setting an input irq pin. As a win, also get > correct IRQ status after save/load cycle. Thanks, I pushed the three patches from you but see a question below. > > Signed-off-by: Dmitry Eremin-Solenikov > -

Re: [Qemu-devel] [PATCH] mst_fpga: correct irq level settings

2011-02-25 Thread andrzej zaborowski
On 16 February 2011 14:22, Dmitry Eremin-Solenikov wrote: > Final corrections for IRQ levels that are set by mst_fpga: > > * Don't retranslate IRQ if previously IRQ was masked. > * After setting or clearing IRQs through register, apply mask >  before setting parent IRQ level. Thanks, applied this

Re: [Qemu-devel] [PATCH 02/10] pxa2xx_pic: update to use qdev and arm-pic

2011-02-25 Thread andrzej zaborowski
Hi Dmitry, On 20 February 2011 14:50, Dmitry Eremin-Solenikov wrote: > Use qdev/sysbus framework to handle pxa2xx-pic. Instead of exposing IRQs > via array, reference them via qdev_get_gpio_in(). Also pxa2xx_pic duplicated > some code from arm-pic. Drop it, replacing with references to arm-pic, >

Re: [Qemu-devel] Unknown command 0xffffff in SVGA command FIFO

2010-07-21 Thread andrzej zaborowski
Hi, On 21 July 2010 13:17, Janne Huttunen wrote: > Now, correct me if I'm wrong, but isn't vmsvga_fifo_run() called > from an asynchronous context (wrt the guest)? If that indeed is > so, it may very well be, that it is run while the guest is > modifying the FIFO. This means, that a command may f

Re: [Qemu-devel] Unknown command 0xffffff in SVGA command FIFO

2010-07-21 Thread andrzej zaborowski
On 21 July 2010 14:14, Janne Huttunen wrote: >> No, I think that can't happen, but it would be interesting to bisect >> what the guest is doing exactly when this happens.  The guest should >> not move the "next command" pointer before if has written the command >> entirely, this should be enough t

Re: [Qemu-devel] Unknown command 0xffffff in SVGA command FIFO

2010-07-22 Thread andrzej zaborowski
Sorry, tried to use get-send-email but haven't tested first. On 23 July 2010 03:35, wrote: > From: Andrzej Zaborowski ...

Re: [Qemu-devel] [PATCH] Added an option to set the VMDK adapter type

2010-08-04 Thread andrzej zaborowski
Hi, On 4 August 2010 12:30, Kevin Wolf wrote: > Am 04.08.2010 01:46, schrieb Aaron Mason: >> +    const char *real_filename, *temp_str, *adapterType = "ide"; Sorry to complain about style, but note that uppercase characters are not used in variable names in Qemu (that I see). Cheers

Re: [Qemu-devel] tcg/arm fixes and improvements

2010-03-02 Thread andrzej zaborowski
On 1 March 2010 22:33, Aurelien Jarno wrote: > This patch series fix a bug in div2/divu2 ops, implement setcond > and setcond2 ops and improve brcond/setcond by allowing immediate > constants. Thanks, pushed the four changes + added a missing break after setcond2. I'm not totally sure but I thin

Re: [Qemu-devel] Intel PXA270 System-on-chip emulation in QEMU

2010-03-02 Thread andrzej zaborowski
Hi Taimoor, On 1 March 2010 09:01, Taimoor Mirza wrote: > I want to know about Intel PXA270 System-on-chip emulation in QEMU. Does > this emulation includes "USB client controller" emulation? If you mean usb "slave" or "device" support, no, it's not supported by Qemu's PXA270 emulator. There is

Re: [Qemu-devel] [PATCH] Fix curses return key when using -k

2010-03-02 Thread andrzej zaborowski
On 28 February 2010 15:35, Samuel Thibault wrote: > Hello, > > There is a small incoherency in curses_keys.h, which makes it fail to > emit \n when using e.g. -k fr: curses2keysym transforms \r and 0x157 > into \n, but name2keysym binds \r with Return, not \n.  The patch below > fixes that. Thank

Re: [Qemu-devel] Intel PXA270 System-on-chip emulation in QEMU

2010-03-03 Thread andrzej zaborowski
On 3 March 2010 18:24, Taimoor Mirza wrote: > Can you tell me name of any platform which is emulated in QEMU and I can run > my USB device application on it? I mean I want to have board(emulated in > QEMU) behaving as a mass storage device (running mass storage application). The N800 and N810 can

Re: [Qemu-devel] [PATCH] fix curses update

2010-04-21 Thread andrzej zaborowski
Hi, On 20 April 2010 11:38, Bernhard Kauer wrote: > If a terminal is resized or the VGA model issues a full refresh, > curses_update() > is called, which uses mvwaddchnstr() to draw a full line of characters.   > Unfortunatelly > this routine expects a null-terminated string and early aborts if

[Qemu-devel] Re: [RFC, PATCH 2/2] bt-sdp: Fix if statement with empty body, spotted by clang

2010-04-21 Thread andrzej zaborowski
On 18 April 2010 10:52, Blue Swirl wrote: > Fix clang error: >  CC    bt-sdp.o > /src/qemu/hw/bt-sdp.c:174:17: error: if statement has empty body > [-Wempty-body] >    if (len > 1); > > However, fixing this means that some code that was previously > ignored by the compiler now gets compiled, resu

Re: [Qemu-devel] [PATCH 18/48] make cursor grab optional

2010-04-21 Thread andrzej zaborowski
On 26 March 2010 18:06, Riku Voipio wrote: > From: Riku Voipio > > Signed-Off-By: Riku Voipio > > --- >  sysemu.h |    1 + >  vl.c     |    1 + >  2 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/sysemu.h b/sysemu.h > index 525efd1..5b4ddd8 100644 > --- a/sysemu.h > +++ b/sysemu

Re: [Qemu-devel] Cortex m3 initialisation

2010-04-21 Thread andrzej zaborowski
On 14 March 2010 15:56, Benjamin Bagland wrote: > Hi, > > I'm having an issue while trying to use the lm3s811 board emulation with > qemu 0.12.3 or git. It works fine however with qemu-0.11.1. > > The problem comes from hw/armv7m.c, around line 231, the initial PC and SP > are set by reading from

[Qemu-devel] Re: vmstate: Useless post_save?

2010-05-10 Thread andrzej zaborowski
Hi, On 8 May 2010 00:39, Jan Kiszka wrote: > I wondered why we have the post_save callback in vmstate. Conceptually, > it made no sense to me. So I grep'ed for its users - and found exactly > one: tmp105. As suspected, only "strange" code was found: > > static void tmp105_post_save(void *opaque)

[Qemu-devel] Re: [PATCH v2 1/6] tmp105: Drop unused faults field

2010-05-15 Thread andrzej zaborowski
Hi Jan, On 15 May 2010 13:32, Jan Kiszka wrote: > From: Jan Kiszka > > It was only written, but never read. I pushed an alternate version to just move the update from post_save to post_load. If you think of code as documentation, the struct becomes less complete in representing the state of th

Re: [Qemu-devel] Unclear committer situation

2009-12-02 Thread andrzej zaborowski
2009/12/1 Alexander Graf : > Maintainership for a subsystem is completely different from "feeling > responsible for patches". You can be the person checking stuff in without > knowing anything about the subsystem. If it breaks, have the community fix > it. If it stays broken and nobody cares, re

Re: [Qemu-devel] Re: Unclear committer situation

2009-12-03 Thread andrzej zaborowski
2009/12/3 Michael S. Tsirkin : > On Wed, Dec 02, 2009 at 07:48:04PM +0100, Artyom Tarasenko wrote: >> Will have to find a way to persuade gmail not to wrap patches. > > gmail MSA/MTA does not wrap patches IMO. the web interface > does and IMO can not be told not to, so just find another MUA you lik

Re: [Qemu-devel] [PATCH] ioemu/qemu vga: save and restore vram buffer (revised)

2007-12-16 Thread andrzej zaborowski
Hi, On 12/12/2007, Ian Jackson <[EMAIL PROTECTED]> wrote: > The first one (stdvga-save-vram-update.patch) is against current > xen-unstable tip (which now includes my previous version) and should > be applied there. > > The second (stdvga-save-vram-take2.patch) is a fresh diff against the > same q

[Qemu-devel] qemu vl.c

2007-12-16 Thread Andrzej Zaborowski
CVSROOT:/sources/qemu Module name:qemu Changes by: Andrzej Zaborowski 07/12/16 11:48:54 Modified files: . : vl.c Log message: Support alternative formats for MAC addresses, by Balazs Attila-Mihaly. CVSWeb URLs: http://cvs.savannah.gnu.org

[Qemu-devel] qemu Makefile.target hw/pxa.h hw/pxa2xx.c hw/px...

2007-12-16 Thread Andrzej Zaborowski
CVSROOT:/sources/qemu Module name:qemu Changes by: Andrzej Zaborowski 07/12/16 12:13:51 Modified files: . : Makefile.target hw : pxa.h pxa2xx.c Added files: hw : pxa2xx_keypad.c Log message: Initial

[Qemu-devel] qemu/hw mainstone.c pxa2xx_keypad.c

2007-12-16 Thread Andrzej Zaborowski
CVSROOT:/sources/qemu Module name:qemu Changes by: Andrzej Zaborowski 07/12/16 12:19:43 Modified files: hw : mainstone.c pxa2xx_keypad.c Log message: Mainstone keypad support, by Armin Kuster. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs

Re: [Qemu-devel] [Patch 1/2v2][PXA27x] initial keypad support

2007-12-16 Thread andrzej zaborowski
On 13/12/2007, Armin <[EMAIL PROTECTED]> wrote: > Hello, > Here is a new series of keypad support patches for the PXA27x. > I believe I have addressed all the concerns from my first set of patch. Thanks! I just changed the use of cpu_abort to an exit() because cpu_single_env will typically be NULL

[Qemu-devel] qemu vl.c hw/pxa2xx_keypad.c

2007-12-16 Thread Andrzej Zaborowski
CVSROOT:/sources/qemu Module name:qemu Changes by: Andrzej Zaborowski 07/12/16 12:39:38 Modified files: . : vl.c hw : pxa2xx_keypad.c Log message: Work around a crash when timer signal occurs before main loop, original

Re: [Qemu-devel] Windows build crash problem

2007-12-16 Thread andrzej zaborowski
Hi, On 12/12/2007, 武田 俊也 <[EMAIL PROTECTED]> wrote: > I encountered the crash problem with windows build on Core-Duo host. > Qemu crashes in cpu_interrupt() called from host_alarm_handler() in vl.c > because CPUState *env = next_cpu is null. > > I tried the patch to check env is not null in host_a

Re: [Qemu-devel] Unable to run on Windows

2007-12-16 Thread andrzej zaborowski
On 14/12/2007, C.W. Betts <[EMAIL PROTECTED]> wrote: > When I try to run qemu with a disk image, I get a segmentation fault. When > I run it under GDB, this is the following error: > Program received signal SIGSEGV, Segmentation fault. > [Switching to thread 5516.0x15b0] > 0x0048e2f3 in cpu_interr

[Qemu-devel] qemu osdep.h

2007-12-16 Thread Andrzej Zaborowski
CVSROOT:/sources/qemu Module name:qemu Changes by: Andrzej Zaborowski 07/12/16 12:55:24 Modified files: . : osdep.h Log message: Add missing ffs() declaration for Win32 hosts, by Stefan Weil. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs

[Qemu-devel] qemu qemu-doc.texi linux-user/main.c

2007-12-16 Thread Andrzej Zaborowski
CVSROOT:/sources/qemu Module name:qemu Changes by: Andrzej Zaborowski 07/12/16 13:06:00 Modified files: . : qemu-doc.texi linux-user : main.c Log message: QEMU_STRACE documentation bit by Thayne Harbaugh. CVSWeb URLs: http

[Qemu-devel] qemu vl.c

2007-12-16 Thread Andrzej Zaborowski
CVSROOT:/sources/qemu Module name:qemu Changes by: Andrzej Zaborowski 07/12/16 13:17:13 Modified files: . : vl.c Log message: Redundant timer rearm optimisation by Anders Melchiorsen. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c

Re: [Qemu-devel] xen / qemu convergence ?

2007-12-17 Thread andrzej zaborowski
On 17/12/2007, Ian Jackson <[EMAIL PROTECTED]> wrote: > Paul Brook writes ("Re: [Qemu-devel] [PATCH] ioemu/qemu vga: save and > > restore vram buffer (revised)"): If you look closer, you'll find > > that s->vram_ptr actually points to an offset from phys_ram_base. So > > the VGA framebuffer is alre

Re: [Qemu-devel] qemu vl.c

2007-12-17 Thread andrzej zaborowski
On 18/12/2007, Anders <[EMAIL PROTECTED]> wrote: > > > Redundant timer rearm optimisation by Anders Melchiorsen. > > > I'm merging qemu-cvs into the kvm repository now, and with this commit > > in, kvm will hang after about a minute. Attaching to it with gdb or > > strace will cause it to re

Re: [Qemu-devel] New Qemu Crash found with evidence of memory corruption

2007-12-17 Thread andrzej zaborowski
On 16/12/2007, Andreas Schwab <[EMAIL PROTECTED]> wrote: > "Alexey Eremenko" <[EMAIL PROTECTED]> writes: > > > == > > The error seems to be in Qemu's readline.c: > > > > if (idx == TERM_MAX_CMDS) { > > /* Need to get one free slot */ > > free(term

Re: [Qemu-devel] Selective snapshots

2007-12-21 Thread andrzej zaborowski
On 21/12/2007, Laurent Vivier <[EMAIL PROTECTED]> wrote: > Le vendredi 21 décembre 2007 à 15:56 +, Ottavio Caruso a écrit : > > Hello, > > > > I have hd, hdb and hdd running in snasphot mode. > > > > Is it possible to have only hda in snapshot and have qemu writing to > > hdb and hdd as usual?

<    1   2   3   4   5   6   7   >