[PATCH v1 2/3]block: braces {} are necessary for all arms of this statement

2020-12-17 Thread chaihaoyu
This patch fixes error style problems found by checkpatch.pl, please review: braces {} are necessary for all arms of this statement Signed-off-by: Haoyu Chai --- block/bochs.c| 6 ++- block/commit.c | 3 +- block/curl.c | 15 +++-- block/file-posix.c | 27 ++---

[PATCH v1 1/3] some space-style errors while coding

2020-12-17 Thread chaihaoyu
This patch fixes error style problems found by checkpatch.pl, please review: some space-style errors while coding Signed-off-by: Haoyu Chai --- block/bochs.c| 10 block/cloop.c| 2 +- block/curl.c | 7 +++ block/dmg.c | 4 +- block/file-posix.c

[PATCH v1 0/3] Fix some style problems in block

2020-12-17 Thread chaihaoyu
This patch fixed some code style problems while using checkpatch.pl tool, please review. Date: Wen, 16 Dec 2020 17:19:37 +0800 Subject: [PATCH] Fix some style problems in block signed-off-by: Haoyu Chai --- Haoyu Chai (3): block: some space-style errors while coding block: braces {} are

[PATCH v1 3/3] block: "(foo*)" should be "(foo *)"

2020-12-17 Thread chaihaoyu
This patch fixes error style problems found by checkpatch.pl, please review: "(foo*)" should be "(foo *)" Signed-off-by: Haoyu Chai --- block/curl.c | 2 +- block/file-win32.c | 2 +- block/qcow2.c| 10 +++--- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git

[PATCH v2 3/3] softmmu: braces {} are necessary for all arms of this statement

2020-11-02 Thread chaihaoyu
Hi, recently I found some code style problems while using checkpatch.pl tool,please review. Date: Tue, 3 Nov 2020 10:09:34 +0800 Subject: [PATCH] braces {} are necessary for all arms of this statement signed-off-by: Haoyu Chai --- --- softmmu/cpus.c | 6 -- softmmu/dma-helpers.c |

[PATCH v2 2/3] softmmu: Don't use '#' flag of printf format

2020-11-02 Thread chaihaoyu
Hi, recently I found some code style problems while using checkpatch.pl tool,please review. Date: Tue, 3 Nov 2020 11:01:40 +0800 Subject: [PATCH] Don't use '#' flag of printf format signed-off-by: Haoyu Chai --- softmmu/device_tree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH v2 1/3] softmmu: Do not use C99 // comments

2020-11-02 Thread chaihaoyu
Hi, recently I found some code style problems while using checkpatch.pl tool,please review. Date: Tue, 3 Nov 2020 11:01:40 +0800 signed-off-by: Haoyu Chai --- softmmu/memory.c | 2 +- softmmu/memory_mapping.c | 2 +- softmmu/physmem.c| 2 +- 3 files changed, 3 insertions(+), 3

[PATCH v2 0/3] softmmu: some space-style problems while coding

2020-11-02 Thread chaihaoyu
Hi, recently I found some code style problems while using checkpatch.pl tool,please review. Date: Tue, 3 Nov 2020 11:19:37 +0800 Subject: [PATCH] space style signed-off-by: Haoyu Chai --- softmmu/physmem.c | 2 +- softmmu/qdev-monitor.c | 4 ++-- softmmu/vl.c | 12

[PATCH] spaces are required in some places

2020-10-29 Thread chaihaoyu
Date: Thu, 29 Oct 2020 22:01:33 +0800 signed-off-by: Haoyu Chai Reported-by: Euler Robot While reading softmmu related code, I found some style problems. Some spaces are required in softmmu/memory.c --- softmmu/memory.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-)

[PATCH 1/1] plugin: foo * bar should be foo *bar

2020-10-29 Thread chaihaoyu
Date: Thu, 29 Oct 2020 15:53:44 +0800 signed-off-by: Haoyu Chai Reported-by: Euler Robot --- plugins/api.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/api.c b/plugins/api.c index bbdc5a4eb4..9661824b89 100644 --- a/plugins/api.c +++ b/plugins/api.c @@ -309,7

Re: [PATCH v2 1/3] softmmu: Do not use C99 // comments

2020-11-03 Thread chaihaoyu
Thank you for your replay. That's OK if C99 support both kinds of comment style. > chaihaoyu writes: > >> Hi, recently I found some code style problems while using checkpatch.pl >> tool,please review. >> >> Date:

[PATCH v2 5/5] softmmu: code indent should never use tabs

2021-01-14 Thread chaihaoyu
This patch fixes error messages found by checkpatch.pl: code indent should never use tabs Signed-off-by: Haoyu Chai --- softmmu/physmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/softmmu/physmem.c b/softmmu/physmem.c index 43e37660c7..7aed899e3f 100644 ---

[PATCH v2 0/5] softmmu: some space-style problems while coding

2021-01-14 Thread chaihaoyu
recently I found some code style problems while using checkpatch.pl tool,please review. Haoyu Chai (5): softmmu: add spaces around operator softmmu: braces {} are needed for if statement softmmu: don't use '#' flag of printf format ('%#') in format strings softmmu: "foo* bar" should be "foo

[PATCH v2 1/5] softmmu: fix problems about spaces

2021-01-14 Thread chaihaoyu
This patch fixes error messages found by checkpatch.pl: fix problems about spaces: Signed-off-by: Haoyu Chai --- softmmu/bootdevice.c | 4 ++-- softmmu/memory.c | 16 softmmu/qdev-monitor.c | 4 ++-- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git

[PATCH v2 2/5] softmmu: braces {} are needed for if statement

2021-01-14 Thread chaihaoyu
This patch fixes error messages found by checkpatch.pl: braces {} are needed for if statement Signed-off-by: Haoyu Chai --- softmmu/cpus.c | 6 -- softmmu/dma-helpers.c | 3 ++- softmmu/memory.c | 3 ++- softmmu/physmem.c | 15 ++- softmmu/qdev-monitor.c

[PATCH v2 3/5] softmmu: don't use '#' flag of printf format ('%#') in format strings

2021-01-14 Thread chaihaoyu
This patch fixes error messages found by checkpatch.pl: don't use '#' flag of printf format ('%#') in format strings Signed-off-by: Haoyu Chai --- softmmu/device_tree.c | 2 +- softmmu/runstate.c| 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/softmmu/device_tree.c

[PATCH v2 4/5] softmmu: "foo* bar" should be "foo *bar"

2021-01-14 Thread chaihaoyu
This patch fixes error messages found by checkpatch.pl: "foo* bar" should be "foo *bar" Signed-off-by: Haoyu Chai --- softmmu/globals.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/softmmu/globals.c b/softmmu/globals.c index 7d0fc81183..341a7029ff 100644 ---

[PATCH] plugin: foo * bar should be foo *bar

2021-01-14 Thread chaihaoyu
recently I a code style problem while using checkpatch.pl tool,please review. foo * bar should be foo *bar: Signed-off-by: Haoyu Chai --- plugins/api.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/api.c b/plugins/api.c index bbdc5a4eb4..9661824b89 100644 ---