Re: [Qemu-devel] snabbswitch integration with QEMU for userspace ethernet I/O

2013-05-29 Thread ronnie sahlberg
Julian, Stefan's concerns are valid. (Hopefully, kernel is harder to exploit and more carefully audited.) On Wed, May 29, 2013 at 9:02 AM, Julian Stecklina jstec...@os.inf.tu-dresden.de wrote: On 05/29/2013 04:21 PM, Stefan Hajnoczi wrote: The fact that a single switch process has shared

Re: [Qemu-devel] [PATCHv7 00/17] block: logical block provisioning enhancements

2013-11-08 Thread ronnie sahlberg
For better support for older versions of libiscsi I think it would be good to convert all the iscsi_unmap_task/iscsi_writesame*_task/iscsi_*_task functions with calls to the much more genric iscsi_scsi_command_sync(). iscsi_scsi_command_sync() and iscsi_scsi_command_async() have been available

Re: [Qemu-devel] [PATCHv7 00/17] block: logical block provisioning enhancements

2013-11-08 Thread ronnie sahlberg
It would mean that any version of libiscsi from 1.1 or later would work and there would not be the issues such as UNMAP is only available from 1.2 and forward, WRITESAME* is only availabel from 1.3. SANITIZE only being available from 1.9 ... On Fri, Nov 8, 2013 at 9:52 AM, ronnie sahlberg

Re: [Qemu-devel] [PATCH v2 20/20] scsi-disk: correctly implement WRITE SAME

2013-11-19 Thread ronnie sahlberg
+#define SCSI_WRITE_SAME_MAX 524288 ... +data-iov.iov_len = MIN(data-nb_sectors * 512, SCSI_WRITE_SAME_MAX); I don't think you should just clamp the data to 512k, instead I think you should report the 512k max write same size through BlockLimitsVPD/MaximumWriteSameLength to the

Re: [Qemu-devel] [PATCH v2 20/20] scsi-disk: correctly implement WRITE SAME

2013-11-19 Thread ronnie sahlberg
That means the initiator will do the split into smaller manageable chunks for you and you get a 1-to-1 mapping between WS10/16 that the initiator issues to qemu and the write-same calls that qemu generates. On Tue, Nov 19, 2013 at 9:23 AM, ronnie sahlberg ronniesahlb...@gmail.com wrote: +#define

Re: [Qemu-devel] [PATCHv2 02/11] iscsi: read unmap info from block limits vpd page

2013-07-02 Thread ronnie sahlberg
max_unmap : If the target does not return an explicit limit for max_unmap it will return 0x which means no limit. I think you should add a check for max_unmap and clamp it down to something sane. Maybe a maximum of 128M ? Same for bdc, that should also be checked and clamped down to

Re: [Qemu-devel] [PATCHv2 02/11] iscsi: read unmap info from block limits vpd page

2013-07-05 Thread ronnie sahlberg
The device MIGHT map or anchor the blocks after the unmap but it may only do so if the blocks that become mapped are all zero. So I think you can safely assume that if lbprz==1 then it will always read back as zero no matter what happens internally in the target. Either the block becomes

Re: [Qemu-devel] [PATCHv2 02/11] iscsi: read unmap info from block limits vpd page

2013-07-06 Thread ronnie sahlberg
and sent a zero block. this would allow an optimization also if lbprz == 0. in this case i would not set the unmap bit. peter Am 05.07.2013 um 09:11 schrieb ronnie sahlberg ronniesahlb...@gmail.com: The device MIGHT map or anchor the blocks after the unmap but it may only do so

Re: [Qemu-devel] [PATCH 4/4] qemu-img: conditionally discard target on convert

2013-07-17 Thread ronnie sahlberg
need to check what LogicalBlocksPerPhysicalBlockExponent is. ) regards ronnie sahlberg

Re: [Qemu-devel] [PATCH 4/4] qemu-img: conditionally discard target on convert

2013-07-17 Thread ronnie sahlberg
On Wed, Jul 17, 2013 at 9:27 AM, Paolo Bonzini pbonz...@redhat.com wrote: Il 17/07/2013 17:54, ronnie sahlberg ha scritto: I think it is reasonable to assume that IF LBPRZ==1 and IF it is an optimal unmap request then the blocks will become unmapped and they will read back as 0. Yes

Re: [Qemu-devel] [PATCH 4/4] qemu-img: conditionally discard target on convert

2013-07-17 Thread ronnie sahlberg
On Wed, Jul 17, 2013 at 10:02 AM, Peter Lieven p...@kamp.de wrote: For Disks we always use read/write16 so i think we Should also use writesame16. Or not? Sounds good. Von meinem iPhone gesendet Am 17.07.2013 um 18:31 schrieb ronnie sahlberg ronniesahlb...@gmail.com: On Wed, Jul 17

Re: [Qemu-devel] [PATCH 4/4] qemu-img: conditionally discard target on convert

2013-07-18 Thread ronnie sahlberg
On Thu, Jul 18, 2013 at 6:29 AM, Peter Lieven p...@kamp.de wrote: On 18.07.2013 14:31, Paolo Bonzini wrote: Il 18/07/2013 13:04, Peter Lieven ha scritto: But if you set BDRV_DISCARD_WRITE_ZEROES, then you always need a fallback to bdrv_write_zeroes. Why not just call bdrv_write_zeroes to

Re: [Qemu-devel] [PATCH 4/4] qemu-img: conditionally discard target on convert

2013-07-18 Thread ronnie sahlberg
BlockLimitsVPD OptimalUnmapGranularity also applies to unmapping with writesame16 : An OPTIMAL UNMAP GRANULARITY field set to a non-zero value indicates the optimal granularity in logical blocks for unmap requests (e.g., an UNMAP command or a WRITE SAME (16) command with the UNMAP bit set to

Re: [Qemu-devel] [PATCH 4/4] qemu-img: conditionally discard target on convert

2013-07-19 Thread ronnie sahlberg
On Thu, Jul 18, 2013 at 11:08 PM, Peter Lieven p...@kamp.de wrote: On 19.07.2013 07:58, Paolo Bonzini wrote: Il 18/07/2013 21:28, Peter Lieven ha scritto: thanks for the details. I think to have optimal performance and best change for unmapping in qemu-img convert it might be best to export

Re: [Qemu-devel] [PATCH 4/4] qemu-img: conditionally discard target on convert

2013-07-19 Thread ronnie sahlberg
On Thu, Jul 18, 2013 at 11:43 AM, Peter Lieven p...@kamp.de wrote: Am 18.07.2013 um 16:35 schrieb Paolo Bonzini pbonz...@redhat.com: Il 18/07/2013 16:32, Peter Lieven ha scritto: (Mis)alignment and granularity can be handled later. We can ignore them for now. Later, if we decide the best

Re: [Qemu-devel] [PATCH 4/4] qemu-img: conditionally discard target on convert

2013-07-19 Thread ronnie sahlberg
On Fri, Jul 19, 2013 at 6:49 AM, Peter Lieven p...@kamp.de wrote: On 19.07.2013 15:25, ronnie sahlberg wrote: On Thu, Jul 18, 2013 at 11:08 PM, Peter Lieven p...@kamp.de wrote: On 19.07.2013 07:58, Paolo Bonzini wrote: Il 18/07/2013 21:28, Peter Lieven ha scritto: thanks for the details

Re: [Qemu-devel] [Bug 1191606] Re: qemu crashes with iscsi initiator (libiscsi) when using virtio

2013-06-18 Thread ronnie sahlberg
I can reproduce with current QEMU. Ubuntu 13 crashes with if=virtio but if=ide is fine. But it seems dependent on the guest/kernel. For example Fedora-18-x86_64-Live-Desktop.iso installs and runs just fine, even with virtio But both ubuntu-12.04-desktop-amd64.iso or

Re: [Qemu-devel] [Bug 1191606] Re: qemu crashes with iscsi initiator (libiscsi) when using virtio

2013-06-20 Thread ronnie sahlberg
comment out SG_IO in iscsi_ioctl then the crash does not happen (but the qemu does nto get serial number either) I will look more into it tonight. On Wed, Jun 19, 2013 at 2:17 AM, Laszlo Ersek ler...@redhat.com wrote: On 06/19/13 06:34, ronnie sahlberg wrote: I can reproduce with current QEMU

Re: [Qemu-devel] [Bug 1191606] Re: qemu crashes with iscsi initiator (libiscsi) when using virtio

2013-06-20 Thread ronnie sahlberg
On Thu, Jun 20, 2013 at 7:47 AM, Laszlo Ersek ler...@redhat.com wrote: On 06/20/13 15:33, ronnie sahlberg wrote: http://pastebin.com/EuwZPna1 Last few thousand lines from the log with your patch. The crash happens immediately after qemu has called out to iscsi_ioctl with SG_IO to read

[Qemu-devel] [PATCH] iSCSI fix crash when using virtio and libiscsi

2013-06-20 Thread Ronnie Sahlberg
against a current libiscsi. I will send patches later to remove the current (LIBISCSI_FEATURE_IOVECTOR) checks in the rest of the file. regards ronnie sahlberg

[Qemu-devel] [PATCH] Fix iSCSI crash on SG_IO with an iovector

2013-06-20 Thread Ronnie Sahlberg
Don't assume that SG_IO is always invoked with a simple buffer, check the iovec_count and if it is 1 then we need to pass an array of iovectors to libiscsi instead of just a plain buffer. Signed-off-by: Ronnie Sahlberg ronniesahlb...@gmail.com --- block/iscsi.c | 31

Re: [Qemu-devel] [PATCH] iSCSI fix crash when using virtio and libiscsi

2013-06-21 Thread ronnie sahlberg
I can add the checks and resubmit. On Fri, Jun 21, 2013 at 12:38 AM, Paolo Bonzini pbonz...@redhat.com wrote: Il 21/06/2013 04:32, Ronnie Sahlberg ha scritto: Stefan, List Please find a patch that fixes the crashes for using virtio with libiscsi. The problem was that block/iscsi.c always

Re: [Qemu-devel] [PATCH 1/2] iscsi: add support for bdrv_co_is_allocated()

2013-06-21 Thread ronnie sahlberg
Should we really mix co-routines and AIO in the same backend? Would it not be better to instead add a new bdrb_aio_is_allocaed and use non-blocking async calls to libiscsi ? On Fri, Jun 21, 2013 at 2:18 AM, Kevin Wolf kw...@redhat.com wrote: Am 20.06.2013 um 20:20 hat Peter Lieven geschrieben:

Re: [Qemu-devel] [PATCH 1/2] iscsi: add support for bdrv_co_is_allocated()

2013-06-21 Thread ronnie sahlberg
On Fri, Jun 21, 2013 at 10:06 AM, Peter Lieven p...@kamp.de wrote: Am 21.06.2013 18:31, schrieb Paolo Bonzini: Il 21/06/2013 13:07, Kevin Wolf ha scritto: Note that you're blocking here. The preferred way would be something involving a yield from the coroutine and a reenter as soon as all

[Qemu-devel] [PATCH] iSCSI fix crash when using virtio and libiscsi V2

2013-06-21 Thread Ronnie Sahlberg
or not. If not we fall back to either lots of datain buffers or a serialization dataout buffer. regards ronnie sahlberg

[Qemu-devel] [PATCH] Fix iSCSI crash on SG_IO with an iovector

2013-06-21 Thread Ronnie Sahlberg
Don't assume that SG_IO is always invoked with a simple buffer, check the iovec_count and if it is 1 then we need to pass an array of iovectors to libiscsi instead of just a plain buffer. Signed-off-by: Ronnie Sahlberg ronniesahlb...@gmail.com --- block/iscsi.c | 56

[Qemu-devel] [PATCH] iSCSI fix crash when using virtio and libiscsi V3

2013-06-23 Thread Ronnie Sahlberg
List, Please find a new version of the patch to fix the iSCSI crash when ioctl with iovector is sent. Updated to fix the commit message as per lerseks suggestion. Also added an explicit cast to suppress a compiler warning when we dont have iovector support available.

[Qemu-devel] [PATCH] Fix iSCSI crash on SG_IO with an iovector

2013-06-23 Thread Ronnie Sahlberg
Don't assume that SG_IO is always invoked with a simple buffer, check the iovec_count and if it is = 1 then we need to pass an array of iovectors to libiscsi instead of just a plain buffer. Signed-off-by: Ronnie Sahlberg ronniesahlb...@gmail.com --- block/iscsi.c | 56

Re: [Qemu-devel] [PATCH] block: add native support for NFS

2013-12-16 Thread ronnie sahlberg
simply be specified by an url of the form: nfs://host/export/filename For example: qemu-img create -f qcow2 nfs://10.0.0.1/qemu-images/test.qcow2 You need libnfs from Ronnie Sahlberg available at: git://github.com/sahlberg/libnfs.git for this to work. During configure

Re: [Qemu-devel] [PATCH] block: add native support for NFS

2013-12-16 Thread ronnie sahlberg
For example: qemu-img create -f qcow2 nfs://10.0.0.1/qemu-images/test.qcow2 You need libnfs from Ronnie Sahlberg available at: git://github.com/sahlberg/libnfs.git for this to work. During configure it is automatically probed for libnfs and support is enabled on-the-fly. You can forbid

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-17 Thread ronnie sahlberg
can simply be specified by an url of the form: nfs://host/export/filename For example: qemu-img create -f qcow2 nfs://10.0.0.1/qemu-images/test.qcow2 You need libnfs from Ronnie Sahlberg available at: git://github.com/sahlberg/libnfs.git for this to work. During configure

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-17 Thread ronnie sahlberg
On Tue, Dec 17, 2013 at 9:03 AM, Peter Lieven p...@kamp.de wrote: On 17.12.2013 17:47, Stefan Hajnoczi wrote: ... Which NFS protocol versions are supported by current libnfs? Will check that out. Ronnie? It uses NFS v3 only.

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-17 Thread ronnie sahlberg
On Tue, Dec 17, 2013 at 9:03 AM, Peter Lieven p...@kamp.de wrote: On 17.12.2013 17:47, Stefan Hajnoczi wrote: On Tue, Dec 17, 2013 at 10:15:25AM +0100, Peter Lieven wrote: ... +if (nfs_pwrite_async(client-context, client-fh, + sector_num * BDRV_SECTOR_SIZE, +

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-17 Thread ronnie sahlberg
On Tue, Dec 17, 2013 at 2:36 PM, Peter Lieven p...@kamp.de wrote: Am 17.12.2013 um 18:13 schrieb ronnie sahlberg ronniesahlb...@gmail.com: On Tue, Dec 17, 2013 at 9:03 AM, Peter Lieven p...@kamp.de wrote: On 17.12.2013 17:47, Stefan Hajnoczi wrote: ... Which NFS protocol versions

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-18 Thread ronnie sahlberg
On Wed, Dec 18, 2013 at 2:00 AM, Orit Wasserman owass...@redhat.com wrote: On 12/18/2013 01:03 AM, Peter Lieven wrote: Am 17.12.2013 um 18:32 schrieb Daniel P. Berrange berra...@redhat.com: On Tue, Dec 17, 2013 at 10:15:25AM +0100, Peter Lieven wrote: This patch adds native support for

[Qemu-devel] [PATCH 1/1] iscsi: add iSCSI block device support

2010-11-21 Thread ronnie sahlberg
functionality The syntax to specify a iscsi resource is iscsi://host[:port]/target-iqn-name/lun Example : -drive file=iscsi://127.0.0.1:3260/iqn.ronnie.test/1 -cdrom iscsi://127.0.0.1:3260/iqn.ronnie.test/2 Please review and/or commit. regards ronnie sahlberg

Re: [Qemu-devel] [PATCH 1/1] iscsi: add iSCSI block device support

2010-11-21 Thread ronnie sahlberg
On Mon, Nov 22, 2010 at 10:13 AM, FUJITA Tomonori fujita.tomon...@lab.ntt.co.jp wrote: On Mon, 22 Nov 2010 09:17:50 +1100 ronnie sahlberg ronniesahlb...@gmail.com wrote: This patch adds support for attaching directorly to iSCSI resources, both DISK/SBC and CDROM/MMC, without the need to make

Re: [Qemu-devel] [PATCH 1/1] iscsi: add iSCSI block device support

2010-11-24 Thread ronnie sahlberg
single thread. (I assume your VirtualBOX performance problem was not the threading in itself but that the threads use blocking calls?) regards ronnie sahlberg

Re: [Qemu-devel] [Patch 0/14] builtin iscsi support

2010-12-03 Thread ronnie sahlberg
into qemu. I would very much like to see bus=scsi make this layer a transparent passthrough layer too, just like it is today for the special case where the file specified matches /dev/sg ronnie sahlberg

Re: [Qemu-devel] [Patch 0/14] builtin iscsi support

2010-12-03 Thread ronnie sahlberg
, I think there are a lot of work in other areas that kvm/qemu does not need/use before it can become standalone. regards ronnie sahlberg

Re: [Qemu-devel] [PATCH 01/14] ./block/iscsi/init.c

2010-12-03 Thread ronnie sahlberg
. Stefan Thanks Ronnie Sahlberg

[Qemu-devel] (no subject)

2010-12-13 Thread Ronnie Sahlberg
Please find a new block driver that IF libiscsi is present on the system will link with this userspace client library and make qemu able to access iscsi devices directly without exposing them to the host. The library used is multiplatform and available from git://github.com/sahlberg/libiscsi.git

[Qemu-devel] [PATCH] libiscsi

2010-12-13 Thread Ronnie Sahlberg
/iqn.ronnie.test/1 -cdrom iscsi://10.1.1.1:3260/iqn.ronnie.test/2 Signed-off-by: Ronnie Sahlberg ronniesahlb...@gmail.com --- Makefile.objs |2 +- block/iscsi.c | 528 + configure | 29 +++ 3 files changed, 558 insertions(+), 1 deletions

Re: [Qemu-devel] [PATCH] libiscsi

2010-12-20 Thread ronnie sahlberg
Thanks. I have implemented all of your suggestions and will submit version 2 of the patch shortly. regards ronnie sahlberg On Tue, Dec 14, 2010 at 7:47 AM, Blue Swirl blauwir...@gmail.com wrote: On Mon, Dec 13, 2010 at 8:05 AM, Ronnie Sahlberg ronniesahlb...@gmail.com wrote: This patch adds

Re: [Qemu-devel] scsi-generic and max request size

2010-12-20 Thread ronnie sahlberg
it. :-( sg_inq --page=0x00 /dev/sg? will show you what inq pages your device supports. regards ronnie sahlberg On Tue, Dec 21, 2010 at 2:25 PM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: Hi folks ! There's an odd problem I've encountered with my scsi host (basically an powerpc vscsi

[Qemu-devel] [PATCH 0/1] iSCSI support

2010-12-25 Thread Ronnie Sahlberg
the need to expose these LUNs to the host. The patch has been updated based on input from review of the initial patch as well as had CHAP authentication added. Please review and/or apply Ronnie Sahlberg

[Qemu-devel] [PATCH] iSCSI support

2010-12-25 Thread Ronnie Sahlberg
explicitely at several palces in the code. - Use the name opaque instead of private_data - Use memset() instead of bzero() Other changes - Use the common library function to parse the iSCSI URL - Add support for CHAP authentication Signed-off-by: Ronnie Sahlberg ronniesahlb...@gmail.com

Re: [Qemu-devel] [PATCH] iSCSI support

2011-02-26 Thread ronnie sahlberg
Hi Stefan Thanks for reviewing the patch. I have addressed all your items, some with comments below, and will resubmit the patch shortly. Comments below. regards ronnie sahlberg On Sun, Feb 20, 2011 at 2:34 AM, Stefan Hajnoczi stefa...@gmail.com wrote: On Fri, Feb 4, 2011 at 4:37 AM

[Qemu-devel] iSCSI block driver support

2011-02-26 Thread Ronnie Sahlberg
The following patch adds a new block driver to QEMU/KVM for iSCSI. This utilizes the userspace client library for iscsi at https://github.com/sahlberg/libiscsi and will link with this library if available. This allows using iSCSI resources with QEMU/KVM without making them visible to the

[Qemu-devel] [PATCH] iSCSI block driver support

2011-02-26 Thread Ronnie Sahlberg
, the password can optionally be set with LIBISCSI_CHAP_PASSWORD=password to avoid it showing up in the process list Example: -drive file=iscsi://10.1.1.1:3260/iqn.ronnie.test/1 -cdrom iscsi://10.1.1.1:3260/iqn.ronnie.test/2 Signed-off-by: Ronnie Sahlberg ronniesahlb...@gmail.com --- Makefile.objs

Re: [Qemu-devel] [PATCH] iSCSI: add configuration variables for iSCSI

2011-12-22 Thread ronnie sahlberg
? regards ronnie sahlberg On Mon, Dec 19, 2011 at 12:48 AM, Paolo Bonzini pbonz...@redhat.com wrote: On 12/18/2011 05:48 AM, Ronnie Sahlberg wrote: This patch adds configuration variables for iSCSI to set initiator-name to use when logging in to the target, which type of header-digest to negotiate

Re: [Qemu-devel] OEM Windows in Qemu

2011-12-22 Thread ronnie sahlberg
Why not just buy a non-OEM version ? They are surely not tied to a specific piece of hardware and its licence should allow to run on arbitrary PC HW you happen to want to install/run it on once activated On Fri, Dec 23, 2011 at 5:11 PM, in...@expertcomputerrepair.com wrote: My patch does

Re: [Qemu-devel] [PATCH] iSCSI: add configuration variables for iSCSI

2011-12-23 Thread ronnie sahlberg
one, called before -S monitor is invoked */ .open_stage_2() /* called after -S finishes and when it starts to boot the guest CPU */ ? regards ronnie sahlberg On Fri, Dec 23, 2011 at 8:08 PM, Paolo Bonzini pbonz...@redhat.com wrote: On 12/22/2011 09:51 PM, ronnie sahlberg wrote

Re: [Qemu-devel] [PATCH] iSCSI: add configuration variables for iSCSI

2012-01-20 Thread ronnie sahlberg
On Thu, Jan 19, 2012 at 11:17 PM, Kevin Wolf kw...@redhat.com wrote: Am 18.12.2011 05:48, schrieb Ronnie Sahlberg: This patch adds configuration variables for iSCSI to set initiator-name to use when logging in to the target, which type of header-digest to negotiate with the target

[Qemu-devel] [PATCH] Add configuration variables for iscsi

2012-01-21 Thread Ronnie Sahlberg
ronnie sahlberg

[Qemu-devel] [PATCH] iSCSI: add configuration variables for iSCSI

2012-01-21 Thread Ronnie Sahlberg
different targets, you can also configure this on a per target basis by using a group name: [iscsi iqn.target.name] ... Signed-off-by: Ronnie Sahlberg ronniesahlb...@gmail.com --- block/iscsi.c | 139 +++ qemu-config.c | 27

[Qemu-devel] Patch to add iSCSI configuration options

2011-11-26 Thread Ronnie Sahlberg
setting to negotiate * chap username * chap password Documentation for both manpage and qemu-doc are also updated regards ronnie sahlberg

[Qemu-devel] [PATCH] iSCSI: add configuration variables for iSCSI

2011-11-26 Thread Ronnie Sahlberg
-doc Signed-off-by: Ronnie Sahlberg ronniesahlb...@gmail.com --- block/iscsi.c | 107 +- qemu-config.c | 27 ++ qemu-doc.texi | 28 ++- qemu-options.hx | 16 ++-- vl.c|8 5 files

[Qemu-devel] Patch to add iSCSI configuration optionsi. Version 2

2011-12-17 Thread Ronnie Sahlberg
List, Please find attached a patch that adds configuration variables for iSCSI to set CHAP username/password, header-digest settings and the iqn to use when logging in to the target. The patch is updated to produce an error if the username is set but no password was given. regards ronnie

[Qemu-devel] [PATCH] iSCSI: add configuration variables for iSCSI

2011-12-17 Thread Ronnie Sahlberg
-doc Signed-off-by: Ronnie Sahlberg ronniesahlb...@gmail.com --- block/iscsi.c | 114 ++- qemu-config.c | 27 + qemu-doc.texi | 28 +- qemu-options.hx | 16 ++-- vl.c|8 5 files

[Qemu-devel] (no subject)

2011-06-11 Thread Ronnie Sahlberg
Please find attached a patch to add built-in support for iSCSI into QEMU. Please review and/or apply this patch. This is the latest version of this patch and I think I have addressed all previous concerns and suggestions. Using built-in iSCSI support has many advantages for certain use cases :

[Qemu-devel] [PATCH] iSCSI block driver support

2011-06-11 Thread Ronnie Sahlberg
-by: Ronnie Sahlberg ronniesahlb...@gmail.com --- Makefile.objs |1 + block/iscsi.c | 596 + configure | 31 +++ trace-events |6 + 4 files changed, 634 insertions(+), 0 deletions(-) create mode 100644 block/iscsi.c diff --git

[Qemu-devel] iSCSI support for QEMU

2011-06-11 Thread ronnie sahlberg
Sorry about the missing subject line in the previous mail Got confused when using git-send-patch :-) regards ronnie sahlberg On Sun, Jun 12, 2011 at 12:47 PM, Ronnie Sahlberg ronniesahlb...@gmail.com wrote: Please find attached a patch to add built-in support for iSCSI into QEMU. Please review

Re: [Qemu-devel] [PATCH] This patch adds a new block driver : iSCSI

2011-10-25 Thread ronnie sahlberg
was confusing. I have changed it from failed to finished since this part is executed for both normal and failures. Thanks Ronnie Sahlberg From f5fc5880a3071188dbfec903bc1ea1247a1e375c Mon Sep 17 00:00:00 2001 From: Ronnie Sahlberg ronniesahlb...@gmail.com Date: Tue, 25 Oct 2011 19:03:18 +1100 Subject

Re: [Qemu-devel] [PATCH] This patch adds a new block driver : iSCSI

2011-10-25 Thread ronnie sahlberg
Hi, On Tue, Oct 25, 2011 at 7:17 PM, Kevin Wolf kw...@redhat.com wrote: Am 25.10.2011 10:04, schrieb ronnie sahlberg: iscsi_destroy_url() is only ever called here. Do we leak it in the normal path? It didnt leak but the the label was confusing. I have changed it from failed to finished

[Qemu-devel] [PATCH 0/0] Add mention of iSCSI devices to manpage

2011-10-26 Thread Ronnie Sahlberg
List Following patch adds a new section to the manpage to describe the special URL syntax used for various block backends. It adds a subsection with examples on the newly added iSCSI backend. Perhaps all other backeds can be added with examples to this section as well? In which case I add

[Qemu-devel] [PATCH] Documentation: add new section for device URL syntax for special files and describe the iSCSI URL with examples

2011-10-26 Thread Ronnie Sahlberg
Signed-off-by: Ronnie Sahlberg ronniesahlb...@gmail.com --- qemu-options.hx | 42 ++ 1 files changed, 42 insertions(+), 0 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index 5d2a776..7c434f8 100644 --- a/qemu-options.hx +++ b/qemu

[Qemu-devel] [PATCH 0/0] Add description on NBD URL to manpage

2011-10-27 Thread Ronnie Sahlberg
Please find a patch to add a description of the NBD URL to the manpage. This describes both TCP and domain socket syntax. (I could not actually test the domain syntax case since my nbd-server crashes:-( ) regards ronnie sahlberg

[Qemu-devel] [PATCH] Documentation: Describe NBD URL syntax

2011-10-27 Thread Ronnie Sahlberg
This patch adds a short description of how to specify a NBD device to QEMU. Syntax for both TCP and Unix Domain Sockets are provided as well as examples. Signed-off-by: Ronnie Sahlberg ronniesahlb...@gmail.com --- qemu-options.hx | 21 + 1 files changed, 21 insertions(+), 0

[Qemu-devel] [PATCH 0/0] Manpage. Fix typo and add Sheepdog description

2011-10-28 Thread Ronnie Sahlberg
These patches 1, fixes a typo in a previous patch NDB - NBD 2, adds description of sheepdog URL syntax to the manpage

[Qemu-devel] [PATCH 1/2] Documentation: Fix typo in manpage. NDB - NBD

2011-10-28 Thread Ronnie Sahlberg
Signed-off-by: Ronnie Sahlberg ronniesahlb...@gmail.com --- qemu-options.hx |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index bf2ebb3..c55080c 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -1761,10 +1761,10 @@ compiled

[Qemu-devel] [PATCH 2/2] Documentation: Add syntax for using sheepdog devices

2011-10-28 Thread Ronnie Sahlberg
Signed-off-by: Ronnie Sahlberg ronniesahlb...@gmail.com --- qemu-options.hx | 27 +++ 1 files changed, 27 insertions(+), 0 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index c55080c..38d0f57 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -1778,6

Re: [Qemu-devel] [PATCH 2/2] Documentation: Add syntax for using sheepdog devices

2011-10-28 Thread ronnie sahlberg
for example show how to create an image and export via STGT so that QEMU can access it as an iscsi lun. regards ronnie sahlberg On Fri, Oct 28, 2011 at 8:32 PM, Kevin Wolf kw...@redhat.com wrote: Am 28.10.2011 11:13, schrieb Eric Sunshine: On Oct 28, 2011, at 5:13 AM, Ronnie Sahlberg wrote

[Qemu-devel] (no subject)

2011-11-11 Thread Ronnie Sahlberg
that part of the patch if you think this does not belong in the qemu docs. regards ronnie sahlberg

[Qemu-devel] [PATCH] Documentation: Add section about iSCSI LUNS to qemu-doc

2011-11-11 Thread Ronnie Sahlberg
Add a new section about using iSCSI LUNs with qemu and provide a short example on how to set up a target and access it using the built-in initiator Signed-off-by: Ronnie Sahlberg ronniesahlb...@gmail.com --- qemu-doc.texi | 53 + 1 files

[Qemu-devel] Patch to add iSCSI documentation

2011-11-11 Thread Ronnie Sahlberg
List, Please find an updated patch to add documentation for iSCSI and a simple example how to set up a target to use with qemu. It addresses the issues rised by the review of the first patch. regards ronnie sahlberg

[Qemu-devel] [PATCH] Documentation: Add section about iSCSI LUNS to qemu-doc

2011-11-11 Thread Ronnie Sahlberg
Add a new section about using iSCSI LUNs with qemu and provide a short example on how to set up a target and access it using the built-in initiator Signed-off-by: Ronnie Sahlberg ronniesahlb...@gmail.com --- qemu-doc.texi | 56 1 files

Re: [Qemu-devel] [PATCH] Documentation: Add section about iSCSI LUNS to qemu-doc

2011-11-11 Thread ronnie sahlberg
Hi, On Sat, Nov 12, 2011 at 10:11 AM, Andreas Färber andreas.faer...@web.de wrote: Hi, Am 11.11.2011 22:46, schrieb Ronnie Sahlberg: Add a new section about using iSCSI LUNs with qemu and provide a short example on how to set up a target and access it using the built-in initiator Signed

[Qemu-devel] [PATCH] Add iSCSI support for QEMU

2011-09-09 Thread Ronnie Sahlberg
and use iSCSI resources without the need for root privilege on the host to map the devices to local scsi devices. Please merge this patch to master or explain how I should change the patch so that it becomes acceptable for inclusion into QEMU. regards ronnie sahlberg

[Qemu-devel] [PATCH] This patch adds a new block driver : iSCSI

2011-09-09 Thread Ronnie Sahlberg
-off-by: Ronnie Sahlberg ronniesahlb...@gmail.com --- Makefile.objs |1 + block/iscsi.c | 594 + configure | 31 +++ trace-events |7 + 4 files changed, 633 insertions(+), 0 deletions(-) create mode 100644 block/iscsi.c diff

Re: [Qemu-devel] [PATCH] Add iSCSI support for QEMU

2011-09-14 Thread ronnie sahlberg
that can be used, so yes, I could build a small simple iscsi target at some stage for qemu for usecases where TGTD or other solutions are inconvenient. regards ronnie sahlberg

Re: [Qemu-devel] [PATCH] This patch adds a new block driver : iSCSI

2011-09-14 Thread ronnie sahlberg
variables : LIBISCSI_CHAP_USERNAME=... LIBISCSI_CHAP_PASSWORD=... I will document this better in the next patch. Libiscsi only support CHAP at this stage. Which other authentication schemes do you have in mind? Perhaps I can add them. regards ronnie sahlberg

Re: [Qemu-devel] [PATCH] This patch adds a new block driver : iSCSI

2011-09-14 Thread ronnie sahlberg
of 512 bytes since a read-modify-write cycle across a network would probably be prohibitively expensive. .bdrv_flush() I can easily add a synchronous implementation of this unless your patch is expected to be merged in the near future. regards ronnie sahlberg On Mon, Sep 12, 2011 at 7:14 PM

Re: [Qemu-devel] [PATCH] This patch adds a new block driver : iSCSI

2011-09-15 Thread ronnie sahlberg
I would not really want to make too many statements in the area other than in some tests I performed, performance was good enough for my use. I would be very happy if someone competent in tuning qemu/scsi/open-iscsi (==that means, not me) would do a real comparasion. regards ronnie sahlberg

[Qemu-devel] [PATCH] Add iSCSI support for QEMU

2011-09-21 Thread Ronnie Sahlberg
that it becomes acceptable for inclusion into QEMU. regards ronnie sahlberg

[Qemu-devel] [PATCH] This patch adds a new block driver : iSCSI

2011-09-21 Thread Ronnie Sahlberg
authentication, the password can optionally be set with LIBISCSI_CHAP_PASSWORD=password to avoid it showing up in the process list Signed-off-by: Ronnie Sahlberg ronniesahlb...@gmail.com --- Makefile.objs |1 + block/iscsi.c | 596

Re: [Qemu-devel] [PATCH] This patch adds a new block driver : iSCSI

2011-09-21 Thread ronnie sahlberg
Stefan, Thanks for your review. I feel that iscsi would be beneficial for several usecases. I have implemented all changes you pointed out, except two, and resent an updated patch to the list. Please see below. regards ronnie sahlberg On Mon, Sep 12, 2011 at 7:14 PM, Stefan Hajnoczi stefa

Re: [Qemu-devel] [PATCH] This patch adds a new block driver : iSCSI

2011-09-21 Thread ronnie sahlberg
On Wed, Sep 21, 2011 at 7:45 PM, Paolo Bonzini pbonz...@redhat.com wrote: On 09/21/2011 11:37 AM, Ronnie Sahlberg wrote: This driver interfaces with the multiplatform posix library for iscsi initiator/client access to iscsi devices hosted at     git://github.com/sahlberg/libiscsi.git Do you

Re: [Qemu-devel] [PATCH] This patch adds a new block driver : iSCSI

2011-09-27 Thread ronnie sahlberg
List, What remains before this patch can be accepted? Previous patch received good feedback and severa people indicated that they would find the feature useful for several use cases. regards ronnie sahlberg On Wed, Sep 21, 2011 at 7:52 PM, ronnie sahlberg ronniesahlb...@gmail.com wrote: On Wed

Re: [Qemu-devel] [PATCH] This patch adds a new block driver : iSCSI

2011-10-09 Thread ronnie sahlberg
ping? On Thu, Sep 29, 2011 at 4:54 PM, Stefan Hajnoczi stefa...@linux.vnet.ibm.com wrote: On Wed, Sep 21, 2011 at 07:37:55PM +1000, Ronnie Sahlberg wrote: This provides built-in support for iSCSI to QEMU. This has the advantage that the iSCSI devices need not be made visible to the host

Re: [Qemu-devel] [PATCH] This patch adds a new block driver : iSCSI

2011-10-13 Thread ronnie sahlberg
sahlberg On Mon, Oct 10, 2011 at 7:46 AM, ronnie sahlberg ronniesahlb...@gmail.com wrote: ping? On Thu, Sep 29, 2011 at 4:54 PM, Stefan Hajnoczi stefa...@linux.vnet.ibm.com wrote: On Wed, Sep 21, 2011 at 07:37:55PM +1000, Ronnie Sahlberg wrote: This provides built-in support for iSCSI

[Qemu-devel] website

2011-10-14 Thread ronnie sahlberg
http://wiki.qemu.org/Main_Page Someone may want to have a look over the website, the links in the Contribute section in the column on the left. All pages seem to primarily discuss the quality of Pandora jewelry and how beneficial it would be to purchase such.

[Qemu-devel] iSCSI support for QEMU

2011-04-21 Thread Ronnie Sahlberg
: 387 seconds QEMU with cache=none,aio=native : 218 seconds Please review and consider for inclusion. regards ronnie sahlberg From: Ronnie Sahlberg ronniesahlb...@gmail.com Subject: iSCSI support for QEMU In-Reply-To:

[Qemu-devel] [PATCH] iSCSI block driver support

2011-04-21 Thread Ronnie Sahlberg
, the password can optionally be set with LIBISCSI_CHAP_PASSWORD=password to avoid it showing up in the process list Example: -drive file=iscsi://10.1.1.1:3260/iqn.ronnie.test/1 -cdrom iscsi://10.1.1.1:3260/iqn.ronnie.test/2 Signed-off-by: Ronnie Sahlberg ronniesahlb...@gmail.com --- Makefile.objs

Re: [Qemu-devel] iSCSI support for QEMU

2011-04-21 Thread ronnie sahlberg
since it does not cache at all, ever. regards ronnie sahlberg On Thu, Apr 21, 2011 at 6:50 PM, Christoph Hellwig h...@lst.de wrote: On Thu, Apr 21, 2011 at 06:43:10PM +1000, Ronnie Sahlberg wrote: Some basic tests thatve been performed show it to be significantly faster than an out-of-the-box

Re: [Qemu-devel] iSCSI support for QEMU

2011-04-21 Thread ronnie sahlberg
is strange. I would like discussion about the merits of my patch and if features like built-in iscsi support that enterprise users find useful are desireable in QEMU. I do not find discussions about semantics of my particular iscsi target to be meaningful for that purpose. regards ronnie sahlberg

Re: [Qemu-devel] iSCSI support for QEMU

2011-04-21 Thread ronnie sahlberg
. As long as libiscsi is not significantly worse than open-iscsi I care very little about why. regards ronnie sahlberg On Thu, Apr 21, 2011 at 7:09 PM, Christoph Hellwig h...@lst.de wrote: In my patch, there are NO data integrity issues. Data is sent out on the wire immediately as the guest

Re: [Qemu-devel] iSCSI support for QEMU

2011-04-21 Thread ronnie sahlberg
On Thu, Apr 21, 2011 at 8:58 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Thu, Apr 21, 2011 at 10:28 AM, ronnie sahlberg ronniesahlb...@gmail.com wrote: On Thu, Apr 21, 2011 at 7:09 PM, Christoph Hellwig h...@lst.de wrote: We only claim WCE=1 to the guest if cache=writeback or cache=none

Re: [Qemu-devel] iSCSI support for QEMU

2011-04-21 Thread ronnie sahlberg
Stephan, I understand. Let me re-send a patch tomorrow that can optionally enable/force FUA bits for write. There are some high-volume arrays that advertise support but fail any cdb with FUA, FUA_NV bits set with sense, so it needs to be made optional. regards ronnie sahlberg On Thu, Apr 21

Re: [Qemu-devel] iSCSI support for QEMU

2011-04-21 Thread ronnie sahlberg
On Thu, Apr 21, 2011 at 10:49 PM, Christoph Hellwig h...@lst.de wrote: On Thu, Apr 21, 2011 at 09:36:12PM +1000, ronnie sahlberg wrote: There are some high-volume arrays that advertise support but fail any cdb with FUA, FUA_NV bits set with sense, so it needs to be made optional. Which

  1   2   3   >