Re: [PATCH v7 09/10] virtio-gpu: Support Venus capset

2024-04-11 Thread Antonio Caggiano
for virtio-gpu. Signed-off-by: Antonio Caggiano --- diff --git a/hw/display/virtio-gpu-virgl.c b/hw/display/virtio-gpu-virgl.c index 9f34d0e661..0e9e4ebcbb 100644 --- a/hw/display/virtio-gpu-virgl.c +++ b/hw/display/virtio-gpu-virgl.c @@ -371,17 +371,13 @@ static void virgl_cmd_get_capset_info(VirtIOGPU

Re: [PATCH v6 02/11] virtio-gpu: Configure new feature flag context_create_with_flags for virglrenderer

2023-12-19 Thread Antonio Caggiano
Hi Huang Rui, Thank you for this new version. All patches which I did not sign off are reviewed by me :) Cheers, Antonio Caggiano On 19/12/2023 08:53, Huang Rui wrote: Configure a new feature flag (context_create_with_flags) for virglrenderer. Originally-by: Antonio Caggiano Signed-off

Re: [PATCH] tests/avocado/virtio-gpu: Fix test_vhost_user_vga_virgl for edid support

2023-11-15 Thread Antonio Caggiano
did" instead of "-edid" now! While we're at it, move the expected string to the preceeding exec_command_and_wait_for_pattern() instead (since waiting for empty string here does not make too much sense). Signed-off-by: Thomas Huth Reviewed-by: Antonio Caggiano --- tests/av

Re: [PATCH for 8.2] ui/gtk-egl: move function calls back to regular code path

2023-11-13 Thread Antonio Caggiano
anout_texture() back to the regular code path so they get always called if one of the gd_egl_init() calls was successful. Fixes: 6f189a08c1 ("ui/gtk-egl: Check EGLSurface before doing scanout") Signed-off-by: Volker Rümelin Reviewed by: Antonio Caggiano --- ui/gtk-egl.c | 12 ++

Re: QEMU Virtio GPU features status & roadmap?

2023-11-08 Thread Antonio Caggiano
Hi Marc-André, On 08/11/2023 12:07, Marc-André Lureau wrote: Hi On Wed, Nov 8, 2023 at 1:04 PM Antonio Caggiano wrote: Hi Hans, +cc Gert and Dmitry On 17/10/2023 02:48, Hans de Ruiter wrote: Hi, I'm working on Virtio GPU drivers for AmigaOS, and would like to know what features

Re: QEMU Virtio GPU features status & roadmap?

2023-11-08 Thread Antonio Caggiano
Hi Hans, +cc Gert and Dmitry On 17/10/2023 02:48, Hans de Ruiter wrote: Hi, I'm working on Virtio GPU drivers for AmigaOS, and would like to know what features are currently stable enough to use. Looking at the master QEMU branch, both Virgl and blob resources are supported, but NOT at the

Re: [RFC] mem: Fix mem region size when is UINT64_MAX

2023-10-24 Thread Antonio Caggiano
+cc Mark which has a better understanding of our use case. On 24/10/2023 15:21, Peter Maydell wrote: On Tue, 24 Oct 2023 at 13:31, Antonio Caggiano wrote: On 24/10/2023 14:00, Peter Maydell wrote: On Tue, 24 Oct 2023 at 11:49, Antonio Caggiano wrote: Given that we don't run

Re: [RFC] mem: Fix mem region size when is UINT64_MAX

2023-10-24 Thread Antonio Caggiano
On 24/10/2023 14:00, Peter Maydell wrote: On Tue, 24 Oct 2023 at 11:49, Antonio Caggiano wrote: Hi Peter, Thanks for the quick response. On 24/10/2023 12:28, Peter Maydell wrote: On Tue, 24 Oct 2023 at 10:45, Antonio Caggiano wrote: This looks like a bug. When the size is `UINT64_MAX

Re: [RFC] mem: Fix mem region size when is UINT64_MAX

2023-10-24 Thread Antonio Caggiano
Hi Peter, Thanks for the quick response. On 24/10/2023 12:28, Peter Maydell wrote: On Tue, 24 Oct 2023 at 10:45, Antonio Caggiano wrote: This looks like a bug. When the size is `UINT64_MAX`, it is reset to (Int128)`1 << 64` which actually is `UINT64_MAX + 1`. Then, an assert is tri

[RFC] mem: Fix mem region size when is UINT64_MAX

2023-10-24 Thread Antonio Caggiano
us one. Signed-off-by: Antonio Caggiano --- system/memory.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/system/memory.c b/system/memory.c index a800fbc9e5..d41fc6af88 100644 --- a/system/memory.c +++ b/system/memory.c @@ -1193,9 +1193,6 @@ static void memory_region_do_init(MemoryRegi

Re: [PATCH] gtk: force realization of drawing area

2023-10-18 Thread Antonio Caggiano
Reviewed-by: Antonio Caggiano On 17/10/2023 13:16, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Fixes the GL context creation from a widget that isn't yet realized (in a hidden tab for example). Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1727 Signed-off-by: Marc

[PATCH v2] ui/gtk-egl: Check EGLSurface before doing scanout

2023-10-16 Thread Antonio Caggiano
that point, the gd_egl_init() will succeed and the EGLContext and EGLSurface stored in the VirtualGfxConsole will be valid. Signed-off-by: Antonio Caggiano Reviewed-by: Marc-André Lureau --- ui/gtk-egl.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/ui/gtk-egl.c b/ui

[PATCH] ui/gtk-egl: Check EGLSurface before doing scanout

2023-10-13 Thread Antonio Caggiano
that point, the gd_egl_init() will succeed and the EGLContext and EGLSurface stored in the VirtualGfxConsole will be valid. Signed-off-by: Antonio Caggiano --- ui/gtk-egl.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/ui/gtk-egl.c b/ui/gtk-egl.c index a1060fd80f..

Re: [QEMU PATCH v4 12/13] virtio-gpu: Initialize Venus

2023-08-31 Thread Antonio Caggiano
Hi Huang, Thank you for pushing this forward! On 31/08/2023 11:32, Huang Rui wrote: From: Antonio Caggiano Request Venus when initializing VirGL. Signed-off-by: Antonio Caggiano Signed-off-by: Huang Rui --- v1->v2: - Rebase to latest version hw/display/virtio-gpu-virgl.c

Re: [PATCH 17/21] virtio-gpu-virgl: teach it to get the QEMU EGL display

2023-08-30 Thread Antonio Caggiano
Thanks for your answer, that'll help. On 30/08/2023 13:49, Marc-André Lureau wrote: Hi Antonio On Wed, Aug 30, 2023 at 3:14 PM Antonio Caggiano wrote: Hi Marc-André, I've been testing this, but I can't find where qemu_egl_display is set when using sdl. Whil ui/gtk.c sets

Re: [PATCH 17/21] virtio-gpu-virgl: teach it to get the QEMU EGL display

2023-08-30 Thread Antonio Caggiano
that (e.g. as opposed to GLX)? Kind regards, Antonio Caggiano On 06/06/2023 13:56, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau virgl offers a few features that require to have access to the underlying EGLDisplay. This is the case for the D3D texture sharing support. The API callback

Re: [PATCH 17/21] virtio-gpu-virgl: teach it to get the QEMU EGL display

2023-08-30 Thread Antonio Caggiano
that (e.g. as opposed to GLX)? Kind regards, Antonio Caggiano On 06/06/2023 13:56, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau virgl offers a few features that require to have access to the underlying EGLDisplay. This is the case for the D3D texture sharing support. The API callback

Re: [PATCH v12 8/9] gfxstream + rutabaga: enable rutabaga

2023-08-25 Thread Antonio Caggiano
"ati-vga", .flag = _vga }, { .driver = "vhost-user-vga", .flag = _vga }, { .driver = "virtio-vga-gl",.flag = _vga }, +{ .driver = "virtio-vga-rutabaga", .flag = _vga }, }; static QemuOptsList qemu_rtc_opts = { Patches 5 to 9: Reviewed-by: Antonio Caggiano Cheers, Antonio

hvf: Invalid ISV on data abort

2023-08-02 Thread Antonio Caggiano
Hi there, I am trying to bring up a guest on HVF, which at a certain point is trying to write to an area of mmio space and it triggers a data abort where ISV=0 (translation fault level 2). I wonder what could cause it and how to recover. Kind regards, Antonio

[PATCH v5] ui/sdl2: OpenGL window context

2023-06-12 Thread Antonio Caggiano
When OpenGL is enabled, create only the OpenGL context, ignoring the SDL renderer as it is unused anyway. Signed-off-by: Antonio Caggiano Reviewed-by: Marc-André Lureau --- v2: There is no need to specify major and minor version if the SDL renderer is not created. Also, tested on Windows

[PATCH v4] ui/sdl2: OpenGL window context

2023-06-12 Thread Antonio Caggiano
When OpenGL is enabled, create only the OpenGL context, ignoring the SDL renderer as it is unused anyway. Signed-off-by: Antonio Caggiano --- v2: There is no need to specify major and minor version if the SDL renderer is not created. Also, tested on Windows. v3: Completely messed up

[PATCH] ui/sdl2: OpenGL window context

2023-06-12 Thread Antonio Caggiano
When OpenGL is enabled, create only the OpenGL context, ignoring the SDL renderer as it is unused anyway. Signed-off-by: Antonio Caggiano --- ui/sdl2.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/ui/sdl2.c b/ui/sdl2.c index 9d703200bf..0d91b555e3

[PATCH v2] ui/sdl2: OpenGL window context

2023-06-09 Thread Antonio Caggiano
When OpenGL is enabled, create only the OpenGL context, ignoring the SDL renderer as it is unused anyway. Signed-off-by: Antonio Caggiano --- v2: There is no need to specify major and minor version if the SDL renderer is not created. Also, tested on Windows. ui/sdl2.c | 21

[PATCH v3] ui/sdl2: OpenGL window context

2023-06-09 Thread Antonio Caggiano
When OpenGL is enabled, create only the OpenGL context, ignoring the SDL renderer as it is unused anyway. Signed-off-by: Antonio Caggiano --- v2: There is no need to specify major and minor version if the SDL renderer is not created. Also, tested on Windows. v3: Completely messed up

Re: [PATCH] sdl2: Check if window exists before updating it

2023-06-09 Thread Antonio Caggiano
Reviewed-by: Antonio Caggiano On 08/06/2023 16:55, Akihiko Odaki wrote: A console does not have a window if the surface is a placeholder and the console is not the first one. sdl2 cannot update the texture in such a case. Add a proper check for window existence. Such a check is only necessary

Re: [PATCH] ui/sdl2: Support multiple OpenGL-enabled windows

2023-06-08 Thread Antonio Caggiano
Hi Marc-André and Akihiko, On 07/06/2023 13:24, Akihiko Odaki wrote: On 2023/06/07 19:29, Marc-André Lureau wrote: Hi Antonio On Wed, Jun 7, 2023 at 1:13 PM Antonio Caggiano mailto:quic_acagg...@quicinc.com>> wrote:     Multiple graphics devices can be defined with an associated

[PATCH v3] hvf: Report HV_DENIED error

2023-06-08 Thread Antonio Caggiano
On MacOS 11 and subsequent versions, in case the resulting binary is not signed with the proper entitlement, handle and report the HV_DENIED error. Signed-off-by: Antonio Caggiano --- v2: Use architecture specific defines from AvailabilityMacros.h to enable the HV_DENIED case only on MacOS

Re: [PATCH] ui/sdl2: Allow high-dpi

2023-06-08 Thread Antonio Caggiano
Hi Marc-André, On 07/06/2023 12:21, Marc-André Lureau wrote: Hi Antonio On Wed, Jun 7, 2023 at 1:05 PM Antonio Caggiano wrote: Add the SDL_WINDOW_ALLOW_HIGHDPI flag when creating a window and get the drawable size instead of the window size when setting up the framebuffer and the viewport

[PATCH] ui/sdl2: Support multiple OpenGL-enabled windows

2023-06-07 Thread Antonio Caggiano
Multiple graphics devices can be defined with an associated OpenGL enabled SDL console, hence make sure to not destroy their shaders and windows. Signed-off-by: Antonio Caggiano --- ui/sdl2-gl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/sdl2-gl.c b/ui/sdl2-gl.c

[PATCH] ui/sdl2: Allow high-dpi

2023-06-07 Thread Antonio Caggiano
Add the SDL_WINDOW_ALLOW_HIGHDPI flag when creating a window and get the drawable size instead of the window size when setting up the framebuffer and the viewport. Signed-off-by: Antonio Caggiano --- ui/sdl2-gl.c | 4 ++-- ui/sdl2.c| 2 +- 2 files changed, 3 insertions(+), 3 deletions

[PATCH v2] hvf: Report HV_DENIED error

2023-06-07 Thread Antonio Caggiano
On MacOS 11 and subsequent versions, in case the resulting binary is not signed with the proper entitlement, handle and report the HV_DENIED error. Signed-off-by: Antonio Caggiano --- v2: Use architecture specific defines from AvailabilityMacros.h to enable the HV_DENIED case only on MacOS

Re: [PATCH] hvf: Handle EC_INSNABORT

2023-06-01 Thread Antonio Caggiano
Hi Peter, On 01/06/2023 16:58, Peter Maydell wrote: On Thu, 1 Jun 2023 at 15:33, Antonio Caggiano wrote: Instead of aborting immediately, try reading the physical address where the instruction should be fetched by calling address_space_read. This would give any memory regions ops callback

[PATCH] hvf: Handle EC_INSNABORT

2023-06-01 Thread Antonio Caggiano
. Then, if the memory transaction is OK, retry HVF execution at the same PC. Signed-off-by: Antonio Caggiano Co-authored-by: Mark Burton --- target/arm/hvf/hvf.c | 12 1 file changed, 12 insertions(+) diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c index ad65603445..6e527254b1

[PATCH] hvf: Report HV_DENIED error

2023-06-01 Thread Antonio Caggiano
In case the resulting binary is not signed with the proper entitlement, handle and report the HV_DENIED error. Signed-off-by: Antonio Caggiano --- accel/hvf/hvf-all.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/accel/hvf/hvf-all.c b/accel/hvf/hvf-all.c index 0043f4d308..679907a147

[PATCH] SDL: OpenGL 3 window context

2023-06-01 Thread Antonio Caggiano
SDL renderer creates an OpenGL 2.1 context while QEMU expects minimum OpenGL version 3.3 or ES 3.0. To fix this we create an OpenGL context directly, ignoring the SDL renderer when OpenGL is enabled. Signed-off-by: Antonio Caggiano --- ui/sdl2.c | 34 ++ 1 file

Re: [PATCH RFC 1/1] memory: Address space map listener

2023-04-05 Thread Antonio Caggiano
Hi David, On 05/04/23 15:23, David Hildenbrand wrote: On 05.04.23 14:57, Antonio Caggiano wrote: Introduce a MemoryListener callback for address space map events. Why? Please, have a look at the cover letter "[PATCH RFC 0/1] MemoryListener address_space_map callback" wit

[PATCH RFC 1/1] memory: Address space map listener

2023-04-05 Thread Antonio Caggiano
owing the model used for MemoryRegion and MemoryRegionOps. Signed-off-by: Antonio Caggiano --- include/exec/memory.h | 19 +++ softmmu/physmem.c | 34 ++ 2 files changed, 53 insertions(+) diff --git a/include/exec/memory.h b/include/exec/memory.h index 7e

[PATCH RFC 0/1] MemoryListener address_space_map callback

2023-04-05 Thread Antonio Caggiano
he memory listener callbacks: while it currently uses "self" as first argument for the callbacks, this new approach is going to use an "opaque" member, effectively following the model used for MemoryRegion and MemoryRegionOps. Antonio Caggiano (1): memory: Address space map lis

[PATCH RFC 1/1] memory: Address space map listener

2023-04-05 Thread Antonio Caggiano
owing the model used for MemoryRegion and MemoryRegionOps. Signed-off-by: Antonio Caggiano --- include/exec/memory.h | 19 +++ softmmu/physmem.c | 34 ++ 2 files changed, 53 insertions(+) diff --git a/include/exec/memory.h b/include/exec/memory.h index 7e

[PATCH v3 9/9] virtio-gpu: Get EGL Display callback

2022-09-26 Thread Antonio Caggiano
Implement get_egl_display callback for virglrenderer. Signed-off-by: Antonio Caggiano --- hw/display/virtio-gpu-virgl.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/hw/display/virtio-gpu-virgl.c b/hw/display/virtio-gpu-virgl.c index 0f17b0..0fd9ad8a3d 100644

[PATCH v3 5/9] virtio-gpu: Unrealize

2022-09-26 Thread Antonio Caggiano
Implement an unrealize function for virtio gpu device. Signed-off-by: Antonio Caggiano --- v3: Call virtio_gpu_base_device_unrealize from virtio_gpu_device_unrealize hw/display/virtio-gpu-base.c | 2 +- hw/display/virtio-gpu.c| 11 +++ include/hw/virtio/virtio-gpu.h | 1

[PATCH v3 4/9] virtio-gpu: CONTEXT_INIT feature

2022-09-26 Thread Antonio Caggiano
Create virgl renderer context with flags using context_id when valid. The feature can be enabled via the context_init config option. A warning message will be emitted and the feature will not be used when linking with virglrenderer versions without context_init support. Signed-off-by: Antonio

[PATCH v3 2/9] virtio-gpu: hostmem

2022-09-26 Thread Antonio Caggiano
From: Gerd Hoffmann Use VIRTIO_GPU_SHM_ID_HOST_VISIBLE as id for virtio-gpu. Signed-off-by: Antonio Caggiano Acked-by: Michael S. Tsirkin --- v3: Formatting fixes hw/display/virtio-gpu-pci.c| 15 +++ hw/display/virtio-gpu.c| 1 + hw/display/virtio-vga.c| 33

[PATCH v3 7/9] virtio-gpu: Support Venus capset

2022-09-26 Thread Antonio Caggiano
Add support for the Venus capset, which enables Vulkan support through the Venus Vulkan driver for virtio-gpu. Signed-off-by: Antonio Caggiano --- v3: Improve commit message hw/display/virtio-gpu-virgl.c | 21 + include/standard-headers/linux/virtio_gpu.h | 2

[PATCH v3 8/9] virtio-gpu: Initialize Venus

2022-09-26 Thread Antonio Caggiano
Request Venus when initializing VirGL. Signed-off-by: Antonio Caggiano --- hw/display/virtio-gpu-virgl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/display/virtio-gpu-virgl.c b/hw/display/virtio-gpu-virgl.c index 16f600adbb..0f17b0 100644 --- a/hw/display/virtio

[PATCH v3 1/9] virtio: Add shared memory capability

2022-09-26 Thread Antonio Caggiano
Dr. David Alan Gilbert Signed-off-by: Antonio Caggiano --- v3: - Remove virtio_pci_shm_cap as virtio_pci_cap64 is used instead. - No need for mask32 as cpu_to_le32 truncates the value. hw/virtio/virtio-pci.c | 18 ++ include/hw/virtio/virtio-pci.h | 4 2 files c

[PATCH v3 3/9] virtio-gpu: Handle resource blob commands

2022-09-26 Thread Antonio Caggiano
Support BLOB resources creation, mapping and unmapping by calling the new stable virglrenderer 0.10 interface. Only enabled when available and via the blob config. E.g. -device virtio-vga-gl,blob=true Signed-off-by: Antonio Caggiano Signed-off-by: Dmitry Osipenko --- v3: Fix memory leaks

[PATCH v3 6/9] virtio-gpu: Resource UUID

2022-09-26 Thread Antonio Caggiano
Enable resource UUID feature and implement command resource assign UUID. This is done by introducing a hash table to map resource IDs to their UUIDs. Signed-off-by: Antonio Caggiano --- v3: Destroy the hash table in the unrealize function hw/display/trace-events| 1 + hw/display

[PATCH v3 0/9] virtio-gpu: Support Venus Vulkan driver

2022-09-26 Thread Antonio Caggiano
resource commands. Antonio Caggiano (7): virtio-gpu: Handle resource blob commands virtio-gpu: CONTEXT_INIT feature virtio-gpu: Unrealize virtio-gpu: Resource UUID virtio-gpu: Support Venus capset virtio-gpu: Initialize Venus virtio-gpu: Get EGL Display callback Dr. David Alan

Re: [PATCH] virtio-gpu: Resource UUID

2022-09-23 Thread Antonio Caggiano
Hi Marc-André, On 23/09/2022 10:38, Marc-André Lureau wrote: Hi On Wed, Sep 21, 2022 at 1:24 PM Antonio Caggiano mailto:antonio.caggi...@collabora.com>> wrote: Enable resource UUID feature and implement command resource assign UUID. This is done by introducing a hash table

[PATCH v2 0/2] virtio-gpu: Resource UUID

2022-09-23 Thread Antonio Caggiano
Enable resource UUID feature and implement command resource assign UUID. Antonio Caggiano (2): virtio-gpu: Unrealize virtio-gpu: Resource UUID hw/display/trace-events| 1 + hw/display/virtio-gpu-base.c | 2 ++ hw/display/virtio-gpu-virgl.c | 11 hw/display/virtio-gpu.c

Re: [PATCH] virtio-gpu: Resource UUID

2022-09-23 Thread Antonio Caggiano
Hi Marc-André, On 23/09/2022 10:38, Marc-André Lureau wrote: Hi On Wed, Sep 21, 2022 at 1:24 PM Antonio Caggiano mailto:antonio.caggi...@collabora.com>> wrote: Enable resource UUID feature and implement command resource assign UUID. This is done by introducing a hash table

[PATCH v2 2/2] virtio-gpu: Resource UUID

2022-09-23 Thread Antonio Caggiano
Enable resource UUID feature and implement command resource assign UUID. This is done by introducing a hash table to map resource IDs to their UUIDs. Signed-off-by: Antonio Caggiano --- v2: Destroy the hash table in the unrealize function hw/display/trace-events| 1 + hw/display

[PATCH v2 1/2] virtio-gpu: Unrealize

2022-09-23 Thread Antonio Caggiano
Implement an unrealize function for virtio gpu device. Signed-off-by: Antonio Caggiano --- hw/display/virtio-gpu.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c index 20cc703dcc..412f0fb7ec 100644 --- a/hw/display/virtio-gpu.c

[PATCH] virtio-gpu: Resource UUID

2022-09-21 Thread Antonio Caggiano
Enable resource UUID feature and implement command resource assign UUID. This is done by introducing a hash table to map resource IDs to their UUIDs. Signed-off-by: Antonio Caggiano --- hw/display/trace-events| 1 + hw/display/virtio-gpu-base.c | 2 ++ hw/display/virtio-gpu-virgl.c

[PATCH v5 1/1] virtio-gpu: CONTEXT_INIT feature

2022-09-19 Thread Antonio Caggiano
Create virgl renderer context with flags using context_id when valid. The feature can be enabled via the context_init config option. A warning message will be emitted and the feature will not be used when linking with virglrenderer versions without context_init support. Signed-off-by: Antonio

[PATCH v5 0/1] virtio-gpu: CONTEXT_INIT feature

2022-09-19 Thread Antonio Caggiano
://github.com/oasis-tcs/virtio-spec/commit/aad2b6f3620ec0c9d16aaf046db8c282c24cce3e [2] https://www.mail-archive.com/qemu-devel@nongnu.org/msg827304.html Antonio Caggiano (1): virtio-gpu: CONTEXT_INIT feature hw/display/virtio-gpu-base.c | 3 +++ hw/display/virtio-gpu-virgl.c | 16

[PATCH v3 0/4] virtio-gpu: Blob resources

2022-09-19 Thread Antonio Caggiano
Add shared memory and support blob resource creation, mapping and unmapping through virglrenderer new stable APIs[0] when available. [0] https://gitlab.freedesktop.org/virgl/virglrenderer/-/merge_requests/891 Antonio Caggiano (1): virtio-gpu: Handle resource blob commands Dmitry Osipenko (1

[PATCH v3 1/4] virtio: Add shared memory capability

2022-09-19 Thread Antonio Caggiano
Dr. David Alan Gilbert Signed-off-by: Antonio Caggiano --- v2: Remove virtio_pci_shm_cap as virtio_pci_cap64 is used instead. v3: No need for mask32 as cpu_to_le32 truncates the value. hw/virtio/virtio-pci.c | 18 ++ include/hw/virtio/virtio-pci.h | 4 2 files c

[PATCH v3 3/4] virtio-gpu: Handle resource blob commands

2022-09-19 Thread Antonio Caggiano
Support BLOB resources creation, mapping and unmapping by calling the new stable virglrenderer 0.10 interface. Only enabled when available and via the blob config. E.g. -device virtio-vga-gl,blob=true Signed-off-by: Antonio Caggiano Signed-off-by: Dmitry Osipenko --- v2: Fix memory leaks

[PATCH v3 2/4] virtio-gpu: hostmem

2022-09-19 Thread Antonio Caggiano
From: Gerd Hoffmann Use VIRTIO_GPU_SHM_ID_HOST_VISIBLE as id for virtio-gpu. Signed-off-by: Antonio Caggiano Acked-by: Michael S. Tsirkin --- v2: Formatting fixes hw/display/virtio-gpu-pci.c| 15 +++ hw/display/virtio-gpu.c| 1 + hw/display/virtio-vga.c| 33

[PATCH v3 4/4] virtio-gpu: Don't require udmabuf when blob support is enabled

2022-09-19 Thread Antonio Caggiano
to 4.5 in guest. Relax the udmabuf requirement. Signed-off-by: Dmitry Osipenko Reviewed-by: Antonio Caggiano --- hw/display/virtio-gpu.c | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c index f79693d44d

[PATCH v2 1/4] virtio: Add shared memory capability

2022-09-13 Thread Antonio Caggiano
re allowed and distinguished by a device-specific 'id'. v2: Remove virtio_pci_shm_cap as virtio_pci_cap64 is used instead. v3: No need for mask32 as cpu_to_le32 truncates the value. Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Antonio Caggiano --- hw/virtio/virtio-pci.c

[PATCH v2 0/4] virtio-gpu: Blob resources

2022-09-13 Thread Antonio Caggiano
Add shared memory and support blob resource creation, mapping and unmapping through virglrenderer new stable APIs[0] when available. [0] https://gitlab.freedesktop.org/virgl/virglrenderer/-/merge_requests/891 Antonio Caggiano (1): virtio-gpu: Handle resource blob commands Dmitry Osipenko (1

[PATCH v2 3/4] virtio-gpu: Handle resource blob commands

2022-09-13 Thread Antonio Caggiano
Support BLOB resources creation, mapping and unmapping by calling the new stable virglrenderer 0.10 interface. Only enabled when available and via the blob config. E.g. -device virtio-vga-gl,blob=true v2: Fix memory leaks and unmap resource on destroy. Signed-off-by: Antonio Caggiano Signed-off

[PATCH v2 2/4] virtio-gpu: hostmem

2022-09-13 Thread Antonio Caggiano
From: Gerd Hoffmann Use VIRTIO_GPU_SHM_ID_HOST_VISIBLE as id for virtio-gpu. v2: Formatting fixes Signed-off-by: Antonio Caggiano Acked-by: Michael S. Tsirkin --- hw/display/virtio-gpu-pci.c| 15 +++ hw/display/virtio-gpu.c| 1 + hw/display/virtio-vga.c| 33

[PATCH v2 4/4] virtio-gpu: Don't require udmabuf when blob support is enabled

2022-09-13 Thread Antonio Caggiano
to 4.5 in guest. Relax the udmabuf requirement. Signed-off-by: Dmitry Osipenko Reviewed-by: Antonio Caggiano --- hw/display/virtio-gpu.c | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c index f79693d44d

Re: [PATCH 0/5] virtio-gpu: Blob resources

2022-09-12 Thread Antonio Caggiano
Hi Marc-André, On 30/08/2022 13:07, Marc-André Lureau wrote: Hi On Mon, Aug 29, 2022 at 7:46 PM Antonio Caggiano mailto:antonio.caggi...@collabora.com>> wrote: Add shared memory and support blob resource creation, mapping and unmapping through virglrenderer new stable APIs[0

[PATCH 5/5] virtio-gpu: Don't require udmabuf when blob support is enabled

2022-08-29 Thread Antonio Caggiano
to 4.5 in guest. Relax the udmabuf requirement. Signed-off-by: Dmitry Osipenko Reviewed-by: Antonio Caggiano --- hw/display/virtio-gpu.c | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c index 527c0aeede

[PATCH 0/5] virtio-gpu: Blob resources

2022-08-29 Thread Antonio Caggiano
Add shared memory and support blob resource creation, mapping and unmapping through virglrenderer new stable APIs[0] when available. [0] https://gitlab.freedesktop.org/virgl/virglrenderer/-/merge_requests/891 Antonio Caggiano (1): virtio-gpu: Handle resource blob commands Dmitry Osipenko (1

[PATCH 4/5] virtio-gpu: Handle resource blob commands

2022-08-29 Thread Antonio Caggiano
Support BLOB resources creation by calling virgl_renderer_resource_create_blob. Signed-off-by: Antonio Caggiano Signed-off-by: Dmitry Osipenko --- hw/display/virtio-gpu-virgl.c| 169 +++ hw/display/virtio-gpu.c | 8 +- include/hw/virtio/virtio-gpu

[PATCH 3/5] virtio-gpu: hostmem

2022-08-29 Thread Antonio Caggiano
From: Gerd Hoffmann Use VIRTIO_GPU_SHM_ID_HOST_VISIBLE as id for virtio-gpu. v2: Formatting fixes Signed-off-by: Antonio Caggiano Acked-by: Michael S. Tsirkin --- hw/display/virtio-gpu-pci.c| 15 +++ hw/display/virtio-gpu.c| 1 + hw/display/virtio-vga.c| 33

[PATCH 1/5] Update version for v7.1.0-rc4 release

2022-08-29 Thread Antonio Caggiano
From: Richard Henderson Signed-off-by: Richard Henderson --- VERSION | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/VERSION b/VERSION index 1c944b9863..b8d5f3ebb6 100644 --- a/VERSION +++ b/VERSION @@ -1 +1 @@ -7.0.93 +7.0.94 -- 2.34.1

[PATCH 2/5] virtio: Add shared memory capability

2022-08-29 Thread Antonio Caggiano
re allowed and distinguished by a device-specific 'id'. v2: Remove virtio_pci_shm_cap as virtio_pci_cap64 is used instead. v3: No need for mask32 as cpu_to_le32 truncates the value. Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Antonio Caggiano --- hw/virtio/virtio-pci.c

[PATCH v4 0/1] virtio-gpu: CONTEXT_INIT feature

2022-08-26 Thread Antonio Caggiano
://github.com/oasis-tcs/virtio-spec/commit/aad2b6f3620ec0c9d16aaf046db8c282c24cce3e [2] https://www.mail-archive.com/qemu-devel@nongnu.org/msg827304.html Antonio Caggiano (1): virtio-gpu: CONTEXT_INIT feature hw/display/virtio-gpu-base.c | 3 +++ hw/display/virtio-gpu-virgl.c | 16

[PATCH v4 1/1] virtio-gpu: CONTEXT_INIT feature

2022-08-26 Thread Antonio Caggiano
HAVE_VIRGL_CONTEXT_INIT in config_host_data. Signed-off-by: Antonio Caggiano Reviewed-by: Marc-André Lureau --- hw/display/virtio-gpu-base.c | 3 +++ hw/display/virtio-gpu-virgl.c | 16 ++-- hw/display/virtio-gpu.c| 2 ++ include/hw/virtio/virtio-gpu.h | 3 +++ meson.build

Re: [PATCH v3 1/1] virtio-gpu: CONTEXT_INIT feature

2022-08-26 Thread Antonio Caggiano
Hi Marc-André, On 26/08/2022 12:16, Marc-André Lureau wrote: Hi On Fri, Aug 26, 2022 at 2:12 PM Antonio Caggiano mailto:antonio.caggi...@collabora.com>> wrote: Create virgl renderer context with flags using context_id when valid. v2: - The feature can be enabl

[PATCH v3 0/1] virtio-gpu: CONTEXT_INIT feature

2022-08-26 Thread Antonio Caggiano
://github.com/oasis-tcs/virtio-spec/commit/aad2b6f3620ec0c9d16aaf046db8c282c24cce3e [2] https://www.mail-archive.com/qemu-devel@nongnu.org/msg827304.html Antonio Caggiano (1): virtio-gpu: CONTEXT_INIT feature hw/display/virtio-gpu-base.c | 3 +++ hw/display/virtio-gpu-virgl.c | 16

[PATCH v3 1/1] virtio-gpu: CONTEXT_INIT feature

2022-08-26 Thread Antonio Caggiano
HAVE_VIRGL_CONTEXT_INIT in config_host_data. Signed-off-by: Antonio Caggiano --- hw/display/virtio-gpu-base.c | 3 +++ hw/display/virtio-gpu-virgl.c | 16 ++-- hw/display/virtio-gpu.c| 2 ++ include/hw/virtio/virtio-gpu.h | 3 +++ meson.build| 5 + 5

[PATCH v2 0/1] virtio-gpu: CONTEXT_INIT feature

2022-08-25 Thread Antonio Caggiano
://github.com/oasis-tcs/virtio-spec/commit/aad2b6f3620ec0c9d16aaf046db8c282c24cce3e [2] https://www.mail-archive.com/qemu-devel@nongnu.org/msg827304.html Antonio Caggiano (1): virtio-gpu: CONTEXT_INIT feature hw/display/virtio-gpu-base.c | 3 +++ hw/display/virtio-gpu-virgl.c | 19

[PATCH v2 1/1] virtio-gpu: CONTEXT_INIT feature

2022-08-25 Thread Antonio Caggiano
-by: Antonio Caggiano --- hw/display/virtio-gpu-base.c | 3 +++ hw/display/virtio-gpu-virgl.c | 19 +-- hw/display/virtio-gpu.c| 2 ++ include/hw/virtio/virtio-gpu.h | 3 +++ meson.build| 18 ++ 5 files changed, 43 insertions(+), 2

[PATCH v3 1/2] virtio: Add shared memory capability

2022-08-16 Thread Antonio Caggiano
re allowed and distinguished by a device-specific 'id'. v2: Remove virtio_pci_shm_cap as virtio_pci_cap64 is used instead. v3: No need for mask32 as cpu_to_le32 truncates the value. Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Antonio Caggiano --- hw/virtio/virtio-pci.c

[PATCH v3 0/2] virtio-gpu: Shared memory capability

2022-08-16 Thread Antonio Caggiano
Previously part of [0], now a patch series on its own. This patch series cherry picks two commits from [1] and applies one fix according to [2], which should answer Gerd's comment [3] on previous patch. v2: Squash patch #3 into patch #2, and formatting fixes to patch #1. v3: Reverse commits

[PATCH v3 2/2] virtio-gpu: hostmem

2022-08-16 Thread Antonio Caggiano
From: Gerd Hoffmann Use VIRTIO_GPU_SHM_ID_HOST_VISIBLE as id for virtio-gpu. v2: Formatting fixes Signed-off-by: Antonio Caggiano Acked-by: Michael S. Tsirkin --- hw/display/virtio-gpu-pci.c| 15 +++ hw/display/virtio-gpu.c| 1 + hw/display/virtio-vga.c| 33

[PATCH v2 2/2] virtio: Add shared memory capability

2022-08-03 Thread Antonio Caggiano
re allowed and distinguished by a device-specific 'id'. v2: Remove virtio_pci_shm_cap as virtio_pci_cap64 is used instead. v3: No need for mask32 as cpu_to_le32 truncates the value. Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Antonio Caggiano --- hw/virtio/virtio-pci.c

[PATCH v2 0/2] virtio-gpu: Shared memory capability

2022-08-03 Thread Antonio Caggiano
I guess RFC has been waiting long enough [0]. v2: Squash patch #3 into patch #2, and formatting fixes to patch #1. [0] https://www.mail-archive.com/qemu-devel@nongnu.org/msg840405.html Dr. David Alan Gilbert (1): virtio: Add shared memory capability Gerd Hoffmann (1): virtio-gpu: hostmem

[PATCH v2 1/2] virtio-gpu: hostmem

2022-08-03 Thread Antonio Caggiano
From: Gerd Hoffmann Use VIRTIO_GPU_SHM_ID_HOST_VISIBLE as id for virtio-gpu. v2: Formatting fixes Signed-off-by: Antonio Caggiano Acked-by: Michael S. Tsirkin --- hw/display/virtio-gpu-pci.c| 15 +++ hw/display/virtio-gpu.c| 1 + hw/display/virtio-vga.c| 33

[PATCH v3 0/2] virtio: Add shared memory capability

2022-08-03 Thread Antonio Caggiano
Previously part of [0], now a patch series on its own. This patch series cherry picks two commits from [1] and applies one fix according to [2], which should answer Gerd's comment [3] on previous patch. v2: Squash patch #3 into patch #2, and formatting fixes to patch #1. v3: Reverse commits

[PATCH v3 2/2] virtio-gpu: hostmem

2022-08-03 Thread Antonio Caggiano
From: Gerd Hoffmann Use VIRTIO_GPU_SHM_ID_HOST_VISIBLE as id for virtio-gpu. v2: Formatting fixes Signed-off-by: Antonio Caggiano Acked-by: Michael S. Tsirkin --- hw/display/virtio-gpu-pci.c| 15 +++ hw/display/virtio-gpu.c| 1 + hw/display/virtio-vga.c| 33

[PATCH v3 1/2] virtio: Add shared memory capability

2022-08-03 Thread Antonio Caggiano
re allowed and distinguished by a device-specific 'id'. v2: Remove virtio_pci_shm_cap as virtio_pci_cap64 is used instead. v3: No need for mask32 as cpu_to_le32 truncates the value. Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Antonio Caggiano --- hw/virtio/virtio-pci.c

Re: [PATCH 2/2] virtio: Add shared memory capability

2022-01-06 Thread Antonio Caggiano
Where's that commit? I think we should drop this, right? Yes, I will submit another version without that line. You don't need & mask32 I think. cpu_to_le32 will truncate the value. Makes sense, will be fixed in next version. So it's a new API, but where's the user? I guess just include

[PATCH 2/2] virtio: Add shared memory capability

2021-11-10 Thread Antonio Caggiano
re allowed and distinguished by a device-specific 'id'. v2: Remove virtio_pci_shm_cap as virtio_pci_cap64 is used instead. Signed-off-by: Dr. David Alan Gilbert (cherry picked from commit a5d628a3a3c5e60b98b15197c36a77056115) Signed-off-by: Antonio Caggiano --- hw/virtio/virtio-

[PATCH 0/2] virtio-gpu: Shared memory capability

2021-11-10 Thread Antonio Caggiano
Previously RFC [0] part of [0], now a patch series on its own. This patch series cherry picks two commits from [1] and applies one fix according to [2], which should answer Gerd's comment [3] on previous patch. [0] https://www.mail-archive.com/qemu-devel@nongnu.org/msg840405.html [1]

[PATCH 1/2] virtio-gpu: hostmem

2021-11-10 Thread Antonio Caggiano
From: Gerd Hoffmann Use VIRTIO_GPU_SHM_ID_HOST_VISIBLE as id for virtio-gpu. Signed-off-by: Antonio Caggiano --- hw/display/virtio-gpu-pci.c| 14 ++ hw/display/virtio-gpu.c| 1 + hw/display/virtio-vga.c| 32 +++- include/hw/virtio

Re: virtio-gpu: Get FD for texture

2021-09-29 Thread Antonio Caggiano
to a different thread. Does that make sense? Kind regards, Antonio Caggiano On 27/09/21 12:21, Antonio Caggiano wrote: Hi, I am trying to support a Vulkan application in the guest (GTKGlArea+VirGL+venus) which needs to import a GL texture from a GL context. Before doing that, I need to get

[RFC v2 1/2] virtio-gpu: hostmem

2021-09-29 Thread Antonio Caggiano
From: Gerd Hoffmann Use VIRTIO_GPU_SHM_ID_HOST_VISIBLE as id for virtio-gpu. Signed-off-by: Antonio Caggiano --- hw/display/virtio-gpu-pci.c| 14 ++ hw/display/virtio-gpu.c| 1 + hw/display/virtio-vga.c| 32 +++- include/hw/virtio

[RFC v2 0/2] virtio-gpu: Shared memory capability

2021-09-29 Thread Antonio Caggiano
Previously part of [0], now a patch series on its own. This patch series cherry picks two commits from [1] and applies one fix according to [2], which should answer Gerd's comment [3] on previous patch. RFC as I believe it needs a proper review from both authors of first two commits. v2: Squash

[RFC v2 2/2] virtio: Add shared memory capability

2021-09-29 Thread Antonio Caggiano
re allowed and distinguished by a device-specific 'id'. v2: Remove virtio_pci_shm_cap as virtio_pci_cap64 is used instead. Signed-off-by: Dr. David Alan Gilbert (cherry picked from commit a5d628a3a3c5e60b98b15197c36a77056115) Signed-off-by: Antonio Caggiano --- hw/virtio/virtio-

[RFC 0/3] virtio-gpu: Shared memory capability

2021-09-28 Thread Antonio Caggiano
://www.mail-archive.com/qemu-devel@nongnu.org/msg826897.html [1] https://gitlab.freedesktop.org/virgl/qemu/-/commits/virtio-gpu-next/ [2] https://github.com/torvalds/linux/commit/0dd4ff93f4c8dba016ad79384007da4938cd54a1 [3] https://www.mail-archive.com/qemu-devel@nongnu.org/msg827306.html Antonio

[RFC 1/3] virtio-gpu: hostmem

2021-09-28 Thread Antonio Caggiano
From: Gerd Hoffmann Use VIRTIO_GPU_SHM_ID_HOST_VISIBLE as id for virtio-gpu. Signed-off-by: Antonio Caggiano --- hw/display/virtio-gpu-pci.c| 14 ++ hw/display/virtio-gpu.c| 1 + hw/display/virtio-vga.c| 32 +++- include/hw/virtio

  1   2   >