Peter,
Hi; Coverity has just noticed an issue with this patch:
[...]
Here we declare the is_oneshot variable...
[...]
...but here we declare another is_oneshot, which shadows the first
declaration...
...so here when the inner variable is no longer in scope, the
value of the outer is_oneshot
Peter,
Applied to target-arm.next, thanks. Sorry it took me so long to> get to this.
No worries. Thanks for picking up the changes, and I really appreciate
all the review feedback.
Axel
Peter,
There's a couple of minor code-style issues here (block comment
format, variable declarations in the middle of a block); rather
than asking you to re-roll the series I'll just squash in the
fixes for those:
[...]
Thanks, that makes things easier. Seems these still unfortunately
slipped
Peter,
For the seL4 specific case, this is currently not possible in
the standard configuration. It's only exposed for a special
debug and benchmarking configuration.
It's not clear to me what you mean here -- the generic
timer in the CPU exists in all configurations, so there
should be no
Peter,
This patch adds timer peripherals to the arm-virt machine.>>
Is there a reason you can't use the CPU's built-in generic timer
device ? That is what typical guest code does on this system.
I'm a bit reluctant to add more devices to the virt board
because over time it gradually gets
Alex,
It would also be worth updating ./docs/system/arm/virt.rst to document
this feature.
Good point. I will add this in the next iteration of the patch.
Until then, the proposed doc changes can be found here:
https://gitlab.com/axel-h/qemu/-/merge_requests/1/diffs
Axel
Hi,
+ switch(uart) {
+ case VIRT_UART0:
+ break;
+ case VIRT_UART1:
Maybe pass a 'is_secure' boolean?
I don't think this would really make things easier. I wanted to
avoid too many changes in this patch. The price is, that there
are two places where decisions about the
Peter,
If you're correcting behaviour of the timer use here,
you should start by fixing the way the timers are currently
created with PTIMER_POLICY_LEGACY. That setting is basically
"bug-for-bug-compatibility with very old QEMU, for devices
where nobody really knows what the hardware behaviour
Having an "update interrupt" function is the more common
convention in QEMU device models -- it means you have one
function you can call from any point where you've updated
any of the state that affects whether an interrupt is generated or not.
Ok, will keept it.
For instance there's
From: Axel Heider
Signed-off-by: Axel Heider
---
hw/timer/imx_epit.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/hw/timer/imx_epit.c b/hw/timer/imx_epit.c
index 5315d9633e..6af460946f 100644
--- a/hw/timer/imx_epit.c
+++ b/hw/timer/imx_epit.c
@@ -191,8
Original Message
From: Philippe Mathieu-Daudé [mailto:phi...@linaro.org]
- simplify code, improve comments
- fix https://gitlab.com/qemu-project/qemu/-/issues/1263
This doesn't match GitLab issues closing pattern:
Original Message
From: Philippe Mathieu-Daudé [mailto:phi...@linaro.org]> diff --git
a/hw/timer/imx_epit.c b/hw/timer/imx_epit.c>
index a79f58c963..37b04a1b53 100644
--- a/hw/timer/imx_epit.c
+++ b/hw/timer/imx_epit.c
@@ -77,23 +77,25 @@ static void
Peter,
Also, did you check that the docs still build without warnings
from a range of Sphinx versions and that the rendered HTML still
looks the same ? These trailing spaces were largely added deliberately
in commit 09ce5f2d6bd6739144, with the comment
* rST does not like definition list
Signed-off-by: Axel Heider
---
qemu-options.hx | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index e3f256fa72..ed91246114 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -244,15 +244,15 @@ DEF("
There is a difference between 'null' and 'none'. Add a sentence to
highlight this, so this does not get mixed up.
Signed-off-by: Axel Heider
---
qemu-options.hx | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index 83aa59a920..e3f256fa72
Fix style to have a proper description of the parameter 'force-raw'.
Signed-off-by: Axel Heider
---
docs/system/generic-loader.rst | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/docs/system/generic-loader.rst b/docs/system/generic-loader.rst
index 6bf8a4eb48
Fix style to have a proper description of the parameter 'force-raw'.
Signed-off-by: Axel Heider
---
docs/system/generic-loader.rst | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/docs/system/generic-loader.rst b/docs/system/generic-loader.rst
index 6bf8a4eb48
Fix style to have a proper description of the parameter 'force-raw'.
Signed-off-by: Axel Heider
---
docs/system/generic-loader.rst | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/docs/system/generic-loader.rst b/docs/system/generic-loader.rst
index 6bf8a4eb48
18 matches
Mail list logo
