[Qemu-devel] [PATCH 1/3] rtl8139: use TARGET_FMT_plx in debug messages

2011-04-20 Thread Benjamin Poirier
‘target_phys_addr_t’ make[1]: *** [rtl8139.o] Error 1 Signed-off-by: Benjamin Poirier benjamin.poir...@gmail.com Cc: Igor V. Kovalenko igor.v.kovale...@gmail.com --- hw/rtl8139.c | 15 +-- 1 files changed, 9 insertions(+), 6 deletions(-) diff --git a/hw/rtl8139.c b/hw/rtl8139.c index d545933..9a759e7

[Qemu-devel] [PATCH 3/3] rtl8139: add format attribute to DPRINTF

2011-04-20 Thread Benjamin Poirier
gcc can check the format string for correctness even when debugging output is not enabled. Have to make sure arguments are always available. They are optimized out if unneeded. Signed-off-by: Benjamin Poirier benjamin.poir...@gmail.com Cc: Igor V. Kovalenko igor.v.kovale...@gmail.com --- hw

[Qemu-devel] Re: [regression] configure: add opengl detection

2011-04-07 Thread Benjamin Poirier
On 07/04/11 05:35 PM, Michael Walle wrote: Am Mittwoch 06 April 2011, 16:13:58 schrieb Benjamin Poirier: Works as usual. The problem I'm facing stems from linking to libGL and memory protection issues. The particular system I ran this on has the binary nvidia driver and its companion libGL.so

[Qemu-devel] Re: [regression] configure: add opengl detection

2011-04-06 Thread Benjamin Poirier
On Mon, Apr 4, 2011 at 6:13 PM, Michael Walle mich...@walle.cc wrote: Hi Benjamin, Let me know if you need more info. what happens if you configure with ./configure --target-list=x86_64-softmmu --disable-opengl Works as usual. The problem I'm facing stems from linking to libGL and memory

[Qemu-devel] [regression] configure: add opengl detection

2011-04-04 Thread Benjamin Poirier
Hello, commit 20ff075bb3340c5278a0da38ad1f4d602565aa06 Author: Michael Walle mich...@walle.cc Date: Mon Mar 7 23:32:39 2011 +0100 configure: add opengl detection This patch introduce a new config option CONFIG_OPENGL. Signed-off-by: Michael Walle mich...@walle.cc

[Qemu-devel] [PATCH v7 1/3] rtl8139: cleanup FCS calculation

2011-03-22 Thread Benjamin Poirier
clean out ifdef's around ethernet checksum calculation Signed-off-by: Benjamin Poirier benjamin.poir...@gmail.com Acked-by: Igor V. Kovalenko igor.v.kovale...@gmail.com Cc: Jason Wang jasow...@redhat.com Cc: Michael S. Tsirkin m...@redhat.com Cc: Blue Swirl blauwir...@gmail.com --- hw/rtl8139.c

[Qemu-devel] [PATCH v7] rtl8139: add vlan support

2011-03-22 Thread Benjamin Poirier
Hello, Here is version 7 of my patchset to add vlan support to the emulated rtl8139 nic. Changes since v6: * added check against guest requesting tagging on frames with len 12 * simplified tag extraction in receive function. dot1q_buf arg removed from

[Qemu-devel] [PATCH v7 2/3] rtl8139: add vlan tag extraction

2011-03-22 Thread Benjamin Poirier
Add support to the emulated hardware to extract vlan tags in packets going from the network to the guest. Signed-off-by: Benjamin Poirier benjamin.poir...@gmail.com Cc: Igor V. Kovalenko igor.v.kovale...@gmail.com Cc: Jason Wang jasow...@redhat.com Cc: Michael S. Tsirkin m...@redhat.com Cc: Blue

[Qemu-devel] [PATCH v7 3/3] rtl8139: add vlan tag insertion

2011-03-22 Thread Benjamin Poirier
Add support to the emulated hardware to insert vlan tags in packets going from the guest to the network. Signed-off-by: Benjamin Poirier benjamin.poir...@gmail.com Cc: Igor V. Kovalenko igor.v.kovale...@gmail.com Cc: Jason Wang jasow...@redhat.com Cc: Michael S. Tsirkin m...@redhat.com Cc: Blue

[Qemu-devel] [PATCH v6 1/3] rtl8139: cleanup FCS calculation

2011-03-10 Thread Benjamin Poirier
clean out ifdef's around ethernet checksum calculation Signed-off-by: Benjamin Poirier benjamin.poir...@gmail.com Cc: Igor V. Kovalenko igor.v.kovale...@gmail.com Cc: Jason Wang jasow...@redhat.com Cc: Michael S. Tsirkin m...@redhat.com Cc: Blue Swirl blauwir...@gmail.com --- hw/rtl8139.c | 20

[Qemu-devel] [PATCH v6] rtl8139: add vlan support

2011-03-10 Thread Benjamin Poirier
Here is version 6 of my patchset to add vlan support to the emulated rtl8139 nic. Changes since v5: * moved all receive changes to add vlan tag extraction * fixed checkpatch.pl style issues * fixed bugs in receive case related to small buffers and loopback mode.

[Qemu-devel] [PATCH v6 3/3] rtl8139: add vlan tag insertion

2011-03-10 Thread Benjamin Poirier
Add support to the emulated hardware to insert vlan tags in packets going from the guest to the network. Signed-off-by: Benjamin Poirier benjamin.poir...@gmail.com Cc: Igor V. Kovalenko igor.v.kovale...@gmail.com Cc: Jason Wang jasow...@redhat.com Cc: Michael S. Tsirkin m...@redhat.com Cc: Blue

[Qemu-devel] [PATCH v6 2/3] rtl8139: add vlan tag extraction

2011-03-10 Thread Benjamin Poirier
Add support to the emulated hardware to extract vlan tags in packets going from the network to the guest. Signed-off-by: Benjamin Poirier benjamin.poir...@gmail.com Cc: Igor V. Kovalenko igor.v.kovale...@gmail.com Cc: Jason Wang jasow...@redhat.com Cc: Michael S. Tsirkin m...@redhat.com Cc: Blue

[Qemu-devel] [PATCH v5] rtl8139: add vlan support

2011-03-07 Thread Benjamin Poirier
Here is version 5 of my patchset to add vlan support to the emulated rtl8139 nic. Changes since v4: * removed alloca(), for real. Thanks to the reviewers for their patience. This patchset now has more versions than the vlan header has bytes! * corrected the

[Qemu-devel] [PATCH v4] rtl8139: add vlan support

2011-03-02 Thread Benjamin Poirier
I've tested v4 with x86_64 host/guest. I used the same testing procedure as before. I've tested a plain configuration as well as one with tso + vlan offload, successfully. I had to hack around the Linux 8139cp driver to be able to enable tso on vlan which leads me to wonder, can someone with

[Qemu-devel] [PATCH v4 2/2] rtl8139: add vlan tag insertion

2011-03-02 Thread Benjamin Poirier
Add support to the emulated hardware to insert vlan tags in packets going from the guest to the network. Signed-off-by: Benjamin Poirier benjamin.poir...@gmail.com Cc: Igor V. Kovalenko igor.v.kovale...@gmail.com Cc: Jason Wang jasow...@redhat.com Cc: Michael S. Tsirkin m...@redhat.com --- hw

[Qemu-devel] [PATCH v4 1/2] rtl8139: add vlan tag extraction

2011-03-02 Thread Benjamin Poirier
Add support to the emulated hardware to extract vlan tags in packets going from the network to the guest. Signed-off-by: Benjamin Poirier benjamin.poir...@gmail.com Cc: Igor V. Kovalenko igor.v.kovale...@gmail.com Cc: Jason Wang jasow...@redhat.com Cc: Michael S. Tsirkin m...@redhat.com

[Qemu-devel] [PATCH v3] rtl8139: add vlan support

2011-02-25 Thread Benjamin Poirier
I've posted v2 of these patches back in november http://article.gmane.org/gmane.comp.emulators.qemu/84252 Changes since v2: insertion: * moved insertion later in the process, to handle tso * use qemu_sendv_packet() to insert the tag for us * added dot1q_buf parameter to

[Qemu-devel] [PATCH v3 1/2] rtl8139: add vlan tag insertion

2011-02-25 Thread Benjamin Poirier
Add support to the emulated hardware to insert vlan tags in packets going from the guest to the network. Signed-off-by: Benjamin Poirier benjamin.poir...@gmail.com Cc: Igor V. Kovalenko igor.v.kovale...@gmail.com Cc: Jason Wang jasow...@redhat.com Cc: Michael S. Tsirkin m...@redhat.com --- hw

[Qemu-devel] [PATCH v3 2/2] rtl8139: add vlan tag extraction

2011-02-25 Thread Benjamin Poirier
Add support to the emulated hardware to extract vlan tags in packets going from the network to the guest. Signed-off-by: Benjamin Poirier benjamin.poir...@gmail.com Cc: Igor V. Kovalenko igor.v.kovale...@gmail.com Cc: Jason Wang jasow...@redhat.com Cc: Michael S. Tsirkin m...@redhat.com

[Qemu-devel] [PATCH] net: Use iov helper functions

2011-02-23 Thread Benjamin Poirier
Signed-off-by: Benjamin Poirier benjamin.poir...@gmail.com --- net.c | 28 ++-- 1 files changed, 6 insertions(+), 22 deletions(-) diff --git a/net.c b/net.c index ec4745d..15ed40b 100644 --- a/net.c +++ b/net.c @@ -36,6 +36,7 @@ #include qemu-common.h #include

Re: [Qemu-devel] [PATCH v2 1/2] rtl8139: add vlan tag insertion

2010-11-16 Thread Benjamin Poirier
On 16/11/10 03:06 PM, Anthony Liguori wrote: On 11/08/2010 07:46 PM, Benjamin Poirier wrote: Add support to the emulated hardware to add vlan tags in packets going from the guest to the network. Signed-off-by: Benjamin Poirierbenjamin.poir...@polymtl.ca Cc: Igor V. Kovalenkoigor.v.kovale

Re: [Qemu-devel] [PATCH 1/2] rtl8139: add vlan tag insertion

2010-11-08 Thread Benjamin Poirier
On 08/11/10 11:34 AM, Stefan Hajnoczi wrote: On Sun, Nov 7, 2010 at 9:25 PM, Benjamin Poirier benjamin.poir...@polymtl.ca wrote: Add support to the emulated hardware to add vlan tags in packets going from the guest to the network. Signed-off-by: Benjamin Poirier benjamin.poir...@polymtl.ca

[Qemu-devel] [PATCH v2 1/2] rtl8139: add vlan tag insertion

2010-11-08 Thread Benjamin Poirier
Add support to the emulated hardware to add vlan tags in packets going from the guest to the network. Signed-off-by: Benjamin Poirier benjamin.poir...@polymtl.ca Cc: Igor V. Kovalenko igor.v.kovale...@gmail.com --- Changes since v1: * moved the debug print statement inside the if block

[Qemu-devel] [PATCH v2 2/2] rtl8139: add vlan tag extraction

2010-11-08 Thread Benjamin Poirier
Add support to the emulated hardware to remove vlan tags in packets going from the network to the guest. Signed-off-by: Benjamin Poirier benjamin.poir...@polymtl.ca Cc: Igor V. Kovalenko igor.v.kovale...@gmail.com --- Changes since v1: * moved the debug print statement inside the if block

[Qemu-devel] [PATCH 1/2] rtl8139: add vlan tag insertion

2010-11-07 Thread Benjamin Poirier
Add support to the emulated hardware to add vlan tags in packets going from the guest to the network. Signed-off-by: Benjamin Poirier benjamin.poir...@polymtl.ca Cc: Igor V. Kovalenko igor.v.kovale...@gmail.com --- hw/rtl8139.c | 46 +++--- 1 files

[Qemu-devel] [PATCH 2/2] rtl8139: add vlan tag extraction

2010-11-07 Thread Benjamin Poirier
Add support to the emulated hardware to remove vlan tags in packets going from the network to the guest. Signed-off-by: Benjamin Poirier benjamin.poir...@polymtl.ca Cc: Igor V. Kovalenko igor.v.kovale...@gmail.com -- AFAIK, extraction is optional to get vlans working. The driver requests rx