Reviewed-by: Christophe Fergeau
On Thu, Feb 21, 2019 at 12:43:28PM +0100, Marc-André Lureau wrote:
> Signed-off-by: Marc-André Lureau
> ---
> include/hw/virtio/virtio-gpu.h | 2 --
> hw/display/virtio-gpu.c| 3 +--
> 2 files changed, 1 insertion(+), 4 deletions(-)
&g
I came up with the same fix while looking at that bug before seeing
Marc-André's patch.
Then I tested Marc-André's patch.
So for this patch,
Reviewed-by: Christophe Fergeau
Tested-by: Christophe Fergeau
On Thu, Feb 21, 2019 at 12:43:29PM +0100, Marc-André Lureau wrote:
> Now tha
Reviewed-by: Christophe Fergeau
On Thu, Feb 21, 2019 at 12:43:27PM +0100, Marc-André Lureau wrote:
> Signed-off-by: Marc-André Lureau
> ---
> include/hw/virtio/virtio-gpu.h | 1 -
> hw/display/virtio-gpu.c| 1 -
> 2 files changed, 2 deletions(-)
>
> diff --gi
Reviewed-by: Christophe Fergeau
On Thu, Feb 21, 2019 at 12:43:30PM +0100, Marc-André Lureau wrote:
> Let's check renderer_blocked instead directly.
>
> Signed-off-by: Marc-André Lureau
> ---
> include/hw/virtio/virtio-gpu.h | 1 -
> hw/display/virtio-gpu.c| 4
The main goal of this patch series is to make logs output by
libspice-server.so go through qemu logging infrastructure so that their
format is the same as the rest of QEMU messages (in particular,
timestamps). This is done in the second patch, the first one is a
preparation patch.
Christophe
ect, so this call is
not conditional on the SPICE version.
Signed-off-by: Christophe Fergeau
Reviewed-by: Stefan Hajnoczi
---
Changes since v6:
- expanded on the bsd-user/linux-user/qemu-pr-helper changes in the
commit log
- fix obsolete mention of qemu_init_logging() in commit log
- improved out
qemu-io reimplements itself what
error_get_progname()/error_set_progname() already does.
This commit switches it to use this API from qemu-error.h
Signed-off-by: Christophe Fergeau
Reviewed-by: Eric Blake
Reviewed-by: Stefan Hajnoczi
---
No changes since v6
qemu-io.c | 14 ++
1
qemu-io reimplements itself what
error_get_progname()/error_set_progname() already does.
This commit switches it to use this API from qemu-error.h
Signed-off-by: Christophe Fergeau
---
qemu-io.c | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/qemu-io.c b/qemu
ice versions, this is not going
to work as expected, but will not have any ill effect, so this call is
not conditional on the SPICE version.
Signed-off-by: Christophe Fergeau
---
bsd-user/main.c | 2 ++
include/qemu/error-report.h | 3 ++-
linux-user/main.c | 2 ++
qemu-im
On Thu, Jan 24, 2019 at 05:10:28PM +0100, Markus Armbruster wrote:
> Christophe Fergeau writes:
>
> > This commit adds a qemu_init_logging() helper which calls
> > g_log_set_default_handler() so that glib logs (g_log, g_warning, ...)
> > are handled similarly to other QE
Hey,
On Thu, Jan 24, 2019 at 10:38:37AM +0100, Markus Armbruster wrote:
> Christophe Fergeau writes:
>
> > This commit adds a qemu_init_logging() helper which calls
> > g_log_set_default_handler() so that glib logs (g_log, g_warning, ...)
> > are handled similarly to oth
Hey,
On Thu, Jan 24, 2019 at 10:35:52AM +0100, Markus Armbruster wrote:
> Markus Armbruster writes:
>
> > Eric Blake writes:
> >
> >> On 1/2/19 12:01 PM, Christophe Fergeau wrote:
> >>> Adding Markus to cc: list, I forgot to do it when sending the patc
ons, this is not going
to work as expected, but will not have any ill effect, so this call is
not conditional on the SPICE version.
Signed-off-by: Christophe Fergeau
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Stefan Hajnoczi
---
One more iteration of the patch as it hit CI failures
(ht
On Tue, Jan 15, 2019 at 02:09:12PM +, Stefan Hajnoczi wrote:
> > In these codepaths, I'm confident up to
> > void monitor_vfprintf(FILE *stream, const char *fmt, va_list ap)
> > {
> > if (cur_mon && !monitor_cur_is_qmp()) {
> > monitor_vprintf(cur_mon, fmt, ap);
> > } else {
> >
On Fri, Jan 04, 2019 at 03:40:34PM +, Stefan Hajnoczi wrote:
> On Thu, Jan 03, 2019 at 03:14:55PM +0100, Christophe Fergeau wrote:
> > Hey,
> >
> > On Thu, Jan 03, 2019 at 10:54:25AM +, Stefan Hajnoczi wrote:
> > > On Fri, Dec 14, 2018 at 11:56:42AM +
On Mon, Jan 07, 2019 at 04:47:44PM +0100, Markus Armbruster wrote:
> Eric Blake writes:
>
> > On 1/2/19 12:01 PM, Christophe Fergeau wrote:
> >> Adding Markus to cc: list, I forgot to do it when sending the patch.
> >
> > Also worth backp
Hey,
On Thu, Jan 03, 2019 at 04:25:00PM -0600, Eric Blake wrote:
> On 12/27/18 8:51 AM, Niccolò Belli wrote:
> > On mercoledì 26 dicembre 2018 13:38:28 CET, Frediano Ziglio wrote:
> >> Yes, this looks like a format string error in the upper (not into
> >> spice) layer.
> >>
> >> This potentially i
Hey,
On Thu, Jan 03, 2019 at 10:54:25AM +, Stefan Hajnoczi wrote:
> On Fri, Dec 14, 2018 at 11:56:42AM +0100, Christophe Fergeau wrote:
> > +static void qemu_log_func(const gchar *log_domain,
> > + GLogLevelFlags log_level,
> > +
Adding Markus to cc: list, I forgot to do it when sending the patch.
Christophe
On Wed, Jan 02, 2019 at 03:05:35PM +0100, Christophe Fergeau wrote:
> commit 8bca4613 added support for %% in json strings when interpolating,
> but in doing so, this broke handling of % when not interpolating
commit 8bca4613 added support for %% in json strings when interpolating,
but in doing so, this broke handling of % when not interpolating as the
'%' is skipped in both cases.
This commit ensures we only try to handle %% when interpolating.
Signed-off-by: Christophe Fergeau
---
qo
ons, this is not going
to work as expected, but will not have any ill effect, so this call is
not conditional on the SPICE version.
Signed-off-by: Christophe Fergeau
Reviewed-by: Daniel P. Berrangé
---
Changes since v3:
- Fixed style issue: removed 2 extra spaces before parens
(reported
ons, this is not going
to work as expected, but will not have any ill effect, so this call is
not conditional on the SPICE version.
Signed-off-by: Christophe Fergeau
---
Changes since v2:
- report G_LOG_LEVEL_CRITICAL using error_report() instead of
warn_report()
- print G_LOG_LEVEL_DEBUG messa
On Thu, Dec 13, 2018 at 11:52:12AM +, Daniel P. Berrangé wrote:
> On Thu, Dec 13, 2018 at 12:26:12PM +0100, Christophe Fergeau wrote:
> > This commit adds a qemu_init_logging() helper which calls
> > g_log_set_default_handler() so that glib logs (g_log, g_warning, ...)
not conditional on the SPICE version.
Signed-off-by: Christophe Fergeau
---
Changes since v1:
- introduced a qemu_init_logging() helper, and call that in more
binaries than just vl.c
bsd-user/main.c | 1 +
include/qemu/error-report.h | 2 ++
linux-user/main.c | 1 +
q
onditional on spice
version.
Since this added g_log_set_default_handler() will bridge glib logging
and QEMU logging, the call might fit better in a more generic place.
Signed-off-by: Christophe Fergeau
---
ui/spice-core.c | 25 +
1 file changed, 25 insertions(+)
diff
hey,
On Mon, Nov 26, 2018 at 03:30:36PM +, Frediano Ziglio wrote:
> Definitions were updated by spice-server in patch de66161 included
> in 0.12.6 released on 12th June 2015.
QEMU's configure only checks for spice-server 0.12.0:
$pkg_config --atleast-version=0.12.0 spice-server
if $pkg_co
This was added in 13f1243, but is missing from qemu-options.hx
Signed-off-by: Christophe Fergeau
---
qemu-options.hx | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index f11c4ac960..118784ceb7 100644
--- a/qemu-options.hx
+++ b
causes https://bugzilla.redhat.com/show_bug.cgi?id=1266484
This commit makes sure that we only emit
QXL_INTERRUPT_CLIENT_MONITORS_CONFIG when there are actual configuration
changes the guest should act on.
Signed-off-by: Christophe Fergeau
---
Changes since v1:
- made sure checkpatch.pl passes
Currently if the client keeps sending the same monitor config to
QEMU/spice-server, QEMU will always raise
a QXL_INTERRUPT_CLIENT_MONITORS_CONFIG regardless of whether there was a
change or not.
Guest-side (with fedora 25), the kernel QXL KMS driver will also forward the
event to user-space without
On Tue, Jul 19, 2016 at 09:41:22AM -0400, Frediano Ziglio wrote:
> > I don't think we have strong reasons to support software encoding, video
> > encoding is really expensive, and that mmap/copy is not going to be
> > marginal, so even less these 2 syscalls.
> >
>
> Using HW encoding is not easy
On Fri, Mar 18, 2016 at 09:17:53AM +0100, Gerd Hoffmann wrote:
> On Mo, 2016-03-14 at 12:41 +0100, Christophe Fergeau wrote:
> > Currently, virgl support has to go through a local unix socket, trying
> > to connect to a VM using -spice gl through spice://localhost:5900 will
>
On Tue, Mar 15, 2016 at 03:32:31PM +0100, Gerd Hoffmann wrote:
> > We can do something similar once gl+tcp is available.
>
> I don't expect adding gl+tcp support to spice needs changes in the
> spice-server API and qemu. So ifdef'ing on the spice-server version is
> bogous,
Hmm, I expected some
On Tue, Mar 15, 2016 at 02:09:47PM +0100, Gerd Hoffmann wrote:
> Hi,
>
> > Yes, long-term we will want to remove this once spice gets support for
> > this.
>
> How can qemu figure whenever spice supports gl+tcp or not?
gl support is already enabled through a spice-server version check
#if def
On Mon, Mar 14, 2016 at 09:41:34AM -0600, Eric Blake wrote:
> On 03/14/2016 05:41 AM, Christophe Fergeau wrote:
> > Currently, virgl support has to go through a local unix socket, trying
> > to connect to a VM using -spice gl through spice://localhost:5900 will
> > only res
Hi,
On Mon, Mar 14, 2016 at 04:00:11PM +0100, Gerd Hoffmann wrote:
> On Mo, 2016-03-14 at 12:41 +0100, Christophe Fergeau wrote:
> > Currently, virgl support has to go through a local unix socket, trying
> > to connect to a VM using -spice gl through spice://localhost:5900 will
>
in spice-server, but currently QEMU does not call
into spice-server when parsing 'gl' on its command line, so we have to
do this check in QEMU instead.
Signed-off-by: Christophe Fergeau
---
ui/spice-core.c | 4
1 file changed, 4 insertions(+)
diff --git a/ui/spice-core.c b/ui/sp
On Mon, Jan 18, 2016 at 11:11:42AM +0100, Gerd Hoffmann wrote:
> On Fr, 2016-01-15 at 16:33 -0700, Eric Blake wrote:
> > > This commit unconditionnally calls spice_server_set_sasl_appname()
> >
> > s/unconditionnally/unconditionally/
>
> Fixed up, no need to resend.
Thanks!
Christophe
signatu
There was a 'capbilities' typo in this man page. This commit
reformulates the sentence the typo was in to make it easier to grasp.
This is based on a suggestion from Eric Blake.
Signed-off-by: Christophe Fergeau
---
Changes since v1:
- rather than just fixing the typo, reformulate th
On Fri, Jan 15, 2016 at 04:31:45PM -0700, Eric Blake wrote:
> On 01/12/2016 06:39 AM, Christophe Fergeau wrote:
> > Signed-off-by: Christophe Fergeau
> > ---
> > fsdev/virtfs-proxy-helper.texi | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
&g
mu command line.
Signed-off-by: Christophe Fergeau
---
ui/spice-core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ui/spice-core.c b/ui/spice-core.c
index 3322bf2..77b209f 100644
--- a/ui/spice-core.c
+++ b/ui/spice-core.c
@@ -743,8 +743,7 @@ void qemu_spice
Signed-off-by: Christophe Fergeau
---
fsdev/virtfs-proxy-helper.texi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fsdev/virtfs-proxy-helper.texi b/fsdev/virtfs-proxy-helper.texi
index e60e3b9..1b905a0 100644
--- a/fsdev/virtfs-proxy-helper.texi
+++ b/fsdev/virtfs-proxy
Hey Gerd,
On Mon, Oct 12, 2015 at 03:43:51PM +0200, Gerd Hoffmann wrote:
> On Mo, 2015-10-12 at 13:25 +0200, Christophe Fergeau wrote:
> > Before commit b1ea7b79e1, it was possible to start with -spice
> > disable-ticketing, and then use the "set_password spice" comman
"
and changes 'auth' to "spice" when this happens.
Signed-off-by: Christophe Fergeau
Reviewed-by: Daniel P. Berrange
---
Changes since v2:
- Added mention of the oVirt bug which was caused by the change of behaviour
ui/spice-core.c | 4
1 file changed, 4 inserti
Hey,
On Fri, Aug 14, 2015 at 05:10:57PM +0200, Christophe Fergeau wrote:
> Before commit b1ea7b79e1, it was possible to start with -spice
> disable-ticketing, and then use the "set_password spice" command to
> enable ticketing with SPICE. Since commit b1ea7b79e1 this is no l
On Fri, Aug 14, 2015 at 03:35:21PM +0100, Daniel P. Berrange wrote:
> On Fri, Aug 14, 2015 at 02:47:15PM +0200, Christophe Fergeau wrote:
> > Before commit b1ea7b79e1, it was possible to start with -spice
> > disable-ticketing, and then use the "set_password spice" comman
ype is "spice". When ticketing is disabled, 'auth' is "none" so
the attempt to set password fails.
This commit allows to call qemu_spice_set_ticket() when 'auth' is "none"
and changes 'auth' to "spice" when this happens.
Signed-
On Fri, Aug 14, 2015 at 03:04:48PM +0100, Daniel P. Berrange wrote:
> Hmm, is oVirt using this via libvirt ? If so, I guess we have to fix
> it, as that would be a break in current usage.
Yes this is done through libvirt.
Before commit qemu-2.1.0-rc2~11^2, you could use virsh update-device
with
Hey,
On Fri, Aug 14, 2015 at 01:54:59PM +0100, Daniel P. Berrange wrote:
> On Fri, Aug 14, 2015 at 02:47:15PM +0200, Christophe Fergeau wrote:
> > Before commit b1ea7b79e1, it was possible to start with -spice
> > disable-ticketing, and then use the "set_password spice&qu
Before commit b1ea7b79e1, it was possible to start with -spice
disable-ticketing, and then use the "set_password spice" command to
enable ticketing with SPICE. Since commit b1ea7b79e1 this is no longer
possible as qemu_spice_set_ticket() will return an error unless the
'auth' type is "spice". When
On Mon, Jul 20, 2015 at 09:43:23AM +0100, Frediano Ziglio wrote:
> The new spice-server function to limit the number of monitors (0.12.6)
> changed while development from spice_qxl_set_monitors_config_limit to
> spice_qxl_max_monitors (accepted upstream).
> By mistake I post patch with former name.
On Fri, Jun 12, 2015 at 03:05:10PM +0100, Frediano Ziglio wrote:
> This patch allow to limit number of heads using qxl driver. By default
> qxl driver is not limited on any kind on head use so can decide to use
> as much heads.
>
> libvirt has this as a video card parameter (actually set to 1 but
On Tue, Jun 09, 2015 at 10:50:48AM +0100, Daniel P. Berrange wrote:
> On Tue, Jun 09, 2015 at 09:49:44AM +0100, Frediano Ziglio wrote:
> > This patch allow to limit number of heads using qxl driver. By default
> > qxl driver is not limited on any kind on head use so can decide to use
> > as much he
Hey,
On Tue, Apr 14, 2015 at 09:14:53AM +0200, Gerd Hoffmann wrote:
> Denis Kirjanov is busy getting spice run on ppc64 and trapped into this
> one. Spice wire format is little endian, so we have to explicitly say
> we want little endian when letting pixman convert the data for us.
This patch lo
Hey,
On Thu, Jan 08, 2015 at 11:50:13AM +0100, Javier Celaya wrote:
> Hello
>
> Recently, SPICE included the lz4 compression algorithm. This patch adds
> a command line option to select it. However, SPICE_IMAGE_COMPRESS_LZ4 did not
> exist before the commit that added this compression algorithm,
Hey, patch looks good
On Tue, Apr 29, 2014 at 10:02:27AM +0400, Michael Tokarev wrote:
> Replace QemuMutex with GMutex and QemuCond with GCond
> (with corresponding function changes), to make libcacard
> independent of qemu internal functions.
>
> Also replace single instance pstrcpy() in vcard_e
On Tue, Apr 29, 2014 at 10:02:24AM +0400, Michael Tokarev wrote:
> glib >= 2.31 always enables thread support and g_thread_supported()
> is #defined to 1, there's no need to call g_thread_init() anymore,
> and it definitely does not need to report error which never happens.
> Keep code for old < 2.
Hey,
On Tue, Apr 29, 2014 at 10:02:26AM +0400, Michael Tokarev wrote:
> Use glib-provided thread primitives in vscclient, not qemu
> thread primitives. This way, vscclient becomes more stand-alone.
For what it's worth, this patch has a few non-threading related bits in
it because of the removal
- Mail original -
> Il 26/03/2014 17:15, Fabio Fantoni ha scritto:
> > Time ago I have read somewhere that there is an option to
> > automatically spice port in qemu as for vnc.
> > I started to write a libxl patch to add this feature like the vnc one:
> > https://github.com/Fantu/Xen/com
On Mon, Apr 07, 2014 at 11:59:06AM +0200, Fabio Fantoni wrote:
>
> Today I did some tests also with hvm and spice and I found another
> segfault with different backtrace to solve:
> >(gdb) c
> >Continuing.
> >
> >*Program received signal SIGSEGV, Segmentation fault.**
> >**0x55855d30 in in
Looks good, ACK.
Christophe
On Wed, Feb 19, 2014 at 11:40:50AM +0100, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann
> ---
> hw/display/qxl.c | 8 +++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/hw/display/qxl.c b/hw/display/qxl.c
> index 1471cc0..2a559eb 100644
ff-by: Christophe Fergeau
---
libcacard/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libcacard/Makefile b/libcacard/Makefile
index 4d15da4..6b06448 100644
--- a/libcacard/Makefile
+++ b/libcacard/Makefile
@@ -25,7 +25,7 @@ vscclient$(EXESUF): libcacard/vsccli
Similarly to the previous commit fixing VNC+SASL+QXL, when starting
QEMU with SPICE but no SASL, and also VNC with SASL, then
spice_server_init() will get called without a previous call to
spice_server_set_sasl_appname(), which will cause cyrus-sasl to
try to use /etc/sasl2/spice.conf (spice-server
Similarly to the previous commit fixing VNC+SASL+QXL, when starting
QEMU with SPICE but no SASL, and also VNC with SASL, then
spice_server_init() will get called without a previous call to
spice_server_set_sasl_appname(), which will cause cyrus-sasl to
try to use /etc/sasl2/spice.conf (spice-server
e_add_interface() without setting the appname
to "qemu", which then causes the VNC code to try to use spice.conf
instead of qemu.conf.
Signed-off-by: Christophe Fergeau
---
ui/spice-core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/ui/spice-core.c b/ui/spice-core.c
index 33e
Hey Hans,
On Tue, Oct 08, 2013 at 04:27:38PM +0200, Hans de Goede wrote:
> I'm having this weird problem with qemu master + spice/qxl using
> guests. As soon as the guest starts Xorg, I get the following message
> from qemu:
>
> main-loop: WARNING: I/O thread spun for 1000 iterations
I've also s
On Mon, Sep 02, 2013 at 01:36:19PM +0200, Gerd Hoffmann wrote:
> On Mo, 2013-09-02 at 11:53 +0200, Christophe Fergeau wrote:
> > Several places in spice-core.c were using either g_malloc+snprintf
> > or snprintf+g_strdup to achieve the same result as g_strdup_printf.
>
>
Several places in spice-core.c were using either g_malloc+snprintf
or snprintf+g_strdup to achieve the same result as g_strdup_printf.
Signed-off-by: Christophe Fergeau
---
Changes since v1:
- split lines >80 chars (checkpatch.pl now succeeds)
ui/spice-core.c |
Several places in spice-core.c were using either g_malloc+snprintf
or snprintf+g_strdup to achieve the same result as g_strdup_printf.
Signed-off-by: Christophe Fergeau
---
ui/spice-core.c | 22 --
1 file changed, 8 insertions(+), 14 deletions(-)
diff --git a/ui/spice
Hey,
On Fri, Nov 16, 2012 at 07:22:58PM +0800, Dunrong Huang wrote:
> 2012/11/16 Christophe Fergeau :
> > On Fri, Nov 16, 2012 at 06:02:33PM +0800, Dunrong Huang wrote:
> >> I meet a weird problem:
> >> If I I boot QEMU with virtio-serial being enabled and assign only
On Fri, Nov 16, 2012 at 06:02:33PM +0800, Dunrong Huang wrote:
> I meet a weird problem:
> If I I boot QEMU with virtio-serial being enabled and assign only one
> cpu to windows VM, when I shutdown VM, QEMU hangs with using 100% cpu.
What version of virtio-serial were you using? The old virtio-ser
When parsing its command line parameters, spice aborts when it
finds unexpected values, except for the 'streaming-video' option.
This happens because the parsing of the parameters for this option
is done using the 'name2enum' helper, which does not error out
on unknown values. Using the 'parse_name
On Mon, Mar 19, 2012 at 01:42:21PM +0200, Vadim Rozenfeld wrote:
> On Monday, March 19, 2012 12:12:59 PM Christophe Fergeau wrote:
> > Hey,
> >
> > On Mon, Mar 19, 2012 at 02:29:41PM +0800, Charles.Tsai-蔡清海-研究發展部 wrote:
> > > 3. When we disable and enable the n
Hey,
On Mon, Mar 19, 2012 at 02:29:41PM +0800, Charles.Tsai-蔡清海-研究發展部 wrote:
> 3. When we disable and enable the new VirtIO driver several times
> on either Qemu 1.0 or Qemu 1.0.50, VirtIo driver failed to work
> after enabling the new VirtIO driver.
For what it's worth, Alon Le
It's currently possible to setup spice channels using TLS when
no TLS port has been specified (ie TLS is disabled). This cannot
work, so better to error out in such a situation.
---
ui/spice-core.c |8 +++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/ui/spice-core.c b/ui
It's currently possible to setup spice channels using TLS when
no TLS port has been specified (ie TLS is disabled). This cannot
work, so better to error out in such a situation.
---
ui/spice-core.c |7 ++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/ui/spice-core.c b/ui/
Error message reporting during spice startup wasn't consistent, it was done
with fprintf(stderr, "") but sometimes the message didn't have a trailing
\n. Using error_report make the intent of the message clearer and deal
with the final \n for us.
---
ui/spice-core.c | 22 +++---
It's currently possible to setup spice channels using TLS when
no TLS port has been specified (ie TLS is disabled). This cannot
work, so better to error out in such a situation.
---
ui/spice-core.c |8 +++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/ui/spice-core.c b/ui
Without it the shell prompt doesn't appear on a new line after
qemu dies.
---
ui/spice-core.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/ui/spice-core.c b/ui/spice-core.c
index 1308a3d..6d240a3 100644
--- a/ui/spice-core.c
+++ b/ui/spice-core.c
@@ -568,15 +568,
Hey,
On Mon, Oct 17, 2011 at 01:37:34PM +0200, Juan Quintela wrote:
> Make the ps2 device track its ledstate so that we can migrate it.
> Otherwise it gets lost across migration, and spice-server gets
> confused about the actual keyboard state and sends bogus
> caps/scroll/num key events. This fix
On Mon, Oct 17, 2011 at 11:25:42AM +0200, Gerd Hoffmann wrote:
> >
> > static const VMStateDescription vmstate_ps2_common = {
> > .name = "PS2 Common State",
> >-.version_id = 3,
> >+.version_id = 4,
> > .minimum_version_id = 2,
> > .minimum_version_id_old = 2,
> > .fie
Make the ps2 device track its ledstate so that we can migrate it.
Otherwise it gets lost across migration, and spice-server gets
confused about the actual keyboard state and sends bogus
caps/scroll/num key events. This fixes RH bug #729294
Signed-off-by: Christophe Fergeau
---
v3: use
Make the ps2 device track its ledstate so that we can migrate it.
Otherwise it gets lost across migration, and spice-server gets
confused about the actual keyboard state and sends bogus
caps/scroll/num key events. This fixes RH bug #729294
Signed-off-by: Christophe Fergeau
---
hw/ps2.c | 15
Hey,
On Wed, Oct 12, 2011 at 06:35:28PM +0200, Christophe Fergeau wrote:
> Make the ps2 device track its ledstate so that we can migrate it.
> Otherwise it gets lost across migration, and spice-server gets
> confused about the actual keyboard state and sends bogus
> caps/scroll/nu
Make the ps2 device track its ledstate so that we can migrate it.
Otherwise it gets lost across migration, and spice-server gets
confused about the actual keyboard state and sends bogus
caps/scroll/num key events.
Signed-off-by: Christophe Fergeau
---
hw/ps2.c | 13 +++--
1 files
On Fri, Jul 22, 2011 at 01:33:26PM +0200, Christophe Fergeau wrote:
> This is a resend of my series of libcacard fixes, no change since last
> version apart from the added "Reviewed-by" tag.
Scratch that, I put the wrong patches in the series (which strongly
indicates tha
rgs+1)" which will do what we expect.
Signed-off-by: Christophe Fergeau
Reviewed-by: Alon Levy
---
libcacard/vcard_emul_nss.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/libcacard/vcard_emul_nss.c b/libcacard/vcard_emul_nss.c
index f3db657..184252f 100644
--- a
se strings. valgrind rightfully
complained about this. It also didn't handle empty fields correctly,
Signed-off-by: Christophe Fergeau
Reviewed-by: Alon Levy
---
libcacard/vcard_emul_nss.c | 45 +++
1 files changed, 28 insertions(+), 17 deletions(-
copy_string reimplements strndup, this commit removes it and
replaces all copy_string uses with strndup.
Signed-off-by: Christophe Fergeau
Reviewed-by: Alon Levy
---
libcacard/vcard_emul_nss.c | 23 ++-
1 files changed, 6 insertions(+), 17 deletions(-)
diff --git a
vcard_emul_options now has repetitive code to read the current
token and advance to the next. After the previous changes,
this repetitive code can be moved in a NEXT_TOKEN macro to
avoid having this code duplicated.
Signed-off-by: Christophe Fergeau
Reviewed-by: Alon Levy
---
libcacard
unchanged
Christophe Fergeau (4):
libcacard: fix soft=... parsing in vcard_emul_options
libcacard: introduce NEXT_TOKEN macro
libcacard: replace copy_string with strndup
libcacard: don't leak vcard_emul_alloc_arrays mem
libcacard/vcard_emul_nss.c |
the memory that was allocated for these arrays should be freed
after use or they will be leaked.
Signed-off-by: Christophe Fergeau
---
libcacard/vcard_emul_nss.c | 11 ++-
1 files changed, 10 insertions(+), 1 deletions(-)
diff --git a/libcacard/vcard_emul_nss.c b/libcacard
se strings. valgrind rightfully
complained about this. It also didn't handle empty fields correctly,
Signed-off-by: Christophe Fergeau
Reviewed-by: Alon Levy
---
libcacard/vcard_emul_nss.c | 45 +++
1 files changed, 28 insertions(+), 17 deletions(-
copy_string reimplements strndup, this commit removes it and
replaces all copy_string uses with strndup.
Signed-off-by: Christophe Fergeau
Reviewed-by: Alon Levy
---
libcacard/vcard_emul_nss.c | 23 ++-
1 files changed, 6 insertions(+), 17 deletions(-)
diff --git a
vcard_emul_options now has repetitive code to read the current
token and advance to the next. After the previous changes,
this repetitive code can be moved in a NEXT_TOKEN macro to
avoid having this code duplicated.
Signed-off-by: Christophe Fergeau
Reviewed-by: Alon Levy
---
libcacard
Hi,
This is a resend of my series of libcacard fixes, no change since last
version apart from the added "Reviewed-by" tag.
Changes since v2:
- added Reviewed-by: Alon Levy to the 4 patches
Changes since v1:
- split first patch into 3 patches, v1 2/2 is unchanged
Christophe
Ping?
On Mon, Jul 04, 2011 at 06:10:43PM +0200, Christophe Fergeau wrote:
> vcard_emul_mirror_card and vcard_emul_init use
> vcard_emul_alloc_arrays to allocate memory for temporary arrays
> which will contain elements that in the end will be used one by
> one in cac_card_init
vcard_emul_mirror_card and vcard_emul_init use
vcard_emul_alloc_arrays to allocate memory for temporary arrays
which will contain elements that in the end will be used one by
one in cac_card_init. The arrays themselves are never stored
anywhere, they are only used as temporary containers. Hence
the
vcard_emul_options now has repetitive code to read the current
token and advance to the next. After the previous changes,
this repetitive code can be moved in a NEXT_TOKEN macro to
avoid having this code duplicated.
Signed-off-by: Christophe Fergeau
---
libcacard/vcard_emul_nss.c | 71
rgs+1)" which will do what we expect.
Signed-off-by: Christophe Fergeau
---
libcacard/vcard_emul_nss.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/libcacard/vcard_emul_nss.c b/libcacard/vcard_emul_nss.c
index f3db657..184252f 100644
--- a/libcacard/vcard_emul_n
Hey,
Alon asked me to split the parsing patches to make the review easier, to here
they are.
Changes since v1:
- split first patch into 3 patches, v1 2/2 is unchanged
Christophe Fergeau (4):
libcacard: s/strip(args++)/strip(args+1)
libcacard: fix soft=... parsing in vcard_emul_options
1 - 100 of 126 matches
Mail list logo
