Re: [PATCH] virtio-pci: Fix the failure process in kvm_virtio_pci_vector_use_one()

2024-04-18 Thread Cindy Lu
On Wed, Apr 17, 2024 at 2:38 AM Michael S. Tsirkin wrote: > > On Tue, Apr 16, 2024 at 02:14:57PM +0100, Peter Maydell wrote: > > On Tue, 16 Apr 2024 at 13:41, Cindy Lu wrote: > > > > > > On Tue, Apr 16, 2024 at 8:30 PM Peter Maydell > > > wrote: >

Re: [PATCH v8] virtio-pci: fix use of a released vector

2024-04-16 Thread Cindy Lu
On Tue, Apr 16, 2024 at 11:21 AM Jason Wang wrote: > > On Mon, Apr 15, 2024 at 6:41 PM Cindy Lu wrote: > > > > On Mon, Apr 15, 2024 at 5:34 PM Michael S. Tsirkin wrote: > > > > > > From: Cindy Lu > > > > > > During the booting process of th

Re: [PULL 1/1] virtio-pci: fix use of a released vector

2024-04-16 Thread Cindy Lu
On Tue, Apr 16, 2024 at 8:22 PM Peter Maydell wrote: > > On Tue, 16 Apr 2024 at 12:50, Peter Maydell wrote: > > > > On Tue, 16 Apr 2024 at 12:05, Cindy Lu wrote: > > > > > > On Tue, Apr 16, 2024 at 6:01 PM Peter Maydell > > > wrote: > > >

Re: [PULL 1/1] virtio-pci: fix use of a released vector

2024-04-16 Thread Cindy Lu
On Tue, Apr 16, 2024 at 7:50 PM Peter Maydell wrote: > > On Tue, 16 Apr 2024 at 12:05, Cindy Lu wrote: > > > > On Tue, Apr 16, 2024 at 6:01 PM Peter Maydell > > wrote: > > > Here we pass that through to kvm_virtio_pci_vector_use_one(). > > > In kvm_vir

Re: [PATCH] virtio-pci: Fix the failure process in kvm_virtio_pci_vector_use_one()

2024-04-16 Thread Cindy Lu
On Tue, Apr 16, 2024 at 8:30 PM Peter Maydell wrote: > > On Tue, 16 Apr 2024 at 13:29, Cindy Lu wrote: > > > > In function kvm_virtio_pci_vector_use_one(), in the undo label, > > the function will get the vector incorrectly while using > > VIRTIO_CONFIG_IRQ_

[PATCH] virtio-pci: Fix the failure process in kvm_virtio_pci_vector_use_one()

2024-04-16 Thread Cindy Lu
: qemu-sta...@nongnu.org Signed-off-by: Cindy Lu --- hw/virtio/virtio-pci.c | 19 +++ 1 file changed, 3 insertions(+), 16 deletions(-) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index b138fa127a..565bdb0897 100644 --- a/hw/virtio/virtio-pci.c +++ b/hw/virtio/virtio-pci.c

Re: [PULL 1/1] virtio-pci: fix use of a released vector

2024-04-16 Thread Cindy Lu
On Tue, Apr 16, 2024 at 6:01 PM Peter Maydell wrote: > > On Mon, 15 Apr 2024 at 11:52, Michael S. Tsirkin wrote: > > > > From: Cindy Lu > > > > During the booting process of the non-standard image, the behavior of the > > called function in qemu is a

Re: [PATCH v8] virtio-pci: fix use of a released vector

2024-04-15 Thread Cindy Lu
On Mon, Apr 15, 2024 at 5:34 PM Michael S. Tsirkin wrote: > > From: Cindy Lu > > During the booting process of the non-standard image, the behavior of the > called function in qemu is as follows: > > 1. vhost_net_stop() was triggered by guest image. This w

Re: [PATCH v8] virtio-pci: fix use of a released vector

2024-04-15 Thread Cindy Lu
On Mon, Apr 15, 2024 at 5:34 PM Michael S. Tsirkin wrote: > > From: Cindy Lu > > During the booting process of the non-standard image, the behavior of the > called function in qemu is as follows: > > 1. vhost_net_stop() was triggered by guest image. This w

Re: [PATCH v6] virtio-pci: Fix the crash that the vector was used after released.

2024-04-15 Thread Cindy Lu
On Mon, Apr 15, 2024 at 4:32 PM Michael S. Tsirkin wrote: > > On Fri, Apr 12, 2024 at 02:26:55PM +0800, Cindy Lu wrote: > > During the booting process of the non-standard image, the behavior of the > > called function in qemu is as follows: > > > > 1. vhost_net_stop(

Re: [PATCH v6] virtio-pci: Fix the crash that the vector was used after released.

2024-04-12 Thread Cindy Lu
; 0) { return; } ... So I move the setting vector into the function virtio_pci_set_and_change_vector() the other part are the same . the sanity test is passed and the qemu qtest is also passed Thanks Cindy On Fri, Apr 12, 2024 at 2:28 PM Cindy Lu wrote: > > During the booting process o

[PATCH v6] virtio-pci: Fix the crash that the vector was used after released.

2024-04-12 Thread Cindy Lu
pthread_create.c:442 23 0x7fc871512630 in clone3 () at ../sysdeps/unix/sysv/linux/x86_64/clone3.S:81 (gdb) Fixes: f9a09ca3ea ("vhost: add support for configure interrupt") Cc: qemu-sta...@nongnu.org Signed-off-by: Cindy Lu --- hw/virtio/virtio-pci.c | 43 +++

[PATCH v5] virtio-pci: Fix the crash that the vector was used after released.

2024-04-11 Thread Cindy Lu
pthread_create.c:442 23 0x7fc871512630 in clone3 () at ../sysdeps/unix/sysv/linux/x86_64/clone3.S:81 (gdb) Fixes: f9a09ca3ea ("vhost: add support for configure interrupt") Cc: qemu-sta...@nongnu.org Signed-off-by: Cindy Lu --- hw/virtio/virtio-pci.c | 29 ++

Re: [PATCH v4] virtio-pci: Fix the crash that the vector was used after released.

2024-04-11 Thread Cindy Lu
On Thu, Apr 11, 2024 at 1:56 PM Michael S. Tsirkin wrote: > > On Thu, Apr 11, 2024 at 12:11:30PM +0800, Cindy Lu wrote: > > During the booting process of the non-standard image, the behavior of the > > called function in qemu is as follows: > > > > 1. vhost_net_stop(

[PATCH v4] virtio-pci: Fix the crash that the vector was used after released.

2024-04-10 Thread Cindy Lu
pthread_create.c:442 23 0x7fc871512630 in clone3 () at ../sysdeps/unix/sysv/linux/x86_64/clone3.S:81 (gdb) Signed-off-by: Cindy Lu --- hw/virtio/virtio-pci.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c inde

Re: [PATCH v3] virtio-pci: Fix the crash that the vector was used after released.

2024-04-10 Thread Cindy Lu
On Thu, Apr 11, 2024 at 12:18 AM Michael S. Tsirkin wrote: > > On Thu, Apr 11, 2024 at 12:12:00AM +0800, Cindy Lu wrote: > > During the booting process of the non-standard image, the behavior of the > > called function in qemu is as follows: > > > > 1. vhost_net

[PATCH v3] virtio-pci: Fix the crash that the vector was used after released.

2024-04-10 Thread Cindy Lu
pthread_create.c:442 23 0x7fc871512630 in clone3 () at ../sysdeps/unix/sysv/linux/x86_64/clone3.S:81 (gdb) Signed-off-by: Cindy Lu --- hw/virtio/virtio-pci.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c inde

Re: [PATCH v2 1/1] virtio-pci: Fix the crash that the vector was used after released.

2024-04-10 Thread Cindy Lu
On Wed, Apr 10, 2024 at 1:48 PM Jason Wang wrote: > > On Wed, Apr 10, 2024 at 1:29 PM Cindy Lu wrote: > > > > When the guest triggers vhost_stop and then virtio_reset, the vector will > > the > > IRQFD for this vector will be released and change to VIRTIO_NO_VEC

Re: [PATCH v2 1/1] virtio-pci: Fix the crash that the vector was used after released.

2024-04-10 Thread Cindy Lu
On Wed, Apr 10, 2024 at 1:36 PM Jason Wang wrote: > > On Wed, Apr 10, 2024 at 1:29 PM Cindy Lu wrote: > > > > When the guest triggers vhost_stop and then virtio_reset, the vector will > > the > > IRQFD for this vector will be released and change to VIRTIO_NO_VEC

[PATCH v2 0/1] virtio-pci: Fix the crash that the vector was used after released

2024-04-09 Thread Cindy Lu
et_stop(), So this step will not lost during this process. Change from V1 1.add the check for if using irqfd 2.remove the check for bool recovery, irqfd's user is enough to check status Cindy Lu (1): virtio-pci: Fix the crash that the vector was used after released. hw/v

[PATCH v2 1/1] virtio-pci: Fix the crash that the vector was used after released.

2024-04-09 Thread Cindy Lu
d731 in kvm_vcpu_thread_fn (arg=0x560642f205e0) at ../accel/kvm/kvm-accel-ops.c:51 21 0x5606411949f4 in qemu_thread_start (args=0x560642f292b0) at ../util/qemu-thread-posix.c:541 22 0x7fc87148cdcd in start_thread (arg=) at pthread_create.c:442 23 0x7fc871512630 in clone3 () at ../sy

Re: [PATCH 1/1] virtio-pci: Fix the crash when the vector changes back from VIRTIO_NO_VECTOR

2024-04-08 Thread Cindy Lu
On Mon, Apr 8, 2024 at 12:59 PM Jason Wang wrote: > > On Sun, Apr 7, 2024 at 3:00 PM Cindy Lu wrote: > > > > On Sun, Apr 7, 2024 at 12:20 PM Jason Wang wrote: > > > > > > On Tue, Apr 2, 2024 at 11:02 PM Cindy Lu wrote: > > > > > > >

Re: [PATCH 1/1] virtio-pci: Fix the crash when the vector changes back from VIRTIO_NO_VECTOR

2024-04-07 Thread Cindy Lu
On Sun, Apr 7, 2024 at 12:20 PM Jason Wang wrote: > > On Tue, Apr 2, 2024 at 11:02 PM Cindy Lu wrote: > > > > When the guest calls virtio_stop and then virtio_reset, > > Guests could not call those functions directly, it is triggered by for > example writing to some

[PATCH 0/1] virtio-pci: Fix the crash when the vector changes back from VIRTIO_NO_VECTOR

2024-04-02 Thread Cindy Lu
0 is_masked 1 [msix_fire_vector_notifier] 112 called vector 0 is_masked 0 To fix this, we need to call the function "kvm_virtio_pci_vector_use_one()" when the vector changes back from VIRTIO_NO_VECTOR Signed-off-by: Cindy Lu Cindy Lu (1): virtio-pci: Fix the crash when the v

[PATCH 1/1] virtio-pci: Fix the crash when the vector changes back from VIRTIO_NO_VECTOR

2024-04-02 Thread Cindy Lu
e_one()" when the vector changes back from VIRTIO_NO_VECTOR Signed-off-by: Cindy Lu --- hw/virtio/virtio-pci.c | 31 --- 1 file changed, 28 insertions(+), 3 deletions(-) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index e433879542..45f3ab38c3 10064

Re: [RFC 0/2] disable the configuration interrupt for the unsupported device

2024-03-28 Thread Cindy Lu
On Thu, Mar 28, 2024 at 12:12 PM Jason Wang wrote: > > On Wed, Mar 27, 2024 at 5:33 PM Cindy Lu wrote: > > > > On Wed, Mar 27, 2024 at 5:12 PM Jason Wang wrote: > > > > > > On Wed, Mar 27, 2024 at 4:28 PM Cindy Lu wrote: > > > > > >

Re: [RFC 0/2] disable the configuration interrupt for the unsupported device

2024-03-28 Thread Cindy Lu
On Thu, Mar 28, 2024 at 12:14 PM Jason Wang wrote: > > On Wed, Mar 27, 2024 at 5:44 PM Cindy Lu wrote: > > > > On Wed, Mar 27, 2024 at 5:13 PM Jason Wang wrote: > > > > > > On Wed, Mar 27, 2024 at 5:12 PM Jason Wang wrote: > > > > > &g

Re: [RFC 0/2] disable the configuration interrupt for the unsupported device

2024-03-27 Thread Cindy Lu
On Wed, Mar 27, 2024 at 5:13 PM Jason Wang wrote: > > On Wed, Mar 27, 2024 at 5:12 PM Jason Wang wrote: > > > > On Wed, Mar 27, 2024 at 4:28 PM Cindy Lu wrote: > > > > > > On Wed, Mar 27, 2024 at 3:54 PM Jason Wang wrote: > > > > > &g

Re: [RFC 0/2] disable the configuration interrupt for the unsupported device

2024-03-27 Thread Cindy Lu
On Wed, Mar 27, 2024 at 5:12 PM Jason Wang wrote: > > On Wed, Mar 27, 2024 at 4:28 PM Cindy Lu wrote: > > > > On Wed, Mar 27, 2024 at 3:54 PM Jason Wang wrote: > > > > > > On Wed, Mar 27, 2024 at 2:03 PM Cindy Lu wrote: > > > > > >

Re: [RFC 0/2] disable the configuration interrupt for the unsupported device

2024-03-27 Thread Cindy Lu
On Wed, Mar 27, 2024 at 3:54 PM Jason Wang wrote: > > On Wed, Mar 27, 2024 at 2:03 PM Cindy Lu wrote: > > > > On Wed, Mar 27, 2024 at 11:05 AM Jason Wang wrote: > > > > > > Hi Cindy: > > > > > > On Wed, Mar 27, 2024 at 9:29 AM Cindy Lu

Re: [RFC 0/2] disable the configuration interrupt for the unsupported device

2024-03-27 Thread Cindy Lu
On Wed, Mar 27, 2024 at 11:05 AM Jason Wang wrote: > > Hi Cindy: > > On Wed, Mar 27, 2024 at 9:29 AM Cindy Lu wrote: > > > > we need a crash in Non-standard image, here is the jira for this > > https://issues.redhat.com/browse/RHEL-28522 > > The root cause of

[RFC 1/2] virtio-net: disable the configure interrupt for not support device

2024-03-26 Thread Cindy Lu
will set to true. Signed-off-by: Cindy Lu --- hw/net/virtio-net.c| 5 - hw/virtio/virtio.c | 1 + include/hw/virtio/virtio.h | 1 + 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index 80c56f0cfc..3b487864a8 100644 --- a/hw

[RFC 2/2] virtio-pci: check if the configure interrupt enable

2024-03-26 Thread Cindy Lu
If config_irq_enabled is not true, it means that configure interrupt is not supported. Therefore, the config vector will not be handled during the interrupt process. Signed-off-by: Cindy Lu --- hw/virtio/virtio-pci.c | 41 +++-- 1 file changed, 23 insertions

[RFC 0/2] disable the configuration interrupt for the unsupported device

2024-03-26 Thread Cindy Lu
Vyatta using, it doesn't support configure interrupts at all, So we plan to disable the configure interrupts in unsupported device Signed-off-by: Cindy Lu Cindy Lu (2): virtio-net: disable the configure interrupt for not support device virtio-pci: check if the configure interrupt enable hw/net

Re: Re: [PATCH] vdpa-dev: Fix initialisation order to restore VDUSE compatibility

2024-02-07 Thread Cindy Lu
Jason Wang 于2024年2月7日周三 11:17写道: > > On Tue, Feb 6, 2024 at 4:31 PM Stefano Garzarella wrote: > > > > On Tue, Feb 06, 2024 at 10:47:40AM +0800, Jason Wang wrote: > > >On Mon, Feb 5, 2024 at 6:51 PM Stefano Garzarella > > >wrote: > > >> > > >> On Fri, Feb 02, 2024 at 02:25:21PM +0100, Kevin

Re: [RFC 0/7] vhost-vdpa: add support for iommufd

2023-09-13 Thread Cindy Lu
3:30PM +0800, Cindy Lu wrote: > > Hi All > > There is the RFC to support the IOMMUFD in vdpa device > > any comments are welcome > > Thanks > > Cindy > > Any plans to work on this or should I consider this abandoned? > > > > Cindy Lu (7): > > vhos

Re: [RFC 0/7] vhost-vdpa: add support for iommufd

2023-06-05 Thread Cindy Lu
On Mon, Jun 5, 2023 at 1:41 PM Michael S. Tsirkin wrote: > > On Fri, May 05, 2023 at 02:29:23PM +0800, Cindy Lu wrote: > > On Fri, May 5, 2023 at 11:29 AM Jason Wang wrote: > > > > > > Hi Cindy > > > > > > On Wed, May 3, 2023 at

[PATCH v16 1/4] vhost: expose function vhost_dev_has_iommu()

2023-05-09 Thread Cindy Lu
To support vIOMMU in vdpa, need to exposed the function vhost_dev_has_iommu, vdpa will use this function to check if vIOMMU enable. Signed-off-by: Cindy Lu --- hw/virtio/vhost.c | 2 +- include/hw/virtio/vhost.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/hw

[PATCH v16 4/4] vhost-vdpa: Add support for vIOMMU.

2023-05-09 Thread Cindy Lu
in vhost_vdpa_dev_start, if the SVQ and IOMMU enable at the same time the function will return fail. 2. Skip the iova_max check vhost_vdpa_listener_skipped_section(). While MR is IOMMU, move this check to vhost_vdpa_iommu_map_notify() Verified in vp_vdpa and vdpa_sim_net driver Signed-off-by: Cindy Lu --- hw

[PATCH v16 3/4] vhost-vdpa: Add check for full 64-bit in region delete

2023-05-09 Thread Cindy Lu
The unmap ioctl doesn't accept a full 64-bit span. So need to add check for the section's size in vhost_vdpa_listener_region_del(). Signed-off-by: Cindy Lu --- hw/virtio/vhost-vdpa.c | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/hw/virtio/vhost-vdpa.c

[PATCH v16 0/4] vhost-vdpa: add support for vIOMMU

2023-05-09 Thread Cindy Lu
changes in V16 remove the batch mode operation in vIOMMU MR Cindy Lu (4): vhost: expose function vhost_dev_has_iommu() vhost_vdpa: fix the input in trace_vhost_vdpa_listener_region_del() vhost-vdpa: Add check for full 64-bit in region delete vhost-vdpa: Add support for vIOMMU. hw/virtio/vhost

[PATCH v16 2/4] vhost_vdpa: fix the input in trace_vhost_vdpa_listener_region_del()

2023-05-09 Thread Cindy Lu
In trace_vhost_vdpa_listener_region_del, the value for llend should change to int128_get64(int128_sub(llend, int128_one())) Signed-off-by: Cindy Lu --- hw/virtio/vhost-vdpa.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c

Re: [RFC 0/7] vhost-vdpa: add support for iommufd

2023-05-05 Thread Cindy Lu
On Fri, May 5, 2023 at 11:29 AM Jason Wang wrote: > > Hi Cindy > > On Wed, May 3, 2023 at 5:13 PM Cindy Lu wrote: > > > > Hi All > > There is the RFC to support the IOMMUFD in vdpa device > > any comments are welcome > > Thanks > > Cindy > &g

[RFC 5/7] vhost-vdpa: Add the iommufd support in the map/unmap function

2023-05-03 Thread Cindy Lu
iotlb message if iommufd enable Signed-off-by: Cindy Lu --- hw/virtio/vhost-vdpa.c | 56 ++ include/hw/virtio/vhost-vdpa.h | 24 +++ 2 files changed, 74 insertions(+), 6 deletions(-) diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c

[RFC 2/7] qapi: support iommufd in vdpa

2023-05-03 Thread Cindy Lu
Add a new option for iommufd, The usage is -object iommufd,id=iommufd0 \ -device virtio-net-pci,netdev=vhost-vdpa1,disable-legacy=on,disable-modern=off\ -netdev type=vhost-vdpa,vhostdev=/dev/vhost-vdpa-0,id=vhost-vdpa1,iommufd=iommufd0\ ... Signed-off-by: Cindy Lu --- qapi/net.json | 1

[RFC 7/7] vhost-vdpa-iommufd: Add iommufd support for vdpa

2023-05-03 Thread Cindy Lu
.    b. If this is the new asid,  get the new ioas_id and attach it to iommufd.        save this information in vdpa_iommufd.    c. Use the ioas_id for mapping    The unmap logic is the same Signed-off-by: Cindy Lu --- hw/virtio/meson.build | 2 +- hw/virtio/vhost-vdpa-iommufd.c

[RFC 1/7] vhost: introduce new UAPI to support IOMMUFD

2023-05-03 Thread Cindy Lu
Add 3 new UAPI VHOST_VDPA_SET_IOMMU_FD: this to bind the vdpa device to iommufd VDPA_DEVICE_ATTACH_IOMMUFD_AS: attach new ioas to iommufd VDPA_DEVICE_DTTACH_IOMMUFD_AS: detach all the ioas from iommufd Signed-off-by: Cindy Lu --- linux-headers/linux/vhost.h | 72

[RFC 4/7] net/vhost-vdpa: Add the check for iommufd

2023-05-03 Thread Cindy Lu
Add the check for object iommufd, if the iommfd enabled. pass the information to vhost_vdpa. vhost_vdpa dev start will check this bool and connect to the iommufd Signed-off-by: Cindy Lu --- net/vhost-vdpa.c | 31 +-- 1 file changed, 17 insertions(+), 14 deletions

[RFC 6/7] vhost-vdpa: init iommufd function in vhost_vdpa start

2023-05-03 Thread Cindy Lu
Add support for iommufd, init the vdpa_iommufd in vdpa_start in this step, driver will bind to the iommufd device and attach the default ASID(asid 0) to iommufd Signed-off-by: Cindy Lu --- hw/virtio/vhost-vdpa.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/hw/virtio

[RFC 0/7] vhost-vdpa: add support for iommufd

2023-05-03 Thread Cindy Lu
Hi All There is the RFC to support the IOMMUFD in vdpa device any comments are welcome Thanks Cindy Cindy Lu (7): vhost: introduce new UAPI to support IOMMUFD qapi: support iommufd in vdpa virtio : add a ptr for vdpa_iommufd in VirtIODevice net/vhost-vdpa: Add the check for iommufd

[RFC 3/7] virtio : add a ptr for vdpa_iommufd in VirtIODevice

2023-05-03 Thread Cindy Lu
and write Signed-off-by: Cindy Lu --- include/hw/virtio/vhost-vdpa.h | 23 +++ include/hw/virtio/virtio.h | 5 + 2 files changed, 28 insertions(+) diff --git a/include/hw/virtio/vhost-vdpa.h b/include/hw/virtio/vhost-vdpa.h index 7997f09a8d..309d4ffc70 100644

Re: [PATCH v15 4/4] vhost-vdpa: Add support for vIOMMU.

2023-03-23 Thread Cindy Lu
On Fri, Mar 24, 2023 at 10:49 AM Jason Wang wrote: > > On Thu, Mar 23, 2023 at 4:41 PM Cindy Lu wrote: > > > > On Thu, Mar 23, 2023 at 11:47 AM Jason Wang wrote: > > > > > > On Tue, Mar 21, 2023 at 10:24 PM Cindy Lu wrote: > > > > > > >

Re: [PATCH v15 4/4] vhost-vdpa: Add support for vIOMMU.

2023-03-23 Thread Cindy Lu
On Thu, Mar 23, 2023 at 11:47 AM Jason Wang wrote: > > On Tue, Mar 21, 2023 at 10:24 PM Cindy Lu wrote: > > > > 1. The vIOMMU support will make vDPA can work in IOMMU mode. This > > will fix security issues while using the no-IOMMU mode. > > To support this featur

[PATCH v15 2/4] vhost_vdpa: fix the input in trace_vhost_vdpa_listener_region_del()

2023-03-21 Thread Cindy Lu
In trace_vhost_vdpa_listener_region_del, the value for llend should change to int128_get64(int128_sub(llend, int128_one())) Signed-off-by: Cindy Lu --- hw/virtio/vhost-vdpa.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c

[PATCH v15 4/4] vhost-vdpa: Add support for vIOMMU.

2023-03-21 Thread Cindy Lu
in vhost_vdpa_dev_start, if the SVQ and IOMMU enable at the same time the function will return fail. 2. Skip the iova_max check vhost_vdpa_listener_skipped_section(). While MR is IOMMU, move this check to vhost_vdpa_iommu_map_notify() Verified in vp_vdpa and vdpa_sim_net driver Signed-off-by: Cindy Lu --- hw

[PATCH v15 1/4] vhost: expose function vhost_dev_has_iommu()

2023-03-21 Thread Cindy Lu
To support vIOMMU in vdpa, need to exposed the function vhost_dev_has_iommu, vdpa will use this function to check if vIOMMU enable. Signed-off-by: Cindy Lu --- hw/virtio/vhost.c | 2 +- include/hw/virtio/vhost.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/hw

[PATCH v15 3/4] vhost-vdpa: Add check for full 64-bit in region delete

2023-03-21 Thread Cindy Lu
The unmap ioctl doesn't accept a full 64-bit span. So need to add check for the section's size in vhost_vdpa_listener_region_del(). Signed-off-by: Cindy Lu --- hw/virtio/vhost-vdpa.c | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/hw/virtio/vhost-vdpa.c

[PATCH v15 0/4] vhost-vdpa: add support for vIOMMU

2023-03-21 Thread Cindy Lu
the crash found in test changes in V12 Address the comments, squash patch 1 into the next patch improve the code style issue changes in V13 fail to start if IOMMU and svq enable at same time improve the code style issue changes in V14 Address the comments changes in V15 Address the comments Cindy

Re: [PATCH v14 4/4] vhost-vdpa: Add support for vIOMMU.

2023-03-21 Thread Cindy Lu
On Tue, Mar 21, 2023 at 11:21 AM Jason Wang wrote: > > On Tue, Mar 21, 2023 at 12:20 AM Cindy Lu wrote: > > > > 1. The vIOMMU support will make vDPA can work in IOMMU mode. This > > will fix security issues while using the no-IOMMU mode. > > To support this featur

[PATCH v14 1/4] vhost: expose function vhost_dev_has_iommu()

2023-03-20 Thread Cindy Lu
To support vIOMMU in vdpa, need to exposed the function vhost_dev_has_iommu, vdpa will use this function to check if vIOMMU enable. Signed-off-by: Cindy Lu --- hw/virtio/vhost.c | 2 +- include/hw/virtio/vhost.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/hw

[PATCH v14 2/4] vhost_vdpa: fix the input in trace_vhost_vdpa_listener_region_del()

2023-03-20 Thread Cindy Lu
In trace_vhost_vdpa_listener_region_del, the value for llend should change to int128_get64(int128_sub(llend, int128_one())) Signed-off-by: Cindy Lu --- hw/virtio/vhost-vdpa.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c

[PATCH v14 4/4] vhost-vdpa: Add support for vIOMMU.

2023-03-20 Thread Cindy Lu
in vhost_vdpa_dev_start, if the SVQ and IOMMU enable at the same time the function will return fail. 2. Skip the iova_max check vhost_vdpa_listener_skipped_section(). While MR is IOMMU, move this check to  vhost_vdpa_iommu_map_notify() Verified in vp_vdpa and vdpa_sim_net driver Signed-off-by: Cindy Lu --- hw

[PATCH v14 0/4] vhost-vdpa: add support for vIOMMU

2023-03-20 Thread Cindy Lu
the crash found in test changes in V12 Address the comments, squash patch 1 into the next patch improve the code style issue changes in V13 fail to start if IOMMU and svq enable at same time improve the code style issue changes in V14 Address the comments Cindy Lu (4): vhost: expose function

[PATCH v14 3/4] vhost-vdpa: Add check for full 64-bit in region delete

2023-03-20 Thread Cindy Lu
The unmap ioctl doesn't accept a full 64-bit span. So need to add check for the section's size in vhost_vdpa_listener_region_del(). Signed-off-by: Cindy Lu --- hw/virtio/vhost-vdpa.c | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/hw/virtio/vhost-vdpa.c

Re: [PATCH v13 2/2] vhost-vdpa: add support for vIOMMU

2023-03-14 Thread Cindy Lu
On Mon, Mar 6, 2023 at 11:36 AM Jason Wang wrote: > > > 在 2023/2/8 10:57, Cindy Lu 写道: > > 1.Add support for vIOMMU. > > Add the new function to deal with iommu MR. > > - during iommu_region_add register a specific IOMMU notifier, > >and store all

[PATCH v13 2/2] vhost-vdpa: add support for vIOMMU

2023-02-07 Thread Cindy Lu
-by: Cindy Lu --- hw/virtio/vhost-vdpa.c | 173 ++--- include/hw/virtio/vhost-vdpa.h | 11 +++ 2 files changed, 173 insertions(+), 11 deletions(-) diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c index 542e003101..46f676ab71 100644 --- a/hw/virtio

[PATCH v13 0/2] vhost-vdpa: add support for vIOMMU

2023-02-07 Thread Cindy Lu
the crash found in test changes in V12 Address the comments, squash patch 1 into the next patch improve the code style issue changes in V13 fail to start if IOMMU and svq enable at same time improve the code style issue Cindy Lu (2): vhost: expose function vhost_dev_has_iommu() vhost-vdpa: add

[PATCH v13 1/2] vhost: expose function vhost_dev_has_iommu()

2023-02-07 Thread Cindy Lu
To support vIOMMU in vdpa, need to exposed the function vhost_dev_has_iommu, vdpa will use this function to check if vIOMMU enable. Signed-off-by: Cindy Lu --- hw/virtio/vhost.c | 2 +- include/hw/virtio/vhost.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/hw

[PATCH v21 06/10] virtio: add support for configure interrupt

2022-12-21 Thread Cindy Lu
Add the functions to support the configure interrupt in virtio The function virtio_config_guest_notifier_read will notify the guest if there is an configure interrupt. The function virtio_config_set_guest_notifier_fd_handler is to set the fd hander for the notifier Signed-off-by: Cindy Lu

[PATCH v21 07/10] vhost: add support for configure interrupt

2022-12-21 Thread Cindy Lu
Add functions to support configure interrupt. The configure interrupt process will start in vhost_dev_start and stop in vhost_dev_stop. Also add the functions to support vhost_config_pending and vhost_config_mask. Signed-off-by: Cindy Lu --- hw/virtio/vhost.c | 78

[PATCH v21 08/10] virtio-net: add support for configure interrupt

2022-12-21 Thread Cindy Lu
Add functions to support configure interrupt in virtio_net Add the functions to support vhost_net_config_pending and vhost_net_config_mask. Signed-off-by: Cindy Lu --- hw/net/vhost_net-stub.c | 9 + hw/net/vhost_net.c | 9 + hw/net/virtio-net.c | 4 ++-- include/net

[PATCH v21 09/10] virtio-mmio: add support for configure interrupt

2022-12-21 Thread Cindy Lu
Add configure interrupt support in virtio-mmio bus. add function to set configure guest notifier. Signed-off-by: Cindy Lu --- hw/virtio/virtio-mmio.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/hw/virtio/virtio-mmio.c b/hw/virtio/virtio-mmio.c index

[PATCH v21 10/10] virtio-pci: add support for configure interrupt

2022-12-21 Thread Cindy Lu
Add process to handle the configure interrupt, The function's logic is the same with vq interrupt.Add extra process to check the configure interrupt Signed-off-by: Cindy Lu --- hw/virtio/virtio-pci.c | 118 +++-- include/hw/virtio/virtio-pci.h | 4 +- 2

[PATCH v21 05/10] vhost-vdpa: add support for config interrupt

2022-12-21 Thread Cindy Lu
Add new call back function in vhost-vdpa, The function vhost_set_config_call can set the event fd to kernel. This function will be called in the vhost_dev_start and vhost_dev_stop Signed-off-by: Cindy Lu --- hw/virtio/trace-events | 1 + hw/virtio/vhost-vdpa.c | 8 2 files changed, 9

[PATCH v21 03/10] virtio-pci: decouple the single vector from the interrupt process

2022-12-21 Thread Cindy Lu
-off-by: Cindy Lu --- hw/virtio/virtio-pci.c | 131 +++-- 1 file changed, 73 insertions(+), 58 deletions(-) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index 52c7692fff..ec816ea367 100644 --- a/hw/virtio/virtio-pci.c +++ b/hw/virtio/virtio

[PATCH v21 01/10] virtio: introduce macro VIRTIO_CONFIG_IRQ_IDX

2022-12-21 Thread Cindy Lu
, the function will just return Signed-off-by: Cindy Lu --- hw/display/vhost-user-gpu.c| 18 ++ hw/net/virtio-net.c| 22 -- hw/virtio/vhost-user-fs.c | 18 ++ hw/virtio/vhost-user-gpio.c| 10 ++ hw/virtio/vhost

[PATCH v21 00/10] vhost-vdpa: add support for configure interrupt

2022-12-21 Thread Cindy Lu
is a new device,So I missed to add the VIRTIO_CONFIG_IRQ_IDX check in notifier_mask changes in v19 fix the crash in qtest rebased the code based on upstream changes in v20 fix the compile issue in mingw32 Cindy Lu (10): virtio: introduce macro VIRTIO_CONFIG_IRQ_IDX virtio-pci: decouple

[PATCH v21 04/10] vhost: introduce new VhostOps vhost_set_config_call

2022-12-21 Thread Cindy Lu
This patch introduces new VhostOps vhost_set_config_call. This function allows the qemu to set the config event fd to kernel driver. Signed-off-by: Cindy Lu --- include/hw/virtio/vhost-backend.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/hw/virtio/vhost-backend.h b/include

[PATCH v21 02/10] virtio-pci: decouple notifier from interrupt process

2022-12-21 Thread Cindy Lu
To reuse the notifier process. We add the virtio_pci_get_notifier to get the notifier and vector. The INPUT for this function is IDX, The OUTPUT is the notifier and the vector Signed-off-by: Cindy Lu --- hw/virtio/virtio-pci.c | 88 +++--- 1 file changed, 57

Re: [PATCH v20 08/10] virtio-net: add support for configure interrupt

2022-12-21 Thread Cindy Lu
On Wed, 21 Dec 2022 at 19:25, Michael S. Tsirkin wrote: > > On Mon, Dec 12, 2022 at 01:20:40AM +0800, Cindy Lu wrote: > > Add functions to support configure interrupt in virtio_net > > Add the functions to support vhost_net_config_pending > > and vhost_net_config_

Re: [PATCH v12 0/1] vhost-vdpa: add support for vIOMMU

2022-12-20 Thread Cindy Lu
On Tue, 20 Dec 2022 at 22:33, Michael S. Tsirkin wrote: > > On Fri, Dec 09, 2022 at 09:08:04PM +0800, Cindy Lu wrote: > > These patches are to support vIOMMU in vdpa device > > Verified in vp_vdpa/vdpa_sim_net driverand intel_iommu > > virtio-iommu device > > Pls add

[PATCH v20 10/10] virtio-pci: add support for configure interrupt

2022-12-11 Thread Cindy Lu
Add process to handle the configure interrupt, The function's logic is the same with vq interrupt.Add extra process to check the configure interrupt Signed-off-by: Cindy Lu --- hw/virtio/virtio-pci.c | 118 +++-- include/hw/virtio/virtio-pci.h | 4 +- 2

[PATCH v20 04/10] vhost: introduce new VhostOps vhost_set_config_call

2022-12-11 Thread Cindy Lu
This patch introduces new VhostOps vhost_set_config_call. This function allows the qemu to set the config event fd to kernel driver. Signed-off-by: Cindy Lu --- include/hw/virtio/vhost-backend.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/hw/virtio/vhost-backend.h b/include

[PATCH v20 07/10] vhost: add support for configure interrupt

2022-12-11 Thread Cindy Lu
Add functions to support configure interrupt. The configure interrupt process will start in vhost_dev_start and stop in vhost_dev_stop. Also add the functions to support vhost_config_pending and vhost_config_mask. Signed-off-by: Cindy Lu --- hw/virtio/vhost.c | 78

[PATCH v20 03/10] virtio-pci: decouple the single vector from the interrupt process

2022-12-11 Thread Cindy Lu
-off-by: Cindy Lu --- hw/virtio/virtio-pci.c | 131 +++-- 1 file changed, 73 insertions(+), 58 deletions(-) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index 52c7692fff..ec816ea367 100644 --- a/hw/virtio/virtio-pci.c +++ b/hw/virtio/virtio

[PATCH v20 09/10] virtio-mmio: add support for configure interrupt

2022-12-11 Thread Cindy Lu
Add configure interrupt support in virtio-mmio bus. add function to set configure guest notifier. Signed-off-by: Cindy Lu --- hw/virtio/virtio-mmio.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/hw/virtio/virtio-mmio.c b/hw/virtio/virtio-mmio.c index

[PATCH v20 00/10] vhost-vdpa: add support for configure interrupt

2022-12-11 Thread Cindy Lu
,So I missed to add the VIRTIO_CONFIG_IRQ_IDX check in notifier_mask changes in v19 fix the crash in qtest rebased the code based on upstream Cindy Lu (10): virtio: introduce macro VIRTIO_CONFIG_IRQ_IDX virtio-pci: decouple notifier from interrupt process virtio-pci: decouple the single

[PATCH v20 08/10] virtio-net: add support for configure interrupt

2022-12-11 Thread Cindy Lu
Add functions to support configure interrupt in virtio_net Add the functions to support vhost_net_config_pending and vhost_net_config_mask. Signed-off-by: Cindy Lu --- hw/net/vhost_net.c | 9 + hw/net/virtio-net.c | 4 ++-- include/net/vhost_net.h | 2 ++ 3 files changed, 13

[PATCH v20 06/10] virtio: add support for configure interrupt

2022-12-11 Thread Cindy Lu
Add the functions to support the configure interrupt in virtio The function virtio_config_guest_notifier_read will notify the guest if there is an configure interrupt. The function virtio_config_set_guest_notifier_fd_handler is to set the fd hander for the notifier Signed-off-by: Cindy Lu

[PATCH v20 02/10] virtio-pci: decouple notifier from interrupt process

2022-12-11 Thread Cindy Lu
To reuse the notifier process. We add the virtio_pci_get_notifier to get the notifier and vector. The INPUT for this function is IDX, The OUTPUT is the notifier and the vector Signed-off-by: Cindy Lu --- hw/virtio/virtio-pci.c | 88 +++--- 1 file changed, 57

[PATCH v20 01/10] virtio: introduce macro VIRTIO_CONFIG_IRQ_IDX

2022-12-11 Thread Cindy Lu
, the function will just return Signed-off-by: Cindy Lu --- hw/display/vhost-user-gpu.c| 18 ++ hw/net/virtio-net.c| 22 -- hw/virtio/vhost-user-fs.c | 18 ++ hw/virtio/vhost-user-gpio.c| 10 ++ hw/virtio/vhost

[PATCH v20 05/10] vhost-vdpa: add support for config interrupt

2022-12-11 Thread Cindy Lu
Add new call back function in vhost-vdpa, The function vhost_set_config_call can set the event fd to kernel. This function will be called in the vhost_dev_start and vhost_dev_stop Signed-off-by: Cindy Lu --- hw/virtio/trace-events | 1 + hw/virtio/vhost-vdpa.c | 8 2 files changed, 9

[PATCH v12 1/1] vhost-vdpa: add support for vIOMMU

2022-12-09 Thread Cindy Lu
. - during iommu_region_del, compare and delete the IOMMU notifier from the list Verified in vp_vdpa and vdpa_sim_net driver Signed-off-by: Cindy Lu --- hw/virtio/vhost-vdpa.c | 162 ++--- include/hw/virtio/vhost-vdpa.h | 10 ++ 2 files changed, 161 insertions

[PATCH v12 0/1] vhost-vdpa: add support for vIOMMU

2022-12-09 Thread Cindy Lu
changes in V10 Address the comments changes in V11 Address the comments fix the crash found in test changes in V12 Address the comments, squash patch 1 into the next patch improve the code style issue Cindy Lu (1): vhost-vdpa: add support for vIOMMU hw/virtio/vhost-vdpa.c | 162

Re: [PATCH v11 1/2] vhost-vdpa: Skip the range check while MR is IOMMU

2022-12-08 Thread Cindy Lu
On Thu, 8 Dec 2022 at 15:42, Jason Wang wrote: > > On Wed, Nov 30, 2022 at 1:33 PM Cindy Lu wrote: > > > > Skip the check in vhost_vdpa_listener_skipped_section() while > > MR is IOMMU, Move this check to vhost_vdpa_iommu_map_notify() > > > > Signed-off-

Re: [PATCH] vhost: Not return fail while the device does not support send_iotlb_msg

2022-12-02 Thread Cindy Lu
On Thu, 1 Dec 2022 at 16:49, Jason Wang wrote: > > On Wed, Nov 30, 2022 at 4:11 PM Cindy Lu wrote: > > > > Some device does not support vhost_send_device_iotlb_msg() > > such as vDPA device, which is as expected. So we should not > > return fail here. > > Plea

[PATCH] vhost: Not return fail while the device does not support send_iotlb_msg

2022-11-30 Thread Cindy Lu
Some device does not support vhost_send_device_iotlb_msg() such as vDPA device, which is as expected. So we should not return fail here. Signed-off-by: Cindy Lu --- hw/virtio/vhost-backend.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/virtio/vhost-backend.c b/hw

[PATCH v11 0/2] vhost-vdpa: add support for vIOMMU

2022-11-29 Thread Cindy Lu
the crash found in test Cindy Lu (2): vhost-vdpa: Skip the range check while MR is IOMMU vhost-vdpa: add support for vIOMMU hw/virtio/vhost-vdpa.c | 168 ++--- include/hw/virtio/vhost-vdpa.h | 10 ++ 2 files changed, 167 insertions(+), 11 deletions

[PATCH v11 1/2] vhost-vdpa: Skip the range check while MR is IOMMU

2022-11-29 Thread Cindy Lu
Skip the check in vhost_vdpa_listener_skipped_section() while MR is IOMMU, Move this check to vhost_vdpa_iommu_map_notify() Signed-off-by: Cindy Lu --- hw/virtio/vhost-vdpa.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/hw/virtio/vhost-vdpa.c b/hw

[PATCH v11 2/2] vhost-vdpa: add support for vIOMMU

2022-11-29 Thread Cindy Lu
-off-by: Cindy Lu --- hw/virtio/vhost-vdpa.c | 147 - include/hw/virtio/vhost-vdpa.h | 10 +++ 2 files changed, 153 insertions(+), 4 deletions(-) diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c index f0e9963d19..4137094fef 100644 --- a/hw

  1   2   3   4   5   6   >