Re: [PATCH 3/4] python/qmp-shell: relicense as LGPLv2+

2022-03-30 Thread Cleber Rosa
ion from the current authors of this > tool to loosen the license. At present, those people are: > > - John Snow (me!), 411/609 > - Luiz Capitulino, Author, 97/609 > - Daniel Berrangé, 81/609 > - Eduardo Habkost, 10/609 > - Marc-André Lureau, 6/609 > - Fam Zheng, 3/609 > -

Re: [PATCH v2] tests/avocado: starts PhoneServer upfront

2022-03-16 Thread Cleber Rosa
t, then we save this information so we can > later configure the guest. > > Suggested-by: Daniel P. Berrangé > Signed-off-by: Beraldo Leal > --- > tests/avocado/avocado_qemu/__init__.py | 13 +++-- > 1 file changed, 7 insertions(+), 6 deletions(-) Reviewed-by: Cleber Rosa Tested-by: Cleber Rosa

Re: [PATCH] tests/avocado: starts PhoneServer upfront

2022-03-11 Thread Cleber Rosa
Beraldo Leal writes: > On Fri, Mar 11, 2022 at 09:28:24AM -0500, Cleber Rosa wrote: >> >> Beraldo Leal writes: >> >> > Race conditions can happen with the current code, because the port that >> > was available might not be anymore by the time the

Re: [PATCH] tests/avocado: starts PhoneServer upfront

2022-03-11 Thread Cleber Rosa
Beraldo Leal writes: > Race conditions can happen with the current code, because the port that > was available might not be anymore by the time the server is started. > > By setting the port to 0, PhoneServer it will use the OS default > behavior to get a free port, then we save this

Re: [PATCH] tests/avocado: Cancel BootLinux tests in case there is no free port

2022-03-10 Thread Cleber Rosa
> > tests/avocado/avocado_qemu/__init__.py | 2 ++ > 1 file changed, 2 insertions(+) > LGTM, despite the root issue is being addressed in Avocado. Reviewed-by: Cleber Rosa

Re: [PATCH 5/9] tests/avocado/linux_ssh_mips_malta.py: add missing accel (tcg) tag

2022-03-03 Thread Cleber Rosa
Philippe Mathieu-Daudé writes: > On 25/2/22 22:01, Cleber Rosa wrote: >> Being explicit about the accelerator used on these tests is a good >> thing in itself, but it will also be used in the filtering rules >> applied on "make check-avocado". >> Signed-o

[PATCH 8/9] Avocado tests: classify tests based on what it's booted

2022-02-25 Thread Cleber Rosa
possible, if deemed valuable, to further evolve this classification into one with a clear separation between mechanism and content. Signed-off-by: Cleber Rosa --- tests/avocado/boot_linux.py | 4 ++ tests/avocado/boot_linux_console.py | 54 +++ tests/

[PATCH 9/9] Avocado tests: don't run tests with TCG that boot full blown distros

2022-02-25 Thread Cleber Rosa
ts or tags to be used on a "make check-avocado" by setting AVOCADO_TESTS or AVOCADO_TAGS. Signed-off-by: Cleber Rosa --- tests/Makefile.include | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 676aa0d94

[PATCH 4/9] Avocado: bump to version 95.0

2022-02-25 Thread Cleber Rosa
t timeouts or similar reasons when run under systems with limited or shared resources. To avoid breakages, especially on CI, let's keep the serial execution until proven that it won't impact the CI jobs. Signed-off-by: Cleber Rosa --- tests/Makefile.include | 1 + tests/requirements.txt | 2 +- 2 fil

[PATCH 0/9] Avocado tests: filter out tests using TCG booting full blown distros

2022-02-25 Thread Cleber Rosa
minutes. [1] https://lists.gnu.org/archive/html/qemu-devel/2021-07/msg07271.html [2] https://gitlab.com/cleber.gnu/qemu/-/pipelines/479720240 [3] https://gitlab.com/qemu-project/qemu/-/pipelines/478580581 Cleber Rosa (9): Avocado GitLab CI jobs: don't reset TARGETS and simplify commands Avocad

[PATCH 6/9] tests/avocado/virtiofs_submounts.py: shared_dir may not exist

2022-02-25 Thread Cleber Rosa
If the test is skipped because of their conditionals, the shared_dir attribute may not exist. Check for its existence in the tearDown() method to avoid and AttributeError. Signed-off-by: Cleber Rosa --- tests/avocado/virtiofs_submounts.py | 7 --- 1 file changed, 4 insertions(+), 3

[PATCH 3/9] Avocado migration test: adapt to "utils.network" API namespace change

2022-02-25 Thread Cleber Rosa
t/releases/94_0.html#utility-apis Signed-off-by: Cleber Rosa --- tests/avocado/avocado_qemu/__init__.py | 5 +++-- tests/avocado/migration.py | 4 ++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/tests/avocado/avocado_qemu/__init__.py b/tests/avocado/avocado_qemu/_

[PATCH 7/9] Avocado tests: improve documentation on tag filtering

2022-02-25 Thread Cleber Rosa
It's possible to filter based on a combination of criteria. This adds examples to the documentation. Signed-off-by: Cleber Rosa --- docs/devel/testing.rst | 22 ++ 1 file changed, 22 insertions(+) diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst index

[PATCH 5/9] tests/avocado/linux_ssh_mips_malta.py: add missing accel (tcg) tag

2022-02-25 Thread Cleber Rosa
Being explicit about the accelerator used on these tests is a good thing in itself, but it will also be used in the filtering rules applied on "make check-avocado". Signed-off-by: Cleber Rosa --- tests/avocado/linux_ssh_mips_malta.py | 3 +++ 1 file changed, 3 insertions(+) diff --g

[PATCH 2/9] Avocado tests: use logging namespace that is preserved in test logs

2022-02-25 Thread Cleber Rosa
quot; as a namespace prefix for everything that Avocado should collect/preserve, and other prefixes for logged content that should be handled differently. [1] - https://avocado-framework.readthedocs.io/en/94.0/releases/92_0.html#users-test-writers Signed-off-by: Cleber Rosa --- tests/avocado/a

[PATCH 1/9] Avocado GitLab CI jobs: don't reset TARGETS and simplify commands

2022-02-25 Thread Cleber Rosa
to be run on each job, and less noise on the test results. Signed-off-by: Cleber Rosa --- .gitlab-ci.d/buildtest-template.yml | 3 +++ .gitlab-ci.d/buildtest.yml | 9 - 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/.gitlab-ci.d/buildtest-template.yml b/.gitlab

Re: "make check-acceptance" takes way too long

2022-02-01 Thread Cleber Rosa
On Tue, Feb 1, 2022 at 1:06 PM Alex Bennée wrote: > > > Cleber Rosa writes: > > > On Tue, Feb 1, 2022 at 11:20 AM Daniel P. Berrangé > > wrote: > >> > >> On Tue, Feb 01, 2022 at 11:01:43AM -0500, Cleber Rosa wrote: > >> > On

Re: "make check-acceptance" takes way too long

2022-02-01 Thread Cleber Rosa
On Tue, Feb 1, 2022 at 12:01 PM Daniel P. Berrangé wrote: > > On Tue, Feb 01, 2022 at 12:29:56AM -0500, Cleber Rosa wrote: > > > > Assuming this is about "Testing that QEMU can boot a full distro", I > > wouldn't > > try to solve the problem by making the

Re: "make check-acceptance" takes way too long

2022-02-01 Thread Cleber Rosa
On Tue, Feb 1, 2022 at 11:20 AM Daniel P. Berrangé wrote: > > On Tue, Feb 01, 2022 at 11:01:43AM -0500, Cleber Rosa wrote: > > On Tue, Feb 1, 2022 at 6:25 AM Alex Bennée wrote: > > > > > > We have up to now tried really hard as a project to avoid building and

Re: "make check-acceptance" takes way too long

2022-02-01 Thread Cleber Rosa
On Tue, Feb 1, 2022 at 6:07 AM Kashyap Chamarthy wrote: > > On Tue, Jan 25, 2022 at 10:20:11AM +0100, Gerd Hoffmann wrote: > > Hi, > > > > > IMHO the ideal scenario would be for us to have a kernel, initrd > > > containing just busybox tools for the key arch targets we care > > > about. Those

Re: "make check-acceptance" takes way too long

2022-02-01 Thread Cleber Rosa
On Tue, Feb 1, 2022 at 6:25 AM Alex Bennée wrote: > > We have up to now tried really hard as a project to avoid building and > hosting our own binaries to avoid theoretical* GPL compliance issues. > This is why we've ended up relying so much on distros to build and host > binaries we can use.

Re: "make check-acceptance" takes way too long

2022-01-31 Thread Cleber Rosa
On Fri, Jan 21, 2022 at 10:22 AM Daniel P. Berrangé wrote: > > On Fri, Jan 21, 2022 at 12:23:23PM +, Alex Bennée wrote: > > > > Peter Maydell writes: > > > > > On Fri, 21 Jan 2022 at 10:50, Markus Armbruster wrote: > > >> No objection, but it's no replacement for looking into why these

Re: [PATCH] python: pin setuptools below v60.0.0

2022-01-21 Thread Cleber Rosa
python/Makefile | 2 ++ > python/setup.cfg | 1 + > 2 files changed, 3 insertions(+) > Reviewed-by: Cleber Rosa Tested-by: Cleber Rosa

Give the fosshost.org VM a purpose or a retirement

2021-11-24 Thread Cleber Rosa
Hi, Fosshost.org was kind enough to supply the QEMU project with a public VM hosted by them. The original use case we anticipated was to set up a GitLab CI runner, because we assumed the VM was KVM capable, but that turned out not to be the case. So, at this point, adding it as a GitLab CI

[PATCH v2 1/1] Jobs based on custom runners: add CentOS Stream 8

2021-11-11 Thread Cleber Rosa
t with the given configuration (point II) under the given OS build environment (point I) should be subjected to. IV) Job definition: GitLab CI jobs that will dispatch the build/test jobs (see points #II and #III) to the machine specifically configured according to #I. Signed-off-by:

[PATCH v2 0/1] Jobs based on custom runners: add CentOS Stream 8

2021-11-11 Thread Cleber Rosa
c8s-stream-rhel branch) from CentOS repo at https://git.centos.org/rpms/qemu-kvm/. * Further separated distribution version and architecture specific files into separate sub directories. * Added a gitlab CI rule and variable to allow other repos/users who have a CentOS Stream 8 x86_64 ru

[PATCH 14/16] tests/acceptance/ppc_prep_40p.py: NetBSD 7.1.2 location update

2021-09-24 Thread Cleber Rosa
The NetBSD-7.1.2-prep.iso is no longer available on the CDN, but it's still available in the archive. Let's update its location so that users without the file on cache can still fetch it and run the test. Signed-off-by: Cleber Rosa --- tests/acceptance/ppc_prep_40p.py | 4 ++-- 1 file changed

[PATCH 16/16] tests/acceptance/ppc_prep_40p.py: unify tags

2021-09-24 Thread Cleber Rosa
The arch and machine tags apply to all tests, so let's define them only once. Signed-off-by: Cleber Rosa --- tests/acceptance/ppc_prep_40p.py | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/tests/acceptance/ppc_prep_40p.py b/tests/acceptance/ppc_prep_40p.py

[PATCH 13/16] tests/acceptance/boot_xen.py: use class attribute

2021-09-24 Thread Cleber Rosa
Rather than defining a single use variable, let's just use the class attribute directly. Signed-off-by: Cleber Rosa --- tests/acceptance/boot_xen.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/acceptance/boot_xen.py b/tests/acceptance/boot_xen.py index 66621fd14d

[PATCH 04/16] Acceptance Tests: keep track and disable tests with known issues

2021-09-24 Thread Cleber Rosa
ts, and do not have known issues) can be obtained with: make list-acceptance As a future improvement, a tool can be added to sync the "issue" tags with issues that end up being resolved closed. Signed-off-by: Cleber Rosa --- docs/devel/testing.rst | 28 +

[PATCH 12/16] tests/acceptance/boot_xen.py: removed unused import

2021-09-24 Thread Cleber Rosa
Just a clean up for an unused import. Signed-off-by: Cleber Rosa --- tests/acceptance/boot_xen.py | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/acceptance/boot_xen.py b/tests/acceptance/boot_xen.py index cd916ddba4..66621fd14d 100644 --- a/tests/acceptance/boot_xen.py +++ b/tests

[PATCH 02/16] Acceptance Tests: improve check-acceptance description

2021-09-24 Thread Cleber Rosa
The "check-acceptance" make rule won't necessarily run *all* available tests, because it employs a filter based on the currently configured targets. This change in the description of the rule makes that behavior extra clear. Signed-off-by: Cleber Rosa --- tests/Makefile.include | 2

[PATCH 15/16] tests/acceptance/ppc_prep_40p.py: clean up unused import

2021-09-24 Thread Cleber Rosa
Just a removal of an unused imported symbol. Signed-off-by: Cleber Rosa --- tests/acceptance/ppc_prep_40p.py | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/acceptance/ppc_prep_40p.py b/tests/acceptance/ppc_prep_40p.py index 6b28a69ea5..5e61e686bd 100644 --- a/tests/acceptance

[PATCH 11/16] tests/acceptance/boot_xen.py: fetch kernel during test setUp()

2021-09-24 Thread Cleber Rosa
The kernel is a common blob used in all tests. By moving it to the setUp() method, the "fetch asset" plugin will recognize the kernel and attempt to fetch it and cache it before the tests are started. Signed-off-by: Cleber Rosa --- tests/acceptance/boot_xen.py | 13 ++-

[PATCH 10/16] tests/acceptance/boot_xen.py: unify tags

2021-09-24 Thread Cleber Rosa
Because all tests share the same tags, it's possible to have all of them at the class level. Signed-off-by: Cleber Rosa --- tests/acceptance/boot_xen.py | 26 +- 1 file changed, 5 insertions(+), 21 deletions(-) diff --git a/tests/acceptance/boot_xen.py b/tests

[PATCH 07/16] Acceptance Tests: workaround expired mipsdistros.mips.com HTTPS cert

2021-09-24 Thread Cleber Rosa
-by: Cleber Rosa --- tests/acceptance/boot_linux_console.py | 6 +++--- tests/acceptance/replay_kernel.py | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/acceptance/boot_linux_console.py b/tests/acceptance/boot_linux_console.py index 80e3a2f7a6..bc0caa1099 100644

[PATCH 09/16] tests/acceptance/boot_xen.py: merge base classes

2021-09-24 Thread Cleber Rosa
While it's a good practice to have reusable base classes, in this specific case there's no other user of the BootXenBase class. By unifying the class used in this test, we can improve readability and have the opportunity to add some future improvements in a clearer fashion. Signed-off-by: Cleber

[PATCH 03/16] Acceptance Tests: add mechanism for listing tests

2021-09-24 Thread Cleber Rosa
It is helpful to know the tests that would be executed with a "make check-acceptance" without executing them. Let's introduce a "make list-acceptance" rule for that purpose. Signed-off-by: Cleber Rosa --- tests/Makefile.include | 8 1 file changed, 8 insertions(+)

[PATCH 06/16] Acceptance Tests: use extract from package from avocado.utils

2021-09-24 Thread Cleber Rosa
Signed-off-by: Cleber Rosa --- tests/acceptance/boot_linux_console.py | 84 ++ tests/acceptance/boot_xen.py | 6 +- tests/acceptance/replay_kernel.py | 12 ++-- tests/acceptance/tcg_plugins.py| 2 +- 4 files changed, 41 insertions(+), 63 deletions

[PATCH 01/16] Acceptance Tests: bump Avocado requirement to 91.0

2021-09-24 Thread Cleber Rosa
ementation to be used by those that choose to do so. More information can be found at the release notes at: https://avocado-framework.readthedocs.io/en/latest/releases/91_0.html Signed-off-by: Cleber Rosa --- docs/devel/testing.rst | 12 tests/Makefile.include | 2 ++ tests/requirements.tx

[PATCH 08/16] acceptance/tests/vnc.py: use explicit syntax for enabling passwords

2021-09-24 Thread Cleber Rosa
This matches the command line on 82a17d1d67, where the "on" or "off" should be explicitly given. Signed-off-by: Cleber Rosa --- tests/acceptance/vnc.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/acceptance/vnc.py b/tests/acceptance/vnc

[PATCH 00/16] Acceptance Tests: use Avocado 91.0 features and other improvements

2021-09-24 Thread Cleber Rosa
proposal is a convention to tag tests that either have known issues, or that touch on QEMU features that have known issues. By tagging those tests accordingly, they will be automatically excluded from the regular execution with "make check-acceptance". Finally, some updates to as

[PATCH 05/16] Acceptance Tests: add standard clean up at test tearDown()

2021-09-24 Thread Cleber Rosa
ll Signed-off-by: Cleber Rosa --- tests/acceptance/avocado_qemu/__init__.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/acceptance/avocado_qemu/__init__.py b/tests/acceptance/avocado_qemu/__init__.py index 2c4fef3e14..1e807e2e55 100644 --- a/tests/acceptance/avocado_qemu/__init__.py +

[PATCH 2/2] Acceptance Tests: updates to the MAINTAINERS file

2021-08-03 Thread Cleber Rosa
unintentionally by a third party. Signed-off-by: Cleber Rosa --- MAINTAINERS | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 37b1a8e442..d35b948e8d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3418,11 +3418,11 @@ F: tests/tcg/Makefile F: tests

[PATCH 0/2] Acceptance Tests: clean up of temporary dirs and MAINTAINERS entry

2021-08-03 Thread Cleber Rosa
This is a reply to an issue[1] reported by Peter, and while at it, an update of the MAINTAINERS entry so other people now the status and where to go for help with regards to the acceptance tests' infrastructure. [1] https://lists.gnu.org/archive/html/qemu-devel/2021-08/msg00349.html Cleber Rosa

[PATCH 1/2] Acceptance Tests: add standard clean up at test tearDown()

2021-08-03 Thread Cleber Rosa
ll Signed-off-by: Cleber Rosa --- tests/acceptance/avocado_qemu/__init__.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/acceptance/avocado_qemu/__init__.py b/tests/acceptance/avocado_qemu/__init__.py index 2c4fef3e14..1e807e2e55 100644 --- a/tests/acceptance/avocado_qemu/__init__.py +

Re: 'make check-acceptance' eats lots of disk space and never cleans it up

2021-08-03 Thread Cleber Rosa
On Tue, Aug 3, 2021 at 9:47 AM Peter Maydell wrote: > > On Tue, 3 Aug 2021 at 13:58, Cleber Rosa wrote: > > > > On Tue, Aug 3, 2021 at 8:43 AM Peter Maydell > > wrote: > > > > > > It looks like 'make check-acceptance' creates directories in >

Re: 'make check-acceptance' eats lots of disk space and never cleans it up

2021-08-03 Thread Cleber Rosa
On Tue, Aug 3, 2021 at 8:43 AM Peter Maydell wrote: > > It looks like 'make check-acceptance' creates directories in > build/clang/tests/results which are huge and which it never > cleans up. For example one of my build directories (configured > just for arm targets) has over 350

Re: "make check-acceptance" takes way too long

2021-08-02 Thread Cleber Rosa
On Sat, Jul 31, 2021 at 4:33 PM Peter Maydell wrote: > > On Sat, 31 Jul 2021 at 19:43, Alex Bennée wrote: > > > > > > Peter Maydell writes: > > > > > "make check-acceptance" takes way way too long. I just did a run > > > on an arm-and-aarch64-targets-only debug build and it took over > > > half

Re: "make check-acceptance" takes way too long

2021-07-31 Thread Cleber Rosa
On Sat, Jul 31, 2021 at 2:40 AM Thomas Huth wrote: > > On 31/07/2021 00.04, Cleber Rosa wrote: > > On Fri, Jul 30, 2021 at 11:43 AM Peter Maydell > > wrote: > >> > >> On Fri, 30 Jul 2021 at 16:12, Peter Maydell > >> wrote: > >>> > &g

Re: "make check-acceptance" takes way too long

2021-07-30 Thread Cleber Rosa
On Fri, Jul 30, 2021 at 11:43 AM Peter Maydell wrote: > > On Fri, 30 Jul 2021 at 16:12, Peter Maydell wrote: > > > > "make check-acceptance" takes way way too long. I just did a run > > on an arm-and-aarch64-targets-only debug build and it took over > > half an hour, and this despite it skipping

Re: Regression caught by replay_kernel.py:ReplayKernelNormal.test_aarch64_virt

2021-07-27 Thread Cleber Rosa
On Tue, Jul 27, 2021 at 9:48 AM Peter Maydell wrote: > > On Tue, 27 Jul 2021 at 14:24, Cleber Rosa wrote: > > Yes, I've spent quite some time with some flaky behavior while running > > the replay tests as well. But in the end, the test remained unchanged > > bec

Re: Regression caught by replay_kernel.py:ReplayKernelNormal.test_aarch64_virt

2021-07-27 Thread Cleber Rosa
On Tue, Jul 27, 2021 at 5:17 AM Peter Maydell wrote: > > On Tue, 27 Jul 2021 at 01:39, Cleber Rosa wrote: > > tests/acceptance/replay_kernel.py:ReplayKernelNormal.test_aarch64_virt > > is currently failing consistently (first found that in [1]). > > FWIW I find that on my

Re: Regression caught by replay_kernel.py:ReplayKernelNormal.test_aarch64_virt

2021-07-27 Thread Cleber Rosa
On Tue, Jul 27, 2021 at 3:37 AM Peter Maydell wrote: > > On Tue, 27 Jul 2021 at 01:39, Cleber Rosa wrote: > > > > > > Hi everyone, > > > > tests/acceptance/replay_kernel.py:ReplayKernelNormal.test_aarch64_virt > > is currently failing consistently (first

Regression caught by replay_kernel.py:ReplayKernelNormal.test_aarch64_virt

2021-07-26 Thread Cleber Rosa
ab.com/qemu-project/qemu/-/jobs/1445513133#L268 -- Cleber Rosa [ Sr Software Engineer - Virtualization Team - Red Hat ] [ Avocado Test Framework - avocado-framework.github.io ] [ 7ABB 96EB 8B46 B94D 5E0F E9BB 657E 8D33 A5F2 09F3 ]

Re: [PATCH for-6.1 v2] machine: Disallow specifying topology parameters as zero

2021-07-23 Thread Cleber Rosa
wangyanan (Y) writes: > Hi Cleber, > > On 2021/7/23 6:25, Cleber Rosa wrote: >> Yanan Wang writes: >> >>> In the SMP configuration, we should either specify a topology >>> parameter with a reasonable value (equal to or greater than 1) >>> or j

Re: [PATCH for-6.1 v2] machine: Disallow specifying topology parameters as zero

2021-07-22 Thread Cleber Rosa
Yanan Wang writes: > In the SMP configuration, we should either specify a topology > parameter with a reasonable value (equal to or greater than 1) > or just leave it omitted and QEMU will calculate its value. > Configurations which explicitly specify the topology parameters > as zero like

Re: [PATCH-for-6.1 v2] gitlab-ci: Extract OpenSBI job rules and fix 'when' condition

2021-07-22 Thread Cleber Rosa
; --- > v2: when 'always' -> 'on_success' & reworded (danpb) > > Supersedes: <20210720164829.3949558-1-phi...@redhat.com> > --- > .gitlab-ci.d/opensbi.yml | 30 ++ > 1 file changed, 18 insertions(+), 12 deletions(-) > Reviewed-by: Cleber Rosa

Re: [PATCH for-6.1 2/2] docs: Move licence/copyright from HTML output to rST comments

2021-07-22 Thread Cleber Rosa
m/generic-loader.rst | 4 ++-- > 3 files changed, 13 insertions(+), 10 deletions(-) Reviewed-by: Cleber Rosa

Re: [PATCH for-6.1 1/2] docs: Remove stale TODO comments about license and version

2021-07-22 Thread Cleber Rosa
ell > --- > docs/interop/qemu-ga-ref.rst | 9 - > docs/interop/qemu-qmp-ref.rst| 9 - > docs/interop/qemu-storage-daemon-qmp-ref.rst | 9 - > 3 files changed, 27 deletions(-) > Reviewed-by: Cleber Rosa

[PULL 4/7] tests/acceptance/virtio-gpu.py: combine kernel command line

2021-07-20 Thread Cleber Rosa
Both tests use the same kernel command line arguments, so there's no need to have a common and then an additional set of arguments. Signed-off-by: Cleber Rosa Message-Id: <20210714174051.28164-5-cr...@redhat.com> Reviewed-by: Willian Rampazzo Signed-off-by: Cleber Rosa --- tests/acce

[PULL 3/7] tests/acceptance/virtio-gpu.py: combine CPU tags

2021-07-20 Thread Cleber Rosa
Like previously done with the arch tags, all tests use the same CPU value so it's possible to combine them at the class level. Signed-off-by: Cleber Rosa Message-Id: <20210714174051.28164-4-cr...@redhat.com> Reviewed-by: Willian Rampazzo Signed-off-by: Cleber Rosa --- tests/acceptance/

[PULL 1/7] tests/acceptance/virtio-gpu.py: use require_accelerator()

2021-07-20 Thread Cleber Rosa
Since efe30d501 there's a shorthand for requiring specific accelerators, and canceling the test if it's not available. Signed-off-by: Cleber Rosa Message-Id: <20210714174051.28164-2-cr...@redhat.com> Reviewed-by: Willian Rampazzo Signed-off-by: Cleber Rosa --- tests/acceptance/virtio-

[PULL 2/7] tests/acceptance/virtio-gpu.py: combine x86_64 arch tags

2021-07-20 Thread Cleber Rosa
The test class in question is x86_64 specific, so it's possible to set the tags at the class level. Signed-off-by: Cleber Rosa Message-Id: <20210714174051.28164-3-cr...@redhat.com> Reviewed-by: Willian Rampazzo Signed-off-by: Cleber Rosa --- tests/acceptance/virtio-gpu.py | 3 +--

[PULL 5/7] tests/acceptance/virtio-gpu.py: use virtio-vga-gl

2021-07-20 Thread Cleber Rosa
Since 49afbca3b, the use of an optional virgl renderer is not available anymore, and since b36eb8860f, the way to choose a GL based rendered is to use the "virtio-vga-gl" device. Signed-off-by: Cleber Rosa Message-Id: <20210714174051.28164-6-cr...@redhat.com> Reviewed-by:

[PULL 7/7] remote/memory: Replace share parameter with ram_flags

2021-07-20 Thread Cleber Rosa
588-1-yang.zh...@intel.com> Signed-off-by: Cleber Rosa --- hw/remote/memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/remote/memory.c b/hw/remote/memory.c index 472ed2a272..6e21ab1a45 100644 --- a/hw/remote/memory.c +++ b/hw/remote/memory.c @@ -46,7 +46,7 @@ void remote

[PULL 6/7] tests/acceptance/virtio-gpu.py: provide kernel and initrd hashes

2021-07-20 Thread Cleber Rosa
By providing kernel and initrd hashes, the test guarantees the integrity of the images used and avoids the warnings set by fetch_asset() when hashes are lacking. Signed-off-by: Cleber Rosa Message-Id: <20210714174051.28164-7-cr...@redhat.com> Reviewed-by: Willian Rampazzo Signed-off-by:

[PULL for 6.1 0/7] Python and Acceptance Tests

2021-07-20 Thread Cleber Rosa
. Cleber Rosa (6): tests/acceptance/virtio-gpu.py: use require_accelerator() tests/acceptance/virtio-gpu.py: combine x86_64 arch tags tests/acceptance/virtio-gpu.py: combine CPU tags tests/acceptance/virtio-gpu.py: combine kernel command line tests/acceptance/virtio-gpu.py: use

Re: tests/acceptance/multiprocess.py test failure

2021-07-20 Thread Cleber Rosa
Jag Raman writes: > > Hi Cleber, > > We presently don’t have permissions to send a PR to > upstream (Peter Maydell). > > Presently, we are requesting someone else who has > permissions to do PRs on our behalf. We will work > on getting permissions to send PRs going forward. > > Thank you! Hi

Re: tests/acceptance/multiprocess.py test failure

2021-07-15 Thread Cleber Rosa
orry for missing that patch on the ml. Maintainers (Elena, Jagannathan, John), Are you planning a PR with this patch? Thanks, -- Cleber Rosa [ Sr Software Engineer - Virtualization Team - Red Hat ] [ Avocado Test Framework - avocado-framework.github.io ] [ 7ABB 96EB 8B46 B94D 5E0F E9BB 657E 8D33 A5F2 09F3 ]

tests/acceptance/multiprocess.py test failure

2021-07-14 Thread Cleber Rosa
Hi everyone, The tests/acceptance/multiprocess.py:Multiprocess.test_multiprocess_x86_64 is currently failing (as of a9649a719a44894b81f38dc1c5c1888ee684acef). Unfortunately CI was unable to catch this issue earlier, because tests that require KVM are not yet running (but this should change soon).

Re: [PATCH-for-6.1] gitlab-ci: Extract EDK2 job rules to reusable section

2021-07-14 Thread Cleber Rosa
s: # 'artifacts.zip' will contains the following files: > - pc-bios/edk2*bz2 Hi Phil, This looks good, but have you triggered a pipeline with these changes? It'd be helpful for an extra level of assurance for the intended results. Thanks! -- Cleber Rosa [ Sr Software Engineer - Virtualization Team - Red Hat ] [ Avocado Test Framework - avocado-framework.github.io ] [ 7ABB 96EB 8B46 B94D 5E0F E9BB 657E 8D33 A5F2 09F3 ]

[PATCH 4/6] tests/acceptance/virtio-gpu.py: combine kernel command line

2021-07-14 Thread Cleber Rosa
Both tests use the same kernel command line arguments, so there's no need to have a common and then an additional set of arguments. Signed-off-by: Cleber Rosa --- tests/acceptance/virtio-gpu.py | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/tests/acceptance

[PATCH 6/6] tests/acceptance/virtio-gpu.py: provide kernel and initrd hashes

2021-07-14 Thread Cleber Rosa
By providing kernel and initrd hashes, the test guarantees the integrity of the images used and avoids the warnings set by fetch_asset() when hashes are lacking. Signed-off-by: Cleber Rosa --- tests/acceptance/virtio-gpu.py | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff

[PATCH 5/6] tests/acceptance/virtio-gpu.py: use virtio-vga-gl

2021-07-14 Thread Cleber Rosa
Since 49afbca3b, the use of an optional virgl renderer is not available anymore, and since b36eb8860f, the way to choose a GL based rendered is to use the "virtio-vga-gl" device. Signed-off-by: Cleber Rosa --- tests/acceptance/virtio-gpu.py | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH 3/6] tests/acceptance/virtio-gpu.py: combine CPU tags

2021-07-14 Thread Cleber Rosa
Like previously done with the arch tags, all tests use the same CPU value so it's possible to combine them at the class level. Signed-off-by: Cleber Rosa --- tests/acceptance/virtio-gpu.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/acceptance/virtio-gpu.py b

[PATCH 2/6] tests/acceptance/virtio-gpu.py: combine x86_64 arch tags

2021-07-14 Thread Cleber Rosa
The test class in question is x86_64 specific, so it's possible to set the tags at the class level. Signed-off-by: Cleber Rosa --- tests/acceptance/virtio-gpu.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/acceptance/virtio-gpu.py b/tests/acceptance/virtio-gpu.py

[PATCH for 6.1 0/6] virtio-gpu acceptance test: use current device name

2021-07-14 Thread Cleber Rosa
-send patch 5 by itself. Cleber Rosa (6): tests/acceptance/virtio-gpu.py: use require_accelerator() tests/acceptance/virtio-gpu.py: combine x86_64 arch tags tests/acceptance/virtio-gpu.py: combine CPU tags tests/acceptance/virtio-gpu.py: combine kernel command line tests/acceptance/virtio

[PATCH 1/6] tests/acceptance/virtio-gpu.py: use require_accelerator()

2021-07-14 Thread Cleber Rosa
Since efe30d501 there's a shorthand for requiring specific accelerators, and canceling the test if it's not available. Signed-off-by: Cleber Rosa --- tests/acceptance/virtio-gpu.py | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/tests/acceptance/virtio-gpu.py b

[PULL 15/23] tests/acceptance: Let the framework handle "cpu:VALUE" tagged tests

2021-07-13 Thread Cleber Rosa
From: Wainer dos Santos Moschetta The tests that are already tagged with "cpu:VALUE" don't need to add "-cpu VALUE" to the list of arguments of the vm object because the avocado_qemu framework is able to handle it automatically. Reviewed-by: Cleber Rosa Tested-by: C

[PULL 23/23] tests/acceptance/cpu_queries.py: use the proper logging channels

2021-07-13 Thread Cleber Rosa
The test contains methods for the proper log of test related information. Let's use that and remove the print and the unused logging import. Reference: https://avocado-framework.readthedocs.io/en/87.0/api/test/avocado.html#avocado.Test.log Signed-off-by: Cleber Rosa Message-Id

[PULL 22/23] tests/acceptance/linux_ssh_mips_malta.py: drop identical setUp

2021-07-13 Thread Cleber Rosa
These tests' setUp do not do anything beyong what their base class do. And while they do decorate the setUp() we can decorate the classes instead, so no functionality is lost here. This is possible because since Avocado 76.0 we can decorate setUp() directly. Signed-off-by: Cleber Rosa Message

[PULL 18/23] tests/acceptance: Add set_vm_arg() to the Test class

2021-07-13 Thread Cleber Rosa
From: Wainer dos Santos Moschetta The set_vm_arg method is added to avocado_qemu.Test class on this change. Use that method to set (or replace) an argument to the list of arguments given to the QEMU binary. Suggested-by: Cleber Rosa Signed-off-by: Wainer dos Santos Moschetta Reviewed

[PULL 12/23] tests/acceptance: Tag NetBSD tests as 'os:netbsd'

2021-07-13 Thread Cleber Rosa
tests/acceptance/ Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20210623180021.898286-4-f4...@amsat.org> Reviewed-by: Niek Linnenbank Reviewed-by: Willian Rampazzo Reviewed-by: Cleber Rosa [PMD: ammend the commit message with example command] Signed-off-by: Cleber Rosa --- tests/acce

[PULL 19/23] tests/acceptance: Handle cpu tag on x86_cpu_model_versions tests

2021-07-13 Thread Cleber Rosa
() to overwrite the -cpu value. Signed-off-by: Wainer dos Santos Moschetta Reviewed-by: Willian Rampazzo Message-Id: <20210430133414.39905-8-waine...@redhat.com> Signed-off-by: Cleber Rosa --- tests/acceptance/x86_cpu_model_versions.py | 40 +- 1 file changed, 32 inse

[PULL 21/23] Acceptance tests: do not try to reuse packages from the system

2021-07-13 Thread Cleber Rosa
tests run on different machines; With regards to downloads, pip already caches the downloaded wheels and tarballs under ~/.cache/pip, so there should not be more than one download even if the venv is destroyed and recreated. Signed-off-by: Cleber Rosa Message-Id: <20210415215141.1865467-3

[PULL 16/23] tests/acceptance: Tagging tests with "cpu:VALUE"

2021-07-13 Thread Cleber Rosa
From: Wainer dos Santos Moschetta The existing tests which are passing "-cpu VALUE" argument to the vm object are now properly "cpu:VALUE" tagged, so letting the avocado_qemu framework to handle that automatically. Reviewed-by: Cleber Rosa Reviewed-by: Willian Rampazzo S

[PULL 20/23] python: Configure tox to skip missing interpreters

2021-07-13 Thread Cleber Rosa
Santos Moschetta Message-Id: <20210630184546.456582-1-waine...@redhat.com> Reviewed-by: Willian Rampazzo Reviewed-by: John Snow Signed-off-by: Cleber Rosa --- .gitlab-ci.d/static_checks.yml | 1 + python/Makefile| 5 - python/setup.cfg | 1 + 3 files chan

[PULL 17/23] python/qemu: Add args property to the QEMUMachine class

2021-07-13 Thread Cleber Rosa
From: Wainer dos Santos Moschetta This added the args property to QEMUMachine so that users of the class can access and handle the list of arguments to be given to the QEMU binary. Reviewed-by: Cleber Rosa Reviewed-by: Willian Rampazzo Signed-off-by: Wainer dos Santos Moschetta Message-Id

[PULL 08/23] avocado_qemu: Fix KNOWN_DISTROS map into the LinuxDistro class

2021-07-13 Thread Cleber Rosa
-Id: <20210706131729.30749-2-eric.au...@redhat.com> [CR: moved aarch64 definition from patch 2 to 1] [CR: protect get() when arch is not defined] [CR: split long lines] Acked-by: Wainer dos Santos Moschetta Signed-off-by: Cleber Rosa --- tests/acceptance/avocado_qemu/__init__.p

[PULL 14/23] tests/acceptance: Fix mismatch on cpu tagged tests

2021-07-13 Thread Cleber Rosa
From: Wainer dos Santos Moschetta There are test cases on machine_mips_malta.py and tcg_plugins.py files where the cpu tag does not correspond to the value actually given to the QEMU binary. This fixed those tests tags. Reviewed-by: Cleber Rosa Tested-by: Cleber Rosa Reviewed-by: Willian

[PULL 04/23] Acceptance Tests: rename attribute holding the distro image checksum

2021-07-13 Thread Cleber Rosa
the naming of those more uniform. Signed-off-by: Cleber Rosa Message-Id: <20210414221457.1653745-2-cr...@redhat.com> Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Eric Auger Reviewed-by: Willian Rampazzo Reviewed-by: Philippe Mathieu-Daudé [CR: split long lines] Signed-off-by:

[PULL 13/23] tests/acceptance: Automatic set -cpu to the test vm

2021-07-13 Thread Cleber Rosa
-chardev socket,id=mon,path=/var/tmp/avo_qemu_sock_pdgzbgd_/qemu-1135557-monitor.sock \ -mon chardev=mon,mode=control -cpu host Reviewed-by: Cleber Rosa Tested-by: Cleber Rosa Reviewed-by: Willian Rampazzo Signed-off-by: Wainer dos Santos Moschetta Message-Id: <20210430133414.39905-2-wain

[PULL 07/23] tests/acceptance: Ignore binary data sent on serial console

2021-07-13 Thread Cleber Rosa
anyway). Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20210515134555.307404-2-f4...@amsat.org> Reviewed-by: Wainer dos Santos Moschetta Tested-by: Wainer dos Santos Moschetta Signed-off-by: Cleber Rosa --- tests/acceptance/avocado_qemu/__init__.py | 7 +-- 1 file changed, 5 insertion

[PULL 10/23] avocado_qemu: Add SMMUv3 tests

2021-07-13 Thread Cleber Rosa
: <20210706131729.30749-4-eric.au...@redhat.com> [CR: split long lines] [CR: added MAINTAINERS entry] Signed-off-by: Cleber Rosa --- MAINTAINERS | 1 + tests/acceptance/smmu.py | 137 +++ 2 files changed, 138 insertions(+) create mode 100644 tests/acceptance/s

[PULL 02/23] Acceptance Tests: log information when creating QEMUMachine

2021-07-13 Thread Cleber Rosa
Including its base temporary directory, given that information useful for debugging can be put there. Signed-off-by: Cleber Rosa Reviewed-by: Wainer dos Santos Moschetta Message-Id: <20210211220146.2525771-5-cr...@redhat.com> Signed-off-by: Cleber Rosa --- tests/acceptance/avocad

[PULL 11/23] avocado_qemu: Add Intel iommu tests

2021-07-13 Thread Cleber Rosa
: <20210706131729.30749-5-eric.au...@redhat.com> [CR: split long lines] Signed-off-by: Cleber Rosa --- tests/acceptance/intel_iommu.py | 119 1 file changed, 119 insertions(+) create mode 100644 tests/acceptance/intel_iommu.py diff --git a/tests/acceptance/intel_iommu.py b

[PULL 06/23] Acceptance Tests: support choosing specific distro and version

2021-07-13 Thread Cleber Rosa
-caching of the Fedora 31 images done during the early stages of `make check-acceptance` (before the tests are actually executed) are not expanded here to cover every new image added. But, the tests will download other needed images (and cache them) during the first execution. Signed-off-by: Cleber Rosa

[PULL 01/23] Acceptance Tests: use the job work directory for created VMs

2021-07-13 Thread Cleber Rosa
://avocado-framework.readthedocs.io/en/85.0/api/test/avocado.html#avocado.Test.workdir Reference: https://avocado-framework.readthedocs.io/en/85.0/config/index.html#run-keep-tmp Signed-off-by: Cleber Rosa Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: John Snow Message-Id: <20210211220146.2525771-4-cr.

[PULL 09/23] Acceptance Tests: Add default kernel params and pxeboot url to the KNOWN_DISTROS collection

2021-07-13 Thread Cleber Rosa
Rampazzo Message-Id: <20210706131729.30749-3-eric.au...@redhat.com> [CR: split long lines] Signed-off-by: Cleber Rosa --- tests/acceptance/avocado_qemu/__init__.py | 58 +-- 1 file changed, 55 insertions(+), 3 deletions(-) diff --git a/tests/acceptance/avocado_qemu/__init__

  1   2   3   4   5   6   7   8   9   10   >