answers. Even as non native speaker
I was aware that this part still did not sound like correct English,
but I restricted my modifications to those parts where I was sure.
Let's ask the original author Corentin Chary...
Regards
Stefan W.
--
Corentin Chary
http://xf.iksaif.net
...@dlhnet.de a écrit :
On 13.03.2012 16:06, Alexander Graf wrote:
On 13.03.2012, at 16:05, Corentin Chary wrote:
On Tue, Mar 13, 2012 at 12:29 PM, Peter Lievenp...@dlh.net wrote:
On 11.02.2012 09:55, Corentin Chary wrote:
On Thu, Feb 9, 2012 at 7:08 PM, Peter Lievenp...@dlh.net wrote
On Wed, Mar 14, 2012 at 11:16 PM, Stefan Weil s...@weilnetz.de wrote:
Am 14.03.2012 22:46, schrieb Anthony Liguori:
On 03/14/2012 01:58 AM, Corentin Chary wrote:
Hi Anthony,
Please merge these two patchs from another age, they fix crash in the VNC
server (the iohandler one is only
Hi Anthony,
Please merge these two patchs from another age, they fix crash in the VNC
server (the iohandler one is only for the threaded server).
Thanks,
Corentin Chary (1):
vnc: don't mess up with iohandlers in the vnc thread
Stefan Weil (1):
vnc: Limit r/w access to size of allocated
On Tue, Mar 13, 2012 at 12:29 PM, Peter Lieven p...@dlh.net wrote:
On 11.02.2012 09:55, Corentin Chary wrote:
On Thu, Feb 9, 2012 at 7:08 PM, Peter Lievenp...@dlh.net wrote:
Hi,
is anyone aware if there are still problems when enabling the threaded
vnc
server?
I saw some VMs crashing
On Mon, Feb 13, 2012 at 10:24 AM, Peter Lieven p...@dlh.net wrote:
Am 11.02.2012 um 09:55 schrieb Corentin Chary:
On Thu, Feb 9, 2012 at 7:08 PM, Peter Lieven p...@dlh.net wrote:
Hi,
is anyone aware if there are still problems when enabling the threaded vnc
server?
I saw some VMs crashing
not have the
time (yet) to test them.
http://git.iksaif.net/?p=qemu.git;a=shortlog;h=refs/heads/wip
Feel free to try them. If QEMU segfault again, please send a full gdb
backtrace / valgrind trace / way to reproduce :).
Thanks,
--
Corentin Chary
http://xf.iksaif.net
The patch looks right, maybe you should send it directly to the qemu
mailing list.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/806656
Title:
Tight PNG VNC encoding is sent even when
of threads
?
Thanks
--
Corentin Chary
http://xf.iksaif.net
Aurelien, could you also take a look at
http://patchwork.ozlabs.org/patch/87717/ ?
Thanks,
--
Corentin Chary
http://xf.iksaif.net
: http://patchwork.ozlabs.org/patch/87722/
--
Corentin Chary
http://xf.iksaif.net
.
Instead, we now store the data in a temporary buffer, and use a bottom
half to notify the main thread that new data is available.
vnc_[un]lock_ouput() is still needed to access VncState members like
abort, csock or jobs_buffer.
Signed-off-by: Corentin Chary corentin.ch...@gmail.com
---
ui/vnc
From: Stefan Weil w...@mail.berlios.de
This fixes memory reads and writes which exceeded the upper limit
of allocated memory vd-guest.ds-data and vd-server-data.
Cc: Anthony Liguori aligu...@us.ibm.com
Signed-off-by: Stefan Weil w...@mail.berlios.de
Signed-off-by: Corentin Chary corentin.ch
Hi Anthony,
Here are some vnc related patchs that should be merged.
Thanks,
Corentin Chary (1):
vnc: don't mess up with iohandlers in the vnc thread
Michael Tokarev (1):
vnc: tight: Fix crash after 2GB of output
Stefan Weil (1):
vnc: Limit r/w access to size of allocated memory
Wen
...@purestorage.com
Signed-off-by: Michael Tokarev m...@tls.msk.ru
Signed-off-by: Corentin Chary corentin.ch...@gmail.com
---
ui/vnc-enc-tight.c |5 +++--
ui/vnc-enc-zlib.c |4 ++--
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c
index 2522936
From: Wen Congyang we...@cn.fujitsu.com
This patch fix the following regression:
1. we should use bitmap_set() and bitmap_clear() to replace vnc_set_bits().
Signed-off-by: Wen Congyang we...@cn.fujitsu.com
Signed-off-by: Corentin Chary corentin.ch...@gmail.com
---
ui/vnc.c |8 ++--
1
a lot like vnc: tight: Fix crash after 2GB of output, right ?
--
Corentin Chary
http://xf.iksaif.net
/Contribute/StartHere .
You can also pick a GSOC 2010/2011 project, and start working on it
outside of GSOC context if you want.
And keep in mind that if you want to write code send patchs for QEMU,
nobody can stop you :).
--
Corentin Chary
http://xf.iksaif.net
On Thu, Mar 10, 2011 at 3:13 PM, Corentin Chary
corentin.ch...@gmail.com wrote:
The threaded VNC servers messed up with QEMU fd handlers without
any kind of locking, and that can cause some nasty race conditions.
Using qemu_mutex_lock_iothread() won't work because vnc_dpy_cpy(),
which
viadeoBonjour,
Je vous invite à rejoindre mon réseau de contacts sur Viadeo.
Cordialement,Corentin Chary Confirmer que vous connaissez Corentin
http://www.viadeo.com/action/index.jsp?actionId=0021xn1x7dm9pjk8urlId=0021v1e4bjtkdcp0utm_source
Signed-off-by: Corentin Chary corentin.ch...@gmail.com
---
osdep.c | 83 +
qemu_socket.h |1 +
2 files changed, 84 insertions(+), 0 deletions(-)
diff --git a/osdep.c b/osdep.c
index 327583b..93bfbe0 100644
--- a/osdep.c
+++ b
to access VncState members like
abort, csock or jobs_buffer.
Thanks to Jan Kiszka for helping me solve this issue.
Signed-off-by: Corentin Chary corentin.ch...@gmail.com
---
ui/vnc-jobs-async.c | 50 --
ui/vnc-jobs-sync.c |4
ui/vnc-jobs.h
On Thu, Mar 10, 2011 at 1:45 PM, Anthony Liguori aligu...@us.ibm.com wrote:
On 03/10/2011 07:06 AM, Paolo Bonzini wrote:
On 03/10/2011 01:59 PM, Corentin Chary wrote:
Instead, we now store the data in a temporary buffer, and use a socket
pair to notify the main thread that new data
.
Instead, we now store the data in a temporary buffer, and use a bottom
half to notify the main thread that new data is available.
vnc_[un]lock_ouput() is still needed to access VncState members like
abort, csock or jobs_buffer.
Signed-off-by: Corentin Chary corentin.ch...@gmail.com
---
ui/vnc
against
the main select loop, this won't help here. So vnc-threading likely
needs to be made dependent on --enable-io-thread.
Plus proper lock_iothread() calls right ?
If yes I'll send a patch for that (or you can do it, as you want).
Thanks,
--
Corentin Chary
http://xf.iksaif.net
On Sat, Mar 5, 2011 at 6:56 AM, Michael Tokarev m...@tls.msk.ru wrote:
05.03.2011 00:08, Corentin Chary wrote:
On Fri, Mar 4, 2011 at 12:46 PM, Michael Tokarev m...@tls.msk.ru wrote:
[]
The attached slightly different patch fixes both places and fixes
them for good (hopefully anyway
inline so they are easy to reply to with review
comments. Do not put patches in attachments.
I mainly asked yo to re-send it so Anthony has less chance to miss it
if he is cc and if the patch is inline :), that's all.
Thanks,
--
Corentin Chary
http://xf.iksaif.net
Can confirm screen update problems (wrong colors, e.g. red blocks).
With wich client, encoding, pixel format ? Does using another client
fix the issue ? Could you provide more informations (wireshark dumps,
screenshots, etc...) ?
Thanks,
--
Corentin Chary
http://xf.iksaif.net
its previous value in previous_out. Something like
the attached patch does.
If you're certain that total_out is not used by zlib, could you also
send a patch for zlib encoding please ? (vnc-enc-zlib.c)
Thanks,
--
Corentin Chary
http://xf.iksaif.net
: for these hosts, VNC_MAX_WIDTH is no
longer a multiple of (16 * BITS_PER_LONG), so the rounded value of
VNC_DIRTY_WORDS was too small.
Fix both declarations by using the macro which is designed for this
purpose.
Cc: Corentin Chary corenti...@iksaif.net
Cc: Wen Congyang we...@cn.fujitsu.com
Cc: Gerhard
On Fri, Mar 4, 2011 at 12:46 PM, Michael Tokarev m...@tls.msk.ru wrote:
04.03.2011 11:56, Corentin Chary wrote:
bytes = zstream-total_out - previous_out;
Good catch
total_out isn't used by zlib internally, so if the resulting
total counter is not needed in qemu, we can just zero-out
argument of bitmap_clear() is number of bits to be cleared, but we
pass
the end bits to be cleared to bitmap_clear().
Signed-off-by: Wen Congyang we...@cn.fujitsu.com
Reported-by: Stefan Weil w...@mail.berlios.de
Acked-by: Corentin Chary corentin.ch...@gmail.com
---
ui/vnc.c | 6 +++---
1
of words to bitmap_intersects().
Changes from v1 to v2:
1. fix the third argument of bitmap_clear()
Signed-off-by: Wen Congyang we...@cn.fujitsu.com
Acked-by: Corentin Chary corentin.ch...@gmail.com
---
ui/vnc.c | 11 ---
1 files changed, 8 insertions(+), 3 deletions(-)
diff --git
))
osdep.h:#define DIV_ROUND_UP(n,d) (((n) + (d) - 1) / (d))
--
Corentin Chary
http://xf.iksaif.net
/ :
- with appropriate Signed-off-by: and changelog for the other patch
- using a const size_t width = ds_get_width(vs-ds) / 16; in both
patchs to make the call more explicit
Thanks,
--
Corentin Chary
http://xf.iksaif.net
On Wed, Feb 23, 2011 at 11:23 PM, Anthony Liguori
aligu...@linux.vnet.ibm.com wrote:
On 02/04/2011 02:05 AM, Corentin Chary wrote:
agraf reported that qemu_mutex_destroy(vs-output_mutex) while failing
in vnc_disconnect_finish().
It's because vnc_worker_thread_loop() tries to unlock the mutex
, resulting in a big and ugly memleak.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
I believe this is a (slightly) better patch than Bruce's one, because
it reduce memory allocations by using always the same buffer.
ui/vnc-jobs-async.c |2 ++
1 files changed, 2 insertions(+), 0 deletions
On Thu, Feb 24, 2011 at 4:04 PM, Peter Maydell peter.mayd...@linaro.org wrote:
Add some missing #ifdefs to fix compilation failures in the !CONFIG_VNC_JPEG
case introduced by commit ce702e93.
Ooops.
Acked-By: Corentin Chary corentin.ch...@gmail.com
--
Corentin Chary
http://xf.iksaif.net
./bitops.h:192: warning: ‘old’ is used uninitialized in this function
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
bitops.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/bitops.h b/bitops.h
index ae7bcb1..e2b9df3 100644
--- a/bitops.h
+++ b/bitops.h
.
Since I don't have any working mingw toolchain, cool you make a patch
for those two ?
Thanks,
--
Corentin Chary
http://xf.iksaif.net
,
+ VNC_DIRTY_WORDS * BITS_PER_LONG)) {
int x;
uint8_t *guest_ptr;
uint8_t *server_ptr;
Good catch,
Thanks,
Acked-by: Corentin Chary corentin.ch...@gmail.com
--
Corentin Chary
http://xf.iksaif.net
= not seen. When you press
enter = OK.
Did you try http://patchwork.ozlabs.org/patch/84517/ ?
What vnc settings are you using ? What VNC encoding did you client choose ?
Thanks,
--
Corentin Chary
http://xf.iksaif.net
from userspace, there is no way to
implement that into QEMU.
Simply install it on your guests if you want to use it.
--
Corentin Chary
http://xf.iksaif.net
agraf reported that qemu_mutex_destroy(vs-output_mutex) while failing
in vnc_disconnect_finish().
It's because vnc_worker_thread_loop() tries to unlock the mutex while
not locked. The unlocking call doesn't fail (pthread bug ?), but
the destroy call does.
Signed-off-by: Corentin Chary corenti
From: Corentin Chary corentin.ch...@gmail.com
Hi,
Since v2:
- Fixed some styles issues
- Rebased to current master
- Fixed a Makefile issue (using .c instead of .o)
I rebased the series against current master, it contains:
- Adaptive Tight Encoding: send lossy or lossless updates depending
These two helpers are needed for zrle and zywrle.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc-palette.c | 32
ui/vnc-palette.h |3 +++
2 files changed, 35 insertions(+), 0 deletions(-)
diff --git a/ui/vnc-palette.c b/ui/vnc-palette.c
If an adaptive encoding has choosen to send a lossy update
based on the result of vnc_update_freq(), then it should advertise
it with vnc_sent_lossy_rect(). This will allow to automatically refresh
this rect once it's static again.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc
This should not change the current behavior, but if any new
encoding try to use the tight quality, it will always be set
to -1 when lossy encodings are disabled.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff
rect was not updated in the last 2 second, then the frequency
became 0, and all the stored timestamp are reseted.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc.c | 101 ++
ui/vnc.h | 19 +++
2 files changed, 120
We now that the palette will never have more than 256
elements. Let's use a pool to reduce malloc calls.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc-palette.c | 18 ++
ui/vnc-palette.h |3 ++-
2 files changed, 4 insertions(+), 17 deletions(-)
diff --git
Use the new update frequency infrastructure to use jpeg for regions with
high update frequency.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc-enc-tight.c | 75 +++-
1 files changed, 62 insertions(+), 13 deletions(-)
diff --git
This allow to use palette on the stack instead of always
allocating them.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc-palette.c |8 +++-
ui/vnc-palette.h |1 +
2 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/ui/vnc-palette.c b/ui/vnc-palette.c
index
.
bitops_ffsl() and bitops_flsl() are here because bitops/bitmap works
on unsigned long, not int, and we can't use current code because:
* ffs only works on int
* qemu_fls only works on int
* ffsl is a GNU extension
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
Makefile.objs |1
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc-enc-tight.c |4 ++--
ui/vnc-enc-zrle.c |3 ++-
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c
index ad9a9a8..81024d5 100644
--- a/ui/vnc-enc-tight.c
+++ b/ui/vnc-enc
The for loop in send_lossy_rect was totally wrong, and we can't
call vnc_set_bits() because it does not really do what it should.
Use vnc_set_bit() directly instead.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc.c | 12
1 files changed, 8 insertions(+), 4
Respect client size if it doesn't not support desktop resizing.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/ui/vnc.c b/ui/vnc.c
index 6c57b0e..86c23207 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
This option allow to disable adaptive behaviors in some encodings.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
qemu-options.hx|9 +
ui/vnc-enc-tight.c |2 +-
ui/vnc.c | 13 +
ui/vnc.h |1 +
4 files changed, 20 insertions(+), 5
Switch to bitmap.h and bitops.h instead of redefining our own bitmap
helpers.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc.c | 91 ++---
ui/vnc.h |7 +++--
2 files changed, 25 insertions(+), 73 deletions(-)
diff
The force_jpeg threshold was too low.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc-enc-tight.c | 20 ++--
1 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c
index 81024d5..82c1e96 100644
--- a/ui/vnc-enc
vnc: qemu can die if the client is disconnected while updating screen
http://patchwork.ozlabs.org/patch/80334/
(what about a stable alias instead of [PING x.x] ? Like sta...@kernel.org)
Thanks,
--
Corentin Chary
http://xf.iksaif.net
Hi Anthony,
If you want to enable vnc threaded server by default, you should
really merge these two lost patchs :).
Thanks,
Corentin Chary (1):
vnc: qemu can die if the client is disconnected while updating screen
Yoshiaki Tamura (1):
vl.c: set NULL upon deleting handlers
From: Corentin Chary corenti...@iksaif.net
agraf reported that qemu_mutex_destroy(vs-output_mutex) was failing
in vnc_disconnect_finish() when the vnc client was disconnected while
updating the screen.
It's because vnc_worker_thread_loop() tries to unlock the mutex while
not locked.
Signed-off
handler still exists, it'll be
called, and then crashes because of lack of resources. This patch
fixes it.
Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp
Reviewed-by: Corentin Chary corenti...@iksaif.net
---
vl.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff
On Tue, Jan 25, 2011 at 10:03 AM, Stefan Hajnoczi stefa...@gmail.com wrote:
On Tue, Jan 25, 2011 at 8:33 AM, Corentin Chary
corentin.ch...@gmail.com wrote:
From: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp
Currently qemu_set_fd_handler2() is only setting ioh-deleted upon
deleting
?), but
the destroy call does.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc-jobs-async.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/ui/vnc-jobs-async.c b/ui/vnc-jobs-async.c
index 6e9cf08..0b5d750 100644
--- a/ui/vnc-jobs-async.c
+++ b/ui/vnc-jobs-async.c
encoding for lossless
updates,
like zlib or tight.
- Bitmap module: create bitmap.h and bitops.h, and remove duplicate code
from vnc.c
It was my last series from GSoC 2010 context, if necessary I can send different
series for adaptive vnc, zrle and bitmap stuff.
Thanks,
Corentin Chary (15
These two helpers are needed for zrle and zywrle.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc-palette.c | 33 +
ui/vnc-palette.h |3 +++
2 files changed, 36 insertions(+), 0 deletions(-)
diff --git a/ui/vnc-palette.c b/ui/vnc-palette.c
If an adaptive encoding has choosen to send a lossy update
based on the result of vnc_update_freq(), then it should advertise
it with vnc_sent_lossy_rect(). This will allow to automatically refresh
this rect once it's static again.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc
Switch to bitmap.h and bitops.h instead of redefining our own bitmap
helpers.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc.c | 91 ++---
ui/vnc.h |7 +++--
2 files changed, 25 insertions(+), 73 deletions(-)
diff
We now that the palette will never have more than 256
elements. Let's use a pool to reduce malloc calls.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc-palette.c | 18 ++
ui/vnc-palette.h |3 ++-
2 files changed, 4 insertions(+), 17 deletions(-)
diff --git
rect was not updated in the last 2 second, then the frequency
became 0, and all the stored timestamp are reseted.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc.c | 101 ++
ui/vnc.h | 19 +++
2 files changed, 120
Respect client size if it doesn't not support desktop resizing.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/ui/vnc.c b/ui/vnc.c
index 600ea75..9189014 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
This allow to use palette on the stack instead of always
allocating them.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc-palette.c |8 +++-
ui/vnc-palette.h |1 +
2 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/ui/vnc-palette.c b/ui/vnc-palette.c
index
This option allow to disable adaptive behaviors in some encodings.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
qemu-options.hx|9 +
ui/vnc-enc-tight.c |2 +-
ui/vnc.c | 13 +
ui/vnc.h |1 +
4 files changed, 20 insertions(+), 5
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc-enc-tight.c |4 ++--
ui/vnc-enc-zrle.c |3 ++-
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c
index ad9a9a8..81024d5 100644
--- a/ui/vnc-enc-tight.c
+++ b/ui/vnc-enc
.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
Makefile.objs |1 +
bitmap.c | 255 +
bitmap.h | 222 ++
bitops.c | 142 ++
bitops.h
__ffs(1): 0
ffs(1): 1
This behavior is needed for all the other function to work (and makes
more sense that the normal ffs).
But .. maybe I should just use ffs() - 1
--
Corentin Chary
http://xf.iksaif.net
=ac71103dc6b408775ae72067790ab367912f75ec
--
Corentin Chary
http://xf.iksaif.net
stuff is multiplatform, and serious
commercial work needs something faster than tcg.
*-user is useful to GCC developers (and used by those who work on the ARM
backend to run the GCC testsuite).
Paolo
Isn't that also used by scratchbox ?
--
Corentin Chary
http://xf.iksaif.net
-fd_write = NULL;
break;
}
}
--
1.7.1.1
Good catch, thanks,
Reviewed-by: Corentin Chary corenti...@iksaif.net
--
Corentin Chary
http://xf.iksaif.net
{
+ } else if (vs-csock != -1) {
qemu_set_fd_handler2(vs-csock, NULL, vnc_client_read, NULL, vs);
}
vnc_unlock_output(vs);
--
1.7.1.1
Acked-By: Corentin Chary corenti...@iksaif.net
--
Corentin Chary
http://xf.iksaif.net
The force_jpeg threshold was too low.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc-enc-tight.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c
index 9f83235..b0181ff 100644
--- a/ui/vnc-enc
These two helpers are needed for zrle and zywrle.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc-palette.c | 33 +
ui/vnc-palette.h |3 +++
2 files changed, 36 insertions(+), 0 deletions(-)
diff --git a/ui/vnc-palette.c b/ui/vnc-palette.c
.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
Makefile.objs |1 +
bitmap.c | 255 +
bitmap.h | 222 ++
bitops.c | 142 ++
bitops.h
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc-enc-tight.c |6 +++---
ui/vnc-enc-zrle.c |3 ++-
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c
index 5ca4342..9f83235 100644
--- a/ui/vnc-enc-tight.c
+++ b/ui/vnc-enc
The force_jpeg threshold was too low.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
qemu-thread.c |1 +
ui/vnc-enc-tight.c | 20 ++--
2 files changed, 11 insertions(+), 10 deletions(-)
diff --git a/qemu-thread.c b/qemu-thread.c
index fbc78fe..4094c51 100644
The for loop in send_lossy_rect was totally wrong, and we can't
call vnc_set_bits() because it does not really do what it should.
Use vnc_set_bit() directly instead.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc.c | 12
1 files changed, 8 insertions(+), 4
Respect client size if it doesn't not support desktop resizing.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/ui/vnc.c b/ui/vnc.c
index 0adab4a..dffb4aa 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
This option allow to disable adaptive behaviors in some encodings.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
qemu-options.hx|9 +
ui/vnc-enc-tight.c |2 +-
ui/vnc.c | 13 +
ui/vnc.h |1 +
4 files changed, 20 insertions(+), 5
Switch to bitmap.h and bitops.h instead of redefining our own bitmap
helpers.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc.c | 91 ++---
ui/vnc.h |7 +++--
2 files changed, 25 insertions(+), 73 deletions(-)
diff
On Wed, Aug 11, 2010 at 3:06 PM, Chris Krumme
chris.kru...@windriver.com wrote:
Hello Corentin,
On 08/11/2010 12:49 AM, Corentin Chary wrote:
The force_jpeg threshold was too low.
Signed-off-by: Corentin Charycorenti...@iksaif.net
---
qemu-thread.c | 1 +
ui/vnc-enc-tight.c
This should not change the current behavior, but if any new
encoding try to use the tight quality, it will always be set
to -1 when lossy encodings are disabled.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff
rect was not updated in the last 2 second, then the frequency
became 0, and all the stored timestamp are reseted.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc.c | 101 ++
ui/vnc.h | 19 +++
2 files changed, 120
,
like zlib or tight.
- Bitmap module: create bitmap.h and bitops.h, and remove duplicate code
from vnc.c
This is probably my last series in the GSoC 2010 context, but I'll probably
continue to work on the VNC server for some time :).
Thanks,
Corentin Chary (15):
vnc: don't set the quality
Use the new update frequency infrastructure to use jpeg for regions with
high update frequency.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc-enc-tight.c | 75 +++-
1 files changed, 62 insertions(+), 13 deletions(-)
diff --git
We now that the palette will never have more than 256
elements. Let's use a pool to reduce malloc calls.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc-palette.c | 18 ++
ui/vnc-palette.h |3 ++-
2 files changed, 4 insertions(+), 17 deletions(-)
diff --git
This allow to use palette on the stack instead of always
allocating them.
Signed-off-by: Corentin Chary corenti...@iksaif.net
---
ui/vnc-palette.c |8 +++-
ui/vnc-palette.h |1 +
2 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/ui/vnc-palette.c b/ui/vnc-palette.c
index
On Thu, Jul 22, 2010 at 3:46 PM, Andre Przywara andre.przyw...@amd.com wrote:
Corentin Chary wrote:
Hi,
I was working on merging VNC updates into bigger ones to see if it
lower the overhead (big updates sometime use less network/cpu than a
lot of small updates).
For that, I needed some new
- find_next_zero_bit
- find_next_zero_area
Should we move that into bitmap.c/bitmap.h ? Which part of QEMU could
use that (block.c maybe ?)
Thanks
--
Corentin Chary
http://xf.iksaif.net
On Thu, Jul 8, 2010 at 11:48 AM, Daniel P. Berrange berra...@redhat.com wrote:
On Wed, Jul 07, 2010 at 08:57:56PM +0200, Corentin Chary wrote:
Introduce a new encoding: VNC_ENCODING_TIGHT_PNG [1] (-269) with a new
tight filter VNC_TIGHT_PNG (0x0A). When the client tells it supports the
Tight
1 - 100 of 229 matches
Mail list logo
