[PATCH] docs: expand firmware descriptor to allow flash without NVRAM

2022-01-21 Thread Daniel P . Berrangé
single file contains both code and variables. - "stateless" - the confidential computing use case where storage of variables is completely disable, leaving only the code. Signed-off-by: Daniel P. Berrangé --- docs/interop/firmware.json | 54

Re: "make check-acceptance" takes way too long

2022-01-21 Thread Daniel P . Berrangé
On Fri, Jan 21, 2022 at 12:23:23PM +, Alex Bennée wrote: > > Peter Maydell writes: > > > On Fri, 21 Jan 2022 at 10:50, Markus Armbruster wrote: > >> No objection, but it's no replacement for looking into why these tests > >> are so slow. > >> > >> The #1 reason for things being slow is not

Re: [PATCH v4 4/8] tests: Refresh lcitool submodule

2022-01-21 Thread Daniel P . Berrangé
On Fri, Jan 21, 2022 at 07:30:55AM -0700, Warner Losh wrote: > On Fri, Jan 21, 2022 at 4:47 AM Daniel P. Berrangé > wrote: > > > On Fri, Jan 21, 2022 at 12:40:48PM +0100, Thomas Huth wrote: > > > On 21/01/2022 11.36, Philippe Mathieu-Daudé wrote: > >

Re: [PATCH v4 4/8] tests: Refresh lcitool submodule

2022-01-21 Thread Daniel P . Berrangé
On Fri, Jan 21, 2022 at 12:40:48PM +0100, Thomas Huth wrote: > On 21/01/2022 11.36, Philippe Mathieu-Daudé wrote: > > Refresh lcitool submodule and the generated files by running: > > > >$ make lcitool-refresh > > > > Reviewed-by: Daniel P. Berrangé > >

Re: [PATCH v4 2/8] gitmodules: Correct libvirt-ci URL

2022-01-21 Thread Daniel P . Berrangé
4 > --- a/.gitmodules > +++ b/.gitmodules > @@ -66,4 +66,4 @@ > url = https://gitlab.com/qemu-project/vbootrom.git > [submodule "tests/lcitool/libvirt-ci"] > path = tests/lcitool/libvirt-ci > - url = http://gitlab.com/libvirt/libvirt-ci > + url =

Re: [PATCH] Update copyright dates to 2022

2022-01-20 Thread Daniel P . Berrangé
I suppose at some point we should try to arrange that Sphinx > can pick up the copyright year from a common location so > we don't need to change two places. > > docs/conf.py | 2 +- > include/qemu-common.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-)

Re: [PATCH v2] qapi: Cleanup SGX related comments and restore @section-size

2022-01-20 Thread Daniel P . Berrangé
On Thu, Jan 20, 2022 at 04:31:14PM +0100, Philippe Mathieu-Daudé wrote: > On 20/1/22 10:10, Daniel P. Berrangé wrote: > > On Wed, Jan 19, 2022 at 06:57:20PM -0500, Yang Zhong wrote: > > > The SGX NUMA patches were merged into Qemu 7.0 release, we need > > > clari

Re: [PATCH 1/2] python: introduce qmp-shell-wrap convenience tool

2022-01-20 Thread Daniel P . Berrangé
On Thu, Jan 20, 2022 at 02:33:46PM +0100, Philippe Mathieu-Daudé wrote: > On 18/1/22 19:04, John Snow wrote: > > On Tue, Jan 18, 2022 at 5:06 AM Daniel P. Berrangé > > wrote: > > > > It would be nice to just have this integrated into 'make check' so we > >

Re: MP tables do not report multiple CPUs in Qemu 6.2.0 on x86 when given -smp cpus=n flag

2022-01-20 Thread Daniel P . Berrangé
Huck > Reviewed-by: Andrew Jones > Reviewed-by: Pankaj Gupta > Reviewed-by: Daniel P. Berrangé > Message-Id: <20210929025816.21076-10-wangyana...@huawei.com> > Signed-off-by: Paolo Bonzini > > In any case, the behavior change is intended because

Re: [PATCH v2 5/6] tests/lcitool: Remove libxml2

2022-01-20 Thread Daniel P . Berrangé
On Thu, Jan 20, 2022 at 12:18:34PM +0100, Philippe Mathieu-Daudé wrote: > On 1/20/22 12:14, Daniel P. Berrangé wrote: > > On Thu, Jan 20, 2022 at 12:05:44PM +0100, Philippe Mathieu-Daudé wrote: > >> The previous commit removed all uses of libxml2. > >> > >> S

Re: [PATCH v3 6/7] tests/lcitool: Remove libxml2

2022-01-20 Thread Daniel P . Berrangé
files changed, 3 insertions(+), 10 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|

Re: [PATCH v3 2/7] tests/lcitool: Include local qemu.yml when refreshing cirrus-ci files

2022-01-20 Thread Daniel P . Berrangé
;.gitlab-ci.d/cirrus: auto-generate variables with > lcitool") > Reported-by: Daniel P. Berrangé > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/lcitool/refresh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé Regards,

Re: [PATCH v2 5/6] tests/lcitool: Remove libxml2

2022-01-20 Thread Daniel P . Berrangé
On Thu, Jan 20, 2022 at 12:21:01PM +0100, Philippe Mathieu-Daudé wrote: > (+Andrea) > > On 1/20/22 12:18, Philippe Mathieu-Daudé wrote: > > On 1/20/22 12:14, Daniel P. Berrangé wrote: > >> On Thu, Jan 20, 2022 at 12:05:44PM +0100, Philippe Mathieu-Daudé wrote: > >

Re: [PATCH v2 3/6] tests/lcitool: Install libibumad to cover RDMA on Debian based distros

2022-01-20 Thread Daniel P . Berrangé
; Signed-off-by: Philippe Mathieu-Daudé > --- > tests/docker/dockerfiles/ubuntu1804.docker | 1 + > tests/docker/dockerfiles/ubuntu2004.docker | 1 + > tests/lcitool/projects/qemu.yml| 1 + > 3 files changed, 3 insertions(+) Reviewed-by: Daniel P. Berrangé Regards

Re: [PATCH 0/2] Improved support for AMD SEV firmware loading

2022-01-20 Thread Daniel P . Berrangé
On Mon, Jan 17, 2022 at 06:12:50AM -0600, Brijesh Singh wrote: > > On 1/17/22 1:34 AM, Dov Murik wrote: > > [+cc Tom, Brijesh, Ashish - see SEV-related changes in this series] > > > > > > On 13/01/2022 18:55, Daniel P. Berrangé wrote: > >> The AMD SEV

Re: [PATCH v2 6/6] tests: Manually remove libxml2 on MSYS2 targets

2022-01-20 Thread Daniel P . Berrangé
yml | 2 -- > 2 files changed, 3 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://entangle-photo.org-o-h

Re: [PATCH v2 5/6] tests/lcitool: Remove libxml2

2022-01-20 Thread Daniel P . Berrangé
On Thu, Jan 20, 2022 at 12:05:44PM +0100, Philippe Mathieu-Daudé wrote: > The previous commit removed all uses of libxml2. > > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/docker/dockerfiles/alpine.docker| 1 - > tests/docker/dockerfiles/centos8.docker | 1 - >

Re: [PATCH v2] qapi: Cleanup SGX related comments and restore @section-size

2022-01-20 Thread Daniel P . Berrangé
On Thu, Jan 20, 2022 at 05:16:01PM +0800, Yang Zhong wrote: > On Thu, Jan 20, 2022 at 09:10:34AM +0000, Daniel P. Berrangé wrote: > > On Wed, Jan 19, 2022 at 06:57:20PM -0500, Yang Zhong wrote: > > > The SGX NUMA patches were merged into Qemu 7.0 release, we need > > &g

Re: [PATCH v2 5/5] python/aqmp: add socket bind step to legacy.py

2022-01-20 Thread Daniel P . Berrangé
On Wed, Jan 19, 2022 at 02:39:16PM -0500, John Snow wrote: > The old QMP library would actually bind to the server address during > __init__(). The new library delays this to the accept() call, because > binding occurs inside of the call to start_[unix_]server(), which is an > async method -- so

Re: [PATCH v2] qapi: Cleanup SGX related comments and restore @section-size

2022-01-20 Thread Daniel P . Berrangé
schema promises backwards compatibility as standard. > We temporarily restore "@section-size", which can avoid incompatible > API breakage. The "@section-size" will be deprecated in 7.2 version. > > Suggested-by: Daniel P. Berrangé > Signed-off-by: Yang Zhong

Re: [PATCH v7 3/5] migration: Add zero-copy parameter for QMP/HMP for Linux

2022-01-19 Thread Daniel P . Berrangé
On Wed, Jan 19, 2022 at 03:03:29PM -0300, Leonardo Bras Soares Passos wrote: > Hello Daniel, > > On Thu, Jan 13, 2022 at 10:10 AM Daniel P. Berrangé > wrote: > > > > On Thu, Jan 06, 2022 at 07:13:40PM -0300, Leonardo Bras wrote: > > > Add property that allows ze

Re: [PATCH 0/3] meson: Don't pass 'method' to dependency()

2022-01-19 Thread Daniel P . Berrangé
On Wed, Jan 19, 2022 at 06:17:57PM +0100, Andrea Bolognani wrote: > See [1] for recent discussion about libgcrypt specifically, which the > first patch is about. > > After writing that one, I realized that there is no point in > explicitly passing 'method' to dependency() because Meson will do

Re: [PATCH 2/2] tests: Refresh lcitool submodule

2022-01-19 Thread Daniel P . Berrangé
# $ lcitool dockerfile ubuntu-2004 qemu > +# $ lcitool dockerfile --layers all ubuntu-2004 qemu > # > # https://gitlab.com/libvirt/libvirt-ci > > diff --git a/tests/lcitool/libvirt-ci b/tests/lcitool/libvirt-ci > index 29cec2153b9..8f48e54238d 16 > --- a/tests/lcitool/libvirt-ci > +++ b/tests/lcitool

Re: [PATCH 1/2] MAINTAINERS: Cover lcitool submodule with build test / automation

2022-01-19 Thread Daniel P . Berrangé
changed, 1 insertion(+) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|

Re: [PATCH] qapi: Cleanup SGX related comments

2022-01-19 Thread Daniel P . Berrangé
On Wed, Jan 19, 2022 at 05:22:59PM +0800, Yang Zhong wrote: > On Wed, Jan 19, 2022 at 09:16:46AM +0000, Daniel P. Berrangé wrote: > > On Wed, Jan 19, 2022 at 07:00:14AM -0500, Yang Zhong wrote: > > > The SGX NUMA patches were merged into Qemu 7.0 release, we need > > &g

Re: [PATCH] drop libxml2 checks since libxml is not actually used (for parallels)

2022-01-19 Thread Daniel P . Berrangé
Copying the maintainers for block/parallels.c On Wed, Jan 19, 2022 at 12:04:23PM +0300, Michael Tokarev wrote: > [This is a trivial patch, but due to the number of files it touches > I'm not using qemu-trivial@ route.] > > For a long time, we assumed that libxml2 is neecessary for parallels >

Re: [PULL 11/13] numa: Support SGX numa in the monitor and Libvirt interfaces

2022-01-19 Thread Daniel P . Berrangé
On Mon, Jan 17, 2022 at 06:37:31PM +0800, Yang Zhong wrote: > On Thu, Jan 13, 2022 at 04:15:10PM +0000, Daniel P. Berrangé wrote: > > On Wed, Dec 15, 2021 at 09:25:13PM +0100, Paolo Bonzini wrote: > > > From: Yang Zhong > > > > > > Add the SGXEPCSection li

Re: [PATCH v2 1/3] qmp: Support for querying stats

2022-01-19 Thread Daniel P . Berrangé
On Wed, Jan 19, 2022 at 09:43:23AM +0100, Paolo Bonzini wrote: > On 1/18/22 15:47, Igor Mammedov wrote: > > and what exactly this CPU ID is, > > may QOM path pointing to VCPU instance would be better? > > For x86 it would be the APIC ID but yes, having a QOM path is more future > proof. Thanks

Re: [PATCH] qapi: Cleanup SGX related comments

2022-01-19 Thread Daniel P . Berrangé
-by: Yang Zhong > --- > qapi/machine.json | 4 ++-- > qapi/misc-target.json | 14 +- > 2 files changed, 11 insertions(+), 7 deletions(-) Reviewed-by: Daniel P. Berrangé > diff --git a/qapi/machine.json b/qapi/machine.json > index b6a37e17c4..cf47cb63a9 100644 >

Re: /usr/shared/qemu binaries

2022-01-18 Thread Daniel P . Berrangé
On Tue, Jan 18, 2022 at 01:30:35PM +0100, Paolo Bonzini wrote: > On 1/13/22 18:23, Peter Maydell wrote: > > On Thu, 13 Jan 2022 at 17:13, Paolo Bonzini wrote: > > > > > > On 1/12/22 14:56, Peter Maydell wrote: > > > > Those are UEFI firmware images which are suitable for using with > > > > the

Re: [PATCH v2 1/3] qmp: Support for querying stats

2022-01-18 Thread Daniel P . Berrangé
On Tue, Jan 18, 2022 at 01:26:32PM +0100, Paolo Bonzini wrote: > On 1/17/22 16:17, Mark Kanda wrote: > > > > > > I agree except that I think this and StatsResults should be unions, > > > even if it means running multiple query-stats commands. > > > > IIUC, making StatsResults a union implies the

Re: [PATCH 1/2] python: introduce qmp-shell-wrap convenience tool

2022-01-18 Thread Daniel P . Berrangé
On Mon, Jan 17, 2022 at 06:27:24PM -0500, John Snow wrote: > On Mon, Jan 17, 2022 at 9:11 AM Daniel P. Berrangé > wrote: > > > > With the current 'qmp-shell' tool developers must first spawn QEMU with > > a suitable -qmp arg and then spawn qmp-shell in a separa

[PATCH v2 2/2] python: support recording QMP session to a file

2022-01-18 Thread Daniel P . Berrangé
": false, "current": true, "index": 2, "name": "QEMU PS/2 Mouse" } ] } $ jq --slurp '. | to_entries[] | select(.value.execute == "query-kvm") | .value.return.enabled' <

[PATCH v2 1/2] python: introduce qmp-shell-wrap convenience tool

2022-01-18 Thread Daniel P . Berrangé
wrap' switches the socket peers around so that it is the UNIX socket server and QEMU is the socket client. This makes QEMU reliably go away when qmp-shell-wrap exits, closing the server socket. Signed-off-by: Daniel P. Berrangé --- python/qemu/qmp/qmp_shell.py

[PATCH v2 0/2] python: a few improvements to qmp-shell

2022-01-18 Thread Daniel P . Berrangé
warnings Daniel P. Berrangé (2): python: introduce qmp-shell-wrap convenience tool python: support recording QMP session to a file python/qemu/qmp/qmp_shell.py | 88 +--- python/setup.cfg | 3 ++ scripts/qmp/qmp-shell-wrap | 11 + 3 files

Re: tracing.rst neglects to document syntax of trace-events files

2022-01-18 Thread Daniel P . Berrangé
On Tue, Jan 18, 2022 at 09:23:50AM +0100, Markus Armbruster wrote: > Almost[*] all trace-events files start with this line: > > # See docs/devel/tracing.rst for syntax documentation. > > But I can't find syntax documentation there. In that doc, under the heading "Declaring trace events", is

Re: [PATCH] hw/i386/pc_piix: Mark the machine types from version 1.4 to 1.7 as deprecated

2022-01-17 Thread Daniel P . Berrangé
On Mon, Jan 17, 2022 at 08:16:39PM +0100, Thomas Huth wrote: > The list of machine types grows larger and larger each release ... and > it is unlikely that many people still use the very old ones for live > migration. QEMU v1.7 has been released more than 8 years ago, so most > people should have

[PATCH 1/2] python: introduce qmp-shell-wrap convenience tool

2022-01-17 Thread Daniel P . Berrangé
wrap' switches the socket peers around so that it is the UNIX socket server and QEMU is the socket client. This makes QEMU reliably go away when qmp-shell-wrap exits, closing the server socket. Signed-off-by: Daniel P. Berrangé --- python/qemu/qmp/qmp_shell.py

Re: [PATCH 1/2] hw/i386/x86: Attach CPUs to machine

2022-01-17 Thread Daniel P . Berrangé
On Mon, Jan 17, 2022 at 12:53:30AM +0100, Philippe Mathieu-Daudé via wrote: > Avoid having CPUs objects dangling as unattached QOM ones, > directly attach them to the machine. Lets be more explicit here [quote] Previously CPUs were exposed in the QOM tree at a path

[PATCH 0/2] python: a few improvements to qmp-shell

2022-01-17 Thread Daniel P . Berrangé
is tied to that of the shell. Second it adds ability to log QMP commands/responses to a file that can be queried with 'jq' to extract information. This is good for commands which return huge JSON docs. Daniel P. Berrangé (2): python: introduce qmp-shell-wrap convenience tool python: support

[PATCH 2/2] python: support recording QMP session to a file

2022-01-17 Thread Daniel P . Berrangé
": false, "current": true, "index": 2, "name": "QEMU PS/2 Mouse" } ] } $ jq --slurp '. | to_entries[] | select(.value.execute == "query-kvm") | .value.return.enabl

Re: [PATCH 0/2] Improved support for AMD SEV firmware loading

2022-01-17 Thread Daniel P . Berrangé
On Mon, Jan 17, 2022 at 09:34:30AM +0200, Dov Murik wrote: > [+cc Tom, Brijesh, Ashish - see SEV-related changes in this series] > > > On 13/01/2022 18:55, Daniel P. Berrangé wrote: > > The AMD SEV build of EDK2 only emits a single file, intended to be > &

Re: [PATCH 4/6] migration: Add ram-only capability

2022-01-14 Thread Daniel P . Berrangé
On Fri, Jan 14, 2022 at 12:22:13PM +0100, Markus Armbruster wrote: > Nikita Lapshin writes: > > > If this capability is enabled migration stream > > will have RAM section only. > > > > Signed-off-by: Nikita Lapshin > > [...] > > > diff --git a/qapi/migration.json b/qapi/migration.json > >

[PATCH 2/2] hw/i386: support loading OVMF using -bios too

2022-01-13 Thread Daniel P . Berrangé
it is a little strange to use pflash if there won't be any persistent data. A stateless OVMF build can be loaded with -bios, however, QEMU does not currently initialize SEV in that scenario. This patch introduces the call needed for SEV initialization of the firmware. Signed-off-by: Daniel P

[PATCH 1/2] hw/i386: refactor logic for setting up SEV firmware

2022-01-13 Thread Daniel P . Berrangé
Currently this logic is only run in the pflash codepath but we want to run it in other scenarios too. Signed-off-by: Daniel P. Berrangé --- hw/i386/pc_sysfw.c| 24 +++- hw/i386/pc_sysfw_ovmf-stubs.c | 10 ++ hw/i386/pc_sysfw_ovmf.c | 27

[PATCH 0/2] Improved support for AMD SEV firmware loading

2022-01-13 Thread Daniel P . Berrangé
kernel boot In all these cases I was able to validate the reported SEV guest measurement. Daniel P. Berrangé (2): hw/i386: refactor logic for setting up SEV firmware hw/i386: support loading OVMF using -bios too hw/i386/pc_sysfw.c| 24 +++- hw/i386

Re: [PATCH 2/2] qapi/ui: introduce change-vnc-listen

2022-01-13 Thread Daniel P . Berrangé
On Thu, Jan 13, 2022 at 05:27:08PM +0100, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Mon, Dec 20, 2021 at 04:44:18PM +0100, Vladimir Sementsov-Ogievskiy > > wrote: > >> Add command that can change addresses where VNC server listens for new >

Re: [PULL 10/13] numa: Enable numa for SGX EPC sections

2022-01-13 Thread Daniel P . Berrangé
On Wed, Dec 15, 2021 at 09:25:12PM +0100, Paolo Bonzini wrote: > From: Yang Zhong > > The basic SGX did not enable numa for SGX EPC sections, which > result in all EPC sections located in numa node 0. This patch > enable SGX numa function in the guest and the EPC section can > work with RAM as

Re: [PULL 11/13] numa: Support SGX numa in the monitor and Libvirt interfaces

2022-01-13 Thread Daniel P . Berrangé
On Wed, Dec 15, 2021 at 09:25:13PM +0100, Paolo Bonzini wrote: > From: Yang Zhong > > Add the SGXEPCSection list into SGXInfo to show the multiple > SGX EPC sections detailed info, not the total size like before. > This patch can enable numa support for 'info sgx' command and > QMP interfaces.

Re: [PATCH v7 4/5] migration: Add migrate_use_tls() helper

2022-01-13 Thread Daniel P . Berrangé
ng > for TLS usage. > > Signed-off-by: Leonardo Bras > Reviewed-by: Juan Quintela > --- > migration/migration.h | 1 + > migration/channel.c | 6 +++--- > migration/migration.c | 9 + > migration/multifd.c | 5 + > 4 files changed, 14 insertions

Re: [PATCH v7 3/5] migration: Add zero-copy parameter for QMP/HMP for Linux

2022-01-13 Thread Daniel P . Berrangé
5 + > migration/migration.c | 32 > migration/socket.c| 5 + > monitor/hmp-cmds.c| 6 ++ > 5 files changed, 72 insertions(+) Reviewed-by: Daniel P. Berrangé > > diff --git a/qapi/migration.json b/qapi/migration.json > index bbfd48cf0b..2e62ea6ebd 10

Re: [PATCH v7 2/5] QIOChannelSocket: Implement io_writev zero copy flag & io_flush for CONFIG_LINUX

2022-01-13 Thread Daniel P . Berrangé
f-by: Leonardo Bras > --- > include/io/channel-socket.h | 2 + > io/channel-socket.c | 107 ++++++-- > 2 files changed, 105 insertions(+), 4 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-http

Re: [PATCH v7 1/5] QIOChannel: Add flags on io_writev and introduce io_flush callback

2022-01-13 Thread Daniel P . Berrangé
On Thu, Jan 06, 2022 at 07:13:38PM -0300, Leonardo Bras wrote: > Add flags to io_writev and introduce io_flush as optional callback to > QIOChannelClass, allowing the implementation of zero copy writes by > subclasses. > > How to use them: > - Write data using

Re: [PATCH v7 2/5] QIOChannelSocket: Implement io_writev zero copy flag & io_flush for CONFIG_LINUX

2022-01-13 Thread Daniel P . Berrangé
On Thu, Jan 13, 2022 at 06:34:12PM +0800, Peter Xu wrote: > On Thu, Jan 13, 2022 at 10:06:14AM +0000, Daniel P. Berrangé wrote: > > On Thu, Jan 13, 2022 at 02:48:15PM +0800, Peter Xu wrote: > > > On Thu, Jan 06, 2022 at 07:13:39PM -0300, Leonardo Bras wrote: > > > >

Re: [PATCH v7 2/5] QIOChannelSocket: Implement io_writev zero copy flag & io_flush for CONFIG_LINUX

2022-01-13 Thread Daniel P . Berrangé
On Thu, Jan 13, 2022 at 02:48:15PM +0800, Peter Xu wrote: > On Thu, Jan 06, 2022 at 07:13:39PM -0300, Leonardo Bras wrote: > > @@ -558,15 +575,26 @@ static ssize_t qio_channel_socket_writev(QIOChannel > > *ioc, > > memcpy(CMSG_DATA(cmsg), fds, fdsize); > > } > > > > +if (flags

Re: PyPI account

2022-01-12 Thread Daniel P . Berrangé
On Wed, Jan 12, 2022 at 12:47:01PM -0500, John Snow wrote: > On Wed, Jan 12, 2022 at 12:34 PM Daniel P. Berrangé > wrote: > > > > On Wed, Jan 12, 2022 at 12:25:16PM -0500, John Snow wrote: > > > On Wed, Jan 12, 2022 at 5:56 AM Stefan Hajnoczi > > > wrote: &g

Re: PyPI account

2022-01-12 Thread Daniel P . Berrangé
On Wed, Jan 12, 2022 at 12:25:16PM -0500, John Snow wrote: > On Wed, Jan 12, 2022 at 5:56 AM Stefan Hajnoczi wrote: > > > > [Context: John created a PyPI QEMU user in order to publish the qemu.qmp > > package. If anyone wants to publish additional Python packages from > > qemu.git, please contact

Re: [PATCH] sgx: Move sgx object from /machine/unattached to /machine

2022-01-12 Thread Daniel P . Berrangé
On Wed, Jan 12, 2022 at 10:16:33AM +, Peter Maydell wrote: > On Wed, 12 Jan 2022 at 10:14, Daniel P. Berrangé wrote: > > > > On Wed, Jan 12, 2022 at 11:55:17AM -0500, Yang Zhong wrote: > > > When Libvirt start, it get the vcpu's unavailable-features from > >

Re: [PATCH] sgx: Move sgx object from /machine/unattached to /machine

2022-01-12 Thread Daniel P . Berrangé
On Wed, Jan 12, 2022 at 11:55:17AM -0500, Yang Zhong wrote: > When Libvirt start, it get the vcpu's unavailable-features from > /machine/unattached/device[0] path by qom-get command, but in SGX > guest, since the sgx-epc virtual device is initialized before VCPU > creation(virtual sgx need set the

Re: [RFC qemu.qmp PATCH 17/24] Makefile: add build and publish targets

2022-01-12 Thread Daniel P . Berrangé
On Tue, Jan 11, 2022 at 02:48:55PM -0500, John Snow wrote: > On Fri, Dec 17, 2021 at 8:46 AM Daniel P. Berrangé > wrote: > > > On Thu, Dec 16, 2021 at 06:35:23PM -0500, John Snow wrote: > > > On Thu, Dec 16, 2021 at 5:48 AM Daniel P. Berrangé > > > wrote: &

Re: cirrus-ci: FreeBSD failure (lttng-ust package not found)

2022-01-11 Thread Daniel P . Berrangé
On Tue, Jan 11, 2022 at 02:11:14PM +0100, Philippe Mathieu-Daudé wrote: > Hi Alex, > > I am getting this failure for the x64-freebsd-*-build jobs [1, 2]: > > pkg: No packages available to install matching 'lttng-ust' have been > found in the repositories It was being installed fine on FreeBSD

Re: Re: [PATCH] usb: allow max 8192 bytes for desc

2022-01-11 Thread Daniel P . Berrangé
On Tue, Jan 11, 2022 at 08:27:35PM +0800, zhenwei pi wrote: > > > On 1/11/22 8:25 PM, Daniel P. Berrangé wrote: > > On Tue, Jan 11, 2022 at 12:21:42PM +, Peter Maydell wrote: > > > On Tue, 11 Jan 2022 at 10:54, zhenwei pi wrote: > > > > > > &g

Re: [PATCH 4/5] usb: allow max 8192 bytes for desc

2022-01-11 Thread Daniel P . Berrangé
> 2 files changed, 9 insertions(+), 7 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://entangle-photo.org-o-h

Re: [PATCH] usb: allow max 8192 bytes for desc

2022-01-11 Thread Daniel P . Berrangé
On Tue, Jan 11, 2022 at 12:21:42PM +, Peter Maydell wrote: > On Tue, 11 Jan 2022 at 10:54, zhenwei pi wrote: > > > > A device of USB video class usually uses larger desc structure, so > > use larger buffer to avoid failure. (dev-video.c is ready) > > > > Allocating memory dynamically by

Re: "Startup" meeting (was Re: Meeting today?)

2022-01-11 Thread Daniel P . Berrangé
On Tue, Jan 11, 2022 at 11:20:54AM +0100, Philippe Mathieu-Daudé wrote: > Hi, > > Just checking in, this call is scheduled for today, 3pm CEST, right? > > Here is the KVM call calendar: >

Re: [RFC PATCH v2 06/44] hw/i386: Introduce kvm-type for TDX guest

2022-01-10 Thread Daniel P . Berrangé
On Mon, Jan 10, 2022 at 08:01:33PM +0800, Xiaoyao Li wrote: > On 1/10/2022 7:18 PM, Daniel P. Berrangé wrote: > > On Wed, Nov 24, 2021 at 03:31:13PM +0800, Xiaoyao Li wrote: > > > On 8/26/2021 6:22 PM, Gerd Hoffmann wrote: > > > > On Wed, Jul 07, 2021 at 05:54:36PM -

Re: [PATCH] docs: Add measurement calculation details to amd-memory-encryption.txt

2022-01-10 Thread Daniel P . Berrangé
On Mon, Jan 10, 2022 at 01:17:02PM +0200, Dov Murik wrote: > > > On 07/01/2022 22:18, Daniel P. Berrangé wrote: > > On Thu, Dec 16, 2021 at 11:41:27PM +0200, Dov Murik wrote: > >> > >> > >> On 16/12/2021 18:09, Daniel P. Berrangé wrote: > >>&g

Re: [RFC PATCH v2 06/44] hw/i386: Introduce kvm-type for TDX guest

2022-01-10 Thread Daniel P . Berrangé
On Wed, Nov 24, 2021 at 03:31:13PM +0800, Xiaoyao Li wrote: > On 8/26/2021 6:22 PM, Gerd Hoffmann wrote: > > On Wed, Jul 07, 2021 at 05:54:36PM -0700, isaku.yamah...@gmail.com wrote: > > > From: Xiaoyao Li > > > > > > Introduce a machine property, kvm-type, to allow the user to create a > > >

Re: [PATCH v2 6/6] gitlab-ci: Support macOS 12 via cirrus-run

2022-01-10 Thread Daniel P . Berrangé
On Sun, Jan 09, 2022 at 06:06:12PM +0100, Philippe Mathieu-Daudé wrote: > Add support for macOS 12 build on Cirrus-CI, similarly to commit > 0e103a65ba1 ("gitlab: support for ... macOS 11 via cirrus-run"). > > Disable deprecation warnings on Objective C to avoid: > > [2789/6622] Compiling

Re: [PATCH] docs: Add measurement calculation details to amd-memory-encryption.txt

2022-01-07 Thread Daniel P . Berrangé
On Thu, Dec 16, 2021 at 11:41:27PM +0200, Dov Murik wrote: > > > On 16/12/2021 18:09, Daniel P. Berrangé wrote: > > On Thu, Dec 16, 2021 at 12:38:34PM +0200, Dov Murik wrote: > >> > >> > >> On 14/12/2021 20:39, Daniel P. Berrangé wrote: > >>

Re: [Qemu-devel] [PATCH] configure: Add pkg-config handling for libgcrypt

2022-01-07 Thread Daniel P . Berrangé
On Fri, Jan 07, 2022 at 12:55:42PM +0100, Thomas Huth wrote: > On 07/01/2022 12.43, Andrea Bolognani wrote: > > On Thu, Aug 29, 2019 at 10:15:05AM +0100, Daniel P. Berrangé wrote: > > > On Thu, Aug 29, 2019 at 04:53:02PM +0800, zhe...@windriver.com wrote: > > > > li

Re: "Startup" meeting (was Re: Meeting today?)

2022-01-06 Thread Daniel P . Berrangé
> > On Tue, Dec 14, 2021 at 3:49 PM Markus Armbruster > <mailto:arm...@redhat.com>> wrote: > > Daniel P. Berrangé mailto:berra...@redhat.com>> > > writes: > > > > > On Tue, Dec 14, 2021 at 12:37:43PM +0100, Markus Armbruster wrote: > > &g

Re: [PATCH 1/1] softmmu: fix device deletion events with -device JSON syntax

2022-01-05 Thread Daniel P . Berrangé
On Wed, Jan 05, 2022 at 04:00:54PM +0100, Laurent Vivier wrote: > On 05/01/2022 15:55, Daniel P. Berrangé wrote: > > On Wed, Jan 05, 2022 at 03:49:12PM +0100, Laurent Vivier wrote: > > > On 05/01/2022 13:38, Daniel P. Berrangé wrote: > > > > The -device JSON

Re: [PATCH 1/1] softmmu: fix device deletion events with -device JSON syntax

2022-01-05 Thread Daniel P . Berrangé
On Wed, Jan 05, 2022 at 03:49:12PM +0100, Laurent Vivier wrote: > On 05/01/2022 13:38, Daniel P. Berrangé wrote: > > The -device JSON syntax impl leaks a reference on the created > > DeviceState instance. As a result when you hot-unplug the > > device, the device_finalize m

Re: [PATCH v1 20/34] tests/docker: add libfuse3 development headers

2022-01-05 Thread Daniel P . Berrangé
On Wed, Jan 05, 2022 at 02:26:55PM +, Richard W.M. Jones wrote: > On Wed, Jan 05, 2022 at 01:49:55PM +, Alex Bennée wrote: > > From: Stefan Hajnoczi > > > > The FUSE exports feature is not built because most container images do > > not have libfuse3 development headers installed. Add the

[PATCH 0/1] Fix -device JSON support wrt hotplug

2022-01-05 Thread Daniel P . Berrangé
Libvirt switched to using -device JSON support, but we discovered in testing that it is broken for hotplug, never sending DEVICE_DELETED events. This is caused by a subtle refcount leak. Daniel P. Berrangé (1): softmmu: fix device deletion events with -device JSON syntax qapi/qdev.json

[PATCH 1/1] softmmu: fix device deletion events with -device JSON syntax

2022-01-05 Thread Daniel P . Berrangé
/qemu-project/qemu/-/issues/802 Signed-off-by: Daniel P. Berrangé --- qapi/qdev.json | 5 - softmmu/vl.c | 4 +++- tests/qtest/device-plug-test.c | 19 +++ 3 files changed, 26 insertions(+), 2 deletions(-) diff --git a/qapi/qdev.json b/qapi

Re: [PATCH v2] FreeBSD: Upgrade to 12.3 release

2022-01-05 Thread Daniel P . Berrangé
> Tested-by: Thomas Huth > Reviewed-by: Warner Losh > --- > .gitlab-ci.d/cirrus.yml | 5 + > tests/vm/freebsd| 8 +++- > 2 files changed, 4 insertions(+), 9 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-

Re: [PATCH 2/2] [crypto] Only verify CA certs in chain of trust

2022-01-04 Thread Daniel P . Berrangé
> tests/unit/test-crypto-tlscredsx509.c | 25 +- > 2 files changed, 68 insertions(+), 7 deletions(-) Reviewed-by: Daniel P. Berrangé > > diff --git a/crypto/tlscredsx509.c b/crypto/tlscredsx509.c > index d061c68253..841f80aac6 100644 >

Re: [PATCH 2/2] [crypto] Only verify CA certs in chain of trust

2022-01-04 Thread Daniel P . Berrangé
On Wed, Dec 22, 2021 at 03:54:08PM +, Henry Kleynhans wrote: > Hi Daniel, > > This patch tightens the CA verification code to only check the > issuer chain of the client cert. I think this will still not > catch expired/invalid certs if the client and server certs have > different issuer

Re: [PATCH 1/2] [crypto] Load all certificates in X509 CA file

2022-01-04 Thread Daniel P . Berrangé
space to load all of the > certificates present in the CA file and ensure they are cleaned up. > > Signed-off-by: Henry Kleynhans > --- > crypto/tlscredsx509.c | 20 ++-- > 1 file changed, 10 insertions(+), 10 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel

Re: [PATCH v5 0/3] tpm: Add missing ACPI device identification objects

2022-01-04 Thread Daniel P . Berrangé
On Tue, Jan 04, 2022 at 12:58:03PM -0500, Stefan Berger wrote: > This series of patches adds missing ACPI device identification objects _STR > and _UID to TPM 1.2 and TPM 2 ACPI tables. What was the practical impact on guests (if any) from these ACPI objects being missing ? Regards, Daniel --

Re: [PATCH] [RESEND] docs: Add spec of OVMF GUIDed table for SEV guests

2022-01-04 Thread Daniel P . Berrangé
f-by: Dov Murik > --- > docs/specs/index.rst | 1 + > docs/specs/sev-guest-firmware.rst | 125 ++ > 2 files changed, 126 insertions(+) > create mode 100644 docs/specs/sev-guest-firmware.rst Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |

Re: [PATCH v2] docs: Add measurement calculation details to amd-memory-encryption.txt

2022-01-04 Thread Daniel P . Berrangé
Murik > Suggested-by: Daniel P. Berrangé > > --- > > v2: > - Explain that firmware must be built without NVRAM store. > --- > docs/amd-memory-encryption.txt | 52 +++--- > 1 file changed, 48 insertions(+), 4 deletions(-) Reviewed-by: Danie

Re: [PATCH 0/5] Introduce camera subsystem and USB video device

2022-01-04 Thread Daniel P . Berrangé
On Mon, Dec 27, 2021 at 10:27:29PM +0800, zhenwei pi wrote: > 1, The full picture of this patch set: >+-+ ++ +---+ >|UVC(done)| |virtio(TODO)| |other HW device| >+-+ ++ +---+ > |

Re: [PATCH v2 2/3] qapi/ui: introduce change-vnc-listen

2022-01-04 Thread Daniel P . Berrangé
On Wed, Dec 22, 2021 at 08:17:30PM +0100, Vladimir Sementsov-Ogievskiy wrote: > Add command that can change addresses where VNC server listens for new > connections. Prior to 6.0 this functionality was available through > 'change' qmp command which was deleted. > > Signed-off-by: Vladimir

Re: [PATCH v2 1/5] ps2: Initial horizontal scroll support

2022-01-04 Thread Daniel P . Berrangé
On Wed, Dec 22, 2021 at 02:06:43AM +0100, Dmitry Petrov wrote: > v2: > - Patch is split into a sequence > - value is clamped to 31 for horizontal scroll > > This patch introduces horizontal scroll support for the ps/2 > mouse. > > The patch is based on the previous work > by Brad Jorsch done

Re: [PATCH 2/2] qapi/ui: introduce change-vnc-listen

2022-01-04 Thread Daniel P . Berrangé
On Mon, Dec 20, 2021 at 04:44:18PM +0100, Vladimir Sementsov-Ogievskiy wrote: > Add command that can change addresses where VNC server listens for new > connections. Prior to 6.0 this functionality was available through > 'change' qmp command which was deleted. > > Signed-off-by: Vladimir

Re: [PATCH] vl: Add -set options to device opts dict when using JSON syntax for -device

2022-01-04 Thread Daniel P . Berrangé
On Wed, Dec 22, 2021 at 09:22:47AM +0100, Gerd Hoffmann wrote: > On Tue, Dec 21, 2021 at 04:40:28PM +0100, Markus Armbruster wrote: > > Paolo Bonzini writes: > > > > > On 12/21/21 13:58, Markus Armbruster wrote: > > >>> Is this a regression? I suspect commit 5dacda5167 "vl: Enable JSON > > >>>

Re: [RFC PATCH] docs/devel: more documentation on the use of suffixes

2021-12-17 Thread Daniel P . Berrangé
/devel/style.rst | 7 +++ > include/glib-compat.h | 6 +++--- > 2 files changed, 10 insertions(+), 3 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-

Re: [PATCH v2] hw: Add compat machines for 7.0

2021-12-17 Thread Daniel P . Berrangé
| 15 +-- > hw/s390x/s390-virtio-ccw.c | 14 +- > include/hw/boards.h| 3 +++ > include/hw/i386/pc.h | 3 +++ > 9 files changed, 71 insertions(+), 6 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com

Re: [PATCH v3 02/28] glib-compat: Introduce g_memdup2() wrapper

2021-12-17 Thread Daniel P . Berrangé
On Fri, Dec 17, 2021 at 02:53:05PM +, Alex Bennée wrote: > > Daniel P. Berrangé writes: > > > On Thu, Dec 16, 2021 at 02:11:37PM +, Alex Bennée wrote: > >> > >> Philippe Mathieu-Daudé writes: > >> > >> > When experimenting raisi

Re: [PATCH v3 02/28] glib-compat: Introduce g_memdup2() wrapper

2021-12-17 Thread Daniel P . Berrangé
On Thu, Dec 16, 2021 at 02:11:37PM +, Alex Bennée wrote: > > Philippe Mathieu-Daudé writes: > > > When experimenting raising GLIB_VERSION_MIN_REQUIRED to 2.68 > > (Fedora 34 provides GLib 2.68.1) we get: > > > > hw/virtio/virtio-crypto.c:245:24: error: 'g_memdup' is deprecated: Use > >

Re: [RFC qemu.qmp PATCH 17/24] Makefile: add build and publish targets

2021-12-17 Thread Daniel P . Berrangé
On Thu, Dec 16, 2021 at 06:35:23PM -0500, John Snow wrote: > On Thu, Dec 16, 2021 at 5:48 AM Daniel P. Berrangé > wrote: > > > On Wed, Dec 15, 2021 at 04:06:27PM -0500, John Snow wrote: > > > Signed-off-by: John Snow > > > --- > > > Makefile | 32

Re: [PATCH v3 02/28] glib-compat: Introduce g_memdup2() wrapper

2021-12-17 Thread Daniel P . Berrangé
On Fri, Dec 17, 2021 at 11:10:31AM +, Alex Bennée wrote: > > Philippe Mathieu-Daudé writes: > > > On 12/16/21 15:11, Alex Bennée wrote: > >> Philippe Mathieu-Daudé writes: > >> > >>> When experimenting raising GLIB_VERSION_MIN_REQUIRED to 2.68 > >>> (Fedora 34 provides GLib 2.68.1) we

Re: [PATCH for-7.0] hw: Add compat machines for 7.0

2021-12-17 Thread Daniel P . Berrangé
On Fri, Dec 17, 2021 at 09:13:55AM +0100, Cornelia Huck wrote: > On Wed, Dec 08 2021, Cornelia Huck wrote: > > > Add 7.0 machine types for arm/i440fx/q35/s390x/spapr. > > > > Signed-off-by: Cornelia Huck > > --- > > hw/arm/virt.c | 9 - > > hw/core/machine.c | 3

Re: [PATCH] docs: Add measurement calculation details to amd-memory-encryption.txt

2021-12-17 Thread Daniel P . Berrangé
On Thu, Dec 16, 2021 at 11:41:27PM +0200, Dov Murik wrote: > > > On 16/12/2021 18:09, Daniel P. Berrangé wrote: > > On Thu, Dec 16, 2021 at 12:38:34PM +0200, Dov Murik wrote: > >> > >> > >> On 14/12/2021 20:39, Daniel P. Berrangé wrote: > >>&g

Re: Redesign of QEMU startup & initial configuration

2021-12-16 Thread Daniel P . Berrangé
On Thu, Dec 16, 2021 at 05:00:55PM +0100, Mark Burton wrote: > > > > On 16 Dec 2021, at 16:40, Daniel P. Berrangé wrote: > > > > On Thu, Dec 16, 2021 at 04:28:29PM +0100, Paolo Bonzini wrote: > >> On 12/16/21 11:24, Markus Armbruster wrote: > >>>>

Re: [PATCH] docs: Add measurement calculation details to amd-memory-encryption.txt

2021-12-16 Thread Daniel P . Berrangé
On Thu, Dec 16, 2021 at 12:38:34PM +0200, Dov Murik wrote: > > > On 14/12/2021 20:39, Daniel P. Berrangé wrote: > > On Tue, Dec 14, 2021 at 01:59:10PM +, Dov Murik wrote: > >> Add a section explaining how the Guest Owner should calculate the > >> expected

Re: Redesign of QEMU startup & initial configuration

2021-12-16 Thread Daniel P . Berrangé
On Thu, Dec 16, 2021 at 04:28:29PM +0100, Paolo Bonzini wrote: > On 12/16/21 11:24, Markus Armbruster wrote: > > > Not really, in particular the startup has been mostly reworked already > > > and I disagree that it is messy. softmmu/vl.c is messy, sure: it has > > > N different command line

  1   2   3   4   5   6   7   8   9   10   >