[Qemu-devel] [PATCH] hw/arm/virt: Fix non-secure flash mode

2019-07-12 Thread David Engraf
is NULL. Signed-off-by: David Engraf --- hw/arm/virt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 0b5138cb22..d9496c9363 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -1674,7 +1674,7 @@ static void machvirt_init(MachineState *machine

[Qemu-devel] [PATCH] PPC e500: Fix gap between u-boot and kernel

2018-03-08 Thread David Engraf
This patch moves the gap between u-boot and kernel at the correct location. Signed-off-by: David Engraf <david.eng...@sysgo.com> --- hw/ppc/e500.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c index 43c15d18c4..bdef2bddc6

[Qemu-devel] [PATCH v4] PPC: e500: Fix duplicate kernel load and device tree overlap

2018-03-02 Thread David Engraf
kernel and initrd because Linux can handle the dtb only within the first 64MB. Add a comment to clarify the behavior. Signed-off-by: David Engraf <david.eng...@sysgo.com> Reviewed-by: David Gibson <da...@gibson.dropbear.id.au> --- hw/ppc/

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3] PPC: e500: Fix duplicate kernel load and device tree overlap

2018-03-02 Thread David Engraf
Am 02.03.2018 um 10:11 schrieb Mark Cave-Ayland: On 02/03/18 08:53, David Engraf wrote: Am 02.03.2018 um 02:45 schrieb David Gibson: On Thu, Feb 15, 2018 at 10:36:00AM +0100, David Engraf wrote: This patch fixes an incorrect behavior when the -kernel argument has been specified without -bios

Re: [Qemu-devel] [PATCH v3] PPC: e500: Fix duplicate kernel load and device tree overlap

2018-03-02 Thread David Engraf
Am 02.03.2018 um 02:45 schrieb David Gibson: On Thu, Feb 15, 2018 at 10:36:00AM +0100, David Engraf wrote: This patch fixes an incorrect behavior when the -kernel argument has been specified without -bios. In this case the kernel was loaded twice. At address 32M as a raw image and afterwards

[Qemu-devel] [PATCH v3] PPC: e500: Fix duplicate kernel load and device tree overlap

2018-02-15 Thread David Engraf
kernel and initrd because Linux can handle the dtb only within the first 64MB. Add a comment to clarify the behavior. Signed-off-by: David Engraf <david.eng...@sysgo.com> --- hw/ppc/e500.c | 116 +++--- 1 file chang

[Qemu-devel] [PATCH v2] PPC: e500: Fix duplicate kernel load and device tree overlap

2018-02-13 Thread David Engraf
generic name called payload_name/size. Signed-off-by: David Engraf <david.eng...@sysgo.com> --- hw/ppc/e500.c | 112 ++ 1 file changed, 65 insertions(+), 47 deletions(-) diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c index c4fe06ea2a..d12b

Re: [Qemu-devel] [RESEND PATCH] PPC: e500: Fix duplicate kernel load and device tree overlap

2018-02-13 Thread David Engraf
Am 13.02.2018 um 04:51 schrieb David Gibson: On Fri, Feb 09, 2018 at 08:49:45AM +0100, David Engraf wrote: Hello David, Am 09.02.2018 um 06:33 schrieb David Gibson: On Thu, Feb 08, 2018 at 09:36:21AM +0100, David Engraf wrote: This patch fixes an incorrect behavior when the -kernel argument

Re: [Qemu-devel] [RESEND PATCH] PPC: e500: Fix duplicate kernel load and device tree overlap

2018-02-08 Thread David Engraf
Hello David, Am 09.02.2018 um 06:33 schrieb David Gibson: On Thu, Feb 08, 2018 at 09:36:21AM +0100, David Engraf wrote: This patch fixes an incorrect behavior when the -kernel argument has been specified without -bios. In this case the kernel was loaded twice. At address 32M as a raw image

[Qemu-devel] [RESEND PATCH] PPC: e500: Fix duplicate kernel load and device tree overlap

2018-02-08 Thread David Engraf
and the raw kernel image may overlap. The patch fixes the behavior by loading the kernel image once with load_elf/load_uimage and skips loading the raw image. It also ensures that the device tree is generated behind bios/kernel/initrd. Signed-off-by: David Engraf <david.eng...@sysgo.com> --- hw/ppc/

[Qemu-devel] [PATCH] PPC: e500: Fix duplicate kernel load and device tree overlap

2018-01-29 Thread David Engraf
and the raw kernel image may overlap. The patch fixes the behavior by loading the kernel image once with load_elf/load_uimage and skips loading the raw image. It also ensures that the device tree is generated behind bios/kernel/initrd. Signed-off-by: David Engraf <david.eng...@sysgo.com> --- hw/ppc/

Re: [Qemu-devel] [PATCH v2] pflash_cfi01: fix per device sector length in CFI table

2017-01-17 Thread David Engraf
Am 16.01.2017 um 11:26 schrieb Dr. David Alan Gilbert: * Andrew Jones (drjo...@redhat.com) wrote: On Thu, Jan 12, 2017 at 10:42:41AM +, Peter Maydell wrote: On 12 January 2017 at 10:35, David Engraf <david.eng...@sysgo.com> wrote: The CFI entry for sector length must be set to

Re: [Qemu-devel] [PATCH] pflash_cfi01: fix per device sector length in CFI table

2017-01-12 Thread David Engraf
Am 12.01.2017 um 12:36 schrieb Andrew Jones: On Thu, Jan 12, 2017 at 10:42:41AM +, Peter Maydell wrote: On 12 January 2017 at 10:35, David Engraf <david.eng...@sysgo.com> wrote: The CFI entry for sector length must be set to sector length per device. This is important for boards

[Qemu-devel] [PATCH] pflash_cfi01: fix per device sector length in CFI table

2017-01-12 Thread David Engraf
fixes the sector length in the CFI table to match the length per device, equal to blocks_per_device. Signed-off-by: David Engraf <david.eng...@sysgo.com> diff --git a/hw/block/pflash_cfi01.c b/hw/block/pflash_cfi01.c index 5f0ee9d..8bb61e4 100644 --- a/hw/block/pflash_cfi01.c +++ b/hw/block/pf

Re: [Qemu-devel] [PATCH] vexpress fix flash device-width

2017-01-05 Thread David Engraf
Am 05.01.2017 um 19:32 schrieb Peter Maydell: On 22 December 2016 at 14:02, David Engraf <david.eng...@sysgo.com> wrote: The current implementation uses width = 4 and device-width = 2 for the flash configuration. When using u-boot or Linux, the flash is detected as 32 x 16 bit, thus the

[Qemu-devel] [PATCH] vexpress fix flash device-width

2016-12-22 Thread David Engraf
The current implementation uses width = 4 and device-width = 2 for the flash configuration. When using u-boot or Linux, the flash is detected as 32 x 16 bit, thus the sector size is doubled to 512 KB. When u-boot sends a sector erase, only the first 256 KB are erased because the QEMU flash

Re: [Qemu-devel] [PATCH v2] qemu_mutex_iothread_locked not correctly synchronized

2015-11-26 Thread David Engraf
Am 25.11.2015 um 17:16 schrieb Paolo Bonzini: On 25/11/2015 16:48, David Engraf wrote: Indeed, TLS handling is broken. The address of iothread_locked is always the same between threads and I can see that a different thread sets iothread_locked to false, thus my current thread uses an invalid

Re: [Qemu-devel] [PATCH v2] qemu_mutex_iothread_locked not correctly synchronized

2015-11-26 Thread David Engraf
Am 26.11.2015 um 12:25 schrieb Stefan Weil: Am 26.11.2015 um 10:12 schrieb David Engraf: Am 25.11.2015 um 17:16 schrieb Paolo Bonzini: On 25/11/2015 16:48, David Engraf wrote: Indeed, TLS handling is broken. The address of iothread_locked is always the same between threads and I can see

Re: [Qemu-devel] [PATCH v2] qemu_mutex_iothread_locked not correctly synchronized

2015-11-25 Thread David Engraf
Am 25.11.2015 um 15:36 schrieb Paolo Bonzini: On 25/11/2015 15:04, David Engraf wrote: No, you don't. Who is reading iothread_locked during qemu_cond_wait_iothread? No one, because it is a thread-local variable whose address is never taken. prepare_mmio_access is reading

Re: [Qemu-devel] [PATCH] qemu_mutex_iothread_locked not correctly synchronized

2015-11-25 Thread David Engraf
Hi Paolo, Am 24.11.2015 um 16:54 schrieb Paolo Bonzini: On 24/11/2015 16:43, David Engraf wrote: Commit afbe70535ff1a8a7a32910cc15ebecc0ba92e7da introduced the function qemu_mutex_iothread_locked to avoid recursive locking of the iothread lock. The iothread_locked variable uses the __thread

Re: [Qemu-devel] [PATCH v2] qemu_mutex_iothread_locked not correctly synchronized

2015-11-25 Thread David Engraf
ion tries to acquire the mutex again. The patch adds a function called qemu_cond_wait_iothread to keep iothread_locked in sync. Signed-off-by: David Engraf <david.eng...@sysgo.com> --- cpus.c | 27 ++- 1 file changed, 18 insertions(+), 9 deletions(-) diff --git a/cpus.c

Re: [Qemu-devel] [PATCH v2] qemu_mutex_iothread_locked not correctly synchronized

2015-11-25 Thread David Engraf
Am 25.11.2015 um 14:26 schrieb Paolo Bonzini: On 25/11/2015 13:31, David Engraf wrote: Hi Paolo, please check the new version. I removed changing the iothread_locked variable. But I still need to set the correct value of iothread_locked when using qemu_cond_wait. No, you don't. Who

[Qemu-devel] [PATCH] qemu_mutex_iothread_locked not correctly synchronized

2015-11-24 Thread David Engraf
. Signed-off-by: David Engraf <david.eng...@sysgo.com> --- cpus.c | 29 +++-- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/cpus.c b/cpus.c index 877bd70..d7cdd11 100644 --- a/cpus.c +++ b/cpus.c @@ -70,6 +70,8 @@ static CPUState *next_cpu; i