On Mon, Jul 08, 2024 at 04:59:30PM +0100, Peter Maydell wrote:
> On Mon, 8 Jul 2024 at 08:49, Nicholas Piggin wrote:
> >
> > On Sun Jul 7, 2024 at 9:46 AM AEST, David Gibson wrote:
> > > On Sat, Jul 06, 2024 at 11:37:08AM +0100, Peter Maydell wrote:
> > > >
On Mon, Jul 08, 2024 at 05:49:32PM +1000, Nicholas Piggin wrote:
> On Sun Jul 7, 2024 at 9:46 AM AEST, David Gibson wrote:
> > On Sat, Jul 06, 2024 at 11:37:08AM +0100, Peter Maydell wrote:
> > > On Fri, 5 Jul 2024 at 06:13, David Gibson
> > > wrote:
> > > >
On Sat, Jul 06, 2024 at 11:37:08AM +0100, Peter Maydell wrote:
> On Fri, 5 Jul 2024 at 06:13, David Gibson wrote:
> >
> > On Fri, Jul 05, 2024 at 02:40:19PM +1000, Nicholas Piggin wrote:
> > > On Fri Jul 5, 2024 at 11:41 AM AEST, David Gibson wrote:
> > > >
On Fri, Jul 05, 2024 at 02:40:19PM +1000, Nicholas Piggin wrote:
> On Fri Jul 5, 2024 at 11:41 AM AEST, David Gibson wrote:
> > On Fri, Jul 05, 2024 at 11:18:47AM +1000, Nicholas Piggin wrote:
> > > On Thu Jul 4, 2024 at 10:15 PM AEST, Peter Maydell wrote:
> > > >
On Fri, Jul 05, 2024 at 11:18:47AM +1000, Nicholas Piggin wrote:
> On Thu Jul 4, 2024 at 10:15 PM AEST, Peter Maydell wrote:
> > On Sat, 29 Jun 2024 at 04:17, David Gibson
> > wrote:
> > >
> > > On Fri, Jun 28, 2024 at 04:20:02PM +0100, Peter Maydell wrote:
>
On Thu, Jul 04, 2024 at 01:15:57PM +0100, Peter Maydell wrote:
> On Sat, 29 Jun 2024 at 04:17, David Gibson
> wrote:
> >
> > On Fri, Jun 28, 2024 at 04:20:02PM +0100, Peter Maydell wrote:
> > > On Thu, 27 Jun 2024 at 14:39, Akihiko Odaki
> > > wrote:
> &
better way to do what this is doing,
> but neither we (in system/device_tree.c) nor libfdt seem to
> provide one.
libfdt does provide unaligned access helpers (fdt32_ld() etc.), but
not an automatic aligned-or-unaligned helper. Maybe we should add that?
--
David Gibson (he or they)
On Thu, May 30, 2024 at 10:03:51AM +0100, Peter Maydell wrote:
> On Thu, 30 May 2024 at 01:52, David Gibson
> wrote:
> >
> > On Wed, May 29, 2024 at 02:07:18PM +0300, Oleg Sviridov wrote:
> > > Pointer, returned from function 'spapr_vio_find_by_reg', m
int i;
>
> +if (!dev) {
> +return H_PARAMETER;
> +}
> +
> for (i = 0; i < ETH_ALEN; i++) {
> dev->nicconf.macaddr.a[ETH_ALEN - i - 1] = macaddr & 0xff;
> macaddr >>= 8;
--
David Gibson| I'll h
gt; C.
>
>
>
> >
> > Cc: Cédric Le Goater
> > Cc: Daniel Henrique Barboza
> > Cc: David Gibson
> > Cc: Frédéric Barrat
> > Cc: Harsh Prateek Bora
> > Cc: Mahesh J Salgaonkar
> > Cc: Madhavan Srinivasan
> > Cc: Nicholas Piggin
41 */
> /* 42: PM, 44: PC RA, 46: SC vec'd */
> 0x80, 0x00, 0x80, 0x00, 0x80, 0x00, /* 42 - 47 */
> /* 48: SIMD, 50: QP BFP, 52: String */
--
David Gibson| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimal
/* 0: MMU|FPU|SLB|RUN|DABR|NX, 1: fri[nzpm]|DABRX|SPRG3|SLB0|PP110 */
> -/* 2: VPM|DS205|PPR|DS202|DS206, 3: LSD|URG, SSO, 5: LE|CFAR|EB|LSQ
> */
> -0xf6, 0x1f, 0xc7, 0xc0, 0x80, 0xf0, /* 0 - 5 */
> +/* 2: VPM|DS205|PPR|DS202|DS206, 3: LSD|URG, 5: LE|CFAR|EB|LS
2 @@ static target_ulong
> > h_set_mode_resource_set_ciabr(PowerPCCPU *cpu,
> > return H_SUCCESS;
> > }
> >
> > -static target_ulong h_set_mode_resource_set_dawr0(PowerPCCPU *cpu,
> > - SpaprMachineSt
}
> base = ppc_hash64_hpt_base(cpu);
> @@ -837,9 +831,7 @@ static void ppc_hash64_set_c(PowerPCCPU *cpu, hwaddr
> ptex, uint64_t pte1)
> hwaddr base, offset = ptex * HASH_PTE_SIZE_64 + HPTE64_DW1_C;
>
> if (cpu->vhyp) {
> -PPCVirtualHypervisorClass *
Odd Fixes
> F: target/ppc/kvm.c
>
> @@ -1502,7 +1500,6 @@ F: tests/avocado/ppc_prep_40p.py
> sPAPR (pseries)
> M: Nicholas Piggin
> R: Daniel Henrique Barboza
> -R: Cédric Le Goater
> R: David Gibson
> R: Harsh Prateek Bora
> L: qemu-...@nongnu.org
> "action is reset because the user never expressed a preference"
> and "action is reset because the user specifically asked for that",
> but I guess in theory we could make that distinction. (Conveniently
> there is no QMP action for "query current watchdog-act
On Tue, Jan 23, 2024 at 11:57:56AM +1000, Nicholas Piggin wrote:
> On Fri Jan 19, 2024 at 10:23 AM AEST, David Gibson wrote:
> > On Fri, Jan 19, 2024 at 12:09:36AM +1000, Nicholas Piggin wrote:
> > > SAO is a page table attribute that strengthens the memory ordering of
> &g
t; + * academic.
> + */
> +pa_features[4 + 2] &= ~0x80;
Oof.. I see the reasoning but modifying guest visible parameters based
on host capabilities without a cap really worries me nonetheless.
> +}
> +
> if (ppc_hash64_has(cpu, PPC_HASH64_CI_LA
gt; > ninja: build stopped: subcommand failed.
> > make: *** [Makefile:162: run-ninja] Error 1
> >
> > Signed-off-by: Juan Quintela
>
>
> Reviewed-by: Cédric Le Goater
I think changing the name of one of the functions would be even
better. Making it static mea
en: ['CONFIG_PSERIES', 'CONFIG_TCG'], if_true: files(
> - 'spapr_softmmu.c',
> + 'spapr_tcg.c',
> ))
> ppc_ss.add(when: 'CONFIG_SPAPR_RNG', if_true: files('spapr_rng.c'))
> ppc_ss.add(when: ['CO
} else if (tcg_enabled()) {
> -return softmmu_resize_hpt_commit(cpu, spapr, flags, shift);
> +return tcgppc_resize_hpt_commit(cpu, spapr, flags, shift);
> } else {
> g_assert_not_reached();
> }
--
David Gibson| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
uired knowledge and motivation to drive the boat.
>
> - Greg Kurz is being removed from all qemu-ppc entries. Greg has moved
> to other areas of interest and will retire from qemu-ppc. Thanks Mr
> Kurz for all the years of service.
>
> - David Gibson was removed as 'R
use here we don't care about
> KVM, we really want to test for TCG.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: David Gibson
> ---
> hw/ppc/spapr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
&
rent Vivier
Reviewed-by: David Gibson
> ---
> net/socket.c | 43 +--
> 1 file changed, 17 insertions(+), 26 deletions(-)
>
> diff --git a/net/socket.c b/net/socket.c
> index 6b1f0fec3a10..8e3702e1f3a8 100644
> --- a/net/socket.c
>
On Fri, 9 Jun 2023 09:27:47 +0200
Laurent Vivier wrote:
> Signed-off-by: Laurent Vivier
Reviewed-by: David Gibson
> ---
> net/socket.c | 28
> 1 file changed, 20 insertions(+), 8 deletions(-)
>
> diff --git a/net/socket.c b/net/socket.c
&g
Reviewed-by: David Gibson
> ---
> net/socket.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/net/socket.c b/net/socket.c
> index ba6e5b0b0035..24dcaa55bc46 100644
> --- a/net/socket.c
> +++ b/net/socket.c
> @@ -587,7 +587,7 @@ static int
On Wed, Dec 21, 2022 at 10:15:28PM +, Peter Maydell wrote:
> On Wed, 21 Dec 2022 at 16:03, Cédric Le Goater wrote:
> >
> > On 12/21/22 13:33, Peter Maydell wrote:
> > > On Wed, 21 Dec 2022 at 01:35, David Gibson
> > > wrote:
> > >> On Mon, De
> > The code is not consistent in another places :
> >
> > hw/ppc/spapr_tpm_proxy.c uses a uint64_t
> > hw/ppc/spapr_hcall.c, a target_ulong
> > hw/ppc/spapr_rtas.c, a hwaddr
> > hw/ppc/spapr_drc.c, a hwaddr indirectly
> >
> > Should we ch
On Mon, Dec 19, 2022 at 10:39:40AM +, Peter Maydell wrote:
> On Mon, 19 Dec 2022 at 06:35, David Gibson
> wrote:
> >
> > On Fri, Dec 16, 2022 at 09:39:19PM +, Peter Maydell wrote:
> > > On Fri, 16 Dec 2022 at 19:11, Daniel Henrique Barboza
> > > wrote
ndianness which can depend on a bunch of factors. When these
macros were created, an ISA nearly always used the same endianness,
but that's not really true any more - not just for POWER, but for a
bunch of targets. So from that point of view, I think getting rid of
tswap() - particular
the middle
> > of the 7.2 development cycle.
> >
>
> Great thanks Daniel for all your contributions over
> the years, and for being the one steering the vessel
> to the dry dock. This is it.
Seconded.
Reviewed-by: David Gibson
>
> > Change the status of PPC KVM
On Wed, Oct 05, 2022 at 06:20:39PM +0200, Laurent Vivier wrote:
> Embed the setting of info_str in a function.
>
> Signed-off-by: Laurent Vivier
Reviewed-by: David Gibson
> ---
> include/net/net.h | 1 +
> net/l2tpv3.c | 3 +--
> net/net.c | 17 +++
Stefano Brivio
> [lvivier: applied to net/stream.c]
> Signed-off-by: Laurent Vivier
> Reviewed-by: Daniel P. Berrangé
Reviewed-by: David Gibson
> ---
> net/stream.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/net/stream.c b/net/stream.c
>
no Brivio
> Signed-off-by: Laurent Vivier
Reviewed-by: David Gibson
> ---
> net/socket.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/net/socket.c b/net/socket.c
> index ade1ecf38b87..4944bb70d580 100644
> --- a/net/socket.c
>
On Wed, Oct 05, 2022 at 12:08:27PM +0200, Laurent Vivier wrote:
> On 9/28/22 07:55, David Gibson wrote:
> > > +static int net_stream_server_init(NetClientState *peer,
> > > + const char *model,
> > > +
On Wed, Oct 05, 2022 at 03:38:09PM +0200, Laurent Vivier wrote:
> On 9/28/22 08:12, David Gibson wrote:
> > > @@ -253,9 +253,27 @@ static void net_stream_accept(void *opaque)
> > > s->fd = fd;
> > > s->nc.link_down = false;
> > >
t
> > funded for this work.
> >
> > Signed-off-by: Cédric Le Goater
> > ---
>
> End of an era. Thank you for all the dedication and accomplishments !
Seconded.
Reviewed-by: David Gibson
>
> Reviewed-by: Greg Kurz
>
> > MAINTAINERS | 10 +-
gt; +break;
> +default:
> + error_setg(errp, "only support inet or fd type");
> +return -1;
> +}
> +
> +s = net_stream_fd_init_stream(peer, model, name, fd, connected);
> +
> +pstrcpy(s->nc.info_str, sizeof(s->nc.info_
On Mon, Sep 26, 2022 at 09:50:33PM +0200, Laurent Vivier wrote:
> Signed-off-by: Laurent Vivier
> Reviewed-by: Stefano Brivio
Reviewed-by: David Gibson
> ---
> include/qemu/sockets.h | 2 ++
> net/net.c | 62 ++
> 2
> Reviewed-by: Markus Armbruster
Reviewed-by: David Gibson
> ---
> include/net/net.h | 2 +-
> net/net.c | 6 ++
> softmmu/vl.c | 12 +++-
> 3 files changed, 6 insertions(+), 14 deletions(-)
>
> diff --git a/include/net/net.h b/include/net/ne
gt; Reviewed-by: Dr. David Alan Gilbert
> Reviewed-by: Markus Armbruster
Reviewed-by: David Gibson
> ---
> util/qemu-sockets.c | 7 ++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c
> index 9f6f655fd526..a9
On Mon, Sep 26, 2022 at 09:50:43PM +0200, Laurent Vivier wrote:
> Signed-off-by: Laurent Vivier
> Reviewed-by: Stefano Brivio
Reviewed-by: David Gibson
Although one note below.
> ---
> net/dgram.c | 65 ++---
> qapi/net.json
#or connect to (server=false)
> # @server: create server socket (default: true)
> #
> -# Only SocketAddress types 'inet' and 'fd' are supported.
> +# Only SocketAddress types 'unix', 'inet' and 'fd' are supported.
> #
>
;u.inet.port,
> errp) < 0) {
> @@ -492,9 +503,12 @@ static int net_dgram_init(NetClientState *peer,
> }
> qemu_socket_set_nonblock(fd);
>
> +dgram_dst = g_malloc(sizeof(raddr_in));
> +memcpy(dgram_dst, &raddr_in, sizeof(raddr_in));
> +
> info_str = g_strdup_printf("udp=%s:%d/%s:%d",
> - inet_ntoa(laddr_in.sin_addr), ntohs(laddr_in.sin_port),
> - inet_ntoa(raddr_in.sin_addr), ntohs(raddr_in.sin_port));
> +inet_ntoa(laddr_in.sin_addr),
> ntohs(laddr_in.sin_port),
> +inet_ntoa(raddr_in.sin_addr),
> ntohs(raddr_in.sin_port));
>
> break;
> }
> @@ -521,7 +535,8 @@ static int net_dgram_init(NetClientState *peer,
> }
>
> if (remote) {
> -s->dgram_dst = raddr_in;
> +g_assert(s->dgram_dst == NULL);
> +s->dgram_dst = dgram_dst;
>
> pstrcpy(s->nc.info_str, sizeof(s->nc.info_str), info_str);
> g_free(info_str);
--
David Gibson| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
} else {
> error_setg_errno(errp, errno, "can't connect socket");
--
David Gibson| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
s from a string.
>
> Signed-off-by: Laurent Vivier
Reviewed-by: David Gibson
> ---
> include/qemu/sockets.h | 2 +-
> monitor/hmp-cmds.c | 23 +--
> util/qemu-sockets.c| 20
> 3 files changed, 22 insertions(+), 23 deletio
'inet' and 'fd' are supported.
> +# Only SocketAddress types 'unix', 'inet' and 'fd' are supported.
> #
> # Since: 7.1
> ##
> diff --git a/qemu-options.hx b/qemu-options.hx
> index bb16a61bae8e..8870bcce6bcd 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -2733,6 +2733,7 @@ DEF("netdev", HAS_ARG, QEMU_OPTION_netdev,
> "configure a network backend to connect to another
> network\n"
> "using an UDP tunnel\n"
> "-netdev
> stream,id=str[,server=on|off],addr.type=inet,addr.host=host,addr.port=port\n"
> +"-netdev stream,id=str[,server=on|off],addr.type=unix,addr.path=path\n"
> "-netdev stream,id=str[,server=on|off],addr.type=fd,addr.str=h\n"
> "configure a network backend to connect to another
> network\n"
> "using a socket connection in stream mode.\n"
--
David Gibson| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
d.str, errp);
> +if (fd == -1) {
> +return -1;
> +}
> +ret = qemu_socket_try_set_nonblock(fd);
> +if (ret < 0) {
> + error_setg_errno(errp, -ret, "%s: Can't use file descriptor %d",
> +
vier
> Reviewed-by: Markus Armbruster
Reviewed-by: David Gibson
> ---
> include/net/net.h | 2 +-
> net/net.c | 20 +++-
> softmmu/vl.c | 2 +-
> 3 files changed, 9 insertions(+), 15 deletions(-)
>
> diff --git a/include/net/net.h b/include/
> Reviewed-by: Markus Armbruster
Reviewed-by: David Gibson
> ---
> include/net/net.h | 2 +-
> net/net.c | 6 ++
> softmmu/vl.c | 12 +++-
> 3 files changed, 6 insertions(+), 14 deletions(-)
>
> diff --git a/include/net/net.h b/include/net/ne
On Tue, Sep 13, 2022 at 08:39:47AM +0200, Laurent Vivier wrote:
> Signed-off-by: Laurent Vivier
> Reviewed-by: Stefano Brivio
Reviewed-by: David Gibson
Although, if you do respin, an actual commit message would be nice to
have.
> ---
> include/qemu/sockets.h | 2 ++
On Tue, Aug 30, 2022 at 12:43:23PM +0200, Markus Armbruster wrote:
> David Gibson writes:
>
> > On Mon, Aug 29, 2022 at 07:00:55PM -0300, Daniel Henrique Barboza wrote:
> >>
> >>
> >> On 8/29/22 00:34, David Gibson wrote:
> >> > On Fri, Aug 26
On Mon, Aug 22, 2022 at 07:30:36AM -0300, Daniel Henrique Barboza wrote:
>
>
> On 8/22/22 00:29, Alexey Kardashevskiy wrote:
> >
> >
> > On 22/08/2022 13:05, David Gibson wrote:
> > > On Fri, Aug 19, 2022 at 06:42:34AM -0300, Daniel Henrique Barboza wrote:
On Mon, Aug 29, 2022 at 07:00:55PM -0300, Daniel Henrique Barboza wrote:
>
>
> On 8/29/22 00:34, David Gibson wrote:
> > On Fri, Aug 26, 2022 at 11:11:44AM -0300, Daniel Henrique Barboza wrote:
> > > Reading the FDT requires that the user saves the fdt_blob and then use
void *fdt = current_machine->fdt;
> +int padding = depth * 4;
> +int property = 0;
> +int prop_size;
> +
> +g_string_append_printf(buf, "%*s%s {\n", padding, "",
> + fdt_get_name(fdt, nod
dt property / dumpdtb etc. as
describing specifically the boot time DT before guest firmware or OS
does any further mangling of it. That's effectively what it means for
all the other embedded cases, though in those cases the firmware
usually doesn't need to do further modifications, unlike a
I suspect what Alexey was suggesting though, was merely to make
ms::fdt accessible as a single bytestring property on the machine QOM
object. Effectively it's just "dumpdtb" but as a property get.
I'm not 100% certain if QOM can safely repre
uot; etc. obviously have additional funtionality in formatting
the contents more helpfully.
> Another thing is that on every HMP dump I'd probably rebuild the entire FDT
> for the reasons David explained. Thanks,
This would require per-machine hooks, however.
--
David Gibson
On Mon, Aug 15, 2022 at 07:48:14PM -0300, Daniel Henrique Barboza wrote:
>
>
> On 8/8/22 01:21, David Gibson wrote:
> > On Fri, Aug 05, 2022 at 06:39:43AM -0300, Daniel Henrique Barboza wrote:
> > > Reading the FDT requires that the user saves the fdt_blob and then use
1, ram_high_sz);
> >> +fdt_pack(fdt);
> >> fdt = g_realloc(fdt, fdt_totalsize(fdt));
> >> qemu_fdt_dumpdtb(fdt, fdt_sz);
> >>
> >
> > Why not pack by default in qemu_fdt_dumpdtb()?
>
> qemu_fdt_dumpdtb() is exp
dt) {
> error_setg(errp, "Unable to find the machine FDT");
> return NULL;
> }
>
> -node = fdt_path_offset(current_machine->fdt, nodepath);
> +node = fdt_path_offset(fdt, nodepath);
> if (node < 0) {
> error_setg(errp, "n
t; directly like that to save some clutter. No functional change intended.
>
> Signed-off-by: Matheus Ferst
Good idea.
Reviewed-by: David Gibson
> ---
> hw/ppc/ppc.c | 10 +++---
> hw/ppc/trace-events | 2 +-
> target/ppc/cpu.h | 40 +++-
buf, int node, int depth)
> {
> const struct fdt_property *prop = NULL;
> @@ -681,7 +738,12 @@ static void fdt_format_node(GString *buf, int node, int
> depth)
> prop = fdt_get_property_by_offset(fdt, property, &prop_size);
> propname = fdt_string(fdt, fdt32_to_cpu(prop->nameoff));
>
> -g_string_append_printf(buf, "%*s%s;\n", padding, "", propname);
> +if (fdt_prop_is_string_array(prop->data, prop_size)) {
> +fdt_prop_format_string_array(buf, propname, prop->data,
> + prop_size, padding);
> +} else {
> +g_string_append_printf(buf, "%*s%s;\n", padding, "", propname);
> +}
> }
>
> padding -= 4;
--
David Gibson| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
; +}
> +
> padding -= 4;
> g_string_append_printf(buf, "%*s}\n", padding, "");
> }
> @@ -821,7 +834,7 @@ HumanReadableText *qemu_fdt_qmp_query_fdt(const char
> *nodepath, Error **errp)
> return NULL;
> }
>
> -fd
gt; spapr->fdt_initial_size = spapr->fdt_size;
> spapr->fdt_blob = fdt;
>
> +/*
> + * Set the machine->fdt pointer again since we just freed
> + * it above (by freeing spapr->fdt_blob). We set this
> + * pointer to enable support for 'dumpdtb' and &
On Fri, Aug 12, 2022 at 07:23:09PM -0300, Daniel Henrique Barboza wrote:
>
>
> On 8/8/22 00:26, David Gibson wrote:
> > On Fri, Aug 05, 2022 at 06:39:38AM -0300, Daniel Henrique Barboza wrote:
> > > The pSeries machine never bothered with the common machine->fdt
>
On Fri, Aug 12, 2022 at 07:03:26PM -0300, Daniel Henrique Barboza wrote:
> David,
>
> On 8/8/22 00:23, David Gibson wrote:
> > On Fri, Aug 05, 2022 at 06:39:29AM -0300, Daniel Henrique Barboza wrote:
> > > At this moment, arm_load_dtb() can free machine->fdt when
> &
On Wed, Aug 10, 2022 at 04:40:18PM -0300, Daniel Henrique Barboza wrote:
>
>
> On 8/8/22 01:36, David Gibson wrote:
> > On Fri, Aug 05, 2022 at 06:39:44AM -0300, Daniel Henrique Barboza wrote:
> > > To support printing string properties in 'info fdt' we need
; +propname = fdt_string(fdt, fdt32_to_cpu(prop->nameoff));
> +
> +g_string_append_printf(buf, "%*s%s;\n", padding, "", propname);
> +}
> +
> +padding -= 4;
> +g_string_append_printf(buf, "%*s}\n", padding, "");
So
s%s = '%s'\n",
> + padding, "", propname, prop->data);
If you're going for dts like output, I'd suggest going all the way.
That means \" instead of \' and a ';' at the end of the line.
> +} else {
> +g_string_append_printf(buf, "%*s%s;\n", padding, "", propname);
> +}
> }
>
> padding -= 4;
--
David Gibson| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
adding, "", propname);
> +continue;
> +}
> +
> if (fdt_prop_is_string(prop->data, prop_size)) {
> g_string_append_printf(buf, "%*s%s = '%s'\n",
> padding, "", pro
ry?
>
> hmmm I think it's possible if we issue a 'system_reset' via the
> monitor.
Right. I'm not certain about pnv, but on most platforms there's a way
to trigger system_reset from the guest side as well.
> I'll put a g_free(machine->fdt) before the assignment.
ms->fdt = fdt;
>
> return size;
fdt_pack() could change (reduce) the effective size of the dtb blob,
so returning a 'size' value from above rather than the new value of
fdt_totalsize(fdt) doesn't see right.
I believe some of the other patches in the series hav
e just freed
> + * it above (by freeing spapr->fdt_blob). We set this
> + * pointer to enable support for 'dumpdtb' and 'info fdt'
> + * HMP commands.
> + */
> +MACHINE(spapr)->fdt = fdt;
> +
> return H_SUCCESS;
> }
>
--
David Gibson| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
quot;arguments": { "filename": "/tmp/fdt.dtb" } }
> +#
> +##
> +{ 'command': 'dumpdtb',
> + 'data': { 'filename': 'str' } }
> diff --git a/softmmu/device_tree.c b/softmmu/device_tree.c
> index 6c
osas
Reviewed-by: David Gibson
and, I believe, mea culpa.
> ---
> v2:
> - Skip current and parent directories.
>
> v1:
> https://lore.kernel.org/qemu-devel/20220711193743.51456-1-muri...@linux.ibm.com/
>
> target/ppc/kvm.c | 6 ++
> 1 file changed, 6 insertio
)
> > - " DECR " TARGET_FMT_lu
> > + " DECR " TARGET_FMT_lu
> > #endif
> > - "\n",
> > - cpu_ppc_load_tbu(env), cpu_ppc_load_tbl(env)
> > + "\n
ing problems now, but it would be technically more
correct to also skip ".", wouldn't it?
> +continue;
> +}
> +
> snprintf(buf, buf_len, "%s%s/clock-frequency", PROC_DEVTREE_CPU,
> dirp->d_name);
>
On Thu, Apr 14, 2022 at 03:46:59AM -0700, Yi Liu wrote:
> Qomify the VFIOContainer object which acts as a base class for a
> container. This base class is derived into the legacy VFIO container
> and later on, into the new iommufd based container.
You certainly need the abstraction, but I'm not su
{
> +error_report("papr_scm: Could not find nvdimm device with DRC 0x%u",
> + state->drcidx);
> +return;
> +}
> +
> +s_nvdimm = SPAPR_NVDIMM(drc->dev);
>
> state->hcall_ret = hcall_ret;
> QLIST_REMOVE(state, node);
--
David Gibson| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
w
valgrind to get the benefits.
> More generally, how much use is running QEMU with KVM enabled
> under valgrind anyway? Valgrind has no way of knowing about
> writes to memory that the guest vCPUs do...
Those should be limited to the guest memory area though, which as
mmap()ed space would a
e in the
> function but it will bring benefit for its other callers.
>
> This patch uses the memcheck VALGRING_MAKE_MEM_DEFINED() to mark the
> 'target' variable as initialized if the ioctl is successful.
>
> Cc: Paolo Bonzini
> Signed-off-by: Daniel Henrique Barboz
is annotation inside kvm_get_one_reg, so that it
> > covers all kvm hosts. But it's too late to do this for 7.0.
>
> I wasn't planning on pushing these changes for 7.0 since they aren't fixing
> mem
> leaks or anything really bad. It's more of a quality of
On Thu, Mar 31, 2022 at 02:17:42PM -0300, Daniel Henrique Barboza wrote:
>
>
> On 3/30/22 22:25, David Gibson wrote:
> > On Wed, Mar 30, 2022 at 09:17:15PM -0300, Daniel Henrique Barboza wrote:
> > > 'lpcr' is used as an input of kvm_get_one_reg(). Valgrind do
On Mon, Mar 14, 2022 at 07:10:10PM -0300, Fabiano Rosas wrote:
> David Gibson writes:
>
> > On Tue, Mar 08, 2022 at 10:23:59PM -0300, Fabiano Rosas wrote:
> >> QEMU reports MMU support to the guest via the ibm,architecture-vec-5
> >> property of the /chosen node.
t lpcr;
> + uint64_t lpcr = 0;
>
> kvm_get_one_reg(cs, KVM_REG_PPC_LPCR_64, &lpcr);
> /* Do we need to modify the LPCR? */
--
David Gibson| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
> ==707578==at 0xB11F08: kvm_get_one_spr (kvm.c:543)
>
> Initializing 'val' has no impact in the logic and makes Valgrind output
> more bearable.
>
> Reviewed-by: Philippe Mathieu-Daudé
> Signed-off-by: Daniel Henrique Barboza
Reviewed-by: David Gibson
>
9B: qdev_realize (qdev.c:333)
> ==636935==
>
> This patch adds a cpu_ppc_tb_free() helper in hw/ppc/ppc.c to allow us
> to free the timebase. This leak is then solved by calling
> cpu_ppc_tb_free() in spapr_unrealize_vcpu().
>
> Fixes: 6f4b5c3ec590 ("spapr: CPU hot unplug s
aniel Henrique Barboza (2):
> hw/ppc/ppc.c: add cpu_ppc_tb_free()
> hw/ppc: free env->tb_env in spapr_unrealize_vcpu()
>
> hw/ppc/ppc.c| 7 +++
> hw/ppc/spapr_cpu_core.c | 3 +++
> include/hw/ppc/ppc.h| 1 +
> 3 files changed, 11 insertions(+)
>
v->excp_model == POWERPC_EXCP_POWER10) {
> > +attn = !!(env->spr[SPR_HID0] & HID0_POWER9_ATTN);
> > +}
>
> The excp_model is not a CPU identifier. This should ideally be a flag
> set during init_proc. Something like HID0_ATTN_P8/HID0_ATTN_P9.
>
t;unrealize = unrealize_physical;
> +dk->vmsd = &vmstate_spapr_drc_physical;
> +
> drck->dr_entity_sense = physical_entity_sense;
> drck->isolate = drc_isolate_physical;
> drck->unisolate = drc_unisolate_physical;
--
David Gibson| I'
d when testing migration scenarios with
> hotplug/unplug of devices.
Looks good tome.
--
David Gibson| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
On Mon, Mar 21, 2022 at 04:58:47AM -0300, Daniel Henrique Barboza wrote:
>
>
> On 3/21/22 00:55, David Gibson wrote:
> > On Fri, Mar 18, 2022 at 02:33:11PM -0300, Daniel Henrique Barboza wrote:
> > > Hi,
> > >
> > > I decided to make this chang
On Fri, Mar 18, 2022 at 10:41:19AM -0300, Fabiano Rosas wrote:
> David Gibson writes:
>
> > On Thu, Mar 17, 2022 at 02:20:47PM -0300, Fabiano Rosas wrote:
> >> It is possible that nested KVM hypercalls reach QEMU while we're
> >> running KVM. The spapr virtu
| 18 -
> hw/ppc/spapr_drc.c | 79 +++---
> hw/ppc/spapr_events.c | 4 +-
> hw/ppc/spapr_nvdimm.c | 10 ++---
> hw/ppc/spapr_pci.c | 5 +--
> include/hw/ppc/spapr_drc.h | 2 +-
> 6 files changed, 48 insertio
On Fri, Mar 18, 2022 at 04:51:10PM -0300, Daniel Henrique Barboza wrote:
>
>
> On 3/18/22 00:43, David Gibson wrote:
> > On Thu, Mar 17, 2022 at 04:29:14PM +, Dr. David Alan Gilbert wrote:
> > > * Peter Maydell (peter.mayd...@linaro.org) wrote:
> > > >
rcall(KVMPPC_H_UPDATE_DT, h_update_dt);
> -
> -spapr_register_hypercall(KVMPPC_H_SET_PARTITION_TABLE, h_set_ptbl);
> -spapr_register_hypercall(KVMPPC_H_ENTER_NESTED, h_enter_nested);
> -spapr_register_hypercall(KVMPPC_H_TLB_INVALIDATE, h_tlb_invalidate);
> -s
ith the same name, and no bus for them to be named by, then
> the instance_id is used to uniquify them.
Thanks for the information. I remember deciding at the time that just
using vmsd wouldn't work for the DRCs because we needed this fixed
index. At the time either qdev_set_legacy_
; +if (!tcg_enabled()) {
> +return H_FUNCTION;
> +}
> +
> if (spapr->nested_ptcr == 0) {
> return H_NOT_AVAILABLE;
> }
--
David Gibson| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
Class *pcc, uint32_t pvr)
> {
> -if ((pvr & CPU_POWERPC_POWER_SERVER_MASK) == CPU_POWERPC_POWER10_BASE) {
> +uint32_t base = pvr & CPU_POWERPC_POWER_SERVER_MASK;
> +uint32_t pcc_base = pcc->pvr & CPU_POWERPC_POWER_SERVER_MASK;
> +
> +if (base != pcc_ba
1 - 100 of 5262 matches
Mail list logo
