On Tue, Mar 5, 2019 at 6:18 PM David Kiarie wrote:
> Signed-off-by: David Kiarie
> ---
> hw/i386/amd_iommu.c | 2 +-
> hw/i386/amd_iommu.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c
> index
On Tue, Mar 5, 2019 at 6:18 PM David Kiarie wrote:
also, i have a strange preference for this patch as it looks like the right
thing to do if parties are not able to update copyright notices.
On Tue, Mar 5, 2019 at 5:36 PM David Kiarie wrote:
> i hope you don't find this offensive, Eric but i'm forwarding this message
> to all the people on this thread.
>
> i don't find anything exactly private in this email.
>
> [off-list]
>
> On 3/4/19 1:20 PM, David Kiarie
Signed-off-by: David Kiarie
---
hw/i386/amd_iommu.c | 2 +-
hw/i386/amd_iommu.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c
index 8ad707a..6eabdf9 100644
--- a/hw/i386/amd_iommu.c
+++ b/hw/i386/amd_iommu.c
@@ -2,7 +2,7
Signed-off-by: David Kiarie
---
hw/i386/Makefile.objs |1 -
hw/i386/acpi-build.c | 84 +--
hw/i386/amd_iommu.c | 1645 -
hw/i386/amd_iommu.h | 373 --
hw/i386/pc_q35.c |2 -
hw/i386/trace-events | 43 --
6 files changed, 1
i hope you don't find this offensive, Eric but i'm forwarding this message
to all the people on this thread.
i don't find anything exactly private in this email.
[off-list]
On 3/4/19 1:20 PM, David Kiarie wrote:
> On Mon, Mar 4, 2019 at 8:48 PM Philippe Mathieu-Daudé
> wrote:
>
>&
On Tue, Mar 5, 2019 at 5:16 PM David Kiarie wrote:
>
>
> On Mon, Mar 4, 2019 at 11:52 PM Eric Blake wrote:
>
>> On 3/4/19 9:18 AM, David Kiarie wrote:
>> > i think it is best put as i've updated.
>> >
>> > David Kiarie (1):
>> >updat
On Mon, Mar 4, 2019 at 11:52 PM Eric Blake wrote:
> On 3/4/19 9:18 AM, David Kiarie wrote:
> > i think it is best put as i've updated.
> >
> > David Kiarie (1):
> >update copyright notice
> >
> > hw/i386/amd_iommu.c | 2 +-
> > hw/i38
>
> IANAL and I have no knowledge of IOMMU indeed.
> I noticed first this patch is sent from the same email used in this
> copyright notice, then the patch content merged in commit d29a09ca684
> was accepted in 2016 with a copyright date of 2015, hence your copyright
> modification looks correct
On Mon, Mar 4, 2019 at 10:29 PM David Kiarie wrote:
>
>
> On Mon, Mar 4, 2019 at 10:20 PM David Kiarie
> wrote:
>
>>
>>
>> On Mon, Mar 4, 2019 at 8:48 PM Philippe Mathieu-Daudé
>> wrote:
>>
>>> On 3/4/19 4:18 PM, David Kiarie wrot
On Mon, Mar 4, 2019 at 10:20 PM David Kiarie wrote:
>
>
> On Mon, Mar 4, 2019 at 8:48 PM Philippe Mathieu-Daudé
> wrote:
>
>> On 3/4/19 4:18 PM, David Kiarie wrote:
>> > Signed-off-by: David Kiarie
>>
>> Reviewed-by: Philippe Mathieu-Daudé
>>
>>>
>>> On 3/4/19 4:18 PM, David Kiarie wrote:
>>>> > Signed-off-by: David Kiarie
>>>>
>>>> Reviewed-by: Philippe Mathieu-Daudé
>>>>
>>>
>>> would i be wrong to say this patch received unwarranted scrutiny fr
On Mon, Mar 4, 2019 at 8:48 PM Philippe Mathieu-Daudé
wrote:
> On 3/4/19 4:18 PM, David Kiarie wrote:
> > Signed-off-by: David Kiarie
>
> Reviewed-by: Philippe Mathieu-Daudé
>
would i be wrong to say this patch received unwarranted scrutiny from you,
Philippe?
&g
>
>
>>>>
>>>> On 04/03/2019 16.13, David Kiarie wrote:
>>>>> >
>>>>> > Hi David,
>>>>> >
>>>>> > On 2
On Mon, Mar 4, 2019 at 6:32 PM David Kiarie wrote:
>
>
> On Mon, Mar 4, 2019 at 6:27 PM David Kiarie
> wrote:
>
>>
>>
>> On Mon, Mar 4, 2019 at 6:23 PM Thomas Huth wrote:
>>
>>> On 04/03/2019 16.13, David Kiarie wrote:
On Mon, Mar 4, 2019 at 6:33 PM David Kiarie wrote:
>
>
> On Mon, Mar 4, 2019 at 6:32 PM David Kiarie
> wrote:
>
>>
>>
>> On Mon, Mar 4, 2019 at 6:27 PM David Kiarie
>> wrote:
>>
>>>
>>>
>>> On Mon, Mar 4, 2019 at 6:23
On Mon, Mar 4, 2019 at 6:27 PM David Kiarie wrote:
>
>
> On Mon, Mar 4, 2019 at 6:23 PM Thomas Huth wrote:
>
>> On 04/03/2019 16.13, David Kiarie wrote:
>> >
>> > Hi David,
>> >
>> >
On Mon, Mar 4, 2019 at 6:23 PM Thomas Huth wrote:
> On 04/03/2019 16.13, David Kiarie wrote:
> >
> > Hi David,
> >
> > On 2/23/19 11:54 AM, David Kiarie wrote:
> >
On Mon, Mar 4, 2019 at 6:13 PM David Kiarie wrote:
>
>
>
>>>>>>>
>>>>>>> Hi David,
>>>>>>>>
>>>>>>>> On 2/23/19 11:54 AM, David Kiarie wrote:
>>>>>>>> > Signed-off-by:
On Mon, Mar 4, 2019 at 6:22 PM David Kiarie wrote:
>
>
> On Mon, Mar 4, 2019 at 6:13 PM David Kiarie
> wrote:
>
>>
>>
>>
>>>>>>>>
>>>>>>>> Hi David,
>>>>>>>>>
>>>>>
Signed-off-by: David Kiarie
---
hw/i386/amd_iommu.c | 2 +-
hw/i386/amd_iommu.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c
index 8ad707a..6eabdf9 100644
--- a/hw/i386/amd_iommu.c
+++ b/hw/i386/amd_iommu.c
@@ -2,7 +2,7
i think it is best put as i've updated.
David Kiarie (1):
update copyright notice
hw/i386/amd_iommu.c | 2 +-
hw/i386/amd_iommu.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--
2.21.0
>>>>>>
>>>>>> Hi David,
>>>>>>>
>>>>>>> On 2/23/19 11:54 AM, David Kiarie wrote:
>>>>>>> > Signed-off-by: David Kiarie
>>>>>>> > ---
>>>>>>> >
On Mon, Mar 4, 2019 at 5:40 PM David Kiarie wrote:
>
>
> On Mon, Mar 4, 2019 at 5:36 PM David Kiarie
> wrote:
>
>>
>>
>> On Mon, Mar 4, 2019 at 5:10 PM David Kiarie
>> wrote:
>>
>>>
>>>
>>> On Mon, Mar 4, 2019 at 4:42 PM
On Mon, Mar 4, 2019 at 5:36 PM David Kiarie wrote:
>
>
> On Mon, Mar 4, 2019 at 5:10 PM David Kiarie
> wrote:
>
>>
>>
>> On Mon, Mar 4, 2019 at 4:42 PM David Kiarie
>> wrote:
>>
>>>
>>>
>>> On Mon, Mar 4, 2019 at 3:57 PM
On Mon, Mar 4, 2019 at 5:10 PM David Kiarie wrote:
>
>
> On Mon, Mar 4, 2019 at 4:42 PM David Kiarie
> wrote:
>
>>
>>
>> On Mon, Mar 4, 2019 at 3:57 PM David Kiarie
>> wrote:
>>
>>>
>>>
>>> On Mon, Mar 4, 2019 at 2:57 PM
On Mon, Mar 4, 2019 at 4:42 PM David Kiarie wrote:
>
>
> On Mon, Mar 4, 2019 at 3:57 PM David Kiarie
> wrote:
>
>>
>>
>> On Mon, Mar 4, 2019 at 2:57 PM Philippe Mathieu-Daudé
>> wrote:
>>
>>> Hi David,
>>>
>>> On
On Mon, Mar 4, 2019 at 3:57 PM David Kiarie wrote:
>
>
> On Mon, Mar 4, 2019 at 2:57 PM Philippe Mathieu-Daudé
> wrote:
>
>> Hi David,
>>
>> On 2/23/19 11:54 AM, David Kiarie wrote:
>> > Signed-off-by: David Kiarie
>> > ---
>> &g
On Mon, Mar 4, 2019 at 2:57 PM Philippe Mathieu-Daudé
wrote:
> Hi David,
>
> On 2/23/19 11:54 AM, David Kiarie wrote:
> > Signed-off-by: David Kiarie
> > ---
> > hw/i386/amd_iommu.c | 2 +-
> > hw/i386/amd_iommu.h | 2 +-
> > 2 files changed, 2 insertion
On Mon, Mar 4, 2019 at 2:45 PM Paolo Bonzini wrote:
> On 04/03/19 12:22, David Kiarie wrote:
> >
> >
> >
> > On Mon, Feb 25, 2019 at 1:39 PM Daniel P. Berrangé > <mailto:berra...@redhat.com>> wrote:
> >
> > On Sat, Feb 23, 2019 at 01:54:2
On Mon, Mar 4, 2019 at 2:22 PM David Kiarie wrote:
>
>
>
> On Mon, Feb 25, 2019 at 1:39 PM Daniel P. Berrangé
> wrote:
>
>> On Sat, Feb 23, 2019 at 01:54:21PM +0300, David Kiarie wrote:
>> > Signed-off-by: David Kiarie
>> > ---
>> > hw/i3
On Mon, Feb 25, 2019 at 1:39 PM Daniel P. Berrangé
wrote:
> On Sat, Feb 23, 2019 at 01:54:21PM +0300, David Kiarie wrote:
> > Signed-off-by: David Kiarie
> > ---
> > hw/i386/amd_iommu.c | 2 +-
> > hw/i386/amd_iommu.h | 2 +-
> > 2 files changed, 2 insertion
update copyright notice to reflect my full legal name. looks better to
me that way.
also, that way people are not under the impression i *own* qemu AMD
IOMMU.
thanks.
David Kiarie (1):
hw/i386: update copyright notice
hw/i386/amd_iommu.c | 2 +-
hw/i386/amd_iommu.h | 2 +-
2 files changed
Signed-off-by: David Kiarie
---
hw/i386/amd_iommu.c | 2 +-
hw/i386/amd_iommu.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c
index 8ad707a..4f179da 100644
--- a/hw/i386/amd_iommu.c
+++ b/hw/i386/amd_iommu.c
@@ -2,7 +2,7
On Mon, Feb 18, 2019 at 9:59 PM David Kiarie wrote:
>
>
>> >
>> > 3. And this might be something specific to my AMD IOMMU (1022:1437,
>> Family
>> > 16h), but the PS4 OS is checks the entire word stored in these registers
>> > and computes th
On Thu, Feb 21, 2019 at 7:09 PM Jan Kiszka wrote:
> On 21.02.19 17:05, Eric Blake wrote:
> > On 2/21/19 9:53 AM, David Kiarie wrote:
> >> the occurrence of my name and email on the files below may have led to
> >> some confusion in the reporting of a few recent bugs.
On Thu, Feb 21, 2019 at 8:04 PM David Kiarie wrote:
> i personally mostly don't care what someone does with the code i wrote
> but i mostly had this since everyone else was doing it but the presence
> of the email on the file led to some recent confusion and i will
> therefore d
On Thu, Feb 21, 2019 at 8:35 PM Philippe Mathieu-Daudé
wrote:
> On 2/21/19 6:13 PM, Markus Armbruster wrote:
>
> >
> > Can we resync with the kernel's script to get this feature? Or should
> > we cherry-pick it?
>
> I think we are out-of-sync and only cherry-picking.
>
you can do this if you
Signed-off-by: David Kiarie
---
hw/i386/amd_iommu.c | 2 +-
hw/i386/amd_iommu.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c
index 8ad707a..bb3f5e5 100644
--- a/hw/i386/amd_iommu.c
+++ b/hw/i386/amd_iommu.c
@@ -2,7 +2,7
i personally mostly don't care what someone does with the code i wrote
but i mostly had this since everyone else was doing it but the presence
of the email on the file led to some recent confusion and i will
therefore drop it.
thanks.
David Kiarie (1):
hw/i386: drop my email from copyright
i will just drop the email.
thanks.
On Thu, Feb 21, 2019 at 7:19 PM Daniel P. Berrangé
wrote:
> On Thu, Feb 21, 2019 at 06:53:59PM +0300, David Kiarie wrote:
>
> Note, patches to QEMU are required to have a signed-off-by line in the
> commit message with name + email address to indicate your contribution
> follows
)
*
* Copyright (C) 2011 Eduard - Gabriel Munteanu
- * Copyright (C) 2015 David Kiarie,
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
diff --git a/hw/i386/amd_iommu.h b/hw/i386/amd_iommu.h
index c52886f
the occurrence of my name and email on the files below may have led to
some confusion in the reporting of a few recent bugs.
i have therefore choosen to snip it.
David Kiarie (1):
hw/i386: snip my name and email
hw/i386/amd_iommu.c | 1 -
hw/i386/amd_iommu.h | 1 -
2 files changed, 2
>
> >
> > 3. And this might be something specific to my AMD IOMMU (1022:1437,
> Family
> > 16h), but the PS4 OS is checks the entire word stored in these registers
> > and computes the expression as:
> > config[AMDVI_CAPAB_BAR_LOW] | cap[AMDVI_CAPAB_BAR_HIGH] << 32
> > So just storing half words
On Sat, Feb 16, 2019 at 10:11 PM David Kiarie
wrote:
>
>
> -- Forwarded message -
> From: Alexandro Sánchez Bach
> Date: Wed, Jan 31, 2018 at 2:29 AM
> Subject: QEMU: AMD IOMMU implementation bugs
> To:
>
>
> Hey David,
>
> hello Mr Ale
-- Forwarded message -
From: Alexandro Sánchez Bach
Date: Wed, Jan 31, 2018 at 2:29 AM
Subject: QEMU: AMD IOMMU implementation bugs
To:
Hey David,
hello Mr Alexandro Sanchez Bach,
I'm working with your AMD IOMMU implementation since I'm writing a
PlayStation 4 emulator. I
On Mon, Oct 10, 2016 at 11:34 AM, Paolo Bonzini <pbonz...@redhat.com> wrote:
>
>
> On 10/10/2016 00:11, Michael S. Tsirkin wrote:
>> On Tue, Sep 20, 2016 at 08:40:41PM +0300, David Kiarie wrote:
>>> When using IOMMU platform devices like IOAPIC are required to make
&g
Signed-off-by: David Kiarie <davidkiar...@gmail.com>
---
hw/i386/amd_iommu.c | 22 +-
1 file changed, 13 insertions(+), 9 deletions(-)
diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c
index 023de52..47b79d9 100644
--- a/hw/i386/amd_iommu.c
+++ b/hw/i386/amd_i
The following patch fixes a few issues reported by Coverity in the file
hw/i386/amd_iommu.c
V3 includes fixes and suggestions from Paolo and Stefan.
David Kiarie (1):
hw/iommu: Fix problems reported by Coverity scan
hw/i386/amd_iommu.c | 22 +-
1 file changed, 13
Signed-off-by: David Kiarie <davidkiar...@gmail.com>
---
hw/i386/amd_iommu.c | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c
index 023de52..886c72b 100644
--- a/hw/i386/amd_iommu.c
+++ b/hw/i386/amd_iommu.c
@@
This patch fixes a few issues reported by coverity scan in file
hw/i386/amd_iommu.c
V2 includes a fix and suggestion from Stefan Weil.
David Kiarie (1):
hw/iommu: Fix problems reported by Coverity scan
hw/i386/amd_iommu.c | 16 ++--
1 file changed, 10 insertions(+), 6 deletions
On Fri, Sep 30, 2016 at 4:57 PM, David Kiarie <davidkiar...@gmail.com> wrote:
> On Fri, Sep 30, 2016 at 4:55 PM, Paolo Bonzini <pbonz...@redhat.com> wrote:
>>
>>
>> On 20/09/2016 17:42, David Kiarie wrote:
>>> Hi all,
>>>
>>>
On Sat, Oct 1, 2016 at 7:29 PM, Stefan Weil <s...@weilnetz.de> wrote:
> Hi,
>
>
> On 10/01/16 17:57, David Kiarie wrote:
>>
>> Signed-off-by: David Kiarie <davidkiar...@gmail.com>
>> ---
>> hw/i386/amd_iommu.c | 12
>> 1 file cha
Signed-off-by: David Kiarie <davidkiar...@gmail.com>
---
hw/i386/amd_iommu.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c
index 023de52..815d45f 100644
--- a/hw/i386/amd_iommu.c
+++ b/hw/i386/amd_iommu.c
@@
Hi all,
The following patch fixes a few issues reported by coverity in the file
hw/i386/amd_iommu.c
David Kiarie (1):
hw/iommu: Fix problems reported by Coverity scan
hw/i386/amd_iommu.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
--
2.1.4
On Fri, Sep 30, 2016 at 4:55 PM, Paolo Bonzini <pbonz...@redhat.com> wrote:
>
>
> On 20/09/2016 17:42, David Kiarie wrote:
>> Hi all,
>>
>> This patchset adds basic AMD IOMMU emulation support to Qemu.
>>
>> Resent this with some changes suggested by Mi
On Tue, Sep 20, 2016 at 8:40 PM, David Kiarie <davidkiar...@gmail.com> wrote:
> Hello all,
>
> This patchset mainly adds AMD IOMMU interrupt remapping logic to Qemu. Doing
> that
> I have solved an existing issue where platform devices are not able to make
&
Enabling interrupt remapping with kernel_irqchip=on should result
in an error for both VT-d and AMD-Vi
Signed-off-by: David Kiarie <davidkiar...@gmail.com>
---
hw/i386/intel_iommu.c | 9 -
hw/i386/x86-iommu.c | 8
2 files changed, 8 insertions(+), 9 deletions(-)
diff
Platform devices are now able to make interrupt request with
explicit SIDs hence remove unnecesary check for invalid SID.
Signed-off-by: David Kiarie <davidkiar...@gmail.com>
---
hw/i386/intel_iommu.c | 72 -
include/hw/i386/x86-iommu.h |
here[1]
Changes since v4
-Removed SID enforcement from Intel IOMMU.
-changed the code so that cache invalidation handler triggers with each
invalidation from IOMMU
-A few other miscallaneous fixes all suggested by Peter.
[1] https://github.com/aslaq/qemu ir
David Kiarie (6):
hw/msi
Report IOAPIC via IVRS which effectively allows linux AMD-Vi
driver to enable interrupt remapping
Signed-off-by: David Kiarie <davidkiar...@gmail.com>
---
hw/i386/acpi-build.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index c20bc71..c
Introduce AMD IOMMU interrupt remapping and hook it onto
the existing interrupt remapping infrastructure
Signed-off-by: David Kiarie <davidkiar...@gmail.com>
---
hw/i386/amd_iommu.c | 206 +++-
hw/i386/amd_iommu.h | 2 +-
2 files change
ensures compatility with the original code
which mainly dealt with PCI devices.
Signed-off-by: David Kiarie <davidkiar...@gmail.com>
---
hw/i386/intel_iommu.c | 3 +++
hw/i386/kvm/pci-assign.c | 12
hw/intc/ioapic.c
Introduce macros and trace events for use in AMD IOMMU
interrupt remapping
Signed-off-by: David Kiarie <davidkiar...@gmail.com>
---
hw/i386/amd_iommu.h | 80
hw/i386/trace-events | 7 +
2 files changed, 87 insertions(+)
diff --gi
translation
as it is the q35 interrupt region.
We advertise features that are not yet implemented to please
the Linux IOMMU driver.
IOTLB aims at implementing commands on real IOMMUs which is
essential for debugging and may not offer any performance
benefits
Signed-off-by: David Kiarie <davidk
Signed-off-by: David Kiarie <davidkiar...@gmail.com>
---
hw/i386/trace-events | 29 +
1 file changed, 29 insertions(+)
diff --git a/hw/i386/trace-events b/hw/i386/trace-events
index 5b99eba..1938b98 100644
--- a/hw/i386/trace-events
+++ b/hw/i386/trace-events
@@
can still go ahead pass
command line parameter 'iommu=pt iommu=1'
and try to pass a device to L2 guest. This can also done without passing any
iommu related parameters to the kernel.
David Kiarie (4):
hw/pci: Prepare for AMD IOMMU
hw/i386/trace-events: Add AMD IOMMU trace events
hw/i386
Introduce PCI macros from for use by AMD IOMMU
Signed-off-by: David Kiarie <davidkiar...@gmail.com>
---
include/hw/pci/pci.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h
index e8b83bb..772692f 100644
--- a/include/hw/pci/pci.h
+++ b/i
On Tue, Sep 20, 2016 at 4:40 AM, Michael S. Tsirkin <m...@redhat.com> wrote:
> On Tue, Sep 20, 2016 at 04:14:14AM +0300, David Kiarie wrote:
> >
> >
> > On Tue, Sep 20, 2016 at 3:09 AM, Michael S. Tsirkin <m...@redhat.com>
> wrote:
> >
> >
Signed-off-by: David Kiarie <davidkiar...@gmail.com>
---
hw/i386/trace-events | 29 +
1 file changed, 29 insertions(+)
diff --git a/hw/i386/trace-events b/hw/i386/trace-events
index 5b99eba..1938b98 100644
--- a/hw/i386/trace-events
+++ b/hw/i386/trace-events
@@
On Tue, Sep 20, 2016 at 3:09 AM, Michael S. Tsirkin <m...@redhat.com> wrote:
> On Tue, Sep 20, 2016 at 03:05:02AM +0300, David Kiarie wrote:
> > Signed-off-by: David Kiarie <davidkiar...@gmail.com>
> > ---
> > hw/i386/trace-events | 29
translation
as it is the q35 interrupt region.
We advertise features that are not yet implemented to please
the Linux IOMMU driver.
IOTLB aims at implementing commands on real IOMMUs which is
essential for debugging and may not offer any performance
benefits
Signed-off-by: David Kiarie <davidk
Signed-off-by: David Kiarie <davidkiar...@gmail.com>
---
hw/i386/trace-events | 29 +
1 file changed, 29 insertions(+)
diff --git a/hw/i386/trace-events b/hw/i386/trace-events
index 5b99eba..ddeda02 100644
--- a/hw/i386/trace-events
+++ b/hw/i386/trace-events
@@
'iommu=pt iommu=1'
and try to pass a device to L2 guest. This can also done without passing any
iommu related parameters to the kernel.
[1] https://github.com/aslaq/qemu v18
David Kiarie (4):
hw/pci: Prepare for AMD IOMMU
hw/i386/trace-events: Add AMD IOMMU trace events
hw/i386: Introduce
Introduce PCI macros from for use by AMD IOMMU
Signed-off-by: David Kiarie <davidkiar...@gmail.com>
---
include/hw/pci/pci.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h
index e8b83bb..772692f 100644
--- a/include/hw/pci/pci.h
+++ b/i
On Sat, Sep 17, 2016 at 7:59 AM, David Kiarie <davidkiar...@gmail.com>
wrote:
>
>
> On 16/09/16 21:58, Michael S. Tsirkin wrote:
>
>> On Wed, Aug 31, 2016 at 07:17:42PM +0300, David Kiarie wrote:
>>
> Hi Michael,
>
> +
>> +/* issue a PCIe comp
On 16/09/16 21:58, Michael S. Tsirkin wrote:
On Wed, Aug 31, 2016 at 07:17:42PM +0300, David Kiarie wrote:
Hi Michael,
+
+/* issue a PCIe completion packet for devid */
+typedef struct QEMU_PACKED {
+uint32_t reserved_1:16;
+uint32_t devid:16;
+
+#ifdef HOST_WORDS_BIGENDIAN
On Tue, Sep 13, 2016 at 10:38 AM, Peter Xu <pet...@redhat.com> wrote:
> On Mon, Sep 12, 2016 at 03:45:48PM +0300, David Kiarie wrote:
> > > When we say cache here, we are mostly talking about GSI routes in
> > > kernel, right? Since we still don't have other kind of i
On Mon, Sep 12, 2016 at 3:11 PM, Peter Xu <pet...@redhat.com> wrote:
> On Mon, Sep 12, 2016 at 02:51:27PM +0300, David Kiarie wrote:
> > On Mon, Sep 12, 2016 at 2:34 PM, Peter Xu <pet...@redhat.com> wrote:
> >
> > > On Mon, Sep 12, 2016 at
On Mon, Sep 12, 2016 at 2:34 PM, Peter Xu <pet...@redhat.com> wrote:
> On Mon, Sep 12, 2016 at 01:08:07PM +0300, David Kiarie wrote:
>
> [...]
>
> > /* configure MMIO registers at startup/reset */
> > static void amdvi_set_quad(AMDVIState
On Mon, Sep 12, 2016 at 2:02 PM, Peter Xu <pet...@redhat.com> wrote:
> On Mon, Sep 12, 2016 at 01:08:04PM +0300, David Kiarie wrote:
> > When using IOMMU platform devices like IOAPIC are required to make
> > interrupt remapping requests using explicit SID.We affil
On Mon, Sep 12, 2016 at 2:09 PM, Peter Xu <pet...@redhat.com> wrote:
> On Mon, Sep 12, 2016 at 01:08:05PM +0300, David Kiarie wrote:
>
> [...]
>
> > @@ -2252,14 +2250,17 @@ static MemTxResult vtd_mem_ir_write(void
> *opaque, hwaddr addr,
> > {
> >
Platform devices are now able to make interrupt request with
explicit SIDs hence we can safely expect triggered AddressSpace ID
to match the requesting ID
Signed-off-by: David Kiarie <davidkiar...@gmail.com>
---
hw/i386/intel_iommu.c | 77 ++--
Introduce AMD IOMMU interrupt remapping and hook it onto
the existing interrupt remapping infrastructure
Signed-off-by: David Kiarie <davidkiar...@gmail.com>
---
hw/i386/amd_iommu.c | 240 +++-
hw/i386/amd_iommu.h | 4 +-
hw/intc/io
maintaining compatility with the original code
which mainly dealt with PCI devices.
Signed-off-by: David Kiarie <davidkiar...@gmail.com>
---
hw/i386/intel_iommu.c | 3 +++
hw/i386/kvm/pci-assign.c | 12
hw/intc/ioapic.c
Report IOAPIC via IVRS which effectively allows linux AMD-Vi
driver to enable interrupt remapping
Signed-off-by: David Kiarie <davidkiar...@gmail.com>
---
hw/i386/acpi-build.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index c20bc71..c
Enabling interrupt remapping with kernel_irqchip=on should result
in an error for both VT-d and AMD-Vi
Signed-off-by: David Kiarie <davidkiar...@gmail.com>
---
hw/i386/intel_iommu.c | 9 -
hw/i386/x86-iommu.c | 8
2 files changed, 8 insertions(+), 9 deletions(-)
diff
to a Requester ID and a PCI
device
if one is present.
This patchset builds ontop of the AMD IOMMU patchset but is available here[1]
for quick
testing.
https://github.com/aslaq/qemu IR
David Kiarie (6):
hw/msi: Allow platform devices to use explicit SID
hw/i386: enforce SID verification
hw
Introduce macros and trace events for use in AMD IOMMU
interrupt remapping
Signed-off-by: David Kiarie <davidkiar...@gmail.com>
---
hw/i386/amd_iommu.h | 80
hw/i386/trace-events | 7 +
2 files changed, 87 insertions(+)
diff --gi
Report IOAPIC via IVRS which effectively allows linux AMD-Vi
driver to enable interrupt remapping
Signed-off-by: David Kiarie <davidkiar...@gmail.com>
---
hw/i386/acpi-build.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index 49bd183..c
Introduce AMD IOMMU interrupt remapping and hook it onto
the existing interrupt remapping infrastructure
Signed-off-by: David Kiarie <davidkiar...@gmail.com>
---
hw/i386/amd_iommu.c | 241 +++-
hw/i386/amd_iommu.h | 4 +-
hw/intc/io
maintaining compatility with the original code
which mainly dealt with PCI devices.
Signed-off-by: David Kiarie <davidkiar...@gmail.com>
---
hw/i386/intel_iommu.c | 3 +++
hw/i386/kvm/pci-assign.c | 12
hw/intc/ioapic.c | 25 +--
together with the "Explicit SID for
IOAPIC"."Explicit SID for IOAPIC" functions to
affiliate MSI routes with a requester ID and a PCI device if present which
enables platform devices like IOAPIC to
make interrupt requests using an explicit SID as required by both VT-d and
AMD-
Enabling interrupt remapping with kernel_irqchip=on should result
in an error for both VT-d and AMD-Vi
Signed-off-by: David Kiarie <davidkiar...@gmail.com>
---
hw/i386/intel_iommu.c | 9 -
hw/i386/x86-iommu.c | 8
2 files changed, 8 insertions(+), 9 deletions(-)
diff
Platform device are now able to make interrupt request with
explicit SIDs hence we can safely expect triggered AddressSpace ID
to match the requesting ID
Signed-off-by: David Kiarie <davidkiar...@gmail.com>
---
hw/i386/intel_iommu.c | 77 ++--
Signed-off-by: David Kiarie <davidkiar...@gmail.com>
---
hw/i386/trace-events | 29 +
1 file changed, 29 insertions(+)
diff --git a/hw/i386/trace-events b/hw/i386/trace-events
index 7735e46..60bdf6a 100644
--- a/hw/i386/trace-events
+++ b/hw/i386/trace-events
@@
Introduce macros and trace events for use in AMD IOMMU
interrupt remapping
Signed-off-by: David Kiarie <davidkiar...@gmail.com>
---
hw/i386/amd_iommu.h | 80
hw/i386/trace-events | 7 +
2 files changed, 87 insertions(+)
diff --gi
translation
as it is the q35 interrupt region.
We advertise features that are not yet implemented to please
the Linux IOMMU driver.
IOTLB aims at implementing commands on real IOMMUs which is
essential for debugging and may not offer any performance
benefits
Signed-off-by: David Kiarie <davidk
Introduce PCI macros from for use by AMD IOMMU
Signed-off-by: David Kiarie <davidkiar...@gmail.com>
---
include/hw/pci/pci.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h
index 929ec2f..5ff92de 100644
--- a/include/hw/pci
1 - 100 of 301 matches
Mail list logo
