On 1/16/17 5:46 AM, Stefan Hajnoczi wrote:
> On Fri, Jan 13, 2017 at 09:15:49AM -0600, Doug Goldstein wrote:
>> On 1/13/17 6:02 AM, Stefan Hajnoczi wrote:
>>> On Thu, Jan 12, 2017 at 10:57:53AM -0600, Doug Goldstein wrote:
>>>> On 1/12/17 5:46 AM, St
On 1/13/17 6:02 AM, Stefan Hajnoczi wrote:
> On Thu, Jan 12, 2017 at 10:57:53AM -0600, Doug Goldstein wrote:
>> On 1/12/17 5:46 AM, Stefan Hajnoczi wrote:
>>> The virtio_queue_set_notification() nesting introduced for AioContext
>>> polling
>>> raised an as
On 1/12/17 2:05 PM, Michael S. Tsirkin wrote:
> On Thu, Jan 12, 2017 at 10:57:53AM -0600, Doug Goldstein wrote:
>> On 1/12/17 5:46 AM, Stefan Hajnoczi wrote:
>>> The virtio_queue_set_notification() nesting introduced for AioContext
>>> polling
>>> raised an as
ing a DHCP address the screen
immediately flashes over to the UEFI shell. Its like a timeout is
getting hit and just dropping me to the shell.
--
Doug Goldstein
signature.asc
Description: OpenPGP digital signature
57aa2a8 in kvm_cpu_exec (cpu=cpu@entry=0x565bc7f0)
at /home/doug/work/qemu/kvm-all.c:1968
#20 0x55797d48 in qemu_kvm_cpu_thread_fn (arg=0x565bc7f0)
at /home/doug/work/qemu/cpus.c:998
#21 0x748726ca in start_thread (arg=0x7fffead75700)
at pthread_create.c:333
#22 0x745ac0af in clone ()
at ../sysdeps/unix/sysv/linux/x86_64/clone.S:105
--
Doug Goldstein
signature.asc
Description: OpenPGP digital signature
,netdev=net0 -boot
order=n -device qxl-vga -gdb tcp::1234
It happens almost right away. Let me know how I can help track this down
further.
Thanks.
--
Doug Goldstein
signature.asc
Description: OpenPGP digital signature
to commit this patch?
> Richard already reviewed it.
>
> See also http://patchwork.ozlabs.org/patch/268687/ for
> another configure patch waiting for a commit.
>
> Regards,
> Stefan
>
>
Ping on getting this into master (and then over to stable).
--
Doug Goldstein
anyways
>
> Paolo, those patches are all yours, mind updating/pinging/reposting ?
>
> Thanks,
> Cole
>
>
>
I pinged on the first one since we had a similar bug in Gentoo and
I've carried that patch as well. I'm also pinging a number of other
patches I've been carrying.
--
Doug Goldstein
-vga std -boot d
> -cpu pentium -machine isapc
>
> https://bugzilla.redhat.com/show_bug.cgi?id=986790
>
> So I tried your patch on git master, but it gives:
>
> qemu-system-x86_64: Property '.kvmvapic' not found
>
> Changing the property name to 'vapic' fixes both issues for me.
>
> Thanks,
> Cole
>
Ping this patch. I had to make the same change as Cole for Gentoo as well.
--
Doug Goldstein
ot;,
> + strerror(-ret));
> +goto out;
> +}
> if (ret) {
> continue;
> }
> diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c
> index ffbcf31..ffe48ad 100644
> --- a/qemu-io-cmds.c
> +++ b/qemu-io-cmds.c
> @@ -1829,6 +1829,10 @@ static int alloc_f(BlockDriverState *bs, int argc,
> char **argv)
> sector_num = offset >> 9;
> while (remaining) {
> ret = bdrv_is_allocated(bs, sector_num, remaining, &num);
> +if (ret < 0) {
> +printf("is_allocated failed: %s\n", strerror(-ret));
> +return 0;
> +}
> sector_num += num;
> remaining -= num;
> if (ret) {
> --
> 1.7.9.5
>
>
--
Doug Goldstein
;parent,
> + 2, ehci->as);
> if (off + len > 4096) {
> /* transfer crosses page border */
> uint32_t len2 = off + len - 4096;
> --
> 1.8.3.1
>
>
Ping. Don't see this in master (and as such its missing from mdroth's
1.6.1 patch set).
--
Doug Goldstein
vices, similar to lspci?
>
> Are virtio-mmio devices self-describing or do they have to be listed
> in the device tree? (it's going to really complicate things if the
> latter ...)
>
> Attached below is the command line and kernel output.
>
> Rich.
>
>
--
Doug Goldstein
};
>
> Am I right that anonymous unions are only a C11 feature (not C99)? But
> you are just copying and pasting from the other uses in this file, so
> it's not a problem.
>
>
Yes, they're a C11-ism. But they appear in gnu99, not sure as to what GCC
added them but I know GCC 3.2 didn't have them.
--
Doug Goldstein
mp; O_DIRECT. In practice, the warning
> probably does much more good than harm.
>
>
Actually EINVAL is only for O_DIRECT with open(). There are other
filesystems that will return this other than tmpfs as well, but we were
discussing /var/run so the assumption was tmpfs [1]. The code that performs
the check to see if EINVAL should be returned checks to see if the
direct_IO address space op is defined [2] (or get_xip_mem but that's
another story).
[1] https://www.redhat.com/archives/libvir-list/2013-August/msg00768.html
[2] http://lxr.linux.no/#linux+v3.10.9/fs/open.c#L651
--
Doug Goldstein
16:22:07 2013 +0200
qemu-char: Fix ringbuf option size
Any attempt to use it trips an "opt->desc->type == QEMU_OPT_NUMBER"
assertion. Broken in commit 1da48c65.
Cc: qemu-sta...@nongnu.org
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Signed-off-by: Luiz Capitulino
--
Doug Goldstein
signal(SIGPIPE, SIG_IGN);
>> +#endif
>> +
>> progname = basename(argv[0]);
>>
>> while ((c = getopt_long(argc, argv, sopt, lopt, &opt_index)) != -1) {
>>
>
> Reviewed-by: Paolo Bonzini
>
> and adding qemu-stable for this one.
>
Nudge so this isn't forgotten about since it hasn't hit master yet.
--
Doug Goldstein
>> /* Prepare for the next iteration */
>> offset += ret;
>> total += ret;
>>
>
> Reviewed-by: Paolo Bonzini
>
> ... and should also be in 1.5.2.
>
> Paolo
>
Nudge so this doesn't get forgotten about. It hasn't hit master yet.
--
Doug Goldstein
lo Bonzini
Signed-off-by: Stefan Hajnoczi
---
It only adds a test for something that was fixed in 1.4.1 (maybe was fixed
by the final 1.4.0 release I can't recall).
--
Doug Goldstein
Allow the bridge helper to take a config directory rather than having to
specify every file in the directory manually via an include statement.
Signed-off-by: Doug Goldstein
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Corey Bryant
CC: Anthony Liguori
CC: Richa Marwaha
CC: Corey Bryant
TO
Handle errors and cleanup from the error in a unified place for
parse_acl_file().
Signed-off-by: Doug Goldstein
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Corey Bryant
CC: Anthony Liguori
CC: Richa Marwaha
CC: Corey Bryant
TO: qemu-devel@nongnu.org
---
qemu-bridge-helper.c | 28
ted review changes from Stefan Hajnoczi
Doug Goldstein (2):
bridge helper: unified error cleanup for parse_acl_file
bridge helper: support conf dirs
qemu-bridge-helper.c | 75 +++-
1 file changed, 63 insertions(+), 12 deletions(-)
--
1.8.1.5
The configure script allows you to supply a libdir via --libdir but was
not advertising this in --help.
Signed-off-by: Doug Goldstein
CC: qemu-triv...@nongnu.org
---
configure | 1 +
1 file changed, 1 insertion(+)
diff --git a/configure b/configure
index 46a7594..497ce29 100755
--- a/configure
Handle errors and cleanup from the error in a unified place for
parse_acl_file().
Signed-off-by: Doug Goldstein
CC: Anthony Liguori
CC: Richa Marwaha
CC: Corey Bryant
TO: qemu-devel@nongnu.org
---
qemu-bridge-helper.c | 28
1 file changed, 16 insertions(+), 12
Allow the bridge helper to take a config directory rather than having to
specify every file in the directory manually via an include statement.
Signed-off-by: Doug Goldstein
CC: Anthony Liguori
CC: Richa Marwaha
CC: Corey Bryant
TO: qemu-devel@nongnu.org
---
qemu-bridge-helper.c | 55
hange from v2:
- Integrated review changes from Corey Bryant
- Integrated review changes from Stefan Hajnoczi
Change from v1:
- Reversed patch order to make the series clearer
- Integrated review changes from Corey Bryant
- Integrated review changes from Stefan Hajnoczi
Doug Goldstein (2):
bri
+ qemu, that
I've solved in Gentoo by simply using the coreboot seabios images
after some troubleshooting help from Peter. Similarly our Ubuntu
OpenStack machines at work had quirks resolved by dropping the
coreboot seabios images on them.
--
Doug Goldstein
On Mon, Mar 4, 2013 at 10:27 AM, Corey Bryant wrote:
>
>
> On 03/02/2013 01:58 AM, Doug Goldstein wrote:
>>
>> Handle errors and cleanup from the error in a unified place for
>> parse_acl_file().
>>
>> Signed-off-by: Doug Goldstein
>> CC: Anthon
spice="yes"
> libs_softmmu="$libs_softmmu $spice_libs"
> --
> 1.8.1.2
>
>
I can confirm this issue and that this is the fix. This change is
queued in my 1.4 stable series as well.
Reviewed-by: Doug Goldstein
--
Doug Goldstein
Handle errors and cleanup from the error in a unified place for
parse_acl_file().
Signed-off-by: Doug Goldstein
CC: Anthony Liguori
CC: Richa Marwaha
CC: Corey Bryant
TO: qemu-devel@nongnu.org
---
qemu-bridge-helper.c | 20 +++-
1 file changed, 11 insertions(+), 9 deletions
Allow the bridge helper to take a config directory rather than having to
specify every file in the directory manually via an include statement.
Signed-off-by: Doug Goldstein
CC: Anthony Liguori
CC: Richa Marwaha
CC: Corey Bryant
TO: qemu-devel@nongnu.org
---
qemu-bridge-helper.c | 55
hange from v1:
- Reversed patch order to make the series clearer
- Integrated review changes from Corey Bryant
- Integrated review changes from Stefan Hajnoczi
Doug Goldstein (2):
bridge helper: unified error cleanup for parse_acl_file
bridge helper: support conf dirs
qemu-bridge-hel
I've updated the Gentoo docs for the flag to read:
Enable VirtFS via fsdev (host) and virtio-9p-pci (guest). See
http://wiki.qemu.org/Documentation/9psetup
Hopefully that's a bit more clear that you need to enable that for this
support.
--
You received this bug notification because you are a me
Handle errors and cleanup from the error in a unified place for
parse_acl_file().
Signed-off-by: Doug Goldstein
CC: Anthony Liguori
CC: Richa Marwaha
CC: Corey Bryant
TO: qemu-devel@nongnu.org
---
qemu-bridge-helper.c | 32 +---
1 file changed, 21 insertions
Allow the bridge helper to take a config directory rather than having to
specify every file in the directory manually via an include statement.
Signed-off-by: Doug Goldstein
CC: Anthony Liguori
CC: Richa Marwaha
CC: Corey Bryant
TO: qemu-devel@nongnu.org
---
qemu-bridge-helper.c | 55
C: Anthony Liguori
CC: Richa Marwaha
CC: Corey Bryant
TO: qemu-devel@nongnu.org
Doug Goldstein (2):
bridge helper: support conf dirs
bridge helper: unified error cleanup for parse_acl_file
qemu-bridge-helper.c | 73 +---
1 file changed, 69
of them have any references. So it seems like a
better place is /usr/bin (I could see /usr/sbin but I thought that was
also targeted by the /usr merge to go away and just have it all in
/usr/bin).
>
>> I have no idea how virtfs-proxy-helper would work, but I suspect that a
>> better design would have QEMU spawning it, just like qemu-bridge-helper.
>
> QEMU can't spawn it, it is spawned in *guest* by a startup script or some
> event daemon (such as systemd or udev).
>
> Thanks,
>
> /mjt
>
--
Doug Goldstein
rt. I just didn't have feedback other than
"ah that's a good patch to use".
--
Doug Goldstein
ch queue
that you did shortly for what would amount to a 1.2.3 release as well.
But I'll gladly test your branch and provide some feedback when
possible.
--
Doug Goldstein
"$seccomp" = "yes"; then
> --
> 1.7.10.4
>
>
This should likely be considered for QEMU 1.3.1 as well. I've added it
to my QEMU 1.2.x queue as well.
--
Doug Goldstein
selected to be shipped in a stable release it'd be great if it was
backported and pushed into that stable repo as that would allow for
more testing of the stable series. I know this increases your
maintenance burden but it would enable more distros to provide you
more meaningful feedback on stable releases so that they are truly
stable.
--
Doug Goldstein
rapper is
> welcome generally, due to different reception of defaults
> by different people.
>
> Comments?
>
> [1] http://patchwork.ozlabs.org/patch/205676/
> [2] https://patchwork.kernel.org/patch/1531761/
>
> Thanks,
>
> /mjt
>
--
Doug Goldstein
lly, but decided
> it isn't really needed ;)
>
> Thank you!
>
> /mjt
>
Can you go ahead and push this into the 1.1-stable repo then? I'd
rather see things that are accepted pushed into the various stable
repos than languish in someone's personal repo/list and then pushed
right before a new stable tarball is released.
--
Doug Goldstein
gt; diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
> index 5062e07..56e5a40 100644
> --- a/src/conf/domain_conf.h
> +++ b/src/conf/domain_conf.h
> @@ -652,6 +652,7 @@ enum virDomainControllerType {
> VIR_DOMAIN_CONTROLLER_TYPE_VIRTIO_SERIAL,
> VIR_DOMAIN_CONTROLLER_TYPE_CCID,
> VIR_DOMAIN_CONTROLLER_TYPE_USB,
> +VIR_DOMAIN_CONTROLLER_TYPE_PCIBRIDGE,
>
> VIR_DOMAIN_CONTROLLER_TYPE_LAST
> };
> --
> 1.7.2.5
>
>
Looks like:
int virDevicePCIAddressIsValid(virDevicePCIAddressPtr addr)
Needs to be updated as well part of this series to allow bus to not be
0 anymore.
This change also needs an update to the XML schemas in
docs/schemas/basictypes.rng
--
Doug Goldstein
On Sun, Nov 4, 2012 at 3:51 PM, Anthony Liguori wrote:
> Avi Kivity writes:
>
>> On 10/22/2012 09:04 AM, Philipp Hahn wrote:
>>> Hello Doug,
>>>
>>> On Saturday 20 October 2012 00:46:43 Doug Goldstein wrote:
>>>> I'm using li
g_config --atleast-version=1.0.0 libseccomp --modversion
> >/dev/null 2>&1; then
> LIBS=`$pkg_config --libs libseccomp`
> seccomp="yes"
> else
> --
> 1.7.2.5
>
>
I can confirm this will fix the compile issue when you've got
libseccomp 0.1.0, so ACK from a non-maintainer.
--
Doug Goldstein
Report an error when ramblock's sizes mismatch with a suggestion to the
user as to what went wrong. If a user has a managedsave state by
libvirt, which is the default now, and upgrades their distro, which in
turn upgrades QEMU, they will be surprised by the fact that their VMs fail
to start. The re
Report an error when ramblock's sizes mismatch with a suggestion to the
user as to what went wrong.
---
libvirt uses migration to save the state, however when performing a
distro upgrade you might get an error starting your VMs up again without
much detail. This patch attempts to remedy that with
On Mon, Oct 22, 2012 at 6:23 AM, Avi Kivity wrote:
> On 10/22/2012 09:04 AM, Philipp Hahn wrote:
>> Hello Doug,
>>
>> On Saturday 20 October 2012 00:46:43 Doug Goldstein wrote:
>>> I'm using libvirt 0.10.2 and I had qemu-kvm 1.1.1 running all my VMs.
>>
On Mon, Oct 22, 2012 at 6:23 AM, Avi Kivity wrote:
> On 10/22/2012 09:04 AM, Philipp Hahn wrote:
>> Hello Doug,
>>
>> On Saturday 20 October 2012 00:46:43 Doug Goldstein wrote:
>>> I'm using libvirt 0.10.2 and I had qemu-kvm 1.1.1 running all my VMs.
>>
global
qxl-vga.vram_size=67108864 -incoming fd:20 -device
virtio-balloon-pci,id=balloon0,bus=pci.0,addr=0x5
char device redirected to /dev/pts/7
qemu: warning: error while loading state for instance 0x0 of device 'ram'
load of migration failed
--
Doug Goldstein
Which has also been released.
** Changed in: qemu
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/816370
Title:
compile error in QEMU 0.15.0-rc0 and 0.1
Fixed by: http://lists.freedesktop.org/archives/spice-
devel/2011-January/002259.html
** Changed in: qemu
Status: New => Fix Committed
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/816370
Tit
> QEMU can't prevent the user from running a (possibly valid)
> configuration just because it's not very common.
>
> --
> Eduardo
>
Isn't MPS and APIC support required for a guest OS to really handle
the topology correctly? Now days ACPI provides most of that
information so its likely that QEMU doesn't support plain old MPS +
APIC. Its also possible that QEMU does support this but the kernel got
confused because I see the CPUID +acpi specified in the command line
while -no-acpi is on the command line as you noted.
--
Doug Goldstein
a cluster of machines is established as being redundant
migratable machines for each other I must do the following for each
machine:
virsh -c qemu://machine/system capabilities | xpath
/capabilities/host/cpu > machine-cpu.xml
Once I have that data I combine them together and use virsh
cpu-baseline, which is a handy addition from the past of doing it
manually, but still not optimal. This gives me a model which is mostly
meaningless and uninteresting to me, but I know all the guests must
use Penryn for example. If ovirt and by extension libvirt let me know
that guest X is running on CPU-A, I know I could migrate it to any
other machine supporting CPU-A or CPU-B (assuming B is a super set of
A).
--
Doug Goldstein
*** This bug has been marked as a duplicate of bug 378907 ***
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/816370
Title:
compile error in QEMU 0.15.0-rc0 and 0.15.0-rc1
Status in QEMU:
New
Sta
configure --with-kvm-kmod{=optional/path/to} because
otherwise this adds a potential automagical dependency onto kvm-kmod
(i.e. if the user had kvm-kmod installed at the time of build but then
removed them and went back with their kernel provided version)
Thanks.
--
Doug Goldstein
56 matches
Mail list logo
