[PATCH] Make some structure static

2024-03-01 Thread Frediano Ziglio
Not used outside C module. Signed-off-by: Frediano Ziglio --- hw/vfio/pci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index 4fa387f043..a1522a011a 100644 --- a/hw/vfio/pci.c +++ b/hw/vfio/pci.c @@ -2558,7 +2558,7 @@ static bool

[PATCH] Fix typo in comment (uin32_t -> uint32_t)

2024-03-01 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- hw/vfio/pci.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/vfio/pci.h b/hw/vfio/pci.h index 6e64a2654e..4bb7d7d257 100644 --- a/hw/vfio/pci.h +++ b/hw/vfio/pci.h @@ -181,7 +181,7 @@ struct VFIOPCIDevice { Notifier

Re: qemu-system-i386

2023-10-31 Thread Frediano Ziglio
Hi, did you compile on yourself? Downloaded from some website? Regards, Frediano Il giorno dom 29 ott 2023 alle ore 20:13 Joachim Roden ha scritto:

Re: [RFC v2 2/2] spice: Add an option to forward the dmabuf directly to the encoder (v2)

2023-02-01 Thread Frediano Ziglio
Il giorno lun 30 gen 2023 alle ore 02:24 Kasireddy, Vivek ha scritto: > > Hi Frediano, Gerd, > > > > > Il giorno mar 24 gen 2023 alle ore 06:41 Kasireddy, Vivek > > ha scritto: > > > > > > + Frediano > > > > > > Hi Gerd, > > > > > > > > > > > Hi, > > > > > > > > > Here is the flow of things

Re: [QEMU][PATCH v4 07/10] hw/xen/xen-hvm-common: Use g_new and error_setg_errno

2023-01-25 Thread Frediano Ziglio
Il giorno mer 25 gen 2023 alle ore 22:07 Stefano Stabellini ha scritto: > > On Wed, 25 Jan 2023, Vikram Garhwal wrote: > > Replace g_malloc with g_new and perror with error_setg_errno. > > error_setg_errno -> error_report ? Also in the title > > Signed-off-by: Vikram Garhwal Frediano

Re: [RFC v2 2/2] spice: Add an option to forward the dmabuf directly to the encoder (v2)

2023-01-25 Thread Frediano Ziglio
Il giorno mar 24 gen 2023 alle ore 06:41 Kasireddy, Vivek ha scritto: > > + Frediano > > Hi Gerd, > > > > > Hi, > > > > > Here is the flow of things from the Qemu side: > > > - Call gl_scanout (to update the fd) and gl_draw_async just like > > > in the local display case. > > > > Ok. > > > >

Re: [RFC v2 1/2] spice: Add an option for users to provide a preferred codec

2023-01-25 Thread Frediano Ziglio
Il giorno lun 23 gen 2023 alle ore 08:37 Vivek Kasireddy ha scritto: > > Giving users an option to choose a particular codec will enable > them to make an appropriate decision based on their hardware and > use-case. > > Cc: Gerd Hoffmann > Cc: Marc-André Lureau > Cc: Dongwon Kim >

Re: [RFC PATCH 13/21] contrib/gitdm: Add more entries to the Red Hat domain

2020-10-05 Thread Frediano Ziglio
Il giorno lun 5 ott 2020 alle ore 09:39 Philippe Mathieu-Daudé < f4...@amsat.org> ha scritto: > On Mon, Oct 5, 2020 at 10:05 AM Frediano Ziglio > wrote: > > > > Hi, > > can I disagree? If the contribution is personal I use my personal > address, if

Re: [RFC PATCH 13/21] contrib/gitdm: Add more entries to the Red Hat domain

2020-10-05 Thread Frediano Ziglio
Frediano Ziglio > Cc: Frediano Ziglio > Cc: Nir Soffer > Cc: Nir Soffer > Signed-off-by: Philippe Mathieu-Daudé > --- > To the developers Cc'ed: If you agree with your entry, please > reply with a Reviewed-by/Acked-by tag. If you disagree or doesn't > care, please ei

Re: [PATCH v2 5/6] spice: get monitors physical dimension

2020-09-26 Thread Frediano Ziglio
> > From: Marc-André Lureau > > Note that for consistency, we use the same logic as MonitorsConfig to > figure out the associated monitor. However, I can't find traces of the > discussion/patches about the "new spice-server" behaviour: it still uses > the multiple-configurations path in git

Re: [PATCH] spice: remove obsolete callback

2020-09-18 Thread Frediano Ziglio
> > From: Marc-André Lureau > > The "attach_worker" callbacks aren't doing anything in QEMU, but they > were mandatory until Spice server commit > 6aa1a17c69dc3cc02f338a78b3266e4c00ea1c1a ("spice-qxl: Remove QXLWorker > definition"). > > Furthermore, the old spelling is deprecated since commit

[PATCH] ui: Add more mouse buttons to SPICE

2020-08-20 Thread Frediano Ziglio
From: Frediano Ziglio Add support for SIDE and EXTRA buttons. The constants for buttons in both SPICE and QEMU are defined as LEFT MIDDLE RIGHT UP DOWN SIDE EXTRA (same order). "button_mask" contains for each bit the state of a button. Qemu currently uses bi

[PATCH] ui: Add more mouse buttons to SPICE

2020-08-20 Thread Frediano Ziglio
From: Frediano Ziglio Add support for SIDE and EXTRA buttons. Signed-off-by: Frediano Ziglio --- ui/spice-input.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ui/spice-input.c b/ui/spice-input.c index cd4bb0043f..d5bba231c9 100644 --- a/ui/spice-input.c +++ b/ui/spice-input.c

[PATCH] ui: Add more mouse buttons to SPICE

2020-08-20 Thread Frediano Ziglio
Add support for SIDE and EXTRA buttons. Signed-off-by: Frediano Ziglio --- ui/spice-input.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ui/spice-input.c b/ui/spice-input.c index cd4bb0043f..d5bba231c9 100644 --- a/ui/spice-input.c +++ b/ui/spice-input.c @@ -123,6 +123,8 @@ static void

Re: [PATCH 3/3] qemu-timer: reuse MIN macro in qemu_timeout_ns_to_ms

2019-10-23 Thread Frediano Ziglio
> > On 10/23/19 8:42 AM, Laurent Vivier wrote: > > Le 23/10/2019 à 14:26, Frediano Ziglio a écrit : > >> Signed-off-by: Frediano Ziglio > >> --- > >> util/qemu-timer.c | 6 +- > >> 1 file changed, 1 insertion(+), 5 deletions(-) > >>

[PATCH 2/3] event_notifier: avoid dandling file descriptor in event_notifier_cleanup

2019-10-23 Thread Frediano Ziglio
-by: Frediano Ziglio --- util/event_notifier-posix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/event_notifier-posix.c b/util/event_notifier-posix.c index 73c4046b58..00d93204f9 100644 --- a/util/event_notifier-posix.c +++ b/util/event_notifier-posix.c @@ -80,8 +80,8 @@ void

[PATCH 3/3] qemu-timer: reuse MIN macro in qemu_timeout_ns_to_ms

2019-10-23 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- util/qemu-timer.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/util/qemu-timer.c b/util/qemu-timer.c index d428fec567..094a20a05a 100644 --- a/util/qemu-timer.c +++ b/util/qemu-timer.c @@ -322,11 +322,7 @@ int qemu_timeout_ns_to_ms

[PATCH 1/3] util/async: avoid useless cast

2019-10-23 Thread Frediano Ziglio
event_notifier_dummy_cb is already compatible with EventNotifierHandler. Signed-off-by: Frediano Ziglio --- util/async.c | 1 - 1 file changed, 1 deletion(-) diff --git a/util/async.c b/util/async.c index ca83e32c7f..b1fa5319e5 100644 --- a/util/async.c +++ b/util/async.c @@ -429,7 +429,6

Re: [Qemu-devel] [RFC] spice-core: allow setting properties from QMP

2019-06-21 Thread Frediano Ziglio
> > Hello Eric, > > > A new command may be okay, however, > > thanks, I've fix the typos and updated the patch to use an Enum, which > indeed makes more sense. > > I've also updated "spice-query" command to provide the current value > of the "video-codec" property, > but it made me wonder if I

[Qemu-devel] [PATCH 2/2] audio: Do not check for audio_calloc failure

2019-02-25 Thread Frediano Ziglio
audio_calloc uses g_malloc0 which never returns in case of memory failure. Signed-off-by: Frediano Ziglio --- audio/audio.c | 48 ++-- 1 file changed, 6 insertions(+), 42 deletions(-) diff --git a/audio/audio.c b/audio/audio.c index 472721a7a9

[Qemu-devel] [PATCH 1/2] audio: Use g_strdup_printf instead of manual building a string

2019-02-25 Thread Frediano Ziglio
Instead of using lot of low level function and manually allocate the temporary string in audio_process_options use more high level GLib function. The function is not used in hot path but to read some initial setting. Signed-off-by: Frediano Ziglio --- audio/audio.c | 25

[Qemu-devel] [PATCH] spice: Remove unused include

2019-01-07 Thread Frediano Ziglio
The definitions in the header are not used. Also this fixes porting SPICE to Windows where the header is not available. Signed-off-by: Frediano Ziglio --- ui/spice-core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/ui/spice-core.c b/ui/spice-core.c index 525e0929b9..fb87944a24 100644

Re: [Qemu-devel] [Spice-devel] Always get Invalid password while trying to connect to spice server

2018-12-26 Thread Frediano Ziglio
> > On martedì 25 dicembre 2018 09:04:31 CET, Uri Lublin wrote: > > Hi, > > Hi and thanks for your answer. > > > It's hard to tell without more details. > > I'll try to provide all the details, let me know if you need anything else. > > > How do you set the password ? > > I set the password

Re: [Qemu-devel] [PATCH for-4.0 v3] configure: bump spice-server required version to 0.12.5

2018-11-29 Thread Frediano Ziglio
> > On Thu, Nov 29, 2018 at 03:32:28AM -0500, Frediano Ziglio wrote: > > > On Thu, Nov 29, 2018 at 12:09 PM Gerd Hoffmann wrote: > > > > > > > > On Wed, Nov 28, 2018 at 07:59:32PM +0400, Marc-André Lureau wrote: > > > > > Looking at

Re: [Qemu-devel] [PATCH for-4.0 v3] configure: bump spice-server required version to 0.12.5

2018-11-29 Thread Frediano Ziglio
> On Thu, Nov 29, 2018 at 12:09 PM Gerd Hoffmann wrote: > > > > On Wed, Nov 28, 2018 at 07:59:32PM +0400, Marc-André Lureau wrote: > > > Looking at chardev/spice.c code, I realize compilation was broken for > > > a while with spice-server < 0.12.3. Let's bump required version > > > to 0.12.5,

Re: [Qemu-devel] [PATCH for-4.0 v3] configure: bump spice-server required version to 0.12.5

2018-11-29 Thread Frediano Ziglio
> > On Wed, Nov 28, 2018 at 07:59:32PM +0400, Marc-André Lureau wrote: > > Looking at chardev/spice.c code, I realize compilation was broken for > > a while with spice-server < 0.12.3. Let's bump required version > > to 0.12.5, released May 19 2014, instead of adding more #ifdef. > > Oh, you did

Re: [Qemu-devel] [PATCH for-4.0 v3] configure: bump spice-server required version to 0.12.5

2018-11-28 Thread Frediano Ziglio
> > Looking at chardev/spice.c code, I realize compilation was broken for > a while with spice-server < 0.12.3. Let's bump required version > to 0.12.5, released May 19 2014, instead of adding more #ifdef. > > (this patch combines changes from an early version and some of > Frediano "[PATCH 2/2]

Re: [Qemu-devel] [Spice-devel] [PATCH 2/2] spice: Bump required spice-server version to 0.12.6

2018-11-28 Thread Frediano Ziglio
> > On Wed, Nov 28, 2018 at 12:23 PM Frediano Ziglio wrote: > > > > Version 0.12.6 was released on 12th June 2015. > > > > Signed-off-by: Frediano Ziglio > > --- > > chardev/spice.c | 12 > > configure

Re: [Qemu-devel] [Spice-devel] [PATCH] spice: Use new SpiceImageCompression definition

2018-11-28 Thread Frediano Ziglio
> > Hi > On Wed, Nov 28, 2018 at 9:48 AM Gerd Hoffmann wrote: > > > > On Tue, Nov 27, 2018 at 01:35:02PM +0100, Christophe Fergeau wrote: > > > hey, > > > > > > On Mon, Nov 26, 2018 at 03:30:36PM +, Frediano Ziglio wrote: > > > &g

[Qemu-devel] [PATCH 2/2] spice: Bump required spice-server version to 0.12.6

2018-11-28 Thread Frediano Ziglio
Version 0.12.6 was released on 12th June 2015. Signed-off-by: Frediano Ziglio --- chardev/spice.c | 12 configure | 4 ++-- hw/display/qxl.c| 27 --- hw/display/qxl.h| 2 -- include/ui/qemu-spice.h | 12

[Qemu-devel] [PATCH 1/2] spice: Use new SpiceImageCompression definition

2018-11-28 Thread Frediano Ziglio
Definitions were updated by spice-server in patch de66161 included in 0.12.6 released on 12th June 2015. Signed-off-by: Frediano Ziglio --- ui/spice-core.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/ui/spice-core.c b/ui/spice-core.c index ebaae24643

[Qemu-devel] [PATCH] spice: Use new SpiceImageCompression definition

2018-11-26 Thread Frediano Ziglio
Definitions were updated by spice-server in patch de66161 included in 0.12.6 released on 12th June 2015. Signed-off-by: Frediano Ziglio --- ui/spice-core.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/ui/spice-core.c b/ui/spice-core.c index ebaae24643

Re: [Qemu-devel] [RFC PATCH spice v3 1/3] QXL interface: add a function to identify monitors in the guest

2018-11-09 Thread Frediano Ziglio
> On Thu, Nov 08, 2018 at 11:05:10AM +0100, Lukáš Hrázký wrote: > > Hello, > > > > On Thu, 2018-11-08 at 07:49 +0100, Gerd Hoffmann wrote: > > > Hi, > > > > > > > + * The device_display_id_{start,count} denotes the sequence of device > > > > display > > > > + * IDs that map to the zero-based

Re: [Qemu-devel] [RFC PATCH spice v2 1/2] QXL interface: add functions to identify monitors in the guest

2018-11-05 Thread Frediano Ziglio
> > On Mon, 2018-11-05 at 14:08 +0100, Gerd Hoffmann wrote: > > On Mon, Nov 05, 2018 at 01:18:57PM +0100, Lukáš Hrázký wrote: > > > On Mon, 2018-11-05 at 07:52 +0100, Gerd Hoffmann wrote: > > > > > 2. Have a single function as follows: > > > > > > > > > > void

Re: [Qemu-devel] [RFC PATCH spice v2 1/2] QXL interface: add functions to identify monitors in the guest

2018-11-05 Thread Frediano Ziglio
> On Mon, 2018-11-05 at 07:52 +0100, Gerd Hoffmann wrote: > > > 2. Have a single function as follows: > > > > > > void spice_qxl_set_device_info(QXLInstance *instance, > > >const char *device_address, > > >uint32_t

Re: [Qemu-devel] [PULL 1/2] qxl: store channel id in qxl->id

2018-11-05 Thread Frediano Ziglio
> Hi, > > > > vga->con = graphic_console_init(DEVICE(dev), 0, _ops, qxl); > > > +qxl->id = qemu_console_get_index(vga->con); /* == channel_id */ > > > +if (qxl->id != 0) { > > > +error_setg(errp, "primary qxl-vga device must be console 0 " > > > + "(first

Re: [Qemu-devel] [RFC PATCH spice v2 1/2] QXL interface: add functions to identify monitors in the guest

2018-11-05 Thread Frediano Ziglio
> > > 2. Have a single function as follows: > > > > void spice_qxl_set_device_info(QXLInstance *instance, > >const char *device_address, > >uint32_t device_display_id_start, > >uint32_t

Re: [Qemu-devel] [PULL 1/2] qxl: store channel id in qxl->id

2018-11-05 Thread Frediano Ziglio
> > Hi, > > > > vga->con = graphic_console_init(DEVICE(dev), 0, _ops, qxl); > > > +qxl->id = qemu_console_get_index(vga->con); /* == channel_id */ > > > +if (qxl->id != 0) { > > > +error_setg(errp, "primary qxl-vga device must be console 0 " > > > + "(first

Re: [Qemu-devel] [PULL 1/2] qxl: store channel id in qxl->id

2018-11-02 Thread Frediano Ziglio
> > See qemu_spice_add_display_interface(), the console index is also used > as channel id. So put that into the qxl->id field too. > > In typical use cases (one primary qxl-vga device, optionally one or more > secondary qxl devices, no non-qxl display devices) this doesn't change > anything. >

Re: [Qemu-devel] [RFC PATCH qemu v2 2/2] spice: set device address and device display ID in QXL interface

2018-10-18 Thread Frediano Ziglio
> > Calls new SPICE QXL interface functions to set: > > * The hardware address of the graphics device represented by the QXL > interface (e.g. a PCI path): > spice_qxl_set_device_address(...) > > * The device display IDs (the IDs of the device's monitors that belong > to this QXL

Re: [Qemu-devel] [RFC PATCH spice v2 1/2] QXL interface: add functions to identify monitors in the guest

2018-10-18 Thread Frediano Ziglio
> > Adds two functions to let QEMU provide information to identify graphics > devices and their monitors in the guest: > > * device address - The path identifying the device on the system (e.g. PCI > path): > spice_qxl_set_device_address(...) > > * device display ID - The index of the

Re: [Qemu-devel] [Spice-devel] [RFC PATCH spice 1/2] QXL interface: add functions to identify monitors in the guest

2018-10-12 Thread Frediano Ziglio
> > Hi, > > > > When using qemu_console_get_head() it doesn't work correctly, it would > > > use the qxl card's data. It would work if spice-server would filter the > > > list to only include the entries for the given display channel before > > > calling the ->client_monitors_config() callback.

Re: [Qemu-devel] [Spice-devel] [RFC PATCH spice 1/2] QXL interface: add functions to identify monitors in the guest

2018-10-12 Thread Frediano Ziglio
> On Thu, Oct 11, 2018 at 05:37:46PM +0200, Lukáš Hrázký wrote: > > On Thu, 2018-10-11 at 17:09 +0200, Gerd Hoffmann wrote: > > > > > Ok. We probably should fix interface_client_monitors_config() to use > > > > > the channel_id instead of qemu_console_get_head() then. > > > > > > > > It's not

Re: [Qemu-devel] [Spice-devel] [RFC PATCH spice 1/2] QXL interface: add functions to identify monitors in the guest

2018-10-11 Thread Frediano Ziglio
> > > > So, if I remember correctly, Gerd recommended returning this value from > > > the function. But I think it needs more explanation here. What exactly > > > is a "monitor_id" supposed to represent? It is not used in your follow- > > > up qemu patch so it's hard to tell. > > > > It's

Re: [Qemu-devel] [PATCH 1/4] spice: remove QXLWorker interface field

2018-01-09 Thread Frediano Ziglio
Thanks. How is your hand? Frediano - Original Message - > > On Sun, Dec 31, 2017 at 05:17:43AM -0500, Frediano Ziglio wrote: > > ping > > > > > > > > ping > > > > > > > > > > > ping the series > &g

Re: [Qemu-devel] [PATCH 1/4] spice: remove QXLWorker interface field

2017-12-31 Thread Frediano Ziglio
ping > > ping > > > > > ping the series > > > > > > > > This fields points to an old interface that is no more > > > used in the current code. > > > > > > Signed-off-by: Frediano Ziglio <fzig...@redhat.com> >

Re: [Qemu-devel] [PATCH 1/4] spice: remove QXLWorker interface field

2017-12-19 Thread Frediano Ziglio
ping > > ping the series > > > > > This fields points to an old interface that is no more > > used in the current code. > > > > Signed-off-by: Frediano Ziglio <fzig...@redhat.com> > > --- > > hw/display/qxl.c | 1 - >

Re: [Qemu-devel] [PATCH 1/4] spice: remove QXLWorker interface field

2017-12-07 Thread Frediano Ziglio
ping the series > > This fields points to an old interface that is no more > used in the current code. > > Signed-off-by: Frediano Ziglio <fzig...@redhat.com> > --- > hw/display/qxl.c | 1 - > include/ui/spice-display.h | 1 - > ui/spice-display.c

[Qemu-devel] [PATCH 3/4] spice: remove only written event_mask field

2017-11-22 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio <fzig...@redhat.com> --- ui/spice-core.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/ui/spice-core.c b/ui/spice-core.c index 85b9ea2127..6d579faaae 100644 --- a/ui/spice-core.c +++ b/ui/spice-core.c @@ -89,7 +89,6 @@ stati

[Qemu-devel] [PATCH 4/4] spice: remove unused timer list

2017-11-22 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio <fzig...@redhat.com> --- ui/spice-core.c | 4 1 file changed, 4 deletions(-) diff --git a/ui/spice-core.c b/ui/spice-core.c index 6d579faaae..2baf0c7120 100644 --- a/ui/spice-core.c +++ b/ui/spice-core.c @@ -55,9 +55,7 @@ static QemuThread me;

[Qemu-devel] [PATCH 2/4] spice: remove unused watch list

2017-11-22 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio <fzig...@redhat.com> --- ui/spice-core.c | 4 1 file changed, 4 deletions(-) diff --git a/ui/spice-core.c b/ui/spice-core.c index ea04dc69b5..85b9ea2127 100644 --- a/ui/spice-core.c +++ b/ui/spice-core.c @@ -92,9 +92,7 @@ struct SpiceWatch {

[Qemu-devel] [PATCH 1/4] spice: remove QXLWorker interface field

2017-11-22 Thread Frediano Ziglio
This fields points to an old interface that is no more used in the current code. Signed-off-by: Frediano Ziglio <fzig...@redhat.com> --- hw/display/qxl.c | 1 - include/ui/spice-display.h | 1 - ui/spice-display.c | 2 -- 3 files changed, 4 deletions(-) diff --git a/hw/d

[Qemu-devel] [Bug 1635339] Re: qxl_pre_save assertion failure on vm "save"

2017-05-19 Thread Frediano Ziglio
wddm dod 0.17 version released which fixes the issue guest side. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1635339 Title: qxl_pre_save assertion failure on vm "save" Status in QEMU:

[Qemu-devel] [Bug 1635339] Re: qxl_pre_save assertion failure on vm "save"

2017-05-02 Thread Frediano Ziglio
Similar issue, seems not caused by save/restore/migration but is still detecting offset problems with resource deallocation. See https://lists.freedesktop.org/archives/spice-devel/2017-April/037248.html. Still working on some updates for the driver. -- You received this bug notification

[Qemu-devel] [Bug 1635339] Re: qxl_pre_save assertion failure on vm "save"

2017-04-19 Thread Frediano Ziglio
Next version of the driver will solve the problem (already fixed in master). -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1635339 Title: qxl_pre_save assertion failure on vm "save" Status in

[Qemu-devel] [Bug 1635339] Re: qxl_pre_save assertion failure on vm "save"

2017-04-10 Thread Frediano Ziglio
Is this problem limited to commands or also to data attached to the commands? To me looks like a limitation Qemu should remove on the long run. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1635339

Re: [Qemu-devel] [PATCH] ui/egl-helpers: fix egl 1.5 display init

2017-03-17 Thread Frediano Ziglio
6fec028e60a. See the > >> longish comment for the complete story. > >> > >> Cc: Frediano Ziglio <fzig...@redhat.com> > >> Suggested-by: Hans de Goede <hdego...@redhat.com> > >> Signed-off-by: Gerd Hoffmann <kra...@redhat.com> > >&g

Re: [Qemu-devel] [PATCH] egl-helpers: Support newer MESA versions

2017-03-13 Thread Frediano Ziglio
> > > > Hi, > > On 20-02-17 10:50, Frediano Ziglio wrote: > > According to > > https://www.khronos.org/registry/EGL/extensions/MESA/EGL_MESA_platform_gbm.txt > > if MESA_platform_gbm is supported display should be initialized > > from a GBM handle usin

[Qemu-devel] [PATCH] egl-helpers: Support newer MESA versions

2017-02-20 Thread Frediano Ziglio
According to https://www.khronos.org/registry/EGL/extensions/MESA/EGL_MESA_platform_gbm.txt if MESA_platform_gbm is supported display should be initialized from a GBM handle using eglGetPlatformDisplayEXT. Signed-off-by: Frediano Ziglio <fzig...@redhat.com> --- This should fi

[Qemu-devel] [PATCH v2] egl-helpers: Change file licensing to LGPLv2

2016-12-08 Thread Frediano Ziglio
The relicense permits sharing the code with Spice which is LGPL. All people listed below have agreed to the relicense: - Arei Gonglei; - Cole Robinson; - Gerd Hoffmann; - Peter Maydell. Signed-off-by: Frediano Ziglio <fzig...@redhat.com> Acked-by: Cole Robinson <crobi...@redhat.com>

[Qemu-devel] [PATCH v2] usb: Fix typo in documentation

2016-12-07 Thread Frediano Ziglio
simliar -> similar Signed-off-by: Frediano Ziglio <fzig...@redhat.com> --- docs/usb-storage.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Changes since v1: - extend commit message diff --git a/docs/usb-storage.txt b/docs/usb-storage.txt index fbc1f2e..551af6f 100644 --- a

[Qemu-devel] [PATCH] egl-helpers: Change file licensing to LGPL2

2016-12-07 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio <fzig...@redhat.com> --- ui/egl-helpers.c | 16 1 file changed, 16 insertions(+) diff --git a/ui/egl-helpers.c b/ui/egl-helpers.c index 79cee05..cd24568 100644 --- a/ui/egl-helpers.c +++ b/ui/egl-helpers.c @@ -1,3 +1,19 @@ +/* + * Copyri

[Qemu-devel] [PATCH] usb: Fix typo in documentation

2016-12-07 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio <fzig...@redhat.com> --- docs/usb-storage.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/usb-storage.txt b/docs/usb-storage.txt index fbc1f2e..551af6f 100644 --- a/docs/usb-storage.txt +++ b/docs/usb-storage.txt @@ -34,7

[Qemu-devel] ui/egl-helpers.c license and reuse

2016-12-06 Thread Frediano Ziglio
Hi, I work in the SPICE team (www.spice-space.org). I'd like to reuse some code from this file for some test for our project. The license of the 2 projects are a bit different (GPL2 against LGPL2) so in theory I couldn't do it. The code is mainly doing EGL initialization. Could I obtain a

[Qemu-devel] [Bug 1606899] Re: virtio-vga does not let guest poweroff properly

2016-07-28 Thread Frediano Ziglio
Removed the parameters, now the command line is /usr/bin/qemu-system-x86_64 -machine accel=kvm -name rawhide -machine pc-i440fx-2.3,accel=kvm,usb=off -cpu Haswell-noTSX -m 2048 -realtime mlock=off -smp 2,sockets=2,cores=1,threads=1 -uuid 64216421-aec4-4ce4-aa52-aed9e4e31a1c -no-user-config

[Qemu-devel] [Bug 1606899] [NEW] virtio-vga does not let guest poweroff properly

2016-07-27 Thread Frediano Ziglio
Public bug reported: I have a VM running rawhide (Fedora development) and I can't poweroff the machine when I enable virtio-vga. Reboot works correctly. Using QXL works also. The machine arrive to print the "Powering off" message (from Linux kernel) but then hangs. The command line is

Re: [Qemu-devel] [Spice-devel] [PATCH Qemu] Change spice-server protocol for GL texture passing

2016-07-21 Thread Frediano Ziglio
> > On Tue, Jul 19, 2016 at 09:41:22AM -0400, Frediano Ziglio wrote: > > > I don't think we have strong reasons to support software encoding, video > > > encoding is really expensive, and that mmap/copy is not going to be > > > marginal, so even less these 2 s

Re: [Qemu-devel] [Spice-devel] [PATCH Qemu] Change spice-server protocol for GL texture passing

2016-07-19 Thread Frediano Ziglio
> Hi > > - Original Message - > > > > > > Hi > > > > > > - Original Message - > > > > Forgot to add RFC to the subject > > > > > > > > > > What's the rationale? if you share the texture id, you must share the GL > > > context too, right? Why not use a lower level dmabuf fd

Re: [Qemu-devel] [Spice-devel] [PATCH Qemu] Change spice-server protocol for GL texture passing

2016-07-19 Thread Frediano Ziglio
> > Hi > > - Original Message - > > Forgot to add RFC to the subject > > > > What's the rationale? if you share the texture id, you must share the GL > context too, right? Why not use a lower level dmabuf fd that can be imported > by the server gl context (which is also what the

Re: [Qemu-devel] [PATCH Qemu] Change spice-server protocol for GL texture passing

2016-07-15 Thread Frediano Ziglio
Forgot to add RFC to the subject Frediano > > --- > ui/spice-core.c| 5 - > ui/spice-display.c | 29 - > 2 files changed, 8 insertions(+), 26 deletions(-) > > diff --git a/ui/spice-core.c b/ui/spice-core.c > index da05054..f7647f7 100644 > ---

[Qemu-devel] [PATCH Qemu] Change spice-server protocol for GL texture passing

2016-07-15 Thread Frediano Ziglio
--- ui/spice-core.c| 5 - ui/spice-display.c | 29 - 2 files changed, 8 insertions(+), 26 deletions(-) diff --git a/ui/spice-core.c b/ui/spice-core.c index da05054..f7647f7 100644 --- a/ui/spice-core.c +++ b/ui/spice-core.c @@ -828,11 +828,6 @@ void

[Qemu-devel] [PATCH] vnc: send cursor when a new client is connecting

2016-03-02 Thread Frediano Ziglio
If you have hardware cursor and you are reconnecting the VNC client you need to send the cursor. Failing to do so make the cursor invisible till is changed. Signed-off-by: Frediano Ziglio <fzig...@redhat.com> --- ui/vnc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ui/vnc.c b/ui

[Qemu-devel] [PATCH] qxl: Fix new function name for spice-server library

2015-07-20 Thread Frediano Ziglio
The new spice-server function to limit the number of monitors (0.12.6) changed while development from spice_qxl_set_monitors_config_limit to spice_qxl_max_monitors (accepted upstream). By mistake I post patch with former name. This patch fix the function name. Signed-off-by: Frediano Ziglio fzig

Re: [Qemu-devel] [PATCH v3] qxl: allow to specify head limit to qxl driver

2015-07-14 Thread Frediano Ziglio
Hi, This patch rely on some change in spice-protocol which are not still accepted. See http://lists.freedesktop.org/archives/spice-devel/2015-June/020221.html. What is the upstream status here? accepted meanwhile? cheers, Gerd Accepted and merged, see patch at

Re: [Qemu-devel] [PATCH v3] qxl: allow to specify head limit to qxl driver

2015-07-13 Thread Frediano Ziglio
Ping - Original Message - From: Frediano Ziglio fzig...@redhat.com To: kra...@redhat.com, spice-de...@lists.freedesktop.org, berra...@redhat.com Cc: qemu-devel@nongnu.org, Frediano Ziglio fzig...@redhat.com Sent: Monday, July 6, 2015 7:56:38 AM Subject: [Qemu-devel] [PATCH v3] qxl

[Qemu-devel] [PATCH v3] qxl: allow to specify head limit to qxl driver

2015-07-06 Thread Frediano Ziglio
could be confusing). This patch rely on some change in spice-protocol which are not still accepted. See http://lists.freedesktop.org/archives/spice-devel/2015-June/020221.html. Signed-off-by: Frediano Ziglio fzig...@redhat.com --- hw/display/qxl.c | 26 +- hw/display/qxl.h

Re: [Qemu-devel] [Qemu-trivial] [PATCH 2/2] Check value for invalid negative values

2015-06-18 Thread Frediano Ziglio
is able to optimize if (v 0 || v = l) with if ((unsigned) v = l) Frediano 11.06.2015 16:17, Frediano Ziglio wrote: In qxl_v2n check that value is not negative. Why do you think it is necessary? Thanks, /mjt Signed-off-by: Frediano Ziglio fzig...@redhat.com --- hw/display/qxl

Re: [Qemu-devel] [Qemu-trivial] [PATCH 2/2] Check value for invalid negative values

2015-06-18 Thread Frediano Ziglio
On Do, 2015-06-18 at 05:58 -0400, Frediano Ziglio wrote: For the same reason there is the v = l test. The v = l test state that the value can be out of range so it not always a constant in the range. Adding the v 0 check for every invalid value. As these are executed only for logging

Re: [Qemu-devel] [PATCH v2] RFC: qxl: allow to specify head limit to qxl driver

2015-06-12 Thread Frediano Ziglio
On Do, 2015-06-11 at 10:38 +0100, Frediano Ziglio wrote: libvirt has this as a video card parameter (actually set to 1 but not used). This parameter will allow to limit setting a use can do (which could be confusing). Hmm. So heads is '1' by default but ignored today. When

[Qemu-devel] [RFC PATCH v2] qxl: allows to specify head limit to qxl driver

2015-06-12 Thread Frediano Ziglio
could be confusing). This patch rely on some change in spice-protocol which are not still accepted. See http://lists.freedesktop.org/archives/spice-devel/2015-June/020221.html. Signed-off-by: Frediano Ziglio fzig...@redhat.com --- hw/display/qxl.c | 26 +- hw/display/qxl.h

[Qemu-devel] [PATCH 1/2] Constify some variable

2015-06-11 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio fzig...@redhat.com --- hw/display/qxl-logger.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/hw/display/qxl-logger.c b/hw/display/qxl-logger.c index c900c2c..d944d3f 100644 --- a/hw/display/qxl-logger.c +++ b/hw/display/qxl

[Qemu-devel] [PATCH 2/2] Check value for invalid negative values

2015-06-11 Thread Frediano Ziglio
In qxl_v2n check that value is not negative. Signed-off-by: Frediano Ziglio fzig...@redhat.com --- hw/display/qxl-logger.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/display/qxl-logger.c b/hw/display/qxl-logger.c index d944d3f..faed869 100644 --- a/hw/display/qxl

[Qemu-devel] [PATCH v2] RFC: qxl: allow to specify head limit to qxl driver

2015-06-11 Thread Frediano Ziglio
could be confusing). This patch rely on some change in spice-protocol which are not still accepted. See http://lists.freedesktop.org/archives/spice-devel/2015-June/020221.html. Signed-off-by: Frediano Ziglio fzig...@redhat.com --- hw/display/qxl.c | 20 +++- hw/display/qxl.h | 1

Re: [Qemu-devel] [PATCH] RFC: qxl: allow to specify head limit to qxl driver

2015-06-09 Thread Frediano Ziglio
2015-06-09 10:12 GMT+01:00 Gerd Hoffmann kra...@redhat.com: On Di, 2015-06-09 at 09:49 +0100, Frediano Ziglio wrote: This patch allow to limit number of heads using qxl driver. By default qxl driver is not limited on any kind on head use so can decide to use as much heads. There is a hard

Re: [Qemu-devel] [PATCH] RFC: qxl: allow to specify head limit to qxl driver

2015-06-09 Thread Frediano Ziglio
2015-06-09 10:43 GMT+01:00 Gerd Hoffmann kra...@redhat.com: On Di, 2015-06-09 at 10:26 +0100, Frediano Ziglio wrote: 2015-06-09 10:12 GMT+01:00 Gerd Hoffmann kra...@redhat.com: On Di, 2015-06-09 at 09:49 +0100, Frediano Ziglio wrote: This patch allow to limit number of heads using qxl driver

[Qemu-devel] [PATCH] RFC: qxl: allow to specify head limit to qxl driver

2015-06-09 Thread Frediano Ziglio
looking anyway to a way to enforce this in spice-server. Signed-off-by: Frediano Ziglio fzig...@redhat.com --- hw/display/qxl.c | 6 ++ hw/display/qxl.h | 1 + 2 files changed, 7 insertions(+) diff --git a/hw/display/qxl.c b/hw/display/qxl.c index b220e2d..e9ccd30 100644 --- a/hw/display/qxl.c

Re: [Qemu-devel] [RFC PATCH v3] tests: rtl8139: test timers and interrupt

2015-02-06 Thread Frediano Ziglio
2015-02-06 16:54 GMT+00:00 Stefan Hajnoczi stefa...@redhat.com: On Thu, Jan 08, 2015 at 06:38:23PM +, Frediano Ziglio wrote: Test behaviour of timers and interrupts related to timeouts. Signed-off-by: Frediano Ziglio fredd...@gmail.com --- tests/Makefile | 2 +- tests/rtl8139

Re: [Qemu-devel] [RFC PATCH v3] tests: rtl8139: test timers and interrupt

2015-01-22 Thread Frediano Ziglio
2015-01-20 13:36 GMT+00:00 Paolo Bonzini pbonz...@redhat.com: On 08/01/2015 19:38, Frediano Ziglio wrote: Test behaviour of timers and interrupts related to timeouts. Signed-off-by: Frediano Ziglio fredd...@gmail.com --- tests/Makefile | 2 +- tests/rtl8139-test.c | 181

Re: [Qemu-devel] [PATCH 2/2] qemu-common.h: optimise muldiv64 for x86_64 architecture

2015-01-09 Thread Frediano Ziglio
2015-01-09 12:22 GMT+00:00 Peter Maydell peter.mayd...@linaro.org: On 9 January 2015 at 11:25, Frediano Ziglio fredd...@gmail.com wrote: As this platform can do multiply/divide using 128 bit precision use these instructions to implement it. Signed-off-by: Frediano Ziglio frediano.zig

Re: [Qemu-devel] [PATCH 2/2] qemu-common.h: optimise muldiv64 for x86_64 architecture

2015-01-09 Thread Frediano Ziglio
2015-01-09 15:52 GMT+00:00 Peter Maydell peter.mayd...@linaro.org: On 9 January 2015 at 15:41, Frediano Ziglio fredd...@gmail.com wrote: 2015-01-09 12:22 GMT+00:00 Peter Maydell peter.mayd...@linaro.org: +/* Optimised x64 version. This assume that a*b/c fits in 64 bit */ This assumption isn't

[Qemu-devel] [PATCH] x86_64: optimise muldiv64 for x86_64 architecture

2015-01-09 Thread Frediano Ziglio
As this platform can do multiply/divide using 128 bit precision use these instruction to implement it. Signed-off-by: Frediano Ziglio frediano.zig...@huawei.com --- include/qemu-common.h | 13 + 1 file changed, 13 insertions(+) diff --git a/include/qemu-common.h b/include/qemu

Re: [Qemu-devel] [PATCH] x86_64: optimise muldiv64 for x86_64 architecture

2015-01-09 Thread Frediano Ziglio
2015-01-09 11:24 GMT+00:00 Paolo Bonzini pbonz...@redhat.com: On 09/01/2015 12:04, Frediano Ziglio wrote: 2015-01-09 10:35 GMT+00:00 Paolo Bonzini pbonz...@redhat.com: On 09/01/2015 11:27, Frediano Ziglio wrote: Signed-off-by: Frediano Ziglio frediano.zig...@huawei.com --- include/qemu

Re: [Qemu-devel] [PATCH 2/2] qemu-common.h: optimise muldiv64 for x86_64 architecture

2015-01-09 Thread Frediano Ziglio
2015-01-09 11:43 GMT+00:00 Paolo Bonzini pbonz...@redhat.com: On 09/01/2015 12:25, Frediano Ziglio wrote: /* compute with 96 bit intermediate result: (a*b)/c */ -#ifdef CONFIG_INT128 +#if defined(CONFIG_INT128) !defined(__x86_64__) static inline uint64_t muldiv64(uint64_t a, uint32_t b

[Qemu-devel] [PATCH] x86_64: optimise muldiv64 for x86_64 architecture

2015-01-09 Thread Frediano Ziglio
As this platform can do multiply/divide using 128 bit precision use these instruction to implement it. Signed-off-by: Frediano Ziglio frediano.zig...@huawei.com --- include/qemu-common.h | 13 + 1 file changed, 13 insertions(+) diff --git a/include/qemu-common.h b/include/qemu

[Qemu-devel] [PATCH 1/2] qemu-common.h: optimise muldiv64 if int128 is available

2015-01-09 Thread Frediano Ziglio
Let compiler do the job to optimise the function. Signed-off-by: Frediano Ziglio frediano.zig...@huawei.com --- include/qemu-common.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/qemu-common.h b/include/qemu-common.h index f862214..f3033ae 100644 --- a/include/qemu-common.h

Re: [Qemu-devel] [PATCH] x86_64: optimise muldiv64 for x86_64 architecture

2015-01-09 Thread Frediano Ziglio
2015-01-09 10:35 GMT+00:00 Paolo Bonzini pbonz...@redhat.com: On 09/01/2015 11:27, Frediano Ziglio wrote: Signed-off-by: Frediano Ziglio frediano.zig...@huawei.com --- include/qemu-common.h | 13 + 1 file changed, 13 insertions(+) diff --git a/include/qemu-common.h b/include

[Qemu-devel] [PATCH 2/2] qemu-common.h: optimise muldiv64 for x86_64 architecture

2015-01-09 Thread Frediano Ziglio
As this platform can do multiply/divide using 128 bit precision use these instructions to implement it. Signed-off-by: Frediano Ziglio frediano.zig...@huawei.com --- include/qemu-common.h | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/include/qemu-common.h b

[Qemu-devel] [PATCH 1/2] qemu-common.h: optimise muldiv64 if int128 is available

2015-01-09 Thread Frediano Ziglio
Let compiler do the job to optimise the function. Signed-off-by: Frediano Ziglio frediano.zig...@huawei.com --- include/qemu-common.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/qemu-common.h b/include/qemu-common.h index f862214..f3033ae 100644 --- a/include/qemu-common.h

[Qemu-devel] [RFC PATCH v3] tests: rtl8139: test timers and interrupt

2015-01-08 Thread Frediano Ziglio
Test behaviour of timers and interrupts related to timeouts. Signed-off-by: Frediano Ziglio fredd...@gmail.com --- tests/Makefile | 2 +- tests/rtl8139-test.c | 181 +++ 2 files changed, 182 insertions(+), 1 deletion(-) This patch

[Qemu-devel] [RFC PATCH v2] tests: rtl8139: test timers and interrupt

2015-01-07 Thread Frediano Ziglio
Test behaviour of timers and interrupts related to timeouts. Signed-off-by: Frediano Ziglio fredd...@gmail.com --- tests/Makefile | 2 +- tests/rtl8139-test.c | 180 +++ 2 files changed, 181 insertions(+), 1 deletion(-) This patch

  1   2   3   >