-
hw/arm/aspeed_ast2600.c | 6 +-
hw/arm/aspeed_soc_common.c | 5 -
6 files changed, 27 insertions(+), 6 deletions(-)
Reviewed-by: Gavin Shan
/arm/aspeed_ast10x0.c | 2 +-
hw/arm/aspeed_ast2400.c | 3 ++-
hw/arm/aspeed_ast2600.c | 3 ++-
hw/arm/aspeed_soc_common.c | 5 +
5 files changed, 11 insertions(+), 3 deletions(-)
Reviewed-by: Gavin Shan
insertions(+), 43 deletions(-)
One nit needs to be addressed:
Reviewed-by: Gavin Shan
diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
index 5b01a4dd28..636a6269aa 100644
--- a/hw/arm/aspeed.c
+++ b/hw/arm/aspeed.c
@@ -1141,10 +1141,14 @@ static void aspeed_machine_class_props_init(ObjectClass
*oc
oc:
Add AST1030 support") and supermicrox11-bmc (commit 40a38df55e
"hw/arm/aspeed: Add board model for Supermicro X11 BMC") machines.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/arm/aspeed.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
Reviewed-by: Gavin Shan
On 1/24/24 08:48, Philippe Mathieu-Daudé wrote:
Remove copy/paste typo from commit 6c323aba40 ("hw/arm/aspeed:
Adding new machine Tiogapass in QEMU").
Signed-off-by: Philippe Mathieu-Daudé
---
hw/arm/aspeed.c | 1 -
1 file changed, 1 deletion(-)
Reviewed-by: Gavin Shan
On 1/24/24 08:25, Philippe Mathieu-Daudé wrote:
Restrict MachineClass::valid_cpu_types[] to the single
valid CPU type.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/arm/xilinx_zynq.c | 5 +
1 file changed, 5 insertions(+)
Reviewed-by: Gavin Shan
On 1/24/24 08:25, Philippe Mathieu-Daudé wrote:
Restrict MachineClass::valid_cpu_types[] to the single
valid CPU types.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/arm/vexpress.c | 10 ++
1 file changed, 10 insertions(+)
Reviewed-by: Gavin Shan
-Daudé
---
hw/arm/highbank.c | 10 ++
1 file changed, 10 insertions(+)
Reviewed-by: Gavin Shan
On 1/24/24 08:25, Philippe Mathieu-Daudé wrote:
QDev objects created with qdev_new() need to manually add
their parent relationship with object_property_add_child().
Signed-off-by: Philippe Mathieu-Daudé
---
hw/arm/highbank.c | 1 +
1 file changed, 1 insertion(+)
Reviewed-by: Gavin Shan
-by: Philippe Mathieu-Daudé
---
hw/arm/exynos4_boards.c | 8
1 file changed, 8 insertions(+)
Reviewed-by: Gavin Shan
On 1/24/24 08:25, Philippe Mathieu-Daudé wrote:
QDev objects created with qdev_new() need to manually add
their parent relationship with object_property_add_child().
Signed-off-by: Philippe Mathieu-Daudé
---
hw/arm/exynos4210.c | 1 +
1 file changed, 1 insertion(+)
Reviewed-by: Gavin
Hi Phil,
On 1/11/24 18:21, Philippe Mathieu-Daudé wrote:
On 11/1/24 08:30, Gavin Shan wrote:
On 1/11/24 16:47, Philippe Mathieu-Daudé wrote:
Per cpu_model_from_type() docstring (added in commit 445946f4dd):
* Returns: CPU model name or NULL if the CPU class doesn't exist
We must check
Hi Phil,
On 1/11/24 16:47, Philippe Mathieu-Daudé wrote:
Per cpu_model_from_type() docstring (added in commit 445946f4dd):
* Returns: CPU model name or NULL if the CPU class doesn't exist
We must check the return value in order to avoid surprises, i.e.:
$ qemu-system-arm -machine virt
Hi Peter,
On 1/10/24 00:33, Peter Maydell wrote:
On Fri, 5 Jan 2024 at 15:46, Philippe Mathieu-Daudé wrote:
From: Gavin Shan
Set mc->valid_cpu_types so that the user specified CPU type can be
validated in machine_run_board_init(). We needn't to do the check
by ourselves.
Hi; af
, cortex-a55,
cortex-a72, cortex-a76, cortex-a710, a64fx, neoverse-n1, neoverse-v1,
neoverse-n2, cortex-a53, cortex-a57, max
Reported-by: Peter Maydell
Fixes: fa8c617791 ("hw/arm/virt: Check CPU type in machine_run_board_init()")
Signed-off-by: Gavin Shan
---
hw/arm/virt.c | 8 ++--
1 fi
Hi Phil,
On 1/6/24 08:12, Philippe Mathieu-Daudé wrote:
On 13/12/23 11:54, Gavin Shan wrote:
On 12/13/23 20:08, Philippe Mathieu-Daudé wrote:
On 12/12/23 05:55, Gavin Shan wrote:
On 12/4/23 10:47, Gavin Shan wrote:
This series bases on Phil's repository because the prepatory commits
have
On 1/6/24 08:09, Philippe Mathieu-Daudé wrote:
On 4/12/23 01:47, Gavin Shan wrote:
It's no sense to check the CPU type when mc->valid_cpu_types[0] is
NULL, which is a program error. Raise an assert on this.
A precise hint for the error message is given when mc->valid_cpu_types[0]
is th
On 1/5/24 21:00, Philippe Mathieu-Daudé wrote:
On 4/12/23 01:47, Gavin Shan wrote:
Functions that use an Error **errp parameter to return errors should
not also report them to the user, because reporting is the caller's
job. The principle is violated by machine_run_board_init() because
it calls
On 12/13/23 20:08, Philippe Mathieu-Daudé wrote:
On 12/12/23 05:55, Gavin Shan wrote:
On 12/4/23 10:47, Gavin Shan wrote:
This series bases on Phil's repository because the prepatory commits
have been queued to the branch.
https://gitlab.com/philmd/qemu.git (branch: cpus-next
Hi Phil,
On 12/4/23 10:47, Gavin Shan wrote:
This series bases on Phil's repository because the prepatory commits
have been queued to the branch.
https://gitlab.com/philmd/qemu.git (branch: cpus-next)
There are two places where the user specified CPU type is checked to see
if it's
Hi Shaoqin,
On 12/7/23 20:36, Shaoqin Huang wrote:
The KVM_ARM_VCPU_PMU_V3_FILTER provide the ability to let the VMM decide
^^^
provides
which PMU events are provided to the guest. Add a new option
`pmu-filter` as -accel
+ !memory_region_init_rom_device(mr, owner, arg3, arg4, arg5, arg6, )
) {
...
return;
}
and removing the local Error variable.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/nvram/nrf51_nvm.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
Reviewed-by: Gavin Shan
changed, 4 insertions(+), 2 deletions(-)
Reviewed-by: Gavin Shan
+ !memory_region_init_ram_from_fd(mr, owner, arg3, arg4, arg5, arg6, arg7,
)
) {
...
return;
}
and removing the local Error variable.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/misc/ivshmem.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
Reviewed-by: Gavin
(-)
Reviewed-by: Gavin Shan
, arg4, )
) {
...
return;
}
and removing the local Error variable.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/sparc/sun4m.c | 20 ++--
hw/sparc64/sun4u.c | 7 ++-
2 files changed, 8 insertions(+), 19 deletions(-)
Reviewed-by: Gavin Shan
++
hw/arm/integratorcp.c | 7 ++-
hw/arm/nrf51_soc.c | 7 ++-
hw/ppc/rs6000_mc.c | 7 ++-
8 files changed, 16 insertions(+), 35 deletions(-)
Reviewed-by: Gavin Shan
On 11/21/23 07:32, Philippe Mathieu-Daudé wrote:
Signed-off-by: Philippe Mathieu-Daudé
---
backends/hostmem.c | 22 +++---
hw/virtio/virtio-mem.c | 6 ++
2 files changed, 9 insertions(+), 19 deletions(-)
Reviewed-by: Gavin Shan
clude/qemu/osdep.h | 4 +++-
util/oslib-posix.c | 7 +--
util/oslib-win32.c | 4 +++-
3 files changed, 11 insertions(+), 4 deletions(-)
s/cpu_exec_realizefn()/qemu_prealloc_mem()
Reviewed-by: Gavin Shan
On 11/21/23 07:32, Philippe Mathieu-Daudé wrote:
Reduce the _err variable use and remove the 'out:' label.
Signed-off-by: Philippe Mathieu-Daudé
---
backends/hostmem.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Gavin Shan
deletions(-)
s/cpu_exec_realizefn()/HostMemoryBackendClass::alloc()
Reviewed-by: Gavin Shan
ppe Mathieu-Daudé
---
backends/hostmem.c | 133 +++--
1 file changed, 67 insertions(+), 66 deletions(-)
Reviewed-by: Gavin Shan
-memfd.c | 3 +--
backends/hostmem-ram.c | 3 +--
4 files changed, 4 insertions(+), 8 deletions(-)
Reviewed-by: Gavin Shan
clude/exec/memory.h | 4 +++-
system/memory.c | 4 +++-
2 files changed, 6 insertions(+), 2 deletions(-)
s/cpu_exec_realizefn()/memory_region_init_ram_from_fd()
Reviewed-by: Gavin Shan
clude/exec/memory.h | 4 +++-
system/memory.c | 4 +++-
2 files changed, 6 insertions(+), 2 deletions(-)
s/cpu_exec_realizefn()/memory_region_init_ram_from_file()
Reviewed-by: Gavin Shan
clude/exec/memory.h | 4 +++-
system/memory.c | 4 +++-
2 files changed, 6 insertions(+), 2 deletions(-)
s/cpu_exec_realizefn()/memory_region_init_resizeable_ram()
Reviewed-by: Gavin Shan
clude/exec/memory.h | 4 +++-
system/memory.c | 6 --
2 files changed, 7 insertions(+), 3 deletions(-)
With Peter Xu's comments addressed, to
s/cpu_exec_realizefn()/memory_region_init_rom_device()
in the commit messages.
Reviewed-by: Gavin Shan
+ !memory_region_init_rom_device_nomigrate(mr, owner, arg3, arg4, arg5, arg6,
)
) {
...
return;
}
and removing the local Error variable.
Signed-off-by: Philippe Mathieu-Daudé
---
system/memory.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
Reviewed-by: Gavin Shan
clude/exec/memory.h | 4 +++-
system/memory.c | 4 +++-
2 files changed, 6 insertions(+), 2 deletions(-)
s/cpu_exec_realizefn()/memory_region_init_rom_device_nomigrate()
Reviewed-by: Gavin Shan
clude/exec/memory.h | 4 +++-
system/memory.c | 6 --
2 files changed, 7 insertions(+), 3 deletions(-)
s/cpu_exec_realizefn()/memory_region_init_rom()
Reviewed-by: Gavin Shan
clude/exec/memory.h | 4 +++-
system/memory.c | 6 --
2 files changed, 7 insertions(+), 3 deletions(-)
With Peter Xu's comments addressed:
Reviewed-by: Gavin Shan
+ !memory_region_init_ram_from_fd(mr, owner, arg3, arg4, arg5, arg6, arg7,
)
) {
...
return;
}
and removing the local Error variable.
Signed-off-by: Philippe Mathieu-Daudé
---
system/memory.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
Reviewed-by: Gavin Shan
, arg4, )
) {
...
return;
}
and removing the local Error variable.
Signed-off-by: Philippe Mathieu-Daudé
---
system/memory.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
Reviewed-by: Gavin Shan
clude/exec/memory.h | 4 +++-
system/memory.c | 8 ++--
2 files changed, 9 insertions(+), 3 deletions(-)
s/cpu_exec_realizefn()/memory_region_init_rom_nomigrate() in the
commit message, mentioned by Peter Xu. With this:
Reviewed-by: Gavin Shan
clude/exec/memory.h | 4 +++-
system/memory.c | 5 +++--
2 files changed, 6 insertions(+), 3 deletions(-)
s/cpu_exec_realizefn()/memory_region_init_ram_nomigrate() for the commit
message, as mentioned by Peter Xu.
Reviewed-by: Gavin Shan
clude/exec/memory.h | 4 +++-
system/memory.c | 4 +++-
2 files changed, 6 insertions(+), 2 deletions(-)
With Peter Xu's comments addressed, to replace cpu_exec_realizefn()
with memory_region_init_ram_flags_nomigrate() in the commit log.
Reviewed-by: Gavin Shan
On 12/2/23 00:32, Philippe Mathieu-Daudé wrote:
Do not open-code the generic kvm_supports_guest_debug().
Signed-off-by: Philippe Mathieu-Daudé
---
target/arm/kvm64.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
Reviewed-by: Gavin Shan
On 12/2/23 00:32, Philippe Mathieu-Daudé wrote:
kvm_supports_guest_debug() should be accessible by KVM
implementations.
Signed-off-by: Philippe Mathieu-Daudé
---
accel/kvm/kvm-cpus.h | 1 -
include/sysemu/kvm.h | 1 +
2 files changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Gavin
Set mc->valid_cpu_types so that the user specified CPU type can be
validated in machine_run_board_init(). We needn't to do the check
by ourselves.
Signed-off-by: Gavin Shan
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
---
hw/arm/virt.c |
ple valid entries there is avoided to increase the code
readability, as suggested by Philippe Mathieu-Daudé.
Besides, @cc comes from machine->cpu_type or mc->default_cpu_type. For
the later case, it can be NULL and it's also a program error. We should
use assert() in this case.
Signed-off-by:
The names of supported CPU models instead of CPU types should be
printed when the user specified CPU type isn't supported, to be
consistent with the output from '-cpu ?'.
Correct the error messages to print CPU model names instead of CPU
type names.
Signed-off-by: Gavin Shan
Reviewed
Set mc->valid_cpu_types so that the user specified CPU type can
be validated in machine_run_board_init(). We needn't to do it
by ourselves.
Signed-off-by: Gavin Shan
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Leif Lindholm
Reviewed-by: Richard Henderson
---
hw/arm/sbsa-ref.c |
Set mc->valid_cpu_types so that the user specified CPU type can
be validated in machine_run_board_init(). We needn't to do it
by ourselves.
Signed-off-by: Gavin Shan
Reviewed-by: Philippe Mathieu-Daudé
---
hw/riscv/shakti_c.c | 13 ++---
1 file changed, 6 insertions(+), 7 deleti
of code. The comments are tweaked a bit
either.
No functional change intended.
Signed-off-by: Gavin Shan
Reviewed-by: Philippe Mathieu-Daudé
---
hw/core/machine.c | 83 +--
1 file changed, 45 insertions(+), 38 deletions(-)
diff --git a/hw/core
Set mc->valid_cpu_types so that the user specified CPU type can
be validated in machine_run_board_init(). We needn't to do it by
ourselves.
Signed-off-by: Gavin Shan
Reviewed-by: Richard Henderson
Reviewed-by: Philippe Mathieu-Daudé
---
hw/arm/bananapi_m2u.c | 12 ++--
hw/
.
qemu-system-aarch64: Invalid CPU type: cortex-a8
The valid types are: cortex-a7, cortex-a15, cortex-a35, \
cortex-a55, cortex-a72, cortex-a76, cortex-a710, a64fx, \
neoverse-n1, neoverse-v1, neoverse-n2, cortex-a53, \
cortex-a57, max
Signed-off-by: Gavin Shan
Reviewed-by: Richard
(Phil)
* Clearer hint if only one CPU type is supported and have
'const MachineState *' in is_cpu_type_supported()(Phil)
* Move valid_cpu_types[] to board's class_init() function (Phil)
Gavin Shan (9):
machine: Use error handling when CPU type is checked
machine: Introdu
the requested CPU type.
Clean this up by using error_setg() and error_append_hint() instead.
No functional change, as the only caller passes _fatal.
Suggested-by: Igor Mammedov
Signed-off-by: Gavin Shan
Reviewed-by: Markus Armbruster
---
v9: Improved change log (Markus
Hi Phil,
On 12/4/23 09:20, Gavin Shan wrote:
On 12/1/23 20:57, Philippe Mathieu-Daudé wrote:
On 29/11/23 05:20, Gavin Shan wrote:
It's no sense to check the CPU type when mc->valid_cpu_types[0] is
NULL.
This case is a programming error, right? We should simply:
assert(
Hi Phil
On 12/1/23 20:57, Philippe Mathieu-Daudé wrote:
On 29/11/23 05:20, Gavin Shan wrote:
It's no sense to check the CPU type when mc->valid_cpu_types[0] is
NULL.
This case is a programming error, right? We should simply:
assert(!mc->valid_cpu_types || *mc->valid_cpu_types
Hi Phil,
On 12/1/23 20:53, Philippe Mathieu-Daudé wrote:
On 29/11/23 05:20, Gavin Shan wrote:
The logic, to check if the specified CPU type is supported in
machine_run_board_init(), is independent enough. Factor it out into
helper is_cpu_type_supported(). machine_run_board_init() looks a bit
Hi Shaoqin,
On 11/29/23 14:08, Shaoqin Huang wrote:
The KVM_ARM_VCPU_PMU_V3_FILTER provide the ability to let the VMM decide
which PMU events are provided to the guest. Add a new option
`pmu-filter` as -accel sub-option to set the PMU Event Filtering.
Without the filter, the KVM will expose all
Hi Markus,
On 11/29/23 19:20, Markus Armbruster wrote:
Gavin Shan writes:
QEMU will be terminated if the specified CPU type isn't supported
in machine_run_board_init(). The list of supported CPU type names
is tracked by mc->valid_cpu_types.
Suggest to drop the second sentence.
Ind
Set mc->valid_cpu_types so that the user specified CPU type can
be validated in machine_run_board_init(). We needn't to do it
by ourselves.
Signed-off-by: Gavin Shan
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Leif Lindholm
Reviewed-by: Richard Henderson
---
hw/arm/sbsa-ref.c |
Set mc->valid_cpu_types so that the user specified CPU type can
be validated in machine_run_board_init(). We needn't to do it
by ourselves.
Signed-off-by: Gavin Shan
Reviewed-by: Philippe Mathieu-Daudé
---
hw/riscv/shakti_c.c | 13 ++---
1 file changed, 6 insertions(+), 7 deleti
.
qemu-system-aarch64: Invalid CPU type: cortex-a8
The valid types are: cortex-a7, cortex-a15, cortex-a35, \
cortex-a55, cortex-a72, cortex-a76, cortex-a710, a64fx, \
neoverse-n1, neoverse-v1, neoverse-n2, cortex-a53, \
cortex-a57, max
Signed-off-by: Gavin Shan
Reviewed-by: Richard
of code. The comments are tweaked a bit
either.
No functional change intended.
Signed-off-by: Gavin Shan
---
v8: Move the precise message hint to PATCH[v8 3/9](Gavin)
---
hw/core/machine.c | 83 +--
1 file changed, 45 insertions(+), 38
Set mc->valid_cpu_types so that the user specified CPU type can
be validated in machine_run_board_init(). We needn't to do it by
ourselves.
Signed-off-by: Gavin Shan
Reviewed-by: Richard Henderson
Reviewed-by: Philippe Mathieu-Daudé
---
hw/arm/bananapi_m2u.c | 12 ++--
hw/
The names of supported CPU models instead of CPU types should be
printed when the user specified CPU type isn't supported, to be
consistent with the output from '-cpu ?'.
Correct the error messages to print CPU model names instead of CPU
type names.
Signed-off-by: Gavin Shan
---
v8: Use
esides, enumeration on mc->valid_cpu_types[0]
when we have mutiple valid entries there is avoided to increase the code
readability, as suggested by Philippe Mathieu-Daudé.
Signed-off-by: Gavin Shan
---
hw/core/machine.c | 18 --
1 file changed, 12 insertions(+), 6 deletions
Set mc->valid_cpu_types so that the user specified CPU type can be
validated in machine_run_board_init(). We needn't to do the check
by ourselves.
Signed-off-by: Gavin Shan
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
---
hw/arm/virt.c |
ons in the
same function.
No functional change intended.
Suggested-by: Igor Mammedov
Signed-off-by: Gavin Shan
---
v8: Drop @local_err and use @errp to be compatible with
ERRP_GUARD() (Phil)
---
hw/core/machine.c | 13 +++--
1 file changed
'const MachineState *' in is_cpu_type_supported()(Phil)
* Move valid_cpu_types[] to board's class_init() function (Phil)
Gavin Shan (9):
machine: Use error handling when CPU type is checked
machine: Introduce helper is_cpu_type_supported()
machine: Improve is_cpu_type_sup
Hi Phil,
On 11/28/23 20:55, Philippe Mathieu-Daudé wrote:
On 27/11/23 00:12, Gavin Shan wrote:
The names of supported CPU models instead of CPU types should be
printed when the user specified CPU type isn't supported, to be
consistent with the output from '-cpu ?'.
Correct the error messages
Hi Phil,
On 11/28/23 20:38, Philippe Mathieu-Daudé wrote:
On 27/11/23 00:12, Gavin Shan wrote:
The logic, to check if the specified CPU type is supported in
machine_run_board_init(), is independent enough. Factor it out into
helper is_cpu_type_supported(). machine_run_board_init() looks a bit
Hi Phil,
On 11/28/23 20:43, Philippe Mathieu-Daudé wrote:
On 27/11/23 00:12, Gavin Shan wrote:
QEMU will be terminated if the specified CPU type isn't supported
in machine_run_board_init(). The list of supported CPU type names
is tracked by mc->valid_cpu_types.
The error handling can be u
On 11/27/23 21:13, Marcin Juszkiewicz wrote:
W dniu 27.11.2023 o 00:12, Gavin Shan pisze:
@@ -2939,6 +2900,28 @@ static void virt_machine_class_init(ObjectClass *oc,
void *data)
{
MachineClass *mc = MACHINE_CLASS(oc);
HotplugHandlerClass *hc = HOTPLUG_HANDLER_CLASS(oc
On 11/27/23 21:10, Marcin Juszkiewicz wrote:
W dniu 27.11.2023 o 00:12, Gavin Shan pisze:
After the series is applied:
[gshan@gshan q]$ ./build/qemu-system-aarch64 -M virt -cpu cortex-a8
qemu-system-aarch64: Invalid CPU type: cortex-a8
The valid types are: cortex-a7, cortex-a15
target/arm/kvm.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
With the following comments addressed:
Reviewed-by: Gavin Shan
diff --git a/target/arm/kvm.c b/target/arm/kvm.c
index 1f6da5529f..cbfea689cc 100644
--- a/target/arm/kvm.c
+++ b/target/arm/kvm.c
@@ -145
target/arm/kvm.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Gavin Shan
arget/arm/kvm.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
Reviewed-by: Gavin Shan
target/arm/kvm.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Gavin Shan
arget/arm/kvm.c | 23 ++-
1 file changed, 10 insertions(+), 13 deletions(-)
Reviewed-by: Gavin Shan
arget/arm/kvm.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
Reviewed-by: Gavin Shan
target/arm/kvm.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Gavin Shan
arget/arm/kvm.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
Reviewed-by: Gavin Shan
et/arm/kvm_arm.h | 4 ++--
hw/arm/virt.c| 2 +-
target/arm/kvm.c | 6 +++---
3 files changed, 6 insertions(+), 6 deletions(-)
Reviewed-by: Gavin Shan
target/arm/kvm_arm.h | 4 ++--
hw/arm/virt.c| 2 +-
target/arm/kvm.c | 6 +++---
3 files changed, 6 insertions(+), 6 deletions(-)
One nit below, but I guess it doesn't matter.
Reviewed-by: Gavin Shan
diff --git a/target/arm/kvm_arm.h b/target/arm/kvm_arm.h
index 0e12a008a
et/arm/kvm_arm.h | 6 +++---
hw/arm/virt.c| 5 +++--
target/arm/kvm.c | 6 +++---
3 files changed, 9 insertions(+), 8 deletions(-)
Reviewed-by: Gavin Shan
arget/arm/kvm.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
Reviewed-by: Gavin Shan
Hi Phil,
On 11/24/23 05:35, Philippe Mathieu-Daudé wrote:
Unify the "kvm_arm.h" API: All functions related to ARM vCPUs
take a ARMCPU* argument. Use the CPU() QOM cast macro When
calling the generic vCPU API from "sysemu/kvm.h".
Signed-off-by: Philippe Mathieu-Daudé
---
target/arm/kvm_arm.h
target/arm/kvm.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
Reviewed-by: Gavin Shan
target/arm/kvm_arm.h | 4 ++--
target/arm/cpu.c | 2 +-
target/arm/kvm.c | 4 ++--
3 files changed, 5 insertions(+), 5 deletions(-)
With the following comments resolved:
Reviewed-by: Gavin Shan
diff --git a/target/arm/kvm_arm.h b/target/arm/kvm_arm.h
index 50967f4ae9..6fb8a5f67e
On 11/24/23 05:35, Philippe Mathieu-Daudé wrote:
Both MemoryRegion and Error types are forward declared
in "qemu/typedefs.h".
Signed-off-by: Philippe Mathieu-Daudé
---
target/arm/kvm_arm.h | 2 --
1 file changed, 2 deletions(-)
Reviewed-by: Gavin Shan
On 11/24/23 05:35, Philippe Mathieu-Daudé wrote:
kvm_arm_its_reset_hold() calls warn_report(), itself declared
in "qemu/error-report.h".
Signed-off-by: Philippe Mathieu-Daudé
---
hw/intc/arm_gicv3_its_kvm.c | 1 +
1 file changed, 1 insertion(+)
Reviewed-by: Gavin Shan
On 11/23/23 15:42, Richard Henderson wrote:
Signed-off-by: Richard Henderson
---
target/arm/kvm_arm.h | 2 --
target/arm/kvm.c | 2 +-
2 files changed, 1 insertion(+), 3 deletions(-)
Reviewed-by: Gavin Shan
deletions(-)
Reviewed-by: Gavin Shan
On 11/23/23 15:42, Richard Henderson wrote:
Signed-off-by: Richard Henderson
---
target/arm/kvm_arm.h | 20
target/arm/kvm.c | 20 ++--
2 files changed, 18 insertions(+), 22 deletions(-)
Reviewed-by: Gavin Shan
changed, 4 insertions(+), 17 deletions(-)
Reviewed-by: Gavin Shan
On 11/23/23 15:42, Richard Henderson wrote:
Signed-off-by: Richard Henderson
---
target/arm/kvm_arm.h | 12
target/arm/kvm.c | 10 --
2 files changed, 8 insertions(+), 14 deletions(-)
Reviewed-by: Gavin Shan
1 - 100 of 964 matches
Mail list logo
