Re: [RFC 3/3] acpi: cpuhp: add CPHP_GET_CPU_ID_CMD command

2019-10-22 Thread Igor Mammedov
On Tue, 22 Oct 2019 14:39:24 +0200 Laszlo Ersek wrote: > On 10/21/19 15:06, Laszlo Ersek wrote: > > On 10/18/19 18:18, Igor Mammedov wrote: > >> On Thu, 10 Oct 2019 16:56:18 +0200 > >> Laszlo Ersek wrote: > > [...] > > >>> Can I use the fo

Re: [PATCH v13 06/12] numa: Extend CLI to provide memory latency and bandwidth information

2019-10-22 Thread Igor Mammedov
On Sun, 20 Oct 2019 19:11:19 +0800 Tao Xu wrote: > From: Liu Jingqi > > Add -numa hmat-lb option to provide System Locality Latency and > Bandwidth Information. These memory attributes help to build > System Locality Latency and Bandwidth Information Structure(s) > in ACPI Heterogeneous Memory

Re: [PATCH v13 05/12] numa: Extend CLI to provide initiator information for numa nodes

2019-10-21 Thread Igor Mammedov
ng, use " > + "'-numa node,initiator' option to declare it.", i); > +goto err; > +} > + > +if (!numa_info[numa_info[i].initiator].present) { > +error_report("NUMA node %&quo

Re: [PATCH 0/3] eliminate remaining places that abuse memory_region_allocate_system_memory()

2019-10-21 Thread Igor Mammedov
On Mon, 21 Oct 2019 10:59:56 +0200 Philippe Mathieu-Daudé wrote: > Hi Igor, > > On 10/8/19 1:33 PM, Igor Mammedov wrote: > > Series cleans up remaining boards that call > > memory_region_allocate_system_memory() > > multiple times, violating interface contract (th

Re: [RFC 3/3] acpi: cpuhp: add CPHP_GET_CPU_ID_CMD command

2019-10-18 Thread Igor Mammedov
On Thu, 10 Oct 2019 16:56:18 +0200 Laszlo Ersek wrote: > On 10/09/19 15:22, Igor Mammedov wrote: > > Extend CPU hotplug interface to return architecture specific > > identifier for current CPU (in case of x86, it's APIC ID). > > > > Signed-off-by: Igor

Re: [RFC 2/3] acpi: cpuhp: add typical usecases into spec

2019-10-18 Thread Igor Mammedov
On Thu, 10 Oct 2019 16:13:22 +0200 Laszlo Ersek wrote: > On 10/09/19 15:22, Igor Mammedov wrote: > > Clarify values of "CPU selector' register and add workflows for > > * finding CPU with pending 'insert/remove' event > > * enumerating present/non present CPUs &g

Re: [RFC 1/3] acpi: cpuhp: fix 'Command data' description is spec

2019-10-17 Thread Igor Mammedov
On Thu, 10 Oct 2019 14:33:19 +0200 Laszlo Ersek wrote: > On 10/09/19 15:22, Igor Mammedov wrote: > > QEMU returns 0, in case of erro or invalid value in 'Command field', > > make spec match reality, i.e. > > Unfinished thought? yep, I'll fix it up. [...] > > i

Re: ACPI table modifications

2019-10-17 Thread Igor Mammedov
On Sat, 12 Oct 2019 00:17:10 +0530 Gautam Bhat wrote: > Hi, > > I want to add some I2C based temperature sensors to the -M Q35 machine. I > want to update the ACPI tables to add this device information. How can I go > about doing this? Process is described here:

Re: [PATCH v12 09/11] hmat acpi: Build System Locality Latency and Bandwidth Information Structure(s)

2019-10-17 Thread Igor Mammedov
On Tue, 15 Oct 2019 13:40:54 +0800 Tao Xu wrote: > On 10/15/2019 8:59 AM, Tao Xu wrote: > > On 10/14/2019 5:00 PM, Igor Mammedov wrote: > >> On Sat, 12 Oct 2019 11:04:03 +0800 > >> Tao Xu wrote: > >> > >>> On 10/11/2019 10:08 PM, Igor Mamme

Re: [PATCH v12 09/11] hmat acpi: Build System Locality Latency and Bandwidth Information Structure(s)

2019-10-14 Thread Igor Mammedov
On Sat, 12 Oct 2019 11:04:03 +0800 Tao Xu wrote: > On 10/11/2019 10:08 PM, Igor Mammedov wrote: > > On Thu, 10 Oct 2019 14:53:56 +0800 > > Tao Xu wrote: > > > >> On 10/3/2019 10:41 PM, Igor Mammedov wrote: > >>> On Fri, 20 S

Re: [PATCH 0/3] eliminate remaining places that abuse memory_region_allocate_system_memory()

2019-10-11 Thread Igor Mammedov
On Thu, 10 Oct 2019 19:35:03 +0200 Igor Mammedov wrote: Forgot to actually CC Eduardo, > On Tue, 8 Oct 2019 07:33:15 -0400 > Igor Mammedov wrote: ... > Eduardo, > > This patches are fixing various machines across tree, so series does not > belong > to any particular ar

Re: [PATCH v12 09/11] hmat acpi: Build System Locality Latency and Bandwidth Information Structure(s)

2019-10-11 Thread Igor Mammedov
On Thu, 10 Oct 2019 14:53:56 +0800 Tao Xu wrote: > On 10/3/2019 10:41 PM, Igor Mammedov wrote: > > On Fri, 20 Sep 2019 15:43:47 +0800 > > Tao Xu wrote: > > > >> From: Liu Jingqi > >> > >> This structure describes the memory access latency an

Re: [PATCH v12 07/11] numa: Extend CLI to provide memory side cache information

2019-10-11 Thread Igor Mammedov
On Wed, 9 Oct 2019 15:54:00 +0800 Tao Xu wrote: > On 10/3/2019 7:19 PM, Igor Mammedov wrote: > > On Fri, 20 Sep 2019 15:43:45 +0800 > > Tao Xu wrote: > > > >> From: Liu Jingqi > >> > >> Add -numa hmat-cache option to provide Memory Side Cach

Re: [PATCH v12 06/11] numa: Extend CLI to provide memory latency and bandwidth information

2019-10-11 Thread Igor Mammedov
On Wed, 9 Oct 2019 14:39:46 +0800 Tao Xu wrote: > On 10/2/2019 11:16 PM, Igor Mammedov wrote: > > On Fri, 20 Sep 2019 15:43:44 +0800 > > Tao Xu wrote: > > > [...] > >> +struct HMAT_LB_Info { > >> +/* Indicates it's memory or the specified lev

Re: [RFC 0/3] acpi: cphp: add CPHP_GET_CPU_ID_CMD command to cpu hotplug MMIO interface

2019-10-11 Thread Igor Mammedov
On Thu, 10 Oct 2019 16:20:39 -0300 Eduardo Habkost wrote: > On Thu, Oct 10, 2019 at 05:57:54PM +0200, Igor Mammedov wrote: > > On Thu, 10 Oct 2019 09:59:42 -0400 > > "Michael S. Tsirkin" wrote: > > > > > On Thu, Oct 10, 2019 at 03:39:12PM +0200, Igor

Re: [PATCH 0/3] eliminate remaining places that abuse memory_region_allocate_system_memory()

2019-10-10 Thread Igor Mammedov
On Tue, 8 Oct 2019 07:33:15 -0400 Igor Mammedov wrote: > > Series cleans up remaining boards that call > memory_region_allocate_system_memory() > multiple times, violating interface contract (the function should be called > only > once). > > With that cleaned u

Re: [RFC 3/3] acpi: cpuhp: add CPHP_GET_CPU_ID_CMD command

2019-10-10 Thread Igor Mammedov
On Thu, 10 Oct 2019 11:06:29 -0400 "Michael S. Tsirkin" wrote: > On Thu, Oct 10, 2019 at 04:56:18PM +0200, Laszlo Ersek wrote: > > On 10/09/19 15:22, Igor Mammedov wrote: > > > Extend CPU hotplug interface to return architecture specific > > > identifier

Re: [RFC 0/3] acpi: cphp: add CPHP_GET_CPU_ID_CMD command to cpu hotplug MMIO interface

2019-10-10 Thread Igor Mammedov
On Thu, 10 Oct 2019 11:16:52 -0300 Eduardo Habkost wrote: > On Thu, Oct 10, 2019 at 03:39:12PM +0200, Igor Mammedov wrote: > > On Thu, 10 Oct 2019 05:56:55 -0400 > > "Michael S. Tsirkin" wrote: > > > > > On Wed, Oct 09, 2019 at 09:22:49AM -0400, Igor M

Re: [RFC 0/3] acpi: cphp: add CPHP_GET_CPU_ID_CMD command to cpu hotplug MMIO interface

2019-10-10 Thread Igor Mammedov
On Thu, 10 Oct 2019 09:59:42 -0400 "Michael S. Tsirkin" wrote: > On Thu, Oct 10, 2019 at 03:39:12PM +0200, Igor Mammedov wrote: > > On Thu, 10 Oct 2019 05:56:55 -0400 > > "Michael S. Tsirkin" wrote: > > > > > On Wed, Oct

Re: [RFC PATCH 12/12] virt/acpi: add SDEI table if SDEI is enabled

2019-10-10 Thread Igor Mammedov
On Thu, 10 Oct 2019 21:08:10 +0800 Guoheyi wrote: > Thanks for your comments. > > On 2019/10/10 17:15, Igor Mammedov wrote: > > On Tue, 24 Sep 2019 23:21:51 +0800 > > Heyi Guo wrote: > > > >> Add SDEI table if SDEI is enabled, so that guest OS can get a

Re: [RFC 0/3] acpi: cphp: add CPHP_GET_CPU_ID_CMD command to cpu hotplug MMIO interface

2019-10-10 Thread Igor Mammedov
On Thu, 10 Oct 2019 05:56:55 -0400 "Michael S. Tsirkin" wrote: > On Wed, Oct 09, 2019 at 09:22:49AM -0400, Igor Mammedov wrote: > > As an alternative to passing to firmware topology info via new fwcfg files > > so it could recreate APIC IDs based on it and

Re: [PATCH 3/4] hw/i386: add facility to expose CPU topology over fw-cfg

2019-10-10 Thread Igor Mammedov
On Thu, 10 Oct 2019 06:01:51 -0400 "Michael S. Tsirkin" wrote: > On Tue, Oct 08, 2019 at 05:59:31PM +0200, Igor Mammedov wrote: > > On Tue, 8 Oct 2019 12:52:58 +0200 > > Laszlo Ersek wrote: > > > > > FW_CFG_MAX_CPUS exposes the (exclusive) maxi

Re: [PATCH 3/4] hw/i386: add facility to expose CPU topology over fw-cfg

2019-10-10 Thread Igor Mammedov
On Wed, 9 Oct 2019 23:01:21 +0200 Laszlo Ersek wrote: > On 10/08/19 17:59, Igor Mammedov wrote: > > On Tue, 8 Oct 2019 12:52:58 +0200 > > Laszlo Ersek wrote: > > > >> FW_CFG_MAX_CPUS exposes the (exclusive) maximum APIC ID to guest firmware, > >>

Re: [RFC PATCH 12/12] virt/acpi: add SDEI table if SDEI is enabled

2019-10-10 Thread Igor Mammedov
s Morse > Cc: Shannon Zhao > Cc: "Michael S. Tsirkin" > Cc: Igor Mammedov > --- > hw/arm/virt-acpi-build.c| 16 > include/hw/acpi/acpi-defs.h | 5 + > 2 files changed, 21 insertions(+) > > diff --git a/hw/arm/virt-acpi-bu

[RFC 2/3] acpi: cpuhp: add typical usecases into spec

2019-10-09 Thread Igor Mammedov
Clarify values of "CPU selector' register and add workflows for * finding CPU with pending 'insert/remove' event * enumerating present/non present CPUs Signed-off-by: Igor Mammedov --- docs/specs/acpi_cpu_hotplug.txt | 22 ++ 1 file changed, 22 insertions(+) diff

[RFC 3/3] acpi: cpuhp: add CPHP_GET_CPU_ID_CMD command

2019-10-09 Thread Igor Mammedov
Extend CPU hotplug interface to return architecture specific identifier for current CPU (in case of x86, it's APIC ID). Signed-off-by: Igor Mammedov --- TODO: * cripple it to behave old way on old machine types so that new firmware started on new QEMU won't see a difference when

Re: [PATCH 2/3] ppc: rs6000_mc: drop usage of memory_region_allocate_system_memory()

2019-10-09 Thread Igor Mammedov
On Wed, 9 Oct 2019 12:21:06 +1100 David Gibson wrote: > On Tue, Oct 08, 2019 at 07:33:17AM -0400, Igor Mammedov wrote: > > rs6000mc_realize() violates memory_region_allocate_system_memory() contract > > by calling it multiple times which could break -mem-path. Replace it

[RFC 1/3] acpi: cpuhp: fix 'Command data' description is spec

2019-10-09 Thread Igor Mammedov
QEMU returns 0, in case of erro or invalid value in 'Command field', make spec match reality, i.e. Also fix returned value description in case 'Command field' == 0x0, it's in not PXM but CPU selector value with pending event Signed-off-by: Igor Mammedov --- docs/specs/acpi_cpu_hotplug.txt | 5

[RFC 0/3] acpi: cphp: add CPHP_GET_CPU_ID_CMD command to cpu hotplug MMIO interface

2019-10-09 Thread Igor Mammedov
: "Michael S. Tsirkin" CC: Gerd Hoffmann CC: Paolo Bonzini CC: Philippe Mathieu-Daudé CC: Richard Henderson Igor Mammedov (3): acpi: cpuhp: fix 'Command data' description is spec acpi: cpuhp: add typical usecases into spec acpi: cpuhp: add CPHP_GET_CPU_ID_CMD command

Re: [PATCH 3/4] hw/i386: add facility to expose CPU topology over fw-cfg

2019-10-09 Thread Igor Mammedov
y that map is what OVMF would have to receive over fw_cfg, > *if* the "cpu_index -> APIC-ID" mapping is not considered guest ABI. > Should I write v2 for that? > > Please comment! > > Thanks, > Laszlo > > > > This is > > slightly complicated by

Re: [PATCH 3/4] hw/i386: add facility to expose CPU topology over fw-cfg

2019-10-08 Thread Igor Mammedov
) PS: The reason we started building ACPI tables in QEMU, was never ending story of adding more ABI and supporting it afterwards. So I'd try to avoid doing it if it can be helped. > For now, the feature is temporarily disabled. > > Cc: "Michael S. Tsirkin" > Cc: Eduardo Habkost

Re: [PATCH 1/3] sparc64: use memory_region_allocate_system_memory() only for '-m' specified RAM

2019-10-08 Thread Igor Mammedov
On Tue, 8 Oct 2019 14:09:28 +0200 Philippe Mathieu-Daudé wrote: > On 10/8/19 1:33 PM, Igor Mammedov wrote: > > memory_region_allocate_system_memory() was designed to be called for > > allocating inital RAM. Using it mutiple times within one board is not > > supported and co

Re: [PATCH 0/3] eliminate remaining places that abuse memory_region_allocate_system_memory()

2019-10-08 Thread Igor Mammedov
On Tue, 8 Oct 2019 14:41:25 +0200 Philippe Mathieu-Daudé wrote: > Hi Igor, > > On 10/8/19 1:33 PM, Igor Mammedov wrote: > > Series cleans up remaining boards that call > > memory_region_allocate_system_memory() > > multiple times, violating interface contract (th

[PATCH 3/3] hppa: drop usage of memory_region_allocate_system_memory() for ROM

2019-10-08 Thread Igor Mammedov
machine_hppa_init() violates memory_region_allocate_system_memory() contract by calling it multiple times which could break with -mem-path. Replace the second usage (for 'rom') with memory_region_init_ram() instead. Signed-off-by: Igor Mammedov --- hw/hppa/machine.c | 5 ++--- 1 file changed, 2

[PATCH 0/3] eliminate remaining places that abuse memory_region_allocate_system_memory()

2019-10-08 Thread Igor Mammedov
ing -mem-path/mem-prealloc to it are postponed till then. Igor Mammedov (3): sparc64: use memory_region_allocate_system_memory() only for '-m' specified RAM ppc: rs6000_mc: drop usage of memory_region_allocate_system_memory() hppa: drop usage of memory_region_allocate_system_memory() for

[PATCH 2/3] ppc: rs6000_mc: drop usage of memory_region_allocate_system_memory()

2019-10-08 Thread Igor Mammedov
rs6000mc_realize() violates memory_region_allocate_system_memory() contract by calling it multiple times which could break -mem-path. Replace it with plain memory_region_init_ram() instead. Signed-off-by: Igor Mammedov --- hw/ppc/rs6000_mc.c | 15 ++- 1 file changed, 10 insertions

[PATCH 1/3] sparc64: use memory_region_allocate_system_memory() only for '-m' specified RAM

2019-10-08 Thread Igor Mammedov
memory_region_init_ram() for the rest fixed size regions. Signed-off-by: Igor Mammedov --- hw/sparc64/niagara.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/hw/sparc64/niagara.c b/hw/sparc64/niagara.c index 167143bffe..5987693659 100644 --- a/hw/sparc64

Re: [PULL 18/19] virtio: add vhost-user-fs base device

2019-10-06 Thread Igor Mammedov
On Sat, 5 Oct 2019 18:00:09 -0400 "Michael S. Tsirkin" wrote: > From: "Dr. David Alan Gilbert" > > The virtio-fs virtio device provides shared file system access using > the FUSE protocol carried over virtio. > The actual file server is implemented in an external vhost-user-fs device > backend

Re: [PATCH 01/11] hw/acpi/piix4: Convert reset handler to DeviceReset

2019-10-04 Thread Igor Mammedov
On Thu, 26 Sep 2019 17:17:23 +0200 Philippe Mathieu-Daudé wrote: > Convert the reset handler into a proper Device reset method. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Igor Mammedov > --- > hw/acpi/piix4.c | 7 +++ > 1 file changed, 3 insertio

Re: [edk2-devel] [Qemu-devel] [PATCH 1/2] q35: implement 128K SMRAM at default SMBASE address

2019-10-04 Thread Igor Mammedov
On Tue, 1 Oct 2019 20:03:20 +0200 "Laszlo Ersek" wrote: > On 09/30/19 16:22, Yao, Jiewen wrote: > > > >> -Original Message- > >> From: de...@edk2.groups.io On Behalf Of Igor > >> Mammedov > >> Sent: Monday, September 30, 2019 8

Re: [Qemu-devel] [PATCH v18 2/6] docs: APEI GHES generation and CPER record description

2019-10-04 Thread Igor Mammedov
On Fri, 6 Sep 2019 16:31:48 +0800 Xiang Zheng wrote: > From: Dongjiu Geng > [...] > + > +(9) When QEMU gets SIGBUS from the kernel, QEMU formats the CPER right into > +guest memory, and then injects whatever interrupt (or assert whatever > GPIO s/whatever .../platform specific/ and add

Re: [PATCH v12 11/11] tests/bios-tables-test: add test cases for ACPI HMAT

2019-10-04 Thread Igor Mammedov
tem enable numa, the > following tables need to be added for this test: > tests/acpi-test-data/pc/*.acpihmat > tests/acpi-test-data/pc/HMAT.* > tests/acpi-test-data/q35/*.acpihmat > tests/acpi-test-data/q35/HMAT.* > > Reviewed-by: Daniel Black > Reviewed-by: Jingqi Liu >

Re: [PATCH v12 10/11] hmat acpi: Build Memory Side Cache Information Structure(s)

2019-10-04 Thread Igor Mammedov
On Fri, 20 Sep 2019 15:43:48 +0800 Tao Xu wrote: > From: Liu Jingqi > > This structure describes memory side cache information for memory > proximity domains if the memory side cache is present and the > physical device forms the memory side cache. > The software could use this information to

Re: [PATCH v12 09/11] hmat acpi: Build System Locality Latency and Bandwidth Information Structure(s)

2019-10-03 Thread Igor Mammedov
On Fri, 20 Sep 2019 15:43:47 +0800 Tao Xu wrote: > From: Liu Jingqi > > This structure describes the memory access latency and bandwidth > information from various memory access initiator proximity domains. > The latency and bandwidth numbers represented in this structure > correspond to rated

Re: [PATCH v12 08/11] hmat acpi: Build Memory Proximity Domain Attributes Structure(s)

2019-10-03 Thread Igor Mammedov
On Fri, 20 Sep 2019 15:43:46 +0800 Tao Xu wrote: > From: Liu Jingqi > > HMAT is defined in ACPI 6.3: 5.2.27 Heterogeneous Memory Attribute Table > (HMAT). The specification references below link: > http://www.uefi.org/sites/default/files/resources/ACPI_6_3_final_Jan30.pdf > > It describes the

Re: [PATCH v12 07/11] numa: Extend CLI to provide memory side cache information

2019-10-03 Thread Igor Mammedov
On Fri, 20 Sep 2019 15:43:45 +0800 Tao Xu wrote: > From: Liu Jingqi > > Add -numa hmat-cache option to provide Memory Side Cache Information. > These memory attributes help to build Memory Side Cache Information > Structure(s) in ACPI Heterogeneous Memory Attribute Table (HMAT). > >

Re: [PATCH v12 06/11] numa: Extend CLI to provide memory latency and bandwidth information

2019-10-02 Thread Igor Mammedov
On Fri, 20 Sep 2019 15:43:44 +0800 Tao Xu wrote: > From: Liu Jingqi > > Add -numa hmat-lb option to provide System Locality Latency and > Bandwidth Information. These memory attributes help to build > System Locality Latency and Bandwidth Information Structure(s) > in ACPI Heterogeneous Memory

Re: [edk2-devel] [Qemu-devel] [PATCH 1/2] q35: implement 128K SMRAM at default SMBASE address

2019-09-30 Thread Igor Mammedov
On Mon, 30 Sep 2019 13:51:46 +0200 "Laszlo Ersek" wrote: > Hi Igor, > > On 09/24/19 13:19, Igor Mammedov wrote: > > On Mon, 23 Sep 2019 20:35:02 +0200 > > "Laszlo Ersek" wrote: > > >> I've got good results. For this (1/2) QEMU patch:

Re: [PATCH v12 05/11] numa: Extend CLI to provide initiator information for numa nodes

2019-09-30 Thread Igor Mammedov
On Fri, 20 Sep 2019 15:43:43 +0800 Tao Xu wrote: > In ACPI 6.3 chapter 5.2.27 Heterogeneous Memory Attribute Table (HMAT), > The initiator represents processor which access to memory. And in 5.2.27.3 > Memory Proximity Domain Attributes Structure, the attached initiator is > defined as where the

Re: [PATCH v7 4/4] s390: do not call memory_region_allocate_system_memory() multiple times

2019-09-30 Thread Igor Mammedov
On Mon, 30 Sep 2019 09:09:59 +0200 Christian Borntraeger wrote: > On 28.09.19 03:28, Peter Xu wrote: > > On Fri, Sep 27, 2019 at 03:33:20PM +0200, Igor Mammedov wrote: > >> On Thu, 26 Sep 2019 07:52:35 +0800 > >> Peter Xu wrote: > >> > >>>

Re: [PATCH v7 4/4] s390: do not call memory_region_allocate_system_memory() multiple times

2019-09-27 Thread Igor Mammedov
On Thu, 26 Sep 2019 07:52:35 +0800 Peter Xu wrote: > On Wed, Sep 25, 2019 at 01:51:05PM +0200, Igor Mammedov wrote: > > On Wed, 25 Sep 2019 11:27:00 +0800 > > Peter Xu wrote: > > > > > On Tue, Sep 24, 2019 at 10:47:51AM -0400, Igor Mammedov wrote: > >

Re: [PATCH-for-4.2 v11 11/11] tests: Add bios tests to arm/virt

2019-09-25 Thread Igor Mammedov
On Wed, 25 Sep 2019 11:26:04 -0400 "Michael S. Tsirkin" wrote: > On Wed, Sep 18, 2019 at 02:06:33PM +0100, Shameer Kolothum wrote: > > This adds numamem and memhp tests for arm/virt platform. > > > > Signed-off-by: Shameer Kolothum > > Reviewed-by:

Re: [PATCH-for-4.2 v11 10/11] tests: Update ACPI tables list for upcoming arm/virt tests

2019-09-25 Thread Igor Mammedov
> > Signed-off-by: Shameer Kolothum Reviewed-by: Igor Mammedov > --- > v10 --> v11 > > As per Michael's suggestion updated bios-tables-test-allowed-diff.h > instead of adding expected files directly. > --- > tests/bios-tables-test-allowed-diff.h | 15 ++

Re: [PATCH-for-4.2 v11 00/11] ARM virt: ACPI memory hotplug support

2019-09-25 Thread Igor Mammedov
On Wed, 25 Sep 2019 11:28:42 -0400 "Michael S. Tsirkin" wrote: > On Wed, Sep 18, 2019 at 02:06:22PM +0100, Shameer Kolothum wrote: > > This series is an attempt to provide device memory hotplug support > > on ARM virt platform. This is based on Eric's recent works here[1] > > and carries some

Re: [Qemu-devel] [PATCH-for-4.2 v11 03/11] hw/acpi: Add ACPI Generic Event Device Support

2019-09-25 Thread Igor Mammedov
cted by the > interrupt. This way, we can support up to 32 events with a unique > interrupt. > > This supports only memory hotplug for now. > > Signed-off-by: Samuel Ortiz > Signed-off-by: Sebastien Boeuf > Signed-off-by: Shameer Kolothum > Reviewed-by: Eric Auger

Re: [PATCH-for-4.2 v11 05/11] hw/arm/virt: Enable device memory cold/hot plug with ACPI boot

2019-09-25 Thread Igor Mammedov
th ACPI boot. Memory cold plug support with Guest DT boot is not yet > supported. > > As DSDT table gets changed by this, update bios-tables-test-allowed-diff.h > to avoid "make check" failure. > > Signed-off-by: Shameer Kolothum Reviewed-by: Igor Mammedov > --- > v

Re: [Qemu-devel] [PATCH-for-4.2 v11 09/11] docs/specs: Add ACPI GED documentation

2019-09-25 Thread Igor Mammedov
On Wed, 18 Sep 2019 14:06:31 +0100 Shameer Kolothum wrote: > Documents basic concepts of ACPI Generic Event device(GED) > and interface between QEMU and the ACPI BIOS. > > Signed-off-by: Shameer Kolothum > Reviewed-by: Eric Auger Reviewed-by: Igor Mammedov > --- &

Re: [PATCH v7 3/4] kvm: split too big memory section on several memslots

2019-09-25 Thread Igor Mammedov
On Wed, 25 Sep 2019 11:12:11 +0800 Peter Xu wrote: > On Tue, Sep 24, 2019 at 10:47:50AM -0400, Igor Mammedov wrote: > > [...] > > > @@ -2877,6 +2912,7 @@ static bool kvm_accel_has_memory(MachineState *ms, > > AddressSpace *as, > > > >

Re: [PATCH v7 4/4] s390: do not call memory_region_allocate_system_memory() multiple times

2019-09-25 Thread Igor Mammedov
On Wed, 25 Sep 2019 11:27:00 +0800 Peter Xu wrote: > On Tue, Sep 24, 2019 at 10:47:51AM -0400, Igor Mammedov wrote: > > s390 was trying to solve limited KVM memslot size issue by abusing > > memory_region_allocate_system_memory(), which breaks API contract > > where the fun

[PATCH v7 3/4] kvm: split too big memory section on several memslots

2019-09-24 Thread Igor Mammedov
and eventually use a single hostmem backend for guest RAM. Signed-off-by: Igor Mammedov --- v7: * rebase on top of Paolo's series "kvm: clear dirty bitmaps from all overlapping memslots" * use MIN() instead of open coding it * keep KVM_SLOT_MAX_BYTES at original place

[PATCH v7 1/4] kvm: extract kvm_log_clear_one_slot

2019-09-24 Thread Igor Mammedov
From: Paolo Bonzini We may need to clear the dirty bitmap for more than one KVM memslot. First do some code movement with no semantic change. Signed-off-by: Paolo Bonzini Signed-off-by: Igor Mammedov Reviewed-by: Peter Xu --- accel/kvm/kvm-all.c | 102

[PATCH v7 0/4] s390: stop abusing memory_region_allocate_system_memory()

2019-09-24 Thread Igor Mammedov
all. Tested: * s390 with hacked KVM_SLOT_MAX_BYTES = 128Mb - guest reboot cycle in ping-pong migration * x86 with hacke max memslot = 128 and manual_dirty_log_protect enabled - ping-pong migration with workload dirtying RAM around a split area Igor Mammedov (2): kvm: split too big mem

[PATCH v7 4/4] s390: do not call memory_region_allocate_system_memory() multiple times

2019-09-24 Thread Igor Mammedov
ory() multiple times Signed-off-by: Igor Mammedov --- v7: - move KVM_SLOT_MAX_BYTES movement from kvm specific patch to here (Peter Xu ) v3: - drop migration compat code PS: I don't have access to a suitable system to test it with 8Tb split, so I've tested only hacked up KVM_SLOT_MAX_BY

[PATCH v7 2/4] kvm: clear dirty bitmaps from all overlapping memslots

2019-09-24 Thread Igor Mammedov
From: Paolo Bonzini Currently MemoryRegionSection has 1:1 mapping to KVMSlot. However next patch will allow splitting MemoryRegionSection into several KVMSlot-s, make sure that kvm_physical_log_slot_clear() is able to handle such 1:N mapping. Signed-off-by: Paolo Bonzini Signed-off-by: Igor

Re: [edk2-devel] [Qemu-devel] [PATCH 1/2] q35: implement 128K SMRAM at default SMBASE address

2019-09-24 Thread Igor Mammedov
On Mon, 23 Sep 2019 20:35:02 +0200 "Laszlo Ersek" wrote: > On 09/20/19 11:28, Laszlo Ersek wrote: > > On 09/20/19 10:28, Igor Mammedov wrote: > >> On Thu, 19 Sep 2019 19:02:07 +0200 > >> "Laszlo Ersek" wrote: > >> > >>>

Re: [PATCH 0/2] kvm: clear dirty bitmaps from all overlapping memslots

2019-09-23 Thread Igor Mammedov
On Mon, 23 Sep 2019 09:29:46 +0800 Peter Xu wrote: > On Fri, Sep 20, 2019 at 03:58:51PM +0200, Igor Mammedov wrote: > > On Fri, 20 Sep 2019 20:19:51 +0800 > > Peter Xu wrote: > > > > > On Fri, Sep 20, 2019 at 12:21:20PM +0200, Paolo Bonzini wrote: > >

Re: [PATCH 0/2] kvm: clear dirty bitmaps from all overlapping memslots

2019-09-20 Thread Igor Mammedov
On Fri, 20 Sep 2019 20:19:51 +0800 Peter Xu wrote: > On Fri, Sep 20, 2019 at 12:21:20PM +0200, Paolo Bonzini wrote: > > A single ram_addr (representing a host-virtual address) could be aliased > > to multiple guest physical addresses. Since the KVM dirty page reporting > > works on guest

Re: [edk2-devel] [Qemu-devel] [PATCH 1/2] q35: implement 128K SMRAM at default SMBASE address

2019-09-20 Thread Igor Mammedov
On Thu, 19 Sep 2019 19:02:07 +0200 "Laszlo Ersek" wrote: > Hi Igor, > > (+Brijesh) > > long-ish pondering ahead, with a question at the end. [...] > Finally: can you please remind me why we lock down 128KB (32 pages) at > 0x3_, and not just half of that? What do we need the range at >

Re: [Qemu-devel] [PATCH-for-4.2 v10 05/11] hw/arm/virt: Enable device memory cold/hot plug with ACPI boot

2019-09-17 Thread Igor Mammedov
On Mon, 16 Sep 2019 10:30:45 + Shameerali Kolothum Thodi wrote: > Hi Igor, > > > -Original Message- > > From: Igor Mammedov [mailto:imamm...@redhat.com] > > Sent: 11 September 2019 14:07 > > To: Shameerali Kolothum Thodi > > Cc: qemu-d

Re: [Qemu-devel] [PATCH v6 2/2] s390: do not call memory_region_allocate_system_memory() multiple times

2019-09-17 Thread Igor Mammedov
On Tue, 17 Sep 2019 16:44:42 +0800 Peter Xu wrote: > On Mon, Sep 16, 2019 at 09:23:47AM -0400, Igor Mammedov wrote: > > PS: > > I don't have access to a suitable system to test it. > > Hmm I feel like it would be good to have series like this to be at > least smoke te

Re: [Qemu-devel] [edk2-devel] [PATCH] q35: lpc: allow to lock down 128K RAM at default SMBASE address

2019-09-17 Thread Igor Mammedov
On Wed, 11 Sep 2019 19:30:46 +0200 "Laszlo Ersek" wrote: > On 09/10/19 17:58, Igor Mammedov wrote: > > On Mon, 9 Sep 2019 21:15:44 +0200 > > Laszlo Ersek wrote: > > [...] > > > It looks like fwcfg smi feature negotiation isn't reusable in this case.

[Qemu-devel] [PATCH 0/2] q35: mch: allow to lock down 128K RAM at default SMBASE address

2019-09-17 Thread Igor Mammedov
: boris.ostrov...@oracle.com CC: r...@edk2.groups.io CC: joao.m.mart...@oracle.com CC: ler...@redhat.com Igor Mammedov (2): q35: implement 128K SMRAM at default SMBASE address tests: q35: MCH: add default SMBASE SMRAM lock test include/hw/pci-host/q35.h | 10 hw/i386/pc.c

[Qemu-devel] [PATCH 1/2] q35: implement 128K SMRAM at default SMBASE address

2019-09-17 Thread Igor Mammedov
context. In non-SMM context, reads return 0xff and writes are ignored. Further writes into the register are ignored until the system reset. *) https://www.mail-archive.com/qemu-devel@nongnu.org/msg455991.html Signed-off-by: Igor Mammedov --- include/hw/pci-host/q35.h | 10 + hw/i386

[Qemu-devel] [PATCH 2/2] tests: q35: MCH: add default SMBASE SMRAM lock test

2019-09-17 Thread Igor Mammedov
test lockable SMRAM at default SMBASE feature introduced by commit "q35: implement 128K SMRAM at default SMBASE address" Signed-off-by: Igor Mammedov --- tests/q35-test.c | 105 +++ 1 file changed, 105 insertions(+) diff --git a/tests/q3

[Qemu-devel] [PATCH v6 2/2] s390: do not call memory_region_allocate_system_memory() multiple times

2019-09-16 Thread Igor Mammedov
ble to split too big MemorySection into several memslots, stop abusing memory_region_allocate_system_memory() and use only one memory region for RAM. 1) [PATCH RFC v2 4/4] s390: do not call memory_region_allocate_system_memory() multiple times Signed-off-by: Igor Mammedov Reviewed-by: Da

[Qemu-devel] [PATCH v6 1/2] kvm: s390: split too big memory section on several memslots

2019-09-16 Thread Igor Mammedov
and eventually use a single hostmem backend for guest RAM. Signed-off-by: Igor Mammedov --- Since there is quite a bit of migration related code churn in the patch CCing migration maintainer CC: dgilb...@redhat.com v6: * KVM's migration code was assuming 1:1 relation between memslot

[Qemu-devel] [PATCH v6 0/2] s390: stop abusing memory_region_allocate_system_memory()

2019-09-16 Thread Igor Mammedov
ing in s390 code Igor Mammedov (2): kvm: s390: split too big memory section on several memslots s390: do not call memory_region_allocate_system_memory() multiple times include/sysemu/kvm_int.h | 1 + accel/kvm/kvm-all.c| 239 ++--- hw/s390x/s

Re: [Qemu-devel] [qemu-s390x] [PATCH for-4.2 v5 1/2] kvm: s390: split too big memory section on several memslots

2019-09-16 Thread Igor Mammedov
On Tue, 3 Sep 2019 08:57:38 +0200 Christian Borntraeger wrote: > On 02.09.19 15:49, Igor Mammedov wrote: > > On Fri, 30 Aug 2019 18:19:29 +0200 > > Christian Borntraeger wrote: > > > >> On 30.08.19 11:41, Igor Mammedov wrote: > >>> On Thu,

Re: [Qemu-devel] [PATCH-for-4.2 v10 10/11] tests: add dummy ACPI tables for arm/virt board

2019-09-11 Thread Igor Mammedov
On Wed, 11 Sep 2019 13:57:06 +0100 Peter Maydell wrote: > On Wed, 4 Sep 2019 at 09:58, Shameer Kolothum > wrote: > > > > This patch is in preparation for adding numamem and memhp tests > > to arm/virt board so that 'make check' is happy. This may not > > be required once the scripts are run and

Re: [Qemu-devel] [PATCH-for-4.2 v10 11/11] tests: Add bios tests to arm/virt

2019-09-11 Thread Igor Mammedov
On Wed, 4 Sep 2019 09:56:29 +0100 Shameer Kolothum wrote: > This adds numamem and memhp tests for arm/virt platform > > Signed-off-by: Shameer Kolothum Reviewed-by: Igor Mammedov > --- > tests/bios-tables-test-allowed-diff.h | 1 + > tests/bios-tables-test.c

Re: [Qemu-devel] [PATCH-for-4.2 v10 08/11] hw/arm: Use GED for system_powerdown event

2019-09-11 Thread Igor Mammedov
On Wed, 4 Sep 2019 09:56:26 +0100 Shameer Kolothum wrote: > For machines 4.2 or higher with ACPI boot use GED for system_powerdown > event instead of GPIO. Guest boot with DT still uses GPIO. > > Signed-off-by: Shameer Kolothum > Reviewed-by: Eric Auger Reviewed-by

Re: [Qemu-devel] [PATCH-for-4.2 v10 06/11] hw/arm/virt-acpi-build: Add PC-DIMM in SRAT

2019-09-11 Thread Igor Mammedov
present on CLI. Hence add support(>=4.2) to > create numa node automatically (auto_enable_numa_with_memhp) when > QEMU is started with memory hotplug enabled but without '-numa' > options on CLI. > > Signed-off-by: Shameer Kolothum > Signed-off-by: Eric Auger > Review

Re: [Qemu-devel] [PATCH-for-4.2 v10 07/11] hw/arm: Factor out powerdown notifier from GPIO

2019-09-11 Thread Igor Mammedov
On Wed, 4 Sep 2019 09:56:25 +0100 Shameer Kolothum wrote: > This is in preparation of using GED device for > system_powerdown event. Make the powerdown notifier > registration independent of create_gpio() fn. > > Signed-off-by: Shameer Kolothum > Reviewed-by: Eric Auger

Re: [Qemu-devel] [PATCH-for-4.2 v10 05/11] hw/arm/virt: Enable device memory cold/hot plug with ACPI boot

2019-09-11 Thread Igor Mammedov
On Wed, 4 Sep 2019 09:56:23 +0100 Shameer Kolothum wrote: [...] > @@ -730,6 +733,19 @@ build_dsdt(GArray *table_data, BIOSLinker *linker, > VirtMachineState *vms) >vms->highmem, vms->highmem_ecam); > acpi_dsdt_add_gpio(scope, [VIRT_GPIO], >

Re: [Qemu-devel] [PATCH-for-4.2 v10 05/11] hw/arm/virt: Enable device memory cold/hot plug with ACPI boot

2019-09-11 Thread Igor Mammedov
On Wed, 4 Sep 2019 09:56:23 +0100 Shameer Kolothum wrote: > This initializes the GED device with base memory and irq, configures > ged memory hotplug event and builds the corresponding aml code. With > this, both hot and cold plug of device memory is enabled now for Guest > with ACPI boot.

Re: [Qemu-devel] [PATCH-for-4.2 v10 03/11] hw/acpi: Add ACPI Generic Event Device Support

2019-09-11 Thread Igor Mammedov
On Wed, 4 Sep 2019 09:56:21 +0100 Shameer Kolothum wrote: > From: Samuel Ortiz > > The ACPI Generic Event Device (GED) is a hardware-reduced specific > device[ACPI v6.1 Section 5.6.9] that handles all platform events, > including the hotplug ones. This patch generates the AML code that >

Re: [Qemu-devel] [PATCH] q35: lpc: allow to lock down 128K RAM at default SMBASE address

2019-09-10 Thread Igor Mammedov
On Mon, 9 Sep 2019 21:15:44 +0200 Laszlo Ersek wrote: > Hi Igor, > > On 09/05/19 17:49, Igor Mammedov wrote: > > lpc already has SMI negotiation feature, extend it by adding > > optin ICH9_LPC_SMI_F_LOCKED_SMBASE_BIT to supported features. > > > > Writing

[Qemu-devel] [PATCH] q35: lpc: allow to lock down 128K RAM at default SMBASE address

2019-09-05 Thread Igor Mammedov
quot; and set if supported set it in "etc/smi/requested-features" 3. read "etc/smi/features-ok", if returned value is 1 negotiated at step 2 features are activated successfully. Signed-off-by: Igor Mammedov --- include/hw/i386/ich9.h | 11 ++-- hw/i386/pc.c

Re: [Qemu-devel] [edk2-rfc] [edk2-devel] CPU hotplug using SMM with QEMU+OVMF

2019-09-05 Thread Igor Mammedov
On Thu, 5 Sep 2019 15:08:31 +0200 Laszlo Ersek wrote: > On 09/04/19 11:52, Igor Mammedov wrote: > > > it could be stolen RAM + black hole like TSEG, assuming fw can live > > without RAM(0x3+128K) range > > (in this case fwcfg interface would only work fo

Re: [Qemu-devel] [PATCH-for-4.2 v10 01/11] hw/acpi: Make ACPI IO address space configurable

2019-09-04 Thread Igor Mammedov
eer Kolothum > Reviewed-by: Eric Auger Reviewed-by: Igor Mammedov > --- > v9 --> v10 > - Fixed "make check" failure on x86_64. > > v8 --> v9 > -base address is an input into build_memory_hotplug_aml() > -Removed R-by tags f

Re: [Qemu-devel] [edk2-rfc] [edk2-devel] CPU hotplug using SMM with QEMU+OVMF

2019-09-04 Thread Igor Mammedov
On Tue, 3 Sep 2019 19:20:25 +0200 Laszlo Ersek wrote: > On 09/03/19 16:53, Igor Mammedov wrote: > > On Mon, 2 Sep 2019 21:09:58 +0200 > > Laszlo Ersek wrote: > > > >> On 09/02/19 10:45, Igor Mammedov wrote: > >>> On Fri, 30 Aug 201

Re: [Qemu-devel] [edk2-rfc] [edk2-devel] CPU hotplug using SMM with QEMU+OVMF

2019-09-03 Thread Igor Mammedov
On Mon, 2 Sep 2019 21:09:58 +0200 Laszlo Ersek wrote: > On 09/02/19 10:45, Igor Mammedov wrote: > > On Fri, 30 Aug 2019 20:46:14 +0200 > > Laszlo Ersek wrote: > > > >> On 08/30/19 16:48, Igor Mammedov wrote: > >> > >>> (01) On boot f

Re: [Qemu-devel] [qemu-s390x] [PATCH for-4.2 v5 1/2] kvm: s390: split too big memory section on several memslots

2019-09-02 Thread Igor Mammedov
On Fri, 30 Aug 2019 18:19:29 +0200 Christian Borntraeger wrote: > On 30.08.19 11:41, Igor Mammedov wrote: > > On Thu, 29 Aug 2019 14:41:13 +0200 > > Christian Borntraeger wrote: > > > >> On 29.08.19 14:31, Igor Mammedov wrote: > >>> On Thu,

[Qemu-devel] [PATCH] x86: do not advertise die-id in query-hotpluggbale-cpus if '-smp dies' is not set

2019-09-02 Thread Igor Mammedov
case '-smp dies' is not provided on CLI or -smp dies = 1', in which case smp_dies == 1 and APIC ID is calculated in default way (as it was before DIE support) so we won't need compat code as in both cases the topology provided to guest via CPUID is the same. Signed-off-by: Igor Mammedov --- hw

Re: [Qemu-devel] [edk2-rfc] [edk2-devel] CPU hotplug using SMM with QEMU+OVMF

2019-09-02 Thread Igor Mammedov
On Fri, 30 Aug 2019 20:46:14 +0200 Laszlo Ersek wrote: > On 08/30/19 16:48, Igor Mammedov wrote: > > > (01) On boot firmware maps and initializes SMI handler at default SMBASE > > (3) > > (using dedicated SMRAM at 3 would allow us to avoid save/restore >

Re: [Qemu-devel] [edk2-rfc] [edk2-devel] CPU hotplug using SMM with QEMU+OVMF

2019-08-30 Thread Igor Mammedov
On Thu, 29 Aug 2019 19:01:35 +0200 Laszlo Ersek wrote: > On 08/27/19 20:31, Igor Mammedov wrote: > > On Sat, 24 Aug 2019 01:48:09 + > > "Yao, Jiewen" wrote: > > >> (05) Host CPU: (OS) Port 0xB2 write, all CPUs enter SMM (NOTE: New CPU > >>

Re: [Qemu-devel] [edk2-rfc] [edk2-devel] CPU hotplug using SMM with QEMU+OVMF

2019-08-30 Thread Igor Mammedov
On Thu, 29 Aug 2019 18:25:17 +0200 Laszlo Ersek wrote: > On 08/28/19 14:01, Igor Mammedov wrote: > > On Tue, 27 Aug 2019 22:11:15 +0200 > > Laszlo Ersek wrote: > > > >> On 08/27/19 18:23, Igor Mammedov wrote: > >>> On Mon, 26 Aug 201

[Qemu-devel] [PATCH 1/2] tests: add qtest_qmp_device_add_qdict() helper

2019-08-30 Thread Igor Mammedov
Add an API that takes QDict directly, so users could skip steps of first building json dictionary and converting it back to QDict in existing qtest_qmp_device_add() and instead use QDict directly without intermediate conversion. Signed-off-by: Igor Mammedov --- tests/libqtest.h | 12

[Qemu-devel] [PATCH 2/2] tests: cpu-plug-test: fix device_add for pc/q35 machines

2019-08-30 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- tests/cpu-plug-test.c | 62 ++- 1 file changed, 26 insertions(+), 36 deletions(-) diff --git a/tests/cpu-plug-test.c b/tests/cpu-plug-test.c index 3049620854..46e51dc07a 100644 --- a/tests/cpu-plug-test.c +++ b/tests/cpu-p

[Qemu-devel] [PATCH 0/2] tests: cpu-plug-test: fix x86 device_add cpu-foo test cases

2019-08-30 Thread Igor Mammedov
Fixes bc1fb850a3 (vl.c deprecate incorrect CPUs topology) that introduced regression. Igor Mammedov (2): tests: add qtest_qmp_device_add_qdict() helper tests: cpu-plug-test: fix device_add for pc/q35 machines tests/libqtest.h | 12 + tests/cpu-plug-test.c | 62

  1   2   3   4   5   6   7   8   9   10   >