Re: [PATCH v6 12/12] qtest: Do not restrict bios-tables-test to Aarch64 hosts anymore

2021-05-05 Thread Igor Mammedov
On Mon, 3 May 2021 23:10:20 +0200 Philippe Mathieu-Daudé wrote: > Since commit 82bf7ae84ce ("target/arm: Remove KVM support for > 32-bit Arm hosts") we can remove the comment / check added in > commit ab6b6a4 and directly run the bios-tables-test. However I no longer recall what exactly

Re: [PATCH v6 11/12] qtest/bios-tables-test: Make test build-independent from accelerator

2021-05-05 Thread Igor Mammedov
; > Signed-off-by: Philippe Mathieu-Daudé > --- > v5 had: > Reviewed-by: Eric Blake > Reviewed-by: Alex Bennée > > v6 is simplified and keeps the same logic, however since > it is different, I'm not keeping the R-b tags. Reviewed-by: Igor Mammedov >

Re: [PATCH v6 10/12] qtest/bios-tables-test: Rename TCG specific tests

2021-05-05 Thread Igor Mammedov
On Mon, 3 May 2021 23:10:18 +0200 Philippe Mathieu-Daudé wrote: > Some tests require TCG, but don't have '_tcg' in their name, > while others do. Unify the test names by adding 'tcg' to the > TCG specific tests. > > Reported-by: Igor Mammedov > Signed-off-by: Philippe Mathie

Re: [PATCH v6 09/12] qtest/bios-tables-test: Rename tests not TCG specific

2021-05-05 Thread Igor Mammedov
On Mon, 3 May 2021 23:10:17 +0200 Philippe Mathieu-Daudé wrote: > Various tests don't require TCG, but have '_tcg' in their name. > As this is misleading, remove 'tcg' from their name. > > Reported-by: Igor Mammedov > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by

Re: [PATCH v2 3/7] ACPI ERST: support for ACPI ERST feature

2021-05-03 Thread Igor Mammedov
initialized by firmware and build tables using address. Maybe it will need dynamic tables patching but lets get to that only if rebuilding table won't be enough > Thanks, > eric > > ____ > From: Igor Mammedov > Sent: Wednesda

Re: [PATCH v5 08/10] qtest/bios-tables-test: Make test build-independent from accelerator

2021-05-03 Thread Igor Mammedov
On Mon, 3 May 2021 14:44:32 +0200 Philippe Mathieu-Daudé wrote: > Hi Igor, > > On 5/3/21 2:36 PM, Igor Mammedov wrote: > > On Sun, 2 May 2021 00:36:36 +0200 > > Philippe Mathieu-Daudé wrote: > > > >> Now than we can probe if the TCG accelerator is

Re: [RFC PATCH-for-6.1 0/9] hw/clock: Strengthen machine (non-qdev) clock propagation

2021-05-03 Thread Igor Mammedov
On Tue, 13 Apr 2021 15:43:19 -0400 Eduardo Habkost wrote: > On Mon, Apr 12, 2021 at 11:44:29AM +0100, Peter Maydell wrote: > > On Mon, 12 Apr 2021 at 11:31, Philippe Mathieu-Daudé > > wrote: > > > TIL MachineClass::reset(). > > > > > > - hw/hppa/machine.c > > > - hw/i386/pc.c > > > > > >

Re: [PATCH v4] hw/smbios: support for type 41 (onboard devices extended information)

2021-05-03 Thread Igor Mammedov
On Thu, 1 Apr 2021 19:11:38 +0200 Vincent Bernat wrote: > Type 41 defines the attributes of devices that are onboard. The > original intent was to imply the BIOS had some level of control over > the enablement of the associated devices. > > If network devices are present in this table, by

Re: [PATCH RESEND] pc-dimm: remove unnecessary get_vmstate_memory_region() method

2021-05-03 Thread Igor Mammedov
ordinary function. > This saves us from having to do an indirect call in order to reach it. > > Signed-off-by: Maciej S. Szmigiero Reviewed-by: Igor Mammedov > --- > hw/mem/pc-dimm.c | 33 ++--- > include/hw/mem/pc-dimm.h | 5 - > 2 fi

Re: Adjustments of NVDIMM devices and future data safety

2021-05-03 Thread Igor Mammedov
On Fri, 30 Apr 2021 14:18:30 +0200 Milan Zamazal wrote: > Hi, > > I work on NVDIMM support in oVirt/RHV, I think other virtualization > management software built on top of QEMU may have similar concerns. > > When a virtual NVDIMM device size is specified, it's not necessarily the > eventual

Re: [PATCH v5 08/10] qtest/bios-tables-test: Make test build-independent from accelerator

2021-05-03 Thread Igor Mammedov
On Sun, 2 May 2021 00:36:36 +0200 Philippe Mathieu-Daudé wrote: > Now than we can probe if the TCG accelerator is available > at runtime with a QMP command, do it once at the beginning > and only register the tests we can run. > We can then replace the #ifdef'ry by an assertion. > >

Re: [PATCH] Deprecate pmem=on with non-DAX capable backend file

2021-05-03 Thread Igor Mammedov
On Wed, 28 Apr 2021 12:29:30 -0400 Eduardo Habkost wrote: > On Tue, Apr 27, 2021 at 04:48:48PM -0400, Eduardo Habkost wrote: > > On Mon, Jan 11, 2021 at 03:33:32PM -0500, Igor Mammedov wrote: > > > It is not safe to pretend that emulated NVDIMM supports > > > persist

Re: [PULL 0/2] pc: last minute bugfixes

2021-04-23 Thread Igor Mammedov
On Fri, 23 Apr 2021 10:01:49 +0100 Daniel P. Berrangé wrote: > On Thu, Apr 22, 2021 at 06:24:48PM -0400, Michael S. Tsirkin wrote: > > The following changes since commit d83f46d189a26fa32434139954d264326f199a45: > > > > virtio-pci: compat page aligned ATS (2021-04-06 07:11:36 -0400) > > > >

Re: [Bug 1923497] Re: bios_linker_loader_add_checksum: Assertion `start_offset < file->blob->len' failed

2021-04-19 Thread Igor Mammedov
On Wed, 14 Apr 2021 19:40:36 - Ed Davison <1923...@bugs.launchpad.net> wrote: > The patch may be a bit beyond me at the moment as I use a package to > install this and would have to figure out how to download source, get it > configure, patched and compiled. Whew! Maybe ... > > But here is

Re: [PATCH v2 3/7] ACPI ERST: support for ACPI ERST feature

2021-04-14 Thread Igor Mammedov
On Fri, 9 Apr 2021 15:54:47 + Eric DeVolder wrote: > Hi Igor, > Thank you for reviewing. I've responded inline below. > eric > > ____ > From: Igor Mammedov > Sent: Tuesday, April 6, 2021 2:31 PM > To: Eric DeVolder > Cc: m...

Re: [PATCH for-6.0 v2] x86: acpi: use offset instead of pointer when using build_header()

2021-04-14 Thread Igor Mammedov
On Wed, 14 Apr 2021 04:43:56 -0400 Igor Mammedov wrote: > Do the same as in commit > (4d027afeb3a97 Virt: ACPI: fix qemu assert due to re-assigned table data > address) > for remaining tables that happen to use saved at > the beginning pointer to build header to avoid assert &g

Re: [Bug 1923497] Re: bios_linker_loader_add_checksum: Assertion `start_offset < file->blob->len' failed

2021-04-14 Thread Igor Mammedov
On Tue, 13 Apr 2021 21:29:45 - Ed Davison <1923...@bugs.launchpad.net> wrote: > Hmmm. Well, I don't know what the command line was. I use Virtual > Machine Manager (virt-manager.org) for my interface to the VM and it > does the startup. The error shows up when I start the VM. In this case

[PATCH for-6.0 v2] x86: acpi: use offset instead of pointer when using build_header()

2021-04-14 Thread Igor Mammedov
to start Windows 10 and getting assert at hw/acpi/bios-linker-loader.c:239: bios_linker_loader_add_checksum: Assertion `start_offset < file->blob->len' failed. Fixes: https://bugs.launchpad.net/bugs/1923497 Signed-off-by: Igor Mammedov --- v2: - amend commit message (Michael) PS

Re: [PATCH for-6.0] x86: acpi: use offset instead of pointer when using build_header()

2021-04-13 Thread Igor Mammedov
On Tue, 13 Apr 2021 09:53:17 -0400 "Michael S. Tsirkin" wrote: > On Tue, Apr 13, 2021 at 03:18:16PM +0200, Igor Mammedov wrote: > > On Tue, 13 Apr 2021 08:14:56 -0400 > > "Michael S. Tsirkin" wrote: > > > > > On Tue, Apr 13, 2021 at 0

Re: [PATCH for-6.0] x86: acpi: use offset instead of pointer when using build_header()

2021-04-13 Thread Igor Mammedov
On Tue, 13 Apr 2021 08:14:56 -0400 "Michael S. Tsirkin" wrote: > On Tue, Apr 13, 2021 at 07:14:00AM -0400, Igor Mammedov wrote: > > Do the same as in commit > > (4d027afeb3a97 Virt: ACPI: fix qemu assert due to re-assigned table data > > address) > > fo

[PATCH for-6.0] x86: acpi: use offset instead of pointer when using build_header()

2021-04-13 Thread Igor Mammedov
://bugs.launchpad.net/bugs/1923497 Signed-off-by: Igor Mammedov --- PS: I have build_header() refactoring patch that requires offset instead of pointer, to make it harder to misuse but it's a bit intrusive for last minute fixes. So here goes simplified variant, and I'll post refactoring patch for 6.1. later

Re: [Bug 1923497] [NEW] bios_linker_loader_add_checksum: Assertion `start_offset < file->blob->len' failed

2021-04-13 Thread Igor Mammedov
On Mon, 12 Apr 2021 20:29:04 - Ed Davison <1923...@bugs.launchpad.net> wrote: > Public bug reported: > > Trying boot/start a Windows 10 VM. Worked until recently when this > error started showing up. > > I have the following installed on Fedora 33: > qemu-kvm-5.1.0-9.fc33.x86_64 Could you

Re: [PATCH-for-6.0?] hw/arm/imx25_pdk: Fix error message for invalid RAM size

2021-04-08 Thread Igor Mammedov
aae02 ("arm/imx25_pdk: drop RAM size fixup") > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Igor Mammedov > --- > hw/arm/imx25_pdk.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/hw/arm/imx25_pdk.c b/hw/arm/imx25_pdk.c > index

Re: [Bug 1915063] Re: Windows 10 wil not install using qemu-system-x86_64

2021-04-07 Thread Igor Mammedov
On Wed, 07 Apr 2021 13:00:23 - David Ober <1915...@bugs.launchpad.net> wrote: > I have not done any of what you are asking so not exactly sure how to > change those values, been looking and reading but not finding what I > want so thought it might be better to just ask how to do what yo are >

Re: [PULL v2 11/19] pci: acpi: ensure that acpi-index is unique

2021-04-07 Thread Igor Mammedov
On Wed, 7 Apr 2021 09:29:45 +0100 Daniel P. Berrangé wrote: > On Tue, Apr 06, 2021 at 08:15:46PM +0200, Igor Mammedov wrote: > > On Tue, 6 Apr 2021 16:07:25 +0100 > > Daniel P. Berrangé wrote: > > > > > On Tue, Apr 06, 2021 at 03:54:24PM +0100, Daniel P. Berrang

Re: [PULL v2 11/19] pci: acpi: ensure that acpi-index is unique

2021-04-07 Thread Igor Mammedov
On Wed, 7 Apr 2021 09:29:22 -0400 "Michael S. Tsirkin" wrote: > On Tue, Apr 06, 2021 at 08:15:46PM +0200, Igor Mammedov wrote: > > On Tue, 6 Apr 2021 16:07:25 +0100 > > Daniel P. Berrangé wrote: > > > > > On Tue, Apr 06, 2021 at 03:54:24PM +0100, Da

Re: [PATCH v2 3/7] ACPI ERST: support for ACPI ERST feature

2021-04-06 Thread Igor Mammedov
On Mon, 8 Feb 2021 15:57:55 -0500 Eric DeVolder wrote: > This change implements the support for the ACPI ERST feature[1,2]. > > The size of the ACPI ERST storage is declared via the QEMU > global parameter acpi-erst.size. The size can range from 64KiB > to to 64MiB. The default is 64KiB. > >

Re: [PATCH v2 4/7] ACPI ERST: build step for ACPI ERST

2021-04-06 Thread Igor Mammedov
On Mon, 8 Feb 2021 15:57:56 -0500 Eric DeVolder wrote: > This change includes ERST in the build of ACPI support. > > Signed-off-by: Eric DeVolder > --- > hw/acpi/meson.build | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/acpi/meson.build b/hw/acpi/meson.build > index

Re: [PATCH v3] hw/smbios: support for type 41 (onboard devices extended information)

2021-04-06 Thread Igor Mammedov
On Fri, 02 Apr 2021 19:40:03 +0200 Vincent Bernat wrote: > ❦ 1 avril 2021 23:07 +02, Vincent Bernat: > > >>> This can be invoked with: > >>> > >>> $QEMU -netdev user,id=internet > >>> -device > >>> virtio-net-pci,mac=50:54:00:00:00:42,netdev=internet,id=internet-dev \ > >>>

Re: [Bug 1915063] Re: Windows 10 wil not install using qemu-system-x86_64

2021-04-06 Thread Igor Mammedov
On Sat, 03 Apr 2021 16:52:13 - Christian Ehrhardt  <1915...@bugs.launchpad.net> wrote: > That is awesome David, > qemu64 is like a very low common denominator with only very basic CPU > features. > While "copy host" means "enable all you can". Also it's worth to try setting real CPU

Re: [PATCH v3] hw/smbios: support for type 41 (onboard devices extended information)

2021-04-06 Thread Igor Mammedov
On Tue, 6 Apr 2021 09:42:50 +0200 Andrew Jones wrote: > On Thu, Apr 01, 2021 at 11:32:25PM +0200, Igor Mammedov wrote: > > On Thu, 01 Apr 2021 23:07:06 +0200 > > Vincent Bernat wrote: > > > > > ❦ 1 avril 2021 22:58 +02, Igor Mammedov: > &g

Re: [PULL v2 11/19] pci: acpi: ensure that acpi-index is unique

2021-04-06 Thread Igor Mammedov
On Tue, 6 Apr 2021 16:07:25 +0100 Daniel P. Berrangé wrote: > On Tue, Apr 06, 2021 at 03:54:24PM +0100, Daniel P. Berrangé wrote: > > On Mon, Mar 22, 2021 at 07:00:18PM -0400, Michael S. Tsirkin wrote: > > > From: Igor Mammedov > > > > > > it helps to avoi

Re: CXL 2.0 memory device design

2021-04-06 Thread Igor Mammedov
On Fri, 19 Mar 2021 10:47:11 -0700 Ben Widawsky wrote: > On 21-03-19 18:07:05, Igor Mammedov wrote: > > On Wed, 17 Mar 2021 14:40:58 -0700 > > Ben Widawsky wrote: > > > > > Phil, Igor, Markus > > > > > > TL;DR: What to do about multiple capa

Re: [PATCH 2/6] pci: introduce apci-index property for PCI device

2021-04-06 Thread Igor Mammedov
On Tue, 6 Apr 2021 10:47:12 +0100 Daniel P. Berrangé wrote: > On Mon, Mar 15, 2021 at 02:00:58PM -0400, Igor Mammedov wrote: > > In x86/ACPI world, linux distros are using predictable > > network interface naming since systemd v197. Which on > > QEMU based VMs results i

Re: [PATCH v3] hw/smbios: support for type 41 (onboard devices extended information)

2021-04-01 Thread Igor Mammedov
On Thu, 01 Apr 2021 23:07:06 +0200 Vincent Bernat wrote: > ❦ 1 avril 2021 22:58 +02, Igor Mammedov: > > >> This can be invoked with: > >> > >> $QEMU -netdev user,id=internet > >> -device > >> virtio-net-pci,ma

Re: [PATCH v3] hw/smbios: support for type 41 (onboard devices extended information)

2021-04-01 Thread Igor Mammedov
On Thu, 1 Apr 2021 14:26:58 +0200 Vincent Bernat wrote: > Type 41 defines the attributes of devices that are onboard. The > original intent was to imply the BIOS had some level of control over > the enablement of the associated devices. > > If network devices are present in this table, by

Re: [PATCH 0/4] DEVICE_NOT_DELETED/DEVICE_UNPLUG_ERROR QAPI events

2021-03-31 Thread Igor Mammedov
On Wed, 31 Mar 2021 10:46:49 +1100 David Gibson wrote: > On Tue, Mar 30, 2021 at 01:28:31AM +0200, Igor Mammedov wrote: > > On Wed, 24 Mar 2021 16:09:59 -0300 > > Daniel Henrique Barboza wrote: > > > > > On 3/23/21 10:40 PM, David Gibson wrote: > > &g

Re: [PATCH v2] qapi: introduce 'query-cpu-model-cpuid' action

2021-03-31 Thread Igor Mammedov
On Tue, 30 Mar 2021 12:37:11 +0300 Valeriy Vdovin wrote: > On Tue, Mar 30, 2021 at 02:15:10AM +0200, Igor Mammedov wrote: > > On Thu, 25 Mar 2021 19:57:05 +0300 > > Valeriy Vdovin wrote: > > > > > Introducing new qapi method 'query-cpu-model-cpuid'.

Re: [PATCH v2] qapi: introduce 'query-cpu-model-cpuid' action

2021-03-29 Thread Igor Mammedov
On Thu, 25 Mar 2021 19:57:05 +0300 Valeriy Vdovin wrote: > Introducing new qapi method 'query-cpu-model-cpuid'. This method can be used > to > get virtualized cpu model info generated by QEMU during VM initialization in > the form of cpuid representation. > > Diving into more details about

Re: [PATCH 1/2] spapr: number of SMP sockets must be equal to NUMA nodes

2021-03-29 Thread Igor Mammedov
On Mon, 29 Mar 2021 15:32:37 -0300 Daniel Henrique Barboza wrote: > On 3/29/21 12:32 PM, Cédric Le Goater wrote: > > On 3/29/21 6:20 AM, David Gibson wrote: > >> On Thu, Mar 25, 2021 at 09:56:04AM +0100, Cédric Le Goater wrote: > >>> On 3/25/21 3:10 AM, David Gibson wrote: > On Tue,

Re: [PATCH 1/2] spapr: number of SMP sockets must be equal to NUMA nodes

2021-03-29 Thread Igor Mammedov
; > > > [1] https://bugzilla.redhat.com/1934421 > > [2] > > https://lore.kernel.org/linuxppc-dev/daa5d05f-dbd0-05ad-7395-5d5a3d364...@gmail.com/ > > > > CC: Srikar Dronamraju > > CC: Cédric Le Goater > > CC: Igor Mammedov > > CC: Laurent V

Re: [PATCH 0/4] DEVICE_NOT_DELETED/DEVICE_UNPLUG_ERROR QAPI events

2021-03-29 Thread Igor Mammedov
On Wed, 24 Mar 2021 16:09:59 -0300 Daniel Henrique Barboza wrote: > On 3/23/21 10:40 PM, David Gibson wrote: > > On Tue, Mar 23, 2021 at 02:10:22PM -0300, Daniel Henrique Barboza wrote: > >> > >> > >> On 3/22/21 10:12 PM, David Gibson wrote: > >>> On Fri, Mar 12, 2021 at 05:07:36PM -0300,

Re: Ways to deal with broken machine types

2021-03-29 Thread Igor Mammedov
On Mon, 29 Mar 2021 15:46:53 +0100 "Dr. David Alan Gilbert" wrote: > * Igor Mammedov (imamm...@redhat.com) wrote: > > On Tue, 23 Mar 2021 17:40:36 + > > Daniel P. Berrangé wrote: > > > > > On Tue, Mar 23, 2021 at 05:54:47PM +0100, Igor Mammedov wr

Re: Ways to deal with broken machine types

2021-03-25 Thread Igor Mammedov
On Tue, 23 Mar 2021 17:40:36 + Daniel P. Berrangé wrote: > On Tue, Mar 23, 2021 at 05:54:47PM +0100, Igor Mammedov wrote: > > Let me hijack this thread for beyond this case scope. > > > > I agree that for this particular bug we've done all we could, but > > there

Re: [PATCH] i386/acpi: restore device paths for pre-5.1 vms

2021-03-25 Thread Igor Mammedov
On Tue, 23 Mar 2021 15:32:23 -0400 "Michael S. Tsirkin" wrote: > On Tue, Mar 23, 2021 at 04:04:11PM +0100, Thomas Lamprecht wrote: > > On 23.03.21 15:55, Vitaly Cheptsov wrote: > > >> 23 марта 2021 г., в 17:48, Michael S. Tsirkin > > >> написал(а): > > >> > > >> The issue is with people who

Re: [PULL 00/20] pc,virtio,pci: fixes, features

2021-03-23 Thread Igor Mammedov
On Tue, 23 Mar 2021 10:13:58 -0400 "Michael S. Tsirkin" wrote: CCing Philippe, maybe he has an idea how to fix it from mips side. > On Tue, Mar 23, 2021 at 10:50:05AM +, Peter Maydell wrote: > > On Mon, 22 Mar 2021 at 22:56, Michael S. Tsirkin wrote: > > > On Mon, Mar 22, 2021 at

Ways to deal with broken machine types

2021-03-23 Thread Igor Mammedov
On Tue, 23 Mar 2021 16:04:11 +0100 Thomas Lamprecht wrote: > On 23.03.21 15:55, Vitaly Cheptsov wrote: > >> 23 марта 2021 г., в 17:48, Michael S. Tsirkin написал(а): > >> > >> The issue is with people who installed a VM using 5.1 qemu, > >> migrated to 5.2, booted there and set a config on a

Re: [RFC] adding a generic QAPI event for failed device hotunplug

2021-03-23 Thread Igor Mammedov
On Tue, 23 Mar 2021 14:33:28 +1100 David Gibson wrote: > On Mon, Mar 22, 2021 at 01:06:53PM +0100, Paolo Bonzini wrote: > > On 22/03/21 07:39, David Gibson wrote: > > > > QEMU doesn't really keep track of "in flight" unplug requests, and as > > > > long as that's the case, its timeout even

Re: CXL 2.0 memory device design

2021-03-19 Thread Igor Mammedov
On Wed, 17 Mar 2021 14:40:58 -0700 Ben Widawsky wrote: > Phil, Igor, Markus > > TL;DR: What to do about multiple capacities in a single device, and what to do > about interleave? > > I've hacked together a basic CXL 2.0 implementation which exposes a CXL "Type > 3" > memory device (CXL 2.0

Re: Windows 10 won't run on default x86_64 machine anymore

2021-03-17 Thread Igor Mammedov
On Wed, 17 Mar 2021 09:58:25 +0100 Reinoud Zandijk wrote: > On Tue, Mar 16, 2021 at 09:34:08PM +0100, Igor Mammedov wrote: > > Thanks for reporting it before it was released > > please test/review fix that I've just posted: > > > > "[PATCH for-6.0] x86:acpi:piix

Re: [PATCH for-6.0] x86:acpi:piix4: reinitialize PM1.CNT on reset

2021-03-17 Thread Igor Mammedov
cpi_gpe_reset(>ar); It's very possible we should reset other registers too. Can you look into it, please? > > Reviewed-by: Isaku Yamahata Thanks! > > Thanks, > > > On Tue, Mar 16, 2021 at 04:29:56PM -0400, > Igor Mammedov wrote: > > > Commit 6be8cf56bc8b

Re: Windows 10 won't run on default x86_64 machine anymore

2021-03-16 Thread Igor Mammedov
On Tue, 16 Mar 2021 18:17:50 +0100 Igor Mammedov wrote: > On Tue, 16 Mar 2021 17:28:52 +0100 > Reinoud Zandijk wrote: > > > On Tue, Mar 16, 2021 at 01:53:01PM +0100, Igor Mammedov wrote: > > > > The image file was downloaded pre-installed from Microsof

[PATCH for-6.0] x86:acpi:piix4: reinitialize PM1.CNT on reset

2021-03-16 Thread Igor Mammedov
=off -cdrom any_windows_10x64.iso Fix it by calling acpi_pm1_cnt_reset() at piix4 reset time. Fixes: 6be8cf56bc8b (acpi/core: always set SCI_EN when SMM isn't supported) Signed-off-by: Igor Mammedov --- CC: isaku.yamah...@intel.com CC: m...@redhat.com CC: rein...@netbsd.org CC: isaku.yamah

Re: Windows 10 won't run on default x86_64 machine anymore

2021-03-16 Thread Igor Mammedov
On Tue, 16 Mar 2021 18:33:47 +0100 Paolo Bonzini wrote: > On 16/03/21 17:49, Igor Mammedov wrote: > > | smm=on | smm=off| > > -- > > QEMU6.0 pc-i440fx-5.2 |pass| pass |

Re: Windows 10 won't run on default x86_64 machine anymore

2021-03-16 Thread Igor Mammedov
On Tue, 16 Mar 2021 17:28:52 +0100 Reinoud Zandijk wrote: > On Tue, Mar 16, 2021 at 01:53:01PM +0100, Igor Mammedov wrote: > > > The image file was downloaded pre-installed from Microsoft for Edge > > > browser > > > evaluation. I used it first on Qemu 5.1 II

Re: Windows 10 won't run on default x86_64 machine anymore

2021-03-16 Thread Igor Mammedov
On Tue, 16 Mar 2021 14:10:44 +0100 Igor Mammedov wrote: > On Tue, 16 Mar 2021 13:49:57 +0100 > Paolo Bonzini wrote: > > > On 16/03/21 13:13, Igor Mammedov wrote: > > >>> Surprisingly without accelerator ie with tcg the default machine does > > >>

Re: Windows 10 won't run on default x86_64 machine anymore

2021-03-16 Thread Igor Mammedov
On Tue, 16 Mar 2021 13:49:57 +0100 Paolo Bonzini wrote: > On 16/03/21 13:13, Igor Mammedov wrote: > >>> Surprisingly without accelerator ie with tcg the default machine does > >>> seem to > >>> get to the login prompt. Is the ACPI data tailo

Re: Windows 10 won't run on default x86_64 machine anymore

2021-03-16 Thread Igor Mammedov
On Tue, 16 Mar 2021 12:40:28 + Daniel P. Berrangé wrote: > On Tue, Mar 16, 2021 at 01:33:54PM +0100, Igor Mammedov wrote: > > On Mon, 15 Mar 2021 15:05:26 -0700 > > Isaku Yamahata wrote: > > > > > On Mon, Mar 15, 2021 at 05:58:04PM +0100, > > > Rei

Re: Windows 10 won't run on default x86_64 machine anymore

2021-03-16 Thread Igor Mammedov
On Mon, 15 Mar 2021 23:27:29 +0100 Reinoud Zandijk wrote: > On Mon, Mar 15, 2021 at 06:53:02PM +0100, Igor Mammedov wrote: > > Windows 10 1607x64 boots fine when I test it with default machine. > > > > So > > 1) can you provide full QEMU command line used > &g

Re: Windows 10 won't run on default x86_64 machine anymore

2021-03-16 Thread Igor Mammedov
On Mon, 15 Mar 2021 15:05:26 -0700 Isaku Yamahata wrote: > On Mon, Mar 15, 2021 at 05:58:04PM +0100, > Reinoud Zandijk wrote: > > > I think its better to revert this and fix Linux ;) or make it a selectable > > feature as a workaround that's by default OFF :) > > Anyway here is a patch to

Re: Windows 10 won't run on default x86_64 machine anymore

2021-03-16 Thread Igor Mammedov
On Mon, 15 Mar 2021 18:55:03 -0700 Isaku Yamahata wrote: > On Mon, Mar 15, 2021 at 11:27:29PM +0100, > Reinoud Zandijk wrote: > > > On Mon, Mar 15, 2021 at 06:53:02PM +0100, Igor Mammedov wrote: > > > Windows 10 1607x64 boots fine when I test it with default

Re: [PATCH 0/6] pc: support user provided NIC naming/indexing

2021-03-15 Thread Igor Mammedov
On Mon, 15 Mar 2021 11:36:49 -0700 (PDT) no-re...@patchew.org wrote: > Patchew URL: > https://patchew.org/QEMU/20210315180102.3008391-1-imamm...@redhat.com/ > > > > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Type: series >

[PATCH 4/6] acpi: add aml_to_decimalstring() and aml_call6() helpers

2021-03-15 Thread Igor Mammedov
it will be used by follow up patches Signed-off-by: Igor Mammedov --- include/hw/acpi/aml-build.h | 3 +++ hw/acpi/aml-build.c | 28 2 files changed, 31 insertions(+) diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h index 380d3e3924

[PATCH 1/6] tests: acpi: temporary whitelist DSDT changes

2021-03-15 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- tests/qtest/bios-tables-test-allowed-diff.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h index dfb8523c8b..fddcfc061f 100644 --- a/tests/qtest/bios

[PATCH 2/6] pci: introduce apci-index property for PCI device

2021-03-15 Thread Igor Mammedov
re guest NIC. This patch adds, 'acpi-index'* property and wires up a 32bit register on top of pci hotplug register block to pass index value to AML code at runtime. Following patch will add corresponding _DSM code and wire it up to PCI devices described in ACPI. *) name comes from linux kernel te

[PATCH 3/6] pci: acpi: ensure that acpi-index is unique

2021-03-15 Thread Igor Mammedov
scope. This instance number does not have to be sequential in a given system configuration. " Signed-off-by: Igor Mammedov --- hw/acpi/pcihp.c | 46 ++ 1 file changed, 46 insertions(+) diff --git a/hw/acpi/pcihp.c b/hw/acpi/pcihp.c index ceab287bd3..f4cb3c9

[PATCH 6/6] tests: acpi: update expected blobs

2021-03-15 Thread Igor Mammedov
+{ +Return (PDSM (Arg0, Arg1, Arg2, Arg3, BSEL, _SUN)) +} + Method (_S1D, 0, NotSerialized) // _S1D: S1 Device State { Return (Zero) [...] Signed-off-by: Igor Mammedov --- tests/qtest/bios-tables-test-allowe

[PATCH 5/6] pci: acpi: add _DSM method to PCI devices

2021-03-15 Thread Igor Mammedov
lugged (monitor) device_del remove_me (monitor) device_add e1000,acpi-index=1 => 'eno1' Windows also sees index under "PCI Label Id" field in properties dialog but otherwise it doesn't seem to have any effect. Signed-off-by: Igor Mammedov --- v1: * drop optional

[PATCH 0/6] pc: support user provided NIC naming/indexing

2021-03-15 Thread Igor Mammedov
://github.com/imammedo/qemu/branches acpi-index-v1 CC: la...@redhat.com CC: m...@redhat.com CC: jus...@redhat.com Igor Mammedov (6): tests: acpi: temporary whitelist DSDT changes pci: introduce apci-index property for PCI device pci: acpi: ensure that acpi-index is unique acpi: add

Re: Windows 10 won't run on default x86_64 machine anymore

2021-03-15 Thread Igor Mammedov
keep compatibility, use > "smm-compat" introduced by earlier patch. If the property is true, > disable new behavior. > > ACPI spec 4.8.10.1 PM1 Event Grouping > PM1 Eanble Registers > > For ACPI-only platforms (where SCI_EN is always set) >

Re: [PATCH v3 0/4] acpi: Set proper maximum size for "etc/table-loader" blob

2021-03-15 Thread Igor Mammedov
utils.c | 17 +++-- > hw/arm/virt-acpi-build.c| 12 ++-- > hw/i386/acpi-build.c| 7 +++ > hw/i386/acpi-microvm.c | 16 ++-- > include/hw/acpi/aml-build.h | 3 --- > include/hw/acpi/utils.h | 3 +-- > 6 files changed, 31 insertions(+), 27 deletions(-) > Reviewed-by: Igor Mammedov

Re: [PATCH v3 4/4] acpi: Set proper maximum size for "etc/acpi/rsdp" blob

2021-03-15 Thread Igor Mammedov
does not exceed the maximum size; while > qemu_ram_alloc_internal() properly asserts that the initial RAMBlock size > is <= its maximum size, the result might differ when the host page size > is bigger than 4k. > > Suggested-by: Laszlo Ersek > Cc: Alistair Francis > Cc: Paol

qemu crashes on changing display resolution within guest

2021-03-12 Thread Igor Mammedov
happens on current master, to reproduce start ./x86_64-softmmu/qemu-system-x86_64 -enable-kvm -m 1g -M pc -vnc localhost:0 \ -snapshot -cdrom Fedora-Workstation-Live-x86_64-33-1.2.iso connect to guest using 'Remote Desktop', wait till it boots to graphical desktop then try to change

Re: [Bug 1917565] Re: Windows 10 fails with "Boot device inaccessible"

2021-03-03 Thread Igor Mammedov
On Wed, 03 Mar 2021 05:10:51 - Nick <1917...@bugs.launchpad.net> wrote: Is it happening to preexisting guest images only or to clean install as well? > ** Description changed: > > The issue is happening on all versions I tried after the following > - commit. > + commit. I can also

Re: [PATCH v1 2/2] exec: Get rid of phys_mem_set_alloc()

2021-03-03 Thread Igor Mammedov
Cc: Thomas Huth > Cc: Igor Mammedov > Cc: Peter Xu > Signed-off-by: David Hildenbrand Reviewed-by: Igor Mammedov > --- > include/sysemu/kvm.h | 4 > softmmu/physmem.c| 36 +++- > 2 files changed, 3 insertions(+), 37 deletions(-)

Re: [PATCH v1 1/2] s390x/kvm: Get rid of legacy_s390_alloc()

2021-03-03 Thread Igor Mammedov
> Cc: Paolo Bonzini > Cc: Richard Henderson > Cc: Halil Pasic > Cc: Cornelia Huck > Cc: Christian Borntraeger > Cc: Thomas Huth > Cc: Igor Mammedov > Cc: Peter Xu > Signed-off-by: David Hildenbrand Reviewed-by: Igor Mammedov > --- > target/s390x/kvm.c |

Re: [PATCH v1] acpi: increase maximum size for "etc/table-loader" blob

2021-03-03 Thread Igor Mammedov
On Wed, 3 Mar 2021 16:03:36 +0100 Laszlo Ersek wrote: > On 03/02/21 19:43, David Hildenbrand wrote: > > > We are dealing with different blobs here (tables_blob vs. cmd_blob). > > OK, thanks -- this was the important bit I was missing. Over time I've > lost track of the actual set of fw_cfg

Re: [PATCH v1] acpi: increase maximum size for "etc/table-loader" blob

2021-03-03 Thread Igor Mammedov
On Wed, 3 Mar 2021 10:49:08 +0100 David Hildenbrand wrote: > On 02.03.21 19:43, David Hildenbrand wrote: > The resizeable memory region that is created for the cmd blob has a > maximum > size of ACPI_BUILD_ALIGN_SIZE - 4k. This used to be sufficient, however, > > >> > >>

Re: [PATCH v1] acpi: increase maximum size for "etc/table-loader" blob

2021-03-02 Thread Igor Mammedov
setups that would have crashed until now for compat > machines. But I am not sure if the effort (messing compat machine > properties) is worth it as we fail migration in a safe way early. > > Cc: Alistair Francis > Cc: Paolo Bonzini > Cc: "Michael S. Tsirkin"

Re: [PATCH v1] acpi: increase maximum size for "etc/table-loader" blob

2021-03-02 Thread Igor Mammedov
On Tue, 2 Mar 2021 11:32:09 +0100 David Hildenbrand wrote: > On 02.03.21 11:07, Michael S. Tsirkin wrote: > > On Tue, Mar 02, 2021 at 10:43:55AM +0100, David Hildenbrand wrote: > >> On 02.03.21 10:06, Igor Mammedov wrote: > >>> On Mon, 1 Mar 2021 11:48:33

Re: [PATCH v1] acpi: increase maximum size for "etc/table-loader" blob

2021-03-02 Thread Igor Mammedov
ot sure if the effort (messing compat machine > properties) is worth it as we fail migration in a safe way early. > > Cc: Alistair Francis > Cc: Paolo Bonzini > Cc: "Michael S. Tsirkin" > Cc: Igor Mammedov > Cc: Peter Maydell > Cc: Shannon Zhao > Cc: Marc

Re: [PATCH] i386/acpi: restore device paths for pre-5.1 vms

2021-03-02 Thread Igor Mammedov
u-sta...@nongnu.org > Cc: qemu-devel@nongnu.org > Reported-by: Thomas Lamprecht > Suggested-by: Michael S. Tsirkin > Signed-off-by: Vitaly Cheptsov Reviewed-by: Igor Mammedov > --- > hw/i386/acpi-build.c | 4 ++-- > hw/i386/pc_piix.c| 2 ++ > hw/i386/pc_q35.c

Re: [PATCH 2/2] acpi: Consolidate the handling of OEM ID and OEM Table ID fields

2021-03-01 Thread Igor Mammedov
On Sun, 21 Feb 2021 02:17:37 +0200 Marian Postevca wrote: > Introduces structure AcpiBuildOem to hold the value of OEM fields and > uses dedicated macros to initialize/set the values. > Unnecessary dynamically allocated OEM fields are re-factored to static > allocation. looks fine to me.

Re: [PATCH 1/2] acpi: Move setters/getters of oem fields to X86MachineState

2021-03-01 Thread Igor Mammedov
Postevca nice cleanup, thanks! Reviewed-by: Igor Mammedov > --- > include/hw/i386/microvm.h | 4 --- > include/hw/i386/pc.h | 4 --- > include/hw/i386/x86.h | 4 +++ > hw/i386/acpi-build.c | 48 ++-- > hw/i386/acpi-microvm.c| 1

Re: [PATCH 1/2] i386/acpi: fix inconsistent QEMU/OVMF device paths

2021-03-01 Thread Igor Mammedov
On Mon, 1 Mar 2021 15:27:38 +0100 Thomas Lamprecht wrote: > On 01.03.21 15:20, Igor Mammedov wrote: > > On Mon, 1 Mar 2021 08:45:53 +0100 > > Thomas Lamprecht wrote: > >> On 01.03.21 08:20, Michael S. Tsirkin wrote: > >>> There are various testing ef

Re: [PATCH 1/2] i386/acpi: fix inconsistent QEMU/OVMF device paths

2021-03-01 Thread Igor Mammedov
On Mon, 1 Mar 2021 17:28:05 +0100 Laszlo Ersek wrote: > On 03/01/21 17:14, Michael S. Tsirkin wrote: > > On Mon, Mar 01, 2021 at 02:28:19PM +0100, Igor Mammedov wrote: > > >> How about: > >> * buggy ACPI for 5.1 machine types and older > >> * fixed ACP

Re: [PATCH v4 16/21] i386: track explicit 'hv-*' features enablement/disablement

2021-03-01 Thread Igor Mammedov
On Wed, 24 Feb 2021 18:00:43 +0100 Vitaly Kuznetsov wrote: > Igor Mammedov writes: > > > On Tue, 23 Feb 2021 19:08:42 +0100 > > Vitaly Kuznetsov wrote: > > > >> Igor Mammedov writes: > >> > >> > On Tue, 23 Feb 2021 16:46:50 +0100 &

Re: [PATCH 1/2] i386/acpi: fix inconsistent QEMU/OVMF device paths

2021-03-01 Thread Igor Mammedov
On Mon, 1 Mar 2021 08:45:53 +0100 Thomas Lamprecht wrote: > On 01.03.21 08:20, Michael S. Tsirkin wrote: > > On Mon, Mar 01, 2021 at 08:12:35AM +0100, Thomas Lamprecht wrote: > >> On 28.02.21 21:43, Michael S. Tsirkin wrote: > >>> Sure. The way to do that is to tie old behaviour to old

Re: [PATCH 1/2] i386/acpi: fix inconsistent QEMU/OVMF device paths

2021-03-01 Thread Igor Mammedov
On Sun, 28 Feb 2021 15:43:40 -0500 "Michael S. Tsirkin" wrote: > On Sat, Feb 27, 2021 at 08:41:11PM +0100, Thomas Lamprecht wrote: > > On 30.07.20 17:58, Michael S. Tsirkin wrote: > > > macOS uses ACPI UIDs to build the DevicePath for NVRAM boot options, > > > while OVMF firmware gets them via

Re: [PATCH v5 00/10] ACPI related fixes to comform the spec better

2021-02-24 Thread Igor Mammedov
On Wed, 17 Feb 2021 21:51:08 -0800 isaku.yamah...@gmail.com wrote: > From: Isaku Yamahata > > Miscellaneous bug fixes related to ACPI to play nice with guest BIOSes/OSes > by conforming to ACPI spec better. Michael, I finished with review, to me series looks ready to be merged > Changes

Re: [PATCH v4 16/21] i386: track explicit 'hv-*' features enablement/disablement

2021-02-24 Thread Igor Mammedov
On Tue, 23 Feb 2021 19:08:42 +0100 Vitaly Kuznetsov wrote: > Igor Mammedov writes: > > > On Tue, 23 Feb 2021 16:46:50 +0100 > > Vitaly Kuznetsov wrote: > > > >> Igor Mammedov writes: > >> > >> > On Mon, 22 Feb 2021 11:20:34 +0100 >

Re: [PATCH v4 16/21] i386: track explicit 'hv-*' features enablement/disablement

2021-02-23 Thread Igor Mammedov
On Tue, 23 Feb 2021 16:46:50 +0100 Vitaly Kuznetsov wrote: > Igor Mammedov writes: > > > On Mon, 22 Feb 2021 11:20:34 +0100 > > Vitaly Kuznetsov wrote: > > > >> Vitaly Kuznetsov writes: > >> > >> > Igor Mammedov writes: > &

Re: [PATCH v4 16/21] i386: track explicit 'hv-*' features enablement/disablement

2021-02-23 Thread Igor Mammedov
On Mon, 22 Feb 2021 11:20:34 +0100 Vitaly Kuznetsov wrote: > Vitaly Kuznetsov writes: > > > Igor Mammedov writes: > > > >>> > >>> We need to distinguish because that would be sane. > >>> > >>> Enlightened VMCS is an ex

Re: [PATCH v5 07/10] hw/i386: declare ACPI mother board resource for MMCONFIG region

2021-02-23 Thread Igor Mammedov
onRegion (HPTM, SystemMemory, 0xFED0, 0x0400) > Field (HPTM, DWordAcc, Lock, Preserve) > { > VEND, 32, > PRD,32 > } > > Method (_STA, 0, NotSerialized) // _STA: Status > >

Re: [PATCH v5 03/10] ich9, piix4: add properoty, smm-compat, to keep compatibility of SMM

2021-02-23 Thread Igor Mammedov
old behavior for compatibility. > To enable smm compat, use "-global ICH9-LPC.smm-compat=on" or > "-global PIIX4_PM.smm-compat=on" > > Suggested-by: Igor Mammedov > Signed-off-by: Isaku Yamahata Reviewed-by: Igor Mammedov > --- > hw/acpi/piix4.c| 2 ++ >

Re: [PATCH v4 07/10] hw/i386: declare ACPI mother board resource for MMCONFIG region

2021-02-16 Thread Igor Mammedov
On Mon, 15 Feb 2021 17:04:12 -0800 isaku.yamah...@gmail.com wrote: > From: Isaku Yamahata > > Declare PNP0C01 device to reserve MMCONFIG region to conform to the > spec better and play nice with guest BIOSes/OSes. > > According to PCI Firmware Specification[0], MMCONFIG region must be >

Re: [PATCH v4 04/10] acpi/core: always set SCI_EN when SMM isn't supported

2021-02-16 Thread Igor Mammedov
uest ABI. To keep compatibility, use > "x-smm-compat-5" introduced by earlier patch. > If the property is true, disable new behavior. > > ACPI spec 4.8.10.1 PM1 Event Grouping > PM1 Eanble Registers > > For ACPI-only platforms (where SCI_EN is always set) > >

Re: [PATCH v4 03/10] ich9, piix4: add properoty, smm-compat, to keep compatibility of SMM

2021-02-16 Thread Igor Mammedov
ICH9-LPC.smm-compat=on" or > "-global PIIX4.smm-compat=on" > > Suggested-by: Igor Mammedov > Signed-off-by: Isaku Yamahata looks good to me, but doesn't apply to master anymore, so needs to be rebased > --- > hw/acpi/piix4.c| 2 ++ > hw/core/machine.c | 5

Re: [PATCH] acpi: Remove duplicated code handling OEM ID and OEM table ID fields

2021-02-16 Thread Igor Mammedov
On Mon, 15 Feb 2021 20:26:10 +0200 Marian Postevca wrote: > Igor Mammedov writes: > > > hmm, looks like adding instead of removing > > > Do you mean that the commit message does not describe the change > correctly, or that my refactoring is too extreme? I've me

Re: [PATCH v3 07/10] hw/i386: declare ACPI mother board resource for MMCONFIG region

2021-02-16 Thread Igor Mammedov
On Tue, 16 Feb 2021 10:13:25 -0800 Isaku Yamahata wrote: > On Tue, Feb 16, 2021 at 08:45:48AM -0500, > "Michael S. Tsirkin" wrote: > > > On Tue, Feb 16, 2021 at 01:43:01AM -0800, Isaku Yamahata wrote: > > > On Mon, Feb 15, 2021 at 01:48:32PM

  1   2   3   4   5   6   7   8   9   10   >