Re: [PATCH] MAINTAINERS: add/replace backups for some s390 areas

2021-03-25 Thread Jason J. Herne
Pasic -M: Pierre Morel +M: Jason Herne Acked-by: Jason J. Herne -- -- Jason J. Herne (jjhe...@linux.ibm.com)

Re: [PATCH] pc-bios/s390x: Pack ResetInfo struct

2020-09-01 Thread Jason J. Herne
On 8/27/20 6:07 AM, Thomas Huth wrote: On 07/02/2020 15.02, Jason J. Herne wrote: On 2/7/20 6:28 AM, Christian Borntraeger wrote: Jason, can you run objdump -Sdr on jump2ipl.o on a broken variant? To keep the volume lower, I've only pasted the output that I think you're interested

Re: [PATCH] pc-bios: s390x: Only set lowcore iplb address on list-directed IPL

2020-08-25 Thread Jason J. Herne
On 8/25/20 7:38 AM, Thomas Huth wrote: On 19/08/2020 12.46, Janosch Frank wrote: On 8/19/20 11:45 AM, Cornelia Huck wrote: On Wed, 19 Aug 2020 11:32:34 +0200 Janosch Frank wrote: On 8/17/20 7:51 PM, Jason J. Herne wrote: On 8/17/20 12:30 PM, Cornelia Huck wrote: On Mon, 17 Aug 2020 10:17

Re: [PATCH] pc-bios: s390x: Only set lowcore iplb address on list-directed IPL

2020-08-17 Thread Jason J. Herne
On 8/17/20 12:30 PM, Cornelia Huck wrote: On Mon, 17 Aug 2020 10:17:34 -0400 "Jason J. Herne" wrote: The POP states that the IPLB location is only written to 0x14 for list-directed IPL. Some operating systems expect 0x14 to not change on boot and will fail IPL if it does chan

[PATCH] pc-bios: s390x: Only set lowcore iplb address on list-directed IPL

2020-08-17 Thread Jason J. Herne
The POP states that the IPLB location is only written to 0x14 for list-directed IPL. Some operating systems expect 0x14 to not change on boot and will fail IPL if it does change. Fixes: 9bfc04f9ef6802fff0 Signed-off-by: Jason J. Herne Reviewed-by: Janosch Frank --- pc-bios/s390-ccw/jump2ipl.c

Re: [PATCH] pc-bios/s390x: Pack ResetInfo struct

2020-02-25 Thread Jason J. Herne
On 2/25/20 6:13 AM, Christian Borntraeger wrote: On 25.02.20 11:23, Jason J. Herne wrote: On 2/13/20 1:24 PM, Christian Borntraeger wrote: ... diff --git a/pc-bios/s390-ccw/jump2ipl.c b/pc-bios/s390-ccw/jump2ipl.c index da13c43cc0..8839226803 100644 --- a/pc-bios/s390-ccw/jump2ipl.c +++ b/pc

Re: [PATCH] pc-bios/s390x: Pack ResetInfo struct

2020-02-25 Thread Jason J. Herne
static void jump_to_IPL_2(void) { ResetInfo *current = 0; void (*ipl)(void) = (void *) (uint64_t) current->ipl_continue; *current = save; ipl(); /* should not return */ } -- -- Jason J. Herne (jjhe...@linux.ibm.com)

Re: [PATCH] pc-bios/s390x: Pack ResetInfo struct

2020-02-13 Thread Jason J. Herne
On 2/6/20 5:09 AM, Christian Borntraeger wrote: On 05.02.20 19:21, Jason J. Herne wrote: This fixes vfio-ccw when booting non-Linux operating systems. Without this struct being packed, a few extra bytes of low core memory get overwritten when we assign a value to memory address 0

Re: [PATCH] pc-bios/s390x: Pack ResetInfo struct

2020-02-07 Thread Jason J. Herne
0x2 } 334: 18 00 lr %r0,%r0 336: eb bf b1 08 00 04 lmg %r11,%r15,264(%r11) 33c: 07 fe br %r14 33e: 07 07 nopr%r7 -- -- Jason J. Herne (jjhe...@linux.ibm.com)

[PATCH] pc-bios/s390x: Pack ResetInfo struct

2020-02-05 Thread Jason J. Herne
: Fix reset psw mask") CC: Janosch Frank Signed-off-by: Jason J. Herne --- pc-bios/s390-ccw/jump2ipl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pc-bios/s390-ccw/jump2ipl.c b/pc-bios/s390-ccw/jump2ipl.c index da13c43cc0..1e9eaa037f 100644 --- a/pc-bios/s390-ccw/jump

Re: [Qemu-devel] [PULL SUBSYSTEM s390x 3/3] pc-bios/s390: Update firmware image with "Skip bootmap signature entries" fix

2019-05-10 Thread Jason J. Herne
img b/pc-bios/s390-ccw.img index ba054828d35d72fd1ed5521a48f43f593a1c291f..a0234bf748e10fdfaab27b8a751bee1db1865256 100644 GIT binary patch literal 42608 zcmeHwd3==B){GbBJ*5+(^t*kmRPCW ... I've tested this build with signature entries in the bootmap and everything appears to work. -- -- Jaso

Re: [Qemu-devel] [PATCH] s390-bios: Skip bootmap signature entries

2019-05-06 Thread Jason J. Herne
On 5/6/19 4:08 AM, Christian Borntraeger wrote: On 03.05.19 11:34, Thomas Huth wrote: On 29/04/2019 15.09, Jason J. Herne wrote: Newer versions of zipl have the ability to write signature entries to the boot script for secure boot. We don't yet support secure boot, but we need to skip over

[Qemu-devel] [PATCH] s390-bios: Skip bootmap signature entries

2019-04-29 Thread Jason J. Herne
bootloader. Signed-off-by: Jason J. Herne Reviewed-by: Farhan Ali --- pc-bios/s390-ccw/bootmap.c | 19 +-- pc-bios/s390-ccw/bootmap.h | 10 ++ 2 files changed, 23 insertions(+), 6 deletions(-) diff --git a/pc-bios/s390-ccw/bootmap.c b/pc-bios/s390-ccw/bootmap.c index 7aef65a

Re: [Qemu-devel] [qemu-s390x] [PATCH v6 00/16] s390: vfio-ccw dasd ipl support

2019-04-05 Thread Jason J. Herne
On 4/5/19 9:26 AM, Thomas Huth wrote: On 05/04/2019 15.11, Jason J. Herne wrote: On 4/5/19 3:52 AM, Thomas Huth wrote: On 05/04/2019 08.58, Thomas Huth wrote: [...] while running my s390-ccw bios tests, I noticed that network booting seems to be broken now. This used to work before: s390x

Re: [Qemu-devel] [qemu-s390x] [PATCH v6 00/16] s390: vfio-ccw dasd ipl support

2019-04-05 Thread Jason J. Herne
On 4/5/19 3:52 AM, Thomas Huth wrote: On 05/04/2019 08.58, Thomas Huth wrote: On 04/04/2019 16.34, Jason J. Herne wrote: This is to support booting from vfio-ccw dasd devices. We basically implement the real hardware ipl procedure. This allows for booting Linux guests on vfio-ccw devices

[Qemu-devel] [PATCH v6 15/16] s390-bios: Support booting from real dasd device

2019-04-04 Thread Jason J. Herne
Allows guest to boot from a vfio configured real dasd device. Signed-off-by: Jason J. Herne Reviewed-by: Cornelia Huck --- MAINTAINERS | 1 + docs/devel/s390-dasd-ipl.txt | 133 pc-bios/s390-ccw/Makefile| 2 +- pc-bios/s390-ccw/dasd-ipl.c

[Qemu-devel] [PATCH v6 12/16] s390-bios: Refactor virtio to run channel programs via cio

2019-04-04 Thread Jason J. Herne
Now that we have a Channel I/O library let's modify virtio boot code to make use of it for running channel programs. Signed-off-by: Jason J. Herne Reviewed-by: Cornelia Huck Acked-by: Thomas Huth --- pc-bios/s390-ccw/virtio.c | 57 ++- 1 file

[Qemu-devel] [PATCH v6 09/16] s390-bios: cio error handling

2019-04-04 Thread Jason J. Herne
addr [0]=: 0x cyl & head addr [1]=: 0x cyl & head addr [2]=: 0x The Sense Data section is currently only printed for ECKD DASD. Signed-off-by: Jason J. Herne Reviewed-by: Cornelia Huck --- pc-bios/s390-

[Qemu-devel] [PATCH v6 16/16] s390-bios: Use control unit type to find bootable devices

2019-04-04 Thread Jason J. Herne
When the user does not specify which device to boot from then we end up guessing. Instead of simply grabbing the first available device let's be a little bit smarter and only choose devices that might be bootable like disk, and not console devices. Signed-off-by: Jason J. Herne --- pc-bios/s390

[Qemu-devel] [PATCH v6 13/16] s390-bios: Use control unit type to determine boot method

2019-04-04 Thread Jason J. Herne
as well remove that call from virtio.c : run_ccw(). This requires adding some additional enable_subchannel calls to not break calls to virtio_is_supported(). Signed-off-by: Jason J. Herne Reviewed-by: Cornelia Huck Reviewed-by: Thomas Huth --- pc-bios/s390-ccw/main.c| 16 ++-- pc-bios

[Qemu-devel] [PATCH v6 07/16] s390-bios: ptr2u32 and u32toptr

2019-04-04 Thread Jason J. Herne
Introduce inline functions to convert between pointers and unsigned 32-bit ints. These are used to hide the ugliness required to avoid compiler warnings. Signed-off-by: Jason J. Herne Acked-by: Cornelia Huck Reviewed-by: Thomas Huth --- pc-bios/s390-ccw/helper.h | 31

[Qemu-devel] [PATCH v6 11/16] s390-bios: Factor finding boot device out of virtio code path

2019-04-04 Thread Jason J. Herne
wording. Signed-off-by: Jason J. Herne Reviewed-by: Farhan Ali Reviewed-by: Cornelia Huck --- pc-bios/s390-ccw/main.c | 85 ++-- tests/boot-serial-test.c | 2 +- 2 files changed, 47 insertions(+), 40 deletions(-) diff --git a/pc-bios/s390-ccw

[Qemu-devel] [PATCH v6 14/16] s390-bios: Add channel command codes/structs needed for dasd-ipl

2019-04-04 Thread Jason J. Herne
The dasd IPL procedure needs to execute a few previously unused channel commands. Let's define them and their associated data structures. Signed-off-by: Jason J. Herne Acked-by: Cornelia Huck Acked-by: Thomas Huth --- pc-bios/s390-ccw/cio.h | 23 +++ 1 file changed, 23

[Qemu-devel] [PATCH v6 05/16] s390-bios: Decouple channel i/o logic from virtio

2019-04-04 Thread Jason J. Herne
Create a separate library for channel i/o related code. This decouples channel i/o operations from virtio and allows us to make use of them for the real dasd boot path. Signed-off-by: Jason J. Herne Reviewed-by: Cornelia Huck Reviewed-by: Thomas Huth --- pc-bios/s390-ccw/Makefile| 2

[Qemu-devel] [PATCH v6 08/16] s390-bios: Support for running format-0/1 channel programs

2019-04-04 Thread Jason J. Herne
dasd device. Signed-off-by: Jason J. Herne Reviewed-by: Cornelia Huck Reviewed-by: Farhan Ali --- pc-bios/s390-ccw/cio.c | 144 pc-bios/s390-ccw/cio.h | 130 ++- pc-bios/s390-ccw/s390-ccw.h | 1 + pc

[Qemu-devel] [PATCH v6 01/16] s390 vfio-ccw: Add bootindex property and IPLB data

2019-04-04 Thread Jason J. Herne
Add bootindex property and iplb data for vfio-ccw devices. This allows us to forward boot information into the bios for vfio-ccw devices. Refactor s390_get_ccw_device() to return device type. This prevents us from having to use messy casting logic in several places. Signed-off-by: Jason J. Herne

[Qemu-devel] [PATCH v6 03/16] s390-bios: decouple common boot logic from virtio

2019-04-04 Thread Jason J. Herne
Create a boot_setup function to handle getting boot information from the machine/hypervisor. This decouples common boot logic from the virtio code path and allows us to make use of it for the real dasd boot scenario. Signed-off-by: Jason J. Herne Acked-by: Halil Pasic Reviewed-by: Collin

[Qemu-devel] [PATCH v6 06/16] s390-bios: Map low core memory

2019-04-04 Thread Jason J. Herne
Create a new header for basic architecture specific definitions and add a mapping of low core memory. This mapping will be used by the real dasd boot process. Signed-off-by: Jason J. Herne Acked-by: Cornelia Huck Reviewed-by: Thomas Huth --- pc-bios/s390-ccw/main.c | 2 + pc-bios/s390

[Qemu-devel] [PATCH v6 10/16] s390-bios: Extend find_dev() for non-virtio devices

2019-04-04 Thread Jason J. Herne
We need a method for finding the subchannel of a dasd device. Let's modify find_dev to handle this since it mostly does what we need. Up to this point find_dev has been specific to only virtio devices. Signed-off-by: Jason J. Herne Acked-by: Halil Pasic Reviewed-by: Cornelia Huck --- pc-bios

[Qemu-devel] [PATCH v6 04/16] s390-bios: Clean up cio.h

2019-04-04 Thread Jason J. Herne
Add proper typedefs to all structs and modify all bit fields to use consistent formatting. Signed-off-by: Jason J. Herne Reviewed-by: Collin Walling Reviewed-by: Farhan Ali Acked-by: Cornelia Huck Reviewed-by: Thomas Huth --- pc-bios/s390-ccw/cio.h | 114

[Qemu-devel] [PATCH v6 02/16] s390-bios: decouple cio setup from virtio

2019-04-04 Thread Jason J. Herne
Move channel i/o setup code out to a separate function. This decouples cio setup from the virtio code path and allows us to make use of it for booting dasd devices. Signed-off-by: Jason J. Herne Acked-by: Halil Pasic Reviewed-by: Collin Walling Reviewed-by: Farhan Ali Reviewed-by: Thomas Huth

[Qemu-devel] [PATCH v6 00/16] s390: vfio-ccw dasd ipl support

2019-04-04 Thread Jason J. Herne
end of sense data status array - Reorganized patch order slightly - Other misc wording/spelling fixups Jason J. Herne (16): s390 vfio-ccw: Add bootindex property and IPLB data s390-bios: decouple cio setup from virtio s390-bios: decouple common boot logic from virtio s390-bios: Clean up

Re: [Qemu-devel] [qemu-s390x] [PATCH v5 15/15] s390-bios: Support booting from real dasd device

2019-04-01 Thread Jason J. Herne
On 3/29/19 4:33 AM, Thomas Huth wrote: On 13/03/2019 17.31, Jason J. Herne wrote: s/tansfers/transfers/ Will fix this, and the other typos you've pointed out. ... +static char prefix_page[PAGE_SIZE * 2] +__attribute__((__aligned__(PAGE_SIZE * 2))); + +static void

Re: [Qemu-devel] [qemu-s390x] [PATCH v5 11/15] s390-bios: cio error handling

2019-04-01 Thread Jason J. Herne
On 3/27/19 6:47 AM, Thomas Huth wrote: On 13/03/2019 17.31, Jason J. Herne wrote: Add verbose error output for when unexpected i/o errors happen. This eases the burden of debugging and reporting i/o errors. No error information is printed in the success case, here is an example of what

Re: [Qemu-devel] [qemu-s390x] [PATCH v5 00/15] s390: vfio-ccw dasd ipl support

2019-03-20 Thread Jason J. Herne
On 3/13/19 12:31 PM, Jason J. Herne wrote: This is to support booting from vfio-ccw dasd devices. We basically implement the real hardware ipl procedure. This allows for booting Linux guests on vfio-ccw devices. vfio-ccw's channel program prefetch algorithm complicates ipl because most ipl

[Qemu-devel] [PATCH v5 02/15] s390-bios: decouple cio setup from virtio

2019-03-13 Thread Jason J. Herne
Move channel i/o setup code out to a separate function. This decouples cio setup from the virtio code path and allows us to make use of it for booting dasd devices. Signed-off-by: Jason J. Herne Acked-by: Halil Pasic Reviewed-by: Collin Walling Reviewed-by: Farhan Ali Reviewed-by: Thomas Huth

[Qemu-devel] [PATCH v5 04/15] s390-bios: Extend find_dev() for non-virtio devices

2019-03-13 Thread Jason J. Herne
We need a method for finding the subchannel of a dasd device. Let's modify find_dev to handle this since it mostly does what we need. Up to this point find_dev has been specific to only virtio devices. Signed-off-by: Jason J. Herne Acked-by: Halil Pasic Reviewed-by: Cornelia Huck --- pc-bios

[Qemu-devel] [PATCH v5 05/15] s390-bios: Factor finding boot device out of virtio code path

2019-03-13 Thread Jason J. Herne
wording. Signed-off-by: Jason J. Herne Reviewed-by: Farhan Ali Reviewed-by: Cornelia Huck --- pc-bios/s390-ccw/main.c | 85 ++-- tests/boot-serial-test.c | 2 +- 2 files changed, 47 insertions(+), 40 deletions(-) diff --git a/pc-bios/s390-ccw

[Qemu-devel] [PATCH v5 00/15] s390: vfio-ccw dasd ipl support

2019-03-13 Thread Jason J. Herne
. Details on the ipl process and how we worked around this issue can be found in docs/devel/s390-dasd-ipl.txt. Changelog == v5 - Whitespace changes and comments. - Added newlines to printed strings in patch 15. Jason J. Herne (15): s390 vfio-ccw: Add bootindex property and IPLB data s390

[Qemu-devel] [PATCH v5 07/15] s390-bios: Decouple channel i/o logic from virtio

2019-03-13 Thread Jason J. Herne
Create a separate library for channel i/o related code. This decouples channel i/o operations from virtio and allows us to make use of them for the real dasd boot path. Signed-off-by: Jason J. Herne Reviewed-by: Cornelia Huck --- pc-bios/s390-ccw/Makefile| 2 +- pc-bios/s390-ccw/cio.c

[Qemu-devel] [PATCH v5 01/15] s390 vfio-ccw: Add bootindex property and IPLB data

2019-03-13 Thread Jason J. Herne
Add bootindex property and iplb data for vfio-ccw devices. This allows us to forward boot information into the bios for vfio-ccw devices. Refactor s390_get_ccw_device() to return device type. This prevents us from having to use messy casting logic in several places. Signed-off-by: Jason J. Herne

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 15/16] s390-bios: Support booting from real dasd device

2019-03-13 Thread Jason J. Herne
On 3/13/19 12:21 PM, Cornelia Huck wrote: On Wed, 13 Mar 2019 12:10:50 -0400 "Jason J. Herne" wrote: On 3/13/19 10:04 AM, Eric Farman wrote: +static void run_readipl(SubChannelId schid) +{ +if (do_cio(schid, 0x00, CCW_FMT0)) { +panic("dasd-ipl: Failed to run R

[Qemu-devel] [PATCH v5 03/15] s390-bios: decouple common boot logic from virtio

2019-03-13 Thread Jason J. Herne
Create a boot_setup function to handle getting boot information from the machine/hypervisor. This decouples common boot logic from the virtio code path and allows us to make use of it for the real dasd boot scenario. Signed-off-by: Jason J. Herne Acked-by: Halil Pasic Reviewed-by: Collin

[Qemu-devel] [PATCH v5 09/15] s390-bios: ptr2u32 and u32toptr

2019-03-13 Thread Jason J. Herne
Introduce inline functions to convert between pointers and unsigned 32-bit ints. These are used to hide the ugliness required to avoid compiler warnings. Signed-off-by: Jason J. Herne Acked-by: Cornelia Huck Reviewed-by: Thomas Huth --- pc-bios/s390-ccw/helper.h | 31

[Qemu-devel] [PATCH v5 06/15] s390-bios: Clean up cio.h

2019-03-13 Thread Jason J. Herne
Add proper typedefs to all structs and modify all bit fields to use consistent formatting. Signed-off-by: Jason J. Herne Reviewed-by: Collin Walling Reviewed-by: Farhan Ali Acked-by: Cornelia Huck Reviewed-by: Thomas Huth --- pc-bios/s390-ccw/cio.h | 114

[Qemu-devel] [PATCH v5 08/15] s390-bios: Map low core memory

2019-03-13 Thread Jason J. Herne
Create a new header for basic architecture specific definitions and add a mapping of low core memory. This mapping will be used by the real dasd boot process. Signed-off-by: Jason J. Herne Acked-by: Cornelia Huck --- pc-bios/s390-ccw/main.c | 2 + pc-bios/s390-ccw/s390-arch.h | 90

[Qemu-devel] [PATCH v5 10/15] s390-bios: Support for running format-0/1 channel programs

2019-03-13 Thread Jason J. Herne
dasd device. Signed-off-by: Jason J. Herne Reviewed-by: Cornelia Huck --- pc-bios/s390-ccw/cio.c | 144 pc-bios/s390-ccw/cio.h | 130 ++- pc-bios/s390-ccw/s390-ccw.h | 1 + pc-bios/s390-ccw/start.S

[Qemu-devel] [PATCH v5 14/15] s390-bios: Add channel command codes/structs needed for dasd-ipl

2019-03-13 Thread Jason J. Herne
The dasd IPL procedure needs to execute a few previously unused channel commands. Let's define them and their associated data structures. Signed-off-by: Jason J. Herne Acked-by: Cornelia Huck --- pc-bios/s390-ccw/cio.h | 23 +++ 1 file changed, 23 insertions(+) diff --git

[Qemu-devel] [PATCH v5 11/15] s390-bios: cio error handling

2019-03-13 Thread Jason J. Herne
addr [0]=: 0x cyl & head addr [1]=: 0x cyl & head addr [2]=: 0x The Sense Data section is currently only printed for ECKD DASD. Signed-off-by: Jason J. Herne Reviewed-by: Cornelia Huck --- pc-bios/s390-

[Qemu-devel] [PATCH v5 12/15] s390-bios: Refactor virtio to run channel programs via cio

2019-03-13 Thread Jason J. Herne
Now that we have a Channel I/O library let's modify virtio boot code to make use of it for running channel programs. Signed-off-by: Jason J. Herne Reviewed-by: Cornelia Huck --- pc-bios/s390-ccw/virtio.c | 57 ++- 1 file changed, 27 insertions(+), 30

[Qemu-devel] [PATCH v5 15/15] s390-bios: Support booting from real dasd device

2019-03-13 Thread Jason J. Herne
Allows guest to boot from a vfio configured real dasd device. Signed-off-by: Jason J. Herne Reviewed-by: Cornelia Huck --- MAINTAINERS | 1 + docs/devel/s390-dasd-ipl.txt | 133 +++ pc-bios/s390-ccw/Makefile| 2 +- pc-bios/s390-ccw/dasd-ipl.c | 249

[Qemu-devel] [PATCH v5 13/15] s390-bios: Use control unit type to determine boot method

2019-03-13 Thread Jason J. Herne
as well remove that call from virtio.c : run_ccw(). This requires adding some additional enable_subchannel calls to not break calls to virtio_is_supported(). Signed-off-by: Jason J. Herne Reviewed-by: Cornelia Huck --- pc-bios/s390-ccw/main.c| 16 ++-- pc-bios/s390-ccw/netmain.c | 1

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 15/16] s390-bios: Support booting from real dasd device

2019-03-13 Thread Jason J. Herne
wline. All of them appear to be before an if statement's closing brace. Can you explain why you feel these are needed? I don't really see any improvement in readability with these newlines. -- -- Jason J. Herne (jjhe...@linux.ibm.com)

Re: [Qemu-devel] [PATCH v4 01/15] s390 vfio-ccw: Add bootindex property and IPLB data

2019-03-12 Thread Jason J. Herne
On 3/12/19 6:38 AM, Cornelia Huck wrote: On Mon, 11 Mar 2019 11:21:19 -0400 "Jason J. Herne" wrote: Add bootindex property and iplb data for vfio-ccw devices. This allows us to forward boot information into the bios for vfio-ccw devices. Refactor s390_get_ccw_device() to return d

Re: [Qemu-devel] [PATCH v4 00/15] s390: vfio-ccw dasd ipl support

2019-03-11 Thread Jason J. Herne
On 3/11/19 1:33 PM, Cornelia Huck wrote: On Mon, 11 Mar 2019 11:21:18 -0400 "Jason J. Herne" wrote: This is to support booting from vfio-ccw dasd devices. We basically implement the real hardware ipl procedure. This allows for booting Linux guests on vfio-ccw devices. vfio-ccw

[Qemu-devel] [PATCH v4 06/15] s390-bios: Clean up cio.h

2019-03-11 Thread Jason J. Herne
Add proper typedefs to all structs and modify all bit fields to use consistent formatting. Signed-off-by: Jason J. Herne Reviewed-by: Collin Walling Reviewed-by: Farhan Ali Acked-by: Cornelia Huck Reviewed-by: Thomas Huth --- pc-bios/s390-ccw/cio.h | 114

[Qemu-devel] [PATCH v4 09/15] s390-bios: ptr2u32 and u32toptr

2019-03-11 Thread Jason J. Herne
Introduce inline functions to convert between pointers and unsigned 32-bit ints. These are used to hide the ugliness required to avoid compiler warnings. Signed-off-by: Jason J. Herne Acked-by: Cornelia Huck Reviewed-by: Thomas Huth --- pc-bios/s390-ccw/helper.h | 31

[Qemu-devel] [PATCH v4 12/15] s390-bios: Refactor virtio to run channel programs via cio

2019-03-11 Thread Jason J. Herne
Now that we have a Channel I/O library let's modify virtio boot code to make use of it for running channel programs. Signed-off-by: Jason J. Herne --- pc-bios/s390-ccw/virtio.c | 49 +++ 1 file changed, 20 insertions(+), 29 deletions(-) diff --git

[Qemu-devel] [PATCH v4 02/15] s390-bios: decouple cio setup from virtio

2019-03-11 Thread Jason J. Herne
Move channel i/o setup code out to a separate function. This decouples cio setup from the virtio code path and allows us to make use of it for booting dasd devices. Signed-off-by: Jason J. Herne Acked-by: Halil Pasic Reviewed-by: Collin Walling Reviewed-by: Farhan Ali Reviewed-by: Thomas Huth

[Qemu-devel] [PATCH v4 00/15] s390: vfio-ccw dasd ipl support

2019-03-11 Thread Jason J. Herne
hen it is provided 15/16: - Added support for CU_TYPE_DASD_2107 16/16: - Merged with various earlier patches Jason J. Herne (15): s390 vfio-ccw: Add bootindex property and IPLB data s390-bios: decouple cio setup from virtio s390-bios: decouple common boot logic from virtio s390-bios: Extend find_

[Qemu-devel] [PATCH v4 13/15] s390-bios: Use control unit type to determine boot method

2019-03-11 Thread Jason J. Herne
as well remove that call from virtio.c : run_ccw(). This requires adding some additional enable_subchannel calls to not break calls to virtio_is_supported(). Signed-off-by: Jason J. Herne --- pc-bios/s390-ccw/main.c| 16 ++-- pc-bios/s390-ccw/netmain.c | 1 + pc-bios/s390-ccw/virtio.c

[Qemu-devel] [PATCH v4 04/15] s390-bios: Extend find_dev() for non-virtio devices

2019-03-11 Thread Jason J. Herne
We need a method for finding the subchannel of a dasd device. Let's modify find_dev to handle this since it mostly does what we need. Up to this point find_dev has been specific to only virtio devices. Signed-off-by: Jason J. Herne Acked-by: Halil Pasic Reviewed-by: Cornelia Huck --- pc-bios

[Qemu-devel] [PATCH v4 01/15] s390 vfio-ccw: Add bootindex property and IPLB data

2019-03-11 Thread Jason J. Herne
Add bootindex property and iplb data for vfio-ccw devices. This allows us to forward boot information into the bios for vfio-ccw devices. Refactor s390_get_ccw_device() to return device type. This prevents us from having to use messy casting logic in several places. Signed-off-by: Jason J. Herne

[Qemu-devel] [PATCH v4 07/15] s390-bios: Decouple channel i/o logic from virtio

2019-03-11 Thread Jason J. Herne
Create a separate library for channel i/o related code. This decouples channel i/o operations from virtio and allows us to make use of them for the real dasd boot path. Signed-off-by: Jason J. Herne --- pc-bios/s390-ccw/Makefile| 2 +- pc-bios/s390-ccw/cio.c | 44

[Qemu-devel] [PATCH v4 14/15] s390-bios: Add channel command codes/structs needed for dasd-ipl

2019-03-11 Thread Jason J. Herne
The dasd IPL procedure needs to execute a few previously unused channel commands. Let's define them and their associated data structures. Signed-off-by: Jason J. Herne Acked-by: Cornelia Huck --- pc-bios/s390-ccw/cio.h | 23 +++ 1 file changed, 23 insertions(+) diff --git

[Qemu-devel] [PATCH v4 08/15] s390-bios: Map low core memory

2019-03-11 Thread Jason J. Herne
Create a new header for basic architecture specific definitions and add a mapping of low core memory. This mapping will be used by the real dasd boot process. Signed-off-by: Jason J. Herne Acked-by: Cornelia Huck --- pc-bios/s390-ccw/main.c | 2 + pc-bios/s390-ccw/s390-arch.h | 90

[Qemu-devel] [PATCH v4 05/15] s390-bios: Factor finding boot device out of virtio code path

2019-03-11 Thread Jason J. Herne
wording. Signed-off-by: Jason J. Herne Reviewed-by: Farhan Ali Reviewed-by: Cornelia Huck --- pc-bios/s390-ccw/main.c | 85 ++-- tests/boot-serial-test.c | 2 +- 2 files changed, 47 insertions(+), 40 deletions(-) diff --git a/pc-bios/s390-ccw

[Qemu-devel] [PATCH v4 10/15] s390-bios: Support for running format-0/1 channel programs

2019-03-11 Thread Jason J. Herne
dasd device. Signed-off-by: Jason J. Herne --- pc-bios/s390-ccw/cio.c | 144 pc-bios/s390-ccw/cio.h | 130 ++- pc-bios/s390-ccw/s390-ccw.h | 1 + pc-bios/s390-ccw/start.S| 29 + 4 files

[Qemu-devel] [PATCH v4 11/15] s390-bios: cio error handling

2019-03-11 Thread Jason J. Herne
addr [0]=: 0x cyl & head addr [1]=: 0x cyl & head addr [2]=: 0x Signed-off-by: Jason J. Herne --- pc-bios/s390-ccw/cio.c | 237 +++- pc-bios/s390-ccw/libc.h | 11 +++ 2 files changed, 247 insertion

[Qemu-devel] [PATCH v4 15/15] s390-bios: Support booting from real dasd device

2019-03-11 Thread Jason J. Herne
Allows guest to boot from a vfio configured real dasd device. Signed-off-by: Jason J. Herne Reviewed-by: Cornelia Huck --- MAINTAINERS | 1 + docs/devel/s390-dasd-ipl.txt | 133 +++ pc-bios/s390-ccw/Makefile| 2 +- pc-bios/s390-ccw/dasd-ipl.c | 250

[Qemu-devel] [PATCH v4 03/15] s390-bios: decouple common boot logic from virtio

2019-03-11 Thread Jason J. Herne
Create a boot_setup function to handle getting boot information from the machine/hypervisor. This decouples common boot logic from the virtio code path and allows us to make use of it for the real dasd boot scenario. Signed-off-by: Jason J. Herne Acked-by: Halil Pasic Reviewed-by: Collin

Re: [Qemu-devel] [PATCH v3 11/16] s390-bios: cio error handling

2019-03-07 Thread Jason J. Herne
On 3/4/19 1:35 PM, Cornelia Huck wrote: On Fri, 1 Mar 2019 13:59:31 -0500 "Jason J. Herne" wrote: Add verbose error output for when unexpected i/o errors happen. This eases the burden of debugging and reporting i/o errors. No error information is printed in the success

Re: [Qemu-devel] [PATCH v3 10/16] s390-bios: Support for running format-0/1 channel programs

2019-03-07 Thread Jason J. Herne
On 3/4/19 1:25 PM, Cornelia Huck wrote: On Fri, 1 Mar 2019 13:59:30 -0500 "Jason J. Herne" wrote: Add struct for format-0 ccws. Support executing format-0 channel programs and waiting for their completion before continuing execution. That sentence is a bit confusing.

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 16/16] s390-bios: dasd-ipl: Use control unit type to customize error data

2019-03-07 Thread Jason J. Herne
On 3/7/19 1:15 PM, Eric Farman wrote: On 03/07/2019 09:38 AM, Jason J. Herne wrote: On 3/4/19 12:02 PM, Eric Farman wrote: On 03/01/2019 01:59 PM, Jason J. Herne wrote: Propagate control unit type from main through the dasd ipl call chain. The control unit type can be used to determine

Re: [Qemu-devel] [PATCH v3 13/16] s390-bios: Use control unit type to determine boot method

2019-03-07 Thread Jason J. Herne
On 3/5/19 7:27 AM, Cornelia Huck wrote: On Fri, 1 Mar 2019 13:59:33 -0500 "Jason J. Herne" wrote: The boot method is different depending on which device type we are booting from. Let's examine the control unit type to determine if we're a virtio device. We'll eventually add a cas

Re: [Qemu-devel] [PATCH v3 12/16] s390-bios: Refactor virtio to run channel programs via cio

2019-03-07 Thread Jason J. Herne
On 3/5/19 7:30 AM, Cornelia Huck wrote: On Fri, 1 Mar 2019 13:59:32 -0500 "Jason J. Herne" wrote: Now that we have a Channel I/O library let's modify virtio boot code to make use of it for running channel programs. Signed-off-by: Jason J. Herne --- pc-bios/s390-ccw/vir

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 16/16] s390-bios: dasd-ipl: Use control unit type to customize error data

2019-03-07 Thread Jason J. Herne
On 3/4/19 12:02 PM, Eric Farman wrote: On 03/01/2019 01:59 PM, Jason J. Herne wrote: Propagate control unit type from main through the dasd ipl call chain. The control unit type can be used to determine if we are attempting to boot from a real dasd device. If something goes wrong we'll want

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 09/16] s390-bios: ptr2u32 and u32toptr

2019-03-07 Thread Jason J. Herne
On 3/5/19 2:22 AM, Thomas Huth wrote: On 01/03/2019 19.59, Jason J. Herne wrote: Introduce inline functions to convert between pointers and unsigned 32-bit ints. These are used to hide the ugliness required to avoid compiler warnings. Signed-off-by: Jason J. Herne Acked-by: Cornelia Huck

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 08/16] s390-bios: Map low core memory

2019-03-06 Thread Jason J. Herne
On 3/5/19 1:27 AM, Thomas Huth wrote: On 01/03/2019 19.59, Jason J. Herne wrote: Create a new header for basic architecture specific definitions and add a mapping of low core memory. This mapping will be used by the real dasd boot process. Signed-off-by: Jason J. Herne --- pc-bios/s390-ccw

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 08/16] s390-bios: Map low core memory

2019-03-06 Thread Jason J. Herne
On 3/5/19 1:27 AM, Thomas Huth wrote: On 01/03/2019 19.59, Jason J. Herne wrote: Create a new header for basic architecture specific definitions and add a mapping of low core memory. This mapping will be used by the real dasd boot process. Signed-off-by: Jason J. Herne --- pc-bios/s390-ccw

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 06/16] s390-bios: Clean up cio.h

2019-03-06 Thread Jason J. Herne
On 3/5/19 12:51 AM, Thomas Huth wrote: On 01/03/2019 19.59, Jason J. Herne wrote: Add proper typedefs to all structs and modify all bit fields to use consistent formatting. Signed-off-by: Jason J. Herne Reviewed-by: Collin Walling Reviewed-by: Farhan Ali --- pc-bios/s390-ccw/cio.h

Re: [Qemu-devel] [PATCH v3 01/16] s390 vfio-ccw: Add bootindex property and IPLB data

2019-03-06 Thread Jason J. Herne
On 3/6/19 10:27 AM, Cornelia Huck wrote: On Wed, 6 Mar 2019 09:55:40 -0500 "Jason J. Herne" wrote: On 3/4/19 8:40 AM, Cornelia Huck wrote: On Fri, 1 Mar 2019 13:59:21 -0500 "Jason J. Herne" wrote: @@ -532,7 +559,7 @@ void s390_ipl_reset_request(CPUState *cs, enum s3

Re: [Qemu-devel] [PATCH v3 01/16] s390 vfio-ccw: Add bootindex property and IPLB data

2019-03-06 Thread Jason J. Herne
On 3/4/19 11:09 AM, Farhan Ali wrote: On 03/01/2019 01:59 PM, Jason J. Herne wrote: Add bootindex property and iplb data for vfio-ccw devices. This allows us to forward boot information into the bios for vfio-ccw devices. Refactor s390_get_ccw_device() to return device type. This prevents us

Re: [Qemu-devel] [PATCH v3 01/16] s390 vfio-ccw: Add bootindex property and IPLB data

2019-03-06 Thread Jason J. Herne
On 3/4/19 8:40 AM, Cornelia Huck wrote: On Fri, 1 Mar 2019 13:59:21 -0500 "Jason J. Herne" wrote: Add bootindex property and iplb data for vfio-ccw devices. This allows us to forward boot information into the bios for vfio-ccw devices. Refactor s390_get_ccw_device() to return d

[Qemu-devel] [PATCH v3 10/16] s390-bios: Support for running format-0/1 channel programs

2019-03-01 Thread Jason J. Herne
are booting a virtio device or a real dasd device. Signed-off-by: Jason J. Herne --- pc-bios/s390-ccw/cio.c | 141 pc-bios/s390-ccw/cio.h | 127 ++- pc-bios/s390-ccw/s390-ccw.h | 1 + pc-bios/s390-ccw/start.S

[Qemu-devel] [PATCH v3 11/16] s390-bios: cio error handling

2019-03-01 Thread Jason J. Herne
addr [0]=: 0x cyl & head addr [1]=: 0x cyl & head addr [2]=: 0x Signed-off-by: Jason J. Herne --- pc-bios/s390-ccw/cio.c | 230 pc-bios/s390-ccw/libc.h | 11 +++ 2 files changed, 241 insertions(+)

[Qemu-devel] [PATCH v3 07/16] s390-bios: Decouple channel i/o logic from virtio

2019-03-01 Thread Jason J. Herne
Create a separate library for channel i/o related code. This decouples channel i/o operations from virtio and allows us to make use of them for the real dasd boot path. Signed-off-by: Jason J. Herne --- pc-bios/s390-ccw/Makefile| 2 +- pc-bios/s390-ccw/cio.c | 43

[Qemu-devel] [PATCH v3 12/16] s390-bios: Refactor virtio to run channel programs via cio

2019-03-01 Thread Jason J. Herne
Now that we have a Channel I/O library let's modify virtio boot code to make use of it for running channel programs. Signed-off-by: Jason J. Herne --- pc-bios/s390-ccw/virtio.c | 49 +++ 1 file changed, 20 insertions(+), 29 deletions(-) diff --git

[Qemu-devel] [PATCH v3 03/16] s390-bios: decouple common boot logic from virtio

2019-03-01 Thread Jason J. Herne
Create a boot_setup function to handle getting boot information from the machine/hypervisor. This decouples common boot logic from the virtio code path and allows us to make use of it for the real dasd boot scenario. Signed-off-by: Jason J. Herne Acked-by: Halil Pasic Reviewed-by: Collin

[Qemu-devel] [PATCH v3 06/16] s390-bios: Clean up cio.h

2019-03-01 Thread Jason J. Herne
Add proper typedefs to all structs and modify all bit fields to use consistent formatting. Signed-off-by: Jason J. Herne Reviewed-by: Collin Walling Reviewed-by: Farhan Ali --- pc-bios/s390-ccw/cio.h | 152 ++-- pc-bios/s390-ccw/s390-ccw.h | 8

[Qemu-devel] [PATCH v3 13/16] s390-bios: Use control unit type to determine boot method

2019-03-01 Thread Jason J. Herne
as well remove that call from virtio.c : run_ccw(). Signed-off-by: Jason J. Herne --- pc-bios/s390-ccw/main.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/pc-bios/s390-ccw/main.c b/pc-bios/s390-ccw/main.c index 0670c14..ed79b7a 100644 --- a/pc-bios/s390-ccw

[Qemu-devel] [PATCH v3 04/16] s390-bios: Extend find_dev() for non-virtio devices

2019-03-01 Thread Jason J. Herne
We need a method for finding the subchannel of a dasd device. Let's modify find_dev to handle this since it mostly does what we need. Up to this point find_dev has been specific to only virtio devices. Signed-off-by: Jason J. Herne Acked-by: Halil Pasic Reviewed-by: Cornelia Huck --- pc-bios

[Qemu-devel] [PATCH v3 05/16] s390-bios: Factor finding boot device out of virtio code path

2019-03-01 Thread Jason J. Herne
wording. Signed-off-by: Jason J. Herne Reviewed-by: Farhan Ali --- pc-bios/s390-ccw/main.c | 85 ++-- tests/boot-serial-test.c | 2 +- 2 files changed, 47 insertions(+), 40 deletions(-) diff --git a/pc-bios/s390-ccw/main.c b/pc-bios/s390-ccw/main.c

[Qemu-devel] [PATCH v3 00/16] s390: vfio-ccw dasd ipl support

2019-03-01 Thread Jason J. Herne
s390-dasd-ipl.c: Replace all instances of Qemu with QEMU - Added docs/devel/s390-dasd-ipl.txt to MAINTAINERS - s390-dasd-ipl.c: Include helper.c for new pointer conversion functions Jason J. Herne (16): s390 vfio-ccw: Add bootindex property and IPLB data s390-bios: decouple cio setup from vir

[Qemu-devel] [PATCH v3 01/16] s390 vfio-ccw: Add bootindex property and IPLB data

2019-03-01 Thread Jason J. Herne
Add bootindex property and iplb data for vfio-ccw devices. This allows us to forward boot information into the bios for vfio-ccw devices. Refactor s390_get_ccw_device() to return device type. This prevents us from having to use messy casting logic in several places. Signed-off-by: Jason J. Herne

[Qemu-devel] [PATCH v3 16/16] s390-bios: dasd-ipl: Use control unit type to customize error data

2019-03-01 Thread Jason J. Herne
. Since determining the control unit type is the very first thing we do with any real dasd device, this is our most likely point of failure. Signed-off-by: Jason J. Herne --- pc-bios/s390-ccw/cio.c | 16 ++-- pc-bios/s390-ccw/cio.h | 6 -- pc-bios/s390-ccw/dasd-ipl.c | 25

[Qemu-devel] [PATCH v3 15/16] s390-bios: Support booting from real dasd device

2019-03-01 Thread Jason J. Herne
Allows guest to boot from a vfio configured real dasd device. Signed-off-by: Jason J. Herne --- MAINTAINERS | 1 + docs/devel/s390-dasd-ipl.txt | 133 +++ pc-bios/s390-ccw/Makefile| 2 +- pc-bios/s390-ccw/dasd-ipl.c | 249

[Qemu-devel] [PATCH v3 08/16] s390-bios: Map low core memory

2019-03-01 Thread Jason J. Herne
Create a new header for basic architecture specific definitions and add a mapping of low core memory. This mapping will be used by the real dasd boot process. Signed-off-by: Jason J. Herne --- pc-bios/s390-ccw/main.c | 2 + pc-bios/s390-ccw/s390-arch.h | 102

[Qemu-devel] [PATCH v3 14/16] s390-bios: Add channel command codes/structs needed for dasd-ipl

2019-03-01 Thread Jason J. Herne
The dasd IPL procedure needs to execute a few previously unused channel commands. Let's define them and their associated data structures. Signed-off-by: Jason J. Herne Acked-by: Cornelia Huck --- pc-bios/s390-ccw/cio.h | 23 +++ 1 file changed, 23 insertions(+) diff --git

[Qemu-devel] [PATCH v3 09/16] s390-bios: ptr2u32 and u32toptr

2019-03-01 Thread Jason J. Herne
Introduce inline functions to convert between pointers and unsigned 32-bit ints. These are used to hide the ugliness required to avoid compiler warnings. Signed-off-by: Jason J. Herne Acked-by: Cornelia Huck --- pc-bios/s390-ccw/helper.h | 16 1 file changed, 16 insertions

  1   2   3   4   >