Re: [Qemu-devel] [PATCH] migration: avoid copying ignore-shared ramblock when in incoming migration

2019-03-19 Thread Jia He
corruption. But in normal case (!in_incoming_migration), this logic should be reserved. Fixes: commit 18269069c310 ("migration: Introduce ignore-shared capability") Signed-off-by: Catherine Ho Suggested-by: Yury Kotov thanks, Catherine Tested on aarch64 kvm/tcg mode --- Cheers, Justin (Ji

Re: [Qemu-devel] [RFC PATCH] QEMU may write to system_memory before guest starts

2019-03-19 Thread Jia He
/core/machine.c:965 #12 0xab14070c in main (argc=51, argv=0xee78, envp=0xf018) at vl.c:4459 --- Cheers, Jia He To fix this particular we can skip these writes for the first system_reset if -incoming is set. But I'm not sure how to fix this problem in general. May

Re: [Qemu-devel] [PATCH v5 07/18] kvm: add kvm_arm_get_max_vm_phys_shift

2019-01-29 Thread Jia He
KVMState *s = KVM_STATE(ms->accelerator); + +return kvm_check_extension(s, KVM_CAP_ARM_VM_IPA_SIZE); If KVM_CAP_ARM_VM_IPA_SIZE is not supported in host kernel, would it be better if kvm_arm_get_max_vm_phys_shift returns a default value (e.g. 40),instead of an errno? --- Cheers, Jia

Re: [Qemu-devel] [PATCH] hw/intc/arm_gicv3_its: downgrade error_report to warn_report in kvm_arm_its_reset

2018-07-19 Thread Jia He
Hi Peter。 Thanks for the comments On 7/19/2018 8:41 PM, Peter Maydell Wrote: > On 19 July 2018 at 04:11, Jia He wrote: >> In scripts/arch-run.bash of kvm-unit-tests, it will check the qemu >> output log with: >> if [ -z "$(echo "$errors" | grep -vi

[Qemu-devel] [PATCH] hw/intc/arm_gicv3_its: downgrade error_report to warn_report in kvm_arm_its_reset

2018-07-18 Thread Jia He
ntation, downgrading the report from error to warn makes sense. Signed-off-by: Jia He --- hw/intc/arm_gicv3_its_kvm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/intc/arm_gicv3_its_kvm.c b/hw/intc/arm_gicv3_its_kvm.c index 271ebe4..01573ab 100644 --- a/hw/intc/arm_gicv3_its

Re: [Qemu-devel] [PATCH] vhost: fix invalid downcast

2018-07-13 Thread Jia He
dr(vdev, idx) == 0) { >> /* Don't stop the virtqueue which might have not been started */ >> return; >> } >> -- >> 2.7.4 > yes, it is a bug introduced by fb20fbb764aa1 Acked-by: Jia He -- Cheers, Jia

Re: [Qemu-devel] [PATCH v3 4/4] hw/arm/smmuv3: Add notifications on invalidation

2018-06-22 Thread Jia He
H On 6/21/2018 7:16 PM, Eric Auger Wrote: > On TLB invalidation commands, let's call registered > IOMMU notifiers. Those can only be UNMAP notifiers. > SMMUv3 does not support notification on MAP (VFIO). > > This patch allows vhost use case where IOTLB API is notified > on each guest IOTLB

Re: [Qemu-devel] [Questio] What the proper vfio NIC for emulation smmu?

2018-06-22 Thread Jia He
Hi Eric On 6/22/2018 2:39 PM, Auger Eric Wrote: > Hello Jia, > > On 06/22/2018 03:44 AM, Jia He wrote: >> Hi Eric >> I want to test your smmu emulation patchset with vfio-pci ethernet device. >> Could you kindly give me the NIC type information. >> In

[Qemu-devel] [Questio] What the proper vfio NIC for emulation smmu?

2018-06-21 Thread Jia He
Hi Eric I want to test your smmu emulation patchset with vfio-pci ethernet device. Could you kindly give me the NIC type information. In my test, there is vf probe error for menallox connect 4 NIC and TX Unit hang error for Intel X540 NIC. That's the reason why I ask this question. -- Cheers,

Re: [Qemu-devel] [PATCH] hw/arm/smmuv3: fix smmu emulation when guest smmu is in passthrough mode

2018-06-07 Thread Jia He
Hi Eric On 6/8/2018 1:06 AM, Auger Eric Wrote: > Hi Jia, > > On 06/07/2018 03:38 PM, Jia He wrote: >> There is an exception when I passes iommu.passthrough=1 to guest's >> kernel boot parameter(host QDF2400 kernel 4.17, guest kernel 4.14). >> The guest will be hang

[Qemu-devel] [PATCH] hw/arm/smmuv3: fix smmu emulation when guest smmu is in passthrough mode

2018-06-07 Thread Jia He
There is an exception when I passes iommu.passthrough=1 to guest's kernel boot parameter(host QDF2400 kernel 4.17, guest kernel 4.14). The guest will be hang when booting up. When guest smmu is in passthrough mode, entry.perm will not be assigned to flag in smmuv3_translate. It seems not be

[Qemu-devel] [PATCH 2/2] vhost: fix incorrect check in vhost_verify_ring_mappings

2018-02-28 Thread Jia He
In commit 0ca1fd2d6878 ("vhost: Simplify ring verification checks"), it checks the virtqueue desc mapping for 3 times. Fixed: commit 0ca1fd2d6878 ("vhost: Simplify ring verification checks") Signed-off-by: Jia He <jia...@hxt-semitech.com> --- hw/virtio/vhost.c |

[Qemu-devel] [PATCH 1/2] vhost: avoid to start/stop virtqueue which is not ready

2018-02-28 Thread Jia He
, after guest kernel starts, all the 3 queues will be initialized and set address correctly. Already tested on Arm64 and X86_64 qemu. Signed-off-by: Jia He <jia...@hxt-semitech.com> --- hw/virtio/vhost.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/hw/