[Qemu-devel] [QEMU PATCH v17 4/4] migration: add error_report

2017-01-19 Thread Jianjun Duan
Added error_report where version_ids do not match in vmstate_load_state. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Jianjun Duan --- migration/vmstate.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/migration/vmstate.c b/migration/vmstate.c index 2f9d4ba..8ddd230 100644

[Qemu-devel] [QEMU PATCH v17 3/4] tests/migration: Add test for QTAILQ migration

2017-01-19 Thread Jianjun Duan
Add a test for QTAILQ migration to tests/test-vmstate.c. Signed-off-by: Jianjun Duan --- tests/test-vmstate.c | 147 +++ 1 file changed, 147 insertions(+) diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c index d2f529b..9d87faf 100644

[Qemu-devel] [QEMU PATCH v17 0/4] migration: migrate QTAILQ

2017-01-19 Thread Jianjun Duan
_events of spapr state need be transmitted in migration. This patch also takes care of it. Jianjun Duan (4): migration: extend VMStateInfo migration: migrate QTAILQ tests/migration: Add test for QTAILQ migration migration: add error_report hw/display/virtio-gpu.c | 8 +- hw/intc/s390_f

[Qemu-devel] [QEMU PATCH v17 2/4] migration: migrate QTAILQ

2017-01-19 Thread Jianjun Duan
using pointer arithmetic. This ensures that we do not depend on the implementation details about QTAILQ in the migration code. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Jianjun Duan --- include/migration/vmstate.h | 20 + include/qemu/queue.h| 60

[Qemu-devel] [QEMU PATCH v17 1/4] migration: extend VMStateInfo

2017-01-19 Thread Jianjun Duan
Current migration code cannot handle some data structures such as QTAILQ in qemu/queue.h. Here we extend the signatures of put/get in VMStateInfo so that customized handling is supported. put now will return int type. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Jianjun Duan --- hw

Re: [Qemu-devel] [PATCH] add migration capability to bypass the shared memory

2017-01-16 Thread Jianjun Duan
On 01/12/2017 08:44 PM, Lai Jiangshan wrote: > On Fri, Jan 13, 2017 at 3:19 AM, Jianjun Duan > wrote: >> I have a question related to interplay of bypassing the shared memory in >> migration and memory hotplugging. If on the source guest a big chunk of >> memory is plu

Re: [Qemu-devel] [PATCH] add migration capability to bypass the shared memory

2017-01-12 Thread Jianjun Duan
I have a question related to interplay of bypassing the shared memory in migration and memory hotplugging. If on the source guest a big chunk of memory is plugged in, will the shared memory still be mapped the same way on the guest? i.e, the mapping from guest physical address to the host virtual a

[Qemu-devel] [QEMU PATCH v16 4/4] migration: add error_report

2016-12-08 Thread Jianjun Duan
Added error_report where version_ids do not match in vmstate_load_state. Signed-off-by: Jianjun Duan --- migration/vmstate.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/migration/vmstate.c b/migration/vmstate.c index 2f9d4ba..8ddd230 100644 --- a/migration/vmstate.c +++ b

[Qemu-devel] [QEMU PATCH v16 3/4] tests/migration: Add test for QTAILQ migration

2016-12-08 Thread Jianjun Duan
Add a test for QTAILQ migration to tests/test-vmstate.c. Signed-off-by: Jianjun Duan --- tests/test-vmstate.c | 147 +++ 1 file changed, 147 insertions(+) diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c index d2f529b..140754d 100644

[Qemu-devel] [QEMU PATCH v16 1/4] migration: extend VMStateInfo

2016-12-08 Thread Jianjun Duan
Current migration code cannot handle some data structures such as QTAILQ in qemu/queue.h. Here we extend the signatures of put/get in VMStateInfo so that customized handling is supported. put now will return int type. Signed-off-by: Jianjun Duan --- hw/display/virtio-gpu.c | 8 +++- hw

[Qemu-devel] [QEMU PATCH v16 2/4] migration: migrate QTAILQ

2016-12-08 Thread Jianjun Duan
using pointer arithmetic. This ensures that we do not depend on the implementation details about QTAILQ in the migration code. Signed-off-by: Jianjun Duan --- include/migration/vmstate.h | 20 + include/qemu/queue.h| 60 +++ migration/trace

[Qemu-devel] [QEMU PATCH v16 0/4] migration: migrate QTAILQ

2016-12-08 Thread Jianjun Duan
link: https://lists.nongnu.org/archive/html/qemu-devel/2016-05/msg04188.html) v1: - Inital version. (link: https://lists.nongnu.org/archive/html/qemu-devel/2016-04/msg02601.html) Jianjun Duan (4): migration: extend VMStateInfo migration: migrate QTAILQ tests/migration: Add test for QTA

Re: [Qemu-devel] [Qemu-ppc] [QEMU PATCH v14 3/4] tests/migration: Add test for QTAILQ migration

2016-12-08 Thread Jianjun Duan
On 12/08/2016 01:03 AM, Dr. David Alan Gilbert wrote: > * Jianjun Duan (du...@linux.vnet.ibm.com) wrote: >> >> >> On 12/07/2016 11:49 AM, Dr. David Alan Gilbert wrote: >>> * Jianjun Duan (du...@linux.vnet.ibm.com) wrote: >>>> Add a test for QTAILQ migr

[Qemu-devel] [QEMU PATCH v15 4/4] migration: add error_report

2016-12-07 Thread Jianjun Duan
Added error_report where version_ids do not match in vmstate_load_state. Signed-off-by: Jianjun Duan --- migration/vmstate.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/migration/vmstate.c b/migration/vmstate.c index 2f9d4ba..8ddd230 100644 --- a/migration/vmstate.c +++ b

[Qemu-devel] [QEMU PATCH v15 2/4] migration: migrate QTAILQ

2016-12-07 Thread Jianjun Duan
using pointer arithmetic. This ensures that we do not depend on the implementation details about QTAILQ in the migration code. Signed-off-by: Jianjun Duan --- include/migration/vmstate.h | 20 + include/qemu/queue.h| 60 +++ migration/trace

[Qemu-devel] [QEMU PATCH v15 3/4] tests/migration: Add test for QTAILQ migration

2016-12-07 Thread Jianjun Duan
Add a test for QTAILQ migration to tests/test-vmstate.c. Signed-off-by: Jianjun Duan --- tests/test-vmstate.c | 160 +++ 1 file changed, 160 insertions(+) diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c index d2f529b..88aab8c 100644

[Qemu-devel] [QEMU PATCH v15 1/4] migration: extend VMStateInfo

2016-12-07 Thread Jianjun Duan
Current migration code cannot handle some data structures such as QTAILQ in qemu/queue.h. Here we extend the signatures of put/get in VMStateInfo so that customized handling is supported. put now will return int type. Signed-off-by: Jianjun Duan --- hw/display/virtio-gpu.c | 8 +++- hw

[Qemu-devel] [QEMU PATCH v15 0/4] migration: migrate QTAILQ

2016-12-07 Thread Jianjun Duan
en. - Set detach_cb field right after migration so that a migrated hot-unplug event could finish its course. (link: https://lists.nongnu.org/archive/html/qemu-devel/2016-05/msg04188.html) v1: - Inital version. (link: https://lists.nongnu.org/archive/html/qemu-devel/2016-04/msg0260

Re: [Qemu-devel] [QEMU PATCH v14 3/4] tests/migration: Add test for QTAILQ migration

2016-12-07 Thread Jianjun Duan
On 12/07/2016 11:49 AM, Dr. David Alan Gilbert wrote: > * Jianjun Duan (du...@linux.vnet.ibm.com) wrote: >> Add a test for QTAILQ migration to tests/test-vmstate.c. > > Yes, but see comment below if you have to respin: > >> Signed-off-by: Jianjun Duan >> ---

Re: [Qemu-devel] [QEMU PATCH v14 0/4] migration: migrate QTAILQ

2016-12-05 Thread Jianjun Duan
ping On 11/23/2016 09:53 AM, Jianjun Duan wrote: > Hi all, > > I addressed some review comments. Comments are welcome. > > v14: - Fixed a return statement. > > Previous versions are: > > v13: - Changed some QTAILQ related macro names to match ex

[Qemu-devel] [QEMU PATCH v14 2/4] migration: migrate QTAILQ

2016-11-23 Thread Jianjun Duan
using pointer arithmetic. This ensures that we do not depend on the implementation details about QTAILQ in the migration code. Signed-off-by: Jianjun Duan --- include/migration/vmstate.h | 20 + include/qemu/queue.h| 60 +++ migration/trace

[Qemu-devel] [QEMU PATCH v14 0/4] migration: migrate QTAILQ

2016-11-23 Thread Jianjun Duan
finish its course. (link: https://lists.nongnu.org/archive/html/qemu-devel/2016-05/msg04188.html) v1: - Inital version. (link: https://lists.nongnu.org/archive/html/qemu-devel/2016-04/msg02601.html) Jianjun Duan (4): migration: extend VMStateInfo migration: migrate QTAILQ tests/migration: Add

[Qemu-devel] [QEMU PATCH v14 3/4] tests/migration: Add test for QTAILQ migration

2016-11-23 Thread Jianjun Duan
Add a test for QTAILQ migration to tests/test-vmstate.c. Signed-off-by: Jianjun Duan --- tests/test-vmstate.c | 160 +++ 1 file changed, 160 insertions(+) diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c index d2f529b..88aab8c 100644

[Qemu-devel] [QEMU PATCH v14 4/4] migration: add error_report

2016-11-23 Thread Jianjun Duan
Added error_report where version_ids do not match in vmstate_load_state. Signed-off-by: Jianjun Duan --- migration/vmstate.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/migration/vmstate.c b/migration/vmstate.c index 2f9d4ba..0e6fce4 100644 --- a/migration/vmstate.c +++ b/migration

[Qemu-devel] [QEMU PATCH v14 1/4] migration: extend VMStateInfo

2016-11-23 Thread Jianjun Duan
Current migration code cannot handle some data structures such as QTAILQ in qemu/queue.h. Here we extend the signatures of put/get in VMStateInfo so that customized handling is supported. put now will return int type. Signed-off-by: Jianjun Duan --- hw/display/virtio-gpu.c | 8 +++- hw

Re: [Qemu-devel] [QEMU PATCH v13 0/4] migration: migrate QTAILQ

2016-11-18 Thread Jianjun Duan
ping On 11/16/2016 04:07 PM, Jianjun Duan wrote: > Hi all, > > I addressed some review comments. Comments are welcome. > > v13: - Changed some QTAILQ related macro names to match existing ones. > > Previous versions are: > > v12: - Fixed type for put_qtai

[Qemu-devel] [QEMU PATCH v13 4/4] migration: add error_report

2016-11-16 Thread Jianjun Duan
Added error_report where version_ids do not match in vmstate_load_state. Signed-off-by: Jianjun Duan --- migration/vmstate.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/migration/vmstate.c b/migration/vmstate.c index 2f9d4ba..0e6fce4 100644 --- a/migration/vmstate.c +++ b/migration

[Qemu-devel] [QEMU PATCH v13 3/4] tests/migration: Add test for QTAILQ migration

2016-11-16 Thread Jianjun Duan
Add a test for QTAILQ migration to tests/test-vmstate.c. Signed-off-by: Jianjun Duan --- tests/test-vmstate.c | 160 +++ 1 file changed, 160 insertions(+) diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c index d2f529b..88aab8c 100644

[Qemu-devel] [QEMU PATCH v13 2/4] migration: migrate QTAILQ

2016-11-16 Thread Jianjun Duan
using pointer arithmetic. This ensures that we do not depend on the implementation details about QTAILQ in the migration code. Signed-off-by: Jianjun Duan --- include/migration/vmstate.h | 20 + include/qemu/queue.h| 60 +++ migration/trace

[Qemu-devel] [QEMU PATCH v13 1/4] migration: extend VMStateInfo

2016-11-16 Thread Jianjun Duan
Current migration code cannot handle some data structures such as QTAILQ in qemu/queue.h. Here we extend the signatures of put/get in VMStateInfo so that customized handling is supported. put now will return int type. Signed-off-by: Jianjun Duan --- hw/display/virtio-gpu.c | 8 +++- hw

[Qemu-devel] [QEMU PATCH v13 0/4] migration: migrate QTAILQ

2016-11-16 Thread Jianjun Duan
tal version. (link: https://lists.nongnu.org/archive/html/qemu-devel/2016-04/msg02601.html) Jianjun Duan (4): migration: extend VMStateInfo migration: migrate QTAILQ tests/migration: Add test for QTAILQ migration migration: add error_report hw/display/virtio-gpu.c | 8 +- hw/intc/

Re: [Qemu-devel] [Qemu-ppc] [QEMU PATCH v12 2/4] migration: migrate QTAILQ

2016-11-10 Thread Jianjun Duan
On 11/10/2016 11:13 AM, Halil Pasic wrote: > > > On 11/10/2016 07:00 PM, Jianjun Duan wrote: >> >> >> On 11/10/2016 04:04 AM, Halil Pasic wrote: >>> >>> >>> On 11/08/2016 01:06 AM, Jianjun Duan wrote: >>>> Currently we cannot

Re: [Qemu-devel] [Qemu-ppc] [QEMU PATCH v12 2/4] migration: migrate QTAILQ

2016-11-10 Thread Jianjun Duan
On 11/10/2016 04:04 AM, Halil Pasic wrote: > > > On 11/08/2016 01:06 AM, Jianjun Duan wrote: >> Currently we cannot directly transfer a QTAILQ instance because of the >> limitation in the migration code. Here we introduce an approach to >> transfer such structu

[Qemu-devel] [QEMU PATCH v12 4/4] migration: add error_report

2016-11-07 Thread Jianjun Duan
Added error_report where version_ids do not match in vmstate_load_state. Signed-off-by: Jianjun Duan --- migration/vmstate.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/migration/vmstate.c b/migration/vmstate.c index 2f9d4ba..0e6fce4 100644 --- a/migration/vmstate.c +++ b/migration

[Qemu-devel] [QEMU PATCH v12 2/4] migration: migrate QTAILQ

2016-11-07 Thread Jianjun Duan
using pointer arithmetic. This ensures that we do not depend on the implementation details about QTAILQ in the migration code. Signed-off-by: Jianjun Duan --- include/migration/vmstate.h | 20 + include/qemu/queue.h| 60 +++ migration/trace

[Qemu-devel] [QEMU PATCH v12 3/4] tests/migration: Add test for QTAILQ migration

2016-11-07 Thread Jianjun Duan
Add a test for QTAILQ migration to tests/test-vmstate.c. Signed-off-by: Jianjun Duan --- tests/test-vmstate.c | 160 +++ 1 file changed, 160 insertions(+) diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c index d8da26f..a992408 100644

[Qemu-devel] [QEMU PATCH v12 1/4] migration: extend VMStateInfo

2016-11-07 Thread Jianjun Duan
Current migration code cannot handle some data structures such as QTAILQ in qemu/queue.h. Here we extend the signatures of put/get in VMStateInfo so that customized handling is supported. put now will return int type. Signed-off-by: Jianjun Duan --- hw/display/virtio-gpu.c | 8 +++- hw

[Qemu-devel] [QEMU PATCH v12 0/4] migration: migrate QTAILQ

2016-11-07 Thread Jianjun Duan
finish its course. (link: https://lists.nongnu.org/archive/html/qemu-devel/2016-05/msg04188.html) v1: - Inital version. (link: https://lists.nongnu.org/archive/html/qemu-devel/2016-04/msg02601.html) Jianjun Duan (4): migration: extend VMStateInfo migration: migrate QTAILQ tests/migration: Add

[Qemu-devel] [QEMU PATCH v11 2/4] migration: migrate QTAILQ

2016-11-07 Thread Jianjun Duan
using pointer arithmetic. This ensures that we do not depend on the implementation details about QTAILQ in the migration code. Signed-off-by: Jianjun Duan --- include/migration/vmstate.h | 20 ++ include/qemu/queue.h| 60 migration/trace

[Qemu-devel] [QEMU PATCH v11 4/4] migration: add error_report

2016-11-07 Thread Jianjun Duan
Added error_report where version_ids do not match in vmstate_load_state. Signed-off-by: Jianjun Duan --- migration/vmstate.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/migration/vmstate.c b/migration/vmstate.c index 4ef528c..344863f 100644 --- a/migration/vmstate.c +++ b/migration

[Qemu-devel] [QEMU PATCH v11 1/4] migration: extend VMStateInfo

2016-11-07 Thread Jianjun Duan
Current migration code cannot handle some data structures such as QTAILQ in qemu/queue.h. Here we extend the signatures of put/get in VMStateInfo so that customized handling is supported. put now will return int type. Signed-off-by: Jianjun Duan --- hw/display/virtio-gpu.c | 8 +++- hw

[Qemu-devel] [QEMU PATCH v11 0/4] migration: migrate QTAILQ

2016-11-07 Thread Jianjun Duan
mu-devel/2016-05/msg04188.html) v1: - Inital version. (link: https://lists.nongnu.org/archive/html/qemu-devel/2016-04/msg02601.html) Jianjun Duan (4): migration: extend VMStateInfo migration: migrate QTAILQ tests/migration: Add test for QTAILQ migration migration: add error_report hw/displ

[Qemu-devel] [QEMU PATCH v11 3/4] tests/migration: Add test for QTAILQ migration

2016-11-07 Thread Jianjun Duan
Add a test for QTAILQ migration to tests/test-vmstate.c. Signed-off-by: Jianjun Duan --- tests/test-vmstate.c | 160 +++ 1 file changed, 160 insertions(+) diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c index d8da26f..a992408 100644

Re: [Qemu-devel] [QEMU PATCH v10 3/3] tests/migration: Add test for QTAILQ migration

2016-11-03 Thread Jianjun Duan
On 11/03/2016 10:17 AM, Halil Pasic wrote: > > > On 11/03/2016 05:47 PM, Jianjun Duan wrote: >> >> On 11/03/2016 05:22 AM, Halil Pasic wrote: >>>> >>>> >>>> On 11/02/2016 11:47 AM, Juan Quintela wrote: >>>>>> Jianjun Du

Re: [Qemu-devel] [QEMU PATCH v10 3/3] tests/migration: Add test for QTAILQ migration

2016-11-03 Thread Jianjun Duan
On 11/03/2016 05:22 AM, Halil Pasic wrote: > > > On 11/02/2016 11:47 AM, Juan Quintela wrote: >> Jianjun Duan wrote: >>> Add a test for QTAILQ migration to tests/test-vmstate.c. >>> >>> Signed-off-by: Jianjun Duan >> >> Reviewed-by:

Re: [Qemu-devel] [QEMU PATCH v10 2/3] migration: migrate QTAILQ

2016-11-02 Thread Jianjun Duan
On 11/02/2016 03:45 AM, Juan Quintela wrote: > Jianjun Duan wrote: >> Currently we cannot directly transfer a QTAILQ instance because of the >> limitation in the migration code. Here we introduce an approach to >> transfer such structures. We created VMStateInfo vmsta

Re: [Qemu-devel] [QEMU PATCH v10 1/3] migration: extend VMStateInfo

2016-11-02 Thread Jianjun Duan
On 11/02/2016 03:40 AM, Juan Quintela wrote: > Jianjun Duan wrote: >> Current migration code cannot handle some data structures such as >> QTAILQ in qemu/queue.h. Here we extend the signatures of put/get >> in VMStateInfo so that customized handling is supported. >>

[Qemu-devel] [QEMU PATCH v10 1/3] migration: extend VMStateInfo

2016-10-31 Thread Jianjun Duan
Current migration code cannot handle some data structures such as QTAILQ in qemu/queue.h. Here we extend the signatures of put/get in VMStateInfo so that customized handling is supported. Signed-off-by: Jianjun Duan --- hw/display/virtio-gpu.c | 6 ++- hw/intc/s390_flic_kvm.c | 6

[Qemu-devel] [QEMU PATCH v10 3/3] tests/migration: Add test for QTAILQ migration

2016-10-31 Thread Jianjun Duan
Add a test for QTAILQ migration to tests/test-vmstate.c. Signed-off-by: Jianjun Duan --- tests/test-vmstate.c | 160 +++ 1 file changed, 160 insertions(+) diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c index d8da26f..a992408 100644

[Qemu-devel] [QEMU PATCH v10 0/3] migration: migrate QTAILQ

2016-10-31 Thread Jianjun Duan
ed hot-unplug event could finish its course. (link: https://lists.nongnu.org/archive/html/qemu-devel/2016-05/msg04188.html) v1: - Inital version. (link: https://lists.nongnu.org/archive/html/qemu-devel/2016-04/msg02601.html) Jianjun Duan (3): migration: extend VMStateInfo migration: migrate

[Qemu-devel] [QEMU PATCH v10 2/3] migration: migrate QTAILQ

2016-10-31 Thread Jianjun Duan
. This approach will be used to transfer pending_events and ccs_list in spapr state. We also create some macros in qemu/queue.h to access a QTAILQ using pointer arithmetic. This ensures that we do not depend on the implementation details about QTAILQ in the migration code. Signed-off-by: Jianjun Duan

Re: [Qemu-devel] [Qemu-ppc] [QEMU PATCH v9 2/3] migration: migrate QTAILQ

2016-10-31 Thread Jianjun Duan
On 10/31/2016 11:01 AM, Halil Pasic wrote: > > > On 10/31/2016 06:32 PM, Jianjun Duan wrote: >>>>> I think this got overly complicated. Here is a little patch on >>>>>>>>>> top of your stuff which gets rid of 15 lines and IMHO simpli

Re: [Qemu-devel] [Qemu-ppc] [QEMU PATCH v9 2/3] migration: migrate QTAILQ

2016-10-31 Thread Jianjun Duan
On 10/31/2016 10:21 AM, Halil Pasic wrote: > > > On 10/31/2016 06:10 PM, Jianjun Duan wrote: >>> I think this got overly complicated. Here is a little patch on >>>> top of your stuff which gets rid of 15 lines and IMHO simplifies >>>> things quite a

Re: [Qemu-devel] [Qemu-ppc] [QEMU PATCH v9 2/3] migration: migrate QTAILQ

2016-10-31 Thread Jianjun Duan
On 10/31/2016 06:10 AM, Halil Pasic wrote: > > > On 10/28/2016 09:46 PM, Jianjun Duan wrote: >> >> >> On 10/28/2016 12:06 PM, Dr. David Alan Gilbert wrote: >>> * Jianjun Duan (du...@linux.vnet.ibm.com) wrote: >>>> Currently we cannot di

Re: [Qemu-devel] [QEMU PATCH v9 2/3] migration: migrate QTAILQ

2016-10-28 Thread Jianjun Duan
On 10/28/2016 12:06 PM, Dr. David Alan Gilbert wrote: > * Jianjun Duan (du...@linux.vnet.ibm.com) wrote: >> Currently we cannot directly transfer a QTAILQ instance because of the >> limitation in the migration code. Here we introduce an approach to >> transfer such s

[Qemu-devel] [QEMU PATCH v9 2/3] migration: migrate QTAILQ

2016-10-27 Thread Jianjun Duan
. This approach will be used to transfer pending_events and ccs_list in spapr state. We also create some macros in qemu/queue.h to access a QTAILQ using pointer arithmetic. This ensures that we do not depend on the implementation details about QTAILQ in the migration code. Signed-off-by: Jianjun Duan

[Qemu-devel] [QEMU PATCH v9 1/3] migration: extend VMStateInfo

2016-10-27 Thread Jianjun Duan
Current migration code cannot handle some data structures such as QTAILQ in qemu/queue.h. Here we extend the signatures of put/get in VMStateInfo so that customized handling is supported. Signed-off-by: Jianjun Duan --- hw/display/virtio-gpu.c | 6 ++- hw/intc/s390_flic_kvm.c | 6

[Qemu-devel] [QEMU PATCH v9 3/3] tests/migration: Add test for QTAILQ migration

2016-10-27 Thread Jianjun Duan
Add a test for QTAILQ migration to tests/test-vmstate.c. Signed-off-by: Jianjun Duan --- tests/test-vmstate.c | 160 +++ 1 file changed, 160 insertions(+) diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c index d8da26f..a992408 100644

[Qemu-devel] [QEMU PATCH v9 0/3] migration: migrate QTAILQ

2016-10-27 Thread Jianjun Duan
mu-devel/2016-05/msg04188.html) v1: - Inital version. (link: https://lists.nongnu.org/archive/html/qemu-devel/2016-04/msg02601.html) Jianjun Duan (3): migration: extend VMStateInfo migration: migrate QTAILQ tests/migration: Add test for QTAILQ migration hw/display/virtio-gpu.c | 6 +-

Re: [Qemu-devel] [Qemu-ppc] [QEMU PATCH v7 2/3] migration: migrate QTAILQ

2016-10-27 Thread Jianjun Duan
On 10/27/2016 05:01 AM, Paolo Bonzini wrote: > > > On 26/10/2016 18:58, Jianjun Duan wrote: >>>> >>>> Seems you partially adopted Paolo's suggestion for improving the >>>> macros. Is there a particular reason why you did not follow it more >

Re: [Qemu-devel] [Qemu-ppc] [QEMU PATCH v8 2/3] migration: migrate QTAILQ

2016-10-27 Thread Jianjun Duan
On 10/27/2016 04:16 AM, Halil Pasic wrote: > > > On 10/26/2016 07:33 PM, Jianjun Duan wrote: >>>>>>>> +#define QTAILQ_FIRST_OFFSET 0 >>>>>>>>>>>>>> +#define QTAILQ_LAST_OFFSET (sizeof(void *)) >>>>

Re: [Qemu-devel] [QEMU PATCH v8 2/3] migration: migrate QTAILQ

2016-10-26 Thread Jianjun Duan
On 10/26/2016 10:09 AM, Dr. David Alan Gilbert wrote: > * Jianjun Duan (du...@linux.vnet.ibm.com) wrote: >> >> >> On 10/26/2016 09:53 AM, Dr. David Alan Gilbert wrote: >>> * Jianjun Duan (du...@linux.vnet.ibm.com) wrote: >>>> >>>> >

Re: [Qemu-devel] [Qemu-ppc] [QEMU PATCH v7 2/3] migration: migrate QTAILQ

2016-10-26 Thread Jianjun Duan
On 10/26/2016 05:29 AM, Halil Pasic wrote: > > > On 10/22/2016 12:52 AM, Jianjun Duan wrote: >> +#define RAW_FIELD(base, offset) >>\ >> +((char *) (base) + offset) >> + > > Seems you partially a

Re: [Qemu-devel] [QEMU PATCH v8 2/3] migration: migrate QTAILQ

2016-10-26 Thread Jianjun Duan
On 10/26/2016 09:29 AM, Dr. David Alan Gilbert wrote: > * Jianjun Duan (du...@linux.vnet.ibm.com) wrote: >> Currently we cannot directly transfer a QTAILQ instance because of the >> limitation in the migration code. Here we introduce an approach to >> transfer such s

Re: [Qemu-devel] [QEMU PATCH v8 2/3] migration: migrate QTAILQ

2016-10-26 Thread Jianjun Duan
On 10/26/2016 09:53 AM, Dr. David Alan Gilbert wrote: > * Jianjun Duan (du...@linux.vnet.ibm.com) wrote: >> >> >> On 10/26/2016 09:29 AM, Dr. David Alan Gilbert wrote: >>> * Jianjun Duan (du...@linux.vnet.ibm.com) wrote: >>>> Currently we cannot directly

[Qemu-devel] [QEMU PATCH v8 3/3] tests/migration: Add test for QTAILQ migration

2016-10-25 Thread Jianjun Duan
Add a test for QTAILQ migration to tests/test-vmstate.c. Signed-off-by: Jianjun Duan --- tests/test-vmstate.c | 160 +++ 1 file changed, 160 insertions(+) diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c index d8da26f..a992408 100644

[Qemu-devel] [QEMU PATCH v8 1/3] migration: extend VMStateInfo

2016-10-25 Thread Jianjun Duan
Current migration code cannot handle some data structures such as QTAILQ in qemu/queue.h. Here we extend the signatures of put/get in VMStateInfo so that customized handling is supported. Signed-off-by: Jianjun Duan --- hw/display/virtio-gpu.c | 6 ++- hw/intc/s390_flic_kvm.c | 6

[Qemu-devel] [QEMU PATCH v8 2/3] migration: migrate QTAILQ

2016-10-25 Thread Jianjun Duan
. This approach will be used to transfer pending_events and ccs_list in spapr state. We also create some macros in qemu/queue.h to access a QTAILQ using pointer arithmetic. This ensures that we do not depend on the implementation details about QTAILQ in the migration code. Signed-off-by: Jianjun Duan

[Qemu-devel] [QEMU PATCH v8 0/3] migration: migrate QTAILQ

2016-10-25 Thread Jianjun Duan
tach_cb field right after migration so that a migrated hot-unplug event could finish its course. (link: https://lists.nongnu.org/archive/html/qemu-devel/2016-05/msg04188.html) v1: - Inital version. (link: https://lists.nongnu.org/archive/html/qemu-devel/2016-04/msg02601.html) Jianjun Duan

[Qemu-devel] [QEMU PATCH v7 1/3] migration: extend VMStateInfo

2016-10-21 Thread Jianjun Duan
Current migration code cannot handle some data structures such as QTAILQ in qemu/queue.h. Here we extend the signatures of put/get in VMStateInfo so that customized handling is supported. Signed-off-by: Jianjun Duan --- hw/display/virtio-gpu.c | 6 ++- hw/intc/s390_flic_kvm.c | 6

[Qemu-devel] [QEMU PATCH v7 2/3] migration: migrate QTAILQ

2016-10-21 Thread Jianjun Duan
. This approach will be used to transfer pending_events and ccs_list in spapr state. We also create some macros in qemu/queue.h to access a QTAILQ using pointer arithmetic. This ensures that we do not depend on the implementation details about QTAILQ in the migration code. Signed-off-by: Jianjun Duan

[Qemu-devel] [QEMU PATCH v7 3/3] tests/migration: Add test for QTAILQ migration

2016-10-21 Thread Jianjun Duan
Add a test for QTAILQ migration to tests/test-vmstate.c. Signed-off-by: Jianjun Duan --- tests/test-vmstate.c | 162 +++ 1 file changed, 162 insertions(+) diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c index d8da26f..80f534f 100644

[Qemu-devel] [QEMU PATCH v7 0/3] migration: migrate QTAILQ

2016-10-21 Thread Jianjun Duan
finish its course. (link: https://lists.nongnu.org/archive/html/qemu-devel/2016-05/msg04188.html) v1: - Inital version. (link: https://lists.nongnu.org/archive/html/qemu-devel/2016-04/msg02601.html) Jianjun Duan (3): migration: extend VMStateInfo migration: migrate QTAILQ tests/migra

Re: [Qemu-devel] [Qemu-ppc] [QEMU PATCH v6 2/2] migration: migrate QTAILQ

2016-10-21 Thread Jianjun Duan
On 10/21/2016 11:51 AM, Dr. David Alan Gilbert wrote: > * Jianjun Duan (du...@linux.vnet.ibm.com) wrote: >> >> >> On 10/15/2016 05:48 AM, Halil Pasic wrote: >>> >>> >>> On 10/14/2016 07:18 PM, Jianjun Duan wrote: >>>>>

Re: [Qemu-devel] [very-WIP 1/7] migration: Add VMSTATE_WITH_TMP

2016-10-17 Thread Jianjun Duan
On 10/17/2016 12:16 PM, Dr. David Alan Gilbert wrote: > * Jianjun Duan (du...@linux.vnet.ibm.com) wrote: >> >> >> On 10/17/2016 11:52 AM, Dr. David Alan Gilbert wrote: >>> * Jianjun Duan (du...@linux.vnet.ibm.com) wrote: >>>> >>>> >>

Re: [Qemu-devel] [very-WIP 1/7] migration: Add VMSTATE_WITH_TMP

2016-10-17 Thread Jianjun Duan
On 10/17/2016 11:52 AM, Dr. David Alan Gilbert wrote: > * Jianjun Duan (du...@linux.vnet.ibm.com) wrote: >> >> >> On 10/16/2016 08:31 PM, David Gibson wrote: >>> On Tue, Oct 11, 2016 at 06:18:30PM +0100, Dr. David Alan Gilbert (git) >>> wr

Re: [Qemu-devel] [very-WIP 1/7] migration: Add VMSTATE_WITH_TMP

2016-10-17 Thread Jianjun Duan
On 10/16/2016 08:31 PM, David Gibson wrote: > On Tue, Oct 11, 2016 at 06:18:30PM +0100, Dr. David Alan Gilbert (git) wrote: >> From: "Dr. David Alan Gilbert" >> >> VMSTATE_WITH_TMP is for handling structures where some calculation >> or rearrangement of the data needs to be performed before the

Re: [Qemu-devel] [Qemu-ppc] [QEMU PATCH v6 2/2] migration: migrate QTAILQ

2016-10-17 Thread Jianjun Duan
On 10/15/2016 05:48 AM, Halil Pasic wrote: > > > On 10/14/2016 07:18 PM, Jianjun Duan wrote: >>>>>> +/* >>>>>>>>>> + * Offsets of layout of a tail queue head. >>>>>>>>>> + */ >&g

Re: [Qemu-devel] [Qemu-ppc] [QEMU PATCH v6 2/2] migration: migrate QTAILQ

2016-10-14 Thread Jianjun Duan
On 10/14/2016 11:39 AM, Paolo Bonzini wrote: > >>> Another possibility is a macro like >>> >>> #define field_at_offset(base, offset, type) \ >>>((type) (((char *) (base)) + (offset))) >>> >>> so that you can do >>> >>>*field_at_offset(void **, elm, (entry) + QTAILQ_NEXT_OFFSET) = NULL; >

Re: [Qemu-devel] [Qemu-ppc] [QEMU PATCH v6 2/2] migration: migrate QTAILQ

2016-10-14 Thread Jianjun Duan
On 10/14/2016 10:04 AM, Dr. David Alan Gilbert wrote: > * Jianjun Duan (du...@linux.vnet.ibm.com) wrote: >> >> >> On 10/14/2016 03:44 AM, Dr. David Alan Gilbert wrote: >>> * Jianjun Duan (du...@linux.vnet.ibm.com) wrote: >>>> Currently we cannot directly

Re: [Qemu-devel] [QEMU PATCH v6 1/2] migration: extend VMStateInfo

2016-10-14 Thread Jianjun Duan
On 10/14/2016 02:23 AM, Dr. David Alan Gilbert wrote: > * Jianjun Duan (du...@linux.vnet.ibm.com) wrote: >> Current migration code cannot handle some data structures such as >> QTAILQ in qemu/queue.h. Here we extend the signatures of put/get >> in VMStateInfo so that c

Re: [Qemu-devel] [Qemu-ppc] [QEMU PATCH v6 2/2] migration: migrate QTAILQ

2016-10-14 Thread Jianjun Duan
On 10/14/2016 03:44 AM, Dr. David Alan Gilbert wrote: > * Jianjun Duan (du...@linux.vnet.ibm.com) wrote: >> Currently we cannot directly transfer a QTAILQ instance because of the >> limitation in the migration code. Here we introduce an approach to >> transfer such s

Re: [Qemu-devel] [Qemu-ppc] [QEMU PATCH v6 2/2] migration: migrate QTAILQ

2016-10-14 Thread Jianjun Duan
I need to double check my code. My build passed and migration test also succeeded. On 10/14/2016 04:07 AM, Paolo Bonzini wrote: > > > On 14/10/2016 12:44, Dr. David Alan Gilbert wrote: +#define QTAILQ_RAW_INSERT_TAIL(head, elm, entry) do { \ +*((

[Qemu-devel] [QEMU PATCH v6 2/2] migration: migrate QTAILQ

2016-10-13 Thread Jianjun Duan
. This approach will be used to transfer pending_events and ccs_list in spapr state. We also create some macros in qemu/queue.h to access a QTAILQ using pointer arithmetic. This ensures that we do not depend on the implementation details about QTAILQ in the migration code. Signed-off-by: Jianjun Duan

[Qemu-devel] [QEMU PATCH v6 0/2] migration: migrate QTAILQ

2016-10-13 Thread Jianjun Duan
s.nongnu.org/archive/html/qemu-devel/2016-05/msg04188.html) v1: - Inital version. (link: https://lists.nongnu.org/archive/html/qemu-devel/2016-04/msg02601.html) Jianjun Duan (2): migration: extend VMStateInfo migration: migrate QTAILQ hw/display/virtio-gpu.c | 6 +- hw/net/vmxnet3.c

[Qemu-devel] [QEMU PATCH v6 1/2] migration: extend VMStateInfo

2016-10-13 Thread Jianjun Duan
Current migration code cannot handle some data structures such as QTAILQ in qemu/queue.h. Here we extend the signatures of put/get in VMStateInfo so that customized handling is supported. Signed-off-by: Jianjun Duan --- hw/display/virtio-gpu.c | 6 ++- hw/net/vmxnet3.c| 18

Re: [Qemu-devel] [Qemu-ppc] [QEMU PATCH v5 3/6] migration: extend VMStateInfo

2016-10-13 Thread Jianjun Duan
On 10/13/2016 09:32 AM, Halil Pasic wrote: > > > On 10/13/2016 06:23 PM, Jianjun Duan wrote: >> >> >> On 10/13/2016 03:48 AM, Halil Pasic wrote: >>> >>> >>> On 10/13/2016 10:22 AM, Paolo Bonzini wrote: >>>>>> No, I disag

Re: [Qemu-devel] [Qemu-ppc] [QEMU PATCH v5 3/6] migration: extend VMStateInfo

2016-10-13 Thread Jianjun Duan
On 10/13/2016 03:48 AM, Halil Pasic wrote: > > > On 10/13/2016 10:22 AM, Paolo Bonzini wrote: No, I disagree. We shouldn't be worried about making intrusive changes >> to all invocations or declarations, if that leads to a simpler API. If VMStateInfo was meant for complete c

Re: [Qemu-devel] [Qemu-ppc] [QEMU PATCH v5 3/6] migration: extend VMStateInfo

2016-10-12 Thread Jianjun Duan
On 10/12/2016 05:07 AM, Paolo Bonzini wrote: > > > On 12/10/2016 13:59, Halil Pasic wrote: >> IMHO this would: >> * allow us to keep the good old MVStateInfo objects unmodified and >> the semantic of VMStateInfo unchanged >> * make clear that VMStateLinked does not care about the calculated s

Re: [Qemu-devel] [Qemu-ppc] [QEMU PATCH v5 4/6] migration: migrate QTAILQ

2016-10-10 Thread Jianjun Duan
On 10/08/2016 12:28 PM, Halil Pasic wrote: > > > On 10/08/2016 01:37 PM, Paolo Bonzini wrote: >>> Even though most put/get have no issues now, when somebody writes a new put, he or she could run into issues if only checking the type signature. It makes the code more readable. > >> No

Re: [Qemu-devel] [Qemu-ppc] [QEMU PATCH v5 4/6] migration: migrate QTAILQ

2016-10-10 Thread Jianjun Duan
On 10/08/2016 12:28 PM, Halil Pasic wrote: > > > On 10/08/2016 01:37 PM, Paolo Bonzini wrote: >>> Even though most put/get have no issues now, when somebody writes a new put, he or she could run into issues if only checking the type signature. It makes the code more readable. > >> No

Re: [Qemu-devel] [Qemu-ppc] [QEMU PATCH v5 2/6] migration: spapr_drc: defined VMStateDescription struct

2016-10-10 Thread Jianjun Duan
On 10/09/2016 10:09 PM, David Gibson wrote: > On Fri, Oct 07, 2016 at 10:17:45AM -0700, Jianjun Duan wrote: >> >> >> On 10/06/2016 08:12 PM, David Gibson wrote: >>> On Mon, Oct 03, 2016 at 11:24:53AM -0700, Jianjun Duan wrote: >>>> To manage hotplug/unp

Re: [Qemu-devel] [Qemu-ppc] [QEMU PATCH v5 4/6] migration: migrate QTAILQ

2016-10-07 Thread Jianjun Duan
On 10/07/2016 10:34 AM, Dr. David Alan Gilbert wrote: > * Jianjun Duan (du...@linux.vnet.ibm.com) wrote: >> >> >> On 10/07/2016 09:32 AM, Paolo Bonzini wrote: >>> >>> >>> On 07/10/2016 18:31, Jianjun Duan wrote: >>>> >>>>

Re: [Qemu-devel] [Qemu-ppc] [QEMU PATCH v5 4/6] migration: migrate QTAILQ

2016-10-07 Thread Jianjun Duan
On 10/07/2016 09:32 AM, Paolo Bonzini wrote: > > > On 07/10/2016 18:31, Jianjun Duan wrote: >> >> >> On 10/07/2016 07:34 AM, Dr. David Alan Gilbert wrote: >>> * Paolo Bonzini (pbonz...@redhat.com) wrote: >>>> >>>

Re: [Qemu-devel] [QEMU PATCH v5 2/6] migration: spapr_drc: defined VMStateDescription struct

2016-10-07 Thread Jianjun Duan
On 10/06/2016 08:12 PM, David Gibson wrote: > On Mon, Oct 03, 2016 at 11:24:53AM -0700, Jianjun Duan wrote: >> To manage hotplug/unplug of dynamic resources such as PCI cards, >> memory, and CPU on sPAPR guests, a firmware abstraction known as >> a Dynamic Resource Conne

Re: [Qemu-devel] [Qemu-ppc] [QEMU PATCH v5 3/6] migration: extend VMStateInfo

2016-10-07 Thread Jianjun Duan
On 10/07/2016 05:08 AM, Dr. David Alan Gilbert wrote: > * Jianjun Duan (du...@linux.vnet.ibm.com) wrote: >> Current migration code cannot handle some data structures such as >> QTAILQ in qemu/queue.h. Here we extend the signatures of put/get >> in VMStateInfo so that c

Re: [Qemu-devel] [Qemu-ppc] [QEMU PATCH v5 4/6] migration: migrate QTAILQ

2016-10-07 Thread Jianjun Duan
On 10/07/2016 07:34 AM, Dr. David Alan Gilbert wrote: > * Paolo Bonzini (pbonz...@redhat.com) wrote: >> >> >> On 06/10/2016 21:01, Dr. David Alan Gilbert wrote: >> +} else if (field->flags & VMS_LINKED) { >> +ret = field->info->get(f, addr, size, field)

Re: [Qemu-devel] [QEMU PATCH v5 4/6] migration: migrate QTAILQ

2016-10-06 Thread Jianjun Duan
On 10/06/2016 12:01 PM, Dr. David Alan Gilbert wrote: > * Jianjun Duan (du...@linux.vnet.ibm.com) wrote: >> >> >> On 10/05/2016 09:56 AM, Dr. David Alan Gilbert wrote: >>> * Jianjun Duan (du...@linux.vnet.ibm.com) wrote: >>>> Currently we cannot directly

Re: [Qemu-devel] [QEMU PATCH v5 4/6] migration: migrate QTAILQ

2016-10-05 Thread Jianjun Duan
On 10/05/2016 09:56 AM, Dr. David Alan Gilbert wrote: > * Jianjun Duan (du...@linux.vnet.ibm.com) wrote: >> Currently we cannot directly transfer a QTAILQ instance because of the >> limitation in the migration code. Here we introduce an approach to >> transfer such struct

Re: [Qemu-devel] [Qemu-ppc] [QEMU PATCH v5 1/6] migration: alternative way to set instance_id in SaveStateEntry

2016-10-05 Thread Jianjun Duan
On 10/05/2016 03:12 AM, Dr. David Alan Gilbert wrote: > * Jianjun Duan (du...@linux.vnet.ibm.com) wrote: >> In QOM(QEMU Object Model) migrated objects are identified with instance_id >> which is calculated automatically using their path in the QOM composition >> tree. For so

  1   2   >