Re: [Qemu-devel] [RFC PATCH v4 0/6] optimize various tcg_gen() functions using extract op

2017-05-12 Thread Julia Lawall
On Fri, 12 May 2017, Philippe Mathieu-Daudé wrote: > * Changes from v3 > > Tried to fix wrong previous attempt... > After getting some nice/fast pieces of advice from Coccinelle folks, I tried > to > improved the script (not much inline documentation yet although). > - correctly check if this

Re: [Qemu-devel] [RFC PATCH v3 1/5] coccinelle: add a script to optimize tcg op using tcg_gen_extract()

2017-05-12 Thread Julia Lawall
On Fri, 12 May 2017, Philippe Mathieu-Daudé wrote: > Hi Julia, > > Sorry I planed to send you another mail but sent this mail to QEMU list first. > > > I don't think I have seen earlier versions of this script. Are you > > proposing it to be added to the kernel? If so, it should be put in an

Re: [Qemu-devel] [RFC PATCH v3 1/5] coccinelle: add a script to optimize tcg op using tcg_gen_extract()

2017-05-11 Thread Julia Lawall
Hello, I don't think I have seen earlier versions of this script. Are you proposing it to be added to the kernel? If so, it should be put in an appropriate subdirectory of Coccinelle. Overall, could you explain at a high level what it is intended to do? It uses rather heavily regular

Re: [Qemu-devel] [PATCH v2 2/6] qdict: Add convenience helpers for wrapped puts

2017-04-05 Thread Julia Lawall
On Wed, 5 Apr 2017, Richard W.M. Jones wrote: > On Wed, Apr 05, 2017 at 10:21:13AM +0200, Julia Lawall wrote: > > > > > > On Wed, 5 Apr 2017, Richard W.M. Jones wrote: > > > > > On Tue, Apr 04, 2017 at 05:41:08PM -0500, Eric Blake wrote: > > &g

Re: [Qemu-devel] [PATCH v2 2/6] qdict: Add convenience helpers for wrapped puts

2017-04-05 Thread Julia Lawall
On Wed, 5 Apr 2017, Richard W.M. Jones wrote: > On Tue, Apr 04, 2017 at 05:41:08PM -0500, Eric Blake wrote: > > On 01/19/2017 08:38 AM, Eric Blake wrote: > > > On 01/19/2017 03:25 AM, Markus Armbruster wrote: > > >> Eric Blake writes: > > >> > > >>> Quite a few users of